From nobody Wed Oct 8 07:40:05 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F2D78C0B; Mon, 30 Jun 2025 21:53:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751320429; cv=none; b=hyZ+zJvq9DzRvxUECapNUJGxkissyK7ZWq3jn4azIElS37Lj3JOEdN+arxAJqNvocIEAmF1LZHbXEv9szpXfPuP1vNlpKpQovvD6OHc0ewQ15wEuGcZtHuRXYenkll593U1/9g+v8JtT2OLNspMBloBCfjwrmZrScxiW+uZF1mQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751320429; c=relaxed/simple; bh=tpbE2FvztANs2/izJnOECYoMP2X5oOScRQHxOIydI1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZHQO8MKDb+4JkbyswOEj7vWnjvPFUTFHQfwLIPDijjPtNCEIPC0QYQRBFw/jSMo5rWekzUPzLsnz/s/4oNfsQm/n/sWn7EOMuegU6RgxONTNyFnEo39k4kSWp7NA8YpaTSoN2rua7xW76+cIMmghPgMyRxKOJRkLzKVx02b+gtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hWcuo0G5; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hWcuo0G5" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7d38ddc198eso296226585a.1; Mon, 30 Jun 2025 14:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751320427; x=1751925227; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mt5O7/7JEumjsAyKxjvlFipcH+4/5yB2S8im+OQhNPo=; b=hWcuo0G57nXvXAd7jgtgKB0jV7xMfu1RpxeuIqZX9Yz0iBHoe+AEs9M/lD71E6u/qd u3jJUP/kTbss5LpOLZf5gVwgvo7Jvc0Z+WQ8B1+zIBaw1DBSsZnCOOsYAll9O3nfJO07 qltAsHwn4OFuv25O8Zot7o/nv22ao6Em6AzhxrxWLDUX3xfIlYVHOY2DzM9GQqO0jpiH HE14Fgq10+QO9jtg8g9MOt8U5lkWZixeMP9WoaYXO3q3PEc+K2m7IxKZjlaXIWgMaX71 cR1TFiBp9oYdIHSchfb6iGOvwDvWCh42Wz6EraXOj4o7AExbZjUIelaNok/MNwVLvEBX Hjyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751320427; x=1751925227; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mt5O7/7JEumjsAyKxjvlFipcH+4/5yB2S8im+OQhNPo=; b=LlfmEEYAa2HG2S+YZtPOzFzuxOj6PnHGnKny3JYDbMMRiX6T+lUTGat4eEQqoo8kWZ juISNx4l1fY/DSl6ts3c2K9w/ortvM1hEioauzrLEcJP33Uk3fXksw+hvY9ob0Ql0Wj2 fx7n32azgij5aZbXF9CNizVdJjy04LicuOpNiKymA5MyCbLTV0jP27edUVaCQYoV1TTU 5g5B6e1RvVYAi2tgglCpDj6M7xnUNp/jrTpN+YBGuDpvZqST4q7Kp/DhzwnMI+mfd2hS 20eL4K9p0v/uoTouSLR9BsohutVi8YsMPS8Dc4M4BOp7XaDEaFsbNPU6Tsk86ENDj1yp UW1w== X-Forwarded-Encrypted: i=1; AJvYcCWbKuDdeClUxwc27eWy8hB0yAXpPAFW+usz/TcP+/hcn0xRsrSbGU8Bov9ncNHQZ0J93/+c43IszxMn@vger.kernel.org, AJvYcCXhVuaFb4IwiPQQ+vtm45MpzATdi04gE2o1VvYQeKkl7pT0KNB+Z0UrOxEoV9KJihuWTlUXtsQvlsXe+WQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwIDsGSC9ohaUab3S9qmyo0yoehljtN7h9q4w7FvUCibwA8cmZD cz60IFvAMH9sYnLVAYML+QB2+sYf7tu46s9M0zEYKfpfdv3gjzsBJC+9 X-Gm-Gg: ASbGncs1hXQXnyRb7GVmshM7vLQN/rJmeH9w9Fn9moHDFP8kJH60XPFWgmNgYw4aPjf rhfN6v8evwbCCwWGYVsmcduKBRiyV4TaAHfiDI047Y6a3qwKnsd+c9F8WoKZB4rNp0DILIkG53O ZwUDvoJgVlduBGJAChnoSUBDXPlGwd1Q0emgq9eqVTMaGagH4jHSekgvle7uOub7BhkA/a7TjvF QR7pr/RCjozD2ZIsHAO3qLH85mMNlzyAiSQFo/EAzW+Vd6jdDKJ8N7WfyjlKlKTKiMbNenJMQLF nssN0o3zgKcuHbEBNF43eh7f/SvBKdc/ELCdLE6xo9Lk045J8Q== X-Google-Smtp-Source: AGHT+IE4ZwMGrjquWRKjbheHxPupZnOX8kEtV3PU4VrObQVpxq1kD417A3FEkJjqoIJaFDQY6Rp04g== X-Received: by 2002:a05:620a:4708:b0:7d3:f9a0:2c10 with SMTP id af79cd13be357-7d4439cc95bmr1949708785a.57.1751320426794; Mon, 30 Jun 2025 14:53:46 -0700 (PDT) Received: from geday ([2804:7f2:800b:4851::dead:c001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd772df637sm74795696d6.79.2025.06.30.14.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 14:53:46 -0700 (PDT) Date: Mon, 30 Jun 2025 18:53:39 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , Neil Armstrong , Valmantas Paliksa , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 1/4] PCI: rockchip: Use standard PCIe defines Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code uses custom-defined register offsets and bitfields for standard PCIe registers. Change to using standard PCIe defines. Since we are now using standard PCIe defines, drop unused custom-defined ones, which are now referenced from offset at added Capabilities Register. Suggested-By: Bjorn Helgaas Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-ep.c | 4 +- drivers/pci/controller/pcie-rockchip-host.c | 44 ++++++++++----------- drivers/pci/controller/pcie-rockchip.h | 12 +----- 3 files changed, 25 insertions(+), 35 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/contro= ller/pcie-rockchip-ep.c index 55416b8311dd..300cd85fa035 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -518,9 +518,9 @@ static void rockchip_pcie_ep_retrain_link(struct rockch= ip_pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_EP_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_EP_CONFIG_BASE + PCI_EXP_LNK= CTL); status |=3D PCI_EXP_LNKCTL_RL; - rockchip_pcie_write(rockchip, status, PCIE_EP_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_EP_CONFIG_BASE + PCI_EXP_LNKCT= L); } =20 static bool rockchip_pcie_ep_link_up(struct rockchip_pcie *rockchip) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index b9e7a8710cf0..65653218b9ab 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -40,18 +40,18 @@ static void rockchip_pcie_enable_bw_int(struct rockchip= _pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D (PCI_EXP_LNKCTL_LBMIE | PCI_EXP_LNKCTL_LABIE); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); } =20 static void rockchip_pcie_clr_bw_int(struct rockchip_pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D (PCI_EXP_LNKSTA_LBMS | PCI_EXP_LNKSTA_LABS) << 16; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); } =20 static void rockchip_pcie_update_txcredit_mui(struct rockchip_pcie *rockch= ip) @@ -269,7 +269,7 @@ static void rockchip_pcie_set_power_limit(struct rockch= ip_pcie *rockchip) scale =3D 3; /* 0.001x */ curr =3D curr / 1000; /* convert to mA */ power =3D (curr * 3300) / 1000; /* milliwatt */ - while (power > PCIE_RC_CONFIG_DCR_CSPL_LIMIT) { + while (power > FIELD_MAX(PCI_EXP_DEVCAP_PWR_VAL)) { if (!scale) { dev_warn(rockchip->dev, "invalid power supply\n"); return; @@ -278,10 +278,10 @@ static void rockchip_pcie_set_power_limit(struct rock= chip_pcie *rockchip) power =3D power / 10; } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DCR); - status |=3D (power << PCIE_RC_CONFIG_DCR_CSPL_SHIFT) | - (scale << PCIE_RC_CONFIG_DCR_CPLS_SHIFT); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DCR); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCA= P); + status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_VAL, power); + status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_SCL, scale); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP); } =20 /** @@ -309,14 +309,14 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) rockchip_pcie_set_power_limit(rockchip); =20 /* Set RC's clock architecture as common clock */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D PCI_EXP_LNKSTA_SLC << 16; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); =20 /* Set RC's RCB to 128 */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D PCI_EXP_LNKCTL_RCB; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); =20 /* Enable Gen1 training */ rockchip_pcie_write(rockchip, PCIE_CLIENT_LINK_TRAIN_ENABLE, @@ -341,9 +341,9 @@ static int rockchip_pcie_host_init_port(struct rockchip= _pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); =20 err =3D readl_poll_timeout(rockchip->apb_base + PCIE_CORE_CTRL, status, PCIE_LINK_IS_GEN2(status), 20, @@ -380,15 +380,15 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) =20 /* Clear L0s from RC's link cap */ if (of_property_read_bool(dev->of_node, "aspm-no-l0s")) { - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LINK_CAP); - status &=3D ~PCIE_RC_CONFIG_LINK_CAP_L0S; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LINK_CAP); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= AP); + status &=3D ~PCI_EXP_LNKCAP_ASPM_L0S; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCAP= ); } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DCSR); - status &=3D ~PCIE_RC_CONFIG_DCSR_MPS_MASK; - status |=3D PCIE_RC_CONFIG_DCSR_MPS_256; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DCSR); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCT= L); + status &=3D ~PCI_EXP_DEVCTL_PAYLOAD; + status |=3D PCI_EXP_DEVCTL_PAYLOAD_256B; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCTL); =20 return 0; err_power_off_phy: diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index 5864a20323f2..f5cbf3c9d2d9 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -155,17 +155,7 @@ #define PCIE_EP_CONFIG_DID_VID (PCIE_EP_CONFIG_BASE + 0x00) #define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_RID_CCR (PCIE_RC_CONFIG_BASE + 0x08) -#define PCIE_RC_CONFIG_DCR (PCIE_RC_CONFIG_BASE + 0xc4) -#define PCIE_RC_CONFIG_DCR_CSPL_SHIFT 18 -#define PCIE_RC_CONFIG_DCR_CSPL_LIMIT 0xff -#define PCIE_RC_CONFIG_DCR_CPLS_SHIFT 26 -#define PCIE_RC_CONFIG_DCSR (PCIE_RC_CONFIG_BASE + 0xc8) -#define PCIE_RC_CONFIG_DCSR_MPS_MASK GENMASK(7, 5) -#define PCIE_RC_CONFIG_DCSR_MPS_256 (0x1 << 5) -#define PCIE_RC_CONFIG_LINK_CAP (PCIE_RC_CONFIG_BASE + 0xcc) -#define PCIE_RC_CONFIG_LINK_CAP_L0S BIT(10) -#define PCIE_RC_CONFIG_LCS (PCIE_RC_CONFIG_BASE + 0xd0) -#define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) +#define PCIE_RC_CONFIG_CR (PCIE_RC_CONFIG_BASE + 0xc0) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) #define PCIE_RC_CONFIG_THP_CAP_NEXT_MASK GENMASK(31, 20) --=20 2.49.0 From nobody Wed Oct 8 07:40:05 2025 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA0A628C84D; Mon, 30 Jun 2025 21:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751320445; cv=none; b=kbiDad2PzqEzJxxx5dMgjUmmpeE2Xq36WgT74S8EHvblVQUckRI+zt8iWdFV+BWCNq4UDWvbVjSobYWC5v95PcDAu/slxZSED8eFyLP3OPz7ThDPVlO8TWG44x6T3qTYsN9hZ8IvUKq1W2D5CgjsUYvhHqFYrQYw9KG7ew1MB1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751320445; c=relaxed/simple; bh=TMyeQZWAOAuTwvIXse5kaD0KDoeWmnfqoNhsSOfoCv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GC5KLD0WLQsTw6ndyP/bCUHOzFRCgE1RSGl9mE+GzkOGVA4Cmer5Ctex4uBDctJyWZ6dpW0D4atCidCu8XLKpNmldLVGpvzZ6t8Z3ezl37RgUZ+3QDrkzpglzVsP9KDYjsPItUpnWNlsHcQTFwHqCsp092qXFDbqo1EoVUA/7iI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MzpeL4kR; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MzpeL4kR" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4a585dc5f4aso58860481cf.2; Mon, 30 Jun 2025 14:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751320443; x=1751925243; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rtc4GJjYIzCc3h+Hv3COhOArvofrVT3IhU2L5CEaYbA=; b=MzpeL4kR+IzZIGN2OjxMc67kX9Dpfsdd9WC/g+VIPT5Qr0lxmYAfQnnm4Sy0+BbU0D 2yh8EaJbzSW3eW8qMo6wVTdswXns32PaieawgJl1VmtAtCNgdEr3nZtHVHb+19HSQXtf X8LqBAl/qJ7gE8+Tg6q45LYW2nCmCjixJRhgmUd8nfXYMQChFE+954hPt/lx6Uh7qWQP k14oWbbCWLUe6X/nlsAEANsrKgHFbqA52gw4xBb9t/rX0bBp64rkJQlHPc9Kimwjmfp4 HqkHI6SIqv6rIi6AJXiNLSRlaNv5JPFNiecpQsLUC7JdOuneDYqHzTigNeUi4ZdmAku4 4Mnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751320443; x=1751925243; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rtc4GJjYIzCc3h+Hv3COhOArvofrVT3IhU2L5CEaYbA=; b=C/CnSa3Ht0DwqPjbixzEhJYz3MlzcxYiTozV4aGzTmQaKK2NxGixLSoVOcEfyLjmPP uWMdUsoYWj6+0mbCj+FQgG6py5yjqV65uEpZhdPTrE+OptI3SlYbwuVfO2EFc4P6np/V zQCjYutduiD2rPTkd7AIaarQ1L0Zxat1hktdsfp8O8dasS71KuAOh3HXrVOCVnoK0JQd BHPglbN4KWfAdgZnRmZCZEA26TMkBE8GeGWzw0AalF18k+0vvd/1Z4JuNQ+lY1n3awTD cZklKzX1mESBtml5gZBt0DdltLx5t89IiBhQPvQIK2Bj0mmTddWAYWVthFtMah/1piI5 ldSQ== X-Forwarded-Encrypted: i=1; AJvYcCVgYlH1KmkwmrB0Z3J0WKpg0Aazl4jUmFjTcsaDASBFmkzNi6UUw1tER9QGiaTLg23AGEni+ce9fhPZEp0=@vger.kernel.org, AJvYcCXYouaKnQJv2ucpF/q40R61rHfYrHk4jIxFcQTJ0laM+wYaRI3hpUEErREbbZqnORMOeID+2uktKf0q@vger.kernel.org X-Gm-Message-State: AOJu0YzhgtZqCMgnxvTUsIEb0uqzsOInlrRksIiiRnLUTIBadw9q7Zx0 jBmbG9l7eZWxDFx1oktcZGVdyILTzpgjcpvpSm0mKiO3r7Auf7E923MYpLyAkWYL X-Gm-Gg: ASbGncseYlDKoYKqpWRkwZY052etzXzkOSol7OJ9Mib8T2dGZkJ6vXGqXyHCkLzDr4A 5pIyR6J1qVswIn+9dPh6V+Ox4uL/SMWQG5Henaajk6ZcCdO/zlw7Z8DGE3NOlvI6YeOUHlZTUAd pJxZs+xHUZ86kfZhzOlgbZ7fJy8m/rmPk3C7Lb2ZxJhPyPVSaQTdimQvEWp78D4b6ek47HPguBS PSh7LLkW/3oIaSyGywaPoYzo/5C45mElwM9xMHVsRHMqMNI3TdAXreoQ72fUSv0sPld0wIGBjYv dhhfKqK8aTbi47K3c5ngGjgAzEBYMCIXtqSuc66hsipT7565xw== X-Google-Smtp-Source: AGHT+IEl8a6dIg9zoMy4z5faHvrY/Wge5nU0Ym4b/IhHk8USZly6BJFNwucTpW4cMCnQ1wqi4jpzDQ== X-Received: by 2002:a05:622a:2d5:b0:4a4:30a0:39c0 with SMTP id d75a77b69052e-4a7fcab1a7fmr246749051cf.28.1751320442648; Mon, 30 Jun 2025 14:54:02 -0700 (PDT) Received: from geday ([2804:7f2:800b:4851::dead:c001]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a81b8ea2a4sm21766721cf.75.2025.06.30.14.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 14:54:02 -0700 (PDT) Date: Mon, 30 Jun 2025 18:53:55 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , Neil Armstrong , Valmantas Paliksa , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 2/4] PCI: rockchip: Set Target Link Speed before retraining Message-ID: <0afa6bc47b7f50e2e81b0b47d51c66feb0fb565f.1751320056.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code may fail 5.0GT/s retraining if Target Link Speed is set to 2.5 GT/s in Link Control and Status Register 2. Set it to 5.0 GT/s accordingly. Tested-by: Robin Murphy Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 65653218b9ab..25890f6c0e17 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -341,6 +341,10 @@ static int rockchip_pcie_host_init_port(struct rockchi= p_pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL2); + status &=3D ~PCI_EXP_LNKCTL2_TLS; + status |=3D PCI_EXP_LNKCTL2_TLS_5_0GT; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= 2);=09 status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); --=20 2.49.0 From nobody Wed Oct 8 07:40:05 2025 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFE0123F41D; Mon, 30 Jun 2025 21:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751320560; cv=none; b=Dv5KaZZavPdDEMfipoRKAcuYPlbAWwKCiHkBE9DJn0XqxcFZcZ+tHEiJpG5RRUUrkW/q7bPo7YIPkSnels3nYb54+OAxXphCh9pIDkQ/VBWzrIEt7To/LEu+BSBZl51eRKrnUcDJnKIlrPMstPHegzpgwAwdqQsBmyCAKtHDXKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751320560; c=relaxed/simple; bh=oAZISEWKYtSLKKLeFTIvOInH3R5sB+cLBcS8i1Z7lWU=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DBAhpVT6jmVO3pBoD1Q+2Vh0rQdoSe93hjStWlkHZbaDDadAPBk/eunl2u3exhuTvBr/1YLVLqeGxLSLIhAunUAs9jYyIMqlA1NjJDmiO46J0IUYM+sgM25AgyseTGm5cNYY17ZSkKTTvmdehxIdMe4gkKWYMy3maSuL4H0wbnQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C2+PmzzP; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C2+PmzzP" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7d098f7bd77so561104785a.0; Mon, 30 Jun 2025 14:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751320558; x=1751925358; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=hXeS77/kGdjI+bypW2RtRvB0CsC580lSSASyDeC37uE=; b=C2+PmzzPapJeb7k+C5dmpHs/j6yI1jI1UnBnfEHJhKMVaXhMVJXwxUoQjrTB8pUhTt TRCV5PRi7T7rHym5TSlzbci2EqRDgeXLTx7Ivz8wKGoRc3k1BQCmcPealCKGvmpHhzI3 1iH9WyB4ZGPgd2nnTjptZmoaICMHnUCjZQdoGLxtVoVAUBZY//RKycBZrHKxaVVMqb4d zceRpvNMx0ljWujFWlf9KAutdf3C6pJe1lnIhWYLSp5LWDi9vHLNfPGq4BRYpJMqOp8l 8GapWJSSJ5mTnZ2kXMQJMhDSAHcNeXJfIziimyifI8wRSRCQk8IM8mBN7nwiTfgG+joN jgPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751320558; x=1751925358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hXeS77/kGdjI+bypW2RtRvB0CsC580lSSASyDeC37uE=; b=la9RLrL9gqRjaozfjotEYX6Zy+4qitmsws+PpuZOW3esPYdxz8j/tOqg76iWqJ/WvW qMu/Z3e0oPtRwyG7MkcXz0FF/HnoKinS8XE3hSHWtGwdJwHn/aarh7ZVWjzeX01jeCIu kUsIwcRd4ajUa1+NaNazTny0adQjEkk6+qXG6STYmyFON2/87byOrBVe/AnzWE1uD0eU iUjFOJ99IARtq8QBUWjQQO9h54tLBUUjswRfkcntHVcgg1/DNy4RwKJnnAUrnv/bG2js sm7YrSATeojaCRDmL20XYbbTIQ5zDSNIo+NmWjqANnyjZmUl59EFutPNjBhQFxYtdUtN 6oaw== X-Forwarded-Encrypted: i=1; AJvYcCUZ0QgWEEVzTBWsM7gJIrRjCMPBh6ASvpG2ofJM9IKf8jqJl5JpZdFAa6hyi2rl0WMEKh7H60ddoHwu@vger.kernel.org, AJvYcCVLIGrVIqUNYPzqHUTwTzayM0RIRA9hhCLV25XY2vLuIOODF4GJ2T9nLrjV/Qlq6xG5cQyk5x7Iiz/Ip0w=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4I2Ibk7QBDZN5X3XWkAb7WhB/kB4Db3Od2MId1JF/7MAHtzyW vgG1CDHF79/mtbs4VOKAxrBUvDbzeiyfqOmgma43fcbYd3M+gLjGPvoj X-Gm-Gg: ASbGncuiwQbxuwKsjwkLZdI/ccmqtp14RIWxyva5HEZbSq6uQt7CuxmZ9iOUE/A0q+T ChlDJVGIbFYLJLfqDZjSJRNBCAQG+I6p63Dyf4ScMV4Ga+qpzXQLdMSedX8SUGFgfb8WDyQ1An9 r88KXd3ojp82Vwq2cY9zeD/5EBkUS1rio6005SIaC2Jtp+mUchZdityZ6up3V52ZGczoFACDeyz 4jchRwJ5pA2UUhUa5WDNYLtvDTuvZd7vlb9NEjgBHmUbLRnc5kFn1Ycbed0twbyCHvsA7OUasct lTDsvJ3083Gh3LPX+X6Uj5VRWPGS2RLihVfF6Fg= X-Google-Smtp-Source: AGHT+IGQ/AcloVa3UhaN0HEbry7ak0F/WAQV4L++1fEImPAFM7BWCGo24P62etG1Kv2fRrqUymIgtg== X-Received: by 2002:a05:620a:4054:b0:7d4:3c38:7da5 with SMTP id af79cd13be357-7d466de06b0mr169684185a.14.1751320557720; Mon, 30 Jun 2025 14:55:57 -0700 (PDT) Received: from geday ([2804:7f2:800b:4851::dead:c001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd7730ad9asm74574936d6.107.2025.06.30.14.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 14:55:57 -0700 (PDT) From: Valmantas Paliksa X-Google-Original-From: Valmantas Paliksa Date: Mon, 30 Jun 2025 18:55:50 -0300 To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , Neil Armstrong , Valmantas Paliksa , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 3/4] phy: rockchip-pcie: Enable all four lanes if required Message-ID: <16b610aab34e069fd31d9f57260c10df2a968f80.1751320056.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code enables only Lane 0 because pwr_cnt will be incremented on first call to the function. Let's reorder the enablement code to enable all 4 lanes through GRF. Reviewed-by: Neil Armstrong Reviewed-by: Robin Murphy Signed-off-by: Valmantas Paliksa Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index bd44af36c67a..f22ffb41cdc2 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -160,6 +160,12 @@ static int rockchip_pcie_phy_power_on(struct phy *phy) =20 guard(mutex)(&rk_phy->pcie_mutex); =20 + regmap_write(rk_phy->reg_base, + rk_phy->phy_data->pcie_laneoff, + HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, + PHY_LANE_IDLE_MASK, + PHY_LANE_IDLE_A_SHIFT + inst->index)); + if (rk_phy->pwr_cnt++) { return 0; } @@ -176,12 +182,6 @@ static int rockchip_pcie_phy_power_on(struct phy *phy) PHY_CFG_ADDR_MASK, PHY_CFG_ADDR_SHIFT)); =20 - regmap_write(rk_phy->reg_base, - rk_phy->phy_data->pcie_laneoff, - HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, - PHY_LANE_IDLE_MASK, - PHY_LANE_IDLE_A_SHIFT + inst->index)); - /* * No documented timeout value for phy operation below, * so we make it large enough here. And we use loop-break --=20 2.49.0 From nobody Wed Oct 8 07:40:05 2025 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D46A91865FA; Mon, 30 Jun 2025 21:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751320578; cv=none; b=pLx9yFmuXQG7FnzeLv6ivjB/EOmthRLIbVFAVtwNh4B/6J+KHumxfDsTexFNQewjE/92S9mXm02Mj6TOURft29X1p4q5uo5O1PyuDmk38ZpzPiv4USoJeggmA5WjlLSj2mTpZKRlHaKdn+qi+UVPwa4Pa6g4CGGLT3DjskdxUQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751320578; c=relaxed/simple; bh=CNxK0279ukfbz74d9Orf//2RsynVo3ZY3ta36YHi0ZM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tk7C5SIKvml4pRzIuhh0zk9xdIkKkghpFwUOJVM44rHL4oP45plfYsay9zXNLShQFBIoXm4ugF12FGJD6vu2es5KeP/wX4D0xfwGOt+vDck161Wy3ZIgrzdjUF15MlTUlnN49aHoqt3O7sxc2OLPgb0pbrMVquL6IQdqXKxM7Sk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ApC94354; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ApC94354" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6face367320so30273896d6.3; Mon, 30 Jun 2025 14:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751320575; x=1751925375; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rMkTHKD3jio2hpq8BtE0DToF1CwksemxWLN6Z8dMYEk=; b=ApC94354db43zSoRe00Xwbwv8ntF+QlAtlyfSf8htrC9VwN4EaUTpCh5ro4Vuaiv/y wW3/9hVg1+ogTpWOjgby1lk+6bkGOpO2al5I0HKVtHCORd4ifA+QeIWu65bCsn2U9fLr mkfr25omB6u3550PmBTBR2rnCXcJTLM3t17yC+FrNa0FLUBpbc/FfQmL1jTbOtvllhHi BE55RrlbBT82m1eKMBB9F0EhBFXrMu24ICsc0x4CpQEBHJOvKVVV9GKVquPQ5H0KtH6Z xd8WRjQng8myc+lGCS0xS+jWdzPVdlHQefBtubONKr/dumjWn+npVPm9TEC0xAgEE/0r ZeLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751320575; x=1751925375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rMkTHKD3jio2hpq8BtE0DToF1CwksemxWLN6Z8dMYEk=; b=Ax41gUlN3q6YOxMKzCBGzpMMyJqlHeiVAyZf4QSIwe7uOFqzOOwsYleHYD81YGSQe1 UVxJD4sXNfzQ8q5SXCv1d9sSTjaFTzBBkUkPULWpsv906fyjgRhAIOxZQSw6c/mRMC5Y A+C0iax9kYGLvT77+AjVy+uAuNmFDksrB1Yu3G7gx+nlcER11UdhyV7otSAgJ5q785Rt t3n2OnmtaEIC7UFmrPezewt2C6V1oJ3eFR2q2Dd79TT49/u9RwwDxfASnyu39uwm6UBE apJFF8nv4DgIKnPTAMuSJdHsjaSxXTPJvbti7g+5M2LA0YDwyMG7pO4VeAEb09LM5war Ymfw== X-Forwarded-Encrypted: i=1; AJvYcCV/sAUbV8wIBuwtIweF/oTs5qQae19L864EPvT2zbnNKHn79izGxaqtOt5YqlzIRSOJ9m9OQuyoARbS@vger.kernel.org, AJvYcCXtGapJLlNB+8OMxxl5zytWKzEWctEI6Xlbu5EjawTijUqek2KCVBz+dB6+/rZCOMswN8NuXdW7kH/UdY0=@vger.kernel.org X-Gm-Message-State: AOJu0YxeuJ3HxaCBMk2O+aV6RVuB+DECYpL7Yp8X9Se7GYTkn0ixfgXh mYQdtqXneKOrOFEd0J87Qr+3V/ZGQMHyVcny9KEPIYfw+8wiGFg91K/e X-Gm-Gg: ASbGnctoeyRwYMDO2BT4zvRKslgNeqRaKnScW8cDj2yutZc0YkMjizON6CislSlDUPA MAKnQFXTMCt/mmxGvGPmWlgWieO+PcpIsgW7/BZocFYzM91TAOpVBF3/0qkIQ4nN2x6aVNtkz1V /KNWk4+FejrcVimlCCKADIsHkAjx7wmMTZf+tnlWVmJpmImRdAHzxNpoNa5qdRwq44UTDCnHJZf 9TLWRaCO+LRnlziLy7deA3iHmK/D9WXRY6yNorQiOxlgagzzKe4IcOX+9jK9qN7NMTgIUB0qMLU XZEynekn0ueEsmLmOxGZJA73876w7pvv++y7P6n+KQcznaN8qQ== X-Google-Smtp-Source: AGHT+IHlwnZKtQx0c2S3ULgdwUmNGv7rh1cxRLFpfUvaYKGpyKAJS0ZlrmwkemijKiLME2PiK3LvCQ== X-Received: by 2002:a05:6214:1948:b0:6fe:8c28:f3af with SMTP id 6a1803df08f44-700131c4c3bmr220986626d6.40.1751320574701; Mon, 30 Jun 2025 14:56:14 -0700 (PDT) Received: from geday ([2804:7f2:800b:4851::dead:c001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd771dcb9csm74286306d6.50.2025.06.30.14.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 14:56:14 -0700 (PDT) Date: Mon, 30 Jun 2025 18:56:07 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , Neil Armstrong , Valmantas Paliksa , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 4/4] phy: rockchip-pcie: Properly disable TEST_WRITE strobe signal Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pcie_conf is used to touch TEST_WRITE strobe signal. This signal should be enabled, a little time waited, and then disabled. Current code clearly was copy-pasted and never disables the strobe signal. Adjust the define. While at it, remove PHY_CFG_RD_MASK which has been unused since 64cdc0360811 ("phy: rockchip-pcie: remove unused phy_rd_cfg function"). Reviewed-by: Neil Armstrong Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index f22ffb41cdc2..4e2dfd01adf2 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -30,9 +30,8 @@ #define PHY_CFG_ADDR_SHIFT 1 #define PHY_CFG_DATA_MASK 0xf #define PHY_CFG_ADDR_MASK 0x3f -#define PHY_CFG_RD_MASK 0x3ff #define PHY_CFG_WR_ENABLE 1 -#define PHY_CFG_WR_DISABLE 1 +#define PHY_CFG_WR_DISABLE 0 #define PHY_CFG_WR_SHIFT 0 #define PHY_CFG_WR_MASK 1 #define PHY_CFG_PLL_LOCK 0x10 --=20 2.49.0