From nobody Wed Oct 8 12:49:03 2025 Received: from e2i340.smtp2go.com (e2i340.smtp2go.com [103.2.141.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08DE42DF3EA for ; Fri, 27 Jun 2025 20:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.2.141.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751057797; cv=none; b=jTh1Mu/87N+sAtRqVonXOjy0kYSNiBSWKjA4P3+5gSDXI+qyU1YDT1ZxETMQ+DcfaUZCYXfm6/HE4MrABbFwnyxoId/1W05LIidExis8KMvLNR5heUx/xWaXDoOoRELAwxZJ1Kht9FCu6RnUYPikjU0079JYxtOPxwqVXnt81qs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751057797; c=relaxed/simple; bh=PB5y9/HTjxCPGTDbN0DPdqlQpv1FQay+Az8XF+7AqUk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oFbsxWzoXRJGzkJqvH2bGH+pNjkoU/CD5jw0kN+fU5VRwgN/vNyXtdbl/jj7UcvJN3m//OGl8AcjAxKnrNIYd4mrzlPgx1bfEXWStumaQhMaC+OXwRuWDRA0lHKoxUpJ3zieWgJIvu+thAZpIHB4EosIhbdmVMLkC5mOQCD/rJI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=triplefau.lt; spf=pass smtp.mailfrom=em510616.triplefau.lt; dkim=fail (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b=BdsahQrw reason="unknown key version"; dkim=pass (2048-bit key) header.d=triplefau.lt header.i=@triplefau.lt header.b=O3DknTZ+; arc=none smtp.client-ip=103.2.141.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=triplefau.lt Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em510616.triplefau.lt Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="unknown key version" (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b="BdsahQrw"; dkim=pass (2048-bit key) header.d=triplefau.lt header.i=@triplefau.lt header.b="O3DknTZ+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=maxzs0.a1-4.dyn; x=1751058694; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe:List-Unsubscribe-Post; bh=KI3j6h+4PHiZ7IiGHZy/tubXugs/QE1IKxzd+gUImrA=; b=BdsahQrwQTKrzmzbnC9JYzPyKM vwx2bq+fahNhMbrkBz70ihlztzlkGHjYiNCC4svm+a1sSk4UECfOmUX3hYUvC/OZW51jlueAAkuKU 0MNkHqgzl95MJiyjrHJgac9oIeasHeaN0y/Dss6/JcMscO4VxRK9sm0DhUq3R2t9Aooay3lHL/wPA vCqnszth6BQdpKPIU+sl02yRf61USXqvzyL4goKqep7JNL6FBeMAv/UmCbt9BA9EQMZrM/Fbnf+pg 4QWh2xC0vvTLfX+E1ncbJ95SAVJwa6KhCcSpxqcCH4Jxf1LfB4lsIm7qVBz6mpNhZWyQ2rEIWbRqx z0aOy9iA==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triplefau.lt; i=@triplefau.lt; q=dns/txt; s=s510616; t=1751057794; h=from : subject : to : message-id : date; bh=KI3j6h+4PHiZ7IiGHZy/tubXugs/QE1IKxzd+gUImrA=; b=O3DknTZ+/DHcrJLcwQP0DXuWMoBnvAkiwOCt8ex7lj4weAod6X8i1hMyeKA5XBmGp+PY2 sWv5KFDytJ7g2xbf6DFG32NzNnywKKmsFK3XxsyKQO6EagMzHlf2EvSUt0237l7+ia75dUf uK0mo+9FLNyY5G4sMaZXcYk5bI6xuV5ZVPqqI+b5bMOR1wGe/lsGQoMsF0LCF/7G4xu9uIO wuHlOdhir7FjHLD3KBV4rs1QrKYoemrvn1WLy94OMSZZHY51NhiQCdXrsiyuDNHq1GRJWYn csFy8zxY5j4pIIcXcdntEEnyEH/o+TLdT4C0JyOnzoJyPfLyU+HCIfBT89bA== Received: from [10.139.162.187] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1uVG7U-TRk3Us-CZ; Fri, 27 Jun 2025 20:56:24 +0000 Received: from [10.12.239.196] (helo=localhost) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.1-S2G) (envelope-from ) id 1uVG7U-4o5NDgrn9kc-kei5; Fri, 27 Jun 2025 20:56:24 +0000 From: Remi Pommarel To: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Johannes Berg , Remi Pommarel Subject: [PATCH wireless-next 1/3] wifi: mac80211: Do not set link_id for received management frame Date: Fri, 27 Jun 2025 22:46:47 +0200 Message-Id: <8701dbe48fae509bc8cb6d8ce5e6f96f75ad57af.1751057146.git.repk@triplefau.lt> X-Mailer: git-send-email 2.40.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Smtpcorp-Track: x5Dj2-aHDx0x.RisXXF_SgsDx.b0WCbwmdTEG Feedback-ID: 510616m:510616apGKSTK:510616sqE7JnFGBJ X-Report-Abuse: Please forward a copy of this message, including all headers, to Content-Type: text/plain; charset="utf-8" A non-MLD sta could want to send offchannel management frame (e.g. to do a offchannel scan). Because ieee80211_rx_for_interface() fills the link_id information with the link the sta is currently using; hostapd would send back management frame responses through wrong link causing the sta to miss them. To fix that, do not fill link_id indication for management frames, relying on hostapd instead to infer the proper link from the received frame frequency. Signed-off-by: Remi Pommarel --- net/mac80211/rx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index e73431549ce7..deebdce6d9c7 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -5112,9 +5112,14 @@ static bool ieee80211_rx_for_interface(struct ieee80= 211_rx_data *rx, * have the link information if needed. */ link_sta =3D link_sta_info_get_bss(rx->sdata, hdr->addr2); + if (link_sta) { sta =3D link_sta->sta; - link_id =3D link_sta->link_id; + /* Do no use sta link id information on management frames to allow for + * offchannel scan, roaming, etc. + */ + if (!ieee80211_is_mgmt(hdr->frame_control)) + link_id =3D link_sta->link_id; } else { struct ieee80211_rx_status *status =3D IEEE80211_SKB_RXCB(skb); =20 --=20 2.40.0 From nobody Wed Oct 8 12:49:03 2025 Received: from e2i340.smtp2go.com (e2i340.smtp2go.com [103.2.141.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08E4E2EBDE5 for ; Fri, 27 Jun 2025 20:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.2.141.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751057797; cv=none; b=Lukix3nHcaHxnPEYT9X3if5gys9FTAJ5WyeLGflEXF4en2+AvzZBTgWYrAV1k+UofjtvUPjoVB5GPOCdujDi7hYQVcpF83TcilNXlusjecivkIJTVCg2VsAX19Bfd2DuYal2oX0nLjucCp2weTvDseqSpYqWBs1gVVxUMZdS2sw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751057797; c=relaxed/simple; bh=HUmZknJWh+4IbGoKHMlrRE2bwWFAclzczTpLLSJQjFI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I/AcQQHUQpES0/UdtANbOOiylMOeXSCIyqI+Ba/COoRzOPckweWqkf4KKuA1P/76U2UofgoQ7DW/Qk8CS7K5RXfSGMP2ZUaOm/bW3WwFgeIWkKN93TqVxrOCK7ln3P05kJbde0JxF3rMyjg9X53M7UVJN6DcS4WrqqipZPGDT5U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=triplefau.lt; spf=pass smtp.mailfrom=em510616.triplefau.lt; dkim=fail (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b=IToUDjUU reason="unknown key version"; dkim=pass (2048-bit key) header.d=triplefau.lt header.i=@triplefau.lt header.b=OijLCpEA; arc=none smtp.client-ip=103.2.141.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=triplefau.lt Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em510616.triplefau.lt Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="unknown key version" (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b="IToUDjUU"; dkim=pass (2048-bit key) header.d=triplefau.lt header.i=@triplefau.lt header.b="OijLCpEA" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=maxzs0.a1-4.dyn; x=1751058694; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe:List-Unsubscribe-Post; bh=7qQapT4Ems7IYz4MpjuzCT6uqTNZKqM/89+kD4lotE8=; b=IToUDjUU7ZjHmY5WOHUK4CW6uO zdCefdpN0eOAToux9HVm0MotPJjKMufIne7k9r3oDkj/nRaQeOgZD7Y9ctfaSzn/tvL25PixRsT/N fXMSf3mw9e8lw31e3gBIaeA+kRh2LB76MkwEzLyrekpaAIgF6y+YJSnG1zt5HOJ6BELyeexWhRmJh njiDB20YsHTJhbllKeeEEjujHay3M3NCi1cUj11JyYOSn4Suefix9pa58HRD39XYD8Z168xGtb21G oZAshfIiX6QynQt3X6Kh6VmDKlfDWJLawGTRbvn7G/k35HFAQAJsmo6sAODJw9falzOIBgzIXjEVL 3LxkBgFg==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triplefau.lt; i=@triplefau.lt; q=dns/txt; s=s510616; t=1751057794; h=from : subject : to : message-id : date; bh=7qQapT4Ems7IYz4MpjuzCT6uqTNZKqM/89+kD4lotE8=; b=OijLCpEAaKzgFnZ7f9LRZrPV0oCioin/g6AegtyB0eQhEgASpWz6+74m8La18HmBY7SL0 8r3OENzBFlPUBJ0WzaiUNZEX/1q//ItLKdXMRxBQwTN0rYWNp1+MAXOyFiLmwjfTc8q2iuz QRP4pNac/4i1C63BqEOnzJqEnvtTUzOAwFf/mzQ9vreYEEvb01kzcsX26i+2dj3Sj//CzTv Y0giv6BheWuJcMhTOzLkcEdf2Qwww8PzkWepULuEylqAfP7o5HyhqxScRt4Hky1uItPZ9s0 66DHXMTZU0Iwnu9B0f7mFXP4bY16tjQeLG1JkDv2prfeqw1M1w56bSvpur0A== Received: from [10.172.233.58] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1uVG7V-TRk3Xd-0A; Fri, 27 Jun 2025 20:56:25 +0000 Received: from [10.12.239.196] (helo=localhost) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.1-S2G) (envelope-from ) id 1uVG7U-FnQW0hPw4yg-n6Sv; Fri, 27 Jun 2025 20:56:24 +0000 From: Remi Pommarel To: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Johannes Berg , Remi Pommarel Subject: [PATCH wireless-next 2/3] wifi: mac80211: Check link id at station removal Date: Fri, 27 Jun 2025 22:46:48 +0200 Message-Id: X-Mailer: git-send-email 2.40.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Smtpcorp-Track: kdwHBLEzAKDR.oVzWQ41JtPw5.IDoZGQWYyxC Feedback-ID: 510616m:510616apGKSTK:510616so1T645gTN X-Report-Abuse: Please forward a copy of this message, including all headers, to Content-Type: text/plain; charset="utf-8" hostapd can remove a non-MLD sta connected to one link of one MLD AP several times. If the sta roamed to another link of the same MLD AP between two of those removals the wrong sta_info could be removed. To fix that remove sta only if it is currently using the link specified in NL80211_CMD_DEL_STATION if they are any. Signed-off-by: Remi Pommarel --- net/mac80211/cfg.c | 3 ++- net/mac80211/sta_info.c | 7 ++++++- net/mac80211/sta_info.h | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index d9d88f2f2831..3dfe8e0759bb 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -2195,7 +2195,8 @@ static int ieee80211_del_station(struct wiphy *wiphy,= struct net_device *dev, sdata =3D IEEE80211_DEV_TO_SUB_IF(dev); =20 if (params->mac) - return sta_info_destroy_addr_bss(sdata, params->mac); + return sta_info_destroy_addr_bss(sdata, params->mac, + params->link_id); =20 sta_info_flush(sdata, params->link_id); return 0; diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 61583173629e..7e58ae507a14 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -1530,13 +1530,18 @@ int sta_info_destroy_addr(struct ieee80211_sub_if_d= ata *sdata, const u8 *addr) } =20 int sta_info_destroy_addr_bss(struct ieee80211_sub_if_data *sdata, - const u8 *addr) + const u8 *addr, int link_id) { struct sta_info *sta; =20 lockdep_assert_wiphy(sdata->local->hw.wiphy); =20 sta =3D sta_info_get_bss(sdata, addr); + + if (sta && link_id >=3D 0 && sta->sta.valid_links && + !(sta->sta.valid_links & BIT(link_id))) + return -EINVAL; + return __sta_info_destroy(sta); } =20 diff --git a/net/mac80211/sta_info.h b/net/mac80211/sta_info.h index 7a95d8d34fca..653eda1c2466 100644 --- a/net/mac80211/sta_info.h +++ b/net/mac80211/sta_info.h @@ -878,7 +878,7 @@ int __must_check __sta_info_destroy(struct sta_info *st= a); int sta_info_destroy_addr(struct ieee80211_sub_if_data *sdata, const u8 *addr); int sta_info_destroy_addr_bss(struct ieee80211_sub_if_data *sdata, - const u8 *addr); + const u8 *addr, int link_id); =20 void sta_info_recalc_tim(struct sta_info *sta); =20 --=20 2.40.0 From nobody Wed Oct 8 12:49:03 2025 Received: from e2i340.smtp2go.com (e2i340.smtp2go.com [103.2.141.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08EB62ECD33 for ; Fri, 27 Jun 2025 20:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.2.141.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751057796; cv=none; b=uhR6R7f16/42yWqpcrhJh48XY9Zy1Y3g7ULg2dSQBfeA3Td14fnVslrrZyIjIzzDc57+D9ZGYcZhM+oPdqa5CPHJ1qR9vQg9kVBM30O/Yqw+YrXQTzC7oe4YB6Qgv/Cs2myM/nuMf15M3TAxIC9lpvV5g3jqvV0urFH1Q5QDrn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751057796; c=relaxed/simple; bh=EqsjFcnoV7wkCfCblGpMw/2Zo+KMh0FeYoLwiaCPx8I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JGH+T+bd4Szu3oqSn2ZFAQPPjgZhHssQjLZIW1C19igfPfoFWcBqJQdNYHT7WSRr4LaVWAxz2yAQ/j66bS9CRmYw3UhgXOht3H+YokhCXqfxLOHsOmy4kH3nJTMJkail3Lq7tyQwBOuAKAjLjTOJg+SCmFht4YYixWBDAVFguuY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=triplefau.lt; spf=pass smtp.mailfrom=em510616.triplefau.lt; dkim=fail (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b=it7cKOFv reason="unknown key version"; dkim=pass (2048-bit key) header.d=triplefau.lt header.i=@triplefau.lt header.b=F5qUsqRX; arc=none smtp.client-ip=103.2.141.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=triplefau.lt Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em510616.triplefau.lt Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="unknown key version" (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b="it7cKOFv"; dkim=pass (2048-bit key) header.d=triplefau.lt header.i=@triplefau.lt header.b="F5qUsqRX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=maxzs0.a1-4.dyn; x=1751058694; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe:List-Unsubscribe-Post; bh=EPjNXSD+QUTAQdHPBF1PZFOR+NJM45qYXx5B36QYUrI=; b=it7cKOFvqyVyYcFSrfbRdoewyh UFcfT3Yw7VjN9tfj9AF3PR4wYPpBDElU6g8bputf2LJ391K4UIbDfoROuBY0lIpOIIuMa4P0nyj+4 nHD0QkK/zpWeuoQhxyLfZn1Ci67JPK8iNNludzglGSKR6YKTw6lzZvC2J18QwDLBH4gDWBA2nC5nE iV0IgkocQP2fw9wFWv1lRULcRlIChY0f8lZExulJrqUxhp6Rmas3YCINJm3opyNem93mjrtTUba5Z 52puz7JgjdiwOwoDUC2ZfloXysLZqYs8nUIBMnyxB9bw76vULZRksJ0JlSUAhv83irmg1CIuPw+0D 8E7SWCcA==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triplefau.lt; i=@triplefau.lt; q=dns/txt; s=s510616; t=1751057794; h=from : subject : to : message-id : date; bh=EPjNXSD+QUTAQdHPBF1PZFOR+NJM45qYXx5B36QYUrI=; b=F5qUsqRXDyTcx6V+IZZljLVtUA+PwAlWQA4izgEfdnu8oJGGT66xy7l6umrmFa/U491gu 4LE6GI+YY+3kBrUxf7StBOZbJ2Idtqy/AOrDOR5umZ/9KfxqabpqE51zFMcsHQipQ6BsiYZ N4NKkcuProtDFsg6l67JTiIzmzDIUAai7g2WNsFHL6tX3AVpqPGFct/AejmCjbKKO/5wREq cEgdOa666PbIpUwEPSW4FRuUUls6kHpU2CySIv2G4R5n0j5mXKuF7IM+0eKCMo17mfHyzZI pGbVnh2c8Pp7b9NXCupBC/O0KFdbXWXYP2/ETZQwOxUO9jFynFhPYB3vteAg== Received: from [10.176.58.103] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1uVG7V-TRk3aB-BP; Fri, 27 Jun 2025 20:56:25 +0000 Received: from [10.12.239.196] (helo=localhost) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.1-S2G) (envelope-from ) id 1uVG7V-4o5NDgrjV9w-omjN; Fri, 27 Jun 2025 20:56:25 +0000 From: Remi Pommarel To: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Johannes Berg , Remi Pommarel Subject: [PATCH wireless-next 3/3] wifi: mac80211: Correctly init MLO link in ieee80211_8023_xmit() Date: Fri, 27 Jun 2025 22:46:49 +0200 Message-Id: <8ddf1dd6362e0ad57a98505b0d195554ebc91b7c.1751057146.git.repk@triplefau.lt> X-Mailer: git-send-email 2.40.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Smtpcorp-Track: Nz5J7QcA5snT.TjIl-KkFGOci.EDlO-gMB_5u Feedback-ID: 510616m:510616apGKSTK:510616s0p5iKs-_9 X-Report-Abuse: Please forward a copy of this message, including all headers, to Content-Type: text/plain; charset="utf-8" The IEEE80211_TX_CTRL_MLO_LINK info is the only part of ieee80211_tx_control where a 0 value has a specific meaning. Thus this should always be initialized with IEEE80211_LINK_UNSPECIFIED if there is no MLO link information associated with the skb, even using when 802.11 hw encap offloading. Signed-off-by: Remi Pommarel --- net/mac80211/tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index d58b80813bdd..f65fb96a498e 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -4637,6 +4637,8 @@ static void ieee80211_8023_xmit(struct ieee80211_sub_= if_data *sdata, =20 info->flags |=3D IEEE80211_TX_CTL_HW_80211_ENCAP; info->control.vif =3D &sdata->vif; + info->control.flags |=3D u32_encode_bits(IEEE80211_LINK_UNSPECIFIED, + IEEE80211_TX_CTRL_MLO_LINK); =20 if (key) info->control.hw_key =3D &key->conf; --=20 2.40.0