From nobody Wed Oct 8 20:42:08 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2064.outbound.protection.outlook.com [40.107.223.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 752702E62B3; Tue, 24 Jun 2025 18:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750788081; cv=fail; b=ukco5Sex7e8cyQMVeTv5fw6qaJOyVyTU5zzsgEb2guCJO7zfIpcqLkj7rrNARjtJyGSq0UvPRWcyunXsGmCOmBe+7rH9ArEklGYfoDvJtIM6FabTsPWl2QNsRidUTlv+FAGnzm+W4datPHXinid9fR6cTP9cdUP0rAhJJs03lIg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750788081; c=relaxed/simple; bh=TVAZESO6eMlJRQxUWV37Lp688BbaFvzN3aYBiCNGxWI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TsDZzroRPzkQ4FZ0sNMVENnn8zTaZWvKS3w7ek6wHXGuMQaRCLDBrre+QQmjgHjeIGjX55mHBleTQigH5eG50By6NdXcIAj/L7pTTFe3hS9XOVpwrM8jNmOiP+MvJ5f6ViT2m1yitoSzXAaPRDmjghXj/ujk7FTgWTFw2Vr0XdE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=W196X5NL; arc=fail smtp.client-ip=40.107.223.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="W196X5NL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dQ3QuFptTSuTGTtXzeoMTr5vpgdOCDeJKDIOAUHmcsqJ0PAE1Gmu+78aYdw9lmoux3KIfQldx2/1cPpCRldWNnf2dzDSn4lQwaOGNrv8MvvLBhjuEYcq7A855eHibi1S3BbdhS6DCAsG+5IFgwMdwcg+63XNDqHkQC6JIczHXMFmm+m65fsom0GCR2wX8DxvdZlqRgRXUeb0DMaVhI7ngcPLsDEtiqOgjF6oFLNhlicHSSxcMqEyfAEUQoJPWn6z/IAe5g6hj20I57YWrIBWPY0iLoGcYKbn+o352/eAqVeT1QlDSguSgpuhHaeM/jxeksgyfVn8KfxgbM/cg6HfRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LMgFP8VkwrOWN3KeVrHlV9smNmEx1d/QYkXIzKEjZCM=; b=xxx825RZdrMkadC4IcNipdvqXvSV/Rqb+WlRbUoQowJIt/MDar0LMHI/jqCaJVDO+tKpoZWsmDAMZEcSOKjcQ36EnJFJDZwwnO3blw9pbQU8gl8whRJ4t18uOmrqvqZ+MupZ0zXlt+lzL0dYNGQnoYihrnyhJAQ+K65Z0NSUSDIBCZ5op9febDF+21tYREOX2b+94muueJeUVweSa3S5Fy7RKDi1VIdfJp8TShVE9fiSbB6pefJyz7wKzc18+nD3GvOMtczTLjAcVvBofKuE2yHHq/ri1ztwSEfO7UA42ATT8VkG1F1bXw4w6JvvI/EY+HXJQTbb0yRpIhTHOQYlWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LMgFP8VkwrOWN3KeVrHlV9smNmEx1d/QYkXIzKEjZCM=; b=W196X5NLUED4SWxSP2uMIQ0gERE2Tq86Aht5I/BPE4f86Npv8lQOhgPDR9/XFfa8YIjIo41yppssSlWjSFAgvz6RtOdlFPd/89RBewEmfxVi8RHZfWN1WPFDSNqpSfKd6AoMQAAetN8ZQsMkVn46pii860CYrfywiICo8IcfVFFUVJnUMF9Uw8vLuoNWEahiLbi/cSgeqLZfdVf5L4dWESVf8jnBuA+FhRL3fVBYbAiJHc2jFkxDELIDvrZ5IsPRaPIkqCbLIA/goSxCqSwogdWq6kYAUzxKGzwL6YMBUDLvT1H9q41w7uAXphzM3diVwFedEskDeiohnVhoR4j+CA== Received: from CH0PR03CA0320.namprd03.prod.outlook.com (2603:10b6:610:118::25) by SJ1PR12MB6244.namprd12.prod.outlook.com (2603:10b6:a03:455::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Tue, 24 Jun 2025 18:01:14 +0000 Received: from CH1PEPF0000A34C.namprd04.prod.outlook.com (2603:10b6:610:118:cafe::40) by CH0PR03CA0320.outlook.office365.com (2603:10b6:610:118::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Tue, 24 Jun 2025 18:01:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH1PEPF0000A34C.mail.protection.outlook.com (10.167.244.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 18:01:13 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Jun 2025 11:00:56 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 24 Jun 2025 11:00:56 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 24 Jun 2025 11:00:55 -0700 From: Nicolin Chen To: , CC: , , , , , , Subject: [PATCH rc v2 1/4] iommufd/selftest: Fix iommufd_dirty_tracking with large hugepage sizes Date: Tue, 24 Jun 2025 11:00:45 -0700 Message-ID: <1ea8609ae6d523fdd4d8efb179ddee79c8582cb6.1750787928.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34C:EE_|SJ1PR12MB6244:EE_ X-MS-Office365-Filtering-Correlation-Id: cf3192b5-7af2-4267-3a41-08ddb3491bbe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bqozCCBpcOD/1dV+5RRN6w0Cy3WBh74eqYZNMzMbP9Ju968MCKwPpZMIFpxs?= =?us-ascii?Q?iu0MR/i2FF6xJ2RqSTisdFGKIB1Jy7WczxE1keIZ5VAXQvy0208KdH1ZV/JA?= =?us-ascii?Q?/hvRl8nCHRu5WGhszjwnJ1Y53xjmjUHiMa91UTIwMcSFfqVCQD2MX1fTZPyJ?= =?us-ascii?Q?Aa0tdovNJQ599yfKHdfMekrvSs1wC2S0U0Wq7DPbIpWNytlG2brmjjREvzt4?= =?us-ascii?Q?Dt6qK2T7zstOuamIXLgkzo/kzbEeIEkn/Dro4iYbgKbXfrZ9PcOOvaecTYIp?= =?us-ascii?Q?kqQkngl0O37Nm2eZ0EBfneGArKgUaGJ3/7VuBhPRks1iObGO5JnIT94roEWl?= =?us-ascii?Q?dcwr05qhTps9U9ub0t5+v5tM7VEBmTWtqqzGm8EoFo/NeeoiRMuDMiDYUbGf?= =?us-ascii?Q?mDyAARyCSQr7J/kNiiyuUdtPJYc5+Xq5Y95juPt0Fap2lJ1iScqwzcbmvwlw?= =?us-ascii?Q?XAD2JnjFk03fbXoAI0q5MsGvOcslBoiyI3pO/ifyDED2D2qf42df+cEIuhFN?= =?us-ascii?Q?J8DJ8V7O5gXq4vuRJiF32h/dAVgw3luigUFlFocGQpvayOu1Xh86dAZ5m9zK?= =?us-ascii?Q?pQUhjPmnReaFacnX/4I2L5ZYTphbnV8kj9pipBLBtob+4/o/A0+PtwtvXx2u?= =?us-ascii?Q?SuLw1hEOvU21oMcE79RBIqpnony9eR3Cl87DgJy7C/d95qYO62Yn8Vd0WoXm?= =?us-ascii?Q?wMkFbdUiUWhbGlyjcorSExUw/2bsauB5tMC/0T5yeB26RvK5/0o0QKx2z9wP?= =?us-ascii?Q?Yk91uRL07vJK5ef2ghIsD/ZB7FGTSg8yBlOGTnTm8fne4mzQMpCLAAQymd3W?= =?us-ascii?Q?VA/jD6fO8NilQb6B5KiKJjViVIes0rlVZ5dRi0zb1nhYDl/+eIOsN1dHJXAl?= =?us-ascii?Q?1yzd8TTDKio52KiIiDnjG8DweLIiAoCVXRo+5h2ZTZb2qAhG3BMC+VLQV7dr?= =?us-ascii?Q?XvJF3sZlgaImZ7wG75vVW8AKKB1OCM4pIbghY5Qp6X0f83NSEAbQU54JyhSo?= =?us-ascii?Q?kGcZLJNj0aJFqlRyx9VW+ObsNV+E+3boUGZm/AH950VQMVFBSmj0P2NUPS0C?= =?us-ascii?Q?YgmlvWF+PpveMuePW1T4UK16oLKKqhKL08pzQ5FG7nL1QtmURF8lpK9yIso+?= =?us-ascii?Q?ibZ92NbyLwSkdUdEYt9eF7rz0aI19/FJNYU7LYoOX04VZEP18pAZMxRYcuEA?= =?us-ascii?Q?dwKV25NV5rFoJX8psMu4P5endsaWlMTynrdXS4PZihbjDmD/ZsLh1nANE9C3?= =?us-ascii?Q?CqgXfb/COQdP9IgVSWUaNNkSnIAnzS1tnktn2h4Ybd6JrmuSZJHr7zXkfzf5?= =?us-ascii?Q?XmzD4zHuFVlyYlVucki5xhIEzvjikNjaE39M0nCCWhfxdctw8qqgEBKrvUZL?= =?us-ascii?Q?5/ZmrFgqz221wwuf54gLahvQWhcAiM3kepbjfGe9noxQfA7dtM+E1l4sNSX3?= =?us-ascii?Q?JiZQCwhV0Q1A6FMYWRNs76t+k+xptMEs3EZTeJC58JbJs48cObvZJQpoUwr1?= =?us-ascii?Q?tJ/2gUj7P/L1YtZrqyPluikZgt8ia6cy0pH8?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 18:01:13.4342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf3192b5-7af2-4267-3a41-08ddb3491bbe X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6244 Content-Type: text/plain; charset="utf-8" The hugepage test cases of iommufd_dirty_tracking have the 64MB and 128MB coverages. Both of them are smaller than the default hugepage size 512MB, when CONFIG_PAGE_SIZE_64KB=3Dy. However, these test cases have a variant of using huge pages, which would mmap(MAP_HUGETLB) using these smaller sizes than the system hugepag size. This results in the kernel aligning up the smaller size to 512MB. If a memory was located between the upper 64/128MB size boundary and the hugepage 512MB boundary, it would get wiped out: https://lore.kernel.org/all/aEoUhPYIAizTLADq@nvidia.com/ Given that this aligning up behavior is well documented, we have no choice but to allocate a hugepage aligned size to avoid this unintended wipe out. Instead of relying on the kernel's internal force alignment, pass the same size to posix_memalign() and map(). Also, fix the FIXTURE_TEARDOWN() misusing munmap() to free the memory from posix_memalign(), as munmap() doesn't destroy the allocator meta data. So, call free() instead. Fixes: a9af47e382a4 ("iommufd/selftest: Test IOMMU_HWPT_GET_DIRTY_BITMAP") Cc: stable@vger.kernel.org Suggested-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- tools/testing/selftests/iommu/iommufd.c | 30 +++++++++++++++++-------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selfte= sts/iommu/iommufd.c index 1a8e85afe9aa..e7eb11a94034 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -2008,6 +2008,7 @@ FIXTURE_VARIANT(iommufd_dirty_tracking) =20 FIXTURE_SETUP(iommufd_dirty_tracking) { + size_t mmap_buffer_size; unsigned long size; int mmap_flags; void *vrc; @@ -2022,22 +2023,33 @@ FIXTURE_SETUP(iommufd_dirty_tracking) self->fd =3D open("/dev/iommu", O_RDWR); ASSERT_NE(-1, self->fd); =20 - rc =3D posix_memalign(&self->buffer, HUGEPAGE_SIZE, variant->buffer_size); - if (rc || !self->buffer) { - SKIP(return, "Skipping buffer_size=3D%lu due to errno=3D%d", - variant->buffer_size, rc); - } - mmap_flags =3D MAP_SHARED | MAP_ANONYMOUS | MAP_FIXED; + mmap_buffer_size =3D variant->buffer_size; if (variant->hugepages) { /* * MAP_POPULATE will cause the kernel to fail mmap if THPs are * not available. */ mmap_flags |=3D MAP_HUGETLB | MAP_POPULATE; + + /* + * Allocation must be aligned to the HUGEPAGE_SIZE, because the + * following mmap() will automatically align the length to be a + * multiple of the underlying huge page size. Failing to do the + * same at this allocation will result in a memory overwrite by + * the mmap(). + */ + if (mmap_buffer_size < HUGEPAGE_SIZE) + mmap_buffer_size =3D HUGEPAGE_SIZE; + } + + rc =3D posix_memalign(&self->buffer, HUGEPAGE_SIZE, mmap_buffer_size); + if (rc || !self->buffer) { + SKIP(return, "Skipping buffer_size=3D%lu due to errno=3D%d", + mmap_buffer_size, rc); } assert((uintptr_t)self->buffer % HUGEPAGE_SIZE =3D=3D 0); - vrc =3D mmap(self->buffer, variant->buffer_size, PROT_READ | PROT_WRITE, + vrc =3D mmap(self->buffer, mmap_buffer_size, PROT_READ | PROT_WRITE, mmap_flags, -1, 0); assert(vrc =3D=3D self->buffer); =20 @@ -2066,8 +2078,8 @@ FIXTURE_SETUP(iommufd_dirty_tracking) =20 FIXTURE_TEARDOWN(iommufd_dirty_tracking) { - munmap(self->buffer, variant->buffer_size); - munmap(self->bitmap, DIV_ROUND_UP(self->bitmap_size, BITS_PER_BYTE)); + free(self->buffer); + free(self->bitmap); teardown_iommufd(self->fd, _metadata); } =20 --=20 2.43.0 From nobody Wed Oct 8 20:42:08 2025 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2046.outbound.protection.outlook.com [40.107.236.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B032E62C0; Tue, 24 Jun 2025 18:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750788084; cv=fail; b=cIdLwbp/3l3FReZ7Z/+nelUWzLz9O9q+Uj878Cl4OOpdo/Ii+qJ6wZVe2L8LHjv837FQt2Pky90Z3euEBKT/kLk0MhmSKNdH2PWdii27KdFWPzeAgUDOXt65MzC58rhiTyAu1YyYv9abRhO6m109ifyCr6g0tjBRSTSeSCtxQRE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750788084; c=relaxed/simple; bh=5Ni1NPGOZyphDijmrGiWL02+n+JStbd1ojfNKZM4snE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AyCq5l3T3c1tVBa9gFp5xiMJYctCxLu6GpLNxawNe4MFYIX9+DrzK1/SK9NzexEoxnVJVX6ni3FUTcgeZI7wmyr2B06EI09V2DubZkljRclaUFgQiznER24fPceWauENfx8acBvnJv4geuOGHrkD2sIcvBxL0gMMfxx2JqJEXlg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Tvhewtu3; arc=fail smtp.client-ip=40.107.236.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Tvhewtu3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oiRGp95/E8aEwDDPjax3tFFAmfoOhf2brDFE/f34NmEaN9e+Gr0umZgNCftDZSKRn7Oh9xQRS9h1Qgv4vcqGO8+BfsQKOduHzVCYuImoW7ikAbg4Uj5McK0n3gPBMRhlV+YtZMbDVBFFWCkdkwmP8JCI8+NnJF65PN4ky/rN0BdBbpsQPSh9f38+2UrZxeWMhGcLTFj1KYVJxek2VA1162ef7lLOQrM5AmAuuWdZ4a0l5ZkHmDfFc5KNwA2UcMyPX9m2NUYVQo/LLwrQIk1rAmQAK5rbtGxjLD1VkKF/onl6pWV/UO3ZUr5hlWTq+viLF1/5FbpNewRkNNOsovkMaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1OJ4ofSmuBRIzTl6zbVagr21vkH7GdeC4IfLtIIPLck=; b=HhXkOPs8F/VI7fT8H/mR6Q+Cjo7dwf4QtAxCITCyliR3N2L1pfiKMKF0Sj0LqwhCPlm6bcbbSpBfPGTQtWX1TKZ6V76IKd2QtabvuMCiXIbd/HR8id0OSXioOLaG3yxomDPQGju8GkjfuZDoHGTBZkupA4b15WyRjfIV7Mz79bxIHdH0nOsPQBh5Uv4gpDAqzcAvos7ESj0JrELQjANaM920DN+GGoTVK2JE0zWpRBF/+j//YiHezI8mdaZP6bL6ODvPMU7E0Fqr4oP4y9Os4K7nrf0DQT/HhvqytFlFSs8xok9CTGGdeOjbt6wcAvzAm5eVcq+6iuVQrfWKV6GgxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1OJ4ofSmuBRIzTl6zbVagr21vkH7GdeC4IfLtIIPLck=; b=Tvhewtu3BG2wY9uHP8xtr8DtKpWrPpM+a7CrkR6UJU4dzAQtl5cBT/eCj03oHSPnxGiwtYFYljNWwwM7gT67bymgK4tO/shS/ooYbeMCclvR3540PlXGeX23V0bGbcIzPrgITdzMj3ODd5ZuSIw5D3t1cvPOIvVhxY+Y6/+9Xhxx/toJpEgwy1Q/X8pDd1qKCagJdd+0YlV3PqEPd1iutOSnkS4I3ZLpc+EqVRRzB63UQh0A8Nf4+mxykFtv4Fs6V6Z+dBRtZ2/KAXfkJGanjSdOv2EP8sIZPmQtZN1kMgIy5cuT/H/aVSJgQu/MUxO/EHhSE+Z2PH2mrbsZnmCDTQ== Received: from CH0PR03CA0376.namprd03.prod.outlook.com (2603:10b6:610:119::23) by CH3PR12MB8356.namprd12.prod.outlook.com (2603:10b6:610:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Tue, 24 Jun 2025 18:01:15 +0000 Received: from CH1PEPF0000A349.namprd04.prod.outlook.com (2603:10b6:610:119:cafe::99) by CH0PR03CA0376.outlook.office365.com (2603:10b6:610:119::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.29 via Frontend Transport; Tue, 24 Jun 2025 18:01:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH1PEPF0000A349.mail.protection.outlook.com (10.167.244.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 18:01:15 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Jun 2025 11:00:57 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 24 Jun 2025 11:00:57 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 24 Jun 2025 11:00:56 -0700 From: Nicolin Chen To: , CC: , , , , , , Subject: [PATCH rc v2 2/4] iommufd/selftest: Add missing close(mfd) in memfd_mmap() Date: Tue, 24 Jun 2025 11:00:46 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A349:EE_|CH3PR12MB8356:EE_ X-MS-Office365-Filtering-Correlation-Id: ff7addf7-ecf1-4c78-87cb-08ddb3491ce3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3E5K4QhUnconqACVDQwcciOcCkBEn/WzinqQ6J9XSBg/yMhDA+L5654vtys1?= =?us-ascii?Q?hyUtZuygShHnfZg/WQuOhS1u/FzwQ/K2w4oTxur77lpM40wymiXHihoKgmGF?= =?us-ascii?Q?ITaSXn+XbsaQeITUqHnJBBHiTBRnbxHOJielsCXQM8beKNOx5PSJFslrvNus?= =?us-ascii?Q?0jRbW4LsUfswLYwrl6vebp7vaM2K1xL91dhcek0KSssEhtl9906Uc/oEuz2G?= =?us-ascii?Q?hamGNOTZ69FVUh1kn9Aea+vu+ODSq4Ia7ZtNi2Zs/PgPCg5TQfcWKgp6r0ps?= =?us-ascii?Q?8ruJsHcVSOWKu1O0Ny4mtE8P8jgRgn418fycMTcpk7q3ndpZYQ4R4B2fR4QL?= =?us-ascii?Q?v0cXBMzhIBVF940zkAy2nYBrMFtZtffcJwj13LSoX6rjfsJ24+1iq9t4cMLW?= =?us-ascii?Q?I6b6ceDQirof4QqooGPq/njSBOOZSKMhY9UrBLD5Utqw3Y+y1STEAMr3qtHT?= =?us-ascii?Q?Bic1kzzNvt5+idwDukapMixiqFwN2+UyE04xr7YXtB6hJ+b83XM1gbAJakrA?= =?us-ascii?Q?FM4LSZoZkMc3y3WnkvTNs8eXSuLWCQp01a5hsbgLNOuVDtJvVB3sUu4a0rDi?= =?us-ascii?Q?qU+jZ0VZu0qq9rXY8oVtsmZosO8fbv7gDE7sLh6yjc3xNUzMbQbQs31e5EQ3?= =?us-ascii?Q?RvraN32UNiQxNpGs7GEOKf9E0xysrvIY21t49vEWB+F4Ov1vAzanRVI4+GIu?= =?us-ascii?Q?6e2aA1O5LATpp4vJsxQOpmcNHQkuknskv6EOMdF4eOV5hv/5BLz/8mx+W6FX?= =?us-ascii?Q?kXDUj/zhAg07rvyJ641cG3gODYafDll1c9raWxDTRTDgp6bUT683esa0MLZD?= =?us-ascii?Q?kyIHbv2E00NAyLUTwizy+ef00tIulGtmRDNxhLjegrKwalIX9cV5IC/g/6sD?= =?us-ascii?Q?cvtGUiIPgRYJOyV0TRGiNLQV+NKgOaPYanPxtfoAzJVNLEYus1WHGRZtpAx8?= =?us-ascii?Q?DR/t0OTSXqVIJ3++37Y8rNe7O+Zeq7QYE5mr6n8D/wqJ4UrHqhmhxnB/Ober?= =?us-ascii?Q?SqA/qvLgXOcKiZimgMXLdWKRjWVeFskBc+Zos+REqagzIm013l8/8uKCR0u0?= =?us-ascii?Q?lzTtEThjgKbj4x3g18EDAAI5w1Ms9j6uG5LSs1fP4UnB/ufaLFWFdLNiJoYW?= =?us-ascii?Q?EcC/Jgb3s8hgHjWedy5V50aayBwxs64bIvh6Bw1MWEC03X9AefGhYEi7JL3O?= =?us-ascii?Q?yGxX7J5wOQEhGPoeH0VLYSV0w5/ltRde7r4SilbQq/SKgAL72zdjsKoPHfru?= =?us-ascii?Q?RmJ4dJF1LWnfllaxaom/jETCyH7lvovN4FV2+x0+LMLwMsIKhfy0VhJ+3Azi?= =?us-ascii?Q?QuAwvqPLmWZkiB/7uFfTY6MFCVqHVEKNvoze9EHy521MzjiHC+p/rvYm2Uay?= =?us-ascii?Q?NfOdBMjBulGDxt3qNMfVEuD/jVjt9u4T2avw1KkKcn0Yq+/J1fyj+lYh/p4z?= =?us-ascii?Q?Ymbcxdny2LQGENQYX9GyBqdvQfOZbKzT1BuXLjLjcTfZ0gFi8A2NfEvHUvo9?= =?us-ascii?Q?wDItRMiGXDGm6ZG5EaUUQUJFlIGLNxfGLNyP?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 18:01:15.3587 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff7addf7-ecf1-4c78-87cb-08ddb3491ce3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A349.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8356 Content-Type: text/plain; charset="utf-8" Do not forget to close mfd in the error paths, since none of the callers would close it when ASSERT_NE(MAP_FAILED, buf) fails. Fixes: 0bcceb1f51c7 ("iommufd: Selftest coverage for IOMMU_IOAS_MAP_FILE") Cc: stable@vger.kernel.org Reviewed-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- tools/testing/selftests/iommu/iommufd_utils.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/iommu/iommufd_utils.h b/tools/testing/= selftests/iommu/iommufd_utils.h index 72f6636e5d90..6e967b58acfd 100644 --- a/tools/testing/selftests/iommu/iommufd_utils.h +++ b/tools/testing/selftests/iommu/iommufd_utils.h @@ -60,13 +60,18 @@ static inline void *memfd_mmap(size_t length, int prot,= int flags, int *mfd_p) { int mfd_flags =3D (flags & MAP_HUGETLB) ? MFD_HUGETLB : 0; int mfd =3D memfd_create("buffer", mfd_flags); + void *buf =3D MAP_FAILED; =20 if (mfd <=3D 0) return MAP_FAILED; if (ftruncate(mfd, length)) - return MAP_FAILED; + goto out; *mfd_p =3D mfd; - return mmap(0, length, prot, flags, mfd, 0); + buf =3D mmap(0, length, prot, flags, mfd, 0); +out: + if (buf =3D=3D MAP_FAILED) + close(mfd); + return buf; } =20 /* --=20 2.43.0 From nobody Wed Oct 8 20:42:08 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2068.outbound.protection.outlook.com [40.107.220.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B7772E6D0A; Tue, 24 Jun 2025 18:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750788082; cv=fail; b=o3ZdOJ7yvFb5K0EuunpWkoH5/+e2X00ZsCVrvdVwxPbJf3koVgMTpalIf+w9EKddUoPo48IyGw7Z9/qOz/XcBTPQYLgpkiGSjQwSyMA5IMRVgp7ey6/0BI6rPUDP9wyNbE9T6Ql+1Ul2illG/zfW774doxuVGUvPUg6M9xgcYFQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750788082; c=relaxed/simple; bh=04XyxQRRzBQgOjR8cKmgIdi5k3igOXkg/sbPwAYnLgY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fymwiMp2WgX6qtEWXZg7AhQlNzurVnJlbFm10+Kn9u0nRc8Q0DoELc2XdZ6GizBIPQLLal9Z3nVpozHU4P2tnNeftBO68WGmYhcwE2ArIKiyLYHIjNhz5iGyWc7TBtggD+qcTZiJrUGNznyQVQlGhOX4N4+ea9IrF/jphG7nWZk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=FD9ZsdbQ; arc=fail smtp.client-ip=40.107.220.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="FD9ZsdbQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gI7RHBZWl121ZIEjikcKcMmYzsl2RoZhMmniC+y+9HtwG68BfzqUPCFguvUEOQG6HvVJgumJ3t/If0GB0AGYHWY8flDAaWQLHy17bb44+Jdf0oQTKUE1qtScdshg7TkubJ+qCBf+2isYGvsGX39WQsPmNeE+ZLIqCHmbYB9EIPYvgD4sOwRYpy2spoeRM+b0SV6xEjLD44Tjrtd3Uu41H5IOWj9Vgh95LJ8DhxjrdANlIkwnOUjHWNJc1gRto0vqTTxeFm+Fd2fCqWBK2f2U7+Lqff+o5r+Gb9Sfp2WzAN/nFAAruMnUBU7yZ0QrE9FACozc0IoArp7zMw4eTBNn6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eyoNO4gaYX+hc5AQGo86sv7hmN1Ryh0s3yIV8ODIPwI=; b=hmnX2qVBHVjT1g6SDQASNTEbk0GGFw9fArmxMTqhbHszLPa7z098EgNaDHKRIeo014p7YJwbKBbKmnElKcnhB9AoZBmFoWm7l6Sb6E83s+i2M2ecET1t+DXz0E8ccnREXFWXBU4v1fVNgiEQ9lJWJl/L8kXozU94ncNofJg4I/9zuI4W5XeokIy797BvUwwtDsg7oVhJez5+sQVxiBtSdsfUTV4OtGuLVkqQ2sFJ8f4JHm0X+e1CU7xTp1MIxnu+cm2RXiyrbPxEpO67Z4xA0+ekO0ZkflhYTkAKirlnLqT2DgDhzFBJF9Wv5iEZIhCdon/PSmeiSDv128MEg4Qx0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eyoNO4gaYX+hc5AQGo86sv7hmN1Ryh0s3yIV8ODIPwI=; b=FD9ZsdbQSdl2l2sRJsJFVu26HmcL6KCvDSJLoTQUmVReZWXFc+1axHu3gvytnE+gDHwCnGMN17IDLik4+JH9hceNcaiJlBDIRsaebBpgx8AzuTFxvV+4PW0Y/R9Zh2Bi6ZHFsuyFM19Xd4qSAukw/7CWWLIzLKMle4znpDozFoiF0HltbwVoY2MwIPXAafRE0v9e2v4FHcioUWwAcvhy+V2WKPxZ2q0OYKXmNIpSJ8+cxBZJzxdYqxSowyt/IjBvOB1PC6IEkMgSgxSRPo7N2eBnXfyWB/O26nwxheBeOewKq224mzEx+vAnTcOlrpfzY86StyDtOIVjmua/M4d7Xw== Received: from CH0PR03CA0314.namprd03.prod.outlook.com (2603:10b6:610:118::29) by IA1PR12MB8336.namprd12.prod.outlook.com (2603:10b6:208:3fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.30; Tue, 24 Jun 2025 18:01:18 +0000 Received: from CH1PEPF0000A34A.namprd04.prod.outlook.com (2603:10b6:610:118:cafe::d9) by CH0PR03CA0314.outlook.office365.com (2603:10b6:610:118::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.30 via Frontend Transport; Tue, 24 Jun 2025 18:01:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH1PEPF0000A34A.mail.protection.outlook.com (10.167.244.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 18:01:18 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Jun 2025 11:01:01 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 24 Jun 2025 11:00:58 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 24 Jun 2025 11:00:57 -0700 From: Nicolin Chen To: , CC: , , , , , , Subject: [PATCH rc v2 3/4] iommufd/selftest: Add asserts testing global mfd Date: Tue, 24 Jun 2025 11:00:47 -0700 Message-ID: <94bdc11d2b6d5db337b1361c5e5fce0ed494bb40.1750787928.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34A:EE_|IA1PR12MB8336:EE_ X-MS-Office365-Filtering-Correlation-Id: c93a3696-08b9-4e1e-89d8-08ddb3491eba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZwuBzFT/GytY/cocdRlvG8rhKRkj4MdtBCQqp+ZJSMOvxBF7JOGCkwxMxxPr?= =?us-ascii?Q?u0kz7QR093VpvMi3WsybeY0kPtGzpiEvMhk/FK2jt/ZsftLCRu7A4EYVPt+y?= =?us-ascii?Q?5oBLaMcqb+KrLCbZuswwzVhbKEAbKvX5Z+FWjWoLXpAnHH+HJMubleUfuLjO?= =?us-ascii?Q?4uC4u32HoTIpiRX6fiz4PTvYZdnGiRDldsgb7HIdR56fz2aiovewgrV4H4kh?= =?us-ascii?Q?lmF1asRClT8764Eop36V9xoP79FxxJlGAyyKiI2MXDi0So08uSKG5WJLOrdH?= =?us-ascii?Q?XMP+MuqizXVW5EFWgLmIV0X5hzIb5GAid/RZWbVjX9G0qS8LXOO5GUe8kEml?= =?us-ascii?Q?3nPCDD4uMT4QMDk1ceMvXnKcrD9NAhtSlI7R5EOkMxSFwsd4QS1wLLNLE7FJ?= =?us-ascii?Q?4XvXJOU0c5GB2mlvqQPJHyeQoTy0N1FGK86ofBCIozg9GnPab+qZdr3Tld+s?= =?us-ascii?Q?9g7LKqfOex2cpH7kvUFW6b/LsOp/3qh++RtVMAIC4IgRs+GXpLIAb66fN2Xd?= =?us-ascii?Q?sPLsoUT1zHz+i/jBepe02Vw1h8zB/67GEKQKZ1e+wKNnCQlaYFP+PKqq3b60?= =?us-ascii?Q?nK5JiRH1323/OAkepR6/C7LGcDzN6MCTUm+pYZGmN8awQGPgsIH5KLyqjzPe?= =?us-ascii?Q?VdTqfaiUpiOssh09uH9wMKnkPR75M0HUnTzBXygYJRi3s1jwIx6Mq8RSgOIr?= =?us-ascii?Q?AEnO8F8UgJE/zLtkPvM8gU1Ony5nDdEVyk2kN0bTDGuttNVSVeGjqfJHzt3M?= =?us-ascii?Q?DP9vRv9qkgAkaq9byEleA3ukn9FXiNe+77K+KKiKrhHgjX0A1Ug+SMFLvarN?= =?us-ascii?Q?JAaXBVGG54KNRhw6rGDr5XOx2uKVhq0Yh4KihoZHh/axn7S7U24oWPJlcK7C?= =?us-ascii?Q?guwkhUXqv0aUQi8guhdoLB+5vRbVGFG7xnzOQtglCjifvCALzbKjzYqE2YkU?= =?us-ascii?Q?l0d5O6jH214Jf0eIAMHzH3YTmaVCjT6SYOkf46RlSFnZaMi7SpuGpsHPP5WL?= =?us-ascii?Q?4qXyT5iwodnjwPrkslRxScEPKuNQGNTpPg4kbYdc8xT0uV+pso77CGvJSJRx?= =?us-ascii?Q?cyzIgHm5fLmppACt7NWZnPerUPxFq725Ike7Gr9fwgvPtljqNG9iE6MNV9gf?= =?us-ascii?Q?t/p3MYgeOb+UTaGsFFIbBFaKcLrsQi0uMTi8f2ypcAF1JstYTrGWXlbmKE5g?= =?us-ascii?Q?EFQZgfj8NouzKaw9ZJPfQNriksEz92RuXUY+sswQxdCGo5PcdB+z4NwG/RMS?= =?us-ascii?Q?BVNMW7SxYdayL1Y3U2+TMKbw3gaFy2gG9FqvJrxOfVFQY0jY89fUDSE0xRBO?= =?us-ascii?Q?nV0B8FtBTNxh8qJtER0DXdsGWvnzMTzcCe3xHRIoXSzRydoonyNyghEIeppI?= =?us-ascii?Q?48vocxq6PjI+n65dplr9Y2kBX9dOQGkWjNuj/xq2v0NTk7SSUwNAg8Zvw2Kp?= =?us-ascii?Q?3PYP1aDoY2u2qvesWVyGlr4sJ/91fWkOJYK+mGtj3kF0lJ1Ezx6Bzq9S0pOg?= =?us-ascii?Q?MC2WRysAf6fiHMLT7xpplDxUMJm8OKtSKsTP?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 18:01:18.4775 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c93a3696-08b9-4e1e-89d8-08ddb3491eba X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8336 Content-Type: text/plain; charset="utf-8" The mfd and mfd_buffer will be used in the tests directly without an extra check. Test them in setup_sizes() to ensure they are safe to use. Fixes: 0bcceb1f51c7 ("iommufd: Selftest coverage for IOMMU_IOAS_MAP_FILE") Cc: stable@vger.kernel.org Reviewed-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- tools/testing/selftests/iommu/iommufd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selfte= sts/iommu/iommufd.c index e7eb11a94034..e61218c0537f 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -54,6 +54,8 @@ static __attribute__((constructor)) void setup_sizes(void) =20 mfd_buffer =3D memfd_mmap(BUFFER_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, &mfd); + assert(mfd_buffer !=3D MAP_FAILED); + assert(mfd > 0); } =20 FIXTURE(iommufd) --=20 2.43.0 From nobody Wed Oct 8 20:42:08 2025 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2075.outbound.protection.outlook.com [40.107.95.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 755622E62B4; Tue, 24 Jun 2025 18:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.95.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750788081; cv=fail; b=VmWtWfyJXEUFtaUAwcT0DGf/ETimQ5y864JZpr3zB/m2SNUJPZHvc2VaBxRxUAxpKzKyRGseIj9PtJpIEibHH0/3KHvmNV1NNT2VNYTY1BXJfvTO8qc9yLqIQ4Tm0gHXhUDAWugEqleUTCbgAnGSPUR9MkuYTRB92aFGD8vZYXs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750788081; c=relaxed/simple; bh=NDrWzYLs/sVpu0wpMVhBQgK0rVuNLLymyqfGLVymFK8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZtzKxK1x//ipuq342xhYznX3xa7saDLj8QyLldnO2nKQHiqOSyUFEF2VbrDIfEhWUu0UBtgegikpzuxzfME61uf+gYH9Nx1u5RyeV0+YcEslaC3fBjdYIgz89zV6os2Sq3fIm99bcgpZ1mbPbDLydYih5cnfPsriZZjt+Y8A/2A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=OI9+R2Vl; arc=fail smtp.client-ip=40.107.95.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="OI9+R2Vl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kb1PJ1fDbg7/ZBUsuiW2lCNLL5NEwfWl+VYPgs0uw8QTRZ8LKDKx+qzIJH2dzcTB2F9k/UIOXi59exFV/1eE30u/3scKMLz1AeDP1rXHDSZ7WexUT4kOHYRWnhJgcE+IHEeXNSTAQKesO58paCeCcPzlh8JpHp7tej+bBRP6dHgJ7qqo89fZs5RjQ/WvULtVcM4/brFoD3RHRFOgldEjt/VlcsdxIHM9S8gA5cQXN+SfdoaZzN0Ycka55QrlMNOZ42LsW72W4dTSeCbgZK/lsIin23aWLLVyoFyz66AB1WEyB1HFzKpFRDgRmzGNSDEDRDIDuhNj2HmF5snTXQWv6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1zrbr380aOF0gMA7Rpl3Ua7BP0p/6lIPL/9qDHPyL0s=; b=YwK5imCSgbxkRF1F0OXXA/qVaXfrRl8HwKH6Pi65sKbGgYPV887F63Q6HzgW94CeU+GJaFtOePgSvQjuBUrs8zLkexxX6FdJDzh431mwW85WslySJ0Jl+2F5Qur7Asm/VBF07LLUOor23s6inlDriWxmzbBC6Am53+B/Xnu5wq/vSv0u0eFDwxihV5lbju4q9Ha89CLsn5mTSFabI0/zJzR75djiUS+sRbexrxeKH8bO+FVlQewHdctCzKcpqFUeU4+RkMsitsZOjs3VBvOGOT8OguYllp9OMwi3nINbbX7A4HvLjxPFKA6SAycG5Ed3XG8LuJXbGpnUZZnQvbD8jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1zrbr380aOF0gMA7Rpl3Ua7BP0p/6lIPL/9qDHPyL0s=; b=OI9+R2VlKmVaOLUSnA+8GhBP1QbqVIqJAe6YFyoV1zphonVa6tNaCnQhV2Jy9GcomBBDhCekDlaXYCuM7wErH4arJhfSD7PW3zdiyYwf+fTMcbFzERGC36TmQLStflnwslcWj0BbH5bO8MUoi1KhtdLJ64DTOqK5Ik/mxpW68/QN9EY9bIg2qDHIkrjC0OFXxyOKN5Fqu6Z+HxAUipB5rPwDRQJwTmDJZT9dZE2YppUoBqG6lUY9BRZFr1JvjUU5gKY5QtoDlfp6io514JVmqVM/hq/N/mnhMQWiRMu6HhNXYhREc30hDTTMgXi8+PnE+M9YQ3O6dhd9ACnjBJH1Bg== Received: from SJ0PR05CA0110.namprd05.prod.outlook.com (2603:10b6:a03:334::25) by SJ5PPF4C62B9E70.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::991) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.40; Tue, 24 Jun 2025 18:01:16 +0000 Received: from SJ5PEPF000001ED.namprd05.prod.outlook.com (2603:10b6:a03:334:cafe::d9) by SJ0PR05CA0110.outlook.office365.com (2603:10b6:a03:334::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.16 via Frontend Transport; Tue, 24 Jun 2025 18:01:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001ED.mail.protection.outlook.com (10.167.242.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Tue, 24 Jun 2025 18:01:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Jun 2025 11:00:59 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 24 Jun 2025 11:00:59 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 24 Jun 2025 11:00:58 -0700 From: Nicolin Chen To: , CC: , , , , , , Subject: [PATCH rc v2 4/4] iommufd/selftest: Fix build warnings due to uninitialized mfd Date: Tue, 24 Jun 2025 11:00:48 -0700 Message-ID: <6951d85d5cd34cbf22abab7714542654e63ecc44.1750787928.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001ED:EE_|SJ5PPF4C62B9E70:EE_ X-MS-Office365-Filtering-Correlation-Id: 06411a2e-576d-4401-cd60-08ddb3491d57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bmxtTDVIczN6V3ZJcWFOcnhzQnlJU3hhRHB4VWJZR3lLWU02a2tvNEpwRS9o?= =?utf-8?B?aVhsMDB4eWUrRjZMYlRUbVllWXJjc1pna2pacHFPNnZ3Nm9nUHFaRUp6c1dM?= =?utf-8?B?ejkyc0xjZ2Y2bGFBSFM5UEJ0R1habEJBamZqNlRWWjEyZ25rNEdSdGl1RzhF?= =?utf-8?B?bWdhdlRQdlhIajRQL2o0aitERDN3cXAxMHVDa2pXNHdNN3NyeWgzcFdxMWkv?= =?utf-8?B?YzZ2Z2VYT1V2NTZhYlN2dkFqUE5HQWpFNHdSNjNlSTdZWW4xTkE0eWJqbmdT?= =?utf-8?B?ZzBtbzV3dE02TDZWWjVqTW90Q2w1ZURnYnlRU0NDVlFLc0hMVlhjRCtCNXFP?= =?utf-8?B?bWdUNDkrUVR6YUtvV0dVUFM0ZTFtUFJSYnp0SzBVTmtkL0wwV2Fma2pJcFR4?= =?utf-8?B?STdHZzdzZnd5Nks0RU5wYnBlR0thWFBldmI2TUlteDc0M0JEdlg5U0ZnSCtQ?= =?utf-8?B?aWFxTlZ4U1hQYVBzOVdwZE1YWWxCMzl4WGRFR3JRN0UyeGxkMkNTZ0dQcXo0?= =?utf-8?B?emNpbU5kMkJTL0o1VHpEQm9KTVBnMm5NYk1pa1hnRWt5WWJyNnZZY0tpeDg0?= =?utf-8?B?U3BKanQ0Z1NRMC94V0doWXpTSCtORk15R3hlZzRVYkVFQi9oamxFanFhQm5R?= =?utf-8?B?L1U5SU05VElMWjl5NXlKd09RU0NFd29mNjM5bDlCM1BWVmhVVnMzNGNGVmM3?= =?utf-8?B?cW1FNk5RT3pFTmMxeEZsS1ZvRG1Rdnowc3BTcDZOUmk1NkFUTm9sSUNTWHA5?= =?utf-8?B?QUM0NS90Szk1QTBrSkQ5VFVFL2tXS1E3b1hZWVg2akVGVFVoSGY4VldGUzFP?= =?utf-8?B?eVpYY0Fic3NYRG1zVmxZUll3c25mMHVSNWFFNkJCdWQyY1c1TWRWcGRkMFBx?= =?utf-8?B?azkvSHhJYktrOXljVlkxUHdzektkVExKUzJCaWRnejR3NlNxTFRGREMyeENL?= =?utf-8?B?ZExBWkNVU3FUWGxCbjh4SjRGMzRWRlJMVlRlcG4vVzh0ZDE3SkhtOVFiV24x?= =?utf-8?B?WVp1Snpsc0V4TDhqVEdLUFIrMWppV0tkTVhZN0dtUGtXQlVKeWc0WUlRWTRr?= =?utf-8?B?R28yVDRmL0NFenlRWUl6b3hiWlEyNUtTNzJhcXd5NFJTSG4rNG91QVBEaThH?= =?utf-8?B?K2lrZjNGcUl2TVdvb21xd0NZVmNMUjZpQmwvQS8wK05xRWtlb0JpZ3BUR2hF?= =?utf-8?B?R2tpL1NqSVlDN25MMjJBQUdLQ3ZXWGRsZjA3WVdMWmp5VkNIaUwrRTRwR1RC?= =?utf-8?B?cUhycmpPeEVwQ0tiZlNxR3BkQ0txMXZZVFBEZmJGTGNTUXQ2L0E4UE0ySExP?= =?utf-8?B?ZG8wREVHeHdzWjZwQWlRK1RJTmVMeWFLRU9LV0hCelVsbWgvdkRvSDVLNmhS?= =?utf-8?B?a3hTbituZDhUUGtvaVd0L1ZnN1lpdXZDT3N6N2RGVHlQeW5RTVVLZHVtcEdD?= =?utf-8?B?SldDa042bHI3di9FS3BhYUpqVUs3NXd0eFVnamErU1FjR0YzZVZobkVhbG1X?= =?utf-8?B?cHhqRldmUXY0UzhoL1ZQV0toV0VrQXNCNW5GRVBqbnNJOFFWZ2xpUU4rT1ox?= =?utf-8?B?WnZ1SVU1M0loQ3hnZFdsdy90ZnZZZGpSL1NrSjRKS0hremV2eWZvazNmZlQ5?= =?utf-8?B?SHA2c3RiTkI5V2hYUUlvZGdQZnJsa0ExZ2QwS0NwUkNmRUU0eVI4NWRHUVdu?= =?utf-8?B?ZGJWV2NrcjQwQk1USmVOY2daUGt3MmVGQTIvREFmd1dSUG5BUUlRVXhxUU5D?= =?utf-8?B?WDRPY0lPbGx3cUVZb2lJY2p6ZFpsa2JGazIwL2Zta2RQWDBPOVJ1T2ZKY0F4?= =?utf-8?B?M2FIT3BqNmJjSEhJZ1VnZjNoWDk3VENBZzlFN0Njd0JGbzgxcVUxbUxKaGFW?= =?utf-8?B?NDlNY1BnbllyaEg1b1V4cGUvN3o0blEzd0txazlBN0ZOdDIxSFFTcEd6aTg3?= =?utf-8?B?ZnBxeEVjZkJwUUR3SlUxdXYzNTVRUFlWcWZuUjd1Tm0zd21wVm5YUVdvVlJM?= =?utf-8?B?dURDMWtHN2FWOTQrVEVCZFRjU1pFQkxwak5VQXNNREpoU2VzRm9UY3FuUzdl?= =?utf-8?B?QlAvVVBEN25ORkYyNmhmMllHcTJDaVNnM0VDUT09?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2025 18:01:16.2021 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06411a2e-576d-4401-cd60-08ddb3491d57 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001ED.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF4C62B9E70 Commit 869c788909b9 ("selftests: harness: Stop using setjmp()/longjmp()") changed the harness structure. For some unknown reason, two build warnings occur to the iommufd selftest: iommufd.c: In function =E2=80=98wrapper_iommufd_mock_domain_all_aligns=E2= =80=99: iommufd.c:1807:17: warning: =E2=80=98mfd=E2=80=99 may be used uninitialized= in this function 1807 | close(mfd); | ^~~~~~~~~~ iommufd.c:1767:13: note: =E2=80=98mfd=E2=80=99 was declared here 1767 | int mfd; | ^~~ iommufd.c: In function =E2=80=98wrapper_iommufd_mock_domain_all_aligns_copy= =E2=80=99: iommufd.c:1870:17: warning: =E2=80=98mfd=E2=80=99 may be used uninitialized= in this function 1870 | close(mfd); | ^~~~~~~~~~ iommufd.c:1819:13: note: =E2=80=98mfd=E2=80=99 was declared here 1819 | int mfd; | ^~~ All the mfd have been used in the variant->file path only, so it's likely a false alarm. FWIW, the commit mentioned above does not cause this, yet it might affect gcc in a certain way that resulted in the warnings. It is also found that ading a dummy setjmp (which doesn't make sense) could mute the warnings: https://lore.kernel.org/all/aEi8DV+ReF3v3Rlf@nvidia.com/ The job of this selftest is to catch kernel bug, while such warnings will unlikely disrupt its role. Mute the warning by force initializing the mfd and add an ASSERT_GT(). Reviewed-by: Jason Gunthorpe Signed-off-by: Nicolin Chen --- tools/testing/selftests/iommu/iommufd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selfte= sts/iommu/iommufd.c index e61218c0537f..1926ef6b40ab 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -1748,13 +1748,15 @@ TEST_F(iommufd_mock_domain, all_aligns) unsigned int end; uint8_t *buf; int prot =3D PROT_READ | PROT_WRITE; - int mfd; + int mfd =3D -1; =20 if (variant->file) buf =3D memfd_mmap(buf_size, prot, MAP_SHARED, &mfd); else buf =3D mmap(0, buf_size, prot, self->mmap_flags, -1, 0); ASSERT_NE(MAP_FAILED, buf); + if (variant->file) + ASSERT_GT(mfd, 0); check_refs(buf, buf_size, 0); =20 /* @@ -1800,13 +1802,15 @@ TEST_F(iommufd_mock_domain, all_aligns_copy) unsigned int end; uint8_t *buf; int prot =3D PROT_READ | PROT_WRITE; - int mfd; + int mfd =3D -1; =20 if (variant->file) buf =3D memfd_mmap(buf_size, prot, MAP_SHARED, &mfd); else buf =3D mmap(0, buf_size, prot, self->mmap_flags, -1, 0); ASSERT_NE(MAP_FAILED, buf); + if (variant->file) + ASSERT_GT(mfd, 0); check_refs(buf, buf_size, 0); =20 /* --=20 2.43.0