From nobody Thu Oct 9 02:12:59 2025 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C88F2433AD; Sat, 21 Jun 2025 01:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750470503; cv=none; b=fkjdnKeynNmtM5q0lXs3/NRDpgH49uo5D25zH8XwkKmvkn9vlEYGQdmaYxEzgBvYiVXAdiM+/TcfSiYLCcFjPDNSwGYePQHud/fzkv7YaiQNeINiZwPli/51UAFmih/2s46ET5ii2LQROpMd1VQRarCpzUGLIXlUAZXS4VnCh5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750470503; c=relaxed/simple; bh=tpbE2FvztANs2/izJnOECYoMP2X5oOScRQHxOIydI1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TeWBaZdwgaMsH0D/ommJ9rcHQo46/NLuqLJYFJivtLLuQZ1/Bea/3nDN6nEJpdPM055FL4bIIIQEtgHr0YxiH4YucvtuPu8N51uZXJpi6C3g4ndCkRB3XrZ8n6XSroX4HjUedzb2UB588I/xk7MeHOMQWwt851nwKHOk5MxYMgs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OBrsiraU; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OBrsiraU" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-73c17c770a7so2878952b3a.2; Fri, 20 Jun 2025 18:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750470501; x=1751075301; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mt5O7/7JEumjsAyKxjvlFipcH+4/5yB2S8im+OQhNPo=; b=OBrsiraUQLBH/mPseDkGNvVWPz2NpsCovbF+1v4lzrDGsxpwaVBMc1C3guOWlNHsgd WvLzexv3Qi+m5HE2xgM6qolGOrz7K/DQgNfyy3UNwN3TbM/Dga/1s6wTz9AfGleBuEoX crIodB1SFLiXupVLTjtKTnpdtKfV6PNC2U8zBrZe74FIHed/GFcFappsVzG16zNOV13B h090s9prAdvSQhVXIlpwkj/avxZws6PjGcb1S/siVIe8nQIrZNDLyk0QsiGrEtfh5cgD m7QhvrOw0cNWQ4HCArTMsJ1WSb0bVdckAgXbDg4XxBQdllwwA/dEKwaVxbdw1d1cqjgO 90Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750470501; x=1751075301; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mt5O7/7JEumjsAyKxjvlFipcH+4/5yB2S8im+OQhNPo=; b=YQy//8APw27doNSgFxurVkvgX0NZiyQMpydgU4ZKvsMPiR2qPVY7flg0CMlOpMzx1M CM5nqTg9EtggHkXjNt3cSuBPqb7IlMZTe4t9zyfpgV/cHGgkkwRNnM6WDm/750gTBk5l X4Om+BRb58lUbMGLi6ptPjGiDBCM3eCl83wsYR1xQKkDRl2TE70ZdPk+GmD+wHQKRbmk qWPA6qUCJwal7ErOTJfmhrwlouzt2Pm0WAYvziEHAv3jO53WGqh/bC7hoENAN28R8BVl EKvCsfBOgUM95fwOVbf6V/6qXshRpY69Vl6qD8dkHIfQehVEj3CICg/nTTAFR2nr/TbU /BMQ== X-Forwarded-Encrypted: i=1; AJvYcCU9+TK42jKPj1f+ja6aMaAxHnmZfLTRQNjz0KekbQOf7nkbuII7EQe4Qn61UONxjdCs96MMpBRid5lqLwo=@vger.kernel.org, AJvYcCWXBB0K/2VYGFj38/yNLeUWLF4xgWsGVh4a2OMLUHLGGcD04FoO1GxDbXEZ+CJl/5M2aofv7l+mvEw0@vger.kernel.org X-Gm-Message-State: AOJu0YyHj0gaUCMebaXcBzuQF1rugwFXitxJfCzeHSWIbh+KQmYc1LnG oQssjKm5VDtVebOQgcWK0kKJgGI5RrZMNS1f9m2tZgA6KndEH+ybZh2/6y2MIqve X-Gm-Gg: ASbGncsHqyIUF2RWGXpmuxhj/1v/rul5f4yoB4HrcD98/fkG1A6xcQ7k+NQ2F1n3gYG R8rDgBV0deLCi2+fCle2VpXvD7uzyILs80edjwsecGnY91rJy5FMZLcr3lCrOMABj5EsuawR933 r2D8PIOCRxyPx+S708vo9RSxNbreVUAtqKXlrhOfrQRR+KJMBz6P9ZHSg8yfMfDCS4TAEa9sexF A/A1cUfKEoHYIt5GEznqgxhbWc2g15PLDtZuhTQAjY6U7HzU9ceuYkOfUrRSttYbwMN53Fuc37Z i/ymWb43Did6EOy6qJk74QfJGqhvrBG2uv+VNWrtzN6mvBpbOQ== X-Google-Smtp-Source: AGHT+IFSIf+C/e7hFUiyQQukqnOF7HBTcNd1+R55n0mGf9AyKlyC7XKNh6w0Bnji3xf4KraprNdL+Q== X-Received: by 2002:a05:6a00:1a88:b0:748:2ac2:f8c3 with SMTP id d2e1a72fcca58-7490d6bf6d6mr7948158b3a.24.1750470500939; Fri, 20 Jun 2025 18:48:20 -0700 (PDT) Received: from geday ([2804:7f2:800b:d1c8::dead:c001]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7490a626eecsm3049052b3a.82.2025.06.20.18.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 18:48:20 -0700 (PDT) Date: Fri, 20 Jun 2025 22:48:14 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v6 1/4] PCI: rockchip: Use standard PCIe defines Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code uses custom-defined register offsets and bitfields for standard PCIe registers. Change to using standard PCIe defines. Since we are now using standard PCIe defines, drop unused custom-defined ones, which are now referenced from offset at added Capabilities Register. Suggested-By: Bjorn Helgaas Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-ep.c | 4 +- drivers/pci/controller/pcie-rockchip-host.c | 44 ++++++++++----------- drivers/pci/controller/pcie-rockchip.h | 12 +----- 3 files changed, 25 insertions(+), 35 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/contro= ller/pcie-rockchip-ep.c index 55416b8311dd..300cd85fa035 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -518,9 +518,9 @@ static void rockchip_pcie_ep_retrain_link(struct rockch= ip_pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_EP_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_EP_CONFIG_BASE + PCI_EXP_LNK= CTL); status |=3D PCI_EXP_LNKCTL_RL; - rockchip_pcie_write(rockchip, status, PCIE_EP_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_EP_CONFIG_BASE + PCI_EXP_LNKCT= L); } =20 static bool rockchip_pcie_ep_link_up(struct rockchip_pcie *rockchip) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index b9e7a8710cf0..65653218b9ab 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -40,18 +40,18 @@ static void rockchip_pcie_enable_bw_int(struct rockchip= _pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D (PCI_EXP_LNKCTL_LBMIE | PCI_EXP_LNKCTL_LABIE); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); } =20 static void rockchip_pcie_clr_bw_int(struct rockchip_pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D (PCI_EXP_LNKSTA_LBMS | PCI_EXP_LNKSTA_LABS) << 16; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); } =20 static void rockchip_pcie_update_txcredit_mui(struct rockchip_pcie *rockch= ip) @@ -269,7 +269,7 @@ static void rockchip_pcie_set_power_limit(struct rockch= ip_pcie *rockchip) scale =3D 3; /* 0.001x */ curr =3D curr / 1000; /* convert to mA */ power =3D (curr * 3300) / 1000; /* milliwatt */ - while (power > PCIE_RC_CONFIG_DCR_CSPL_LIMIT) { + while (power > FIELD_MAX(PCI_EXP_DEVCAP_PWR_VAL)) { if (!scale) { dev_warn(rockchip->dev, "invalid power supply\n"); return; @@ -278,10 +278,10 @@ static void rockchip_pcie_set_power_limit(struct rock= chip_pcie *rockchip) power =3D power / 10; } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DCR); - status |=3D (power << PCIE_RC_CONFIG_DCR_CSPL_SHIFT) | - (scale << PCIE_RC_CONFIG_DCR_CPLS_SHIFT); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DCR); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCA= P); + status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_VAL, power); + status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_SCL, scale); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP); } =20 /** @@ -309,14 +309,14 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) rockchip_pcie_set_power_limit(rockchip); =20 /* Set RC's clock architecture as common clock */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D PCI_EXP_LNKSTA_SLC << 16; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); =20 /* Set RC's RCB to 128 */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D PCI_EXP_LNKCTL_RCB; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); =20 /* Enable Gen1 training */ rockchip_pcie_write(rockchip, PCIE_CLIENT_LINK_TRAIN_ENABLE, @@ -341,9 +341,9 @@ static int rockchip_pcie_host_init_port(struct rockchip= _pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); =20 err =3D readl_poll_timeout(rockchip->apb_base + PCIE_CORE_CTRL, status, PCIE_LINK_IS_GEN2(status), 20, @@ -380,15 +380,15 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) =20 /* Clear L0s from RC's link cap */ if (of_property_read_bool(dev->of_node, "aspm-no-l0s")) { - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LINK_CAP); - status &=3D ~PCIE_RC_CONFIG_LINK_CAP_L0S; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LINK_CAP); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= AP); + status &=3D ~PCI_EXP_LNKCAP_ASPM_L0S; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCAP= ); } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DCSR); - status &=3D ~PCIE_RC_CONFIG_DCSR_MPS_MASK; - status |=3D PCIE_RC_CONFIG_DCSR_MPS_256; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DCSR); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCT= L); + status &=3D ~PCI_EXP_DEVCTL_PAYLOAD; + status |=3D PCI_EXP_DEVCTL_PAYLOAD_256B; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCTL); =20 return 0; err_power_off_phy: diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index 5864a20323f2..f5cbf3c9d2d9 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -155,17 +155,7 @@ #define PCIE_EP_CONFIG_DID_VID (PCIE_EP_CONFIG_BASE + 0x00) #define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_RID_CCR (PCIE_RC_CONFIG_BASE + 0x08) -#define PCIE_RC_CONFIG_DCR (PCIE_RC_CONFIG_BASE + 0xc4) -#define PCIE_RC_CONFIG_DCR_CSPL_SHIFT 18 -#define PCIE_RC_CONFIG_DCR_CSPL_LIMIT 0xff -#define PCIE_RC_CONFIG_DCR_CPLS_SHIFT 26 -#define PCIE_RC_CONFIG_DCSR (PCIE_RC_CONFIG_BASE + 0xc8) -#define PCIE_RC_CONFIG_DCSR_MPS_MASK GENMASK(7, 5) -#define PCIE_RC_CONFIG_DCSR_MPS_256 (0x1 << 5) -#define PCIE_RC_CONFIG_LINK_CAP (PCIE_RC_CONFIG_BASE + 0xcc) -#define PCIE_RC_CONFIG_LINK_CAP_L0S BIT(10) -#define PCIE_RC_CONFIG_LCS (PCIE_RC_CONFIG_BASE + 0xd0) -#define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) +#define PCIE_RC_CONFIG_CR (PCIE_RC_CONFIG_BASE + 0xc0) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) #define PCIE_RC_CONFIG_THP_CAP_NEXT_MASK GENMASK(31, 20) --=20 2.49.0 From nobody Thu Oct 9 02:12:59 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55FA517BD3; Sat, 21 Jun 2025 01:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750470519; cv=none; b=Sbe04o+vW5kZcdV0tuxIs3JfviCRyiPjoGT0hhCTGFpoFjYeDQoxo4tvzFFzwtFvrTvx2mxHfU58lzJxusK+4YS26DZ8cEOazbzgjgg52KrltQO8VhKK7MNEwgR5qMO6m/De6Ll54yDnuHBKSCyWef9aNQncs5IVsv5ePnKATiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750470519; c=relaxed/simple; bh=TMyeQZWAOAuTwvIXse5kaD0KDoeWmnfqoNhsSOfoCv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MLQkEvzN1RN50h3xQVma8qaa6XsQem1NatVVBZAtbk1E0j9lOaP0QPIC8ZzcNMUYzw+hwzyvjIlV8q9Xln1BrI1PQkETt2pQeUorsuny+fum1Ph3LVPKXb3BFoJMsn3+fwyyDOl0xJayNv5PcUUifRRHspLhNfoqRfNyKL7NoPA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h+lcaOgW; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h+lcaOgW" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-234b440afa7so25720955ad.0; Fri, 20 Jun 2025 18:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750470516; x=1751075316; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rtc4GJjYIzCc3h+Hv3COhOArvofrVT3IhU2L5CEaYbA=; b=h+lcaOgWxsZWqJTWk2z+vtmy7dKE+VgiPEdm8X5FoICO6H9C4JaNHITxW5tA1FjdxE SamvN31tHNRUrmXVAjZGkVidXY+/dMJ9ahNm32fhZu2G2ugwvWvnsXf8hAtQKhtGvknz GIlkEbgQ44RX5So3mNjDT+Z9FxJfHld9cPLDwbUIpPjXN3e2+Uk9Cr2rklQfYghAhX67 qNKt3b3J1fuj/8uDDtcVrUVRdTFFNOka7hKj7nU5RSAP247iav5KnVTEPc+CXMksv+Bf P2jrpQGNUHAwgRRLmQVH/msOmKB6mbEfnJEA0dzyC5TnyzJwip4HY6R6gS2DtH0hNtTx ZiwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750470516; x=1751075316; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rtc4GJjYIzCc3h+Hv3COhOArvofrVT3IhU2L5CEaYbA=; b=UWu2XGoZZ1kEVvcuQ+YdSXprekwOUwaqSMgzEbysWzCl2KHASdV9lTohYiunfGGige 8wIrtOZ1sXJq3c6ZaClt7QgMN4OXOM2XTkAr8s1N6O/jA1XELazRZ71wV1rqiYFr2DNL ERS3qr1DyGjzprcUNEy2L6Vr4zUInS7bRnpq1AYM0IGmb5RJxcZFZP+sgmS2lBORNZN0 m0EOjNu5RQqC09wOoKwwfbnMKzC3i7C/FVDHU/QOGg+pcXN2oOrN9YHnOmLzvDBxUsZm 64OeI021CXCbhvzgSZRwruWtDMRpry+48Ga88WX/VxMF+ECtqn1PYvDCGXv4CR5WoBuz pCJA== X-Forwarded-Encrypted: i=1; AJvYcCUw5k8KyuZqtqhJGRjeNN1sede0oWfeA3VdAOojwN/k7x8ZQZNlJGl4DlDRzY7N767TK5KN0RuuICRt@vger.kernel.org, AJvYcCV11NeSGRl44aL/ju8BJD1kBcU34UBkjCoXhUT+Ggqp4LZovXEYUZ7qATkaQwEZSAJGj725vpqArnK9HCw=@vger.kernel.org X-Gm-Message-State: AOJu0YxC9vbb2gVce09uWj136B/EmHffgvDTQLUh1gIXexrlsZc0j540 lMmjI5pLvTZ5AfJ9gXeppIXOvGUWdRzp9A6b0po+mOOQp6WdjlsZikhm X-Gm-Gg: ASbGncudLWSNAz3//bPfFHOby0ujHEAMFs+CV1jxFelWso3VmRwNW0QyUCLgEIdrLle S2xsCMQ6bjWv2j0QKaUR0PZz/UhXV5pRqYbrOTbRQesdRNUiNjgDb3wAU5uPAyVMve5iqU6LMTf w5VXY3YAhDN4ehnpc8SKv7C8p/aUEsf2YPNvhclz5l+W6FIn2TU+AmWIrYo16fu5M3p2EsNmJgI 0I/UXHBg320xwvZh5fu6b10Y8tKLnzKZ1XO0tgPaZaEMN6XogRdq72HpPLwfkJncv0mx7yhWHgP VRYhjZiaOzHXbDRanNhPWXvbXIaeSWJGkrJjDEOq+a1477IXOfPhoVB44+B1 X-Google-Smtp-Source: AGHT+IGm/Jggfckdj6HI8cIvmve7CSJ/pB5QUFvBniX73YqNMzADesGHqX4F1bRZCdJ5ROCygqCy0g== X-Received: by 2002:a17:903:1c6:b0:235:e9fe:83c0 with SMTP id d9443c01a7336-237d9852f68mr72238635ad.27.1750470516535; Fri, 20 Jun 2025 18:48:36 -0700 (PDT) Received: from geday ([2804:7f2:800b:d1c8::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d8398dcbsm28491955ad.48.2025.06.20.18.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 18:48:36 -0700 (PDT) Date: Fri, 20 Jun 2025 22:48:30 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v6 2/4] PCI: rockchip: Set Target Link Speed before retraining Message-ID: <0afa6bc47b7f50e2e81b0b47d51c66feb0fb565f.1750470187.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code may fail 5.0GT/s retraining if Target Link Speed is set to 2.5 GT/s in Link Control and Status Register 2. Set it to 5.0 GT/s accordingly. Tested-by: Robin Murphy Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 65653218b9ab..25890f6c0e17 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -341,6 +341,10 @@ static int rockchip_pcie_host_init_port(struct rockchi= p_pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL2); + status &=3D ~PCI_EXP_LNKCTL2_TLS; + status |=3D PCI_EXP_LNKCTL2_TLS_5_0GT; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= 2);=09 status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); --=20 2.49.0 From nobody Thu Oct 9 02:12:59 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AF0342AAF; Sat, 21 Jun 2025 01:48:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750470533; cv=none; b=MQ6nk6ljIP0E+ZFSxKYNa8+Hho/3Bx4BTFR+sWI+t0FiJZL1YtICfBPJrQU6rD7OuFFXvGXYS573aCQZpG4lpkyIIXiamMl/JBDmHF8bRWPTZu/8Qa0Qhan7edEeiCboD/MgguBjgBXPneKOqE4FCWgJhLMhWjP198w1LncD8hQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750470533; c=relaxed/simple; bh=ICTpLVM2M7G18zzAFC+A0bTSgAg31tSJVTdM/HqBFLc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jdv9pPwifTZYXWC7nihPhT9oyglIo8OvbulI4UydwyUSI+oG566kLVu4WtJLZoix1LM3hVnTxnCxXZY5D479GgeWyH+8IHnVw7EEChBoU1sUUVzCjcCq6AY19rm5Y9PisXoxvK9n1VIWO+htM6LbSNB8GGX32qCpgQN4VQXt4+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ULR5Oqg8; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ULR5Oqg8" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-748ece799bdso1661307b3a.1; Fri, 20 Jun 2025 18:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750470531; x=1751075331; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yie4J6/XsAs1Q8lv5qOjqiXHg7FYWZHizYmDgi4UuNs=; b=ULR5Oqg8VvOjerzNnZmbEfmB0NwjRDF9OIvklPPGVMuF4jez7mTqOIP/v4RH8VLrnb nEAc7Ht1vhfKn/PwUiHPyIBbtVhy6VKggvBwGgExZ2qSXNTdAQhrvYsJ79AAhmghZihc 7hYYyAhJcr7b3915yzvar3AUkmB+nxVgAqUKKPFK0hpOU6BEo2YHbQSIwLRmJdWoziIQ gYMw6WHQd8lFud7Vd0SGAgjJW6ru4VnnPy73oBnrZn5hEhQ58shbiGeQcHbDIwvOD1lg n40sFc5+aoxsd7wMY1c//Fw9EgpDNDUIwTeNidPY+MVn9YsuzLWLNzWqnW2yAPd8npkE ZImg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750470531; x=1751075331; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yie4J6/XsAs1Q8lv5qOjqiXHg7FYWZHizYmDgi4UuNs=; b=oSsU3c6nKh9tgjoIbgAxnqSN9SkaKD1eS53GPc2pqSPQXBrd7RuAiX6PNuovzKO9L7 +YO9v2AWmv6TMqMxNK8b+/qwCrXY1iq7gcUVcqrfcFzVMUNPRsEu3zR+nwYWraUAuBXN OGUgbvoGk1q4YadRaaHscZLQpiIDgOGU+AITYzjiolQ/Y/K8dcD21gj6GW6abjYYsyo8 f6LqOfqp7b7m2riwDqC4dNRylQEBW1YYBukFLteIyhCLV4x1RGbKswpGlTPCU2HM3WPI 0LmzEPG+cZlyAxjf9qZ8DKggYELabBJb0zeo4Jp/EBPVqArAyJNlUG4DMwOXYwLt2yip wDcw== X-Forwarded-Encrypted: i=1; AJvYcCVYSCrgT/FmlU4A7o9nZzWD4E+Mw71+1oQaNu1TcXA77fUQT7Uuwj9WN3X3yqDaC5+SoUwFIzWylAj1/iM=@vger.kernel.org, AJvYcCXosiv297lCzrkDF8ykZLbGGnpOYR2uSLhfm8k34VYjnKm4/BAjUU8s4K0CAFc5Tk0yJy3j9fOpFm/G@vger.kernel.org X-Gm-Message-State: AOJu0YwNqGmM1nXL/MmudnAXSoxMPiCEjTNalqRb5oU7/ZyIDKpm5fn4 Ou9kZnwYL+NGNM/vm3sR3UBLaA1mWfHtAcfepm46PqW5l4e7qcLpTxYNzoRunzbi X-Gm-Gg: ASbGnctehAFcMNWcfK8DL0MQ+s/tqXdFE7ZluJzkPbodthS863Bn3l5Bp8DtmrsBmne 6YU/keRJQH9CAT0OWnNxqZgQzSdh5vh8uEyRDJ3S6SDeUIG8PV+t2rDOcH0UtsolyyaJ9DSt3xK aupWyu+2OKDQg5xy4P32lLlIsW4LYAdOAax2XIsGmtX96xu/W+XKOS0UrDHff0wMV6wqckfZbUe M1BSMJCUSdXou28jGyst7sHCeh0Q7j6bwQeWQiF5qb9CBOxZt9oJOQw0ldmJSvwX+ScItrxkwox QG+L1U7boRWz2O9gR3F3a9mp1S73+K2EAHz35NgRx9xJ889J9A== X-Google-Smtp-Source: AGHT+IE6jUjT6swykmz/FymvMeohJed+3m7NKFOTEFnfs7/VIrYSlH3zczi5Z7eYucTtW8YKTwW8BQ== X-Received: by 2002:a17:903:2302:b0:235:7c6:ebbf with SMTP id d9443c01a7336-237d9967be8mr83535185ad.35.1750470531451; Fri, 20 Jun 2025 18:48:51 -0700 (PDT) Received: from geday ([2804:7f2:800b:d1c8::dead:c001]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3158a24c3f0sm5236869a91.22.2025.06.20.18.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 18:48:51 -0700 (PDT) Date: Fri, 20 Jun 2025 22:48:45 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v6 3/4] phy: rockchip-pcie: Enable all four lanes if required Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code enables only Lane 0 because pwr_cnt will be incremented on first call to the function. Let's reorder the enablement code to enable all 4 lanes through GRF. Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index bd44af36c67a..f22ffb41cdc2 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -160,6 +160,12 @@ static int rockchip_pcie_phy_power_on(struct phy *phy) =20 guard(mutex)(&rk_phy->pcie_mutex); =20 + regmap_write(rk_phy->reg_base, + rk_phy->phy_data->pcie_laneoff, + HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, + PHY_LANE_IDLE_MASK, + PHY_LANE_IDLE_A_SHIFT + inst->index)); + if (rk_phy->pwr_cnt++) { return 0; } @@ -176,12 +182,6 @@ static int rockchip_pcie_phy_power_on(struct phy *phy) PHY_CFG_ADDR_MASK, PHY_CFG_ADDR_SHIFT)); =20 - regmap_write(rk_phy->reg_base, - rk_phy->phy_data->pcie_laneoff, - HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, - PHY_LANE_IDLE_MASK, - PHY_LANE_IDLE_A_SHIFT + inst->index)); - /* * No documented timeout value for phy operation below, * so we make it large enough here. And we use loop-break --=20 2.49.0 From nobody Thu Oct 9 02:12:59 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6965D101EE; Sat, 21 Jun 2025 01:49:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750470549; cv=none; b=XgvYPrWCNWG/s9QBJ4OqVO0Czrgh8LEoBJ2BDUPUQIAQKfUyLiDzQCry49noKT52SPQszXg9gE5I7+50a8pKz49W1S1V+qE6dIRvwCYNowAlde+v3e5ySWDmco/KIzKWfBtyxpj0uNSzj4lnCWOzO1iloY4B+Z+UYPAoLcm5OzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750470549; c=relaxed/simple; bh=ZHiuNjkysUslUmsJxg+pQGZzasofUlWvOElEMSh7s+0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sV9J0fWYmUWSCM4aTxHdQ9aYHprIX639pX2HuilKCjKlIQa8mGE8UMZGddfZqPw/jQ4vZnzKH9lg8b+fgm2HfLRxXUsmj01JCReo1ZpJ85QqLRnn+IyW3fG/sBK5O/bPzZNLKL6tTPkJkSjK1H/inwsygyWB6yhpHlj+Bux1DbY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lcswBvEr; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lcswBvEr" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-234b440afa7so25723105ad.0; Fri, 20 Jun 2025 18:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750470548; x=1751075348; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OvjviZOYrIKurfYh7ExfJUlmx0DJYashywHEqMq8QKk=; b=lcswBvErmzX73QhbnW0/6nQhvNCbwLN1JcZQS6aqicHPk0YZjHH5wO9zAPJWybKIy8 N0j/U4ncv/R5Qwk9MHFMrfDkTHdoYivgFS682nUIHc9nryst229QuBqUGduQtW9SfWFL 0bSizdwO2u5VPZ0Hk4UB4ljFN/geXoF6npMliHzMNstvKivYDSN0RlfFNmW+HZ7NH8Bq WwDz/u4N0YAVRt1VHE0lGENy4uq/Gsi52si+bHfQtiUXcKlDVlZGWxf9PAEVrildCFAy dGdo/cns9o6ABWCicQ22XIsjdFPZKNNvDYGC6e36btWKSUNsXYdV4KysTlZ6WVFtqC1G smDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750470548; x=1751075348; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OvjviZOYrIKurfYh7ExfJUlmx0DJYashywHEqMq8QKk=; b=di30E1OI977qHPkZFD7iZbSnD3OZGJmWi3ld78+hgA0tloNBDYqCGS6mjr7D7sqPEH rpj9j8gRunoZhHVQLyY2voz2fyFO+kIb9Xa58XWg04JZBgyHzgPfDBbuhBqC0Vmtvf2W vqceQ06Loa1GFVF0kvoFjvSZq26P+/gVlS6UxjDkrE9lqgwJyUhanQ5bbonoVMvDUY7B RRnGn1lOKdkmlYPSua5EkQApz5c4tEOAx8cd6nsil6hjiMwMtFEfw1zRamrExI/aJ+fV YWxH06GZOOPMCwGdJR7M9Uy3+IEPcj6t9IFO1oFjIOsUQA+MKdLB0zrH3ixbQO6cXo0X teNw== X-Forwarded-Encrypted: i=1; AJvYcCUS8+cEuwxB8xuAaskszPflLwfMCN1oacrx84eCN5dw7FsHS/V/jN1U7fgouAu2I79ctLFvNTEQlY2/fkI=@vger.kernel.org, AJvYcCWh+kZT1S1O6O55BVvNuV13nyL4or7mzHoIO+kMVZszOe/LJljGoACPRm2nzFL9KShVuaxm5UvYjVGy@vger.kernel.org X-Gm-Message-State: AOJu0Yws2hkEXaLpmlXY/u3jGdxNeYCS99MDQDiV+PUvETvhW83VfGJw E9U4Ub+IG95sDxe/w6QsDW4BibXvndU61zRzjJvujqeI4ZO71Dq1zAN4 X-Gm-Gg: ASbGnctCwrnqJB7NhsBvT/LBALoNSxg0D8/ESR+Povg1CU4r/wqnYdeS/8F0IuYJmqu v0hm9krPy0D5UpvvjmsT1fT2j7VOiyXoVXd7vIrTjnr4WIrbi03W9I49gBu5QsAitbiY+Ocvfyz 6h1B8wVR5O9OMneO8NXSiqtMUg9OkEtYdPYSDouoNDN5E7TlRZy7WBGwlUnFkYfpU29vyTq+OIo Vlbiw4goiWWtUC3CIOTIeMUW468iuthHqaJ7XKLt51JER9jJZ6VOIQrcHwgVEQrF404BXGDG+q5 XNaAy7vIK/SrZq8joNiIANUhK3eUu61AqeNgP9C30CLW9VrkXw== X-Google-Smtp-Source: AGHT+IFUK+7UlH5yN/+V0QdO1GZAV34EYzEeJ0R6CtK3UbXVMrL12gPTfahF9bU36fRJMkeuEcy8rQ== X-Received: by 2002:a17:903:4b27:b0:236:937e:633a with SMTP id d9443c01a7336-237d94c1854mr72427915ad.0.1750470547692; Fri, 20 Jun 2025 18:49:07 -0700 (PDT) Received: from geday ([2804:7f2:800b:d1c8::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d860b496sm28183235ad.91.2025.06.20.18.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 18:49:07 -0700 (PDT) Date: Fri, 20 Jun 2025 22:49:01 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v6 4/4] phy: rockchip-pcie: Properly disable TEST_WRITE strobe signal Message-ID: <60ad1985a0de0a6b47044ea9c0acefe6ff865aad.1750470187.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pcie_conf is used to touch TEST_WRITE strobe signal. This signal should be enabled, a little time waited, and then disabled. Current code clearly was copy-pasted and never disables the strobe signal. Adjust the define. While at it, remove PHY_CFG_RD_MASK which has been unused since 64cdc0360811 ("phy: rockchip-pcie: remove unused phy_rd_cfg function"). Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index f22ffb41cdc2..4e2dfd01adf2 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -30,9 +30,8 @@ #define PHY_CFG_ADDR_SHIFT 1 #define PHY_CFG_DATA_MASK 0xf #define PHY_CFG_ADDR_MASK 0x3f -#define PHY_CFG_RD_MASK 0x3ff #define PHY_CFG_WR_ENABLE 1 -#define PHY_CFG_WR_DISABLE 1 +#define PHY_CFG_WR_DISABLE 0 #define PHY_CFG_WR_SHIFT 0 #define PHY_CFG_WR_MASK 1 #define PHY_CFG_PLL_LOCK 0x10 --=20 2.49.0