From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0C05152DE7; Thu, 19 Jun 2025 18:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356021; cv=none; b=ekEBAbOgIAmmEH9nfqyUYQvNKD3bIiPBNc+be9NS9nRLRqR+MA6+/BfBvtaA9zEa85t0z+AfTofjOOhm8orcYP40TWyExG2cOT6n0vYBehXoMwi3e2fr7iUJXpa59GBqA/YO+82NovPeuBa8LIr28MKaAx9DYNZ0pxmltTj4W2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356021; c=relaxed/simple; bh=xUDH6Y3f+vFZWMAVIrIgE0XQt44yZHQIeaYAsn5eqzo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RmvTCe+QLRdHeUs/BRkY1TwxPzqIiIPiRrQML7SpNA2WafQhnWUwU88i+4eBMjXzvecgQhkGHYBWsMZDbZtHxx/UnWJ1EkqkaOESTdggHXG05uV4htkV4I5zjRObPeIwP5dEsvFhScrZdOEw/UZfDj5JoFgI1VoHz3lEYj2803g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CipjD8xF; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CipjD8xF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356020; x=1781892020; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xUDH6Y3f+vFZWMAVIrIgE0XQt44yZHQIeaYAsn5eqzo=; b=CipjD8xF5xa892MyAecx2zN4gfFwbgWslX9ZlGQsZLOJARzMSwYCLdvH 9mKV392UZScFgzDiBkqXyTK51sryUDCAjX87K0FeOI3NhcQgZSCSa5Jx3 /vazFWWvlfkh/gSrsONLVE596JkbjD/ttOMPa/nMefdS3c6SEXIc7tWFL 8xvN+jAQobDMEShH7NwwP1bHaaIng6gPl0WQJX2xQtRmZJtiaCzOwecj9 LhlRDatoHAEm9vUX3rRhH7A07FmK98cPRvAYN4O/ZafIhpiKvx9e1fpZL 2gSXtr2PSPv314QwwuIpjHutOdve0IOCW+z09dyzgZMJOTGugPy4HxdUC A==; X-CSE-ConnectionGUID: do9xO6MkRw6e+yjZGfROIA== X-CSE-MsgGUID: 4sQq9viDSHCQG610V80UyA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047691" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047691" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:19 -0700 X-CSE-ConnectionGUID: 4Z+bK9ZzTqy4LPirAxmCdg== X-CSE-MsgGUID: dVS6tmMNTKSxAA71simgXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919257" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:09 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 01/55] media: v4l2-common: Add a helper for obtaining the clock producer Date: Thu, 19 Jun 2025 19:58:54 +0200 Message-ID: <1f8a0bb1896a57e818fad30a236b350127689be6.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a helper for v4l2 sensor drivers on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. This helper behaves the same as clk_get_optional() except where there is no clock producer like in ACPI-based platforms. For ACPI-based platforms the function will read the "clock-frequency" ACPI _DSD property and register a fixed frequency clock with the frequency indicated in the property. This function also handles the special ACPI-based system case where: The clock-frequency _DSD property is present. A reference to the clock producer is present, where the clock is provided by a camera sensor PMIC driver (e.g. int3472/tps68470.c) In this case try to set the clock-frequency value to the provided clock. Signed-off-by: Mehdi Djait diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-cor= e/v4l2-common.c index bd160a8c9efe..c53221165c5a 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -34,6 +34,9 @@ * Added Gerd Knorrs v4l1 enhancements (Justin Schoeman) */ =20 +#include +#include +#include #include #include #include @@ -673,3 +676,49 @@ int v4l2_link_freq_to_bitmap(struct device *dev, const= u64 *fw_link_freqs, return 0; } EXPORT_SYMBOL_GPL(v4l2_link_freq_to_bitmap); + +struct clk *devm_v4l2_sensor_clk_get(struct device *dev, const char *id) +{ + const char *clk_id __free(kfree) =3D NULL; + struct clk_hw *clk_hw; + struct clk *clk; + bool acpi_node; + u32 rate; + int ret; + + clk =3D devm_clk_get_optional(dev, id); + ret =3D device_property_read_u32(dev, "clock-frequency", &rate); + acpi_node =3D is_acpi_node(dev_fwnode(dev)); + + if (clk) { + if (!ret && acpi_node) { + ret =3D clk_set_rate(clk, rate); + if (ret) { + dev_err(dev, "Failed to set clock rate: %u\n", + rate); + return ERR_PTR(ret); + } + } + return clk; + } + + if (ret) + return ERR_PTR(ret); + + if (!IS_ENABLED(CONFIG_COMMON_CLK) || !acpi_node) + return ERR_PTR(-ENOENT); + + if (!id) { + clk_id =3D kasprintf(GFP_KERNEL, "clk-%s", dev_name(dev)); + if (!clk_id) + return ERR_PTR(-ENOMEM); + id =3D clk_id; + } + + clk_hw =3D devm_clk_hw_register_fixed_rate(dev, id, NULL, 0, rate); + if (IS_ERR(clk_hw)) + return ERR_CAST(clk_hw); + + return clk_hw->clk; +} +EXPORT_SYMBOL_GPL(devm_v4l2_sensor_clk_get); diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h index 0a43f56578bc..72d8fcc6057f 100644 --- a/include/media/v4l2-common.h +++ b/include/media/v4l2-common.h @@ -620,6 +620,31 @@ int v4l2_link_freq_to_bitmap(struct device *dev, const= u64 *fw_link_freqs, unsigned int num_of_driver_link_freqs, unsigned long *bitmap); =20 +/** + * devm_v4l2_sensor_clk_get - lookup and obtain a reference to an optional= clock + * producer for a camera sensor. + * + * @dev: device for v4l2 sensor clock "consumer" + * @id: clock consumer ID + * + * This function behaves the same way as clk_get_optional() except where t= here + * is no clock producer like in ACPI-based platforms. + * + * For ACPI-based platforms, the function will read the "clock-frequency" + * ACPI _DSD property and register a fixed-clock with the frequency indica= ted + * in the property. + * + * This function also handles the special ACPI-based system case where: + * The clock-frequency _DSD property is present. + * A reference to the clock producer is present, where the clock is provid= ed by + * a camera sensor PMIC driver (e.g. int3472/tps68470.c) + * In this case try to set the clock-frequency value to the provided clock. + * + * Return: + * * pointer to a struct clk on success or an error code on failure. + */ +struct clk *devm_v4l2_sensor_clk_get(struct device *dev, const char *id); + static inline u64 v4l2_buffer_get_timestamp(const struct v4l2_buffer *buf) { /* From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CD3E152DE7; Thu, 19 Jun 2025 18:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356031; cv=none; b=kbHwVPPP/pIDtB6t43WwodtbUzV1V1YZwJvaewwL5ESF5VE4/SPEn/bfRJ4dYP08OfqeW+YkNw5fs2D9DQjjbhyrypcPiInybICkpn+JnYz2BYW+Avee/qWnyW7qftjFrjyUFIudKy51pfzPeDf7amTVasW0lMStKfLurmShQCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356031; c=relaxed/simple; bh=KWJQMbX5JD4uCQEL5BpmXqyAVzFe/6rRwmcsG5G6wsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GF+ZW0kiCZFOoIdhNyPsh73cfs/1HE0UMTxMp2K+WzBNZ4FbWYor3lcpwE0fFEy9mx8SzoKcHM9p88DshBTDu7PgcGvwsjHUlAXFy9BTDZ3+PtMQjV/fgezSthSSXyoHvthRfWoF86aZp8mQ00gollB0TlVmPmnEIv1FByGXaMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SGGBeHrM; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SGGBeHrM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356030; x=1781892030; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KWJQMbX5JD4uCQEL5BpmXqyAVzFe/6rRwmcsG5G6wsY=; b=SGGBeHrMzQpRslHLMT9/XOFgEmmGs8/eXT9wneTaUJ9bvWqIJ+J50vUK +ZkPKMTAY7DDYuGx6E/re3pSuCcYUYIZUE/TCYvOgsaACc84PpbjPkK6d a0BVVclfTwmwr6SAai+kBC/xYWQ1vYwwfpz2AyeUeZ8dyXRnCsq3wWjaF NEByxYPvj90iu0C7bUwIZo0geUd8GYRRqhr+p5iwhJCGMw7yt0oqTJbha rvHrgbns8C24L8MQnA6P3d2mX6DUc1ROSoh7c8QXqO4MgOb7hnQltbfGs 4WGJ6Z5Gyoqap8tlN+3uy/t4D6AQbn4v6MQHdXCk83nvEdNVmm+ajhgww A==; X-CSE-ConnectionGUID: 9JY8ZGAXRnK3lt84bSUb2Q== X-CSE-MsgGUID: RtkE+f9HQC+qTVoZXLGy5A== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047708" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047708" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:29 -0700 X-CSE-ConnectionGUID: ONf8kMIbRWyfZhOBKM6CDQ== X-CSE-MsgGUID: egyGboLvSVi0nfLadPKJMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919277" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:19 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 02/55] Documentation: media: camera-sensor: Mention v4l2_devm_sensor_clk_get() for obtaining the clock Date: Thu, 19 Jun 2025 19:58:55 +0200 Message-ID: <1261f41358da597fb9900b7880618ebcc392160d.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the new v4l2 helper devm_v4l2_sensor_clk_get() to Documentation. the helper works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/Documentation/driver-api/media/camera-sensor.rst b/Documentati= on/driver-api/media/camera-sensor.rst index c290833165e6..c82c018a5f40 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/Documentation/driver-api/media/camera-sensor.rst +++ b/Documentation/driver-api/media/camera-sensor.rst @@ -32,7 +32,8 @@ user. ACPI ~~~~ =20 -Read the ``clock-frequency`` _DSD property to denote the frequency. The dr= iver +Use ``devm_v4l2_sensor_clk_get()`` to get the clock. The function will rea= d the +``clock-frequency`` _DSD property to denote the frequency. The driver can rely on this frequency being used. =20 Devicetree From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2469E28C871; Thu, 19 Jun 2025 18:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356041; cv=none; b=CUldEujOzymo/q6wNV4sSlC6RR9HdEtx65ZCCBmWN0KIzzcfGxWoyHvoR+i6vxs3kjAIPXecvqxvpTaiE8AnSfKj1nSOlg9FcTj6b3Ys9SBioIx9sYuV84IvbqtA/yWjn9F5kYn6qaZLjJYbK0nBLe6VP92HPK5kR84fWKrLOEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356041; c=relaxed/simple; bh=vPzOH8cs9rp6/ju9/wn6goMW3EgRy1pi6+Fkchq34xg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I4G7XQpUqi3PDnr25IzTytwB0c6Z1GSDVFZ8xfbh6Rse8TBJcO5QJ7XdVKylBS6RKOdH4e5KI+px8RipRFofqCSEvCmNcP88nEHj7Mf8GGKisAmS10Mn6NEpuIPHS+YSBMqKas5xZlRD6bW6zm8450ndJHjhVOQ+dJdVFKrC8tc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gpuuiObE; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gpuuiObE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356040; x=1781892040; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vPzOH8cs9rp6/ju9/wn6goMW3EgRy1pi6+Fkchq34xg=; b=gpuuiObEDPwpwzpUwHI7T/EmWt6zQOFIJXiC/TECFv4bd0FIlRZ0Y1H/ CU8oUhNszwB5tKf4Ypkwpx/lhSGtbiYdktCB78EkeiCQ1rJoS4w7UUoVe Up7QVP7aDuy3dAymbK1lvnGiST3CCLesHsWhwz852inEsnqWqrHc2sGVj zqPyMnFMjDrsnLK7n0byhefxcOw6v0N6JYWPT2TeaDqU1NmUWW7/oV2KZ VPZ+qcmhzUZJQWe9R066q1ccCCFhpbyLc7q6+j5CY1w0B7Y8t9ajdO9ga sWKw66DN0OtyY7hWwaxOxe9nLKmBYefAu5RLG+xoWDAgiuiUQxF8iAj68 A==; X-CSE-ConnectionGUID: NSzC/bwiQFmPjXJgAsicow== X-CSE-MsgGUID: ojhVS7cBQwmFIMaZ7810pQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047743" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047743" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:40 -0700 X-CSE-ConnectionGUID: UvM614VbRk+b6MJKV3qI5Q== X-CSE-MsgGUID: NsRB+dyDQzmRuRF2oiz4+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919295" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:30 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 03/55] media: i2c: ar0521: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:58:56 +0200 Message-ID: <193004ef9f9ace1b4c1289da7bacbee5adcd5ebc.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c index 24873149096c..87fb12774b95 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ar0521.c +++ b/drivers/media/i2c/ar0521.c @@ -1077,7 +1077,7 @@ static int ar0521_probe(struct i2c_client *client) } =20 /* Get master clock (extclk) */ - sensor->extclk =3D devm_clk_get(dev, "extclk"); + sensor->extclk =3D devm_v4l2_sensor_clk_get(dev, "extclk"); if (IS_ERR(sensor->extclk)) { dev_err(dev, "failed to get extclk\n"); return PTR_ERR(sensor->extclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A37A428EA62; Thu, 19 Jun 2025 18:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356052; cv=none; b=b3kwoDE3wRKiqOz7odYK8DJKqu9MbDOzX0Q2QNNJTWilxtErBu4QiJuFeE4vF0VVWhrotFvXjKeDaUc+bjPc3iUZin2y8I3qGD7aH+YopTgtudQWTwe668+39lnTC/Y4TfoixzkuS+C6pFgKn9fli6Xx3JaOTrG/NAYD1WgmYBU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356052; c=relaxed/simple; bh=ACDDIEOG1RXBBeSXNnhCehhb5lqhYtMwhWBzZljlL7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IbZS+B2TQY+32X4q+Gvk5IGsBIipT+A/rsRhsX4DMkEGW6/JLuUgNdkMFOEuAZFaDw9VcF5AyJRHhBvhAnTD1dXTQPtGVxfJwQnG9nWlPW8qR67/6LuV7ma+8Hk4X3kwghJeFTa57MphVlSSo0Uw6X0cuS8idDLgvZHXdPp6p2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Sckrl+zM; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Sckrl+zM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356051; x=1781892051; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ACDDIEOG1RXBBeSXNnhCehhb5lqhYtMwhWBzZljlL7w=; b=Sckrl+zM9DG8iXWriTpCT+uP2yT6KzdipteFOAJC4EstEFuHpRhpslDo YfHlT/nvOyRpc5vO8wayQui3r2eh/nXFRPYVJHe0GZ1lDGb//458/hu64 9HM5ZPZyGsU+LEXUmUKOKN3ZACmm8lavCtM4dAmVPg3FgdSOV3IDIKUrS O0oJSU5qaa9H2qM2VJP5NNBxOVLYO3nHq5IcZmo3wezSpYCAtxPERTMOJ BpDnpagyqKO5q4N9MC4FaUoRFboLg/km4aJ2Wh/0zfLaPLu2Jy9IAIOq5 NxWV2pCbZx0LCFz0UMmlBLyLultmmGM3r98elM1tqGNs+W6nlqwIzMCaQ A==; X-CSE-ConnectionGUID: IoMvTS1hSJmx5+0Sd9edtA== X-CSE-MsgGUID: C6CixtdsQVOgQVfwB15fzQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047779" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047779" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:50 -0700 X-CSE-ConnectionGUID: Xm+FMAHHTuOBajWA+cpM6Q== X-CSE-MsgGUID: lGzT11PoSBKVWq+Pojy7Cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919311" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:40 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 04/55] media: i2c: ds90ub913: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:58:57 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c index 6d3f8617ef13..e3be10d248eb 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ds90ub913.c +++ b/drivers/media/i2c/ds90ub913.c @@ -880,7 +880,7 @@ static int ub913_probe(struct i2c_client *client) * ub913 can also work without ext clock, but that is not supported by * the driver yet. */ - priv->clkin =3D devm_clk_get(dev, "clkin"); + priv->clkin =3D devm_v4l2_sensor_clk_get(dev, "clkin"); if (IS_ERR(priv->clkin)) return dev_err_probe(dev, PTR_ERR(priv->clkin), "Cannot get CLKIN\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF1D5152DE7; Thu, 19 Jun 2025 18:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356062; cv=none; b=NhJSBLi+lFnoDQic+HV+6qTEeyG0aOnwd871NWv76FrcUaLMymQHqpl1/A9BJhP6lCo/BBhU5ptVG/1XOivIhDgBo0YyngI7csQsDmsysiKwMIHj5E4je+mRQpN8qPrUzAlhW13QMKpEleTuDUAWtGSNzat8l3UY1oOamA3FH/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356062; c=relaxed/simple; bh=BHwRAwG5ENsFFTwinJyd1syE9PfllbFfmJ+4YzbfX/4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h0LKiy+gr8XUWkY7kNk8hcwh2D55CBW67TwK+0qpW9BNKhLJqI0mr5gqr+xGLqGVbiWFfjUc29phl8/iWADMtMQW1UfzkHp7DdEeUQJBCjE6TdBznQ+KQ994UOS+qLdqrNt9e8OF1k3frJct6nmfVAzTfmIk06dKcgmF5GAtjIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jRJ9TSEg; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jRJ9TSEg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356061; x=1781892061; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BHwRAwG5ENsFFTwinJyd1syE9PfllbFfmJ+4YzbfX/4=; b=jRJ9TSEgiZZ/d3dc3AsnzrSJuIpYSTzngvtMVO0RBP81/Kdb94vkJ8IK l/GwXYvyxy1NcqXXfFqbS5EqfyNwZxPXuQXcSyjxH6gpvDzRL/zRzWNr5 YaoybczGAJ1T00OWwJ+zxUG1GdrT243hZd/FKXv5xFJNrNWIZjB3EdLSI VO5yy2MGaWu4kqMvtgLe5DtZwGgxGGh+tGoMlkpNfQjb64e9Za+QPERJ8 P4rgD+J2p2I1kqQgVSKcHIVEYrGxNdrURWUYFr3DjFGPgFOWArN30OOLS x877xLDL7TM9DzhJs+u2WnooB3qh6zT7BByaV7wQsA9/f7ZIGPr15+cVd Q==; X-CSE-ConnectionGUID: 6Mxzpd6wRFSrPybyKRX2gg== X-CSE-MsgGUID: Y6b1LvmGQJOM2VComtWZHA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047816" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047816" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:00 -0700 X-CSE-ConnectionGUID: 75vFlJlvTOOqb67lRRKBSQ== X-CSE-MsgGUID: +0im+s+WQpOI6NQkqKPslg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919318" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:00:50 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 05/55] media: i2c: ds90ub960: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:58:58 +0200 Message-ID: <75002bfe8c15a55d6cb4276666862c15dd4db328.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index 082fc62b0f5b..9de643122e65 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -4964,7 +4964,7 @@ static int ub960_get_hw_resources(struct ub960_data *= priv) return dev_err_probe(dev, PTR_ERR(priv->pd_gpio), "Cannot get powerdown GPIO\n"); =20 - priv->refclk =3D devm_clk_get(dev, "refclk"); + priv->refclk =3D devm_v4l2_sensor_clk_get(dev, "refclk"); if (IS_ERR(priv->refclk)) return dev_err_probe(dev, PTR_ERR(priv->refclk), "Cannot get REFCLK\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F26428DB62; Thu, 19 Jun 2025 18:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356072; cv=none; b=Jt8vX5x4I9a3RfBfMOf8M3RJ9NNwMsfddYkmOSO+jfQTm/O7Lgw5Bd9NhwlFKsSLNr90mK37IE5okhmzoW65X6RwsTIslaHdcJ5qZtjMjkQ4X7hL3IBQ8mulZYh/4azWXykpWk4LDTMOgjLDyPzyFnP3IrxeJ5PuLhoMQKo3Q8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356072; c=relaxed/simple; bh=m+ZUZ+xY0rPq5xshOdtz5io/qL4Yg1SP464CzNCTdBA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i6gsoMhQhUzMtMHU1IEAd/U7dkxKiYm9uOoFsZGWH/JGR9X4rW/32sIhuQwPl0bbPpI2VkNkmW6ZcPpE3izg7R9kr5MiTy8y+9/9cZnFfsFgYeEorRoVNF7j9XW/rA/eg3s8tNyZsncG95Bq4kXe0D5h+Dco95l50dbj6n22PIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BJ8RSSS9; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BJ8RSSS9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356071; x=1781892071; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=m+ZUZ+xY0rPq5xshOdtz5io/qL4Yg1SP464CzNCTdBA=; b=BJ8RSSS94K2xWJv7q1pfuVLgUAWYAFDIvq6f5e0JewP9biLCt0QiFOqu WJiY7I7JwFSxguOM+TZZH6QHIPOqZOYfs1y1saGf8L99hLv/7hPwRRUEt 4IN6zgqJ/T3NvKJJB8U1MaQd4mlX4KGtQTIms5DIsMWTImVsbh2Yb2mdP QJw0hnL03g3lM2/4MWn2+BgARIxHj6Rj+Fw+irXbEELYIOcHost5G1NUk YFmJsuf6k3j6JWenLDnD0BXaDrJGzD/0A3KX35akJak5FWkNEDYx4uCXo xpAzo9+s06SBLMAEldphDkbYr+TDzUKoCtWIzUqNrtVIg6XshDqDFSw8s w==; X-CSE-ConnectionGUID: 7JogRgr1TjmME/xL6ns02w== X-CSE-MsgGUID: RVOFX+4qSY23DzLBJcnH2Q== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047856" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047856" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:11 -0700 X-CSE-ConnectionGUID: T/TmCVa0QHuC9WkMjdDlAg== X-CSE-MsgGUID: UDhJtp0wQjqkHVDO9YYP4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919329" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:00 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 06/55] media: i2c: et8ek8: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:58:59 +0200 Message-ID: <0da110e814e5d0fc194a1b1996e42cb7345be66e.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/e= t8ek8/et8ek8_driver.c index 7519863d77b1..3bc238e44f5b 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c @@ -1433,7 +1433,7 @@ static int et8ek8_probe(struct i2c_client *client) return PTR_ERR(sensor->vana); } =20 - sensor->ext_clk =3D devm_clk_get(dev, NULL); + sensor->ext_clk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(sensor->ext_clk)) { dev_err(&client->dev, "could not get clock\n"); return PTR_ERR(sensor->ext_clk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B4C928D8EB; Thu, 19 Jun 2025 18:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356083; cv=none; b=KapkMnr6irj3+MxuIRB+yx6m9J0IVX/BjNM+zjLg1wrce77fOe+MXwSKImw6r4lmojYp9n+5N1LGLcXGjAfHFMbtn45K3x8+95BddZ3KGI9h3FeFO4ywDxKoYlHm2SSBbjuoqO1BiBnYRNAzc8rb4Yob9oJ6AYV67eeq6ovKDiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356083; c=relaxed/simple; bh=iwy0qPXxu1wNsI/BhicSZq5S5fxF8PgJXwP2EBfuKjU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Su9A89EfxEuWGhRfh5bdYrmJYcslMlvPjikRTluSJlGQYb8wTSwHYU5LgvNNT/CsSwW3SaEiGFENuAnvpXuozF2+L5QGLLl8cL5ZQ+lpAjurj8io7Ij69a1GFUKxXzSIyHwlAiKr3IiHhiEJ+HJzQmcezm2+ZrfBuPWoM+rUsE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MaPfwLsf; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MaPfwLsf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356083; x=1781892083; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iwy0qPXxu1wNsI/BhicSZq5S5fxF8PgJXwP2EBfuKjU=; b=MaPfwLsf/d1/g3Wqoox0VVtP0LR5Lfi+oPLo1RwNmyzsZla0zDWg9NlY h3qmafGc/KoT8E2Oayaj0pTQV1TLGQ5VoOBmiOmWYQp0H0JBi+fsjtJnl NPxjpAK2J/0SkHkQzkRMixdbWuMyzf0FBNJsygJSuqYJ3AiiMhSRXfmbX rZ1Rv4kTcoCLKo0qMKai6vap+j37y3p4wIlKZrz3Ek++wHas/lzuQSHpx CFz820bKOA/+5rgPrL/7jtXq+sO74rhYvrSG1fovW3xOr5aTfpoOh8fUf 81inJNXUocMqmqnCyN83fbPyUEUcdw68R+CFGTUGawgpQfdcT+lytA4aK w==; X-CSE-ConnectionGUID: 4w5iGom9RPW24zMFK/GU5A== X-CSE-MsgGUID: Bu8/46TuSrGnqfxtvh7Arg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047890" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047890" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:21 -0700 X-CSE-ConnectionGUID: TllHjBlbRSGNLMIITRlvEA== X-CSE-MsgGUID: ao4wnHStTk2+R/DY74X4lg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919338" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:11 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 07/55] media: i2c: gc05a2: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:00 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/gc05a2.c b/drivers/media/i2c/gc05a2.c index 3f7f3d5abeeb..4dadd25e6c90 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/gc05a2.c +++ b/drivers/media/i2c/gc05a2.c @@ -1235,7 +1235,7 @@ static int gc05a2_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(gc05a2->regmap), "failed to init CCI\n"); =20 - gc05a2->xclk =3D devm_clk_get(dev, NULL); + gc05a2->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(gc05a2->xclk)) return dev_err_probe(dev, PTR_ERR(gc05a2->xclk), "failed to get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13B0928D8EB; Thu, 19 Jun 2025 18:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356093; cv=none; b=P/HFOa+Wv4Ra46TLU0y7qLIyVxdBsAeESoEC3vxXemT7z2QdC5cPErvouoSeqQOhr7j15U9WfPdJdqXnZ4yfgWYu6FWy7FqMN1N0BUXC84jvvNIptasSKrUCXjtP35qaGcF7On26J6kADMziEDFJWvEbrBGt4t0OCbAEtNQZpFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356093; c=relaxed/simple; bh=/9YzR0OCK5tJ2A2ja+FkVc7nCHiOryitRzRmVxxNAIA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fNRoaoMuL31uwkDIolNrKK2I2UdQt+QwNS1vWkliyijGVXcSJhetZTX7HOa4IoyMR0tk6aOwW9JhwNcf9ylgZATfUEKMv+CLj0nZRDb6oeCmfc6kxHc7cKwxUQScUYrkPFdz386uCD5c6ur9/6KjIMyXvMC27RFXnhN4zbIrfAg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D+IuQpOe; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D+IuQpOe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356092; x=1781892092; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/9YzR0OCK5tJ2A2ja+FkVc7nCHiOryitRzRmVxxNAIA=; b=D+IuQpOesdJsbphEN9Cg9JOaAztJpt+2R0M/gXIqd5sdMK913yPoLX2x TJagugb9tyzTn/T4BAGvgHNeiC0WE8f9YzXNMJM/1rLqFx4dc5l3VVLBO rAXBD3yLdKJjKaehtle6MSGKHZufodYI+AbjtcrZyYWvTfyeOpfjphbWn 8Xsl7nailVN1HnrYFneA6LmXWaKsvzkZFCWx8COw8UyYy9VxOv8wCVh3B N9oF6bt2GJ0Cq8tqz5+8mAbzT9f7XrA+sX8YbAddCsBL61BMXMApYn+Cn +NuUz0wZKK0ktkNfru3aVJpDuv6zFlmuNu8MeyJl0UfIOolZdG42sXa9A g==; X-CSE-ConnectionGUID: +R6JGyCuRkOqHe0AOsatQQ== X-CSE-MsgGUID: t2t/9H+ySryriBrDh9K67Q== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047921" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047921" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:31 -0700 X-CSE-ConnectionGUID: CYVzxLtkQ92OGCjejr+3Sw== X-CSE-MsgGUID: 7y7mIMA3RvuPASDsqnKfNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919346" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:21 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 08/55] media: i2c: gc08a3: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:01 +0200 Message-ID: <8261a7118483073d5f8d952fd2a62bd8f2fa6bb5.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/gc08a3.c b/drivers/media/i2c/gc08a3.c index 938709a677b6..5d38dfa9878e 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/gc08a3.c +++ b/drivers/media/i2c/gc08a3.c @@ -1199,7 +1199,7 @@ static int gc08a3_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(gc08a3->regmap), "failed to init CCI\n"); =20 - gc08a3->xclk =3D devm_clk_get(dev, NULL); + gc08a3->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(gc08a3->xclk)) return dev_err_probe(dev, PTR_ERR(gc08a3->xclk), "failed to get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB63524290B; Thu, 19 Jun 2025 18:01:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356103; cv=none; b=q3kiCfy/xpzpw5Iihle2tbX/Y5KcoWzBTdZjjGr5HUd27jcNmbMQOoJy5tnHpc0J/zNPN/polxwF/GM3YZSxxqh/QPUw1wJaRIMOvlwhhZdg6GHDzBJ1nXjiruzuAIkTxyOhLoD18lVAH1D/PaT1fJVRq745cnbWtAXAP6y0Syw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356103; c=relaxed/simple; bh=i/Voqwf2C7DA8RP0nEiNittzYGjVN4O2kjayJh0irpU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lRfvoiz3oFFCmUTY120kMKnfrVEDl2hZz8/mqTzrSMDkCLXe6c4w2HN8lpZJ2TRqq0nFfvfCYcyLGDji8BNwA0/edow3hgmJNbNkRHHBwcQ/n/xePNK1RdY306WxTChgsfpLXSFWYPukjclCIDS7Ss1R/LrZlrZIdZDzQ+eGSCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NeeEAFhY; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NeeEAFhY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356102; x=1781892102; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=i/Voqwf2C7DA8RP0nEiNittzYGjVN4O2kjayJh0irpU=; b=NeeEAFhYhcOnuSHqJOJ878CcxRmQrPRW1IhHQ5LVMgrEiCEOwtqDkS2B XAfwSIzXpKDAkkuQtGMUhI18K+9/sw6J8W+BrQoEj9bpupYAuwaBrND/D 3R3QwC2qhX4+J5u4UbeZyfXUYOWqoXUKNaHIPFKyEOg3aHtwY0NSaicUu TbO77ImG6zyOlwSW4KH81Bs11Jt57Qm2noD62tWU0bVdJhlNUNzUuJCGH mmLrLVxhcmZeBWBGzURWwN+cJGzgR4Acu2uEDxfH1Oq6nyva6TK7+d1Br 4vq8RvFaq2YH8/16AaZOP6xI2/Xvs620mY33Ouy2IZ/C28IXsnkhGdfNA g==; X-CSE-ConnectionGUID: OiJh6o3nQ0S1g6UVa0TiUg== X-CSE-MsgGUID: AJ3tkMzbT/++7UC9eZuReA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64047968" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64047968" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:42 -0700 X-CSE-ConnectionGUID: FanaB42fRta/fkQ79Ab2mg== X-CSE-MsgGUID: +nICZbLzSwG24ziAbYQZnw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919353" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:31 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 09/55] media: i2c: gc2145: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:02 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/gc2145.c b/drivers/media/i2c/gc2145.c index ba02161d46e7..52d9387559c9 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/gc2145.c +++ b/drivers/media/i2c/gc2145.c @@ -1334,7 +1334,7 @@ static int gc2145_probe(struct i2c_client *client) return -EINVAL; =20 /* Get system clock (xclk) */ - gc2145->xclk =3D devm_clk_get(dev, NULL); + gc2145->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(gc2145->xclk)) return dev_err_probe(dev, PTR_ERR(gc2145->xclk), "failed to get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E53828DF36; Thu, 19 Jun 2025 18:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356113; cv=none; b=oS3wtU9dcXjYVBDK0BmjHOFo1ZB4uFZGxlN8iHSXEOmR40NLSjZfd6JUDBXJKa6M83o9E8qOOyCs7exaEluHSobBBt+kjmqZeK9Nx7V9sFWk+h54uVSqwVfZ1hz4wbAHD3HPR18b12VCTL2Kpjn1wDcDbU2bm49IXRi1b8l4uhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356113; c=relaxed/simple; bh=e0sQLA7VcTCjZU6FaySd9ry+vsQ0ZYGJpaq2yiSSimc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DNhs/WPcJoYTwsoMpKfZUzO2mrUv+8xvkK8oeRnw9QO+iSK2xQgdaspLCo8baKAyDOYwqH28oIeKpM8ssUqbzq1hB1isgIT6HNu4DPkj0wOdAvi5XPzkiQNWrlyNZfNgBXP488fPhD6Q3FWfjJ4E2EpqXyvXQnSnI8OJQih2M+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=E2mx/wp0; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="E2mx/wp0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356113; x=1781892113; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e0sQLA7VcTCjZU6FaySd9ry+vsQ0ZYGJpaq2yiSSimc=; b=E2mx/wp0Y6DOZLRit/qWxO/Q7JRfEju2Jns9ksOOctvirztygSs8B/7p RPSTSGC/5Ogux5Mup/hG3+KzeijWqVLhvRitSZZZKJvf7hERxTdCU7hVX GEwWN70bmGsgeS32nsF9WO0p3BzwcN2CD+aGsbli17GMynNywtrljRg2X qBPFRRL+DHoPx6637u5rPFjiLCJj5fEXGXaoPvtL+26TNkSQKr0zcrOuE RKgxehfTKqkT6hPHth8OQ8hetstgSffEU548pygMcgOGtHu5LvOnWIaYo b7goXrwRy30FhiZY22n19AZrTcxbmrOiCM1F+AqoA2pE4Mfd0VIzUoLi3 Q==; X-CSE-ConnectionGUID: 2c4r5SmJRWuC6vwgdOC10Q== X-CSE-MsgGUID: X7wwR8J8RR6ZAqb/VpD1tg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048020" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048020" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:52 -0700 X-CSE-ConnectionGUID: IFSYzDiiQky5n5lh3cxALg== X-CSE-MsgGUID: t3A8PR9iSDaR11YEQ71uVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919361" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:42 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 10/55] media: i2c: hi846: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:03 +0200 Message-ID: <5f7cfbdd2cd16ebbd43a92b0b5c12871492313c8.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c index 172772decd3d..1ae5006cb9be 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/hi846.c +++ b/drivers/media/i2c/hi846.c @@ -2052,7 +2052,7 @@ static int hi846_probe(struct i2c_client *client) return ret; } =20 - hi846->clock =3D devm_clk_get(&client->dev, NULL); + hi846->clock =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(hi846->clock)) { dev_err(&client->dev, "failed to get clock: %pe\n", hi846->clock); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55EBF28DF08; Thu, 19 Jun 2025 18:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356123; cv=none; b=uh7nMtB6mKDMKpVLaYu1o8wrTiXs5JdC3xCdde0a99pl6CHOkyW3SiPYQPphMb8xiXcDvQjgOyh7a4aW67LRReFX0VIf2eBue10yYyUKrKZyQ9/8yMFTm0CKC/PA5Kq99jArcBfWRKA1W8bxKNiJraA0Cca15p5lzlXwwZpzE40= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356123; c=relaxed/simple; bh=o1NwHoj9JPsS8E0cUUG2MAKjHahzwmMc/pvDpHhvywk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=elS+DtjbVGHE8amg4saa6FDv6SuwC9Z9VAX+0hDz6E0kh5Nag05qcpfh2TX28efhWEUISz8kJvK8Ys8OFbmreZ2Pi53w2l3rJ2Gw6LCvUFf3P8MUWtUNcs+ULeJcTBtUDFXzRacKr7etpb+WtBts+1/pxgiqkkFkk7G2amrYG0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jgfb7naK; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jgfb7naK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356123; x=1781892123; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=o1NwHoj9JPsS8E0cUUG2MAKjHahzwmMc/pvDpHhvywk=; b=jgfb7naKriyyWhQ4WDso86dP26cWd6t01EanSpBpIgNPCTglOLRDLkdL 7pqSSzFF1Y2VzfSZzUarMvpNvT2rE2bNnTPoaXSAnphOUtrDU1H6lMTon YxRiKkWId8KvRYCID38lMrFwMMzewL/6e05JoH3HKA5PAJZnPLMb+3RQ2 di8iwxkLIrgs6ly2aGSESBp7g8JjkwGgJZxyGM4xGTGUL5un9IGs06pMF SUG7OjgrkUVnCzpT+raqregrjPAw0pQyNTEgI8hBkckBzMM+lv/577HGJ GfAQVkBwlpmpHkzsWpGyEdNfJx1KAc9XMxEqzyd+JtfZNliTs/3EMpdRb A==; X-CSE-ConnectionGUID: ftkizoJNQEy+/6No+DOaqg== X-CSE-MsgGUID: fBu8amG2TXWzLB6glRoBdw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048057" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048057" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:02 -0700 X-CSE-ConnectionGUID: qHUFe0YmTs2ScI91qq9fLg== X-CSE-MsgGUID: Sy+wHb3dQmuw9NbN+R6Mcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919373" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:01:52 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 11/55] media: i2c: imx214: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:04 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index dd7bc45523d8..73e7bc2f85c0 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -1271,7 +1271,7 @@ static int imx214_probe(struct i2c_client *client) =20 imx214->dev =3D dev; =20 - imx214->xclk =3D devm_clk_get(dev, NULL); + imx214->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(imx214->xclk)) return dev_err_probe(dev, PTR_ERR(imx214->xclk), "failed to get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDD462980DB; Thu, 19 Jun 2025 18:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356134; cv=none; b=eI1xYwC702OOka2wNXsTsLfioCM3MqN4/XgXBFYVc+vUuMVB1Kqn3OgEAEPUGQokct+D+seiknD1MPhrU50Ilf9m+3EYJgTrVekLJO1TBWq3QTYQKvAigNC7q1NXHP/E/5e+pWYDJkZ1yT8/2FlKmcRXMa+jmqfIp4ZmgxdbHFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356134; c=relaxed/simple; bh=C1vMfDnqWac0SNTLgP5bLPIMcw+naLfxvXI5keuItAM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rVKuXTMsa9d9oTyAFrRx/ScSdOeK4rxnf2HWz2tqH/A5cN+luH3oONYW30aDQ2mBNOusfIYjk6Y6OyctfN8vS9gyWPJRpBRTzwsczUsdYEFygt1Hx8m0ka7Je9qMGAc6BIBOD6woIvvlOVVx+DwxBAAEBGJ6Dofc6+F+Ho9dYZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Qu1nktZW; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Qu1nktZW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356133; x=1781892133; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=C1vMfDnqWac0SNTLgP5bLPIMcw+naLfxvXI5keuItAM=; b=Qu1nktZWrav79sZ85kmegPLPbRQp5kqSwTOL1uCkf3z96MAQvWzJeQ5B PofW7M+u3vZek/sMm10z4O1XVd8IcuM1iC0Q62/qotlE9kX1v7fathsaz 50WSd3XO6eiljRY8/DfValMy1o6fU4nC4I64nlK45STiPTFM2WADUnYiA KwH65Np4/X4fB+27Bez7Tj7wHvXrHdc29gvk3LUAzpSXgHdKLqnVxq/df P9luudz0bf1mJmg6Qb4hmZ8aWvp1y5aumusOpq82/8mqgMrkjQO0ZZpUN awyFeYKH6dZwS5xOmNi5JXmig97BoJFkLY+H2ppPHwbj7Dm7lqwiBIP3m A==; X-CSE-ConnectionGUID: RKvsB+atQP6LilHLmTc4DA== X-CSE-MsgGUID: m970kBa0SNC768i1wKTBvA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048093" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048093" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:12 -0700 X-CSE-ConnectionGUID: ed6JtqWhQgm3iT9RcZwDbg== X-CSE-MsgGUID: TkYXesncRkiizvMcGNQrtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919399" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:02 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 12/55] media: i2c: imx219: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:05 +0200 Message-ID: <0efc2e23bd82294c0b6901188d672d58879c0804.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 3b4f68543342..bb7808515178 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -1188,7 +1188,7 @@ static int imx219_probe(struct i2c_client *client) "failed to initialize CCI\n"); =20 /* Get system clock (xclk) */ - imx219->xclk =3D devm_clk_get(dev, NULL); + imx219->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(imx219->xclk)) return dev_err_probe(dev, PTR_ERR(imx219->xclk), "failed to get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ECDA2BF3E2; Thu, 19 Jun 2025 18:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356144; cv=none; b=mm5OhgQQ8fat3lDCd+OcvO5bjGkLdWwGF3OVwbodd/vCY4bL/5j70QJs5gwqBAXyMYz9l7QpAzERiEKjnDrKz2u9+PEHB8SeCFnQ/P6f8cseC5cv6ajjxUD327PCfKayZhfvHtP2050QgcomjuZOe95XG7b4RXRIEFUgFFTD45k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356144; c=relaxed/simple; bh=fJqzzvXwqVFvHg7tZmNtL1fJddi7wsl4qsm/xDfvmXw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RUDNq3r+H9L43xQIKlL8kVph3VTeEYnmRefoRGJieAFKFfZk0sQT1Mbp0EfVAr7AEMHlVzXk9B+2LuP697o69oSBMyjO5rXg+ZaS3pLyD2ZhOV779EhWkURr9jd0tTrV1LG1HF49AnP3ZlKjXWy5zEhTd537GTQd/Dfu5GBOKcg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kERAWvhb; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kERAWvhb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356144; x=1781892144; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fJqzzvXwqVFvHg7tZmNtL1fJddi7wsl4qsm/xDfvmXw=; b=kERAWvhbsEQzUr7aUx2ALxMfx86Me8v893PtVKMP6SjVOy7pYCD35FIn kxPHz4inrhkKNh/saiOaz9Nf9DCQpwVFjM/+rgOaO5m3ROwek00/kciI8 gFESvJqxhqpd3ogng+5PcZD+uwBrCd5142UOLiuCgpBKHxAwYcGNDPsv9 arL1no7aCaES/b/ZfBkjsSggNNwzvAclig/z0s6MFv3Iut4eJx7Gosjb6 dhp1lTH2aHcn4UU1BGAysypifuowrEmQysqLJk9krzccy5BHr9msenOlu mydjs4hffpd/43fsLQi9wjlRBaHmwhyZayMvX87V1GP4wTz5bry55TuGL w==; X-CSE-ConnectionGUID: 8fXuw6ltTgaQgXB4NDG6iw== X-CSE-MsgGUID: uSSQERhNRN6AOHng8JzZmQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048124" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048124" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:23 -0700 X-CSE-ConnectionGUID: R1/VvB9aTCmuUu607rlpFQ== X-CSE-MsgGUID: jLmvdjq1TRmXEFaCVNhBcA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919413" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:12 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 13/55] media: i2c: imx283: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:06 +0200 Message-ID: <4ed793d95d4fa0b49dd6e06bcc03d0b758eed382.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx283.c b/drivers/media/i2c/imx283.c index da618c8cbadc..582fb528074b 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx283.c +++ b/drivers/media/i2c/imx283.c @@ -1462,7 +1462,7 @@ static int imx283_probe(struct i2c_client *client) } =20 /* Get system clock (xclk) */ - imx283->xclk =3D devm_clk_get(imx283->dev, NULL); + imx283->xclk =3D devm_v4l2_sensor_clk_get(imx283->dev, NULL); if (IS_ERR(imx283->xclk)) { return dev_err_probe(imx283->dev, PTR_ERR(imx283->xclk), "failed to get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35D482D541C; Thu, 19 Jun 2025 18:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356154; cv=none; b=L+b0RNpBqEC5JJVySxwrAcsZPu75bz/WOtYLSJpuadT9jSNMSFMOZ/HnEOTEdZrplCh6a3+UoEAeNpH81QRqIsA/J5h7IPTcg6/f372E4eBQT5R82kyq7cdQ409C594L3Vz46bdzOkfO5BDAk6qN6Xzlv330afHpFw2YEqNaIgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356154; c=relaxed/simple; bh=LWwCH5KxP2Ap6b2HmZwqNFE6LZAv/JOWiL/Ejy4wetY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EWTy5O8iiyBvbUAa7isTMplFqNICi2uYkcpD90lNN2D8Myq1D0ANFvAyM7odpa8uKkwcmgiNGjQgD50rEQwJb99u8UQdUtXG83IyIOQAvCqwAyOr7VOXcaW6gf9r163nY0O0/xtvtHSi8GHE5LTkckiYM9od/ebkR90Hk9Ci87I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DmEbhSkb; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DmEbhSkb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356154; x=1781892154; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LWwCH5KxP2Ap6b2HmZwqNFE6LZAv/JOWiL/Ejy4wetY=; b=DmEbhSkbLebilwRZLgNrowmNGGs7VW6IVGOQknUgVQLKPGAgzs9JsUa2 LduTLUcu9sLuQKBReevn4qZJgnVKHQ6k9pkLcp4TV58flMWSry9qAHrP/ tovtQ7+1CfrVMs7lcI4qtIBphEScGrkB6NmCxMzl3nlVCqQeRAXS7dG21 nZ4hWYcxTdmsgDUqGhZ+QP3Lk4G4bqso6NO1wN9eGx8IJ/GNmEBTyTH5+ IDpa2OZiIJzXPs9bqZ7fJd1gdeaIq6WJaNaWwRfdHHxtAJUP08Ejt427R zNKPWlKJF7pq5z6gWMd9JDHV3y01pTfkxDS3PpOxMBzqsQJGi3SSXgxAN A==; X-CSE-ConnectionGUID: uiWTHSQJTCCuv/gJeq2jZA== X-CSE-MsgGUID: gIFGq5HSQaOAlfXh7yANog== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048144" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048144" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:33 -0700 X-CSE-ConnectionGUID: G9EgXEBNR86mpYMwp6p63g== X-CSE-MsgGUID: X/sl4d83R/CX2kPc+obU/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919428" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:23 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 14/55] media: i2c: imx290: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:07 +0200 Message-ID: <82eaf5de9eb7e66bf435f23fde5f12bb89274e57.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index fbf7eba3d71d..759df6eb8545 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -1600,7 +1600,7 @@ static int imx290_probe(struct i2c_client *client) return ret; =20 /* Acquire resources. */ - imx290->xclk =3D devm_clk_get(dev, "xclk"); + imx290->xclk =3D devm_v4l2_sensor_clk_get(dev, "xclk"); if (IS_ERR(imx290->xclk)) return dev_err_probe(dev, PTR_ERR(imx290->xclk), "Could not get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99ABA2DFF2F; Thu, 19 Jun 2025 18:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356165; cv=none; b=enbYiRmHYOrM6hMjxGm77JpCkisdVrrvzpMHZU0WTq7kIFrEJ80rMgjYTlNUiPsKKxeOZ/Dqm3NWRl7c61yzA4nNW0JG3qjwdqE9c3EqrLZ8JvgVPu4esF+GOtS07+Uu5oOHWtprFdS1+LHf9SBbHr7I6pOqOMY2rK1r6sxf0ZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356165; c=relaxed/simple; bh=s//CA/VbyepwOorzKLzN6G5UE58q7aAXWib97wH/wVE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FoFVbgtY0ZE/M+PzBB28rVqp06HfRKQ3FAYtJ1q5e1LBC1umTpug78xhxiNjXIz010mPj6T8dijNXoWz3RrppgWFRJ83nOAibi/s0PQWFUh9BY1WhY9NtBKIE8AhqSyvUyBhkQQ62WwtaUvkxhoWK4aXiSNpPPLBGlr9qIFEmQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=U3u7rjU0; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U3u7rjU0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356164; x=1781892164; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=s//CA/VbyepwOorzKLzN6G5UE58q7aAXWib97wH/wVE=; b=U3u7rjU0oayTrReZnHWywaZbh100hgO4og0iWYnWGc1Ykz2s1U+bD0PY wordy/CXEEVA5jS8W2cAyb6UB0wVzLUJJDIiHnBTW1ws9Bu345oAWcNqK Pi3+wy/M79UQz2IYA/nfVgH3CBrY0zt+d3Ee+nQ2OfXX09udqRSzA/sun 2xgMFKvaYhlEeQri+QQO5rqJTsU/GwZy49zRz9f7Yztudxgl7SPANlXaN PbjkQuso1p1fCh46EawvvUFjUjCWdJZd8Go0RNzWWGFsiVnI2ljbmz0Jh V/4en6rbSGvT1CLpKopQIQk8dwR/vYHUmSB7L/KXS7jb3KiVDmwjwboCH Q==; X-CSE-ConnectionGUID: v5iKMI0fRe+6M7qH2cno1w== X-CSE-MsgGUID: ZSlfv7w+SmuiZNBbf8qYyQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048175" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048175" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:43 -0700 X-CSE-ConnectionGUID: wgvKYCgcRN6z6lhCdy3zYw== X-CSE-MsgGUID: EzQ80+3OSpOtr0OtxALNGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919450" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:33 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 15/55] media: i2c: imx296: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:08 +0200 Message-ID: <5b2970dfe51bd7091eca86973b6ae2dcc4117e24.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx296.c b/drivers/media/i2c/imx296.c index f3bec16b527c..3795b75a4397 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx296.c +++ b/drivers/media/i2c/imx296.c @@ -1044,7 +1044,7 @@ static int imx296_probe(struct i2c_client *client) return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset), "failed to get reset GPIO\n"); =20 - sensor->clk =3D devm_clk_get(sensor->dev, "inck"); + sensor->clk =3D devm_v4l2_sensor_clk_get(sensor->dev, "inck"); if (IS_ERR(sensor->clk)) return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk), "failed to get clock\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0841E2E719A; Thu, 19 Jun 2025 18:02:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356175; cv=none; b=JBcvNWTIMmsMH01OllcWUBBEvRSlX8q4nvmxcOxZAzQdnkCdtDUIb054DUtC5QqQRdexb1UDnjJ8jMGTK+yE9b27wB0YnAT0FqtTf4pUlId7TEY2J/3fLDxef/n5qD/mheyP/cIUCEqhs/i44cFqgAeS85n96OxwkirZRv6ozFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356175; c=relaxed/simple; bh=v0j1Sia99c7UJ2fUO0kyuHgqsIFrW7tYe3W1QJdDZmQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kAPK7zuawLZYCJOE96yz4Cp3y9coC2/T/sJLhKCOcM3mSMhMmeuOmoMwDN57lEmJPjnHj53pW8UWl5a6xRBDdQOVeEWt4J3EURTaDFQKjmA79LkGztjzbJbJdDdpAvdH6ByqYDQp1UbI7jdieUpMw7yeafbrUsa5LsNsPsWoMlU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=i+VA1ZMy; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="i+VA1ZMy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356174; x=1781892174; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=v0j1Sia99c7UJ2fUO0kyuHgqsIFrW7tYe3W1QJdDZmQ=; b=i+VA1ZMymq1H/+XVtKkIiCuVpQxzjl/XOhZdRoFDcZQ8MO/hHZEzja7n uHPjRp36+sopB6S+TJQFTL38xa97gaTy6JateeQcSd4xdoMX2rbOnn/Xr 78xUCc4bTaZgO2Kbk0ei1ExumBHQjpkANbR57MApRGVkVHPfBooaCepAU wKo1ilz3iKPGd+Rb96nnsX1hF3O3cO5azhjCs0AEx3EXSZ67P5eVHkGlc NSkW7hzxSyv6zOPgEZTz+3Hx9211jAb3OQxQpa6WRyflGPL0CqwXmGOjG YQohBG/TGxRJYZX4pN3mmISlR06NbF3lUJNGCfFi5sUioRx4FicQHioky Q==; X-CSE-ConnectionGUID: jZgzzpi/QwGzkaRY+1crcg== X-CSE-MsgGUID: KDyIpMVXQjuy+bgQhSD17w== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048210" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048210" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:54 -0700 X-CSE-ConnectionGUID: kJ9JMtQaQluuuYo3y82oXQ== X-CSE-MsgGUID: zue/5h+FRt+E2+x2LG92Bg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919465" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:43 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 16/55] media: i2c: imx334: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:09 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index 846b9928d4e8..7a9b14d102c9 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -997,7 +997,7 @@ static int imx334_parse_hw_config(struct imx334 *imx334) "failed to get reset gpio\n"); =20 /* Get sensor input clock */ - imx334->inclk =3D devm_clk_get(imx334->dev, NULL); + imx334->inclk =3D devm_v4l2_sensor_clk_get(imx334->dev, NULL); if (IS_ERR(imx334->inclk)) return dev_err_probe(imx334->dev, PTR_ERR(imx334->inclk), "could not get inclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C9EF2EA147; Thu, 19 Jun 2025 18:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356185; cv=none; b=OcPoUqzsC3Q/4DgcdG7eSJp3HxiS/YacAKyVgzjGhaDwDGJWXgrnDGpCEYxV4v5+yqHShxPTOZAaXNudYX/1wtuJw+24o1m0cq958B41CriDAfC9VMfxpeyusE3/TRLB390v24qIkrt4QMPk7z7pgu6rgzJWdIqMoj7JO2Ygka4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356185; c=relaxed/simple; bh=NSnfMG65i8HXSjOSHVfKrXj6MqCPtrvyaOnkyhUpiEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C3NQZQ6lHNpE7PO7EWT9VlPNHMOyK2b4Z56jJ+QkbG0cJK8o/TnfXqAsM21qp8n4J6fKV6AYODkAbN2/2w7lzToTsPqwCWfpjQrTpnVzDCFze5Ib87cHrt0upiY/xUWp9N58POgzZkg1lb1ERYUAHxt/AfQleRS2tRtHfHRsQVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=goBgtnBd; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="goBgtnBd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356185; x=1781892185; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NSnfMG65i8HXSjOSHVfKrXj6MqCPtrvyaOnkyhUpiEs=; b=goBgtnBdsUxdiSISKXu/RPcJpySZTOJBYnPcwaKtarwI/jd63VGrnJ0u fqY59VZMD0a4hs+BDKYsuNPyMu4U8BVHySz01ygQSbvDw2yVqJvOQaJnu BmeD9UDtCCiCnJnSGznHwCJWta69FlkiTaIcdcWTTo3cpFqL63rkfUoE6 v0TAIhqtovlAqn4vBFtXA2ocWv/5jn6UO+b+RGdrBegSVWEMbBCLZZnTt AUrCG/1kwArKxdaazxwBaktcC8+MKnReiocEsg4aNDR6hz13saQvBaSMy mSVVLvPFg3CVPosO5s8k+58xL9QPDzmb/K95Ct0TfESWTC/eaCVRqQuyl g==; X-CSE-ConnectionGUID: w7i4A++5RnChFw4FSWpQmQ== X-CSE-MsgGUID: zQ6X+O9pQmqXwx0BcuLz5A== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048241" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048241" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:04 -0700 X-CSE-ConnectionGUID: k91rygOhT723GMtFxvq20g== X-CSE-MsgGUID: xBw2p86STBqC16wUgNY5Vg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919482" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:02:54 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 17/55] media: i2c: imx335: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:10 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 9b4db4cd4929..16173aeb3af0 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -1026,7 +1026,7 @@ static int imx335_parse_hw_config(struct imx335 *imx3= 35) } =20 /* Get sensor input clock */ - imx335->inclk =3D devm_clk_get(imx335->dev, NULL); + imx335->inclk =3D devm_v4l2_sensor_clk_get(imx335->dev, NULL); if (IS_ERR(imx335->inclk)) { dev_err(imx335->dev, "could not get inclk\n"); return PTR_ERR(imx335->inclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB0AC2EA147; Thu, 19 Jun 2025 18:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356196; cv=none; b=taVpXqQtbYYV67MKe3D+Lm2Df5NUulkim2snTo7bwERUZ21P+B84hx6JYNPx8W76Sz+6sEsZNH7q15IKtHCdGJnQ0qQwt/e6ugsG94+hTwpwQlaafx2yrWyr/smOIunrkY2KGX/czXMq79HZqCiHk7vDudWiyUZwCkaUXC8EOo0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356196; c=relaxed/simple; bh=vTSgV68UOIYAU2aC7cw5c9gGDd0x+0hJZTZudwtupDw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mwxRqTRWNfiZk0DOW/6biugUYkpwXJ++AwAcmPNp0Tdg3sQc6b9AxMm8xlo6MX6v9hMLh/9U8eTXlo/WdYTX7C5oJNKaMF2W/MSumUkJT+nKSEfXOGKW+4eMdeEO3f0uV+b9vvsZvVD0oLe2c2NARtgBvxXLRSYJ5rU3tdvWXJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=N0ymlh83; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="N0ymlh83" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356195; x=1781892195; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vTSgV68UOIYAU2aC7cw5c9gGDd0x+0hJZTZudwtupDw=; b=N0ymlh83PEFEVO5PUmFLDooJCbj9TSt9pyzyZSJ0r7UObq/DMxme2Gp8 0nRGUIutr20rkYNp9DqZ+3gQjNFjDph6vkkCamnW+yMkPPPiMthPjgw/a 79E1/uhcl2MGOK9acjmb2+HDXV5XGXioxTRuKIS+Ce+MXgjD2kpH7ORSJ dPYnglNRpJt/2lgZPZiOPT3n0GjMBpZGbXsiQ4L7/JjusPbvGAObiJU3w UM/vRchRo0dDoVeA5TCS+rgMncy5J+SpmaPn8EfoCff+vfSlMhkJkYCld 0KYZpVjZ7EUCNdpe0MGcR+NKFsIAL9vGhTHgRbBZ4Z4M2gkxCiQjic169 A==; X-CSE-ConnectionGUID: jJAQK7bOQjyQ4PyVzijqcw== X-CSE-MsgGUID: sB/hOIiZSF20iBSN+xqEIw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048269" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048269" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:14 -0700 X-CSE-ConnectionGUID: hJ6Ii08LTg6itNLmxdD5Ig== X-CSE-MsgGUID: Di/KpJ8DSzCpoKnj6fi97Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919493" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:04 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 18/55] media: i2c: imx412: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:11 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c index c74097a59c42..f35d63ea6c08 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx412.c +++ b/drivers/media/i2c/imx412.c @@ -933,7 +933,7 @@ static int imx412_parse_hw_config(struct imx412 *imx412) } =20 /* Get sensor input clock */ - imx412->inclk =3D devm_clk_get(imx412->dev, NULL); + imx412->inclk =3D devm_v4l2_sensor_clk_get(imx412->dev, NULL); if (IS_ERR(imx412->inclk)) { dev_err(imx412->dev, "could not get inclk\n"); return PTR_ERR(imx412->inclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA29D2ECD34; Thu, 19 Jun 2025 18:03:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356206; cv=none; b=NWnt5NyJZRtcJzJB/d7tYL2acJKUjpCZ+a1QiQOJNiQtrP4edb6UZb9y/eJRmHLysk+BsUYMkRYSNQE6NpDbG3J6bphuW2XuaMF5V97znAxct9+9p3SGDG1ee0fyfBc49eBe+2eSfDny+WvDx/EjTgSZGeaDKniA4sc7SWl1WGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356206; c=relaxed/simple; bh=ile0ZtDaRkGf+js1FhH3hzhWA1jreK0ifRYIkaP4Qwg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qlHkg36FbLRGYb1CjDHnNhkDQl87BK0z0oUqXhMWJLJ0oswGzepSxL0RN4cQ7onaxPh4dKzr+r82LSPUhEmuK41QuLwS6WEMuCrN5ytgSArnabR9NKUrS60jvmlgo+NRsEX52I6ifdEc+rXBTh1BDWYi0VTCgBPJXz5m2J9A1YQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W3nY1c3T; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W3nY1c3T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356205; x=1781892205; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ile0ZtDaRkGf+js1FhH3hzhWA1jreK0ifRYIkaP4Qwg=; b=W3nY1c3Td6JBoE2yLr28mTGSAozZaP+pshBLGw+vQl2pNm/PVm9lgI1f I9LgN78UJBGLsCuuav+oePSDFwexxRwDxVe3keU7QQxxFYJ7X57IDdlMq ML0HzXPSxzUPwxa5WMyo/+YvgEucRmm082pt52qB94L6oDvAsfIC4FW4e p+9bwz2gJNlWByQda1O8f5uqrwjEeMweHFE+eNB5/2IA09dMy63eoU95f Xw6dUY09e8AAUzeyuskQwFHuKkD5A5btTxjKhfgPj3W1+8J2Hua2DkNQE PeY0Rtxq1LB/qgu9Xk9TxQYxE+lfp5TSjqWZAC5+fluStPKi53lIY18v+ w==; X-CSE-ConnectionGUID: hIk/D8INS8GAD+v+m8DsZg== X-CSE-MsgGUID: 2VdojRwfTWmtGgutWl8FxA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048297" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048297" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:25 -0700 X-CSE-ConnectionGUID: 25DIWAOaRSqAo0s2mRvxWQ== X-CSE-MsgGUID: fX/DL5E0Q8CK1rMUAtQdpg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919503" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:14 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 19/55] media: i2c: imx415: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:12 +0200 Message-ID: <0cc24a56cfdd04b871f06a12c30e40bf1012935e.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c index 9f37779bd611..f7897660f44f 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/imx415.c +++ b/drivers/media/i2c/imx415.c @@ -1251,7 +1251,7 @@ static int imx415_parse_hw_config(struct imx415 *sens= or) return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset), "failed to get reset GPIO\n"); =20 - sensor->clk =3D devm_clk_get(sensor->dev, "inck"); + sensor->clk =3D devm_v4l2_sensor_clk_get(sensor->dev, "inck"); if (IS_ERR(sensor->clk)) return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk), "failed to get clock\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19BBD2ED848; Thu, 19 Jun 2025 18:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356216; cv=none; b=cicXdwB52ayZMUD2pyca6Wik6o9FWxYyzWQ4iMFJvxPWTHM0zXZOkhM7vcO5CstueVgD/odib4/NNJNZ5BRVv8mLJdMnCPMrOwPfT4EbjFjUK3AxfpJ+NsNa2SJknyTW9ZnCUrl6cVZAEpHIm1Jb/u7n4+DPurZ0Mcpjwxjo0Kg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356216; c=relaxed/simple; bh=TkmcLKf9kQVLg12uh3HsWKpr1QFdI/FOTRee/sqKz44=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tOP9SxxK+oUWCl1ngzopxZmvZvhW8If0gryyYyYE7/kaYHkyBb9CV1fY7Fmbsia31pTI0JtmUt2t7FIcyF/DDtG4pSzeZs11PUS1LRyx9WMSOB2PYZHOKrTxAPdJULGCMslT6pPFpSoWynKNpawQ5HFTk3wur1L7nPDd5R8gbiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=l4bDxwkO; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="l4bDxwkO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356216; x=1781892216; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TkmcLKf9kQVLg12uh3HsWKpr1QFdI/FOTRee/sqKz44=; b=l4bDxwkOx/3hkbf7jZbLpC86+i7EZ9SzZhaJZzChGdBTwjT4cxN/UHpB U6lvz3OAGzyWMeOKzoOta+XEg0XpM0XwLG0g1Z1hcofS+6e4DyGZg9wd2 vFtxyI2fqtuaU8hhVbCAKEE5I/V2AKnPDIyU7v6igIFBykohMDzhoBGlW aHvIk0ZWzNvllPLQDdSuEfvGLJ6wsSHvCM7YCiPuLICWZ5NPn2xG7A28h mng0NBe8C0OeOyb2bFKIaMWXnkq6f8fgjb5KkkDCZ2UzRLX6OvOhi2LUw xNgOClJpLScLLeqLq7CGEFWsg8JW8scWz2tSiqmjsq4li3gGxqTw05s0s g==; X-CSE-ConnectionGUID: QfJDuj2qQR2yxf5flhTHEw== X-CSE-MsgGUID: m1+kzudJS6u4y9GZpNlCDw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048325" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048325" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:35 -0700 X-CSE-ConnectionGUID: c/YOn5flQ8uDrUSAYjSizg== X-CSE-MsgGUID: 6CnltQyKTG6TjMDeegtaaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919506" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:25 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 20/55] media: i2c: max2175: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:13 +0200 Message-ID: <5d6be0edde5b0810b5560baebd3f41bf78da9521.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/max2175.c b/drivers/media/i2c/max2175.c index bf02ca23a284..07b6e42567ae 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/max2175.c +++ b/drivers/media/i2c/max2175.c @@ -1305,7 +1305,7 @@ static int max2175_probe(struct i2c_client *client) } } =20 - clk =3D devm_clk_get(&client->dev, NULL); + clk =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(clk)) { ret =3D PTR_ERR(clk); dev_err(&client->dev, "cannot get clock %d\n", ret); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4997B2EF288; Thu, 19 Jun 2025 18:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356226; cv=none; b=pVJTKYqf5iA3g/wnmlLaIehQnUlvRwcf1BW1zrRqdmfbbmfGZHtzcuwxUUrS5Vv5zM2olt7Zi7qBqBX7bVwHfhvpFi3HECWB5kfFNaRJQmKWxDrUpWwSn6wm49Q2lk903cbkPAzqKUGdbdSnvs/jBwAtxMnKgSQR/Xb7BLU3QXk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356226; c=relaxed/simple; bh=vOEy371+AU6g99Pp9WvTcS60oQaQx4F9TzmC9QBsf2k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FKhJzQA6RYeoeLZiytzllOjjV3G7X1BP8GrF0K2vlm6yWq5QYX6hk4uZf0dn0Hy5rnYwDy1gEnGSlC3VvDXOHq9PzBBr+QQzKS++eJnfYpGhQPuRg8U25rHzbgBewgtYZBUII0iw06rDBIrWA8LPRg76Ij8+J1C5lK9SlBI/mLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Wdki1TcB; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Wdki1TcB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356226; x=1781892226; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vOEy371+AU6g99Pp9WvTcS60oQaQx4F9TzmC9QBsf2k=; b=Wdki1TcBDoTHlevIUXxXhayyTm7W/P7a29dumZcUSApzZWn5J8+gOFgA 3R6uEi5edsLquLlDyXmtwuRuM7PKIDml4VAPAWlOeDhE0KRi51kApNeKu GI5oVrU7T19+3PWjEtbS69i5JK/n1engR/If1WKnnJdwtH3DKWTyE33bX n5IJrd9rLDmZ5Eeg94ltcV3lQfa6V9AECc8q8WfVwLWjIzDPBWOac/ivc vnC6K3zqD2Kd4HFXVFzz3N42up9wddWE6Lh1ZIpjPuGZJcoygmiM6ReVD +gMGixXSQvCPrWpasm3SGuPHuGfbxemzbrA0TXll0jeUfrLybXiXH1ob4 A==; X-CSE-ConnectionGUID: pKfJUZSNQMyYrhAYlmPzxw== X-CSE-MsgGUID: SK7X5myPSZikOgvplRywdA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048364" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048364" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:45 -0700 X-CSE-ConnectionGUID: iRyYhaEVQli9pDfqacwWNQ== X-CSE-MsgGUID: r7wFbTj1QZ2/NCZpCCwZTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919517" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:35 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 21/55] media: i2c: mt9m001: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:14 +0200 Message-ID: <182e46db14360970be1761933a50e641dde62a4b.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/mt9m001.c b/drivers/media/i2c/mt9m001.c index 12d3e86bdc0f..184f0fb0963d 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/mt9m001.c +++ b/drivers/media/i2c/mt9m001.c @@ -743,7 +743,7 @@ static int mt9m001_probe(struct i2c_client *client) if (!mt9m001) return -ENOMEM; =20 - mt9m001->clk =3D devm_clk_get(&client->dev, NULL); + mt9m001->clk =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(mt9m001->clk)) return PTR_ERR(mt9m001->clk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1A1C2EF9CB; Thu, 19 Jun 2025 18:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356237; cv=none; b=P+CCDERjtDYnXqQ02/f6V1TD0JbmIPUTuuJc5QSY0hCEyUB1LU6qdeivjzYTWa0byoW3L5hHQy2MdhCyYAAV3W9r67mWeo97ze9AE8OK9mZaYKfEy3kXgfR2KILR7qkn0NjYcVVXrOLtDtwm824eqsuSSRCOHbfy/B61Yttc5l8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356237; c=relaxed/simple; bh=Aq+cOsyREo2ELRLxvTpr3QezU4OjKJPCuGQzMllr1lQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J2BH2awKVtUN3uj62wMTO5Af01L5U4vBVfVP+x09X9afL2WudxMhNiIN1CO77csSFDGtqfbTTFpg7wi1TQvyZeGbrPDx4PsArAWokEaNFyIY2fFAiWsIFEhiM0DY/VH/2yaTCErZ2BBS+Tl4skZuqWN90ZaHY9hf05/BLfEckjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jMhaG96a; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jMhaG96a" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356236; x=1781892236; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Aq+cOsyREo2ELRLxvTpr3QezU4OjKJPCuGQzMllr1lQ=; b=jMhaG96ayNjg+aW6PBY+crD78yAiYvh7x8rxyNqUANMtNl/Q3vicMc+m Ik++OJboIvOLoEiNftI+EV/YR+9zxBWsTPjcVtUT/AOrIAxSAKK3mtLwV d4WhK9QzQmg8bB38dyEn7HLUnvM6H5RErCo3STVaFLWylSW2FwqnI4lFS fI5hZ5IcV9Xjcps8zaYxiuHhoYFHeqyEQXao5XfSWOiJ6GgV/CyNm68Ce /AiOXF2wc2vYv7v2EQ1hgQCIdI+EIfT5yA7RkCgbfXiaI5sLJ56bDQKlf HCbZI7VX28scjg+I5nPTbUHZ+z1dCmXTPRmOvH8tISx9SwtWlE21hbewE Q==; X-CSE-ConnectionGUID: I8hoM/1YSu6M+PVFa0THcg== X-CSE-MsgGUID: uwya9ilGRAmtUpBeEPWT9g== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048381" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048381" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:56 -0700 X-CSE-ConnectionGUID: KbGpNULCT+WBwCRN+pBGIg== X-CSE-MsgGUID: evB0gVIHR9iTLnAziS2S0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919548" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:45 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 22/55] media: i2c: mt9m111: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:15 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c index 9aa5dcda3805..8011d16d4874 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/mt9m111.c +++ b/drivers/media/i2c/mt9m111.c @@ -1279,7 +1279,7 @@ static int mt9m111_probe(struct i2c_client *client) return ret; } =20 - mt9m111->clk =3D devm_clk_get(&client->dev, "mclk"); + mt9m111->clk =3D devm_v4l2_sensor_clk_get(&client->dev, "mclk"); if (IS_ERR(mt9m111->clk)) return PTR_ERR(mt9m111->clk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA6D42F0054; Thu, 19 Jun 2025 18:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356247; cv=none; b=lpjgCskunOQQWBagjY6iE2ezrLUPncga9DYYBewFYBTbKTYb4GiBRVtc+URaYZ68P7+TjdXRa/YFZD7tfo7SGlm1qsdOXelJi9DObV8NYSkH/nx8970y4Q9Ym1Y91VkubULGuV8b0B+D6VoFM+yeJ5eZaxXI2dHRDgcgOdfErpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356247; c=relaxed/simple; bh=3GoGpJHW1OACvWTm9gWRMES2uxAkjp/4fTMmflRM0Ks=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CjhImu4dBqxwgnW5hIHWXjrDSvocCEDXMOstqFm3HLfj3Q4LNVQrkxOki5UyXv86fJ5YWdAQZ0sPEpqgwXCIMG9zF3W0FW5JwXBdnm5HTPUprMxyDA8WCL07Q7RYkG+CqGhfOeauLTa4ufVQbcMAxG4/3uX5GxTZZAH6rBctb9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SMb7ygS7; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SMb7ygS7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356246; x=1781892246; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3GoGpJHW1OACvWTm9gWRMES2uxAkjp/4fTMmflRM0Ks=; b=SMb7ygS75GRJD3S3rz4W33mmKDoCAjAwSk8aOfi5qB3ir9kT/ITzq1eH SxVa0UQ8ldA7hqpv0vVukzXrgAukfrrvlz6/hIQufdeSGiHqafRvnmCi5 /iwnCGvoykHyP6tHNoz5c56ShZIhXNBqYIwomxbLthpxsg63kmhpzVW+o 9wx02PbuMRzExz3B//s0TZDgGQeP76YJq63949UUOgk6yb5OEe3eaPa9O kukEzwt6MM7/eRiP2UE4RzdQCqDCVRBj76aYg++tNwoG3VdkQH2avNCtQ R5N19WdJZkwBot2L5WiLPBvyg5jjrUcysjE/L0fh24+2Ku6NVo2b5Lc21 g==; X-CSE-ConnectionGUID: dM0DFTvzQ1Serm1IlbrPeA== X-CSE-MsgGUID: 6K7lFziRRYmkN2RVu+WHhQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048402" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048402" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:06 -0700 X-CSE-ConnectionGUID: mAjiEWdnQo6boPhO9mHS5A== X-CSE-MsgGUID: 9/7nxYHhTbagncTynufkXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919569" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:03:56 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 23/55] media: i2c: mt9m114: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:16 +0200 Message-ID: <391c9f9f82fb4b4fb91290697feae147edf89853.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 5f0b0ad8f885..bef2512e5d48 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -2360,7 +2360,7 @@ static int mt9m114_probe(struct i2c_client *client) return ret; =20 /* Acquire clocks, GPIOs and regulators. */ - sensor->clk =3D devm_clk_get(dev, NULL); + sensor->clk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(sensor->clk)) { ret =3D PTR_ERR(sensor->clk); dev_err_probe(dev, ret, "Failed to get clock\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318C32F19B2; Thu, 19 Jun 2025 18:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356257; cv=none; b=HRcuOoGIq6W1a4t1xiExvdgKuiQohTcFu1cKgz+069be7MYIsfzTS/gA5K7v0cZjcut07yOmdqDfL3hpvm31H0Qv3rclbvrkJ5j6Ix2dLk4hP6Qs6NKNhP5+QdvOZEG5GPU39o9duvBcr75rJbDhIFTJqlijxmeokhSa3z2Wvfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356257; c=relaxed/simple; bh=yTWEq0Sd7gUr62Nt43VucV+iOO3A9V8QhKiHwWfElYU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AqxlIyd9prFLS7pk7JuqpigUqMlrbmq2bgnFIOPoywu/NmZWJ5AB0EsdGopwpvhX9H7fLUzvzcOARdnKwJKqZWNXQ6ThLHdPQDoAKy4Rykb/l6kHbxah+jZk/mkZRFqkBNssORWItYpOunu5U5I5gwjAWvYEJ21uu68QBxeCQJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=E2Gg6FGH; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="E2Gg6FGH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356257; x=1781892257; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yTWEq0Sd7gUr62Nt43VucV+iOO3A9V8QhKiHwWfElYU=; b=E2Gg6FGHQMZcpG3jHpC561llX255PUTthBuAFvkbVyHdY5oJTJwlanQj wZVMJniNqSunRQEbRpF58PHaNJewF99A+lfKX/Va5d5bCpHv6q+L6+aD8 2xuzn/hoYfyzmjvyZKzuC6VhRdhe8aD9Icm1kHequ5Sjb8IG6aD32oj93 wOnsn1IzEUqIHMZVfUnIePjmsxcq3/h76vCC/WbegBD6StYZJBYlZuAJo +wqG3JxncMDl64SFpkA7gPyJ85JG3jz7DR1BdX2fPSKP3RHrm3ghuRGsJ vjHW+8Qoj7jsLdpLtucLfl9FuYikQr5A8hsyVMqyDKQanGy44hR5+zk9j Q==; X-CSE-ConnectionGUID: 5OoeUomOTVuDzoUlF18PuA== X-CSE-MsgGUID: sF8e/fT9SDWzoqW4YbXhrw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048435" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048435" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:16 -0700 X-CSE-ConnectionGUID: NE5lEcQaRV2JsuFWDoNriw== X-CSE-MsgGUID: Lw+LnM5tRtOkgidNDzlmrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919579" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:06 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 24/55] media: i2c: mt9p031: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:17 +0200 Message-ID: <6d73dc0c23038ba8ee5187f666099a8373dd2d89.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index 4ef5fb06131d..b48866831a7a 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -233,7 +233,7 @@ static int mt9p031_clk_setup(struct mt9p031 *mt9p031) unsigned long ext_freq; int ret; =20 - mt9p031->clk =3D devm_clk_get(&client->dev, NULL); + mt9p031->clk =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(mt9p031->clk)) return PTR_ERR(mt9p031->clk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64ADF2F270B; Thu, 19 Jun 2025 18:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356267; cv=none; b=awHJM9CuZyYXQOCYmwY9CaFimEQhNH0pLMoL5EeW4TxoIc0WOccryUzxd+HKCuv9wNwvVuFcr+C8fZWATAOTImZsx+lFWYsHQJpysS6AK8tfUy0i+Vts0j/UoRI4Pi8vENpJCEuK8iIXjJ86iKoHGvlV1rl7z25b3p3rVkDbW5M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356267; c=relaxed/simple; bh=CPk3BsEv5ESdxGPd+6LQvQOSUTMvW7QSWGjh4LDSiyw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nDjOvS6TclypUI2lAw4BTWi7SHYWQIhiw0G86qFUM9QyqaFhC7sYWk01OJfQQ/I6X/X1ona+GsjTd0zg+g5Z1kEA41r8orAmeOq02LDJe//peNW4D5KHJEWe/+tltbmjkEAQgeKoTWDSBxHVTF6lMghCsIWL3MIwTikN+QT1Mw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=X4vPzb06; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="X4vPzb06" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356267; x=1781892267; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CPk3BsEv5ESdxGPd+6LQvQOSUTMvW7QSWGjh4LDSiyw=; b=X4vPzb06LqOPN5nQ/EXQEyWc/aK+R9G+/0oU+rkNryGoPh5Yz/XWDhq8 HlSEiteFCO3McYJ773voBvu8QhtqrKsmpbNvF2zmeZ5uzTCxj1m67ZapC GwfctskGcFSOK6nFEcLVdwRBY939oL2cJY2vY9xGk/8XdOpHBwMXsSpxX CU/bgIX7KOqG3Hg10nzZk9t0QWvlOPbaaJDEI8Iiz4g9b5YVOnvr7KJq1 fX9oyibdZW2HqNra9cD9lxhy6owpBx+DEdomxm0nGX6DK4ezpRGe4WHZj NT1kFuokk5SwqkmeMHCoETRPqUZQOdD9KasqVy8qMwDf4TC1laNTwJ435 g==; X-CSE-ConnectionGUID: hGMWJT4vQ/aaclXNdn4AoQ== X-CSE-MsgGUID: nDAFUf18SSWDJzk9nEkVFA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048470" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048470" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:26 -0700 X-CSE-ConnectionGUID: qwJQQ8w5SlGgLHV2Ol4n1g== X-CSE-MsgGUID: ZzPw0oY+Tm+2u4lSS5cwPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919605" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:16 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 25/55] media: i2c: mt9t112: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:18 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/mt9t112.c b/drivers/media/i2c/mt9t112.c index 878dff9b7577..685234577f30 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/mt9t112.c +++ b/drivers/media/i2c/mt9t112.c @@ -1078,7 +1078,7 @@ static int mt9t112_probe(struct i2c_client *client) =20 v4l2_i2c_subdev_init(&priv->subdev, client, &mt9t112_subdev_ops); =20 - priv->clk =3D devm_clk_get(&client->dev, "extclk"); + priv->clk =3D devm_v4l2_sensor_clk_get(&client->dev, "extclk"); if (PTR_ERR(priv->clk) =3D=3D -ENOENT) { priv->clk =3D NULL; } else if (IS_ERR(priv->clk)) { From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4ED72F2C5A; Thu, 19 Jun 2025 18:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356278; cv=none; b=RYNJ9Hp6ko+D8q2GwfKeUj38Fr2ny77esRYr+0kNdzAaaGWmDmpRaitTk7b6q2up0e3Xwa+rziQT2xuMGbPRsDQ/TniIpHATRXkyXcOAJ0kWWPHZLvrF/d9fOSzf3+NVI1kPZOOC7UYLNkvaxZ6UysZt5unEll/bIVXgbx9DNho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356278; c=relaxed/simple; bh=+aHtNY71VY7tCznfNNGDoDhIrfoGRZZOEiy4adyhO6U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SrdizFzInzeVAVSOcga/CDH8Pejk9nbtbrD71ls4X62uZqgZVCqZ9MbYzmui2iMsPWMQg5fOLZ3TjwWHxseC+qLoWQU9fI9AIJiJNInHQQBV/Hynr45sF8HXPkLaJcE8BtQvrEh4xbZHgNZtBD7I3iKn8nE6hT7PSFHDCdUsyG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BN70I62N; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BN70I62N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356277; x=1781892277; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+aHtNY71VY7tCznfNNGDoDhIrfoGRZZOEiy4adyhO6U=; b=BN70I62NcIAlOe+kejxi2wU8QtzemA3+6KutRt3WzuxfY2DbzkMEmMYg NNhb0ziks3sgZJ6EtS/wiXGYZk/To+9k0hWWhX6SROVUduJELerdkhn7R pFOhUOIBnybfk8tkiMjUZTKnW+cPjlbbkbI04EiHhHx4Po5ORWtdEA48C scRMRfnobKX0WqPmpdUu9aBbsKQWNFfKLa/lVJw3+PvlZffyeNNwx7RtY zTk0OP4dhWUQ12lZvA+//gCXhkpsCmhdKG1kjXd/7smaXTaNwtqHnhi/t MVB6T8FaBwKUo4A0+b/8IBpwcI89e7bJ0eWA5Fl5A+DN5LC3ZajZyuosb g==; X-CSE-ConnectionGUID: KtscQDoTRqqIT1f6WCQaxA== X-CSE-MsgGUID: rhMho8wwSVOBhTqkHVfGsg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048494" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048494" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:37 -0700 X-CSE-ConnectionGUID: YU1fMfwWQcmT+tIN8jdJeA== X-CSE-MsgGUID: mszErYU3QK+eQ340PLIKYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919610" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:26 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 26/55] media: i2c: mt9v032: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:19 +0200 Message-ID: <677a1d4cd8e13b27df977f59025719deae06ed04.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c index 302120ff125e..467a83c1da57 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/mt9v032.c +++ b/drivers/media/i2c/mt9v032.c @@ -1058,7 +1058,7 @@ static int mt9v032_probe(struct i2c_client *client) if (IS_ERR(mt9v032->regmap)) return PTR_ERR(mt9v032->regmap); =20 - mt9v032->clk =3D devm_clk_get(&client->dev, NULL); + mt9v032->clk =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(mt9v032->clk)) return PTR_ERR(mt9v032->clk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E75D52F3C1C; Thu, 19 Jun 2025 18:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356288; cv=none; b=CSW/z3EfqfZKCNOO4DQmPSrsbhSovJDW7rlFfF4kC2Te4W8Mz19+9QDKJFhPqt+Mcm2ovElMP1M2NaSN07wcqkHfqSv6LKo9KxDr+x+8UteYz4vXaUDORCMp1UQgWHc9tORUyzvPGjtsRKFwEmG98VYWZ13zNqlt+L6aSbM3RCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356288; c=relaxed/simple; bh=68/cwgDC2LnKzPeB+SVYMjOAWRK0l+eNjtm1DAuaUU8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qova++nMaLsAOylEQyRWzkpff/HaZ7I0wrr/V5X2SL24JQ8aHOGrfPv+NigdcbD0mGeSVhXxV4OxneJm+H3QQmhzNk3tRqtCl85rMoTN073rTzN24iOQcMvdIC0SG9pWNS5ygE1lQhFa9Kive1aC0xwYoCZ/+nVQ7Qca++aO0hQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=blx+TM3/; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="blx+TM3/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356287; x=1781892287; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=68/cwgDC2LnKzPeB+SVYMjOAWRK0l+eNjtm1DAuaUU8=; b=blx+TM3/yAe+PfOFixqJVIepzwXsXEZcLitrHJ0I5IC2EFXqG6sAfkDQ iwdCG65yLSa0H5b8A0ljR5HMVnZPm50fdJG7A8XNKmXqgx8opgksq+xcW uQXF1vl6pfHNqUEYYBnVkbGfbHU95A+2Nw6ltQHtQhj4k74n+2WiJpF0P pMR1+yFmkCGPtX8wVI9STiRfgSdsj9c3RTHKy2aGNX8oSvAEskrEhrmfc ofvD4QESZnSRtIKALjCUDj19oVNJpIaUNH0QzHUpwmpuE6MeAgzGaA4CV WPMdPUDJ+fyYC/638T6MxwTMu8NqL5DOqWgYd+rRIK8xjaRyBmP4uZtug Q==; X-CSE-ConnectionGUID: i66pSKMlQHCIjj8eIGqW1A== X-CSE-MsgGUID: H+0WU/F6RJqVR09BVD+M7g== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048524" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048524" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:47 -0700 X-CSE-ConnectionGUID: YIFkbbUYSgOIREL/9bpmWA== X-CSE-MsgGUID: cQ1xtTo7Q6uBMgMpRFak0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919616" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:37 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 27/55] media: i2c: mt9v111: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:20 +0200 Message-ID: <1068bd1bdd57f683c676490c561fd21db6fe71d7.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index 723fe138e7bc..f92648b1777e 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/mt9v111.c +++ b/drivers/media/i2c/mt9v111.c @@ -1129,7 +1129,7 @@ static int mt9v111_probe(struct i2c_client *client) mt9v111->dev =3D &client->dev; mt9v111->client =3D client; =20 - mt9v111->clk =3D devm_clk_get(&client->dev, NULL); + mt9v111->clk =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(mt9v111->clk)) return PTR_ERR(mt9v111->clk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0BD2F4A0D; Thu, 19 Jun 2025 18:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356298; cv=none; b=tS11fudlu6fzggymvojWS+vxMmXzgjThrWzpr3EXSDbGG64wsaA2AuD41NyBGx/jbLU8lP/FxsGTm0hlSfUHx1GRjSrCHWC37hyxFvCPoJC/FzNNi9muSSQEk8NNm7yPnJMIEeDovV91fZK42bR8i9A/CUUp+8EL5TkA0f1rZS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356298; c=relaxed/simple; bh=eBk3NG8cUR1tmHKZcn+MEDupJ242pPGtugRTMKoAEaE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fw4GwtoOnzf2aeCkTX0a4kB1DKQDANBE51xM89fJGu0uXr6M5e546++2TyuNcDVjXEew8QuZxAJZbCggkoymO939+KZivrfYlR8xaZk3+XTDEXulwwe92lKuy0a0E36tgikd5RJ2abl0uH9LmAW0OaqFXr43+5xPxl+CKUVAoXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AuXNtzyg; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AuXNtzyg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356298; x=1781892298; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eBk3NG8cUR1tmHKZcn+MEDupJ242pPGtugRTMKoAEaE=; b=AuXNtzygHmNxGSbRALSqAGCcQA2hTv4eiRzrNfLgB8WoKqXKwSVmX+US TcQw3PRIN362Me+WEOgb+sik65M+nJT7kJ+wmFjCRltmUUlgTyjaBUwsA s0eV0qqXconYuidFQRO4bps5sXsDTUoOxH+8MWNtJwJFuKidF6EYlN6A/ MjwRD9l6X2qTvDLVP+nVan9VqC0mkJMsmUfUhTquY8rRjBaJhLe5GcAH4 yVeCtVkyMDANT2oul9rweYNV3Kcm/cDihRQISoHfsXoduu1rXa7PuUaM/ aBbt6v/SE1USNTAqcq4a8HcdecTR2hnDybtRK/ZCT0/Vnktnw0wOgs2qn w==; X-CSE-ConnectionGUID: wlP/7QOKTbewAogItkr/Og== X-CSE-MsgGUID: 1GGyR36zR5Om7oNc2DsRcQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048559" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048559" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:57 -0700 X-CSE-ConnectionGUID: cNbzQ/nFTlG1ajvJY9L1Tw== X-CSE-MsgGUID: o7P+Qgy6RR69/3uV6HnL8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919621" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:47 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 28/55] media: i2c: ov02a10: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:21 +0200 Message-ID: <5af47a9bfdf36e467c8ab910a1f2e00bcee21587.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c index 6c30e1a0d814..74fc0687c849 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov02a10.c +++ b/drivers/media/i2c/ov02a10.c @@ -885,7 +885,7 @@ static int ov02a10_probe(struct i2c_client *client) ov02a10->fmt.code =3D MEDIA_BUS_FMT_SRGGB10_1X10; } =20 - ov02a10->eclk =3D devm_clk_get(dev, "eclk"); + ov02a10->eclk =3D devm_v4l2_sensor_clk_get(dev, "eclk"); if (IS_ERR(ov02a10->eclk)) return dev_err_probe(dev, PTR_ERR(ov02a10->eclk), "failed to get eclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70BA2F94B4; Thu, 19 Jun 2025 18:05:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356309; cv=none; b=J33p2B0l3RNOEbwDwdJwPucRcVbRnaQoMlCmF8MLcmvkbKuNgoUp6pMp0VTsMntzVgEuawajrmjbqXnbluC9BuHezZZ4I1XvsrwCDoSt57j5V8bxxtUGWcbQOMhmot1OWu5/b1xZPd3NKy9AuY0+hbBsuGvIy/Inkp/3/XZQ0Og= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356309; c=relaxed/simple; bh=AIZEY3flhziFIS2wGmnaMLhE40nCGNtLPhU5H0wVfSo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u0g241NfUNNEZVTuxYZufoZayljotC4wFE1sn+vYqKCBIyXFceJYMgEjOovfnCWV3cDvqjhOo1tRyIHvlO5occM7LZzANoGKlvm2PrXpFgmTrC8i+O+6LCFRI3Pvq/kwnln4OdXhNRx00feAvU8IdDXX+dC8qufky1sOKRMsbac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DBk7KlP2; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DBk7KlP2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356309; x=1781892309; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AIZEY3flhziFIS2wGmnaMLhE40nCGNtLPhU5H0wVfSo=; b=DBk7KlP2xiENN9iqF4ZxVSoWCFWI8XHdULQmYg1H5YrvqEFS5/VNsSTi KyB3zgg7Ukz4DqosoTvqG8XjJZBUk1OVl4wewwPG4cZULbs8AHRxR98J/ g5vuiRsGYbbp5NMueKfpxGwpftMOgeje443auemLUp2R98tZAz1+eNQlU dfWRe9fGzQTfxu/kI5PmkFFcE0bA1Z2+vApo/jjn+EWHj+WwqImM4FIqz Z5My5Ts9mp6grHDHPGRPtbaTim8ihirkPnzOr8oKrAnUMJ1TJEgPnvD90 uGpjRLqVYXRUIi6CnVEbgOIrPy8WuR3X4KP7MMscxrpsz3s7AKpvPRgwH A==; X-CSE-ConnectionGUID: nPep9J/HQcy26AgqNG0j2w== X-CSE-MsgGUID: MViZuvI+QCO6ohTTOzeN7A== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048581" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048581" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:07 -0700 X-CSE-ConnectionGUID: p9uPfOGzSUWfHT5I3HkFcw== X-CSE-MsgGUID: 6Re5FhR/SKiTAhljTUv0AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919643" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:04:57 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 29/55] media: i2c: ov2659: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:22 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index 06b7896c3eaf..92a13697ab83 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -1437,7 +1437,7 @@ static int ov2659_probe(struct i2c_client *client) ov2659->pdata =3D pdata; ov2659->client =3D client; =20 - ov2659->clk =3D devm_clk_get(&client->dev, "xvclk"); + ov2659->clk =3D devm_v4l2_sensor_clk_get(&client->dev, "xvclk"); if (IS_ERR(ov2659->clk)) return PTR_ERR(ov2659->clk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 794112FBFF5; Thu, 19 Jun 2025 18:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356319; cv=none; b=thU/qteWXhGZh7nYVy3Mnto0pbPXQJeua/Sa+nV274JSf3yjBOWpFiyv4yU+Sya5S3sam1CcJSMNjg6tN+GwK5tkwWSnaiuhjVy03vOaeo2KwiujNvmHYn4iS/6d48vHv+qQLWbK74WsEYUp9sx2QJpze72byXBW8+/1yH33T+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356319; c=relaxed/simple; bh=OBfm0Z7KHo3zhWVfOu1Aklpp3l/ok0UsbyQhovNsACk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N8c8acXW4fIVb9xElVOXrEBLcg9/vl+VlR/gLMb/HEPkivup1PlBrgtdAJDDaoHagb+AG4Gcr/f4wl+T5yX68tD/8Bwuc4o836vIF6xBCTnhFOcdcZYOVR56uSUkURN8Ml5/zvuenBZZXd45IcwcL7EOs2KRtpCTKQWupAXCuFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VMRgA63U; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VMRgA63U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356319; x=1781892319; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OBfm0Z7KHo3zhWVfOu1Aklpp3l/ok0UsbyQhovNsACk=; b=VMRgA63U6rz8GqxNTj7oD88t/N0N9t6aNHdjSvO9hDC19OTgAL+kESA5 nGsg9lAXQsUdcTWTMI40vo1OjZoXGmaXBXmJQTNEMf5pq19ScdgLthQIO spXUgLDQ8nsiBr+DNdLidwud7kQOx/N20RfP4aJIO4kzyvFJYNMSylODf utmVVDvVZ4miIPK1qbpWMts5YhBPH6wjc5seZZ3RAEUfEQcXGZUgHzLhL o9XwRCftoZ0nq4qse0Ho8TMJabdQEeuCmvgrmh7Wr0V3sVV+G3HYbQOMI 1oQPmouAX3D2+IH3ABjkn2yBZLhktqc74pY+eZ1uxeyFJGcQnGppsqEXX w==; X-CSE-ConnectionGUID: P9Jw8PsVTP+OpJFJ2Ff18Q== X-CSE-MsgGUID: PjV9Lmi2R4SEiYc7fZb9yw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048608" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048608" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:18 -0700 X-CSE-ConnectionGUID: 1i/pjNBZTKelaKQStaKz+g== X-CSE-MsgGUID: tupsFgB1Qt2Iy4MoD3CwUg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919657" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:08 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 30/55] media: i2c: ov2685: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:23 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov2685.c b/drivers/media/i2c/ov2685.c index 9b8481b8dcd4..dcd16530078e 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov2685.c +++ b/drivers/media/i2c/ov2685.c @@ -783,7 +783,7 @@ static int ov2685_probe(struct i2c_client *client) ov2685->client =3D client; ov2685->cur_mode =3D &supported_modes[0]; =20 - ov2685->xvclk =3D devm_clk_get(dev, "xvclk"); + ov2685->xvclk =3D devm_v4l2_sensor_clk_get(dev, "xvclk"); if (IS_ERR(ov2685->xvclk)) { dev_err(dev, "Failed to get xvclk\n"); return -EINVAL; From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7474E2FCE0B; Thu, 19 Jun 2025 18:05:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356329; cv=none; b=t8S06UVSl8zs+mAArgxa2pL8y1L++qO7PU1H6i3Qm64GTx7MP0KYZnz2/saWvow11ilEE0759JZVSOyNhAZntH6ZF8QYUr9gvkmrLSb4zvuoYAqGLW3LHLF/8agsvIk68rlf5EMqeTwmrWOjruxR9ZQ5aQG+dCyUTYA7XzwWwZc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356329; c=relaxed/simple; bh=9oiBugjaQcKhzXaJcODQV7B0gO3fJPGuuRUmpghJfic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jtfijW78SwdeTw+/nEqBxF2hFr9ANCXWuLriHpYQl4NytucPSe5pXzYNBee8bmsmwoGjDI/7k/1+16jDgOU/nokM6PapbRW6uzeUoQBoB/P5WW39Mpc1Y0FYFKifciHwMhGT2cs6zA+0Jtmt8OgPw3C4Vf0xRnHuJkjj/8+tfyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZCY3/RDY; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZCY3/RDY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356329; x=1781892329; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9oiBugjaQcKhzXaJcODQV7B0gO3fJPGuuRUmpghJfic=; b=ZCY3/RDYMxeT0syR2OJoNEc+mbmcfhvyLRkCF9qm0kcZpdfFQRfxFf8g 9H2TMkGTAy7O9ipR0OpGaLg72YzH1skJZpXorEo2PCCA4pfyyeeBhuQc1 tbzuy/I1b/TXZz/Ms4g0ZgcJpQQxsYgZfh04bwOyStfba/EQqkG+r/gGR e8pwvr+exVPmjv3XtotY1Lp/aB/9H67cyEbHnPfBTNTqkUg5viGKRLMPG drhGuBAggSDGOt1n95cx1kfENAMV5zfI97Jt3C2LAJ1eCdTJFsZUbeVwp wdjrrKdAevx/mkxwrq0EiolaNlJs4IUN+bwmcdPq48MalIgfU+LNz4AbO Q==; X-CSE-ConnectionGUID: nY3rL6YRTY+HAXg8TaPZlQ== X-CSE-MsgGUID: EMSmF+V1S4CBZUM0CTV73A== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048634" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048634" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:28 -0700 X-CSE-ConnectionGUID: uw+RvbTcSXiC51eR2Iu2PQ== X-CSE-MsgGUID: XiW3T7WuTNastFkuBoUjnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919685" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:18 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 31/55] media: i2c: ov5640: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:24 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 0dae0438aa80..861ebaaa20e3 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -3898,7 +3898,7 @@ static int ov5640_probe(struct i2c_client *client) ov5640_dvp_default_fmt; =20 /* get system clock (xclk) */ - sensor->xclk =3D devm_clk_get(dev, "xclk"); + sensor->xclk =3D devm_v4l2_sensor_clk_get(dev, "xclk"); if (IS_ERR(sensor->xclk)) { dev_err(dev, "failed to get xclk\n"); return PTR_ERR(sensor->xclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A88C52FCFC0; Thu, 19 Jun 2025 18:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356340; cv=none; b=aaGVIDt2v49EsqMLFlr73AnY8qkaJSG0XFbdT2ghwL70b/zwdbczv5cxNrw07XJb0CZYEL+QlV2fnT6KYyowdOkFxLSPHc5sPOna1FNvpnBM2WHIa6zFIkvdZ7ThENl0NC5JDxWfr2tb82Rd4q6VCcUj/QVFmhPLy2nKI/S9yW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356340; c=relaxed/simple; bh=mEO6PfVC/6y5ltSlE4ejXk+RvXptTghBJSVuHnT03kI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bnqKOalcuhop38Q1X5B4DmWBuAEY9boY3kWze8jM5s42pgBi5rbK5HnabO381ikT9gchcIixg0VwmSnmNg3+cYU/ckY7caaUYTgZ0eUWucvzUL0eeQjv6p4+KXIJwWxxAh5GIkmgtbJeFOARMcsHfNyd0jncv48000Bsk4CnUk4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FJkSvvGl; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FJkSvvGl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356339; x=1781892339; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mEO6PfVC/6y5ltSlE4ejXk+RvXptTghBJSVuHnT03kI=; b=FJkSvvGlg9CBzTp+mMYNp/qXqA7+Mc9R4jJNOnBFZJ39pwF7FFR26lde OjlcO0cEUCjgdO5uM2RRzs6X+aW2VNnceaiKbWjPPPzKQ/JWmWPIXF+rQ YA3tTIeopaSnIRVq47O1aK9zSYhFKtd9wIyKDLq/Y78KaM0aoD3uZhHQH EcGBXlKuxEJowBO71xAYWy6pupB4lkSJzaRmB+Refxuc04yWgm32DMaKJ C1l08xg/ftG+8a02HgWFWwy6dXrHhBM1qzPS07fl3S1RZfvPIniYN2QpH tNScS+3IGBPUHqnQX5nvwcDSE02RRj63OdRb6Xkv+bfGL1Ss7N28X+KSj w==; X-CSE-ConnectionGUID: 3zvw2rpjSmOg/jSbNPfLig== X-CSE-MsgGUID: RioSKQ4AT92Ke8r5/GtaTg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048665" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048665" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:39 -0700 X-CSE-ConnectionGUID: 1NNLQ+LATIyovWuTtMxW/g== X-CSE-MsgGUID: MpC/OTtjSj69JAk+yaEl0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919709" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:28 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 32/55] media: i2c: ov5645: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:25 +0200 Message-ID: <2cffe2c318b1aa9b8a1af116efae9f85b8427604.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index 004d0ee5c3f5..70b4cdb1b9af 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov5645.c +++ b/drivers/media/i2c/ov5645.c @@ -1044,7 +1044,7 @@ static int ov5645_probe(struct i2c_client *client) "invalid bus type, must be CSI2\n"); =20 /* get system clock (xclk) */ - ov5645->xclk =3D devm_clk_get(dev, NULL); + ov5645->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(ov5645->xclk)) return dev_err_probe(dev, PTR_ERR(ov5645->xclk), "could not get xclk"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 621292FCFF5; Thu, 19 Jun 2025 18:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356350; cv=none; b=sN0ThMcrtcak4HgihUixuFglZlwUQuwbyxamkHROoRWy6sC1vmXl9NxNH7XCuWT8xA3A5o0exywxBPPD3GuB9Rc5LBttTXPzuVVGGwJwPQW3HXkkQw+8vGUMayYyqvNly701/CbCFLIDOIUcN3Z4ZB0CC9PqfNE+k/jz3eogsCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356350; c=relaxed/simple; bh=eZo4P8C/f8ugsGt+Y5QjYVD0s4GpGWJonnG/KNGLYpc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vo7J14g+TnzOECGDCHbVi5wyzLNeEYK4QA1mrFZoBy41gfsNViaWqDA/V9aJStPIGIKw3fH6XBOmB5ugFeMfBSAjOLlyYpVdezqBD4hJw7XVFKFZlnsDvcjSC5G+mYE+KgUGqCltXK7lW8Vn63DoL5ORAX+PUniimbUfUW9xz3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AZeduqFz; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AZeduqFz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356350; x=1781892350; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eZo4P8C/f8ugsGt+Y5QjYVD0s4GpGWJonnG/KNGLYpc=; b=AZeduqFzpO7J+wCtELiprSM5ayQI7HKKhbEVH9al1cp1lDmEHlHkzrnv 3Kawa/JbW1cPg8fd0yveHrxlwNV0/mMt9w+prxNdV8lTjE0LJv0r7k8pY VfYgxpnG1PygW6NACeIPjZsCWLM+gCDF/NHrpz5QSZ6Qc11lbFxVycn9X zTUiN9g9cV5c3/SlZMko9NeI64zHmFzxJy9uoIQS+YziA9URNSOTeqkqE Rid37LOjWGF6Sf5MH2lEsCkv8J1/9oRyoayuvcRce2kkL9GrzSuXDONRI DnupfePimU4EpjFrM6lBc5dhy4ZTAAJQjGp5x/EH+Bd9R5UUwyHOrfKyW Q==; X-CSE-ConnectionGUID: 0lKpD/rYTTaMdBR+ysolUw== X-CSE-MsgGUID: gSueReF9TJSi5amEtPlrDg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048695" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048695" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:49 -0700 X-CSE-ConnectionGUID: EhdOjjQGRXyJkfTjLfvgMw== X-CSE-MsgGUID: 44/tRNWSTDWi2MBCuRYdvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919732" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:39 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 33/55] media: i2c: ov5647: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:26 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c index a727beb9d57e..c8d2bd63c6a0 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov5647.c +++ b/drivers/media/i2c/ov5647.c @@ -1398,7 +1398,7 @@ static int ov5647_probe(struct i2c_client *client) } } =20 - sensor->xclk =3D devm_clk_get(dev, NULL); + sensor->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(sensor->xclk)) { dev_err(dev, "could not get xclk"); return PTR_ERR(sensor->xclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC2962FD885; Thu, 19 Jun 2025 18:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356361; cv=none; b=A/1jrt0VTIMSo/RCHS6bXbvDvU0GVtDIfZKCsh7PLU7riwzM/jETRir8TqRmf4tU2FTo5nJIEkQpOQuMfP6DKvvGfakWCIyK6O7ufuADCd17pECKDTVu/fepVsME29hFAGFfAdYilJRbD3delqb7snngjNmyJANd69E94vVlHLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356361; c=relaxed/simple; bh=5Q7X3X49NqLqL1i+//1tCXp1vHRyWl7vlFKITvuaRvU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BUKLeTODk4zUOMmwBTxaGd7vHWGTIXNTVwqBr0sgrhCEi/Lx5uR0eAFCevFKkpeHX3E7gxNx7ORTAQD4AP2Yagr5oCYuOyLo2iGQ1s1Qwtq3zfVlNfr5oFwy44RroWMX5Y3DMzEJvwck21/jyasHdXGgOJqHojo859o9tYAHjyA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=as0OpeKa; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="as0OpeKa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356360; x=1781892360; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5Q7X3X49NqLqL1i+//1tCXp1vHRyWl7vlFKITvuaRvU=; b=as0OpeKaoHRlOZk5E9ZmT29HCdTRznz2NEKQV4vjrowNQ/FC0cabI+Bw 7ixNAiEJBVGHTtbSwBqit8PMXwoACxx3+JMmCMYz9RDcUoV9e3cBXAwb2 z/qIC39bjOcPE/v/Fvc9GHl0rOY62SFSCq85AFCPkeShmkLue/D3g2+Hr UCe46eyPCGHQHnnPsZRbVI1EKAkDnPEqinUxdq3+GIKFH/Fw0H9qMPolQ 0dT3cRuYmV2UAn3uM5rD5shvIsgRrS8Gs7Yuu18asfmb/yjjfd/NEuXDi eiO6y1ZSHjb6ptOv5TAryL3gaot/XWiMrrPhgwnqMUuC0P7k/tVyBvSPA g==; X-CSE-ConnectionGUID: DBE4pXlxRwuBDTRE2w360Q== X-CSE-MsgGUID: 4t0PvNHsQMGbhBZ4uxgkTA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048738" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048738" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:00 -0700 X-CSE-ConnectionGUID: wIRL9y97QJWKCjntkRmtWQ== X-CSE-MsgGUID: 5nRftN5XTEuADwfgjwxIVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919739" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:05:49 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 34/55] media: i2c: ov5648: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:27 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c index 4b86d2631bd1..8478ca3c49c2 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov5648.c +++ b/drivers/media/i2c/ov5648.c @@ -2521,7 +2521,7 @@ static int ov5648_probe(struct i2c_client *client) =20 /* External Clock */ =20 - sensor->xvclk =3D devm_clk_get(dev, NULL); + sensor->xvclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(sensor->xvclk)) { dev_err(dev, "failed to get external clock\n"); ret =3D PTR_ERR(sensor->xvclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEBC72FE317; Thu, 19 Jun 2025 18:06:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356371; cv=none; b=WovQGwdUpj7pt0mcMJ+dWYsLkhC3q12JiL9BWrX/h2vwdHCeRFBxzcjUG6iCLbLwm/yTxKAcCeFh4LkNK1WJqyZColnSSnmfbUI+6xLGctDs935HdfrDkKssYA/9bybSyvgMYjz+e4AEWkHZNYdONT0atWsp1Q+n6C3K7isztkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356371; c=relaxed/simple; bh=1gIorCFG94UmhHTN3ZrubNEQesMYc52whgy6DbtznSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r1WKElZpQj+8/AWYmEsOSjAXOI+/HrghEOsA1Wy1TQnoob18DZKavXQhEIcjiNIlSIFt0DCTiJJyqDA1VBfsFiuh98O9XXSh6MB7Tv4nMVHNHyoqXhHXV3636Ns/rhtVKywbF0z5v2hLI+pXKG9AIo+YZAQJXGi+MLQTG8WEHFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Gt+EeEx8; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Gt+EeEx8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356370; x=1781892370; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1gIorCFG94UmhHTN3ZrubNEQesMYc52whgy6DbtznSs=; b=Gt+EeEx8RsTNoAseLe9UeQd4ohyRKfuSx+s+102B/rMZ0PEwAyjQ+POk CkUQi7M8dheYnK5wqFSwAjYPuxrZU+zqw5B0sBp/x7bhekYr2T7AUS4W6 DpCaZfVGNvWQcA2OX2Jk5NyrGLRhlvScAqqUcyeE2nw87tExIqdlUbc4K AZe9SM94DeUjVAKKApV3pNfiTtVmyphBfsJaP2oujLOuMLSbDUWaKhxXh 03DogCim2eiuW75q80DIPrMNS/3vvqM2D2bOXmpaxUDdixakkzarWGnOg 0yiQGTka5+psD5m5KoQmPnpWDHhhfTSgjOvQzKHYoKwSn5hYuXMCCotUY A==; X-CSE-ConnectionGUID: LWOG4lH2Tky9FqD/3ZGing== X-CSE-MsgGUID: NVINFG6oTM6vN4zv58bLog== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048764" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048764" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:10 -0700 X-CSE-ConnectionGUID: CSB7Pf29TP6lvjzAj49hNg== X-CSE-MsgGUID: Zo+/maNARs2KfzfVihgicg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919747" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:00 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 35/55] media: i2c: ov5695: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:28 +0200 Message-ID: <8bdb217bfe923f3d0be1f2a26c5d631278eaeb18.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c index 663eccdfea6a..12e57ddf00c9 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov5695.c +++ b/drivers/media/i2c/ov5695.c @@ -1264,7 +1264,7 @@ static int ov5695_probe(struct i2c_client *client) ov5695->client =3D client; ov5695->cur_mode =3D &supported_modes[0]; =20 - ov5695->xvclk =3D devm_clk_get(dev, "xvclk"); + ov5695->xvclk =3D devm_v4l2_sensor_clk_get(dev, "xvclk"); if (IS_ERR(ov5695->xvclk)) { dev_err(dev, "Failed to get xvclk\n"); return -EINVAL; From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B5F62FE367; Thu, 19 Jun 2025 18:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356381; cv=none; b=fPOHZpT+xwDJLLfvnT1izxZH5eTjthl59mu60CRkOwYhKoXIWbq/0TZ0bQjB8HVO+Wchra50vf+J04FAM2KUaCzz50MZ+whHOtT5OpR0B9yG16RAPo5P/035xniDf3JHZN9kkvVfy/K7jPvu9yaeAwrWOSezGjRHkrM+kcmTp6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356381; c=relaxed/simple; bh=F0FP5YXxIaHslJZiUPsTJx+SFT71XHUusYAEVJiAsOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CVnUNg00YANx4/dJW/U1XWqT4WSfiCXdAjtrXxKBCpDXah4onqNfo4rggF8CFyK3hXDW09lyVTxWs6oJaDkUiOkBgyKk1dN2gdul7vPgY/0Hn10Bys8VPoTIC1EMrCJDQum7EeeocJgAD1puHEoMeWuKYY445R9qgAsuVJtJhF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=aLjfrs1S; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aLjfrs1S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356381; x=1781892381; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=F0FP5YXxIaHslJZiUPsTJx+SFT71XHUusYAEVJiAsOY=; b=aLjfrs1SjzLaLm0xX6Fio9TtBaGTO4dSRnCpUTEQJ0lReEVe2yTVjc+Y DNx2Dfo5V8jDugelWityhN3tAb7YcIVcHXfIEgkqKU8RFG8NbzjCrNvBP OGvg1DA61UE9kCoufvhWZ79lmIumSjg/kMntt3nLMFtjVdNVZAHm+oUKn KLTMyRn7y7hZB3lkcFenMzYiPNFeZ3cdCY9m3mxlaEpy1wI5cA8TNP7kX wk0RxYKYuRbm6attzgWQCe6uNsUazEiUXfaXB25g5sZyDepYcHiNf8bCj pEWw+C0JP5/lbLjHuMHcbU3059l6us1PebpjNuNvsOe+gHYV72X71/JtX w==; X-CSE-ConnectionGUID: VNpcKD78S1WP5STmULwLnA== X-CSE-MsgGUID: 9ozhLttVQt2ayTvGNWdYFw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048793" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048793" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:20 -0700 X-CSE-ConnectionGUID: 8rhaOdZwTOCFz+2VcsBBSA== X-CSE-MsgGUID: vPhM4iTVSsOWV9DL4gvb1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919759" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:10 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 36/55] media: i2c: ov64a40: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:29 +0200 Message-ID: <1c96d553078894e4e6b6d24990b5c26c07d0f8fd.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov64a40.c b/drivers/media/i2c/ov64a40.c index a5da4fe47e0b..d7a13e855a41 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov64a40.c +++ b/drivers/media/i2c/ov64a40.c @@ -3550,7 +3550,7 @@ static int ov64a40_probe(struct i2c_client *client) return PTR_ERR(ov64a40->cci); } =20 - ov64a40->xclk =3D devm_clk_get(&client->dev, NULL); + ov64a40->xclk =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(ov64a40->xclk)) return dev_err_probe(&client->dev, PTR_ERR(ov64a40->xclk), "Failed to get clock\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB8D22FE39E; Thu, 19 Jun 2025 18:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356392; cv=none; b=b6X4oB/S1W4VeuAol6SM0Th21CcQtFjAcrEbEKTEkA246UVTGkNT5Otv3IbRlxufhOFncsL3HTxENPKLZmAMDVPE216d9cS2XcMQ0jLzgF4Qhjd8JHm6zncnNpbXXv/pOmUMLLbCuLBA2iL6ldb1PeEyjpdkdX3a0XWWHMxz7Jo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356392; c=relaxed/simple; bh=MpjeIvV7GA6XvzJJFXSKGuVT7DnGxF3R7IjTC5n2KqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hmLeTYjozX0EEZtG79/wDDcZ/JELPG1Ayt811JDNKAv2OXKLwOASGkaYeeQ7i4rwT76hhuOds4iDcnDgd5/IhwujKzDsTGjMqHmaMVETzPb4Fwj86LMxFpirlo5N8/g2Dxxm3XiqDjbIAsLzfoILQPyr6KOVq9Koua6q/Dz6F1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V989Fta8; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V989Fta8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356391; x=1781892391; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MpjeIvV7GA6XvzJJFXSKGuVT7DnGxF3R7IjTC5n2KqM=; b=V989Fta8xOfnENiCaiMF29Uu0sSRIbStZs8Gpx2ARHmKWaXx6lGpBHwo MKZMq4TZdXKzfzA5+rKA4bLR/LY1E/Yd2C+Axow+xZV4Sgpp+5x8k/89U thR/Etypz6E3tVb2BPl/TtvjpJvWebdEZJv4Nc77sVGSF7rYpJNGQlgkw kM4uKkPUiDqrnKYNuQjv4Za0A9ZBCm97k6x6/2WbSfbAtcCvzsM9xYmEY v2jOnxAaDqMDEAf4aRjAhIUgomtsUpuPrTgaG8UFzv7s2gvYjSB2gRze/ qsCT4svgbSSypxIFzzoq+cWjnP7gcK3vmMEFoXaLZ6tv/cFdMrC4RiANm w==; X-CSE-ConnectionGUID: j2UcSTXZRGS4knA7ZplvJA== X-CSE-MsgGUID: r8Fog7pHSzWpg1+HgUNtxg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048821" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048821" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:30 -0700 X-CSE-ConnectionGUID: 4H77CYiwSKqV7iJAyiSB8Q== X-CSE-MsgGUID: YOxYRkiGRq6+T5AFP/qXdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919792" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:20 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 37/55] media: i2c: ov6650: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:30 +0200 Message-ID: <8bd026035e56b21521b7722d9b50e0e9e12d4c42.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c index 9c7627161142..251a9058fe18 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov6650.c +++ b/drivers/media/i2c/ov6650.c @@ -898,7 +898,7 @@ static int ov6650_video_probe(struct v4l2_subdev *sd) u8 pidh, pidl, midh, midl; int i, ret =3D 0; =20 - priv->clk =3D devm_clk_get(&client->dev, NULL); + priv->clk =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(priv->clk)) { ret =3D PTR_ERR(priv->clk); dev_err(&client->dev, "clk request err: %d\n", ret); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18FB62FEE3C; Thu, 19 Jun 2025 18:06:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356402; cv=none; b=QalKrd2U5t3JT7s9kAo54IMhj6vo2AFdIsbAniEEEmF9QLTdDfvBbbGsiiC44RQ4LUGRTrVawBVggm8naYS7PFWekn6eDvubLgZOFEJWUKNbqxbATu83nacSMnIWErVK0v0Nf8t2NzoQ/BQN18ZG+VIkYTIIqdhUg5m1EyX7ZaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356402; c=relaxed/simple; bh=WF90vp5njmnk/zu/jHDhmCuxkRYuJAEsgNBhLD6qeXQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cpq8An7ztZQ72IpiAv8PA3/vSfoUN1arfSCHK0+Wr1F8o3XYYRSNKMKt9PSMO98jgd4Ht3mfWqcnq4eubPdrLbHc28W4svIGKQgNcyjnBMKGmrox1V/jTkdI3tESVvPjC4by1/cf8DQtBwajAZp972Pi26UkdcHo1c9Ir1htSJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gfOzZxu5; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gfOzZxu5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356402; x=1781892402; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WF90vp5njmnk/zu/jHDhmCuxkRYuJAEsgNBhLD6qeXQ=; b=gfOzZxu5tVBdW7tZO8IyTQNk+8J7xNONGxm6SDp+mhlSAkrv1hHYbEZx R00IKVzCnUeAJzIBhNVGh/gZxY8RPS2Zd28fFbX6COYxe07H8O+fW9nQk KAXS/5y+QlplGCgzOh+wTTZOhN6PSgbK+RYhEYcc3JvKsMvOVX0yNgREN JYlBk8W5MdhfyjygIcvl5X65wsy2o0PhaKkQf4ReqjW6xCg5gJPhet8HA JuLf2S+rf7sogPAN2Bz7KHbtIwxhOp/SaACEvmqyALObwhtw8Y3caGFno eea+06lPCX3Ya30BO/roGGae8PGIBUG7RlcGULguzF8uuoDVZnjL3JiIa w==; X-CSE-ConnectionGUID: 6Xb3j0tTS6iiAiXtGljJjw== X-CSE-MsgGUID: n2m9cQ9cRMqTIw8ess67mQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048850" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048850" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:41 -0700 X-CSE-ConnectionGUID: l+1MwEGISPiAc1uivoLDNQ== X-CSE-MsgGUID: ERLokO4fQz2VEljMAARvNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919815" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:30 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 38/55] media: i2c: ov7740: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:31 +0200 Message-ID: <5795d43406050ab66da51dbe1ceb8c801f6237d1.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c index 1f1c0de8e510..280855667655 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov7740.c +++ b/drivers/media/i2c/ov7740.c @@ -1036,7 +1036,7 @@ static int ov7740_probe(struct i2c_client *client) if (!ov7740) return -ENOMEM; =20 - ov7740->xvclk =3D devm_clk_get(&client->dev, "xvclk"); + ov7740->xvclk =3D devm_v4l2_sensor_clk_get(&client->dev, "xvclk"); if (IS_ERR(ov7740->xvclk)) { ret =3D PTR_ERR(ov7740->xvclk); dev_err(&client->dev, From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C09302071; Thu, 19 Jun 2025 18:06:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356412; cv=none; b=bKY5ZfCj6q7wQMZUaHX2CbNYKY1lHgaQZlbA5WR2mgu0fzkrE3xYj5C9QQ23kCB0kNsa/eDtSRLKu0lhzRxwzA0wzuxEGMJzB26nhciVmVtZ5OEIxyxGEZtFBMH2wXM5FYa15DsQvSBCr7NBjvgoCU3qshFbgAq2M0iyB/5X+1c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356412; c=relaxed/simple; bh=LKiMJNxuCRVjRAH8HkJB6XK5y0kPFNoaayptRtb6bM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k7RcDVfCV9ccQ3HXOBuZUF8XqJBt9eA9QwwhoiaZQOS3hEQtuLsQHs6Qf0xdTygv9XKESEkAMKYpHRVBxP01eqpmEm0xLGZdDNhWvfuPkQIuSzV5NGndUwd1BH0c69fh2CQO0QbSsX6P6SMsAa8OYDfMKBNg7DlyaFHCwGqHF8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=K+CCFn+E; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="K+CCFn+E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356412; x=1781892412; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LKiMJNxuCRVjRAH8HkJB6XK5y0kPFNoaayptRtb6bM0=; b=K+CCFn+EiLprqXb7JSEw07O4TwKer6xGasc48d7RPmTkBcwanbp0M9nD LOz/M+lQ52fz8SZ41FGzSNdvgNkthuQqrtVmOj4v0tDXRsYQQDJCj70KM IogjTeYNFr30iZA1HMEeG1W94MDLusO5tk46QS4Gp11wxfnODxF1YoZQG md3PVYCp2lBuTEInLk6U0evOhl+oxMEu1gyK9pNp7TnZgonpxBFTKAvyx cAS3/VaO5KKPlJWjQO+HUdZkGhM5HIsftNu2NcMANCXWB/Jj71GxGs29Y PX+AmUXVdgWi/2ziHOQO2PtW1IBJOkg/sMJTOXOePNbVPodLDurw0sqGZ w==; X-CSE-ConnectionGUID: mNA2ijaMQOeI+v+cAxbF4A== X-CSE-MsgGUID: hVALWpu3Qz67LiTWBY9o6w== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048880" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048880" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:51 -0700 X-CSE-ConnectionGUID: 15ENivSCQA6sjUBAAfw/OA== X-CSE-MsgGUID: efNrXp5HQ662OKL8lcAVHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919836" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:41 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 39/55] media: i2c: ov8856: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:32 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c index 4b6874d2a104..8cc973fff767 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov8856.c +++ b/drivers/media/i2c/ov8856.c @@ -2274,7 +2274,7 @@ static int ov8856_get_hwcfg(struct ov8856 *ov8856, st= ruct device *dev) return ret; =20 if (!is_acpi_node(fwnode)) { - ov8856->xvclk =3D devm_clk_get(dev, "xvclk"); + ov8856->xvclk =3D devm_v4l2_sensor_clk_get(dev, "xvclk"); if (IS_ERR(ov8856->xvclk)) { dev_err_probe(dev, PTR_ERR(ov8856->xvclk), "could not get xvclk clock\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BA5E302CBD; Thu, 19 Jun 2025 18:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356422; cv=none; b=icGWZ0hcILTCAblY9RD8IkKwzX1YzgD/rypYW5/FRpYrWsjMv9iCDVXHBu/8Ggq1WDFGCKP9Q9EZH9fpM+GBbCBSH/uo2YqeutUmP7uYRCP6HHFo69tpNwfcbhpZbD3MAcr3aNDfN3FgUxnjwd19IzyiWfKGsBLQyjkryFKiXao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356422; c=relaxed/simple; bh=f3sDdwtUZhDEcf79XqomQs4SepX/r2Sw6ij7LtfOWOA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=poKaliUnzEnGl/KduAvqCAmkOhctD3DN/v+gtpg8u1sNaGei0NaJaVvIm4+MXGBTuw6qRsdr62b/mwPsgA0mhIskAnXukNta3RMbPt4EQLUrHzJDGj7DMm4GKXBWnHks85P5Fd5rhNAo6DM0N2fcUDG3xdYIpuiwshaq1ITQ/6M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MPzznblT; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MPzznblT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356422; x=1781892422; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=f3sDdwtUZhDEcf79XqomQs4SepX/r2Sw6ij7LtfOWOA=; b=MPzznblThDcZ2ddYBy90EoAyZb/Y+aA+wQQrOuJEOFB/eXdxo32f0cTM fPO3m+Idi+Ry8BfrVJ1SrG5XN2SNGBHT9B9bx7sftUzSIuIApz9/pzEyX vfnwHg5N3eJjLbk0krdjK4FXDiKvDWzNdq3AjjTdjtY1maIAG8KMv5u9D S8M7vqNQ1kM6u5UkCi8cVTJrTLZRGKNauN+qFFBLHR3xw86osV0OnFuke XNs+BKtQtajbw9BS7vdNo0kIL3iiJFCNjOZXdHlvS1mG4wVmkRIh/Wlvh cO39WGwbg2pnVCBjJeu4hmXgUFEPvrgQ9AtIsIigjMKsKQQJhes80YZgQ g==; X-CSE-ConnectionGUID: 7Wv3/ucES6aYKS7ignt7xw== X-CSE-MsgGUID: y8aYt2pDSOKc3liWgwpuRQ== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048906" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048906" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:01 -0700 X-CSE-ConnectionGUID: 9fQ8HL/JS7KGa6H4wbnxXw== X-CSE-MsgGUID: BNhm6afZSNKzbN67cGH6Zw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919849" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:06:51 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 40/55] media: i2c: ov8858: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:33 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov8858.c b/drivers/media/i2c/ov8858.c index 95f9ae794846..c1c6bea8a68b 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov8858.c +++ b/drivers/media/i2c/ov8858.c @@ -1877,7 +1877,7 @@ static int ov8858_probe(struct i2c_client *client) if (!ov8858) return -ENOMEM; =20 - ov8858->xvclk =3D devm_clk_get(dev, "xvclk"); + ov8858->xvclk =3D devm_v4l2_sensor_clk_get(dev, "xvclk"); if (IS_ERR(ov8858->xvclk)) return dev_err_probe(dev, PTR_ERR(ov8858->xvclk), "Failed to get xvclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFADE307AD4; Thu, 19 Jun 2025 18:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356433; cv=none; b=ex4UavhD3D5c96U+ZkPBJGPKPj+js9qoA5+Tx/u5pdTGxnq+mk2M64/oL6QqOLcl+FL/e89tp9gu3qujH+Ioan4POZxW5Z4H1s0WKMjPHz+QITQ35xre2uztYSPNQFUY7L4jDT5FpG5wdzreyRnf7QLyfG6+ESkyqeGqW5jS8bU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356433; c=relaxed/simple; bh=A7ijJ53lEBWjePdKjplJFVS8lnA26ndeER7Phf8YhlA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TP6dTHDSZsJX5io3pu3xyblnEcJRWgy/fJX9rqfr/TkbKCSCbTgHRBJBNu21DwiZC7NRi5PN9bJZmQLA3rgBkbjDBgYDfQN4J03/61Kj1e06QkSOzOdRGWc0Q+9yLJ23m8zkkSXzdyHn5GWfcdF4VqXMtTbpuA0/d8hoY2mKQVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BYMpWc+H; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BYMpWc+H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356432; x=1781892432; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=A7ijJ53lEBWjePdKjplJFVS8lnA26ndeER7Phf8YhlA=; b=BYMpWc+Hk0cSKOs1+qARPMpK1tYym1tJIV/qICOQvhOQ5wQyYy7TuGwk Yj9LVzs6/qALNIq2VMh2CJFmXjtbxYgJ+42uKUIBzJxgJLCaoUfU7DDxW VCYb/gMiNk/yIOY7pYjP/Mgv/GiiL2rmQGBALibhlV87XVWYTkE5nknbx +HBetdPyBG4WdymmIAT4u6oymNe3HdBfjX8hgGzi33rMA/l6/XH8piqmD brGC//zFeaT0bpsHoDK86gy1Lt2jGcnow9sI12I7na5qnYoreQZdIGzhG G0fWLg4paISsf2tBQ1CnLAzgVKGhdnpDGDQqAmtC1N5ADVQEZWFD6vU6v Q==; X-CSE-ConnectionGUID: NXjE23FpRr+s/Lo08hINYg== X-CSE-MsgGUID: DSYWNeCQTYGtCr8b4f+EXg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048949" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048949" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:12 -0700 X-CSE-ConnectionGUID: 9VACkkzKR/e+oB5Hs+eQ8Q== X-CSE-MsgGUID: qqvmYstSRTm2FZVC1Noh1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919857" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:01 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 41/55] media: i2c: ov8865: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:34 +0200 Message-ID: <273d77cc78cbe9fd144f96e68407f0f7b41d3895.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c index 95ffe7536aa6..5cc278c3e169 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov8865.c +++ b/drivers/media/i2c/ov8865.c @@ -2956,7 +2956,6 @@ static int ov8865_probe(struct i2c_client *client) struct ov8865_sensor *sensor; struct v4l2_subdev *subdev; struct media_pad *pad; - unsigned int rate =3D 0; unsigned int i; int ret; =20 @@ -3019,39 +3018,14 @@ static int ov8865_probe(struct i2c_client *client) =20 /* External Clock */ =20 - sensor->extclk =3D devm_clk_get(dev, NULL); - if (PTR_ERR(sensor->extclk) =3D=3D -ENOENT) { - dev_info(dev, "no external clock found, continuing...\n"); - sensor->extclk =3D NULL; - } else if (IS_ERR(sensor->extclk)) { + sensor->extclk =3D devm_v4l2_sensor_clk_get(dev, NULL); + if (IS_ERR(sensor->extclk)) { dev_err(dev, "failed to get external clock\n"); ret =3D PTR_ERR(sensor->extclk); goto error_endpoint; } =20 - /* - * We could have either a 24MHz or 19.2MHz clock rate from either dt or - * ACPI...but we also need to support the weird IPU3 case which will - * have an external clock AND a clock-frequency property. Check for the - * clock-frequency property and if found, set that rate if we managed - * to acquire a clock. This should cover the ACPI case. If the system - * uses devicetree then the configured rate should already be set, so - * we can just read it. - */ - ret =3D fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", - &rate); - if (!ret && sensor->extclk) { - ret =3D clk_set_rate(sensor->extclk, rate); - if (ret) { - dev_err_probe(dev, ret, "failed to set clock rate\n"); - goto error_endpoint; - } - } else if (ret && !sensor->extclk) { - dev_err_probe(dev, ret, "invalid clock config\n"); - goto error_endpoint; - } - - sensor->extclk_rate =3D rate ? rate : clk_get_rate(sensor->extclk); + sensor->extclk_rate =3D clk_get_rate(sensor->extclk); =20 for (i =3D 0; i < ARRAY_SIZE(supported_extclk_rates); i++) { if (sensor->extclk_rate =3D=3D supported_extclk_rates[i]) From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08D9C307AD6; Thu, 19 Jun 2025 18:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356443; cv=none; b=A/KFgCSgMrml+10touLUEyTJzzL7r6P0FkW/Yp/o2jKHNCpVLD41+KZPK2tsVPbuj7teoQCGhE1+u7UE4VHKi0efywBvo5fzC0f10HvVh+mAVmJtZF8x4woFyKua7ybIdvmjxG1DtlOwLXXrmkmFvg7Tyuz0091h/OzaV7RBcEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356443; c=relaxed/simple; bh=+5Y3rR1QMOjm4hVc8y6G1DcfhTAlsWfR4Ooufb0n59k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m5xIGBN8TcWbQF6IA+loepmrHUK8ixhKKwkL7jpBLQwBMZueu8h4Qrs7iW0AEfejz7LioU+HdYzx6VyRUhUG4+k2h4F2w3IuQYBnH9irVD/Bhxxl569HF3jVWGDww9eRBhHl/mGkXB8ZYAPrOr7QEQSpIs5PiZwpibIRFlBkS7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=i2LKG00K; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="i2LKG00K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356443; x=1781892443; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+5Y3rR1QMOjm4hVc8y6G1DcfhTAlsWfR4Ooufb0n59k=; b=i2LKG00K1BJ6z6soRj9/g/s0mJ+tBYPL/wxoJ8WcqYcKSbDVNgcEofoz YP8JXOjaHmkVN5JRUtMYwJH5LztfxvEv7bPK67UcKedezfjDkrndUItzt LmafG2b/i1TfA8cxDJybj0kvagL7CdUlteke+jQhZbIPjDlPuwRlJfGyS aoStZwU/0kpQZbJ88Y6z9rhBhKZUj2Ch6rbFvrVreUbO+6tRlk3QauqjV q+tPTmR3x5NPRgMCDH3ePGIB6pyh93neeNPMpd97GVxLxPF1ujoEzwENs 5JegwkIqaIXSvHn0P1xwrRKxtB1a+tu6Zkhtrytsu2qWJixeEz+n3JBoG g==; X-CSE-ConnectionGUID: wRJRl/pOSb6SBKps5eEIoQ== X-CSE-MsgGUID: R8W9itIrTFmkKZBOWk22og== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64048970" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64048970" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:22 -0700 X-CSE-ConnectionGUID: CjA8Py10RPOZtnKSNxtSCw== X-CSE-MsgGUID: 3EKMaUklQeWSSot8N1IQVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919864" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:12 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 42/55] media: i2c: ov9282: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:35 +0200 Message-ID: <0c3e778b4f903ed9bb3a9241321ca1b23b3aca58.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index c882a021cf18..27c7c007c165 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -1135,7 +1135,7 @@ static int ov9282_parse_hw_config(struct ov9282 *ov92= 82) } =20 /* Get sensor input clock */ - ov9282->inclk =3D devm_clk_get(ov9282->dev, NULL); + ov9282->inclk =3D devm_v4l2_sensor_clk_get(ov9282->dev, NULL); if (IS_ERR(ov9282->inclk)) { dev_err(ov9282->dev, "could not get inclk"); return PTR_ERR(ov9282->inclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9FD330E822; Thu, 19 Jun 2025 18:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356454; cv=none; b=DaeDIYh9+Bqx9f7OCc1CWB9RQhq+Qv66wRD/zHH7qW2Yxe8b2ZlTlULt8xs/2/ESXjZVmpKui/0TqE4qN/b2A5hjeYlHSqnQPGWUmtWdXc/U86WklbIlEuTH9yvK4Br2OBsqHdVVuq+dP2++NRvHwg0rzClUD+Zst+7Qwm1snzg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356454; c=relaxed/simple; bh=GEJKwvRKpsGRwItuDF/XoskMvaj7D897Ua16ackYBSg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B+aDBY4JQia+Ney1JR3q2PL4XPmgfvkD9CVzw5ClHxvozOCW/geQMRzPFXg4ukVtW23cVwiBuoKWGueOEp2z6raZXNAp3+N23KOmCdreWUq0v+VdKe1os0kLAlLj05r1jg3O9LDQ/Wp/lzppRRn1+Nx1pAwHGeJACY+KKL/s+GM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZtBJa25D; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZtBJa25D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356453; x=1781892453; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GEJKwvRKpsGRwItuDF/XoskMvaj7D897Ua16ackYBSg=; b=ZtBJa25DAyp/3YZDude6FpHI/c8zTLUF0VuKY107zlcWwj54w6fV0Yt0 gzFRnPGxsek8ykp0rt2osnnjb2pJ2+URiVv0iApliP2wWFnDTAngAvtYA Uo9L79bXwnr1JZ2wrNu+mvvUU1GjiXNzkZDa8WxTpd19vi3pWLn58DtwX T+h2rLDTuz2iRApezauM6VOq1VdP/im6u+zm+OXF5YC931dKDPNaBf06Y 57eqBCgGuRfYQ5I3pquReerQ4LqWRPiu3KeS1WZlNM/YuicwKzOMwXx+n oPfJyJ3Pagnunfn1im2DM940j3kpNtn8x2JPMxMib1G1cNE/FhR5CXNRx g==; X-CSE-ConnectionGUID: 3xAEffMORKa+yC+8d5aIAQ== X-CSE-MsgGUID: GZ5MYcLZQm+0vXjVD7Sw5A== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64049004" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64049004" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:32 -0700 X-CSE-ConnectionGUID: 5QzMaKxrSAeJf6kGLvdW5w== X-CSE-MsgGUID: cvmNQKzJTy2gVKr4wPqH5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919867" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:22 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 43/55] media: i2c: ov9640: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:36 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov9640.c b/drivers/media/i2c/ov9640.c index 01dbc0ba89c8..686d69c1a8eb 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov9640.c +++ b/drivers/media/i2c/ov9640.c @@ -718,7 +718,7 @@ static int ov9640_probe(struct i2c_client *client) =20 priv->subdev.ctrl_handler =3D &priv->hdl; =20 - priv->clk =3D devm_clk_get(&client->dev, "mclk"); + priv->clk =3D devm_v4l2_sensor_clk_get(&client->dev, "mclk"); if (IS_ERR(priv->clk)) { ret =3D PTR_ERR(priv->clk); goto ectrlinit; From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D852830E821; Thu, 19 Jun 2025 18:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356464; cv=none; b=jzCZgomR9mHvvjkTyWvxdKAeEFjXbiew3wbkG0yQ8RYse4yi7R6pV2tGUH4hvlXOd2hgsNwMHBe8xHE3346a1ZUSP+EBzb6dXJFsW+R0cujlXDYiLF9yfk/7YFW4SR7L+53Qkxaz0Vn3S1s34i293Ml1t9E8TVlKM0smaS9Gkj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356464; c=relaxed/simple; bh=CmT9rjN8h+llFAh5a8g6bWh/WApISWsX0k1BnGTQgnw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pGZVKlYhkLt3YQ9PmDqvJbm2P2Og2rmTBdAxyuj+v+ErU3ZdC6slkouNBrEQcoQYml4omJ9VxL6NHlTVhX9qQ9GdJzuTXz8r83tTrGpwAVdytonQZi8V3OSFlwuEQ5gowZJy3LzDKz2Xg+L1sPD9mfz+MDifCLWLo8qd4yUKfXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Mmse9E6V; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Mmse9E6V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356463; x=1781892463; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CmT9rjN8h+llFAh5a8g6bWh/WApISWsX0k1BnGTQgnw=; b=Mmse9E6V/Ma2VnPVdQyoCWFse+hcVuWYBKyEYQGofX8DbyllXK4pU+Pi 70Jkykjx2XlsA+StBJUHdPycgraWwW0QbAb4T/jGikbd4KG1/euZ70NyE d55QVgZiAwsNUSesRx92i5qGN4mAB87iiLlKKOcbx3BCJ1GsG5cYDkGml xoRfLjLQ3d4VncOqfKVr+mteviHZ1wIii7wv1fUBphcC0AOJkImuM1eCm licqVgEJPtZPy0KTp86aHXZrcE2ZPJK3K8ajU/gQMc4BCJhnLMBENyB3o M/wLLqaar8qgXlj2hwjEwTi54hW2H4XFgWJ3ZbiMzgCejjRn/mDaCmqCV A==; X-CSE-ConnectionGUID: ipTSyXeCSva7x/AmWFVoUQ== X-CSE-MsgGUID: Dvga30dvSte6EIRXn9AY0w== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="64049040" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="64049040" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:43 -0700 X-CSE-ConnectionGUID: h4GYJssvTB6XwOe7Xc4rjw== X-CSE-MsgGUID: +UFWHv1HSQCnIfHLCYIhPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150919870" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:07:32 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 44/55] media: i2c: ov9650: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 19:59:37 +0200 Message-ID: <015b80b572b564e8af10ac08bc594443c23f16e9.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c index 026ea34d6291..18c60c91aa40 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov9650.c +++ b/drivers/media/i2c/ov9650.c @@ -1494,7 +1494,7 @@ static int ov965x_probe(struct i2c_client *client) } =20 if (dev_fwnode(&client->dev)) { - ov965x->clk =3D devm_clk_get(&client->dev, NULL); + ov965x->clk =3D devm_v4l2_sensor_clk_get(&client->dev, NULL); if (IS_ERR(ov965x->clk)) return PTR_ERR(ov965x->clk); ov965x->mclk_frequency =3D clk_get_rate(ov965x->clk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A98830E820; Thu, 19 Jun 2025 18:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356607; cv=none; b=X5ci5vM4JWLQmyPZ7z0gKzMP2fxhBjXiDUjmBh4LgUPebLsp3aVY8gM9qfX4xaJgNkdcvElu4Qal8bcj/+XvJUodW9KF+4FBiWQkfWmsBi6C8/zdeobpfIQHpLg5Nhqqdbpiz9k8zlP4+NJK5eSF3OLP6qNU0MWEUMRmBD+S8aE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356607; c=relaxed/simple; bh=gOOzEz2svWzVTyBGU45S9ePS96TyAZOIlCv3DRPqwkE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OZql0EV08fR4XzdDPRuI2Ln81sE3o1DrWQJuRELY/5tIZGSMpsMM+Vr5lSsPJEoegrFoO7epk3o7D6eR53V1Gvlrd+vAgZ3sf1S8GywIhdhT7FGfgVvhnZ2tAsW55zSYN9GO7dodJ0sgUY4+MOv3BefzQzDof4QIFmxN3DfEfVw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AxFScAK4; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AxFScAK4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356607; x=1781892607; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gOOzEz2svWzVTyBGU45S9ePS96TyAZOIlCv3DRPqwkE=; b=AxFScAK44fBpICdtX4uO99rY+/8//ovULZuRYxi7yfpq7RSd7oOfthLV 93xVi8exWQVG251emZi35rrt9Q1SdKtB9/F36YArTXEfJ0Iv/7ogyOXEg MtjmHpMzSZskxMEPHGEz+fOv6An4qJeNkPyRHyovHS9GAXwEg9g5LElc9 X+q8bEHwxez2nYxcek9SFA72k2BX5WtbIUw1CYJPhaCURjFGhxyBxhQRd KmLCBGuTGkPKuLdgY9LHWkFIfIAs5V+qyxnXFBa/33QqQDE707gB2hRPU 0Yddv16RH1w3rnltnO5De9ugxoHBiE+L4OTCDpOtTBYHJxgGDIIvWSnoP g==; X-CSE-ConnectionGUID: vPReAg9hTO6V1Ib4qCvqbQ== X-CSE-MsgGUID: W7w9DEeNR+io771XEytBxw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="52706739" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="52706739" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:10:06 -0700 X-CSE-ConnectionGUID: 64Z25vMkR7K/9vXKm3kyog== X-CSE-MsgGUID: n4RhHVIDRDyHWFQYzXwVlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="156508915" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:09:55 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 45/55] media: i2c: s5c73m3: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:09:47 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s= 5c73m3/s5c73m3-core.c index 7716dfe2b8c9..ff0ced2d8e98 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c @@ -1556,7 +1556,7 @@ static int s5c73m3_get_dt_data(struct s5c73m3 *state) if (!node) return -EINVAL; =20 - state->clock =3D devm_clk_get(dev, S5C73M3_CLK_NAME); + state->clock =3D devm_v4l2_sensor_clk_get(dev, S5C73M3_CLK_NAME); if (IS_ERR(state->clock)) return PTR_ERR(state->clock); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D23530E827; Thu, 19 Jun 2025 18:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356704; cv=none; b=Eo1U3S7fCpAS4wuuhmqW7n3pvhzs6AbTtZrPR7ApqlcxJuVZe1P7juFPIloN4CFvPx+1DFhbVPZrWxDX6bwFdxEiveJelr+MtY06LuIHwxA134eDTpYTY+8k7kqURVRPmN7IDdL7cqyyL2GfoY5G98FXz6e2iU6mNpA9FriEcBU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356704; c=relaxed/simple; bh=u+HYL/MjomKoU42zZYmC3mQI9Nv82B1dv3/KNsTDo2c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GNiRbxlULJb4B7E9OsFA0P5ua+simb+BjPfgcLr0iiThjgfIptSSxzGctVDbn1PDVXuG9Jpef70IYTIiMi370+zpfQ/DxHgxO1CiIGvNZRFa9zdYR29E25zIYOb/t97+DnHaQfyv7s7t5uAwtzA+wjwXrPJ87M1ATgyHnKMXgUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jbRMyp4d; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jbRMyp4d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356703; x=1781892703; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=u+HYL/MjomKoU42zZYmC3mQI9Nv82B1dv3/KNsTDo2c=; b=jbRMyp4dBF52v6VJ/RRqGrWxq72kuLixRf2jEw+uLRNQbrYM8qZhY5eG FbmHQLnVShax1DLOnc0JBqYA/Cg49pHThFCy8XvgGEzWaSQYHvTvpspEQ Xl7Ev584GKTOAHkCxRnmOlH1oxydjuKw5XAV6dqWPKXhgdlEpSASAclDA cp8Ae3Z7ocBEcBGfZPMYV4JZOcsODG88vkRHsc+ioLfuLJV1kvxwo2nJx X4/Bd7iZf3Ao/Mrk6b6eGrae2YgHLppxP5BYqfDkVpah+QG7IScmkqDEJ bRzLO7vjOF2AYkjiENBWcpFqkv4AT9pjYYGa6XMDbwkchLzCt7KlkZBzD w==; X-CSE-ConnectionGUID: aSz1p6eoSqG5dHr4H71XcQ== X-CSE-MsgGUID: KGjIsUewQ+KgNvDYVM0kqA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054265" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054265" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:11:42 -0700 X-CSE-ConnectionGUID: Y1Rhx4+USu6+JomqiPjZ4w== X-CSE-MsgGUID: bKumbF1HT5+VNkcsKCJ3bA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143595" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:11:33 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 46/55] media: i2c: s5k5baf: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:16 +0200 Message-ID: <01a20363c37c8cfce366422739a3dcbacf523f5e.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c index 24f399cd2124..01d37f49e5ad 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/s5k5baf.c +++ b/drivers/media/i2c/s5k5baf.c @@ -1967,7 +1967,7 @@ static int s5k5baf_probe(struct i2c_client *c) if (ret < 0) goto err_me; =20 - state->clock =3D devm_clk_get(state->sd.dev, S5K5BAF_CLK_NAME); + state->clock =3D devm_v4l2_sensor_clk_get(state->sd.dev, S5K5BAF_CLK_NAME= ); if (IS_ERR(state->clock)) { ret =3D -EPROBE_DEFER; goto err_me; From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33EF630E828; Thu, 19 Jun 2025 18:11:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356714; cv=none; b=EuparQsB9neD72DSuaw4HKSkfbhB7TQ+ukpzVjpr4+Aq/Mz1I9Z4xQ/GKMnitPk2kujLEs+Ad6v+mvVR/69FtTNwadXCO3WPYEF+B+cVdlRI/6Yr8HBSyyCezx5cW0lol42hDBLsnaippm4HymhkTc74APsCk8FBlFzu111KYiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356714; c=relaxed/simple; bh=QhPWK86Xf3hO19XNIn7CIvj8X6kOySTO7Hyu+ruqVxQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gma+Zd7CR9cx1o6RS/m1eBj6F81W1YNmgWxO52d3U30WOR+5HwBhAKaI9DdlL4X3DnE3IT6GOTzcnwLYcYLz2wmcG0hpDrwhwsexjPYSLRRGBm/HDYsgfHA9g3wgRuzklKmoW+KSXpYjZyPJzo/WyNHsRy9RPbvC9/H4Vc4PfLI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ccbs+E4X; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ccbs+E4X" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356713; x=1781892713; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QhPWK86Xf3hO19XNIn7CIvj8X6kOySTO7Hyu+ruqVxQ=; b=Ccbs+E4X3zeqmJDMDj5htuczSgUCUjMisjx5ZD3fe7CkHD33wsjgRLUP QmB6MOO5o25it6WTr1aHciShrsAyyl4yZc62+PUrhauiHOkViDhR3ZzOJ egmfZwsNoA9TdZjFSUBnjhHDGeWJb6zYR+tss+ePVRpndVmr0gus1sMF9 435MwnG3cYBEAQow05x3eXZLaEqm9nBouYURW+u20/1JUq7uKUfJTYM4P kjuQSxLkZnQxpHZrzfU40j9L+IlxeFCIPNcYmtRzVfBO5QGectsFHcB8D OYkB8CrKV5wUTMyQm0poNDKPEgnNSFpER4PhJrnZT1lMGbUqXAQlwDdRs g==; X-CSE-ConnectionGUID: n2+kYDirQMGE/fCv8En+xA== X-CSE-MsgGUID: cRkHM65AQtirEcVjAZyogA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054292" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054292" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:11:52 -0700 X-CSE-ConnectionGUID: Y5Rd91hxTAiRqUS8gdj1uA== X-CSE-MsgGUID: knutO0+2SX+TAKLitfUdHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143603" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:11:43 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 47/55] media: i2c: s5k6a3: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:17 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c index 0c2674115b7b..927efaedbcad 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/s5k6a3.c +++ b/drivers/media/i2c/s5k6a3.c @@ -292,7 +292,7 @@ static int s5k6a3_probe(struct i2c_client *client) mutex_init(&sensor->lock); sensor->dev =3D dev; =20 - sensor->clock =3D devm_clk_get(sensor->dev, S5K6A3_CLK_NAME); + sensor->clock =3D devm_v4l2_sensor_clk_get(sensor->dev, S5K6A3_CLK_NAME); if (IS_ERR(sensor->clock)) return PTR_ERR(sensor->clock); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4C3728EA62; Thu, 19 Jun 2025 18:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356725; cv=none; b=DWYebvku67e/g3q5yNL3x6O1ES/c7C9ohZ0mlBZHu2cM7zn4cHvNBI4A8B9P/h8dpu9Olc2dGzU4soMnQS7AnhOTxjX0RbfFFa2TPYPCALFrwx2+kyiv1ry2GFH1GOydQmPMmLJSfXLHBHYeNy7DJygqJGSD1yPbFW6DHjuu/04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356725; c=relaxed/simple; bh=mfqjgIJdMTFb3Dlkv/AjZzAUoTFmJ8OVUUvV86hoHdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GJE4AYZIktXizIx7JOXIVOUCvfh6a2p6QsV44zvVJKmdr9Bb425Vmo87LnJtxZI4g3RjbL90dDQvAVQlXLNaWrOYkg5dV//ZGAdDyW2d5udL7c2cRmEyE3D9hDPJwe9lSOqn66ulZR0+SQmBnCInBDbg/nm4r2zjhdvzBX4rBag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=iJxRFuS3; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iJxRFuS3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356724; x=1781892724; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mfqjgIJdMTFb3Dlkv/AjZzAUoTFmJ8OVUUvV86hoHdM=; b=iJxRFuS3oAiwRrAoG5celAW1uM9dMa2GXsXaA0jTBUqm3Sgp7kWYM/54 AsbIcmwtMrw/SpWakgLLXt36loNkA9vaF/HMGjRvhk5+yTjMkYWrByNYO WJSFEw3AmbCtVnB23Eo+7Kwa01Dwei19hNnakWtZrSJxfqi3EDpxREru8 hnFdJfMIE08P0+WDcp2hkBUfVYO0gEd54LUEZLwsxk49gQFhqMtWHQeec wFC9tSukVpjpg8jAdolldHIU+JBNcDLuB4UTfSaZ0EwY2jUFmbNOmutb3 LyENVu7iShIEI66h9ZlLZuPQRlAaJiBCNWT3PyVhsHovnUcLLXwcpFm7a w==; X-CSE-ConnectionGUID: 6n3UCfDvRtiDhmJR0HwNkQ== X-CSE-MsgGUID: Tp9lNxGvTwOae3gTQ7Szhg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054330" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054330" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:03 -0700 X-CSE-ConnectionGUID: FG9XLWD5SPqv6IZhFylTyw== X-CSE-MsgGUID: WP5S8hRxTCGP6P4BtdElNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143613" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:11:52 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 48/55] media: i2c: st-mipid02: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:18 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c index f4568e87f018..ea848b52f628 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/st-mipid02.c +++ b/drivers/media/i2c/st-mipid02.c @@ -817,7 +817,7 @@ static int mipid02_probe(struct i2c_client *client) v4l2_i2c_subdev_init(&bridge->sd, client, &mipid02_subdev_ops); =20 /* got and check clock */ - bridge->xclk =3D devm_clk_get(dev, "xclk"); + bridge->xclk =3D devm_v4l2_sensor_clk_get(dev, "xclk"); if (IS_ERR(bridge->xclk)) { dev_err(dev, "failed to get xclk\n"); return PTR_ERR(bridge->xclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D200019D8BE; Thu, 19 Jun 2025 18:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356969; cv=none; b=Jwj/iIv/ULOtyeMyy9DF9gp9veeMeXyKu3lWnd6tq5QhB6QuysApksmuur3y+WihnZyRGZq+KRqbQQ8dQYu5CovARXiFE5Cn0Ngho4XiUFmko4fDDznCrhJ917xTiqPkWie5d//d4ygsXXQ29XQcyMPj8VVFBskRHyyvp/gbqx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356969; c=relaxed/simple; bh=mpFEf+w0QGLYo3xIzQedg1K/z/JheVCzGBaCbwHxiVg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uhkbVFlZETmLFH7mpen0RblZVoakOWrF6itURb5Gu7hEuYnF9YKkSjs6nzvWXu3BzTfOsHPJ0ayT0fsCKSvyj8Hh4t4qwTguU+CTWiBFtb1TVaCfrxt3TgYVhs8aLZwBC64x/g6CDaFVtpxKyzLV4LVCGGJs9Z2T2fRoQUySRwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ll94N3XT; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ll94N3XT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356965; x=1781892965; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mpFEf+w0QGLYo3xIzQedg1K/z/JheVCzGBaCbwHxiVg=; b=ll94N3XTVD05+qnXp3sVKF3GgbCc3rgPZKxkEhiCQCjQOcIoRLgx7cj1 p+TNqtachkCl8AzX582A1MI8yRMWiH6Wf1MntQbqGZ4s+1Q8wT/TvFUfo PN3f1qvDfY4I+rWrdqqSBp1ESPuGYnj+KSN/vD7W6bLNCSYgVXNjxDlmn 3S9GLbECLXrugb03tNcjxqXDBY6wPHJkuTURx0DWn08p1A9vYLIOcARwG PHOjB/Jvtp4XPiOwELq0/22Ww7qOxlHTom9VS180F8+IpSUmjZFaEZx/B 1lKPGS08HbgrGZ8EZhy6uKqf+PIs4Ha2o5eURYzwla8HewfDLb/gKhVYz w==; X-CSE-ConnectionGUID: 2uRCA2NlSR2ESrzT5RH+LA== X-CSE-MsgGUID: z40fsIsTSKeveLJLNxy65g== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054863" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054863" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:16:04 -0700 X-CSE-ConnectionGUID: Z5VQpXgETg+pWLmC9AnLHg== X-CSE-MsgGUID: kFNKHWbrTx2cr+nh8FALJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150144287" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:15:54 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 49/55] media: i2c: tc358743: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:15:36 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 3d6703b75bfa..24043461b60a 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1930,7 +1930,7 @@ static int tc358743_probe_of(struct tc358743_state *s= tate) u32 bps_pr_lane; int ret; =20 - refclk =3D devm_clk_get(dev, "refclk"); + refclk =3D devm_v4l2_sensor_clk_get(dev, "refclk"); if (IS_ERR(refclk)) return dev_err_probe(dev, PTR_ERR(refclk), "failed to get refclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFE7C2BD000; Thu, 19 Jun 2025 18:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356734; cv=none; b=ipLL9LqfsOXkd4SlEY0kmIZNCh2ak6DiQ7rWl0dKnVvRVI0ldMQu8fbN5v2YHeIIYaSnIZG6x5PUHSXybW9olWJ1Rblb+b5osscrJGx6e4BuVkEds9lIppBP5OV7W+6LsQW8ijk0SOaWZJWNF8DuECcl0SHkx2k2xIGSmfo4QnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356734; c=relaxed/simple; bh=1Nn/o2nuXOF2WSKEl7KGbdIlMXsDwh9W0PIpKVz01n4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cet0v69mrVETr0wqGDYOfCw50qT65GV5AAjhMr66x7R35cGsXBEqUrASC0SKTgKFvukvPv712i/juwYllKwI1r0g3y43t/uEMD42op4sfYMfV8NRoLV1hh4WHlhV5mOErSQcQpXLlpuhcCjACvlCF8dpUp8TZxOhJoTpjLnYNLg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=i9vlU9IJ; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="i9vlU9IJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356733; x=1781892733; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1Nn/o2nuXOF2WSKEl7KGbdIlMXsDwh9W0PIpKVz01n4=; b=i9vlU9IJhh88N3FxRRXcxPciUhiH2YAGadUcXQ38Cik+hwHdj7q0ZDmr 6Oux8Ac9plwZAT+Ub9xw1tQT1Bta7bclBXRD1MWttmWvcWBLRUiRLP37I VrIEIecM5fLaPhNuu8sipAw94SjuQldOOLuTJEqOfha259xvsonAMMKuI dtqZ4IIWiG7sfBMtblEqX8Vl4iyEtIEvVDdxjIbmiHXkAlc8afoLvMRlp e5r09p2AAanEJzIBRDxAaiDpkGaZXYjzp+fnEx920rVSd4FdSRSrBSHps urt/kTb9RpS5fJn6nifKzu7zvPQaWiw168qEGlI95o2g089MEjIYAIRdm Q==; X-CSE-ConnectionGUID: 54ZavXRVTe2m56ko8NN5Bw== X-CSE-MsgGUID: u0qgcgBFRkWT+Ed5ffZpAA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054390" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054390" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:12 -0700 X-CSE-ConnectionGUID: jDqTubunQNuKA0Qv1oWq/Q== X-CSE-MsgGUID: E31axTxHSvqxOHaE1RFYXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143645" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:02 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 50/55] media: i2c: tc358746: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:19 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/tc358746.c b/drivers/media/i2c/tc358746.c index 143aa1359aba..66d271cd516e 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/tc358746.c +++ b/drivers/media/i2c/tc358746.c @@ -1525,7 +1525,7 @@ static int tc358746_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(tc358746->regmap), "Failed to init regmap\n"); =20 - tc358746->refclk =3D devm_clk_get(dev, "refclk"); + tc358746->refclk =3D devm_v4l2_sensor_clk_get(dev, "refclk"); if (IS_ERR(tc358746->refclk)) return dev_err_probe(dev, PTR_ERR(tc358746->refclk), "Failed to get refclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07AEE2BD032; Thu, 19 Jun 2025 18:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356744; cv=none; b=uRToCzqpwk4VcVbs/FEX3Q9d4f0rJA/yDnyK8LNEv0eDQQ9P0LiXOCOySTqaEJ06igAvXyl6Wu7nJ/f9tONg7fWEKeskbgANObKKW38NLiNhZqpSxq0THyVk4WTBF2NJY7kYWzF6bHqjyOTGDOV0e8r2U1srY/oIf6/D5DWhmtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356744; c=relaxed/simple; bh=bTo6px3X1EMi1rbOravRwlvb8EcSahPkxhRIpVezF4Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GUQLGB2vKXoKXkaRGcCFeZfjZ+bIiKmlklqgvZvlvwlAv57OtTIKlM9eVWCQg2dhbO0KnjscRmMRwofmqkWV5QpYnqdqwi9VRn2d5yhlDyM+VgpxmYEQp1OsIM4nT3m1i9d997brNkBcxKcnF3/8w0hHUmWq6bbT9npIn4EzITk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ex25Tytj; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ex25Tytj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356743; x=1781892743; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bTo6px3X1EMi1rbOravRwlvb8EcSahPkxhRIpVezF4Y=; b=Ex25TytjzxxcIvkzq3y5ph80hW57p7FOirDntgT9rUetpTrkuHwFZMju kkZOAQx9jpDHshMNm0f3Gi0J82Gxs7MeHRLx0DJp6lcBj4S6VUpuaIPZM f7bncecVzNik+U/LNYzVnsoV5KosyH5hwzbteU+MbhrUgcTIkXTJdyawa 4kP9xL+2/c9BczO0zj7eBby5IDDT+8V7SjrggLywNwIG6ae1ex6syUqDD kOGCXeNAXFmOLLKAxh8Abt4A/WpguAuwRjTTPA/shVz7CIpyJr3oX5mv0 7BUDqQc5BdqhSpNlQfE6DficA3s9cSnjhj8Nl2f5q6BPlG5rf3ntXA3CQ g==; X-CSE-ConnectionGUID: Mk98FO+MTbKGIXq17PT1WQ== X-CSE-MsgGUID: d9rXg7bGRZ+fyxT24Ytxqw== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054432" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054432" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:22 -0700 X-CSE-ConnectionGUID: cmz6Q6iCRvyqzah3W+VjVQ== X-CSE-MsgGUID: 9FqFp6DjQM6ySAoxb72tnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143673" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:12 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 51/55] media: i2c: thp7312: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:20 +0200 Message-ID: <840db3da814e0355bbb572e07f1ef794831bd8e7.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/thp7312.c b/drivers/media/i2c/thp7312.c index 8852c56431fe..ca5c5c409c8c 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/thp7312.c +++ b/drivers/media/i2c/thp7312.c @@ -2109,7 +2109,7 @@ static int thp7312_probe(struct i2c_client *client) if (ret) return dev_err_probe(dev, ret, "Failed to get regulators\n"); =20 - thp7312->iclk =3D devm_clk_get(dev, NULL); + thp7312->iclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(thp7312->iclk)) return dev_err_probe(dev, PTR_ERR(thp7312->iclk), "Failed to get iclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CABEA2D541C; Thu, 19 Jun 2025 18:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356754; cv=none; b=TyyHlm686nVR2UeuKBEwEdbhVMPktV3pTdLgK6Xehe4FI5A0gK8t41+0NIjYefdBuJgOiK0kO01guRxpib9fGU3//yRpoZUczZWiJsYu2Sb0APY2fnJDu7oRfjkSBCFcTUMIOSjBcVJScncDZcv/B4isJXZPgJW3duIRWvznGMA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356754; c=relaxed/simple; bh=Fr+uekS13Gv3UvXrP5pfY/9p2ujO/ed4B9WCXFrCIkM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c1B4ApMDiKRWoGWloVl2HbaG3OegVSFW7PJ2Q5ktOpIYHArlIvvFEowuU8mnWArbaKW1hx3Oe8/mL1asE2TlzdWr+HX3YsH0wQdkFJj5B9sBHqdFVS/pw6A5TblyZqY7xH83K/bKOn1WMxc1LGQIRg0f63oeuesFaX+et49hxzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=n2qx1M9y; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="n2qx1M9y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356753; x=1781892753; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Fr+uekS13Gv3UvXrP5pfY/9p2ujO/ed4B9WCXFrCIkM=; b=n2qx1M9yK9J2t4lSUWngnvA2tUN2QzEaZihuqp0R1cTviv3f9IPJcN3l 3j19WP0YLrWDrq1dj4mivVwDi5JUApvm1GLfrT5CSLTL/0kQXteB8Bkrx S145lJIMRF1V9sCD0ytGvtufV0fY+qes46h5Ois/jjl51Bq4sVR+OMiqj r/bV2cW6ME53FYxviT2nOTRa0DgdgALIJPKq3wfvVVTTf+e5/YUkeWWf4 tyAG3IrC2tyCgMwnGsYg4ALzOlOwKPpvNrwAs6ZTNEUFVIo8y2UxSFpg1 N6rmLDJEgNLO91Wv4LatPMG9v8hbdfso2G8rL5lrcjIn/DFRQu334f/jD Q==; X-CSE-ConnectionGUID: byjcI1YzRmOyww9G8JAgKg== X-CSE-MsgGUID: dH7AMw5UQmKDxAaqEroVHg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054467" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054467" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:32 -0700 X-CSE-ConnectionGUID: cIhnqYKPTnqiWEkQ9vp5+Q== X-CSE-MsgGUID: PfXhtw5BSgO8RMfY61DPEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143704" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:22 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 52/55] media: i2c: vd55g1: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:21 +0200 Message-ID: <7ac494567473a27d0470dd65e37415b4e7c454a7.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 25e2fc88a036..693db225e04d 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -1863,7 +1863,7 @@ static int vd55g1_probe(struct i2c_client *client) if (ret) return dev_err_probe(dev, ret, "Failed to get regulators\n"); =20 - sensor->xclk =3D devm_clk_get(dev, NULL); + sensor->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(sensor->xclk)) return dev_err_probe(dev, PTR_ERR(sensor->xclk), "Failed to get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC32D28DF25; Thu, 19 Jun 2025 18:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356764; cv=none; b=WzT2yVmcP44dQo37ObJ9PuuuSPut71uynh8w0ChwhHfG1xqtivGtFfu804bYFLlY4zztaX83PGiOoC9q0RhKUudvayx7qEcjPMgGn2bSLVh2oqLH7lXrEyi942MkPeNQ5SP8HoxF0FNBBTLbdIr0msFDlOYYqLnAeMizgv+tfGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356764; c=relaxed/simple; bh=oT8FbQZ3WZ8aiT2xzMJJKrg0Q9nmErWwFkCSYAZuXlc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mb/HI8pChC60CWxdc+DKNM4/ezljtg0cWfwAk7SKunHCrWixWMqUJ7R+53wfg7ajW+TS5F6UQv71A+2p+CfTk+7BfMQUSwH83Kc+O29XnqevA7EV9oJi2It4M/JXNEeuWuEsnYAvpTs/aF7U/oyDxBdpmwTsgBJpJV1KhIbdtP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CiK0omLT; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CiK0omLT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356762; x=1781892762; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oT8FbQZ3WZ8aiT2xzMJJKrg0Q9nmErWwFkCSYAZuXlc=; b=CiK0omLTQ6lQ/UHY05KMWlB/ljzH6YTCTrfRD8/vPvuHq+j4mrDXcDfJ GkvkN/6ke7yj9+h41759fbcTaVNCiJzGiPbmra3+YHX3fUXykEu88QXGB btyjLH0WYHPhtuJzFwCqwPi8OY+AMcO6VQcAJK6iIj4ZkToCLI3c0UrV3 xAQnoWfRIuOX0PSfn8XK2nQ3gfvhoR/VM+LaxqjN3eMqnO+/86+Zt834P zPoxuc9O3pzhrShrHVnJpDv+ZvYfs63V18CH1qeUbW9r3hzfQTWlSip6K oXv9r/QFQe+E4yv4h1R46JkdVzbaURscybIC72NndNlv3+cN9NvciFp0Z g==; X-CSE-ConnectionGUID: Xc08+7bNT5+BKjBPxDiuqg== X-CSE-MsgGUID: HnKH9DXtRmqT9O5cIwlYfg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054499" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054499" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:42 -0700 X-CSE-ConnectionGUID: GXA3uZcpSu+idVhju7F/Kg== X-CSE-MsgGUID: lEDrlKcURZej0OPpBgX0Tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143720" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:32 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 53/55] media: i2c: vd56g3: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:22 +0200 Message-ID: <7eabbe177e33cc7974913aa3c35d56456dec0456.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/vd56g3.c b/drivers/media/i2c/vd56g3.c index 5d951ad0b478..ac3e868dbb43 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/vd56g3.c +++ b/drivers/media/i2c/vd56g3.c @@ -1474,7 +1474,7 @@ static int vd56g3_probe(struct i2c_client *client) if (ret) return dev_err_probe(dev, ret, "Failed to get regulators\n"); =20 - sensor->xclk =3D devm_clk_get(dev, NULL); + sensor->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(sensor->xclk)) return dev_err_probe(dev, PTR_ERR(sensor->xclk), "Failed to get xclk\n"); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD2212DCBF4; Thu, 19 Jun 2025 18:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356774; cv=none; b=odHibtjJXyEWmba6F0b1ifbh/CgyTsat9dNT/vDuvbj8Gsh6VYGdnfY3VkCurj7LZhBpfeARh3ftbI1z/uQ5Sq6q9EVckE62+QLVEeIb5W5pzO1BzM8LSLF1JTuZTqR74ZDDOGrnQafqajMw9X2q/wVu7jIHWlNK7aWINk0hTvk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356774; c=relaxed/simple; bh=nO4IF4mR8vlPMMdgNFL8tIvgTckUJOfCMFNKPR3FzCI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NcxNSDMlX2X8BCtTV8YLNevT7RQTay2kMPKJr3rVucha3tQI8/yeQKrRUnXKkK6kfRQDJhuL6AWV4287sMQ/DqFvrswND3igBfqUcr8InSp2U5HPTnBR35QSCVdEW4CrlVsGgBrXn9H1irMLYuE5so1Kamc52TFyxeHSytW2lzE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NJioWVUC; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NJioWVUC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356773; x=1781892773; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nO4IF4mR8vlPMMdgNFL8tIvgTckUJOfCMFNKPR3FzCI=; b=NJioWVUC3NTmqtSkHhM0uqdlXkVzBw8JrTFm1kExYg1JuX6eLA2SOFkE Q2BGa8ibpoj2yQe9Bg21QVmq/jSO3udVLBHBzG6tcnzRhE5LSQBInTgro LEpYztPNA94Z4KdLLND6FSq90Hb3x8BMSbYMR0M6rBmdWCHlcoW2O27E5 tNT4N5imPJOQFZ11M66s6Phf44kbYJzTOvpsuZxR7YKdNtjBKMARKmTVr 3l0WVLzEIjBaQrqwWc9Ss7Z3sit7/e0/g17txdfcBp0M/ZASJNpDdan63 AWEQj+A8CsK+bTD4+uoI/SyaFYLsHlv7Rdr+QYYbAahr7zx7fvkBDSf0o w==; X-CSE-ConnectionGUID: DsLyKMvUQUOtqEK6mgvfkA== X-CSE-MsgGUID: 9FQpvFliSn240uTIb6n0Ig== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054532" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054532" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:52 -0700 X-CSE-ConnectionGUID: ZDuf7pZ0Tl+OZqL67h+KXg== X-CSE-MsgGUID: vscIPv4wSwSc9xdqtCyl8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143735" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:42 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 54/55] media: i2c: vgxy61: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:23 +0200 Message-ID: <2c6da6bf52582377dc293a0be2de25d9df13d8b0.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" devm_clk_get() fails on ACPI-based platforms, where firmware does not provide a direct reference to the clock producer. Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c index 5b0479f3a3c0..d6529379d513 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/vgxy61.c +++ b/drivers/media/i2c/vgxy61.c @@ -1761,7 +1761,7 @@ static int vgxy61_probe(struct i2c_client *client) return ret; } =20 - sensor->xclk =3D devm_clk_get(dev, NULL); + sensor->xclk =3D devm_v4l2_sensor_clk_get(dev, NULL); if (IS_ERR(sensor->xclk)) { dev_err(dev, "failed to get xclk\n"); return PTR_ERR(sensor->xclk); From nobody Thu Oct 9 04:43:24 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB891917CD; Thu, 19 Jun 2025 18:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356783; cv=none; b=hRDZTsBl+nvqW1+wSUwBKYsAk40zDqzmeiGgPO6PaFMO7+cWqThQXn0qOgBwDQl1avi/+bvfuQZJrVya9iwA09A0wYXJPTLTLlfYWy1CvriZ41cjRFAx7CbOG/D0tMYmRS6BqM9n3ilbouIfCTfeIDvPtMyanlMdDOxfuU5eif4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750356783; c=relaxed/simple; bh=6c+2N0AUxiqNfsZha6j0d5qz7pyY+SbEaXAGcihmsbw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uBkpaSKW945djvk4CZzLmy6xowAw0KE2Czkk2BT32Fb9DwdKH3R0DbuRNuoc7JjenLJ8J7oQuymMUXi4dgyQjrQr1843TJegd87TYH92UTROtKcWs1/LGIE+tpAca60HeRDPLjhkCsgHwDvb7oyRFk7za+DRB0zDmx+bWrjdPSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=czQUw35R; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="czQUw35R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750356782; x=1781892782; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6c+2N0AUxiqNfsZha6j0d5qz7pyY+SbEaXAGcihmsbw=; b=czQUw35RckoPEFbh+9Z/y6qNHjvwRR4c+XSgIu4KtzrSiXqVL3DjYbl9 axTVXXfKWRO//oAo66C0M+6ED1nP4oq4637um2x2GQ80kUDWzqwkLplCv cIEC/RDXKC20M8yXfN+ByHxLzYB/MZXRSQVN2smLV6hnpX/5MXU7tUx1o 1C7Zo1+jrDzuK5ax4qAgQLpEvyfQPoIU+mNfcQA9MyHU/sbrlq1zemh2C oqUN/rYddfLki3ftXv74mdtEevIDVIZisxch0FvwSFch7Axm7B4w0Rrqn 0Cyxk5VdtAkcxxGzkR3t6xXr0TidcRxvj4oHkLy293gpfYQPCPYe0gHmK g==; X-CSE-ConnectionGUID: 9Lyu564qQoWOJXCPEgPSjA== X-CSE-MsgGUID: jMcLAvUfTeO65XVHbLy7Ww== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="70054571" X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="70054571" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:13:01 -0700 X-CSE-ConnectionGUID: 0v6h7fMQQJObZCL07krtCA== X-CSE-MsgGUID: e7qUCbilQ+WIIAzwOoMH7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,249,1744095600"; d="scan'208";a="150143748" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl.intel.com) ([10.245.245.13]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 11:12:52 -0700 From: Mehdi Djait To: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com Cc: akinobu.mita@gmail.com, stanislaw.gruszka@linux.intel.com, hdegoede@redhat.com, arnd@arndb.de, alain.volmat@foss.st.com, andrzej.hajda@intel.com, benjamin.mugnier@foss.st.com, dave.stevenson@raspberrypi.com, hansg@kernel.org, hverkuil@xs4all.nl, jacopo.mondi@ideasonboard.com, jonas@kwiboo.se, kieran.bingham@ideasonboard.com, khalasa@piap.pl, prabhakar.csengg@gmail.com, mani@kernel.org, m.felsch@pengutronix.de, martink@posteo.de, mattwmajewski@gmail.com, matthias.fend@emfend.at, mchehab@kernel.org, mehdi.djait@linux.intel.com, michael.riesch@collabora.com, naush@raspberrypi.com, nicholas@rothemail.net, nicolas.dufresne@collabora.com, paul.elder@ideasonboard.com, dan.scally@ideasonboard.com, pavel@kernel.org, petrcvekcz@gmail.com, rashanmu@gmail.com, ribalda@chromium.org, rmfrfs@gmail.com, zhengsq@rock-chips.com, slongerbeam@gmail.com, sylvain.petinot@foss.st.com, s.nawrocki@samsung.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, zhi.mao@mediatek.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v1 55/55] media: i2c: ov2680: Use the v4l2 helper for obtaining the clock Date: Thu, 19 Jun 2025 20:11:24 +0200 Message-ID: <6284706df845a3c88826f1c3bd17f60d3e71ecd9.1750352394.git.mehdi.djait@linux.intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based platforms to retrieve a reference to the clock producer from firmware. Signed-off-by: Mehdi Djait diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c index 7237fb27ecd0..c974169c92f8 100644 Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- a/drivers/media/i2c/ov2680.c +++ b/drivers/media/i2c/ov2680.c @@ -1079,7 +1079,6 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor) struct device *dev =3D sensor->dev; struct fwnode_handle *ep_fwnode; struct gpio_desc *gpio; - unsigned int rate =3D 0; int i, ret; =20 /* @@ -1114,13 +1113,6 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor) =20 sensor->pwdn_gpio =3D gpio; =20 - sensor->xvclk =3D devm_clk_get_optional(dev, "xvclk"); - if (IS_ERR(sensor->xvclk)) { - ret =3D dev_err_probe(dev, PTR_ERR(sensor->xvclk), - "xvclk clock missing or invalid\n"); - goto out_free_bus_cfg; - } - /* * We could have either a 24MHz or 19.2MHz clock rate from either DT or * ACPI... but we also need to support the weird IPU3 case which will @@ -1130,22 +1122,15 @@ static int ov2680_parse_dt(struct ov2680_dev *senso= r) * uses devicetree then the configured rate should already be set, so * we can just read it. */ - ret =3D fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", - &rate); - if (ret && !sensor->xvclk) { - dev_err_probe(dev, ret, "invalid clock config\n"); + + sensor->xvclk =3D devm_v4l2_sensor_clk_get(dev, "xvclk"); + if (IS_ERR(sensor->xvclk)) { + ret =3D dev_err_probe(dev, PTR_ERR(sensor->xvclk), + "xvclk clock missing or invalid\n"); goto out_free_bus_cfg; } =20 - if (!ret && sensor->xvclk) { - ret =3D clk_set_rate(sensor->xvclk, rate); - if (ret) { - dev_err_probe(dev, ret, "failed to set clock rate\n"); - goto out_free_bus_cfg; - } - } - - sensor->xvclk_freq =3D rate ?: clk_get_rate(sensor->xvclk); + sensor->xvclk_freq =3D clk_get_rate(sensor->xvclk); =20 for (i =3D 0; i < ARRAY_SIZE(ov2680_xvclk_freqs); i++) { if (sensor->xvclk_freq =3D=3D ov2680_xvclk_freqs[i])