From nobody Fri Oct 10 04:00:31 2025 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2054.outbound.protection.outlook.com [40.107.93.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 132CA1D63C7; Mon, 16 Jun 2025 05:02:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750050170; cv=fail; b=PpadIciMJfWOpSuQCRBWiKbYB3IfH0kgtM1FrxZQmpeb/+6145fG6bD3m2lPGabDpXn3/5rvHedenhWZ06LWivA624O6V4qQBwi5SQqGSIfcNxD2Ie/VN4uyzdNtUrw44+S+iulUN3ZssKNOdFzpK8xMw9Wjw2BquBnrZufSh9w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750050170; c=relaxed/simple; bh=OcaSu5upayMqXAnVY3F5G71gnxO4Bf+QEGcG5++SEOg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PdwOLU9eo60FWv9ZGVZjxz8XmqgqytaBdfWBmxQbka9TnmX5O7TCTWHgpYtMv10alDUOwLfqwNF5wuwsyY5Nrr1rqPxDuss7nBbn1uMbfNWB5G9yu2vKukfaYqPWr7can2ryLm5b72Xt4/98lG6kA7mIZ9pIynLgh3XqrbFWaA8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=BB6NdGuO; arc=fail smtp.client-ip=40.107.93.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="BB6NdGuO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WyzEyg0FX1yC4wlP3QMbwEr9/jAyjPLdHztNOIRQ8DlRiEeU4Wnf2ihWishTZBWLVt9pFYfZKWOhiLBICwgho+i5tIdRIUvkejRgepKlNRgp1MdWFFkG2EGnPZify775raIzyQlSo2+7GYy4yHiZvqmXK5ZZc336PRxN5VgIZJ4Mnbuo2u+qDi+bD3i11w5v6P2DmfxTjU3wNTCnuZRkm3qG5kLW0ivefhHXZ+AkWI3yGz5K2zRqaIOhwSlckPLhK+l8Lq5EcW31jXR1hpDC5Bc9F0vyfs40L4GcPpISO0PyqlFo8QORy/gIfbz3oJQRh9Ptomkbg4d68UweeYVzHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E6EA4sxPELEgtEIyjs+802VjbqVx/acNNDcI4XIxzS4=; b=gz+O7tjgqMgplmmb/hcgX5uKySj6L3+XiOxdsvaMnsNSxaNIRDJtBzAnJFejwPvw2oj68RhNXTgfOZY1JFAPi3bHwoyfyPs3wyxLPIOkjXXnvbSngJQ0JkoRxJ9cefsSuFogauQZPS3awc+DNwtd9fzR/7nr7xt9wr8Vtck3JB47FqmVcmjOHGQGojJOwIwfl2ArHzCFw7/sHdLXrUoMQAH05XLPRcGCMwE7oD+lOt7HyMrahFKF1WggxZ3HUJRcODcr3slj806wJ4388nBCU8RS5Ac3hbhNr8b9SrzItBQp6xxzZIiutqhBzggOfs2MCDncXRl82ahqoMAtmBomPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6EA4sxPELEgtEIyjs+802VjbqVx/acNNDcI4XIxzS4=; b=BB6NdGuOmH7otcA74efyiW/LAyU+0L379p/+qFRB3cN8nexjbcHyRobnaKtAWsa91JWCdtON9zRgPIl/D9vvIz3WG5XzItpruqVqHHOIqmosaqXcL/5vorwc5ydRxkWdgyUXqt5eeykafDg1uSv78CAU3ytvR9XJoz8FN6qGnchlZwH/q0jvfKNY++fiWEgh2oZbuZTKCLlAKcbofRa7IGSpNBrknyP+tTGI65qjurpP1ot+qnDTbCrSAwOTrcrMoCKl4jL7s9FsxiBJNpROylFkBPl9YRIDhQQ2+/27dKnpLZyWrCULapSwUf50kBg72Mi+DKGWiQJU9NxmroRr4g== Received: from YQZPR01CA0107.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:83::19) by MW4PR12MB7239.namprd12.prod.outlook.com (2603:10b6:303:228::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.25; Mon, 16 Jun 2025 05:02:42 +0000 Received: from DS3PEPF0000C37D.namprd04.prod.outlook.com (2603:10b6:c01:83:cafe::f0) by YQZPR01CA0107.outlook.office365.com (2603:10b6:c01:83::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.26 via Frontend Transport; Mon, 16 Jun 2025 05:02:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DS3PEPF0000C37D.mail.protection.outlook.com (10.167.23.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.15 via Frontend Transport; Mon, 16 Jun 2025 05:02:41 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Jun 2025 22:02:24 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 15 Jun 2025 22:02:23 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 15 Jun 2025 22:02:23 -0700 From: Nicolin Chen To: , CC: , , , , , , Subject: [PATCH rc 1/4] iommufd/selftest: Fix iommufd_dirty_tracking with large hugepage sizes Date: Sun, 15 Jun 2025 22:02:03 -0700 Message-ID: <9515eb5cb58bc8dfec083df51550bd9ae6d60da9.1750049883.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37D:EE_|MW4PR12MB7239:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ca8a423-e186-4a52-c83a-08ddac930602 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pBwUDKokLgTch3yweUgAjr5sLkRb62UwaLKQ2ywZseFIq8uttXIk6H1xvHID?= =?us-ascii?Q?WxNw7vDbG7Cynr0h7eFqaoZGCg7r8qEi+FEbjZCyUvj82FnFB9ZXfOaIZ+e2?= =?us-ascii?Q?GuaWQU3OxE544UkpasKVlvd90c/9FN0bC83HE4N/fDAaBfheZ9Tiy3MdtNlc?= =?us-ascii?Q?G7Qs0KFN+Ks1wbRZFtdbhpu1xyWIjAROWASb70bDUMQZJxr8Z5MfNd75UKFv?= =?us-ascii?Q?+zxF5cNQRQ8hdpKV90Ti4lBJsAoyI1dmIPThLMHJxPNqBy2p6yl9v/K2nBgM?= =?us-ascii?Q?/HWFdcVJw8Z1i6kbGQBP6M4V3Cclv+ci8SFGIw9zdkRz7Rc4p9MB3XjMqSVM?= =?us-ascii?Q?BIDYk8DxGXhU+He4CwTgini8xLsg9FBz05Dv2vXc7BfSz0p3uPP8gurKZmIO?= =?us-ascii?Q?+bB8P7pgX9mOHoVB+C47GnSN1wMWn383LPVAJMw3r5otsyISFkHXCBzteMWe?= =?us-ascii?Q?yC3CeNRdxhDPT7LJ3B6e9OFouZX3MYuvNULlPn5mIKeoDdlBkb0b3lPbqp9K?= =?us-ascii?Q?KNvregDPDr/tOnFPSfTkfKB2WGeyobFO8xE4MyK6uRfO2MelNQ1PSoWQZWc3?= =?us-ascii?Q?AH4+tbM7YEwLAdg4EGkGnKUjuDNxMkVD3Dg//0gwpwhGogc4UKMb2JNLENEK?= =?us-ascii?Q?kC5PX27q8sFRVjW1qZhSKoyTnKdTatvgz/CwjQIoJb7Ye/KGayYatI/LEGtP?= =?us-ascii?Q?YLSXBJWQbzlL8tLpx/rtQNiJml93px0PftdIum4mKRO0lwtqw99ALzxi5kni?= =?us-ascii?Q?2KmOBKpUPTWNAv6tvmU5fbYu4hq86vqR11oI0zOPU0kTHOXyLuKH8flccAl0?= =?us-ascii?Q?bIbcK7ezsALIYPRFQ5JB23fhnk6u/ICAkHBXh/vNHSOFtl++iK4VDR2WI0+d?= =?us-ascii?Q?1odcb6x1KTNjRGk2uyxHJ4pESzc0Y3Wm5SBrLOL4DPkWWc8lnFU5r1qfM+St?= =?us-ascii?Q?XJv7qzwUzVfrOoGUWxmQIX13Zu29nl7rEoAz9STnWmIUHG0YiFEuWsuZ7WMY?= =?us-ascii?Q?XZ4hFLP2o1Hcsw6eGpv8y81UMOgdhxVYmzfxTv03Mqas5DWdbzdLc7JmDzGT?= =?us-ascii?Q?+FcR1Bz6vYVIWkp3S1Rhex6qHUgbL3JV8SrFV6rDoElFsGt57hpwY1cYntvT?= =?us-ascii?Q?Yx2LUMFzhEmYm18Fz7ab3qEqPfvHVvewOSOepf7jGOtPXrk9FrRnwpklWxd+?= =?us-ascii?Q?L8WrtQV2YorY4dT8ymkJLA7zqWnO0koes5GFGY8ZZHOtEMNfcd9h1TuAA5u2?= =?us-ascii?Q?+dRyEjIXfEo8Cj6+CbzWdExAqM0s7Cb0x4OxstmDIK4qquEOQyCN5O3XHW/a?= =?us-ascii?Q?T6aOAnVPjQeIc1RIyQd7yre26smNVOx1KS40NYMxxSJWzQ9vThxmP4p/EVr8?= =?us-ascii?Q?6h/uCikAlnsCQ9FTDLoo+zvQX1HQqUzmvh+LShdDnZGKpf823ecmAHm0QQf9?= =?us-ascii?Q?t+EsyAi/wEcDFvnDKrxNHTmT2oQ4Cr2Yg9dZDb5oYQaLm/pRZNH21xi5nYwI?= =?us-ascii?Q?S+GwQUqD8ZCL6K2EybV17XvcdqMMrQQHi8n3?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 05:02:41.6061 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ca8a423-e186-4a52-c83a-08ddac930602 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7239 Content-Type: text/plain; charset="utf-8" The hugepage test cases of iommufd_dirty_tracking have the 64MB and 128MB coverages. Both of them are smaller than the default hugepage size 512MB, when CONFIG_PAGE_SIZE_64KB=3Dy. However, these test cases have a variant of using huge pages, which would mmap(MAP_HUGETLB) using these smaller sizes than the system hugepag size. This results in the kernel aligning up the smaller size to 512MB. If a memory was located between the upper 64/128MB size boundary and the hugepage 512MB boundary, it would get wiped out: https://lore.kernel.org/all/aEoUhPYIAizTLADq@nvidia.com/ Given that this aligning up behavior is well documented, we have no choice but to allocate a hugepage aligned size to avoid this unintended wipe out. Instead of relying on the kernel's internal force alignment, pass the same size to posix_memalign() and map(). On the other hand, the munmap() handler in the kernel doesn't align up, so we have to manually fix the munmap length to prevent a size mismatch. Also, fix the FIXTURE_TEARDOWN(), as it misuses an munmap() for the bitmap allocated via posix_memalign() and forgets to free the self->buffer. Fixes: a9af47e382a4 ("iommufd/selftest: Test IOMMU_HWPT_GET_DIRTY_BITMAP") Cc: stable@vger.kernel.org Signed-off-by: Nicolin Chen --- tools/testing/selftests/iommu/iommufd.c | 28 ++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selfte= sts/iommu/iommufd.c index 1a8e85afe9aa..602f8540242b 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -7,6 +7,7 @@ #include =20 #define __EXPORTED_HEADERS__ +#include #include =20 #include "iommufd_utils.h" @@ -2022,7 +2023,19 @@ FIXTURE_SETUP(iommufd_dirty_tracking) self->fd =3D open("/dev/iommu", O_RDWR); ASSERT_NE(-1, self->fd); =20 - rc =3D posix_memalign(&self->buffer, HUGEPAGE_SIZE, variant->buffer_size); + if (variant->hugepages) { + /* + * Allocation must be aligned to the HUGEPAGE_SIZE, because the + * following mmap() will automatically align the length to be a + * multiple of the underlying huge page size. Failing to do the + * same at this allocation will result in a memory overwrite by + * the mmap(). + */ + size =3D __ALIGN_KERNEL(variant->buffer_size, HUGEPAGE_SIZE); + } else { + size =3D variant->buffer_size; + } + rc =3D posix_memalign(&self->buffer, HUGEPAGE_SIZE, size); if (rc || !self->buffer) { SKIP(return, "Skipping buffer_size=3D%lu due to errno=3D%d", variant->buffer_size, rc); @@ -2037,8 +2050,8 @@ FIXTURE_SETUP(iommufd_dirty_tracking) mmap_flags |=3D MAP_HUGETLB | MAP_POPULATE; } assert((uintptr_t)self->buffer % HUGEPAGE_SIZE =3D=3D 0); - vrc =3D mmap(self->buffer, variant->buffer_size, PROT_READ | PROT_WRITE, - mmap_flags, -1, 0); + vrc =3D mmap(self->buffer, size, PROT_READ | PROT_WRITE, mmap_flags, -1, + 0); assert(vrc =3D=3D self->buffer); =20 self->page_size =3D MOCK_PAGE_SIZE; @@ -2066,8 +2079,13 @@ FIXTURE_SETUP(iommufd_dirty_tracking) =20 FIXTURE_TEARDOWN(iommufd_dirty_tracking) { - munmap(self->buffer, variant->buffer_size); - munmap(self->bitmap, DIV_ROUND_UP(self->bitmap_size, BITS_PER_BYTE)); + unsigned long size =3D variant->buffer_size; + + if (variant->hugepages) + size =3D __ALIGN_KERNEL(variant->buffer_size, HUGEPAGE_SIZE); + munmap(self->buffer, size); + free(self->buffer); + free(self->bitmap); teardown_iommufd(self->fd, _metadata); } =20 --=20 2.43.0 From nobody Fri Oct 10 04:00:31 2025 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2088.outbound.protection.outlook.com [40.107.236.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31A0C19D087; Mon, 16 Jun 2025 05:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750050168; cv=fail; b=FgcFt8lNBDzSj2om5fkrxhkY1oLW+PPg/grrBfuT3dQZ6xdpUa6yagl2Sime7jvlHgIP77C5nLqw3CL6TSemaqHGrgmKFZZu8hBRGaxuNUrYIG2bxYy6JFMaoADMVRI+eMe4Y/ueVuiY4bnckHUxzQ29h8+57njm17OHcnwFd8g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750050168; c=relaxed/simple; bh=TnKvoA41i8APzVrwU4tKAosi4KeL6KxONJh7NhIzmkU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kmHr4VTa7ZNejbG8iyeDo4XfeOZXI/ijecRReU6jiHjlzXIc2Mvj13rSYeTipfq9cuFQmcSV9MjG4hf095XS1vr+bFhh+u2lUh5T3RpZftW3HAYiiLzVotAVwgrEvLN11jAbj7/M87JZw9I8rxCVhes9lpUCN77kPvILCC30zLc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VOUuC8zV; arc=fail smtp.client-ip=40.107.236.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VOUuC8zV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a4YeRiQqXv3KKlU5mZceaKwkKrG/iVDmyGkSTqsoR5OI4dSbhWrbiUMG2ufaP72xKKtcUd5v2Iu/sJc7sZIbzny9W5wwhdm2ygm3I686TPfMDngpCYUs9Gf18JZqxkH1B633OfXP7+nxUYQvBtVZOQbgxCELdTdcdYgfKBavKroZ50Z6a1ujUiZcpAiT7F1+Ur+yduACGhFDsDarGWgiu3D7ZiA3fgacRrfUoH8EgDPHfPCnSK3rGmLFXrh7B0RvcnsgfMbGKgdxgZTQwGsRSz7KRWkjVLslYmn01S3Ov5/n11hGA+qlZnrKJqTdgKiEnPQLLr/Fw5wjAUua8/iQmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hTDXucY8rTkuJJL07uP5aHqak3pGAPuBOF2w/GsyN90=; b=mIn1uQAxwpuWV2sGY5CEm+oxUpHz2DPgBZDRIyaem7U1HkbR8FtP42xZIDADx6rICdQVaHl0ZXtqECKEhY1wBPmpZ7naAF2lVbp4hktz1d9HdiWaA7ylqlyuCk9y+/BOfVlWrRZvNkKfNE28D+VCQr6YlItSeoS/IW/lNc4stP75ukmXgNjnwAsFkAr70F9Uzt3ajbQal2kj/3fD0AskpioTsmQzBY3yhW6EkWSIlspakDxuVRRM463hfzUWfEZXTos0Xb8MPTtrcicNd8F5JrMH5D91/5519icT04KqbKVYo454+dc4q8NO3xtjiUyN2RzOx/PMe71VwnpjyCFOpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hTDXucY8rTkuJJL07uP5aHqak3pGAPuBOF2w/GsyN90=; b=VOUuC8zVApJr8ga+i5iL0Z5cZ9TLhCKjWjFO3t0wW/iRRV4eWnnYbekHjQC0EaXV5OZt9ATCThQfWaq44KthwQEEZSoKNuiPjPp5NwfUKoZ8jkUMd8svYFMDeNL0mzhTZXfzzzYlukM4tt0Bc6XvuPPPw5rb1R4TIF1DlnFTpgT66gZYM7p0wdT4hhJzSUlLXJQB0tsYnE4rx1bkrPus3ceM5IP9QOkgX61St+9RS5sULgcCupxy4csE2c9wAe9YLbIMFmd86HriJEJUKvPRt9x8f248akr101Mu9n5x1t6iSfzCSNnLrdi5sbfFjvjfvEoCGs1YCMJ326hdA5Sx8Q== Received: from YQZPR01CA0118.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:83::6) by SA1PR12MB8859.namprd12.prod.outlook.com (2603:10b6:806:37c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.28; Mon, 16 Jun 2025 05:02:43 +0000 Received: from DS3PEPF0000C37D.namprd04.prod.outlook.com (2603:10b6:c01:83:cafe::aa) by YQZPR01CA0118.outlook.office365.com (2603:10b6:c01:83::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.23 via Frontend Transport; Mon, 16 Jun 2025 05:02:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DS3PEPF0000C37D.mail.protection.outlook.com (10.167.23.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.15 via Frontend Transport; Mon, 16 Jun 2025 05:02:42 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Jun 2025 22:02:24 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 15 Jun 2025 22:02:24 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 15 Jun 2025 22:02:24 -0700 From: Nicolin Chen To: , CC: , , , , , , Subject: [PATCH rc 2/4] iommufd/selftest: Add missing close(mfd) in memfd_mmap() Date: Sun, 15 Jun 2025 22:02:04 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF0000C37D:EE_|SA1PR12MB8859:EE_ X-MS-Office365-Filtering-Correlation-Id: 5fb96d59-7133-4539-b361-08ddac9306bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?l4mRsm/dAF5Gvr+CtWIvJY+/JQqwJs5hrkwsQJWGx12w3U1iJDY1d4BliQRm?= =?us-ascii?Q?SC5Ph5fexzptdhIgM1QYjviAKnCQlxquMJsJwhh8U3wdulr5lgV2oSjuPIb8?= =?us-ascii?Q?6PV5kmpOksPqkSchxq960NX95NMmVID2bp05Zo3k5GQlQw1ZQjThq90vi9nd?= =?us-ascii?Q?sart8zVNb9lO+OGyvEzsqmoyI0yi8Ph7vKssb0TGNwtnhJJ154ZkXhXNlbZ8?= =?us-ascii?Q?99peZcXP8rCZFlPLgRKRGF3bwYdImFn1zQO7t1FdOzth91kiWoeZQgpBdBU3?= =?us-ascii?Q?5Vf695jQMqW37Ceu70AY75LOv22vEHk5Z5m8rNJFZIr0RxSH37Wv9gr3otPH?= =?us-ascii?Q?zPk4uaJIPxWpZzEwDvDhBfTuuHObXbzAo6n+7ZxEr1m+xOXREyzSYLJ6P2bC?= =?us-ascii?Q?EytWwO9pJ10NoudZ6tvuFb4J8pp/0uir5k8IiW6Nydg9OJzxdU4EreXw6gVA?= =?us-ascii?Q?pkTUhaYP8cBshD4d5r4nh3Q2+vGhVNVIE+1tqu7QurPYkDYtfTitp4O9yfIj?= =?us-ascii?Q?fuk68EqcUVskQcKPb9Dor5TeVvBD5T/GpPQ3wBTEH59WBjQGArCvXYtykAa+?= =?us-ascii?Q?vlWs6QdvDg61pXSOYTu14jqxsX4K5caqmcZuhYVK2EmJ8NG+nGUcOFuyvgp2?= =?us-ascii?Q?rKudCylZMZsd7PY0mFe75oPLTnxCW76Nn6xBAqCQFrby0Ni90RqCQ4hA0uHB?= =?us-ascii?Q?ALBeiH2THtMpagYixMTH+v2dkR8QsLoapMC/3T7EWRiEDhJccBsUja+gXx4n?= =?us-ascii?Q?SQOvaF7/ZnTospFZ52EaV8LaLinNTE30r2PurX9d3Vq/Awgk4fHInYuXTAxh?= =?us-ascii?Q?4xwuiIytPvYzOwo54rIfxpfts2y3zTcpjcBSugmhLjRfpg8OosIMN/b+KKcX?= =?us-ascii?Q?xR6d/AOeUI8dSMotKr7VZrG7oWU3q4P4UVd0s2gSoYTmKC4c12qygoMT4Wxz?= =?us-ascii?Q?Qm+fY0YKGpjvbehxg0ff/3j6mjl7qrEUYvtSxz/qFGktURAnLiDvm7BTdyjF?= =?us-ascii?Q?9oa2U2BC4Y4XUCuFlD9A5gZtyn2/HMKpecV3rUfS29277fle9qnG4zgqS1cv?= =?us-ascii?Q?VlEi1lLxmVtkPQ/rdTnwOYz/kbC3RWHhikP3W2O6Hg7RCa2F+MOa5K8zUj16?= =?us-ascii?Q?bFzkohru742mQpdeuy6D4Kz1bkVLP2lEu+MgkZ0O4BUj2ivd4uvKX2/3PuAP?= =?us-ascii?Q?IhLWEKFUfeDiWTxjpTHiwNRsbpFbg1J0QwkBB22iynLr0fygPEKn6CDeBUf4?= =?us-ascii?Q?5S1IAEjJ6lzArzsdMy3bwbJUxeUPVxbs7Xphuk1BG2ZC4hrQ1qEg38GVyrzq?= =?us-ascii?Q?P7OLiRkgDl0khpNqMs143i6nAnycrigPUqUj9GlSAZ+WCgwZ90HQt06Yl21o?= =?us-ascii?Q?WfDVak1YP0Np5edAAt+eLvISC+Wher1vF220BFz4g9H+RmcGKISyi1o1/i5J?= =?us-ascii?Q?m5i5mvJS8z74RKnfmBOW+GGzzkRv/H5BrzU7BRRDf8GQ50L1Aym5niJKM2Qv?= =?us-ascii?Q?I8j3AtmK/Kn0MnizC7AFlwNZHGkJM3cmRwvO?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 05:02:42.8467 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5fb96d59-7133-4539-b361-08ddac9306bf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF0000C37D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8859 Content-Type: text/plain; charset="utf-8" Do not forget to close mfd in the error paths, since none of the callers would close it when ASSERT_NE(MAP_FAILED, buf) fails. Fixes: 0bcceb1f51c7 ("iommufd: Selftest coverage for IOMMU_IOAS_MAP_FILE") Cc: stable@vger.kernel.org Signed-off-by: Nicolin Chen Reviewed-by: Jason Gunthorpe --- tools/testing/selftests/iommu/iommufd_utils.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/iommu/iommufd_utils.h b/tools/testing/= selftests/iommu/iommufd_utils.h index 72f6636e5d90..6e967b58acfd 100644 --- a/tools/testing/selftests/iommu/iommufd_utils.h +++ b/tools/testing/selftests/iommu/iommufd_utils.h @@ -60,13 +60,18 @@ static inline void *memfd_mmap(size_t length, int prot,= int flags, int *mfd_p) { int mfd_flags =3D (flags & MAP_HUGETLB) ? MFD_HUGETLB : 0; int mfd =3D memfd_create("buffer", mfd_flags); + void *buf =3D MAP_FAILED; =20 if (mfd <=3D 0) return MAP_FAILED; if (ftruncate(mfd, length)) - return MAP_FAILED; + goto out; *mfd_p =3D mfd; - return mmap(0, length, prot, flags, mfd, 0); + buf =3D mmap(0, length, prot, flags, mfd, 0); +out: + if (buf =3D=3D MAP_FAILED) + close(mfd); + return buf; } =20 /* --=20 2.43.0 From nobody Fri Oct 10 04:00:31 2025 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2066.outbound.protection.outlook.com [40.107.244.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E0C311713; Mon, 16 Jun 2025 05:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750050160; cv=fail; b=vBs/GzCjYVvKZFvD3ZP/PPPe9WTCC7Ft19DAMnD6DS5/vA4tzUSy8p2y/kHqJKAG5fYF6snh1VCzl4Qt5SdZamPI+Oz3mR+kBotj72GUakLf/OrAp3l//pUELUHOQDLYuXfb1CV6+yF28+ukqNROOkXdDsbOW0U40VnKJcdh7gE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750050160; c=relaxed/simple; bh=DKvZlZfZugcTpqsJzLpT3IVzc7IyaXekg+nFJIzj0W4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LJb7ItKZO19WB1pjQ67LVPI1d8POb+MhmvTUcToypROwQZnsOk7BEWfiTkvDzDGz9sjbnsb44OpYqizoOz9GRp/1s83I/P+K64NE6Jp82+nb8J6oYkCTJqCPG5uiE4OiGauPv10wzcklR0OFjFPqsZdBV85zS+vioRI5m4D11H4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=DwjoTjov; arc=fail smtp.client-ip=40.107.244.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="DwjoTjov" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cHo1q3HeFZw8ppcDum/CeVDpT8iMMKMjEVZH/y5e8KOsuukxEmMiCVK5Xt2OsLR9HwU3zW5xuOvkrZu7gXMxKx7AAqKDP5vjdX7E+8cFt+ciRVFnGtlOQkDOO/tVTP9Fi9GjPHW/KTXUE5Xw8crh/tho9OCt26xgmLGUVzB8b5jGRg6coFIY6h3TLbpMShFpCiJ5A1WeNP0RUezgKrMGrecsi9qCrH9Qj8Vi9uXdRtNzU5Kjfwyoeep39cCtZCB1Qj+29PTj3Ec+cN99Wk8T0c1S0iXhbwaZNZE05ViOS6u/Q9QSECwca6aw3XrNwoUXWmWi5GdXectD0wHlpYbRzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O5OiqD5BqXOiCSiCIE91aOsNrztGQxAxKjA2YRJ0qrg=; b=HvXRovb+mGJDkTOOwEnQO4BXYGWOrsSngNeBd4iPf5c2Gh8PQkgizRpDXYuI57s8qwRwdCiG16N7pVjUYUfPVdqSMsvo2wjMZhUGffMzhrHmKbViR6psvuSKTiuh4Y9iNfzKmjrnmwPTyq8qGhsDsmZ3Qd/EDEkgijvyTiUKwHQvsE11SbdrXLdYOh9ix57vw8xu8F51JoPyxiauPX265D3Decx/ZdwPk617jAZqldvNKOOfCLA0dKf3zn7HPQ8ChaoWRrHyNn3Q52C/TnxbVeoBbeCd8GfqrUT+IUmo8u0Gq6C3tZu8SG713KRVPXByat9XDug6Uv8NfA5HrxOE+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O5OiqD5BqXOiCSiCIE91aOsNrztGQxAxKjA2YRJ0qrg=; b=DwjoTjovaxRJKYFnOiGZwe6Z12gbVlIxhPVb5psS8YJLljaUNKN/Q5Z6xu7jrnEvJcsy/wMCOr7tM/vb6Nimc6kPvq10WWufjUv3qgsmmwFVSFm/ifWM00xQI/Jt4/41W9Ib3S0LMhHJI9jckWVxQY7gkTr8ne5GVi+3UmUlwzODFMJCSotmccOVJegNk18j/7VPwmK6kCT6EC8uSHj2LgcA3LCOG7a/wu2GCl+xwdiZkXTZvIWw5073BJ4Cc9kKK3BQqozU0O4RD9WOF19u0pnsknUATp8M7j+vb1+wYC4JMnjCgrqYeBLkmHxI+/eAw9dtTbFF2bENYGbJxCYQgA== Received: from SJ0PR03CA0369.namprd03.prod.outlook.com (2603:10b6:a03:3a1::14) by MW3PR12MB4491.namprd12.prod.outlook.com (2603:10b6:303:5c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 16 Jun 2025 05:02:36 +0000 Received: from MWH0EPF000989E7.namprd02.prod.outlook.com (2603:10b6:a03:3a1:cafe::f3) by SJ0PR03CA0369.outlook.office365.com (2603:10b6:a03:3a1::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.25 via Frontend Transport; Mon, 16 Jun 2025 05:02:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by MWH0EPF000989E7.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.15 via Frontend Transport; Mon, 16 Jun 2025 05:02:34 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Jun 2025 22:02:25 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 15 Jun 2025 22:02:25 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 15 Jun 2025 22:02:24 -0700 From: Nicolin Chen To: , CC: , , , , , , Subject: [PATCH rc 3/4] iommufd/selftest: Add asserts testing global mfd Date: Sun, 15 Jun 2025 22:02:05 -0700 Message-ID: <03ad77076f50a1931b08cdaa37c3a0e11038a934.1750049883.git.nicolinc@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E7:EE_|MW3PR12MB4491:EE_ X-MS-Office365-Filtering-Correlation-Id: f06b6165-9156-4ebc-a978-08ddac9301ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?NjjBArR3LLn9OJ1gfRFNm4pMmHI/Xn2GWokjRoBjHjvRplYbwTDH1p1nzxHq?= =?us-ascii?Q?r+cCH4ZkQJ19L49YFG1PsyQcb7pJCu5sFEXxF1d2ZN/tY908dKxucxksKl+4?= =?us-ascii?Q?n9k1PnRL3ZVbvW9WHp0jRmUQvacxqsjtyFs8d3/UP2vmCWGl9FLdTF7O4yMI?= =?us-ascii?Q?dwzw9pKYocefCV/Q6LVh2knbN8IU6DLjNfPMyJLVb+VoyumviJAoRusSIume?= =?us-ascii?Q?IpgLb/5NUkpr7J6hZsaRhXn250KcDcgrBvErl/YmjZifDr7RhZ97jb738wr0?= =?us-ascii?Q?evws/gIwEoS3Skhtu+c5/VT1/ILt/iX2BGZ/AY1bIpgz8oMh0XCJdgSOC9nS?= =?us-ascii?Q?x4tnI5T2sYs9n63K6K3IhCGXuObdO/QbA6tUhsbc6cLYhRB9tR3COrFRE6//?= =?us-ascii?Q?6BWbz9phaIEArrN2bflhZ9R2NkO3rHBWYcVFAqSzL4YD08M54c9lTq3Rl3LJ?= =?us-ascii?Q?e6fansMe7mS0MVfcpwXjL/9f9tpSJ+4UKPKxwICNZMYDNsMsoKKs4USRjO2j?= =?us-ascii?Q?dcPqpiyu1ZO1OcTe9a7ZzXzfHX8wbcoslxzKNTpgz7Pd1ROlsG0Kbx2hV2Lj?= =?us-ascii?Q?lUs0QgICIxJqd1hJzOWscW/PHZUcA+y0MWj1JaUY5Lzvn5j07ROc/6MzQxCB?= =?us-ascii?Q?zT3nT3180ygp+EQ/MGENi6ycOE1ymmFxtclwvih0JgD0jxjWPhMSoDXK00Iv?= =?us-ascii?Q?RRe/9VDXIr9Rw742+52dpl6Oz69UpbUhh/Nq4UpXG6Z2DjfQoxM7p0erWTv8?= =?us-ascii?Q?Hp5GPIbNNtdo9jW1JJGUW+XTB+xu2RIqLwkkVpnd/IIAzY1Vg4lqsp+L+PKV?= =?us-ascii?Q?0oI3x2Ptj4cHKayHj10DrUmTJcWfOjZFGqi+WWtbHXQBRWnHUvRjH73HWMZ4?= =?us-ascii?Q?U5IiZReqmfB4BjMcdEaU5FsS2NDwF0P8BmSM6lMdg5wM9O6VLVrhVrUK3pgN?= =?us-ascii?Q?EPGJWIZqZq/u/8AfgrIyNT3o5KBvuFiQpmXIJdjAr07lfSvIRciKTpouyNJ/?= =?us-ascii?Q?HBd+2wBVld+l+YXCLKV42rLDYjxTstQkN8M1b66SqxgG9bC/xLaitx4XOUoP?= =?us-ascii?Q?AsSkUwvvwnaZMxbczHmZkWxhP/83TssbRVNRm2lKcRnI7er1tH5Jai5Xp72h?= =?us-ascii?Q?Msaws/EhaO+jRMprOrw4EajOJevvpJ6VYhXPTP1Y6GqCkH3WQE1EYI7Yj2Qo?= =?us-ascii?Q?yOZIXLwjz2y2y/XnvqcYF/iihAwEeUN8je8Ruse2F8lM6+Bp5/zbtvn2R+4P?= =?us-ascii?Q?dEOtOEx2W3Uj+ErdnB7cc2tfa+kWchAX8Y+r9YukFUbqFGzFUpxfZMfXh/NR?= =?us-ascii?Q?Xsv7WXt3/cFq7NBYCPHYizmq7uIEvAQnkEyv92GdjhjfL/F87loQxfzle/Mx?= =?us-ascii?Q?/Ml0G3y0wCLzSEO80jywvR3SVkJqJxVPTr5L5hSfb0UuFxPJBLCngUCNyukK?= =?us-ascii?Q?6c3tkLCpLk+JPdz0HuIuMkZFAXUjPLfaQuuXhax85vTMCBR08zAsPxBoFkbI?= =?us-ascii?Q?yAmc+j/kCCNw4k4WFmb0McgX7Bi65ocWLrvn?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 05:02:34.8180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f06b6165-9156-4ebc-a978-08ddac9301ef X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E7.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4491 Content-Type: text/plain; charset="utf-8" The mfd and mfd_buffer will be used in the tests directly without an extra check. Test them in setup_sizes() to ensure they are safe to use. Fixes: 0bcceb1f51c7 ("iommufd: Selftest coverage for IOMMU_IOAS_MAP_FILE") Cc: stable@vger.kernel.org Signed-off-by: Nicolin Chen Reviewed-by: Jason Gunthorpe --- tools/testing/selftests/iommu/iommufd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selfte= sts/iommu/iommufd.c index 602f8540242b..393d95f88ad4 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -55,6 +55,8 @@ static __attribute__((constructor)) void setup_sizes(void) =20 mfd_buffer =3D memfd_mmap(BUFFER_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, &mfd); + assert(mfd_buffer !=3D MAP_FAILED); + assert(mfd > 0); } =20 FIXTURE(iommufd) --=20 2.43.0 From nobody Fri Oct 10 04:00:31 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2077.outbound.protection.outlook.com [40.107.220.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 578261DD0F6; Mon, 16 Jun 2025 05:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750050173; cv=fail; b=H9rJeeKaf/pTzd7wq/F8qIZrjSQ6SwX0KnDt9RPjC6+ARY3VY1G7raJ8TwzNn1gCMd3/4ZE+1uiCaOwfM/5BkJsKDG6+G4t43r2I2arQP5WYTriztE3hMqs4AZ+nemMhgzAymejVo5S7Zt0PabAWLnHB98NfS0rKUt0Ub69DDCA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750050173; c=relaxed/simple; bh=qiQ5GkUGjZ+q8vJ7NUB4slVIlr4qCdmz8gr1nrPjyRE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=blmkfqYNkoP/C7/tnGkbKcMZqGCtH+qmMSsbJQ9YU3ploAOVMLSxnwEZUutp9D4ArQ5a6MJifLhVl/iY6zgJe7hKBWXD5wgwIniMEtPbqh9zDXkv1NWU2ZSowPTrwOiYBnWjl+TlYolNmdNQHYLDVFjI1WLCGgbwhdCvPoS6mJk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fLrz6rNW; arc=fail smtp.client-ip=40.107.220.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fLrz6rNW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gS6A9iabMJxCED/vqVAVQMOh8mDqN6iHmiXBBugmidEY0l1ufjHnZsmAEy+Oefo+qSok3bELWd0UhK6eQyIcvBXsY5m/np2XCCbz8eNLuabt5KYFZ6KzEklXlraC/iHtWOOl01OJ4U5bgAvdatm12U10Q4/06kyOPhC3X7rMjKOHQP1CXRYxRi3/+laZYSFZd5Tundi154ehwGqKky8ii/qcWLxP+XIQk9oLl6WVB0QsQFZjE4RoB8VfnLRs2W7K9T/JbJjFgnELSM0vzfaL7+qy41gQDEXhcFi5/vgonlbS404ReELB2PFMAK5ssyUIrV8puVN2gQJnqu8XYjWGVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TNyEDg/zLWkPXnZqMU+5O1XeM+QPexcOgKaAqNHBSaY=; b=WlY/bsz8LW+/t99hMFNcHTWIQdnA4yMQladGmkh59BVJoroNHTRIJ4woihJLAHw826caxYhw5HarlLinUACe33fY+IZybSo4DmzyCFaaEywh+kmXjDWkLFMGDAnY1RXNrzQLEUn+XnLEi1LR8/jBO36SdZS7xDMrtjw1L4arE95VSlR+m2U5PeOJ3UKD2dm71MrFFx/HgWno9RbPCk1EZTyAh3PnExfJkiJFn/hTldapF0U2DPliFDkooOZAsvNYcH94d3IRqAYUAEV3OcuBmfXxI2iyZbFly17p2EubYNNFLxm0c4tGPlWnhtx/AmWh0zZx8PSQ/rxGPN+NZLzCvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=temperror (sender ip is 216.228.118.233) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=temperror action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TNyEDg/zLWkPXnZqMU+5O1XeM+QPexcOgKaAqNHBSaY=; b=fLrz6rNWPpRVq3LWXUE/k1RnJXrp1KCUdI08ENMChHsaK+Z3MPLsrYmT0B7jaxfSv0gKknxIg4ajiCPpkzHVgXCtfsxY2ct5XxTH4Okyb8dp44USH2ZHQP6N2NH3C9IT9EmZcXioIrR9M0wj+nqYgXr/WkRNSbj4q4/C4gal5zfWkIHumnnnXjtKSsYFoByeag1bGIQ4oUfww2H/SUCCs3/nC0+qXjoa9Z6geLaJjDD+ilWQpDAjAuhGZVUS550DY9Kp5VEY41xCtyJ7bj1paZOh7ygYoGPJNLy4xrB+sZqHpRCvekwq1xg3zrndeo/U/FtMqUuSMTaJ5Q/Xjs6ffA== Received: from SA1P222CA0177.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c4::25) by MN0PR12MB6101.namprd12.prod.outlook.com (2603:10b6:208:3cb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.27; Mon, 16 Jun 2025 05:02:47 +0000 Received: from SN1PEPF00036F3D.namprd05.prod.outlook.com (2603:10b6:806:3c4:cafe::31) by SA1P222CA0177.outlook.office365.com (2603:10b6:806:3c4::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.29 via Frontend Transport; Mon, 16 Jun 2025 05:02:47 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=temperror action=none header.from=nvidia.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of nvidia.com: DNS Timeout) Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF00036F3D.mail.protection.outlook.com (10.167.248.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.15 via Frontend Transport; Mon, 16 Jun 2025 05:02:45 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Jun 2025 22:02:26 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 15 Jun 2025 22:02:26 -0700 Received: from Asurada-Nvidia.nvidia.com (10.127.8.11) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 15 Jun 2025 22:02:25 -0700 From: Nicolin Chen To: , CC: , , , , , , Subject: [PATCH rc 4/4] iommufd/selftest: Fix build warnings due to uninitialized mfd Date: Sun, 15 Jun 2025 22:02:06 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00036F3D:EE_|MN0PR12MB6101:EE_ X-MS-Office365-Filtering-Correlation-Id: 43ace109-f0d6-4f47-9b0c-08ddac930890 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700013|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YVdZY09XY05HaUNjS1NKWTlaVkJVQU1GMDZ4UWRQMUhFY1M3alpJb2gxRWFW?= =?utf-8?B?c2xrM0tBK1M0bjV6Qm5TVyt1eGUxckVZN20vMTRKYm1lSi9VVWxqSkMzcHNx?= =?utf-8?B?dUxsbE9aQXJyUE5La2pCek5PbzRpWFhRYkx6REszaXM3UUtzNnd4MkZ2b2Nz?= =?utf-8?B?Zk8xM25vaXdUQ210UGp4dTl4L3hjSXlXZXNqd3grNDZ6anBkT3BUY2xpcHBI?= =?utf-8?B?OXVGajJXalRPZVdBRGxhdjlHYWNrMEJwOVZ1V2FOV2c3VmRHS0pRdkIxV3A2?= =?utf-8?B?VVliVzVlZkVJeGI2R3pvVVRMaGdyc1c2UHR1cFNrVlFXR2pXMlhtL3dhTi9F?= =?utf-8?B?RW9kL1dyVUxsK214MzJSbE5XR1dJSjFiUW5od2dldGprTjJhdFhxL2JiYTFs?= =?utf-8?B?TzlwMnhiK2tSRUczSXVXSFZoWFBuNjNjOFZpNFM0N3FLazZMbXZwTThqaXdS?= =?utf-8?B?VnNqVC9OOVNldE5uWlpxdGZkZGNvaXFtUlZFWXZRblU4RWpYZENDeXZsV1RT?= =?utf-8?B?TE9aeWR0THRGQndWdjlscjVWU1BjbXFtTEgyMmEwOXlFVmJGdHBhYnNKd3hl?= =?utf-8?B?bEFtNW5lb1FGSFVnckxZdlBhK0l2V0pWMWZYaFB3WitTemFmMG4vbkFaMGVq?= =?utf-8?B?Mk5xVVJpOGRGTUMxeGY4eC9SWVJUd2xMVHlMcWxFMXE0Rzhtd093MXNkU3o0?= =?utf-8?B?ZEtiemNQbDJHYjN5T2dvcHJRS0kvUEFQcHN1UE9hNmlxTkd3Z2dRenNLZWNM?= =?utf-8?B?TG5ZRVRWR3pRMFd1Z056Lyt3VVRrV0IzbFM1WG05VmlHZGhsM3A3NE5KejJI?= =?utf-8?B?MDFzU2s4QnU3QXQ5SkU2N1k1dkVTODAvdXpqYUpXT3FVVTltVmhjUDkzdjE3?= =?utf-8?B?K1c2Slc5MEN6WUVJZVRQQytyMHdlUFcraGRZdmppUmJLaEFxN3dXcHA1U2VS?= =?utf-8?B?Qk5tNEIwdFhFVWdWTFJpTUgrcVNXS25pYlJGMmpiTXRMNEhXekFqUjhWazdY?= =?utf-8?B?WEdqekw4YTk4ajJidzdBeHhmOTl0akZEYi9sSDJPa2JweU9KcXNQcmwvd3cz?= =?utf-8?B?RStDeUU3Y2wwR0ZyNTlVZWJFRjVRNHNzQnRjRmh0OVBqMVNDK3pscTAwVHMr?= =?utf-8?B?UkVEYW1xTnU0K0c5RWIwVHRJMFdIM2NWZVpHSkJXNE9kZThINTYxclBJSlVL?= =?utf-8?B?djY3U3FNT0pxK1dEVk9DcHY0ZWgreXprS0tJQmdRc1FzaUpNNnJEZjg3LzZB?= =?utf-8?B?SS9ZUzM5ZFdobklQSmRoekxhVWw0TzBFR2dGbDVKM0N3cW1YODJyL0YzU1pQ?= =?utf-8?B?c1NSZ2l4cGdzKysyTUZjdlN5VWxFZTNlZ0VqZG9jTnFpKzZhVlE4Q1lwaDhm?= =?utf-8?B?YTNiSmtJdERpNTJqMlRpQTlxR0hKMjAvdTROSkpnNGlsVy9HVnRYb3h0VE5C?= =?utf-8?B?RVhCaGpEVEhYa2hHNUNTSS9NMiszYlQ3Y2EveHBOMDU0TnlpQXZId1pDQjdr?= =?utf-8?B?SmxwRTBzMmN1QUpOVnlNTnJIY2ZDK3dIZkM3ZGtFSXVFTlUvaHo1NHUrb0k0?= =?utf-8?B?Rmt5MTZUOEV3Y0hrNStZZ0ZmK3ZBZUs0Wk1DNTFhRzBvMzg0bTVENVE3L1BS?= =?utf-8?B?TGpCVlMySFpSYVM5dGNpRHdqd3hXa09nQ0IrK0ZaN09KMTRTMGhMbk9KSFJX?= =?utf-8?B?a0RVWVMrUU1wc2hLUkx1VWtIeWQwK3Z1eVYra2MyZnh6U3ZkN3MyUk9lTmtv?= =?utf-8?B?THRpVmU0S1BQS0hMTlNybFFqdlVmQXo4U1RxUzFLSEUwWUVPKzdQYnkvM21x?= =?utf-8?B?WXZucmNiNXJucFpsbVU5RkpsQjhPdkF0UTczdS8wMzZUMm9UWnFHSjNWOGk5?= =?utf-8?B?VFZtWjNub3J4QzNZVksrTXZjUytXVDhkd09FYzZqOU9yWWpnQi9RZDdaNDIz?= =?utf-8?B?aS95VDFMZlR3RC9aVTlrMDRUdWhxUlNjQVFPMGwwcUsxcmRGRmFMbEtFcmRE?= =?utf-8?B?ZWJXYXozTXgzbDN0azBUbTg3US91TktKN3dSd1NsQ1pPQTc1dE9lMDZYRnhQ?= =?utf-8?B?SlRmVVdEU1AveTlUeDdwTW5jUVdJcHZpTTcyZz09?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 05:02:45.8877 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43ace109-f0d6-4f47-9b0c-08ddac930890 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00036F3D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6101 Commit 869c788909b9 ("selftests: harness: Stop using setjmp()/longjmp()") changed the harness structure. For some unknown reason, two build warnings occur to the iommufd selftest: iommufd.c: In function =E2=80=98wrapper_iommufd_mock_domain_all_aligns=E2= =80=99: iommufd.c:1807:17: warning: =E2=80=98mfd=E2=80=99 may be used uninitialized= in this function 1807 | close(mfd); | ^~~~~~~~~~ iommufd.c:1767:13: note: =E2=80=98mfd=E2=80=99 was declared here 1767 | int mfd; | ^~~ iommufd.c: In function =E2=80=98wrapper_iommufd_mock_domain_all_aligns_copy= =E2=80=99: iommufd.c:1870:17: warning: =E2=80=98mfd=E2=80=99 may be used uninitialized= in this function 1870 | close(mfd); | ^~~~~~~~~~ iommufd.c:1819:13: note: =E2=80=98mfd=E2=80=99 was declared here 1819 | int mfd; | ^~~ All the mfd have been used in the variant->file path only, so it's likely a false alarm. FWIW, the commit mentioned above does not cause this, yet it might affect gcc in a certain way that resulted in the warnings. It is also found that ading a dummy setjmp (which doesn't make sense) could mute the warnings: https://lore.kernel.org/all/aEi8DV+ReF3v3Rlf@nvidia.com/ The job of this selftest is to catch kernel bug, while such warnings will unlikely disrupt its role. Mute the warning by force initializing the mfd and add an ASSERT_GT(). Signed-off-by: Nicolin Chen Reviewed-by: Jason Gunthorpe --- tools/testing/selftests/iommu/iommufd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/iommu/iommufd.c b/tools/testing/selfte= sts/iommu/iommufd.c index 393d95f88ad4..ca611ae5925f 100644 --- a/tools/testing/selftests/iommu/iommufd.c +++ b/tools/testing/selftests/iommu/iommufd.c @@ -1749,13 +1749,15 @@ TEST_F(iommufd_mock_domain, all_aligns) unsigned int end; uint8_t *buf; int prot =3D PROT_READ | PROT_WRITE; - int mfd; + int mfd =3D -1; =20 if (variant->file) buf =3D memfd_mmap(buf_size, prot, MAP_SHARED, &mfd); else buf =3D mmap(0, buf_size, prot, self->mmap_flags, -1, 0); ASSERT_NE(MAP_FAILED, buf); + if (variant->file) + ASSERT_GT(mfd, 0); check_refs(buf, buf_size, 0); =20 /* @@ -1801,13 +1803,15 @@ TEST_F(iommufd_mock_domain, all_aligns_copy) unsigned int end; uint8_t *buf; int prot =3D PROT_READ | PROT_WRITE; - int mfd; + int mfd =3D -1; =20 if (variant->file) buf =3D memfd_mmap(buf_size, prot, MAP_SHARED, &mfd); else buf =3D mmap(0, buf_size, prot, self->mmap_flags, -1, 0); ASSERT_NE(MAP_FAILED, buf); + if (variant->file) + ASSERT_GT(mfd, 0); check_refs(buf, buf_size, 0); =20 /* --=20 2.43.0