From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F12EB2E11D2; Fri, 13 Jun 2025 17:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749834217; cv=none; b=SREL9XqFHEvrw++2JAzT90I/j4R+TNYAOJBh7A+r3VU4wmWX5cm8S6rDNV6AylalUogVvQXqTDgdAumWaUTMk6vGCuwT9NfYdx6OsRDMdFhbH0j5WkK7aPG/eXz3eKTXPHzjQSvz98FqTJe+eWn3fKHMu99vOy26S0JsVX+JaCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749834217; c=relaxed/simple; bh=SZe0UXm6/6BI1FYFprzL8Sy2n02I5hJ0+EISYYp74OM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tgnFrmVK/FTkJwUTvmWTWFgw0rePcYurJnih4YOI+NaFqBdAN4hBz6JIJN/IY37tvlhwqngaSwWB1Qs8+pnvjoXoyG4zCaOcp5+vpU1/jRm+TW93p5pYQZSyYp7sEf/wQIQbtE79aanpT3wytZoman8qgRswbM+lLYfbiS1DZt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E7OSgNya; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E7OSgNya" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-234d366e5f2so30741595ad.1; Fri, 13 Jun 2025 10:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749834215; x=1750439015; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EwwMgnzQCli9wNrJxdzIMvB+XIZu9hrKvPTUQSw9wl8=; b=E7OSgNyasNLv+cRqgyZNEqwNknFy1wHsSbTLiMI0pNtV0j2bwOvQMFj/vo5UZl9G6C lIlYscVKk8gKohLSo/pfOGpXAp0X5oSOZyCFUjdo5rcWk3Qq0r3NL+kSV3GCePqtfIqm DwGdyuzRJhvXdNzgnBqqstK3A0BcfBpMHtHxajoXlG8OfN8FEahFW+nssA/P0NOO3WlG BJT7ocz99m81IDPcsoDJUsYNeICWdQyXYKSqhBtIUclGxMrMNnHwosvOFZK9l4EDaEJh so/FYZKlofeJZIOQCOyE7Vp2KU1d1q84/GwzbnVRfMaqW1CXwy4oJffZVsYFwY2Mym+m KFdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749834215; x=1750439015; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EwwMgnzQCli9wNrJxdzIMvB+XIZu9hrKvPTUQSw9wl8=; b=Bd/X1biPFsLkDjsZViPL1UJXVaPH9PJJ8H/aioglO52esSnDnLnOXR1PArQHILF0tk VFDRcJ/Ms+eQFO0dz6OOE7tz+GTJ92SbxRPmGGIbIPqz2fxtKdPUwn6MUA12zDDTwBLL AgSyBfS/Vj5hjwSDl4ldmQ/CI3eOVjAdRwnD9W6j/W+QS8otq32DEshEiqn0AxrR5spa 5QfVjZQAK5AUk9jpdnSs8eS7MQhaPvnfPHotwcHjZRZKVChRvvjk7Fs6EtXV8C/v2lYp zwDGp9aNbAUAtvW5tJEgvNU9m+mvvxGEn96mIl6Ls1VTTKHxTupl2V0T5YEv6Kzb99jd 0aLw== X-Forwarded-Encrypted: i=1; AJvYcCU99Dj/g+X7sttzibPjRA6wShllqQkDT3CceIXTBlhvYCYGbe2exnnzC5BIcDswFS8rUd8hVyeg5TxW@vger.kernel.org, AJvYcCW8YEYUAFGop0Z/SycEfbYVlT5t4jFtaLC/0kILbVLgasYgKIIuYcKYYwmBg3BJIKpMjac1ltKC/vWyPX0=@vger.kernel.org X-Gm-Message-State: AOJu0YxSAaGacDT0DhkJaPlYHnqnxM2hfdCKNeKNJaywcH8qXUbGDROw jgugMk4OzZYqeToVkIfChJpylbhInmtVfq4CVa5jmh+1c1/hICZLbfAI X-Gm-Gg: ASbGncvFIrb8N35gbzORKTgInlNFTfD4lOVWMgFjSXNo5vfDuB3GaXT9lCzZRQ9XWiY 2kIBMPacvGkWXl6RVNrHDeNkKMYlG04A/aBARNzXbYsyrtfc3jWVxwY5zzDr79/hDuoxNtxU3Tg kZeJfzm4/FChMk4m3ktvP7nXdPj58BVfVN6rveRGOl1Y91PZosoD9dfjIAyysU00yaDwUrCr3hq rfJZ1nNbi69js5uwKy6kt9oCXJmuNauh9rAUiW/py76w+8wyqcx9S+u4MHLksmTYEVMM6rf64n/ 9ZltxbnpSGgkitzuk+kG2sBOipPeLJb6FTIKynWKZNa/9sntwA== X-Google-Smtp-Source: AGHT+IFpP2K/dPlkvKo1IPxY15KKefhYTlyOqRe5ll2UE6R73H0rBktfilK8anevjd+Htm5u3AbAZg== X-Received: by 2002:a17:902:e74d:b0:22e:3e0e:5945 with SMTP id d9443c01a7336-2366b3df88bmr2862655ad.50.1749834215169; Fri, 13 Jun 2025 10:03:35 -0700 (PDT) Received: from geday ([2804:7f2:800b:8497::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deca2b5sm16903925ad.195.2025.06.13.10.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 10:03:34 -0700 (PDT) Date: Fri, 13 Jun 2025 14:03:28 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v5 1/4] PCI: rockchip: Use standard PCIe defines Message-ID: <638f3e01822d368c7e970141291007f291921136.1749833986.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code uses custom-defined register offsets and bitfields for standard PCIe registers. Change to using standard PCIe defines. Since we are now using standard PCIe defines, drop unused custom-defined ones, which are now referenced from offset at added Capabilities Register. Suggested-By: Bjorn Helgaas Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-ep.c | 4 +- drivers/pci/controller/pcie-rockchip-host.c | 45 +++++++++++---------- drivers/pci/controller/pcie-rockchip.h | 12 +----- 3 files changed, 26 insertions(+), 35 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/contro= ller/pcie-rockchip-ep.c index 55416b8311dd..300cd85fa035 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -518,9 +518,9 @@ static void rockchip_pcie_ep_retrain_link(struct rockch= ip_pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_EP_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_EP_CONFIG_BASE + PCI_EXP_LNK= CTL); status |=3D PCI_EXP_LNKCTL_RL; - rockchip_pcie_write(rockchip, status, PCIE_EP_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_EP_CONFIG_BASE + PCI_EXP_LNKCT= L); } =20 static bool rockchip_pcie_ep_link_up(struct rockchip_pcie *rockchip) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index b9e7a8710cf0..8489d51e01ca 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -40,18 +40,18 @@ static void rockchip_pcie_enable_bw_int(struct rockchip= _pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D (PCI_EXP_LNKCTL_LBMIE | PCI_EXP_LNKCTL_LABIE); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); } =20 static void rockchip_pcie_clr_bw_int(struct rockchip_pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D (PCI_EXP_LNKSTA_LBMS | PCI_EXP_LNKSTA_LABS) << 16; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); } =20 static void rockchip_pcie_update_txcredit_mui(struct rockchip_pcie *rockch= ip) @@ -269,7 +269,7 @@ static void rockchip_pcie_set_power_limit(struct rockch= ip_pcie *rockchip) scale =3D 3; /* 0.001x */ curr =3D curr / 1000; /* convert to mA */ power =3D (curr * 3300) / 1000; /* milliwatt */ - while (power > PCIE_RC_CONFIG_DCR_CSPL_LIMIT) { + while (power > FIELD_MAX(PCI_EXP_DEVCAP_PWR_VAL)) { if (!scale) { dev_warn(rockchip->dev, "invalid power supply\n"); return; @@ -278,10 +278,10 @@ static void rockchip_pcie_set_power_limit(struct rock= chip_pcie *rockchip) power =3D power / 10; } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DCR); - status |=3D (power << PCIE_RC_CONFIG_DCR_CSPL_SHIFT) | - (scale << PCIE_RC_CONFIG_DCR_CPLS_SHIFT); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DCR); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCA= P); + status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_VAL, power); + status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_SCL, scale); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP); } =20 /** @@ -309,14 +309,14 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) rockchip_pcie_set_power_limit(rockchip); =20 /* Set RC's clock architecture as common clock */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D PCI_EXP_LNKSTA_SLC << 16; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); =20 /* Set RC's RCB to 128 */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D PCI_EXP_LNKCTL_RCB; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); =20 /* Enable Gen1 training */ rockchip_pcie_write(rockchip, PCIE_CLIENT_LINK_TRAIN_ENABLE, @@ -341,9 +341,10 @@ static int rockchip_pcie_host_init_port(struct rockchi= p_pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= 2); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); =20 err =3D readl_poll_timeout(rockchip->apb_base + PCIE_CORE_CTRL, status, PCIE_LINK_IS_GEN2(status), 20, @@ -380,15 +381,15 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) =20 /* Clear L0s from RC's link cap */ if (of_property_read_bool(dev->of_node, "aspm-no-l0s")) { - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LINK_CAP); - status &=3D ~PCIE_RC_CONFIG_LINK_CAP_L0S; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LINK_CAP); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= AP); + status &=3D ~PCI_EXP_LNKCAP_ASPM_L0S; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCAP= ); } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DCSR); - status &=3D ~PCIE_RC_CONFIG_DCSR_MPS_MASK; - status |=3D PCIE_RC_CONFIG_DCSR_MPS_256; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DCSR); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCT= L); + status &=3D ~PCI_EXP_DEVCTL_PAYLOAD; + status |=3D PCI_EXP_DEVCTL_PAYLOAD_256B; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCTL); =20 return 0; err_power_off_phy: diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index 5864a20323f2..f5cbf3c9d2d9 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -155,17 +155,7 @@ #define PCIE_EP_CONFIG_DID_VID (PCIE_EP_CONFIG_BASE + 0x00) #define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_RID_CCR (PCIE_RC_CONFIG_BASE + 0x08) -#define PCIE_RC_CONFIG_DCR (PCIE_RC_CONFIG_BASE + 0xc4) -#define PCIE_RC_CONFIG_DCR_CSPL_SHIFT 18 -#define PCIE_RC_CONFIG_DCR_CSPL_LIMIT 0xff -#define PCIE_RC_CONFIG_DCR_CPLS_SHIFT 26 -#define PCIE_RC_CONFIG_DCSR (PCIE_RC_CONFIG_BASE + 0xc8) -#define PCIE_RC_CONFIG_DCSR_MPS_MASK GENMASK(7, 5) -#define PCIE_RC_CONFIG_DCSR_MPS_256 (0x1 << 5) -#define PCIE_RC_CONFIG_LINK_CAP (PCIE_RC_CONFIG_BASE + 0xcc) -#define PCIE_RC_CONFIG_LINK_CAP_L0S BIT(10) -#define PCIE_RC_CONFIG_LCS (PCIE_RC_CONFIG_BASE + 0xd0) -#define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) +#define PCIE_RC_CONFIG_CR (PCIE_RC_CONFIG_BASE + 0xc0) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) #define PCIE_RC_CONFIG_THP_CAP_NEXT_MASK GENMASK(31, 20) --=20 2.49.0 From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC741FE444; Fri, 13 Jun 2025 17:03:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749834233; cv=none; b=juJq6SNZhN1DXjlA+t8s+4j+HkMiJbcAXbxmneWxfWa8a8k9GfIyoza9/cGatjx5Eh9acPZPnb7aEENmVISp+54kQF+QPK9yA5rXrXrYk2SMoFUerxD+bBPfzwJr8Z9BkucY0RnJS0zE1heTUF+Ab6TgEAtt9PzZ1FM6to4TA38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749834233; c=relaxed/simple; bh=VBXSmkbEwyUiveQ0xzMAjdlDhL49GOnb+RhKgEw0Lrw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QdBZsCpgDxtncmzB/sUTrmcHyOu4Vx29qRC3kFiHyCvcrc3GLTAhgMb74COG1OiyAKKqkQ9hFtLwy7ZRoAgmjvTlb7Cj0x8tP/Ha9PwOupveoOVlT3SzJLkPsJbKiT0eNMxnzhVqnJ5+hpep68kWRR2Jp0vXKyqDaM50oIN2y2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DjAHP6ep; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DjAHP6ep" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-234b9dfb842so25057255ad.1; Fri, 13 Jun 2025 10:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749834231; x=1750439031; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hZG2gbmHCn23d73eIBj2Su1Pr4mdTTmU2U/OMW+hTCg=; b=DjAHP6ep9t5Rg9SwUGMzRU4vLfJ8Iax162xJcNPzX7I9MHkjPmTG2GXjQDF4tKamF0 GZoM7aiKg44kxzBUZsKV68edHBSmltfFJ35t/wu6On11WA654SskgRY9qDMzixYCQJvA jEpHkUu201DuoAXZkIbUD2ATRNZaqrKifdSULnzkUY0hCnotzQ0pyalZUCMFESuyUxDx QoxhA2ujYyTigb3/+/hn3IQ9TDr59CrjMOImxzvRdAmHoCsNDsUI0D2Qg8ipk7Jbj/2b TwAJh2hnADetsRoTcQ0JpNYSRWlCANU4X6Khq6Dgb+Z7L2DgvizFEhkST6DDJZai5O4D j8RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749834231; x=1750439031; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hZG2gbmHCn23d73eIBj2Su1Pr4mdTTmU2U/OMW+hTCg=; b=jYajYjJhZia2zSCI3W8qWsRV8QpvjW8EKi4b+BwYQ8m6gvqEqGoDj9g8WdN1S7WXrN +PA1PLqbAI/XjT37oy1gPRJgi93y1DBlqGhTsN063LvBWxuLe6/kSti8HedPbrrOUnTQ JD2QjMo/aIHxJ+xANmqiz5MKbWC0bFN2GMB3P3JJuJflhbyFueiGWEcql4A2+h2tBGXc Ys4FO1q3ZhBRvc7tr4lxd/zyMRlKNQDbk/MGn0rTeGBhjIud88dRxxKuiJLXMl1OJjVE ytTYLZsgOf4cRIXzEe+48HGmZNF+FChppHa2Oa4vKruBZnALUj1aHLp5uHmYpRrfN6Qi 98cQ== X-Forwarded-Encrypted: i=1; AJvYcCVDBlAW1xzbOLh3UtAcHPKibx1E1U+4sBMcWBq9td0UMkoLmWJE+2jPF4Zep9zfb2gu7z/86uz4v1D30LI=@vger.kernel.org, AJvYcCWQxqITbAJKL7deXtIYNajDTXJmVdpBitSkQyByb7SBYGzi33QOZyywZ49Ba8xi7YLU5zR/MdM++FXf@vger.kernel.org X-Gm-Message-State: AOJu0YzDayqTYRf1vf0RgvW0rz97lJEm9r35zOV78J6dv2AMHo5YvzrJ 3A6M35G0VZITTBIV1bVtvZJxTpd7dqa+9ZRoTjoP8nkxoU3JZ8JYLNJPeq4rqwgs X-Gm-Gg: ASbGncsjfp6aSgIZPoHKAgdk3Ga3PraLulFxRDPUt8ofiCxxidClAQxq8LbmPF3EkiG Mf+ksyFDu8OEyFnREQKwWpy1wWLGgczn6+YRRgvNiXjXcWSjeBfsTGFVApauvPRgeFhRkNNu5IR 4NB8wrXHhKu/wdvaRFQKKEUJs2WpuZiwEyXHfCN5I73o/TfD1JiNrRirVQXstgwGXHn9txggosi 419cOUD6pqvRB2q29M9OsIURsbjj5nT2T9e9w8FYYEhZ2fqHYcSW/p1l/r2oYmRNjbAEUvwisYH s36PYc9Ds8lm3BAdCg28cuGZe1zu8WqXb1byM09ELEQBj4yPrw== X-Google-Smtp-Source: AGHT+IFLJ9bCor1c2WHJ7wrTZBUINfNRlAF5VdRV17WHMRfQOATSlzvrkpLZD8EH22C2Gl67bbMhkA== X-Received: by 2002:a17:902:f683:b0:232:59b:58fe with SMTP id d9443c01a7336-2366b3169f9mr3651525ad.1.1749834230599; Fri, 13 Jun 2025 10:03:50 -0700 (PDT) Received: from geday ([2804:7f2:800b:8497::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deb54desm16813665ad.179.2025.06.13.10.03.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 10:03:50 -0700 (PDT) Date: Fri, 13 Jun 2025 14:03:44 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v5 2/4] PCI: rockchip: Set Target Link Speed before retraining Message-ID: <1966f8ddc4a81426b4f1f48c22bea9b4a6e6297c.1749833987.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code may fail Gen2 retraining if Target Link Speed is set to 2.5 GT/s in Link Control and Status Register 2. Set it to 5.0 GT/s accordingly. Signed-off-by: Geraldo Nascimento Tested-by: Robin Murphy --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 8489d51e01ca..467e3fc377f7 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -341,6 +341,10 @@ static int rockchip_pcie_host_init_port(struct rockchi= p_pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL2); + status &=3D ~PCI_EXP_LNKCTL2_TLS; + status |=3D PCI_EXP_LNKCTL2_TLS_5_0GT; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= 2); rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= 2); status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; --=20 2.49.0 From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDE888472; Fri, 13 Jun 2025 17:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749834247; cv=none; b=TqMoj1vkEDWyz8PZVvlTahyjl10jzb2AV+31AuPu2cX6yzXZqe0We+MwbU4+1edOodaoXgIg/GDaET3zvL9rqqhWx88T5nBOWlf1dOQ2xsHB+hsX2m9X8G/wauaoIPtatAW4UiDofsIfmx96O5NA3l6bLIiYwdu+Gvc+T855Vww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749834247; c=relaxed/simple; bh=z1QuJQTs2qeychSUYLbx3MrTtjKfzdWwsIGraIObLLg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=az6oda09aoP7iKzmM3hEYur8HsdnchpQ+wJTCZYJppCe7CvXtmcXLLxTBZkkTyyhcGP9A1+ZfcWpVOnPkr1bdI6xzmbdeLonZvUVrm5VX39oE/2T4FPEHSDl2+JLUtPwz13nQTNtbC8dY13lQpWiHMBhkmsW6qhOhVr707kL46U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BTHzAuY5; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BTHzAuY5" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-234bfe37cccso31857705ad.0; Fri, 13 Jun 2025 10:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749834245; x=1750439045; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tcgFdGvrxzEgL0jd0jS7Kyu6UO50T4AXfHFozAP4vvw=; b=BTHzAuY5wjofoUjx7WOSte6Z76LHN8K/fmsd07vjfA0iYXMEV0YFHN3dWbMtzC28Ax Y6+VYoloXjbLsms6edHHAjJVbceye4gige9l/Kf2xSTp8Er54DkQ0GMDHnHXfVOmYOdh W63C6Ow35X2ThH4TiBfq+n7aBnYu2s7gN4eEZMLKeU0wUQA7ddKITIFUQWGKmS/3KD7k 0SI9nfE/9Rlzh+A3UjvoqYcOa8wEdZ8dtlxOh8I47nLBQXPXESLVippKGzpWGyR7/VzN oVmSAQMovA+wi8Jevb9qWBbE36KW2W6oOCvOVQ0QkMNUv/t53gwlkB2xKtv2MCAYC/VU 1hNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749834245; x=1750439045; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tcgFdGvrxzEgL0jd0jS7Kyu6UO50T4AXfHFozAP4vvw=; b=ULVbhipoRFs5bKXJm0bvxUrvvODppGHopmNNyALQwYR6Na97AWHdJffl3I4Qg41es/ 5qJTo2gwGw/PsGsUhkjfEdjA8QYnb1QpoCCt5eFUP0A2JXcwbGAuyQFhD2f4buSe4L1g AgPCNOiywYVUi9UukEuThIucfvJlGso3YcZlQDYpcPKBY3mt3aQqqpy6iC2dzwfEqW0S rEfAEmS0DKhav5kGl5BttdPbNKd6qjr8zIQhjl/elAT+q8Uz4TAO5roeaOTfPLfYvsfn X50TfSagTugJw8Vph0QtuYNL4XTURoZ/XSDiBztuNN4JLrkSeSZEoGzhkeMW0HHXIm87 0brQ== X-Forwarded-Encrypted: i=1; AJvYcCUqAALiJ0/ZXuApkHqa3xUM+zfpA8NRQi9nrITMfak/RzdDlUYgNgwqA86+TuHPxhOuLOp8/+qzR+S+@vger.kernel.org, AJvYcCXepUMSjAqdVBXgg3kaj3SNXbWJeyJadLlxe8z+Z+3DA8JXWvrJ87KFnPPKb9VJgPJQKLb0rV/eZ9GOOYw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyos+SidnxXG8xd9iQzyhNJ9je4ub5KscYJf1ZbeC/Xmw4lFkvA XS2tA47TY9HFZC5jWAhnnjAE2niZgRg7u4NPpONsRNxqdvnmf/giFpYd X-Gm-Gg: ASbGnctCWd9xmKO1Zf9f11LGqOv7ztVrtFq1UGigIAR96I9GFIpJww0zkAwyxk8uHg7 aJi4GLv7omCg+MtXBkRgTIRigk6bPioYms1oAUsYXRY41Z4iecAzJhHaPOxjvu6+EQihXiU2aBU 6cYUxoc3HOrMsu2c1jJMLA5Qx40fVnA3I4NAGF/LpFm5NdFUcmJr3/UrS7eTIChcxx6lXDmDzJZ 7HSh1U3Cfw+obuqYcYTa7OrMs2HOg4eODxEDGdxuDzJc5gE1jH1U06uNmLuyKGpMBg+H1PTa84B cKO9l3JvilmSg0AE/88XqzHMnqrVVDrOtJ2aQAJVl0Pu0r2JWw== X-Google-Smtp-Source: AGHT+IEake4Oyk+3VD3p5nQZUX+vQxvPT/Si+3TYxp0PC+ZuZKAfc9NiCG381NhK0913uRvKjkWB7Q== X-Received: by 2002:a17:902:f90f:b0:234:ed31:fcb4 with SMTP id d9443c01a7336-2366b17b65cmr3388205ad.41.1749834245130; Fri, 13 Jun 2025 10:04:05 -0700 (PDT) Received: from geday ([2804:7f2:800b:8497::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deb0484sm16748655ad.142.2025.06.13.10.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 10:04:04 -0700 (PDT) Date: Fri, 13 Jun 2025 14:03:58 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v5 3/4] phy: rockchip-pcie: Enable all four lanes Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code enables only Lane 0 because pwr_cnt will be incremented on first call to the function. Use for-loop to enable all 4 lanes through GRF. Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index bd44af36c67a..48bcc7d2b33b 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -176,11 +176,13 @@ static int rockchip_pcie_phy_power_on(struct phy *phy) PHY_CFG_ADDR_MASK, PHY_CFG_ADDR_SHIFT)); =20 - regmap_write(rk_phy->reg_base, - rk_phy->phy_data->pcie_laneoff, - HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, - PHY_LANE_IDLE_MASK, - PHY_LANE_IDLE_A_SHIFT + inst->index)); + for (int i=3D0; i < PHY_MAX_LANE_NUM; i++) { + regmap_write(rk_phy->reg_base, + rk_phy->phy_data->pcie_laneoff, + HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, + PHY_LANE_IDLE_MASK, + PHY_LANE_IDLE_A_SHIFT + i)); + } =20 /* * No documented timeout value for phy operation below, --=20 2.49.0 From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76C092E11B3; Fri, 13 Jun 2025 17:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749834261; cv=none; b=VHAzzxZXZvuvuu2qBrkdOGThtVG5UXZYeCvWn2HfscTQJEBuHKr85iUE0383lQtB4VSkaQLwfSgrZhE/1OX+lbLiNiSIO6ycb90p3g0gUzkFQ1ayQMCLbq4Jo8RNdC6I6QAZFBv5Un4gVln4eOvRpozq+iD/GltXtCB7MIKbGw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749834261; c=relaxed/simple; bh=DzWuE22vL1YP8zSHbfP7Qpjs9nzrUqlrq34nmlb01RA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WAfPL+hoMlyAKc1Hr4zGW78lvCWgtQDl4h634m9BbDzO3shJAmcD5PbYI4TsagXo6koNN8ZTSftrbRBVkhpEF6UEzja9/scX3IIvEo/wfvB3oHS5+T7OaTwytLubOq0zvuKvnGfYbB1tbxW/9/fXDrtvDODM+lbVXbazMWQeKGE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mEy0MV1L; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mEy0MV1L" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-234c5b57557so24232415ad.3; Fri, 13 Jun 2025 10:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749834260; x=1750439060; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4uBBexglmDg860eeLxvF6Ft+pxKPH1DbiU+A4sUq4Hk=; b=mEy0MV1LyRQ2fZwdCDLoi9waqsmR6TbJFVMQXWfYci9D1uJLMd/1kSJ6fS04OZ7VXY r4zevQvwZbPwMomeAMVE1W4+y2lbnhS2V31oSEZqXyIJpomYUgphTIKlHeA81Xhaqpp5 WpsRItbxuHEXG+TfltDsvYS1yvGMKfc0P9lo/gJ8b9rTdXzv0ZK//oD1hQHHqcFb8c9r W+HJ19T4M6kEo/fcsqLGeK6KMBkIk1iPP1zieLSauwXGGlP5iD72COXCAtufzYdF1I48 z1ECVUnEIoifzoONpLDV9kZgvxxkI8dfebNL6VaIP4ThYJy8TRJngOP/zh7xtWmlUfjq udPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749834260; x=1750439060; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4uBBexglmDg860eeLxvF6Ft+pxKPH1DbiU+A4sUq4Hk=; b=M2v9SLw0R/8KbM/ZLRLvnPfmqCPIdVpGYQC3IGQrDSyAvLDYb25N3IGQp677qv03NJ i6AsYKy9+A5huT+S8FFw1G5ymK2pZh+eWSXTdCrvBjxKIfw93e5EROLYIFFoWbudsrDm ZslK/i3Mm2+2mGFr1EyAB0YClkmE4xbZMKe0utTC9cHqSCDOi2YavC1UF0GJfletOm/5 z8mqgi2jvRih35tvGTcrWwbsptmDyC6KpWk6+Rkk4uGTBxbPHIpxdGd6O58OBttaTYBh wsmwk2s5f/W3xBfbz9HsMwPOyKDI9sGZxYlqhBTte0derYOUMSweKUlvoS2ae+n2egmi V74Q== X-Forwarded-Encrypted: i=1; AJvYcCUXWBgn7vC4E+LiqixjaFCQzS5p905WH9g+bWIubrFd1XEyqVHbXKJezdFjN8EpmUo7dToZi+9XmCrLX0w=@vger.kernel.org, AJvYcCXaY46SBumbLtHS0Jrd3LLq51czPxg0hI391Y1kAm+JKimAcRIgp3q8NwNhWjO20m2ade1LUvQdhCOp@vger.kernel.org X-Gm-Message-State: AOJu0YzsBc3WkNLpSIBidRqSEQXUCQwbyp8BqF9PZqmcZos37RAFW4rz mu83tOSRjBKv/jL9GY0mtAo+kkhMQGlvLDpJ00sl1G09WSb0MtzhcAcK X-Gm-Gg: ASbGncuZ9+4Yp0OkndHCI8VA85e7XHkBfqhPrg1AulChf5tb6QS7qMzOSd6EuIMzlzQ p9eseqbkzC6OtubStDA5nMAKzPZT5e3iCbZORniCX2CbVAVp/JKBnl8eU0S/sMVfPceqY9qMn/5 oVNFp5lLVJn3/SSXIYPaaA0OkiSqSLraqT4YWVz5bm+NyNjQ7VAkdfhf/PkBnCnwVKaDtVTTFUr jUwiRy4HyJkIqikGxpIvYPmZqNjHVgWX5czpOc3Nx0LFxAXu7W9m2NQ61820xsrIs8NKsEhILbL ceoPaagTmfgFgthQJOsnWW5qs1l466vj68LtDdqg6yvOc+9QjA== X-Google-Smtp-Source: AGHT+IGZlaoYzpRe5dnXAmpmilA+8wbE0qcSiy78BVL+eKxMI8k9z867nxqg1IoThq9SVp8FoIbSaw== X-Received: by 2002:a17:902:cccd:b0:234:d7b2:2ab4 with SMTP id d9443c01a7336-2366b344261mr3162205ad.17.1749834259682; Fri, 13 Jun 2025 10:04:19 -0700 (PDT) Received: from geday ([2804:7f2:800b:8497::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365d88be1fsm16961065ad.8.2025.06.13.10.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 10:04:19 -0700 (PDT) Date: Fri, 13 Jun 2025 14:04:13 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v5 4/4] phy: rockchip-pcie: Adjust read mask and write Message-ID: <7068a941037eca8ef37cc65e8e08a136c7aac924.1749833987.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Section 17.6.10 of the RK3399 TRM "PCIe PIPE PHY registers Description" defines asynchronous strobe TEST_WRITE which should be enabled then disabled and seems to have been copy-pasted as of current. Adjust it. While at it, adjust read mask which should be the same as write mask. Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index 48bcc7d2b33b..35d2523ee776 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -30,9 +30,9 @@ #define PHY_CFG_ADDR_SHIFT 1 #define PHY_CFG_DATA_MASK 0xf #define PHY_CFG_ADDR_MASK 0x3f -#define PHY_CFG_RD_MASK 0x3ff +#define PHY_CFG_RD_MASK 0x3f #define PHY_CFG_WR_ENABLE 1 -#define PHY_CFG_WR_DISABLE 1 +#define PHY_CFG_WR_DISABLE 0 #define PHY_CFG_WR_SHIFT 0 #define PHY_CFG_WR_MASK 1 #define PHY_CFG_PLL_LOCK 0x10 --=20 2.49.0