From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB4F41ADC90; Fri, 13 Jun 2025 15:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827139; cv=none; b=evtWtaycJCPtBHMoItT2zx5/0tcG/8Hv3W2GC1lz5n+Q9PaStE581uZaoHWBC6MZrVWFO4LoRPxJl/jWlmHXwGXzEoMgTXzYCV5JDrMdx6f450Z9gyFOHflmwSl1jD0KpaXtolT95wxhGiKs+dsDJjRZ/b27UCNxiGXVlB78YIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827139; c=relaxed/simple; bh=HCHxyL0K42wwQ/tfkDZFm1mre6kRDwGlqurOi7MIwBc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VH4csN+IaRbe5KLliMs8PxQvRv54vwfPh8ynjY0pEDK7SQvVL+KXPK5yZmuAM01nRbnFnsAADWQjIerigNL9GtFaU6w21AmBeU4j1Gm4LI7vIlfxmXqhyJXvaF+Bcft/FT5r6v97I0A5AS/ouWUCqJD35/ZgQ5U4oFsB2Nd1h5U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MC64SEDH; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MC64SEDH" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-23602481460so21934565ad.0; Fri, 13 Jun 2025 08:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749827137; x=1750431937; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mzNQkY2OXtljp7yt/i/tI+v/gWIw5D47TujWJasE/B0=; b=MC64SEDHH5OOQp7CI76KLjrQmDs/2aAzLeNOP+Wwl3q9pZztj8uaeoA6rUjAhzvtbq GKh25+seOtXz1dWt6D7wFq6WCa3I/Aj+Gd3muXl1L30o9L/5l5qBTwwVz29yKVwHOUsU NUFE0WXwtHB96kUu4UvekXFfeFf2u1nmTruIxjNyDFH13zsiGWIvI3zGN/vCPYQqZH3G o3ipwhN+Rbb3z+i/nIIk7z+bI7Ha7qCOzUSJxZiAlcp8gtuDip5wDEM1Vz7YQ1OS7tfs DH4Q8RtGTL7bRXU1t3Yw9uORRBRvENkP+QoSHUkiLkEEiZ396CyiwyhNaX7b22y7pCi0 PkRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749827137; x=1750431937; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mzNQkY2OXtljp7yt/i/tI+v/gWIw5D47TujWJasE/B0=; b=AO2ntKZdymbdyBQjlkDcKNtfIWjQHakYix2r6JiQgltM6goTZyemjbyrUxluRSG0iw xYYbQAIu1PII4A7n0Geocnv4JTQ7qphWuFTZwKfpRTphhgiDjQ7WH0FAsEnwXPkeLuw1 aIViF9yw/4ldljBOqxRHk8RxOk8saZqHhgIVCwP0UGusisW2FYFE5hUSEx2XX8mthODD 2uoSa3/64Tkgb4BBOH9nFD/PIBN+SyqMyUflYmlrA4w2kDBQwkcI2xotkUVrRJ8hOU4q kh1Y2tyo/6yjiVTX/Y7evNeFI3TdWBGhOA6HloDBFWAPHoQe7eV0YvBEALNhVIu+icSJ vUKA== X-Forwarded-Encrypted: i=1; AJvYcCUQkW/i+lxSvZECEYA+EflA6DPOx4X22V1HQ94jHbNfuUxIaRZSJ2BkWzd/zZbFvBWrk4P4hdxTrbmu@vger.kernel.org, AJvYcCWnrCRWzg10zs018XQ9q8l7ndo5daano0ltjIhhjaPD76rf0O2hN7mT4yskuKlm3gv11djqmRzwaXC53kg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyq7ovfY2CvZBJFso1YAVaBOWXs1dkwiM9zhDmuSRG6ZFpfX0Ix X+ngrsSxhkuVHvQRI2gAOF1g8hi7GsUVUYzTBOVawTly27XLEr18Zpq4 X-Gm-Gg: ASbGncvGcNqDQIF3odPSvIgERnCdhyL9kUIrCxTNjD5qDq9YBvwUXfUo2X5cOzKD6M0 bNaiFVLVOZCnMh4wauJZxeBYAeZYBXwg8MKNdXRKmVfLfH4659EWPTbMlS7u6wwISpf8toMHROS PhfAfdFq3tOaup4IIihOSGMkPjzIvBGKgQdtILvi0baOIs4LKYkTemitsZNcBFfo/eq9qzIx3c6 ZCMXzl+Qqz8KG6TNFvGnM6WZjlOe1mryEWSoU5ZKnAL97gI/5Tp3wvSBkFXmvpMeXbv0vz8ZRy6 nX8i/Ne+edjKHN5a1ZI0xqBTdBBACobG2w26lNyrTd4ECsG/Ag== X-Google-Smtp-Source: AGHT+IHUZiUNYYnkhNtOIXhUvFD1NyZ9GfAWtXm9pvCPpRR/XwK39oN7VLpPRBZkXkHNasnAU2L+zQ== X-Received: by 2002:a17:903:1b6b:b0:223:65dc:4580 with SMTP id d9443c01a7336-2365de4ae41mr48856495ad.52.1749827137214; Fri, 13 Jun 2025 08:05:37 -0700 (PDT) Received: from geday ([2804:7f2:800b:838f::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deb04a6sm15372025ad.178.2025.06.13.08.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 08:05:36 -0700 (PDT) Date: Fri, 13 Jun 2025 12:05:31 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RESEND RFC PATCH v4 1/5] PCI: rockchip: Use standard PCIe defines Message-ID: <992ab6278af59b8f2f82521bf4611f69a916bbe1.1749827015.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code uses custom-defined register offsets and bitfields for standard PCIe registers. Change to using standard PCIe defines. Suggested-By: Bjorn Helgaas Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-host.c | 44 ++++++++++----------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index b9e7a8710cf0..65653218b9ab 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -40,18 +40,18 @@ static void rockchip_pcie_enable_bw_int(struct rockchip= _pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D (PCI_EXP_LNKCTL_LBMIE | PCI_EXP_LNKCTL_LABIE); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); } =20 static void rockchip_pcie_clr_bw_int(struct rockchip_pcie *rockchip) { u32 status; =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D (PCI_EXP_LNKSTA_LBMS | PCI_EXP_LNKSTA_LABS) << 16; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); } =20 static void rockchip_pcie_update_txcredit_mui(struct rockchip_pcie *rockch= ip) @@ -269,7 +269,7 @@ static void rockchip_pcie_set_power_limit(struct rockch= ip_pcie *rockchip) scale =3D 3; /* 0.001x */ curr =3D curr / 1000; /* convert to mA */ power =3D (curr * 3300) / 1000; /* milliwatt */ - while (power > PCIE_RC_CONFIG_DCR_CSPL_LIMIT) { + while (power > FIELD_MAX(PCI_EXP_DEVCAP_PWR_VAL)) { if (!scale) { dev_warn(rockchip->dev, "invalid power supply\n"); return; @@ -278,10 +278,10 @@ static void rockchip_pcie_set_power_limit(struct rock= chip_pcie *rockchip) power =3D power / 10; } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DCR); - status |=3D (power << PCIE_RC_CONFIG_DCR_CSPL_SHIFT) | - (scale << PCIE_RC_CONFIG_DCR_CPLS_SHIFT); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DCR); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCA= P); + status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_VAL, power); + status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_SCL, scale); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP); } =20 /** @@ -309,14 +309,14 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) rockchip_pcie_set_power_limit(rockchip); =20 /* Set RC's clock architecture as common clock */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D PCI_EXP_LNKSTA_SLC << 16; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); =20 /* Set RC's RCB to 128 */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCT= L); status |=3D PCI_EXP_LNKCTL_RCB; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL); =20 /* Enable Gen1 training */ rockchip_pcie_write(rockchip, PCIE_CLIENT_LINK_TRAIN_ENABLE, @@ -341,9 +341,9 @@ static int rockchip_pcie_host_init_port(struct rockchip= _pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); =20 err =3D readl_poll_timeout(rockchip->apb_base + PCIE_CORE_CTRL, status, PCIE_LINK_IS_GEN2(status), 20, @@ -380,15 +380,15 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) =20 /* Clear L0s from RC's link cap */ if (of_property_read_bool(dev->of_node, "aspm-no-l0s")) { - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LINK_CAP); - status &=3D ~PCIE_RC_CONFIG_LINK_CAP_L0S; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LINK_CAP); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= AP); + status &=3D ~PCI_EXP_LNKCAP_ASPM_L0S; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCAP= ); } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DCSR); - status &=3D ~PCIE_RC_CONFIG_DCSR_MPS_MASK; - status |=3D PCIE_RC_CONFIG_DCSR_MPS_256; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DCSR); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCT= L); + status &=3D ~PCI_EXP_DEVCTL_PAYLOAD; + status |=3D PCI_EXP_DEVCTL_PAYLOAD_256B; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCTL); =20 return 0; err_power_off_phy: --=20 2.49.0 From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B0369444; Fri, 13 Jun 2025 15:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827153; cv=none; b=YAt5xDsifBKXQqQJNrOOfdhnJMJexDvLBpDSNGoXHiWznCMCr41oG8b6aMQtaEkdEII9wRxD6QsE8LZGWL4m0rZ2Jwu2GbEdpV2IO4NSUWMyVzf/SXlHJcCXkZraHnycog9hQWSgYBYKKGEF5u/eW2k/mHRXpiojbP2qj+hmw+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827153; c=relaxed/simple; bh=2czsTqDFs2LayaWE3o+qV4gJyCKv1km6UVStrH9AcGg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DVuXDV4HBGxqg8kEpvvlF5e4sKeuA7IBBVa4pCX0A1IWyl2nEQqFbJJ/B6mjwoU4tU4nanfdTTkWG/bk1PNBiIp4/A+Uknpd4CErqrRaecbvM8eJqwZX9ZY6LMXnIdFPGFJH0WgPA2PZ8Agi9mlqYht8qTAuhsaNN0RbFiZPg2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fyTCATR1; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fyTCATR1" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-74264d1832eso2400933b3a.0; Fri, 13 Jun 2025 08:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749827152; x=1750431952; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d/L0PwwkoPnRzlL6fmDLU+JBmZkHn+VWrN87UcWrxlw=; b=fyTCATR1uAD/E/7RM+N7ukmxomyaXwuaMrnGSV981pv0zqGUFYO1W4FJlLIYhix19C ZNTTnyyg+w0KqNRUci7J/bF3ad66Wh9pbxKucOun8Vj1LpafB+KE1KYxIK8fdCpH4gB9 Hsm2J4NfRDWrkw5mx+npt2FrRFtiRHWIuSiqMzeBcZiNfqtPjLAyspviaUZSJpYXUMGX cAn9HXUsz/5/JNlHTJ6cBcKp7fkYjiUNrLTqisbGmZwYZIK/iVH5Bfo5nsw0LNzZjJsb 8pzNFSSHaIUZrsO5fuukrilGyAjiSZ4B8fC6j9+qv8zFkEYQHf610YDDOqvBkbM9UQTR jufA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749827152; x=1750431952; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d/L0PwwkoPnRzlL6fmDLU+JBmZkHn+VWrN87UcWrxlw=; b=AFwftGcQd8nnqUQR8OunA2xvNObF9FP2rr+X0eeeOcTMqfXZC/gobVgNLF+RwnjVNd Q1BE8HwXv6DoBEJzE3d+C9tdaN7YUCxu6SDMLM9bqHFXbrFMPFW3uDdKVM1F8SXzwobB qvoC/rTczAN4t4JGAWn93TxyP2YAxv2ksrG91Jb//mZ98C+lOK2M7no40lr3ZIleJdTg daZRPq3VR9nEHbpzjA1tYEQwQkkfGrPxmQoDclpHHHqnoUBPhqbtNW7tNSd8soppNDNw lkzAITQBE/+rRObir5e4lgjiIwmIfe6Q7ksHKhhfAkN98XWSyKhnSD7WZ4Nt2Fcnxlcw 9Dpg== X-Forwarded-Encrypted: i=1; AJvYcCUA8osD0Phc6HdnN2LHTnTko4Vh6UARmTUUB8V6vFKZrG0emeMzxHSAAu/o1s4HAAs/4inbdMHVo3jtQqY=@vger.kernel.org, AJvYcCUqDgkrzWmzmEZDUeJCboyFCmgFxTYiDAsgcWRrz6rxitEXXnRFZyiTlRefzujQdAaOBo7raOA7SBj/@vger.kernel.org X-Gm-Message-State: AOJu0Ywh8P94IykJnoaAO37650+G7MrsXT8h90j1YpC6+0upz34S9s8o N23UuXKsCx6CoteFKdiwWssOWA/jZ9fOdBuS1XmxLpqSQko3VDwLpxTW X-Gm-Gg: ASbGncv2vdpW0l06A6obcGp+Q43LQsMAOdsVei/wKBLKsDzOPygdJzZkxmZp3nVKAXn EcZOutPceUwlmRkVLQ7IclKfdOiV9pVnxUATHt/MxBsGPuaN0bCElH2Ln10+TIp5gwGVfTH3XRI cLNBTFklvqR4HOzS5T6fBWANUhp7nElZwG98Tm5RaJDw928VWz3bUKrYWlRMh8NVsszXW/1ve/n 8babVDS/Dv3VtIDDbCYKX3z9fUNH6OADWX4G9m6keQ8A8ShwXxGgp3q8lbzM/2/vD2beudKem3h 9rFuorhduHXNaU2ss0qPSVihCEkWkIUfynawfu2rIE7StqFO9Q== X-Google-Smtp-Source: AGHT+IG4B1Sr0UrOZfVg0WrH56Dwn4JeKH9TeQsHR+vKAhqTKWcWTRjwhT3U5qwgEodmsfG4i94Egg== X-Received: by 2002:a05:6a00:4fc1:b0:746:3200:5f8 with SMTP id d2e1a72fcca58-7488f8044c1mr4455309b3a.22.1749827150000; Fri, 13 Jun 2025 08:05:50 -0700 (PDT) Received: from geday ([2804:7f2:800b:838f::dead:c001]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748900ac001sm1725865b3a.108.2025.06.13.08.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 08:05:49 -0700 (PDT) Date: Fri, 13 Jun 2025 12:05:43 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RESEND RFC PATCH v4 2/5] PCI: rockchip: Drop unused custom registers and bitfields Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since we are now using standard PCIe defines, drop unused custom-defined ones, which are now referenced from offset at added Capabilities Register. Suggested-By: Bjorn Helgaas Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip.h | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index 5864a20323f2..f611599988d7 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -155,16 +155,7 @@ #define PCIE_EP_CONFIG_DID_VID (PCIE_EP_CONFIG_BASE + 0x00) #define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_RID_CCR (PCIE_RC_CONFIG_BASE + 0x08) -#define PCIE_RC_CONFIG_DCR (PCIE_RC_CONFIG_BASE + 0xc4) -#define PCIE_RC_CONFIG_DCR_CSPL_SHIFT 18 -#define PCIE_RC_CONFIG_DCR_CSPL_LIMIT 0xff -#define PCIE_RC_CONFIG_DCR_CPLS_SHIFT 26 -#define PCIE_RC_CONFIG_DCSR (PCIE_RC_CONFIG_BASE + 0xc8) -#define PCIE_RC_CONFIG_DCSR_MPS_MASK GENMASK(7, 5) -#define PCIE_RC_CONFIG_DCSR_MPS_256 (0x1 << 5) -#define PCIE_RC_CONFIG_LINK_CAP (PCIE_RC_CONFIG_BASE + 0xcc) -#define PCIE_RC_CONFIG_LINK_CAP_L0S BIT(10) -#define PCIE_RC_CONFIG_LCS (PCIE_RC_CONFIG_BASE + 0xd0) +#define PCIE_RC_CONFIG_CR (PCIE_RC_CONFIG_BASE + 0xc0) #define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) --=20 2.49.0 From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5A7A1AA1DA; Fri, 13 Jun 2025 15:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827169; cv=none; b=Ok26uZfRwNDbevg5pH2BpQpjvA+ZNNzOs4o2Lp2UUlR4+r2xacxd89HRHCwPviCdLqvyfwV52uKHegV7JNu2G4TbfqpkJRAL7QC/CdOXyvbZDqNN4AKCUfFrfQnr9a6llwpmvqZKRn4ZR8Anxgv4vaAzKGnPGi/ACeQplRrhXnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827169; c=relaxed/simple; bh=I6GWAxCHn9ykIre5Iu/5nDrUj5xXpxLWH8Z1EPm68Ts=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eiKzFGrfnMvFGZ9Dv18bhSZmqyb3W4EZvXwkoSw8lZ71B+odeNwlDFnBV3jcC7FEPp727hf92d+eJOnZuGMkAe9AnHpGSnQf9x6EjLC0tcxvqll2hcywSVQyOzVtRQ4gulLucZNWyhFSDvCIbNfHm5KMG0vzUVsH0X1v+m0tQsw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dd1KsZOA; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dd1KsZOA" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-739b3fe7ce8so1930834b3a.0; Fri, 13 Jun 2025 08:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749827167; x=1750431967; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5jwmmYn5mR6/LEUkoHGVPsLNEcwThgX3SiiTAZydAvs=; b=dd1KsZOAt4QawWSsAHW9c8sFGQUs3GlKOA2fwyXjZUa9NSzLwR5BE9BEhwT+qQ2L3q 2/lJcruHF22uk/QyBQZZNjpPMMSixS6OLXtsDzgD5Vfrfo6EzPb8Yhooqy7w3IgVVUiz Qdgq661/sSr/cIRGylC3y+GCNa5AU90DYBekzEajgrTG/LvrxW3JQKTr1MfwIj0nwPn5 tQNuNXsLGrZtFOyu9hAwYJ7JDT61dleUf21sgylyx3S5dX2hS0fOPo1fY/9s+8dRMs1+ y0TGEgMotcNjhG8txqISp+/BJrZSbMsaqqYCKT6F2ohPcCTUTbXrcJN1sLu/OnMLe1WP E0Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749827167; x=1750431967; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5jwmmYn5mR6/LEUkoHGVPsLNEcwThgX3SiiTAZydAvs=; b=t/k0WawU1JXao/wJb+GjA/68+9Yz2LxElA0Vdb9Xl9vklCUtsQM28zHqDU82JnXjDs WrnVu4JA0UEn/kTPaLP42Q5oBCpdHX9bfPnIzc1jPoDpqYf+EOCDdh2AnN+EAS27NRu0 YnyyK/UoFRhKypwMsIixGRLI9I5iKNZKiDCmi6ym3TyWU96dsueJ+Do3YvzogDr8ez2Z F29lqHlvF6XrORUqFzOUdLoSzYOOhMtjBXTvSbccXF3NfxHQd0HT8+E6HNayTLZdBnBx reKExU+rXL+tuiILnB7wvDn1TZf4S93k3StwhSBGx5YiEZWfJMfL+e+QtEWWJOVkVqEh sMWw== X-Forwarded-Encrypted: i=1; AJvYcCWiNvX/PhcPKLPkU5KTUnuya+k5ikTNfsDEACzzC4DLQh7Yw3ELmK6X769g4qeLolGawNdLxKwnchNE@vger.kernel.org, AJvYcCWqrlrQAZh68fMhindpEJSN7Xdm0GcHwDqgJEScsrec2gZPrmo5FSrKGN3ETMVGyYhVc9k24kxSyxHCPjs=@vger.kernel.org X-Gm-Message-State: AOJu0YxpkG9x9XI1Cearvz8fripVCMX1qfs8uqokJya1f4P8z9z+2UyV df1FRxGNeKMdZlL12RknWSSqy0GvgTzWS1p/gFmVycIcukOWNDH4ZNYg X-Gm-Gg: ASbGncvV4Wz16gJFaiiWP3p+tN+7dmfpgg+MScxF1/MXgPjnvAzInMIy70BIwWgSTH5 4sS4iDDotQsGY7nZtPmRnSMlhJDMn9DjsEUnxODaWUx6pU68+3PZwRPdFps5Fx8MPK9lfFhu2t5 zTUxyNJleXOuiUgYGK9XuU24BFogcPhgaJQGsU60ADxSg/61qe1pGcSJ4ctvLUVUfuAt+r0D2hE 4l/MrvbrlK/qZ8SANVU+WrTbBkQrVI17VVbS+AwLaxlvfdp/8ehp35Y8U9VglG30oRou+CZn412 DQooszE9RY1Yt4Xrh5+Tb3UQ79WvBERisDnp/Pu4Nh+vuUJ6pQ== X-Google-Smtp-Source: AGHT+IGYw5AjQ+/QZORRx3QoafJhKHVvIiAqNZXzixKJWW+8p/p+htMuLlVMp3U5LPssM6b4Oi+Eew== X-Received: by 2002:a05:6a20:7fa4:b0:1f5:6b36:f574 with SMTP id adf61e73a8af0-21fad0d39ebmr4649001637.38.1749827167066; Fri, 13 Jun 2025 08:06:07 -0700 (PDT) Received: from geday ([2804:7f2:800b:838f::dead:c001]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7489000531esm1691240b3a.41.2025.06.13.08.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 08:06:06 -0700 (PDT) Date: Fri, 13 Jun 2025 12:06:00 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RESEND RFC PATCH v4 3/5] PCI: rockchip: Set Target Link Speed before retraining Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code may fail Gen2 retraining if Target Link Speed is set to 2.5 GT/s in Link Control and Status Register 2. Set it to 5.0 GT/s accordingly. Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index 65653218b9ab..7a0b6ebb7c27 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -341,6 +341,10 @@ static int rockchip_pcie_host_init_port(struct rockchi= p_pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL2); + status &=3D ~PCI_EXP_LNKCTL2_TLS; + status |=3D PCI_EXP_LNKCTL2_TLS_5_0GT; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= 2); status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); --=20 2.49.0 From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 463A016F265; Fri, 13 Jun 2025 15:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827183; cv=none; b=A1l0rt9iA7idExxLKnlvyndcCSwtjpZgd3PMJAQKNlLWz6kDYDRE7FYRcCt2/Dxc1O75NfgdZF0KVPHM7jI8AloraCGA47i6oXARr9yv4iA1/VoaYcHIJnwRE1ExOegcGrT/KWvzvQ9MbPQVs49X06kwKI3rGECKkKvzR27cH1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827183; c=relaxed/simple; bh=z1QuJQTs2qeychSUYLbx3MrTtjKfzdWwsIGraIObLLg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rYMHZsohvDxLCt794iKfONNxERIJ8vgxzLjOsee+fkK6VqE7pfeEoe/Rsgimw09+IXGROJAv1AGgJpDjndxii5ejfQQOtdpwvS+1b0zkC22mw+SCHhqYtd/oVOOyrgGdR4+c3U978TuQ+C2te39j1E+Z2mIzRaKksB8wg7fVKv4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=imNINOwj; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="imNINOwj" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-311da0bef4aso2523427a91.3; Fri, 13 Jun 2025 08:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749827181; x=1750431981; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tcgFdGvrxzEgL0jd0jS7Kyu6UO50T4AXfHFozAP4vvw=; b=imNINOwjTZEgX3khIhI0b4CGPIRGartVei50VcTocpluIkHQ164ijxQsdu71T04z7t EU42Sj9eijX1EkjJOSIfLeVZhNxaeMyRaT/HhPxd051iN6m6vp9IDm+9UyHd3B0UnwBv KTMarPxXkZrGsLHGRSGbJl5j1apAXU14jhzwkzNMG4wxFuVfPYRSrAyrXnuLX1dMEhTG 3NbqeSmw6mbxopgmAllcodPgNjykE7Fym8ziH946V0X6HSTnEBhB3mlwlBqVtPk9+w2X gCFwA/8QWlG/MGE8Yoh0o3iVZW8To6nt/ovQIyDPs1ZiCkFEt2h+85Y5rj7/BSS7MJ9F w1Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749827181; x=1750431981; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tcgFdGvrxzEgL0jd0jS7Kyu6UO50T4AXfHFozAP4vvw=; b=hwl6YDyqCLK5bhAUWVUxgCsozwmM3jHHJ8WKwUgRLsmwzVOMNrrhe8K26WBrbIyZzL WicwZ9cyfBSBBZ08kuH54PftxPnXsim1bLRi4iEiIRAqdHTGG7E7hb/2MX6T86UQqD89 EA9qb+pKqOWfHjyUacSgRmlEi/0Lzd733oFKO6GrcYEcbPs5pYd5TI3zBEKjW1bQ6b+9 ntnj7QsBP096pJ28Fqrdt088eEE6KfdCY4MlUCTS+nJDpgiI60mzFmH2nw9a6uvZrKV3 kaglvs/O3YrTjw8CUjxwhIIgzlC9DS1QBLWH4W8Wq5eBGef9XxK1wcLg4QWTf/JGUmqB pklw== X-Forwarded-Encrypted: i=1; AJvYcCVCfGAFw7QIguI9qGjDgssg/tVZGvAMRyr9DvNR6U6pMabVAob7EQY4QJAQs1xaY7VOGdJQA9TnsMU7@vger.kernel.org, AJvYcCXwtBOEPx+QWagj2mmin92iLqxa8feiNQtuDzNuadKSxd3EzRCxtV54wZAtuVCJBoaMTIoOjA59t8bnkdU=@vger.kernel.org X-Gm-Message-State: AOJu0YwEw10x5cxiYXCjAXqB585aTJj4ecrcqju4rBBAGBzFU9BYro1E kJ48Br4Ai1FEcg1WtVWFhbfWaNdZZQWbMP82v+3u6q84vM/Wm3hxtNAz X-Gm-Gg: ASbGnctzn5lUgd8j/eoG/WvTTJE8ZOY8EUadHcsDkHgZTyklzP1r0qmkvLmBBXxQihM ISVxv0Ty/pgDKYyPdjCTUiVSC0uhOtEXuLtki1w7UL1JIR61R12J7LuLZpJ6Vof6mpqRjhiSa19 NM4lz6vuWDWizqsJ5lDzE92yPnKI46/g7hrlx8vdUFTqAIdD6IVkRu6oPVrq3Qhxs1G0H5D7qhM H/wLpbUCRXFCA3oiPy3SPJ1XVSsLfq+9118fTuTMzV3yl4wcmqQamHOOwjoaZ9NEHhxMxPRtp02 otsWsmVlSb2xz1EtfHaHt1SHw8eWyVAq5iTm504+l5+LqrI7Bw== X-Google-Smtp-Source: AGHT+IECaGBjuizwlffuDig1L0laDWaQFszoeJrsrY+zyJrlRqn3sGWZs1z2EMQ8zZxgMRnvK+ky9Q== X-Received: by 2002:a17:90a:ec88:b0:311:cc4e:516b with SMTP id 98e67ed59e1d1-313f1e4a36bmr31111a91.32.1749827181384; Fri, 13 Jun 2025 08:06:21 -0700 (PDT) Received: from geday ([2804:7f2:800b:838f::dead:c001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deaaa15sm15322535ad.173.2025.06.13.08.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 08:06:20 -0700 (PDT) Date: Fri, 13 Jun 2025 12:06:14 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RESEND RFC PATCH v4 4/5] phy: rockchip-pcie: Enable all four lanes Message-ID: <389fc093572f3124244c5f3e87dd084b89be88ba.1749827015.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code enables only Lane 0 because pwr_cnt will be incremented on first call to the function. Use for-loop to enable all 4 lanes through GRF. Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index bd44af36c67a..48bcc7d2b33b 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -176,11 +176,13 @@ static int rockchip_pcie_phy_power_on(struct phy *phy) PHY_CFG_ADDR_MASK, PHY_CFG_ADDR_SHIFT)); =20 - regmap_write(rk_phy->reg_base, - rk_phy->phy_data->pcie_laneoff, - HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, - PHY_LANE_IDLE_MASK, - PHY_LANE_IDLE_A_SHIFT + inst->index)); + for (int i=3D0; i < PHY_MAX_LANE_NUM; i++) { + regmap_write(rk_phy->reg_base, + rk_phy->phy_data->pcie_laneoff, + HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, + PHY_LANE_IDLE_MASK, + PHY_LANE_IDLE_A_SHIFT + i)); + } =20 /* * No documented timeout value for phy operation below, --=20 2.49.0 From nobody Fri Oct 10 13:36:42 2025 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D0541A5BBD; Fri, 13 Jun 2025 15:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827197; cv=none; b=Q7jbf6v9N0YBp2THoVRC6ScL6AViwH8DJUeikKPLSovHww7H1UMcCVknI1hv644ra4M3Nvey/Hhm3MlwZTq3ixlUGlaaGh7widuMkn48aCIYF8R+GXcGYS+mCTWfGwU275cKmSA4Hrvy05x94EGP0T82Gn5CFDi180lahseBj08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749827197; c=relaxed/simple; bh=DzWuE22vL1YP8zSHbfP7Qpjs9nzrUqlrq34nmlb01RA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pNei1UugsVTWfi1mrETIKjjkTIvr7xTSmqI9XAd3XFMz+HhCD+xtyz8ZXz91GuoDvPX49yCXV9dLeRjash23oC/sRmi4pCmop5KVN9VvvM64qs3YMXDbx5lAZ7kkKAZcgVSR3sYufuw3r9vhYKo1udykCm2Be8ad+PxAY5Cdm/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q4DTK97L; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q4DTK97L" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-312e747d2d8so2911456a91.0; Fri, 13 Jun 2025 08:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749827195; x=1750431995; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4uBBexglmDg860eeLxvF6Ft+pxKPH1DbiU+A4sUq4Hk=; b=Q4DTK97L+suPraLAIsC2rcBJ2DUN/4QqJuQvBfJMeGUYXeAXlhElIFj4DLWm2/Yocs cQtJMsLAIjuIjRX9snM9lZLw97yoPr5VEwK/hzHpwup54qeNh3lv20Oz5N952F/nMbyB qLHFOg6Pjh7acykg613UJx83PLDy8C4HAoqD0zFC5X8CH+gcDyWzdwctxrOtDMONdsJi 9QxCVz0EwVhUb7QkzmKo0tRADoqCY7ra25/LMlf827XEy+UNNWekt7DjlaMg3Ebn8aUg G0A/aNvlUsmYc0fV9PhabK+mk+mHs6+BjhCNagzblpAum037HFiKeeRhNBQ7C9H7+MqL JvEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749827195; x=1750431995; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4uBBexglmDg860eeLxvF6Ft+pxKPH1DbiU+A4sUq4Hk=; b=YtpmqofNICL5zdbEODPOLNYKKT/1Urq8NqEjBwQzqjqAMUst7xCEH4xR/3+jjFE4O2 r3ySsjbliA5VN2LGMDMBnoQ+mbYHPcGE1Z2zEZ0RuObvNnEuajJiv6aEa4DlJ7GTwoah xd1clxePGwrh2oV2ssg2xBvO+RlMj4Ib7ofNXW9XPjLW2SrfK6M3/cWwI2nmc02tllbO OOSvesbJgHraLK4KVCfc1eBJVqzmrNqjxxtFFppAxKiCqR5pdRo500bVRrX6F2Bf5Di9 hdrkecREqBOKwCBiToyzWq3vsn3GQHcWEvC4XoEvXQLpDcK5CZ8dTaKNAOrPJ5A+4BTl CpVA== X-Forwarded-Encrypted: i=1; AJvYcCUrLB/Fui9LzUt/rTrZ8gcO9EPqR+zx3AXQ1Is1tVbh2wr8UREGTE/bBQLQ5G+Qd9jmvxQvnZjKhNxqfME=@vger.kernel.org, AJvYcCWef66kSLNOtfyXI5nyPK2QuHpf94SGS32SNZi4SnJUFh+EX9nVySwjWPmKZrsc2ZneTLcUXg65HrPU@vger.kernel.org X-Gm-Message-State: AOJu0YzZwgI/7qg5/3znD63E2SBAMnreAwGBdXHNBffGqCp67i2ZypSm H4x8FmfWhh0W0y1tPc0d3pofJFaKz2RL6kx9ozhn0qifq4ojLdeIahdy X-Gm-Gg: ASbGncutUkrap6ihKP9zEmvSHjnrbtuz1peZfBMutVs8vYdoGdJV8WuC2pNlqmp6+Px L1uNHOGNG29iMDLH4AxS/xmG+tIPC3U8bo6cr6i3QLEVMUYMojUlZb1nPpDKZFWsQTm7LpOgkYV oRz572pdFv+kGunK9nzsXpvrUjMqAH5jaRkLLg1FkdC85H1JQzhrB2U2OSumG48B9ZKS2j9wsOh k11rAkcmp9GGtqv6jo3hv3s5Hnpz60qw5swF8fcdhcE+BneHU1MESgB4Om0TpyKSij6bJelFCN1 6M5ga5U/Bm4+6y7Onh2T3CXgxi7PZixhCE5LJrk+zvPgWYebL3mlbmYNKeRi X-Google-Smtp-Source: AGHT+IHrDxh6U4VAfIfK65vuTtcjHspUUqpNcD7PvyW2ItZ3xJVTxhDo3I8Q61np12P96HXNsZ4NXw== X-Received: by 2002:a17:90a:e184:b0:2fa:42f3:e3e4 with SMTP id 98e67ed59e1d1-313e9036d04mr1456076a91.3.1749827194621; Fri, 13 Jun 2025 08:06:34 -0700 (PDT) Received: from geday ([2804:7f2:800b:838f::dead:c001]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-313c1b499cbsm3885857a91.26.2025.06.13.08.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 08:06:34 -0700 (PDT) Date: Fri, 13 Jun 2025 12:06:28 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RESEND RFC PATCH v4 5/5] phy: rockchip-pcie: Adjust read mask and write Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Section 17.6.10 of the RK3399 TRM "PCIe PIPE PHY registers Description" defines asynchronous strobe TEST_WRITE which should be enabled then disabled and seems to have been copy-pasted as of current. Adjust it. While at it, adjust read mask which should be the same as write mask. Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index 48bcc7d2b33b..35d2523ee776 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -30,9 +30,9 @@ #define PHY_CFG_ADDR_SHIFT 1 #define PHY_CFG_DATA_MASK 0xf #define PHY_CFG_ADDR_MASK 0x3f -#define PHY_CFG_RD_MASK 0x3ff +#define PHY_CFG_RD_MASK 0x3f #define PHY_CFG_WR_ENABLE 1 -#define PHY_CFG_WR_DISABLE 1 +#define PHY_CFG_WR_DISABLE 0 #define PHY_CFG_WR_SHIFT 0 #define PHY_CFG_WR_MASK 1 #define PHY_CFG_PLL_LOCK 0x10 --=20 2.49.0