From nobody Sat Oct 11 08:26:22 2025 Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E34E228314C; Tue, 10 Jun 2025 21:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749590398; cv=none; b=NNP/eYTQu0Bh0hhDP5I7UM+//oWdU0sSCFcPOS/wF9rO9hYUX6A54yTcifaVr3WBUywphr3lR28uXgECGWujHbt6tQHyiM3nV9mJLqtqJ8BF2y2a5B765sdUt6/xq2sTPp8XXjsaGzyiXjigFPtahQMo18wFBvLEcb/VRMO/ie0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749590398; c=relaxed/simple; bh=psl2yGFKwIeajZS8qg8mt/cUrID+Wsj3xhRh7GlCvFs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j3WPCI/W96DDx4oVHBVKakp0xNzk0bZ5+Vg4huVIiWoEfbYR1Y7SJ0N9zt9G9tmWB4I6nfKjwyVtckWqL8Je7+QKN8ro7q5aqmzxZrg2exwQSmcRgmsx2YxI0/UTogXcKU0Ifn75fMJvS7kMlOLSNeZnvKaIBwe3eaZh+7O5qBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JhJ2xPQJ; arc=none smtp.client-ip=209.85.217.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JhJ2xPQJ" Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-4e7b69c1efcso234870137.2; Tue, 10 Jun 2025 14:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749590396; x=1750195196; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bW+KcteMx3KUNTcvwakQQLo/YUGvViEhrbAatOOYWoE=; b=JhJ2xPQJYNq8gwxP9O2sCbI/jIGQ3SVGKLa6oKyhSZvR08CjZqjqa8mW2oOiSxBBAt mP/vhYdh+bzdtjarQ5BgEsexq5+vY75uHz4AgMGlCN443Nzfhlsjzab+yVHN5t/ppcGN qmPJXPaTVqf9yEwioCdwjJ/k4fBLyF054Gzd617MGdHJv6gNpRQ1YHOvF/T8x6uqHFjy r6IqQQEgLD5LClB+XCpHOGFf3VsUPaAuLQiP9VqdqRMamYqz52x6q7yDKgjYFUYyF9c6 2ESgkpKhO+Cm6tzj7EnZTidiGhyEDo8J3yydGZl4QXUkmaw4APRagEiTYzAjxbwY+cX+ cp+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749590396; x=1750195196; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bW+KcteMx3KUNTcvwakQQLo/YUGvViEhrbAatOOYWoE=; b=C0GHgxriSD2afUYvfMJIqIjCEMVJi8BWpWgsIwHKp4Sgajm44H26Boq0wSVRgAERFV VSmj6yb5MtZ9JpCGDvlrJ2h806Lg9EMYmE1OMzVDQT9phHozipbnHXPwPy4O1EPxNOw8 Xb0p64377RilHMWhD+PoXlmrqALjqfcmf5KzAUxsOxtijSmJPk9qtX/wh0LI39+O9znO G56lO7oyMD+Dmb4ZkxxSpMVZajHCuJWg6+4d5Q50yfWBzu0mVTIeTcFHXpuiPQYTex9W uiC4ak4pCN/H8iob4XknsgUUd3zWAbyTkfDCfKtBVERHQe9BNE1M4K6Wjavs7kPyCqqS sfBA== X-Forwarded-Encrypted: i=1; AJvYcCUtFw8cPARGbXh/JS3jcLM5jSFgvF3AbJA2nmjxQpZU8PwLNvrMonEkaTj7xwkplrnlIfeayjQ6Efxkk2k=@vger.kernel.org, AJvYcCWvGPYEPuzQ0yahJhO8+jKHkMR7rnQKn6JE5c/HeqVOEIwkv4jJ2uI13qC3Pw7VHjEs23kKEnPkM7h7@vger.kernel.org X-Gm-Message-State: AOJu0Yx9cyvv83MwpeF4k90HJLlSZKeBzK0FIhLKVbStx6adCzNOwrLh SWOIb+1e5dmLQnFQmOepB5iVHNccvHDtd0w77VG4wC4Y7XI8k5vQM/Z9 X-Gm-Gg: ASbGncsUKocrYumIXIdyQWDaPNI9zCtMfxj83EUBVAX9efaa4OsizZvWhRX/H3g+zPg FF4yYE9UERAFmYCSpeieX/IKX7tVghRM4ZQJTMCeugH1nIQzyJHM1f1Ao9e5u5pAxfkujG+6vuW LD9nHAA6zE8JOioqfvhDiwHdsqFTLt9CZF6NVxg9QSpMxGwTuaSpwqVFAqbpk9t8toUbBzPEca0 XxKAbigNutfYA6kA7+BV4bRJJOCwHtywyIeDkCyKBdqOg/+nxDT4wmG6NFHkqtEv7P/vSBWdVgg gU2MK6AvN8nXEmQzvCGmSoq+PpGNHMxHRNjTdSlK6YIYbfoKVQ== X-Google-Smtp-Source: AGHT+IFUKOR2IsRTBdY8aOGnyv438Gl/440UbjAA3/JAat2G2nQmpyhEiA+RhR87ZqQsV+IyUokALA== X-Received: by 2002:a05:6102:4b1c:b0:4e5:918b:5321 with SMTP id ada2fe7eead31-4e7bafde5b6mr1050769137.25.1749590395586; Tue, 10 Jun 2025 14:19:55 -0700 (PDT) Received: from geday ([2804:7f2:800b:5ce9::dead:c001]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4e7baeb6337sm382957137.3.2025.06.10.14.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 14:19:55 -0700 (PDT) Date: Tue, 10 Jun 2025 18:19:49 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 1/4] PCI: pcie-rockchip: add Link Control and Status Register 2 Message-ID: <28ae3286f3217881ae6ea3aecad47ae4567d6ec7.1749588810.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Link Control and Status Register 2 is not present in current pcie-rockchip.h definitions. Add it in preparation for setting it before Gen2 retraining. While at it, also reference other registers from offset at Capabilities Register through standard PCI definitions. Only RC registers have been touched, although in principle there's no functional change. Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index 5864a20323f2..90d98aa8830e 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -155,17 +155,19 @@ #define PCIE_EP_CONFIG_DID_VID (PCIE_EP_CONFIG_BASE + 0x00) #define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_RID_CCR (PCIE_RC_CONFIG_BASE + 0x08) -#define PCIE_RC_CONFIG_DCR (PCIE_RC_CONFIG_BASE + 0xc4) +#define PCIE_RC_CONFIG_CR (PCIE_RC_CONFIG_BASE + 0xc0) +#define PCIE_RC_CONFIG_DCR (PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP) #define PCIE_RC_CONFIG_DCR_CSPL_SHIFT 18 #define PCIE_RC_CONFIG_DCR_CSPL_LIMIT 0xff #define PCIE_RC_CONFIG_DCR_CPLS_SHIFT 26 -#define PCIE_RC_CONFIG_DCSR (PCIE_RC_CONFIG_BASE + 0xc8) +#define PCIE_RC_CONFIG_DCSR (PCIE_RC_CONFIG_CR + PCI_EXP_DEVCTL) #define PCIE_RC_CONFIG_DCSR_MPS_MASK GENMASK(7, 5) #define PCIE_RC_CONFIG_DCSR_MPS_256 (0x1 << 5) -#define PCIE_RC_CONFIG_LINK_CAP (PCIE_RC_CONFIG_BASE + 0xcc) +#define PCIE_RC_CONFIG_LINK_CAP (PCIE_RC_CONFIG_CR + PCI_EXP_LNKCAP) #define PCIE_RC_CONFIG_LINK_CAP_L0S BIT(10) -#define PCIE_RC_CONFIG_LCS (PCIE_RC_CONFIG_BASE + 0xd0) +#define PCIE_RC_CONFIG_LCS (PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL) #define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) +#define PCIE_RC_CONFIG_LCS_2 (PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL2) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) #define PCIE_RC_CONFIG_THP_CAP_NEXT_MASK GENMASK(31, 20) --=20 2.49.0 From nobody Sat Oct 11 08:26:22 2025 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E844283689; Tue, 10 Jun 2025 21:20:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749590413; cv=none; b=JOEoAH0+k0jI5/NNChuGD+BG83VBlbic/go3uKNbYFnCGH8eQjapMLFCrpw5hoY/ol3oK+qMKpxDxC8eXvov6B/UC+FFOeGCMYmt40B1Eae7++2J1j0K4s6RQdA6D4Qy7pp0MvZjHNJSTMx/ZAiqKGak2Zwkp06KgVEsyyxwPf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749590413; c=relaxed/simple; bh=QOALSA3vQkgShMU13h5qOd5nTj3JQw5+SeYowgENkng=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rR8ma+HyX4KqdyiE/EDnBAPMBrx2GDzu4T3fS12OKdiHVzNsojIZrXzfZH3IndUbNZFTjEpuDvvzThf0BUt62c8l3Q0veiBxQNioLMZdIP2Yn/r2qdhnVLasmzRSKlb/b4RcyDaG9qUcmznU4njMLYnMQAJYjJS/0nrkA/uVfd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RFQXNv6U; arc=none smtp.client-ip=209.85.221.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RFQXNv6U" Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-5308b451df0so1813026e0c.2; Tue, 10 Jun 2025 14:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749590411; x=1750195211; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rMyHEENm3aAi7+mpl/5ALuPQmurPsDkuZW0WhOp/NzQ=; b=RFQXNv6UEn5dHB+kSGfqLmqyYDhVBeRUrPXP8Q4iJOJPTktFYN5ZFkv+EVwsqrMBpW ZQX+cwPYaNIh0a21ovBnyyYlqiTrjhbVO92gJVaWYwAHr+CRAkogqZJ6QeQqyRvxosJU LD82+T9Ne3J+Xo51zL9TV8J+W+vbXG8nJ1RLl9DTgjQ1c3DdrX0MzccxChajhede511m d165I+MzSbn1YgabwhQhKlET2p/aA9Gf8JxBmkcHIBhMOaliC/juG7GFmjOxxI7q372l 3C4tocTI6quKnAjiqG4DwZHKY99qzZG5ksmZwBpXstU643sgAX/93DLmO7wZIMNlaSGN Xutw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749590411; x=1750195211; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rMyHEENm3aAi7+mpl/5ALuPQmurPsDkuZW0WhOp/NzQ=; b=aWgdIFy41JejtWzV9Y37qO99lIE3hGvMcWC1//sTtx5TX4a87HYAvL/dxNTTf6PSW0 /zdEI3g7P5pfPdfT2JURoQGKhe0KQyT4FSkshzOxHdLjnuSJMoNY5NA5PekMBC73k5v9 ICtCfCfiIZDscUwlu93r4BV718X8KPvb6asPb2SdMMFoUMiwOaMiUKLJ+0pZvZnUjvPf 0LKdShxKwExc60AJcq/FqaEzHjuc50A6TpjnR9c9YDq+iptD/OrWiDzYP5BVEOCuhWsL DWoCJTQ49Fzf+x9rokzfjZOxpAYnCqXY0zDnG/haO8xvzgDs0c/JVCRzNcAyqneEBlZR Mp8w== X-Forwarded-Encrypted: i=1; AJvYcCVvGgJbMvZjDQIdcvQrqDPwl142XIw0NVZEG/oEwglV8MH1IYEn5EgK2YddFzR6WRxWmdJWaGcAeZUGn/A=@vger.kernel.org, AJvYcCWKBg+gOtCaze5FzYhWJgj0/tPmXS3nCj3HU62MYlHsO+VUMvYGmt4x2zMSHjndumyZto10PBIzcBrQ@vger.kernel.org X-Gm-Message-State: AOJu0Yz9KWB2/2REayMLEbJmNsUzWRilFIHr7VnYtktGE8/BAvGs0izR 90BnUM4qIOUQqEUC17A6PmNMdRwWWvPdxX3YmKQ8MKRHxQF7G6fsO0aQ X-Gm-Gg: ASbGnctIBzSVdj9s6OPD17emHakoLJD8hikOlHq1dZ26KkCGqoQivRRXPodSqemePHF A18Y+alLROaqFlCEQi30fP4QS/t9umrRO1xEiEJZzjWSG/hy+MEJ9BJEPsLm0+Uv6W89Sel/PNL OEEj95dwR9VIlcHih7uTTlOZ5bZBdfBsBHJOd+7RV/xLFbrd5vDBpEaAxcRdxAM7mREnBT7o2Pu pqQehSiclrOKL0jNp+Y+VEHONyeGtkpYvVF4EWwUrGnYjtCSa8aWr/w0uZJ42mUNw8x/NJDneI6 DPFRFsUCL0gTuXXT9YG06tK+1yABZ9W9jQIRLNIzJ9poDcst4w== X-Google-Smtp-Source: AGHT+IGMLQMogM9Y5TYRZq5x/+RY965YqubXBP0wkzvzdldN6Zcyb449bg6gGKSbqhDtgv+1p5DKOg== X-Received: by 2002:a05:6122:511a:10b0:530:66e6:e21a with SMTP id 71dfb90a1353d-53122c960f2mr547052e0c.3.1749590410872; Tue, 10 Jun 2025 14:20:10 -0700 (PDT) Received: from geday ([2804:7f2:800b:5ce9::dead:c001]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-53113a7e71dsm2065694e0c.2.2025.06.10.14.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 14:20:10 -0700 (PDT) Date: Tue, 10 Jun 2025 18:20:04 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 2/4] PCI: rockchip-host: Set Target Link Speed before retraining Message-ID: <87ca44fc3c34c5ffd3035d0d29b4ebabefed1c63.1749588810.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code may fail Gen2 retraining if Target Link Speed is set to 2.5 GT/s in Link Control and Status Register 2. Set it to 5.0 GT/s accordingly. Signed-off-by: Geraldo Nascimento --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index b9e7a8710cf0..fd6f1a1d48bf 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -341,6 +341,10 @@ static int rockchip_pcie_host_init_port(struct rockchi= p_pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS_2); + status &=3D ~PCI_EXP_LNKCTL2_TLS_2_5GT; + status |=3D PCI_EXP_LNKCTL2_TLS_5_0GT; + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS_2); status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LCS); status |=3D PCI_EXP_LNKCTL_RL; rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LCS); --=20 2.49.0 From nobody Sat Oct 11 08:26:22 2025 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B285283CB8; Tue, 10 Jun 2025 21:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749590429; cv=none; b=WFEBhx5t2dXtlG0mI62YlJ0FcNTklaMyEjBSwe6uFJ2mc5WTvRAN6p9lJBNmHm929N4P2Drx4Ra0y14jpJjbzHT2PmJobpC1SKh3LPhnJUWJ9jkFxdj4ETcoPkJJWTHzBdVgXfG2D1J5cdDO4lGUTtG7y1nMgaHOasHdB3+3KC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749590429; c=relaxed/simple; bh=RQyajJNgx/i4LD7NSbzA7d7o9iqhl4O7QAcY7mWNSDE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QBbN1tixdtmI1djR9qqAbiPlhG2/9EIcDKLrSF+cj6+rmmEqihXDqsLvqkiQBOTBKG6IB/3RLRKWwJEv7IdSLlmkeyoTVGZZoO6xRTyhOvjpGffrlwGeQrk265XsGIvfcP1fvoYspEK7Lz9rzxuALHS+c/Z2N6eVfUrTP6i/OtQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hTW4nwga; arc=none smtp.client-ip=209.85.222.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hTW4nwga" Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-87ecc02528aso733138241.2; Tue, 10 Jun 2025 14:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749590426; x=1750195226; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wWQhuuEyoK+JNH/BgqW9wn8WNRcWE8A0uz1Xnd+CF2o=; b=hTW4nwgaD/Xx8A84Iv8FEz4zcY1zhAIXAvsvi0Bzh0dpWKWxY9duQRcsNUO3gWkoRn XkE4IalUT1uyMzHiv4w/EtQbkasqehnxKPKamV0qqrwqxhD/IfpWVoKB2c+XCvIn5nL9 XMIEvWiIFZnattjyp4JLUuw7spL9N7PRHEPlnh4jAXZ1L8Jc7E7eYi/dEe0e4t8jbyzf kjUih0YX2BRwKNFi98aHLUQZdjaWJ/vBIOTlTRzmfRLoD1kCic/TZPSbuDwGUfUHGlTd cupee2Weyqbb/GrMWBD+F/eIjwbamEqm7MxTNNHXm9rrXvnNzU8rmQOAg9rLFQQNCqfM LBUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749590426; x=1750195226; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wWQhuuEyoK+JNH/BgqW9wn8WNRcWE8A0uz1Xnd+CF2o=; b=dwHp4qKSc/EmRZgMC1N/cOJfm3aNIFsfh+xliE48yusE6jZI9VspT8G+heD5Pr3Ydg 6IcZfGjxppInJ1Mk2wZMX7mB4sfBXbxV8ucwcmEKN/GNEaW2pgQ51tsJZ0d2pDHLORM2 UMrqiHvFmY6tuke6vuocSJi7/OUbucBe+abeXYj4fKt3hBRybdbecC6DqAuqrGJN1h+G xR88jiI/0TdC0vCMmSn71n6REhizBlgvuHRkBI/2FdRICmLy20U9pl4WEHBEx17I4NyV V1nEDd29Te/3fugl5qGTVfRfQpzqa9HjqW9dV7Mc52+ridfl94QwfR7XzCnycIoNWXhv KyIQ== X-Forwarded-Encrypted: i=1; AJvYcCU12vrtqLv1wcFr3u1Gs7OvOqoMt5Se3/3mi6PAnOSIkWb5GsoWELtj3ohYgO3DitGZYDhLr3aFo5JDdpk=@vger.kernel.org, AJvYcCUyMzLHoK87fVvdcTbrQgQKmcGHqQl6av/ayS/7Lw/2imUyw1jyVoUHyDJUwwDX+eyYMR7SJT6inoag@vger.kernel.org X-Gm-Message-State: AOJu0YxUVFNNyMtOhd9A2gJG7MWadvzMRxrOlKqsEXJe5vBBSIZnuDuN Nxv+uZFX4Cq90nJYJjawjYFYkmQk+VIugM3TFPtuqfcUJWL3G1XG6DIZ X-Gm-Gg: ASbGncvgfyBqnVQ4m5sGznYd256RaHZebx/sUqhOs/GoqqwTjJhKZPLCwFiDjOu338j DxsOKFHaNdUYetV8Rk6Rc31fhcM08nf3grsOAsD+tv8WjqKjKbOhbP30aOROJb7WZumTZZ/n4Az fNi9lGsvDv2PJCLrFrqSjK3JyI1sin3sG6m2oZYAbIfEPWhXhx7EXrqzhvDvyMJS/GEYKU8/ncL nt1pbC227udR/LK2M4oTYBgz63zHB2fn+j9GA4eIKcIz8EnTozz0Jc5HyYtCO+FEz0W5WmJ1ONe 1281lOevEOosXvGFtnowtNomlkh4dv7e2se/NI5coaVTR1S3WJlgGPR/k86o X-Google-Smtp-Source: AGHT+IGDXgBG6y7zW2MpyVdaqKpbTNDnRjbJRi3u91tn+U7IB/Trv1jeMCyTLcrjlDOUe09bWYO7Dw== X-Received: by 2002:a05:6102:4a95:b0:4e7:596e:ec10 with SMTP id ada2fe7eead31-4e7bba330c4mr800465137.1.1749590426276; Tue, 10 Jun 2025 14:20:26 -0700 (PDT) Received: from geday ([2804:7f2:800b:5ce9::dead:c001]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-87eeae777a0sm1882453241.11.2025.06.10.14.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 14:20:25 -0700 (PDT) Date: Tue, 10 Jun 2025 18:20:20 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 3/4] phy: rockchip-pcie: enable all four lanes Message-ID: <1dd7e551a9f6c7f6e9c3764e61261388d2bedaeb.1749588810.git.geraldogabriel@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current code enables only Lane 0 because pwr_cnt will be incremented on first call to the function. Use for-loop to enable all 4 lanes through GRF register. Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index bd44af36c67a..48bcc7d2b33b 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -176,11 +176,13 @@ static int rockchip_pcie_phy_power_on(struct phy *phy) PHY_CFG_ADDR_MASK, PHY_CFG_ADDR_SHIFT)); =20 - regmap_write(rk_phy->reg_base, - rk_phy->phy_data->pcie_laneoff, - HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, - PHY_LANE_IDLE_MASK, - PHY_LANE_IDLE_A_SHIFT + inst->index)); + for (int i=3D0; i < PHY_MAX_LANE_NUM; i++) { + regmap_write(rk_phy->reg_base, + rk_phy->phy_data->pcie_laneoff, + HIWORD_UPDATE(!PHY_LANE_IDLE_OFF, + PHY_LANE_IDLE_MASK, + PHY_LANE_IDLE_A_SHIFT + i)); + } =20 /* * No documented timeout value for phy operation below, --=20 2.49.0 From nobody Sat Oct 11 08:26:22 2025 Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B036E282FA; Tue, 10 Jun 2025 21:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749590755; cv=none; b=GY/O61MOsem1/DRb+g39BLDEr66UOta4NK4nyXOf0BI+OgCBVCZjLmAh0dr+H24/mXCQqvtHdK/s79gugP81Drk0xY8JSFeT6ivW6mIByss3s/JXrmgP2H1eXL+jWL4y6OP//HOWCjs7dlypdFITFJZyeFBFwBkjHp0ebGshSDg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749590755; c=relaxed/simple; bh=DzWuE22vL1YP8zSHbfP7Qpjs9nzrUqlrq34nmlb01RA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PfCPq6MRH6OsG2c/IIoTW1XJuLKWTsDozRkpHS7yJdCfwjqytj1XcFcSf/G5YZ6LCpFv2Hq2pPp7M7w+JFZpkWH8lYTkGd+oQCUXdRM6pdnRVFzbE7W7hdEyH2O1LceuZe/qa4zYBZOYmaI3L9gS5W7WJv9WPiuTlCzlhcQ/3vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b0y3COLL; arc=none smtp.client-ip=209.85.222.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b0y3COLL" Received: by mail-ua1-f50.google.com with SMTP id a1e0cc1a2514c-87ed3b792a2so806404241.3; Tue, 10 Jun 2025 14:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749590752; x=1750195552; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4uBBexglmDg860eeLxvF6Ft+pxKPH1DbiU+A4sUq4Hk=; b=b0y3COLLLk8x8IGGD7UFW8H8bi26veUY31gGv85iFxL/QeGFX5XW3+uW8rQk5up3pr 8/nWOcamueAbC92ogXb8tlkp6UYFQz+9rFugAT+/AfkrFPuthrOelR4JnWyLDGb9TdIU dS83lKbuO2kfJuDOwrUPiGTxmmc1kglnbuWvohspv89bA/7z4NYAsrFShgYPa2ERUfy2 R8MgtZPO0CM4su0hxAiuo+wpb3pAhVe3aHzipdYpNzANLT92e6gfHXZTBFVLXDqvoA3e 6lCnU9L/U8jeulx7KxEeHM6tqnucBBINK7snFSzZpAY0zpW5paC3cIZCZr5PoMVGUA01 3ntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749590752; x=1750195552; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4uBBexglmDg860eeLxvF6Ft+pxKPH1DbiU+A4sUq4Hk=; b=PQuim3FOFBli+bFORnUje2Wvr3br2Wq55sMEigan8jZMKviyPG7q9ftFqyKb+6X9xr FiLK8MHEjgiTycscQ/nfKKf6AovhGl809EwVNiWY3lKhY7OWK7Jy0ehzgo2fR/jIF6lR AEwVCuHCDPc5B5VXL4sFSXfkm6OOBg9foQmaq/lqzJChIT5H/F5vwpAUuJLZ5iT00/Zv S0nRJZbvJ8+CQswvXsVIwFVsjMy0HmaKrXz2KjI7wza5xf9bBcly4LBFLhC6MZqsN+5o SJFWM/986pZrk2+FZFiGFIgAkt1FReBOBjcZHSlhDUTDfQ7qxXmcHTPAUdOqyjFTQPrG zPsw== X-Forwarded-Encrypted: i=1; AJvYcCVhCIm045SqhBVP7clPieU3rKpxGgWSahpTSsm0mCYVNGCxbPqy8iTszYBg/YQUkB0b5w5jyLu40XjA+tk=@vger.kernel.org, AJvYcCWp5MUy+fHa+V4lKTfAZaV9AxcjLE0BnV9SNrLJWP+rXVpg+KoYkVqPIWXV1A2Kk55PPnXF+/10xHkG@vger.kernel.org X-Gm-Message-State: AOJu0YxcOoml9xXfknAll5J22/zL70iEqnyouHqM/MrN48lyHoiJAe4H GPQT7eLehAE460V4a3Rqw/K4O9PR9lHF1guN4CC9EGP+HdvmnTo0bHLL X-Gm-Gg: ASbGncty93CjUtTF6uT/SXQN3hcOz4K9+Su3QGKnY2BILOb1M3G8pK1X9Qbzw3HtfiF kWe41kZibI+i23qYfVpRCgVvnmq9ZGxHZqBc9mOB0Mz6Nk6ttKvsTn2IGYKp2x6sCvvbadvRSc4 MectXg2O8Xh3uST+0doyhSW1dgu0OgaEhgmGAHt4kFGF/zBlzJ90f+c+qHx64BCNUu5ZKEQumAB bmhwkSEukOp6d5PgPCKmcgHDWMRiItUBvhy+slpioavSkoIrVqk9XEjsQbZlytWduY1WaSRnxzM AlIfB1/pdSue/zy1uIPMAwfS3uM6BtoYxwrhIbfWZIAVNXqU1w== X-Google-Smtp-Source: AGHT+IEYCVf9ZTSqj5YgISDZOrt+1R+QNbwbWikBaMK6UitqswT/0tSQ42AOnMjbILWu2QKm252CUQ== X-Received: by 2002:a05:6102:54a9:b0:4e6:dbbc:16d0 with SMTP id ada2fe7eead31-4e7bbb8d8f0mr604930137.14.1749590752616; Tue, 10 Jun 2025 14:25:52 -0700 (PDT) Received: from geday ([2804:7f2:800b:5ce9::dead:c001]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4e7bb030493sm356549137.19.2025.06.10.14.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 14:25:51 -0700 (PDT) Date: Tue, 10 Jun 2025 18:25:45 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 4/4] phy: rockchip-pcie: adjust read mask and write strobe disable Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Section 17.6.10 of the RK3399 TRM "PCIe PIPE PHY registers Description" defines asynchronous strobe TEST_WRITE which should be enabled then disabled and seems to have been copy-pasted as of current. Adjust it. While at it, adjust read mask which should be the same as write mask. Signed-off-by: Geraldo Nascimento --- drivers/phy/rockchip/phy-rockchip-pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchi= p/phy-rockchip-pcie.c index 48bcc7d2b33b..35d2523ee776 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -30,9 +30,9 @@ #define PHY_CFG_ADDR_SHIFT 1 #define PHY_CFG_DATA_MASK 0xf #define PHY_CFG_ADDR_MASK 0x3f -#define PHY_CFG_RD_MASK 0x3ff +#define PHY_CFG_RD_MASK 0x3f #define PHY_CFG_WR_ENABLE 1 -#define PHY_CFG_WR_DISABLE 1 +#define PHY_CFG_WR_DISABLE 0 #define PHY_CFG_WR_SHIFT 0 #define PHY_CFG_WR_MASK 1 #define PHY_CFG_PLL_LOCK 0x10 --=20 2.49.0