From nobody Fri Dec 19 16:00:57 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EABF0269CFA; Mon, 19 May 2025 08:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747644742; cv=fail; b=fJnB4YRKSHACSpPv2HgdXjvX5/ASgul6HrqNc/sgd/Wc1GorvlR5PAVB8QH/z7+lzTStmzYjiLV/9twoKnq8aw3g4Hsp0SOIW1cnuKb725eiPUuc22ZrAwwiZr0aj8K9K2vEIfoQfqV6cboJTBmqWoYPavUt4mywY+h9HmNoPrI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747644742; c=relaxed/simple; bh=LlumqDS1X64BsB9WZszh9wkGe3/u3pDj2jOFnF8WEck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=HV/8irCGrcMPslKLeUM3GaEaYauP+Xaz6Eka7zu4wXYIukzuxd3dUq6Zh8VAS1GyQcnHmROEwD4ixfHy3mBkbbrv6LtBRsl1omqRj8Ooauc/7/FBqPw/9x7twBW31MppV+5NVrLvAGR2Jo9qojma1J7Gj5wBbK252PQLfJzanZM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=F9cVF2Wu; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=g7F8JYmc; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="F9cVF2Wu"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="g7F8JYmc" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54J6inq1014394; Mon, 19 May 2025 08:51:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=b3WwCx9vIC+oWToFcblKf853GaMK1ks7LA+u+ZNeV78=; b= F9cVF2WuFIPIsDhMPHnvcvm+IRjyC8ejb2PUXl8JYshr4dK6T0TZGKIVxv5S4KyN jWiz+Hk69Kru2m+zvj/Sn2dp9kUb2bOPSmVjOIpMrX+YWsUBZkJiGvnO7LfCJ/fL 4Pm+alH7YXJteO1jkVVExwpq2LRhb5L4dGpdchQePplGemFURqzXv+PT5Kb92xsK QsEIgrmc2VlRt8ZdLeYgJsOLFabCCIS1+6A1ng57eD7pSS8yLg9+NypMdoyNvLfE VACucKEorVXG3pkMv1IiavFkelZ/wcAaAdZQk+7GkAyFfpV3+gcBzIXUVKu3KcoX PY6Hb8mQeKGAyGI/ryjD4g== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46ph84jfqh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2025 08:51:59 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54J6tH1x029255; Mon, 19 May 2025 08:51:58 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46pgw66861-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2025 08:51:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vnHV0rOFFRhYpST9JRbX3X/y5MUNJOrI/CVKib8M4WVp/+kZ1540MVNj1sMjLKC065hoLBWsWmfUAsAretp8heAfDOx7DyjXyu5GujnSRz95k8VxRhF6zmw9Q9y+eLIC8bpy1eD3Kk3I9SD4nP4d6wQOjuyciil4hijPjMcyV25+pg3bNZSX/5OHcIymPpnwjrZGiP/Ifn69tNXxj0o7HOTiGwAGFT+nXt1eK48j+uQFJvHspY3C2N+4z+4gm7puBkRxUyx4OidJArWTBSMWUmAMJ2tWCctt4j2WaboupvIZYEuM3ZV+ixgBMT/njv0fE2MNfAoA980wJ5JKfBRZEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b3WwCx9vIC+oWToFcblKf853GaMK1ks7LA+u+ZNeV78=; b=aKYaIke8blklOeRL4DPgzrnt9OTd18fv7k6/j8WHAxigV/5Geq4lQogMdMRgtVqvtmBbDMgiGCO7A1FKiUqOu/glTjgtQfIEuWrlE2qtVA+Nl3+wB+NcnGF+jC31iBFr03ME6cCxM49SwBII1svZHm157OG5NqgajGH5dXczj7HQxrI/TTLvmBYhwj+5ktn3MQW4m7CTV+uyg3rVrd0MrsNUvhcXsNHutipn/shSGod4J+Knl+7wlHcnRTYIKBVxyrsQZd4PS4LqYcb9u+zPMNTPme65t/k86u6e3D7njnvHMVqfy0TbVQ5dc19c5+kMU8KOQDK1iF2XyI7U927q3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3WwCx9vIC+oWToFcblKf853GaMK1ks7LA+u+ZNeV78=; b=g7F8JYmcC5cZtiltww7fnPzRf44J2D5PDLtZZTIZOGoPwbxg0JK4xOQhXD+pDR0R7IoiZ6jmGwOAxu1r65/G55GY/WmE6eawUaqvjXTPQEKkY8X6aTRmt2/4FQlyt2gBxs7BEx0kFjkaoXLyEMwYUak2jIt9/hBhbiRU2FoSL8U= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by PH7PR10MB7767.namprd10.prod.outlook.com (2603:10b6:510:2fe::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Mon, 19 May 2025 08:51:55 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8746.030; Mon, 19 May 2025 08:51:54 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 1/4] mm: ksm: have KSM VMA checks not require a VMA pointer Date: Mon, 19 May 2025 09:51:39 +0100 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO3P123CA0024.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::7) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|PH7PR10MB7767:EE_ X-MS-Office365-Filtering-Correlation-Id: a4a47726-9fdc-419b-034c-08dd96b267f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Txe+Z4cDIv69/fY+qSA+NfUvrpEq63pEiorhnuv15051cRBKsnDZzm5UrZK4?= =?us-ascii?Q?IM95R5Gtu20lC7nwVJ1sV5A6JRthW3SmDToaZo6BqpRGJAnDfLTiS+QQJcGH?= =?us-ascii?Q?kTB9vnTKSAr/n9NHV8GSoGebylBel77dvWMT7Vm49hUfE0pSE10ksJBh7bJK?= =?us-ascii?Q?dseTfrl47zqkSdrKywuA8SX+ZGQZfpVwW2Stm8FzPsooIrTPc2HxPC8QWYqP?= =?us-ascii?Q?cApf0rsS4PXOkAFXin9czp/NIyKKvg3i/k12+byqu4dtrTsXxq0xnnmH+mkv?= =?us-ascii?Q?r3ZLLFjjTsiMWiw4ymJB9F+Ic81mRCR8NFQOjYQCRpx1b/tywqW9kBuPFpgB?= =?us-ascii?Q?ZeNnqZ6DJqwWb7tY0t2d8UkAspBQPzUK3u3fM+xB2NE0gCzVOBtiZFvky+i/?= =?us-ascii?Q?UU5h0oYu42NTdnhpLvAZqWN5De/Im/dmujAFWkpuiZvxvbcXWQ3Bz0VrUUsA?= =?us-ascii?Q?l0RXksrv7oZTqQ2KKb7o6csJZ+FiSA/AD5RGV9lRNIuRktnXaTrV0oy8xGru?= =?us-ascii?Q?Doi1MC2uSsksrbZIYSPJ7J+7+mxScM03xZEt7H577VhhOAtZZtuwGOcCCp4N?= =?us-ascii?Q?CCOjY2aWExR+hEqFHMVkBnJguOm/HoLmU8Xut/W+0DHhvSnsE9e2Q6+znD48?= =?us-ascii?Q?srIkaTAl7A6Co/E2qv/de6PQcnyDbyB5Gvg95MwfV4Pd4gTrm0hioeZfg288?= =?us-ascii?Q?/xtHAPDxX0Ydqpko6VPS6hKfQ5T9qODXNoK8V/xZhFyM3351Bcl+5IZ9TFvm?= =?us-ascii?Q?Iypcl6I5WkTlScCSOi3WwL5mNvxSXOHOr33kGB4Yz8lcAybiEViYXyobeunG?= =?us-ascii?Q?nr+55rO7qEj5BRAPSBNgrh1V4qTVzoGe8ofDwiClAe+VfJY+rW0wYOP53l23?= =?us-ascii?Q?PM0kzh7LXmTv1F7TYPsk5FT/JCPJu6BPIRpFO1o+YFmNCW8PRMbhKumKfDSk?= =?us-ascii?Q?5VbNm5aADkJBWqSISzXyPk7lKoJ0n9CkNoUXfXkjVZvHgcP9KqogEwgOP+mC?= =?us-ascii?Q?yL4icyQNbmay7pjJ/+SnprWQTD+HX4BNCKG/IaLDtPUlpS4VynEasfirCJb0?= =?us-ascii?Q?56LKBVClWNPZBzQIAQ2aqo5/8UtOR/aU0ewcwvhH0m7Cb13PrsUfHI6Dj+hm?= =?us-ascii?Q?lPsuNtoMWaS3/dxWBaKJ7MtNcvOjlpvFuo2BxokWoGvhF/pDMfcqtcvNhALk?= =?us-ascii?Q?uW3+qiicxKXKkYDCM2eFI6j6WwVMqPiHS8ShZxttm315b17pXK5ypJxR1QN2?= =?us-ascii?Q?oNWqOX6HkejqIy0utATlWjhU1R4sTxQGcjznHb5simIxbDuM94AQKTD367pp?= =?us-ascii?Q?CvuZSSR/P+PpvSBde8nH7ag2kmf8gq+rF3AIg1wcihLqtk1w8+vtnidhC45F?= =?us-ascii?Q?B1cNZ+rCBaJiyDSbh81TOzcfVALbtH0QCAYvj/RlhvSzmNh3WumRX80HMS3t?= =?us-ascii?Q?w2nQPiyoZ48=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WafnMrx/4nf/flgdnDoTl2xdjFK6AFWEsbkNAig401g65bgjTWXSjwh0LMbp?= =?us-ascii?Q?B8lyYxYUjgyrTCr4TxWKG4CftN/bhOqYWcrsXys8aSFBsdeUvoOmSM1POjE4?= =?us-ascii?Q?BP6HW2wa2a8UHXsYeJXQbaXOI6HV0r50xJPtSROzlaIjYErNu8Pu1gmKSwgy?= =?us-ascii?Q?E4kNCJfvwzsN56Q+pKHQA5xg9ORHb6eC5H4pZBYEZ8vMY3aLrQS2qXBFuhi4?= =?us-ascii?Q?BGyZB6JUiKuy0t8dMSJO+PZ/HGGEjqJwOXWZPDfuziHn2LvngBEUiAXNLnRA?= =?us-ascii?Q?dZ1shMLrGSzUlWbLzrb4LKVHWpvTmVY/ZfFUBDuJo286/ebEUC1sa/FInd9N?= =?us-ascii?Q?pYiXOH7NSQVhyqj4GDApeJJMUayJsKukQI+BnWYejPxJwvV+pAJ4G6sb89QY?= =?us-ascii?Q?uqpWiCaaErgaPZ52U5oeEp/D9hg7z5f2vx+DDpqF9fzO6n6dPYpGNriofyYT?= =?us-ascii?Q?8yj7QryDStKY+HpgyyQwpVmA+ck3mizYlitwuDvIIN92IiH+23/sl1cybrzg?= =?us-ascii?Q?JzC2Nx2ngc2vyp3KqN3CKw0ErlscE0lpqiJmOXqN8wSI4qNJDR21Jdksw9IY?= =?us-ascii?Q?vMx2CwjQfL9aWAaYovav3I4XxyPVyL8glHqpznjVWFecF2s9zakrBU/Z4gyS?= =?us-ascii?Q?CjAPTnyfKpGm2cEvwFnr6FlMsnhx439QztImz5LiaNHsro3s43pIKHku7ji6?= =?us-ascii?Q?Gk3GV9MUGXkPeN/25ZxS/7/XWZNsWI1ZUmXgNwS5GrrPVCXqjGBQm993OHsN?= =?us-ascii?Q?kDsYiRoJFBg0dLgUetolzrsDzln6dQ9ITc/idYWeiEHX+d4RqiV2KHtlh05W?= =?us-ascii?Q?5n5whgScv15iwmrvsOEcl6Z0GP5FaG3KKQVlf71W2esiR4l/s32npdyweeHS?= =?us-ascii?Q?ESUyQobM2tNUh90flhUywxE1X9nQ6ibOy/T1m73Wr4MK5juh9Y2P5CuGIq0z?= =?us-ascii?Q?h5fFhxsbeqRUU7cAmY7NxyzSU+82b1zrXMq3C7McMNDDX70IIzsJXlLr9gtq?= =?us-ascii?Q?Iu8AMWNTTfI8qALRwCsVoSPSxCuInA7AeCcAz7efDxa96rEpfwaW7nlZ12Dg?= =?us-ascii?Q?GMwGAjnKQQecuCthzjOE+oOWlgljGRTqu24cp//xir/rBthdQ2VYynVSyEme?= =?us-ascii?Q?2zS8367ODhbPS+2OfqWac+wkqKV7g0SU/4cX5aBvNlVYBSnAUkjnoCTIIFlU?= =?us-ascii?Q?6GppkpkQP3KkkRjfCHor/hZ1oeHHN35Hj+f4YCmBNnipqYo/X/qsaRlu7HAq?= =?us-ascii?Q?26J8fx4QQDP+bIS2vMbt3IHcuMtErG0fYWdiS11yYnXK8G3xxH9Koz9qB+wt?= =?us-ascii?Q?4EktcBN4CHhMv0H4J27S58b+f6d7EKUn6WPEOSrT+Xxinb9Ml8GAOMOnXygJ?= =?us-ascii?Q?igxjkUgL9+5YBPf6GZBkd0N4x/FgzSBEaWQeDMEgHYfLSWSS1EzlHz9Mg4VH?= =?us-ascii?Q?22PNjmJ3qt/4hdMIrah1EXkcQgcIeas+N4vKsgCYRL0YZvO55klrhKRWFIXe?= =?us-ascii?Q?uZMsgPFrFFRW/slAlcidDGPDuOryMPSU5Fr9MjyECTwlgx5QCPb7UMoK+arX?= =?us-ascii?Q?oBhXGNKtH07YJbl0eu7E6vl/I3LxigBfQDk1Qg5kbid7mejcWFx5agM0+WPh?= =?us-ascii?Q?+Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /eFr13yyK634mm0KzOaHBnyKNkj8+AmgHiUd1fUnh+jJW79Z20jQLNsU7iGdWxQkEz9S1hlYVDUaBEzmu4y4YeujsrYm6dxrr79KIRKhms/E8LUXd5vzoFra0RXyk5KvVnGn1c4nZqQI/yW9Q20pxNh08aLLhXsnqYaZZSjaFY2nkmcIJikyOAipzsxcf+yd8DISKoYdQgsmvRmwtAf8tyw7Gs8W6KjU19ksxl5tZ6Bp8KaWd/FDwNxgByB3NwmI6dqLNKzeVOr7ete33ULJMeSrDjc8Qwz3Pm2avLHCs2N6JsZWhI1UE++i/oBNTtwY/W8R8e/Xot7QOU0deJentp7tKvtO8W3IMdYSeS4PJSpL/4dPS0zM0rDb/kN3dWfRvkY3RSet4hHwwWbrL4FWkGj3DFtjSzTGkDtNKazGSRg35zUDZ/02Vvd1i6WU/09EfdfC67bbzWLP25tMsyWhHAvUc8yN+ljSum/tASHhXPlZbUX43OLbnJlSojTOrYgN8yh1fGG7B+l1UcvuBLSGrU/dtYOgaxp5S6l9uCSEl7Uqcp6tb3KiP+AMMLj3xyadzf+E8SmA9GSn/p7Vz0U7TVfy3cYtrc6n9IeyT0+TPhU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4a47726-9fdc-419b-034c-08dd96b267f5 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2025 08:51:54.9551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LVeEy27y74p02pmWjxu2kIq53BXzJp0JBocsFokgeJIAZx29Gfrpj1/bgdhN4R1GHsrCLRIjsKYKXuagZFgNIHpIVA0IeP+a8osZIlD5nFc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7767 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-19_03,2025-05-16_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505070000 definitions=main-2505190083 X-Proofpoint-GUID: 6DyrqAqxmUnXm2FFQA_edAxpPh-1hBo_ X-Authority-Analysis: v=2.4 cv=YPSfyQGx c=1 sm=1 tr=0 ts=682af12f cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=lOzPg2vIf24U1BXouUEA:9 X-Proofpoint-ORIG-GUID: 6DyrqAqxmUnXm2FFQA_edAxpPh-1hBo_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE5MDA4NCBTYWx0ZWRfX1gVfF4PX94fh OEQeso2rk5Fm7f/uEUFrJKjdhfhZPjjey2LdhqgOwNSYbMiTqiUwWHi6iD/g6417vQZvi3RXpCS iRiyblPu97RFePAcXnX/V+RezjdKbE2WDa+rsmwSCyTLoMdI7bQS8OkB2ETNsd7ZhuX8mI03RzY ZxSm5L9AxFqdAlm/22TXK6k0jMp0+9Pi4bxsvTGGX4MLqVqCpA9rLxCM9WylSa1R5+fQQi1Zmh0 bJadlQQpKj3H5E3Vomp7TLOmRRFMTSqZz4RzuMyXNYPEBorKCGKMkZ3xV90MXHi2LrgSJEqvnDN H0asUHqlawJmRVFmLOuaoCkhfegK6kAINDH4+5BDM+bGfznM5VK5BtyQTitSzWJniNqOkp7Y9O4 UbvMX8V1zkixHBnTqjPoRbPmRyUrH0fzKuDInwlZRNLg0/yxSjA8dKwBsjafoKgsMmdXSlNC Content-Type: text/plain; charset="utf-8" In subsequent commits we are going to determine KSM eligibility prior to a VMA being constructed, at which point we will of course not yet have access to a VMA pointer. It is trivial to boil down the check logic to be parameterised on mm_struct, file and VMA flags, so do so. As a part of this change, additionally expose and use file_is_dax() to determine whether a file is being mapped under a DAX inode. Signed-off-by: Lorenzo Stoakes Acked-by: David Hildenbrand Reviewed-by: Chengming Zhou --- include/linux/fs.h | 7 ++++++- mm/ksm.c | 32 ++++++++++++++++++++------------ 2 files changed, 26 insertions(+), 13 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 09c8495dacdb..e1397e2b55ea 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3691,9 +3691,14 @@ void setattr_copy(struct mnt_idmap *, struct inode *= inode, =20 extern int file_update_time(struct file *file); =20 +static inline bool file_is_dax(const struct file *file) +{ + return file && IS_DAX(file->f_mapping->host); +} + static inline bool vma_is_dax(const struct vm_area_struct *vma) { - return vma->vm_file && IS_DAX(vma->vm_file->f_mapping->host); + return file_is_dax(vma->vm_file); } =20 static inline bool vma_is_fsdax(struct vm_area_struct *vma) diff --git a/mm/ksm.c b/mm/ksm.c index 8583fb91ef13..08d486f188ff 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -677,28 +677,33 @@ static int break_ksm(struct vm_area_struct *vma, unsi= gned long addr, bool lock_v return (ret & VM_FAULT_OOM) ? -ENOMEM : 0; } =20 -static bool vma_ksm_compatible(struct vm_area_struct *vma) +static bool ksm_compatible(const struct file *file, vm_flags_t vm_flags) { - if (vma->vm_flags & (VM_SHARED | VM_MAYSHARE | VM_PFNMAP | - VM_IO | VM_DONTEXPAND | VM_HUGETLB | - VM_MIXEDMAP| VM_DROPPABLE)) + if (vm_flags & (VM_SHARED | VM_MAYSHARE | VM_PFNMAP | + VM_IO | VM_DONTEXPAND | VM_HUGETLB | + VM_MIXEDMAP | VM_DROPPABLE)) return false; /* just ignore the advice */ =20 - if (vma_is_dax(vma)) + if (file_is_dax(file)) return false; =20 #ifdef VM_SAO - if (vma->vm_flags & VM_SAO) + if (vm_flags & VM_SAO) return false; #endif #ifdef VM_SPARC_ADI - if (vma->vm_flags & VM_SPARC_ADI) + if (vm_flags & VM_SPARC_ADI) return false; #endif =20 return true; } =20 +static bool vma_ksm_compatible(struct vm_area_struct *vma) +{ + return ksm_compatible(vma->vm_file, vma->vm_flags); +} + static struct vm_area_struct *find_mergeable_vma(struct mm_struct *mm, unsigned long addr) { @@ -2696,14 +2701,17 @@ static int ksm_scan_thread(void *nothing) return 0; } =20 -static void __ksm_add_vma(struct vm_area_struct *vma) +static bool __ksm_should_add_vma(const struct file *file, vm_flags_t vm_fl= ags) { - unsigned long vm_flags =3D vma->vm_flags; - if (vm_flags & VM_MERGEABLE) - return; + return false; + + return ksm_compatible(file, vm_flags); +} =20 - if (vma_ksm_compatible(vma)) +static void __ksm_add_vma(struct vm_area_struct *vma) +{ + if (__ksm_should_add_vma(vma->vm_file, vma->vm_flags)) vm_flags_set(vma, VM_MERGEABLE); } =20 --=20 2.49.0 From nobody Fri Dec 19 16:00:57 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAC85269D11; Mon, 19 May 2025 08:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747644742; cv=fail; b=hNTx1GtMLBnXDUy0UTlE2f/EezziQ38u050WDrXeNHr/eG9u3kG2MfpYBU99TWfBVSnVJ/t5cy37JZtAENPzM3rmI/UlE19yqwaa5e38ttNRf2VG6qlzX7DYe13snm42VEEmgUzUyx/biduKZKeRkYWt+lkeWSf1ZPBpSkPy0p4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747644742; c=relaxed/simple; bh=bF2HK27KdurzMzxGyQbfPDifCb72wN7fZMSRGjnnjAo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=p5M8wW7ght2oNygWLgRTRGkBjEVNNCj9MuFuL7D2BrdI86ynPo3LsrMUwVRQEY73MwKtsGG3jAW9S2p0WeOEWE4JyThKJu3vlEkjxXMYgzSZ4LavwEnlEyri261Qn2VRRGTCXhMSB2WPqsCsdq10yw8Akt0AYyeVYTvQPYWFyqs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=aWArihPr; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=R61s0WBR; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="aWArihPr"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="R61s0WBR" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54J6j0Np015330; Mon, 19 May 2025 08:52:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=xma754bO7EEQEtzMkNfZkJ79BK0CggajKNZMHwoYjV0=; b= aWArihPrTzLxEqbyYR2AEW8WrxYXjlmJ9G23G0vm4h2vZXcyR5PSM+fLz4llkr4Y l0UuWiFrVp4igdgRLoMwb4ouihrLsYF5M6/uWtggSap1ic0btuRmIkbn1Ft8nYb3 dhxl8JFQvHphjnL622+g2cq9BCLWPTNbxlvVxmvm5lWYouyG/GxaLTd+A7RwGI/E RL/FSFOql/Qa7YJyRAQM+NI8E5f32nuxUBXGkKfw7oh9HMbmNi2CMLfNHpijoIls y2Oc2C1YH4b+zeFIUTh3+KpFRmVBeeinIenUWYfT+/T4MJ0d567ozO0K9mmnocqL bdjVZE7ZvvAqwrdkqih8Cw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46pjge2fjb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2025 08:52:01 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54J8fwMN034500; Mon, 19 May 2025 08:52:00 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46pgw6drhq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2025 08:52:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eMMredCep5n5cswHmVM/wEfemm0g3SPH2qStD7QZPIrVVfx6qWfV5EecMlCdE+duGXquZZ4TFgFkGcXkFHG7D85hdgv69mg2lb3Ka2zrlrUocJ84EEPsNJGRXnb7kvR0IVg34rmhnxQxKtXxfsEFWKmmrYVq6GhRG+SkBRwdSf7D2NjQH3+MvO/UNnFQmBQmuihZCacQAncRjObU5mrujuhT+9wyBuUh/loeeMW9QlD67NzRxwKCFm57mCodZqo3DZ3plPGahc1dX7MmRMUAjSkJvm83YE37wf6WO/dqUHYORVyDew+xozhMSagXMf600u2cm1GpZNDYfSt7TfFKgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xma754bO7EEQEtzMkNfZkJ79BK0CggajKNZMHwoYjV0=; b=VHZZzWkIrbC82dkir3gnCfE83mlMSWdEah8dYI+WWaoUZTC5Ur+tl8iOAzJufkhDaS1sbObRyU8D3M3AYF6vuDZwD7g92Wv/actMrzoqZn9VXn01zAFNIWVh3CDE+2MGNOhGXOyGNbXeN3iMkegD21gH4WLTACRGfDkgjZDT3p6gW1eL032k6DQWguPCuSoUOFsFjdZFg65mDIezOI9lDQ1aN7JjbcNl/3SNu+/LpyglY469A+Y387YyUkRHbpE1NBHAFL+rzSBBus2/XkRZxUiOmESCwTVkJXUhT3Gcm3V8O75LE54l/2Jw54+cl7ImuqJ1fq8egP4SR6js+MAtNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xma754bO7EEQEtzMkNfZkJ79BK0CggajKNZMHwoYjV0=; b=R61s0WBRmM146ldzgndrB4waklnGfkYfdQgbin2CZDubt5taw5K6BmichNsWgbEp+3tG+t2mJROGfmfOYQPKWwhKaklaevMhQ4m6ATSx9Gb4d24lq0F6G0OcIKcpvCOtIAODiv4zeZyWo3h3KhZJhmFx3KMZEkYuhrsT7l4VAd0= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by PH7PR10MB7767.namprd10.prod.outlook.com (2603:10b6:510:2fe::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Mon, 19 May 2025 08:51:57 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8746.030; Mon, 19 May 2025 08:51:57 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 2/4] mm: ksm: refer to special VMAs via VM_SPECIAL in ksm_compatible() Date: Mon, 19 May 2025 09:51:40 +0100 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0252.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::23) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|PH7PR10MB7767:EE_ X-MS-Office365-Filtering-Correlation-Id: ebdd7a79-d656-45cb-4a74-08dd96b2699b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gy7piAI9NknkMCUnUAR8p/HRG1s+oIeawsJXArWpb/vVX5PyyaqHV63iRCkL?= =?us-ascii?Q?/FWOxqjnTP3+A+5jVgpQT4egih+T3EDXvJRfGCbtuJabrXzKgY9TmYEp61k8?= =?us-ascii?Q?SYkG1NiMSoGNNFCbNp8xZDz+wZuBFif1/YM5SkLVCNI45C7dcmk12t2R0Ebs?= =?us-ascii?Q?bBBrAydIFMXVR701JQpZzWtpSxnVYc5eaonu9ISz2UGDU+z26gvB+pBTzqeH?= =?us-ascii?Q?Fs886QBIcrDv32QClXxzHZp6I6DoowuHZF0qzj3L6lukvrE+dB3zzg5ETjgc?= =?us-ascii?Q?xVsQvTjvD7zyotp2bhfRVSan6SdONxN131c9LIzBQawbs2tG9FAp1zQAoZ+C?= =?us-ascii?Q?vhdvWU1yxZNXw+ISiwXNmBWIFy6opqR8ki0RM2VDcdmlOavyOlVfNkLz0Y8p?= =?us-ascii?Q?9ehOs5VzOd/qgMqrFCtArm5I5sG6by8xH5C35b+RfTi70k+YP2HqDLwO7LZs?= =?us-ascii?Q?DSZmVxdnYG0yMNdjlBaoTqn3pLg8yLrXTWZ7QBeKM/z8PJ2pp8r/6AnKFy5B?= =?us-ascii?Q?ov3baLFeeSfMVyTW1Htk5RRxIfuziRXmfij56u4FoPsCYoD35q/XFYqQJVYF?= =?us-ascii?Q?6WAJ6ov6wA2Q3RgZfEWf8VBdjIgEswTl7++hMGZxbMU+9xY+d1R9dR6uYfh1?= =?us-ascii?Q?wFgMcYZ054UxvuMvlUGv83txsIarXcFerja8dVatGfTZHJlzEdOPGxEPwv1H?= =?us-ascii?Q?sqt/MPIIP1uUTqlcvcSXD2mntUpFRJ4R0FeDsb6DbeBLAezocBJMpuDcOulu?= =?us-ascii?Q?ww1fTN65wTKLT/8xlsyzR80hNb1R0f/ccWcXzZmDcSxWhOiMM9HYJ/Cnw8qD?= =?us-ascii?Q?nJTgQ9On1fPD+xOi8/4E1QcXaS7EJF6LQXjph6vlphTEqO5hcw3e41ewqG3l?= =?us-ascii?Q?W+4f9nFgIsWkbqIHrfwFh4sl6k0Is4NyXdr9FLtfFg94lb+NBbrCr4KGwApc?= =?us-ascii?Q?gAf6ArSFypJe/ZuykLUETdzBHJ+uCdIKEpmxMwHJAzVrVNjkouMOE7nZVLGC?= =?us-ascii?Q?/vlQUd2v57vZ1yvozBLad3nSsMVGSUNzI75TjRwELbmfNojIyFmi78cXPhyO?= =?us-ascii?Q?S5YEW9xSin3qHQFvfkJ3AJM2yYTuHpdFLp+NF4Ks6OsFlOi1r9ZdvNd2TiLJ?= =?us-ascii?Q?vAh2braw4jVOSm4IaKBGhamorUyhe5UolCCEinQ17k0DsmLria4UWy1w9cNC?= =?us-ascii?Q?uj6M4Nd+f4ZQBQv6j/qI9vRzmwpGJES7ChwlV0s4EwBNUafelnlkoed9dVGk?= =?us-ascii?Q?odjOmJxbN0Pf1SWd6ntoadMsiSOCatHqGXPCdAslzcBZYC5H37sf5k5hLq//?= =?us-ascii?Q?Lo1/EfjCPIDq7eQvcTu3UMuT8JO20uVlOpfKl3FVwxFwrbFJvr7E0EfM82Pc?= =?us-ascii?Q?zIxT5kPn1W7+PjjUh3+QOctwX/wK8l0W/OVUcby77+b2lWvGuQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aXxv0vs695Vu7HJ4LhGiOTsuHxWQ7DSEpSV4+YzSaom7tmcgXruR6cS8wnRr?= =?us-ascii?Q?mJm5ASVycm2FDV4WDGfi4Wm3dVWmaNXyf6peL5v4HBueissdr7a3ZTl2GDp2?= =?us-ascii?Q?cc2LTBB+7lSvtSs7p3e97zr5rywqnKRrGnWSgZga7KDRIPKxF6NVQbEjv94H?= =?us-ascii?Q?Yw9AaG5YhHXUaYgYAqanP3bhQ9G1k4vwKa57CIkqXoYm9qF6zKiBz2hTNLSt?= =?us-ascii?Q?c/y+65NfAcO2dWiK1QnZ8k/W7mFlVIUBmSh6Z51NlBf5lqgqKe/VjOuiGgHt?= =?us-ascii?Q?uEH3pqEI+DlmHgTAwaQZFgd1JYgtJpSKZ7fUQInTkcBgBsYJA8TG7yjDKRgF?= =?us-ascii?Q?X0qWUwRc4F7xkvmo8i+gEMUWfiVbWFOF6emFKiBrKueuHUvZ5AgTEcfTOLIe?= =?us-ascii?Q?1j25gzNlUhg0HbSG+/+0cid7akNBF9SzWF9rmjikvBMOgJ5ma+k10lmiXpRm?= =?us-ascii?Q?ooy29Vb0x1KW1/7XzSQEknY2wryJqIARakkq4Zepi9mQWU7REREqh2cqc7Pu?= =?us-ascii?Q?sdNOQqB45LdX5jRK924irVfqtxK+xeU+c5nr+r9eJZCuMObaIr4rAgkW7C1l?= =?us-ascii?Q?9rr19ckls5qpRhG//Yqp0L4xCuOLmeDQgQJme8UuO1A7obcJreH2pv9ORHzI?= =?us-ascii?Q?kqTxRey5FpRQ5EcFnA5qvpyxANoBtIt8q7wp8rlzwa8yws+ZzG33vgJrZVoq?= =?us-ascii?Q?93HGSYpjp6XEgimn55bHU0ns9dLdHJQrA5oWaLTMR/08xt/JVKU0xO8vIopc?= =?us-ascii?Q?81f5qU2sS1tODMhycTifhXpaqnQSYWh6LHsOxISi0l22SFIEvB6rJbg8/e6T?= =?us-ascii?Q?o4lxbThlPoII+SzVhxgeo09wldAVKCT4ByORZZPxvKbwaGExMk4/5gmcd4FQ?= =?us-ascii?Q?osvc22YlPng1E1LHIWEMQ3w/LwRWmKd9Wx6TLU2+GmczV6pZrSdEIeluRs5p?= =?us-ascii?Q?Fe8kAGz4ij0lY4/k5v7wXmCrhChP4qs4zsGY0xmi0GCGpLQ3wOM/PqhRRnVR?= =?us-ascii?Q?J2gi0+1j/S2uWnWnwtgS8CP+c63VEtSm+37TIytPeSRsvZ1m3p5eYvck89fz?= =?us-ascii?Q?LrcwcM4DvEYyCeR7BrgzJDY/k5cS/3+UQJa4QGGvZ4DBtPtk9vIfstjCSyLN?= =?us-ascii?Q?sf66hxAZiREODAyHtQ4s+h7bvZ3Z4Hm7iruHizNjHipBYYrh+8j7kqfEQDme?= =?us-ascii?Q?5LJDpz70W0vBLwOU2fEYSFkdBxNNfUT4AUu9n7OyDo1Indp8jdsH9qNPGwoJ?= =?us-ascii?Q?6c8xp4QU1fBM7l3ZoU6QHgi8+rAm8+BSfb75jLeLzRHo+k0whMQLZAQC5pKI?= =?us-ascii?Q?XrcnPmKBoMRJDdfyHZihbLLP1s6b8lNRzE6/FYNERb+oAFa7/C698NqrrzOJ?= =?us-ascii?Q?GcDmBlFi+5ydHlzdzsg1n9NtALFasiU26Nsj3zO4oNk4C9foNQzB01CauE9Z?= =?us-ascii?Q?CtRq5NWVHQMc+iMKqmFKQ8DOwYJt5qHbcKHghUuEKiO8Wp67DiT3rV9nCW84?= =?us-ascii?Q?ArUR+dPHCrv0hKSoiKKq7m0G0yZj/WplGy69NETEGvSfy7QrubBrh0Y2Ej0t?= =?us-ascii?Q?ZJ8RSI28I96Wa0gqKn6Ec4QmKH1qNLri9nAC56XFq7a3DJ+0ec7mtKK+B/nT?= =?us-ascii?Q?gw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CEo050ffI0TkZWLP/nA135U+JkC3pEs4/+OEzmvTCpk7eWi2kjusU6xS65ef5rdcbwr1QdgL1smNEUlZnSjw4dylvJ+t8Pq3bPREc9aMbpk0kzjks2I//RXbq6br+LsKpuxJWjToiYKPUEVBSY45E5rPpn1o7h6VCvL4Yo0A2mStyDd2tgJApzJAOl6dwEAxz7pU5klEUNIkuvX2KSUEM7yGt5Yl/nBbDDJQcS7YwQk2irEhkwSzD7ls84l6PBdne8Jxm4H9ubS5CwcHqwHHP6UhF7pjsIKFr7K0IIP6eSmnXEu68fjIyk2IFlXBORsBvNimsUi8n7Lc2ajdlPVlhZAmZzWUnCu9u5Nxlf/QRQEwR4jFvUhaGpxWRM4Pvnca9BE0lnv2NFEXvGFnmLnz3Xui7ryiWvQj0I3VF9vmaNdPnUDLVrdOtUF/5Pskx9W/VJ2T9sU/6AE8EtN3hUC7z8VltV1Ldz6hUXA69B1R8T5iXu5HBy2jaHhtVCAMYl9FimpT9PzwGoJI0/DqX8yc4gguhzllCTuu3UxBPh218ZedvxYmPPdXdpQHWy/yGb/JIcrYWIY2Iy8UBqJ5AtTARhSPmWAvb8v9it0PC1eL/LU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebdd7a79-d656-45cb-4a74-08dd96b2699b X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2025 08:51:57.7227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ObLs0rjVJ7rsXiwhVgXAmWpO2l4jyVvWY4kJ8Dod4E2unOO/c9emjejbxH643BGAG74lKOR2ajG2/id5Il4a0Tv0j93OQC6p1DsR6U9St8s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7767 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-19_03,2025-05-16_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505070000 definitions=main-2505190083 X-Authority-Analysis: v=2.4 cv=RamQC0tv c=1 sm=1 tr=0 ts=682af131 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=JCz4esxvuu-7hMN-IX8A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE5MDA4MyBTYWx0ZWRfX7OweDKHQJVuW 4I/eStI2nYTXH+lrP4MV6yy2bqIbKeWX65Gj88hfAv54UAgJYFrY119dt9OMrnSaCKcgfA5VoR9 MePbPhXgkwoDy/bCPrGj9aX39Yufbgz7JJ/Cwt7D6jmvL3pazvfNfKrWl3d6phrmEQPcNcr9ykl cLNAbDOSbkiijYVPzCsR+pGTg+Xs/XbhgVAAOZyxTG+Y/QlrO3VYNv+f3N1htt8d8q1leXNzPic KDjiUNM5PZ9jTkBSI3ZmqburzgCxBxALA+W5GwgqA0885N8rcyhYCxCPDkn4w2V06b3qiy2w8iz VCo0/T5Dp9G7hcUspoNvm8rp6VyrrDXt8dW7PW10V1Ihw8HtCuv6X+YVP9B5e+f0SUgMZQ/TZ+H pbZIDURlZaQ3qBxjMqp9yKEjob0Gbok+q4ODeFEBHg4CG8dEZVRpFaFRwfYD2Id527xwXs7G X-Proofpoint-ORIG-GUID: 74Kn8q-GaKAvSGornKjJs4R-aHyevcSg X-Proofpoint-GUID: 74Kn8q-GaKAvSGornKjJs4R-aHyevcSg Content-Type: text/plain; charset="utf-8" There's no need to spell out all the special cases, also doing it this way makes it absolutely clear that we preclude unmergeable VMAs in general, and puts the other excluded flags in stark and clear contrast. Signed-off-by: Lorenzo Stoakes Acked-by: David Hildenbrand Reviewed-by: Chengming Zhou --- mm/ksm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index 08d486f188ff..d0c763abd499 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -679,9 +679,8 @@ static int break_ksm(struct vm_area_struct *vma, unsign= ed long addr, bool lock_v =20 static bool ksm_compatible(const struct file *file, vm_flags_t vm_flags) { - if (vm_flags & (VM_SHARED | VM_MAYSHARE | VM_PFNMAP | - VM_IO | VM_DONTEXPAND | VM_HUGETLB | - VM_MIXEDMAP | VM_DROPPABLE)) + if (vm_flags & (VM_SHARED | VM_MAYSHARE | VM_SPECIAL | + VM_HUGETLB | VM_DROPPABLE)) return false; /* just ignore the advice */ =20 if (file_is_dax(file)) --=20 2.49.0 From nobody Fri Dec 19 16:00:57 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3547826AAA5; Mon, 19 May 2025 08:52:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747644747; cv=fail; b=R+6RtSV9buPjB+uxT0LVnB5wVGB3jVrs6QwFRuaog5TXH+tA1BdDLRlkxCPntUkjB389hWE/N+9hhil6sUS4MlaryqKBmdyUeTLt7jEJpHJvkjb2xnU5tXPs5COGrDmSxDPqR+0gzFqDGS7386feLgFk/vOTy4f+V5ibD7jLErM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747644747; c=relaxed/simple; bh=kRN98GNItL+O6Vc25bt4ZCyGrx+jD0iVVDXevj9+PAk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=D4y41egfWRn73HhDVDYXvSL6gDBPglY+GDBhYLCNVmgDa2jf6ObTHnPIZ/CSQVanNF42KSlWXsD3vblJE40npTMPzxaf0L5bnoRuEIhd9RrqVd3V7DsdGimSpGfHusfkLDTSoAx1wVWVJ1bKBTQCUcBKkdQdPgdKZW+ufjJri2U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=fuUqK646; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=yPBSpsEC; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="fuUqK646"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="yPBSpsEC" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54J6imkM024963; Mon, 19 May 2025 08:52:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=8TuWYa+9z0ohzDM9mYzEITFvvLHSnXGgRsnjyKLoJJQ=; b= fuUqK646r1K9A0Sxesh819GGEzg3K3wqUvvkOj/mPLHa7wGK6UtbN4BbWxoxIzOr 4pcQ/0chwadGgAsdB5u4HU6E6q19mMkmCXbdEwOwP1zB7/qZE6OuTKNKPFK6bhOx DbHvsUGAOXiCSct+vjPJ8/X/f7iXKJ1rCh4yJ1nYIhCHDZGIuJ8MkySgMRN+ZxEK 1EUqosqQ93VAJYx1mSarcApxdlORQoaPEHB3FxoS+2kuJ5SNhqDuDGrtcB917XuF NH5WG7Q+wf0KKbam4yM8OOupleTHd0f/Ix/0CXliZxYGwVKYgmUo0K2sK9JSkUgu 7IR8Z/RsVDBqPDFSzgt8Yg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46pgvejfq0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2025 08:52:03 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54J7Y6QQ035236; Mon, 19 May 2025 08:52:02 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46pgw6drk0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2025 08:52:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SuB5uwh/Ym49YHhHvh8f3dKftCBhOAEOKSU0ia3Xr4y9exJ5ILI3S11Fbn5DnomONyRBFnNunAp4is6xGNOkFVBDFhc3TRoyU5V45nIn6Dkxk2is0xj9m1b+5aiWjE92qe0OZ/JspNfJ6RVBKK+tQbQTzJ2mfimNBaEply51oKM2MjQAgoNJHxxO4fA5xt64ZxjOqzlaB5tm6yY8ihrBpZHMb6BdjH+A2iw7iYm1cT/Mnlk4ssVoMl1hOhXZ5LToKD3gACVDWOk/0jXA+zaEe5B6ufhQJy/MSKGwIzliDj6u7VB2s6GlPrBVc3IYydUwy1fWsqbuU8VbpYcMyqxUaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8TuWYa+9z0ohzDM9mYzEITFvvLHSnXGgRsnjyKLoJJQ=; b=d2JAbPt6gUVPTVZL177HPj513J2r5C45/i3hj09TxwzAcM191u/J5ByQciQl2Sih+G6dlzVlILRU1Op89mS5ILgl37dwkKG9+D7afvKqEkLegWzYeBDs2NeWW+vYTJpf9RWvg2OeBFkUcLBCfsTQE+o8Mht0xOUmTl8B0iaOwlcAROvLfSu0N9/4aHJ5QWPuZee5XSJDQULZ7Ddhc+ZGZ+bDY3KOHng29Vn4k17q6IIslLoZ61ljCFZP6/ErLeOryQUZ0RFiuTS3g8rAxgFk+Dzsi0DQen6mF1VumdIQzNbnOeCL3L5UoLIAgi085f6cEWl+9lqagx3w6z74T4E6MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8TuWYa+9z0ohzDM9mYzEITFvvLHSnXGgRsnjyKLoJJQ=; b=yPBSpsECljtdUJkcDMK3d4/UxTQDdOMVyjjQYRCiGza8h5WcFkun0xrLjpcpjdtZLZKWbok3iWOS9WQ96nRiuH/ATGh18XOkc0WBnK7YQ7zZvjcvGJEy/BGqGgCNPBTVgQpb+wPfwgyNVz4b8P1k7to5LQwgY8G3w84P6nfr/cU= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by PH7PR10MB7767.namprd10.prod.outlook.com (2603:10b6:510:2fe::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Mon, 19 May 2025 08:51:59 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8746.030; Mon, 19 May 2025 08:51:59 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 3/4] mm: prevent KSM from completely breaking VMA merging Date: Mon, 19 May 2025 09:51:41 +0100 Message-ID: <418d3edbec3a718a7023f1beed5478f5952fc3df.1747431920.git.lorenzo.stoakes@oracle.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO6P123CA0027.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::19) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|PH7PR10MB7767:EE_ X-MS-Office365-Filtering-Correlation-Id: a74b4248-e01a-4873-e1fa-08dd96b26ad1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?P5RrJqK8/98UAwCe/k/tvf/s3GjGAkmdIbSPuRCJSfA+zgZPrDPSMyP9C3FJ?= =?us-ascii?Q?GYYHR1qX5sDrJNeq6x+i5KIImO4pAs/V8LxL1mAjHWUK9saWVf2Wjuu+O24J?= =?us-ascii?Q?cuiwYfWtd1ou3flisT/DSmuMQu0gPMhmrQXKxojzOUeUC3ArhdvQCI9YHugN?= =?us-ascii?Q?ghQEDAf71qMNHJybqYaR8Q6a+qRPEFKPSFm5LCjjUfm59hMKGsbiLpBwpmaH?= =?us-ascii?Q?tYdxk8ZFnGBucQQCGvUZ2QAYZxdeWEksX7ySGVE+egKGImFg+/mjOZ1heJ91?= =?us-ascii?Q?t1otQkliHJEByiqsyFok01jScKaJFFslAFYREVIR2/bQuAn5NTHppeuJrzos?= =?us-ascii?Q?I+FiML1fSnX3EEMwpU6a3fGFSTWL3WJ5utuHv3PlJAfnoOhdhI+da4BV/fG6?= =?us-ascii?Q?CgFr9+SA0SFA3IPOrx7VC83v0PDFyNdk980PWm+p1gcETviRH9gYjsLeh/qQ?= =?us-ascii?Q?On5R6cmelCwGvUGXhOouKNrlZLY7GItRlhtkv+kr5kuB5Ts6xSjojLrezO4C?= =?us-ascii?Q?XrGwKy/d2B8kI295fcsbdl76Bsxsyn6OFpvki3phBgc1qOWV9/8c3AC0bqjL?= =?us-ascii?Q?hHQdDb9RkIh3pN1c1fEkqpzXUoS0NfEDdhJ9Haw7W2v6DPsAPGF1qHwcuhJO?= =?us-ascii?Q?w8y7QNoQM7hLt958U+qQBDbdyzd9s3qPLrXMRKTjhyZvFtgDqIlUOYmM2zxN?= =?us-ascii?Q?R2ZCUNqz14vYJc7NKDUIWOWxwS+fBmrm6dBoTmLtunEm1Rfhmb7WMHM5MM8K?= =?us-ascii?Q?/QTek7O1431y2w6h2uX3eR5SpCT72FfYjjdNrmaWlhpS0F8CJ7rIo140yBVS?= =?us-ascii?Q?gYCDRYBPkE2CXcK+MLhpKwJsmHUlMXt8gq9pgeAjc7q3aNiBVKB04I/GAG+G?= =?us-ascii?Q?oKnnb6/vqesM8FDChjAEbEQkvoSdzZEbZ9ab8v34T4WTWxX8FQMZXk87zzLc?= =?us-ascii?Q?cMUrlYBjqKm2MjiC8FhCYwbnCztSU/TKoxU0c2cdwluMGc3I92NzhAoAsS3X?= =?us-ascii?Q?1pgN/9tPRa3WM5mli3mSPLxOUmmVbBiO9HeCJov4dcMlF+Ze9PWGGRoiT6z5?= =?us-ascii?Q?vzg/k+YL4mHNIfq3uhTaGUgaOw5l6iADEQf8u40mUMMLSEZHcyMMuhSGndW9?= =?us-ascii?Q?ykCk0dTaub/g0trm0rq9M9iL8mvE7fLWhM7K4MFGelfba6Dk9YbQoyag5X+X?= =?us-ascii?Q?taXTq/Ylhl+3UQOTUxytIdfv4EObJ7ncWrMwVKKYBbZHdJfoYRjXxWPlTqGs?= =?us-ascii?Q?ZqiFzezWtFH/j3uV+qb4r6FCAHjxuOKQB+VXLnycughoGClgAikdZiJmFfls?= =?us-ascii?Q?1nnXxjyXbXtKXtyBr98/grO0dUO0SuKc/nr8Ck99Y0araOvp8HGjhg9el3Ei?= =?us-ascii?Q?27gb5XcSFq18iTnU90i8IpYVxkkf1Ao0mg5KjLbhNzvPhZhtexTGViUpSc03?= =?us-ascii?Q?lLKs+rFWXso=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fntyi69b8jDFd2gTwOsCdY1wI87Vl2KLaP9tkzz9Huz7LflsL+7Ya+Mx0Z6g?= =?us-ascii?Q?5TiVPPwlwbep1rm97M3wqn8L9PzX3ib6uVIeBw82lc0igtcux1v4RTy6beos?= =?us-ascii?Q?BK8FaatYZDMNcyvPvWv6T1a2wcGba1Qf8Qi/ounmtFmMpcoGFqgeEUt+h/8V?= =?us-ascii?Q?eYkVEBbHZyQUrHJ2AwlKZbCuPeEBW8CLBUw1sPIitTXlcGEXbqojtmnWLLvv?= =?us-ascii?Q?D72Yax7LekUygeWix7LsKzLLjv8A5obRiYbo4pfSXMphT0IkLGs/mqF/bU1c?= =?us-ascii?Q?GxECFaf88gAokFRSMU4QuCWEJa4OAbC6+QNCUsAWS2bfBxYBW4/kjtttZLE6?= =?us-ascii?Q?N2GySShO0RBhY23fu6d59VDLY3PyztdRP3QKwFiYf/8n++VQPCsaj7Ey0Csl?= =?us-ascii?Q?pHlCkIEsnldFA5gTkjIkmFl0ToT4Pq7xlQ+9MgHW0QKFHWK9nHUgXMWm6nmB?= =?us-ascii?Q?O6r5e6S7URsVw7Y2zaG/ZU63+ExGkAwP837W0gZRCEf7WBBkaANuI840eAov?= =?us-ascii?Q?OgTttS4Hz9BQfHbDZ4b1IkrhBOtcln3G7K6bykSQ2BhIoWxBa8cXfQ6ARnxE?= =?us-ascii?Q?LU+4+TkcVtC/sV7673tk7o9fiz3TDDxf7VkumoF2+oYf/xryRS+pQvTuwQu1?= =?us-ascii?Q?bMsnJ49an76ld/8dn+Lffi42u5RA60tjJHFkTKE4ay1dIuGgG+CZZ35pLgyp?= =?us-ascii?Q?UWAjdS/Lj/+yKNqzeEgSM7k25PqWFA2LbQp3Sovap2VxXn+GNhPySMbCeS9b?= =?us-ascii?Q?GGbbeMTLhrs2yaawCzqGbsEWcKhCxchL7YI03XAZEajOOnEnadOpTnhVmSVr?= =?us-ascii?Q?yonasLDFF0AlF9lQEguWnVKrjsxns4jb6LwCYulRXnJZ0Gj8scvtYMklU5Uf?= =?us-ascii?Q?+BuIXvTzWHBSpn+3zn/yamAufeUjervkMZNMeFm2nafAiTYpSJITC7OEeupK?= =?us-ascii?Q?JTNFZkUV6qfDYgTLxfS/CtN6rPr2nY4AQS9rgdycUsuHnooUJZ9OfFURJIzA?= =?us-ascii?Q?sC+t15OJGAYByRsCKMMY7fA7EPkq2ky+1pSzUw2xjj4pqtR+22du2XW/1R/s?= =?us-ascii?Q?TxhJn2aCGPvg6wkzpU82ZeeGdbPNgcmKem1F7v/yJaSBOtdZiQ72cMt/v1lT?= =?us-ascii?Q?XYdk4EFL4djz94vCcn1z479dva0df6BsaeE7TNqX8gUqmsHo6DFgy8ojsu4G?= =?us-ascii?Q?rxtnRAveY/5g3lgE5/lBC4AJRo1uMWq9Udj10XUbgzY6JPv/E6z/ghHjbjpn?= =?us-ascii?Q?F4AysnY9bCcMWLkc+tqr4PhZzmzWmS7jJyEwSIhdHwoUQavioIiUi/Pkkqnh?= =?us-ascii?Q?4GwsVQprKE+k5W+zF0+EzqTICg5r1+TbnuM2y0aM2vgTF/vahJGPb9FLpT1k?= =?us-ascii?Q?duUpUOu2O0lAJxLoCnCybfd0VBCExcI+1/L2EFOBbvxrAqjP8gN7WNh7cAKM?= =?us-ascii?Q?L9FomdDljYmb5RGMS6k3fRaI3MuZGUreDRFlaJDAXcI6CEiHbX3Y5X0N1BGI?= =?us-ascii?Q?Fq+dHpURWaLzjH7Sug6j9EqfVYRomsrVkwqJeHHkVzTy2GBrLTU7k8GzDCNQ?= =?us-ascii?Q?k86yrg4dqhOgfDCGJ0CKhqDOp3U7y5aYGfLbi1IOFUUeUfLSPb+8h8mW5mr+?= =?us-ascii?Q?WA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: cgVEmhc2a/BhexrzI7D7dXPqMhMv3fXA4iJ8BsdB6lmii4pI3kPd1e6AVvRB3EKNtYCFtHwUJpcuQ7GVkXTO/F2RFI1GUsgvFaCUlFHsy8lgF9SRB/9jWOespT7izI+nCn91RdkKMAOL7dfXDsC5aPVh+ZhZeT8VAGbgkZeX8Ey1sVjTP/jroo1UUcgIiOf5SxJAvCPphX4mY7D9E+X67Fdzbxj50OyZZtlJB9scbGyxE3GfgJJZy7l4q8EwP13iVqrM/vn4fyfOnrD9A8SihaWxvVEe23CevcYWpW98RF1THhP9iIOCr2D2QRmBKrrBvHHQAwORbPaizmRQnouIo3xE9Nad7yHpght0lxOgJQ+kxAg4su04rAki4XnOixESNPYH+gWLQ7SH4OxvbLIHhMVzccP/2ek1L7sB7SJyvGouLrOb6xmR6uvqlvj/SP7QnMhH4pHRPnhFOdEuZ7dZR79mW17eBWA00Op0tlWxekVzUPPXtxoODPcA3P2Uc44GhCSVLVqNy58AHtvVd4+82OGXQ6BSCJ/hlrV8fLjCusrgGD1UNmUVwEKJlMBV/jboTpuMOIG0oYPepqN4mPY+TJoiBWFKmTA/eZHuwJyioY8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a74b4248-e01a-4873-e1fa-08dd96b26ad1 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2025 08:51:59.7789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KJ33J8qBFzyjfIXUS6wut3Z7YdvcI7goZaPVQcCl2w049zn3HOh8RtsjJ6XfAbt9cz9jkglCXCvGoLyxVPGwRDcv3EJejCYditFMGvyBevo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7767 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-19_03,2025-05-16_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505070000 definitions=main-2505190083 X-Proofpoint-GUID: ZpUlUYvYXKrjW0uEUffdCOsfLRjpqQeK X-Authority-Analysis: v=2.4 cv=JJk7s9Kb c=1 sm=1 tr=0 ts=682af133 b=1 cx=c_pps a=WeWmnZmh0fydH62SvGsd2A==:117 a=WeWmnZmh0fydH62SvGsd2A==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=UG4qeyOn-HlvHNRBQ68A:9 X-Proofpoint-ORIG-GUID: ZpUlUYvYXKrjW0uEUffdCOsfLRjpqQeK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE5MDA4NCBTYWx0ZWRfXx0dCYcT4/xa5 c5HU8NaRHaBAOFi+7uSOIZy171+dc0j5CEkv5VCvOjy9Ryn6mXOYb1wdrXeeeXh9/DYLv9rYb2o EChiKeK/9MDOfzsCDmVZQerEV6+7dHE2anSZ4qnY0j7PxmdvkRpGC2WopkSOsR+mNARm9xLJtO0 5MY4hRy5vCdM6hRZkzq8+P/y77DkPlGzKnN3R0ERJu5fKPp4ddFAbi3moqCSAdrKLMhuSK+F/ob omRX2KOgqsNZcBDx3S1kQneETxMBjuvkkfC+a7qU9Kh3m2HyNQh7JJkpuCdLs2vlFCq5EhGTxi9 OtfGhcAIYzbwTGTPcosseTye7P3OzkUa/ElhzxKxxKscsf4hNDAHYasJkRi3Rnsheuin9d15Xpl uoqJgy04NwGtVLZ7oM6h1ZhiN7DAHWmwG+Mw0SO3CISAFg4RNp4jMfwMRMITf3XZ6az44RfR Content-Type: text/plain; charset="utf-8" If a user wishes to enable KSM mergeability for an entire process and all fork/exec'd processes that come after it, they use the prctl() PR_SET_MEMORY_MERGE operation. This defaults all newly mapped VMAs to have the VM_MERGEABLE VMA flag set (in order to indicate they are KSM mergeable), as well as setting this flag for all existing VMAs. However it also entirely and completely breaks VMA merging for the process and all forked (and fork/exec'd) processes. This is because when a new mapping is proposed, the flags specified will never have VM_MERGEABLE set. However all adjacent VMAs will already have VM_MERGEABLE set, rendering VMAs unmergeable by default. To work around this, we try to set the VM_MERGEABLE flag prior to attempting a merge. In the case of brk() this can always be done. However on mmap() things are more complicated - while KSM is not supported for file-backed mappings, it is supported for MAP_PRIVATE file-backed mappings. And these mappings may have deprecated .mmap() callbacks specified which could, in theory, adjust flags and thus KSM merge eligiblity. So we check to determine whether this at all possible. If not, we set VM_MERGEABLE prior to the merge attempt on mmap(), otherwise we retain the previous behaviour. When .mmap_prepare() is more widely used, we can remove this precaution. While this doesn't quite cover all cases, it covers a great many (all anonymous memory, for instance), meaning we should already see a significant improvement in VMA mergeability. Signed-off-by: Lorenzo Stoakes Reviewed-by: Chengming Zhou --- include/linux/ksm.h | 4 ++-- mm/ksm.c | 20 ++++++++++++------ mm/vma.c | 49 +++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 63 insertions(+), 10 deletions(-) diff --git a/include/linux/ksm.h b/include/linux/ksm.h index d73095b5cd96..ba5664daca6e 100644 --- a/include/linux/ksm.h +++ b/include/linux/ksm.h @@ -17,8 +17,8 @@ #ifdef CONFIG_KSM int ksm_madvise(struct vm_area_struct *vma, unsigned long start, unsigned long end, int advice, unsigned long *vm_flags); - -void ksm_add_vma(struct vm_area_struct *vma); +vm_flags_t ksm_vma_flags(const struct mm_struct *mm, const struct file *fi= le, + vm_flags_t vm_flags); int ksm_enable_merge_any(struct mm_struct *mm); int ksm_disable_merge_any(struct mm_struct *mm); int ksm_disable(struct mm_struct *mm); diff --git a/mm/ksm.c b/mm/ksm.c index d0c763abd499..022af14a95ea 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -2731,16 +2731,24 @@ static int __ksm_del_vma(struct vm_area_struct *vma) return 0; } /** - * ksm_add_vma - Mark vma as mergeable if compatible + * ksm_vma_flags - Update VMA flags to mark as mergeable if compatible * - * @vma: Pointer to vma + * @mm: Proposed VMA's mm_struct + * @file: Proposed VMA's file-backed mapping, if any. + * @vm_flags: Proposed VMA"s flags. + * + * Returns: @vm_flags possibly updated to mark mergeable. */ -void ksm_add_vma(struct vm_area_struct *vma) +vm_flags_t ksm_vma_flags(const struct mm_struct *mm, const struct file *fi= le, + vm_flags_t vm_flags) { - struct mm_struct *mm =3D vma->vm_mm; + vm_flags_t ret =3D vm_flags; =20 - if (test_bit(MMF_VM_MERGE_ANY, &mm->flags)) - __ksm_add_vma(vma); + if (test_bit(MMF_VM_MERGE_ANY, &mm->flags) && + __ksm_should_add_vma(file, vm_flags)) + ret |=3D VM_MERGEABLE; + + return ret; } =20 static void ksm_add_vmas(struct mm_struct *mm) diff --git a/mm/vma.c b/mm/vma.c index 3ff6cfbe3338..5bebe55ea737 100644 --- a/mm/vma.c +++ b/mm/vma.c @@ -2482,7 +2482,6 @@ static int __mmap_new_vma(struct mmap_state *map, str= uct vm_area_struct **vmap) */ if (!vma_is_anonymous(vma)) khugepaged_enter_vma(vma, map->flags); - ksm_add_vma(vma); *vmap =3D vma; return 0; =20 @@ -2585,6 +2584,45 @@ static void set_vma_user_defined_fields(struct vm_ar= ea_struct *vma, vma->vm_private_data =3D map->vm_private_data; } =20 +static void update_ksm_flags(struct mmap_state *map) +{ + map->flags =3D ksm_vma_flags(map->mm, map->file, map->flags); +} + +/* + * Are we guaranteed no driver can change state such as to preclude KSM me= rging? + * If so, let's set the KSM mergeable flag early so we don't break VMA mer= ging. + * + * This is applicable when PR_SET_MEMORY_MERGE has been set on the mm_stru= ct via + * prctl() causing newly mapped VMAs to have the KSM mergeable VMA flag se= t. + * + * If this is not the case, then we set the flag after considering mergeab= ility, + * which will prevent mergeability as, when PR_SET_MEMORY_MERGE is set, a = new + * VMA will not have the KSM mergeability VMA flag set, but all other VMAs= will, + * preventing any merge. + */ +static bool can_set_ksm_flags_early(struct mmap_state *map) +{ + struct file *file =3D map->file; + + /* Anonymous mappings have no driver which can change them. */ + if (!file) + return true; + + /* shmem is safe. */ + if (shmem_file(file)) + return true; + + /* + * If .mmap_prepare() is specified, then the driver will have already + * manipulated state prior to updating KSM flags. + */ + if (file->f_op->mmap_prepare) + return true; + + return false; +} + static unsigned long __mmap_region(struct file *file, unsigned long addr, unsigned long len, vm_flags_t vm_flags, unsigned long pgoff, struct list_head *uf) @@ -2595,6 +2633,7 @@ static unsigned long __mmap_region(struct file *file,= unsigned long addr, bool have_mmap_prepare =3D file && file->f_op->mmap_prepare; VMA_ITERATOR(vmi, mm, addr); MMAP_STATE(map, mm, &vmi, addr, len, pgoff, vm_flags, file); + bool check_ksm_early =3D can_set_ksm_flags_early(&map); =20 error =3D __mmap_prepare(&map, uf); if (!error && have_mmap_prepare) @@ -2602,6 +2641,9 @@ static unsigned long __mmap_region(struct file *file,= unsigned long addr, if (error) goto abort_munmap; =20 + if (check_ksm_early) + update_ksm_flags(&map); + /* Attempt to merge with adjacent VMAs... */ if (map.prev || map.next) { VMG_MMAP_STATE(vmg, &map, /* vma =3D */ NULL); @@ -2611,6 +2653,9 @@ static unsigned long __mmap_region(struct file *file,= unsigned long addr, =20 /* ...but if we can't, allocate a new VMA. */ if (!vma) { + if (!check_ksm_early) + update_ksm_flags(&map); + error =3D __mmap_new_vma(&map, &vma); if (error) goto unacct_error; @@ -2713,6 +2758,7 @@ int do_brk_flags(struct vma_iterator *vmi, struct vm_= area_struct *vma, * Note: This happens *after* clearing old mappings in some code paths. */ flags |=3D VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags; + flags =3D ksm_vma_flags(mm, NULL, flags); if (!may_expand_vm(mm, flags, len >> PAGE_SHIFT)) return -ENOMEM; =20 @@ -2756,7 +2802,6 @@ int do_brk_flags(struct vma_iterator *vmi, struct vm_= area_struct *vma, =20 mm->map_count++; validate_mm(mm); - ksm_add_vma(vma); out: perf_event_mmap(vma); mm->total_vm +=3D len >> PAGE_SHIFT; --=20 2.49.0 From nobody Fri Dec 19 16:00:57 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD1526A0AE; Mon, 19 May 2025 08:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747644742; cv=fail; b=j9CiC0r0NBs35okd8pCwQk5B15VmdidlnKgf6WRMvA39sFlThWCtPvaHUxKONgXtbe5ADhCntXHRdrEwYq/5V3DAcEpKaVoXU37SZmIptY1QivHvNKgVD3aI/L+5tsc51H7M6E0zbAhoNg8ipVm8D3kZ1hok53kkUaAlNFhMXGQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747644742; c=relaxed/simple; bh=6/sKvf8vqS/WkmwfxrLkZKY1AQ+syPxTLOdjyhd51Qc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=QF9bxh2IC/YY2t7MQ6BVuDao8MWm3F5vyWnuPd78aedDWbzGvaSojeuw+JcdCaCTBKpG/02zwkHq28+N+NIMlsLKTOfHyEMWZPc/B4zG/BaL0Eh4O8RwXrMWJUQOgtBj760PfMNkU22LOQDbvFXRfaTf+BWIaiiRUGSgJ2SGji8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=JYvq8HcK; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=YzZBQhJl; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="JYvq8HcK"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="YzZBQhJl" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54J6ijwA024932; Mon, 19 May 2025 08:52:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=eTotjCqvzuqwBDx0TGUdS1aD9rrUNtEE6ZwURwlQl2Q=; b= JYvq8HcKPWNj6nnFBO5AqdviOXYI/OphZsW23hce09Kdv/jRyj43kfmJ9XPABjWp UTdOYpXuiJKYWwvYrfqAdL/J2eLxKzO4zs4+1TKWik4J3PT+l+YAEOCiRJQXRmF5 rX8yuGmsNwG3tVrdpRGTRSf10pGt1Kotzcc7ZK4Rj5ydaE/TU5/+ZGF5i+DTHikb aYFpvUstlBczfINUvyGRtFUStnf2KZdzHhzzg4zuoC0UxLFUGLuEHSJpYKCq+YVg eORWzsTxTC/LDctshGJaPYG+BWaUQeHLF30UFjYMPK6Ojch2agtLkqqj28ddNakL CJs0hec9rgMAtQU6RqKc+Q== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46pgvejfq8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2025 08:52:05 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 54J6rrcU022284; Mon, 19 May 2025 08:52:04 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 46pgw66jcd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2025 08:52:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HWW4RKylfhNC+n1P6TkvynTII2IyMDsrIBkJzZ2/K3uQyj1+PBB+Tj0gGiSxG3QjrG7oJh+QCA8TAppKpUGd9z8PO6U38Z3u/L8W4H7Pp+tB4A6K83SD93YAK4uY4WnApq/VgsZMYlO5bMusAHigaXPJLIGmaTM0PM2uA8PppxEGlUJvx7ESxi4Td/+RuK9Aht079L8NVMQvJRUkYQuCo5jm/rqow4NszT9MweG02ql0kcGzKuYg2cewP/hnJzE9wOdf33fN7UGl7Zxm9Fu+b0rYr9lT4eg+eHIM2qPOdVNTQsv8KlDiL2t1HhH4inx3N2iGtpu9wXE3cEOJ71N/gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eTotjCqvzuqwBDx0TGUdS1aD9rrUNtEE6ZwURwlQl2Q=; b=qj5AQvcP1vhdbLQJq1Fk4zGEclcIuVMrRoWqxpUZNdXnpdbvPgZQzobU7Pb7liYhcxkTl8oUJGMai7iP8076EWURrSOs1SbYxo7ni6L+RcDxaEIPC3CU0aQkRbucEuIa0d6/gvY3v1xaPC3C0JltOBhMSstAcWIvsQ9N1jma11vCsoOfpcZk9KrmPkE3QX2Ua4OrYGd7ppTi1+EsU49I4CR/omqypECjpA+iMgHYRAetEhlMkmSumos/Ce45fcQWJUIBBFsHZvvmk9jtACnSn2iZoRduGBG62eUcr5pnZCkMtilZrQm1+L1pk+jM7ADpnNIFCxMrE465fls3HYsheg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eTotjCqvzuqwBDx0TGUdS1aD9rrUNtEE6ZwURwlQl2Q=; b=YzZBQhJl6R83G4TjX8KzqNvxoCVTAhsoHy2AHpP7Dr6763wzg+kxPQ1a0uhMVvm7ciN/aO3DRDXqBMzoA4fab+TJA6hs696cmratKiSlWLNzWdF4yeIkC2eExOHunh8Ebb/YE3RH5gWhDSt+mslsSF6XqO5Fdm6zVYFUULGpYRU= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by PH7PR10MB7767.namprd10.prod.outlook.com (2603:10b6:510:2fe::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Mon, 19 May 2025 08:52:02 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8746.030; Mon, 19 May 2025 08:52:01 +0000 From: Lorenzo Stoakes To: Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 4/4] tools/testing/selftests: add VMA merge tests for KSM merge Date: Mon, 19 May 2025 09:51:42 +0100 Message-ID: <95db1783c752fd4032fc0e81431afe7e6d128630.1747431920.git.lorenzo.stoakes@oracle.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P265CA0261.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::14) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|PH7PR10MB7767:EE_ X-MS-Office365-Filtering-Correlation-Id: f505d65c-7309-4a2c-836b-08dd96b26c1e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0wTJVCrdrEJWj8q62c1l+ISgCul/Jc3Giy7d5z/58hKl1dI9LiMSSLFfbtpd?= =?us-ascii?Q?ZZ+I1Z6dERu2UFFKFV5Yegddo/0gis4CqJnMlo+2AEJq8KLT3t+j1JLm4+xA?= =?us-ascii?Q?pSe2b3pnJz++QB7FT4xxYaBMnYtJkHhQIrlMSWjXsaUemmKJytNKB/i/eHdY?= =?us-ascii?Q?3LqRvbmLEKa3e25EMMczjEKwFIubpt+6V4Klk/hneskdXsAs6OyvToM/7fPM?= =?us-ascii?Q?iMqW54lZyEjHpY6GHTt5dVcnO+rX6MnwAME6lqkkw+TMMvqZc6gGTs2zEXnV?= =?us-ascii?Q?0Z3v9vOXUtVNyFz8N1PdURTZWWK/yRgIpMb5c2c7QgsJuPUdAbYwyabFBeSQ?= =?us-ascii?Q?ORvNp6k7YEizJa/0dpGHc4it3VtZn3dwAAMiffqpmG/rwXzYVSFgPdwdpy43?= =?us-ascii?Q?wceUpzzttQRLnHvLcYUQBaJz67T8w1n0nfxxjFCWk1597sZAaOG5jDQDqW57?= =?us-ascii?Q?53PKvi7qh2I2agqJ9CjDz62GTPJ0oB6GzQ/m32v8MMzGsV2vT+8SlXGMCbgw?= =?us-ascii?Q?x/nUqhwSsAXBL3zKfVNBqi6cWBRNiL/9ZExEL23bHpKe6TVHL708aO+pLe9O?= =?us-ascii?Q?wbrlnzVDYxMRNfXmC1pDM7X7CoCfBAlWhw+FuZmc6vrk3s8oEggC3LGAmLvU?= =?us-ascii?Q?QzqkZh9lejmXNz5kOWhZLKKvCUWNR6klNc8Tb4Ta3GqqdXPUHc52jYkgDXHY?= =?us-ascii?Q?xHZchb1Ry+oj8Vv1DjqDlqzfH6+AbSrsP1M71DZrOC6lvfPmxp14j71qHV/1?= =?us-ascii?Q?qIE1fo0z++rIG5v3sNgiWpVp/VBw+2R3IHi5oxjQeIb8XYacfpI9e9T2ETzo?= =?us-ascii?Q?A+YtBAqIjQVdWAGZyF+o6Stz9Osjxhv77hNRJ4nPdcumCllaNg+K2uZri0ul?= =?us-ascii?Q?pk49QbFAsLNDJlTmvI1Kp4zQgF7jmrLVzZhNW0nTQ4DYxX10K/ugJF0yJ+4x?= =?us-ascii?Q?tfmNbzflXRpzV2naHMg8OCsXAd8fCNjVLe2CRzOXmuFCj28LwdCLUxCxtIQR?= =?us-ascii?Q?EYNU78fS3KcvoXj27Yn0JtudkyJMW9h9aMRaZmOIPBRbyhkgqE0QM2X2yAoW?= =?us-ascii?Q?IvLhwFqaq+tOl/hzdVsGrilka+7L1xEeEzcNzIQy+FC4LVNoOmSTwN3lIMtu?= =?us-ascii?Q?6t35Qr/wRkbIIp9ceMRgvEvtyFklbd9X/gb61gmprrE5KZcZYkB5vVe2mUiq?= =?us-ascii?Q?BOxmR5T4vyQbswq8OJoFyU/ODH59COLpUaJgiFwiwuKdA1NPNlHcMLmJ1f3N?= =?us-ascii?Q?klfoOcGsJItyBfcs7isVUxjc0BbiJ5VR9OCcKZ7KlO1kc8Aox78eoSe96GD/?= =?us-ascii?Q?fJaBRIWWWf4nNGTW3M1rF2Erh/um4UZaSQLmVa/W05rDCoGuq6GNSa7ES9/C?= =?us-ascii?Q?CUtXKzvpWJ5ztmKq/0Ua4GKk96bMgqGx7vKsWsqG6hKK7znGzQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YLq8gwD/mGEQApW5FLHB+5JlMJnN79Ka4TYR2DLGjfkKzif7gAFPG6rZvbtD?= =?us-ascii?Q?uch0oIP/jYt6CdPoqfjZ+j3u7I4XpDn7TzdcHF/Nd1rnAy98WOOo166SOCkJ?= =?us-ascii?Q?7KTUOdGQvXQ21kbK4ltQ2ZFGGnimSQjLuuTZq4lgmvnX1Ctb1xbUSLrXNfl0?= =?us-ascii?Q?goQ5GlCoySEFrpqsa3vwrIGShvm+/fIIBOTUOUjgLTNo4kdeJmUFLnkSHF56?= =?us-ascii?Q?rhI0b/P0N/fR7ZB9BCq0kqIf6bv2KuJj+p3lnMtyRCOPHnzN3IBWdOipOuSv?= =?us-ascii?Q?z85F5awV5AZzjv3YVRYJNlB01Dx5efC0jNIswz3VwruywC00a6lMpKedB373?= =?us-ascii?Q?bUtZV9FXVuDhJUJljKuRDVgblOGdBunk0wdjuARbG+M0ddpSowW5RlMJ/0T5?= =?us-ascii?Q?4a1s4KcYZi6VfZG7WTG9OKKO4242U60hu1FQvokVrPahx717wHI/solB41Gh?= =?us-ascii?Q?nHay+HFwujjAGHRTmAa0NgBjX2g1pdwGMQoQk/uanjLHb9RhFiGtzOkzuO1B?= =?us-ascii?Q?9zagcEv2pZDrCj+NlFj5U73gL8cNbZnpgj/9y3uystNmLdsAspWWYwvA0Be5?= =?us-ascii?Q?0Efu9D3ZfM8zAZlluev0MuSnCY8bQOkG8iHq4UzhG5CFcT56Yf2ibwHcwA2V?= =?us-ascii?Q?t9u0D7EBO0Cqq147TPsD94deZPjntXSLzp19jZEWvsz42tLbw1fKIG+7GBM5?= =?us-ascii?Q?e3z766SitjCo/tH8dgOYCFLltX+Rup0Y4qIpW1luzEdK2Mu4wo013p63TIEU?= =?us-ascii?Q?sd03mmzUA/8cNbNO/7f+Ft45f10+zP6MJWUIFH7cY0BQjfnZcgVLmrN1WLft?= =?us-ascii?Q?HQXEgoHnjldPcP2bm7oSolgnPaZHSqjy4ZMpvnznmqMXNVpHFZyyLT8He7H2?= =?us-ascii?Q?1PAwBynnspSI9XiDbnag1u2EQcoi6CiwZLkrU0+jvgPMSqrt6e6BAktTBwHu?= =?us-ascii?Q?al6lutoLztbHVTbSY2ISc2p5hqTs/9Fm95vVWFJbQF6YsW7Y611UuZS8RdWD?= =?us-ascii?Q?TQsuDsm85vd46SgFXGD2Ztnnn4+HQoSgj8/CHL67vNq4IMkfynDiVJ1apeFM?= =?us-ascii?Q?WiadtSpMATyEYjKlxliLm40viTok6YZvp2nuGBuP5EKk+Fl3odWq+cz0cmwe?= =?us-ascii?Q?DV2OTmCH5prLxmBQvkUFZTjh47wL+oywK1SDnfugqYj+TIEe/VmCuYPd1KPa?= =?us-ascii?Q?acyckQBNd9TOkUmyI/hSVzFdCUk4ww9WcGlgQDxKD7QqDWvs0rnzCAJuo4Ki?= =?us-ascii?Q?etvI3GQSJDF2zjxghMa03HI/PoyXRT3a8AZ2CTjUbnpVVl4OsS4KAXyRDMN1?= =?us-ascii?Q?ygFq0fddV52U5rL7tNUPsoQvPsb+pFTqKz0zu5dHpMHFDrEVMmll5ZbSdVqd?= =?us-ascii?Q?L6cFaeYaeqrBK7wioCKBBfVziy3+OXCkvt2+DLUTeXC0bUHydGstjNdLcbD6?= =?us-ascii?Q?vjMJnC+ZLGxafMrsJm8nK0YLSGOyhhdiCpQYJXh1Qyg7D74zoR8b2cbPiNUf?= =?us-ascii?Q?CGnMaL+I1nIb/UPcyGhqvUySe+iaiJHP5vV+IXHlYGQoHL4Wa9gFn4tmOa5m?= =?us-ascii?Q?/BORPfyoMgfjoIpHIMfBynp4BtXYsCkEs7oNARXeknEhk6bTgikFfCyws3L9?= =?us-ascii?Q?ZQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: i6xazKNFsHa9nDJQAKLGUWW2BQ0VVT8IhtOPe36pRt4Y6Dul+1vGFr2s78OEEV99QAUKz2mz64IDy4uxduTbJylOXrja9tNijcYyIavmVJecEi2eaUVkG9rkZk+w/GnWzZ6jiUX3ac0oO7L0sqtXCkTL2vOdykIYBWG3d00/5R78WRvd2dNwJ9ObFYFOpN+ouS1eHx5586S+ChPGufCQ/08bg5ggT4d8NDCYLODcjiMcUcS7eE2zc1N0rxE76pxwYivJiScr+wzk4dCViPDlS48u7T3I5IGY/CIHkCV5ljYJEMr3vcF79v5NDaSC307JN/Os8zR+EvMAqn27rSNAlHtiZCFCcoerAR/L61PQRXe6MYVZyf7v6kq8LHv1ZYuqs+lmKVjMSJfKR+6KUwp0cEDKEOSNGnrtMVqf6acPWZEJJ/RyhMOzhG7FnaQ/OwV9eE5YdbCnxheMroImjD4Ws2xs9VmWj5yKUQzrgmeO80qf+HLZNZlq08VHvcANPLFOLKz42d4Fze1TjRQppjCRZEssSq6swCNe83RuJSm5v8JOt1OhKsNGZuPgI5pPEfh7VXpuYx3+iZDCx9ad0qgSEyvaX8xwQ+lTuYmIXJ9OJe0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f505d65c-7309-4a2c-836b-08dd96b26c1e X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2025 08:52:01.9430 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kSrBvlLGCiB2/PYeke9dbJxv5BANjPX6m8nYmDPs6+TGi+AB3yx/ieqpoRdJgGXObD0HkuuingWXXUDX6pduqBPuVhg0vWWeJ60NrtpGRUw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7767 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-19_03,2025-05-16_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 mlxlogscore=999 phishscore=0 adultscore=0 suspectscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505070000 definitions=main-2505190083 X-Proofpoint-GUID: XoRuabH-Y1GqjyzWTSSsnQyTlBhFMuzJ X-Authority-Analysis: v=2.4 cv=JJk7s9Kb c=1 sm=1 tr=0 ts=682af135 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=dt9VzEwgFbYA:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=gr9gRmO7I7NIG7Hr9ywA:9 X-Proofpoint-ORIG-GUID: XoRuabH-Y1GqjyzWTSSsnQyTlBhFMuzJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE5MDA4NCBTYWx0ZWRfX/Un2SWW0IZo9 wn3gV//ylzEhAiZKuVysOuvSkL9KQ7gOMxOzZaZzICrbM39QIsYQYxKfGNcQM8h4AEyKBbPtyl4 DaeLvzwRowepmWiKQQi/Z+j63QMU+f8cVZ1sUPLFtruBshZZ01XFZy5cyexa/zDGyHZdBZ1v1Ps zNx7qMl63axq7j1e6T/R2lwrnOO+uGyKD+6Qwc3Y9fen0gFeNiLsF9d2vQuwV2iAQ7vVJU9HZLu qNovfS/PSFF8L/FDIwzzGdqvfQ6niIhHXikvoMZcY9MKp9onHzCjAKM8EM1PoTNccSpL4sVV1H9 j1imjwBWLjVA64sWZrJekhtJkZlbhlmKt9pENqACRvz3aAO/oKBfVp9m2ee1DiAnMYlMrd2fhAI cB5sOqIDy5cWNLrldIAAxNvFNXahgh5o1GpwrvCxNG5p58mLV2UnKJ6iXkne0ZoaUwrN4mEF Content-Type: text/plain; charset="utf-8" Add test to assert that we have now allowed merging of VMAs when KSM merging-by-default has been set by prctl(PR_SET_MEMORY_MERGE, ...). We simply perform a trivial mapping of adjacent VMAs expecting a merge, however prior to recent changes implementing this mode earlier than before, these merges would not have succeeded. Assert that we have fixed this! Signed-off-by: Lorenzo Stoakes Reviewed-by: Chengming Zhou Tested-by: Chengming Zhou --- tools/testing/selftests/mm/merge.c | 78 ++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/tools/testing/selftests/mm/merge.c b/tools/testing/selftests/m= m/merge.c index c76646cdf6e6..2380a5a6a529 100644 --- a/tools/testing/selftests/mm/merge.c +++ b/tools/testing/selftests/mm/merge.c @@ -2,10 +2,12 @@ =20 #define _GNU_SOURCE #include "../kselftest_harness.h" +#include #include #include #include #include +#include #include #include "vm_util.h" =20 @@ -31,6 +33,11 @@ FIXTURE_TEARDOWN(merge) { ASSERT_EQ(munmap(self->carveout, 12 * self->page_size), 0); ASSERT_EQ(close_procmap(&self->procmap), 0); + /* + * Clear unconditionally, as some tests set this. It is no issue if this + * fails (KSM may be disabled for instance). + */ + prctl(PR_SET_MEMORY_MERGE, 0, 0, 0, 0); } =20 TEST_F(merge, mprotect_unfaulted_left) @@ -452,4 +459,75 @@ TEST_F(merge, forked_source_vma) ASSERT_EQ(procmap->query.vma_end, (unsigned long)ptr2 + 5 * page_size); } =20 +TEST_F(merge, ksm_merge) +{ + unsigned int page_size =3D self->page_size; + char *carveout =3D self->carveout; + struct procmap_fd *procmap =3D &self->procmap; + char *ptr, *ptr2; + int err; + + /* + * Map two R/W immediately adjacent to one another, they should + * trivially merge: + * + * |-----------|-----------| + * | R/W | R/W | + * |-----------|-----------| + * ptr ptr2 + */ + + ptr =3D mmap(&carveout[page_size], page_size, PROT_READ | PROT_WRITE, + MAP_ANON | MAP_PRIVATE | MAP_FIXED, -1, 0); + ASSERT_NE(ptr, MAP_FAILED); + ptr2 =3D mmap(&carveout[2 * page_size], page_size, + PROT_READ | PROT_WRITE, + MAP_ANON | MAP_PRIVATE | MAP_FIXED, -1, 0); + ASSERT_NE(ptr2, MAP_FAILED); + ASSERT_TRUE(find_vma_procmap(procmap, ptr)); + ASSERT_EQ(procmap->query.vma_start, (unsigned long)ptr); + ASSERT_EQ(procmap->query.vma_end, (unsigned long)ptr + 2 * page_size); + + /* Unmap the second half of this merged VMA. */ + ASSERT_EQ(munmap(ptr2, page_size), 0); + + /* OK, now enable global KSM merge. We clear this on test teardown. */ + err =3D prctl(PR_SET_MEMORY_MERGE, 1, 0, 0, 0); + if (err =3D=3D -1) { + int errnum =3D errno; + + /* Only non-failure case... */ + ASSERT_EQ(errnum, EINVAL); + /* ...but indicates we should skip. */ + SKIP(return, "KSM memory merging not supported, skipping."); + } + + /* + * Now map a VMA adjacent to the existing that was just made + * VM_MERGEABLE, this should merge as well. + */ + ptr2 =3D mmap(&carveout[2 * page_size], page_size, + PROT_READ | PROT_WRITE, + MAP_ANON | MAP_PRIVATE | MAP_FIXED, -1, 0); + ASSERT_NE(ptr2, MAP_FAILED); + ASSERT_TRUE(find_vma_procmap(procmap, ptr)); + ASSERT_EQ(procmap->query.vma_start, (unsigned long)ptr); + ASSERT_EQ(procmap->query.vma_end, (unsigned long)ptr + 2 * page_size); + + /* Now this VMA altogether. */ + ASSERT_EQ(munmap(ptr, 2 * page_size), 0); + + /* Try the same operation as before, asserting this also merges fine. */ + ptr =3D mmap(&carveout[page_size], page_size, PROT_READ | PROT_WRITE, + MAP_ANON | MAP_PRIVATE | MAP_FIXED, -1, 0); + ASSERT_NE(ptr, MAP_FAILED); + ptr2 =3D mmap(&carveout[2 * page_size], page_size, + PROT_READ | PROT_WRITE, + MAP_ANON | MAP_PRIVATE | MAP_FIXED, -1, 0); + ASSERT_NE(ptr2, MAP_FAILED); + ASSERT_TRUE(find_vma_procmap(procmap, ptr)); + ASSERT_EQ(procmap->query.vma_start, (unsigned long)ptr); + ASSERT_EQ(procmap->query.vma_end, (unsigned long)ptr + 2 * page_size); +} + TEST_HARNESS_MAIN --=20 2.49.0