From nobody Tue Feb 10 04:23:47 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97E78218EA2 for ; Wed, 30 Apr 2025 08:27:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746001658; cv=none; b=DhgHpxPd9dRUrD7YK8o9bxFwJuiMAG5yeNjVfEaKIqoqJs0wBud8TFrlwkq7Sc+0CsJfGPpES/+394MpsLdiGfYG/AVWM8KQ6lPdwUQpx96s2+khzuoVCWZEf60VwaILFeefOH7KEQ/e5R6XmMQ8XT2pxZQL1emfWocrOGVKmqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746001658; c=relaxed/simple; bh=DxHxKhJsfM5IQo4p/BKw2Qv5mxONn1+sIjGNnBfbnCc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VYMX1U8eRUAnbt9qxbxPt0AhS06PtQjh8fnUzFjP9X6zAQbwvPQXCjs7Q4npe8XZEkX71GvpTMVbMvNfprYG+rZakwZS+k5MfAXDly/39rTeCqW+hQ1ZJGoRt6VU868VpnHyXXKcBEfmd1vpPI4Po6Dlp64LEQWq1mvRAJOmx10= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mLXTCk1R; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mLXTCk1R" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43d07ca6a80so26592085e9.1 for ; Wed, 30 Apr 2025 01:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746001654; x=1746606454; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ca2Hq/Lqblr8quUvSQPFNLA2CAIvKIyN9VULJch+1To=; b=mLXTCk1R8CZkBSaln/P3982QK+0Aoy+HdQnfMCFydvQ8Ap05PtmX3Q20gXmdtfGhf6 uygm75QhLs6uFXlk9beQpNjpyYeiiho3rT1IXC3cH31O5NBpLRPZHj/nSHCtzym7prDn QvyXQtLbTqb0GwJP/1SYkYFPrPng9zHaW1WdZZWNCDa550QUaVq3UiLdY6ubWWsCnqlj xhoQK+GxhEMjqfMdaqzj+iAWS11G0GR25Wrqo3s5qveb9I936IbxKXwIy55grWTZsOuP Nap5pDTJyOO4FA2C4g950FCmiCsiJft3F7VeMWEFQP/aI58E6cJR0uRxqT6GoQnTCnQz 81Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746001654; x=1746606454; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ca2Hq/Lqblr8quUvSQPFNLA2CAIvKIyN9VULJch+1To=; b=oAaqYU31+YHEYVdgxpn+nh3k9slgFCn4WSpdAiDXkRuBGErBhRelC35mkzMkroiH0k k4dStQIkTYNtL8q2SldluCVNk+9heTj2ER2FOTQjHZj+aQhzgzJjMAZH4eaaAmk+8qwW NXD2YFZclNetuXx20Mc3R+bUEGXpxm03O6js95jYyuL+tzkkQnRlJ70pInAr3x3UMAA0 WDDLjotUSoCoS75FFqiZNsRO3A96RBjnEyRRmnL5NrJdqJszrLOIp3q6RulxEw9w+F3T r6kAZaskbJimVmbL5ttmyrokE7fWyD9/MuUa9OvSFKXwALWPuYaOA1OCHFcOdX8NOQQh 0PPA== X-Forwarded-Encrypted: i=1; AJvYcCUBeHlztNzw+NLgvKEG37AEZtrRFQYxP6M1zmKcYLWisJjz9EwuD2Q8zzjxQYk9OVg1u84Lip7g2Inp0Sw=@vger.kernel.org X-Gm-Message-State: AOJu0YwwE2JQ4yN2gbUa7j+NGRcdVsfR9epNNDDhy+k5EEh+mrJ9/kC3 Kv6KWun/ujNyRWJN0S17VNie6Ep2muxcXN5fF7FTS3WXA9GxJWjgQ4saYy0opD0= X-Gm-Gg: ASbGncuRuChaYSONfIf/cIUXEPx9nSUGay9gEeTYSkdlmmduiZcPTZz7QSqHPNvIwf8 tzG3jKboB5LEEyha9jL7alKKXrMD6w145aDeUPVBO7ZuNG4PTSoqZGvjkW/o9mxMn4DOq8nbyg4 qIJvsE7WnidA5XQmvx6fZxFeSvKacjiQlVopK1Kz31qIc+aFaOVJYV8l4qEkoYevb9S0cyf5vYR MtnmGFeJ6CLYJuotHFVriZaGdBk6T4/aYEAW+HRyW28ats9EBFMU67DwdGc7Vsi+Lh96+Fq8SlW 1zQT/SjkCXO6ydPmyyL8YYNpVaqp+pWLRnQb+uGN6/uKHA== X-Google-Smtp-Source: AGHT+IGwdDRTjPXieuwqML9OeOIGuwumXqnwuBaxSQXQnI/omezt1QxDAaH8vN3P12fRW7cmzI1H6w== X-Received: by 2002:a05:600c:1d8d:b0:440:54ef:dfdc with SMTP id 5b1f17b1804b1-441b2639c36mr13608775e9.8.1746001653963; Wed, 30 Apr 2025 01:27:33 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-441b2aecc89sm16215325e9.9.2025.04.30.01.27.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 01:27:33 -0700 (PDT) Date: Wed, 30 Apr 2025 11:27:30 +0300 From: Dan Carpenter To: Tarang Raval Cc: Sakari Ailus , Mauro Carvalho Chehab , Hans Verkuil , Shravan Chippa , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] media: i2c: imx334: uninitialized variable in imx334_update_exp_gain() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "ret" variable is not initialized on the success path. Set it to zero. Fixes: 7b19b0fc8ac8 ("media: i2c: imx334: Convert to CCI register access he= lpers") Signed-off-by: Dan Carpenter --- drivers/media/i2c/imx334.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index fc875072f859..846b9928d4e8 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -536,7 +536,8 @@ static int imx334_update_controls(struct imx334 *imx334, static int imx334_update_exp_gain(struct imx334 *imx334, u32 exposure, u32= gain) { u32 lpfr, shutter; - int ret, ret_hold; + int ret_hold; + int ret =3D 0; =20 lpfr =3D imx334->vblank + imx334->cur_mode->height; shutter =3D lpfr - exposure; --=20 2.47.2 From nobody Tue Feb 10 04:23:47 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544821EF388 for ; Wed, 30 Apr 2025 08:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746001664; cv=none; b=DVy4MxN0H9ZyIoOEbfwGkg6qxTdsQOU7/EfGzjnUFWAI3vvI3L/9NMj6Q4vgDfy33b6DN5Yvz1i7tw200q8jkcK8jQmrprJ0fCBoj1wKHmZF9+HGK+O19trPoayJf9WUHnOxZiawn7GNayqFhR+VZQpFnOQNVV7nHQUkCHV/lyU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746001664; c=relaxed/simple; bh=qVsS2hUBtqENy+Oubx9DpGdc3RA0lMtgQ25CAEpQvtU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WHpav/M1/PaZPwfK5P+wnmcNzmOCSvr8tGkvoZZ/STiet58mN1KqRDxJmno2FRJw6bHpPHjvzwHdfC6HPNfz2WJoNpJNxCWHQPlO6bRc8IHPp4neQFNA2FX1txx1vnKMsL7msC8CztLk2QemS4deQ/XNnY1ZJpvwxd/dqFb/fd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Alh41VcA; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Alh41VcA" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so65059355e9.3 for ; Wed, 30 Apr 2025 01:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746001660; x=1746606460; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1mGsDZPklQSrBkLSeSMFUQEvM6CvjwvWAOT3FCKj6DE=; b=Alh41VcAHba6JSo3mD2BqMWSh+WzP0a8CfA/RbQ8zniwxJJUDVF4lTqHuTwM1Q/+Su iGTQu8YQfVE6M9CvoGy7VZ85OneF6wNgNccuw3Kzh+f8AH8Xs/ucSLwYmPbDJ6yfDzIY 5Ee12Bf11b8SbMKmHpOVz8u0v66qjNl3donX0gDQiyeyeHJFLC84PfdkJ6vKdlUEYW/R EHFIJXQlQy2kkD5JgGdajP3w0BQTqTnj0zUHWe2Sh4/wp6ut4cDRmIx1arYJBTW6fHAe 6fmeoUF0FVfLnPD0hbhScziPB5SYET3bk+xj+PrgATvTbEBCgSm/uWAK08jgysu4e3l5 DSwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746001660; x=1746606460; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1mGsDZPklQSrBkLSeSMFUQEvM6CvjwvWAOT3FCKj6DE=; b=ozy3CE2MMDbPNU/4Nxo1SRmurEu/HaPgdlJjOKjHA9cH15GpiXGklk7oiCHFR4pmnY tHqig7TUGYUXt3VNrjmtsNmvCbovJp4AGAdjcno2RAkRu6PxPKHEjJhIO/akli1Z6Vrw 58mov4A++ejKjzwQdRRzibxpQSl9XZBKZSdibdRsh2Y5BuhRr7+fdN6scz0yo0BYE+2/ W+1ZfZ8KideQD1DO5ixjXNgTWH9qHfFa094WlMT93TijHqCnw9nWW4eHgyJ0Af4d7iuQ Klgq9ROnGAWqrkL1pme4AHIiF4TnTDy0JmSi6wmHkLUqWIwM5VvSF7egniL03whi7fWj Sa+A== X-Forwarded-Encrypted: i=1; AJvYcCUDXNYtXWqRldUG6InMuu3osqO4gR9C5Xwd9WxfYrg3tcqFZP+hxqLL/+Vs3Ao9cBndA4aBTfbGCCntJyQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyAssH6rFR//LOuvlihAVIrXndrMHsJPa+HblxDA0mDs8CGbeSc cMfUMBuBNZB2mu5VoOfCI8mBxM/CmjEBp2y2D+ydqH6JV73NQTkJGoIWMIhY7NI= X-Gm-Gg: ASbGncvhB3hNX3earUf68ZeezCR2OjEggfGklVqyQCLs6U2RVGehWM1LuO8nnO7B3rk Nf8qgbBDrFF3MMbomDHRrrMRpDOYj7zSUwwds0JKs5inGde2yd7jLeNRpyhpRYPLwCXNoQhEqRr ZMp3rBivW6CV5a4PDl32OzmN9v6/t6hgjUj8Z6Xxa5/a7BZZp059YnhqlaeaLQhWYj0fPkbrLrQ x+AnIWCll99jucr4RI3CpuRzE7efpxajtC76rXpAJWeyyQiqjjBDQ9YQlZtke4QGObF0bOz40e8 +1LKB4zFPR/CWVxUHjsy1uC8CLfMuiuR+xOWJJPtZf2hlw== X-Google-Smtp-Source: AGHT+IFirixO8zK1n2Aomk9+LOvvs0gmdVuJyEBLIkX5VxmbuCqSlheIcRnqq6WdgItyXk/d3bhvEQ== X-Received: by 2002:a05:600c:3acb:b0:43c:fc00:f94f with SMTP id 5b1f17b1804b1-441b268dfcamr12676025e9.23.1746001660599; Wed, 30 Apr 2025 01:27:40 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-441ae3f5949sm33946145e9.1.2025.04.30.01.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 01:27:40 -0700 (PDT) Date: Wed, 30 Apr 2025 11:27:36 +0300 From: Dan Carpenter To: Jai Luthra Cc: Tomi Valkeinen , Mauro Carvalho Chehab , Sakari Ailus , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] media: i2c: ds90ub960: Fix uninitialized variable in ub960_serializer_temp_ramp() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "ret" variable is not initialized on the success path. Fixes: a05744749600 ("media: i2c: ds90ub9xx: Set serializer temperature ram= p") Signed-off-by: Dan Carpenter Reviewed-By: Jai Luthra --- drivers/media/i2c/ds90ub960.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index 8075bffbac2b..cf104461b9a7 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -2058,7 +2058,7 @@ static int ub960_serializer_temp_ramp(struct ub960_rx= port *rxport) u8 temp_dynamic_cfg; u8 nport =3D rxport->nport; u8 ser_temp_code; - int ret; + int ret =3D 0; =20 /* Configure temp ramp only on UB953 */ if (!fwnode_device_is_compatible(rxport->ser.fwnode, "ti,ds90ub953-q1")) --=20 2.47.2 From nobody Tue Feb 10 04:23:47 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AA231EF388 for ; Wed, 30 Apr 2025 08:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746001668; cv=none; b=avEKRLo5Ss2TvQnYwnam/1NmIeSsFQCnldKD2TNvIuU8074rQNXuiFF9BIFgH8gzRfCp8LuJ5xPgcKgTOQxx+v7fq0A+F/l/nPH3NA9sT+sQPMcVMcCQ7yCW+osIl121JOUeBVbnEU3R2nHD7R1LpYS+7YVIQbjGZDZGu36j/04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746001668; c=relaxed/simple; bh=pC6366U9Vxi4MCVI0rp1quj2Je4SIGb4/739P9X10sI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gVvIlZkn7NT6RSbTNJZ4j3Um0KI0JVGct/BtxR1KMZIzw6GBeWXtTcUZM2pmO+sBgX8ccXIt/SDRpaTsm75ZS4/QVUzxh5uJ5m1aS4Tc25qjMSxJWntxD9zeiK+54ED89Os8IVzydc5q97w25mAzNnHJu11UqE8vpgV0hTXKaWA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BpV55Hca; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BpV55Hca" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso411611f8f.1 for ; Wed, 30 Apr 2025 01:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746001665; x=1746606465; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LSY65Em9CZe+eeM7wzETHW6baTLUML3bJ9yO/W+LGW4=; b=BpV55Hcao8LJx3USC8dXWGy0jZY0dTNUf1NOyG77FbAJZwFSVYrF6m4t7Sc3nxMOP2 gduwBHbW/2CIdoEnPpxOviBUC08AycRD3smxY79htAvGhCls9vg5bYNM02dQ4c+kCyqL YbF9seQjC8WDwilrb0kiB5bPlpfVTxt37UkUH32drVyxhVJTS0hVDg44MVD0Z3NAekAh 3ThUhBstwF8QJ5fvZxy8fZ0WJzVtsM8p1kX3v5deaoIfjeNYYpGu0ml9QInH8h/aO6NP AAudKhR7m5zy4UYrlQ03GQOnxHC4+wz7v5Jc1bIME6bm5hqQJOYkcFxLuJxAgt8Ykg9S +fCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746001665; x=1746606465; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LSY65Em9CZe+eeM7wzETHW6baTLUML3bJ9yO/W+LGW4=; b=erxwP4hGzULbboU2Bcg4Y/of4AFCSbSS2q13U2MOxeSUV1DnY4pqBiTeAsoPW9lpdv l7T7ySnNPnFkpsBoUhsd1rmt56ShufHInr1GNgJ8Wf3NwbYZI5nQVW2eeWhDslfXpgYg rzFAXim80G4QggQxDWEwEmtcoOmhaAisziyIX8D0BIfkyoZ6wz5LIekXuIpLwu3CewVV PrHfj4WDHAMyrgr9U3oHLKRJ9r8WPwMn0oN2oYM9X8CXMqLjd5IZl92q6/ASEpnA8ODc ZGf8uKhlErc9QRqBlm4XxAVy8PVL6YG4SEE0vmwAHkICrpx6dIQejtqyPDIv7g00J5hc dV/g== X-Forwarded-Encrypted: i=1; AJvYcCUu+2touWmDkAajiz++1be17qlqrtLBXbGsXQoSJOibY7r4lYqNa0xGPTgpnLMNrEjYQkITN66Fcz+YxaM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/O5mxlu8liGojZHLlkrPrjBTO2wfLpo0WaxZaFKggBBbz2uMe sWL+wLviOZgJzfyVPg97+TnxJxuH6Y3Xa9JoS2WoG4eccw63tEobaJOxGoKyGwk= X-Gm-Gg: ASbGncuxy/KgRFdm6eJX/cBdIJA8woOOsujUcCDj6fMkRdbr9K5MNmtobczx9FOod9J A25oI5LoEaAeWGoIBADoMTDt9U/YICPy0pRMwz20hcp6IqRRHcAPVt4AHVC2mx9ZnCrwC/B00N+ eCziaACOuxYspTTN6McfR2et1eD93lHGPZGejlALLcFjw4DP2msROwxSrh5QooNiL+Lz8Kd7tiW QS+GbNubysSaVkQw6rUpwF0ubuOsgEbu/z1G/baPXWzPsKSNpwtz+ZmgfWSHG/y1iX3Td5IuENM URp+RUFoFDgZIW9Z5D3dqQtmV7bSNs/Zv5AoKmYouvmN0w== X-Google-Smtp-Source: AGHT+IHBFA+cH5958bx6/B07wZ/+XLQktMK13x4OjzkahXEnks5zyuH0RW3+E62V7jkfN4hmL/NqQQ== X-Received: by 2002:a05:6000:18ad:b0:39f:cfc:d520 with SMTP id ffacd0b85a97d-3a08fb52cf0mr1465639f8f.15.1746001665462; Wed, 30 Apr 2025 01:27:45 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a073c8d67esm16491272f8f.17.2025.04.30.01.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 01:27:45 -0700 (PDT) Date: Wed, 30 Apr 2025 11:27:42 +0300 From: Dan Carpenter To: Jai Luthra Cc: Tomi Valkeinen , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] media: i2c: ds90ub960: Fix uninitialized variable in ub960_rxport_bc_ser_config() Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "ret" variable is not initialized on success. Set it to zero. Fixes: e2a3b695bc5f ("media: i2c: ds90ub960: Configure serializer using bac= k-channel") Signed-off-by: Dan Carpenter Reviewed-By: Jai Luthra --- drivers/media/i2c/ds90ub960.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index cf104461b9a7..ed2cf9d247d1 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -2133,7 +2133,7 @@ static int ub960_rxport_bc_ser_config(struct ub960_rx= port *rxport) struct ub960_data *priv =3D rxport->priv; struct device *dev =3D &priv->client->dev; u8 nport =3D rxport->nport; - int ret; + int ret =3D 0; =20 /* Skip port if serializer's address is not known */ if (rxport->ser.addr < 0) { --=20 2.47.2