From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-69.smtpout.orange.fr [193.252.22.69]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16E8F18DF89 for ; Sat, 12 Apr 2025 06:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.69 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439154; cv=none; b=T3K+XH63XHsS1FusW1+amrcJw29uMIC7GooUAxDEkSQFkjQilQYfm24bwpKGLlDohg1T0Vgj29Y+9wugzBUssNfEeAEnfyRwvrsRUnX+cf/iqm4Y7weEJoMXRyR5mLsig8g6A+RKUbCWC1L2BJ4bNVSHu3SRsq+XWnVtH7vOADA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439154; c=relaxed/simple; bh=IAhsLA0/zEXzdcdk/cSylhKBYULt1RUYWwFyvQ5umJY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kGNdaZOM9QbDaG/Oc46G0/uwtQOFxU53BFoTJOxuPUSIH8CSJlSRxapp4oZ4ZZrG3S1LUdX8YbHQLeHTwJHsLXJqf58sgCIzqwYRkqPuVrqi1mHRmbVeTUK5FVHOk1r/++NmKftQD7fya6rolQvrH57C85TAHhBoGT6r5wCWKNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=PyDDP8rz; arc=none smtp.client-ip=193.252.22.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="PyDDP8rz" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UI4u7H5JdZ1m3UIAuov3C; Sat, 12 Apr 2025 08:24:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744439080; bh=UnY0gEG4q5ZXAVNgAZAHVIFGiZ9UkuNh2cMWLSm9czA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=PyDDP8rzMRfP2vu3JelU3kP4tIXDwXENsRYxI6MS/o1rFPlqOKjK/Er+YnPOscps0 xRupHwb/SDdPOjK/i9cONT60qHflTeKcX3oFHs+g7tfL5qXvhfsTbtTQfzx/oID+e4 v6BwaR/cJ0z2auv39qnUNlAK+sIbbB0/TSj3vnh5NI5AWBZPvCiC9OAvlI1E2lbMZA IQ4IZXln+xft+8sQtdcmWwOHnA463fm0anwJ1PWOgeOMtePmLWw4GEHLl9ikgMzodP W/KRNKqzfZR+M6KNpXlyJtzLN8Kz3KbeN9VJ63piz76iKR2TdkylcLysgEooUP+LYY OZhCUthi0FIpA== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:24:40 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 01/16] staging: gpib: agilent_82357a: fixes multiline comments style Date: Fri, 11 Apr 2025 23:21:53 -0700 Message-ID: <3ecb8bc6701ce7b3e5d098c10c2a2b75c9f155f0.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- .../staging/gpib/agilent_82357a/agilent_82357a.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index da229965d98e..2275d8ac8d30 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -524,9 +524,10 @@ static int agilent_82357a_read(struct gpib_board *boar= d, uint8_t *buffer, size_t } kfree(in_data); =20 - /* Fix for a bug in 9914A that does not return the contents of ADSR - * when the board is in listener active state and ATN is not asserted. - * Set ATN here to obtain a valid board level ibsta + /* + * Fix for a bug in 9914A that does not return the contents of ADSR + * when the board is in listener active state and ATN is not asserted. + * Set ATN here to obtain a valid board level ibsta */ agilent_82357a_take_control_internal(board, 0); =20 @@ -715,9 +716,10 @@ static int agilent_82357a_take_control(struct gpib_boa= rd *board, int synchronous if (!a_priv->bus_interface) return -ENODEV; =20 -/* It looks like the 9914 does not handle tcs properly. - * See comment above tms9914_take_control_workaround() in - * drivers/gpib/tms9914/tms9914_aux.c +/* + * It looks like the 9914 does not handle tcs properly. + * See comment above tms9914_take_control_workaround() in + * drivers/gpib/tms9914/tms9914_aux.c */ if (synchronous) return -ETIMEDOUT; --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-70.smtpout.orange.fr [193.252.22.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF3AD18D625 for ; Sat, 12 Apr 2025 06:25:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439153; cv=none; b=jFDhkfifTtsvyAom1Z847HdGEvbLqav/nM/v+vUfr0gfrTpfqCx9XRIaO2m7yoLOJjUlzt+aYmEENueMdb+MrsgLI/xzIYMBnIU/1R5GMnIp97sV6Yu6HYMcjUKaLvzJoICKhtLy56tkAKQ8iXJu0oVkPWP9V/TpcgSQn2gx7+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439153; c=relaxed/simple; bh=lPyIFdWe8cCysi4YaOYgh9rhKLE2LGD2GRB0Akzsb4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oAUuW/A2tLxQ5NhwCr1H3GWVlxoZHhpJEY6EGunC8ukxnzqM0cslTjjPUFWsNANT94vDqq3m96X7kM0BJThu0VINlA9y8yvatTF2Asv853FFKAm0Q6dvUA6G4ZwHK6xuht2fcfjvBkUHmSpX6HM5ZBDJ6fiGqzxVEx7y0NP1Tg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=Y6IXwY4j; arc=none smtp.client-ip=193.252.22.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="Y6IXwY4j" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UI4u7H5JdZ1m3UICuov7R; Sat, 12 Apr 2025 08:24:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744439082; bh=NM+fH7qiGwC50T/qCbhnnCq1sgqkLyAbaAAuVcX4cr4=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Y6IXwY4junAnE27N95ouK72RclgePNlnnEWesXAFZ1/n+v9qTSnhOC9Xe8FR0C0uh rTnDSQrb8vDiDSOgFnyqXBIIJ+TfX42wh3d6ncEcxH3rhpwyEF1CIPwglcGxc3cVHR 2oI+ETECqM2wdBfjkW0D7ubfwKL3VcMWhcKt3Yo2NaoYijAk6DOkogWet8yUMb33+n UjewhnUWWDhM5idF6Ey9O3a5jSu1NJd9gYDInZV4j6jeTbpJ721RIXYcZp3cm0xwm9 o/g1nZauJHRNNDdLBYQwsJwANrr2u5l6FVZKibkE7OB0bvf4R7GlwrW7ij8ESre8dA A5JIt8y9h0TrA== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:24:42 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 02/16] staging: gpib: cb7210: fixes multiline comments style Date: Fri, 11 Apr 2025 23:21:54 -0700 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/cb7210/cb7210.c | 9 +++++---- drivers/staging/gpib/cb7210/cb7210.h | 14 ++++++++------ 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb= 7210/cb7210.c index 6b22a33a8c4f..86aaef001924 100644 --- a/drivers/staging/gpib/cb7210/cb7210.c +++ b/drivers/staging/gpib/cb7210/cb7210.c @@ -905,7 +905,8 @@ static int cb7210_init(struct cb7210_priv *cb_priv, str= uct gpib_board *board) cb7210_write_byte(cb_priv, cb_priv->hs_mode_bits, HS_MODE); =20 write_byte(nec_priv, AUX_LO_SPEED, AUXMR); - /* set clock register for maximum (20 MHz) driving frequency + /* + * set clock register for maximum (20 MHz) driving frequency * ICR should be set to clock in megahertz (1-15) and to zero * for clocks faster than 15 MHz (max 20MHz) */ @@ -1275,9 +1276,9 @@ static int cb_gpib_config(struct pcmcia_device *link) } /* gpib_config */ =20 /* - * After a card is removed, gpib_release() will unregister the net - * device, and release the PCMCIA configuration. If the device is - * still open, this will be postponed until it is closed. + * After a card is removed, gpib_release() will unregister the net + * device, and release the PCMCIA configuration. If the device is + * still open, this will be postponed until it is closed. */ =20 static void cb_gpib_release(struct pcmcia_device *link) diff --git a/drivers/staging/gpib/cb7210/cb7210.h b/drivers/staging/gpib/cb= 7210/cb7210.h index 2108fe7a8ce5..ea92a81689fa 100644 --- a/drivers/staging/gpib/cb7210/cb7210.h +++ b/drivers/staging/gpib/cb7210/cb7210.h @@ -134,7 +134,8 @@ enum bus_status_bits { =20 /* CBI 488.2 HS control */ =20 -/* when both bit 0 and 1 are set, it +/* + * when both bit 0 and 1 are set, it * 1 clears the transmit state machine to an initial condition * 2 clears any residual interrupts left latched on cbi488.2 * 3 resets all control bits in HS_MODE to zero @@ -189,11 +190,12 @@ static inline unsigned int irq_bits(unsigned int irq) } =20 enum cb7210_aux_cmds { -/* AUX_RTL2 is an undocumented aux command which causes cb7210 to assert - * (and keep asserted) local rtl message. This is used in conjunction - * with the (stupid) cb7210 implementation - * of the normal nec7210 AUX_RTL aux command, which - * causes the rtl message to toggle between on and off. +/* + * AUX_RTL2 is an undocumented aux command which causes cb7210 to assert + * (and keep asserted) local rtl message. This is used in conjunction + * with the (stupid) cb7210 implementation + * of the normal nec7210 AUX_RTL aux command, which + * causes the rtl message to toggle between on and off. */ AUX_RTL2 =3D 0xd, AUX_LO_SPEED =3D 0x40, --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-70.smtpout.orange.fr [193.252.22.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 157C913AD1C for ; Sat, 12 Apr 2025 06:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439154; cv=none; b=I/uyJVhFG3mHajUI4a694U2wsmK16O30fnpAMsGZN3ySkhr5BJhP8WXblMfC7ns4Qz2G8rAqCRJzRbewg+YLtQfCBzA9gn/Nk2vsSk2Hq/XcH3BzAWKo2JYJyevEja2eFW3JUeA4gdSwZNTvhstEvoMi+DOsRry4bg1e1vMg4NY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439154; c=relaxed/simple; bh=325t6xAI6HmPt2h7UuYsI0IH+8YEuV8oarfXrv538hU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hq3litnPucBWsP/KjqysmoT0YHyKHVqeO9+iKOJl0o76NPFYni4Nt3Uz2KO2KefhxYhv3To61GPfnfOcN/6p9E6odzy1USW0oVQKw5aByoh/FfCYy5rjTIfmDqWGRSCidgJJzUFVqlHoQThX7xZTVBIsWqoHiPrHMixLJpslN0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=nC9QTDHV; arc=none smtp.client-ip=193.252.22.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="nC9QTDHV" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UI4u7H5JdZ1m3UIFuovBG; Sat, 12 Apr 2025 08:24:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744439084; bh=BTYeDY62fAwGNjpwRghfOx+adz/TljBBiQP6TNR/L8s=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=nC9QTDHVMh3HL0J3MbHTniIiBDQTSsxSVo0cYOdzPhG7ABgGg3kBi5+/Q3f/9OMwZ E4m3Xq501lgApdhdbyewjgBfIIKfuABSTyA3PfU7MN5aV2d6Pr1jZ+ZiI2hnZa7Pm2 Q4wUba9+x3CaB55rM3cptNep11f1EkANOQ7Bj0tTlr5H8wLHl8LBiYraW5JRzRpt7A tXAoKVsrk0S6f5vk3eflFyHRV+Kwzs5sk7IjWICoNv4S/iTVwqrtfai4uMIUj9CFXW W/bBo3O3o/3BCXtCYEL/70nLDmbpj8q04l70OecyRM9NK0RqZeJTPn756+52HHlx4m 0Bjr+BqLXQn6A== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:24:44 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 03/16] staging: gpib: common: fixes multiline comments style Date: Fri, 11 Apr 2025 23:21:55 -0700 Message-ID: <2ffeae1761ba77526e6aa7188f07d25a2f9a1950.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/common/gpib_os.c | 47 +++++++++++++++++---------- drivers/staging/gpib/common/iblib.c | 19 +++++++---- 2 files changed, 41 insertions(+), 25 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 8456b97290b8..12cd91a4c677 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -119,7 +119,8 @@ int io_timed_out(struct gpib_board *board) return 0; } =20 -/* this is a function instead of a constant because of Suse +/* + * this is a function instead of a constant because of Suse * defining HZ to be a function call to get_hz() */ static inline int pseudo_irq_period(void) @@ -291,7 +292,8 @@ int autopoll_all_devices(struct gpib_board *board) } =20 dev_dbg(board->gpib_dev, "complete\n"); - /* need to wake wait queue in case someone is + /* + * need to wake wait queue in case someone is * waiting on RQS */ wake_up_interruptible(&board->wait); @@ -665,8 +667,9 @@ long ibioctl(struct file *filep, unsigned int cmd, unsi= gned long arg) retval =3D board_info_ioctl(board, arg); goto done; case IBMUTEX: - /* Need to unlock board->big_gpib_mutex before potentially locking board= ->user_mutex - * to maintain consistent locking order + /* + * Need to unlock board->big_gpib_mutex before potentially locking board= ->user_mutex + * to maintain consistent locking order */ mutex_unlock(&board->big_gpib_mutex); return mutex_ioctl(board, file_priv, arg); @@ -736,8 +739,9 @@ long ibioctl(struct file *filep, unsigned int cmd, unsi= gned long arg) retval =3D take_control_ioctl(board, arg); goto done; case IBCMD: - /* IO ioctls can take a long time, we need to unlock board->big_gpib_mut= ex - * before we call them. + /* + * IO ioctls can take a long time, we need to unlock board->big_gpib_mut= ex + * before we call them. */ mutex_unlock(&board->big_gpib_mutex); return command_ioctl(file_priv, board, arg); @@ -760,8 +764,9 @@ long ibioctl(struct file *filep, unsigned int cmd, unsi= gned long arg) retval =3D query_board_rsv_ioctl(board, arg); goto done; case IBRD: - /* IO ioctls can take a long time, we need to unlock board->big_gpib_mut= ex - * before we call them. + /* + * IO ioctls can take a long time, we need to unlock board->big_gpib_mut= ex + * before we call them. */ mutex_unlock(&board->big_gpib_mutex); return read_ioctl(file_priv, board, arg); @@ -790,8 +795,9 @@ long ibioctl(struct file *filep, unsigned int cmd, unsi= gned long arg) retval =3D timeout_ioctl(board, arg); goto done; case IBWRT: - /* IO ioctls can take a long time, we need to unlock board->big_gpib_mut= ex - * before we call them. + /* + * IO ioctls can take a long time, we need to unlock board->big_gpib_mut= ex + * before we call them. */ mutex_unlock(&board->big_gpib_mutex); return write_ioctl(file_priv, board, arg); @@ -913,7 +919,8 @@ static int read_ioctl(gpib_file_private_t *file_priv, s= truct gpib_board *board, } read_cmd.completed_transfer_count =3D read_cmd.requested_transfer_count -= remain; read_cmd.end =3D end_flag; - /* suppress errors (for example due to timeout or interruption by device = clear) + /* + * suppress errors (for example due to timeout or interruption by device = clear) * if all bytes got sent. This prevents races that can occur in the vari= ous drivers * if a device receives a device clear immediately after a transfer compl= etes and * the driver code wasn't careful enough to handle that case. @@ -967,10 +974,11 @@ static int command_ioctl(gpib_file_private_t *file_pr= iv, if (!access_ok(userbuf, remain)) return -EFAULT; =20 - /* Write buffer loads till we empty the user supplied buffer. - * Call drivers at least once, even if remain is zero, in - * order to allow them to insure previous commands were - * completely finished, in the case of a restarted ioctl. + /* + * Write buffer loads till we empty the user supplied buffer. + * Call drivers at least once, even if remain is zero, in + * order to allow them to insure previous commands were + * completely finished, in the case of a restarted ioctl. */ =20 atomic_set(&desc->io_in_progress, 1); @@ -1068,7 +1076,8 @@ static int write_ioctl(gpib_file_private_t *file_priv= , struct gpib_board *board, break; } write_cmd.completed_transfer_count =3D write_cmd.requested_transfer_count= - remain; - /* suppress errors (for example due to timeout or interruption by device = clear) + /* + * suppress errors (for example due to timeout or interruption by device = clear) * if all bytes got sent. This prevents races that can occur in the vari= ous drivers * if a device receives a device clear immediately after a transfer compl= etes and * the driver code wasn't careful enough to handle that case. @@ -1116,7 +1125,8 @@ static int increment_open_device_count(struct gpib_bo= ard *board, struct list_hea struct list_head *list_ptr; gpib_status_queue_t *device; =20 - /* first see if address has already been opened, then increment + /* + * first see if address has already been opened, then increment * open count */ for (list_ptr =3D head->next; list_ptr !=3D head; list_ptr =3D list_ptr->= next) { @@ -1242,7 +1252,8 @@ static int open_dev_ioctl(struct file *filep, struct = gpib_board *board, unsigned if (retval < 0) return retval; =20 - /* clear stuck srq state, since we may be able to find service request on + /* + * clear stuck srq state, since we may be able to find service request on * the new device */ atomic_set(&board->stuck_srq, 0); diff --git a/drivers/staging/gpib/common/iblib.c b/drivers/staging/gpib/com= mon/iblib.c index b297261818f2..b05c26d47aa0 100644 --- a/drivers/staging/gpib/common/iblib.c +++ b/drivers/staging/gpib/common/iblib.c @@ -33,9 +33,10 @@ int ibcac(struct gpib_board *board, int sync, int fallba= ck_to_async) return 0; =20 if (sync && (status & LACS) =3D=3D 0) - /* tcs (take control synchronously) can only possibly work when - * controller is listener. Error code also needs to be -ETIMEDOUT - * or it will giveout without doing fallback. + /* + * tcs (take control synchronously) can only possibly work when + * controller is listener. Error code also needs to be -ETIMEDOUT + * or it will giveout without doing fallback. */ retval =3D -ETIMEDOUT; else @@ -50,7 +51,8 @@ int ibcac(struct gpib_board *board, int sync, int fallbac= k_to_async) return retval; } =20 -/* After ATN is asserted, it should cause any connected devices +/* + * After ATN is asserted, it should cause any connected devices * to start listening for command bytes and leave acceptor idle state. * So if ATN is asserted and neither NDAC or NRFD are asserted, * then there are no devices and ibcmd should error out immediately. @@ -218,7 +220,8 @@ int ibonline(struct gpib_board *board) board->interface->detach(board); return retval; } - /* nios2nommu on 2.6.11 uclinux kernel has weird problems + /* + * nios2nommu on 2.6.11 uclinux kernel has weird problems * with autospoll thread causing huge slowdowns */ #ifndef CONFIG_NIOS2 @@ -313,7 +316,8 @@ int ibrd(struct gpib_board *board, uint8_t *buf, size_t= length, int *end_flag, s if (retval < 0) return retval; } - /* XXX resetting timer here could cause timeouts take longer than they sh= ould, + /* + * XXX resetting timer here could cause timeouts take longer than they sh= ould, * since read_ioctl calls this * function in a loop, there is probably a similar problem with writes/co= mmands */ @@ -514,7 +518,8 @@ int general_ibstatus(struct gpib_board *board, const gp= ib_status_queue_t *device =20 if (board->private_data) { status =3D board->interface->update_status(board, clear_mask); - /* XXX should probably stop having drivers use TIMO bit in + /* + * XXX should probably stop having drivers use TIMO bit in * board->status to avoid confusion */ status &=3D ~TIMO; --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-70.smtpout.orange.fr [193.252.22.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA9477FD for ; Sat, 12 Apr 2025 06:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439152; cv=none; b=i2U4m53ajZycX1fnc1+l/fmXM9Q/rLqFtORusZTXSY1h6rPIY11rEPJrnXInE6WS3cthtMmOd/IpPiAENhOjlmeJYPXjF/1CoMJPz0ajbtM/JD49RDWGN2cbF8WnpQ86aTYTPU7o/PSpHLzccGcj1Nq8E6E3CfE5vstuWubXsso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439152; c=relaxed/simple; bh=lSN97m/THny4yQwhMPj6R5BDbaRm2P89lemSwdrQVfc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=thL0dIfuaO9Ki5qeZV5QKkfgQQW307q7CEqHacCDNrVFUsk1ZnPdjFVY2nlwmhCX5m3Pm/KET7jH4VAdtCkts0gEMyOQdkFeboX0Q41gA5zMoTl1p1fEZkh1W0YVFhVtXAXXF/Z4QTkswZtkbKpTbqFkuRkAk2TClKjGC4A09vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=nlynygVl; arc=none smtp.client-ip=193.252.22.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="nlynygVl" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UI4u7H5JdZ1m3UIHuovDz; Sat, 12 Apr 2025 08:24:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744439087; bh=c9ReeE86kF/374t3a4BHV3Ao7MfSs6fX9dP4Nmlbeak=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=nlynygVlKs6+fLo6h1S6ATsjCu7tNZCcZFL2zKxvqoXHfnocO65oRXSMfAkiP0lJL 5CekNIBHE0HQ6pd3N32iDnsmz7m6sZgBlOD4VJBTEm4C7XEsMbJ3lAakd0fX2Owzp7 pTEQ+m3NrDPv+braAW0FdWDRtJ0yNCA/xMkJTz2JuAFoF4AUwO1Nz9vrHoK/Z9YZMw +pUj+g4ay+hcMhpEyX0AY5cY7cfvzXelzcg22gowNkAu+UaNtkcB+wv4RBv+jGP6e+ 9joZTYHTszhduqrnbCIYlUIlMxAwyRzkQ6usCCtQOryb5YkhTl+laG7D5PFY10w8O4 d8AoGYbqeWfWA== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:24:47 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 04/16] staging: gpib: eastwood: fixes multiline comments style Date: Fri, 11 Apr 2025 23:21:56 -0700 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/eastwood/fluke_gpib.c | 51 ++++++++++++++-------- drivers/staging/gpib/eastwood/fluke_gpib.h | 17 +++++--- 2 files changed, 44 insertions(+), 24 deletions(-) diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/g= pib/eastwood/fluke_gpib.c index a6b1ac169f94..a782b2297b0c 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.c +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c @@ -254,7 +254,8 @@ static int lacs_or_read_ready(struct gpib_board *board) return retval; } =20 -/* Wait until it is possible for a read to do something useful. This +/* + * Wait until it is possible for a read to do something useful. This * is not essential, it only exists to prevent RFD holdoff from being rele= ased pointlessly. */ static int wait_for_read(struct gpib_board *board) @@ -276,7 +277,8 @@ static int wait_for_read(struct gpib_board *board) return retval; } =20 -/* Check if the SH state machine is in SGNS. We check twice since there i= s a very small chance +/* + * Check if the SH state machine is in SGNS. We check twice since there i= s a very small chance * we could be blowing through SGNS from SIDS to SDYS if there is already a * byte available in the handshake state machine. We are interested * in the case where the handshake is stuck in SGNS due to no byte being @@ -310,7 +312,8 @@ static int source_handshake_is_sids_or_sgns(struct fluk= e_priv *e_priv) (source_handshake_bits =3D=3D SOURCE_HANDSHAKE_SIDS_BITS); } =20 -/* Wait until the gpib chip is ready to accept a data out byte. +/* + * Wait until the gpib chip is ready to accept a data out byte. * If the chip is SGNS it is probably waiting for a a byte to * be written to it. */ @@ -441,7 +444,8 @@ static int fluke_dma_write(struct gpib_board *board, ui= nt8_t *buffer, size_t len if (test_bit(DMA_WRITE_IN_PROGRESS_BN, &nec_priv->state)) fluke_dma_callback(board); =20 - /* if everything went fine, try to wait until last byte is actually + /* + * if everything went fine, try to wait until last byte is actually * transmitted across gpib (but don't try _too_ hard) */ if (retval =3D=3D 0) @@ -508,7 +512,8 @@ static int fluke_accel_write(struct gpib_board *board, = uint8_t *buffer, size_t l if (WARN_ON_ONCE(remainder !=3D 1)) return -EFAULT; =20 - /* wait until we are sure we will be able to write the data byte + /* + * wait until we are sure we will be able to write the data byte * into the chip before we send AUX_SEOI. This prevents a timeout * scenerio where we send AUX_SEOI but then timeout without getting * any bytes into the gpib chip. This will result in the first byte @@ -539,8 +544,10 @@ static int fluke_get_dma_residue(struct dma_chan *chan= , dma_cookie_t cookie) return result; } dmaengine_tx_status(chan, cookie, &state); - // hardware doesn't support resume, so dont call this - // method unless the dma transfer is done. + /* + * hardware doesn't support resume, so dont call this + * method unless the dma transfer is done. + */ return state.residue; } =20 @@ -608,7 +615,8 @@ static int fluke_dma_read(struct gpib_board *board, uin= t8_t *buffer, if (test_bit(DEV_CLEAR_BN, &nec_priv->state)) retval =3D -EINTR; =20 - /* If we woke up because of end, wait until the dma transfer has pulled + /* + * If we woke up because of end, wait until the dma transfer has pulled * the data byte associated with the end before we cancel the dma transfe= r. */ if (test_bit(RECEIVED_END_BN, &nec_priv->state)) { @@ -625,7 +633,8 @@ static int fluke_dma_read(struct gpib_board *board, uin= t8_t *buffer, =20 // stop the dma transfer nec7210_set_reg_bits(nec_priv, IMR2, HR_DMAI, 0); - /* delay a little just to make sure any bytes in dma controller's fifo get + /* + * delay a little just to make sure any bytes in dma controller's fifo get * written to memory before we disable it */ usleep_range(10, 15); @@ -641,14 +650,17 @@ static int fluke_dma_read(struct gpib_board *board, u= int8_t *buffer, dma_unmap_single(board->dev, bus_address, length, DMA_FROM_DEVICE); memcpy(buffer, e_priv->dma_buffer, *bytes_read); =20 - /* If we got an end interrupt, figure out if it was + /* + * If we got an end interrupt, figure out if it was * associated with the last byte we dma'd or with a * byte still sitting on the cb7210. */ spin_lock_irqsave(&board->spinlock, flags); if (test_bit(READ_READY_BN, &nec_priv->state) =3D=3D 0) { - // There is no byte sitting on the cb7210. If we - // saw an end interrupt, we need to deal with it now + /* + * There is no byte sitting on the cb7210. If we + * saw an end interrupt, we need to deal with it now + */ if (test_and_clear_bit(RECEIVED_END_BN, &nec_priv->state)) *end =3D 1; } @@ -725,7 +737,8 @@ static gpib_interface_t fluke_unaccel_interface =3D { .return_to_local =3D fluke_return_to_local, }; =20 -/* fluke_hybrid uses dma for writes but not for reads. Added +/* + * fluke_hybrid uses dma for writes but not for reads. Added * to deal with occasional corruption of bytes seen when doing dma * reads. From looking at the cb7210 vhdl, I believe the corruption * is due to a hardware bug triggered by the cpu reading a cb7210 @@ -914,7 +927,8 @@ static int fluke_init(struct fluke_priv *e_priv, struct= gpib_board *board, int h =20 nec7210_board_reset(nec_priv, board); write_byte(nec_priv, AUX_LO_SPEED, AUXMR); - /* set clock register for driving frequency + /* + * set clock register for driving frequency * ICR should be set to clock in megahertz (1-15) and to zero * for clocks faster than 15 MHz (max 20MHz) */ @@ -933,7 +947,8 @@ static int fluke_init(struct fluke_priv *e_priv, struct= gpib_board *board, int h return 0; } =20 -/* This function is passed to dma_request_channel() in order to +/* + * This function is passed to dma_request_channel() in order to * select the pl330 dma channel which has been hardwired to * the gpib controller. */ @@ -1042,8 +1057,10 @@ static int fluke_attach_impl(struct gpib_board *boar= d, const gpib_board_config_t e_priv->dma_channel =3D dma_request_channel(dma_cap, gpib_dma_channel_fil= ter, NULL); if (!e_priv->dma_channel) { dev_err(board->gpib_dev, "failed to allocate a dma channel.\n"); - // we don't error out here because unaccel interface will still - // work without dma + /* + * we don't error out here because unaccel interface will still + * work without dma + */ } =20 return fluke_init(e_priv, board, handshake_mode); diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.h b/drivers/staging/g= pib/eastwood/fluke_gpib.h index 3e4348196b42..dfe2d3c60deb 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.h +++ b/drivers/staging/gpib/eastwood/fluke_gpib.h @@ -55,8 +55,10 @@ enum state1_bits { SOURCE_HANDSHAKE_MASK =3D 0x7 }; =20 -// we customized the cb7210 vhdl to give the "data in" status -// on the unused bit 7 of the address0 register. +/* + * we customized the cb7210 vhdl to give the "data in" status + * on the unused bit 7 of the address0 register. + */ enum cb7210_address0 { DATA_IN_STATUS =3D 0x80 }; @@ -124,11 +126,12 @@ enum bus_status_bits { }; =20 enum cb7210_aux_cmds { -/* AUX_RTL2 is an undocumented aux command which causes cb7210 to assert - * (and keep asserted) local rtl message. This is used in conjunction - * with the (stupid) cb7210 implementation - * of the normal nec7210 AUX_RTL aux command, which - * causes the rtl message to toggle between on and off. +/* + * AUX_RTL2 is an undocumented aux command which causes cb7210 to assert + * (and keep asserted) local rtl message. This is used in conjunction + * with the (stupid) cb7210 implementation + * of the normal nec7210 AUX_RTL aux command, which + * causes the rtl message to toggle between on and off. */ AUX_RTL2 =3D 0xd, AUX_NBAF =3D 0xe, // new byte available false (also clears seoi) --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (outm-51.smtpout.orange.fr [193.252.22.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D74708828 for ; Sat, 12 Apr 2025 06:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439580; cv=none; b=Jr/n4my1njkxchL785xOGRJZlBHH/MZ5XADq6GjGZCH9jRDjK4+cH6EHrqupDkY4Mo9+l8Bps7nIObi7laHqV/w6SOMVmL84atyO/FYyjuXexcourNa1zuQyI1nr5KeSg71CnBW5PjgzhSdxbQwP3k39hXygecuVomqDl4FKGjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439580; c=relaxed/simple; bh=hVrTVhkxm+kDr6N2u4Zlx+XVHZLk8fgc8MojQnk3Or0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lzpCAC1xuEcV+ygHBY/gkjrrj7awNl2j7IypdNIu57SArHui3Ao4+MFiqACFT1YqEo+GpwSV5PVFKUmVzrZRajXpZNZfhhoaoAv99BC6ulj9ug8I9vGEf9vGPq6FsDvEiIah86YaVCOQZu6XDawI2iBfeF4ZQyCeQJCUmd6AKVs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=AOUjC0dU; arc=none smtp.client-ip=193.252.22.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="AOUjC0dU" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UP1uRIIxiefY3UP5upciJ; Sat, 12 Apr 2025 08:31:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744439509; bh=jr8S9LErN5v/hyKCUiP39DDZItTOS468y0EMeWscIAY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=AOUjC0dUb17orMdpzspkHd1u7i3jcOtgRDhRFddWXu4jDEc6J9RWAa00Xvw0ujVf6 agRjhDEx/ot9IU9uKGD4pu7Et9twusq92FlXUl9Xn+TWaDPYrvncloiIWq95/XwYdO bHsD1WoUdsyASgDFCpCZP9tSGAe82nSrnfH8cNHXa5F+Vxd2HO0bKL7lZLWMhYo/Cz uil/wnnYuTzvz5R3rTlYPJJzQ+wgyBeOKsBYJLuZnMIkIkSJOs4/eeywEnS2ShaHeF ruT9OGMGhmINLxzw+cpspy0yyBAHdjKQCP/YQszlOF8ljPJwo9BOHkwoNZsAYNmuc6 uMXj2qdMvFekg== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:31:49 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 05/16] staging: gpib: fmh_gpib: fixes multiline comments style Date: Fri, 11 Apr 2025 23:31:37 -0700 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 66 ++++++++++++++++-------- 1 file changed, 44 insertions(+), 22 deletions(-) diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpi= b/fmh_gpib/fmh_gpib.c index 53f4b3fccc3c..8a2f758c828b 100644 --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c @@ -169,7 +169,8 @@ static void fmh_gpib_local_parallel_poll_mode(struct gp= ib_board *board, int loca if (local) { write_byte(&priv->nec7210_priv, AUX_I_REG | LOCAL_PPOLL_MODE_BIT, AUXMR); } else { - /* For fmh_gpib_core, remote parallel poll config mode is unaffected by = the + /* + * For fmh_gpib_core, remote parallel poll config mode is unaffected by = the * state of the disable bit of the parallel poll register (unlike the tn= t4882). * So, we don't need to worry about that. */ @@ -195,7 +196,8 @@ static void fmh_gpib_serial_poll_response2(struct gpib_= board *board, uint8_t sta } =20 if (reqt) { - /* It may seem like a race to issue reqt before updating + /* + * It may seem like a race to issue reqt before updating * the status byte, but it is not. The chip does not * issue the reqt until the SPMR is written to at * a later time. @@ -204,7 +206,8 @@ static void fmh_gpib_serial_poll_response2(struct gpib_= board *board, uint8_t sta } else if (reqf) { write_byte(&priv->nec7210_priv, AUX_REQF, AUXMR); } - /* We need to always zero bit 6 of the status byte before writing it to + /* + * We need to always zero bit 6 of the status byte before writing it to * the SPMR to insure we are using * serial poll mode SP1, and not accidentally triggering mode SP3. */ @@ -333,7 +336,8 @@ static int wait_for_rx_fifo_half_full_or_end(struct gpi= b_board *board) return retval; } =20 -/* Wait until the gpib chip is ready to accept a data out byte. +/* + * Wait until the gpib chip is ready to accept a data out byte. */ static int wait_for_data_out_ready(struct gpib_board *board) { @@ -377,7 +381,8 @@ static void fmh_gpib_dma_callback(void *arg) spin_unlock_irqrestore(&board->spinlock, flags); } =20 -/* returns true when all the bytes of a write have been transferred to +/* + * returns true when all the bytes of a write have been transferred to * the chip and successfully transferred out over the gpib bus. */ static int fmh_gpib_all_bytes_are_sent(struct fmh_priv *e_priv) @@ -523,7 +528,8 @@ static int fmh_gpib_accel_write(struct gpib_board *boar= d, uint8_t *buffer, if (WARN_ON_ONCE(remainder !=3D 1)) return -EFAULT; =20 - /* wait until we are sure we will be able to write the data byte + /* + * wait until we are sure we will be able to write the data byte * into the chip before we send AUX_SEOI. This prevents a timeout * scenario where we send AUX_SEOI but then timeout without getting * any bytes into the gpib chip. This will result in the first byte @@ -554,8 +560,10 @@ static int fmh_gpib_get_dma_residue(struct dma_chan *c= han, dma_cookie_t cookie) return result; } dmaengine_tx_status(chan, cookie, &state); - // dma330 hardware doesn't support resume, so dont call this - // method unless the dma transfer is done. + /* + * dma330 hardware doesn't support resume, so dont call this + * method unless the dma transfer is done. + */ return state.residue; } =20 @@ -581,7 +589,8 @@ static int wait_for_tx_fifo_half_empty(struct gpib_boar= d *board) return retval; } =20 -/* supports writing a chunk of data whose length must fit into the hardwar= e'd xfer counter, +/* + * supports writing a chunk of data whose length must fit into the hardwar= e'd xfer counter, * called in a loop by fmh_gpib_fifo_write() */ static int fmh_gpib_fifo_write_countable(struct gpib_board *board, uint8_t= *buffer, @@ -768,8 +777,10 @@ static int fmh_gpib_dma_read(struct gpib_board *board,= uint8_t *buffer, // stop the dma transfer nec7210_set_reg_bits(nec_priv, IMR2, HR_DMAI, 0); fifos_write(e_priv, 0, FIFO_CONTROL_STATUS_REG); - // give time for pl330 to transfer any in-flight data, since - // pl330 will throw it away when dmaengine_pause is called. + /* + * give time for pl330 to transfer any in-flight data, since + * pl330 will throw it away when dmaengine_pause is called. + */ usleep_range(10, 15); residue =3D fmh_gpib_get_dma_residue(e_priv->dma_channel, dma_cookie); if (WARN_ON_ONCE(residue > length || residue < 0)) @@ -793,14 +804,17 @@ static int fmh_gpib_dma_read(struct gpib_board *board= , uint8_t *buffer, buffer[(*bytes_read)++] =3D fifos_read(e_priv, FIFO_DATA_REG) & fifo_dat= a_mask; } =20 - /* If we got an end interrupt, figure out if it was + /* + * If we got an end interrupt, figure out if it was * associated with the last byte we dma'd or with a * byte still sitting on the cb7210. */ spin_lock_irqsave(&board->spinlock, flags); if (*bytes_read > 0 && test_bit(READ_READY_BN, &nec_priv->state) =3D=3D 0= ) { - // If there is no byte sitting on the cb7210 and we - // saw an end, we need to deal with it now + /* + * If there is no byte sitting on the cb7210 and we + * saw an end, we need to deal with it now + */ if (test_and_clear_bit(RECEIVED_END_BN, &nec_priv->state)) *end =3D 1; } @@ -819,7 +833,8 @@ static void fmh_gpib_release_rfd_holdoff(struct gpib_bo= ard *board, struct fmh_pr =20 ext_status_1 =3D read_byte(nec_priv, EXT_STATUS_1_REG); =20 - /* if there is an end byte sitting on the chip, don't release + /* + * if there is an end byte sitting on the chip, don't release * holdoff. We want it left set after we read out the end * byte. */ @@ -828,7 +843,8 @@ static void fmh_gpib_release_rfd_holdoff(struct gpib_bo= ard *board, struct fmh_pr if (ext_status_1 & RFD_HOLDOFF_STATUS_BIT) write_byte(nec_priv, AUX_FH, AUXMR); =20 - /* Check if an end byte raced in before we executed the AUX_FH command. + /* + * Check if an end byte raced in before we executed the AUX_FH command. * If it did, we want to make sure the rfd holdoff is in effect. The end * byte can arrive since * AUX_RFD_HOLDOFF_ASAP doesn't immediately force the acceptor handshake @@ -893,7 +909,8 @@ static int fmh_gpib_accel_read(struct gpib_board *board= , uint8_t *buffer, size_t return retval; } =20 -/* Read a chunk of data whose length is within the limits of the hardware's +/* + * Read a chunk of data whose length is within the limits of the hardware's * xfer counter. Called in a loop from fmh_gpib_fifo_read(). */ static int fmh_gpib_fifo_read_countable(struct gpib_board *board, uint8_t = *buffer, @@ -969,7 +986,8 @@ static int fmh_gpib_fifo_read(struct gpib_board *board,= uint8_t *buffer, size_t *end =3D 0; *bytes_read =3D 0; =20 - /* Do a little prep with data in interrupt so that following wait_for_rea= d() + /* + * Do a little prep with data in interrupt so that following wait_for_rea= d() * will wake up if a data byte is received. */ nec7210_set_reg_bits(nec_priv, IMR1, HR_DIIE, HR_DIIE); @@ -1166,7 +1184,8 @@ irqreturn_t fmh_gpib_internal_interrupt(struct gpib_b= oard *board) clear_bit(RFD_HOLDOFF_BN, &nec_priv->state); =20 if (ext_status_1 & END_STATUS_BIT) { - /* only set RECEIVED_END while there is still a data + /* + * only set RECEIVED_END while there is still a data * byte sitting in the chip, to avoid spuriously * setting it multiple times after it has been cleared * during a read. @@ -1179,7 +1198,8 @@ irqreturn_t fmh_gpib_internal_interrupt(struct gpib_b= oard *board) =20 if ((fifo_status & TX_FIFO_HALF_EMPTY_INTERRUPT_IS_ENABLED) && (fifo_status & TX_FIFO_HALF_EMPTY)) { - /* We really only want to clear the + /* + * We really only want to clear the * TX_FIFO_HALF_EMPTY_INTERRUPT_ENABLE bit in the * FIFO_CONTROL_STATUS_REG. Since we are not being * careful, this also has a side effect of disabling @@ -1193,7 +1213,8 @@ irqreturn_t fmh_gpib_internal_interrupt(struct gpib_b= oard *board) =20 if ((fifo_status & RX_FIFO_HALF_FULL_INTERRUPT_IS_ENABLED) && (fifo_status & RX_FIFO_HALF_FULL)) { - /* We really only want to clear the + /* + * We really only want to clear the * RX_FIFO_HALF_FULL_INTERRUPT_ENABLE bit in the * FIFO_CONTROL_STATUS_REG. Since we are not being * careful, this also has a side effect of disabling @@ -1444,7 +1465,8 @@ static int fmh_gpib_attach_impl(struct gpib_board *bo= ard, const gpib_board_confi return -EIO; } } - /* in the future we might want to know the half-fifo size + /* + * in the future we might want to know the half-fifo size * (dma_burst_length) even when not using dma, so go ahead an * initialize it unconditionally. */ --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-16.smtpout.orange.fr [193.252.22.16]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31E8B14EC73 for ; Sat, 12 Apr 2025 06:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439684; cv=none; b=Cagu2Gl4t7a0YZOW1uZQnKna12DWkKHfbViElD9DvMgrLhNQ/5E6Dt2buHZTs1g8ZhvnTpSV1NH1ptkHm9ANz6w0Oql9fLyxl4prTbMJg5Tfrc8a8gnJPLDHYWhg0a+CMrPM5U+LBeAQojV5ahU8SdpouE3arBqnOzAA8aWyZmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439684; c=relaxed/simple; bh=LZ03fjekvVWXEAMSKHSwO5p1QE9Copk4oc6W9a9wg3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Galwn+OYvSKFXFQoONbqKILwGq7Fzfldfx5ECKkB6n5njFuLOyRRN4v8OvwGo/ErRCYc0qdQHri3Ds1hF5v3QvLRtZ1hcVnoAz5Aq55s9Yp7wumsNRrCuHm0qBrepjNkmReh/fs9TE2iKgywE7YjMNyEJf7rlknEmxJgFrrmigM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=SCYmuN19; arc=none smtp.client-ip=193.252.22.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="SCYmuN19" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3URhuYTtAiSFB3URkuke9C; Sat, 12 Apr 2025 08:34:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744439675; bh=ViZkdHUhRet3So6CMJzrcaKkByL778r7/I6kMxf+EB8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=SCYmuN191ZLdWQkC3jFqJ9dZS9Y25Kat+LSiyihk3h1bhQOQBnJG3FfZnZ66U0K++ byE8w6XTmao3DdbRQ/ydNjHUQybD2mE3mLPOqi1h2vMAd64pnZ9zEt9g7PagV75rLw tSuu2Btj3JN2PX9A0hV0o3DaBImgA8oB6/Uv3cHvvHkRIc9XtJJ5orOR77TG+RTFWj VnKF/ZmI7G7p+Q+s0q2fLIx5ekL6Q43Boqde3mTS5qGUum4Mj/4h9YxTXRh6fPx39c ThTGQL4kpj8cVpqQhJ8kh4afi2CHos36wFzvTSxmpPmM9w1DiHE/u/8XKyMb+8i7OD NwC363eGLAsCA== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:34:35 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 06/16] staging: gpib: gpio: fixes multiline comments style Date: Fri, 11 Apr 2025 23:34:25 -0700 Message-ID: <44c064ed914fef384800e94ac99d00af5ff5f13b.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/gpio/gpib_bitbang.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpi= b/gpio/gpib_bitbang.c index 86bdd381472a..97ae80e8ee3b 100644 --- a/drivers/staging/gpib/gpio/gpib_bitbang.c +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c @@ -32,7 +32,8 @@ #define ENABLE_IRQ(IRQ, TYPE) irq_set_irq_type(IRQ, TYPE) #define DISABLE_IRQ(IRQ) irq_set_irq_type(IRQ, IRQ_TYPE_NONE) =20 -/* Debug print levels: +/* + * Debug print levels: * 0 =3D load/unload info and errors that make the driver fail; * 1 =3D + warnings for unforeseen events that may break the current * operation and lead to a timeout, but do not affect the @@ -1256,7 +1257,8 @@ static int bb_attach(struct gpib_board *board, const = gpib_board_config_t *config if (allocate_gpios(board)) goto bb_attach_fail; =20 -/* Configure SN7516X control lines. +/* + * Configure SN7516X control lines. * drive ATN, IFC and REN as outputs only when master * i.e. system controller. In this mode can only be the CIC * When not master then enable device mode ATN, IFC & REN as inputs --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (outm-51.smtpout.orange.fr [193.252.22.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E68A14EC73 for ; Sat, 12 Apr 2025 06:37:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439864; cv=none; b=WH979UIhI0HxMoJPiF61zsMDJ3to5ZvOQlX3DMM3sxLdIZwpKDiFJgrso6YGN2nUWE9r5UAPcYR3P6p6U+O4IxTaPuZszD/UhDbbruKS0TofhAVpDdMOgALh26xqCBbmIKBWVWOLNdtylcwI9tJhM/ALJ7Slb9P5YrEHWe+iH9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744439864; c=relaxed/simple; bh=GWpst8nYkDoq9Pz2hqWVI6ZEKnv7GsxDoDu0ZjjsHU0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VjBGlw8nTlw4VJYg7XBPP8t2YOviZJ0UyOXOp4q34ugEluwE4UTqK/p11LkhwdlapSSrrggUc9d10mqpVE+7IpVLIQ09SnrVgiaxakEyPWCLIQQBkGPBUhLqnci+u/7lhDy0bXl+ANCbGEU60igBZc0uTL9DtCeTGMkKVZL/frk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=nYDxPLVg; arc=none smtp.client-ip=193.252.22.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="nYDxPLVg" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UUgulSZJBkGO3UUlu5T4W; Sat, 12 Apr 2025 08:37:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744439861; bh=TsJ6G2PB784E5CZ0z44RMlKXhavUEi1mq83Q1cDFTrw=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=nYDxPLVgOng/KaFLF6zPkG5hrLdBygLxC7dB2pSJXM/I/INXZ/kQO1c9HSdt4u5/s 85cMkL2ro4eNOZyjiynR1LC8xVya0TiTKdiL7CAWgTt2SqOZCCYIwdELrXJ5ij7Kwf Mrx1tapb5RqBI7XXVLY8kVIFV2FUTumo2GepvzcENhhv46Bq1vl5PxSlhgZpB3nmz1 qmlnyeOJsZDrKgdTLI1Z1mj6zBSYA5nW4f+lSli83DC27Wa0rhpIjAhMZWm2+myLtD bAj6NXSeXqnJHglicHX8++2ekXfxC+cGyq7qvceQm0pWOx+6eI5Mtf7PlI7nHiE5wp nUzdVRoWpNBQg== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:37:41 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 07/16] staging: gpib: hp_82335: fixes multiline comments style Date: Fri, 11 Apr 2025 23:37:25 -0700 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/hp_82335/hp82335.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib= /hp_82335/hp82335.c index fd23b1cb80f9..ec531c2b174f 100644 --- a/drivers/staging/gpib/hp_82335/hp82335.c +++ b/drivers/staging/gpib/hp_82335/hp82335.c @@ -4,8 +4,9 @@ * copyright : (C) 2002 by Frank Mori Hess = * *************************************************************************= **/ =20 -/*should enable ATN interrupts (and update board->status on occurrence), - * implement recovery from bus errors (if necessary) +/* + * should enable ATN interrupts (and update board->status on occurrence), + * implement recovery from bus errors (if necessary) */ =20 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-14.smtpout.orange.fr [193.252.22.14]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A1F84037 for ; Sat, 12 Apr 2025 06:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440155; cv=none; b=syXOgXdOdMoWGe7wLe9oqezqlnbMvsCpDfTKOpYw+PxDuxY5CLaUn7KbfFXS2kjhNfSHUESUZYDtchDZVxdZBy/02GWzVaWdMMt+WRJFmKxKEEmeIxRNku4QGhI8hNG8WjsdFRFuN+cnNRrcP+3tY/iCpuWASSnlwyyK4dcdnDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440155; c=relaxed/simple; bh=Pbg91NGVaIppdXiCQrAk27vgVtrjkiG606Woz1tENV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K1c323WQm2RqBOKip+Llr7dgvgP7dldssz9QLkHduYTC3UK0WR0ivZjRAyfKUdkEr6henT6/cUx608byoVex+jAY7ewsNnvmcnrYWUzbPwcInHIoaOyd2mo8b6OX2pfas9Lzy0u+AHCyrNgtcjSsNWxiQfwX6goCHTC9fnood+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=X0xjjADn; arc=none smtp.client-ip=193.252.22.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="X0xjjADn" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UYwuQskrdrQ13UZ1u9Tdl; Sat, 12 Apr 2025 08:42:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744440125; bh=qmcOzlOI/g3RKdkTnvlzTmINQekNCm3D9C0EIorAHIE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=X0xjjADn1UsDPY3SskDqS30cuzEVbuKLhE22gn35wZGqrxLC09dIwQB5jPX3G0SF/ TIR9evw4kBke0nsyqQeQyaSAZEiyWb9J1QtRX50f7c22NyEgTNiQzAvjTWpHPhQ7tb u0L+O+xqWIQdaJgtC4+Ymj6bsR0pJb846I8NZFSTVveQi+i0eJCm2GYGtyYRyf2j7j U/BsrPzl1x0cGksPBl0rg2zUGCBoZrPlcl7ZEaqhE4R0Nn9WSToDNoitJfBecFGahg rff8hSSTv0wzay8JNn8LncvrmyTPxYLNeOhvC/lG6Hgs6npHryZwQurCscp0lXAMJ1 Jx/doC6wiN7gQ== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:42:05 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 08/16] staging: gpib: hp_82341: fixes multiline comments style Date: Fri, 11 Apr 2025 23:42:14 -0700 Message-ID: <5bc4da465b2df932b7cb7783012786a7220a2e2a.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/hp_82341/hp_82341.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpi= b/hp_82341/hp_82341.c index f52e673dc869..0b1f923de24a 100644 --- a/drivers/staging/gpib/hp_82341/hp_82341.c +++ b/drivers/staging/gpib/hp_82341/hp_82341.c @@ -51,11 +51,12 @@ static int hp_82341_accel_read(struct gpib_board *board= , uint8_t *buffer, size_t return 0; //disable fifo for the moment outb(DIRECTION_GPIB_TO_HOST_BIT, hp_priv->iobase[3] + BUFFER_CONTROL_REG); - // Handle corner case of board not in holdoff and one byte has slipped in= already. - // Also, board sometimes has problems (spurious 1 byte reads) when read f= ifo is - // started up with board in - // TACS under certain data holdoff conditions. Doing a 1 byte tms9914-st= yle - // read avoids these problems. + /* + * Handle corner case of board not in holdoff and one byte has slipped in= already. + * Also, board sometimes has problems (spurious 1 byte reads) when read f= ifo is + * started up with board in TACS under certain data holdoff conditions. + * Doing a 1 byte tms9914-style read avoids these problems. + */ if (/*tms_priv->holdoff_active =3D=3D 0 && */length > 1) { size_t num_bytes; =20 --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (outm-50.smtpout.orange.fr [193.252.22.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5F2C1862 for ; Sat, 12 Apr 2025 06:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440410; cv=none; b=KabWGX2HCQPnFCkPkM0v93saLk28hjus0AiElLp/0zfH32ze33MDyVsyPdkiejML/DpTfFKJQ3RsR2uPf9o3cXHjZHspqlyRF3g0WWjphr6loADNNtK4zIkcWcN8xT8VK58/Yja1R4GePPqyCbqYmMA4dfj45a0+vLP/yUuJ8sM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440410; c=relaxed/simple; bh=qOIvLc6Jo3QX+enzkD1QoTBG99HrID9MKHAd92DD4lU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hwc36WDgrBJSqStaafg0VeEMLhr2UChfHja0evDB+U3+/zSe9gwic8nVo7+Fqq28K8uOZAy7Kq7lML7z0VH6DhNxfAEVkalAa8VOtv6+g2gTneCd2kpK0Pu/qzrQXymuEtZmV9zfYO0xFWYH9PProz4rNAxkgX0qWfpZ/rzyqq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=sd3uzJuu; arc=none smtp.client-ip=193.252.22.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="sd3uzJuu" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UcNul94nQxp63UcRuFtC3; Sat, 12 Apr 2025 08:45:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744440338; bh=kl5hACu3fbUlT4qqCG0brbsgDnD7DKEFvoE5aGuYHiI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=sd3uzJuuO5OgQSyOjtya1viOYcaF8mkKpl2SrZeL5LohadEf+wFkzPDiLeuJT6XM/ moftKAW8Ej2NlrwL00YZBzD8pZSuQdscbhe/JjSxuj/rp4cSZdT13tDlzvsbvr7/AO XgCqVdY+QsD6LVCeCmkTbkw1WQDDVmsY9NqupRfkRmeq1FQwM0o5CD5ZsLosCQuz1b R+PWdCUZ6W72nZ1UN2yY11vk4u7xtK7ph6ILZd87MYe13hONuNfxMfPW3CY6NJEr3Q /JfuQWzwAAhU2otBPCdelOf1YNy8zlOKBWbIutm4Xp9JEFbUYIEVJbscl7ULNULaOT tWI5XPAPTStiA== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:45:38 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 09/16] staging: gpib: include: fixes multiline comments style Date: Fri, 11 Apr 2025 23:45:22 -0700 Message-ID: <740f5ae0cf149ce9729c9d8288ac4fa20ec4ebb3.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/include/gpib_types.h | 81 ++++++++++++------- .../staging/gpib/include/nec7210_registers.h | 3 +- drivers/staging/gpib/include/tms9914.h | 6 +- 3 files changed, 60 insertions(+), 30 deletions(-) diff --git a/drivers/staging/gpib/include/gpib_types.h b/drivers/staging/gp= ib/include/gpib_types.h index 2d9b9be683f8..8cea658078e2 100644 --- a/drivers/staging/gpib/include/gpib_types.h +++ b/drivers/staging/gpib/include/gpib_types.h @@ -8,7 +8,8 @@ #define _GPIB_TYPES_H =20 #ifdef __KERNEL__ -/* gpib_interface_t defines the interface +/* + * gpib_interface_t defines the interface * between the board-specific details dealt with in the drivers * and generic interface provided by gpib-common. * This really should be in a different header file. @@ -37,11 +38,13 @@ typedef struct { unsigned int ibirq; /* dma channel to use for non-pnp cards (set by core, driver should make = local copy) */ unsigned int ibdma; - /* pci bus of card, useful for distinguishing multiple identical pci cards + /* + * pci bus of card, useful for distinguishing multiple identical pci cards * (negative means don't care) */ int pci_bus; - /* pci slot of card, useful for distinguishing multiple identical pci car= ds + /* + * pci slot of card, useful for distinguishing multiple identical pci car= ds * (negative means don't care) */ int pci_slot; @@ -58,7 +61,8 @@ struct gpib_interface_struct { int (*attach)(struct gpib_board *board, const gpib_board_config_t *config= ); /* detach() shuts down board and frees resources */ void (*detach)(struct gpib_board *board); - /* read() should read at most 'length' bytes from the bus into + /* + * read() should read at most 'length' bytes from the bus into * 'buffer'. It should return when it fills the buffer or * encounters an END (EOI and or EOS if appropriate). It should set 'end' * to be nonzero if the read was terminated by an END, otherwise 'end' @@ -70,39 +74,46 @@ struct gpib_interface_struct { */ int (*read)(struct gpib_board *board, uint8_t *buffer, size_t length, int= *end, size_t *bytes_read); - /* write() should write 'length' bytes from buffer to the bus. + /* + * write() should write 'length' bytes from buffer to the bus. * If the boolean value send_eoi is nonzero, then EOI should * be sent along with the last byte. Returns number of bytes * written or negative value on error. */ int (*write)(struct gpib_board *board, uint8_t *buffer, size_t length, in= t send_eoi, size_t *bytes_written); - /* command() writes the command bytes in 'buffer' to the bus + /* + * command() writes the command bytes in 'buffer' to the bus * Returns zero on success or negative value on error. */ int (*command)(struct gpib_board *board, uint8_t *buffer, size_t length, size_t *bytes_written); - /* Take control (assert ATN). If 'asyncronous' is nonzero, take + /* + * Take control (assert ATN). If 'asyncronous' is nonzero, take * control asyncronously (assert ATN immediately without waiting * for other processes to complete first). Should not return * until board becomes controller in charge. Returns zero no success, * nonzero on error. */ int (*take_control)(struct gpib_board *board, int asyncronous); - /* De-assert ATN. Returns zero on success, nonzer on error. + /* + * De-assert ATN. Returns zero on success, nonzer on error. */ int (*go_to_standby)(struct gpib_board *board); /* request/release control of the IFC and REN lines (system controller) */ void (*request_system_control)(struct gpib_board *board, int request_cont= rol); - /* Asserts or de-asserts 'interface clear' (IFC) depending on + /* + * Asserts or de-asserts 'interface clear' (IFC) depending on * boolean value of 'assert' */ void (*interface_clear)(struct gpib_board *board, int assert); - /* Sends remote enable command if 'enable' is nonzero, disables remote mo= de + /* + * Sends remote enable command if 'enable' is nonzero, disables remote mo= de * if 'enable' is zero */ void (*remote_enable)(struct gpib_board *board, int enable); - /* enable END for reads, when byte 'eos' is received. If + /* + * enable END for reads, when byte 'eos' is received. If * 'compare_8_bits' is nonzero, then all 8 bits are compared * with the eos bytes. Otherwise only the 7 least significant * bits are compared. @@ -118,26 +129,31 @@ struct gpib_interface_struct { void (*parallel_poll_response)(struct gpib_board *board, int ist); /* select local parallel poll configuration mode PP2 versus remote PP1 */ void (*local_parallel_poll_mode)(struct gpib_board *board, int local); - /* Returns current status of the bus lines. Should be set to + /* + * Returns current status of the bus lines. Should be set to * NULL if your board does not have the ability to query the * state of the bus lines. */ int (*line_status)(const struct gpib_board *board); - /* updates and returns the board's current status. + /* + * updates and returns the board's current status. * The meaning of the bits are specified in gpib_user.h * in the IBSTA section. The driver does not need to * worry about setting the CMPL, END, TIMO, or ERR bits. */ unsigned int (*update_status)(struct gpib_board *board, unsigned int clea= r_mask); - /* Sets primary address 0-30 for gpib interface card. + /* + * Sets primary address 0-30 for gpib interface card. */ int (*primary_address)(struct gpib_board *board, unsigned int address); - /* Sets and enables, or disables secondary address 0-30 + /* + * Sets and enables, or disables secondary address 0-30 * for gpib interface card. */ int (*secondary_address)(struct gpib_board *board, unsigned int address, int enable); - /* Sets the byte the board should send in response to a serial poll. + /* + * Sets the byte the board should send in response to a serial poll. * This function should also start or stop requests for service via * IEEE 488.2 reqt/reqf, based on MSS (bit 6 of the status_byte). * If the more flexible serial_poll_response2 is implemented by the @@ -150,7 +166,8 @@ struct gpib_interface_struct { * STB, reqt, and reqf". */ void (*serial_poll_response)(struct gpib_board *board, uint8_t status_byt= e); - /* Sets the byte the board should send in response to a serial poll. + /* + * Sets the byte the board should send in response to a serial poll. * This function should also request service via IEEE 488.2 reqt/reqf * based on MSS (bit 6 of the status_byte) and new_reason_for_service. * reqt should be set true if new_reason_for_service is true, @@ -166,7 +183,8 @@ struct gpib_interface_struct { */ void (*serial_poll_response2)(struct gpib_board *board, uint8_t status_by= te, int new_reason_for_service); - /* returns the byte the board will send in response to a serial poll. + /* + * returns the byte the board will send in response to a serial poll. */ uint8_t (*serial_poll_status)(struct gpib_board *board); /* adjust T1 delay */ @@ -216,14 +234,16 @@ typedef struct gpib_interface_list_struct { struct module *module; } gpib_interface_list_t; =20 -/* One struct gpib_board is allocated for each physical board in the compu= ter. +/* + * One struct gpib_board is allocated for each physical board in the compu= ter. * It provides storage for variables local to each board, and interface * functions for performing operations on the board */ struct gpib_board { /* functions used by this board */ gpib_interface_t *interface; - /* Pointer to module whose use count we should increment when + /* + * Pointer to module whose use count we should increment when * interface is in use */ struct module *provider_module; @@ -231,20 +251,24 @@ struct gpib_board { u8 *buffer; /* length of buffer */ unsigned int buffer_length; - /* Used to hold the board's current status (see update_status() above) + /* + * Used to hold the board's current status (see update_status() above) */ unsigned long status; - /* Driver should only sleep on this wait queue. It is special in that the + /* + * Driver should only sleep on this wait queue. It is special in that the * core will wake this queue and set the TIMO bit in 'status' when the * watchdog timer times out. */ wait_queue_head_t wait; - /* Lock that only allows one process to access this board at a time. + /* + * Lock that only allows one process to access this board at a time. * Has to be first in any locking order, since it can be locked over * multiple ioctls. */ struct mutex user_mutex; - /* Mutex which compensates for removal of "big kernel lock" from kernel. + /* + * Mutex which compensates for removal of "big kernel lock" from kernel. * Should not be held for extended waits. */ struct mutex big_gpib_mutex; @@ -259,7 +283,8 @@ struct gpib_board { struct device *dev; /* gpib_common device gpibN */ struct device *gpib_dev; - /* 'private_data' can be used as seen fit by the driver to + /* + * 'private_data' can be used as seen fit by the driver to * store additional variables for this board */ void *private_data; @@ -296,7 +321,8 @@ struct gpib_board { unsigned master : 1; /* individual status bit */ unsigned ist : 1; - /* one means local parallel poll mode ieee 488.1 PP2 (or no parallel poll= PP0), + /* + * one means local parallel poll mode ieee 488.1 PP2 (or no parallel poll= PP0), * zero means remote parallel poll configuration mode ieee 488.1 PP1 */ unsigned local_ppoll_mode : 1; @@ -308,7 +334,8 @@ typedef struct { short event_type; } gpib_event_t; =20 -/* Each board has a list of gpib_status_queue_t to keep track of all open = devices +/* + * Each board has a list of gpib_status_queue_t to keep track of all open = devices * on the bus, so we know what address to poll when we get a service reque= st */ typedef struct { diff --git a/drivers/staging/gpib/include/nec7210_registers.h b/drivers/sta= ging/gpib/include/nec7210_registers.h index 888803dd97f9..97c53ac8e805 100644 --- a/drivers/staging/gpib/include/nec7210_registers.h +++ b/drivers/staging/gpib/include/nec7210_registers.h @@ -17,7 +17,8 @@ enum nec7210_chipset { TNT5004, // NI (minor differences to TNT4882) }; =20 -/* nec7210 register numbers (might need to be multiplied by +/* + * nec7210 register numbers (might need to be multiplied by * a board-dependent offset to get actually io address offset) */ // write registers diff --git a/drivers/staging/gpib/include/tms9914.h b/drivers/staging/gpib/= include/tms9914.h index 424c95ad85c6..11909c3e6bbf 100644 --- a/drivers/staging/gpib/include/tms9914.h +++ b/drivers/staging/gpib/include/tms9914.h @@ -86,7 +86,8 @@ int tms9914_write(struct gpib_board *board, struct tms991= 4_priv *priv, uint8_t * int tms9914_command(struct gpib_board *board, struct tms9914_priv *priv, u= int8_t *buffer, size_t length, size_t *bytes_written); int tms9914_take_control(struct gpib_board *board, struct tms9914_priv *pr= iv, int syncronous); -/* alternate version of tms9914_take_control which works around buggy tcs +/* + * alternate version of tms9914_take_control which works around buggy tcs * implementation. */ int tms9914_take_control_workaround(struct gpib_board *board, struct tms99= 14_priv *priv, @@ -139,7 +140,8 @@ enum { ms9914_num_registers =3D 8, }; =20 -/* tms9914 register numbers (might need to be multiplied by +/* + * tms9914 register numbers (might need to be multiplied by * a board-dependent offset to get actually io address offset) */ // write registers --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-15.smtpout.orange.fr [193.252.22.15]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC223645 for ; Sat, 12 Apr 2025 06:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440520; cv=none; b=I7BUc3pJ4Rm4I2CfYVpIoTEdANQ/PNGt2/ENz2n4d8p2fy2UO9L8aUeei9FpMoMONMgJYqL6cR/vHgfoSCptn+L4hjBBt8rV+/GG0trJlsOSa+kmIcvwGaCbdiz94ZfLyBz0kn3Njp0TaKQjfnVD5OH+KhfSApZGANQTjPNfaKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440520; c=relaxed/simple; bh=O1JgI00a/efCbNOGQpa+5xqZJHTLJe8jQNXtRk7lwXo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VlTO8ep8eCWgSDH9eqJITsqj+jZprhqZDtzgp/Vm0uel4zUlYCnx22/O4kWnnQMDuhb/4s3jrmjW1TBcFki1WEzDgtFVDjdZlExCyyegJLbXIns2vWphLpj5Cu9I8ZSuCDIJX1WVnm0SNH6+oiCp7I5cpTY21jN1I5qyIn+jXoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=EmdFd7Qi; arc=none smtp.client-ip=193.252.22.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="EmdFd7Qi" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UeAuNICOB75R3UeEuB4Ro; Sat, 12 Apr 2025 08:47:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744440448; bh=AphogcM6Nx5fUPKv40KkaG6PJmjwevwNNLjesePnqVI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=EmdFd7QieXenGN/JHWEMeAwpU4Kk+Wj8TnNUFXZh1nsDQbsVGx5ZA14YBL3lnx/VB k/9MJUG5gAidN97wVRa8TM+ankn1mtOkv9EIkL7u2hl/lN0hnOQkAB1PuUVY/YfOL7 F1YKyoiNww57+7VbQqw7iE+O+KmUdZDyiR/+bl224hg+YHfLn/mwDhSauIhYvD+ulG hYiKcz/4o4xgRn3tXKYy2CPC4or0EWnq+ckT8aHN9BQjQY12rb2V4z4joCDFMZzUKi CQ5Bb43dZtuIfXE++Xs1KLW6Aw+ORXGD2hjaMdUZ5uGKeifvkNj79fy3/CCwD2aN0C cQzAl/mFd9FeQ== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:47:28 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 10/16] staging: gpib: ines: fixes multiline comments style Date: Fri, 11 Apr 2025 23:47:18 -0700 Message-ID: <69a082f18148881a673e1d57b4a9d83767d87a2a.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/ines/ines_gpib.c | 86 ++++++++++++++------------- 1 file changed, 44 insertions(+), 42 deletions(-) diff --git a/drivers/staging/gpib/ines/ines_gpib.c b/drivers/staging/gpib/i= nes/ines_gpib.c index d93eb05dab90..f143fe8011bd 100644 --- a/drivers/staging/gpib/ines/ines_gpib.c +++ b/drivers/staging/gpib/ines/ines_gpib.c @@ -990,12 +990,13 @@ static struct pci_driver ines_pci_driver =3D { =20 static const int ines_pcmcia_iosize =3D 0x20; =20 -/* The event() function is this driver's Card Services event handler. - * It will be called by Card Services when an appropriate card status - * event is received. The config() and release() entry points are - * used to configure or release a socket, in response to card insertion - * and ejection events. They are invoked from the gpib event - * handler. +/* + * The event() function is this driver's Card Services event handler. + * It will be called by Card Services when an appropriate card status + * event is received. The config() and release() entry points are + * used to configure or release a socket, in response to card insertion + * and ejection events. They are invoked from the gpib event + * handler. */ =20 static int ines_gpib_config(struct pcmcia_device *link); @@ -1007,31 +1008,31 @@ static irqreturn_t ines_pcmcia_interrupt(int irq, v= oid *arg); static int ines_common_pcmcia_attach(struct gpib_board *board); /* * A linked list of "instances" of the gpib device. Each actual - * PCMCIA card corresponds to one device instance, and is described - * by one dev_link_t structure (defined in ds.h). + * PCMCIA card corresponds to one device instance, and is described + * by one dev_link_t structure (defined in ds.h). * - * You may not want to use a linked list for this -- for example, the - * memory card driver uses an array of dev_link_t pointers, where minor - * device numbers are used to derive the corresponding array index. + * You may not want to use a linked list for this -- for example, the + * memory card driver uses an array of dev_link_t pointers, where minor + * device numbers are used to derive the corresponding array index. */ =20 static struct pcmcia_device *curr_dev; =20 /* - * A dev_link_t structure has fields for most things that are needed - * to keep track of a socket, but there will usually be some device - * specific information that also needs to be kept track of. The - * 'priv' pointer in a dev_link_t structure can be used to point to - * a device-specific private data structure, like this. + * A dev_link_t structure has fields for most things that are needed + * to keep track of a socket, but there will usually be some device + * specific information that also needs to be kept track of. The + * 'priv' pointer in a dev_link_t structure can be used to point to + * a device-specific private data structure, like this. * - * A driver needs to provide a dev_node_t structure for each device - * on a card. In some cases, there is only one device per card (for - * example, ethernet cards, modems). In other cases, there may be - * many actual or logical devices (SCSI adapters, memory cards with - * multiple partitions). The dev_node_t structures need to be kept - * in a linked list starting at the 'dev' field of a dev_link_t - * structure. We allocate them in the card's private data structure, - * because they generally can't be allocated dynamically. + * A driver needs to provide a dev_node_t structure for each device + * on a card. In some cases, there is only one device per card (for + * example, ethernet cards, modems). In other cases, there may be + * many actual or logical devices (SCSI adapters, memory cards with + * multiple partitions). The dev_node_t structures need to be kept + * in a linked list starting at the 'dev' field of a dev_link_t + * structure. We allocate them in the card's private data structure, + * because they generally can't be allocated dynamically. */ =20 struct local_info { @@ -1042,13 +1043,13 @@ struct local_info { }; =20 /* - * gpib_attach() creates an "instance" of the driver, allocating - * local data structures for one device. The device is registered - * with Card Services. + * gpib_attach() creates an "instance" of the driver, allocating + * local data structures for one device. The device is registered + * with Card Services. * - * The dev_link structure is initialized, but we don't actually - * configure the card at this point -- we wait until we receive a - * card insertion event. + * The dev_link structure is initialized, but we don't actually + * configure the card at this point -- we wait until we receive a + * card insertion event. */ static int ines_gpib_probe(struct pcmcia_device *link) { @@ -1079,10 +1080,10 @@ static int ines_gpib_probe(struct pcmcia_device *li= nk) } =20 /* - * This deletes a driver "instance". The device is de-registered - * with Card Services. If it has been released, all local data - * structures are freed. Otherwise, the structures will be freed - * when the device is released. + * This deletes a driver "instance". The device is de-registered + * with Card Services. If it has been released, all local data + * structures are freed. Otherwise, the structures will be freed + * when the device is released. */ static void ines_gpib_remove(struct pcmcia_device *link) { @@ -1103,9 +1104,9 @@ static int ines_gpib_config_iteration(struct pcmcia_d= evice *link, void *priv_dat } =20 /* - * gpib_config() is scheduled to run after a CARD_INSERTION event - * is received, to configure the PCMCIA socket, and to make the - * device available to the system. + * gpib_config() is scheduled to run after a CARD_INSERTION event + * is received, to configure the PCMCIA socket, and to make the + * device available to the system. */ static int ines_gpib_config(struct pcmcia_device *link) { @@ -1125,8 +1126,9 @@ static int ines_gpib_config(struct pcmcia_device *lin= k) dev_dbg(&link->dev, "ines_cs: manufacturer: 0x%x card: 0x%x\n", link->manf_id, link->card_id); =20 - /* for the ines card we have to setup the configuration registers in - * attribute memory here + /* + * for the ines card we have to setup the configuration registers in + * attribute memory here */ link->resource[2]->flags |=3D WIN_MEMORY_TYPE_AM | WIN_DATA_WIDTH_8 | WIN= _ENABLE; link->resource[2]->end =3D 0x1000; @@ -1159,9 +1161,9 @@ static int ines_gpib_config(struct pcmcia_device *lin= k) } /* gpib_config */ =20 /* - * After a card is removed, gpib_release() will unregister the net - * device, and release the PCMCIA configuration. If the device is - * still open, this will be postponed until it is closed. + * After a card is removed, gpib_release() will unregister the net + * device, and release the PCMCIA configuration. If the device is + * still open, this will be postponed until it is closed. */ =20 static void ines_gpib_release(struct pcmcia_device *link) --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-14.smtpout.orange.fr [193.252.22.14]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12AD4645 for ; Sat, 12 Apr 2025 06:48:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440534; cv=none; b=CS0Dl4pdZLxhRxr6xV+sEYUFRisSUqEJqfGX82MZNdXQ/rs+SBmQYciUMjO1mJWGHF6cJyORrVxw3+o2CChIBKyqhm4xdvD9Mh2lSFYwjHDBdnvr1drfUG8solg9gzgvJaxlBud1DHhJrvS5Fza3z+emKX3OjkYnYKtIMMK4L/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440534; c=relaxed/simple; bh=gb7TDOVl4T+tIy5B2G5Rh/o7V863Z+YPDNbeqDA7o78=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tLte/NUkUH165bKlDqk3ROZNl62iJJve63geVBxHktjKCH+w9EZpBbfrb87/xU2idfa/U38f/CdDgkT7IQ2xitVXwMCkMMidgtefEJs7mllzFMkL8u+Wp33WhZBZRYjNFfEoSg/0Kov0aaR2nWFus8QSi3OTyw2ZOj3yCkSMDWY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=Xm4esHUX; arc=none smtp.client-ip=193.252.22.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="Xm4esHUX" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3Uf9uoeYetvMG3UfDuGx5K; Sat, 12 Apr 2025 08:48:29 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744440510; bh=QlZRUZx+8kKhk8v1urqpIN1u6ZO6v4bCEcVF3PP/e4Y=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Xm4esHUXJzQZBiIwEe12plDBsiFY95mCGzZFZ1r1fgoG6pApS2Pht7hvZh6/ziP0T Xnb3ttZoUPPcxcLSDmZhoSI6NsQ0r1TpjcG1KLdLA3QxXLvoBO15zvGs8FGWw1BjyL RQoF82QU4WqXpEveYdjdSw2JO+wIsJBEMjStX/26bbgT9Vl92gR3SMTFscDD0vhIp6 RZhVLZVGhrqHp5txtSiydJmccjbEMp8kiq+mT75NKw2Ov7vA0tcRoTlQjgwHtX4kiG uWt16S/rCgIrOlKPEBpGzwHgpH1ooD1TgfHqACGvo5LW39gCCLZVaUbwSynTV1ImWK /NIMZR28q3TKw== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:48:29 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 11/16] staging: gpib: lpvo_usb_gpib: fixes multiline comments style Date: Fri, 11 Apr 2025 23:48:35 -0700 Message-ID: <7699226216a99b8bf053c4d6017941ebc87cb8e2.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 123 +++++++++--------- 1 file changed, 64 insertions(+), 59 deletions(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index faf96e9cc4a1..f7dd7e8b0764 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -36,16 +36,16 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("GPIB driver for LPVO usb devices"); =20 /* - * Table of devices that work with this driver. + * Table of devices that work with this driver. * - * Currently, only one device is known to be used in the - * lpvo_usb_gpib adapter (FTDI 0403:6001). - * If your adapter uses a different chip, insert a line - * in the following table with proper , . + * Currently, only one device is known to be used in the + * lpvo_usb_gpib adapter (FTDI 0403:6001). + * If your adapter uses a different chip, insert a line + * in the following table with proper , . * - * To have your chip automatically handled by the driver, - * update files "/usr/local/etc/modprobe.d/lpvo_usb_gpib.conf" - * and /usr/local/etc/udev/rules.d/99-lpvo_usb_gpib.rules. + * To have your chip automatically handled by the driver, + * update files "/usr/local/etc/modprobe.d/lpvo_usb_gpib.conf" + * and /usr/local/etc/udev/rules.d/99-lpvo_usb_gpib.rules. * */ =20 @@ -56,18 +56,18 @@ static const struct usb_device_id skel_table[] =3D { MODULE_DEVICE_TABLE(usb, skel_table); =20 /* - * *** Diagnostics and Debug *** - * To enable the diagnostic and debug messages either compile with DEBUG = set - * or control via the dynamic debug mechanisms. - * The module parameter "debug" controls the sending of debug messages to - * syslog. By default it is set to 0 - * debug =3D 0: only attach/detach messages are sent - * 1: every action is logged - * 2: extended logging; each single exchanged byte is documented - * (about twice the log volume of [1]) - * To switch debug level: - * At module loading: modprobe lpvo_usb_gpib debug=3D{0,1,2} - * On the fly: echo {0,1,2} > /sys/modules/lpvo_usb_gpib/parameters/= debug + * *** Diagnostics and Debug *** + * To enable the diagnostic and debug messages either compile with DEBUG s= et + * or control via the dynamic debug mechanisms. + * The module parameter "debug" controls the sending of debug messages to + * syslog. By default it is set to 0 + * debug =3D 0: only attach/detach messages are sent + * 1: every action is logged + * 2: extended logging; each single exchanged byte is documented + * (about twice the log volume of [1]) + * To switch debug level: + * At module loading: modprobe lpvo_usb_gpib debug=3D{0,1,2} + * On the fly: echo {0,1,2} > /sys/modules/lpvo_usb_gpib/parameter= s/debug */ =20 static int debug; @@ -169,10 +169,10 @@ static void show_status(struct gpib_board *board) } =20 /* - * GLOBAL VARIABLES: required for - * pairing among gpib minor and usb minor. - * MAX_DEV is the max number of usb-gpib adapters; free - * to change as you like, but no more than 32 + * GLOBAL VARIABLES: required for + * pairing among gpib minor and usb minor. + * MAX_DEV is the max number of usb-gpib adapters; free + * to change as you like, but no more than 32 */ =20 #define MAX_DEV 8 @@ -182,7 +182,7 @@ static int assigned_usb_minors; /* mask of filled s= lots */ static struct mutex minors_lock; /* operations on usb_minors are to be= protected */ =20 /* - * usb-skeleton prototypes + * usb-skeleton prototypes */ =20 struct usb_skel; @@ -192,7 +192,7 @@ static int skel_do_open(struct gpib_board *, int); static int skel_do_release(struct gpib_board *); =20 /* - * usec_diff : take difference in MICROsec between two 'timespec' + * usec_diff : take difference in MICROsec between two 'timespec' * (unix time in sec and NANOsec) */ =20 @@ -203,7 +203,7 @@ static inline int usec_diff(struct timespec64 *a, struc= t timespec64 *b) } =20 /* - * *** these routines are specific to the usb-gpib adapter *** + * *** these routines are specific to the usb-gpib adapter *** */ =20 /** @@ -262,13 +262,11 @@ static int send_command(struct gpib_board *board, cha= r *msg, int leng) } =20 /* - * * set_control_line() - Set the value of a single gpib control line * * @board: the gpib_board_struct data area for this gpib interface * @line: line mask * @value: line new value (0/1) - * */ =20 static int set_control_line(struct gpib_board *board, int line, int value) @@ -368,7 +366,7 @@ static void set_timeout(struct gpib_board *board) } =20 /* - * now the standard interface functions - attach and detach + * now the standard interface functions - attach and detach */ =20 /** @@ -464,7 +462,8 @@ static int usb_gpib_attach(struct gpib_board *board, co= nst gpib_board_config_t * if (retval !=3D ACK) return -EIO; =20 - /* We must setup debug mode because we need the extended instruction + /* + * We must setup debug mode because we need the extended instruction * set to cope with the Core (gpib_common) point of view */ =20 @@ -473,7 +472,8 @@ static int usb_gpib_attach(struct gpib_board *board, co= nst gpib_board_config_t * if (retval !=3D ACK) return -EIO; =20 - /* We must keep REN off after an IFC because so it is + /* + * We must keep REN off after an IFC because so it is * assumed by the Core */ =20 @@ -654,7 +654,8 @@ static int usb_gpib_line_status(const struct gpib_board= *board) =20 DIA_LOG(1, "%s\n", "request"); =20 - /* if we are on the wait queue (board->wait), do not hurry + /* + * if we are on the wait queue (board->wait), do not hurry * reading status line; instead, pause a little */ =20 @@ -707,7 +708,8 @@ static int usb_gpib_line_status(const struct gpib_board= *board) =20 static int usb_gpib_parallel_poll(struct gpib_board *board, uint8_t *resul= t) { - /* request parallel poll asserting ATN | EOI; + /* + * request parallel poll asserting ATN | EOI; * we suppose ATN already asserted */ =20 @@ -1083,13 +1085,13 @@ static gpib_interface_t usb_gpib_interface =3D { }; =20 /* - * usb_gpib_init_module(), usb_gpib_exit_module() + * usb_gpib_init_module(), usb_gpib_exit_module() * - * This functions are called every time a new device is detected - * and registered or is removed and unregistered. - * We must take note of created and destroyed usb minors to be used - * when usb_gpib_attach() and usb_gpib_detach() will be called on - * request by gpib_config. + * This functions are called every time a new device is detected + * and registered or is removed and unregistered. + * We must take note of created and destroyed usb minors to be used + * when usb_gpib_attach() and usb_gpib_detach() will be called on + * request by gpib_config. */ =20 static int usb_gpib_init_module(struct usb_interface *interface) @@ -1107,8 +1109,9 @@ static int usb_gpib_init_module(struct usb_interface = *interface) goto exit; } } else { - /* check if minor is already registered - maybe useless, but if - * it happens the code is inconsistent somewhere + /* + * check if minor is already registered - maybe useless, but if + * it happens the code is inconsistent somewhere */ =20 for (j =3D 0 ; j < MAX_DEV ; j++) { @@ -1162,12 +1165,11 @@ static void usb_gpib_exit_module(int minor) } =20 /* - * Default latency time (16 msec) is too long. - * We must use 1 msec (best); anyhow, no more than 5 msec. - * - * Defines and function taken and modified from the kernel tree - * (see ftdi_sio.h and ftdi_sio.c). + * Default latency time (16 msec) is too long. + * We must use 1 msec (best); anyhow, no more than 5 msec. * + * Defines and function taken and modified from the kernel tree + * (see ftdi_sio.h and ftdi_sio.c). */ =20 #define FTDI_SIO_SET_LATENCY_TIMER 9 /* Set the latency timer */ @@ -1235,7 +1237,8 @@ static int write_latency_timer(struct usb_device *ude= v) /* private defines */ =20 #define MAX_TRANSFER (PAGE_SIZE - 512) -/* MAX_TRANSFER is chosen so that the VM is not stressed by +/* + * MAX_TRANSFER is chosen so that the VM is not stressed by * allocations > PAGE_SIZE and the number of packets in a page * is an integer 512 is the largest possible packet on EHCI */ @@ -1280,7 +1283,7 @@ static void skel_delete(struct kref *kref) } =20 /* - * skel_do_open() - to be called by usb_gpib_attach + * skel_do_open() - to be called by usb_gpib_attach */ =20 static int skel_do_open(struct gpib_board *board, int subminor) @@ -1317,7 +1320,7 @@ static int skel_do_open(struct gpib_board *board, int= subminor) } =20 /* - * skel_do_release() - to be called by usb_gpib_detach + * skel_do_release() - to be called by usb_gpib_detach */ =20 static int skel_do_release(struct gpib_board *board) @@ -1340,7 +1343,7 @@ static int skel_do_release(struct gpib_board *board) } =20 /* - * read functions + * read functions */ =20 static void skel_read_bulk_callback(struct urb *urb) @@ -1405,7 +1408,7 @@ static int skel_do_read_io(struct usb_skel *dev, size= _t count) } =20 /* - * skel_do_read() - read operations from lpvo_usb_gpib + * skel_do_read() - read operations from lpvo_usb_gpib */ =20 static ssize_t skel_do_read(struct usb_skel *dev, char *buffer, size_t cou= nt) @@ -1482,7 +1485,8 @@ static ssize_t skel_do_read(struct usb_skel *dev, cha= r *buffer, size_t count) * all data has been used * actual IO needs to be done */ - /* it seems that requests for less than dev->bulk_in_size + /* + * it seems that requests for less than dev->bulk_in_size * are not accepted */ rv =3D skel_do_read_io(dev, dev->bulk_in_size); @@ -1496,7 +1500,8 @@ static ssize_t skel_do_read(struct usb_skel *dev, cha= r *buffer, size_t count) * data is available - chunk tells us how much shall be copied */ =20 - /* Condition dev->bulk_in_copied > 0 maybe will never happen. In case, + /* + * Condition dev->bulk_in_copied > 0 maybe will never happen. In case, * signal the event and copy using the original procedure, i.e., copy * first two bytes also */ @@ -1551,7 +1556,7 @@ static ssize_t skel_do_read(struct usb_skel *dev, cha= r *buffer, size_t count) } =20 /* - * write functions + * write functions */ =20 static void skel_write_bulk_callback(struct urb *urb) @@ -1581,7 +1586,7 @@ static void skel_write_bulk_callback(struct urb *urb) } =20 /* - * skel_do_write() - write operations from lpvo_usb_gpib + * skel_do_write() - write operations from lpvo_usb_gpib */ =20 static ssize_t skel_do_write(struct usb_skel *dev, const char *buffer, siz= e_t count) @@ -1686,7 +1691,7 @@ static ssize_t skel_do_write(struct usb_skel *dev, co= nst char *buffer, size_t co } =20 /* - * services for the user space devices + * services for the user space devices */ =20 #if USER_DEVICE /* conditional compilation of user space device */ @@ -1771,7 +1776,7 @@ static int skel_release(struct inode *inode, struct f= ile *file) } =20 /* - * user space access to read function + * user space access to read function */ =20 static ssize_t skel_read(struct file *file, char __user *buffer, size_t co= unt, @@ -1800,7 +1805,7 @@ static ssize_t skel_read(struct file *file, char __us= er *buffer, size_t count, } =20 /* - * user space access to write function + * user space access to write function */ =20 static ssize_t skel_write(struct file *file, const char __user *user_buffe= r, --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (outm-50.smtpout.orange.fr [193.252.22.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 198347D3F4 for ; Sat, 12 Apr 2025 06:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440581; cv=none; b=YnZ3BbsE60oCdfID5/rV3Cm6tjI7hQTOQ4YN1Jl+9oDDoSIANd3u4H7RuwtKp9r/vf1IGIljT/3Shj22KKEYuzy3cxjnx9/Da22pJU6a+DEZxmqQ3YDA9otcRa7NO3D2I/+7ng2zdYd7l2NTIlHFDjpYBTg84hmdTXV12mDWn6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744440581; c=relaxed/simple; bh=mH7zDevPNYTr+1kdTDaCGMSroPfVGxNIdvITme9rG+k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m7MLE3qJ5HUBSqHZH+b4+9HLLI/zu5C/vS7UDTFI7OgqbD1G5ZURnnrzZ3VyY1ihUffidU9s2JItZrKhsi9xLKDWcEzfEY4inPgffkcPV8LLDpleyRRR+5so9NqCs7xUbAzMYxzSPly6WcMAyNUyzerbZBztW53TgoIBZdAgcME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=LZHV+Smt; arc=none smtp.client-ip=193.252.22.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="LZHV+Smt" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3UgGulZ4tBkGO3UgKu651W; Sat, 12 Apr 2025 08:49:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744440578; bh=C8nI+H4mpuKXD1G5NCEn9hFgwdTXnNiDXVTLCrvw1Vo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=LZHV+Smt2NCFE5l6eSAbb7fTI+VUK7HWDKzyzi42IomwFbEQWq93V1xWTcIoI/YQn vk3jUMyWVzutKVel8Qrq3zU+WOMPUmsIqBQIpw5FDTQ4TFJD3Pj7lBSU8389qJUF/u n5uyjLithwgdA9GsxkZlcQWwQDubk9E/kKnN1CiCWBcHHXCBac6rs7lwZ1BnkMuQ2u q0WRIAUILW+uHjN9zf/OdzhfryWnjAzplcV4R07od/6BoYDe2EN2fprBZyABk6jN8S MEgMDjUiy1CegUXLQ5v0sDaSp4kXfmg3MHMiEkw3VVKUAYowWU3jhBcRSqtLV9qXdj QMC309/znEtjQ== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 08:49:38 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 12/16] staging: gpib: nec7210: fixes multiline comments style Date: Fri, 11 Apr 2025 23:49:26 -0700 Message-ID: <2bdfadb59d11441d10c8e3994de49b876f8e7efe.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/nec7210/nec7210.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gpib/nec7210/nec7210.c b/drivers/staging/gpib/= nec7210/nec7210.c index 846c0a3fa1dc..eaa37f916b0b 100644 --- a/drivers/staging/gpib/nec7210/nec7210.c +++ b/drivers/staging/gpib/nec7210/nec7210.c @@ -79,7 +79,8 @@ void nec7210_parallel_poll_response(struct gpib_board *bo= ard, struct nec7210_pri write_byte(priv, AUX_CPPF, AUXMR); } EXPORT_SYMBOL(nec7210_parallel_poll_response); -/* This is really only adequate for chips that do a 488.2 style reqt/reqf +/* + * This is really only adequate for chips that do a 488.2 style reqt/reqf * based on bit 6 of the SPMR (see chapter 11.3.3 of 488.2). For simpler c= hips that simply * set rsv directly based on bit 6, we either need to do more hardware set= up to expose * the 488.2 capability (for example with NI chips), or we need to impleme= nt the @@ -202,7 +203,8 @@ unsigned int nec7210_update_status_nolock(struct gpib_b= oard *board, struct nec72 set_bit(SPOLL_NUM, &board->status); } =20 - /* we rely on the interrupt handler to set the + /* + * we rely on the interrupt handler to set the * rest of the status bits */ =20 @@ -482,7 +484,8 @@ static int pio_read(struct gpib_board *board, struct ne= c7210_priv *priv, uint8_t } if (test_bit(READ_READY_BN, &priv->state)) { if (*bytes_read =3D=3D 0) { - /* We set the handshake mode here because we know + /* + * We set the handshake mode here because we know * no new bytes will arrive (it has already arrived * and is awaiting being read out of the chip) while we are changing * modes. This ensures we can reliably keep track @@ -662,7 +665,8 @@ static int pio_write(struct gpib_board *board, struct n= ec7210_priv *priv, uint8_ if (retval =3D=3D -EIO) { /* resend last byte on bus error */ *bytes_written =3D last_count; - /* we can get unrecoverable bus errors, + /* + * we can get unrecoverable bus errors, * so give up after a while */ bus_error_count++; @@ -805,7 +809,8 @@ int nec7210_write(struct gpib_board *board, struct nec7= 210_priv *priv, if (send_eoi) { size_t num_bytes; =20 - /* We need to wait to make sure we will immediately be able to write the= data byte + /* + * We need to wait to make sure we will immediately be able to write the= data byte * into the chip before sending the associated AUX_SEOI command. This i= s really * only needed for length=3D=3D1 since otherwise the earlier calls to pi= o_write * will have dont the wait already. @@ -827,7 +832,7 @@ int nec7210_write(struct gpib_board *board, struct nec7= 210_priv *priv, EXPORT_SYMBOL(nec7210_write); =20 /* - * interrupt service routine + * interrupt service routine */ irqreturn_t nec7210_interrupt(struct gpib_board *board, struct nec7210_pri= v *priv) { @@ -1021,7 +1026,8 @@ EXPORT_SYMBOL(nec7210_ioport_read_byte); void nec7210_ioport_write_byte(struct nec7210_priv *priv, uint8_t data, un= signed int register_num) { if (register_num =3D=3D AUXMR) - /* locking makes absolutely sure noone accesses the + /* + * locking makes absolutely sure noone accesses the * AUXMR register faster than once per microsecond */ nec7210_locking_ioport_write_byte(priv, data, register_num); @@ -1066,7 +1072,8 @@ EXPORT_SYMBOL(nec7210_iomem_read_byte); void nec7210_iomem_write_byte(struct nec7210_priv *priv, uint8_t data, uns= igned int register_num) { if (register_num =3D=3D AUXMR) - /* locking makes absolutely sure noone accesses the + /* + * locking makes absolutely sure noone accesses the * AUXMR register faster than once per microsecond */ nec7210_locking_iomem_write_byte(priv, data, register_num); --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-67.smtpout.orange.fr [193.252.22.67]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04C927FD for ; Sat, 12 Apr 2025 07:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744441762; cv=none; b=jefz7dhRmYAVTMGQ3NDqRwxbZ+ha1bWQzM5dRa9xqGrxN6v0hvCaTb6KLzZygqx1OlgsQon7I5HAcMA9Hw2rIrEnVFsCpSGnPZtuMXWo1B0f0K/rG+ZTl3wtv/8CiGQJkIifkVHBdRokfS39fM98f8St9CzeXzIkY7Mc+A1YPcY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744441762; c=relaxed/simple; bh=ObI/eBXSwueiLbh/W262pQOsW5q9GzUhDYiqINvHFH0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=izi/W5GvOWE7qT93Up4rC9I4ExRDY6osFeDCFr3XAR7Hd8FNwNm4FBaewebpzLN+eKlUtMiLf88EHzGF+a6ks2A31iz2DKVzJK1OxXZ+ewk8ckBIuxpZnxoznEPsy497WsqAtz+jsibSASH6UWVmCeH79crHH0a9cFqLpdiCWG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=pTCrFZNz; arc=none smtp.client-ip=193.252.22.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="pTCrFZNz" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3Uy7uq3PTX7PJ3UyBuK7yP; Sat, 12 Apr 2025 09:08:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744441686; bh=RdrGqUxYKIUxWcSWCmpIVhg02jT+Jr6I9gU2Sw+YTQQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=pTCrFZNzdtVCa+fssemeB7n3RXcpYzabWHbCCZ6JiKkSnfpZERmK+i+ewxRc6l1Li E1LmB7ER1BCuaOG2XS4RniSK5GiW6TLyJNq1WK22sSOD6UanmwjqGtCL7NBvJHV781 +HqN8x1P5+loRH+QMLNzKtJsiaJTnUH3Lig4McPKjAh74Hh705Faty7QZdh1kpX2Mo fMVytaAfzpLqqjPe6xOrqpbMcSONAfLOu/tI8KZ5rwZlbcRUNFawaOBmyHlVXjmOda FVYvwPJQU3DMkqo2mZzx/uEi9oJ88W8LIz1qWYjFJgvJrBt1CH0+mUcbeGXtE2/5L4 69Ahz092Y/lsg== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 09:08:06 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 13/16] staging: gpib: ni_usb: fixes multiline comments style Date: Sat, 12 Apr 2025 00:07:54 -0700 Message-ID: <4b2762d349e06db8f541a86ca0ec429bc1351097.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 40 +++++++++++++++-------- drivers/staging/gpib/ni_usb/ni_usb_gpib.h | 32 +++++++++++------- 2 files changed, 47 insertions(+), 25 deletions(-) diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gp= ib/ni_usb/ni_usb_gpib.c index 9f1b9927f025..62735a0cb4ec 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -74,7 +74,8 @@ static unsigned short ni_usb_timeout_code(unsigned int us= ec) return 0xff; else if (usec <=3D 300000000) return 0x01; - /* NI driver actually uses 0xff for timeout T1000s, which is a bug in the= ir code. + /* + * NI driver actually uses 0xff for timeout T1000s, which is a bug in the= ir code. * I've verified on a usb-b that a code of 0x2 is correct for a 1000 sec = timeout */ else if (usec <=3D 1000000000) @@ -232,7 +233,8 @@ static int ni_usb_nonblocking_receive_bulk_msg(struct n= i_usb_priv *ni_priv, mutex_unlock(&ni_priv->bulk_transfer_lock); if (interruptible) { if (wait_for_completion_interruptible(&context->complete)) { - /* If we got interrupted by a signal while + /* + * If we got interrupted by a signal while * waiting for the usb gpib to respond, we * should send a stop command so it will * finish up with whatever it was doing and @@ -240,8 +242,9 @@ static int ni_usb_nonblocking_receive_bulk_msg(struct n= i_usb_priv *ni_priv, */ ni_usb_stop(ni_priv); retval =3D -ERESTARTSYS; - /* now do an uninterruptible wait, it shouldn't take long - * for the board to respond now. + /* + * now do an uninterruptible wait, it shouldn't take long + * for the board to respond now. */ wait_for_completion(&context->complete); } @@ -684,7 +687,8 @@ static int ni_usb_read(struct gpib_board *board, uint8_= t *buffer, size_t length, retval =3D 0; break; case NIUSB_ABORTED_ERROR: - /* this is expected if ni_usb_receive_bulk_msg got + /* + * this is expected if ni_usb_receive_bulk_msg got * interrupted by a signal and returned -ERESTARTSYS */ break; @@ -794,7 +798,8 @@ static int ni_usb_write(struct gpib_board *board, uint8= _t *buffer, size_t length retval =3D 0; break; case NIUSB_ABORTED_ERROR: - /* this is expected if ni_usb_receive_bulk_msg got + /* + * this is expected if ni_usb_receive_bulk_msg got * interrupted by a signal and returned -ERESTARTSYS */ break; @@ -893,7 +898,8 @@ static int ni_usb_command_chunk(struct gpib_board *boar= d, uint8_t *buffer, size_ case NIUSB_NO_ERROR: break; case NIUSB_ABORTED_ERROR: - /* this is expected if ni_usb_receive_bulk_msg got + /* + * this is expected if ni_usb_receive_bulk_msg got * interrupted by a signal and returned -ERESTARTSYS */ break; @@ -1192,8 +1198,9 @@ static int ni_usb_enable_eos(struct gpib_board *board= , uint8_t eos_byte, int com static void ni_usb_disable_eos(struct gpib_board *board) { struct ni_usb_priv *ni_priv =3D board->private_data; - /* adapter gets unhappy if you don't zero all the bits - * for the eos mode and eos char (returns error 4 on reads). + /* + * adapter gets unhappy if you don't zero all the bits + * for the eos mode and eos char (returns error 4 on reads). */ ni_priv->eos_mode =3D 0; ni_priv->eos_char =3D 0; @@ -2045,8 +2052,10 @@ static int ni_usb_hs_wait_for_ready(struct ni_usb_pr= iv *ni_priv) unexpected =3D 1; } ++j; - // MC usb-488 (and sometimes NI-USB-HS?) sends 0x8 here; MC usb-488A sen= ds 0x7 here - // NI-USB-HS+ sends 0x0 + /* + * MC usb-488 (and sometimes NI-USB-HS?) sends 0x8 here; MC usb-488A sen= ds 0x7 here + * NI-USB-HS+ sends 0x0 + */ if (buffer[j] !=3D 0x1 && buffer[j] !=3D 0x8 && buffer[j] !=3D 0x7 && bu= ffer[j] !=3D 0x0) { // [3] dev_err(&usb_dev->dev, "unexpected data: buffer[%i]=3D0x%x, expected 0x= 0, 0x1, 0x7 or 0x8\n", @@ -2127,7 +2136,8 @@ static int ni_usb_hs_wait_for_ready(struct ni_usb_pri= v *ni_priv) return retval; } =20 -/* This does some extra init for HS+ models, as observed on Windows. One = of the +/* + * This does some extra init for HS+ models, as observed on Windows. One = of the * control requests causes the LED to stop blinking. * I'm not sure what the other 2 requests do. None of these requests are = actually required * for the adapter to work, maybe they do some init for the analyzer inter= face @@ -2343,8 +2353,10 @@ static void ni_usb_detach(struct gpib_board *board) struct ni_usb_priv *ni_priv; =20 mutex_lock(&ni_usb_hotplug_lock); -// under windows, software unplug does chip_reset nec7210 aux command, -// then writes 0x0 to address 0x10 of device 3 + /* + * under windows, software unplug does chip_reset nec7210 aux command, + * then writes 0x0 to address 0x10 of device 3 + */ ni_priv =3D board->private_data; if (ni_priv) { if (ni_priv->bus_interface) { diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.h b/drivers/staging/gp= ib/ni_usb/ni_usb_gpib.h index 4b297db09a9b..b011e131201c 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.h +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.h @@ -113,27 +113,37 @@ enum ni_usb_bulk_ids { =20 enum ni_usb_error_codes { NIUSB_NO_ERROR =3D 0, - /* NIUSB_ABORTED_ERROR occurs when I/O is interrupted early by - * doing a NI_USB_STOP_REQUEST on the control endpoint. + /* + * NIUSB_ABORTED_ERROR occurs when I/O is interrupted early by + * doing a NI_USB_STOP_REQUEST on the control endpoint. */ NIUSB_ABORTED_ERROR =3D 1, - // NIUSB_READ_ATN_ERROR occurs when you do a board read while - // ATN is set + /* + * NIUSB_READ_ATN_ERROR occurs when you do a board read while + * ATN is set + */ NIUSB_ATN_STATE_ERROR =3D 2, - // NIUSB_ADDRESSING_ERROR occurs when you do a board - // read/write as CIC but are not in LACS/TACS + /* + * NIUSB_ADDRESSING_ERROR occurs when you do a board + * read/write as CIC but are not in LACS/TACS + */ NIUSB_ADDRESSING_ERROR =3D 3, - /* NIUSB_EOSMODE_ERROR occurs on reads if any eos mode or char + /* + * NIUSB_EOSMODE_ERROR occurs on reads if any eos mode or char * bits are set when REOS is not set. * Have also seen error 4 if you try to send more than 16 * command bytes at once on a usb-b. */ NIUSB_EOSMODE_ERROR =3D 4, - // NIUSB_NO_BUS_ERROR occurs when you try to write a command - // byte but there are no devices connected to the gpib bus + /* + * NIUSB_NO_BUS_ERROR occurs when you try to write a command + * byte but there are no devices connected to the gpib bus + */ NIUSB_NO_BUS_ERROR =3D 5, - // NIUSB_NO_LISTENER_ERROR occurs when you do a board write as - // CIC with no listener + /* + * NIUSB_NO_LISTENER_ERROR occurs when you do a board write as + * CIC with no listener + */ NIUSB_NO_LISTENER_ERROR =3D 8, // get NIUSB_TIMEOUT_ERROR on board read/write timeout NIUSB_TIMEOUT_ERROR =3D 10, --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-70.smtpout.orange.fr [193.252.22.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E8E1191F75 for ; Sat, 12 Apr 2025 07:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744444128; cv=none; b=D0DGIl74rKbVl85dwOEjRMJAbhJ0ZRI7PF6tMJ49WvFyKHN6yKZ1ERqEI1HVPJdyykmbXKSyvPlDj0+zZH7XBXtNr8TLEEtdpN2uCtJipBAVQNZSrR8INfOkKxQ4We0+9kHUH5DltaHJXoxN1yiScIHMhYzWl9m9C6GQxHKFxVY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744444128; c=relaxed/simple; bh=2TDNINhhP+tqL6gRsN/zaGla/IazuRP/HIv0iKIdYdg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qwfiqos4Ma9tlGA/IP1JKJHq34x62S6d/HqUsZTtgCW/rEgyVlADv9T3QixShHebkhIOb/dVtfoIQv5A6vwfhLX7wpl1rKzkUlxBIjWzt7QMlQ0Wtnvw4jDpCgc2KV83kkxzVZ7aVwsUXBpF20rrjom2r0OwaXLWoQ5hSxEqcIE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=pqtZyHa7; arc=none smtp.client-ip=193.252.22.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="pqtZyHa7" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3VbRuJv5sCZIm3VbVuYMRQ; Sat, 12 Apr 2025 09:48:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744444124; bh=TyBefwaCj12qoZCRmqa2pA2xtccxwzTRF92uBTc5N+k=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=pqtZyHa7FFYe+AplfhLYIUWw2niLc6gTv5te8yyIDzQQ0IX40p50ASDzMTt9/fR0z edZhstppiuZaJQQbpDWCbLY04wjCez/+chWlAXqzXU77eNnIMgGW7PE1/GmJ7sOwc8 3EL7NWBfltZazWV1ywEwcLYLM07R2krNBFECuu5hiNEgBS8Ci+eCuDfXzjYjUwcQc1 j6P1PGgza4RudwrYmMNYigF0b/2amK8MeUPcy+8B+zhCMcOrIevhTrs1h1S+8RH2sL sZBWJrOYHZ0FBJUNtqMHksrRPrrrObNXWOiqz+RZvhPPDsl78l5tyYm//VXq7GMrLy UvoTSVzFx/T0g== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 09:48:44 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 14/16] staging: gpib: pc2: fixes multiline comments style Date: Sat, 12 Apr 2025 00:48:34 -0700 Message-ID: <77eb5fc5050298503009fa212600f00514eeb713.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/pc2/pc2_gpib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/pc2/pc2_gpib.c b/drivers/staging/gpib/pc2= /pc2_gpib.c index 96d3c09f2273..d93502a833bf 100644 --- a/drivers/staging/gpib/pc2/pc2_gpib.c +++ b/drivers/staging/gpib/pc2/pc2_gpib.c @@ -267,8 +267,9 @@ static int pc2_generic_attach(struct gpib_board *board,= const gpib_board_config_ nec_priv->type =3D chipset; =20 #ifndef PC2_DMA - /* board->dev hasn't been initialized, so forget about DMA until this dri= ver - * is adapted to use isa_register_driver. + /* + * board->dev hasn't been initialized, so forget about DMA until this dri= ver + * is adapted to use isa_register_driver. */ if (config->ibdma) // driver needs to be adapted to use isa_register_driver to get a struct = device* --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-74.smtpout.orange.fr [193.252.22.74]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 221FB1A23B1 for ; Sat, 12 Apr 2025 18:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744481471; cv=none; b=gZbssQSqHwNSS4X2A9uCpR2Vc0VpsdLP+AcW8w8SgihXN9Y3y17Z63cCCZ48cuG5Zynuijl7YMT9L/QRDfNGiqRcBGtseK7H3KbbOIQ2ctb5X8vQ2W6B4kXqCV9VwQmm8ub1ep3thvgk+20g5vitQaaweVX3CZxONAN2sXlo1j8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744481471; c=relaxed/simple; bh=2C69E6Zwa0LwrizAy5FHjlaDU9BOYApEAc6a4ZpExZE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NUTM6XbV/5Dak6TFRLRx+2ooIphEI/n9AhB1uLbfJVAmjbcpH4mStJMzqo5wyZrOQCq1DR1+YPoJpc9ZFhayZXzn724EXwxHVedyyu44VrbnA3GMJQlhb70hoAZqEi7UG6V130qe+mc6W0m6M4w+/Rj7vJzxc12IFstA+ZnO+lI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=fje/+rDq; arc=none smtp.client-ip=193.252.22.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="fje/+rDq" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3fIbuBn9ASD8r3fIfu2ZfU; Sat, 12 Apr 2025 20:09:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744481395; bh=xgOC6c3drb1XwiKpCFrfeMke7xkgHxeZhp+Mp/LTlMc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=fje/+rDqMB9YIBoN7EoGNhlkyzG78P9Xkq+feD31ie4+SqAH170fhPg8iPFg3da5P XCVCmyrpamKlKjF2++QWqvBuzTYHEPdbMeGvXKZjxx4wUnnmbPgyGRzUfg6neACN4V qGYIaPyQ3nkNugenqlnwjQDM8/mlmd3Twysj9EHGulHNdrO4Q3H8DiOfKMtAmczjDD VO7q2W9ePpGmSXUkHda/8yyljUqaJNKW8HCofz1yiNXK1zWNyG3jZq72dAqMtkREfC MlpSZMWhdAoYyfbixMYKlMgxLZYxKoTGntUaNw0l9MNgFFCCnUvWks/bxeWFmabCQC REF41GygIAy2A== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 20:09:55 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 15/16] staging: gpib: tms9914: fixes multiline comments style Date: Sat, 12 Apr 2025 11:09:46 -0700 Message-ID: X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/tms9914/tms9914.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/tms9914/tms9914.c b/drivers/staging/gpib/= tms9914/tms9914.c index 2abda9d7dfcb..edbd8ea8967c 100644 --- a/drivers/staging/gpib/tms9914/tms9914.c +++ b/drivers/staging/gpib/tms9914/tms9914.c @@ -53,7 +53,8 @@ int tms9914_take_control(struct gpib_board *board, struct= tms9914_priv *priv, in } EXPORT_SYMBOL_GPL(tms9914_take_control); =20 -/* The agilent 82350B has a buggy implementation of tcs which interferes w= ith the +/* + * The agilent 82350B has a buggy implementation of tcs which interferes w= ith the * operation of tca. It appears to be based on the controller state machi= ne * described in the TI 9900 TMS9914A data manual published in 1982. This * manual describes tcs as putting the controller into a CWAS @@ -321,7 +322,8 @@ static void update_talker_state(struct tms9914_priv *pr= iv, unsigned int address_ if (address_status_bits & HR_ATN) priv->talker_state =3D talker_addressed; else - /* this could also be serial_poll_active, but the tms9914 provides no + /* + * this could also be serial_poll_active, but the tms9914 provides no * way to distinguish, so we'll assume talker_active */ priv->talker_state =3D talker_active; @@ -738,7 +740,8 @@ irqreturn_t tms9914_interrupt_have_status(struct gpib_b= oard *board, struct tms99 switch (command_byte) { case PPConfig: priv->ppoll_configure_state =3D 1; - /* AUX_PTS generates another UNC interrupt on the next command byte + /* + * AUX_PTS generates another UNC interrupt on the next command byte * if it is in the secondary address group (such as PPE and PPD). */ write_byte(priv, AUX_PTS, AUXCR); --=20 2.49.0 From nobody Sat Feb 7 10:08:02 2026 Received: from out.smtpout.orange.fr (out-70.smtpout.orange.fr [193.252.22.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3841A1A23B1 for ; Sat, 12 Apr 2025 18:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.252.22.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744481420; cv=none; b=UzPQGaDZVsnHTsK1qDRBtW/YhP6AuArm/ofTxjpYTUzNbwFoPVVb7tW7vJLLLxbpm8fi0Z5HS6w6xBrqEaQw8/yNBAL1p1pSRnvW6CKtFs6gNcA0Q9Qq3yfcHqsl0dGYW4hIaXHo7vBKS7pVbUPGoXe3v0gMM7oo9ZAVjUHShd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744481420; c=relaxed/simple; bh=gaudnVqMUoy2Fr1V0TmMlGZFF+5NS84yjRnDGzpWB6o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OozAPVV04r4IjkuB7JaEHyNmlGGKKUD2aDEcQDvVYYxjXwLevoxzZzpnvAzTP71kh4ssyW2T6jlFbtxfyJQTdD4gpnpe4kNy0iZktEnT7HRw4jRYZSfRyuoXyDc00LUaS742DP6Y4F5Ci9BAZMwdnDq0CDIYZlv54xnBhKZoIx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr; spf=pass smtp.mailfrom=orange.fr; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b=kvmJKXx9; arc=none smtp.client-ip=193.252.22.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=orange.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orange.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orange.fr header.i=@orange.fr header.b="kvmJKXx9" Received: from cyber-villager.csun.edu ([130.166.192.226]) by smtp.orange.fr with ESMTPA id 3fIuuykkq5k813fIyuvf6X; Sat, 12 Apr 2025 20:10:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1744481415; bh=GUegS7DJ1heWnU9cJ9eegjqKTPOLv20pbEP3tyGJKzA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kvmJKXx9qbM5D5vGzgyuDLqe+GcT8lcR71Yuhox5O8f2v92bRo0xrkz0wwEy/wSbG OegatmqpSg2iRCzRog4XHNiD+0s2tMG4S8otOWAUOSWv1H8FYzkopVKjkwicF6A1IH Y8+kzIVAz0sTE+6JK17smXOUpX4vDsu3MJ6bAKrrSmzn5EWyDD6goosb+zdcDAa4iP CnZsb1V/Us+OSxHU4UnbheRXy8cdpFGIQjr/f9AyOCI3nl/wdrkeNYaTrM73CHA7O8 xviyUrHhjqW24VWyzU3Xl+G4K01ZMCJw3Gp9OjfTlDhlSrR/bliOJngfpwNC1u87VK BnY9/bMTYMOMQ== X-ME-Helo: cyber-villager.csun.edu X-ME-Auth: cGF1bC5yZXRvdXJuZUBvcmFuZ2UuZnI= X-ME-Date: Sat, 12 Apr 2025 20:10:15 +0200 X-ME-IP: 130.166.192.226 From: =?UTF-8?q?Paul=20Retourn=C3=A9?= To: gregkh@linuxfoundation.org, dpenkler@gmail.com, dan.carpenter@linaro.org Cc: =?UTF-8?q?Paul=20Retourn=C3=A9?= , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 16/16] staging: gpib: tnt4882: fixes multiline comments style Date: Sat, 12 Apr 2025 11:10:05 -0700 Message-ID: <2b72df3bfc4a3f57679d2af52112e58acb5c259f.1744438358.git.paul.retourne@orange.fr> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Fixes the style of multiline comments to comply with the linux kernel coding style. Signed-off-by: Paul Retourn=C3=A9 --- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 32 ++++++++++++--------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/= gpib/tnt4882/tnt4882_gpib.c index c35b084b6fd0..51ddade6819a 100644 --- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c +++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c @@ -258,7 +258,8 @@ static void tnt4882_release_holdoff(struct gpib_board *= board, struct tnt4882_pri =20 sasr_bits =3D tnt_readb(tnt_priv, SASR); =20 - /*tnt4882 not in one-chip mode won't always release holdoff unless we + /* + * tnt4882 not in one-chip mode won't always release holdoff unless we * are in the right mode when release handshake command is given */ if (sasr_bits & AEHS_BIT) /* holding off due to holdoff on end mode*/ { @@ -384,7 +385,8 @@ static int tnt4882_accel_read(struct gpib_board *board,= uint8_t *buffer, size_t =20 nec7210_set_reg_bits(nec_priv, IMR1, HR_ENDIE, 0); nec7210_set_reg_bits(nec_priv, IMR2, HR_DMAI, 0); - /* force handling of any pending interrupts (seems to be needed + /* + * force handling of any pending interrupts (seems to be needed * to keep interrupts from getting hosed, plus for syncing * with RECEIVED_END below) */ @@ -531,7 +533,8 @@ static int generic_write(struct gpib_board *board, uint= 8_t *buffer, size_t lengt =20 nec7210_set_reg_bits(nec_priv, IMR1, HR_ERR, 0x0); nec7210_set_reg_bits(nec_priv, IMR2, HR_DMAO, 0x0); - /* force handling of any interrupts that happened + /* + * force handling of any interrupts that happened * while they were masked (this appears to be needed) */ tnt4882_internal_interrupt(board); @@ -760,7 +763,8 @@ static void tnt4882_parallel_poll_response(struct gpib_= board *board, int ist) nec7210_parallel_poll_response(board, &priv->nec7210_priv, ist); } =20 -/* this is just used by the old nec7210 isa interfaces, the newer +/* + * this is just used by the old nec7210 isa interfaces, the newer * boards use tnt4882_serial_poll_response2 */ static void tnt4882_serial_poll_response(struct gpib_board *board, uint8_t= status) @@ -788,7 +792,8 @@ static void tnt4882_serial_poll_response2(struct gpib_b= oard *board, uint8_t stat priv->nec7210_priv.srq_pending =3D 0; } if (reqt) - /* It may seem like a race to issue reqt before updating + /* + * It may seem like a race to issue reqt before updating * the status byte, but it is not. The chip does not * issue the reqt until the SPMR is written to at * a later time. @@ -796,7 +801,8 @@ static void tnt4882_serial_poll_response2(struct gpib_b= oard *board, uint8_t stat write_byte(&priv->nec7210_priv, AUX_REQT, AUXMR); else if (reqf) write_byte(&priv->nec7210_priv, AUX_REQF, AUXMR); - /* We need to always zero bit 6 of the status byte before writing it to + /* + * We need to always zero bit 6 of the status byte before writing it to * the SPMR to insure we are using * serial poll mode SP1, and not accidentally triggering mode SP3. */ @@ -1581,10 +1587,10 @@ static int ni_gpib_probe(struct pcmcia_device *link) } =20 /* - * This deletes a driver "instance". The device is de-registered - * with Card Services. If it has been released, all local data - * structures are freed. Otherwise, the structures will be freed - * when the device is released. + * This deletes a driver "instance". The device is de-registered + * with Card Services. If it has been released, all local data + * structures are freed. Otherwise, the structures will be freed + * when the device is released. */ static void ni_gpib_remove(struct pcmcia_device *link) { @@ -1611,9 +1617,9 @@ static int ni_gpib_config_iteration(struct pcmcia_dev= ice *link, void *priv_data) } =20 /* - * ni_gpib_config() is scheduled to run after a CARD_INSERTION event - * is received, to configure the PCMCIA socket, and to make the - * device available to the system. + * ni_gpib_config() is scheduled to run after a CARD_INSERTION event + * is received, to configure the PCMCIA socket, and to make the + * device available to the system. */ static int ni_gpib_config(struct pcmcia_device *link) { --=20 2.49.0