From nobody Thu Apr 10 18:51:40 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA0B924E00D for ; Thu, 3 Apr 2025 13:27:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743686842; cv=none; b=SX5t/IfFqFMDC+r+LjI9v7UXspg0GgX3Gtogoa2xH6QNxjAyDSmYrtdcNAAVikJiz7pJ7ZAMHgHyUorNRu2QLY3Cy5+3DQorStI/XaUMUfJ+LxDO/Rz7VuQ2P09fIv6XMSPjdXq3a10UmOhnQs9LIBSjGtzuRzl3L1Ss+ijD5bo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743686842; c=relaxed/simple; bh=bVf8sNtlOPiNtnb/QuJiBwy6O37jwESn47YYpAmQjV0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SG6OoXR32v27nwuDD8ZGbLM7ei/zTpe9HIaorQsH831DuYwE+I1JLl4YsNURoIr8U2Fx9Mw99e+Y2z+fNKXcA3YbtkxKXtNSjtP5VN+TZZVnb7bSw96cTLBaXUKBsQIeEcVKieKUphaXPk7E0u0hG6fLKyead9G8BHsdpRFT+dM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hp57XCWr; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hp57XCWr" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so9089105e9.3 for ; Thu, 03 Apr 2025 06:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743686838; x=1744291638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wtb38M7XPfK2ABPkqM2/N+HipjT3AJdIZ5Gc3Kb76jY=; b=hp57XCWr63CGrCvHtVvtukLEhVjR0/RSmvRMGeB8Rz4mmAKc5ZyelyYrfhtoYJLCs1 55I2gHiJOiZ6f/Xorr3N6nLE88U4zXkdobKP6f/aCraQ6OybOViExfnRTRtSnB4Za/8s bWCe4azE23j00wZiYkBNBBw7EewMoWhv1P2Ovr1yVHk1aMWOnKh3/27ifOdLsyBiRrmj +9Uljhm3oFCao+PJU04HZx7ve2qY/HytOCTOkDBD/XTrGom3DYZw0L3OFcRVqn4mbg4q /qITDKfNPdVLH86ThR8jvd2aS0cutN2Kyb6Ns1LqbcCeJTcuFhjBbSssbaJ14ur4HPZT n4ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743686838; x=1744291638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wtb38M7XPfK2ABPkqM2/N+HipjT3AJdIZ5Gc3Kb76jY=; b=FPqWtdNtnKH6LS0OB3dYBaxzZBB2GBbObpdFnNTsS6ifDGkKcAeBUb8RoP0mKuGX7b F/EOxm8KhKG2UJq9F4e2tkI+Q+N03zknPljScsIuTLXsomSqrFMkmxT8AyYca03WoyeM rjGUWHwrycluTyiEOvVuWjqwmLqpXXAN7VzStOglfLgxhka1HCFskjTX6mUdvR6tMmpZ Qf1JmOQ9vjmxdIPoTQU70fiUI0hwi+c2fT0JYEvqKi/fEYZJECw3gAMR0rjzOO1r7BEV Y7B3pu98alBZBo3nQoUmeQOcDjhvoEZUmFM29FoPSWZ8wtITcBY9EqcV3z/ngn3YYiAj diCA== X-Forwarded-Encrypted: i=1; AJvYcCXfipZQOKXZGzKHVl23INkEZiAva4VxvJW9q2h/CWiqZT3mb3YB/pO1m2KiS8osLK6eGpuUExkQQkSAEBw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4JZbBl3lrq8Ts/2V+Eorfqc+DcMADN+A/cdvKEDtc5dldkw3o Vt1VTINokpR1BS9052p/eDylQIbVo4Vhi+uhdOUGMg2++tj5hZBC X-Gm-Gg: ASbGnctQX7zEkpoClbfyzsF2AiAAfbHtr3XX5h2lICBhNYbXj+XlMc8h9SDUMtTgcVr BQSijH9SoBsvu+/QHT4UiviP76awd4V4dzQa/FyZVmh6bUWOxd2OkGjSQfzQUjN2IolHd82DJyz 88T5Ghgsp0PFrL/PjbmP8KYgYjefcGet8kjdRQzvoCxyT8/fKv5mMz12o7ASNa/UqMvdZ56HC2W DI3/gWYzvo6xjgspbttmqSKRHMzIxSQqgZWcB/7lJxCjndXcYLlmgsWMeLrbFlgy3gzuZMZ5P0D NDpxLuHAwKZfv8icH7QvQpqEsJITrkSnTFuDR9I8llM= X-Google-Smtp-Source: AGHT+IEWrpNwkQmaE+F7DT2RwdWz5IQFeLuSWWcZCSMqyoShcSaTPUbro2aUdBJ7nPmipn5q9X16tg== X-Received: by 2002:a05:600c:35c5:b0:43c:f575:e305 with SMTP id 5b1f17b1804b1-43ec1397af4mr26286315e9.8.1743686837648; Thu, 03 Apr 2025 06:27:17 -0700 (PDT) Received: from HP-650 ([197.210.35.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1f27a55sm20532075e9.2.2025.04.03.06.27.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 06:27:16 -0700 (PDT) From: Abraham Samuel Adekunle To: outreachy@lists.linux.dev, julia.lawall@inria.fr Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, andy@kernel.org, hdegoede@redhat.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, Abraham Samuel Adekunle Subject: [PATCH v2 1/3] staging: media: Remove duplicate NULL tests on a value in pci Date: Thu, 3 Apr 2025 14:26:41 +0100 Message-Id: <26990d4a9d4419f9d4155a40595bc213acb671a0.1743685415.git.abrahamadekunle50@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a value has been tested for NULL in an expression, a second NULL test on the same value in another expression is unnecessary when the value has not been assigned NULL. Remove unnecessary duplicate NULL tests on the same value that has previously been NULL tested. Found by Coccinelle Signed-off-by: Abraham Samuel Adekunle --- drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/dr= ivers/staging/media/atomisp/pci/atomisp_gmin_platform.c index e176483df301..0abac820299a 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c @@ -1292,7 +1292,7 @@ static int gmin_get_config_dsm_var(struct device *dev, * if it founds something different than string, letting it * to fall back to the old code. */ - if (cur && cur->type !=3D ACPI_TYPE_STRING) { + if (cur->type !=3D ACPI_TYPE_STRING) { dev_info(dev, "found non-string _DSM entry for '%s'\n", var); ACPI_FREE(obj); return -EINVAL; --=20 2.34.1 From nobody Thu Apr 10 18:51:40 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92ADF248195 for ; Thu, 3 Apr 2025 13:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743686865; cv=none; b=jeH/Jy5Ku1dGnHCRsQPmssKvjH56TvpFTtOgIF5WyBrigRV+iMzAhb3kXizo/GmHLQURUBrwCqmo3lDGlTiFgBhHzCFbkgZizItIuRulboXHuNvReKPpaKayAXNXBPlSAiM6Ds4459yZn5esCJzDnBh3/HEyt7e2EM7pQpiZef0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743686865; c=relaxed/simple; bh=3lqEc9rPy9OYJRQBlojfZPpuIi3iFAtcMjxPrU7z7DA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qves2atO4ggH40g3YouKyCbx+TJILTfflDHQ8l+aeDBPS4vbVA9Ye5IAFtqxk3YQKZEe/+s0z31vuHmSsKcs63dk6GNSpBMVGiLljHeRLrw1hxj4gkprmkUNAydRCS1pRIcQQjNJI7Pwz392YX2JHr6cA55z+ek2LvuBOqqNHa4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A9vsAYxT; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A9vsAYxT" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3913958ebf2so638781f8f.3 for ; Thu, 03 Apr 2025 06:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743686862; x=1744291662; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dp5nBsd/DFr5VpeaYg8UHTlBPWUcWv/79+vKJ0EyykY=; b=A9vsAYxTxDKykIFOTyV+Xh8SnFiLQY7gXqsuIDhzTNQgNFP5YzzUYMH7OjqK0ddHAF qLEVCRMgPWAzZekhNXJD/ED16zEMaLOFfjwcc7I3Spd/rWdc9WJlZWw2f9aSasfo1Op6 94yvubYsNBUY9O7T/0RzmCAJNyGUcGbWt5errC/exlw/9HFpvUbrqiQUv+Abt4z5X9dX rUaWTEEGSRw4hcfWo2FtMKlw8AiwiZHZXb4Co6GD+h67lGeQbePDxeyBLHkxWakJe1ea mjLDm11RblKTC8ZNa/6VsbBFQ5JTfIjv747/dtNIyOAuxT2e0/6vNs+6GvH/pQaeiuvT YJsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743686862; x=1744291662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dp5nBsd/DFr5VpeaYg8UHTlBPWUcWv/79+vKJ0EyykY=; b=Mo8o2+XYrJxkmcI4PKGmP7CR+XvVNu3mRv0EIvYiCx0pER1Vonxr+MW7FqcN4NHD+k 45i3XNPxVIPWDku7NvpRD/4P8IcjRTK1nwP8fEYxWW0M5+VzQvjX974lS9Zetr8ZwPvL 8b1glt8VS6TreoEp0NtVPLcIQE/G4K40f5t/LCkEWk/rjqtaRoxTQvlQAzF3i2vNjz9H h2VlP1LzaVD4g2u6uThaIPA9HdRbAnepI7xmGDwAjlgXlL72fjWcfo9768PwwoDzq7xE joiPfJRvxCTqQRKE/O173lFvxgCDkp6KYIYz/OKS3M7xoLaJkKaTqNufgLATqnAwbm12 DDnw== X-Forwarded-Encrypted: i=1; AJvYcCVmu/zeevshrMPPLDpJok6cG0qGJ2+1gphGos8Zx+3OWehkl21haS+8AxgZlrBCuhrg0FzywvJJepLvo/U=@vger.kernel.org X-Gm-Message-State: AOJu0YytM5QQVWleZXHjwkJklA7WBNSF2pxXbrrlOqI9PqRt34SE08yd +Wv1wbKrNSLtQk1y46/C+ywiGZOT00ZSv/BKNTRuF2ryQ35JtV+q X-Gm-Gg: ASbGncv1nYhEHE8B/O2rAcN7QRRZw86w8M0rIeblqLtMgk1tuEETzP3vAkyxNnb9sBu 6R5VHRprVtQxHakg1e2DwR9bKxuNGSNPhv14/SjeOjhxTQ7r064rvU9NniLjOuSV+dfDsr8myU9 5Mp1B2whVwjVrCU9yWDI5LSmTslYLhBMoH8oeDq6jmIzlhbh5EruqQW/cb6QnJyDnDt7nU3N1GS 2/Li5bzPB1wjXyUH8NHg5IzB31X6xrPS3yOzXeWc9VRSyG8OMKfmb0x46PqlHX5XyYfAiJh3Mb8 lj+SH5x9zh2NnyNjHRV9PXPVI5b2dtgpMiS4ddlxbZooJ2IIqG3vnw== X-Google-Smtp-Source: AGHT+IF8hv/rELd9ZpO2/F3vybwO6WLkSrCgrysuGBoCihWf+/H7dhnQV7G5SP6T1xyX8KA9DX7Wcg== X-Received: by 2002:a05:6000:1acc:b0:39a:ca59:a626 with SMTP id ffacd0b85a97d-39c297687e3mr5947919f8f.28.1743686861580; Thu, 03 Apr 2025 06:27:41 -0700 (PDT) Received: from HP-650 ([197.210.35.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec36691b3sm18621535e9.34.2025.04.03.06.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 06:27:41 -0700 (PDT) From: Abraham Samuel Adekunle To: outreachy@lists.linux.dev, julia.lawall@inria.fr Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, andy@kernel.org, hdegoede@redhat.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, Abraham Samuel Adekunle Subject: [PATCH v2 2/3] staging: media: Remove duplicated NULL tests on a value in av7110 Date: Thu, 3 Apr 2025 14:26:42 +0100 Message-Id: <76351e135cf7ec4d609e60461bae4ba6d3c3a445.1743685415.git.abrahamadekunle50@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a value has been tested for NULL in an expression, a second NULL test on the same value in another expression is unnecessary when the value has not been assigned NULL. Remove unnecessary duplicate NULL tests on the same value that has previously been NULL tested. Found by Coccinelle Signed-off-by: Abraham Samuel Adekunle --- drivers/staging/media/av7110/sp8870.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/= av7110/sp8870.c index 0c813860f5b2..65842dd559e3 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -508,12 +508,10 @@ static int sp8870_set_frontend(struct dvb_frontend *f= e) } =20 if (debug) { - if (valid) { - if (trials > 1) { - pr_info("%s(): firmware lockup!!!\n", __func__); - pr_info("%s(): recovered after %i trial(s))\n", __func__, trials - 1); - lockups++; - } + if (trials > 1) { + pr_info("%s(): firmware lockup!!!\n", __func__); + pr_info("%s(): recovered after %i trial(s))\n", __func__, trials - 1); + lockups++; } switches++; pr_info("%s(): switches =3D %i lockups =3D %i\n", __func__, switches, lo= ckups); --=20 2.34.1 From nobody Thu Apr 10 18:51:40 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46E1724E00C for ; Thu, 3 Apr 2025 13:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743686877; cv=none; b=RGAKlsLtn8cqw5NmjAHSpD+SrkSUPylxBgaMPIjTrlENaBrJ4Cisn8GuEuaY2V2kPc5GiMkDDkfQeqQGCsW5glFcVQZl/EtX6xleq/lzTQaypDFjqI82CC6l6VgBExRz4p184WuEBVt8k8+w1Q21VSpImugLkX/uta9iUb9XuLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743686877; c=relaxed/simple; bh=TppPfz48Zffja+0eAECqj/ufQLq2W2xqDiyamIDS1nk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eCNXXg7R4YpUeIWe+G12NPzFSR+JjUqeKznbqr+lGv7/s6YM5Uz5j4TL7ktw/Yh1vw4gF+YO2PJvxI1t1r9A/De1jHgFdcJrePzXERbPeeppYMNMvXWei77wpVaK8B74uI0E8SK8OYNQkCC9Y0Gn1vpVwindY6uvmiUfihKBjXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HLwsZU6w; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HLwsZU6w" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43690d4605dso6201615e9.0 for ; Thu, 03 Apr 2025 06:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743686873; x=1744291673; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XYfbRwZUzQz04jJUerlZh/Bqaam70D9SFCg8UAJdhY0=; b=HLwsZU6w7aVDCsrsujm0Us+uyHGVeWRjIik/wXIlUz9CXHmqpnFlkq4PQsevkjNvM4 G2pfeu/ZYlTwW+aLgmgHlAV5UfQcSr2GZgh36Tv0NijX9ZhftONMReZiLqul7D0nJYeI GLFkzKwjofiAdEXYpXwqrmEkwE292FxjhwTOBe3+fpVAseyYf/FeulxWevRcm7cPSGsJ EduSJ90/UMUwNvtRa8F/bc/X4UC8soC8X/92d9zm2YlX1Zm34SS+c7XhDs93PjNlTLrh JRDOnJHhgWmgvxL8gsbXUjDpOyrbhC14F/u38qkm084nVSAvAKvcxkI7UtcKpekGmOd3 +zZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743686873; x=1744291673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XYfbRwZUzQz04jJUerlZh/Bqaam70D9SFCg8UAJdhY0=; b=M1uM/EtCh6lMZYk67yzb0kT+lT8Qw4H/xM/8ndAn5hW5Gt03JMTdbJ4NK1vlJNFmGZ pqtFmeQjKE/Plij4aaU9msKszxl78mKfGX5aeAExR0pJmhs+l1bi5RhtbxkC37glZ33U E1/34wd4F33PmFtP3ooixHMtaPpV8JQuBCmxbplEFapjZknZOMorEWU524I5/t3q3O8x jgX9NEq9W/V4+hOebwMQEgVfMcfhavsTCx7EZ4/Zdf6WppvTY5pfzlC4bwzWLiwKWC9j UrdfekLfqF8vCq6urZvf8TTxR0z22O/X3+bT8jjjWM3kpQH4zXgpSo+0hN3yLDg7LOp4 f1AA== X-Forwarded-Encrypted: i=1; AJvYcCXl7HR1yIUbTS7LxmHVS3BwfUx1g09g+r6+0TrCBc9ELbvbIGl5+W0N+6AkQmmjVwpIVaIdO8JNeg0bcrg=@vger.kernel.org X-Gm-Message-State: AOJu0YygnDPMH6x+IZ51LXxm6u3Umyn3IttXVE50jU02TTM6hZ+beBus 3V4uTuJAr+DQP5bQmfTzn0b2R1qflEsPAK+LJlVxYkRyTzetqNt7 X-Gm-Gg: ASbGnctV9HQB/9piBWHjMElHCtqqODdyD30u/4SCWkgDiT/xKtudOo1GJk5wl8S1o9f MwLg5q3UOPGJ3/iEsKMlgQQdzEvLkjLi6yMjktJ34rdRspC5k0KJNVyyO6Ah82J4Egx3jXWcv9P rinDH2941JK3ZnyZilEWeDxWPJLj0p38dLPpX3eo/wRSTzWS2/hQypcVrWaloCL7GRwxc3z2xLb tfrcyT4gsapg+slCqITNYJt+c16Z398mPj4B+iUHkLGBujWl/jXm/2EjYTGezc/ZWRUsg2jjHMP DkuARkHtj7l5WoYWc6TyacfdJrm9HG6ZenZ0ZcD91Q4= X-Google-Smtp-Source: AGHT+IG2whMe7p+lHvWAbm/G2Q6XIeZ+yTcqJqi0mfB5DqR5mC79MruKtdqNX9IV4WY/5SQ7zodhcw== X-Received: by 2002:a05:600c:16d4:b0:43d:7588:6699 with SMTP id 5b1f17b1804b1-43ec40eeec7mr15115695e9.7.1743686873298; Thu, 03 Apr 2025 06:27:53 -0700 (PDT) Received: from HP-650 ([197.210.35.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec364c959sm18242925e9.25.2025.04.03.06.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 06:27:53 -0700 (PDT) From: Abraham Samuel Adekunle To: outreachy@lists.linux.dev, julia.lawall@inria.fr Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, andy@kernel.org, hdegoede@redhat.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, Abraham Samuel Adekunle Subject: [PATCH v2 3/3] staging: rtl8723bs: Prevent duplicate NULL tests on a value Date: Thu, 3 Apr 2025 14:26:43 +0100 Message-Id: <1325d06f5a4eb18eb52eb20d5af89207504c46b6.1743685415.git.abrahamadekunle50@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a value has been tested for NULL in an expression, a second NULL test on the same value in another expression is unnecessary when the value has not been assigned NULL. Remove unnecessary duplicate NULL tests on the same value that has previously been NULL tested. Found by Coccinelle Signed-off-by: Abraham Samuel Adekunle --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 56 +++++++++---------- 2 files changed, 28 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 90966b7034ab..675226535cd1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1323,7 +1323,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) spin_unlock_bh(&pstapriv->asoc_list_lock); =20 /* now the station is qualified to join our BSS... */ - if (pstat && (pstat->state & WIFI_FW_ASSOC_SUCCESS) && (status =3D=3D WLA= N_STATUS_SUCCESS)) { + if ((pstat->state & WIFI_FW_ASSOC_SUCCESS) && (status =3D=3D WLAN_STATUS_= SUCCESS)) { /* 1 bss_cap_update & sta_info_update */ bss_cap_update_on_sta_join(padapter, pstat); sta_info_update(padapter, pstat); diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 026061b464f7..f817cab2f831 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -941,35 +941,33 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hd= r, struct pkt_attrib *pattr if (!(psta->state & _FW_LINKED)) return _FAIL; =20 - if (psta) { - psta->sta_xmitpriv.txseq_tid[pattrib->priority]++; - psta->sta_xmitpriv.txseq_tid[pattrib->priority] &=3D 0xFFF; - pattrib->seqnum =3D psta->sta_xmitpriv.txseq_tid[pattrib->priority]; - - SetSeqNum(hdr, pattrib->seqnum); - - /* check if enable ampdu */ - if (pattrib->ht_en && psta->htpriv.ampdu_enable) - if (psta->htpriv.agg_enable_bitmap & BIT(pattrib->priority)) - pattrib->ampdu_en =3D true; - - /* re-check if enable ampdu by BA_starting_seqctrl */ - if (pattrib->ampdu_en =3D=3D true) { - u16 tx_seq; - - tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; - - /* check BA_starting_seqctrl */ - if (SN_LESS(pattrib->seqnum, tx_seq)) { - pattrib->ampdu_en =3D false;/* AGG BK */ - } else if (SN_EQUAL(pattrib->seqnum, tx_seq)) { - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (tx_seq+1)&0= xfff; - - pattrib->ampdu_en =3D true;/* AGG EN */ - } else { - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (pattrib->se= qnum+1)&0xfff; - pattrib->ampdu_en =3D true;/* AGG EN */ - } + psta->sta_xmitpriv.txseq_tid[pattrib->priority]++; + psta->sta_xmitpriv.txseq_tid[pattrib->priority] &=3D 0xFFF; + pattrib->seqnum =3D psta->sta_xmitpriv.txseq_tid[pattrib->priority]; + + SetSeqNum(hdr, pattrib->seqnum); + + /* check if enable ampdu */ + if (pattrib->ht_en && psta->htpriv.ampdu_enable) + if (psta->htpriv.agg_enable_bitmap & BIT(pattrib->priority)) + pattrib->ampdu_en =3D true; + + /* re-check if enable ampdu by BA_starting_seqctrl */ + if (pattrib->ampdu_en =3D=3D true) { + u16 tx_seq; + + tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; + + /* check BA_starting_seqctrl */ + if (SN_LESS(pattrib->seqnum, tx_seq)) { + pattrib->ampdu_en =3D false;/* AGG BK */ + } else if (SN_EQUAL(pattrib->seqnum, tx_seq)) { + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (tx_seq+1)&0x= fff; + + pattrib->ampdu_en =3D true;/* AGG EN */ + } else { + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] =3D (pattrib->seq= num+1)&0xfff; + pattrib->ampdu_en =3D true;/* AGG EN */ } } } --=20 2.34.1