From nobody Sat Feb 7 22:22:48 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADF90190485 for ; Fri, 28 Mar 2025 05:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743138266; cv=none; b=XZK6xhu6ys3gP43V6dSOw0GPOMxN5GjqJ1PaFXsoux6hkE9g9liGleIebCug4GsstUxc+GjKsBWnGZH+IHS3gcnFfuCIGRucCA46BXH6TnRL6HPsQxK29bYbsCaCYTFK1/PC1Dy1OiAYHmNvm3KXRkad+67UDYV2yeLSGux3CP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743138266; c=relaxed/simple; bh=EgH+zS8m02VBfvYvd5mItGroGZUXJBXJ8xd4n5yOAJ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SFJ7ZwkwhY6X2Sp7G3siXxq8rImwjl5D0L2szAezASaZ/Bk7eRl9ns35hg49XH1EWQuAs5QUQhq3orSahpdk9u4tutG9tRx4sBV6HMsZ5vGJ1MJSfkGDGguNd2MKxNeC0XAbjQTMRkZ4SN5KB7si9G1X9H4Ig54oVk2pjM8i9RA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T+FhOJ5R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T+FhOJ5R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF21AC4CEE9; Fri, 28 Mar 2025 05:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743138266; bh=EgH+zS8m02VBfvYvd5mItGroGZUXJBXJ8xd4n5yOAJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T+FhOJ5RjOfPjBGz7/Xw2airX0wkhF8X0njb21yb5BXBPGklPT4YfgNX7RP4p25yj y5cOP2/2PeJ0hwryVQlBI0grU0DCTETQBvVp+erpyh6Kd6aLeP+uFFSYW1thGXwCOD FOqRSztajWOohZvr8sfETYr7ssl5YVBlVSo25Nrhn6wE+0DWGrIkoxTvU91Tb07krt 6OgbxLPTOhsn4IxlsfWiW5JWYUOp5ZKd/KBNOgzEzTXC+tRGapDysg7ia7SijjZYb2 q52SNcwP3edM3ho7VWB2VTjJ+3q3A4M1bT6zje4Ae0ecibaJDRo0vmLvAamMR84wW5 59yi9To09nKnw== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Arnd Bergmann Subject: [PATCH 1/3] objtool: Fix seg fault in ignore_unreachable_insn() Date: Thu, 27 Mar 2025 22:04:21 -0700 Message-ID: <5df4ff89c9e4b9e788b77b0531234ffa7ba03e9e.1743136205.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Check prev_insn before dereferencing it. Fixes: bd841d6154f5 ("objtool: Fix CONFIG_UBSAN_TRAP unreachable warnings") Reported-by: Arnd Bergmann Closes: https://lore.kernel.org/d86b4cc6-0b97-4095-8793-a7384410b8ab@app.fa= stmail.com Reported-by: Ingo Molnar Closes: https://lore.kernel.org/Z-V_rruKY0-36pqA@gmail.com Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 3bf29923d5c0..29de1709ea00 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -4037,7 +4037,7 @@ static bool ignore_unreachable_insn(struct objtool_fi= le *file, struct instructio * It may also insert a UD2 after calling a __noreturn function. */ prev_insn =3D prev_insn_same_sec(file, insn); - if (prev_insn->dead_end && + if (prev_insn && prev_insn->dead_end && (insn->type =3D=3D INSN_BUG || (insn->type =3D=3D INSN_JUMP_UNCONDITIONAL && insn->jump_dest && insn->jump_dest->type =3D=3D INSN_BUG))) --=20 2.48.1 From nobody Sat Feb 7 22:22:48 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 029421C84B3 for ; Fri, 28 Mar 2025 05:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743138267; cv=none; b=qRU8fp7YuPHcUdqb2kdFIhLYcp7MWYL4HBK1DJHme69cGgbDS9yU3brKT9U4DxgnPZGbyMr7gS32FdAimNagHPYv5ylyQkhv7vbmuO52mQ8o+IyKVtGhak2i4RE1kO3aTgEJWT6uG2qDLG0daPQ/I7oWLWwHxsOKxrwLSztd0/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743138267; c=relaxed/simple; bh=lS79mp1UHWS0SDhbFFU0ZHGEGRIr5Z31iIdfbGeyhws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rN4xOpGoRnLckOKMTkC4ChvJmkqZue4vnQ4KPVI4ygohlrBrVsINWbQTwJ3OIpJR7HHsjFJ93zD17h56BZcl7lOP9O6qec/NASrzL66/CPfi5swbInoeBKvxtTCSWYFAGFtu9nQcfgppKlVE/P5on4oiVCkv08C8zXFQLF0YRaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pr3xPL9S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pr3xPL9S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5095EC4CEEB; Fri, 28 Mar 2025 05:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743138266; bh=lS79mp1UHWS0SDhbFFU0ZHGEGRIr5Z31iIdfbGeyhws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pr3xPL9SQL/NuWCbWMRuSypSfq/2nIUQLGatNaxJiqg90PsjFNDZlBKEAzgTZB6fg +3XHqNogDJyiFbDTJvjz4OIA61bWablshTk+kYd2dlLwdy/SqAysOQtWc/yi+j+BkH utHTktPXuWT1BlBsDrT3FfuPCJLPM+u2v3ExoF4+Ck+9jfNBA7HPP06WEYYownI0sP Ftdub+mTNoWtWJt0XGyZmB7mENY43RQdzIb2vlOX860+s7q5tWIpgJInKgipXJMuA3 Yiyjqfhn5m8Xb+n9eGRhokqb8ZwDFr5iy3dBG1YEA0AK41EAkcYB/1STVjvQNNzlBA JvrpUOkJu/ICQ== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Arnd Bergmann Subject: [PATCH 2/3] objtool: Fix STACK_FRAME_NON_STANDARD for cold subfunctions Date: Thu, 27 Mar 2025 22:04:22 -0700 Message-ID: <70a09ec0b0704398b2bbfb3153ce3d7cb8a381be.1743136205.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The recent STACK_FRAME_NON_STANDARD refactoring forgot about .cold subfunctions. They must also be ignored. Fixes the following warning: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: warning: objtool: vmw_recv_msg.cold+= 0x0: unreachable instruction Fixes: c84301d706c5 ("objtool: Ignore entire functions rather than instruct= ions") Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 29de1709ea00..fff9d7a2947a 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1014,6 +1014,8 @@ static int add_ignores(struct objtool_file *file) } =20 func->ignore =3D true; + if (func->cfunc) + func->cfunc->ignore =3D true; } =20 return 0; --=20 2.48.1 From nobody Sat Feb 7 22:22:48 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6015720DD7D for ; Fri, 28 Mar 2025 05:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743138267; cv=none; b=K8h6LTEKbby2PrxEjnsE+RLOb1uVkfXkAjbNZ3umbWyljG5SgahjQfOk6H6EshGfntcsQZDNYbv+xZitjaUkW+DOVRgnUIFHHMDX8XXPeQA+G+uAjOPnWVMTRd4m+7cp8u7rf2rfkg15S/hZ/h64eJ32rBKtMdfSeohhzl405Ng= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743138267; c=relaxed/simple; bh=1yj8dhgzDIV8G0WRIClQNYLJgUPmkwlcqABMXs/7pjg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tlyareZQWC36ERI7exWL7xC7IZG8E/LtQJP1oQ5h31GYvT8Zzg/5kPsnSSJwyVb//4/YptMU9eS0IfrMuey1ERY6NHBAEBRlv9uxTHWOHobcvCDZk1auP4hZyTQY2VDNuQB5cRZg9BV3kUikVV4CbTQYuqFCP/3EBjmiVYO+RBA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WL+fZg6v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WL+fZg6v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7498C4CEEE; Fri, 28 Mar 2025 05:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743138266; bh=1yj8dhgzDIV8G0WRIClQNYLJgUPmkwlcqABMXs/7pjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WL+fZg6v+ghExi/6DoqKiuFO0T3wgr8pLyItZozndv6ZrWky5ZjnW1t7ia4h7Edtf jl8zTlR3u/Mn5UfTFXIaV7FNgq/4Lr22Unh7xBIUTV0Dk0VgQWXhMxT0owKez/z9YH 0h0ngMX/GCgH+ngxBD1UFvIOU2GopXGo40z4/GD/6uuUEcM9y/Djne82ogFNShPmZl kT41JifkmyAxdmwTjslASB16ZCg/N7BG2trVgxQ2MpUjcRbLuskfVUauCBtmQ734kb WcmwCfoVsdfCEtCaXmWGtWPtCg4v/VTNSaHXEgyPqdib3e9UJsMi4GLgodRlm6oQU5 oPJ6+cegCBr8w== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Arnd Bergmann Subject: [PATCH 3/3] objtool, drm/vmwgfx: Don't ignore vmw_send_msg() for ORC Date: Thu, 27 Mar 2025 22:04:23 -0700 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The following commit: 0b0d81e3b733 ("objtool, drm/vmwgfx: Fix "duplicate frame pointer save" wa= rning") ... marked vmw_send_msg() STACK_FRAME_NON_STANDARD because it uses RBP in a non-standard way which violates frame pointer convention. That issue only affects the frame pointer unwinder. Remove the annotation for ORC. Signed-off-by: Josh Poimboeuf --- drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c b/drivers/gpu/drm/vmwgfx/v= mwgfx_msg.c index 1f15990d3934..1d9a42cbc88f 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_msg.c @@ -289,7 +289,7 @@ static int vmw_send_msg(struct rpc_channel *channel, co= nst char *msg) =20 return -EINVAL; } -STACK_FRAME_NON_STANDARD(vmw_send_msg); +STACK_FRAME_NON_STANDARD_FP(vmw_send_msg); =20 =20 /** --=20 2.48.1