From nobody Sun Dec 14 07:50:24 2025 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50EED158524 for ; Tue, 4 Feb 2025 06:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738652304; cv=none; b=EsCHJZXVKv6POgisr9fGHoZ/5/8xPrFXELq5wh+U3MiqXLdjChH2MpcdBwMj48IQqVZKvsqBCOOF6pFvPnWGpz/OJZvjcpdqDuZW60/LSyQXrOjMARD40XmTgni6WM1/cPWamCc8R4w5lyYw6fRTf/J56Sy4ECdcRO+HuUmZ1fY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738652304; c=relaxed/simple; bh=dY3XMv6XCS+Kgh20TNrcg77Cnv/MOiEl1Kmxsu+FxzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HE0tQ1PUfLSW6Z79E/17nMtZdiyhR3UzS90jfAI1K1SYzXVkuhcG2yAWQ4zxv1DrxwAIgtzY9Yu6BZo8Z8JvqDBB6uH/Yn6yUDIc8WXj/UvsU+WKXa+yxhOp55uZGQ/UJvzUfnMbr5r4X2W/siVaq4DObWnR6v0TXMG3XOwKYIM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f6Nc5LVb; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f6Nc5LVb" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-2a01bcd0143so3489120fac.2 for ; Mon, 03 Feb 2025 22:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738652301; x=1739257101; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q+gIbAsvAdDC8Lv0QOQf7RrQntEmNr+Q7vrClBGKTqs=; b=f6Nc5LVbY/NLUM4NN0Pqqw58HiRnEYdJeHgG0tJQi/6/8jwM6aHdONmSPk9waoiKAA FIRPtB7Hx7kQ3KPtpeL4KWd1jZ1315YS8dLtYcYNyAHYXbAtWE58zmtAw7OUPGtp9Hxk XyFRPocTZt4Mk19baX9H4VficcFcqWFToPDXj1WTiUB19aU2OXbW5W/+aV0/RBX3qw7u rTyjIRZTA5l83ZrtQljsceb1dRsHj2EMKXAW9IsttKf1NMxdqLC8GXVGFIuodwLnO4n/ F55jzXcFWN/hKyguqtCmbUuOPEz2TFZFAxuF/R9RmmOPW8MqOGlLw0tvaLo9PZEAtBSZ UYQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738652301; x=1739257101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q+gIbAsvAdDC8Lv0QOQf7RrQntEmNr+Q7vrClBGKTqs=; b=YMKX6jnrTEcK9223C9d6AOVa9qpbaBpb/v7zEeu99syNj0aOHu0mkFQxFRovUHq/em aEqAMCAHX12wV7lwoRxc/QqM7Vi3uA6LFTMFzyyLsBzzvAaMIvQtZlmABBLkxuBs8kvR X+bsHdSX6ENFdiWWnliw5qAREiQyGIvR0/yQfHUXRNPWP4VuwaSspiMg5Gj8tmNXIoYT W+FsR2Vo8EgR21oOLJzaZjdqe+7B09VdOjY32iJhax46wO5s9QdnBOqxs6HKU/HS5iOX 3a4wROBYBPtxHqQkLhoFxZDnklwMjcgJ2iKRHZOdDWibtM+fzzH2ojVzWtNjnmIvp/zr vmng== X-Forwarded-Encrypted: i=1; AJvYcCXfEQFkkie8GyCg8aZn3Phtw6F00oUzRJAOodrRuyfmn+qJlOcrqfRZ16LI9FQSX+BrrTd3LpriK9OkPgg=@vger.kernel.org X-Gm-Message-State: AOJu0YxwSs6JbHeJhGqMqaHciiVYS0RGxniUuUfIV7CSgjisodTemwN+ z3NI7jzKdkcTXQj/jR8GevD4pXrNm0GZn5S1ehZqlAheELdUNcnfDCI+Buv2bDA= X-Gm-Gg: ASbGnctO+l9RbOyvimcaY7/wzQ1x6Ftth/NKezBj/3RHZ8pHJMQHzrPBTfcFf7iAA2M 3vwbNkE5Ofe3cUH9gYIFaSAheagNJfqROt1Kxzo04UKWI/7GyxGITHl1RxIUiwkRkcrVm0dgWMx hQhDwem9+4PROVI998EMnmTPHQYHbulaVwUGAqu/A9rC499Gk8nLvTabMphyW3CLRrL5bEjk+0P 2rPJ/U3faBp31fLv2fSOlGQEIOjYnWXDcbft1Sl2Fiuj099sOkFns971RZePz2jZ31ZAnmEc/lz KOAGdU5VY7qVg4EyJuhGL+1xWFlLyb8Pyzqyj5N/+/mq50E+HWRB89V1SKGi/Cif0JrSThJJNtA Y X-Google-Smtp-Source: AGHT+IHud1Lx/e9hjLylARcdg9YwgwsL26JFB4RSMGKgaYHKocJaJ769bcyXNbc2yJwuIYn75/h4mQ== X-Received: by 2002:a05:6871:20cb:b0:29e:526a:eeef with SMTP id 586e51a60fabf-2b32f3503e2mr15436661fac.34.1738652301328; Mon, 03 Feb 2025 22:58:21 -0800 (PST) Received: from DESKTOP-GL3U3CJ (162-207-94-177.lightspeed.irvnca.sbcglobal.net. [162.207.94.177]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b3565b5946sm3887340fac.31.2025.02.03.22.58.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 22:58:20 -0800 (PST) From: Ian To To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ian To Subject: [PATCH 1/4] staging: rtl8723bs: Add missing spaces Date: Mon, 3 Feb 2025 22:57:19 -0800 Message-ID: <28655748fedb84aa4cfde307ec4d2020610b2047.1738651582.git.onlyian4981@gmail.com> X-Mailer: git-send-email 2.45.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add missing spaces to operators. Signed-off-by: Ian To --- .../staging/rtl8723bs/core/rtw_wlan_util.c | 55 ++++++++++--------- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 73c70b016f00..f73bde9ee4d3 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -170,10 +170,10 @@ void get_rate_set(struct adapter *padapter, unsigned = char *pbssrate, int *bssrat =20 void set_mcs_rate_by_mask(u8 *mcs_set, u32 mask) { - u8 mcs_rate_1r =3D (u8)(mask&0xff); - u8 mcs_rate_2r =3D (u8)((mask>>8)&0xff); - u8 mcs_rate_3r =3D (u8)((mask>>16)&0xff); - u8 mcs_rate_4r =3D (u8)((mask>>24)&0xff); + u8 mcs_rate_1r =3D (u8)(mask & 0xff); + u8 mcs_rate_2r =3D (u8)((mask >> 8) & 0xff); + u8 mcs_rate_3r =3D (u8)((mask >> 16) & 0xff); + u8 mcs_rate_4r =3D (u8)((mask >> 24) & 0xff); =20 mcs_set[0] &=3D mcs_rate_1r; mcs_set[1] &=3D mcs_rate_2r; @@ -267,21 +267,22 @@ inline void rtw_set_oper_ch(struct adapter *adapter, = u8 ch) dvobj->on_oper_ch_time =3D jiffies; =20 #ifdef DBG_CH_SWITCH - cnt +=3D scnprintf(msg+cnt, len-cnt, "switch to ch %3u", ch); + cnt +=3D scnprintf(msg + cnt, len - cnt, "switch to ch %3u", ch); =20 for (i =3D 0; i < dvobj->iface_nums; i++) { struct adapter *iface =3D dvobj->padapters[i]; =20 - cnt +=3D scnprintf(msg+cnt, len-cnt, " [%s:", ADPT_ARG(iface)); + cnt +=3D scnprintf(msg + cnt, len - cnt, " [%s:", ADPT_ARG(iface)); if (iface->mlmeextpriv.cur_channel =3D=3D ch) - cnt +=3D scnprintf(msg+cnt, len-cnt, "C"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "C"); else - cnt +=3D scnprintf(msg+cnt, len-cnt, "_"); - if (iface->wdinfo.listen_channel =3D=3D ch && !rtw_p2p_chk_state(&iface= ->wdinfo, P2P_STATE_NONE)) - cnt +=3D scnprintf(msg+cnt, len-cnt, "L"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "_"); + if (iface->wdinfo.listen_channel =3D=3D ch && + !rtw_p2p_chk_state(&iface->wdinfo, P2P_STATE_NONE)) + cnt +=3D scnprintf(msg + cnt, len - cnt, "L"); else - cnt +=3D scnprintf(msg+cnt, len-cnt, "_"); - cnt +=3D scnprintf(msg+cnt, len-cnt, "]"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "_"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "]"); } =20 #endif /* DBG_CH_SWITCH */ @@ -431,7 +432,7 @@ void invalidate_cam_all(struct adapter *padapter) =20 spin_lock_bh(&cam_ctl->lock); cam_ctl->bitmap =3D 0; - memset(dvobj->cam_cache, 0, sizeof(struct cam_entry_cache)*TOTAL_CAM_ENTR= Y); + memset(dvobj->cam_cache, 0, sizeof(struct cam_entry_cache) * TOTAL_CAM_EN= TRY); spin_unlock_bh(&cam_ctl->lock); } =20 @@ -522,7 +523,7 @@ static bool _rtw_camid_is_gk(struct adapter *adapter, u= 8 cam_id) if (!(cam_ctl->bitmap & BIT(cam_id))) goto exit; =20 - ret =3D (dvobj->cam_cache[cam_id].ctrl&BIT6)?true:false; + ret =3D (dvobj->cam_cache[cam_id].ctrl & BIT6) ? true : false; =20 exit: return ret; @@ -537,7 +538,7 @@ static s16 _rtw_camid_search(struct adapter *adapter, u= 8 *addr, s16 kid) for (i =3D 0; i < TOTAL_CAM_ENTRY; i++) { if (addr && memcmp(dvobj->cam_cache[i].mac, addr, ETH_ALEN)) continue; - if (kid >=3D 0 && kid !=3D (dvobj->cam_cache[i].ctrl&0x03)) + if (kid >=3D 0 && kid !=3D (dvobj->cam_cache[i].ctrl & 0x03)) continue; =20 cam_id =3D i; @@ -585,7 +586,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta= _info *sta, u8 kid) cam_id =3D kid; } else { int i; - u8 *addr =3D sta?sta->hwaddr:NULL; + u8 *addr =3D sta ? sta->hwaddr : NULL; =20 if (!sta) { if (!(mlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) { @@ -792,7 +793,7 @@ void WMMOnAssocRsp(struct adapter *padapter) switch (ACI) { case 0x0: rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_BE, (u8 *)(&acParm)); - acm_mask |=3D (ACM ? BIT(1):0); + acm_mask |=3D (ACM ? BIT(1) : 0); edca[XMIT_BE_QUEUE] =3D acParm; break; =20 @@ -804,13 +805,13 @@ void WMMOnAssocRsp(struct adapter *padapter) =20 case 0x2: rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_VI, (u8 *)(&acParm)); - acm_mask |=3D (ACM ? BIT(2):0); + acm_mask |=3D (ACM ? BIT(2) : 0); edca[XMIT_VI_QUEUE] =3D acParm; break; =20 case 0x3: rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_VO, (u8 *)(&acParm)); - acm_mask |=3D (ACM ? BIT(3):0); + acm_mask |=3D (ACM ? BIT(3) : 0); edca[XMIT_VO_QUEUE] =3D acParm; break; } @@ -1175,7 +1176,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *p= frame, u32 packet_len) ht_info_infos_0 =3D 0; } if (ht_cap_info !=3D cur_network->bcn_info.ht_cap_info || - ((ht_info_infos_0&0x03) !=3D (cur_network->bcn_info.ht_info_infos_0&0= x03))) { + ((ht_info_infos_0 & 0x03) !=3D (cur_network->bcn_info.ht_info_infos_0= & 0x03))) { { /* bcn_info_update */ cur_network->bcn_info.ht_cap_info =3D ht_cap_info; @@ -1243,12 +1244,12 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 = *pframe, u32 packet_len) goto _mismatch; =20 if (encryp_protocol =3D=3D ENCRYP_PROTOCOL_WPA || encryp_protocol =3D=3D = ENCRYP_PROTOCOL_WPA2) { - pbuf =3D rtw_get_wpa_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length-12= ); + pbuf =3D rtw_get_wpa_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length - = 12); if (pbuf && (wpa_ielen > 0)) { rtw_parse_wpa_ie(pbuf, wpa_ielen + 2, &group_cipher, &pairwise_cipher, &is_8021x); } else { - pbuf =3D rtw_get_wpa2_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length-= 12); + pbuf =3D rtw_get_wpa2_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length = - 12); =20 if (pbuf && (wpa_ielen > 0)) rtw_parse_wpa2_ie(pbuf, wpa_ielen + 2, &group_cipher, @@ -1635,7 +1636,7 @@ void process_addba_req(struct adapter *padapter, u8 *= paddba_req, u8 *addr) =20 if (psta) { param =3D le16_to_cpu(preq->BA_para_set); - tid =3D (param>>2)&0x0f; + tid =3D (param >> 2) & 0x0f; =20 preorder_ctrl =3D &psta->recvreorder_ctrl[tid]; =20 @@ -1653,7 +1654,7 @@ void update_TSF(struct mlme_ext_priv *pmlmeext, u8 *p= frame, uint len) pIE =3D pframe + sizeof(struct ieee80211_hdr_3addr); pbuf =3D (__le32 *)pIE; =20 - pmlmeext->TSFValue =3D le32_to_cpu(*(pbuf+1)); + pmlmeext->TSFValue =3D le32_to_cpu(*(pbuf + 1)); =20 pmlmeext->TSFValue =3D pmlmeext->TSFValue << 32; =20 @@ -1679,14 +1680,14 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlme= ext, u8 *pframe, uint len) pIE =3D pframe + sizeof(struct ieee80211_hdr_3addr); pbuf =3D (__le32 *)pIE; =20 - tsf =3D le32_to_cpu(*(pbuf+1)); + tsf =3D le32_to_cpu(*(pbuf + 1)); tsf =3D tsf << 32; tsf |=3D le32_to_cpu(*pbuf); =20 /* delay =3D (timestamp mod 1024*100)/1000 (unit: ms) */ /* delay_ms =3D do_div(tsf, (pmlmeinfo->bcn_interval*1024))/1000; */ - delay_ms =3D do_div(tsf, (pmlmeinfo->bcn_interval*1024)); - delay_ms =3D delay_ms/1000; + delay_ms =3D do_div(tsf, (pmlmeinfo->bcn_interval * 1024)); + delay_ms =3D delay_ms / 1000; =20 if (delay_ms >=3D 8) pmlmeext->bcn_delay_cnt[8]++; --=20 2.45.3 From nobody Sun Dec 14 07:50:24 2025 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11FA72040A8 for ; Tue, 4 Feb 2025 06:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738652308; cv=none; b=IbcJp8nRDFf8aOB4//RJhEuMUhXH4whRsci9Tr4rJxPrOrR2HO+ritWopjZ8dhqPz7dVrb4s6RuV+gunD5B3eXyD8u8n3gfvwiZRedPfqYAQESWpzm2xXHZJQzbsaS+TeRtZPY37w9lBVGpp40tEtFcxHB4f1gvbzmB5WpG2DxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738652308; c=relaxed/simple; bh=b3lijSXyE6x9SgjhtgDsqZA2uYCgMh+ewY1B6W4ithw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vogt4LLEaeoBCh52VpmZB5BklhV0VVOiXSOq3/vOJPZ4YI1x6cVDF+Z3GwkwHZzGDBtzVBRSkBTNQMfl3JQIIQDDvSOiZRX2SQFhprqYSkCapqp8QMqgDOc2iW3GBPKECE8wmFpTJWBDvEOYUs+xuKx3F50NMKXYICj5jLr0EnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q+8kkXMp; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q+8kkXMp" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3eba583fbe8so1257889b6e.3 for ; Mon, 03 Feb 2025 22:58:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738652304; x=1739257104; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r4762hkLrmSiaKdmQk784TxrThn/ycMKykakCzUArJk=; b=Q+8kkXMpWVORmD3im+mvlUgTT+l/zUBm6sm+WLYsvLg5p7MjcFaA0xr82r9BLm5hrC ldSbUyXkfbrh37cWn2QXFBCPc1N/vtKnGpJWiostO5AnfqaGTdILg4wIlO7mqr5Imfcx RieqIB5okkURMO7QZQgbl51pmNTOZ/AELPmMBMprNaa++w+Oe3kIV6IJ7efIGYnJDZoL Bo+u63cqvk6y1y/MtRssPbgWcFfnOthYwhg4Pa4vb5NxPrsV39WsFt+SpMWLOVboDzO2 qBS+weEVzdYV5xJjg0Mubm067EotDEYpnWh/WqtjlH9oUt97mL3jjbsXpKQCdVbIfPva BpaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738652304; x=1739257104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r4762hkLrmSiaKdmQk784TxrThn/ycMKykakCzUArJk=; b=Yu/ySRMo7i+471DussfMsZwAouMA8vlbxkSgGyCVXdTabQrZOCKvycBnX6xE7eNOq0 Kc/0yRjJLoX323HA3WauVrPTtScUcOwJKMGP3WXnHnxq0UjMzbPHcAh4bY1aO6ie9Q6A ZZGNtsUNgxTusnivhdLI2nrW0o32J/vK/ETPvW4Z2rs3HFyrAhJZRuVLcNhlqgViUKK3 EjBYFLHI+lnBfVt41BQueX3VNDpG10mymZH15wc61VhYhK6K7KDQZaOfADrlipn+2x/p JOe+xJQcH7mv64V6S2R52fX5r9OBfbwQ9TMIJG9/YupQwS5XRZbjyUf2/aQyHzoVYNw7 1b+A== X-Forwarded-Encrypted: i=1; AJvYcCVsMLZ1ePQiusbZw/X36pBb6jvq510aO4Ja9ZCeozPqWBbzsgDeTHgeKimjZnmxOJ0Tf2oRVZZA9w5Gl5M=@vger.kernel.org X-Gm-Message-State: AOJu0YzpGV7uVi9ee49iOdUBwSm+OuoqxAeuoT9Kc9udnV0qW8i4VLJq cgLYnI+K8YIn3wzxcd087krkHlGPch0RyQ9cSP8jFtt9yiT/oFkA X-Gm-Gg: ASbGnctbUAwuvF7TlFGYZ0tM4f1tVwbVGHVovk6LIT6augHOkufrQIlaKZb9xDA5dky yMG8DBrFkL+1ujmiqEUxp7dMgzb4rHrTjmlkza2c2tZjKl6bHG5Zh4GnlUIJmtae1vOBjZeFOUM Kh0F23zroDJMvbVPsWzuPd4wPeFXsetoCaF/t/eb5xuwsuMvPLEpc9XCh7O0Eof7rHryIJU6UCc o3YdTDk1OKkQvRYV+kwgUm3ATdDjPX3U1lBfNszsyjFkParxFdXEXfnjis/Xn9UbV3dZ3fXdAfl R9C0y5PHx161VdKoE68NGI3buePwc0zy8heP2Pd7v+QAlrnpwkM48FxktMgkDR+aWjCijTEnzY5 s X-Google-Smtp-Source: AGHT+IFx7DNMU57U7g4/HUYZJ5bg9VweGyCmrkUIq81hlCJJ3ZMs79YG8u1S5Pw8uhNvInKMoMkVdQ== X-Received: by 2002:a05:6808:4491:b0:3f0:8e41:a7a7 with SMTP id 5614622812f47-3f323820aa2mr18252090b6e.0.1738652303935; Mon, 03 Feb 2025 22:58:23 -0800 (PST) Received: from DESKTOP-GL3U3CJ (162-207-94-177.lightspeed.irvnca.sbcglobal.net. [162.207.94.177]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5fc104b3c1dsm2984812eaf.8.2025.02.03.22.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 22:58:23 -0800 (PST) From: Ian To To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ian To Subject: [PATCH 2/4] staging: rtl8723bs: Split up long lines Date: Mon, 3 Feb 2025 22:57:20 -0800 Message-ID: X-Mailer: git-send-email 2.45.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Long lines were present and split up. Signed-off-by: Ian To --- .../staging/rtl8723bs/core/rtw_wlan_util.c | 38 ++++++++++++------- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index f73bde9ee4d3..7929e93c23ac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -336,13 +336,13 @@ void r8723bs_select_channel(struct adapter *padapter,= unsigned char channel) mutex_unlock(&(adapter_to_dvobj(padapter)->setch_mutex)); } =20 -void set_channel_bwmode(struct adapter *padapter, unsigned char channel, u= nsigned char channel_offset, unsigned short bwmode) +void set_channel_bwmode(struct adapter *padapter, unsigned char channel, + unsigned char channel_offset, unsigned short bwmode) { u8 center_ch, chnl_offset80 =3D HAL_PRIME_CHNL_OFFSET_DONT_CARE; =20 center_ch =3D rtw_get_center_ch(channel, bwmode, channel_offset); =20 - /* set Channel */ if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex))) return; @@ -352,7 +352,8 @@ void set_channel_bwmode(struct adapter *padapter, unsig= ned char channel, unsigne rtw_set_oper_bw(padapter, bwmode); rtw_set_oper_choffset(padapter, channel_offset); =20 - rtw_hal_set_chnl_bw(padapter, center_ch, bwmode, channel_offset, chnl_off= set80); /* set center channel */ + /* set center channel */ + rtw_hal_set_chnl_bw(padapter, center_ch, bwmode, channel_offset, chnl_off= set80); =20 mutex_unlock(&(adapter_to_dvobj(padapter)->setch_mutex)); } @@ -382,7 +383,8 @@ int is_client_associated_to_ap(struct adapter *padapter) pmlmeext =3D &padapter->mlmeextpriv; pmlmeinfo =3D &(pmlmeext->mlmext_info); =20 - if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state&0x03= ) =3D=3D WIFI_FW_STATION_STATE)) + if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE)) return true; else return _FAIL; @@ -393,7 +395,8 @@ int is_client_associated_to_ibss(struct adapter *padapt= er) struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); =20 - if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state&0x03= ) =3D=3D WIFI_FW_ADHOC_STATE)) + if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE)) return true; else return _FAIL; @@ -468,7 +471,8 @@ void _write_cam(struct adapter *padapter, u8 entry, u16= ctrl, u8 *mac, u8 *key) void _clear_cam_entry(struct adapter *padapter, u8 entry) { unsigned char null_sta[] =3D {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; - unsigned char null_key[] =3D {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0= x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; + unsigned char null_key[] =3D {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0= x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; =20 _write_cam(padapter, entry, 0, null_sta, null_key); } @@ -572,8 +576,8 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta= _info *sta, u8 kid) =20 mlmeinfo =3D &adapter->mlmeextpriv.mlmext_info; =20 - if ((((mlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) || ((mlmeinfo->stat= e&0x03) =3D=3D WIFI_FW_ADHOC_STATE)) - && !sta) { + if ((((mlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) || + ((mlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE)) && !sta) { /* AP/Ad-hoc mode group key: static alloction to default key by key ID */ if (kid > 3) { netdev_dbg(adapter->pnetdev, @@ -1142,7 +1146,9 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *p= frame, u32 packet_len) if (!bssid) return true; =20 - if ((pmlmepriv->timeBcnInfoChkStart !=3D 0) && (jiffies_to_msecs(jiffies = - pmlmepriv->timeBcnInfoChkStart) > DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIO= D_IN_MS)) { + if ((pmlmepriv->timeBcnInfoChkStart !=3D 0) && + (jiffies_to_msecs(jiffies - pmlmepriv->timeBcnInfoChkStart) > + DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIOD_IN_MS)) { pmlmepriv->timeBcnInfoChkStart =3D 0; pmlmepriv->NumOfBcnInfoChkFail =3D 0; } @@ -1214,7 +1220,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *p= frame, u32 packet_len) bssid->ssid.ssid_length =3D ssid_len; =20 if (memcmp(bssid->ssid.ssid, cur_network->network.ssid.ssid, 32) || - bssid->ssid.ssid_length !=3D cur_network->network.ssid.ssid_length) + bssid->ssid.ssid_length !=3D cur_network->network.ssid.ssid_length) if (bssid->ssid.ssid[0] !=3D '\0' && bssid->ssid.ssid_length !=3D 0) /* not hidden ssid */ goto _mismatch; @@ -1275,8 +1281,10 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *= pframe, u32 packet_len) =20 pmlmepriv->NumOfBcnInfoChkFail++; =20 - if ((pmlmepriv->timeBcnInfoChkStart !=3D 0) && (jiffies_to_msecs(jiffies = - pmlmepriv->timeBcnInfoChkStart) <=3D DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PE= RIOD_IN_MS) - && (pmlmepriv->NumOfBcnInfoChkFail >=3D DISCONNECT_BY_CHK_BCN_FAIL_THRES= HOLD)) { + if ((pmlmepriv->timeBcnInfoChkStart !=3D 0) && + (jiffies_to_msecs(jiffies - pmlmepriv->timeBcnInfoChkStart) <=3D + DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIOD_IN_MS) && + (pmlmepriv->NumOfBcnInfoChkFail >=3D DISCONNECT_BY_CHK_BCN_FAIL_THRES= HOLD)) { pmlmepriv->timeBcnInfoChkStart =3D 0; pmlmepriv->NumOfBcnInfoChkFail =3D 0; return _FAIL; @@ -1337,7 +1345,8 @@ unsigned int is_ap_in_tkip(struct adapter *padapter) =20 switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: - if ((!memcmp(pIE->data, RTW_WPA_OUI, 4)) && (!memcmp((pIE->data + 12),= WPA_TKIP_CIPHER, 4))) + if ((!memcmp(pIE->data, RTW_WPA_OUI, 4)) && + (!memcmp((pIE->data + 12), WPA_TKIP_CIPHER, 4))) return true; =20 break; @@ -1440,7 +1449,8 @@ unsigned char check_assoc_AP(u8 *pframe, uint len) =20 switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: - if ((!memcmp(pIE->data, ARTHEROS_OUI1, 3)) || (!memcmp(pIE->data, ARTHE= ROS_OUI2, 3))) + if ((!memcmp(pIE->data, ARTHEROS_OUI1, 3)) || + (!memcmp(pIE->data, ARTHEROS_OUI2, 3))) return HT_IOT_PEER_ATHEROS; else if ((!memcmp(pIE->data, BROADCOM_OUI1, 3)) || (!memcmp(pIE->data, BROADCOM_OUI2, 3)) || --=20 2.45.3 From nobody Sun Dec 14 07:50:24 2025 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC4E8202C36 for ; Tue, 4 Feb 2025 06:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738652308; cv=none; b=MYzVHd9iSE8sKBeKNTgLVqD/zQPKo8PBFPr/0J5zVqjDRZsCKP9iDp9UEAI5oI2yWTpW9hgTCrbKOkKkZkOIjSzzXVL6ZMcMeQIkKJy9ekkEkdvzMQpVi01Asaaircc3eeEokB1atc1uNLO72xo9/e0chxTIGrfvplmskFrmwho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738652308; c=relaxed/simple; bh=96HgJQVXEtnEWvGQaz3WHV5fyZYlxatEwWd2O8eUxTE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RU0R/e+/tSjHBmiwSkW0O/AqNW51gKDaquwI23YhyJmDppr1UTb0oAMSQHO8z/v2A39n/gHQe8P0rxbr7+buZd7bk36D+jFuuoJsEwaRY/JMGazoT1Lti6NKAwAqeiOldrOO4NwT3WX8t1jnW5yv07mxwi/zA0yjTjMqm/LtSo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LOvLPeGt; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LOvLPeGt" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-723442fd88aso1403136a34.3 for ; Mon, 03 Feb 2025 22:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738652305; x=1739257105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a65k5SXteKyuZ7RWFZV+p3mgGeMzOMzhhd+ce8eWs20=; b=LOvLPeGtw7Md2U4eLvSWslh5sLI+aG7xJDQrvHCYjbh0YUl+HAKK9QeaEAC0lUVvWU GrPIfvBBmHkcVp+0OA33djl3zn+i4hw7WnGRN55ygmKMNH/mY3sGbm45oq9Byf5Hx3xB 65Uw3Qw9AigcNVn+VI2C4GjPyG/7CWnwwoKTMmsFkEvehVz6JPXJhPAsJWcsb1LeH88l m1AdYBZVfYigbjyljX68JsqY2+rVaEGe5ADFSTRyfyuR30fNKaFwD4651E0lrP1G3Sxh 4vGPEzKoTvYjh67Z6e5DhrOzfxKUKpcEfcTbtltCkYAMU/AGvmumviYzIwzU74DlVE21 PPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738652305; x=1739257105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a65k5SXteKyuZ7RWFZV+p3mgGeMzOMzhhd+ce8eWs20=; b=uxGl008uQTR0BL7Z+d0A75copNbiUfw+lkdeOC802Qb9rMod05vPYbrImNDsXeNCYT Rqh5P8bUGP1bYJrII04zP0eMFxeB8XEAOTaj3sjteiwyA95WuwVpVtp0U2xpzGPfDvEw TB4VU1BLkJ+fe3mPpvnenkKoz2cZIv2BHwaBQrY0Hmne06gTwJ5aw9mHVSVcah2Oc1kO Xm7WYoEOz6/jxe68NsN4SwUJ8oQ4Y/24uVqPcmRKcu4FEFcKm+HfuqOnvyXVcEomFe5i qVEW8F67YbhtnFreZP5p3ushs/Mh0FylBJaWWJgk2xjuX+st/NEO7KDFPqIuiZs5Cd1Z VghQ== X-Forwarded-Encrypted: i=1; AJvYcCUKVvKzEP7WTQiq+OVJ6U8yfMdn7SXKyRSVWcNCevm2XmE0H8hCNjg5DQlV7oQnNrcOawOUUwTllMO1u14=@vger.kernel.org X-Gm-Message-State: AOJu0YxAbgD+zxwRtuZgk77q+SXTPMVIxXUrHHfd3NM5l0sQg6cwfTRV cbg9uvTLVCXfCfMjqHwl3HksG0tcM1PhDPn7tLWHgcfF4oNIx8gP X-Gm-Gg: ASbGncsj0n+j84sT7DjeXMjpuBiAZhBy+aH9I8Sqe0mMKV7lEfq/BSgJIBEx1/vlF+z Ew71rbvmWCcAmzZv4vYs7RH0Nnz6qUNCIGQht/3PqClW7imhRi3jYWYIlugVHhWoMfHyVD4jTxF 7WPU6BY9fYf39WCIk2G52WZFoumYXvMfx0r+ODaV5Ku1aa2GylDH6bxtIbO/sPDzo38dfcWPCBa 2dOhknKl4G4FQFGsyMr+T4Oi5SdJmgAEubkvu6wy5nV43hXxYUMBOIITgVswQUJaFp1a3GY6iWE gQZpGKONbL4ac3GEMjbls9MeKJUaLMr59aSoxcFi/6xy5pchGTOJZWeeGz1hsI3o3rTiTW+73Px X X-Google-Smtp-Source: AGHT+IHFvSdICYcWLZNF1kSu8yn1yGi/SdtEjNcRIwBz65TqXYEOxSVtPbF5IH6eNl0ZTzAu2RIC2Q== X-Received: by 2002:a05:6830:370b:b0:71e:223c:1789 with SMTP id 46e09a7af769-7265678521emr17539000a34.16.1738652305498; Mon, 03 Feb 2025 22:58:25 -0800 (PST) Received: from DESKTOP-GL3U3CJ (162-207-94-177.lightspeed.irvnca.sbcglobal.net. [162.207.94.177]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cc389sm3214721a34.23.2025.02.03.22.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 22:58:24 -0800 (PST) From: Ian To To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ian To Subject: [PATCH 3/4] staging: rtl8723bs: Remove unnecessary parentheses Date: Mon, 3 Feb 2025 22:57:21 -0800 Message-ID: <3163c1de16443eddce6ab5cd31a891e0ce00c344.1738651582.git.onlyian4981@gmail.com> X-Mailer: git-send-email 2.45.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unnecessary parentheses were present and removed Signed-off-by: Ian To --- .../staging/rtl8723bs/core/rtw_wlan_util.c | 68 +++++++++---------- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 7929e93c23ac..dfe036cd4ef7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -381,7 +381,7 @@ int is_client_associated_to_ap(struct adapter *padapter) return _FAIL; =20 pmlmeext =3D &padapter->mlmeextpriv; - pmlmeinfo =3D &(pmlmeext->mlmext_info); + pmlmeinfo =3D &pmlmeext->mlmext_info; =20 if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE)) @@ -393,7 +393,7 @@ int is_client_associated_to_ap(struct adapter *padapter) int is_client_associated_to_ibss(struct adapter *padapter) { struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE)) @@ -406,7 +406,7 @@ int is_IBSS_empty(struct adapter *padapter) { unsigned int i; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 for (i =3D IBSS_START_MAC_ID; i < NUM_STA; i++) { if (pmlmeinfo->FW_sta_info[i].status =3D=3D 1) @@ -510,7 +510,7 @@ void clear_cam_cache(struct adapter *adapter, u8 id) =20 spin_lock_bh(&cam_ctl->lock); =20 - memset(&(dvobj->cam_cache[id]), 0, sizeof(struct cam_entry_cache)); + memset(&dvobj->cam_cache[id], 0, sizeof(struct cam_entry_cache)); =20 spin_unlock_bh(&cam_ctl->lock); } @@ -660,7 +660,7 @@ int allocate_fw_sta_entry(struct adapter *padapter) { unsigned int mac_id; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 for (mac_id =3D IBSS_START_MAC_ID; mac_id < NUM_STA; mac_id++) { if (pmlmeinfo->FW_sta_info[mac_id].status =3D=3D 0) { @@ -676,7 +676,7 @@ int allocate_fw_sta_entry(struct adapter *padapter) void flush_all_cam_entry(struct adapter *padapter) { struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 invalidate_cam_all(padapter); /* clear default key related key search setting */ @@ -688,19 +688,19 @@ void flush_all_cam_entry(struct adapter *padapter) int WMM_param_handler(struct adapter *padapter, struct ndis_80211_var_ie *= pIE) { /* struct registry_priv *pregpriv =3D &padapter->registrypriv; */ - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 if (pmlmepriv->qospriv.qos_option =3D=3D 0) { pmlmeinfo->WMM_enable =3D 0; return false; } =20 - if (!memcmp(&(pmlmeinfo->WMM_param), (pIE->data + 6), sizeof(struct WMM_p= ara_element))) + if (!memcmp(&pmlmeinfo->WMM_param, (pIE->data + 6), sizeof(struct WMM_par= a_element))) return false; else - memcpy(&(pmlmeinfo->WMM_param), (pIE->data + 6), sizeof(struct WMM_para_= element)); + memcpy(&pmlmeinfo->WMM_param, (pIE->data + 6), sizeof(struct WMM_para_el= ement)); =20 pmlmeinfo->WMM_enable =3D 1; return true; @@ -740,7 +740,7 @@ void WMMOnAssocRsp(struct adapter *padapter) u32 acParm, i; u32 edca[4], inx[4]; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; struct registry_priv *pregpriv =3D &padapter->registrypriv; =20 @@ -841,9 +841,9 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ unsigned char new_bwmode; unsigned char new_ch_offset; struct HT_info_element *pHT_info; - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; u8 cbw40_enable =3D 0; @@ -903,7 +903,7 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ =20 if (true =3D=3D pmlmeinfo->bwmode_updated) { struct sta_info *psta; - struct wlan_bssid_ex *cur_network =3D &(pmlmeinfo->network); + struct wlan_bssid_ex *cur_network =3D &pmlmeinfo->network; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 /* set_channel_bwmode(padapter, pmlmeext->cur_channel, pmlmeext->cur_ch_= offset, pmlmeext->cur_bwmode); */ @@ -933,7 +933,7 @@ void HT_caps_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) u8 max_AMPDU_len, min_MPDU_spacing; u8 cur_ldpc_cap =3D 0, cur_stbc_cap =3D 0; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; =20 @@ -996,7 +996,7 @@ void HT_caps_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) void HT_info_handler(struct adapter *padapter, struct ndis_80211_var_ie *p= IE) { struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; =20 @@ -1010,7 +1010,7 @@ void HT_info_handler(struct adapter *padapter, struct= ndis_80211_var_ie *pIE) return; =20 pmlmeinfo->HT_info_enable =3D 1; - memcpy(&(pmlmeinfo->HT_info), pIE->data, pIE->length); + memcpy(&pmlmeinfo->HT_info, pIE->data, pIE->length); } =20 void HTOnAssocRsp(struct adapter *padapter) @@ -1019,7 +1019,7 @@ void HTOnAssocRsp(struct adapter *padapter) unsigned char min_MPDU_spacing; /* struct registry_priv *pregpriv =3D &padapter->registrypriv; */ struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 if ((pmlmeinfo->HT_info_enable) && (pmlmeinfo->HT_caps_enable)) { pmlmeinfo->HT_enable =3D 1; @@ -1046,20 +1046,20 @@ void HTOnAssocRsp(struct adapter *padapter) void ERP_IE_handler(struct adapter *padapter, struct ndis_80211_var_ie *pI= E) { struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 if (pIE->length > 1) return; =20 pmlmeinfo->ERP_enable =3D 1; - memcpy(&(pmlmeinfo->ERP_IE), pIE->data, pIE->length); + memcpy(&pmlmeinfo->ERP_IE, pIE->data, pIE->length); } =20 void VCS_update(struct adapter *padapter, struct sta_info *psta) { struct registry_priv *pregpriv =3D &padapter->registrypriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 switch (pregpriv->vrtl_carrier_sense) {/* 0:off 1:on 2:auto */ case 0: /* off */ @@ -1114,7 +1114,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *p= frame, u32 packet_len) unsigned int len; unsigned char *p; unsigned short val16, subtype; - struct wlan_network *cur_network =3D &(Adapter->mlmepriv.cur_network); + struct wlan_network *cur_network =3D &Adapter->mlmepriv.cur_network; /* u8 wpa_ie[255], rsn_ie[255]; */ u16 wpa_len =3D 0, rsn_len =3D 0; u8 encryp_protocol =3D 0; @@ -1336,8 +1336,8 @@ unsigned int is_ap_in_tkip(struct adapter *padapter) u32 i; struct ndis_80211_var_ie *pIE; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); - struct wlan_bssid_ex *cur_network =3D &(pmlmeinfo->network); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; + struct wlan_bssid_ex *cur_network =3D &pmlmeinfo->network; =20 if (rtw_get_capability((struct wlan_bssid_ex *)cur_network) & WLAN_CAPABI= LITY_PRIVACY) { for (i =3D sizeof(struct ndis_802_11_fix_ie); i < pmlmeinfo->network.ie_= length;) { @@ -1373,7 +1373,7 @@ int support_short_GI(struct adapter *padapter, struct= HT_caps_element *pHT_caps, { unsigned char bit_offset; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 if (!(pmlmeinfo->HT_enable)) return _FAIL; @@ -1482,7 +1482,7 @@ unsigned char check_assoc_AP(u8 *pframe, uint len) void update_IOT_info(struct adapter *padapter) { struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 switch (pmlmeinfo->assoc_AP_vendor) { case HT_IOT_PEER_MARVELL: @@ -1512,7 +1512,7 @@ void update_IOT_info(struct adapter *padapter) void update_capinfo(struct adapter *Adapter, u16 updateCap) { struct mlme_ext_priv *pmlmeext =3D &Adapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; bool ShortPreamble; =20 /* Check preamble mode, 2005.01.06, by rcnjko. */ @@ -1564,8 +1564,8 @@ void update_wireless_mode(struct adapter *padapter) int network_type =3D 0; u32 SIFS_Timer; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); - struct wlan_bssid_ex *cur_network =3D &(pmlmeinfo->network); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; + struct wlan_bssid_ex *cur_network =3D &pmlmeinfo->network; unsigned char *rate =3D cur_network->supported_rates; =20 if ((pmlmeinfo->HT_info_enable) && (pmlmeinfo->HT_caps_enable)) @@ -1588,7 +1588,7 @@ void update_wireless_mode(struct adapter *padapter) =20 SetHwReg8723BS(padapter, HW_VAR_RESP_SIFS, (u8 *)&SIFS_Timer); =20 - SetHwReg8723BS(padapter, HW_VAR_WIRELESS_MODE, (u8 *)&(pmlmeext->cur_wir= eless_mode)); + SetHwReg8723BS(padapter, HW_VAR_WIRELESS_MODE, (u8 *)&pmlmeext->cur_wire= less_mode); =20 if (pmlmeext->cur_wireless_mode & WIRELESS_11B) update_mgnt_tx_rate(padapter, IEEE80211_CCK_RATE_1MB); @@ -1613,8 +1613,8 @@ int update_sta_support_rate(struct adapter *padapter,= u8 *pvar_ie, uint var_ie_l unsigned int ie_len; struct ndis_80211_var_ie *pIE; int supportRateNum =3D 0; - struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 pIE =3D (struct ndis_80211_var_ie *)rtw_get_ie(pvar_ie, WLAN_EID_SUPP_RAT= ES, &ie_len, var_ie_len); if (!pIE) @@ -1640,7 +1640,7 @@ void process_addba_req(struct adapter *padapter, u8 *= paddba_req, u8 *addr) struct sta_priv *pstapriv =3D &padapter->stapriv; struct ADDBA_request *preq =3D (struct ADDBA_request *)paddba_req; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 psta =3D rtw_get_stainfo(pstapriv, addr); =20 @@ -1683,7 +1683,7 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeex= t, u8 *pframe, uint len) __le32 *pbuf; u64 tsf =3D 0; u32 delay_ms; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 pmlmeext->bcn_cnt++; =20 --=20 2.45.3 From nobody Sun Dec 14 07:50:24 2025 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EB42204680 for ; Tue, 4 Feb 2025 06:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738652309; cv=none; b=rBkwQcNLCuY2FBdOKR9WGrv8zZgw1wYDGaLZO4Q3FUfwnHhGAbWf0v2Hq25zThTeEQ1aEGz22RFBdqqeMjQ08UALWEMvldx6rRWoHOAPPadJenVea3vW0ozIBwLSKS0ZbtE43EOPTfQiz/Q3yQVx1CxUgbChPdcSsw9fIRvrnW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738652309; c=relaxed/simple; bh=/KIqPx3OcibD6mX6v3Lzyi4ET0I49KQ/VdMRMO9wh/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gAlIDBrrmtzNudx+bFGFndqr0u3jmFkQ+q7UcRdFgUTF3M/x3mLK6aPeIjDZxqgVwNjzRFep/S112AhDwSh5/j/QP79DbMYc6heCrCPgHt40axyPh/12TjHWRuF5OOEYfetkRflD8A8gymLoc8dOouCCch01LOHKHTtBBumjksU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q5X/zdYs; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q5X/zdYs" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3eb7e725aa0so2057753b6e.0 for ; Mon, 03 Feb 2025 22:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738652307; x=1739257107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7lh9L/j2V92hTgmHwcgJ4LgGzf6Mnu2fil9QHhtdmks=; b=Q5X/zdYs9EQGyieYj1LWu9lXJjspd1mCeHZnsV0+scZCAgE1BPyb9ECPjXmsUBMCjy tJ4vckIa0ImBuvqxYKMQQ0VDtURhOs1d5G4igUNRukTH/06/1hl2RrZYAAlTKyJEKe66 BZcGElnmZu1GBdpdBgg8SLHwxWwwTDY8cz25yp6yXP01fTaTCqiv7NKid7sBbe2hMOFx WdFkgDJxO9ZHjgb7bFJEyFIpKrYqglg+pW3fBj2YZswhMbXsAHQ7bqvBi9+kWQ1RyRMc tO2iWGoiDQisjtVC3WXGx8y37dEODyG9p4ddJg0I8OFueaBkMbhGDsWZv+gCXn/Xo7+h pTRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738652307; x=1739257107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7lh9L/j2V92hTgmHwcgJ4LgGzf6Mnu2fil9QHhtdmks=; b=NU/JE2EWi2WAiOII/uXslEVarC+Xh0aqGziNjzVx0ooV2pTz3/O5V96L29sJSSle88 htAYWCjf90uj9DJ4cN1T0whHWU6vmvWykw6hRSQmeZBtx8nVr0uEPFUwI23O8bp+f6x+ CxhcxFjJSyfT+bBQdmfxttoTPwhEVakoJOSw0jfJxp7OAMpbxhIGTF849z+1eyUWCvb5 G/5ar+fcqNXlj5uKgHDGKL4RaJ++nocxBvZSOFfMrPwFNc8WTVdzBjK/6753A1R8H/ud LIt2afTH3XmMnkU1y9wywrhSrKhoRv8a7d/+Yd6cC+qVUneSpzsdtN1xnseEs1WfCv0n Ec3A== X-Forwarded-Encrypted: i=1; AJvYcCXTG8qk2Lvq8e3w83VpPRkF3aIjcqYWoHXtfHpk4WHqCaHJS6NoEKZIF662RPZ5m8vXyzmy3RmjBakySGs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzy6iewv07qlAMsByO7k9+5MO+WJ6NxUylGfC+XCONv0vqmbJWP PvlpGL8GWsY/rcWqFaqJkHCNv1/+cK0PAr4RzKJwar+p5fCHf8vCP89/9ljlGXI= X-Gm-Gg: ASbGnctUlHHRptQ90cVZmVze/PICoK9K7/6aZkJwI/T+cTMt8gxs7X215Uc2dVQ2u/Y bzuAyjjWFREOTRE5mopjG/c4bAD3VaElP5nIDdLRTuWM1QqQmZIP1i3BZfmPdHindM9YeXUHvfr pQLAFTzf/vxlfiL/TbdGJkhn0RDvtvdZODLAGXgFo+zFAntjzaEAMCGzB5IXFipXKstFoxSylNl XKW6A+4uojq0fS27BMh7v/oJK17ES93fnmPpERVWV6gjm8quNCX64gp2X1xD4RSVMsCFPc050lm jE+/l3fiAv2pObl+ls8EmpwlIgM1nr9q1naUko5ObKm8vYwqyx0m3HGTsuWp5Y6fEHzxc3rmMir t X-Google-Smtp-Source: AGHT+IF55WgJ4bcciobrlt7SG02tK+/1rry6sDdSiq6H3Gi4wyzFQenCiUX1GRIT6gmiklZr8WGykQ== X-Received: by 2002:a05:6808:2106:b0:3ea:5880:fe1d with SMTP id 5614622812f47-3f323b4a05amr15783914b6e.35.1738652307193; Mon, 03 Feb 2025 22:58:27 -0800 (PST) Received: from DESKTOP-GL3U3CJ (162-207-94-177.lightspeed.irvnca.sbcglobal.net. [162.207.94.177]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f333660e78sm2934557b6e.35.2025.02.03.22.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 22:58:26 -0800 (PST) From: Ian To To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ian To Subject: [PATCH 4/4] staging: rtl8723bs: Format comments Date: Mon, 3 Feb 2025 22:57:22 -0800 Message-ID: <1ed23303429f4c7170f92122a3794bc9052f07c3.1738651582.git.onlyian4981@gmail.com> X-Mailer: git-send-email 2.45.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make comments adhere to the coding style. Signed-off-by: Ian To --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index dfe036cd4ef7..2e9963c857aa 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -1031,9 +1031,9 @@ void HTOnAssocRsp(struct adapter *padapter) =20 /* handle A-MPDU parameter field */ /* - AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k - AMPDU_para [4:2]:Min MPDU Start Spacing - */ + * AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k + * AMPDU_para [4:2]:Min MPDU Start Spacing + */ max_AMPDU_len =3D pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03; =20 min_MPDU_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x= 1c) >> 2; @@ -1706,14 +1706,6 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmee= xt, u8 *pframe, uint len) pmlmeext->bcn_delay_cnt[delay_ms]++; /* pmlmeext->bcn_delay_ratio[delay_ms] =3D (pmlmeext->bcn_delay_cnt[dela= y_ms] * 100) /pmlmeext->bcn_cnt; */ =20 -/* - - for (i =3D 0; i<9; i++) - { - pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]); - } -*/ - /* dump for adaptive_early_32k */ if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done =3D=3D true))= { u8 ratio_20_delay, ratio_80_delay; --=20 2.45.3