From nobody Sun Nov 24 02:41:00 2024 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1421E1384BF; Tue, 19 Nov 2024 12:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732020853; cv=none; b=jts6Xx9Kz6wG+wASksVF0kKdrUt0lcUQe4iSrS+btVKs/0Fc375Cgc99yGXC0q7mRBIIRzm6uu5ANAznES9dFx5bNek5xXHfrJy+KqJ7LIjdfBtWhQlj5RUmQhvTc3bO6WDuKyQGHww9iLiFlLuq6bLN/NkKRA4yK/cEsGdu6IY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732020853; c=relaxed/simple; bh=VovvSiGmUrV0t9+Xf0heE8+663WCB9icQPkL7ivgIdk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s6ZfoWpt32if3B6mFjeLS74anQuBvGQfqj8M1XUDo5vsLdGMSxxVTHl4v/p4pKqUBqnhcoxmlenDDSOpTzddHmRZG6GCbiP53tRu2oYmsJOkGp7rlRDDrETIForUR53CtNrZmien3gEzIZMWa8WW3lfH+wPafs6L8B0a9rYUpp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=nO61i+UD; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="nO61i+UD" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AJB18op009120; Tue, 19 Nov 2024 07:53:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=q1kCt ufGivdN8gh+vtObMebHErhtEEm1UZTBwdz/0Lk=; b=nO61i+UDBhWg2LS0hK9Dr mW/4fsjV0KkuVlFLeDeseo8sySXdb1PtI10C3aX9fOpvvzO2lYUME347FCVWTLQJ m1j9hh5ku4EeftFOu0owg54dQmwred386PQth4EBdyX6gNL07nonrUbwcurmZ547 XtHYZgHRYmc/sdYy+LVvoF8szk4gejwN35njnnLzJXjrWY+uZg5Y+/7wq2TcBI7Q nY0BfYMRvSc7Pkc71+1D4FiDtzC3N9BG9JIuFQXs4eKoLqb85ncXrhfbMF5E7fwp jpTYAbD5MXz8/x98SUDGM6fKeXPlOHnN5nsSmYRqFcj9EIcA+oyOTXEseI7SCbhw w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 430seagef8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Nov 2024 07:53:57 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 4AJCruBL005017 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Nov 2024 07:53:56 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Tue, 19 Nov 2024 07:53:56 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Tue, 19 Nov 2024 07:53:56 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Tue, 19 Nov 2024 07:53:56 -0500 Received: from work.ad.analog.com (HYB-hERzalRezfV.ad.analog.com [10.65.205.9]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 4AJCrhF8007310; Tue, 19 Nov 2024 07:53:45 -0500 From: Marcelo Schmitt To: , , , , , , , CC: , , Subject: [PATCH v3 1/4] dt-bindings: iio: adc: adi,ad4000: Add PulSAR Date: Tue, 19 Nov 2024 09:53:40 -0300 Message-ID: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: dxq_kf_dOOYPaFY_H6sJhRGYVK94DBpR X-Proofpoint-ORIG-GUID: dxq_kf_dOOYPaFY_H6sJhRGYVK94DBpR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411190095 Content-Type: text/plain; charset="utf-8" Extend the AD4000 series device tree documentation to also describe PulSAR devices. Signed-off-by: Marcelo Schmitt --- No changes from v2 -> v3. .../bindings/iio/adc/adi,ad4000.yaml | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml b/Do= cumentation/devicetree/bindings/iio/adc/adi,ad4000.yaml index e413a9d8d2a2..4dbb3d2876f9 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml @@ -19,6 +19,20 @@ description: | https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 4020-4021-4022.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/ad= aq4001.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/ad= aq4003.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7685.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7686.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7687.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7688.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7690.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7691.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7693.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7942.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7946.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7980.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7982.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7983.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7984.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad= 7988-1_7988-5.pdf =20 $ref: /schemas/spi/spi-peripheral-props.yaml# =20 @@ -63,6 +77,37 @@ properties: =20 - const: adi,adaq4003 =20 + - const: adi,ad7946 + - items: + - enum: + - adi,ad7942 + - const: adi,ad7946 + + - const: adi,ad7983 + - items: + - enum: + - adi,ad7980 + - adi,ad7988-5 + - adi,ad7686 + - adi,ad7685 + - adi,ad7988-1 + - const: adi,ad7983 + + - const: adi,ad7688 + - items: + - enum: + - adi,ad7693 + - adi,ad7687 + - const: adi,ad7688 + + - const: adi,ad7984 + - items: + - enum: + - adi,ad7982 + - adi,ad7690 + - adi,ad7691 + - const: adi,ad7984 + reg: maxItems: 1 =20 @@ -133,6 +178,32 @@ required: - ref-supply =20 allOf: + # Single-channel PulSAR devices have SDI either tied to VIO, GND, or hos= t CS. + - if: + properties: + compatible: + contains: + enum: + - adi,ad7685 + - adi,ad7686 + - adi,ad7687 + - adi,ad7688 + - adi,ad7690 + - adi,ad7691 + - adi,ad7693 + - adi,ad7942 + - adi,ad7946 + - adi,ad7980 + - adi,ad7982 + - adi,ad7983 + - adi,ad7984 + - adi,ad7988-1 + - adi,ad7988-5 + then: + properties: + adi,sdi-pin: + enum: [ high, low, cs ] + default: cs # The configuration register can only be accessed if SDI is connected to= MOSI - if: required: --=20 2.45.2 From nobody Sun Nov 24 02:41:00 2024 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41F7E1CCB4D; Tue, 19 Nov 2024 12:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732020873; cv=none; b=B+Ds5Yo59Pd1ZRINkjR1N4azyhMSKQoEBXlEcHG3NPq7gqlDxLrvYJPPF8pCFVyOrYWxYjuMofxca5rxKP8Jlol6VPUYN4XKv7DYI0kJqxQRC7MLhAO+FXaz5fanjFl9vy3SURRGVOISiEGwKovTJ5xyU0ceXlGij1kWKM+SZWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732020873; c=relaxed/simple; bh=LHfl5uf4OUxuRyZMtrgPR7+lm2rc4DSaGKM1rtAFcWE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G6tKxuqpBkL7trdT9mt6R7aeHrohqRLBwM/kuqbXojCkSUZX4V6bSc/OPc8tTkJM7yDODpwoPEEhCM5+r9dULVmmmLeBT41Uac5NY0QCmc1Mek7BJoxINxSO6CC9zWMfJtFkguFyqZfxUMXUSESOBvgsxe1aUizedcEKzmLybaI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=LydTJUxt; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="LydTJUxt" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AJB18gD009127; Tue, 19 Nov 2024 07:54:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=dWWsa OTW4pk8/fGx3aVmoRzEo9LkdzNQxdEyeNyVyoE=; b=LydTJUxtjXGfpsw3FX+B2 buFYOp4RDEtsZttlkgsMmGt0/kt6wilotQFP9RKdjvY3wY5KYfbR1NNndqNZrVPR lkyhwpgXBnxZ2rJO/8DE3l/uxMEEdktNR88hsGohnYET2lgl0q4Kdks3Yk7JkdBg ULxYVA4u1y1eILfZbeS9QyZvF1+WXRn5w39mfbKHoA/ABpjCbq46v8QuL4qW3M52 NAE40GZ+eq2iRpWEXvSinObeTfnX4FSbv9qKwlfIvPMEGtXacXLsnJRWsv7IqaWg YZ3PdKiIDoR9pzSTUAKGgdfR2FVNv38E/5V0h678d5LWfmiIYQWYVE2pAD+vf3+G w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 430seagega-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Nov 2024 07:54:15 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 4AJCsEQZ005020 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Nov 2024 07:54:14 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Tue, 19 Nov 2024 07:54:14 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Tue, 19 Nov 2024 07:54:14 -0500 Received: from work.ad.analog.com (HYB-hERzalRezfV.ad.analog.com [10.65.205.9]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 4AJCs1J1007314; Tue, 19 Nov 2024 07:54:03 -0500 From: Marcelo Schmitt To: , , , , , , , CC: , , , David Lechner Subject: [PATCH v3 2/4] iio: adc: ad4000: Add timestamp channel Date: Tue, 19 Nov 2024 09:53:59 -0300 Message-ID: <70c80e58b5fc32d1b028634d78f609893c6e73e1.1732020224.git.marcelo.schmitt@analog.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: oTdNDME2ZooFvN_du3QhBT9juBgzzjMq X-Proofpoint-ORIG-GUID: oTdNDME2ZooFvN_du3QhBT9juBgzzjMq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411190095 Content-Type: text/plain; charset="utf-8" The ADC data is pushed to the IIO buffer along with timestamp but no timestamp channel was provided to retried the time data. Add a timestamp channel to provide sample capture time. Suggested-by: David Lechner Reviewed-by: David Lechner Signed-off-by: Marcelo Schmitt --- drivers/iio/adc/ad4000.c | 98 +++++++++++++++++++++++----------------- 1 file changed, 56 insertions(+), 42 deletions(-) diff --git a/drivers/iio/adc/ad4000.c b/drivers/iio/adc/ad4000.c index b3b82535f5c1..21731c4d31ee 100644 --- a/drivers/iio/adc/ad4000.c +++ b/drivers/iio/adc/ad4000.c @@ -49,6 +49,7 @@ .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) | \ BIT(IIO_CHAN_INFO_SCALE), \ .info_mask_separate_available =3D _reg_access ? BIT(IIO_CHAN_INFO_SCALE) = : 0,\ + .scan_index =3D 0, \ .scan_type =3D { \ .sign =3D _sign, \ .realbits =3D _real_bits, \ @@ -62,6 +63,12 @@ __AD4000_DIFF_CHANNEL((_sign), (_real_bits), \ ((_real_bits) > 16 ? 32 : 16), (_reg_access)) =20 +#define AD4000_DIFF_CHANNELS(_sign, _real_bits, _reg_access) \ +{ \ + AD4000_DIFF_CHANNEL(_sign, _real_bits, _reg_access), \ + IIO_CHAN_SOFT_TIMESTAMP(1) \ +} + #define __AD4000_PSEUDO_DIFF_CHANNEL(_sign, _real_bits, _storage_bits, _re= g_access)\ { \ .type =3D IIO_VOLTAGE, \ @@ -71,6 +78,7 @@ BIT(IIO_CHAN_INFO_SCALE) | \ BIT(IIO_CHAN_INFO_OFFSET), \ .info_mask_separate_available =3D _reg_access ? BIT(IIO_CHAN_INFO_SCALE) = : 0,\ + .scan_index =3D 0, \ .scan_type =3D { \ .sign =3D _sign, \ .realbits =3D _real_bits, \ @@ -84,6 +92,12 @@ __AD4000_PSEUDO_DIFF_CHANNEL((_sign), (_real_bits), \ ((_real_bits) > 16 ? 32 : 16), (_reg_access)) =20 +#define AD4000_PSEUDO_DIFF_CHANNELS(_sign, _real_bits, _reg_access) \ +{ \ + AD4000_PSEUDO_DIFF_CHANNEL(_sign, _real_bits, _reg_access), \ + IIO_CHAN_SOFT_TIMESTAMP(1) \ +} + static const char * const ad4000_power_supplies[] =3D { "vdd", "vio" }; @@ -110,106 +124,106 @@ static const int ad4000_gains[] =3D { =20 struct ad4000_chip_info { const char *dev_name; - struct iio_chan_spec chan_spec; - struct iio_chan_spec reg_access_chan_spec; + struct iio_chan_spec chan_spec[2]; + struct iio_chan_spec reg_access_chan_spec[2]; bool has_hardware_gain; }; =20 static const struct ad4000_chip_info ad4000_chip_info =3D { .dev_name =3D "ad4000", - .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 16, 0), - .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 16, 1), + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 1), }; =20 static const struct ad4000_chip_info ad4001_chip_info =3D { .dev_name =3D "ad4001", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 16, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 16, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 1), }; =20 static const struct ad4000_chip_info ad4002_chip_info =3D { .dev_name =3D "ad4002", - .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 18, 0), - .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 18, 1), + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 0), + .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 1), }; =20 static const struct ad4000_chip_info ad4003_chip_info =3D { .dev_name =3D "ad4003", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 18, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 18, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 1), }; =20 static const struct ad4000_chip_info ad4004_chip_info =3D { .dev_name =3D "ad4004", - .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 16, 0), - .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 16, 1), + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 1), }; =20 static const struct ad4000_chip_info ad4005_chip_info =3D { .dev_name =3D "ad4005", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 16, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 16, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 1), }; =20 static const struct ad4000_chip_info ad4006_chip_info =3D { .dev_name =3D "ad4006", - .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 18, 0), - .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 18, 1), + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 0), + .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 1), }; =20 static const struct ad4000_chip_info ad4007_chip_info =3D { .dev_name =3D "ad4007", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 18, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 18, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 1), }; =20 static const struct ad4000_chip_info ad4008_chip_info =3D { .dev_name =3D "ad4008", - .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 16, 0), - .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 16, 1), + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 1), }; =20 static const struct ad4000_chip_info ad4010_chip_info =3D { .dev_name =3D "ad4010", - .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 18, 0), - .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNEL('u', 18, 1), + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 0), + .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 1), }; =20 static const struct ad4000_chip_info ad4011_chip_info =3D { .dev_name =3D "ad4011", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 18, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 18, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 1), }; =20 static const struct ad4000_chip_info ad4020_chip_info =3D { .dev_name =3D "ad4020", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 20, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 20, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 1), }; =20 static const struct ad4000_chip_info ad4021_chip_info =3D { .dev_name =3D "ad4021", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 20, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 20, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 1), }; =20 static const struct ad4000_chip_info ad4022_chip_info =3D { .dev_name =3D "ad4022", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 20, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 20, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 1), }; =20 static const struct ad4000_chip_info adaq4001_chip_info =3D { .dev_name =3D "adaq4001", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 16, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 16, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 1), .has_hardware_gain =3D true, }; =20 static const struct ad4000_chip_info adaq4003_chip_info =3D { .dev_name =3D "adaq4003", - .chan_spec =3D AD4000_DIFF_CHANNEL('s', 18, 0), - .reg_access_chan_spec =3D AD4000_DIFF_CHANNEL('s', 18, 1), + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), + .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 1), .has_hardware_gain =3D true, }; =20 @@ -591,7 +605,7 @@ static int ad4000_probe(struct spi_device *spi) switch (st->sdi_pin) { case AD4000_SDI_MOSI: indio_dev->info =3D &ad4000_reg_access_info; - indio_dev->channels =3D &chip->reg_access_chan_spec; + indio_dev->channels =3D chip->reg_access_chan_spec; =20 /* * In "3-wire mode", the ADC SDI line must be kept high when @@ -603,7 +617,7 @@ static int ad4000_probe(struct spi_device *spi) if (ret < 0) return ret; =20 - ret =3D ad4000_prepare_3wire_mode_message(st, indio_dev->channels); + ret =3D ad4000_prepare_3wire_mode_message(st, &indio_dev->channels[0]); if (ret) return ret; =20 @@ -614,16 +628,16 @@ static int ad4000_probe(struct spi_device *spi) break; case AD4000_SDI_VIO: indio_dev->info =3D &ad4000_info; - indio_dev->channels =3D &chip->chan_spec; - ret =3D ad4000_prepare_3wire_mode_message(st, indio_dev->channels); + indio_dev->channels =3D chip->chan_spec; + ret =3D ad4000_prepare_3wire_mode_message(st, &indio_dev->channels[0]); if (ret) return ret; =20 break; case AD4000_SDI_CS: indio_dev->info =3D &ad4000_info; - indio_dev->channels =3D &chip->chan_spec; - ret =3D ad4000_prepare_4wire_mode_message(st, indio_dev->channels); + indio_dev->channels =3D chip->chan_spec; + ret =3D ad4000_prepare_4wire_mode_message(st, &indio_dev->channels[0]); if (ret) return ret; =20 @@ -637,7 +651,7 @@ static int ad4000_probe(struct spi_device *spi) } =20 indio_dev->name =3D chip->dev_name; - indio_dev->num_channels =3D 1; + indio_dev->num_channels =3D 2; =20 ret =3D devm_mutex_init(dev, &st->lock); if (ret) @@ -658,7 +672,7 @@ static int ad4000_probe(struct spi_device *spi) } } =20 - ad4000_fill_scale_tbl(st, indio_dev->channels); + ad4000_fill_scale_tbl(st, &indio_dev->channels[0]); =20 ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, &iio_pollfunc_store_time, --=20 2.45.2 From nobody Sun Nov 24 02:41:00 2024 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 254101CCEFC; Tue, 19 Nov 2024 12:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732020892; cv=none; b=PLEgl9sAJykhA545tvLK3S7XYah09ufIjcEnpGsw9+ISNhKiHSYt0hfeR4h0ozIuzH/TcPbLIT3CCUeHH7pU6IQScRT1FHfaM0jCLMHoiklGP7msmplp9yIxBWhiFqhUFR0h6Hk2ZiqwJLiIyRoYaipLXa65tmkM6yFCK2geK90= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732020892; c=relaxed/simple; bh=0NtJLeywE+5TIOBJlVnnpu8TszEYpxScCqZ+saKDLZE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uUgQ87amUvYR4F8jgXvB+teN2U/+f4MB7w0s//wCsusVJHmNsx23L1gwXDxJahurhUVM9+BI3a5gRN2x7GaY6q0yIjaEdjO27TqhrWJjKPtLnXkXjkhdopqoqhdDjxadCn1tAofXME4LUt1rizwSr2Cc2Zmv3b8V8deJtR5DTsk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=wMSZ+HFh; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="wMSZ+HFh" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AJB18gM009127; Tue, 19 Nov 2024 07:54:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=ATPUJ Fb2+7Q0aIr6pLA77tNE670dlGb9JHs4u0ZKanc=; b=wMSZ+HFhSKXq/HXwU70or oV15qa1xgp8Xc3lmR1aTGXAS/5k04h+rGszct8kEuprsbLGDwMXhti793XhxJldw IlTpJhEBZ+t+sszo10LnS8Z5kl8nOZRTlNZSQzCY86ngfOWoAz/2MXIXcFbxpxfH dfwIEag2Bn++A8nafjv6riTwD5M51+nrZq1r0I/fRfdqyErWxr2c0Ma6CE5dCnRh nqfJw98xT+1fScbYRZX+iDWOCJkfxSCvzvcVy3jLfrg5fzrJhu23VhC/9ry8Wk0w WS95VtKa+HtGelkVq5lZuSM/legG4YvIhdEOljzu4rCnL7QU4P92A0U6fSlTq0LV g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 430seageje-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Nov 2024 07:54:37 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 4AJCsaTb005026 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Nov 2024 07:54:36 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Tue, 19 Nov 2024 07:54:36 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Tue, 19 Nov 2024 07:54:35 -0500 Received: from work.ad.analog.com (HYB-hERzalRezfV.ad.analog.com [10.65.205.9]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 4AJCsOOD007325; Tue, 19 Nov 2024 07:54:27 -0500 From: Marcelo Schmitt To: , , , , , , , CC: , , Subject: [PATCH v3 3/4] iio: adc: ad4000: Use device specific timing for SPI transfers Date: Tue, 19 Nov 2024 09:54:22 -0300 Message-ID: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: w1bXRaGFWh2B7bHw8PBN3V4vWyK9IA3a X-Proofpoint-ORIG-GUID: w1bXRaGFWh2B7bHw8PBN3V4vWyK9IA3a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411190095 Content-Type: text/plain; charset="utf-8" The SPI transfers for AD4020, AD4021, and AD4022 have slightly different timing specifications. Use device specific timing constraints to set SPI transfer parameters. While tweaking time constraints, remove time related defines including unused AD4000_TQUIET1_NS. Signed-off-by: Marcelo Schmitt --- drivers/iio/adc/ad4000.c | 51 +++++++++++++++++++++++++++++++++------- 1 file changed, 42 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/ad4000.c b/drivers/iio/adc/ad4000.c index 21731c4d31ee..c700d51b5637 100644 --- a/drivers/iio/adc/ad4000.c +++ b/drivers/iio/adc/ad4000.c @@ -35,10 +35,6 @@ =20 #define AD4000_SCALE_OPTIONS 2 =20 -#define AD4000_TQUIET1_NS 190 -#define AD4000_TQUIET2_NS 60 -#define AD4000_TCONV_NS 320 - #define __AD4000_DIFF_CHANNEL(_sign, _real_bits, _storage_bits, _reg_acces= s) \ { \ .type =3D IIO_VOLTAGE, \ @@ -122,10 +118,31 @@ static const int ad4000_gains[] =3D { 454, 909, 1000, 1900, }; =20 +struct ad4000_time_spec { + int t_conv_ns; + int t_quiet2_ns; +}; + +/* + * Same timing specifications for all of AD4000, AD4001, ..., AD4008, AD40= 10, + * ADAQ4001, and ADAQ4003. + */ +static const struct ad4000_time_spec ad4000_t_spec =3D { + .t_conv_ns =3D 320, + .t_quiet2_ns =3D 60, +}; + +/* AD4020, AD4021, AD4022 */ +static const struct ad4000_time_spec ad4020_t_spec =3D { + .t_conv_ns =3D 350, + .t_quiet2_ns =3D 60, +}; + struct ad4000_chip_info { const char *dev_name; struct iio_chan_spec chan_spec[2]; struct iio_chan_spec reg_access_chan_spec[2]; + const struct ad4000_time_spec *time_spec; bool has_hardware_gain; }; =20 @@ -133,90 +150,105 @@ static const struct ad4000_chip_info ad4000_chip_inf= o =3D { .dev_name =3D "ad4000", .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4001_chip_info =3D { .dev_name =3D "ad4001", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4002_chip_info =3D { .dev_name =3D "ad4002", .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 0), .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4003_chip_info =3D { .dev_name =3D "ad4003", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4004_chip_info =3D { .dev_name =3D "ad4004", .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4005_chip_info =3D { .dev_name =3D "ad4005", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4006_chip_info =3D { .dev_name =3D "ad4006", .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 0), .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4007_chip_info =3D { .dev_name =3D "ad4007", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4008_chip_info =3D { .dev_name =3D "ad4008", .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4010_chip_info =3D { .dev_name =3D "ad4010", .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 0), .reg_access_chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 18, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4011_chip_info =3D { .dev_name =3D "ad4011", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 1), + .time_spec =3D &ad4000_t_spec, }; =20 static const struct ad4000_chip_info ad4020_chip_info =3D { .dev_name =3D "ad4020", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 1), + .time_spec =3D &ad4020_t_spec, }; =20 static const struct ad4000_chip_info ad4021_chip_info =3D { .dev_name =3D "ad4021", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 1), + .time_spec =3D &ad4020_t_spec, }; =20 static const struct ad4000_chip_info ad4022_chip_info =3D { .dev_name =3D "ad4022", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 20, 1), + .time_spec =3D &ad4020_t_spec, }; =20 static const struct ad4000_chip_info adaq4001_chip_info =3D { .dev_name =3D "adaq4001", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 1), + .time_spec =3D &ad4000_t_spec, .has_hardware_gain =3D true, }; =20 @@ -224,6 +256,7 @@ static const struct ad4000_chip_info adaq4003_chip_info= =3D { .dev_name =3D "adaq4003", .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), .reg_access_chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 1), + .time_spec =3D &ad4000_t_spec, .has_hardware_gain =3D true, }; =20 @@ -238,6 +271,7 @@ struct ad4000_state { bool span_comp; u16 gain_milli; int scale_tbl[AD4000_SCALE_OPTIONS][2]; + const struct ad4000_time_spec *time_spec; =20 /* * DMA (thus cache coherency maintenance) requires the transfer buffers @@ -502,16 +536,15 @@ static const struct iio_info ad4000_info =3D { static int ad4000_prepare_3wire_mode_message(struct ad4000_state *st, const struct iio_chan_spec *chan) { - unsigned int cnv_pulse_time =3D AD4000_TCONV_NS; struct spi_transfer *xfers =3D st->xfers; =20 xfers[0].cs_change =3D 1; - xfers[0].cs_change_delay.value =3D cnv_pulse_time; + xfers[0].cs_change_delay.value =3D st->time_spec->t_conv_ns; xfers[0].cs_change_delay.unit =3D SPI_DELAY_UNIT_NSECS; =20 xfers[1].rx_buf =3D &st->scan.data; xfers[1].len =3D BITS_TO_BYTES(chan->scan_type.storagebits); - xfers[1].delay.value =3D AD4000_TQUIET2_NS; + xfers[1].delay.value =3D st->time_spec->t_quiet2_ns; xfers[1].delay.unit =3D SPI_DELAY_UNIT_NSECS; =20 spi_message_init_with_transfers(&st->msg, st->xfers, 2); @@ -529,7 +562,6 @@ static int ad4000_prepare_3wire_mode_message(struct ad4= 000_state *st, static int ad4000_prepare_4wire_mode_message(struct ad4000_state *st, const struct iio_chan_spec *chan) { - unsigned int cnv_to_sdi_time =3D AD4000_TCONV_NS; struct spi_transfer *xfers =3D st->xfers; =20 /* @@ -537,7 +569,7 @@ static int ad4000_prepare_4wire_mode_message(struct ad4= 000_state *st, * going low. */ xfers[0].cs_off =3D 1; - xfers[0].delay.value =3D cnv_to_sdi_time; + xfers[0].delay.value =3D st->time_spec->t_conv_ns; xfers[0].delay.unit =3D SPI_DELAY_UNIT_NSECS; =20 xfers[1].rx_buf =3D &st->scan.data; @@ -576,6 +608,7 @@ static int ad4000_probe(struct spi_device *spi) =20 st =3D iio_priv(indio_dev); st->spi =3D spi; + st->time_spec =3D chip->time_spec; =20 ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(ad4000_power_suppl= ies), ad4000_power_supplies); --=20 2.45.2 From nobody Sun Nov 24 02:41:00 2024 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DA471CC88D; Tue, 19 Nov 2024 12:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732020915; cv=none; b=T42BsvTJc6IigIuFZlbArceOVXRALHxtVnnxZ4y9KoOrOTQOFKhI9f32L9yqKHZNaqHWhXYEPok29KaL5fn957UJ9FqZIV8o5mCMjHTUbdSZ9NUMID/O4FAKuRECd3JoJJLXVma5cAMWzWRamqBF3ASiYJl5ephX1MTwZFxu0Kg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732020915; c=relaxed/simple; bh=UG0j9jP4clEqcDpOVurpM+p4zKueeealkqG18mOI5Fc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SMT1lJYeS9AYJ5zFiwZ2na7F2gAyKRnPtriJMkTPsGmq7p6xTrtkwzUkUKGk7Jnijab8dlTnHaLqWhC49lbITmXcRqkQuS+5neDB5uGtUYQVcvldkVI2Wf8tdjle6BevQyB2OR7lfuG04rttAvOWdM8MBCmiwitqEARFvxXyfQI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=QoROGbph; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="QoROGbph" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AJCMdrr020233; Tue, 19 Nov 2024 07:54:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=RtKzt Mk+WaSacvWDrWRl7PaF1p+LzKzHwlczSrtztto=; b=QoROGbph0BKCtfHUwC6eY iqDt8nZoEH4pskfq3DfslKhO69SOBXSu5LBWlJCk1R3MuJ7VkNmEteO3W2oPraxq 1fjNIu/W+TzRLBIiz7rU8QnlfEm3PC80Z1buDOWsgdIPvBjzmWWwFx91f3SlBpLi 9l8+vwZn0A3x+Ncz2ZWt/iwmy/gWuQNhCkxJcQnICKppNLzZln2kGDQShkbLe5+y A/PHcHVWBjTaykq/IXb7BoS246UWZiYVFoMmreCAjmAUV7yEQ875qxnNwvRO4GQh ccvg0/+pP1teRA4PyparOuae9RdQTu2XcCVWNfm4M2GSJ+mkxL2uoNF8JVJ4lZYC w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 43025m6hfb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Nov 2024 07:54:57 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 4AJCsuHl005035 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Nov 2024 07:54:56 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Tue, 19 Nov 2024 07:54:56 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Tue, 19 Nov 2024 07:54:56 -0500 Received: from work.ad.analog.com (HYB-hERzalRezfV.ad.analog.com [10.65.205.9]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 4AJCsfwN007335; Tue, 19 Nov 2024 07:54:43 -0500 From: Marcelo Schmitt To: , , , , , , , CC: , , , David Lechner Subject: [PATCH v3 4/4] iio: adc: ad4000: Add support for PulSAR devices Date: Tue, 19 Nov 2024 09:54:39 -0300 Message-ID: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: AWhEhaKjXbNS37g5ITvXKU-vkOM1u5uz X-Proofpoint-ORIG-GUID: AWhEhaKjXbNS37g5ITvXKU-vkOM1u5uz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411190095 Content-Type: text/plain; charset="utf-8" The ADI PulSAR series of single-channel devices comprises differential and pseudo-differential ADCs that don't require any input data from the host controller. By not requiring a data input line, PulSAR devices can operate with a 3-wire only data bus in some setups. The AD4000 series and the single-channel PulSAR series of devices have similar SPI transfer specifications and wiring configurations. Single-channel PulSAR devices are slower than AD4000 and don't have a configuration register. That taken into account, single-channel PulSARs can be supported by the ad4000 driver without any increase in code complexity. Extend the AD4000 driver to also support single-channel PulSAR devices. Reviewed-by: David Lechner Signed-off-by: Marcelo Schmitt --- drivers/iio/adc/ad4000.c | 162 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 162 insertions(+) diff --git a/drivers/iio/adc/ad4000.c b/drivers/iio/adc/ad4000.c index c700d51b5637..74b8894d1a2a 100644 --- a/drivers/iio/adc/ad4000.c +++ b/drivers/iio/adc/ad4000.c @@ -138,6 +138,48 @@ static const struct ad4000_time_spec ad4020_t_spec =3D= { .t_quiet2_ns =3D 60, }; =20 +/* AD7983, AD7984 */ +static const struct ad4000_time_spec ad7983_t_spec =3D { + .t_conv_ns =3D 500, + .t_quiet2_ns =3D 0, +}; + +/* AD7980, AD7982 */ +static const struct ad4000_time_spec ad7980_t_spec =3D { + .t_conv_ns =3D 800, + .t_quiet2_ns =3D 0, +}; + +/* AD7946, AD7686, AD7688, AD7988-5, AD7693 */ +static const struct ad4000_time_spec ad7686_t_spec =3D { + .t_conv_ns =3D 1600, + .t_quiet2_ns =3D 0, +}; + +/* AD7690 */ +static const struct ad4000_time_spec ad7690_t_spec =3D { + .t_conv_ns =3D 2100, + .t_quiet2_ns =3D 0, +}; + +/* AD7942, AD7685, AD7687 */ +static const struct ad4000_time_spec ad7687_t_spec =3D { + .t_conv_ns =3D 3200, + .t_quiet2_ns =3D 0, +}; + +/* AD7691 */ +static const struct ad4000_time_spec ad7691_t_spec =3D { + .t_conv_ns =3D 3700, + .t_quiet2_ns =3D 0, +}; + +/* AD7988-1 */ +static const struct ad4000_time_spec ad7988_1_t_spec =3D { + .t_conv_ns =3D 9500, + .t_quiet2_ns =3D 0, +}; + struct ad4000_chip_info { const char *dev_name; struct iio_chan_spec chan_spec[2]; @@ -260,6 +302,96 @@ static const struct ad4000_chip_info adaq4003_chip_inf= o =3D { .has_hardware_gain =3D true, }; =20 +static const struct ad4000_chip_info ad7685_chip_info =3D { + .dev_name =3D "ad7685", + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .time_spec =3D &ad7687_t_spec, +}; + +static const struct ad4000_chip_info ad7686_chip_info =3D { + .dev_name =3D "ad7686", + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .time_spec =3D &ad7686_t_spec, +}; + +static const struct ad4000_chip_info ad7687_chip_info =3D { + .dev_name =3D "ad7687", + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), + .time_spec =3D &ad7687_t_spec, +}; + +static const struct ad4000_chip_info ad7688_chip_info =3D { + .dev_name =3D "ad7688", + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), + .time_spec =3D &ad7686_t_spec, +}; + +static const struct ad4000_chip_info ad7690_chip_info =3D { + .dev_name =3D "ad7690", + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), + .time_spec =3D &ad7690_t_spec, +}; + +static const struct ad4000_chip_info ad7691_chip_info =3D { + .dev_name =3D "ad7691", + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), + .time_spec =3D &ad7691_t_spec, +}; + +static const struct ad4000_chip_info ad7693_chip_info =3D { + .dev_name =3D "ad7693", + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 16, 0), + .time_spec =3D &ad7686_t_spec, +}; + +static const struct ad4000_chip_info ad7942_chip_info =3D { + .dev_name =3D "ad7942", + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 14, 0), + .time_spec =3D &ad7687_t_spec, +}; + +static const struct ad4000_chip_info ad7946_chip_info =3D { + .dev_name =3D "ad7946", + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 14, 0), + .time_spec =3D &ad7686_t_spec, +}; + +static const struct ad4000_chip_info ad7980_chip_info =3D { + .dev_name =3D "ad7980", + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .time_spec =3D &ad7980_t_spec, +}; + +static const struct ad4000_chip_info ad7982_chip_info =3D { + .dev_name =3D "ad7982", + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), + .time_spec =3D &ad7980_t_spec, +}; + +static const struct ad4000_chip_info ad7983_chip_info =3D { + .dev_name =3D "ad7983", + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .time_spec =3D &ad7983_t_spec, +}; + +static const struct ad4000_chip_info ad7984_chip_info =3D { + .dev_name =3D "ad7984", + .chan_spec =3D AD4000_DIFF_CHANNELS('s', 18, 0), + .time_spec =3D &ad7983_t_spec, +}; + +static const struct ad4000_chip_info ad7988_1_chip_info =3D { + .dev_name =3D "ad7988-1", + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .time_spec =3D &ad7988_1_t_spec, +}; + +static const struct ad4000_chip_info ad7988_5_chip_info =3D { + .dev_name =3D "ad7988-5", + .chan_spec =3D AD4000_PSEUDO_DIFF_CHANNELS('u', 16, 0), + .time_spec =3D &ad7686_t_spec, +}; + struct ad4000_state { struct spi_device *spi; struct gpio_desc *cnv_gpio; @@ -733,6 +865,21 @@ static const struct spi_device_id ad4000_id[] =3D { { "ad4022", (kernel_ulong_t)&ad4022_chip_info }, { "adaq4001", (kernel_ulong_t)&adaq4001_chip_info }, { "adaq4003", (kernel_ulong_t)&adaq4003_chip_info }, + { "ad7685", (kernel_ulong_t)&ad7685_chip_info }, + { "ad7686", (kernel_ulong_t)&ad7686_chip_info }, + { "ad7687", (kernel_ulong_t)&ad7687_chip_info }, + { "ad7688", (kernel_ulong_t)&ad7688_chip_info }, + { "ad7690", (kernel_ulong_t)&ad7690_chip_info }, + { "ad7691", (kernel_ulong_t)&ad7691_chip_info }, + { "ad7693", (kernel_ulong_t)&ad7693_chip_info }, + { "ad7942", (kernel_ulong_t)&ad7942_chip_info }, + { "ad7946", (kernel_ulong_t)&ad7946_chip_info }, + { "ad7980", (kernel_ulong_t)&ad7980_chip_info }, + { "ad7982", (kernel_ulong_t)&ad7982_chip_info }, + { "ad7983", (kernel_ulong_t)&ad7983_chip_info }, + { "ad7984", (kernel_ulong_t)&ad7984_chip_info }, + { "ad7988-1", (kernel_ulong_t)&ad7988_1_chip_info }, + { "ad7988-5", (kernel_ulong_t)&ad7988_5_chip_info }, { } }; MODULE_DEVICE_TABLE(spi, ad4000_id); @@ -754,6 +901,21 @@ static const struct of_device_id ad4000_of_match[] =3D= { { .compatible =3D "adi,ad4022", .data =3D &ad4022_chip_info }, { .compatible =3D "adi,adaq4001", .data =3D &adaq4001_chip_info }, { .compatible =3D "adi,adaq4003", .data =3D &adaq4003_chip_info }, + { .compatible =3D "adi,ad7685", .data =3D &ad7685_chip_info }, + { .compatible =3D "adi,ad7686", .data =3D &ad7686_chip_info }, + { .compatible =3D "adi,ad7687", .data =3D &ad7687_chip_info }, + { .compatible =3D "adi,ad7688", .data =3D &ad7688_chip_info }, + { .compatible =3D "adi,ad7690", .data =3D &ad7690_chip_info }, + { .compatible =3D "adi,ad7691", .data =3D &ad7691_chip_info }, + { .compatible =3D "adi,ad7693", .data =3D &ad7693_chip_info }, + { .compatible =3D "adi,ad7942", .data =3D &ad7942_chip_info }, + { .compatible =3D "adi,ad7946", .data =3D &ad7946_chip_info }, + { .compatible =3D "adi,ad7980", .data =3D &ad7980_chip_info }, + { .compatible =3D "adi,ad7982", .data =3D &ad7982_chip_info }, + { .compatible =3D "adi,ad7983", .data =3D &ad7983_chip_info }, + { .compatible =3D "adi,ad7984", .data =3D &ad7984_chip_info }, + { .compatible =3D "adi,ad7988-1", .data =3D &ad7988_1_chip_info }, + { .compatible =3D "adi,ad7988-5", .data =3D &ad7988_5_chip_info }, { } }; MODULE_DEVICE_TABLE(of, ad4000_of_match); --=20 2.45.2