From nobody Sun Nov 24 08:35:35 2024 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A90E4192583; Wed, 6 Nov 2024 06:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730874550; cv=none; b=G51UVKQt+i2Rmz1GrI3pVZnyc1S54Sfay8zg0ukxBvvgssVievU57Hw43sHLu7j5Nqo9rfhoJAYl+V2mYJYrBUjGeN0diGmbC68NVNyY/8gha1h2d5H96gF+3NQApZyqlfCj/X25L7NEdteAkxUyuG5rYf4YtkKrnqTdYN3KKhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730874550; c=relaxed/simple; bh=bc7z2TrjPCemYNFXMKTXgqZ9s5+UAL9PCibzgFBB7FM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gQa2+1KnpwFeDt12Rl1kp8ln2t9qUvW3fO1LQnoNfwZYsYrQYn+rJ60EaOby++HNMLMxRS6qQymSY6aO1rWqS7mSN21h/gdd7XRChkKEB/+hAcRoNFahqs+Rm4Bud3AcJe6ofnQeV/YYU++rslr/gaHyUMA7Ym3hNxv9J8ViWUQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=bZiU3vFw; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="bZiU3vFw" From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1730874539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A6VQYF4EfyDGrmwUI4CX6ZEqHhlwwOz819w7ZIjm6cY=; b=bZiU3vFweT+js9yvjgn8q2+cUPtfCqqdgYzh7tAT4SX5AaOHyqZm93Z5P4VfJ3Lonf0O58 ltpiroQhmyJSPw/h+pd7g2vT1fAMCGh2/47COxtSgrPFOuhmbHd112PK3ETvAVmZ1goivU NZiYvgeXmKNrWvUwim4H0NM1wmrdcw3zCAcOClS9E8IlbEHyqGPWTmiD6HjTzVsKn/3BlN r0c1Tg4YwevuDRcqj2mgMmdM4ULpQdE0POk9rq9vKxc+DGY04NIW3B5PxG5mA9gW59qlLj eIH3oSBRd5I3ZFVSk/8Yh9U7ELNYLxGGCPue8xQZJQYEHdZ+GQ3+LaPdTspbAQ== To: apw@canonical.com, joe@perches.com, corbet@lwn.net Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, workflows@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, wens@csie.org, dsimic@manjaro.org Subject: [PATCH v2 1/3] checkpatch: Make Helped-by tag supported Date: Wed, 6 Nov 2024 07:28:40 +0100 Message-Id: <0e1ef28710e3e49222c966f07958a9879fa4e903.1730874296.git.dsimic@manjaro.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Content-Type: text/plain; charset="utf-8" Providing a Helped-by tag fits well to indicate someone had helped with the development of a patch, to the level that still doesn't warrant providing a Co-developed-by tag, but is much more than it would've been indicated by providing a Suggested-by tag. The Helped-by tag been already used recently a few times in accepted patches. [1] With all this in mind, let's have Helped-by supported in checkpatch.pl. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/= ?qt=3Dgrep&q=3DHelped-by Signed-off-by: Dragan Simic --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4427572b2477..b89e62e9c2dd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -622,6 +622,7 @@ our $signature_tags =3D qr{(?xi: Reviewed-by:| Reported-by:| Suggested-by:| + Helped-by:| To:| Cc: )}; From nobody Sun Nov 24 08:35:35 2024 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A908C192581; Wed, 6 Nov 2024 06:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730874549; cv=none; b=KpYVoCzSUurIj9tAfjOrbH6aizp0gg6DRUCWwV0Eyf7UniR5oN7y4c83Bnf4Ge3XKkjEextiBnXivqPUSosUT9r/1kwkXZXV+0E09aZqVSKgziGv+k5REYKXSBrys3b1f/9Ol59PadwLvfQ/qYzUIHrQFWUQnPATqt63i4h7Tt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730874549; c=relaxed/simple; bh=v4yDzdwdmKCTNq2JJwFmsmUgEFGcIFhHRpm2flf6WWk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HyHVbIqNQW4NxPzZFpY8F5ypfaRc3OeEnFeh5LpM667Zg4usRbwBumBi7tBqWG0mwsFrGCOHcF+lgPyoDOW1pD+TgL+7xGhi/oceG2YtI7Z389cQ0EgchsKkxFtfNRiqpphGhcv4pIo3DRTuXWaWjgpsd0c4Kia2qw6gdWtHJO4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=XBD907jq; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="XBD907jq" From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1730874540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9chjI8yf8DsjPo9gl1sBbaHEUuI28DbskiyOJJFDi0g=; b=XBD907jqcnt8ltatvFLetAF1CiDS6rnujO9pVVxcjqeVkedto4e5C4DRq9e/wghTsf+Hgi HsslplxPTc3V7ukYCXtwewL+m1j+rP/t+MkMxWLgTqxVMq5Cc2/qQbZ/VeouyK/3/yi4F9 a662LKMOyZnkC6gFc0gkwYtbETv5rJ9wp7715h9DSpAMPHAaBr5v3QGKFzpAG+mUX5/zrT XqKgvuYDUd0HgBpGvda0vT5EKmSDl8FogDl1L2aKQM/GRZhdlxsRRcYSUjNZZouLn5Hj6r 5QfjX1AaDRNblcxLNg5BAsqxlEyQw3u5n/5SGgZlZOm8FBMG5ei2v0+Q1pDUHg== To: apw@canonical.com, joe@perches.com, corbet@lwn.net Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, workflows@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, wens@csie.org, dsimic@manjaro.org Subject: [PATCH v2 2/3] docs: submitting-patches: Reflow one short paragraph Date: Wed, 6 Nov 2024 07:28:41 +0100 Message-Id: <69b22028203da533392c60debbeabe6932422e98.1730874296.git.dsimic@manjaro.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Content-Type: text/plain; charset="utf-8" Reflow one spotted short paragraph, to make it more consistent with the rest of the file. No functional changes are introduced. Signed-off-by: Dragan Simic --- Documentation/process/submitting-patches.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/process/submitting-patches.rst b/Documentation/p= rocess/submitting-patches.rst index 1518bd57adab..382c49659cb9 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -202,9 +202,8 @@ Style-check your changes ------------------------ =20 Check your patch for basic style violations, details of which can be -found in Documentation/process/coding-style.rst. -Failure to do so simply wastes -the reviewers time and will get your patch rejected, probably +found in Documentation/process/coding-style.rst. Failure to do so simply +wastes the reviewers time and will get your patch rejected, probably without even being read. =20 One significant exception is when moving code from one file to From nobody Sun Nov 24 08:35:35 2024 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E3219259D; Wed, 6 Nov 2024 06:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730874550; cv=none; b=kNJjcLHu5xcYk2lettItU4XPwY29mztCQrscQL13whC3oI0kbgAjZVtmlTPEH7AR5zrdxNnuqeljBt+Tdm7HGl2jv/fvkW453/erTHS0j4za1qFOD3lWhYzJzPL3DpgDy9WqJEIZ+P/eYxfe72NNAUmgFgFcunstPDRpS8bIB8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730874550; c=relaxed/simple; bh=dQgcGWUvfOu5xpeBNFHrBzxUtWgdyqujDCKQfFq6Dkg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KFzTTqPUKFXgXZ7U/x9iGxtG+mSWQzUSWoOm7RuUr1g3MJ+OX+FP6V8OUoGaUm+JSggOEI6Wenlkhxqs/flgl65WiVQR8qOUQeWiO/uTUerlNXq36vYlnsH3RJuDFtWPU3pCVBuc9ioB06dmQAEoJWpQ9HK2tGXGcui9g5o8og8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=ECRbCt83; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="ECRbCt83" From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1730874541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cKylLYA/b4uX/rCkAgwCAqhzPmE0mtRHuRn9J/WQvog=; b=ECRbCt83YvrrNDL67JttM61Lst+t4md/GY9YFVLN+gmQsSCDKcmziFB9z5xqANkE18wSE3 iq1h0cekEZOeZwwppdE7hnWhaB0ahMAA0YU2fdzeUTUVywl1HFmHduSmsts6N+KibRzx70 PoThe9XD9cOMUVGJseTJIkzWZE8lVfp4SVv58aIx6xWnmvMZwEoHQAR+x20ogApTazwhvC XNJspnT4jR1aUnpBryp/iPSIcdcXI0LmvhkSxanzhrx+tOEiA8IGoNcXDsC/FDL26eBq8e SAI1jo28Us7c+K5NY5/mQP1bZwHuzkCTvkid80MvXco3sXODClEaICFT9mqm3Q== To: apw@canonical.com, joe@perches.com, corbet@lwn.net Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, workflows@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, wens@csie.org, dsimic@manjaro.org Subject: [PATCH v2 3/3] docs: submitting-patches: Describe the use of Helped-by tag Date: Wed, 6 Nov 2024 07:28:42 +0100 Message-Id: <55056f4ec0365c67576a1e1e3162b0cfeadd1c6d.1730874296.git.dsimic@manjaro.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Content-Type: text/plain; charset="utf-8" Add the description of the intended use of Helped-by tags, which give credit to the persons who assisted the patch authors in a way that didn't actually contribute to the patch directly, i.e. at the source-code level. Suggested-by: Chen-Yu Tsai Signed-off-by: Dragan Simic --- Documentation/process/submitting-patches.rst | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/process/submitting-patches.rst b/Documentation/p= rocess/submitting-patches.rst index 382c49659cb9..d0d12536ab68 100644 --- a/Documentation/process/submitting-patches.rst +++ b/Documentation/process/submitting-patches.rst @@ -452,8 +452,8 @@ as it was propagated to the maintainers and ultimately = to Linus, with the first SoB entry signalling primary authorship of a single author. =20 =20 -When to use Acked-by:, Cc:, and Co-developed-by: ------------------------------------------------- +When to use Acked-by:, Cc:, Co-developed-by:, and Helped-by +----------------------------------------------------------- =20 The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. @@ -495,6 +495,14 @@ chronological history of the patch insofar as possible= , regardless of whether the author is attributed via From: or Co-developed-by:. Notably, the last Signed-off-by: must always be that of the developer submitting the patch. =20 +Helped-by: gives attribution to the persons that helped the patch authors +in a way that didn't directly produce the patch itself. For example, some= one +may provide significant assistance to the authors by researching the schem= atic +of a device that the patch addresses, or by providing the patch authors wi= th +some background information required to develop the patch, while contribut= ing +no actual source code. As a result of no direct patch authorship, no +Signed-off-by: tags are needed together with Helped-by: tags. + Note, the From: tag is optional when the From: author is also the person (= and email) listed in the From: line of the email header.