From nobody Sun Nov 24 19:33:22 2024 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3321F42070; Sat, 2 Nov 2024 03:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730516968; cv=none; b=rCjol7HsL4X3WzJ3uj3qLuAwyfnCv5fQSQM8tcpF+LmI3hfpCXxsZ7PaBioyMxPFTeuYYEs7om70riGStSJOjoojfO2I3Ofb4EL/yCW3yoeRgOmgKt2c2WpwYaLnkTRxb8hEWl7uQKNnk2hqpbLO5VqBCTzmjwhIPxKkcvjkltQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730516968; c=relaxed/simple; bh=geYC7r4H3w86VyqGSsfw/vB/Pc5suyDUj0gAsNSm5uU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nCjIGzfK2qTtAcAf5wrbktlJ3TeZaVpDekEu5r5fHfCJi68YCbHYWWXz70D39NhwBbW71GCSgRt6sLXS1VdQoUhOUUOZmza3zxIoZNWJBWGdWeYHZcSBnrlJvToFBd220P1BudivJFCx+R3V7ibCBEmoilod62idp5GaFtjycoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=acDK5Lt9; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="acDK5Lt9" From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1730516957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k33vTDitf06aKiwfNJDdOoAA6cwqjjJzaXvt5dYrR+I=; b=acDK5Lt93Pm2eToay6pQv0CX3Gn3gQagepQd+XDmGCqJOTGy76/7E4lu11S+0yHkuRRMdO 6C+TBxot+ps8HWtLCfSAqaAhzXhxITcGiOtWZRJjjmGYjXdkGC8byvGtSKtKHH5DgHtI/u i7WJiqXaqSbCb86WWTZ8H1ssGB7l6aL8YRf8aejjGrplsAIAPLK4tESkjnlRR9gOh+6IHF 5UTTwcgwWfcfutiZN/NPzEiG93tqjB9N2WWVYRqPCSYQQonPgm0htkfePbBzUuapFNWeW+ MfXENjKfwh3d5OBLGnvTSq6818Kkevuca2ZNDFmdgkzgZQJqxu66EiDTBoxMyA== To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, didi.debian@cknow.org Subject: [PATCH v2 1/3] arm64: dts: rockchip: Update CPU OPP voltages in RK356x SoC dtsi Date: Sat, 2 Nov 2024 04:08:59 +0100 Message-Id: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Content-Type: text/plain; charset="utf-8" Update the lower/upper voltage limits and the exact voltages for the Rockch= ip RK356x CPU OPPs, using the most conservative values (i.e. the highest per-O= PP voltages) found in the vendor kernel source. [1] Using the most conservative per-OPP voltages ensures reliable CPU operation regardless of the actual CPU binning, with the downside of possibly using a bit more power for the CPU cores than absolutely needed. Additionally, fill in the missing "clock-latency-ns" CPU OPP properties, us= ing the values found in the vendor kernel source. [1] [1] https://raw.githubusercontent.com/rockchip-linux/kernel/f8b9431ee38ed56= 1650be7092ab93f564598daa9/arch/arm64/boot/dts/rockchip/rk3568.dtsi Related-to: eb665b1c06bc ("arm64: dts: rockchip: Update GPU OPP voltages in= RK356x SoC dtsi") Signed-off-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk356x.dtsi | 18 ++++++++++++------ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts= /rockchip/rk3568.dtsi index 0946310e8c12..5c54898f6ed1 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi @@ -273,6 +273,7 @@ &cpu0_opp_table { opp-1992000000 { opp-hz =3D /bits/ 64 <1992000000>; opp-microvolt =3D <1150000 1150000 1150000>; + clock-latency-ns =3D <40000>; }; }; =20 diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts= /rockchip/rk356x.dtsi index 0ee0ada6f0ab..534593f2ed0b 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi @@ -134,39 +134,45 @@ cpu0_opp_table: opp-table-0 { =20 opp-408000000 { opp-hz =3D /bits/ 64 <408000000>; - opp-microvolt =3D <900000 900000 1150000>; + opp-microvolt =3D <850000 850000 1150000>; clock-latency-ns =3D <40000>; }; =20 opp-600000000 { opp-hz =3D /bits/ 64 <600000000>; - opp-microvolt =3D <900000 900000 1150000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; }; =20 opp-816000000 { opp-hz =3D /bits/ 64 <816000000>; - opp-microvolt =3D <900000 900000 1150000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; opp-suspend; }; =20 opp-1104000000 { opp-hz =3D /bits/ 64 <1104000000>; opp-microvolt =3D <900000 900000 1150000>; + clock-latency-ns =3D <40000>; }; =20 opp-1416000000 { opp-hz =3D /bits/ 64 <1416000000>; - opp-microvolt =3D <900000 900000 1150000>; + opp-microvolt =3D <1025000 1025000 1150000>; + clock-latency-ns =3D <40000>; }; =20 opp-1608000000 { opp-hz =3D /bits/ 64 <1608000000>; - opp-microvolt =3D <975000 975000 1150000>; + opp-microvolt =3D <1100000 1100000 1150000>; + clock-latency-ns =3D <40000>; }; =20 opp-1800000000 { opp-hz =3D /bits/ 64 <1800000000>; - opp-microvolt =3D <1050000 1050000 1150000>; + opp-microvolt =3D <1150000 1150000 1150000>; + clock-latency-ns =3D <40000>; }; }; From nobody Sun Nov 24 19:33:22 2024 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88F1E433B9; Sat, 2 Nov 2024 03:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730516968; cv=none; b=aoJNlnszdWrlz72DzO2c5Jo4+/SFaDLOg/AJTSrlseE2yuFqYwXVL62mZV64cNf7vQShUr2cigNS7UPcjvXR4L0uL+6XJmOvw3yZyXZ1Kf38+vi5fhP06bLTv4+AltDJ7QhY3br9d/dKy5y2JrAEtmATx8FJ4zlBuAMdaq31eco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730516968; c=relaxed/simple; bh=WscoEetMerZfbgKZnga9triImhcswg0ki+akIuXVHxw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bTFnavStkyuyhpSmzrW/IndNJBPO2VHEwdF1ThyG2TDD6QI7f5qwaSOLiBjn+Aj/zOErZS5bhzDu0H6HqDP/1RFDdaVThvWHlXDJodikpMkd+QpBjSxnL7GT5gIqylhzlh2g5yY5dUCyFu25269eAxX6qNadyRm++HR5rTLbXHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=WK6owBrL; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="WK6owBrL" From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1730516958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ULWUQV2euOeJnEAJ3CyxZrGsfmuHWmE0j0muWaOqgrQ=; b=WK6owBrL+0sFVsFZHUFDd9/PO+J6TGgQR0g2+EyEyo4l3SaN+0G4WMosbdezAmNunoD7s8 Tlne6ENA0gkB21AazsUunrvVZxqGNmyEzVhZ62SlDytVN/M7Eb79c+bjGwEzXl4S3NfpYx jLwG7c/7Qc6vXBAUGt6QlHGfgiOeP0KQS8YXW/EYJ4lSU2Ew48CFytktHFH3AeRcwGi+rD NGF0oSCP6GkIFGiXkI0s7kWPXC9PrOdGA3Pqjqiazrp3Gnsyrey8c6UnWvCfQ2QP9eesrp JLtA0NWDZmAxfhnxZFE+TMggaDS/g10WCaysInzRG8N+90Pfeigd6RNLZY+JBA== To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, didi.debian@cknow.org Subject: [PATCH v2 2/3] arm64: dts: rockchip: Prepare RK356x SoC dtsi files for per-variant OPPs Date: Sat, 2 Nov 2024 04:09:00 +0100 Message-Id: <77e7450b8280bbdf4e2dc47366c9da85d4d8d1de.1730516702.git.dsimic@manjaro.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Content-Type: text/plain; charset="utf-8" Rename the Rockchip RK356x SoC dtsi files and, consequently, adjust their contents appropriately, to prepare them for the ability to specify different CPU and GPU OPPs for each of the supported RK356x SoC variants. The first new RK356x SoC variant to be introduced is the RK3566T, which the Pine64 Quartz64 Zero SBC is officially based on. [1] Some other SBCs are also based on the RK3566T variant, including Radxa ROCK 3C and ZERO 3E/3W, but the slight trouble is that Radxa doesn't state that officially. Though, it's rather easy to spot the RK3566T on such boards, because their official specifications state that the maximum frequency for the Cortex-A55 cores is lower than the "full-fat" RK3566's 1.8 GHz. [2][3][4] These changes follow the approach used for the Rockchip RK3588 SoC variants, which was introduced and described further in commit def88eb4d836 ("arm64: dts: rockchip: Prepare RK3588 SoC dtsi files for per-variant OPPs"). Please see that commit for a more detailed explanation. No functional changes are introduced, which was validated by decompiling and comparing all affected board dtb files before and after these changes. In more detail, the affected dtb files have some of their blocks shuffled arou= nd a bit and some of their phandles have different values, as a result of the changes to the order in which the building blocks from the parent dtsi files are included, but they effectively remain the same as the originals. As a side note, due to the nature of introduced changes, this commit is a b= it more readable when viewed using the --break-rewrites option for git-log(1). [1] https://wiki.pine64.org/wiki/Quartz64 [2] https://dl.radxa.com/rock3/docs/hw/3c/radxa_rock3c_product_brief.pdf [3] https://dl.radxa.com/zero3/docs/hw/3e/radxa_zero_3e_product_brief.pdf [4] https://dl.radxa.com/zero3/docs/hw/3w/radxa_zero_3w_product_brief.pdf Related-to: def88eb4d836 ("arm64: dts: rockchip: Prepare RK3588 SoC dtsi fi= les for per-variant OPPs") Signed-off-by: Dragan Simic --- .../{rk3566.dtsi =3D> rk3566-base.dtsi} | 2 +- arch/arm64/boot/dts/rockchip/rk3566.dtsi | 142 +++++++++++++----- arch/arm64/boot/dts/rockchip/rk3568.dtsi | 114 +++++++++++++- .../{rk356x.dtsi =3D> rk356x-base.dtsi} | 87 ----------- 4 files changed, 215 insertions(+), 130 deletions(-) copy arch/arm64/boot/dts/rockchip/{rk3566.dtsi =3D> rk3566-base.dtsi} (95%) rewrite arch/arm64/boot/dts/rockchip/rk3566.dtsi (87%) rename arch/arm64/boot/dts/rockchip/{rk356x.dtsi =3D> rk356x-base.dtsi} (9= 6%) diff --git a/arch/arm64/boot/dts/rockchip/rk3566.dtsi b/arch/arm64/boot/dts= /rockchip/rk3566-base.dtsi similarity index 95% copy from arch/arm64/boot/dts/rockchip/rk3566.dtsi copy to arch/arm64/boot/dts/rockchip/rk3566-base.dtsi index 6c4b17d27bdc..e56e0b6ba941 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-base.dtsi @@ -1,6 +1,6 @@ // SPDX-License-Identifier: (GPL-2.0+ OR MIT) =20 -#include "rk356x.dtsi" +#include "rk356x-base.dtsi" =20 / { compatible =3D "rockchip,rk3566"; diff --git a/arch/arm64/boot/dts/rockchip/rk3566.dtsi b/arch/arm64/boot/dts= /rockchip/rk3566.dtsi dissimilarity index 87% index 6c4b17d27bdc..3fcca79279f7 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566.dtsi @@ -1,35 +1,107 @@ -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) - -#include "rk356x.dtsi" - -/ { - compatible =3D "rockchip,rk3566"; -}; - -&pipegrf { - compatible =3D "rockchip,rk3566-pipe-grf", "syscon"; -}; - -&power { - power-domain@RK3568_PD_PIPE { - reg =3D ; - clocks =3D <&cru PCLK_PIPE>; - pm_qos =3D <&qos_pcie2x1>, - <&qos_sata1>, - <&qos_sata2>, - <&qos_usb3_0>, - <&qos_usb3_1>; - #power-domain-cells =3D <0>; - }; -}; - -&usb_host0_xhci { - phys =3D <&usb2phy0_otg>; - phy-names =3D "usb2-phy"; - extcon =3D <&usb2phy0>; - maximum-speed =3D "high-speed"; -}; - -&vop { - compatible =3D "rockchip,rk3566-vop"; -}; +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +#include "rk3566-base.dtsi" + +/ { + cpu0_opp_table: opp-table-0 { + compatible =3D "operating-points-v2"; + opp-shared; + + opp-408000000 { + opp-hz =3D /bits/ 64 <408000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-600000000 { + opp-hz =3D /bits/ 64 <600000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-816000000 { + opp-hz =3D /bits/ 64 <816000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + opp-suspend; + }; + + opp-1104000000 { + opp-hz =3D /bits/ 64 <1104000000>; + opp-microvolt =3D <900000 900000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-1416000000 { + opp-hz =3D /bits/ 64 <1416000000>; + opp-microvolt =3D <1025000 1025000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-1608000000 { + opp-hz =3D /bits/ 64 <1608000000>; + opp-microvolt =3D <1100000 1100000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-1800000000 { + opp-hz =3D /bits/ 64 <1800000000>; + opp-microvolt =3D <1150000 1150000 1150000>; + clock-latency-ns =3D <40000>; + }; + }; + + gpu_opp_table: opp-table-1 { + compatible =3D "operating-points-v2"; + + opp-200000000 { + opp-hz =3D /bits/ 64 <200000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-300000000 { + opp-hz =3D /bits/ 64 <300000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-400000000 { + opp-hz =3D /bits/ 64 <400000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-600000000 { + opp-hz =3D /bits/ 64 <600000000>; + opp-microvolt =3D <900000 900000 1000000>; + }; + + opp-700000000 { + opp-hz =3D /bits/ 64 <700000000>; + opp-microvolt =3D <950000 950000 1000000>; + }; + + opp-800000000 { + opp-hz =3D /bits/ 64 <800000000>; + opp-microvolt =3D <1000000 1000000 1000000>; + }; + }; +}; + +&cpu0 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu1 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu2 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu3 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&gpu { + operating-points-v2 =3D <&gpu_opp_table>; +}; diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts= /rockchip/rk3568.dtsi index 5c54898f6ed1..ecaefe208e3e 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi @@ -3,11 +3,99 @@ * Copyright (c) 2021 Rockchip Electronics Co., Ltd. */ =20 -#include "rk356x.dtsi" +#include "rk356x-base.dtsi" =20 / { compatible =3D "rockchip,rk3568"; =20 + cpu0_opp_table: opp-table-0 { + compatible =3D "operating-points-v2"; + opp-shared; + + opp-408000000 { + opp-hz =3D /bits/ 64 <408000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-600000000 { + opp-hz =3D /bits/ 64 <600000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-816000000 { + opp-hz =3D /bits/ 64 <816000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + opp-suspend; + }; + + opp-1104000000 { + opp-hz =3D /bits/ 64 <1104000000>; + opp-microvolt =3D <900000 900000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-1416000000 { + opp-hz =3D /bits/ 64 <1416000000>; + opp-microvolt =3D <1025000 1025000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-1608000000 { + opp-hz =3D /bits/ 64 <1608000000>; + opp-microvolt =3D <1100000 1100000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-1800000000 { + opp-hz =3D /bits/ 64 <1800000000>; + opp-microvolt =3D <1150000 1150000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-1992000000 { + opp-hz =3D /bits/ 64 <1992000000>; + opp-microvolt =3D <1150000 1150000 1150000>; + clock-latency-ns =3D <40000>; + }; + }; + + gpu_opp_table: opp-table-1 { + compatible =3D "operating-points-v2"; + + opp-200000000 { + opp-hz =3D /bits/ 64 <200000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-300000000 { + opp-hz =3D /bits/ 64 <300000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-400000000 { + opp-hz =3D /bits/ 64 <400000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-600000000 { + opp-hz =3D /bits/ 64 <600000000>; + opp-microvolt =3D <900000 900000 1000000>; + }; + + opp-700000000 { + opp-hz =3D /bits/ 64 <700000000>; + opp-microvolt =3D <950000 950000 1000000>; + }; + + opp-800000000 { + opp-hz =3D /bits/ 64 <800000000>; + opp-microvolt =3D <1000000 1000000 1000000>; + }; + }; + sata0: sata@fc000000 { compatible =3D "rockchip,rk3568-dwc-ahci", "snps,dwc-ahci"; reg =3D <0 0xfc000000 0 0x1000>; @@ -269,12 +357,24 @@ combphy0: phy@fe820000 { }; }; =20 -&cpu0_opp_table { - opp-1992000000 { - opp-hz =3D /bits/ 64 <1992000000>; - opp-microvolt =3D <1150000 1150000 1150000>; - clock-latency-ns =3D <40000>; - }; +&cpu0 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu1 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu2 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu3 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&gpu { + operating-points-v2 =3D <&gpu_opp_table>; }; =20 &pipegrf { diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts= /rockchip/rk356x-base.dtsi similarity index 96% rename from arch/arm64/boot/dts/rockchip/rk356x.dtsi rename to arch/arm64/boot/dts/rockchip/rk356x-base.dtsi index 534593f2ed0b..62be06f3b863 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi @@ -56,7 +56,6 @@ cpu0: cpu@0 { clocks =3D <&scmi_clk 0>; #cooling-cells =3D <2>; enable-method =3D "psci"; - operating-points-v2 =3D <&cpu0_opp_table>; i-cache-size =3D <0x8000>; i-cache-line-size =3D <64>; i-cache-sets =3D <128>; @@ -72,7 +71,6 @@ cpu1: cpu@100 { reg =3D <0x0 0x100>; #cooling-cells =3D <2>; enable-method =3D "psci"; - operating-points-v2 =3D <&cpu0_opp_table>; i-cache-size =3D <0x8000>; i-cache-line-size =3D <64>; i-cache-sets =3D <128>; @@ -88,7 +86,6 @@ cpu2: cpu@200 { reg =3D <0x0 0x200>; #cooling-cells =3D <2>; enable-method =3D "psci"; - operating-points-v2 =3D <&cpu0_opp_table>; i-cache-size =3D <0x8000>; i-cache-line-size =3D <64>; i-cache-sets =3D <128>; @@ -104,7 +101,6 @@ cpu3: cpu@300 { reg =3D <0x0 0x300>; #cooling-cells =3D <2>; enable-method =3D "psci"; - operating-points-v2 =3D <&cpu0_opp_table>; i-cache-size =3D <0x8000>; i-cache-line-size =3D <64>; i-cache-sets =3D <128>; @@ -128,54 +124,6 @@ l3_cache: l3-cache { cache-sets =3D <512>; }; =20 - cpu0_opp_table: opp-table-0 { - compatible =3D "operating-points-v2"; - opp-shared; - - opp-408000000 { - opp-hz =3D /bits/ 64 <408000000>; - opp-microvolt =3D <850000 850000 1150000>; - clock-latency-ns =3D <40000>; - }; - - opp-600000000 { - opp-hz =3D /bits/ 64 <600000000>; - opp-microvolt =3D <850000 850000 1150000>; - clock-latency-ns =3D <40000>; - }; - - opp-816000000 { - opp-hz =3D /bits/ 64 <816000000>; - opp-microvolt =3D <850000 850000 1150000>; - clock-latency-ns =3D <40000>; - opp-suspend; - }; - - opp-1104000000 { - opp-hz =3D /bits/ 64 <1104000000>; - opp-microvolt =3D <900000 900000 1150000>; - clock-latency-ns =3D <40000>; - }; - - opp-1416000000 { - opp-hz =3D /bits/ 64 <1416000000>; - opp-microvolt =3D <1025000 1025000 1150000>; - clock-latency-ns =3D <40000>; - }; - - opp-1608000000 { - opp-hz =3D /bits/ 64 <1608000000>; - opp-microvolt =3D <1100000 1100000 1150000>; - clock-latency-ns =3D <40000>; - }; - - opp-1800000000 { - opp-hz =3D /bits/ 64 <1800000000>; - opp-microvolt =3D <1150000 1150000 1150000>; - clock-latency-ns =3D <40000>; - }; - }; - display_subsystem: display-subsystem { compatible =3D "rockchip,display-subsystem"; ports =3D <&vop_out>; @@ -196,40 +144,6 @@ scmi_clk: protocol@14 { }; }; =20 - gpu_opp_table: opp-table-1 { - compatible =3D "operating-points-v2"; - - opp-200000000 { - opp-hz =3D /bits/ 64 <200000000>; - opp-microvolt =3D <850000 850000 1000000>; - }; - - opp-300000000 { - opp-hz =3D /bits/ 64 <300000000>; - opp-microvolt =3D <850000 850000 1000000>; - }; - - opp-400000000 { - opp-hz =3D /bits/ 64 <400000000>; - opp-microvolt =3D <850000 850000 1000000>; - }; - - opp-600000000 { - opp-hz =3D /bits/ 64 <600000000>; - opp-microvolt =3D <900000 900000 1000000>; - }; - - opp-700000000 { - opp-hz =3D /bits/ 64 <700000000>; - opp-microvolt =3D <950000 950000 1000000>; - }; - - opp-800000000 { - opp-hz =3D /bits/ 64 <800000000>; - opp-microvolt =3D <1000000 1000000 1000000>; - }; - }; - hdmi_sound: hdmi-sound { compatible =3D "simple-audio-card"; simple-audio-card,name =3D "HDMI"; @@ -635,7 +549,6 @@ gpu: gpu@fde60000 { clocks =3D <&scmi_clk 1>, <&cru CLK_GPU>; clock-names =3D "gpu", "bus"; #cooling-cells =3D <2>; - operating-points-v2 =3D <&gpu_opp_table>; power-domains =3D <&power RK3568_PD_GPU>; status =3D "disabled"; }; From nobody Sun Nov 24 19:33:22 2024 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 508FC145346; Sat, 2 Nov 2024 03:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730516970; cv=none; b=ZBKSIfqPiCe2P0fEuOrVvliHUQrbz4EeC/3F6UIgeySy08yeFjfqu7WKheYhX/YXlvT/Y4VCQiGL4tx3uGyeKUb6ZNLT9o7ezV1KLy+sgj7LWFYMf8Dg8ytLL5jCV7RYGH+mrAdjS8wrdu6l/ZLsrDW6cMszc7p0oYIhSn4itEI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730516970; c=relaxed/simple; bh=6dh0MAiotjwWwOtFUrbib9gSbbYWZgra3wRkLFxr1dc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cvVS2PeTxxCH9qU7W8+kj+RJqoFsY+1fFa1MN31CdIx7D/GgJegakTyPZ2YtpnUpx/68AYiH8H+sdmE90DNBwlV0hJMFrZ8iYw0V+FpmtHZSbvGGcI+yK9+jXj6n0xiwpUWlnZTpes2tQj0Rp1dCPyoTf6P3+UZ1kgPCNceJzHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=wDXukHfA; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="wDXukHfA" From: Dragan Simic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1730516960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtV456hiHBEE5hovxeMqN3o5TuxazmsArwN78vbz390=; b=wDXukHfA6HNYzvsoYYpXn/JZDhwNKpoHYwofC33ZNLCvrGMaGB47O6P/sxfUIlABRSaKTt uR86CFRY1WKZhzKUoNbXHFyEzxVJNJ9uvEMtk0KrBpGIlfJ6ZAKdMz8V9vCrG5SbNFLlo0 JuEeZKE5b2cUZgA9WQOPCVQzfTYVSEBKoG+XfJMsXikMj86QVM2ggA1c5gBWbyj77u+Lao cRj/82B+DObNtVy+/ayy7WjjChgoEHA5csxo8eOgm/81HVi2kU3eqnTaUuynEjScVpSOlg oZqy32vbuL8I5E8Z5NM6cqg/iHTC/cOaz7neYC91XIf7W76jF+LmfTadjNWnnw== To: linux-rockchip@lists.infradead.org Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, didi.debian@cknow.org, TL Lim , Marek Kraus , Tom Cubie , FUKAUMI Naoki , Nicolas Frattaroli , Jonas Karlman Subject: [PATCH v2 3/3] arm64: dts: rockchip: Add new SoC dtsi for the RK3566T variant Date: Sat, 2 Nov 2024 04:09:01 +0100 Message-Id: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Content-Type: text/plain; charset="utf-8" Add new SoC dtsi file for the RK3566T variant of the Rockchip RK3566 SoC. The difference between the RK3566T variant and the "full-fat" RK3566 variant is in fewer supported CPU and GPU OPPs on the RK3566T, and in the absence of a functional NPU, which we currently don't have to worry about. Examples of the boards based on the RK3566T include the Pine64 Quartz64 Zero SBC, [1] which is yet to be supported, the Radxa ROCK 3C, and the Radxa ZERO 3E/3W SBCs, which are both already supported. Though, Radxa doesn't mention the use of RK3566T officially, but its official SBC specifications do state that the maximum frequency for the Cortex-A55 cores on those SBCs is lower than the "full-fat" RK3566's 1.8 GHz, which makes spotting the presence of the RK3566T SoC variant rather easy. [2][3][4] An additional, helpful cue is that Radxa handles the CPU and GPU OPPs for the RK3566T variant separate= ly in its downstream kernel source. [5] The CPU and GPU OPPs supported on the RK3566T SoC variant are taken from the vendor kernel source, [6] which uses the values of the "opp-supported-hw" O= PP properties to determine which ones are supported on a particular SoC varian= t. The actual values of the "opp-supported-hw" properties make it rather easy to see what OPPs are supported on the RK3566T SoC variant, but that, rather unfortunately, clashes with the maximum frequencies advertised officially for the Cortex-A55 CPU cores on the above-mentioned SBCs. [1][2][3][4] The vendor kernel source indicates that the maximum frequency for the CPU cores is 1.4 GHz, while the SBC specifications state that to be 1.6 GHz. Until that discrepancy is resolved somehow, let's take the safe approach and use the lower maximum frequency for the CPU cores. Update the dts files of the currently supported RK3566T-based boards to use the new SoC dtsi for the RK3566T variant. This actually takes the CPU cores and the GPUs found on these boards out of their earlier overclocks, but it also means that the officially advertised specifications [1][2][3][4] of the highest supported frequencies for the Cortex-A55 CPU cores on these boards may actually be wrong, as already explained above. The correctness of the introduced changes was validated by decompiling and comparing all affected board dtb files before and after these changes. [1] https://wiki.pine64.org/wiki/Quartz64 [2] https://dl.radxa.com/rock3/docs/hw/3c/radxa_rock3c_product_brief.pdf [3] https://dl.radxa.com/zero3/docs/hw/3e/radxa_zero_3e_product_brief.pdf [4] https://dl.radxa.com/zero3/docs/hw/3w/radxa_zero_3w_product_brief.pdf [5] https://github.com/radxa/kernel/commit/2dfd51da472e7ebb5ef0d3db78f90245= 4af826b8 [6] https://raw.githubusercontent.com/rockchip-linux/kernel/f8b9431ee38ed56= 1650be7092ab93f564598daa9/arch/arm64/boot/dts/rockchip/rk3568.dtsi Cc: TL Lim Cc: Marek Kraus Cc: Tom Cubie Cc: FUKAUMI Naoki Helped-by: Nicolas Frattaroli Helped-by: Jonas Karlman Signed-off-by: Dragan Simic --- .../dts/rockchip/rk3566-radxa-zero-3.dtsi | 2 +- .../boot/dts/rockchip/rk3566-rock-3c.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3566t.dtsi | 90 +++++++++++++++++++ 3 files changed, 92 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/boot/dts/rockchip/rk3566t.dtsi diff --git a/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3.dtsi b/arch/a= rm64/boot/dts/rockchip/rk3566-radxa-zero-3.dtsi index de390d92c35e..1ee5d96a46a1 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3566-radxa-zero-3.dtsi @@ -3,7 +3,7 @@ #include #include #include -#include "rk3566.dtsi" +#include "rk3566t.dtsi" =20 / { chosen { diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/b= oot/dts/rockchip/rk3566-rock-3c.dts index f2cc086e5001..9a8f4f774dbc 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts @@ -5,7 +5,7 @@ #include #include #include -#include "rk3566.dtsi" +#include "rk3566t.dtsi" =20 / { model =3D "Radxa ROCK 3C"; diff --git a/arch/arm64/boot/dts/rockchip/rk3566t.dtsi b/arch/arm64/boot/dt= s/rockchip/rk3566t.dtsi new file mode 100644 index 000000000000..cd89bd3b125b --- /dev/null +++ b/arch/arm64/boot/dts/rockchip/rk3566t.dtsi @@ -0,0 +1,90 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +#include "rk3566-base.dtsi" + +/ { + cpu0_opp_table: opp-table-0 { + compatible =3D "operating-points-v2"; + opp-shared; + + opp-408000000 { + opp-hz =3D /bits/ 64 <408000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-600000000 { + opp-hz =3D /bits/ 64 <600000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-816000000 { + opp-hz =3D /bits/ 64 <816000000>; + opp-microvolt =3D <850000 850000 1150000>; + clock-latency-ns =3D <40000>; + opp-suspend; + }; + + opp-1104000000 { + opp-hz =3D /bits/ 64 <1104000000>; + opp-microvolt =3D <900000 900000 1150000>; + clock-latency-ns =3D <40000>; + }; + + opp-1416000000 { + opp-hz =3D /bits/ 64 <1416000000>; + opp-microvolt =3D <1025000 1025000 1150000>; + clock-latency-ns =3D <40000>; + }; + }; + + gpu_opp_table: opp-table-1 { + compatible =3D "operating-points-v2"; + + opp-200000000 { + opp-hz =3D /bits/ 64 <200000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-300000000 { + opp-hz =3D /bits/ 64 <300000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-400000000 { + opp-hz =3D /bits/ 64 <400000000>; + opp-microvolt =3D <850000 850000 1000000>; + }; + + opp-600000000 { + opp-hz =3D /bits/ 64 <600000000>; + opp-microvolt =3D <900000 900000 1000000>; + }; + + opp-700000000 { + opp-hz =3D /bits/ 64 <700000000>; + opp-microvolt =3D <950000 950000 1000000>; + }; + }; +}; + +&cpu0 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu1 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu2 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&cpu3 { + operating-points-v2 =3D <&cpu0_opp_table>; +}; + +&gpu { + operating-points-v2 =3D <&gpu_opp_table>; +};