From nobody Fri Sep 20 01:30:03 2024 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 126C31A0B10 for ; Thu, 4 Jul 2024 06:54:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720076056; cv=none; b=MQflDSpTy2OV2NsngGai07x3O2q7+HL2ygHfoJxJqHYrRX944HmsCVKwCKofqnWCKFpqWuEFkeLDSErwYonmBv0fasAx+AWz8XjM1Z164VLG7nJfdclu06hv6de9BESsI1a40xurDdWjuKoLASaXe8g7k+6gXZHAJHGkKXv4WGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720076056; c=relaxed/simple; bh=TZ8lUJ+EdtbvrUI0mVlJgpMBTSp9t3SM/Ev/g7RgE8Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BiEwq8bvzRMegkJBoJRwUR+v+PxTM9M7FPXz6roq8YQ8aKqDwIyMZwlEQtBN6xluugwVto0fNHl+xaBwFxnJVcIuQXi+TPGTFrKAB8JBH4ldhM0OmmlHqjBzvwbKoBddFL8vg4JEceUPFpZkK5C97AAxFf/ESZhyDyn4+mEtlqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MRBavK1J; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MRBavK1J" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-25da8a19acaso196477fac.2 for ; Wed, 03 Jul 2024 23:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720076054; x=1720680854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=646R/nei8b6Pjif+wq+djuFAbamOolETBvkXxk7jQQ0=; b=MRBavK1JZPakSgqoy4vTWxOX76XkauuQIrDUA5J5mELIglsym0dlX+aRPFKgkblf2J c+13Zp1ZCOvsKmvkENeJRom3KhDFb+7KYetyjJkNH0PZPUysXXu1ImP6NbktVQW4/9EM uttPyuH0dkQ0ccnuNHlBN3EIMJvZaqJWlKH6W+0e2qDq8aqndTpMeYO2Hc9qkSXSrkxo 9BwmVuxOEaKdGUJDWM8r9GvFPS9DCo0L6mPVn/zSDOYKf7shA0bJmqZrXix5aEwJSWF/ WlA8AlUsqru07w3GnlpkjUytmDE96obAKLB01zRPVlcR6Th9dPn3oSYsdres9imwqQOR 3WjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720076054; x=1720680854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=646R/nei8b6Pjif+wq+djuFAbamOolETBvkXxk7jQQ0=; b=HtD99KV+QjlONeRz9byda5d/7Kg/9eUA9UXoddUkm/JClKfd0O58xGtxHmtJntZXza znKHuvXAiVy4DjjBIfpiw9RB7pe+zOJOqhSCeg/Mq8xsCmgVPE3u8anwCPcLJeVazl5h yT0wVAoGDmybBvCRS2PUWePbSomt5Q6OfTU3ngqmrpAetzCVIhLQQdFDnAaivTsgOzED WbzEX0QZIIvdk6R2gq2aULRgpYZdTHun1UiNpr6GFUdA1biowVPJqkiKCah4ZcynBbMx 2bEY4ui451fCrCVEf68r985MOGPWu6ZiGjWnqs+l62ZvCJBqGURM2EXVDAJrmNR/YCJf GlVA== X-Forwarded-Encrypted: i=1; AJvYcCVe1QNiBJebLcyzawgPXUULYq2UzX+pCLxgmlJEt2mJNREr8fIJPwKTIj830PeCgDGLR404riDFiMI5l14exwGp1a9JW3gEj+HPIJSX X-Gm-Message-State: AOJu0YwZ//QFmIiO7aES3Pv9nGhhqd7tZFRZfBpQgA7XPCnUPVJVZAYt dhCEarMhoX89YwEqtQWTTpytXsp1C+qR8g6rGNGzU27oEGNSpFgs/gz9m3nTvts= X-Google-Smtp-Source: AGHT+IGjYh1lTXxVRjoahxmOdu63Hv9FjAowD7DcCHLak2Or+s2oM/b9Q24N9BhJjSId5owDNnm2wQ== X-Received: by 2002:a05:6870:8a0d:b0:254:9ba7:488b with SMTP id 586e51a60fabf-25e2bed77a3mr690546fac.40.1720076054170; Wed, 03 Jul 2024 23:54:14 -0700 (PDT) Received: from localhost ([122.172.82.13]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70802565b3asm11476391b3a.53.2024.07.03.23.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 23:54:13 -0700 (PDT) From: Viresh Kumar To: "Rafael J. Wysocki" , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: [PATCH 1/4] cpufreq: nforce2: Remove empty exit() callback Date: Thu, 4 Jul 2024 12:23:52 +0530 Message-Id: <5f62b0af67ca9ebe2f28a379d807b47a7f54a824.1720075640.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The exit() callback is optional, remove the empty one. Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki --- drivers/cpufreq/cpufreq-nforce2.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/cpufreq/cpufreq-nforce2.c b/drivers/cpufreq/cpufreq-nf= orce2.c index f7a7bcf6f52e..fedad1081973 100644 --- a/drivers/cpufreq/cpufreq-nforce2.c +++ b/drivers/cpufreq/cpufreq-nforce2.c @@ -359,11 +359,6 @@ static int nforce2_cpu_init(struct cpufreq_policy *pol= icy) return 0; } =20 -static int nforce2_cpu_exit(struct cpufreq_policy *policy) -{ - return 0; -} - static struct cpufreq_driver nforce2_driver =3D { .name =3D "nforce2", .flags =3D CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING, @@ -371,7 +366,6 @@ static struct cpufreq_driver nforce2_driver =3D { .target =3D nforce2_target, .get =3D nforce2_get, .init =3D nforce2_cpu_init, - .exit =3D nforce2_cpu_exit, }; =20 #ifdef MODULE --=20 2.31.1.272.g89b43f80a514 From nobody Fri Sep 20 01:30:03 2024 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C8601A255B for ; Thu, 4 Jul 2024 06:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720076059; cv=none; b=V5lo/w7RzQXo9Eeo/risZYlnD6jHWncfcdjXhamIC5lqh8uB8K424fUhwXXeV4T2zGuOZtYP4ZTa/Qxxc7N3QcmHqYg8DKRvrlBIRnGG1ffPaXilCNzxzk8sr+zIgiOGwPxAGpR+Y8zX96pC/ilNVKclUeGoP+0CmEg+4+H8pjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720076059; c=relaxed/simple; bh=rvmbprnMHM6RuihnA3iI8+faiVS/K3OKoDAAx/cTilc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KvCIMrsoSfkr134l/wLYPheqTfAp9Cz0rrmIbH45yntPMLBCfbJi6JN4YhlFAuIvMM/k26kLa1WLVKKo3YNtBVdAPAlMmevgbnA4RB/9u94hSHD7WACjPlQkiXr5cpLFDRzqpmd4BCprn+POMi2sTQzIfxCfGnF88IzeIeOWhdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wX98WCi6; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wX98WCi6" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2c8911c84daso225661a91.3 for ; Wed, 03 Jul 2024 23:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720076057; x=1720680857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dqt2bqXZTu+jtLjs9BXsNPr4gZaqVWVCViCBOTfKtXs=; b=wX98WCi66wvL9ePxOdfS4OnbQRyI/c0FgklI6XAqYMeWTSYJI9wvkDc4tbLNK+A1OI yLMVzJqwrNHu6pGKzqfymgYL0DFOJCFeQ9h7uaGAHUcynbWP+KEzTCBjAgRMpgGF61xV NFvoYL70Af6sfdWub3ODW6qZi5SbkI8bsHalsjjJQKB3GTZ33ABxNpdzGOOdi7Mm2qmM EfbP6hZQh+MpznRkdzuBWBCdt9YvGEZepyUCO3HS+U+qtbXdqj0iuGPhlzVgB0Wwicwo 0I5rYG4E3hVC/2rMVvpYj+Rx9mSjwdZ9Bc5xbKvd7nHidr26Cy2O+YVZv9UjY9KJw3M3 FHag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720076057; x=1720680857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dqt2bqXZTu+jtLjs9BXsNPr4gZaqVWVCViCBOTfKtXs=; b=phRu0aSAHZnompo+7gFKN3m2yd1uqXRLrLKepiBw1yfV78wbl31JQopEgOtV+2pgF5 v+5dkccWX65aH7PEhD+xRYXV3NE68u1599nVlKswCUZmwGp7zeIU03NJzvY7R1n746z9 c9UjgVldONMZSj264NO4aODp6eQG3rtj/hdgCdk/7bxBJQn/xyZg8E6fR0B9mTAHaBRL sKi+HzT770pgwZ10ZnxBbGyE0IoS7oJQ5DezjQrqsPR8Yx2Kh9ULYUj70kG/1Djd1p45 YNWhe1kJpFQZgKWRV+uHoh9qA5fC/6apZzuFIU8G4ycjtN4B6g2/Ft1GsjNIbgd+gD+T bdYg== X-Forwarded-Encrypted: i=1; AJvYcCUK+UO1E8zw5WGPQdO+H8NZCDtE1BSE8Ihs3Vf+YUwqhtwlX7FIQiEYeJZ8xmQvGrU/1YIyc7M2Z5U2quZebZdRvnPztNgAgnWZwgWk X-Gm-Message-State: AOJu0YxYAegkLzRH2VruOEB6oHViNMPEUiP/0pqQHIutH55ZpKqw7igx eISycehlAW9Edw+5IrODIxJeF8LSaPgIMMIHaN/kjMem2pmUCAy5Nv/lRs7A87c= X-Google-Smtp-Source: AGHT+IE6fNB2yrW6RNftQOsnBHViWmextONFWbrX8jTlqq5TSpm4UeSlu7EdPmVmpu6y90sy4DvlNg== X-Received: by 2002:a17:90b:4b04:b0:2c9:6791:a752 with SMTP id 98e67ed59e1d1-2c99c6d0948mr487823a91.44.1720076057304; Wed, 03 Jul 2024 23:54:17 -0700 (PDT) Received: from localhost ([122.172.82.13]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c99a947485sm706021a91.4.2024.07.03.23.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 23:54:16 -0700 (PDT) From: Viresh Kumar To: "Rafael J. Wysocki" , Jiaxun Yang , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] cpufreq: loongson2: Remove empty exit() callback Date: Thu, 4 Jul 2024 12:23:53 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The exit() callback is optional, remove the empty one. Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki Reviewed-by: Huacai Chen --- drivers/cpufreq/loongson2_cpufreq.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson= 2_cpufreq.c index afc59b292153..6a8e97896d38 100644 --- a/drivers/cpufreq/loongson2_cpufreq.c +++ b/drivers/cpufreq/loongson2_cpufreq.c @@ -85,18 +85,12 @@ static int loongson2_cpufreq_cpu_init(struct cpufreq_po= licy *policy) return 0; } =20 -static int loongson2_cpufreq_exit(struct cpufreq_policy *policy) -{ - return 0; -} - static struct cpufreq_driver loongson2_cpufreq_driver =3D { .name =3D "loongson2", .init =3D loongson2_cpufreq_cpu_init, .verify =3D cpufreq_generic_frequency_table_verify, .target_index =3D loongson2_cpufreq_target, .get =3D cpufreq_generic_get, - .exit =3D loongson2_cpufreq_exit, .attr =3D cpufreq_generic_attr, }; =20 --=20 2.31.1.272.g89b43f80a514 From nobody Fri Sep 20 01:30:03 2024 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 685761A2C09 for ; Thu, 4 Jul 2024 06:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720076062; cv=none; b=KVyoF1iohdcn8Fj6gIp2AKxSe4YXakhmIU5Wp8UnxdrC5ZOBWJ+hwTWIMoihTTwOM6dzZaAv8Vpi5+KBNcwWuaZFvQ4LTb7wPEynVMvt5yi8CbSLSVkn5cGW53F5CQT4bh0c107QnQ9YVYX0QGRKwwR8ZJJipYPzNrE02S6LbDA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720076062; c=relaxed/simple; bh=p3g4yOXFGrC+1v+U9pGXCG8xiA5NUBZG/HMlE2fajnY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=te3R338CKFEbLM4tgB5aj96boX4TD5zTLWQSxKUkEN0e+PuZBBEqKXvWep2JJPw8FRkBVB4Por54/CNbAN9sx5QxSa4G1kGv5Gxz7wgCXd76R3WlcEvFmHA3QjUQ028nMdmcM2c26y+M/54kP32IwseAk1N+nPB/CjeWh13tUMo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gEHGGDgX; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gEHGGDgX" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-701b0b0be38so257928b3a.0 for ; Wed, 03 Jul 2024 23:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720076061; x=1720680861; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w6xrWhuQO/F2V4yv6AaPs7D8YwIWXmiw86tXq5hUOyc=; b=gEHGGDgXeN9uRQ5mQw8cfJZXr8+lNd+O50G9phLkH7cV6VUefbWGzTnZzw8SMiPj/h haHP+74LUYBFYjrbSRqTB8X2sevpShKRfg9O4yNS3ljN25xpXnK782YUiyPmQ6LLnWKg JYFmMgwU80Ako40+PKnfCvTLHMKSLMkrSQ6ED1Po4DZ0nTUWJ1RC63/FyCCjn9KapZjU +VmnmJ4AQ3gSbiDe49qtTcS3lk4kEJ4GFaSE61DFYFoAuDBD/XGFmpVk68mD+Jpj/QQW eQ9ZX0avPtt0/XVYuCrXmOmJxJDqae++fub3eo6mWONPs+FArLda2GZ7BkZchegEuUcw nrUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720076061; x=1720680861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w6xrWhuQO/F2V4yv6AaPs7D8YwIWXmiw86tXq5hUOyc=; b=JQ59BBmSHjd89hpHpn01iH0X6WmUT7qhRtfU2o/bExWutA1D1MfIk/Yqt+w2l8/CCy ai6SmmE4wOD+8Va4dswHsgv2551TmxEPeRw70kqHx49ubpk/uMhkFaXr05y6xdcWPkSZ Xh8eUjJ1Lr/XtOSZ6tMAmVaqySt42i5nG/mxj9ElesR/0Ou8DW9NAta9wt7BgIL7uBbJ 8gFexxzF+UfwLiYJ9BbujGiwjiBH1nCRIlczlGtyjZBHaNjhbDn1J/KF5/A3lyiXIIvS 3RmQNodlMDLQvDX0VoLMCZ2D3sC89xr4z2XmtqQmYME/hMEapX1kd5O/X9vJbd+4g8uh ETZw== X-Forwarded-Encrypted: i=1; AJvYcCUflfnQy7tHVu74umOrGmTPNXezxoXGSDMbL0jzfEtApyHS6H2WwGLfRLdO79qGAnwrwEKZlBrerjeJxP0/PFEDsiRp/ZusSvlz9FJG X-Gm-Message-State: AOJu0YylduIj+YJwFrIMkYUv7dkZGLiJi+xaWZPu5qwpLW1KHef0AwLc QC84WBJQUjj332PCqYPmsKes3t2UL6D94iEdWpLHQfvNxfcOg3NlFzdAZcFdhWg= X-Google-Smtp-Source: AGHT+IGnPnbN5hoDog45bSFXx983A7/UJMbl0GjEfYUbedd3XUIpEPJwHqdYZ6FsK+nT7KO4hY8SRw== X-Received: by 2002:a05:6a00:1784:b0:708:11f:d151 with SMTP id d2e1a72fcca58-70b009695cbmr851143b3a.16.1720076060590; Wed, 03 Jul 2024 23:54:20 -0700 (PDT) Received: from localhost ([122.172.82.13]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b03a9d996sm245894b3a.96.2024.07.03.23.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 23:54:20 -0700 (PDT) From: Viresh Kumar To: "Rafael J. Wysocki" , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: [PATCH 3/4] cpufreq: pcc: Remove empty exit() callback Date: Thu, 4 Jul 2024 12:23:54 +0530 Message-Id: <02fbaba9bfee5814b2446a747785746fc242e92a.1720075640.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The exit() callback is optional, remove the empty one. Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki --- drivers/cpufreq/pcc-cpufreq.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c index 6f8b5ea7aeae..771efbf51a48 100644 --- a/drivers/cpufreq/pcc-cpufreq.c +++ b/drivers/cpufreq/pcc-cpufreq.c @@ -562,18 +562,12 @@ static int pcc_cpufreq_cpu_init(struct cpufreq_policy= *policy) return result; } =20 -static int pcc_cpufreq_cpu_exit(struct cpufreq_policy *policy) -{ - return 0; -} - static struct cpufreq_driver pcc_cpufreq_driver =3D { .flags =3D CPUFREQ_CONST_LOOPS, .get =3D pcc_get_freq, .verify =3D pcc_cpufreq_verify, .target =3D pcc_cpufreq_target, .init =3D pcc_cpufreq_cpu_init, - .exit =3D pcc_cpufreq_cpu_exit, .name =3D "pcc-cpufreq", }; =20 --=20 2.31.1.272.g89b43f80a514 From nobody Fri Sep 20 01:30:03 2024 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7893D1A0B0B for ; Thu, 4 Jul 2024 06:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720076071; cv=none; b=XALGmFOEZcithDJe+kRI6xaYs6FcqDpoO/pQRAYQw4BjpxYc2TE4UYzCBgUNx0pn0rp8kQ2OU7sOkxGQHfQmUmxi9LildrnKRRccvRhxBQKZyOSDI9CK/08ascKBNNYj8G7qLOZijeIZmaRGIDzRt0N/fAYzjTTLYIwq1HweJ9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720076071; c=relaxed/simple; bh=UgJntJJItwRPbmZ3drnB27BIpgrdHOlMLVcS1e3gkOQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VMc6V0uMC7Me+cBl21A+ytQK5iTxB+8vT3k1GjDNwCwL7WP8MuSpo+bszq32Y0Bwj7sSigXd+kNq2hoblYFrQ10kw+4n+9yzJjMzYTW6g99b+S9vB8/ayYC1nD03QOTPpu+VVv5nRkmSFfkyoKSxxsLyoeZ4Jnuj5GYnP5N0Y5s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ja+0u+nl; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ja+0u+nl" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-70683d96d0eso228140b3a.0 for ; Wed, 03 Jul 2024 23:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720076069; x=1720680869; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cX8buroefB8E6dbxaZ62ekQqAJPRBxFIJid/1WsNJSU=; b=ja+0u+nlxDsYombBfEPbouRtoiU0KvmNPOH5rlBbBi/jVT2aJ7rNz4ZpVS4rkIOFAs DO/+MkkUUKoWjn3k4JAf+I9DUp19VGDFJYEIJxJOLoFXBPcYR6YC3OnwCBG3kfEvNkn3 Zmt7N0ucAMqbjZPsF5zdMRkWxkI3b7HXu7hdjDsN8QlYEZucFyZRyWHFiDQboOQrMlvT 9JEy+sfQjYIgGz2An+9ksfGE9H+qjdO61XYidpOsDclZH9QM1qqzD36aQ02dSYXopRDD 4DgwJb1Pn9sjlpjdmfZu1+prs4BbIkJgZ5o9kuJl8tiwysAdIkT81L6HkZ+4MBUxSVIb HBcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720076069; x=1720680869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cX8buroefB8E6dbxaZ62ekQqAJPRBxFIJid/1WsNJSU=; b=eg5VjFSB5x4ztqEyOejDM+XBh7WDesm9YvkaoZIalYe1g7D2UCtf1AVcMH1jHlhpIM fS4TSFec5HyI8YLLd3orpBkTPY01CfO2BPCP9/O/c2dj6vMw09QJ7En6590sXfgW9oV3 nWj6H8hf9O9ITDH+EZJZtghNSujorVbz78X+7ByEmWioBLca1e3NcrRnB8p6HS8vN6Mc L18gpC9ljq/UW3sECpeCx2YcfRs1yrMkMV9GH+ipJTaYvt0Ykh7Zw13ApTnqWxitVSz0 RT3hLpjCZzxEz4QX2uRrNQ2GnsTkCV/eI/elWc+gXwjU9i6X7Z0quk/FvmVNR7engUs2 ePnA== X-Forwarded-Encrypted: i=1; AJvYcCXE1q3Fnru2wKk/bSsRLn88X3TSfgDqWwTHVVVgBYJy6XEn4UbOstQYBPxx6417MCqUbwMeybp1yVv4F3Wt+/GmMlG6o+NRkIrtXGm7 X-Gm-Message-State: AOJu0YygHkSrk03loEuxmSMcpFJH3gISizMDT38rjQLUYGX1vCvcwJVj 9txVhNoKKPMHWLmNv+CTHGoAg193X80O922b+wQ1shevLE5jdQIBHWzfnTdacKA= X-Google-Smtp-Source: AGHT+IHb/ish9+ohH5ub0e29qxY/FTfbV+gjRAhLMOTo0HY1LhCudPsfofUDHf6hNsZZN9GoTmmEZQ== X-Received: by 2002:a05:6a00:2d0c:b0:70a:f0f1:480f with SMTP id d2e1a72fcca58-70b0092ada1mr888903b3a.3.1720076068495; Wed, 03 Jul 2024 23:54:28 -0700 (PDT) Received: from localhost ([122.172.82.13]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70803ecf878sm11466999b3a.135.2024.07.03.23.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 23:54:27 -0700 (PDT) From: Viresh Kumar To: "Rafael J. Wysocki" , Viresh Kumar , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , Hector Martin , Sven Peter , Alyssa Rosenzweig , Markus Mayer , Broadcom internal kernel review list , Srinivas Pandruvada , Len Brown , Kevin Hilman , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Sudeep Holla , Cristian Marussi , Thierry Reding , Jonathan Hunter , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-pm@vger.kernel.org, Vincent Guittot , Lizhe , linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void Date: Thu, 4 Jul 2024 12:23:55 +0530 Message-Id: <3f73fda736818128558b61ad5fe2bed5dce3ddc4.1720075640.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lizhe The cpufreq core doesn't check the return type of the exit() callback and there is not much the core can do on failures at that point. Just drop the returned value and make it return void. Signed-off-by: Lizhe [ Viresh: Reworked the patches to fix all missing changes together. ] Signed-off-by: Viresh Kumar Acked-by: Kevin Hilman Acked-by: Mario Limonciello #=20 Acked-by: Rafael J. Wysocki Acked-by: Sudeep Holla Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Florian Fainelli --- drivers/cpufreq/acpi-cpufreq.c | 4 +--- drivers/cpufreq/amd-pstate.c | 7 ++----- drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- drivers/cpufreq/bmips-cpufreq.c | 4 +--- drivers/cpufreq/cppc_cpufreq.c | 3 +-- drivers/cpufreq/cpufreq-dt.c | 3 +-- drivers/cpufreq/e_powersaver.c | 3 +-- drivers/cpufreq/intel_pstate.c | 8 +++----- drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- drivers/cpufreq/mediatek-cpufreq.c | 4 +--- drivers/cpufreq/omap-cpufreq.c | 3 +-- drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- drivers/cpufreq/powernow-k6.c | 5 ++--- drivers/cpufreq/powernow-k7.c | 3 +-- drivers/cpufreq/powernow-k8.c | 6 ++---- drivers/cpufreq/powernv-cpufreq.c | 4 +--- drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- drivers/cpufreq/qoriq-cpufreq.c | 4 +--- drivers/cpufreq/scmi-cpufreq.c | 4 +--- drivers/cpufreq/scpi-cpufreq.c | 4 +--- drivers/cpufreq/sh-cpufreq.c | 4 +--- drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- drivers/cpufreq/speedstep-centrino.c | 10 +++------- drivers/cpufreq/tegra194-cpufreq.c | 4 +--- drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- include/linux/cpufreq.h | 2 +- 28 files changed, 37 insertions(+), 84 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index fa2664f9f259..a8ca625a98b8 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -906,7 +906,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy = *policy) return result; } =20 -static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct acpi_cpufreq_data *data =3D policy->driver_data; =20 @@ -919,8 +919,6 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy = *policy) free_cpumask_var(data->freqdomain_cpus); kfree(policy->freq_table); kfree(data); - - return 0; } =20 static int acpi_cpufreq_resume(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 80eaa58f1405..c1f48a0d69b6 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1090,7 +1090,7 @@ static int amd_pstate_cpu_init(struct cpufreq_policy = *policy) return ret; } =20 -static int amd_pstate_cpu_exit(struct cpufreq_policy *policy) +static void amd_pstate_cpu_exit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata =3D policy->driver_data; =20 @@ -1098,8 +1098,6 @@ static int amd_pstate_cpu_exit(struct cpufreq_policy = *policy) freq_qos_remove_request(&cpudata->req[0]); policy->fast_switch_possible =3D false; kfree(cpudata); - - return 0; } =20 static int amd_pstate_cpu_resume(struct cpufreq_policy *policy) @@ -1542,7 +1540,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_pol= icy *policy) return ret; } =20 -static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) +static void amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata =3D policy->driver_data; =20 @@ -1552,7 +1550,6 @@ static int amd_pstate_epp_cpu_exit(struct cpufreq_pol= icy *policy) } =20 pr_debug("CPU %d exiting\n", policy->cpu); - return 0; } =20 static void amd_pstate_epp_update_limit(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-so= c-cpufreq.c index 021f423705e1..af34c22fa273 100644 --- a/drivers/cpufreq/apple-soc-cpufreq.c +++ b/drivers/cpufreq/apple-soc-cpufreq.c @@ -305,7 +305,7 @@ static int apple_soc_cpufreq_init(struct cpufreq_policy= *policy) return ret; } =20 -static int apple_soc_cpufreq_exit(struct cpufreq_policy *policy) +static void apple_soc_cpufreq_exit(struct cpufreq_policy *policy) { struct apple_cpu_priv *priv =3D policy->driver_data; =20 @@ -313,8 +313,6 @@ static int apple_soc_cpufreq_exit(struct cpufreq_policy= *policy) dev_pm_opp_remove_all_dynamic(priv->cpu_dev); iounmap(priv->reg_base); kfree(priv); - - return 0; } =20 static struct cpufreq_driver apple_soc_cpufreq_driver =3D { diff --git a/drivers/cpufreq/bmips-cpufreq.c b/drivers/cpufreq/bmips-cpufre= q.c index 39221a9a187a..17a4c174553d 100644 --- a/drivers/cpufreq/bmips-cpufreq.c +++ b/drivers/cpufreq/bmips-cpufreq.c @@ -121,11 +121,9 @@ static int bmips_cpufreq_target_index(struct cpufreq_p= olicy *policy, return 0; } =20 -static int bmips_cpufreq_exit(struct cpufreq_policy *policy) +static void bmips_cpufreq_exit(struct cpufreq_policy *policy) { kfree(policy->freq_table); - - return 0; } =20 static int bmips_cpufreq_init(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index 15f1d41920a3..17aeb3785446 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -688,7 +688,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy = *policy) return ret; } =20 -static int cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct cppc_cpudata *cpu_data =3D policy->driver_data; struct cppc_perf_caps *caps =3D &cpu_data->perf_caps; @@ -705,7 +705,6 @@ static int cppc_cpufreq_cpu_exit(struct cpufreq_policy = *policy) caps->lowest_perf, cpu, ret); =20 cppc_cpufreq_put_cpu_data(policy); - return 0; } =20 static inline u64 get_delta(u64 t1, u64 t0) diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index 907e22632fda..6532c4d71338 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -157,10 +157,9 @@ static int cpufreq_offline(struct cpufreq_policy *poli= cy) return 0; } =20 -static int cpufreq_exit(struct cpufreq_policy *policy) +static void cpufreq_exit(struct cpufreq_policy *policy) { clk_put(policy->clk); - return 0; } =20 static struct cpufreq_driver dt_cpufreq_driver =3D { diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c index ab93bce8ae77..6e958b09e1b5 100644 --- a/drivers/cpufreq/e_powersaver.c +++ b/drivers/cpufreq/e_powersaver.c @@ -360,14 +360,13 @@ static int eps_cpu_init(struct cpufreq_policy *policy) return 0; } =20 -static int eps_cpu_exit(struct cpufreq_policy *policy) +static void eps_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu =3D policy->cpu; =20 /* Bye */ kfree(eps_cpu[cpu]); eps_cpu[cpu] =3D NULL; - return 0; } =20 static struct cpufreq_driver eps_driver =3D { diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 25389e43c392..392a8000b238 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -2715,13 +2715,11 @@ static int intel_pstate_cpu_offline(struct cpufreq_= policy *policy) return intel_cpufreq_cpu_offline(policy); } =20 -static int intel_pstate_cpu_exit(struct cpufreq_policy *policy) +static void intel_pstate_cpu_exit(struct cpufreq_policy *policy) { pr_debug("CPU %d exiting\n", policy->cpu); =20 policy->fast_switch_possible =3D false; - - return 0; } =20 static int __intel_pstate_cpu_init(struct cpufreq_policy *policy) @@ -3052,7 +3050,7 @@ static int intel_cpufreq_cpu_init(struct cpufreq_poli= cy *policy) return ret; } =20 -static int intel_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void intel_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct freq_qos_request *req; =20 @@ -3062,7 +3060,7 @@ static int intel_cpufreq_cpu_exit(struct cpufreq_poli= cy *policy) freq_qos_remove_request(req); kfree(req); =20 - return intel_pstate_cpu_exit(policy); + intel_pstate_cpu_exit(policy); } =20 static int intel_cpufreq_suspend(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/mediatek-cpufreq-hw.c b/drivers/cpufreq/mediat= ek-cpufreq-hw.c index 8d097dcddda4..8925e096d5b9 100644 --- a/drivers/cpufreq/mediatek-cpufreq-hw.c +++ b/drivers/cpufreq/mediatek-cpufreq-hw.c @@ -260,7 +260,7 @@ static int mtk_cpufreq_hw_cpu_init(struct cpufreq_polic= y *policy) return 0; } =20 -static int mtk_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) +static void mtk_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) { struct mtk_cpufreq_data *data =3D policy->driver_data; struct resource *res =3D data->res; @@ -270,8 +270,6 @@ static int mtk_cpufreq_hw_cpu_exit(struct cpufreq_polic= y *policy) writel_relaxed(0x0, data->reg_bases[REG_FREQ_ENABLE]); iounmap(base); release_mem_region(res->start, resource_size(res)); - - return 0; } =20 static void mtk_cpufreq_register_em(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-= cpufreq.c index 518606adf14e..102cfaa3b7e5 100644 --- a/drivers/cpufreq/mediatek-cpufreq.c +++ b/drivers/cpufreq/mediatek-cpufreq.c @@ -599,13 +599,11 @@ static int mtk_cpufreq_init(struct cpufreq_policy *po= licy) return 0; } =20 -static int mtk_cpufreq_exit(struct cpufreq_policy *policy) +static void mtk_cpufreq_exit(struct cpufreq_policy *policy) { struct mtk_cpu_dvfs_info *info =3D policy->driver_data; =20 dev_pm_opp_free_cpufreq_table(info->cpu_dev, &policy->freq_table); - - return 0; } =20 static struct cpufreq_driver mtk_cpufreq_driver =3D { diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c index 895690856665..3458d5cc9b7f 100644 --- a/drivers/cpufreq/omap-cpufreq.c +++ b/drivers/cpufreq/omap-cpufreq.c @@ -135,11 +135,10 @@ static int omap_cpu_init(struct cpufreq_policy *polic= y) return 0; } =20 -static int omap_cpu_exit(struct cpufreq_policy *policy) +static void omap_cpu_exit(struct cpufreq_policy *policy) { freq_table_free(); clk_put(policy->clk); - return 0; } =20 static struct cpufreq_driver omap_driver =3D { diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpuf= req.c index 039a66bbe1be..ee925b53b6b9 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c @@ -204,21 +204,19 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy= *policy) return err; } =20 -static int pas_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void pas_cpufreq_cpu_exit(struct cpufreq_policy *policy) { /* * We don't support CPU hotplug. Don't unmap after the system * has already made it to a running state. */ if (system_state >=3D SYSTEM_RUNNING) - return 0; + return; =20 if (sdcasr_mapbase) iounmap(sdcasr_mapbase); if (sdcpwr_mapbase) iounmap(sdcpwr_mapbase); - - return 0; } =20 static int pas_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/powernow-k6.c b/drivers/cpufreq/powernow-k6.c index 41eefef95d87..f0a4a6c31204 100644 --- a/drivers/cpufreq/powernow-k6.c +++ b/drivers/cpufreq/powernow-k6.c @@ -219,7 +219,7 @@ static int powernow_k6_cpu_init(struct cpufreq_policy *= policy) } =20 =20 -static int powernow_k6_cpu_exit(struct cpufreq_policy *policy) +static void powernow_k6_cpu_exit(struct cpufreq_policy *policy) { unsigned int i; =20 @@ -234,10 +234,9 @@ static int powernow_k6_cpu_exit(struct cpufreq_policy = *policy) cpufreq_freq_transition_begin(policy, &freqs); powernow_k6_target(policy, i); cpufreq_freq_transition_end(policy, &freqs, 0); - break; + return; } } - return 0; } =20 static unsigned int powernow_k6_get(unsigned int cpu) diff --git a/drivers/cpufreq/powernow-k7.c b/drivers/cpufreq/powernow-k7.c index 5d515fc34836..4271446c8725 100644 --- a/drivers/cpufreq/powernow-k7.c +++ b/drivers/cpufreq/powernow-k7.c @@ -644,7 +644,7 @@ static int powernow_cpu_init(struct cpufreq_policy *pol= icy) return 0; } =20 -static int powernow_cpu_exit(struct cpufreq_policy *policy) +static void powernow_cpu_exit(struct cpufreq_policy *policy) { #ifdef CONFIG_X86_POWERNOW_K7_ACPI if (acpi_processor_perf) { @@ -655,7 +655,6 @@ static int powernow_cpu_exit(struct cpufreq_policy *pol= icy) #endif =20 kfree(powernow_table); - return 0; } =20 static struct cpufreq_driver powernow_driver =3D { diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index b10f7a1b77f1..a01170f7d01c 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -1089,13 +1089,13 @@ static int powernowk8_cpu_init(struct cpufreq_polic= y *pol) return -ENODEV; } =20 -static int powernowk8_cpu_exit(struct cpufreq_policy *pol) +static void powernowk8_cpu_exit(struct cpufreq_policy *pol) { struct powernow_k8_data *data =3D per_cpu(powernow_data, pol->cpu); int cpu; =20 if (!data) - return -EINVAL; + return; =20 powernow_k8_cpu_exit_acpi(data); =20 @@ -1104,8 +1104,6 @@ static int powernowk8_cpu_exit(struct cpufreq_policy = *pol) /* pol->cpus will be empty here, use related_cpus instead. */ for_each_cpu(cpu, pol->related_cpus) per_cpu(powernow_data, cpu) =3D NULL; - - return 0; } =20 static void query_values_on_cpu(void *_err) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cp= ufreq.c index fddbd1ea1635..50c62929f7ca 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -874,7 +874,7 @@ static int powernv_cpufreq_cpu_init(struct cpufreq_poli= cy *policy) return 0; } =20 -static int powernv_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void powernv_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct powernv_smp_call_data freq_data; struct global_pstate_info *gpstates =3D policy->driver_data; @@ -886,8 +886,6 @@ static int powernv_cpufreq_cpu_exit(struct cpufreq_poli= cy *policy) del_timer_sync(&gpstates->timer); =20 kfree(policy->driver_data); - - return 0; } =20 static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb, diff --git a/drivers/cpufreq/ppc_cbe_cpufreq.c b/drivers/cpufreq/ppc_cbe_cp= ufreq.c index 88afc49941b7..5ee4c7bfdcc5 100644 --- a/drivers/cpufreq/ppc_cbe_cpufreq.c +++ b/drivers/cpufreq/ppc_cbe_cpufreq.c @@ -113,10 +113,9 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy = *policy) return 0; } =20 -static int cbe_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void cbe_cpufreq_cpu_exit(struct cpufreq_policy *policy) { cbe_cpufreq_pmi_policy_exit(policy); - return 0; } =20 static int cbe_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufr= eq-hw.c index ec8df5496a0c..370fe6a0104b 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -573,7 +573,7 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_poli= cy *policy) return qcom_cpufreq_hw_lmh_init(policy, index); } =20 -static int qcom_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) +static void qcom_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) { struct device *cpu_dev =3D get_cpu_device(policy->cpu); struct qcom_cpufreq_data *data =3D policy->driver_data; @@ -583,8 +583,6 @@ static int qcom_cpufreq_hw_cpu_exit(struct cpufreq_poli= cy *policy) qcom_cpufreq_hw_lmh_exit(data); kfree(policy->freq_table); kfree(data); - - return 0; } =20 static void qcom_cpufreq_ready(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufre= q.c index 0aecaecbb0e6..3519bf34d397 100644 --- a/drivers/cpufreq/qoriq-cpufreq.c +++ b/drivers/cpufreq/qoriq-cpufreq.c @@ -225,7 +225,7 @@ static int qoriq_cpufreq_cpu_init(struct cpufreq_policy= *policy) return -ENODEV; } =20 -static int qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct cpu_data *data =3D policy->driver_data; =20 @@ -233,8 +233,6 @@ static int qoriq_cpufreq_cpu_exit(struct cpufreq_policy= *policy) kfree(data->table); kfree(data); policy->driver_data =3D NULL; - - return 0; } =20 static int qoriq_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 3b4f6bfb2f4c..bf5f17f0dfb1 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -308,7 +308,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *pol= icy) return ret; } =20 -static int scmi_cpufreq_exit(struct cpufreq_policy *policy) +static void scmi_cpufreq_exit(struct cpufreq_policy *policy) { struct scmi_data *priv =3D policy->driver_data; =20 @@ -316,8 +316,6 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *pol= icy) dev_pm_opp_remove_all_dynamic(priv->cpu_dev); free_cpumask_var(priv->opp_shared_cpus); kfree(priv); - - return 0; } =20 static void scmi_cpufreq_register_em(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c index d33be56983ed..8d73e6e8be2a 100644 --- a/drivers/cpufreq/scpi-cpufreq.c +++ b/drivers/cpufreq/scpi-cpufreq.c @@ -167,7 +167,7 @@ static int scpi_cpufreq_init(struct cpufreq_policy *pol= icy) return ret; } =20 -static int scpi_cpufreq_exit(struct cpufreq_policy *policy) +static void scpi_cpufreq_exit(struct cpufreq_policy *policy) { struct scpi_data *priv =3D policy->driver_data; =20 @@ -175,8 +175,6 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *pol= icy) dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); dev_pm_opp_remove_all_dynamic(priv->cpu_dev); kfree(priv); - - return 0; } =20 static struct cpufreq_driver scpi_cpufreq_driver =3D { diff --git a/drivers/cpufreq/sh-cpufreq.c b/drivers/cpufreq/sh-cpufreq.c index b8704232c27b..aa74036d0420 100644 --- a/drivers/cpufreq/sh-cpufreq.c +++ b/drivers/cpufreq/sh-cpufreq.c @@ -135,14 +135,12 @@ static int sh_cpufreq_cpu_init(struct cpufreq_policy = *policy) return 0; } =20 -static int sh_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void sh_cpufreq_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu =3D policy->cpu; struct clk *cpuclk =3D &per_cpu(sh_cpuclk, cpu); =20 clk_put(cpuclk); - - return 0; } =20 static struct cpufreq_driver sh_cpufreq_driver =3D { diff --git a/drivers/cpufreq/sparc-us2e-cpufreq.c b/drivers/cpufreq/sparc-u= s2e-cpufreq.c index 2783d3d55fce..8a0cd5312a59 100644 --- a/drivers/cpufreq/sparc-us2e-cpufreq.c +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c @@ -296,10 +296,9 @@ static int us2e_freq_cpu_init(struct cpufreq_policy *p= olicy) return 0; } =20 -static int us2e_freq_cpu_exit(struct cpufreq_policy *policy) +static void us2e_freq_cpu_exit(struct cpufreq_policy *policy) { us2e_freq_target(policy, 0); - return 0; } =20 static struct cpufreq_driver cpufreq_us2e_driver =3D { diff --git a/drivers/cpufreq/sparc-us3-cpufreq.c b/drivers/cpufreq/sparc-us= 3-cpufreq.c index 6c3657679a88..b50f9d13e6d2 100644 --- a/drivers/cpufreq/sparc-us3-cpufreq.c +++ b/drivers/cpufreq/sparc-us3-cpufreq.c @@ -140,10 +140,9 @@ static int us3_freq_cpu_init(struct cpufreq_policy *po= licy) return 0; } =20 -static int us3_freq_cpu_exit(struct cpufreq_policy *policy) +static void us3_freq_cpu_exit(struct cpufreq_policy *policy) { us3_freq_target(policy, 0); - return 0; } =20 static struct cpufreq_driver cpufreq_us3_driver =3D { diff --git a/drivers/cpufreq/speedstep-centrino.c b/drivers/cpufreq/speedst= ep-centrino.c index ddd6f53bfd2a..3fafedb983b5 100644 --- a/drivers/cpufreq/speedstep-centrino.c +++ b/drivers/cpufreq/speedstep-centrino.c @@ -400,16 +400,12 @@ static int centrino_cpu_init(struct cpufreq_policy *p= olicy) return 0; } =20 -static int centrino_cpu_exit(struct cpufreq_policy *policy) +static void centrino_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu =3D policy->cpu; =20 - if (!per_cpu(centrino_model, cpu)) - return -ENODEV; - - per_cpu(centrino_model, cpu) =3D NULL; - - return 0; + if (per_cpu(centrino_model, cpu)) + per_cpu(centrino_model, cpu) =3D NULL; } =20 /** diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-= cpufreq.c index 59865ea455a8..07ea7ed61b68 100644 --- a/drivers/cpufreq/tegra194-cpufreq.c +++ b/drivers/cpufreq/tegra194-cpufreq.c @@ -551,14 +551,12 @@ static int tegra194_cpufreq_offline(struct cpufreq_po= licy *policy) return 0; } =20 -static int tegra194_cpufreq_exit(struct cpufreq_policy *policy) +static void tegra194_cpufreq_exit(struct cpufreq_policy *policy) { struct device *cpu_dev =3D get_cpu_device(policy->cpu); =20 dev_pm_opp_remove_all_dynamic(cpu_dev); dev_pm_opp_of_cpumask_remove_table(policy->related_cpus); - - return 0; } =20 static int tegra194_cpufreq_set_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/vexpress-spc-cpufreq.c b/drivers/cpufreq/vexpr= ess-spc-cpufreq.c index 9ac4ea50b874..3fadf536c429 100644 --- a/drivers/cpufreq/vexpress-spc-cpufreq.c +++ b/drivers/cpufreq/vexpress-spc-cpufreq.c @@ -447,7 +447,7 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *p= olicy) return 0; } =20 -static int ve_spc_cpufreq_exit(struct cpufreq_policy *policy) +static void ve_spc_cpufreq_exit(struct cpufreq_policy *policy) { struct device *cpu_dev; =20 @@ -455,11 +455,10 @@ static int ve_spc_cpufreq_exit(struct cpufreq_policy = *policy) if (!cpu_dev) { pr_err("%s: failed to get cpu%d device\n", __func__, policy->cpu); - return -ENODEV; + return; } =20 put_cluster_clk_and_freq_table(cpu_dev, policy->related_cpus); - return 0; } =20 static struct cpufreq_driver ve_spc_cpufreq_driver =3D { diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 6f57de7de433..d4d2f4d1d7cb 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -396,7 +396,7 @@ struct cpufreq_driver { =20 int (*online)(struct cpufreq_policy *policy); int (*offline)(struct cpufreq_policy *policy); - int (*exit)(struct cpufreq_policy *policy); + void (*exit)(struct cpufreq_policy *policy); int (*suspend)(struct cpufreq_policy *policy); int (*resume)(struct cpufreq_policy *policy); =20 --=20 2.31.1.272.g89b43f80a514