From nobody Sat May 18 12:12:32 2024 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2081.outbound.protection.outlook.com [40.107.93.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E6954645; Tue, 23 Apr 2024 07:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859130; cv=fail; b=kNa1j/BJ1f/xcZkxH2LKq8YGmnBRS0DiovTPyxhdd603lrxZFKHxTjnVU55+a28+CXw5pLjc2TSrd8VGXXeYgAYHhb6uwLWndsRmSZGDbvrAsK7AuB3ru8oS+OyeebjP1mm17hBNQ4li8J9kgvWRgvgFu8+UVbpVNIftqHZVexc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859130; c=relaxed/simple; bh=7qVpJHN69a+YM7VR5sMzFULPFNuxFuQfsn4vU1YeY4c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iupX7H06aL4D/zvlzMl3E80MuAEeRQ3aXJnGdzMqPAGZL4vQpgrSl2qzrJ9oq/AuMwMeoGkKXMmZ3akXRi5nMHcD05Ny22Qq7BG1hWp8xYREMnOW2XvGO9FDmWnzJ51XvtQpTQS35UOmumoUA+5UN68c7ex3/gkuNZ2/DW+k+YA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=SHMubgXB; arc=fail smtp.client-ip=40.107.93.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="SHMubgXB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F81n6tzL0IAksGZ8JOrEYUkwa5mJTIfpWIxQHuH2a9J9ey0CX7/S0mlOA5j9otXi4r52PT7ejYKjRbOXmXRJcjr2P08Gmjln5XnqvGSvAYaht8DLBaAhK6o1WsddlFIkEuJSzXEOgpVXPd9lhRLCwpC6vXCzYNnmhYJTwn03dDeV7EKyvd7wuKj4djZoha8P7o7MXWv3Jlm4pArRmbdZB4l+4d2/9WwdyanN7GsfgZJ1HKoUvl60DGNhDxnJQcYCsOcolARMZgPfFnao3G73j3TwJF8MzsZJBjjxYGxxvy+Xqn68bVPbwgsubuvOUe1etJSSfptyqm5p9w1kiFCQAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7HXeCwDP1hShOrQ2Q2cbuT0Gosp0Fwy3kjqWF577x4k=; b=QGoUCcB6Kw9SCdRybkUgOFK72c96oGDgpk/jyP3DYJllQLXFfCE6oBoOlqJX55ptruoC4xZq5wAIS8jZyIVTER6irUH9YZB5wO3OI8xY8lvPjzmrCkMw07/OaGnSuRmOqT4L7vfO9pcqZ+HLDtNTJwqrPjopd4AVU5e6djZ7s8oMxH1u8Dzy5OU56CBE0sbd6rNn4vORURu8SgUlaWlmwR9n2JrOmU67pOmmysD52RQXSgyq3x4aymRZwvEQUHUfto7E8vcMZC66ZskWN+PeBjQDiME6gc6GCEy8xLt+gOdYjCo/ZOD152NL3WqU4QKKG2gZeNAfVxcuiN4FM7nUxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7HXeCwDP1hShOrQ2Q2cbuT0Gosp0Fwy3kjqWF577x4k=; b=SHMubgXBFyEpem8R78tbMVBPAQ+839spSuCM4NcrapO66nSysSrXLjRuStXIMIW82UEPmCcY4p+PFI2o5Z5A48UZs5lk2YJD2hqRvtlfZ23VDB1XzoE1q5gYtbtOCgYDH1yZk4Jrr/pt5hPLYNNBYbItDLyqvQvvQE4u/I6gIbc= Received: from CH2PR03CA0020.namprd03.prod.outlook.com (2603:10b6:610:59::30) by SJ2PR12MB8829.namprd12.prod.outlook.com (2603:10b6:a03:4d0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 07:58:45 +0000 Received: from CH2PEPF0000013E.namprd02.prod.outlook.com (2603:10b6:610:59:cafe::a0) by CH2PR03CA0020.outlook.office365.com (2603:10b6:610:59::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.34 via Frontend Transport; Tue, 23 Apr 2024 07:58:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF0000013E.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Tue, 23 Apr 2024 07:58:45 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 02:58:41 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v11 1/8] cpufreq: amd-pstate: Document *_limit_* fields in struct amd_cpudata Date: Tue, 23 Apr 2024 15:58:17 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013E:EE_|SJ2PR12MB8829:EE_ X-MS-Office365-Filtering-Correlation-Id: e361bc8b-6b1d-4f79-8f28-08dc636b336b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZlcU6X9+Do5cQ7NGC/t52bmrC22Mup1MbcbaXNdcYFU+RX2MP0y+R7UnmfEq?= =?us-ascii?Q?AnEO5S5IthynmEFGTzvmSB5sbbdMFVprysc3NbRXXnTDDDJMikusadZeRrr4?= =?us-ascii?Q?zEWmkZz9VInGNq2365KtIn/x3OTDtwsB8YQdxCwNMT3TiMtlNTrzNsjRXqKI?= =?us-ascii?Q?0fKdKkOo5kvh8s4WdUzw0XJjr26Lckza9qbnEQ8k7QVoTsWH+0ASsVyruRmS?= =?us-ascii?Q?tjmaip9QZ/zQPQWdLL4d6QBIYRodMVdeQWs3xsJHbIazsKBvGv8OCA7P9Gur?= =?us-ascii?Q?Ei9AoamWcW0GCdCKfm0X/5x3WNohcR9/RYTKJuZSrT7oeuTceUHilzA6x5Zk?= =?us-ascii?Q?DS+F66f/AB/aK1zW7iMcecrjFZAapUwi30ZE0Wnw319a5o/JD1/Cxo7ieKMy?= =?us-ascii?Q?LfaR7Bs/i1PtIVzBYg6i01vLODXtlGMdxYzE2EsJidBUs7vBCroKeBVEsKCv?= =?us-ascii?Q?/OyOARef/sUWSCViYLaiEYR9gzh/4eCypRVuvI1ZQMfLxcYOL1jZ8BbMGz44?= =?us-ascii?Q?9NHhrpG18h7qEXHsmgzwwLEzHtgy9JAtKhVdn3I4TCk8zZjBhOuKylQtHe+H?= =?us-ascii?Q?JGBoJgqcDVTkIsNq7FQqO9KaF6YnGwtMnUZjbDmVsOdzOKA0y82FcsQWB0i1?= =?us-ascii?Q?rd4FZz6IiLZqgoC9y8FCGBVe8jp/MzhfcQuuiaxRi0jRcFgjitHplbI1qprn?= =?us-ascii?Q?59mR8ojzGXApkJJ3GqAZsxws0sZoOKMsmTxkuLuETim9iqqgkpWojrWZrSQ/?= =?us-ascii?Q?876jKBCiFA3FvkmO4uggbRzHC9N5lBHtaLodhgOOR5jK9TJYfWiRYMG02p5p?= =?us-ascii?Q?hOJnLIacfSMN37UXqnAXbxIllYm2K8VmfHPBwLZAJFUoSv+J/+7KyUPMkyql?= =?us-ascii?Q?gNJmjxRqXN7bX0zQkWDaSOaigSu7bQFjtndjOcFqUyOItiiX2od4B7rWc4ap?= =?us-ascii?Q?RvIPCCa8130b11HYZbawlLl/GrRnxuPVVfAC2Mv+6U/CJGc2t+FCN/iKP13E?= =?us-ascii?Q?lvZtQFJjlTG8ihg9ms5Hvcbg0c31OTA8z64b/cUQXMvMuPxPG7NENGgJUMXn?= =?us-ascii?Q?KLEsLUzpfrMxDenBlKUV7nkR3xB2ecEl/Cl1/U7qXQT46qHjOSRNKqSSne8E?= =?us-ascii?Q?I2p8Pjhc/XDM46hd5wmfL18UpT4WGgsJSz4yItFmsHPLuC8miCQ49Vlw9Cbj?= =?us-ascii?Q?QqkaFIBaMBzlnqSEiHHmCMsSIh+mujFJkf+qfVywLOOB3BNxBTHMfw1VcTg7?= =?us-ascii?Q?eVEsGRQi+hzdk7TCcZq0vl2ii7AQQaC+8XV9JpAzOmKbeHJ263rbw1QuzRG/?= =?us-ascii?Q?/3mAHF5rdl1JFDfDsmzUY6WmrefxqsGXpHvBgJ5tsX1oGqP3EuQnVF2WJizn?= =?us-ascii?Q?qtWzDYZb5WpO9MOYmZWlX6giUX3g?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:58:45.4480 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e361bc8b-6b1d-4f79-8f28-08dc636b336b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8829 Content-Type: text/plain; charset="utf-8" From: "Gautham R. Shenoy" The four fields of struct cpudata namely min_limit_perf, max_limit_perf, min_limit_freq, max_limit_freq introduced in the commit febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and scaling_max_freq update") are currently undocumented Add comments describing these fields Acked-by: Huang Rui Fixes: febab20caeba("cpufreq/amd-pstate: Fix scaling_min_freq and scaling_m= ax_freq update") Reviewed-by: Li Meng Tested-by: Dhananjay Ugwekar Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- include/linux/amd-pstate.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index d21838835abd..212f377d615b 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -49,6 +49,10 @@ struct amd_aperf_mperf { * @lowest_perf: the absolute lowest performance level of the processor * @prefcore_ranking: the preferred core ranking, the higher value indicat= es a higher * priority. + * @min_limit_perf: Cached value of the perf corresponding to policy->min + * @max_limit_perf: Cached value of the perf corresponding to policy->max + * @min_limit_freq: Cached value of policy->min + * @max_limit_freq: Cached value of policy->max * @max_freq: the frequency that mapped to highest_perf * @min_freq: the frequency that mapped to lowest_perf * @nominal_freq: the frequency that mapped to nominal_perf --=20 2.34.1 From nobody Sat May 18 12:12:32 2024 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2088.outbound.protection.outlook.com [40.107.96.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74FA2548E0; Tue, 23 Apr 2024 07:58:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.96.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859133; cv=fail; b=BpYrJmOxjJ8vha7kAgdgCNjjeEE1RXy+hpwbq3UIezp10L8RGIbE++Jpma7XWWq4+IERUmQLsUibeKQhgD3IuO0RGBvSTlN+gJLHtBiLpw7bwaQ2LcEM0sJfYGw8GM0rQn73lZVx1QuhWc/L1aPqfJvyIZ4v7dfJOZTk40OEFdU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859133; c=relaxed/simple; bh=XND/4DrRvnxXSuCo9VLOeYfmAdUCI9xOj/tgHRyLNFg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=doJQHXmDg63cvo0KMJT8vWOgl5MDubBfzz4YpFFWBjfHEBrDWvkhvOuhxP2WEN16O7AGfnwdqlZRauueyq9RsZLMuumVBjuEqPo6zQfNM8Ut80wfI97WToKcTlYY80Vs7nMhrL2phjJoAnNAaxLOah6nrztdiLs5YJxwkdkrKvc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=nqE9nwLU; arc=fail smtp.client-ip=40.107.96.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="nqE9nwLU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dyYjJiyROw6LFCowhidW6MSmcLWB83s9EgbWJBaUJ7hFk+MjzjVDmjNeMrmOZ8jTReYGjkB6cgPcrG05HUFKiX2mlqBwZsgFz9XJlvln6hYxtO7aCKej0tRPYIqcEO3IRqXqRFCW2Q1yK6GijnYhNWscneWKmQ67k4bU0F+vLIES60NR75rnJ0l9xqzZqYBjENPo8wv1PwfwhLQ/poi8hIR0pswSd0Exklc2BFjyf+9Xk4F9k1CHKYgCAD6oZpk+jD106z2Bme3Ec3EO1MDOevDwZV3XdpGoy1W9w3hAQ9QTuPB27S+Sq74w841uoCZLPjqEZurQJY47nPLxi/xnhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rACBeBy1UTX6WaxVN1vDPYnPhWdoyKM4IaNY38r6jZg=; b=UFdqYgbGx4LNkgMzT67BHXlyTS5/oJXrcttNktw0D24OjS+OHIriuwO/KW+uNgVXJe1bSJfWx11kNDuwhL+ToT3P9rIVfPObFoYZbZBcHYxorxO2wN4zXLKtmoO1xR2ltyFET2HeFRQbzqagy4p16OoFGU+xLRtOL389YbV8Ptjyt9ULHNyU8EAMg1wOMSfoIcyPe7XlfzjyzbURtzwY6f5atJr0VI0eyqDgtzEefvYJlbhRZy/14t16MBrpwUouUcEuaic4IQod/beJ9uyzcltPmXT/lk8ZVxE3GU9LgKAnv7w1WtGUlSrWK5bxcAFQ1SURKJpq43EHwA4NqS/EKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rACBeBy1UTX6WaxVN1vDPYnPhWdoyKM4IaNY38r6jZg=; b=nqE9nwLUCKuDvb7Z0079nz9jvl8nkhPC/mQowEftodLtj1Ug9OIff14Tuipks5dycEKKOxevbIAl1z7qShUFgqoGTEJZqnRqI6xs/h4q6zvGARn1FoPKo6oElNev90mXAOAtSIwstiG6deZaPPfgLNi/vQUG+vGHbkoeW2YAd28= Received: from CH2PR03CA0004.namprd03.prod.outlook.com (2603:10b6:610:59::14) by DM4PR12MB5961.namprd12.prod.outlook.com (2603:10b6:8:68::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 07:58:49 +0000 Received: from CH2PEPF0000013E.namprd02.prod.outlook.com (2603:10b6:610:59:cafe::d) by CH2PR03CA0004.outlook.office365.com (2603:10b6:610:59::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.34 via Frontend Transport; Tue, 23 Apr 2024 07:58:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF0000013E.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Tue, 23 Apr 2024 07:58:48 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 02:58:45 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v11 2/8] cpufreq: amd-pstate: Document the units for freq variables in amd_cpudata Date: Tue, 23 Apr 2024 15:58:18 +0800 Message-ID: <72cbda63659fbe05878320c70f09e4a2b4d1b27a.1713858800.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013E:EE_|DM4PR12MB5961:EE_ X-MS-Office365-Filtering-Correlation-Id: c9ae4301-4f99-4eac-2a1f-08dc636b356c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0+/v1FKMh6wZMovf6R8LkJTaEdXFLfuAJ2Y5fKzG3RYDY2qLy8LpU2qAtyAr?= =?us-ascii?Q?V+UuLifYHFiwav+mhtjbevE5i1S2iY6kEq7YSmwamPWHTiQYrVDoYXOrQ+bO?= =?us-ascii?Q?gBiUnlOBNxUIX8fewGmBuITllsiZY2q87Rj6b3DLHpz/+6+toCxzFmR0QS7J?= =?us-ascii?Q?wO5dmxgJGAiy2CVNUmSTEgnuC03cWF7R1tChRYay3IWYzR6LtogJ6TZhK/yA?= =?us-ascii?Q?gSsxygi647Ii5uTVubH74jD1k8RnS7aH7vm8jp0PA/vv0kCFRsPqzsBBRqDh?= =?us-ascii?Q?1Lw/6UGrcY5bUf7CVA5fi3UDI/Bj8v2FtRydBiPgUWoMBv8f+5zIplW5WgMf?= =?us-ascii?Q?WsobnMKEPhCshlUB74nHSmMqH0DHNwzuB5Qwv//hHJPnTg0d7+2wmj3QAFix?= =?us-ascii?Q?VMBtrtW6NbjDhCZLaFSy9y0EkVzEC5zbHH6xKJU9OYDyxuqcfo1SXcsfFE16?= =?us-ascii?Q?l0BQcp0hH3jFsArOwy8D3dOOmq6z9mUhobfLdgdTJcSiYjUvZF/cRr7lQLuh?= =?us-ascii?Q?zyuVaXLdN+1VeST1i5ISiovzJS3eE/7ExZM0mCgBiWvptaw6U/LDrI9OqB2L?= =?us-ascii?Q?HC1+08noLChrTWfz0PNsmEYXt2LX0oJ7IUECt3r9pNBmsEy+TxOEhybcdLjo?= =?us-ascii?Q?MCoCKwcRabTQTIWpVO4bSv6ynsG5AQWmFxtyzY+pHjORQ00JmHW2n0RrIAEr?= =?us-ascii?Q?IlNprI6KlD+MDCI8RA+mul7bbN7seYjYASBY1mogNT5lkApK3QPKrEqBcNdy?= =?us-ascii?Q?ibUSY9rl4mhtpk0zXIEzqU8HA5CMmrXv2TWKnEtMeXY2/a3HYNtB57tc6h9a?= =?us-ascii?Q?iyqer8JuJDikZpcTvetnh/99xAIrkH+4VBd44zYCqCOLun+cwQVlTTLyGrBW?= =?us-ascii?Q?a0JTfGo7mejeDuXvAaJkwl9SVd1f5aG1k3S7G0nr8f4m081jv7sl1KAEHqMM?= =?us-ascii?Q?+oEfX7jupIXKkWl45WsexAdG10dN3mIgAdM3hCBBCPUKtX52/Fx+bdSs5+ZA?= =?us-ascii?Q?MNrPzHrcuaNIoNdRqtOl3PdCc8PUrJk391lC/fd7xYhFOzlVmZ2mMfwMZTyp?= =?us-ascii?Q?ct9HTNfyFflh2oRrHjvqSon4T4D6pOixl7V4SsK64ApAB0WOeAWBavzI8gon?= =?us-ascii?Q?ZLKqvecPT4qchgP5AliHI8zzX17qFtu10JJuBfHerZFyAhG/UEhNalnAvivv?= =?us-ascii?Q?M50J97zVzn/xQ1jlPf1RZpzIPbf+R6W5A1ngrZxA49TfO73dALrg/EkzkJ0T?= =?us-ascii?Q?pYof3kjksgY11426oqN0yoBaNz/xgLkeGvnx44MbDibjnTUWxKJtk+OVs7jM?= =?us-ascii?Q?NMmDZcqjR1lIn+c7vUj75a+qgIxIZxJNBAv98JZVI4qa6f9TFnOg2myL62G9?= =?us-ascii?Q?Kqby4z3llVB22a6cYk0+VtIY0nQ5?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(376005)(36860700004)(82310400014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:58:48.8074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9ae4301-4f99-4eac-2a1f-08dc636b356c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5961 Content-Type: text/plain; charset="utf-8" From: "Gautham R. Shenoy" The min_limit_freq, max_limit_freq, min_freq, max_freq, nominal_freq and the lowest_nominal_freq members of struct cpudata store the frequency value in khz to be consistent with the cpufreq core. Update the comment to document this. Reviewed-by: Li Meng Tested-by: Dhananjay Ugwekar Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan Acked-by: Huang Rui --- include/linux/amd-pstate.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index 212f377d615b..ab7e82533718 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -51,15 +51,15 @@ struct amd_aperf_mperf { * priority. * @min_limit_perf: Cached value of the perf corresponding to policy->min * @max_limit_perf: Cached value of the perf corresponding to policy->max - * @min_limit_freq: Cached value of policy->min - * @max_limit_freq: Cached value of policy->max - * @max_freq: the frequency that mapped to highest_perf - * @min_freq: the frequency that mapped to lowest_perf - * @nominal_freq: the frequency that mapped to nominal_perf - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_p= erf + * @min_limit_freq: Cached value of policy->min (in khz) + * @max_limit_freq: Cached value of policy->max (in khz) + * @max_freq: the frequency (in khz) that mapped to highest_perf + * @min_freq: the frequency (in khz) that mapped to lowest_perf + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_no= nlinear_perf * @cur: Difference of Aperf/Mperf/tsc count between last and current samp= le * @prev: Last Aperf/Mperf/tsc count value read from register - * @freq: current cpu frequency value + * @freq: current cpu frequency value (in khz) * @boost_supported: check whether the Processor or SBIOS supports boost m= ode * @hw_prefcore: check whether HW supports preferred core featue. * Only when hw_prefcore and early prefcore param are true, --=20 2.34.1 From nobody Sat May 18 12:12:32 2024 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2080.outbound.protection.outlook.com [40.107.93.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11E1654BFE; Tue, 23 Apr 2024 07:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859137; cv=fail; b=UZEW+CqShpuys/X5aUyDOxctOxuBa3e+PML48EhDgvFEy1bxwaSfmIF8PMuO1WRos3MwJabgPP0vJuijqFRBKlhBUbb2585nCEvGrDaD7KugYBQ75N3tvq8B/bnouO4QHrBhrji28Tx2zaLdlWrD1swqW4zIAo8frqSgdYcAoRs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859137; c=relaxed/simple; bh=LtDBJFN9mt4Ghp8tKeZFaX6vbLB5XW99XgCcPx3/nXk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=U6UUfb3VOXqkUIncJCJhS5e1DaVTwv4Gkcdou1D45rdt75r+zNIXxKNozmyx3k/bRtlk6ILEszCgXHIot+6kCrNecqVj0It0tMF3ALCY7pSffsGEJ80IRelCKsY5nTUx2VtMTbrAa97tSQhKDEOTARq9VBYALSeav3JvSRcL0XM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NHQAuteh; arc=fail smtp.client-ip=40.107.93.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NHQAuteh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JkpkdW7XKabDg6RGSr7R+sshsD7/0J+jbbzNtOQQfaTSI2Vl9CVK19fhPGdobLDA++6sTIN13rawUwOfVOuOVO6zE7Lsw5a3+75PQZt5P2G4hDgGenHbYYMyMQLhhauvSFzJ8lcioqgH9qF8w5gTcdxEWCha/Yjihf8XL/3FUzfEj1bWhnJddsWIH9ZTmto06zxn5vq1sk7a80mUTE/zsXCEhdUpWZzH345qyvjHT65piyQ6lNtIdP7edv4bjlU58gEZR2r1d4v5IOXhnnk95BjC2UmpeIi5pri7ODWqzs3khcmmlEPa0dMM7B6f0p+FG3pzfBzecCdwPPgaWvFtaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qMBDLDmclriccSsNVlKFKkaYu1FJp1/xBHkw9sBTVmM=; b=jLYoyRFPiOJ8SwGm2j0cqhTSaujjJ8iBOB+CaNOIDVnhmKngaDL0Qfk+k8DcUcxbOUCD3klVKXz+wy0po3qE6gpohocgrbezROeQLgdehSlRJjB+QMx+T8Trr7tvUKw0O6TOVqAdwDD0PnnFUqjSlw/y05HE7uyz2SEPxk646yfbxKU4Sr2lbePsVd/mIqjh5sTniCzIG7OzNuc2mYauK2maKytiZ+amKUCdBouQIDSpGJZbtmWY53Dq6B4igUdgCPJbdvEp2bR+tITzs1bO/IV6o4OsvyYjFEHtvTwEAsdSJz4if2G2OXVCGLZkOSV8QmSu+vTDExX+dB8pZoHSKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qMBDLDmclriccSsNVlKFKkaYu1FJp1/xBHkw9sBTVmM=; b=NHQAutehy3mlWr2uJkbTZQtjl3cGjJI1r/S3+i3eahsYHQ9RuSl7eHr84rW3nswc+1yqagamZLtBUYQ/+asBmItMyBQn78UgzUI0Ffk0Ydvr5ObSjKmnef1DpduDoeg0SdZNyFUR74QQuIVfBEGMJojQ+GOyM4Pxe7wLRfjAyuc= Received: from CH0PR03CA0237.namprd03.prod.outlook.com (2603:10b6:610:e7::32) by IA0PR12MB7723.namprd12.prod.outlook.com (2603:10b6:208:431::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 07:58:52 +0000 Received: from CH2PEPF0000013C.namprd02.prod.outlook.com (2603:10b6:610:e7:cafe::9a) by CH0PR03CA0237.outlook.office365.com (2603:10b6:610:e7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.31 via Frontend Transport; Tue, 23 Apr 2024 07:58:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF0000013C.mail.protection.outlook.com (10.167.244.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Tue, 23 Apr 2024 07:58:52 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 02:58:48 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v11 3/8] cpufreq: amd-pstate: Unify computation of {max,min,nominal,lowest_nonlinear}_freq Date: Tue, 23 Apr 2024 15:58:19 +0800 Message-ID: <0a8c3ba26e0631e47189c22bc9b9596554461360.1713858800.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013C:EE_|IA0PR12MB7723:EE_ X-MS-Office365-Filtering-Correlation-Id: 0655a21d-57af-4c4f-a866-08dc636b37ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?09tHmLwpWrNjIa/0+vxL+cemZ6TI5i4444zZtAxYOKuLsTda2xvmaBBnJ/qM?= =?us-ascii?Q?Bbj2/IZOGJTUmlB2Bsumx439GQ3wREuHKeUB5FdB9n/BxORDGTWtzhh+Do1l?= =?us-ascii?Q?ZHGz+vK5PhrRWSJFSJqHAzJeeiXjtB5jPU87/F7xv1ZFTNyY2oiPtCmxq8bd?= =?us-ascii?Q?r3LmDAud3hNawMSwiKiBA92i7//wYFG+F0QwyJ9nvqOBQEIwTJZee1CwJgg1?= =?us-ascii?Q?wf6w9vtoXKGK09XVK6FhiC4xGSYsse1L8YqOd5WLK5dHjJRzFB/l+RScBynU?= =?us-ascii?Q?R8eVqUiuQOAGHb6XeCIwXGHql/8RuOSap56vjVnh9X/nHoTQFIKwb1xiv/7Q?= =?us-ascii?Q?GIOITqXbZezruN1T1MHTarPlaB4w6MbpP393wpHywhpjwt2THZgSBW3Ysgv1?= =?us-ascii?Q?FxuFO0L05IzlGSpSdJqnPRjXHiWIVZCswoIfAZXPIvtvGEaggp85F10Agd80?= =?us-ascii?Q?fdXKMT1z0TWfWrIZQ0x75IV+nVH0YoNySvPUamLKnVCLXanPsXZEUM6Yix1W?= =?us-ascii?Q?9CONnW90PMJyC1nyl1z2CsBAkugN95fd9YIL1PBa8nHmVgHTjgAF1MG+CcG3?= =?us-ascii?Q?5pne2bfd2wR5qjCWMyGzPLAM5TXNquTl6asPqBgk7u53uVelNk9YDnfq7nj7?= =?us-ascii?Q?80IFRZS76k5ZbzkKiq6syD7+7IzdSR0XKf/zqEmn2DBxRJxaWVhrsLHjBIDT?= =?us-ascii?Q?CEut4n5MpImPMsajwix5HEdIjY8jTApWbfBGB9OZmaieAWKdfx/uMQMkfXk3?= =?us-ascii?Q?tveFJiR4nBkBsBxGk+Z4YU42nPEDRkCHv3Bt+x3JJJ/06Lm2MpgzlT4wGisg?= =?us-ascii?Q?ZZz69mMblLIXm/xAgV6Vtkd2w8hTMr0M1+0SedmtS6uTNQxvwaFLw0Oh7WGi?= =?us-ascii?Q?2ypJJTOOIgKJ8KQ0Rxyj7YWPy8HZ6G9tCsA/66j0Bt9dMP5SXj9hqTBbyw/+?= =?us-ascii?Q?13bCZTDNfKAwGTbVIoweKIU3Rf+bC3Y4bQlXkkOz4XfbOzcqTKJRaDFmf+Ym?= =?us-ascii?Q?XBShWgcgq6blEhlOoMKKYIRlVP/350JVi/hvTJWzqgYD+utsFeI/e3YpKi+N?= =?us-ascii?Q?+tLNiSEx4szdMSHzxAR/pql9C4ZWHAT3ARaL/YVqpvw3PWEp0BNY6jBQyCZ2?= =?us-ascii?Q?aRdvtdjh2mphS+F4PC97ds6n0IupqwKNipUlAzqJuxQuFfA3MlwwvlyIscdp?= =?us-ascii?Q?pA07soOE3xTSvUTBoqV6BctuBo99f5qwku3DbJbmbVj9D6BVqEUsLR9JIz+m?= =?us-ascii?Q?5VNtGVTDRihROohDSLjYGCWTUe2wZ6xVM52T0r1nxIcM6H5F1/jJvChxTZJb?= =?us-ascii?Q?rgizGeyfDhYpei5g1sa8/gLqr4DFQ+JYZHyZhoVGSp642dWXvrIrLKW8JF9p?= =?us-ascii?Q?utz5OUyC0T5oDjHeDBsocDImzLdc?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(376005)(1800799015)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:58:52.6773 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0655a21d-57af-4c4f-a866-08dc636b37ba X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7723 Content-Type: text/plain; charset="utf-8" Currently the amd_get_{min, max, nominal, lowest_nonlinear}_freq() helpers computes the values of min_freq, max_freq, nominal_freq and lowest_nominal_freq respectively afresh from cppc_get_perf_caps(). This is not necessary as there are fields in cpudata to cache these values. To simplify this, add a single helper function named amd_pstate_init_freq() which computes all these frequencies at once, and caches it in cpudata. Use the cached values everywhere else in the code. Acked-by: Huang Rui Reviewed-by: Li Meng Tested-by: Dhananjay Ugwekar Co-developed-by: Gautham R. Shenoy Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 126 ++++++++++++++++------------------- 1 file changed, 59 insertions(+), 67 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 2015c9fcc3c9..891fad6f90e1 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -606,74 +606,22 @@ static void amd_pstate_adjust_perf(unsigned int cpu, =20 static int amd_get_min_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - - int ret =3D cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - /* Switch to khz */ - return cppc_perf.lowest_freq * 1000; + return READ_ONCE(cpudata->min_freq); } =20 static int amd_get_max_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - u32 max_perf, max_freq, nominal_freq, nominal_perf; - u64 boost_ratio; - - int ret =3D cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - nominal_freq =3D cppc_perf.nominal_freq; - nominal_perf =3D READ_ONCE(cpudata->nominal_perf); - max_perf =3D READ_ONCE(cpudata->highest_perf); - - boost_ratio =3D div_u64(max_perf << SCHED_CAPACITY_SHIFT, - nominal_perf); - - max_freq =3D nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT; - - /* Switch to khz */ - return max_freq * 1000; + return READ_ONCE(cpudata->max_freq); } =20 static int amd_get_nominal_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - - int ret =3D cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - /* Switch to khz */ - return cppc_perf.nominal_freq * 1000; + return READ_ONCE(cpudata->nominal_freq); } =20 static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) { - struct cppc_perf_caps cppc_perf; - u32 lowest_nonlinear_freq, lowest_nonlinear_perf, - nominal_freq, nominal_perf; - u64 lowest_nonlinear_ratio; - - int ret =3D cppc_get_perf_caps(cpudata->cpu, &cppc_perf); - if (ret) - return ret; - - nominal_freq =3D cppc_perf.nominal_freq; - nominal_perf =3D READ_ONCE(cpudata->nominal_perf); - - lowest_nonlinear_perf =3D cppc_perf.lowest_nonlinear_perf; - - lowest_nonlinear_ratio =3D div_u64(lowest_nonlinear_perf << SCHED_CAPACIT= Y_SHIFT, - nominal_perf); - - lowest_nonlinear_freq =3D nominal_freq * lowest_nonlinear_ratio >> SCHED_= CAPACITY_SHIFT; - - /* Switch to khz */ - return lowest_nonlinear_freq * 1000; + return READ_ONCE(cpudata->lowest_nonlinear_freq); } =20 static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) @@ -828,6 +776,53 @@ static void amd_pstate_update_limits(unsigned int cpu) mutex_unlock(&amd_pstate_driver_lock); } =20 +/** + * amd_pstate_init_freq: Initialize the max_freq, min_freq, + * nominal_freq and lowest_nonlinear_freq for + * the @cpudata object. + * + * Requires: highest_perf, lowest_perf, nominal_perf and + * lowest_nonlinear_perf members of @cpudata to be + * initialized. + * + * Returns 0 on success, non-zero value on failure. + */ +static int amd_pstate_init_freq(struct amd_cpudata *cpudata) +{ + int ret; + u32 min_freq; + u32 highest_perf, max_freq; + u32 nominal_perf, nominal_freq; + u32 lowest_nonlinear_perf, lowest_nonlinear_freq; + u32 boost_ratio, lowest_nonlinear_ratio; + struct cppc_perf_caps cppc_perf; + + + ret =3D cppc_get_perf_caps(cpudata->cpu, &cppc_perf); + if (ret) + return ret; + + min_freq =3D cppc_perf.lowest_freq * 1000; + nominal_freq =3D cppc_perf.nominal_freq; + nominal_perf =3D READ_ONCE(cpudata->nominal_perf); + + highest_perf =3D READ_ONCE(cpudata->highest_perf); + boost_ratio =3D div_u64(highest_perf << SCHED_CAPACITY_SHIFT, nominal_per= f); + max_freq =3D (nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT) * 1000; + + lowest_nonlinear_perf =3D READ_ONCE(cpudata->lowest_nonlinear_perf); + lowest_nonlinear_ratio =3D div_u64(lowest_nonlinear_perf << SCHED_CAPACIT= Y_SHIFT, + nominal_perf); + lowest_nonlinear_freq =3D (nominal_freq * lowest_nonlinear_ratio >> SCHED= _CAPACITY_SHIFT) * 1000; + + WRITE_ONCE(cpudata->min_freq, min_freq); + WRITE_ONCE(cpudata->lowest_nonlinear_freq, lowest_nonlinear_freq); + WRITE_ONCE(cpudata->nominal_freq, nominal_freq); + WRITE_ONCE(cpudata->max_freq, max_freq); + + return 0; +} + static int amd_pstate_cpu_init(struct cpufreq_policy *policy) { int min_freq, max_freq, nominal_freq, lowest_nonlinear_freq, ret; @@ -855,6 +850,10 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *= policy) if (ret) goto free_cpudata1; =20 + ret =3D amd_pstate_init_freq(cpudata); + if (ret) + goto free_cpudata1; + min_freq =3D amd_get_min_freq(cpudata); max_freq =3D amd_get_max_freq(cpudata); nominal_freq =3D amd_get_nominal_freq(cpudata); @@ -896,13 +895,8 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *= policy) goto free_cpudata2; } =20 - /* Initial processor data capability frequencies */ - cpudata->max_freq =3D max_freq; - cpudata->min_freq =3D min_freq; cpudata->max_limit_freq =3D max_freq; cpudata->min_limit_freq =3D min_freq; - cpudata->nominal_freq =3D nominal_freq; - cpudata->lowest_nonlinear_freq =3D lowest_nonlinear_freq; =20 policy->driver_data =3D cpudata; =20 @@ -1317,6 +1311,10 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_po= licy *policy) if (ret) goto free_cpudata1; =20 + ret =3D amd_pstate_init_freq(cpudata); + if (ret) + goto free_cpudata1; + min_freq =3D amd_get_min_freq(cpudata); max_freq =3D amd_get_max_freq(cpudata); nominal_freq =3D amd_get_nominal_freq(cpudata); @@ -1333,12 +1331,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_po= licy *policy) /* It will be updated by governor */ policy->cur =3D policy->cpuinfo.min_freq; =20 - /* Initial processor data capability frequencies */ - cpudata->max_freq =3D max_freq; - cpudata->min_freq =3D min_freq; - cpudata->nominal_freq =3D nominal_freq; - cpudata->lowest_nonlinear_freq =3D lowest_nonlinear_freq; - policy->driver_data =3D cpudata; =20 cpudata->epp_cached =3D amd_pstate_get_epp(cpudata, 0); --=20 2.34.1 From nobody Sat May 18 12:12:32 2024 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2050.outbound.protection.outlook.com [40.107.212.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DD4955C29; Tue, 23 Apr 2024 07:58:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859141; cv=fail; b=aswbWNizotscGzP6yk6bRuk1KswLqM4aKmsCj6ZqnNl2LcQmShIc8eKheKpAg1zmpO5BDzfGP3r80avhI2kBQRYDtsUVCEmxLZHUH2VCzD2TBlH7Bh7dJzopd/tP3c0x9jPDdkoHIbmQawZDRdNj+Hj/10mT5ZsIKN5M+RVPL+w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859141; c=relaxed/simple; bh=GOEylsnGtnQnASO5apgdHql6QhHuHp5kmw/FAiy/xSc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P1PnmujNtgOy6fWyajnVb/zt+4vFQ8u4n+WXemjrTiPE9/YJeSN6mL49W1OB2EbzSTUYU181mAtFeJY9dzQOielKTq36JEUbCwK0aPERkl4SOBsi44gyCZw1X6ck+wEI3rRbNixA5nVb9Wk8LDAbfCY5Qip302GMiCdoBlSfXS0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fnk/9LoD; arc=fail smtp.client-ip=40.107.212.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fnk/9LoD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dMt/6t6kqH5tX2JpP58tJUZcOjJBJugvBBihqgJaI/flhxpaRptSMLzBUXfCpNs9liTVRCbvU6FelB1Z5jmIiqwL6C/EBij8ZpXvkAc1t1Gb4HSdcs5isMUQeenJFuHJNZNoj6fXMGC/wwzGlU08vljAZ5+UD4bX/OEgUosd7GVkUrmhMTQGUcILgLnKnbY/nfqAhX2QjpJJJU9utt/krPZWEvMrs07iGd3+/iU3gCZ/oQj6E+ACqmnDqmP99OYcqhyvAa4xa16minspqx1jUPhtDatfj0YRX1HZFV+hePw+HelWQsb/3nnIsnjeo/MWddQhSSJxcCu6BA5ofXXUKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWFXVGCIXk3NQuI7JxRsnYQ5oZtrEZj2oetcQrcIfN0=; b=LPTp5xgfdXJs/2lspMUKlt81lWh/xivZZ/35d8EK/HE+CbE3YMI9NpKvpbDT15ISv5/vEA3n/3WeIeXraIlUOtPxcqE/3kNnPa/kezkK05wXq/IBA7aNMc2lRmE0WIRswZkrxFQjP2koNdx7s9Q8S3MGG7h0fjPTg6qd8Uj/6FBLBvW/RfDB1AAVSrZf4hc9E1EOVjF+H86tQBqMLRg/3IVhn6SJlrZbQXaIhtzS/OjE0MmI852d+F0Tdm3mcgbpzWgc6GDhlvKLzo8FgTOAVWM0JsVJiYO3vVZSnx0YuFLC3cfSQFlPdTxMxnhHfMfjJnth3/X9SIIqhDhUjsl5Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWFXVGCIXk3NQuI7JxRsnYQ5oZtrEZj2oetcQrcIfN0=; b=fnk/9LoDzL6JK84n3QZsqwwH89puy3dA4WNJ2lAd/o09S43vgMUTsIDybAIcGTuS2BAJiRmXezrQH+SY7ItOA0a0LmIT8Fznl6xsqsaFATy6bm7hmt6ZO6+dB3cUZjVD8B24BfaxJhZZ/IG42DpwijjJhGo9qUMNLyRpIIFkK5k= Received: from CH2PR03CA0030.namprd03.prod.outlook.com (2603:10b6:610:59::40) by PH0PR12MB7814.namprd12.prod.outlook.com (2603:10b6:510:288::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 07:58:56 +0000 Received: from CH2PEPF0000013E.namprd02.prod.outlook.com (2603:10b6:610:59:cafe::fa) by CH2PR03CA0030.outlook.office365.com (2603:10b6:610:59::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.35 via Frontend Transport; Tue, 23 Apr 2024 07:58:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF0000013E.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Tue, 23 Apr 2024 07:58:55 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 02:58:52 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v11 4/8] cpufreq: amd-pstate: Remove amd_get_{min,max,nominal,lowest_nonlinear}_freq() Date: Tue, 23 Apr 2024 15:58:20 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013E:EE_|PH0PR12MB7814:EE_ X-MS-Office365-Filtering-Correlation-Id: 79aa5896-c356-4ff5-fb64-08dc636b39a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XHCdHpUL4sMjc7tRksZyRjrAXTp4T3FGft91lwyGtxFnTOrWwHCz/iYhAHrj?= =?us-ascii?Q?PnP+prNb0kNbM49zR468P9gTxXV2QBrZU0EGEP076ukFkk0uQcRC+ZKMDpr1?= =?us-ascii?Q?SPqsPxCCYEuYTYJadAdVHU4nR3s+a7N9KSg/3v2IB1pUMCPFRPXwumrL3H7h?= =?us-ascii?Q?/cXaFbmSx4oMtenztsA/xmnvYUWW/h9NVMMEGJ9x3Dmc7CqYbqEMXFQ18R2a?= =?us-ascii?Q?iKZWk9ybGUHhpp44E/dljIyQKi8XXJoBVs/a+0g4itMs/A75DOLGtEk6G019?= =?us-ascii?Q?2llDl2Vsgvd5b00YClgL1GKo8+Or4GWz6OBl+b7PNbbeFrnqrvoQ7LO2ChP8?= =?us-ascii?Q?A1Ui42+4CcCERjfU3NEaJOMlFwQPagBOTwEW8c9ZUCRCFc/RvrKiZqBO95UA?= =?us-ascii?Q?p7ZBnUQ1KohQnVbc/UWNIjZQPxT/Lp4PYjrKuknOBQY/V717ZWkK81e+JbfZ?= =?us-ascii?Q?DWDy9BIqr/HZX1szil2avUXViUUYtlbtMFDpKmZ9xUglcpHDSMEMiCQUk8/I?= =?us-ascii?Q?ydQyPhz/Mbi37sK4gRAONiYK12grShFTYa3MlJhtkktGAwkqw7Q2LLkwVmj5?= =?us-ascii?Q?6udPBUqGByU0FNqzS+TLjEyqzMtgXE1+nyv/UoK4S1SRC8WbUzI7MztiTWdP?= =?us-ascii?Q?na70ybpb6C2iqw4WkIg82TXHJ4WbbTBFqSh87CdryG/oByHBYMCWCSpo831H?= =?us-ascii?Q?2vWbXAanvpqBVPieJ8NuUutz0sbIywStRkmDERXb9B8ruBuFqaVwHxxa0R3J?= =?us-ascii?Q?gu+NR0rZ8YU59Fn/Zv3lq6ssSGIY+BD0w0rEkrb/8piz21lt4GVL97Lr66zx?= =?us-ascii?Q?SExkOIFgTcjBwEj9LEVmZALp/uN0C/sDC7McX16RJkiO99CsxM23quzuAilt?= =?us-ascii?Q?93rJTNXmBIYlkvia6S6vyRdLM0EoiT6ZpWrCMfOl8jQyPc/4fFGWxo+1pKQV?= =?us-ascii?Q?eDtEzKCHOTKpGCN7OUyb9W1MA9GTVz5+aTm/ZQCEA9ebUvHw7rN6ZbHUHMAS?= =?us-ascii?Q?pHPFuIwd5/GPOg3Iv0zQLq50j5RU5R6U6OGijc0Jqf4G3Fi8IAKg1mijmW2E?= =?us-ascii?Q?dFvCGFmrTIaB+YI7azACyqWjZNvyRCmfU2EeiLf6tPDdyvoNH/NOrsX+p8Dh?= =?us-ascii?Q?Peg47BAh/4cauNkROzwZD7k82wd6sbYxGuq7kpJbiXy6+QhKhZzQGiuMn/2B?= =?us-ascii?Q?i4TSox25zMqP/YnCuhNEwyq5Q4kvcxsLKoKLpo43ZyZWpCl/xzchtvpu4wCr?= =?us-ascii?Q?foWtIcPXNMWhVHEFbNp9ahkugZW4fjxzJUIbpYFCVcgP2zBun6NsdkAAuQbs?= =?us-ascii?Q?4pXJaX4CQN2RkjG9wvoBGf7fDJfNpNWE+7MJXm15EzQnEjmnfgafFrQQGNsW?= =?us-ascii?Q?36QOvaWLr/Mm7itUPsaL3ysFbnED?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:58:55.9169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79aa5896-c356-4ff5-fb64-08dc636b39a8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7814 Content-Type: text/plain; charset="utf-8" From: "Gautham R. Shenoy" amd_get_{min,max,nominal,lowest_nonlinear}_freq() functions merely return cpudata->{min,max,nominal,lowest_nonlinear}_freq values. There is no loss in readability in replacing their invocations by accesses to the corresponding members of cpudata. Do so and remove these helper functions. Acked-by: Huang Rui Reviewed-by: Li Meng Tested-by: Dhananjay Ugwekar Signed-off-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 40 +++++++++--------------------------- 1 file changed, 10 insertions(+), 30 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 891fad6f90e1..3836d62b54ef 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -604,26 +604,6 @@ static void amd_pstate_adjust_perf(unsigned int cpu, cpufreq_cpu_put(policy); } =20 -static int amd_get_min_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->min_freq); -} - -static int amd_get_max_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->max_freq); -} - -static int amd_get_nominal_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->nominal_freq); -} - -static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata) -{ - return READ_ONCE(cpudata->lowest_nonlinear_freq); -} - static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) { struct amd_cpudata *cpudata =3D policy->driver_data; @@ -854,10 +834,10 @@ static int amd_pstate_cpu_init(struct cpufreq_policy = *policy) if (ret) goto free_cpudata1; =20 - min_freq =3D amd_get_min_freq(cpudata); - max_freq =3D amd_get_max_freq(cpudata); - nominal_freq =3D amd_get_nominal_freq(cpudata); - lowest_nonlinear_freq =3D amd_get_lowest_nonlinear_freq(cpudata); + min_freq =3D READ_ONCE(cpudata->min_freq); + max_freq =3D READ_ONCE(cpudata->max_freq); + nominal_freq =3D READ_ONCE(cpudata->nominal_freq); + lowest_nonlinear_freq =3D READ_ONCE(cpudata->lowest_nonlinear_freq); =20 if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", @@ -960,7 +940,7 @@ static ssize_t show_amd_pstate_max_freq(struct cpufreq_= policy *policy, int max_freq; struct amd_cpudata *cpudata =3D policy->driver_data; =20 - max_freq =3D amd_get_max_freq(cpudata); + max_freq =3D READ_ONCE(cpudata->max_freq); if (max_freq < 0) return max_freq; =20 @@ -973,7 +953,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(st= ruct cpufreq_policy *poli int freq; struct amd_cpudata *cpudata =3D policy->driver_data; =20 - freq =3D amd_get_lowest_nonlinear_freq(cpudata); + freq =3D READ_ONCE(cpudata->lowest_nonlinear_freq); if (freq < 0) return freq; =20 @@ -1315,10 +1295,10 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_p= olicy *policy) if (ret) goto free_cpudata1; =20 - min_freq =3D amd_get_min_freq(cpudata); - max_freq =3D amd_get_max_freq(cpudata); - nominal_freq =3D amd_get_nominal_freq(cpudata); - lowest_nonlinear_freq =3D amd_get_lowest_nonlinear_freq(cpudata); + min_freq =3D READ_ONCE(cpudata->min_freq); + max_freq =3D READ_ONCE(cpudata->max_freq); + nominal_freq =3D READ_ONCE(cpudata->nominal_freq); + lowest_nonlinear_freq =3D READ_ONCE(cpudata->lowest_nonlinear_freq); if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", min_freq, max_freq); --=20 2.34.1 From nobody Sat May 18 12:12:32 2024 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2065.outbound.protection.outlook.com [40.107.236.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D01C54BFE; Tue, 23 Apr 2024 07:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859144; cv=fail; b=DFjl0saH0HxJwGGikBS4VmcKGlB9hOnM8X6dE6PV6RJPZR5JSPgVajEkfiwNEKScII0mZpzSNBTB6NjHirNtT0IvD7icUT4UEnZcdY156Ku7/J0B5x+Zd7EwE1P0xHpegdmducVVIgmqmCxXPlcU/qfptC1sTkFZWEz6JBaVPpc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859144; c=relaxed/simple; bh=OLudeT+1gijlMUi7TFfWkAzoR9bs8ojKSeLEe4FVrk0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bJst2oNIlrZzwrGwL99lv3q7iIfQsEXdPg/dO+++kopgrue6IeD+eGOPM++mgHBysyR3nH12sxhmHmgxRF7LOs9FM4l6J2PQFiyudA/rxlVKyj3PjJFeETvG+1GfwdxE9rzXhoGfEoWKFCGpt/XxGoZAVH81d25rouq3A0NdtSE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=rYxJTddu; arc=fail smtp.client-ip=40.107.236.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="rYxJTddu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3sMrbUobNQnfSVIZJA3Qw6PDYiTXG9iHoSKGu0qJakyQlqR/vyPM9+loVI3SDKoTUBe4XdRRuUiSTu5/+IjuYJXpQmZqnFUYVM5sMi9EDrwgOqNrZr9Yyo2fUcKPYl3ghuHvkep33vNxLDfgbCKOel7jnA8lIKgAAkILil73giPU49WU1PdlLv7pPb68jFDPCWugGz5PzMBF1qD5uOrh4v0zeeG+1njMd+UfCAXnQcoTyHJaWPiW+efOBhl4f4evakB1elpCbL64wF69iFq90YqC0qIfVlRroDPoUMsbNr+EYiiZ3HgwGx2mja3PBDwlqx1V2MtJEeMkKUWYpqG4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0+TC2KATw7Hqz4WMVGydK+FfXr1FbAtVbdW2gRVy1Mw=; b=Miyoply3gTq5ALkBIHllc5SJeQkPIGPzrcaU9MHBJAdjwXCTKoL/eY1ltDgm0AihJ9UQuQeWRUAO8lnwrYQadMxitdPQRDt8aq07nplqABGu0NpiEgTLX+ShCbBV7qaUoZc/50vVvIpCJS73jhNDLOs8L4hYwT9wz4yCug3AIlx89BXVnPrmfuc4Rdch/RSyWqtknEEb/1xVL+aERRlnC7/cSj3vOWW3fyTfXqewzVzMxWo2yWGG0Z+NuBR9y6piQjY5lyIciUInOp5qKenMcFeS3xYJHY2UkSKZcXrzZIz/dN/rhmAD2zmUxfXq9PkiqtlR0c5mC/lR7RDFONDIKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+TC2KATw7Hqz4WMVGydK+FfXr1FbAtVbdW2gRVy1Mw=; b=rYxJTddu4m+CVSq/txKJFKHY3XH51H3wYy/sF+vkjYTxXh+UiZTP5ZEbIsg8Nxf/ZfYQYxG1Vp+Ud00MX9jJ8HwOnxbIyJ1p1vIkVj4h+lOC22fERzxo//B4/EA9ncPwl+r+fMgFFqZ2TJLeBTL8ekEzoEItWN4nHRlLhAkTW2w= Received: from CH0PR04CA0108.namprd04.prod.outlook.com (2603:10b6:610:75::23) by CH3PR12MB8356.namprd12.prod.outlook.com (2603:10b6:610:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 07:59:00 +0000 Received: from CH2PEPF00000140.namprd02.prod.outlook.com (2603:10b6:610:75:cafe::1c) by CH0PR04CA0108.outlook.office365.com (2603:10b6:610:75::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.34 via Frontend Transport; Tue, 23 Apr 2024 07:59:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000140.mail.protection.outlook.com (10.167.244.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Tue, 23 Apr 2024 07:59:00 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 02:58:55 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v11 5/8] cpufreq: amd-pstate: Bail out if min/max/nominal_freq is 0 Date: Tue, 23 Apr 2024 15:58:21 +0800 Message-ID: <6f016bc90debb6fb590db105c32ac9456c6ce490.1713858800.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000140:EE_|CH3PR12MB8356:EE_ X-MS-Office365-Filtering-Correlation-Id: 02ede79f-8af4-4dc1-7295-08dc636b3c25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uhzQIVfrcVUNv9A/xIyNA4MAzXg1BYfCFZKGzXnZKQFqtvv017o3nmNR78hT?= =?us-ascii?Q?KXKgpTEWgpAFVgC7kNzsfNhlcRfcgENx8rNaQEBFL7TDpZ7WY9oM5ezfWteC?= =?us-ascii?Q?neAXl28alEGvEmQYnSPnuJr2zAiM6VMFeAyik45iwljr3dt/0fx4u6djaMIp?= =?us-ascii?Q?52ozIxlg8Bo/s69fysYEj1kNHCD9sywWDskRQ6qRHn3DpcfuXYO4zWEu1PY4?= =?us-ascii?Q?ZuCaRUgoZ3fDocV4aBw3q1cvwprqbDy1VlX+HkMSgppFjHDsjat+xmDCuf9A?= =?us-ascii?Q?zWRFzwnMc+TuNITPyydOcGOmZ3JYdDaRTmXBHm5xybzs+jhWvHopK8HP/mKD?= =?us-ascii?Q?n176/pxp5cNwFmYuLrAtHE/PtK1Y/oEGhPh5t74Hxpj8VBSUDAId9k0Kgmkh?= =?us-ascii?Q?IPBq7kY6SNFSZyzEkmUYWgn15Q8BBYA60fGTPKYdNxqKUkQVOZh6T0rF/NY8?= =?us-ascii?Q?jwBXVC40OAKIUjN+6z1cJWmb7P4xned3j5M9+a0VSzANFeXJjHWU60Bt960R?= =?us-ascii?Q?ODZ/2IUwotQpvNTlw/t5VMnnT8x21IX7P1/+thX/CdHiqf8ar0/7/MGXoqxQ?= =?us-ascii?Q?NOnP1l7dH6DRoH3dZA468A/KdSZS/RrYPUs64ZDkQlYYhVBqWzt9Pqtw2UKU?= =?us-ascii?Q?EohGTAfQ6Ki4dmYRG7OMGy1N2lOrg1kDdsixeoJ6K74bqCgI/CrVtunqzYW/?= =?us-ascii?Q?1UfWa+XmTscbZzIzC9CWR++IsQgm4DaadEv3CnHjJdMgyRPQtZm/YjU2P+YZ?= =?us-ascii?Q?+N+1+t2govcLAoWMPX3ggCXV15Mv3YYX9XN7O8vkroLM8qRs6HDkB5seoFU9?= =?us-ascii?Q?hbV41HnYvNkciFyECrKunwSzaIEWtM3wgfejaGY4AcG2rsWnZ+8/9rOzkXbt?= =?us-ascii?Q?6Nad4SiJLSO0iyUHvFJwcVESwSSeWiPGx7IIF4TFKApFz0WVDDXNQWaGfPqt?= =?us-ascii?Q?4qGD9OgkKyigGYPbNYmzzHVoEb43WrzTE7cCoIkiusa2jrrqFaz6h0Nb1QVW?= =?us-ascii?Q?XsEBDZrvEBIMnj4O6Vw8r1+sLricJA1RIMWqi7PMlK56qpdTovEZzdOW1DoE?= =?us-ascii?Q?Ud4xzi6T+gh8Pbjo3UQb9twYzYfqWI8fkhp0gp0r36ZgPkh8w7slehPNFxYr?= =?us-ascii?Q?gXH6VfkNNzBtmnCRlcbmf72Oq7XHrPi2JasXCf+QAY2ur/uMWB07L+Ya5V9I?= =?us-ascii?Q?Ck0uM0wXnV9WNFgX49D2e18Jgz9NpCbcbzP0a7wvdmnd1opKcOqjU2gHQ6Zv?= =?us-ascii?Q?4+AuvXTW01jDoKf4CEAMbPbCqoEFnIg46XZgTEitF/2gnfH8ycwychkJyt+E?= =?us-ascii?Q?fjDT+nrkT2+XePMXibjb1Zivb+zubWQFwx7bw+xL33ZCNuXsOYph2eWAy1gf?= =?us-ascii?Q?M+YveF4=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(376005)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:59:00.0880 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02ede79f-8af4-4dc1-7295-08dc636b3c25 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000140.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8356 Content-Type: text/plain; charset="utf-8" The amd-pstate driver cannot work when the min_freq, nominal_freq or the max_freq is zero. When this happens it is prudent to error out early on rather than waiting failing at the time of the governor initialization. Acked-by: Huang Rui Reviewed-by: Gautham R. Shenoy Tested-by: Dhananjay Ugwekar Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 3836d62b54ef..960fead0b83e 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -839,9 +839,11 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *= policy) nominal_freq =3D READ_ONCE(cpudata->nominal_freq); lowest_nonlinear_freq =3D READ_ONCE(cpudata->lowest_nonlinear_freq); =20 - if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { - dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", - min_freq, max_freq); + if (min_freq <=3D 0 || max_freq <=3D 0 || + nominal_freq <=3D 0 || min_freq > max_freq) { + dev_err(dev, + "min_freq(%d) or max_freq(%d) or nominal_freq (%d) value is incorrect, = check _CPC in ACPI tables\n", + min_freq, max_freq, nominal_freq); ret =3D -EINVAL; goto free_cpudata1; } @@ -1299,9 +1301,11 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_po= licy *policy) max_freq =3D READ_ONCE(cpudata->max_freq); nominal_freq =3D READ_ONCE(cpudata->nominal_freq); lowest_nonlinear_freq =3D READ_ONCE(cpudata->lowest_nonlinear_freq); - if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) { - dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n", - min_freq, max_freq); + if (min_freq <=3D 0 || max_freq <=3D 0 || + nominal_freq <=3D 0 || min_freq > max_freq) { + dev_err(dev, + "min_freq(%d) or max_freq(%d) or nominal_freq(%d) value is incorrect, c= heck _CPC in ACPI tables\n", + min_freq, max_freq, nominal_freq); ret =3D -EINVAL; goto free_cpudata1; } --=20 2.34.1 From nobody Sat May 18 12:12:32 2024 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2040.outbound.protection.outlook.com [40.107.237.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A4854BFE; Tue, 23 Apr 2024 07:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859152; cv=fail; b=J9ZR5gaAw439E7e2FruL+YXj615cgm1vPUEytmQR4ay8AGy2M14fFyLYeiDDwg6a5GOeLS6bao5OWzUGQ35pXI1Ufo3iC/4JQ0Hk510EJHO9DZXV89+6uw20XqzCmYofRauaSkOZxd94Gb+bD+4JZc1BVp06GxFX51auyQggndA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859152; c=relaxed/simple; bh=ckwcOBVNDuF40QHvqaELwzXzB6I9pFsprYsdpq4lBWI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l3zv44bcsucsCmEEa4OVvQJsKvpdkRbi/qSYYeJi44z6Vx7FWQBlKNkjFxWbn27qezKCJeQcz6/CHKEYcBznhxSi0PwnDfuzGR1Cx+W/yic3AO/+3TOohGfDyM0AYpmkCf49aY3aIlzeKma2HBULqEn98fZtqwn2a2pkOFL1prQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Zi7E/0Z+; arc=fail smtp.client-ip=40.107.237.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Zi7E/0Z+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QrQuXYi4hw+C7o8UdutHPI5jAf1ublzUgkm0tAWm9714oKjZO0Hp5GDRf2L7AGmMuNku5eqLibVLue260K9VyeTAoYq3VvASgPK+MCeLF73vex6qID45O6oi1w3I38eMdQAecmIaXTDWGs4sO1dyIPKdzRjaUYIGLwOlzzo7tdmLZntjbuXw9/pNtnx8kukPvm5A1pU2tkLBi5PusLiuWRU87Rp58FDiJRlWDYqDsRQXxz/jQwo6qdIo754nLLvtYxByv14r/uZcTLiQxI/88XudVx0jiUZ45T9rnNe2JD5h3wM2z+/rUc2L2O/xtr+o8PcZcNx1kKyuwMhjBjvGrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m7Nnj+wrL8I671SDCrz9Xga9ZXP4NJdoC+h1QNGeU94=; b=nYKqyKz5s2ilW37RNMKtZIDdertcVP+CscU/TeG4FJ5PZUYoJPFHAy4XnrBRC1RIZz3Vi2xr3ASwGEM1G8zRXx2ca/4F3CIUEaNh/UaiDqeYbk0/qKPolocyBsaCqhecPFK4XMakmkJrXL58dSVVZuKx1qiED38FXdUvhJr8SbwgfofLT9UGDohyzX1rFaUCFotGLrIbIadCbwi9QuScMa/N9aLcRdVou2J0fQZPaJG5/AShplD8BFxVq3+0XGJJ11SR5Vfv0FEqeUob0K6lHOYJj638luftxKv57Fbnt2W55lzq9rgGskRNHXpV5ENbE+WyF54Dyr3cVyyUQKHynw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m7Nnj+wrL8I671SDCrz9Xga9ZXP4NJdoC+h1QNGeU94=; b=Zi7E/0Z+MtFMCr6T+UmhTxvjWpTj6ROURFIWzHu/zz+Rv4grE54n4Payi1QJE4lHxy/j4i4eKaeUGAw9uOgsYVd6R7PC05xP51mkvbMam+KE7Mcruo9cgOQgSZsNnmUb7yAn0D7w5bvj+rOWR4o7B6Dnl7iIa6BXydnkFkBHnyU= Received: from CH2PR03CA0026.namprd03.prod.outlook.com (2603:10b6:610:59::36) by IA0PR12MB8695.namprd12.prod.outlook.com (2603:10b6:208:485::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 07:59:06 +0000 Received: from CH2PEPF0000013E.namprd02.prod.outlook.com (2603:10b6:610:59:cafe::5c) by CH2PR03CA0026.outlook.office365.com (2603:10b6:610:59::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.35 via Frontend Transport; Tue, 23 Apr 2024 07:59:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF0000013E.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Tue, 23 Apr 2024 07:59:05 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 02:58:59 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v11 6/8] cpufreq: amd-pstate: get transition delay and latency value from ACPI tables Date: Tue, 23 Apr 2024 15:58:22 +0800 Message-ID: <81aafa46533637984cc9c80f90faf5498a7308c9.1713858800.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013E:EE_|IA0PR12MB8695:EE_ X-MS-Office365-Filtering-Correlation-Id: 39172584-af73-49d4-6adf-08dc636b3fa8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gPrEsdNZkaMZPQOBAcNXOcd23dfEOg0IQXNyHPV28+isDh95eTQsWC3ukCOi?= =?us-ascii?Q?BZQzQmtmyaC8SkLZySeQJZ6c5zXeE3Vw84zypv8UzKPwxkbr9xVecD08hOSq?= =?us-ascii?Q?9bAamQYJjigPwSok39jQdj5mhsIQjNmwumH4jOWTgQaoN6CKvBJlJVmfcLKB?= =?us-ascii?Q?f0a8yReee13evptusfkUSjb+YG8dVP9O1jXF2P0Zmqqn5vbwk55WQULoZMBe?= =?us-ascii?Q?LuIMBfUngVQfxwADq3hsvhCWLZH4JFox76Ib1TgRqBM024BZVSTooZtYDCVr?= =?us-ascii?Q?aWjzpgOhEwhEbx14fwWteLkqDfNJtYbAZP/SXXlj3PV9EIMp/mZR1oa4V4XA?= =?us-ascii?Q?TJJ+AnIrqHLl7uKmR7625sU80SIGNnkhLTC63eozlauk+10a/0XeWbAURYvM?= =?us-ascii?Q?L+s5TrawFBc/FUEfC01G9JdxQlktUhgpX5Fc/ui4/e0RoES7O9P19NOR3jFu?= =?us-ascii?Q?Fj5mcxCslKuu54t0b6N8lmV+4fJE/at7j6iw48iMPC1AmqVzq3ZZCiuF9MFC?= =?us-ascii?Q?y8AP2Mg5W6GRjU/We+mR9LfyZWDeCgPvyaOSiNuUW3nIj/ZyvpBiAxaQD1jq?= =?us-ascii?Q?F+OQf4WMX832Ic41vV+r7pPwctfYXmxgAHo937050Cmvt/ChwJ4xwtDdY8FA?= =?us-ascii?Q?eG+EnrCuLl50XdaLYXNhQTJxMiB0hoNFWL8ZnJ0SxF/YHTPWIEBzvuNyACJw?= =?us-ascii?Q?x41TFmG1z0Sh2H6gxog4vy8aWCUOTyWL9zOCCAXE9fnUc2Du1IOaUPWMXrzu?= =?us-ascii?Q?0979ZNpu+2qr3RbEYQvLpwlaWD2ctPrKSlvFxohlKsORW9bQ4L9L/FChiLGb?= =?us-ascii?Q?qi1TVQduem9Hvu75pabNbLFrn1RmvphDealQiVVf6ad5ApLzcggZ7QUNqW+H?= =?us-ascii?Q?TtanEBYBQx45zULhkTnTMEDfcpEUfs9GoT+GkEpPJTUbWYWCczinSMertu+/?= =?us-ascii?Q?rXI/mNo4NHV4vLzT4Y+G8IgwD+bM7Q51gfppE41cm7aMjqLQwrxzxFi5oJKK?= =?us-ascii?Q?tRm+GFBb4mxlJb/xUklNQbN2IPtrT+X0a8/EwnNPEGIq6Ajv7i2n13kO5vgP?= =?us-ascii?Q?oZkSUtDr3Eux+oW42FtZNGV+lsenkL2z6uUaqFi7303QURyB2soYxY0Q2KsP?= =?us-ascii?Q?vEIgEkGcggXuzs5sOmp0gg9XGPcz4vSAr7cwgV/WEi7hVtKf5o0G4v0MQDrh?= =?us-ascii?Q?ypKtfwb0Pg/8+T2Dnfj+Hk1SNVqB8Vi+KS9Py5n7725rPDmOIKSdSZEufktU?= =?us-ascii?Q?GZjRvg/YcrWPAqr2tk85wZEJRN1Fnc1qYP6vhtQeznQWODiJ2I8x5DivP1sw?= =?us-ascii?Q?ory0mmT8ro4tZW5m31MYB7SvD5Gi7EARKNh/KSZnbpoxtTWuhGOQrLl4M7CG?= =?us-ascii?Q?ojBvpF0=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:59:05.9795 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39172584-af73-49d4-6adf-08dc636b3fa8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8695 Content-Type: text/plain; charset="utf-8" Make pstate driver initially retrieve the P-state transition delay and latency values from the BIOS ACPI tables which has more reasonable delay and latency values according to the platform design and requirements. Previously there values were hardcoded at specific value which may have conflicted with platform and it might not reflect the most accurate or optimized setting for the processor. [054h 0084 8] Preserve Mask : FFFFFFFF00000000 [05Ch 0092 8] Write Mask : 0000000000000001 [064h 0100 4] Command Latency : 00000FA0 [068h 0104 4] Maximum Access Rate : 0000EA60 [06Ch 0108 2] Minimum Turnaround Time : 0000 Reviewed-by: Gautham R. Shenoy Reviewed-by: Mario Limonciello Tested-by: Dhananjay Ugwekar Signed-off-by: Perry Yuan Acked-by: Huang Rui --- drivers/cpufreq/amd-pstate.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 960fead0b83e..510b5aec42ea 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -756,6 +756,36 @@ static void amd_pstate_update_limits(unsigned int cpu) mutex_unlock(&amd_pstate_driver_lock); } =20 +/** + * Get pstate transition delay time from ACPI tables that firmware set + * instead of using hardcode value directly. + */ +static u32 amd_pstate_get_transition_delay_us(unsigned int cpu) +{ + u32 transition_delay_ns; + + transition_delay_ns =3D cppc_get_transition_latency(cpu); + if (transition_delay_ns =3D=3D CPUFREQ_ETERNAL) + return AMD_PSTATE_TRANSITION_DELAY; + + return transition_delay_ns / NSEC_PER_USEC; +} + +/** + * Get pstate transition latency value from ACPI tables that firmware + * set instead of using hardcode value directly. + */ +static u32 amd_pstate_get_transition_latency(unsigned int cpu) +{ + u32 transition_latency; + + transition_latency =3D cppc_get_transition_latency(cpu); + if (transition_latency =3D=3D CPUFREQ_ETERNAL) + return AMD_PSTATE_TRANSITION_LATENCY; + + return transition_latency; +} + /** * amd_pstate_init_freq: Initialize the max_freq, min_freq, * nominal_freq and lowest_nonlinear_freq for @@ -848,8 +878,8 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *p= olicy) goto free_cpudata1; } =20 - policy->cpuinfo.transition_latency =3D AMD_PSTATE_TRANSITION_LATENCY; - policy->transition_delay_us =3D AMD_PSTATE_TRANSITION_DELAY; + policy->cpuinfo.transition_latency =3D amd_pstate_get_transition_latency(= policy->cpu); + policy->transition_delay_us =3D amd_pstate_get_transition_delay_us(policy= ->cpu); =20 policy->min =3D min_freq; policy->max =3D max_freq; --=20 2.34.1 From nobody Sat May 18 12:12:32 2024 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2074.outbound.protection.outlook.com [40.107.94.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C09458ACD; Tue, 23 Apr 2024 07:59:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859157; cv=fail; b=I3uh9utT2xJFh42kmJq4d+oC6xrUmqyRifUFzx2NMIEmXYkCE4Yg0zRd49apVuEQgZk1b2Dyh7bdh2MDqcUiwREKKyWRMRv3ZmS9MIH3hfliWb7gh3wPBW2GI1SbLY5b8J3hktr+xA44RRydzK6wZrPZaSCwak/4VJnDEeCMw0g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859157; c=relaxed/simple; bh=yMZuIbGw42YjORpyBThUbZaZYwLpoIiSd88evb9PS1g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Jn1B5gG9fQZUstXTQTiPQT7XM15scqcT3nSQAjU00SVytUQiCFfSomRtHl4g1bAHHrlOru73km7QcBoazEoz+soPsfZI8fSEYFE6kOg/EVxwa003ThDO54udIXwO54doB2n9vlp9LTPbgtBiwZHS3qF0Ku2RIHXCDhDu5Xae2Bg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NA39QfMN; arc=fail smtp.client-ip=40.107.94.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NA39QfMN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TfX+mZayTMfE3E6JfS0ZdZrpONZ+6sA61/9eYc6QD3/dLecXX+Yw07FRQEB2GYnZ+YBr2Pz4aUvSbPuGypVYil6gv2uE3dUZvMBqwdN0q+Ny19Dntq0qXiIuz3Pc4nAkyearJB7VxFCDvwiPm7YLBPk6uz6cz9Xn+5akOAZL/5qlvh+ryKzMhK6FwACvPp2DmoZY7BlU/UExIf7iabXTIdslUD9gOC6XKWj6/ANlV7iWoRpMpuc/NEZlBYTSXh0wyenac+/5M7CAb5OZ4nUraejZw055gJQpyPYanuFGi7EMz0THnv7eL2ihkpH5Ooghhk5nHYCABVc+XMkpbzooEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NnIfoUNNUSgZSFxKZmxAZtt+uHq/r8v5ejdRJ9wrWCM=; b=I2dtd/zifhgihCJD+z1w4xpVZ7L3CSY9qgsnlh2tX1QcH1YVRFvVohmkyqzHivDT+mHT/Ylde5nyauG8VMADTgnPaPcd83Qt1gkVEtvuIcmaQbxrjAsGBpnHXL6Dy9M0KEmsxWys7wb7c8Zx1XnvK9IezKgaL4ZKK9NyATMw/24MiO280clR5HZBzed6EnBl6CJg3S8jfe/29HKb0SgQD59YdxEqb8oPVe6LlgCqYprG9O9ci410KgfB/eAd6i/IhO7w4ZKPmJUZ2qs6ATohU62PtXhcw1DfYflhUMqmOJan+NnQ06TQJdh7aZTLVyp11rBGjCYE/oHXTbTX++NrdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnIfoUNNUSgZSFxKZmxAZtt+uHq/r8v5ejdRJ9wrWCM=; b=NA39QfMN+GocqaSkmXI/1KB+eSn9peizNQo7Nz+XhM2yi5+ypdnlxd/UOSv8jN5wn+J3g2Bl07dFTak82BzorAKcXIV3ePrL4lZGPkL8BKvgaY3tDSQT5S9Lb2kUV8wSWBRwK3lICxhXM63wOhur6JQDJAsCCzx3ZTtklXHUIu0= Received: from CH2PR03CA0030.namprd03.prod.outlook.com (2603:10b6:610:59::40) by DS7PR12MB6048.namprd12.prod.outlook.com (2603:10b6:8:9f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 07:59:08 +0000 Received: from CH2PEPF0000013E.namprd02.prod.outlook.com (2603:10b6:610:59:cafe::fa) by CH2PR03CA0030.outlook.office365.com (2603:10b6:610:59::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.35 via Frontend Transport; Tue, 23 Apr 2024 07:59:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF0000013E.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Tue, 23 Apr 2024 07:59:08 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 02:59:02 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v11 7/8] cppc_acpi: print error message if CPPC is unsupported Date: Tue, 23 Apr 2024 15:58:23 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013E:EE_|DS7PR12MB6048:EE_ X-MS-Office365-Filtering-Correlation-Id: bc5a5811-8ef5-4c8c-702e-08dc636b40f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QbWHOWmlE4IjcVSRGR/3mb67RedpqyPvFGn2Xc5vwNX9qK6qy1QJxexMD7Bl?= =?us-ascii?Q?cW64+//VcsGSx3BK15Q65lAUy5YIt4MzAONC7UFWe37AwXy/T6Ube5b+ij4J?= =?us-ascii?Q?ImyK8l+/rgiTk66kxo+6s5t/TR8KuyZwxfvOZp04/DIlOcV3Hu1pbXARCWTA?= =?us-ascii?Q?OSs/0R0qvm5xKjBsKwWZxEic972+c+3p6ciVYE1yx4rFm4WuP/mDbg87C0hh?= =?us-ascii?Q?CQAouYLxaPtOOWdlHdq5Mr9iRVICAF8NnopY52jKUB27H70arXwU0dh0b7gu?= =?us-ascii?Q?yjkiAS4m3eGiiZApzyKN73DGWb4vN6kqZJNh+3lQlgiKLTZy58fwqlHx3WeX?= =?us-ascii?Q?fLAViOzgzZew/I8ePolNfLr7C3tzn1PcO4xbLcx7DvacWeBlir+GLDvTpTYT?= =?us-ascii?Q?fRzTZghQ9wtCku6cmN1sSwQdBSImS5Vg0JTLAoGPlE7EP63Su69vbWmhe15S?= =?us-ascii?Q?wl4w5bTpjXi9L3Rr6VmCBtamzTl5+011A6ddKAo2w5s9UD/XvrA2Dj7z1uC+?= =?us-ascii?Q?wrEk02pjGlbajj5e5Ai+n/EcktX+LgpKuyrwgc4wiYSXzqztkyHxYfiFpk2C?= =?us-ascii?Q?Bsz67dTgJdC0AzuCSQXiKu/OS7jbrvrx5IrWDkOUklzAtHsi6KspLLJtSevY?= =?us-ascii?Q?8GEQCVUN5BcWVzN/OqxEJJ0kQZfXAcLlpCGdn5LFDDy6zmydSWMmFnubjtDg?= =?us-ascii?Q?o1Rj9EkkRFq8bmxjgpM/aDTIQFu6pJeSvB69JmrMblLvL5x/BbALpZWxcZdC?= =?us-ascii?Q?jVPG7BkbUfssg29xLJVmxo3K9NlIfTooHTDAOMqu6UCkhi1MiM1YXNWLDpWw?= =?us-ascii?Q?xNF6Bd+RS+wltQC7sM6JMHFGjjtdwmJ5CGrgVKCrcEWsxe+DDURFuGMkZDHP?= =?us-ascii?Q?T6Lyh19wMLXGbNNQRPZ/lK4bItxP02frCtPzpsu+rMxG77OTz/hG7rirgFIu?= =?us-ascii?Q?tUidCptGwFv3lDDCaqvr7yLFtvu7JNdk2k2N7rGOUY2Xo8vz4hHO2fzWuRtF?= =?us-ascii?Q?ISz3qB2+o5MsZL5QyEVRQ38sJo71zev1lIQH3yzMGfglPpqLy97Gjy5Sjw6l?= =?us-ascii?Q?8j+DdpI/JZG4MTKn6XipuBuWAAxn8AIpsrrC6MfsvOx2sKNtMMbYmjb3Udm1?= =?us-ascii?Q?W1N0gDoZbTj0LqTlKPh3dxZmG9olAThYfqYApUMCiTME7bL9fu4esPZOKKzF?= =?us-ascii?Q?mzXgHjI/QlIYbrNg3WjO7LXWYY/1tQh/Fqj6dP/Iy0uJylynBYYANNa3AgGi?= =?us-ascii?Q?2Ml8PAoFIyN+jxbMy4sbqaFPAAjB+AEjmfesxeH7Wwi07WM5Tg96jzzApfS7?= =?us-ascii?Q?w1iRbZHd1WUaRHst3kSgxFUtGuzhjyHeTXEhbczcQ4gmUoUwokF4Wy3ml+7O?= =?us-ascii?Q?+unhj6cXpRF2ZS+xXYgcXKX5vS57?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:59:08.1358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc5a5811-8ef5-4c8c-702e-08dc636b40f1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6048 Content-Type: text/plain; charset="utf-8" The amd-pstate driver can fail when _CPC objects are not supported by the CPU. However, the current error message is ambiguous (see below) and there is no clear way for attributing the failure of the amd-pstate driver to the lack of CPPC support. [ 0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI = disabled Fix this by adding an debug message to notify the user if the amd-pstate driver failed to load due to CPPC not be supported by the CPU Reviewed-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy Tested-by: Dhananjay Ugwekar Signed-off-by: Perry Yuan Acked-by: Huang Rui --- drivers/acpi/cppc_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 4bfbe55553f4..3134101f31b6 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -686,8 +686,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *p= r) =20 if (!osc_sb_cppc2_support_acked) { pr_debug("CPPC v2 _OSC not acked\n"); - if (!cpc_supported_by_cpu()) + if (!cpc_supported_by_cpu()) { + pr_debug("CPPC is not supported by the CPU\n"); return -ENODEV; + } } =20 /* Parse the ACPI _CPC table for this CPU. */ --=20 2.34.1 From nobody Sat May 18 12:12:32 2024 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2070.outbound.protection.outlook.com [40.107.220.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0EF59147; Tue, 23 Apr 2024 07:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859159; cv=fail; b=BTxjzltA6GuzVhbQXpbvWmwv84JJaMnDKJQPQd9ZFy4d+9LK0lPR+7V/kRrALFUarRIYm50DXh2B4OF1AtxoJgqtIFoJ5I3UQTO8Lx5AuSDK8Gg+Bg0tIc4bzdh8svpY3xn1fDil9Z0MvnZXbGsl6zDhjAi7ubvmLiWktLgb9rg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713859159; c=relaxed/simple; bh=S4gsus1AXJRFAgD2JZ2zQyEthUpzhSrTBjm9MkN9kWc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fzP9nDbl6vRQyrmekxFK6cB82//GYXV2Y1er5kYw4/w7MjlRBSoa9jWzt0r2mgn5bN3QXxdHbarsfqAqPVF4dI0SmNXLV+zh699K1r7ln2gYgwDQ8Y39qRTIGiwKnV2JuiUiZEJExPAc1NoBqnjfV1E4ZVSQuWAcfb+++mEiYnI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fkycmskF; arc=fail smtp.client-ip=40.107.220.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fkycmskF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwxPEGzhZgrWhUYZzMh9x/ZDkCqCoONbl2GGJxEGwvnNqEDO8XUDI72SbXKc16PJ/KOu1+QbAMtcqnxN2drYHojTArAyrgYZVxvtSaALhMkFZNblTxQBk3sxUiSBm5oguts4ftca+Azvx1GSTmZsSI9RgVic3xweTQ/3nwYaYsHw2M8xOWvyjZ5bS4q190Mr/20Pi0hUP46/HZ/a0CYjrrewCcoRBWBeTuW1mmMBqEvohhTqChberoehQkjCfqPpRSmg1IZO9HmxHHuvG+2qHEhNUfjMJTpwKThqQoTEEMBXRB2Tx82RQqTeukPxcHIMW2BLkuzfJNhTtD4Qu2iHlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X4t0t0fJjgDfNpBvcy1Ndw/c94RTZuz0xnRm36uFwBM=; b=fVTFegscXm6JftW4kMstMVICkI8MHF9vyJqWtoDC3r/tldCmjivr7rNoNRRGVPCkAYzbD7dBsjYCnqGxXZTStEgzTrChgdFc4nGppUCgc3ExetOms8Jkm7D66SzKL//f/kMlt5YbW7J5v/R4HdAvmT4cXVP0Fc1Izlp5RlwBrvJgpKSFfTB2F7ii2RzabRfzzW9ZmCAHmQNtpWEs9x7R7r3oO7874kD4DtUq/pUOuJnzp4vxvjvkqnwMBI5IutXnPc/6m6m+35AhQqK03fdtMYWt+z7VWBYFsIvXtcIxhb/Z++tqRj4M1pzWIb8W7urNup/yW9pkkkKfwILNz8qSmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X4t0t0fJjgDfNpBvcy1Ndw/c94RTZuz0xnRm36uFwBM=; b=fkycmskFdsSwwn3zBcYtX3By7F8cGxACJRAI8MQlg/q4YGxvp+ydqPEWt/ZS2MGRtSohDIplN7tKWYzrsnhR1mz/XB5e9NyWVBo9OiKw0L/QWcM4x1N1pokceZCNqMlkWBcprAPyiyIDYn2gegNqKHyV/30fJZv7fzac7xh8wc8= Received: from CH2PR03CA0028.namprd03.prod.outlook.com (2603:10b6:610:59::38) by MN2PR12MB4062.namprd12.prod.outlook.com (2603:10b6:208:1d0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Tue, 23 Apr 2024 07:59:12 +0000 Received: from CH2PEPF0000013E.namprd02.prod.outlook.com (2603:10b6:610:59:cafe::55) by CH2PR03CA0028.outlook.office365.com (2603:10b6:610:59::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.35 via Frontend Transport; Tue, 23 Apr 2024 07:59:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF0000013E.mail.protection.outlook.com (10.167.244.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7519.19 via Frontend Transport; Tue, 23 Apr 2024 07:59:12 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 23 Apr 2024 02:59:06 -0500 From: Perry Yuan To: , , , , , , CC: , , , , , Subject: [PATCH v11 8/8] cpufreq: amd-pstate: Add quirk for the pstate CPPC capabilities missing Date: Tue, 23 Apr 2024 15:58:24 +0800 Message-ID: <381226526d045eb70a0d7fddbaff06a5e0592bb0.1713858800.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013E:EE_|MN2PR12MB4062:EE_ X-MS-Office365-Filtering-Correlation-Id: ae941862-a31a-495f-7a38-08dc636b43a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|36860700004|1800799015|82310400014|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3q5XP9ZHq1aSyMojBFWz7WLVqc6UblNf7EqOZPLMP/P1pmxo8auxUDOIQ9Ss?= =?us-ascii?Q?Mwibrm7v9lrXPZpUtl+ZtwwrSJCmu6jeGzFijBgDu6O1rpwSoP25Ir3Rzmcw?= =?us-ascii?Q?A3cbgrA6F2+hGse2t7fM1cJKx+ZW8A9BQJpCciAlTFSF3r0TRZWoir/tRyO5?= =?us-ascii?Q?mxsVc9+XN5n8eUwnb0QB9IyHCR8urv/kb1vXGQb4GcabAPCpYMf09UeqU6CP?= =?us-ascii?Q?78zoQ2rr33f0eRuTUpJ9zHe3V82uCXWanXmT+0rsg+xX7JQE0IhKbHQKuV0F?= =?us-ascii?Q?mVvnhEQbMvmdZM43ArPAeDWV/4JAOlcePLURMujYkRDRRW9iz6uW1MPjjBG5?= =?us-ascii?Q?T3G5yuJv+1ARjjvlkULfWNtfNr2oqIyGC2upwb/tawVH6DfyqG6BEhNER7XW?= =?us-ascii?Q?QhTmxbmhX2Qqgv0EabPc9S9brqieJbHabm4rux74g5/ZEkPUJZE/K0Bc2dM3?= =?us-ascii?Q?mp8IWag1sfwLDTb2ohg4WY+Agjm8hnlmE0N7jtmoDznokspNiF7NxU00Y12r?= =?us-ascii?Q?e4uoGSka+Ftlv2sNIlu6DG865SwyUQkfda146ZfhUnGc484dc4LR+clrqQTA?= =?us-ascii?Q?/UFNW12coq1RHm1ZjYG+PsukaUMp1ineDxFo6F7z0NWEsMAu81uvAHvNBnIu?= =?us-ascii?Q?BrCpkiAQyTbh0yhtUXCNsz0PKPOYnLeQB4gR5MegMIrH1HB5e7ALJFEWKIF5?= =?us-ascii?Q?FPReCnYtdkRvrYF34HEeNeT/DQpOJmuoNBWqD+BoXutxlc+0acH+i9IEHYWY?= =?us-ascii?Q?rYV40d+6LRYL5hKatuHnLRAepXkY7S5n8h2OfT71qZzntTHZvWoDq8ZcAMLU?= =?us-ascii?Q?BaSOaArrmZLzXU3BSI7glTQigRoIaBNmn0RDIJdDCGTZThKkkL3hYqiBXvNB?= =?us-ascii?Q?UYAu6c/l/wvU55feJxr0QREQ7Tx0ShJ6gHL6WNU1wUIgH8oDV10SRU+4Sl8E?= =?us-ascii?Q?yJzpJrsZhLMCqdNOARjd2OY528BU04uB7b8dT9gou1dSFN1Iy1mzm2BSDcQU?= =?us-ascii?Q?HqKRg4E2Pz1Ue4H6jdfL9W9qcfgHoZVjav4LGxXuadC3sVY9lSbBYQQfvQsq?= =?us-ascii?Q?tfx1FWWDHHDLqgVQmB7LH5VzWzbOdcy7IXyhXoU1OVdiThI/ANbjLULBfJKH?= =?us-ascii?Q?2uVMtrrgZSQaZ+i0rAs2cybMkvqObgqSfVvdyRxXgM/67cVXyrECdGKjUKKt?= =?us-ascii?Q?qnnSlggRWUuuie/+90yRfIkDmabPz0h/qLwM030Bzmg0DYo3LUceNinacRYJ?= =?us-ascii?Q?SWqvAh8rcJvz54TZc3FAa3eY7dHl+semdMnv4HWddH+w3+d/4LpMa0vRAGlq?= =?us-ascii?Q?vNDZnfz70ihNisg7SRAfB9KHmYs3ZiDvKiTkVZl5gIIW7nFuz2kbSVyQ3UIx?= =?us-ascii?Q?n6Yh7QwcZh+6oRuSEcV/N4JDNnts?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:59:12.6514 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae941862-a31a-495f-7a38-08dc636b43a2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4062 Content-Type: text/plain; charset="utf-8" Add quirks table to get CPPC capabilities issue fixed by providing correct perf or frequency values while driver loading. If CPPC capabilities are not defined in the ACPI tables or wrongly defined by platform firmware, it needs to use quick to get those issues fixed with correct workaround values to make pstate driver can be loaded even though there are CPPC capabilities errors. The workaround will match the broken BIOS which lack of CPPC capabilities nominal_freq and lowest_freq definition in the ACPI table. $ cat /sys/devices/system/cpu/cpu0/acpi_cppc/lowest_freq 0 $ cat /sys/devices/system/cpu/cpu0/acpi_cppc/nominal_freq 0 Acked-by: Huang Rui Reviewed-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy Tested-by: Dhananjay Ugwekar Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 53 ++++++++++++++++++++++++++++++++++-- include/linux/amd-pstate.h | 6 ++++ 2 files changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 510b5aec42ea..83a29b257794 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -67,6 +67,7 @@ static struct cpufreq_driver amd_pstate_epp_driver; static int cppc_state =3D AMD_PSTATE_UNDEFINED; static bool cppc_enabled; static bool amd_pstate_prefcore =3D true; +static struct quirk_entry *quirks; =20 /* * AMD Energy Preference Performance (EPP) @@ -111,6 +112,41 @@ static unsigned int epp_values[] =3D { =20 typedef int (*cppc_mode_transition_fn)(int); =20 +static struct quirk_entry quirk_amd_7k62 =3D { + .nominal_freq =3D 2600, + .lowest_freq =3D 550, +}; + +static int __init dmi_matched_7k62_bios_bug(const struct dmi_system_id *dm= i) +{ + /** + * match the broken bios for family 17h processor support CPPC V2 + * broken BIOS lack of nominal_freq and lowest_freq capabilities + * definition in ACPI tables + */ + if (boot_cpu_has(X86_FEATURE_ZEN2)) { + quirks =3D dmi->driver_data; + pr_info("Overriding nominal and lowest frequencies for %s\n", dmi->ident= ); + return 1; + } + + return 0; +} + +static const struct dmi_system_id amd_pstate_quirks_table[] __initconst = =3D { + { + .callback =3D dmi_matched_7k62_bios_bug, + .ident =3D "AMD EPYC 7K62", + .matches =3D { + DMI_MATCH(DMI_BIOS_VERSION, "5.14"), + DMI_MATCH(DMI_BIOS_RELEASE, "12/12/2019"), + }, + .driver_data =3D &quirk_amd_7k62, + }, + {} +}; +MODULE_DEVICE_TABLE(dmi, amd_pstate_quirks_table); + static inline int get_mode_idx_from_str(const char *str, size_t size) { int i; @@ -812,8 +848,16 @@ static int amd_pstate_init_freq(struct amd_cpudata *cp= udata) if (ret) return ret; =20 - min_freq =3D cppc_perf.lowest_freq * 1000; - nominal_freq =3D cppc_perf.nominal_freq; + if (quirks && quirks->lowest_freq) + min_freq =3D quirks->lowest_freq * 1000; + else + min_freq =3D cppc_perf.lowest_freq * 1000; + + if (quirks && quirks->nominal_freq) + nominal_freq =3D quirks->nominal_freq ; + else + nominal_freq =3D cppc_perf.nominal_freq; + nominal_perf =3D READ_ONCE(cpudata->nominal_perf); =20 highest_perf =3D READ_ONCE(cpudata->highest_perf); @@ -1662,6 +1706,11 @@ static int __init amd_pstate_init(void) if (cpufreq_get_current_driver()) return -EEXIST; =20 + quirks =3D NULL; + + /* check if this machine need CPPC quirks */ + dmi_check_system(amd_pstate_quirks_table); + switch (cppc_state) { case AMD_PSTATE_UNDEFINED: /* Disable on the following configs by default: diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h index ab7e82533718..6b832153a126 100644 --- a/include/linux/amd-pstate.h +++ b/include/linux/amd-pstate.h @@ -128,4 +128,10 @@ static const char * const amd_pstate_mode_string[] =3D= { [AMD_PSTATE_GUIDED] =3D "guided", NULL, }; + +struct quirk_entry { + u32 nominal_freq; + u32 lowest_freq; +}; + #endif /* _LINUX_AMD_PSTATE_H */ --=20 2.34.1