From nobody Mon Feb 9 00:42:27 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AFFF57323 for ; Mon, 11 Mar 2024 21:59:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710194392; cv=none; b=dVxtcuole9KkhL7OLP2IyFe6xOxMhNLRqJV26QOgmckJuZzdmU/8a1tNkRGTudw83MCBWls3fOJpIWSwpeHrtVoixITHgIu1Zhdo9y7oCeN1RyFRkUMbKaV+byWkLv81uoM/wfVuiWb094d6oaRuAI/+/I5YrSPcGRVEoN2nhp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710194392; c=relaxed/simple; bh=sJAchNzXAv9E3hkPsb4i2oZNryNTPj084Bm1vvR01RI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tw6mP0pbqXuBYdgPFAGjXuF1wolt5I9wNiQXkZXbJwwazXmTtpefnMTbA3Xt4Q506UHcJhuJv6EzIoyyVHhCwnc/KhqWTgt52Yio/uRG3zUuIdsvcR1gZd64I/Y3Nx1fgFo0gUjGro2ozsuOBikz1Klmn0zfSAH85CHy4L1XqoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjngP-0006Cf-HI; Mon, 11 Mar 2024 22:59:45 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rjngP-005nEy-4m; Mon, 11 Mar 2024 22:59:45 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rjngP-004JCE-0E; Mon, 11 Mar 2024 22:59:45 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Andy Shevchenko Cc: Miguel Ojeda , Geert Uytterhoeven , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/3] auxdisplay: cfag12864bfb: Convert to platform remove callback returning void Date: Mon, 11 Mar 2024 22:59:22 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1758; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=sJAchNzXAv9E3hkPsb4i2oZNryNTPj084Bm1vvR01RI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl7367bct4lW/IFOLs/9zOUh9xzn0wYnWk3dwId 0a2R8FhuUaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZe9+uwAKCRCPgPtYfRL+ Tu1LB/0R5hJGYy3KJDdsu0+UxjJkjj5GaMv6AwNzlXyr2F7Q0hJD1Uro8E32M/RVbaHohHydqiF PJfmzQZt1h4NcLXyO3t10XR4Y9c11gAqylaUcwiG16rKjH3tQwnE7erQ1A/WAEiR8NZ81ojWpD6 wTloPD3/UHMidkR8Lu0QPSftuPyJgnFjlNCdRnsNVZGKg/UN09lMyrNMlbp7SjGc1HNA4NPexrP cBIMYaaywW16u7NGsoVWNY0jXfg84593oolLWUOGpYSOKBWstqnlzTtXrEXm0X1rZcKo4ras6dA /v68KJGLKq1EiPyZhqf04CuLkMDC4llPAVsdSVKP9T1LyOlP X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Acked-by: Miguel Ojeda Reviewed-by: Geert Uytterhoeven --- drivers/auxdisplay/cfag12864bfb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/auxdisplay/cfag12864bfb.c b/drivers/auxdisplay/cfag128= 64bfb.c index 5ba19c339f08..2b74dabe7e17 100644 --- a/drivers/auxdisplay/cfag12864bfb.c +++ b/drivers/auxdisplay/cfag12864bfb.c @@ -96,7 +96,7 @@ static int cfag12864bfb_probe(struct platform_device *dev= ice) return ret; } =20 -static int cfag12864bfb_remove(struct platform_device *device) +static void cfag12864bfb_remove(struct platform_device *device) { struct fb_info *info =3D platform_get_drvdata(device); =20 @@ -104,13 +104,11 @@ static int cfag12864bfb_remove(struct platform_device= *device) unregister_framebuffer(info); framebuffer_release(info); } - - return 0; } =20 static struct platform_driver cfag12864bfb_driver =3D { .probe =3D cfag12864bfb_probe, - .remove =3D cfag12864bfb_remove, + .remove_new =3D cfag12864bfb_remove, .driver =3D { .name =3D CFAG12864BFB_NAME, }, --=20 2.43.0 From nobody Mon Feb 9 00:42:27 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD41A56B7F for ; Mon, 11 Mar 2024 21:59:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710194390; cv=none; b=GqS5r5MMEy9EThla4tWbD3JwacRsNJR73slhlDyeTc0YvtJ2SXHFuBmdJdfNNkMpxMNA9W6iwnEkyUKZigCZdy+/RxbmHtQ0UpqbYsgROhzxZkPPfQjf1FjzietG4zGhsBFT7uV9or4c98rAimVznC/Yfqc2TjOO0cOA6SxdRgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710194390; c=relaxed/simple; bh=X4bTRkoZDBfqWFUU0A2YBkREN3iooCLnOateAdH0SDw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lHVg173FLB118cYFcwAuj/ojgDrav2Zthzj+aWZI8aa1BqSQx8M71EaLe5cRiBBoURoO7bx5yMuHnp2KdMjD0LVNRAHP5G6jtu64m61jZBnXgCxy0pL0k2gioopz6eICf+AhRW+b5VHOwOuo6E35S6ZXZR295FeEErALJGI+7BU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjngP-0006Cy-RM; Mon, 11 Mar 2024 22:59:45 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rjngP-005nF1-Ee; Mon, 11 Mar 2024 22:59:45 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rjngP-004JCI-1E; Mon, 11 Mar 2024 22:59:45 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Andy Shevchenko Cc: Geert Uytterhoeven , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/3] auxdisplay: hd44780: Convert to platform remove callback returning void Date: Mon, 11 Mar 2024 22:59:23 +0100 Message-ID: <868dcff909d5056be2d548a249820b61fc2f0452.1710194084.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1845; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=X4bTRkoZDBfqWFUU0A2YBkREN3iooCLnOateAdH0SDw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl7369FQPSH9c4hM0zjqBQ8uZ8qBeTc8EPc+CBF 6IBKGHBmgiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZe9+vQAKCRCPgPtYfRL+ TpF5CACoMgPE7gOxWEe31mB7e/Pzj/yKPnp5quXarQCYDDyjwNv3cJmftHLPJTTWMurY+R4WUIq dn7Bb+bd1eMVAdStJT0Gu0vtSUpKtyIXzCbQCgB7AzcuE12BU27SeLrKNPqfpk4RYMjkLbSz5NL vWabLWcrzjASL152CxQEozI1gRouh9HQipnf/LfuGNwfV515zd7s8QgP5fgZ67TSkmfRaS1IXbp QPdcGORWrD3cxvrizC36cXnc7CgnPDGpAAADoNZFE57QPn+w+34zxZa/CMXMuaE9hRMLLl9KQDL EPyD9I9uQG2g1QCKg6y13tUcufU/G2MLmQcl8YnqbMeDjjZk X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Geert Uytterhoeven --- drivers/auxdisplay/hd44780.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c index d56a5d508ccd..7ac0b1b1d548 100644 --- a/drivers/auxdisplay/hd44780.c +++ b/drivers/auxdisplay/hd44780.c @@ -319,7 +319,7 @@ static int hd44780_probe(struct platform_device *pdev) return ret; } =20 -static int hd44780_remove(struct platform_device *pdev) +static void hd44780_remove(struct platform_device *pdev) { struct charlcd *lcd =3D platform_get_drvdata(pdev); struct hd44780_common *hdc =3D lcd->drvdata; @@ -329,7 +329,6 @@ static int hd44780_remove(struct platform_device *pdev) kfree(lcd->drvdata); =20 kfree(lcd); - return 0; } =20 static const struct of_device_id hd44780_of_match[] =3D { @@ -340,7 +339,7 @@ MODULE_DEVICE_TABLE(of, hd44780_of_match); =20 static struct platform_driver hd44780_driver =3D { .probe =3D hd44780_probe, - .remove =3D hd44780_remove, + .remove_new =3D hd44780_remove, .driver =3D { .name =3D "hd44780", .of_match_table =3D hd44780_of_match, --=20 2.43.0 From nobody Mon Feb 9 00:42:27 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 954FC5788F for ; Mon, 11 Mar 2024 21:59:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710194393; cv=none; b=uLM8O1zRxzYVKYbacr/SkNEBuhXrknxj2hltLyYXQissTO/7kuRsaRUrNEG973pxITO2PcnHX8h+C7P498MLwM6n0smUGSmcMYrUEPaH4aqQrvL0oZGyshNr/gIgSlOcibQs7EFcgAXlGpLlaPTbudyBqiAgqGq0aHowieul8ew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710194393; c=relaxed/simple; bh=J0af8rTU5N8DEwYEax+Abb4w87fJFVFWbwKgVA1K+cg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L9JVgNz07k+g79L+sKb08zUwM36rJApggDF0bTAhd0N9Q+66xOenVfoRNzt0Icc5s+QRh+Gh5SSujIl4URP9dgu14xa/fW4/w93IuMjJnRG0EGxFotjB9GuG0uUZ4zqiqP+FGCaw7gAjypNUnzSGM0Pf5mLuoPgx5Xj8qroldO4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjngQ-0006D5-2f; Mon, 11 Mar 2024 22:59:46 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rjngP-005nF6-MQ; Mon, 11 Mar 2024 22:59:45 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rjngP-004JCM-1z; Mon, 11 Mar 2024 22:59:45 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Andy Shevchenko Cc: Paul Burton , Geert Uytterhoeven , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform remove callback returning void Date: Mon, 11 Mar 2024 22:59:24 +0100 Message-ID: <44de2d4c1fed6fe96b68ba9ad768d297b8f392a5.1710194084.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1840; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=J0af8rTU5N8DEwYEax+Abb4w87fJFVFWbwKgVA1K+cg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl736+kkRAF5euv5xWKRVnttsXYNGO5YcyhXrj3 zNGLmw3h8yJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZe9+vgAKCRCPgPtYfRL+ ToVrCACtgQ3byPvcqkYc7egHYXqIgIEew3R5CGgGy+npZ8Y+0SzVdhUG2/5P6BmbcT0FqxcdmU8 91OdVr0Fu0Yvf1QlczqdY5GUrl8iu6+bqHlwSJeiU69OTmhQUfPXGF8ZUhBn6zhpQN0BCgpltLG RU+5yLaU8IlkBdyHV7izWk1CzA+0tt6N19VOOAc5HDYgrCi0ZyhQkHGSMetUTw0eg9RtU/f0vrg yTt+rFSUGzp4vrLtpyCHUo/ak+AO1OXjAnP8f6Lf8atP1maFwM74RYrgfubfi3rJTZgLbF3q5IJ iYFKCZNwDDQRECgfDsY0cCwdEMLayYOo0dc2vSj6v5WR6DpK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Geert Uytterhoeven --- drivers/auxdisplay/img-ascii-lcd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-as= cii-lcd.c index 925c4cd101e9..0c91e39389c1 100644 --- a/drivers/auxdisplay/img-ascii-lcd.c +++ b/drivers/auxdisplay/img-ascii-lcd.c @@ -279,13 +279,12 @@ static int img_ascii_lcd_probe(struct platform_device= *pdev) * * Return: 0 */ -static int img_ascii_lcd_remove(struct platform_device *pdev) +static void img_ascii_lcd_remove(struct platform_device *pdev) { struct img_ascii_lcd_ctx *ctx =3D platform_get_drvdata(pdev); =20 sysfs_remove_link(&pdev->dev.kobj, "message"); linedisp_unregister(&ctx->linedisp); - return 0; } =20 static struct platform_driver img_ascii_lcd_driver =3D { @@ -294,7 +293,7 @@ static struct platform_driver img_ascii_lcd_driver =3D { .of_match_table =3D img_ascii_lcd_matches, }, .probe =3D img_ascii_lcd_probe, - .remove =3D img_ascii_lcd_remove, + .remove_new =3D img_ascii_lcd_remove, }; module_platform_driver(img_ascii_lcd_driver); =20 --=20 2.43.0