From nobody Fri Dec 26 01:20:34 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 990CD4CB55 for ; Wed, 10 Jan 2024 15:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007JH-A6; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajR-001jUY-4g; Wed, 10 Jan 2024 16:43:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajR-006c4H-0C; Wed, 10 Jan 2024 16:43:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: Rob Herring , Dmitry Torokhov , Jean Delvare , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] macintosh: therm_windtunnel: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:48 +0100 Message-ID: <74b35a7183dead9cb8359b38356e1a70e720c53e.1704900449.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1673; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=wIMIdTe+K947pJ7HyIvyj/RU52wHIptwgMFUY9QCPbU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr5l0AtXlvqg8+OuSJ+g70r7wMj9tyeZPwiL 4EQGUfHGDCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66+QAKCRCPgPtYfRL+ TtSgB/9nM0q7cqw2P3IaAJfMIWn+HNub1qIM8irQgmtAYZoKYkV59mB1pn5cLYY5yTBoYpZw95y mZiFfHFxG7AGS8Nq7Zj24IosVpvniBmrf/lkglLBMi4ruTzHZIE2XzWLFW2k9Md4nOc5usr9eb5 jmt3DbKLni6966NyStqEWQX7l4CVa/3CVk4pIwSOHyfjg+MEDjUGe7xrq3701MoQEEvVmC+Q9Sj mNA7qCdfIr0vljW6fgkFS74QllLKwPm/69+834WAoqriP1KCp8kcuL0FgQrEXDdEeAR+s6ooTHU yPRPx0O1hP8adVAAMwnhR2FnVyXVlPXycVkzdsiPMQ4vFQDf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/macintosh/therm_windtunnel.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/macintosh/therm_windtunnel.c b/drivers/macintosh/therm= _windtunnel.c index 3c1b29476ce2..37cdc6931f6d 100644 --- a/drivers/macintosh/therm_windtunnel.c +++ b/drivers/macintosh/therm_windtunnel.c @@ -481,11 +481,9 @@ static int therm_of_probe(struct platform_device *dev) return -ENODEV; } =20 -static int -therm_of_remove( struct platform_device *dev ) +static void therm_of_remove(struct platform_device *dev) { i2c_del_driver( &g4fan_driver ); - return 0; } =20 static const struct of_device_id therm_of_match[] =3D {{ @@ -501,7 +499,7 @@ static struct platform_driver therm_of_driver =3D { .of_match_table =3D therm_of_match, }, .probe =3D therm_of_probe, - .remove =3D therm_of_remove, + .remove_new =3D therm_of_remove, }; =20 struct apple_thermal_info { --=20 2.43.0 From nobody Fri Dec 26 01:20:34 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6953D4BABE for ; Wed, 10 Jan 2024 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007JI-A4; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajR-001jUb-B5; Wed, 10 Jan 2024 16:43:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajR-006c4L-0s; Wed, 10 Jan 2024 16:43:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] macintosh: windfarm_pm112: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:49 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1592; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=EDHxRAEtSZEx4PMN+NHAvrn9dvdslr8ymxAgEO6mM54=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr6o9vZrpebD10MOZdZmw5FqvDRtlGuQv/Ny lxuC0t+3OuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66+gAKCRCPgPtYfRL+ Tp7yB/44+RH1GGupIvmLoyJcQ16OpEyinOqC00OpPqyfAfbw3z9vVNi/5wuWHkgslkcesPpl8Ja efsFt7RPCCjg8rdtgPd4oW1Yf+6msVDzFuDp2fQ/yLPyaUhv4k2h74bYqoRkXhblqA3PNkGAjYa +s44DBpjCinsW2hbVAA15PG2s5LSIDJ5n4hVIf5/b7TwHJKi4mvgNpP6tk6zm2wDmb84SIztiVe k9dQKxbdZPgP6b1tKyasQ4ZjfKS7SnGJwH001v1DeS1AYBrD8322Skl6B6gC4DLZcW36LIfgnMO ppZKVTjOgghEXntnJ1uLoichovITKRqWsC4jJ8PhtoVc3wOK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/macintosh/windfarm_pm112.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/macintosh/windfarm_pm112.c b/drivers/macintosh/windfar= m_pm112.c index d1dec314ae30..876b4d8cbe37 100644 --- a/drivers/macintosh/windfarm_pm112.c +++ b/drivers/macintosh/windfarm_pm112.c @@ -662,16 +662,14 @@ static int wf_pm112_probe(struct platform_device *dev) return 0; } =20 -static int wf_pm112_remove(struct platform_device *dev) +static void wf_pm112_remove(struct platform_device *dev) { wf_unregister_client(&pm112_events); - /* should release all sensors and controls */ - return 0; } =20 static struct platform_driver wf_pm112_driver =3D { .probe =3D wf_pm112_probe, - .remove =3D wf_pm112_remove, + .remove_new =3D wf_pm112_remove, .driver =3D { .name =3D "windfarm", }, --=20 2.43.0 From nobody Fri Dec 26 01:20:34 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3DE4BAAB for ; Wed, 10 Jan 2024 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007JJ-A4; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajR-001jUe-JE; Wed, 10 Jan 2024 16:43:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajR-006c4P-1e; Wed, 10 Jan 2024 16:43:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] macintosh: windfarm_pm121: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:50 +0100 Message-ID: <36f421f845449a9700f704379105aa5f5db5dd9e.1704900449.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1549; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=ahSfaLmJWp+gaXOKoxuCz1P0tq1CJb3CsTzJGUZXrFg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr7FqpOPEO32kCs+/cZZvDnptqWO72wpcelD /JB3p5/NgqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66+wAKCRCPgPtYfRL+ Th2LCACT1HQcveropFDIDsahtIYtsDE+XV6WXUevICZiD0pzKxhcxb3akPORbEQXzEYUTvloubq wcZbyc7YSBvYeIRo/d5IAUoKT5HNb9dnuHBw8y0A+imiBj3+R1YYgzqU6Was6bqm/qaRP6f10K5 5dr1nVae+0DS4MSFFfMe+H35GenT2N7UjSJBoZHlMyCfjGJI34MnKuTG7zZ1kbIU53tjcFzjBFK EAdF9k+89qA5rY2fN+p89azvsOfnEgtAFANmxUenuxiZaMFSnKALUXhAXJaFOoB8uljmRkKMhNt jYyvxfjW3NhYMGpoIyScrnLV7JBDKcqyfZNPH2PisvlxqL3B X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/macintosh/windfarm_pm121.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfar= m_pm121.c index 82500417ebee..cd45fbc4fe1c 100644 --- a/drivers/macintosh/windfarm_pm121.c +++ b/drivers/macintosh/windfarm_pm121.c @@ -992,15 +992,14 @@ static int pm121_probe(struct platform_device *ddev) return 0; } =20 -static int pm121_remove(struct platform_device *ddev) +static void pm121_remove(struct platform_device *ddev) { wf_unregister_client(&pm121_events); - return 0; } =20 static struct platform_driver pm121_driver =3D { .probe =3D pm121_probe, - .remove =3D pm121_remove, + .remove_new =3D pm121_remove, .driver =3D { .name =3D "windfarm", .bus =3D &platform_bus_type, --=20 2.43.0 From nobody Fri Dec 26 01:20:34 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C989D4C62D for ; Wed, 10 Jan 2024 15:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007JK-A6; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajR-001jUh-PQ; Wed, 10 Jan 2024 16:43:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajR-006c4T-2J; Wed, 10 Jan 2024 16:43:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] macintosh: windfarm_pm72: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:51 +0100 Message-ID: <0406f1db35f23f66fa8a5f8c756fa456601795c4.1704900449.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1583; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=aw806HvRXreeZA5T9PNUL536MWa1crg4mYwzubfZCqM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr8BWOzxqiESpUlKHCPvCHKSw6PyFt6YKTab bdc2G3052iJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66/AAKCRCPgPtYfRL+ Tg/4CAClfdt/GaZ8eDUKP58DKL1Azfj+Hgi4v2X0clejkOaCg6LPMMu3E2Gk9+yUxfdZqdYhpZj sRWWI3WAC8nU4IjVBsT3k5Qt8sChQRoyYiA0SIvOZ8IZjbmWx5M9rLnaovj+ES8igoru/LtB7+r 8ecAZegjb09AqiVm/f3rz6PMsT6Dy5iCdq+fBkgnuvLVXZMBxlOKo37tPoQB9VbYOgfxOqIXgfk kiS8NxZosinnOR0wwr5P50CoW2aahylxzcFS9UhQ5hFsy78MGFsGMIJiZlX3At/kCSaN36GVaXH Ux/lkNTzYhpbViGyvqhDy06cNGUSxUvVg7qfnM3QIbcji5Nk X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/macintosh/windfarm_pm72.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/macintosh/windfarm_pm72.c b/drivers/macintosh/windfarm= _pm72.c index e21f973551cc..14fa1e9ac3e0 100644 --- a/drivers/macintosh/windfarm_pm72.c +++ b/drivers/macintosh/windfarm_pm72.c @@ -775,17 +775,14 @@ static int wf_pm72_probe(struct platform_device *dev) return 0; } =20 -static int wf_pm72_remove(struct platform_device *dev) +static void wf_pm72_remove(struct platform_device *dev) { wf_unregister_client(&pm72_events); - - /* should release all sensors and controls */ - return 0; } =20 static struct platform_driver wf_pm72_driver =3D { .probe =3D wf_pm72_probe, - .remove =3D wf_pm72_remove, + .remove_new =3D wf_pm72_remove, .driver =3D { .name =3D "windfarm", }, --=20 2.43.0 From nobody Fri Dec 26 01:20:34 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3673EA80 for ; Wed, 10 Jan 2024 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007JL-EX; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajS-001jUk-1Y; Wed, 10 Jan 2024 16:43:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajR-006c4X-38; Wed, 10 Jan 2024 16:43:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] macintosh: windfarm_pm81: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:52 +0100 Message-ID: <725a17c7fb1bbe6d827b38bbee40494aebf9c06d.1704900449.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1754; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=JIumVAh3vPYREF//u7bkB7EN6JDIcq7JQV0/55+tgig=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr9cGJf6iwan3BelkYvjxz1rORpYhL3KQpVA H9WZZ5TI1WJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66/QAKCRCPgPtYfRL+ TriLB/wMDX8j2YkG3CwhSFKfGseVipaO6qkUR7ahpC0Up2CnkrqOwZAobIsf3dw0Y/01I0ZNjtc 8+8LchW5znSHRLxrlQBxaCoeN1dKsRNtzRRkf+vHnAQ53cG9J3OLv7hBL1J+2WtgT6nrZ8VjLqX U1RKwAMSzpK1UzOZs1BUrfpXhNQNigflasKZUFYTfDP/uHGRtATepZ/SNqMKG0XZ9kSbVVrDEcj uNzXxdWCArERgcm9ufu+623M897Wzo6B46xttPUtXAdDQ/PsS2x6iITCaoSlbxFiffqIswxbLyE 0BzKDEr3DmmT0xNnzNC2zLxFrOt+ZszHMFOat94qUpmNvHGT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/macintosh/windfarm_pm81.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/macintosh/windfarm_pm81.c b/drivers/macintosh/windfarm= _pm81.c index 257fb2c695c5..404d2454e33d 100644 --- a/drivers/macintosh/windfarm_pm81.c +++ b/drivers/macintosh/windfarm_pm81.c @@ -724,7 +724,7 @@ static int wf_smu_probe(struct platform_device *ddev) return 0; } =20 -static int wf_smu_remove(struct platform_device *ddev) +static void wf_smu_remove(struct platform_device *ddev) { wf_unregister_client(&wf_smu_events); =20 @@ -761,13 +761,11 @@ static int wf_smu_remove(struct platform_device *ddev) /* Destroy control loops state structures */ kfree(wf_smu_sys_fans); kfree(wf_smu_cpu_fans); - - return 0; } =20 static struct platform_driver wf_smu_driver =3D { - .probe =3D wf_smu_probe, - .remove =3D wf_smu_remove, + .probe =3D wf_smu_probe, + .remove_new =3D wf_smu_remove, .driver =3D { .name =3D "windfarm", }, --=20 2.43.0 From nobody Fri Dec 26 01:20:34 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6957C4C3AC for ; Wed, 10 Jan 2024 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007Jm-KW; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajS-001jUn-7t; Wed, 10 Jan 2024 16:43:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajS-006c4b-0Y; Wed, 10 Jan 2024 16:43:06 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/7] macintosh: windfarm_pm91: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:53 +0100 Message-ID: <398f9079cacd5b87a930181c250aad2ad4d31424.1704900449.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1737; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=8aZfpoH5lzS55ahHLTUxaDk7/GZmD/HxONs4PkUDUl0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr/7dIK9PJJ+nUZAKGCKE1x+4eq/t9mns0qt c/Kvyw1SU+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66/wAKCRCPgPtYfRL+ Tj1fCACs0Dowfmv5ewZRIzj9K3M5xLJmeqHgYzUwMO4KqHsHOhLiDckbm3XJGhShydspUs6ANCD V3zLTHecUbbipJ3AzGv6XK+hHji+AIIMU+JI9CAfx8p0hypPUgsIqgCfpqWWuB58At22Z039AM9 /w8vV1uSQ9MXuGvxV68mFpm5yXf2w31t7l+3v/Nfs2ZTgjMsnXz5nBdf+mVbq3uZouNdvD6AnnZ wLlISOAkYE3fU1nk5U4nQh3SatJlZ2ruocIoZasV7cLT4aGr/cQPxmForu/QiWu2TnYUqg1JRwI YhU1U8xq/i/OFIhfs6DNXjL3sG0kmlIhjKhaP1FEcQSWWZpW X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/macintosh/windfarm_pm91.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm= _pm91.c index 120a9cfba0c5..fba02a375435 100644 --- a/drivers/macintosh/windfarm_pm91.c +++ b/drivers/macintosh/windfarm_pm91.c @@ -647,7 +647,7 @@ static int wf_smu_probe(struct platform_device *ddev) return 0; } =20 -static int wf_smu_remove(struct platform_device *ddev) +static void wf_smu_remove(struct platform_device *ddev) { wf_unregister_client(&wf_smu_events); =20 @@ -691,13 +691,11 @@ static int wf_smu_remove(struct platform_device *ddev) kfree(wf_smu_slots_fans); kfree(wf_smu_drive_fans); kfree(wf_smu_cpu_fans); - - return 0; } =20 static struct platform_driver wf_smu_driver =3D { - .probe =3D wf_smu_probe, - .remove =3D wf_smu_remove, + .probe =3D wf_smu_probe, + .remove_new =3D wf_smu_remove, .driver =3D { .name =3D "windfarm", }, --=20 2.43.0 From nobody Fri Dec 26 01:20:34 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3A94BA9C for ; Wed, 10 Jan 2024 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007Jt-Qq; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajS-001jUv-E5; Wed, 10 Jan 2024 16:43:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajS-006c4p-1B; Wed, 10 Jan 2024 16:43:06 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/7] macintosh: windfarm_rm31: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:54 +0100 Message-ID: <42358a12b38c9498b8ab2896d4f3d4eb9484b45e.1704900449.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1583; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=SYuS+JG1kCFHVDFFkk6OOKn6/bBKAGVRc6vnNPxCuB8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrsALUVJaP9KLzW4W4Q2uqO4g/+z6q6TcsNvc WtfreWrCVOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ67AAAKCRCPgPtYfRL+ TuWzB/9UqQD+sv10SjS2Ng0JuRkLQkmcXfn0JSulQ/U3YwO6FsjHeKNGSQielI8xA1GNZrbgg1I Rov5/JCaS42PHL4r8/CfNJMVmS4JyjQaJv+UaqLmQrbgnnce8wRCGEOwee6h2W/Z5JAClMV/FVZ hh4MlNfpO4WI4eOfa+d9oQbIiO2bLKh/9Jf1KDsKIXCdWiUL4+HUM1in6IK8H76kD1cO/Ppzn01 BnFZ4W9SOhIZ2hDogxc7cdLW1l1S8qv3PyK5WASJoVxRI6M78QP+ubTHh52RtSdgLOyXUJ2lDDp TQ+NnBtdlSs/fsreDGlffiw370ZeihOeb9ClesKFHeUT7FrR X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/macintosh/windfarm_rm31.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/macintosh/windfarm_rm31.c b/drivers/macintosh/windfarm= _rm31.c index e9eb7fdde48c..dc8f2c7ef103 100644 --- a/drivers/macintosh/windfarm_rm31.c +++ b/drivers/macintosh/windfarm_rm31.c @@ -668,17 +668,14 @@ static int wf_rm31_probe(struct platform_device *dev) return 0; } =20 -static int wf_rm31_remove(struct platform_device *dev) +static void wf_rm31_remove(struct platform_device *dev) { wf_unregister_client(&rm31_events); - - /* should release all sensors and controls */ - return 0; } =20 static struct platform_driver wf_rm31_driver =3D { .probe =3D wf_rm31_probe, - .remove =3D wf_rm31_remove, + .remove_new =3D wf_rm31_remove, .driver =3D { .name =3D "windfarm", }, --=20 2.43.0