From nobody Wed Dec 17 06:25:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0256C001E0 for ; Sat, 21 Oct 2023 23:12:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbjJUXMw (ORCPT ); Sat, 21 Oct 2023 19:12:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjJUXMu (ORCPT ); Sat, 21 Oct 2023 19:12:50 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEF96A3 for ; Sat, 21 Oct 2023 16:12:44 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32daeed7771so1394341f8f.3 for ; Sat, 21 Oct 2023 16:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697929963; x=1698534763; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EhZlYF/jnKgWZIepjn1KYt9HmSq9ZfWEq3tbhcGSt/s=; b=AnKsR+XYzJUFsOQg6c9GKTrSHCkEaR6Q452Oh+Io+wI5nvBLplzbtzUzYzzwCZsqfF sWnmmuPKvS6bL4DwFgmq5g1GC/bbGSca2OvfaiuqPgLAcHbXnHGLHx0ifDibdmHiXgP8 iS6URaCwdc2EH8cGghZb3eTDxFf6oWz8iFjO9e+T064RmSiJs5aOZlcN+1xdL3FKUvrv 5s9LNIcKAF0e0IZxWlCTbdTAmuMcd7123Y0bc8owGFLD03NgooGeDD4uyiAr2IMBytgi lpw6i8b+S9XNuVVCXFXoRQCYw/bV7KydlTxrg8nzOJ2lqYqaLw+1qt1fhSROfO7eNjzQ WRkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697929963; x=1698534763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EhZlYF/jnKgWZIepjn1KYt9HmSq9ZfWEq3tbhcGSt/s=; b=Et4jpfRyY9/GEsNwEpeYMMd+19f4Vj61mkjgT5iOPwGEOiqtBF+yuoIphRTySTNWaN 8fA1b6ztDpZ9jcPkmzz8XkLK4ZTfqcjL0eaQ3Vh0JOKJu9t4wKSFs88vUbVqMJYduJwS nasLWE+XTzIdG7ha42Lbav4eAHKu8l9/SgwTzXPhiArfMmLbxxpXCo13e0Mu29iP65Jd z05fDiRsJ+jSXOJ6FS/qigDt3Wep2s2554xWFSN8Rg4qf6v59pjU+XiJzVy0krlTh5F+ 0b1IpXRQHypOZ9fDnGBcCo0oQqrc7w2oO1ywooRcFRysA9vZuHk5t5wbP41RaXOf9OoI s2jw== X-Gm-Message-State: AOJu0YyB6dRJoY+46ZRGEq++Mise44DuzPfcTxTrynVfxdayP9PYV6F9 u36Zu0n8BH09/hMRb2o1OO/PkbfA7smRH7/E X-Google-Smtp-Source: AGHT+IEtkBK3neciFc03aUIrVOh+Ut2pheeqyddpfYeI8zbfLK+uF4rgtfVrgFu0Fw79p9G5On00xQ== X-Received: by 2002:adf:fd90:0:b0:32d:8a32:3b2f with SMTP id d16-20020adffd90000000b0032d8a323b2fmr3722833wrr.16.1697929963123; Sat, 21 Oct 2023 16:12:43 -0700 (PDT) Received: from gilbert-PC ([105.113.89.119]) by smtp.gmail.com with ESMTPSA id y7-20020a5d4ac7000000b0032dde679398sm4508262wrs.8.2023.10.21.16.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 16:12:42 -0700 (PDT) From: Gilbert Adikankwu To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gilbert Adikankwu Subject: [PATCH 1/5] staging: vt6655: Rename variable byCWMaxMin Date: Sun, 22 Oct 2023 00:12:27 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove byte Type encoding "by" from variable name and replace camelcase with snakecase Fix checkpatch.pl error: CHECK: Avoid CamelCase: Signed-off-by: Gilbert Adikankwu Tested-by: Philipp Hortmann --- drivers/staging/vt6655/card.c | 16 ++++++++-------- drivers/staging/vt6655/device.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index bec39c72d540..08e50311f7ba 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -184,7 +184,7 @@ static void s_vCalculateOFDMRParameter(unsigned char ra= te, */ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type) { - unsigned char byCWMaxMin =3D 0; + unsigned char cw_max_min =3D 0; unsigned char bySlot =3D 0; unsigned char bySIFS =3D 0; unsigned char byDIFS =3D 0; @@ -197,14 +197,14 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u= 8 bb_type) bySlot =3D C_SLOT_SHORT; bySIFS =3D C_SIFS_A; byDIFS =3D C_SIFS_A + 2 * C_SLOT_SHORT; - byCWMaxMin =3D 0xA4; + cw_max_min =3D 0xA4; } else if (bb_type =3D=3D BB_TYPE_11B) { vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11B); bb_write_embedded(priv, 0x88, 0x02); bySlot =3D C_SLOT_LONG; bySIFS =3D C_SIFS_BG; byDIFS =3D C_SIFS_BG + 2 * C_SLOT_LONG; - byCWMaxMin =3D 0xA5; + cw_max_min =3D 0xA5; } else { /* PK_TYPE_11GA & PK_TYPE_11GB */ vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11G); bb_write_embedded(priv, 0x88, 0x08); @@ -218,11 +218,11 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u= 8 bb_type) byDIFS =3D C_SIFS_BG + 2 * C_SLOT_LONG; } =20 - byCWMaxMin =3D 0xa4; + cw_max_min =3D 0xa4; =20 for (i =3D RATE_54M; i >=3D RATE_6M; i--) { if (priv->basic_rates & ((u32)(0x1 << i))) { - byCWMaxMin |=3D 0x1; + cw_max_min |=3D 0x1; break; } } @@ -260,9 +260,9 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) =20 bb_set_short_slot_time(priv); } - if (priv->byCWMaxMin !=3D byCWMaxMin) { - priv->byCWMaxMin =3D byCWMaxMin; - iowrite8(priv->byCWMaxMin, priv->port_offset + MAC_REG_CWMAXMIN0); + if (priv->cw_max_min !=3D cw_max_min) { + priv->cw_max_min =3D cw_max_min; + iowrite8(priv->cw_max_min, priv->port_offset + MAC_REG_CWMAXMIN0); } =20 priv->byPacketType =3D CARDbyGetPktType(priv); diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/devic= e.h index 2b5f9bf6aa5d..8ff28e4e72a4 100644 --- a/drivers/staging/vt6655/device.h +++ b/drivers/staging/vt6655/device.h @@ -185,7 +185,7 @@ struct vnt_private { unsigned char byDIFS; unsigned char byEIFS; unsigned char bySlot; - unsigned char byCWMaxMin; + unsigned char cw_max_min; =20 u8 byBBType; /* 0:11A, 1:11B, 2:11G */ u8 byPacketType; /* --=20 2.34.1 From nobody Wed Dec 17 06:25:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B04C004C0 for ; Sat, 21 Oct 2023 23:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232195AbjJUXM4 (ORCPT ); Sat, 21 Oct 2023 19:12:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbjJUXMy (ORCPT ); Sat, 21 Oct 2023 19:12:54 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E5EED78 for ; Sat, 21 Oct 2023 16:12:48 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40790b0a224so16251915e9.0 for ; Sat, 21 Oct 2023 16:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697929966; x=1698534766; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0vXZgyEKU5ol5cYhGlFd2UNXwc+nr6jp8jVrQ9cIWSU=; b=Um+3ao/sst+F1XnsSoAcIBo5bVE4mhgL0m5F043V5LgjIsZ+U5NkAsaJFsfgeuzFaQ VCUMuyxi7vdNYXkpb+1yKrM66OQuaCAh5XJ3cJ9PjLk9hzRRVMWejDZ0rMyDVd6mUjj+ IyYE2/EW3bBm7cb1UYwTKgPLaOSfVydeDAoAXgoIt6icp5tufVjiq0EPUfuzbHTydsTo FHjP91lWvpOh375c64KZhu/FC1YcG3mXgsPfq6Q+PrBZLonVXdOU8NVISC0rx+ZnK8NY uKuGT5p89+Uv0RsESsV+7aRfIqSgs6CndE3cXOdBmwONqaWYrXEBaxKagUMNVh1+E9Ja dHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697929966; x=1698534766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0vXZgyEKU5ol5cYhGlFd2UNXwc+nr6jp8jVrQ9cIWSU=; b=Ri1eAEzL/9gip5JxaXUSz4E8XwN/GUjhGYZsafmlgIf1Q50vTED7QhCs6ggMz+b23z Q0BmyxTL4aVftXH5efpOhtVoQ+EXRfr2WXmL7Kr7hzH3zI3T+V2fPHtPxFrE8scrt2Tv dqd1aTCpOJygULgswMygllWY3S3vZCA+gqEADQkdeQ3M9YylXlB5mL/Q/ZgipyUY2he3 ZIcLOyuLb81Kwy9TUhcjXM+4u6NMXzJUlHsZ98fb5VHB2NLXM9DwGvz8PnNxZPdGtwEJ eXLtLJRCnMCukvGNJYovAaxcaSwmezX2PscP2vEL5fk4sHWmVGgpxtZNSVMY588XzvnI buAQ== X-Gm-Message-State: AOJu0YwEkbGranodJq3JK+4opUi31XYppAs7LGEGSzLstQuBt7ckOIk1 ZMfyeeCQ4olgHetpMw7nDMo= X-Google-Smtp-Source: AGHT+IEOhz+zHqvkO1ijotRi7C69/N8MtDb5GnmyPn+9EKp78ZR1odKS5Dk+24cC4tmYTl3bYPfh+g== X-Received: by 2002:a05:600c:3112:b0:401:bdf9:c336 with SMTP id g18-20020a05600c311200b00401bdf9c336mr4566240wmo.27.1697929966363; Sat, 21 Oct 2023 16:12:46 -0700 (PDT) Received: from gilbert-PC ([105.113.89.119]) by smtp.gmail.com with ESMTPSA id h17-20020a05600c499100b0040772138bb7sm10250760wmp.2.2023.10.21.16.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 16:12:46 -0700 (PDT) From: Gilbert Adikankwu To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gilbert Adikankwu Subject: [PATCH 2/5] staging: vt6655: Rename variable bySlot Date: Sun, 22 Oct 2023 00:12:28 +0100 Message-Id: <57a1a08fba23d8da8ed1411d84f31f074f510444.1697927812.git.gilbertadikankwu@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove byte Type encoding "by" from variable name and replace camelcase with snakecase. Fix checkpatch.pl error: CHECK: Avoid CamelCase: Signed-off-by: Gilbert Adikankwu Tested-by: Philipp Hortmann --- drivers/staging/vt6655/card.c | 16 ++++++++-------- drivers/staging/vt6655/device.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index 08e50311f7ba..b5a87837995f 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -185,7 +185,7 @@ static void s_vCalculateOFDMRParameter(unsigned char ra= te, bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type) { unsigned char cw_max_min =3D 0; - unsigned char bySlot =3D 0; + unsigned char slot =3D 0; unsigned char bySIFS =3D 0; unsigned char byDIFS =3D 0; int i; @@ -194,14 +194,14 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u= 8 bb_type) if (bb_type =3D=3D BB_TYPE_11A) { vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11A); bb_write_embedded(priv, 0x88, 0x03); - bySlot =3D C_SLOT_SHORT; + slot =3D C_SLOT_SHORT; bySIFS =3D C_SIFS_A; byDIFS =3D C_SIFS_A + 2 * C_SLOT_SHORT; cw_max_min =3D 0xA4; } else if (bb_type =3D=3D BB_TYPE_11B) { vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11B); bb_write_embedded(priv, 0x88, 0x02); - bySlot =3D C_SLOT_LONG; + slot =3D C_SLOT_LONG; bySIFS =3D C_SIFS_BG; byDIFS =3D C_SIFS_BG + 2 * C_SLOT_LONG; cw_max_min =3D 0xA5; @@ -211,10 +211,10 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u= 8 bb_type) bySIFS =3D C_SIFS_BG; =20 if (priv->short_slot_time) { - bySlot =3D C_SLOT_SHORT; + slot =3D C_SLOT_SHORT; byDIFS =3D C_SIFS_BG + 2 * C_SLOT_SHORT; } else { - bySlot =3D C_SLOT_LONG; + slot =3D C_SLOT_LONG; byDIFS =3D C_SIFS_BG + 2 * C_SLOT_LONG; } =20 @@ -254,9 +254,9 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) priv->byEIFS =3D C_EIFS; iowrite8(priv->byEIFS, priv->port_offset + MAC_REG_EIFS); } - if (priv->bySlot !=3D bySlot) { - priv->bySlot =3D bySlot; - iowrite8(priv->bySlot, priv->port_offset + MAC_REG_SLOT); + if (priv->slot !=3D slot) { + priv->slot =3D slot; + iowrite8(priv->slot, priv->port_offset + MAC_REG_SLOT); =20 bb_set_short_slot_time(priv); } diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/devic= e.h index 8ff28e4e72a4..a63a8ddb7ff1 100644 --- a/drivers/staging/vt6655/device.h +++ b/drivers/staging/vt6655/device.h @@ -184,7 +184,7 @@ struct vnt_private { unsigned char bySIFS; unsigned char byDIFS; unsigned char byEIFS; - unsigned char bySlot; + unsigned char slot; unsigned char cw_max_min; =20 u8 byBBType; /* 0:11A, 1:11B, 2:11G */ --=20 2.34.1 From nobody Wed Dec 17 06:25:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA484C0032E for ; Sat, 21 Oct 2023 23:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232217AbjJUXM7 (ORCPT ); Sat, 21 Oct 2023 19:12:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231655AbjJUXMz (ORCPT ); Sat, 21 Oct 2023 19:12:55 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD932DF for ; Sat, 21 Oct 2023 16:12:51 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4083f613272so17400735e9.1 for ; Sat, 21 Oct 2023 16:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697929970; x=1698534770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pgihYbweOv461mq7krCIfGB4Er0uLAixEkR4tcljzVg=; b=F0/PbgBOoNmtPxAAkbI412y2I6e5Iw7JAjdN/E5ShX6SdxiPgduNOWmoSQPq2Hd4C/ ry/F+6EwZHVkNSEDbiYhX5whJDWLH3fNmUkqVn7tAvT7YziRoswrbDWzu0V+nksUGzxU O2B2WnQrZ9fOJHgbQzL0vm4cy0pZzGxnWTZ90iNPCn1qg4bhawISABtvpo0jj9V+oPOk BltYODPRPZN04qmATfXeyh4qPuZoK7BbQzYWNeW3/RUs2RCicu8wSavov010XIp8ORqh SkNHmoYrX8D7U3SVbcW6H8qTRXJhCPAAdHllJa36O13X3iPFM6FA6+bMfqBvkERWJuW3 zDlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697929970; x=1698534770; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pgihYbweOv461mq7krCIfGB4Er0uLAixEkR4tcljzVg=; b=pvwevEMBmUVDIXOfsPQ/SsIEy+6TtpAHfv5oFfuPQTnDkp1Zi0Uai6KrpJkz3Rv+U2 vY5sLnEhdUdWV8OzXJJdASb9NdHYcmwdCtB2GhFLIquMV28qnQjTpJ61LWoTRpJyC9+J mbBXfdFTkPswfFmPMmyzMl9Td4OUsJEWSLg3ORMSucb8GX3dJ1bWFIoHHilTrOLd62gX BdRf3DiRwGEOie/RjgMFLXPdEVzBoJfxjXlJ+5Xx8BeJhzsRvY3EWm1N6SqyOcTw+sJC n8Lx3WxD9E48ugK8HKay1vmm6VAaSBllt8BrVRn3t5/tfZHhN08Yj9HZ6l1ZjqvMoT+d cwCA== X-Gm-Message-State: AOJu0YxeOZGASXlDCkdv1NTGAxFlQEAwhROXPj/sohjW2sMrwJZ5eD6Z Y1b1z4zMehArUvmAF1jcxlR6kjZm34qMwh8H X-Google-Smtp-Source: AGHT+IF4yQPxDHy4u8fqqIQ6nGdZZ81GvcnTqBDt2CrhddFLnIFOB5WS+xWsqX4tsoiJEyQmEmgW5g== X-Received: by 2002:a05:600c:1396:b0:404:7659:ba39 with SMTP id u22-20020a05600c139600b004047659ba39mr4016012wmf.16.1697929969850; Sat, 21 Oct 2023 16:12:49 -0700 (PDT) Received: from gilbert-PC ([105.113.89.119]) by smtp.gmail.com with ESMTPSA id g7-20020a5d6987000000b003232380ffd7sm4511073wru.102.2023.10.21.16.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 16:12:49 -0700 (PDT) From: Gilbert Adikankwu To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gilbert Adikankwu Subject: [PATCH 3/5] staging: vt6655: Rename variable bySIFS Date: Sun, 22 Oct 2023 00:12:29 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove byte Type encoding "by" from variable name and replace camelcase with snakecase Fix checkpatch.pl error: CHECK: Avoid CamelCase: Signed-off-by: Gilbert Adikankwu Tested-by: Philipp Hortmann --- drivers/staging/vt6655/card.c | 16 ++++++++-------- drivers/staging/vt6655/device.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index b5a87837995f..48e571badfb1 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -186,7 +186,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) { unsigned char cw_max_min =3D 0; unsigned char slot =3D 0; - unsigned char bySIFS =3D 0; + unsigned char sifs =3D 0; unsigned char byDIFS =3D 0; int i; =20 @@ -195,20 +195,20 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u= 8 bb_type) vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11A); bb_write_embedded(priv, 0x88, 0x03); slot =3D C_SLOT_SHORT; - bySIFS =3D C_SIFS_A; + sifs =3D C_SIFS_A; byDIFS =3D C_SIFS_A + 2 * C_SLOT_SHORT; cw_max_min =3D 0xA4; } else if (bb_type =3D=3D BB_TYPE_11B) { vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11B); bb_write_embedded(priv, 0x88, 0x02); slot =3D C_SLOT_LONG; - bySIFS =3D C_SIFS_BG; + sifs =3D C_SIFS_BG; byDIFS =3D C_SIFS_BG + 2 * C_SLOT_LONG; cw_max_min =3D 0xA5; } else { /* PK_TYPE_11GA & PK_TYPE_11GB */ vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11G); bb_write_embedded(priv, 0x88, 0x08); - bySIFS =3D C_SIFS_BG; + sifs =3D C_SIFS_BG; =20 if (priv->short_slot_time) { slot =3D C_SLOT_SHORT; @@ -233,7 +233,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) * bcs TX_PE will reserve 3 us hardware's processing * time here is 2 us. */ - bySIFS -=3D 3; + sifs -=3D 3; byDIFS -=3D 3; /* * TX_PE will reserve 3 us for MAX2829 A mode only, it is for @@ -242,9 +242,9 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) */ } =20 - if (priv->bySIFS !=3D bySIFS) { - priv->bySIFS =3D bySIFS; - iowrite8(priv->bySIFS, priv->port_offset + MAC_REG_SIFS); + if (priv->sifs !=3D sifs) { + priv->sifs =3D sifs; + iowrite8(priv->sifs, priv->port_offset + MAC_REG_SIFS); } if (priv->byDIFS !=3D byDIFS) { priv->byDIFS =3D byDIFS; diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/devic= e.h index a63a8ddb7ff1..e6669c5f0b8b 100644 --- a/drivers/staging/vt6655/device.h +++ b/drivers/staging/vt6655/device.h @@ -181,7 +181,7 @@ struct vnt_private { unsigned int uCwMin; /* Current CwMin */ unsigned int uCwMax; /* CwMax is fixed on 1023. */ /* PHY parameter */ - unsigned char bySIFS; + unsigned char sifs; unsigned char byDIFS; unsigned char byEIFS; unsigned char slot; --=20 2.34.1 From nobody Wed Dec 17 06:25:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9812C001E0 for ; Sat, 21 Oct 2023 23:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231655AbjJUXNG (ORCPT ); Sat, 21 Oct 2023 19:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232227AbjJUXNE (ORCPT ); Sat, 21 Oct 2023 19:13:04 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23DBF10C8 for ; Sat, 21 Oct 2023 16:12:55 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4079ed65471so16877665e9.1 for ; Sat, 21 Oct 2023 16:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697929973; x=1698534773; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NaXhciQDtI63AcB9SDgDuqcYaairo+slB91oIneRn5o=; b=B4NoOF89IYWyMARdbh40zFRm0TvHH82Kth80Ewl8Zw1W0rO6thSgUKu6jWq0R1p9Px lwjb0WawpD5XKsF8lRpnGF0mr8JBfA6KENxWwfULRkNelKq5UudQZoO7NyuAMK/x1BkU KywKItCoAd+eVqONuDj1rHs5d3wAAT45plN6vhIy9+wW5ocw6ZaJKpRodm6LjIQIqQQ6 8aduQP05QLGw4QURtU79RxK+qi8oYynD/T15E2O1eH30I3a4TwH0luQ7TGfuJtIm/lR5 bvKVhx+toBh/K9oPH5FCNmy8hVL0HU1z6YhvnMsq/16M5rGvJfEk1ef/XuRlo/3qyiYf Mnbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697929973; x=1698534773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NaXhciQDtI63AcB9SDgDuqcYaairo+slB91oIneRn5o=; b=GP55unxdK2BVvvgAyX1IFj3YCzlDqyHTma7x2jQAr47iloCx2KD9tlNQN1Un3sTXDc +2xS0iGC0wQETREl9XFhsslg4dBjPqugWtUrQ3ZI4txMsaDz6XA8MRGhhIktcBHZiAZP K9vtLejyULl6hMyrrIevGEmKZANyWBAs9epieLI+/yNBvpCyrObDiLsy27qN6ZClXURs 23WBFV2MGO/H7gHATcxAU6wlP7wOxKj5Vo/+WtIEVI/17nFg85RzNY3XnSjz+a0hm46y 6zfvw7DscV/7a/wZph/JlHDJRgr6bvbSiHEX9EJ1vFy1gRhHoXFtyBCxx8footLp9Bjx zG/A== X-Gm-Message-State: AOJu0YxUllNbkb8RKyJu2QCNJfyXkBsbQ7rhPUdPdB8g4slwIHE0XDEk otqHM+zP2j7r/lZPbkd2RVExyD9QpL4+qUBS X-Google-Smtp-Source: AGHT+IE/j4x916pVyFkELwANRSWr6IFipb3aUbvMqTQ6Ci/25Qe3Yqq8DqkvkPJcBIyJrzdpu7dRMQ== X-Received: by 2002:a05:600c:4fcb:b0:405:34e4:14e3 with SMTP id o11-20020a05600c4fcb00b0040534e414e3mr4167364wmq.3.1697929973438; Sat, 21 Oct 2023 16:12:53 -0700 (PDT) Received: from gilbert-PC ([105.113.89.119]) by smtp.gmail.com with ESMTPSA id ay10-20020a05600c1e0a00b00405442edc69sm7758919wmb.14.2023.10.21.16.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 16:12:53 -0700 (PDT) From: Gilbert Adikankwu To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gilbert Adikankwu Subject: [PATCH 4/5] staging: vt6655: Rename variable byDIFS Date: Sun, 22 Oct 2023 00:12:30 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove byte Type encoding "by" from variable name and replace camelcase with snakecase Fix checkpatch.pl error: CHECK: Avoid CamelCase: Signed-off-by: Gilbert Adikankwu Tested-by: Philipp Hortmann --- drivers/staging/vt6655/card.c | 18 +++++++++--------- drivers/staging/vt6655/device.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index 48e571badfb1..9c8648ea96be 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -187,7 +187,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) unsigned char cw_max_min =3D 0; unsigned char slot =3D 0; unsigned char sifs =3D 0; - unsigned char byDIFS =3D 0; + unsigned char difs =3D 0; int i; =20 /* Set SIFS, DIFS, EIFS, SlotTime, CwMin */ @@ -196,14 +196,14 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u= 8 bb_type) bb_write_embedded(priv, 0x88, 0x03); slot =3D C_SLOT_SHORT; sifs =3D C_SIFS_A; - byDIFS =3D C_SIFS_A + 2 * C_SLOT_SHORT; + difs =3D C_SIFS_A + 2 * C_SLOT_SHORT; cw_max_min =3D 0xA4; } else if (bb_type =3D=3D BB_TYPE_11B) { vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11B); bb_write_embedded(priv, 0x88, 0x02); slot =3D C_SLOT_LONG; sifs =3D C_SIFS_BG; - byDIFS =3D C_SIFS_BG + 2 * C_SLOT_LONG; + difs =3D C_SIFS_BG + 2 * C_SLOT_LONG; cw_max_min =3D 0xA5; } else { /* PK_TYPE_11GA & PK_TYPE_11GB */ vt6655_mac_set_bb_type(priv->port_offset, BB_TYPE_11G); @@ -212,10 +212,10 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u= 8 bb_type) =20 if (priv->short_slot_time) { slot =3D C_SLOT_SHORT; - byDIFS =3D C_SIFS_BG + 2 * C_SLOT_SHORT; + difs =3D C_SIFS_BG + 2 * C_SLOT_SHORT; } else { slot =3D C_SLOT_LONG; - byDIFS =3D C_SIFS_BG + 2 * C_SLOT_LONG; + difs =3D C_SIFS_BG + 2 * C_SLOT_LONG; } =20 cw_max_min =3D 0xa4; @@ -234,7 +234,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) * time here is 2 us. */ sifs -=3D 3; - byDIFS -=3D 3; + difs -=3D 3; /* * TX_PE will reserve 3 us for MAX2829 A mode only, it is for * better TX throughput; MAC will need 2 us to process, so the @@ -246,9 +246,9 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) priv->sifs =3D sifs; iowrite8(priv->sifs, priv->port_offset + MAC_REG_SIFS); } - if (priv->byDIFS !=3D byDIFS) { - priv->byDIFS =3D byDIFS; - iowrite8(priv->byDIFS, priv->port_offset + MAC_REG_DIFS); + if (priv->difs !=3D difs) { + priv->difs =3D difs; + iowrite8(priv->difs, priv->port_offset + MAC_REG_DIFS); } if (priv->byEIFS !=3D C_EIFS) { priv->byEIFS =3D C_EIFS; diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/devic= e.h index e6669c5f0b8b..264bb056c80c 100644 --- a/drivers/staging/vt6655/device.h +++ b/drivers/staging/vt6655/device.h @@ -182,7 +182,7 @@ struct vnt_private { unsigned int uCwMax; /* CwMax is fixed on 1023. */ /* PHY parameter */ unsigned char sifs; - unsigned char byDIFS; + unsigned char difs; unsigned char byEIFS; unsigned char slot; unsigned char cw_max_min; --=20 2.34.1 From nobody Wed Dec 17 06:25:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC28AC0032E for ; Sat, 21 Oct 2023 23:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232135AbjJUXNQ (ORCPT ); Sat, 21 Oct 2023 19:13:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231515AbjJUXNO (ORCPT ); Sat, 21 Oct 2023 19:13:14 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDA4110E6 for ; Sat, 21 Oct 2023 16:12:58 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-31f71b25a99so1393542f8f.2 for ; Sat, 21 Oct 2023 16:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697929977; x=1698534777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=amjkysvwGLDMqQy/BiqSp0BajkmyMximPs7WeghdDP8=; b=Vq9xzjuobKr5c0n73r5RHo/MavdItckh4TsNWKOiZtQk93k4bD/j5dQRsgVRwlB2jF /kqiDRKnarUTSBSG6bmz0OuXjZhnE3uT7tfog15pMXR0Mm1OyCt/NfTCp9Wr94qz/HiO BlkjCriDmoTg+kSzMdvxM19/Ptk5OGnpmc4UVkYNeSRID6yWdqorVUmVOP0B1VBUFgJy /bVk9YgPdFBATJoNktQ4fsguaFlEmmyAecq6rlDMIzd2A10ZIMzwp8O34Sy5gEFX2M6L 9CKB8Wsjzb6lEDcrKUDP6BDRqjk8VpiK7K76wVLc3nnDoMzG2THtY/FcY1PaUIJqjflW 8GsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697929977; x=1698534777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=amjkysvwGLDMqQy/BiqSp0BajkmyMximPs7WeghdDP8=; b=AyVPKeQe8VPeLQiv9E8NUY0Wf5DSJ/cnc93CijQ9ptV0l4w9z/fTFh+Bqy+ktMCxAq yg5Qym8vSCfS0NcC+Jeggtpl78FvBbW/fi96D1r9YiqyhRSH5D+ZYI0jh84irP+KCAPK LKM6eBchvtYG8Fa7ri3dMtVV4sDVuFoF07MKvvwEt+wYZj8SnIzQEHnt7Z9EacxkMUQ1 JjcDfqbWuCNS8vXVrMmxoHkY7ahSeGpOoP/3ijJI+F6WbksHdan+2oNq1Bh8bogdzWPk 5n3Jst0xyCnKlLENxB0HvXGwEHMBWOK8Q+KLeij+R9f+b2DnLvhqwUf55OwJ233S8vm0 3xTg== X-Gm-Message-State: AOJu0Yxe0hng0fdXLHcET9rAgazOjkLAxOw+ZUTpPB4BuJ94xp1e5aKc oGrsWmK8KmRXu+vuCrnMAqKIar40Kni+tAMM X-Google-Smtp-Source: AGHT+IF388wDyEcE44JY0oqc4aiVNscTJNQza6DDdkdC9cj3Y1sX7vvjrj6sCaTLdYDZdpuaze36Mw== X-Received: by 2002:adf:f30e:0:b0:32d:a98c:aa1f with SMTP id i14-20020adff30e000000b0032da98caa1fmr3648237wro.1.1697929977124; Sat, 21 Oct 2023 16:12:57 -0700 (PDT) Received: from gilbert-PC ([105.113.89.119]) by smtp.gmail.com with ESMTPSA id w15-20020a5d608f000000b0032dbf32bd56sm4505098wrt.37.2023.10.21.16.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 16:12:56 -0700 (PDT) From: Gilbert Adikankwu To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gilbert Adikankwu Subject: [PATCH 5/5] staging: vt6655: Rename variable byEIFS Date: Sun, 22 Oct 2023 00:12:31 +0100 Message-Id: <4428aa96453516b6706b1a834c46e3f6e70b5828.1697927812.git.gilbertadikankwu@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove byte Type encoding "by" from variable name and replace camelcase with snakecase. Fix checkpatch.pl error: CHECK: Avoid CamelCase: Signed-off-by: Gilbert Adikankwu Tested-by: Philipp Hortmann --- drivers/staging/vt6655/card.c | 6 +++--- drivers/staging/vt6655/device.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index 9c8648ea96be..079fd01c6780 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -250,9 +250,9 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 = bb_type) priv->difs =3D difs; iowrite8(priv->difs, priv->port_offset + MAC_REG_DIFS); } - if (priv->byEIFS !=3D C_EIFS) { - priv->byEIFS =3D C_EIFS; - iowrite8(priv->byEIFS, priv->port_offset + MAC_REG_EIFS); + if (priv->eifs !=3D C_EIFS) { + priv->eifs =3D C_EIFS; + iowrite8(priv->eifs, priv->port_offset + MAC_REG_EIFS); } if (priv->slot !=3D slot) { priv->slot =3D slot; diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/devic= e.h index 264bb056c80c..7773b19a5788 100644 --- a/drivers/staging/vt6655/device.h +++ b/drivers/staging/vt6655/device.h @@ -183,7 +183,7 @@ struct vnt_private { /* PHY parameter */ unsigned char sifs; unsigned char difs; - unsigned char byEIFS; + unsigned char eifs; unsigned char slot; unsigned char cw_max_min; =20 --=20 2.34.1