From nobody Thu Jan 1 17:22:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591AEC001DF for ; Fri, 20 Oct 2023 01:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346848AbjJTBzg (ORCPT ); Thu, 19 Oct 2023 21:55:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346825AbjJTBzd (ORCPT ); Thu, 19 Oct 2023 21:55:33 -0400 Received: from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com [IPv6:2607:f8b0:4864:20::c36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB2111B for ; Thu, 19 Oct 2023 18:55:30 -0700 (PDT) Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-581e5a9413bso194489eaf.1 for ; Thu, 19 Oct 2023 18:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697766930; x=1698371730; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gK4VRLVP527Wk0wpmDeExKtEeRPAXb3C2H0so+dEMnk=; b=f/hFK7g4tbc2/Uzrs216wzIoZ+3fvQTV32NmLfZOltOT14+roOosRJKKIPKDAyEjpd P4VFV03f/9p15YD5cg8dQL6nZy+z3CCsf/jTXapYAPQ0F1xMWACikAcuxV55jEFwUfqQ Ey77MOhBy7jC3OJjFK1x6BOsX/y5n0ZGANKxG7GnC7PUUJq9IQkUKmlu+kPC6WaH60QT yA4Hl/GMCU3WAW4mC3OrmoDYSyBCt7lbfPQz7uh7ltx3bERQyTxiPeS2X4ll4SfrGmGS iZoJU9vkztfLcOA6Yl8eiCuJIxc4sSd4AdoL4go7pL4JgpzHNubnaIs490TuzxtwbLyC PbSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697766930; x=1698371730; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gK4VRLVP527Wk0wpmDeExKtEeRPAXb3C2H0so+dEMnk=; b=Rpu37zowZ1hXhnnajSgPd+KhwQIzmFFw6x754Qr4aGtE4eVxePqaPhwgh4P4FC/5fq iVcROesabQDTDFagtFSm8Mqfo4pI3PpIDZXcff4BmX+f4DbPEwffY81DT3XbhDLDASB+ 42jwfFwguHedMnGY6fBHNkjxuCVJa28lFMbNxCcswbacofAnSJQLU3tObNcaLZdKtRyM r3lyODmwNkcmrQHK/8N7/eIZsUhf9z45CGybz6WoMxB/k1BtLoRlclJ/BqSA8hEf6SbT Gt/cU59/+y3so4sQ/eJUHY+5Thdg0xor5XHLJ+bw5Rb6YoUUHK96hnqV/tT3pQfvKZY2 EEyA== X-Gm-Message-State: AOJu0YwaEgaI/35WZKqGQjgCG9ikmpVzmx4AO8QkcSVm6HLsQI7evcBV SvE/PeaS7ESQ3AEsfbv7wbk= X-Google-Smtp-Source: AGHT+IG7sdgVeroBy837E0BU6P5gj4+ZwkTbZEhu2S2KRHiDElKNoOWFF2k1XnovOi695QYHCXfHLA== X-Received: by 2002:a05:6358:9147:b0:166:e779:7ce7 with SMTP id r7-20020a056358914700b00166e7797ce7mr547975rwr.32.1697766929705; Thu, 19 Oct 2023 18:55:29 -0700 (PDT) Received: from Negi ([68.181.16.134]) by smtp.gmail.com with ESMTPSA id k17-20020aa79d11000000b006933866f49dsm431389pfp.19.2023.10.19.18.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 18:55:29 -0700 (PDT) From: Soumya Negi To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , julia.lawall@inria.fr, Andi Shyti Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Soumya Negi , Andi Shyti Subject: [PATCH v3 1/5] staging: vme_user: Replace printk() with dev_*() Date: Thu, 19 Oct 2023 18:55:19 -0700 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" vme.c uses printk() to log messages. To improve and standardize message formatting, use logging mechanisms dev_err()/dev_warn() instead. Retain the printk log levels of the messages during replacement. Issue found by checkpatch.pl Signed-off-by: Soumya Negi Acked-by: Andi Shyti --- drivers/staging/vme_user/vme.c | 175 +++++++++++++++++++-------------- 1 file changed, 99 insertions(+), 76 deletions(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index 6519a7c994a0..25f3cac641ed 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -100,8 +100,9 @@ void *vme_alloc_consistent(struct vme_resource *resourc= e, size_t size, } =20 if (!bridge->alloc_consistent) { - printk(KERN_ERR "alloc_consistent not supported by bridge %s\n", - bridge->name); + dev_err(bridge->parent, + "alloc_consistent not supported by bridge %s\n", + bridge->name); return NULL; } =20 @@ -140,8 +141,9 @@ void vme_free_consistent(struct vme_resource *resource,= size_t size, } =20 if (!bridge->free_consistent) { - printk(KERN_ERR "free_consistent not supported by bridge %s\n", - bridge->name); + dev_err(bridge->parent, + "free_consistent not supported by bridge %s\n", + bridge->name); return; } =20 @@ -161,6 +163,7 @@ EXPORT_SYMBOL(vme_free_consistent); */ size_t vme_get_size(struct vme_resource *resource) { + struct vme_bridge *bridge =3D find_bridge(resource); int enabled, retval; unsigned long long base, size; dma_addr_t buf_base; @@ -184,7 +187,7 @@ size_t vme_get_size(struct vme_resource *resource) case VME_DMA: return 0; default: - printk(KERN_ERR "Unknown resource type\n"); + dev_err(bridge->parent, "Unknown resource type\n"); return 0; } } @@ -288,14 +291,15 @@ struct vme_resource *vme_slave_request(struct vme_dev= *vdev, u32 address, =20 bridge =3D vdev->bridge; if (!bridge) { - printk(KERN_ERR "Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); goto err_bus; } =20 /* Loop through slave resources */ list_for_each_entry(slave_image, &bridge->slave_resources, list) { if (!slave_image) { - printk(KERN_ERR "Registered NULL Slave resource\n"); + dev_err(bridge->parent, + "Registered NULL Slave resource\n"); continue; } =20 @@ -362,20 +366,20 @@ int vme_slave_set(struct vme_resource *resource, int = enabled, int retval; =20 if (resource->type !=3D VME_SLAVE) { - printk(KERN_ERR "Not a slave resource\n"); + dev_err(bridge->parent, "Not a slave resource\n"); return -EINVAL; } =20 image =3D list_entry(resource->entry, struct vme_slave_resource, list); =20 if (!bridge->slave_set) { - printk(KERN_ERR "Function not supported\n"); + dev_err(bridge->parent, "Function not supported\n"); return -ENOSYS; } =20 if (!(((image->address_attr & aspace) =3D=3D aspace) && ((image->cycle_attr & cycle) =3D=3D cycle))) { - printk(KERN_ERR "Invalid attributes\n"); + dev_err(bridge->parent, "Invalid attributes\n"); return -EINVAL; } =20 @@ -411,14 +415,14 @@ int vme_slave_get(struct vme_resource *resource, int = *enabled, struct vme_slave_resource *image; =20 if (resource->type !=3D VME_SLAVE) { - printk(KERN_ERR "Not a slave resource\n"); + dev_err(bridge->parent, "Not a slave resource\n"); return -EINVAL; } =20 image =3D list_entry(resource->entry, struct vme_slave_resource, list); =20 if (!bridge->slave_get) { - printk(KERN_ERR "vme_slave_get not supported\n"); + dev_err(bridge->parent, "vme_slave_get not supported\n"); return -EINVAL; } =20 @@ -435,24 +439,25 @@ EXPORT_SYMBOL(vme_slave_get); */ void vme_slave_free(struct vme_resource *resource) { + struct vme_bridge *bridge =3D find_bridge(resource); struct vme_slave_resource *slave_image; =20 if (resource->type !=3D VME_SLAVE) { - printk(KERN_ERR "Not a slave resource\n"); + dev_err(bridge->parent, "Not a slave resource\n"); return; } =20 slave_image =3D list_entry(resource->entry, struct vme_slave_resource, list); if (!slave_image) { - printk(KERN_ERR "Can't find slave resource\n"); + dev_err(bridge->parent, "Can't find slave resource\n"); return; } =20 /* Unlock image */ mutex_lock(&slave_image->mtx); if (slave_image->locked =3D=3D 0) - printk(KERN_ERR "Image is already free\n"); + dev_err(bridge->parent, "Image is already free\n"); =20 slave_image->locked =3D 0; mutex_unlock(&slave_image->mtx); @@ -484,14 +489,15 @@ struct vme_resource *vme_master_request(struct vme_de= v *vdev, u32 address, =20 bridge =3D vdev->bridge; if (!bridge) { - printk(KERN_ERR "Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); goto err_bus; } =20 /* Loop through master resources */ list_for_each_entry(master_image, &bridge->master_resources, list) { if (!master_image) { - printk(KERN_WARNING "Registered NULL master resource\n"); + dev_warn(bridge->parent, + "Registered NULL master resource\n"); continue; } =20 @@ -511,7 +517,7 @@ struct vme_resource *vme_master_request(struct vme_dev = *vdev, u32 address, =20 /* Check to see if we found a resource */ if (!allocated_image) { - printk(KERN_ERR "Can't find a suitable resource\n"); + dev_err(&vdev->dev, "Can't find a suitable resource\n"); goto err_image; } =20 @@ -561,21 +567,21 @@ int vme_master_set(struct vme_resource *resource, int= enabled, int retval; =20 if (resource->type !=3D VME_MASTER) { - printk(KERN_ERR "Not a master resource\n"); + dev_err(bridge->parent, "Not a master resource\n"); return -EINVAL; } =20 image =3D list_entry(resource->entry, struct vme_master_resource, list); =20 if (!bridge->master_set) { - printk(KERN_WARNING "vme_master_set not supported\n"); + dev_warn(bridge->parent, "vme_master_set not supported\n"); return -EINVAL; } =20 if (!(((image->address_attr & aspace) =3D=3D aspace) && ((image->cycle_attr & cycle) =3D=3D cycle) && ((image->width_attr & dwidth) =3D=3D dwidth))) { - printk(KERN_WARNING "Invalid attributes\n"); + dev_warn(bridge->parent, "Invalid attributes\n"); return -EINVAL; } =20 @@ -611,14 +617,14 @@ int vme_master_get(struct vme_resource *resource, int= *enabled, struct vme_master_resource *image; =20 if (resource->type !=3D VME_MASTER) { - printk(KERN_ERR "Not a master resource\n"); + dev_err(bridge->parent, "Not a master resource\n"); return -EINVAL; } =20 image =3D list_entry(resource->entry, struct vme_master_resource, list); =20 if (!bridge->master_get) { - printk(KERN_WARNING "%s not supported\n", __func__); + dev_warn(bridge->parent, "%s not supported\n", __func__); return -EINVAL; } =20 @@ -650,12 +656,13 @@ ssize_t vme_master_read(struct vme_resource *resource= , void *buf, size_t count, size_t length; =20 if (!bridge->master_read) { - printk(KERN_WARNING "Reading from resource not supported\n"); + dev_warn(bridge->parent, + "Reading from resource not supported\n"); return -EINVAL; } =20 if (resource->type !=3D VME_MASTER) { - printk(KERN_ERR "Not a master resource\n"); + dev_err(bridge->parent, "Not a master resource\n"); return -EINVAL; } =20 @@ -664,7 +671,7 @@ ssize_t vme_master_read(struct vme_resource *resource, = void *buf, size_t count, length =3D vme_get_size(resource); =20 if (offset > length) { - printk(KERN_WARNING "Invalid Offset\n"); + dev_warn(bridge->parent, "Invalid Offset\n"); return -EFAULT; } =20 @@ -698,12 +705,12 @@ ssize_t vme_master_write(struct vme_resource *resourc= e, void *buf, size_t length; =20 if (!bridge->master_write) { - printk(KERN_WARNING "Writing to resource not supported\n"); + dev_warn(bridge->parent, "Writing to resource not supported\n"); return -EINVAL; } =20 if (resource->type !=3D VME_MASTER) { - printk(KERN_ERR "Not a master resource\n"); + dev_err(bridge->parent, "Not a master resource\n"); return -EINVAL; } =20 @@ -712,7 +719,7 @@ ssize_t vme_master_write(struct vme_resource *resource,= void *buf, length =3D vme_get_size(resource); =20 if (offset > length) { - printk(KERN_WARNING "Invalid Offset\n"); + dev_warn(bridge->parent, "Invalid Offset\n"); return -EFAULT; } =20 @@ -749,12 +756,12 @@ unsigned int vme_master_rmw(struct vme_resource *reso= urce, unsigned int mask, struct vme_master_resource *image; =20 if (!bridge->master_rmw) { - printk(KERN_WARNING "Writing to resource not supported\n"); + dev_warn(bridge->parent, "Writing to resource not supported\n"); return -EINVAL; } =20 if (resource->type !=3D VME_MASTER) { - printk(KERN_ERR "Not a master resource\n"); + dev_err(bridge->parent, "Not a master resource\n"); return -EINVAL; } =20 @@ -777,12 +784,13 @@ EXPORT_SYMBOL(vme_master_rmw); */ int vme_master_mmap(struct vme_resource *resource, struct vm_area_struct *= vma) { + struct vme_bridge *bridge =3D find_bridge(resource); struct vme_master_resource *image; phys_addr_t phys_addr; unsigned long vma_size; =20 if (resource->type !=3D VME_MASTER) { - pr_err("Not a master resource\n"); + dev_err(bridge->parent, "Not a master resource\n"); return -EINVAL; } =20 @@ -791,7 +799,7 @@ int vme_master_mmap(struct vme_resource *resource, stru= ct vm_area_struct *vma) vma_size =3D vma->vm_end - vma->vm_start; =20 if (phys_addr + vma_size > image->bus_resource.end + 1) { - pr_err("Map size cannot exceed the window size\n"); + dev_err(bridge->parent, "Map size cannot exceed the window size\n"); return -EFAULT; } =20 @@ -809,24 +817,25 @@ EXPORT_SYMBOL(vme_master_mmap); */ void vme_master_free(struct vme_resource *resource) { + struct vme_bridge *bridge =3D find_bridge(resource); struct vme_master_resource *master_image; =20 if (resource->type !=3D VME_MASTER) { - printk(KERN_ERR "Not a master resource\n"); + dev_err(bridge->parent, "Not a master resource\n"); return; } =20 master_image =3D list_entry(resource->entry, struct vme_master_resource, list); if (!master_image) { - printk(KERN_ERR "Can't find master resource\n"); + dev_err(bridge->parent, "Can't find master resource\n"); return; } =20 /* Unlock image */ spin_lock(&master_image->lock); if (master_image->locked =3D=3D 0) - printk(KERN_ERR "Image is already free\n"); + dev_err(bridge->parent, "Image is already free\n"); =20 master_image->locked =3D 0; spin_unlock(&master_image->lock); @@ -854,18 +863,19 @@ struct vme_resource *vme_dma_request(struct vme_dev *= vdev, u32 route) struct vme_resource *resource =3D NULL; =20 /* XXX Not checking resource attributes */ - printk(KERN_ERR "No VME resource Attribute tests done\n"); + dev_err(&vdev->dev, "No VME resource Attribute tests done\n"); =20 bridge =3D vdev->bridge; if (!bridge) { - printk(KERN_ERR "Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); goto err_bus; } =20 /* Loop through DMA resources */ list_for_each_entry(dma_ctrlr, &bridge->dma_resources, list) { if (!dma_ctrlr) { - printk(KERN_ERR "Registered NULL DMA resource\n"); + dev_err(bridge->parent, + "Registered NULL DMA resource\n"); continue; } =20 @@ -917,10 +927,11 @@ EXPORT_SYMBOL(vme_dma_request); */ struct vme_dma_list *vme_new_dma_list(struct vme_resource *resource) { + struct vme_bridge *bridge =3D find_bridge(resource); struct vme_dma_list *dma_list; =20 if (resource->type !=3D VME_DMA) { - printk(KERN_ERR "Not a DMA resource\n"); + dev_err(bridge->parent, "Not a DMA resource\n"); return NULL; } =20 @@ -1098,12 +1109,13 @@ int vme_dma_list_add(struct vme_dma_list *list, str= uct vme_dma_attr *src, int retval; =20 if (!bridge->dma_list_add) { - printk(KERN_WARNING "Link List DMA generation not supported\n"); + dev_warn(bridge->parent, + "Link List DMA generation not supported\n"); return -EINVAL; } =20 if (!mutex_trylock(&list->mtx)) { - printk(KERN_ERR "Link List already submitted\n"); + dev_err(bridge->parent, "Link List already submitted\n"); return -EINVAL; } =20 @@ -1131,7 +1143,8 @@ int vme_dma_list_exec(struct vme_dma_list *list) int retval; =20 if (!bridge->dma_list_exec) { - printk(KERN_ERR "Link List DMA execution not supported\n"); + dev_err(bridge->parent, + "Link List DMA execution not supported\n"); return -EINVAL; } =20 @@ -1160,12 +1173,13 @@ int vme_dma_list_free(struct vme_dma_list *list) int retval; =20 if (!bridge->dma_list_empty) { - printk(KERN_WARNING "Emptying of Link Lists not supported\n"); + dev_warn(bridge->parent, + "Emptying of Link Lists not supported\n"); return -EINVAL; } =20 if (!mutex_trylock(&list->mtx)) { - printk(KERN_ERR "Link List in use\n"); + dev_err(bridge->parent, "Link List in use\n"); return -EBUSY; } =20 @@ -1175,7 +1189,7 @@ int vme_dma_list_free(struct vme_dma_list *list) */ retval =3D bridge->dma_list_empty(list); if (retval) { - printk(KERN_ERR "Unable to empty link-list entries\n"); + dev_err(bridge->parent, "Unable to empty link-list entries\n"); mutex_unlock(&list->mtx); return retval; } @@ -1197,22 +1211,24 @@ EXPORT_SYMBOL(vme_dma_list_free); */ int vme_dma_free(struct vme_resource *resource) { + struct vme_bridge *bridge =3D find_bridge(resource); struct vme_dma_resource *ctrlr; =20 if (resource->type !=3D VME_DMA) { - printk(KERN_ERR "Not a DMA resource\n"); + dev_err(bridge->parent, "Not a DMA resource\n"); return -EINVAL; } =20 ctrlr =3D list_entry(resource->entry, struct vme_dma_resource, list); =20 if (!mutex_trylock(&ctrlr->mtx)) { - printk(KERN_ERR "Resource busy, can't free\n"); + dev_err(bridge->parent, "Resource busy, can't free\n"); return -EBUSY; } =20 if (!(list_empty(&ctrlr->pending) && list_empty(&ctrlr->running))) { - printk(KERN_WARNING "Resource still processing transfers\n"); + dev_warn(bridge->parent, + "Resource still processing transfers\n"); mutex_unlock(&ctrlr->mtx); return -EBUSY; } @@ -1290,8 +1306,9 @@ void vme_irq_handler(struct vme_bridge *bridge, int l= evel, int statid) if (call) call(level, statid, priv_data); else - printk(KERN_WARNING "Spurious VME interrupt, level:%x, vector:%x\n", - level, statid); + dev_warn(bridge->parent, + "Spurious VME interrupt, level:%x, vector:%x\n", level, + statid); } EXPORT_SYMBOL(vme_irq_handler); =20 @@ -1319,17 +1336,18 @@ int vme_irq_request(struct vme_dev *vdev, int level= , int statid, =20 bridge =3D vdev->bridge; if (!bridge) { - printk(KERN_ERR "Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); return -EINVAL; } =20 if ((level < 1) || (level > 7)) { - printk(KERN_ERR "Invalid interrupt level\n"); + dev_err(bridge->parent, "Invalid interrupt level\n"); return -EINVAL; } =20 if (!bridge->irq_set) { - printk(KERN_ERR "Configuring interrupts not supported\n"); + dev_err(bridge->parent, + "Configuring interrupts not supported\n"); return -EINVAL; } =20 @@ -1337,7 +1355,7 @@ int vme_irq_request(struct vme_dev *vdev, int level, = int statid, =20 if (bridge->irq[level - 1].callback[statid].func) { mutex_unlock(&bridge->irq_mtx); - printk(KERN_WARNING "VME Interrupt already taken\n"); + dev_warn(bridge->parent, "VME Interrupt already taken\n"); return -EBUSY; } =20 @@ -1368,17 +1386,18 @@ void vme_irq_free(struct vme_dev *vdev, int level, = int statid) =20 bridge =3D vdev->bridge; if (!bridge) { - printk(KERN_ERR "Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); return; } =20 if ((level < 1) || (level > 7)) { - printk(KERN_ERR "Invalid interrupt level\n"); + dev_err(bridge->parent, "Invalid interrupt level\n"); return; } =20 if (!bridge->irq_set) { - printk(KERN_ERR "Configuring interrupts not supported\n"); + dev_err(bridge->parent, + "Configuring interrupts not supported\n"); return; } =20 @@ -1415,17 +1434,18 @@ int vme_irq_generate(struct vme_dev *vdev, int leve= l, int statid) =20 bridge =3D vdev->bridge; if (!bridge) { - printk(KERN_ERR "Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); return -EINVAL; } =20 if ((level < 1) || (level > 7)) { - printk(KERN_WARNING "Invalid interrupt level\n"); + dev_warn(bridge->parent, "Invalid interrupt level\n"); return -EINVAL; } =20 if (!bridge->irq_generate) { - printk(KERN_WARNING "Interrupt generation not supported\n"); + dev_warn(bridge->parent, + "Interrupt generation not supported\n"); return -EINVAL; } =20 @@ -1452,14 +1472,15 @@ struct vme_resource *vme_lm_request(struct vme_dev = *vdev) =20 bridge =3D vdev->bridge; if (!bridge) { - printk(KERN_ERR "Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); goto err_bus; } =20 /* Loop through LM resources */ list_for_each_entry(lm, &bridge->lm_resources, list) { if (!lm) { - printk(KERN_ERR "Registered NULL Location Monitor resource\n"); + dev_err(bridge->parent, + "Registered NULL Location Monitor resource\n"); continue; } =20 @@ -1511,10 +1532,11 @@ EXPORT_SYMBOL(vme_lm_request); */ int vme_lm_count(struct vme_resource *resource) { + struct vme_bridge *bridge =3D find_bridge(resource); struct vme_lm_resource *lm; =20 if (resource->type !=3D VME_LM) { - printk(KERN_ERR "Not a Location Monitor resource\n"); + dev_err(bridge->parent, "Not a Location Monitor resource\n"); return -EINVAL; } =20 @@ -1545,14 +1567,14 @@ int vme_lm_set(struct vme_resource *resource, unsig= ned long long lm_base, struct vme_lm_resource *lm; =20 if (resource->type !=3D VME_LM) { - printk(KERN_ERR "Not a Location Monitor resource\n"); + dev_err(bridge->parent, "Not a Location Monitor resource\n"); return -EINVAL; } =20 lm =3D list_entry(resource->entry, struct vme_lm_resource, list); =20 if (!bridge->lm_set) { - printk(KERN_ERR "vme_lm_set not supported\n"); + dev_err(bridge->parent, "vme_lm_set not supported\n"); return -EINVAL; } =20 @@ -1581,14 +1603,14 @@ int vme_lm_get(struct vme_resource *resource, unsig= ned long long *lm_base, struct vme_lm_resource *lm; =20 if (resource->type !=3D VME_LM) { - printk(KERN_ERR "Not a Location Monitor resource\n"); + dev_err(bridge->parent, "Not a Location Monitor resource\n"); return -EINVAL; } =20 lm =3D list_entry(resource->entry, struct vme_lm_resource, list); =20 if (!bridge->lm_get) { - printk(KERN_ERR "vme_lm_get not supported\n"); + dev_err(bridge->parent, "vme_lm_get not supported\n"); return -EINVAL; } =20 @@ -1618,14 +1640,14 @@ int vme_lm_attach(struct vme_resource *resource, in= t monitor, struct vme_lm_resource *lm; =20 if (resource->type !=3D VME_LM) { - printk(KERN_ERR "Not a Location Monitor resource\n"); + dev_err(bridge->parent, "Not a Location Monitor resource\n"); return -EINVAL; } =20 lm =3D list_entry(resource->entry, struct vme_lm_resource, list); =20 if (!bridge->lm_attach) { - printk(KERN_ERR "vme_lm_attach not supported\n"); + dev_err(bridge->parent, "vme_lm_attach not supported\n"); return -EINVAL; } =20 @@ -1651,14 +1673,14 @@ int vme_lm_detach(struct vme_resource *resource, in= t monitor) struct vme_lm_resource *lm; =20 if (resource->type !=3D VME_LM) { - printk(KERN_ERR "Not a Location Monitor resource\n"); + dev_err(bridge->parent, "Not a Location Monitor resource\n"); return -EINVAL; } =20 lm =3D list_entry(resource->entry, struct vme_lm_resource, list); =20 if (!bridge->lm_detach) { - printk(KERN_ERR "vme_lm_detach not supported\n"); + dev_err(bridge->parent, "vme_lm_detach not supported\n"); return -EINVAL; } =20 @@ -1680,10 +1702,11 @@ EXPORT_SYMBOL(vme_lm_detach); */ void vme_lm_free(struct vme_resource *resource) { + struct vme_bridge *bridge =3D find_bridge(resource); struct vme_lm_resource *lm; =20 if (resource->type !=3D VME_LM) { - printk(KERN_ERR "Not a Location Monitor resource\n"); + dev_err(bridge->parent, "Not a Location Monitor resource\n"); return; } =20 @@ -1720,12 +1743,12 @@ int vme_slot_num(struct vme_dev *vdev) =20 bridge =3D vdev->bridge; if (!bridge) { - printk(KERN_ERR "Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); return -EINVAL; } =20 if (!bridge->slot_get) { - printk(KERN_WARNING "vme_slot_num not supported\n"); + dev_warn(bridge->parent, "vme_slot_num not supported\n"); return -EINVAL; } =20 @@ -1748,7 +1771,7 @@ int vme_bus_num(struct vme_dev *vdev) =20 bridge =3D vdev->bridge; if (!bridge) { - pr_err("Can't find VME bus\n"); + dev_err(&vdev->dev, "Can't find VME bus\n"); return -EINVAL; } =20 --=20 2.42.0 From nobody Thu Jan 1 17:22:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D5DC001E0 for ; Fri, 20 Oct 2023 01:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346852AbjJTBzo (ORCPT ); Thu, 19 Oct 2023 21:55:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346851AbjJTBzi (ORCPT ); Thu, 19 Oct 2023 21:55:38 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30EE211D for ; Thu, 19 Oct 2023 18:55:34 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6be840283ceso339787b3a.3 for ; Thu, 19 Oct 2023 18:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697766933; x=1698371733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qZ9Q+Gp8bBY1rgTAuM/1Ler9ZBRDqDxWeGeuDodFtac=; b=hIuc33ie1jNJarNh53136FwhtgEq9st0s/EB1lrZAP4X//90aYaw0JGq9r6sHSGfq4 PO339tt9XuoMk1IBfp7kPEydzpvq8sdtUmluULGOR0ZyD3IWD8to8lbRUj9rbfS3iHUT hVkM7MLYfml7EPa7qR3lXRcFxlo+kw+Ge02PQKrOGMeIcmCIsCTJpurqy9uAMRXFHlCW WarZ5v1wzEDkX4R+xWS+5UMb7SVIOEuWb1CaOEfqYIFBvUPs+/xYaysuMDKAHHVmCU1K i088CbsqB9KhUTexy8T220iIaoWWoLgxRC8clxd1QzpNZ0LKHln4E9EhCHMH1g8Buzu2 245w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697766933; x=1698371733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qZ9Q+Gp8bBY1rgTAuM/1Ler9ZBRDqDxWeGeuDodFtac=; b=wf3fZWEeWdxrgQnTzfXTEGbvoPgehwVuk0fcBuqsDwmz6nnmLc87viUo5XiMNglWZM 7Gto9scL34sFDitiFVveMwzxr6+WIYmUlaSZrEUraG+F0vCPoy3jtRn9jbmOjWIlCAeb 8SbQDfKTzZJEhA743HhJNZy2k85GIP3QawzOYEQ8QkC73hk9Jtv1Aoz3bI62b0OTz1ve 5JqwQsCh5zAWs6l1iWGrjKbWqVLv+COwzxsCtKHGeD0Cd9TzfTFAcS5WgtvuVeLtsVxa EaFcPy0dMI8QB5UBfvFvzCilkDdLiViJhMWQOizxK4FLVy8mYrCxZfkB6VOmPvs+4bzu uJ/g== X-Gm-Message-State: AOJu0Yy6H6OFyr5VlD4bgAYU7HYgDNcJJp1XDPrUQQe/w4QYgrNkb99j 1GAF5G4ADkK9GaOGpDQE9W0= X-Google-Smtp-Source: AGHT+IG5M1a+WXDPCZSl3/oRipDWqxiylVgcnshegQbxFFuTufQ6pm5x5LtkQhOgV9nJIqibYX6vGw== X-Received: by 2002:aa7:9a0e:0:b0:6be:acc:8973 with SMTP id w14-20020aa79a0e000000b006be0acc8973mr418617pfj.20.1697766933598; Thu, 19 Oct 2023 18:55:33 -0700 (PDT) Received: from Negi ([68.181.16.134]) by smtp.gmail.com with ESMTPSA id n14-20020a056a0007ce00b006bb5ff51177sm400665pfu.194.2023.10.19.18.55.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 18:55:33 -0700 (PDT) From: Soumya Negi To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , julia.lawall@inria.fr, Andi Shyti Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Soumya Negi , Andi Shyti Subject: [PATCH v3 2/5] staging: vme_user: Use __func__ instead of function name Date: Thu, 19 Oct 2023 18:55:20 -0700 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace function names in message strings with __func__ to fix all checkpatch warnings like: WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get', this function's name, in a string Signed-off-by: Soumya Negi Acked-by: Andi Shyti --- drivers/staging/vme_user/vme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index 25f3cac641ed..c36c2dc095c5 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -422,7 +422,7 @@ int vme_slave_get(struct vme_resource *resource, int *e= nabled, image =3D list_entry(resource->entry, struct vme_slave_resource, list); =20 if (!bridge->slave_get) { - dev_err(bridge->parent, "vme_slave_get not supported\n"); + dev_err(bridge->parent, "%s not supported\n", __func__); return -EINVAL; } =20 @@ -574,7 +574,7 @@ int vme_master_set(struct vme_resource *resource, int e= nabled, image =3D list_entry(resource->entry, struct vme_master_resource, list); =20 if (!bridge->master_set) { - dev_warn(bridge->parent, "vme_master_set not supported\n"); + dev_warn(bridge->parent, "%s not supported\n", __func__); return -EINVAL; } =20 @@ -1574,7 +1574,7 @@ int vme_lm_set(struct vme_resource *resource, unsigne= d long long lm_base, lm =3D list_entry(resource->entry, struct vme_lm_resource, list); =20 if (!bridge->lm_set) { - dev_err(bridge->parent, "vme_lm_set not supported\n"); + dev_err(bridge->parent, "%s not supported\n", __func__); return -EINVAL; } =20 @@ -1610,7 +1610,7 @@ int vme_lm_get(struct vme_resource *resource, unsigne= d long long *lm_base, lm =3D list_entry(resource->entry, struct vme_lm_resource, list); =20 if (!bridge->lm_get) { - dev_err(bridge->parent, "vme_lm_get not supported\n"); + dev_err(bridge->parent, "%s not supported\n", __func__); return -EINVAL; } =20 @@ -1647,7 +1647,7 @@ int vme_lm_attach(struct vme_resource *resource, int = monitor, lm =3D list_entry(resource->entry, struct vme_lm_resource, list); =20 if (!bridge->lm_attach) { - dev_err(bridge->parent, "vme_lm_attach not supported\n"); + dev_err(bridge->parent, "%s not supported\n", __func__); return -EINVAL; } =20 @@ -1680,7 +1680,7 @@ int vme_lm_detach(struct vme_resource *resource, int = monitor) lm =3D list_entry(resource->entry, struct vme_lm_resource, list); =20 if (!bridge->lm_detach) { - dev_err(bridge->parent, "vme_lm_detach not supported\n"); + dev_err(bridge->parent, "%s not supported\n", __func__); return -EINVAL; } =20 @@ -1748,7 +1748,7 @@ int vme_slot_num(struct vme_dev *vdev) } =20 if (!bridge->slot_get) { - dev_warn(bridge->parent, "vme_slot_num not supported\n"); + dev_warn(bridge->parent, "%s not supported\n", __func__); return -EINVAL; } =20 --=20 2.42.0 From nobody Thu Jan 1 17:22:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18463C001DF for ; Fri, 20 Oct 2023 01:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346863AbjJTBzq (ORCPT ); Thu, 19 Oct 2023 21:55:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346860AbjJTBzl (ORCPT ); Thu, 19 Oct 2023 21:55:41 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA660182 for ; Thu, 19 Oct 2023 18:55:37 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1ca72f8ff3aso2604995ad.0 for ; Thu, 19 Oct 2023 18:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697766937; x=1698371737; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OMzmo97xwNjH5jtNMKKmAOrNQfA+P+FBFZkUHoft9Wg=; b=NSGw8Rj6pZoLPxZ2/TKP1uiH3vKo6mc/PEgR+GamulJocczmf3Wj4bUDPdI5XLdRtK ZvmGqHj5wXyc1uIackwhKuUzZMDGm8VFjswaK2bt+FWDHgqkL72A0cnhB88R9d+ug2Mw mcU3uyKDK+ktxaaCxxRG5eDRjAO6h1ghbLvT62NaK7Pj9346JUmQGA9n8Z6QazIR415d HCxCVDvLLpAJNmRWFhXyaIRJM3pNDimryLYpTjBMDDn2rtl8/plC6mBy118xxC/E9Yji v+cF3Ioo0lscC90xgpwHdbz716EM/GTGTAJdwT8wFgjfayrjVcjiN4UmkIxhHdQzDLWQ lOKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697766937; x=1698371737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OMzmo97xwNjH5jtNMKKmAOrNQfA+P+FBFZkUHoft9Wg=; b=I8eFN6jQ/FmDdlASR1goq6xYfMVav/JxxMVPElfnxGb77zUC9hVzUFIE+63q/Ht9xO zymTqMS6VPpIz8uW3+O77PUl8+9bRDg0Lz5qMQ094d+lj76836qlLsbhLzHAqMlSd7j1 jAHst/JxIXohMTWIsRgx0uIKVxnR26+YSJ2XH8MZwNo6zSd3+y9WD14YFjINviku5DE9 K/6mplWEdxtyJUbUAIAivRoeJL2Yu/dkn/34c29GX0Qz/uHqTvDS2zW3utZnxTkEfvyu HxoUrkUfhK+Uyxd/ohhvFS0I30orX0Tvm3XfarsKYrE9rLZGjR/KYxh5z5lk2MFV1SLe BLOQ== X-Gm-Message-State: AOJu0Yw2SulIf13mWAnb546YCJYCK4WXI8mFGkYGzJ2cInGKxmETdmSA xjZrp9iYSVLmgBzIg4mzgGY= X-Google-Smtp-Source: AGHT+IEuJG7Enp8orPswkJyxWi+u1vgII7qZFIjb75ydntgjSY50fp1yxUsNF25o7HCwTzCabDgQBg== X-Received: by 2002:a17:902:e741:b0:1c9:c951:57f9 with SMTP id p1-20020a170902e74100b001c9c95157f9mr441368plf.68.1697766937089; Thu, 19 Oct 2023 18:55:37 -0700 (PDT) Received: from Negi ([68.181.16.134]) by smtp.gmail.com with ESMTPSA id w12-20020a170902d3cc00b001b8b45b177esm355544plb.274.2023.10.19.18.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 18:55:36 -0700 (PDT) From: Soumya Negi To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , julia.lawall@inria.fr, Andi Shyti Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Soumya Negi Subject: [PATCH v3 3/5] staging: vme_user: Remove printk() in find_bridge() Date: Thu, 19 Oct 2023 18:55:21 -0700 Message-ID: <028725ebbc522f73c39f5b1ec4cc2bdbdf588971.1697763267.git.soumya.negi97@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Don't log error message in find_bridge(). The printk() triggers a checkpatch warning: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... It can't be replaced by dev_err() & using pr_err() is not helpful as it doesn't give much context to the user. It is better to remove it. Signed-off-by: Soumya Negi Suggested-by: Greg Kroah-Hartman --- drivers/staging/vme_user/vme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index c36c2dc095c5..5efcdf15a068 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -62,7 +62,6 @@ static struct vme_bridge *find_bridge(struct vme_resource= *resource) return list_entry(resource->entry, struct vme_lm_resource, list)->parent; default: - printk(KERN_ERR "Unknown resource type\n"); return NULL; } } --=20 2.42.0 From nobody Thu Jan 1 17:22:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA41C0032E for ; Fri, 20 Oct 2023 01:55:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346874AbjJTBzt (ORCPT ); Thu, 19 Oct 2023 21:55:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346875AbjJTBzo (ORCPT ); Thu, 19 Oct 2023 21:55:44 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 129F3131 for ; Thu, 19 Oct 2023 18:55:41 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-27ddc1b1652so290870a91.2 for ; Thu, 19 Oct 2023 18:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697766940; x=1698371740; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rZBEMc6vewNRb3lJ4/ORiz3INshzShkDhkjWu9W5RKw=; b=mjO1w9nJGA/F/0d8HiE03hi6FkkJox4DchtoEoGprNXcMvjlGZxB/DFNmDKO3FAmVB +xNDCopRaB21kpGwK8iZO/eOqKjeoxOr23s5kV0SGaEe6BFqTWYHZPLUf0t9Iev/l+AP eIH11NVtCbB8haWp0JlPGHRnn4mEbVhEyuTRy473Ii/ofiLYtZJzC5YI+LnuCXrRRCIA mYgIeyX/Ai+j0a3HqgKymNTvCXP38vFxfqNCMLWWXRqYJM7bWo9xRR44Y0ughS07PowE xPYQW5tnYdrGYy7FwilwMCSWcWLYJB6QwEFMqV8V55K7jvD2ydcie6Yy+oFqe2RgTW0N BeMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697766940; x=1698371740; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rZBEMc6vewNRb3lJ4/ORiz3INshzShkDhkjWu9W5RKw=; b=KAH2yXF4DkOG4s/k/sooOiSVK85fsyiQm4KYWCENn8m4LmHz2zMTcP/JTkFYzSnNTU ySFmhH3yDex36rl8ouauFI4jmXe1y3NNfaExorBGkXUa945eA+iwU8sEyckYaB//3vvm 2bZXavzX6iMKnFdLpGD6IUZTwFGcrtUyFsWWKlE8VkoZkb9ZsYIWny4Ip9ybIvUivZdh w+TzgSKIuPuCw5JgIdkIe3Efwe1iwrXkqKckJ9hWttSSgxvrDNEoH1i3xBrJUFdHKXoT v10vc37vLkmn9xoO2ezw4anuY6S+bcPeHPOtZc3Gh5sy4YwicYSen7HC5q3R5C2F3bV0 VY4g== X-Gm-Message-State: AOJu0YwM3JaIbADGSo7/YJGrbvsIqje5snTPbKeJL3FhzwLwW2Kui4UU 3G0ev8bnUoBMsff4qipvd10= X-Google-Smtp-Source: AGHT+IEYSJGWt6ZmOSffMWsFL4MdYYC22lCR3Rl4+UKSXa76894eTvl4+jjkWSLXO3+2NTeNLBS9rQ== X-Received: by 2002:a17:90a:f30d:b0:27d:427f:1bf4 with SMTP id ca13-20020a17090af30d00b0027d427f1bf4mr581029pjb.19.1697766940506; Thu, 19 Oct 2023 18:55:40 -0700 (PDT) Received: from Negi ([68.181.16.134]) by smtp.gmail.com with ESMTPSA id ha8-20020a17090af3c800b0026f919ff9a1sm2232789pjb.10.2023.10.19.18.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 18:55:40 -0700 (PDT) From: Soumya Negi To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , julia.lawall@inria.fr, Andi Shyti Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Soumya Negi Subject: [PATCH v3 4/5] staging: vme_user: Remove NULL-checks Date: Thu, 19 Oct 2023 18:55:22 -0700 Message-ID: <049bbedf458e8ac40f3dfff9c9b25dce89f5b642.1697763267.git.soumya.negi97@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Don't check for empty bridge device & resource in vme_alloc_consistent() & vme_free_consistent() since they can not be NULL. Both the VME bridge device and the VME resource that are used in these functions are set at probe time. Signed-off-by: Soumya Negi Suggested-by: Greg Kroah-Hartman --- drivers/staging/vme_user/vme.c | 36 ++-------------------------------- 1 file changed, 2 insertions(+), 34 deletions(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index 5efcdf15a068..661d1edfa26a 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -80,23 +80,7 @@ static struct vme_bridge *find_bridge(struct vme_resourc= e *resource) void *vme_alloc_consistent(struct vme_resource *resource, size_t size, dma_addr_t *dma) { - struct vme_bridge *bridge; - - if (!resource) { - printk(KERN_ERR "No resource\n"); - return NULL; - } - - bridge =3D find_bridge(resource); - if (!bridge) { - printk(KERN_ERR "Can't find bridge\n"); - return NULL; - } - - if (!bridge->parent) { - printk(KERN_ERR "Dev entry NULL for bridge %s\n", bridge->name); - return NULL; - } + struct vme_bridge *bridge =3D find_bridge(resource); =20 if (!bridge->alloc_consistent) { dev_err(bridge->parent, @@ -121,23 +105,7 @@ EXPORT_SYMBOL(vme_alloc_consistent); void vme_free_consistent(struct vme_resource *resource, size_t size, void *vaddr, dma_addr_t dma) { - struct vme_bridge *bridge; - - if (!resource) { - printk(KERN_ERR "No resource\n"); - return; - } - - bridge =3D find_bridge(resource); - if (!bridge) { - printk(KERN_ERR "Can't find bridge\n"); - return; - } - - if (!bridge->parent) { - printk(KERN_ERR "Dev entry NULL for bridge %s\n", bridge->name); - return; - } + struct vme_bridge *bridge =3D find_bridge(resource); =20 if (!bridge->free_consistent) { dev_err(bridge->parent, --=20 2.42.0 From nobody Thu Jan 1 17:22:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A04C001E0 for ; Fri, 20 Oct 2023 01:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346880AbjJTBzx (ORCPT ); Thu, 19 Oct 2023 21:55:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346879AbjJTBzt (ORCPT ); Thu, 19 Oct 2023 21:55:49 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83ABE18A for ; Thu, 19 Oct 2023 18:55:46 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6be0277c05bso331520b3a.0 for ; Thu, 19 Oct 2023 18:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697766946; x=1698371746; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z0ry+kzvCHTJ148NbwYm7VhiEmbwaTHh/+gmqtzaSLw=; b=SsoWPLM08itiup3EhsdID2JndDp0CXqa7rW+TL5dQD8yHvnJPJN+xiT6CtRnhWCYkK iZyUd+xaBW1xB1daReC76bcCDgiUrZ5FEGdmEDJD7jQt65woFb0C19oLOq/DmTlCRBgh e4q2yiqgntaG26UT7pjDE7/SNcDYMvVL2ipKKj+dklnOKPkHRCy3Gepjbhkx+WogjLCo yTemiHp4XAqsQTFVKrNx9+Ouovhb3NE6TD2S9FEQLSNotdAiNRmdqRoG1zCd/WtU6VLJ Ifvcr+cK/xIvUczb+b2fUCVXhbbxzapWQENi90sfHbbN1E4AyEBtnfZZNV2uJIe+n/KR He3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697766946; x=1698371746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z0ry+kzvCHTJ148NbwYm7VhiEmbwaTHh/+gmqtzaSLw=; b=Cb4j/k44L+LNWI58uq37srf1toiCq5QLX6QW+9Pf/M5ftUH9ZWe9vw1Jzc5sJIXOKl y9JOtk9ZkFvJTsvXJ1eBwGQWSXmAc2QiYqDfT/rxMB7YITlQnhj29JcHkvbrx1HJBin7 0aggDoSlYwjPAa6yGjGk9NgDEzSeEQiPAcgi071S9440a4Uv+RLLEaqPp3g+YqmBXIAx 81M4ncXWgKpNZG2SvoF4lyh5cgcTAMIm7KgbEVKo7v7XRAQI3fk1WaLnQmAlADkYkd6v 7+DbJ+GaZPO9D2dyW6ap6b5dRETLls1XLiylMCfy+f8O33tzZlj3+U64BIeZwF/ADy9D N41Q== X-Gm-Message-State: AOJu0YzVguHzEZ0doEFtvz3n2fssXohrr6JKtfIZf8MhcnF4z8W/Ca62 JCfupx68C5Clpn/XPMbMNuGrhGVSxbR75w== X-Google-Smtp-Source: AGHT+IFn/zp+aYLsgb+V9ijWqr1uVXfLKPrE/FA7ILL1PTDKhjIgWawptYIWT2W+n4WuMOmuC1nhzQ== X-Received: by 2002:a05:6a21:7903:b0:16b:8488:babf with SMTP id bg3-20020a056a21790300b0016b8488babfmr485267pzc.35.1697766945798; Thu, 19 Oct 2023 18:55:45 -0700 (PDT) Received: from Negi ([68.181.16.134]) by smtp.gmail.com with ESMTPSA id bj11-20020a170902850b00b001b9d335223csm364784plb.26.2023.10.19.18.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 18:55:45 -0700 (PDT) From: Soumya Negi To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , julia.lawall@inria.fr, Andi Shyti Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Soumya Negi Subject: [PATCH v3 5/5] staging: vme_user: Use dev_err() in vme_check_window() Date: Thu, 19 Oct 2023 18:55:23 -0700 Message-ID: <221344ede933b1d9e6c31310b0f4dbb8be809c86.1697763267.git.soumya.negi97@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" vme_check_window() uses printk() for logging error message. This leads to the following checkpatch warning: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Use dev_err() instead. Pass VME bridge device to vme_check_window() so that the error message can be logged with the bridge device context. Signed-off-by: Soumya Negi Suggested-by: Greg Kroah-Hartman --- drivers/staging/vme_user/vme.c | 10 +++++----- drivers/staging/vme_user/vme.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index 661d1edfa26a..5c416c31ec57 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -160,8 +160,8 @@ size_t vme_get_size(struct vme_resource *resource) } EXPORT_SYMBOL(vme_get_size); =20 -int vme_check_window(u32 aspace, unsigned long long vme_base, - unsigned long long size) +int vme_check_window(struct vme_bridge *bridge, u32 aspace, + unsigned long long vme_base, unsigned long long size) { int retval =3D 0; =20 @@ -195,7 +195,7 @@ int vme_check_window(u32 aspace, unsigned long long vme= _base, /* User Defined */ break; default: - printk(KERN_ERR "Invalid address space\n"); + dev_err(bridge->parent, "Invalid address space\n"); retval =3D -EINVAL; break; } @@ -350,7 +350,7 @@ int vme_slave_set(struct vme_resource *resource, int en= abled, return -EINVAL; } =20 - retval =3D vme_check_window(aspace, vme_base, size); + retval =3D vme_check_window(bridge, aspace, vme_base, size); if (retval) return retval; =20 @@ -552,7 +552,7 @@ int vme_master_set(struct vme_resource *resource, int e= nabled, return -EINVAL; } =20 - retval =3D vme_check_window(aspace, vme_base, size); + retval =3D vme_check_window(bridge, aspace, vme_base, size); if (retval) return retval; =20 diff --git a/drivers/staging/vme_user/vme.h b/drivers/staging/vme_user/vme.h index fbcbd0204453..06504dccd5ff 100644 --- a/drivers/staging/vme_user/vme.h +++ b/drivers/staging/vme_user/vme.h @@ -133,8 +133,8 @@ void vme_free_consistent(struct vme_resource *, size_t,= void *, dma_addr_t); =20 size_t vme_get_size(struct vme_resource *); -int vme_check_window(u32 aspace, unsigned long long vme_base, - unsigned long long size); +int vme_check_window(struct vme_bridge *bridge, u32 aspace, + unsigned long long vme_base, unsigned long long size); =20 struct vme_resource *vme_slave_request(struct vme_dev *, u32, u32); int vme_slave_set(struct vme_resource *, int, unsigned long long, --=20 2.42.0