From nobody Wed Dec 17 06:26:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4C1CDB482 for ; Fri, 13 Oct 2023 14:43:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbjJMOn5 (ORCPT ); Fri, 13 Oct 2023 10:43:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232149AbjJMOnx (ORCPT ); Fri, 13 Oct 2023 10:43:53 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0780CA for ; Fri, 13 Oct 2023 07:43:50 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4053e6e8ca7so6987185e9.1 for ; Fri, 13 Oct 2023 07:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697208229; x=1697813029; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w8SaTIPv9bZSjFBzeO1OYPVCHSjabEYQBQuyencb7Ig=; b=OnjQDnIKAKNIe05JaPfBkoGwvwJCTbY6lKC+sw+R9FUrj9vTV0LKl7aFaqnfaSrnuw 7Tv3yUTgC7Den4ansQIN8WadDCktFG+bgu9EcUi9c/gwakn26ahSMIUxlp2gWI5zw9w7 JmPsxP1Le5RqexwGrM+lAcGYOPEpoxHsaAH6u25eX+CRwsaNYiTzPJxni/SeQuUinY1O uV7dW7HfQ4Y79bM13zRofzl1FFdUqBpo9io9/RLZPTlqra4PTBJXpKI9wlJGWxvb5nfF U+Zphp4sWxhJASEB6ElplVTVFEip24u5khXkHoN2pfKfMQd+up/Qo5NsM57h5YiyQ+q0 JgLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697208229; x=1697813029; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w8SaTIPv9bZSjFBzeO1OYPVCHSjabEYQBQuyencb7Ig=; b=DGX6da0mue/w2upsyYs1uRJ4ytjc6qPkB+UAeUZvJRVTxtXs2miS601umBr346ffzx z072VMJAg2hIUvhIIxdTbIC2k/GOcdpElr1TX7o0TTED1odWx9RXLulaSRl5TSM6v/9l CUmgeJ5dVG92RP+fEUB4/oktKJ7af9MXy8XeNCUVhRgwP9FdQ3nh43tTT9pGLbvRsElI QyHyHp8BfI1bPPhi7T9QlaEnxNjAukQRGwhtOfZ4dyzLZh+vcrgREbyNBZcRzTYMFk3S 2ShO5V32993Sfn2nUgiTWPnFsP1bikkEUrrVK7lRrrqAjKcKMLqc9+NNoCGwV+oJlE8b vD/Q== X-Gm-Message-State: AOJu0YwLIkdbCT/fBN1QS+SxwW5y654GTsKU0xn613/L/jGPZQVZKhQy 7rBIwdkug+zw8q/8E1Rc7bU= X-Google-Smtp-Source: AGHT+IFwtt0CK9XdJ5BjERuoJ4zOPy+UTgy0+12btgC+iqHiQaBZg/OqTFwXi3H2W8zuotSwgh5e9A== X-Received: by 2002:a05:600c:511d:b0:401:b53e:6c3e with SMTP id o29-20020a05600c511d00b00401b53e6c3emr24393440wms.1.1697208228764; Fri, 13 Oct 2023 07:43:48 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id s16-20020a05600c45d000b004063cced50bsm324486wmo.23.2023.10.13.07.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:43:48 -0700 (PDT) Date: Fri, 13 Oct 2023 16:43:46 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] staging: rtl8192e: Remove unchanged variable dig_enable_flag Message-ID: <24a9245840093c5a14124f9fc896433c7d85d18c.1697127817.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove variable dig_enable_flag as its value is set to 1 at initialization. No further writes to dig_enable_flag are done. The equations result accordingly. Remove dead code. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 11 ----------- drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 1 - 2 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 01abe1e48468..bbd18b6cc252 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -913,8 +913,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev) { struct r8192_priv *priv =3D rtllib_priv(dev); =20 - dm_digtable.dig_enable_flag =3D true; - dm_digtable.dig_algorithm =3D DIG_ALGO_BY_RSSI; =20 dm_digtable.dig_algorithm_switch =3D 0; @@ -941,9 +939,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev) =20 static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev) { - if (!dm_digtable.dig_enable_flag) - return; - if (dm_digtable.dig_algorithm =3D=3D DIG_ALGO_BY_FALSE_ALARM) _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(dev); else if (dm_digtable.dig_algorithm =3D=3D DIG_ALGO_BY_RSSI) @@ -976,9 +971,6 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(stru= ct net_device *dev) u8 i; static u8 fw_dig; =20 - if (!dm_digtable.dig_enable_flag) - return; - if (dm_digtable.dig_algorithm_switch) fw_dig =3D 0; if (fw_dig <=3D 3) { @@ -1007,9 +999,6 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_false_alar= m(struct net_device *dev) struct r8192_priv *priv =3D rtllib_priv(dev); u8 i; =20 - if (!dm_digtable.dig_enable_flag) - return; - if (dm_digtable.dig_algorithm_switch) { dm_digtable.dig_state =3D DM_STA_DIG_MAX; for (i =3D 0; i < 3; i++) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.h index 5ae2bf467158..faf08763c340 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h @@ -50,7 +50,6 @@ =20 /*------------------------------Define structure--------------------------= --*/ struct dig_t { - u8 dig_enable_flag; u8 dig_algorithm; u8 dig_algorithm_switch; =20 --=20 2.42.0 From nobody Wed Dec 17 06:26:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C2E5CDB47E for ; Fri, 13 Oct 2023 14:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232156AbjJMOoE (ORCPT ); Fri, 13 Oct 2023 10:44:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232190AbjJMOoC (ORCPT ); Fri, 13 Oct 2023 10:44:02 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 798AFBE for ; Fri, 13 Oct 2023 07:44:00 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3232e96deaaso433220f8f.0 for ; Fri, 13 Oct 2023 07:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697208239; x=1697813039; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r8MB7xPzHf04XyceB1JLxAP8TnhpBNOxPI35yzUOf6A=; b=QWCbTh31BZXVvwinJfIiDJMm76W3dm2rjieMMhl1dLm9ywjfVouoOicnu907WJwzRZ kc0CXqSPh1fhBEbHmmGtuZSW8VBRx3BQShngqQUOs2B6AA2mGOtGW4m1WhCY1xgVRBpW yLKt1granhERx84nA9SNkr3evudLFPs/V4I4Ju7Iwooa+rQHCcTFlLGRNu1zU+eE4PFd h5I69g5nxH/lOtNRxwTo1GVhMj33ZsXoqiDALfO+olClRPhJ5+zx2TsFrkZIClXq0RHI yY7KZJTTZNMxk9M7dJOfQNLDEwXtB1Gcbo+ipz+q2F8U/Z+OnpIX++nrMtK8ZLUU2zf6 /ZxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697208239; x=1697813039; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r8MB7xPzHf04XyceB1JLxAP8TnhpBNOxPI35yzUOf6A=; b=H2z3UrWMvoLsvbf9eJ9wL5KBoG7a2L/fnA2hBkltTB/biGgbk5a8AS/kj6p2oECeSH DEaxFsWM4wz5spH0wOcd8RUvGiwi1PVnbMgm5/1FJANmKqMSVeVa8Yj8uLzPZAmJ6y3d wFGStsJ9D9MUSBHX60p5b3LemN9Lz3mNKZY4dqQWD0dSIhc2UTnDV3RznEVWG5gYukxP DC/zjyshvi/U6E5GOEt6Is4i5LNIDV7uFx7niF2m49WLkZKysYp2U1vjw0cOeOno9tIH nKM0MX9DZM6lVckAP3JapBQgDeQyzVBOBmlRff/4Arjo2cwtGnnab33OHbT4yFB2l3aN LPBQ== X-Gm-Message-State: AOJu0YzUo/7+gaRoc+OiA9HwqIViAIlQfVuRFeZOOjnSp4vtLUQPtM1p wFoqAISvuoOnBa7z+RIoW53RGNhl1Dw= X-Google-Smtp-Source: AGHT+IEb9FEF2/ovxsr3Xtts6ZNg+IzB3L73Po3QSFmFUm6EynuuiaLoxiaVJz/+Ezvqx9mCF6KN/g== X-Received: by 2002:adf:cf0a:0:b0:31a:e54e:c790 with SMTP id o10-20020adfcf0a000000b0031ae54ec790mr23130655wrj.6.1697208238545; Fri, 13 Oct 2023 07:43:58 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id h12-20020a056000000c00b003176aa612b1sm20911022wrx.38.2023.10.13.07.43.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:43:58 -0700 (PDT) Date: Fri, 13 Oct 2023 16:43:56 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] staging: rtl8192e: Remove unchanged variable dig_algorithm Message-ID: <66f7275aa46e68577cc4c20582ffbd16de13f470.1697127817.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove variable dig_algorithm as its value is set to DIG_ALGO_BY_RSSI at initialization. No further writes to dig_algorithm are done. The equations result accordingly. Remove dead code. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 11 ----------- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 9 +-------- drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 1 - 3 files changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 875540a2079d..bc06c2cab35d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -920,9 +920,6 @@ void rtl92e_init_gain(struct net_device *dev, u8 Operat= ion) case IG_Backup: initial_gain =3D SCAN_RX_INITIAL_GAIN; BitMask =3D bMaskByte0; - if (dm_digtable.dig_algorithm =3D=3D - DIG_ALGO_BY_FALSE_ALARM) - rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x8); priv->initgain_backup.xaagccore1 =3D rtl92e_get_bb_reg(dev, rOFDM0_XAAGCCore1, BitMask); @@ -947,10 +944,6 @@ void rtl92e_init_gain(struct net_device *dev, u8 Opera= tion) break; case IG_Restore: BitMask =3D 0x7f; - if (dm_digtable.dig_algorithm =3D=3D - DIG_ALGO_BY_FALSE_ALARM) - rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x8); - rtl92e_set_bb_reg(dev, rOFDM0_XAAGCCore1, BitMask, (u32)priv->initgain_backup.xaagccore1); rtl92e_set_bb_reg(dev, rOFDM0_XBAGCCore1, BitMask, @@ -965,10 +958,6 @@ void rtl92e_init_gain(struct net_device *dev, u8 Opera= tion) =20 rtl92e_set_tx_power(dev, priv->rtllib->current_network.channel); - - if (dm_digtable.dig_algorithm =3D=3D - DIG_ALGO_BY_FALSE_ALARM) - rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x1); break; } } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index bbd18b6cc252..2bbc6a67188c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -913,8 +913,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev) { struct r8192_priv *priv =3D rtllib_priv(dev); =20 - dm_digtable.dig_algorithm =3D DIG_ALGO_BY_RSSI; - dm_digtable.dig_algorithm_switch =3D 0; =20 dm_digtable.dig_state =3D DM_STA_DIG_MAX; @@ -939,12 +937,7 @@ static void _rtl92e_dm_dig_init(struct net_device *dev) =20 static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev) { - if (dm_digtable.dig_algorithm =3D=3D DIG_ALGO_BY_FALSE_ALARM) - _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(dev); - else if (dm_digtable.dig_algorithm =3D=3D DIG_ALGO_BY_RSSI) - _rtl92e_dm_ctrl_initgain_byrssi_driver(dev); - else - return; + _rtl92e_dm_ctrl_initgain_byrssi_driver(dev); } =20 /*------------------------------------------------------------------------= ----- diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.h index faf08763c340..15af490d2dcd 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h @@ -50,7 +50,6 @@ =20 /*------------------------------Define structure--------------------------= --*/ struct dig_t { - u8 dig_algorithm; u8 dig_algorithm_switch; =20 long rssi_low_thresh; --=20 2.42.0 From nobody Wed Dec 17 06:26:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C75F3CDB47E for ; Fri, 13 Oct 2023 14:44:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232207AbjJMOoO (ORCPT ); Fri, 13 Oct 2023 10:44:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232183AbjJMOoL (ORCPT ); Fri, 13 Oct 2023 10:44:11 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C717ACA for ; Fri, 13 Oct 2023 07:44:08 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-405e48d8e72so5561735e9.0 for ; Fri, 13 Oct 2023 07:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697208247; x=1697813047; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2pr0IzxvU4PJX3BEoAev8yksHWUcNoh24JtDBC0yvj8=; b=MgD21UYqDQ/DEUBTumtP+Q/fEX2M6J736jyUlnOg1AnIoR31DTVokUxR2JIQd3+ujJ 1nt46gYP/M4pdvDvtXZ/NVo+0XUc3v0VHf/OOCFv2zGCPtw7wpTN5CTRSj1LAJOP6Gj8 Cmb621i+8bbIt99A35j6xed46A7anqZR8gTFlaq5RQe9npehg4esjMdVjIliS08QACcj H0ruOiKBYJJpOko5mF3DvqlwQ4oNyv/hdMPm13eVqYzOvXM4+cui+UcxiOP1f4ptnAev F0oErY361jNnhESKBb5G4ZGruDhUIMUm+R8h5sMHTDzjjuGR53eUQhA17/N2eIbQd1bm ZusA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697208247; x=1697813047; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2pr0IzxvU4PJX3BEoAev8yksHWUcNoh24JtDBC0yvj8=; b=H6GpkmxwxaUN5UoV2HvUtzuorp6K8FbNKCo5d8oxAAKYANVmqIdp0/Dc/Ap41PuITz 1hkPxxNhW5pZYrHqY738ykXgae+KGp6cTRq/h8UKOIPPxFpizVILSlkfbHpGyR1UUp6C Qs5JkiOU+RwfMombNjiAXSXj7bYY6UpaN3JdcFy7YB6xyPq9P7K3Im+sKAv4rp1jxUx3 vh5Wu/NnvqVlLGmfp43j1QjfaaNXSxknrnW0v7miKmJj3cDDd5e1gt+eaeof7cUxQps/ tnRPpGUj+ovFYs6Y+jonDkBdY0T55Kyz85jazI1x57SbsCNA4JbWPeAac1qRoA7fWo/x y4+g== X-Gm-Message-State: AOJu0YwwBdiF5xOIkI8dXxkWUxXZJoky0SxbNrFp2irXqzM9DL2XP5Ma m/ekDBtd58PQdkKyypD9qOk= X-Google-Smtp-Source: AGHT+IHtZomzfKRt/2/71UhVOm+Uh/gqPQFN82UqGQjXbQNaaKC0vahQ2HX9x92+okKCLYnYUJrtcQ== X-Received: by 2002:a05:600c:3c96:b0:403:334:fb0d with SMTP id bg22-20020a05600c3c9600b004030334fb0dmr24327640wmb.4.1697208246738; Fri, 13 Oct 2023 07:44:06 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id r15-20020a05600c35cf00b00401e32b25adsm333362wmq.4.2023.10.13.07.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:44:06 -0700 (PDT) Date: Fri, 13 Oct 2023 16:44:05 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] staging: rtl8192e: Remove _rtl92e_dm_ctrl_initgain_byrssi_false_alarm() Message-ID: <80a5a0b67d9d225a58c96781c33e2216c0ea1c6e.1697127817.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function _rtl92e_dm_ctrl_initgain_byrssi_false_alarm() as it is unused. Remove in above function called function _rtl92e_dm_ctrl_initgain_byrssi_highpwr() as well. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 115 --------------------- 1 file changed, 115 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 2bbc6a67188c..e69c22e5d205 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -163,9 +163,7 @@ static void _rtl92e_dm_check_tx_power_tracking(struct n= et_device *dev); =20 static void _rtl92e_dm_dig_init(struct net_device *dev); static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev); -static void _rtl92e_dm_ctrl_initgain_byrssi_highpwr(struct net_device *dev= ); static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev); -static void _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(struct net_device = *dev); static void _rtl92e_dm_initial_gain(struct net_device *dev); static void _rtl92e_dm_pd_th(struct net_device *dev); static void _rtl92e_dm_cs_ratio(struct net_device *dev); @@ -987,119 +985,6 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(st= ruct net_device *dev) dm_digtable.pre_sta_connect_state =3D dm_digtable.cur_sta_connect_state; } =20 -static void _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(struct net_device = *dev) -{ - struct r8192_priv *priv =3D rtllib_priv(dev); - u8 i; - - if (dm_digtable.dig_algorithm_switch) { - dm_digtable.dig_state =3D DM_STA_DIG_MAX; - for (i =3D 0; i < 3; i++) - rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x1); - dm_digtable.dig_algorithm_switch =3D 0; - } - - if (priv->rtllib->link_state !=3D MAC80211_LINKED) - return; - - if ((priv->undecorated_smoothed_pwdb > dm_digtable.rssi_low_thresh) && - (priv->undecorated_smoothed_pwdb < dm_digtable.rssi_high_thresh)) - return; - if (priv->undecorated_smoothed_pwdb <=3D dm_digtable.rssi_low_thresh) { - if (dm_digtable.dig_state =3D=3D DM_STA_DIG_OFF) - return; - - dm_digtable.dig_highpwr_state =3D DM_STA_DIG_MAX; - dm_digtable.dig_state =3D DM_STA_DIG_OFF; - - rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x8); - - rtl92e_writeb(dev, rOFDM0_XAAGCCore1, 0x17); - rtl92e_writeb(dev, rOFDM0_XBAGCCore1, 0x17); - rtl92e_writeb(dev, rOFDM0_XCAGCCore1, 0x17); - rtl92e_writeb(dev, rOFDM0_XDAGCCore1, 0x17); - - if (priv->current_chnl_bw !=3D HT_CHANNEL_WIDTH_20) - rtl92e_writeb(dev, (rOFDM0_XATxAFE + 3), 0x00); - else - rtl92e_writeb(dev, rOFDM0_RxDetector1, 0x42); - - rtl92e_writeb(dev, 0xa0a, 0x08); - - return; - } - - if (priv->undecorated_smoothed_pwdb >=3D dm_digtable.rssi_high_thresh) { - u8 reset_flag =3D 0; - - if (dm_digtable.dig_state =3D=3D DM_STA_DIG_ON) { - _rtl92e_dm_ctrl_initgain_byrssi_highpwr(dev); - return; - } - - dm_digtable.dig_state =3D DM_STA_DIG_ON; - - if (reset_flag =3D=3D 1) { - rtl92e_writeb(dev, rOFDM0_XAAGCCore1, 0x2c); - rtl92e_writeb(dev, rOFDM0_XBAGCCore1, 0x2c); - rtl92e_writeb(dev, rOFDM0_XCAGCCore1, 0x2c); - rtl92e_writeb(dev, rOFDM0_XDAGCCore1, 0x2c); - } else { - rtl92e_writeb(dev, rOFDM0_XAAGCCore1, 0x20); - rtl92e_writeb(dev, rOFDM0_XBAGCCore1, 0x20); - rtl92e_writeb(dev, rOFDM0_XCAGCCore1, 0x20); - rtl92e_writeb(dev, rOFDM0_XDAGCCore1, 0x20); - } - - if (priv->current_chnl_bw !=3D HT_CHANNEL_WIDTH_20) - rtl92e_writeb(dev, (rOFDM0_XATxAFE + 3), 0x20); - else - rtl92e_writeb(dev, rOFDM0_RxDetector1, 0x44); - - rtl92e_writeb(dev, 0xa0a, 0xcd); - - rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x1); - } - _rtl92e_dm_ctrl_initgain_byrssi_highpwr(dev); -} - -static void _rtl92e_dm_ctrl_initgain_byrssi_highpwr(struct net_device *dev) -{ - struct r8192_priv *priv =3D rtllib_priv(dev); - - if ((priv->undecorated_smoothed_pwdb > - dm_digtable.rssi_high_power_lowthresh) && - (priv->undecorated_smoothed_pwdb < - dm_digtable.rssi_high_power_highthresh)) - return; - - if (priv->undecorated_smoothed_pwdb >=3D - dm_digtable.rssi_high_power_highthresh) { - if (dm_digtable.dig_highpwr_state =3D=3D DM_STA_DIG_ON) - return; - dm_digtable.dig_highpwr_state =3D DM_STA_DIG_ON; - - if (priv->current_chnl_bw !=3D HT_CHANNEL_WIDTH_20) - rtl92e_writeb(dev, (rOFDM0_XATxAFE + 3), 0x10); - else - rtl92e_writeb(dev, rOFDM0_RxDetector1, 0x43); - } else { - if (dm_digtable.dig_highpwr_state =3D=3D DM_STA_DIG_OFF) - return; - dm_digtable.dig_highpwr_state =3D DM_STA_DIG_OFF; - - if ((priv->undecorated_smoothed_pwdb < - dm_digtable.rssi_high_power_lowthresh) && - (priv->undecorated_smoothed_pwdb >=3D - dm_digtable.rssi_high_thresh)) { - if (priv->current_chnl_bw !=3D HT_CHANNEL_WIDTH_20) - rtl92e_writeb(dev, (rOFDM0_XATxAFE + 3), 0x20); - else - rtl92e_writeb(dev, rOFDM0_RxDetector1, 0x44); - } - } -} - static void _rtl92e_dm_initial_gain(struct net_device *dev) { struct r8192_priv *priv =3D rtllib_priv(dev); --=20 2.42.0 From nobody Wed Dec 17 06:26:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB35CCDB47E for ; Fri, 13 Oct 2023 14:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232191AbjJMOoV (ORCPT ); Fri, 13 Oct 2023 10:44:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232229AbjJMOoS (ORCPT ); Fri, 13 Oct 2023 10:44:18 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 860F7DA for ; Fri, 13 Oct 2023 07:44:14 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3232e96deaaso433248f8f.0 for ; Fri, 13 Oct 2023 07:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697208253; x=1697813053; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Vm9Boe/IQ1CKHp5Z4OotYOocbOOmHzj4fbuWIiiw6vc=; b=YGgN47LwEW41wv09+lrcTOKCWba+JJfw/Eh0fznfHGQK79bGwJukCOw52QoRssNJ/O zrd7DMdKAS4b0Oe/JW3fefUoH0VKnx6FmOVpEBf5brGNX9VXiqVRZwNZRG4KKbGNx7ey ohdrL9lhzEnkKFVDP8it3Vi0m10rNbBHmsC1t2xUI2RAbVf2y7JL8P1ZqQqhl3zWaMJ1 SFGwudh/jH/tSb5HmEi0yB0DiHGBUZEmMKhuMH6y2R48I1hd184WW9gxulKxWrdLM3p1 Ez0p6XhcDgpLtz77WEtnXGGZqMHO4E6p/KuLGEhCmHwHiaB6Sk5b0eIyFiS/3Vqigfuk Slmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697208253; x=1697813053; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vm9Boe/IQ1CKHp5Z4OotYOocbOOmHzj4fbuWIiiw6vc=; b=nPYmitoa8pmnmoMkEHZMnI+6Ldmu67J5eJ0Hig0MMMKDBkAtRfS+nZkdpqxF7Ol0h4 ejEhuld7L3zrP2pJGs5NmfweffC7ywSUTQZXmle41AU9TO2dBvONC1lcrRvbKjsmf0/T eFGCwcYA8H07Abu69Puij2zN6/RBTu2hXfsJdSYeWuXZYU1BphWIUX5QbG4igs+mK/Hf zwN3G/a6BKjCwWu1wQxUfBWowNB84AmGtcWiEvaPiEeW6i/cFljVIVvpOHnjlAYnYnWQ QFwsFTFUsBiD3SHaCov7gq8pzcUKCImEoJAJQL7lTwHsmco6AgHB2caFHHQONmlgO+pV zU8Q== X-Gm-Message-State: AOJu0YyR5WYdgXSyDMIx419qoWJc4WAihPUx1g348KJb9UX18MqumyX6 VlK0L+kZK1GxbSSpP4ibfb0= X-Google-Smtp-Source: AGHT+IH48KHg/LzodbjMHv7fJ3mhlY9Z6dAer1u3kPbEDpMrh+GBR9WyOudn2nEe1Np50VTK4aCYNQ== X-Received: by 2002:adf:ab49:0:b0:32d:974b:6dde with SMTP id r9-20020adfab49000000b0032d974b6ddemr2356312wrc.0.1697208252846; Fri, 13 Oct 2023 07:44:12 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id n14-20020a05600c4f8e00b00405bbfd5d16sm337950wmq.7.2023.10.13.07.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:44:12 -0700 (PDT) Date: Fri, 13 Oct 2023 16:44:11 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/6] staging: rtl8192e: Remove unchanged variable dig_algorithm_switch Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove variable dig_algorithm_switch as its value is set to 0 at initialization. The equations result accordingly. Remove dead code. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 18 ------------------ drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 2 -- 2 files changed, 20 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index e69c22e5d205..0bd9211500ac 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -911,8 +911,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev) { struct r8192_priv *priv =3D rtllib_priv(dev); =20 - dm_digtable.dig_algorithm_switch =3D 0; - dm_digtable.dig_state =3D DM_STA_DIG_MAX; dm_digtable.dig_highpwr_state =3D DM_STA_DIG_MAX; dm_digtable.cur_sta_connect_state =3D DIG_STA_DISCONNECT; @@ -962,8 +960,6 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(stru= ct net_device *dev) u8 i; static u8 fw_dig; =20 - if (dm_digtable.dig_algorithm_switch) - fw_dig =3D 0; if (fw_dig <=3D 3) { for (i =3D 0; i < 3; i++) rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x8); @@ -980,8 +976,6 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(stru= ct net_device *dev) _rtl92e_dm_initial_gain(dev); _rtl92e_dm_pd_th(dev); _rtl92e_dm_cs_ratio(dev); - if (dm_digtable.dig_algorithm_switch) - dm_digtable.dig_algorithm_switch =3D 0; dm_digtable.pre_sta_connect_state =3D dm_digtable.cur_sta_connect_state; } =20 @@ -991,10 +985,6 @@ static void _rtl92e_dm_initial_gain(struct net_device = *dev) u8 initial_gain =3D 0; static u8 initialized, force_write; =20 - if (dm_digtable.dig_algorithm_switch) { - initialized =3D 0; - } - if (rtllib_act_scanning(priv->rtllib, true)) { force_write =3D 1; return; @@ -1040,10 +1030,6 @@ static void _rtl92e_dm_pd_th(struct net_device *dev) struct r8192_priv *priv =3D rtllib_priv(dev); static u8 initialized, force_write; =20 - if (dm_digtable.dig_algorithm_switch) { - initialized =3D 0; - } - if (dm_digtable.pre_sta_connect_state =3D=3D dm_digtable.cur_sta_connect_= state) { if (dm_digtable.cur_sta_connect_state =3D=3D DIG_STA_CONNECT) { if (dm_digtable.rssi_val >=3D @@ -1100,10 +1086,6 @@ static void _rtl92e_dm_cs_ratio(struct net_device *d= ev) { static u8 initialized, force_write; =20 - if (dm_digtable.dig_algorithm_switch) { - initialized =3D 0; - } - if (dm_digtable.pre_sta_connect_state =3D=3D dm_digtable.cur_sta_connect_= state) { if (dm_digtable.cur_sta_connect_state =3D=3D DIG_STA_CONNECT) { if (dm_digtable.rssi_val <=3D dm_digtable.rssi_low_thresh) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.h index 15af490d2dcd..12b7d426b6b9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h @@ -50,8 +50,6 @@ =20 /*------------------------------Define structure--------------------------= --*/ struct dig_t { - u8 dig_algorithm_switch; - long rssi_low_thresh; long rssi_high_thresh; =20 --=20 2.42.0 From nobody Wed Dec 17 06:26:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA6ECDB47E for ; Fri, 13 Oct 2023 14:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232220AbjJMOo2 (ORCPT ); Fri, 13 Oct 2023 10:44:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232221AbjJMOoZ (ORCPT ); Fri, 13 Oct 2023 10:44:25 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37353C9 for ; Fri, 13 Oct 2023 07:44:21 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40651b22977so5492125e9.1 for ; Fri, 13 Oct 2023 07:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697208259; x=1697813059; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R65tSR19h2ERSFEN/PYuOVhJkp4kEom7jNZNDOgm2Dw=; b=bPyns9HJZ8LzVjZbVF6AV0LSRiY1aIiSuNxqsoqUYzJOtxJot51Y+OJJEyUAhNwFTp 8TLvxRumhNGo0kdjUzboyrErwFrzHx7pb3oSHh00G2u6O6xSdZQvWJ8b5BhnUlaUNb0u cU3Op11Xiq21mvnnyxT9hOXPuUI/7Uc5+bkqG0jmBVMx8tmgsgknVEaeFQ5e5bCbtY6H 8tpWMBvSps6Vr3tx50EUcLE+19wLeJv2UZXDqa85V6qZL7I3u7bBKWXogLrn5XXrFhva FxxdEs82gy6/isN93j/oe9G8vXunxAy4GGbDrgqbMtfi6f88r498JWYoEosNEjkmZfgh 9tpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697208259; x=1697813059; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R65tSR19h2ERSFEN/PYuOVhJkp4kEom7jNZNDOgm2Dw=; b=C1E8YJ7v3TIN8ro6zf6u0/iN+q3DY+WjUJsMnl8lvLeSbQeaB4vhOADVR4jUK4/bWK JVxXtX2EWLtHDP4fDmEtuJzgn6rIEmxSQjR6CnJI0Se/EzHih4VvzVBLrTJOQ4/jpyle 955Nu6y44bWTEJoDf8jI7Ss7c5JqYTRjjmwNl+o+/Hkd7jBslr/4K9dCwZSlBaQ/QGMr MYFSeouGWtA8h+tQYXY4xkuw+NqzhmpUzcT2vQoAVz4z69ZTx0R91bpWgL9wZkG0Lc8X yB3zv4HakRhN3JWl57ASEC7cgpFyEGPlH4Z87yQUCepWZvMs2ZBbpOUQSjTpgCnQXObp S71Q== X-Gm-Message-State: AOJu0YyKY3SP2X0TybXhp7NS7cLPVd8MzmU0owAzuDztSbjbyCRQlRc1 Onc6gC5fmWq3wx4kLsFAPDk= X-Google-Smtp-Source: AGHT+IHYPPr6sH0xTh0JgXu27oRZb4vGWPHKDgwKcIcRqvksiJGAB2sO6wYI4wLMOxfcZ4Mm+JGSGQ== X-Received: by 2002:adf:8b54:0:b0:32d:9a32:6261 with SMTP id v20-20020adf8b54000000b0032d9a326261mr1801911wra.7.1697208259367; Fri, 13 Oct 2023 07:44:19 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id dh13-20020a0560000a8d00b00327cd5e5ac1sm6402480wrb.1.2023.10.13.07.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:44:19 -0700 (PDT) Date: Fri, 13 Oct 2023 16:44:17 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] staging: rtl8192e: Remove unused variable dig_state Message-ID: <7bacd7e152a2d044527924d57efdbbaae0f4c9e8.1697127817.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove variable dig_state as it is unused. Remove unused variable dig_highpwr_state as well. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 3 --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 0bd9211500ac..97de404840df 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -911,8 +911,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev) { struct r8192_priv *priv =3D rtllib_priv(dev); =20 - dm_digtable.dig_state =3D DM_STA_DIG_MAX; - dm_digtable.dig_highpwr_state =3D DM_STA_DIG_MAX; dm_digtable.cur_sta_connect_state =3D DIG_STA_DISCONNECT; dm_digtable.pre_sta_connect_state =3D DIG_STA_DISCONNECT; =20 @@ -964,7 +962,6 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(stru= ct net_device *dev) for (i =3D 0; i < 3; i++) rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x8); fw_dig++; - dm_digtable.dig_state =3D DM_STA_DIG_OFF; } =20 if (priv->rtllib->link_state =3D=3D MAC80211_LINKED) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.h index 12b7d426b6b9..80ac77e269fd 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h @@ -56,8 +56,6 @@ struct dig_t { long rssi_high_power_lowthresh; long rssi_high_power_highthresh; =20 - u8 dig_state; - u8 dig_highpwr_state; u8 cur_sta_connect_state; u8 pre_sta_connect_state; =20 --=20 2.42.0 From nobody Wed Dec 17 06:26:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188C7CDB47E for ; Fri, 13 Oct 2023 14:44:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232224AbjJMOod (ORCPT ); Fri, 13 Oct 2023 10:44:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232242AbjJMOo3 (ORCPT ); Fri, 13 Oct 2023 10:44:29 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F2EDD8 for ; Fri, 13 Oct 2023 07:44:26 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-405e48d8e72so5562465e9.0 for ; Fri, 13 Oct 2023 07:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697208265; x=1697813065; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dUwXwdN/92xgfkRGk4NgyBr2C8cERjjyDL8rj/W6Q4A=; b=OTwi3wI+M8jjUTqc5p0F5r7ZT5RCM8oKQLHjDuMDUaemswXom+zXtKv4O3HOCU39MJ 5tDI3YkBLTD5rRMbuoYUmxGqC/mme4ad68tabG1o8RkEYoUhczCY1u+4ETQgrnsWnWjT cwPezC+ihNrTYL+kjViU/cIq2LnOZNsUk903LDjUDfcK8uKCxDrG1wzXEkpSl0kQ2Jjq P6NoIPnE+e8eRMo6aP6JQJAcgIgjkkALYaOT7K1j3i+q8a0nPMa5vFmnUZE6WBdv6Sve CdTwtHJHVjhZog5Sib4ekARMBgjhynLL2CD1jqqGCubqCMW9tMMR/TZ/CrcIkS3o10Ll 5zgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697208265; x=1697813065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dUwXwdN/92xgfkRGk4NgyBr2C8cERjjyDL8rj/W6Q4A=; b=UZCzFFWzEbfhZGBe73mgLm9CjlHhUlgAUyhVJS1p9r1/alubSBaR7PNTyby2qy0Ij4 ZfsU8+rSzLXu5TBl8aqtXBcM3H6Ns3pfvb5r6tBqFJxFVzuhhLCfOs60JJsxhtL4ZC68 y7l8bvfmQlOAV9KI8PTsmPM4pXHT8TYpTp2PKIREbMIX8N015BXwD+yI29bwG08quF+X /FS2ia0BhQqUiUNFCltuS2Ykwrdvuk0omoj+LfXpQ6ayS6BmNq3xVUTGIwOIT5GleKLF qjPnL01vgm4ezQ3kpJBsXzB1l5fITAo63JcNl1cJ9rbXd27f8s+1B0wiHasAg7JnniIM 7DcQ== X-Gm-Message-State: AOJu0YwsKl8qHmnpEzfJlfOf1GQLAfNuG3BZaVDn0kaI2AO/TDNunbrd 2HoLuS8RnOcLhsWTwsLO5vjHMTkr9ZM= X-Google-Smtp-Source: AGHT+IHLyuSifzxEbeDJO3HER84faNj1Duelt7Do8Cm4/ovC64G4DtsR8Hxp0/615lXKfG//X3d1hg== X-Received: by 2002:a05:600c:3b9a:b0:3fe:21a6:a18 with SMTP id n26-20020a05600c3b9a00b003fe21a60a18mr24335407wms.3.1697208265187; Fri, 13 Oct 2023 07:44:25 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id l40-20020a05600c1d2800b0040596352951sm331816wms.5.2023.10.13.07.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 07:44:24 -0700 (PDT) Date: Fri, 13 Oct 2023 16:44:23 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] staging: rtl8192e: Remove unused enums dm_dig_sta and dm_dig_alg Message-ID: <0aab74bcda5f582a5fe44a4c1405940d0c8261ad.1697127817.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused enums dm_dig_sta and dm_dig_alg. Remove unused entries of enum dm_dig_connect. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.h index 80ac77e269fd..84e673452be4 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.h @@ -74,12 +74,6 @@ struct dig_t { long rssi_val; }; =20 -enum dm_dig_sta { - DM_STA_DIG_OFF =3D 0, - DM_STA_DIG_ON, - DM_STA_DIG_MAX -}; - enum dm_ratr_sta { DM_RATR_STA_HIGH =3D 0, DM_RATR_STA_MIDDLE =3D 1, @@ -87,22 +81,9 @@ enum dm_ratr_sta { DM_RATR_STA_MAX }; =20 -enum dm_dig_alg { - DIG_ALGO_BY_FALSE_ALARM =3D 0, - DIG_ALGO_BY_RSSI =3D 1, - DIG_ALGO_BEFORE_CONNECT_BY_RSSI_AND_ALARM =3D 2, - DIG_ALGO_BY_TOW_PORT =3D 3, - DIG_ALGO_MAX -}; - enum dm_dig_connect { DIG_STA_DISCONNECT =3D 0, DIG_STA_CONNECT =3D 1, - DIG_STA_BEFORE_CONNECT =3D 2, - DIG_AP_DISCONNECT =3D 3, - DIG_AP_CONNECT =3D 4, - DIG_AP_ADD_STATION =3D 5, - DIG_CONNECT_MAX }; =20 enum dm_dig_pd_th { --=20 2.42.0