From nobody Wed Feb 11 10:38:08 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDF7EB64D7 for ; Sun, 18 Jun 2023 13:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229540AbjFRNFK (ORCPT ); Sun, 18 Jun 2023 09:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjFRNFH (ORCPT ); Sun, 18 Jun 2023 09:05:07 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C72081AB for ; Sun, 18 Jun 2023 06:05:06 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6685421cdb3so553034b3a.1 for ; Sun, 18 Jun 2023 06:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687093506; x=1689685506; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wRgjeJzxwlHCJLz7nU375fsDcPTbnKnIoD3o2Bz9KAw=; b=cXyvrNAHts7ZQKqRpwP5po9vFgi5UBx2urXqkY9wKEmwBrVwzf21mqIYR5u8OOwqYq seZooz4bJCoP5qNtlcvyDGPR8EJoZHtu0F9dvg71mTHtCwdX/FNRAOxGJnO3NMrm5f6/ 6nZEtvH5LzQPp02TCCd9aWLy1i1P+QFUsSpAjDZzBojJD/SCLHTMtXdzTVyfB8qqnhqS zri/v8RQf8xJt/t8S82m9n1TdJlMRZLopYsK8Y4O2jU6T+oq8QGxBSQnZmodKG1kp2au WHCqz9M1NrMjyZuJ3FaQGHkE4aLTPg8E6K603E2YULLkwERXWk/bhazXNRPEgB5BXS0t BPag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687093506; x=1689685506; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wRgjeJzxwlHCJLz7nU375fsDcPTbnKnIoD3o2Bz9KAw=; b=TiLOoy1Gw/P0e/y93ORyQq1WDIdO7dDlLHT9MDq26kXw692m5ayU097GvCnPcL8Y6i 13VaqAd+pr+qMkb/QxaSql42NR498Gf3JBWT0z2aHvwYTILApNUvCViMDienl0mAommO p5Np0H+lBovwlK5LKSL6XQxSYT4B+Lj1UGkcs8Y6LtiTIweNrfN9pEY64p7PxZH5Smt8 r2GwBgYX4zvC1+mqT7CPp2eXbPRQF2QyuR64jhQ28Ck4u6ZXTIAwWf2IIueg+vigu+nV C/bRtQqr/OL1j5T2uQbJsj0On0a8Iv1THmbsWrwDfH16w5LEXNy1Cp2rn6/LfsdJcolR 2VnQ== X-Gm-Message-State: AC+VfDwVtAf1cnxhYY99tJ9YN2U1vyqm8DE3n+gRX1Fyf/AJbQ1JGl2n pX9wSUd6Jh+uFg8d3BiA4Ms= X-Google-Smtp-Source: ACHHUZ6es/VJJzhFLT9wXqeFtuAH6zY9atWgUcUgors1zxxi0wNkNJm7T9EQ+ZkJ5hRJMjiZlpEfXQ== X-Received: by 2002:a05:6a00:1743:b0:646:f971:b179 with SMTP id j3-20020a056a00174300b00646f971b179mr20164537pfc.16.1687093506145; Sun, 18 Jun 2023 06:05:06 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id j1-20020aa78d01000000b0065418efa5ebsm16110685pfe.155.2023.06.18.06.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 06:05:05 -0700 (PDT) Date: Sun, 18 Jun 2023 18:35:00 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v3 1/4] staging: rtl8192e: Rename variable SetWirelessMode Message-ID: <31ea72cdec675c53b2125f8425e74e92d99de276.1687092111.git.yogi.kernel@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable SetWirelessMode to set_wireless_mode to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde Tested-by: Philipp Hortmann --- v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 12 ++++++------ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 17b70dde7eeb..699c4accf2db 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -716,7 +716,7 @@ static void _rtl92e_init_priv_handler(struct net_device= *dev) priv->rtllib->check_nic_enough_desc =3D _rtl92e_check_nic_enough_desc; priv->rtllib->handle_assoc_response =3D _rtl92e_handle_assoc_response; priv->rtllib->handle_beacon =3D _rtl92e_handle_beacon; - priv->rtllib->SetWirelessMode =3D rtl92e_set_wireless_mode; + priv->rtllib->set_wireless_mode =3D rtl92e_set_wireless_mode; priv->rtllib->LeisurePSLeave =3D rtl92e_leisure_ps_leave; priv->rtllib->SetBWModeHandler =3D rtl92e_set_bw_mode; priv->rf_set_chan =3D rtl92e_set_channel; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 87e9169214f6..f91355de17f7 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1708,7 +1708,7 @@ struct rtllib_device { enum ht_channel_width bandwidth, enum ht_extchnl_offset Offset); bool (*GetNmodeSupportBySecCfg)(struct net_device *dev); - void (*SetWirelessMode)(struct net_device *dev, u8 wireless_mode); + void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); void (*InitialGainHandler)(struct net_device *dev, u8 Operation); diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rt= l8192e/rtllib_softmac.c index 821ca86b8bcd..1c48e1ee5baf 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1472,7 +1472,7 @@ static void rtllib_associate_complete_wq(void *data) netdev_info(ieee->dev, "Using G rates:%d\n", ieee->rate); } else { ieee->rate =3D 22; - ieee->SetWirelessMode(ieee->dev, IEEE_B); + ieee->set_wireless_mode(ieee->dev, IEEE_B); netdev_info(ieee->dev, "Using B rates:%d\n", ieee->rate); } if (ieee->ht_info->bCurrentHTSupport && ieee->ht_info->enable_ht) { @@ -1656,13 +1656,13 @@ inline void rtllib_softmac_new_net(struct rtllib_de= vice *ieee, (ieee->modulation & RTLLIB_OFDM_MODULATION)) { ieee->rate =3D 108; - ieee->SetWirelessMode(ieee->dev, + ieee->set_wireless_mode(ieee->dev, IEEE_G); netdev_info(ieee->dev, "Using G rates\n"); } else { ieee->rate =3D 22; - ieee->SetWirelessMode(ieee->dev, + ieee->set_wireless_mode(ieee->dev, IEEE_B); netdev_info(ieee->dev, "Using B rates\n"); @@ -2237,11 +2237,11 @@ static void rtllib_rx_auth_resp(struct rtllib_devic= e *ieee, struct sk_buff *skb) } /* Dummy wirless mode setting to avoid encryption issue */ if (bSupportNmode) { - ieee->SetWirelessMode(ieee->dev, + ieee->set_wireless_mode(ieee->dev, ieee->current_network.mode); } else { /*TODO*/ - ieee->SetWirelessMode(ieee->dev, IEEE_G); + ieee->set_wireless_mode(ieee->dev, IEEE_G); } =20 if ((ieee->current_network.mode =3D=3D IEEE_N_24G) && @@ -2570,7 +2570,7 @@ static void rtllib_start_ibss_wq(void *data) } =20 ieee->current_network.qos_data.supported =3D 0; - ieee->SetWirelessMode(ieee->dev, IEEE_G); + ieee->set_wireless_mode(ieee->dev, IEEE_G); ieee->current_network.mode =3D ieee->mode; ieee->current_network.atim_window =3D 0; ieee->current_network.capability =3D WLAN_CAPABILITY_IBSS; --=20 2.34.1 From nobody Wed Feb 11 10:38:08 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E16FEB64DA for ; Sun, 18 Jun 2023 13:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229559AbjFRNFx (ORCPT ); Sun, 18 Jun 2023 09:05:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjFRNFv (ORCPT ); Sun, 18 Jun 2023 09:05:51 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD481AB for ; Sun, 18 Jun 2023 06:05:50 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6682909acadso173901b3a.3 for ; Sun, 18 Jun 2023 06:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687093550; x=1689685550; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Awvoaf5eSwNCHFdEadyIQRz9usUvjf5nZIyeulxK9fU=; b=SnvACYEPoPdUseu8hBkro1tuItr+rEyu2aa27tx7DHMkjC/9oXwfzg/R6cDOrSie6x wZls5Gu9hOtqWtK2cvK4qYeulAJL89Vt8sE3OLCd0UbDVBFmLFPMpoOgTwN0y5t1j+KQ /P2yC//YMPxlfdHa1uLhvT/MzGAeD3CR41tAPldRCM3+VZk3keLInzlOWDRqLM2IKOs2 sdjtE1yvvCzW7n/LjnuIKl8kvYnHNMaMZwBtP5QXdZDXxwQkov8FlET2LPdtP3OmsHR8 V3ZYRkDY2z+6z2bYkXjnmZGScXxXaTste1BnR/w7mx4LvP18oPS3iUgyfirgT9fWxYbk 4NhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687093550; x=1689685550; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Awvoaf5eSwNCHFdEadyIQRz9usUvjf5nZIyeulxK9fU=; b=JlKBiTrDxR0BJsyABJbokXI/nMY5thme0k8qOGdsbYuFligJ5GtkgJu7ZpjAVbq0ic Hxju2VCiXBgh+KYxq3PyONXBt+BkCoPwTzMTztZEi8ORZ0Mbe8QyCpFrMx26Xg1SANYx s7yVEqnMMYQxPkNwQuJrqS6W2CRvMiqDawqf79QU8zVUdrTTMPZv4dBneOvX3fst46vw GTAh0ygo+/QmgrOXSMfGrWtPQuDTz6zst0d9aPyRxjHEN5RryVG7zHVcrJ55CePO/wXl 7cEJq7uhvNRywvpZHg/RG1QSS6Y1ssa82eMMrLr+azgZK0C2mPq8edFoOK+3nqwgfRU8 aJYg== X-Gm-Message-State: AC+VfDzCb5LZkRuDts5ZblFhqyLLWvUibwIx+X34rEGM8zgiiSnNfbAn zC4tFek2cWagIb+O9u1Dlzm3WjhURBE= X-Google-Smtp-Source: ACHHUZ5TtP+nQJsdLRDy+mFSw0pnq3nU3bxvH9A/VP5IWjTe8oYDGsEuqaFI7iEVhYUDuR3sgm21wQ== X-Received: by 2002:a05:6a20:8f06:b0:104:873:c3b5 with SMTP id b6-20020a056a208f0600b001040873c3b5mr5440001pzk.44.1687093550144; Sun, 18 Jun 2023 06:05:50 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id 18-20020a056a00073200b0063d2cd02d69sm16137148pfm.54.2023.06.18.06.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 06:05:49 -0700 (PDT) Date: Sun, 18 Jun 2023 18:35:43 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v3 2/4] staging: rtl8192e: Rename variable SetBWModeHandler Message-ID: <6c929da448e04393d1259de820bbcb78f0e2a409.1687092111.git.yogi.kernel@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable SetBWModeHandler to set_bw_mode_handler to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde Tested-by: Philipp Hortmann --- v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 6 +++--- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 699c4accf2db..68e921a3a0a8 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -718,7 +718,7 @@ static void _rtl92e_init_priv_handler(struct net_device= *dev) priv->rtllib->handle_beacon =3D _rtl92e_handle_beacon; priv->rtllib->set_wireless_mode =3D rtl92e_set_wireless_mode; priv->rtllib->LeisurePSLeave =3D rtl92e_leisure_ps_leave; - priv->rtllib->SetBWModeHandler =3D rtl92e_set_bw_mode; + priv->rtllib->set_bw_mode_handler =3D rtl92e_set_bw_mode; priv->rf_set_chan =3D rtl92e_set_channel; =20 priv->rtllib->start_send_beacons =3D rtl92e_start_beacon; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index fe30a291e64c..1fe504244437 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -835,11 +835,11 @@ static void HTSetConnectBwModeCallback(struct rtllib_= device *ieee) ieee->set_chan(ieee->dev, ieee->current_network.channel); =20 - ieee->SetBWModeHandler(ieee->dev, HT_CHANNEL_WIDTH_20_40, + ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20_40, ht_info->CurSTAExtChnlOffset); } else { ieee->set_chan(ieee->dev, ieee->current_network.channel); - ieee->SetBWModeHandler(ieee->dev, HT_CHANNEL_WIDTH_20, + ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20, HT_EXTCHNL_OFFSET_NO_EXT); } =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index f91355de17f7..e79510258447 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1704,9 +1704,9 @@ struct rtllib_device { =20 /* check whether Tx hw resource available */ short (*check_nic_enough_desc)(struct net_device *dev, int queue_index); - void (*SetBWModeHandler)(struct net_device *dev, - enum ht_channel_width bandwidth, - enum ht_extchnl_offset Offset); + void (*set_bw_mode_handler)(struct net_device *dev, + enum ht_channel_width bandwidth, + enum ht_extchnl_offset Offset); bool (*GetNmodeSupportBySecCfg)(struct net_device *dev); void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging= /rtl8192e/rtllib_softmac_wx.c index d6d90e6ba2d3..6a7738a828e1 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -335,7 +335,7 @@ void rtllib_wx_sync_scan_wq(void *data) b40M =3D 1; chan_offset =3D ieee->ht_info->CurSTAExtChnlOffset; bandwidth =3D (enum ht_channel_width)ieee->ht_info->bCurBW40MHz; - ieee->SetBWModeHandler(ieee->dev, HT_CHANNEL_WIDTH_20, + ieee->set_bw_mode_handler(ieee->dev, HT_CHANNEL_WIDTH_20, HT_EXTCHNL_OFFSET_NO_EXT); } =20 @@ -348,7 +348,7 @@ void rtllib_wx_sync_scan_wq(void *data) ieee->set_chan(ieee->dev, chan - 2); else ieee->set_chan(ieee->dev, chan); - ieee->SetBWModeHandler(ieee->dev, bandwidth, chan_offset); + ieee->set_bw_mode_handler(ieee->dev, bandwidth, chan_offset); } else { ieee->set_chan(ieee->dev, chan); } --=20 2.34.1 From nobody Wed Feb 11 10:38:08 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA5FEB64DB for ; Sun, 18 Jun 2023 13:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbjFRNGf (ORCPT ); Sun, 18 Jun 2023 09:06:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjFRNGd (ORCPT ); Sun, 18 Jun 2023 09:06:33 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B9C71AB for ; Sun, 18 Jun 2023 06:06:32 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1b55643507dso5581065ad.0 for ; Sun, 18 Jun 2023 06:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687093592; x=1689685592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GrnRiINtmKsRPpdoYY28cns2m1Iqy+OAFvN9buTT+SU=; b=lZexxq7P3XtuZPtJJ5JNGgBbfUyPOyFIcg0Cf1k4PZUWTiouPub2JaLA0sUnZcqg7y sy5cTPc8wRDhABm2qeP7wQoyi0q2O/BZ00wmncwqtaP9WQssMnaKjq2B7BNnAz65FZlh RIKRJwVBJJF37fYkkIYX99CbN0gm0IFO+oHkUOjKLprNovaxDt6jlgDinvY+2IXrHbnB JyuAmnC1ULxFXQ1qWSvx6rpRoeM41/DR8Q6fnD8Nhty+eBdBVXAgJy163iv1sdu+MNQe xzh9ruZlmDgiDQzy8g4Chp4nDMXrKUP83aje03f68VOk3J8wzM/aPqwowMPLmk9ArNt6 h28g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687093592; x=1689685592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GrnRiINtmKsRPpdoYY28cns2m1Iqy+OAFvN9buTT+SU=; b=OPqp0nJKXvkOTWZUkSJj+FszSArK42fvLW7ryGsOqkXOQQaeljZ0mOmfsTqi299HPi t7TZpPefxIKlpo9/T81+IZlN5FGmyTicBSBbRmp49uGanUCmWYkqipiEAnUtcmAav2ho VIyzm5XhSrRu2F2aylC1FZQmuCL8K/3Mg3krX/QSEiP/qhx5g1Mkp32QsSrWRB3LRZ/Z AI8tuZUNq3PvrX7uRsIEzI18SeGOvgQYZmSIov8/zMuWM5aIkGn44lRn9UxIQy/oEgcd +9ImnMNESfDCvL1GkUPcj7mstsgKgSMc6+emQyqyvaTJacyCe6Up5gFfjbtbRc+FH0Kh Oraw== X-Gm-Message-State: AC+VfDx0KSOC693sjcnTFrtNS7iL9jlYZW1jL+Zm0OmaGTuicO5iZAa6 lOpgPsIkztMxsgP7NL9pQNc= X-Google-Smtp-Source: ACHHUZ7u0MlTI1QnE1/QfcX+1B04t7ijeC3d4SMCyrPu+0RQ8QpwZMt4KJuaa1PbrX26Fyi54isqOw== X-Received: by 2002:a17:902:ee41:b0:1b3:de1d:1ce1 with SMTP id 1-20020a170902ee4100b001b3de1d1ce1mr6859808plo.61.1687093592061; Sun, 18 Jun 2023 06:06:32 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id s11-20020a170902ea0b00b001b23eb0b4bbsm18670943plg.147.2023.06.18.06.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 06:06:31 -0700 (PDT) Date: Sun, 18 Jun 2023 18:36:26 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v3 3/4] staging: rtl8192e: Rename variable LeisurePSLeave Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable LeisurePSLeave to leisure_ps_leave to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde Tested-by: Philipp Hortmann --- v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 68e921a3a0a8..b82d2b7aa26c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -717,7 +717,7 @@ static void _rtl92e_init_priv_handler(struct net_device= *dev) priv->rtllib->handle_assoc_response =3D _rtl92e_handle_assoc_response; priv->rtllib->handle_beacon =3D _rtl92e_handle_beacon; priv->rtllib->set_wireless_mode =3D rtl92e_set_wireless_mode; - priv->rtllib->LeisurePSLeave =3D rtl92e_leisure_ps_leave; + priv->rtllib->leisure_ps_leave =3D rtl92e_leisure_ps_leave; priv->rtllib->set_bw_mode_handler =3D rtl92e_set_bw_mode; priv->rf_set_chan =3D rtl92e_set_channel; =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index e79510258447..0ee9b99b4c5e 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1721,7 +1721,7 @@ struct rtllib_device { =20 void (*rtllib_ips_leave_wq)(struct net_device *dev); void (*rtllib_ips_leave)(struct net_device *dev); - void (*LeisurePSLeave)(struct net_device *dev); + void (*leisure_ps_leave)(struct net_device *dev); =20 /* This must be the last item so that it points to the data * allocated beyond this structure by alloc_rtllib diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 46c77ed335ab..c00f72316a3d 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1200,7 +1200,7 @@ static void rtllib_rx_check_leave_lps(struct rtllib_d= evice *ieee, u8 unicast, if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) > 8) || (ieee->link_detect_info.NumRxUnicastOkInPeriod > 2)) { - ieee->LeisurePSLeave(ieee->dev); + ieee->leisure_ps_leave(ieee->dev); } } } diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging= /rtl8192e/rtllib_softmac_wx.c index 6a7738a828e1..d7df6f698c0c 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -316,7 +316,7 @@ void rtllib_wx_sync_scan_wq(void *data) =20 chan =3D ieee->current_network.channel; =20 - ieee->LeisurePSLeave(ieee->dev); + ieee->leisure_ps_leave(ieee->dev); /* notify AP to be in PS mode */ rtllib_sta_ps_send_null_frame(ieee, 1); rtllib_sta_ps_send_null_frame(ieee, 1); --=20 2.34.1 From nobody Wed Feb 11 10:38:08 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77220EB64D8 for ; Sun, 18 Jun 2023 13:07:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbjFRNHH (ORCPT ); Sun, 18 Jun 2023 09:07:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjFRNHE (ORCPT ); Sun, 18 Jun 2023 09:07:04 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BEFEB0 for ; Sun, 18 Jun 2023 06:07:04 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-66615629689so2451331b3a.2 for ; Sun, 18 Jun 2023 06:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687093623; x=1689685623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ooiaPbgSDk2Vavd/yz78VigQmMncQVwP5N8EDeWNlmo=; b=j+it1mrQUvR/fZDFPPpYHa5RUyGfo/KR3ts/RFYP6cRh8d32bZFpPVhN409/WDBC9X 6+7y6VwhwA1/XDSjGOy6p/VPFjpqG3+hhvk7JTfeOpzkBAKASts7Dla9lbrKFn3apDC2 DtV5jg5oZnTrtG9k/NCZ4+c3tM6z1aWzFh4/6JbZEDX9az+neu7UTbQrmU5boSSSq2Ec 41nuPaRAe537iaI+HSgVLBNbWp4BDJpbJCyr6EbTP9zjV0aCZfLDrAaj+nsuyNBOnf+P WX4w0d/J0lZcmgy+acQq5cq7ICtuMv0E9KxCk4Rez3AjBHZkwqv0tfp42afWRR7khSKm K8TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687093623; x=1689685623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ooiaPbgSDk2Vavd/yz78VigQmMncQVwP5N8EDeWNlmo=; b=f5MvmHcTZ1bSqrgrfduAq6X6FTc3kXPPS2253cXx8Zucm/BMX6Cpq6woS9P1NmSZsd qvX4E06i+ouCWou6pQbpN2aFDW47b/zQjQC5Kw2D0aZ3r/W0qK6j6yo5oTjqU5n3i7bO BfB1N0Q34Oe6NHBdGrBDIOFeChPbp5aVC4yxGB8K0+Pd08AMSCJAeqgSYolUv96p1N1C +mKTbNiX1fY/dHV/U493eGM1LiFRu43bhJI9yyb2P0D8GQbrS6ehjvcAK302jNkSbPX2 1eK3a2Vp9niESw1SUftU6WPKqUAJfIZmD7yA65s92xZNOWtQhA19Z9chySo+yzz8zTzr J+pQ== X-Gm-Message-State: AC+VfDxfJe6achOjHrvEAPEjitJfQD5nVmflqMhZUpty9xRblKnAhrrx Jwd7zlpnhWaCuS5ac7sVasY= X-Google-Smtp-Source: ACHHUZ79lFMtx+Pb0R/irseT7cjmzdFjy784QY0jo3sRAMHQO/wo6KPP3MDUrfzs48j3sNOBNNPMzQ== X-Received: by 2002:a05:6a00:1691:b0:665:c10f:709c with SMTP id k17-20020a056a00169100b00665c10f709cmr11340188pfc.21.1687093623535; Sun, 18 Jun 2023 06:07:03 -0700 (PDT) Received: from zephyrusG14 ([103.251.210.211]) by smtp.gmail.com with ESMTPSA id y9-20020aa78049000000b0065e154bac6dsm16159760pfm.133.2023.06.18.06.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 06:07:03 -0700 (PDT) Date: Sun, 18 Jun 2023 18:36:58 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, philipp.g.hortmann@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, ivan.orlov0322@gmail.com Subject: [PATCH v3 4/4] staging: rtl8192e: Rename variable InitialGainHandler Message-ID: <59e1d108e07a159e766d33df1556ffbeab1f7693.1687092111.git.yogi.kernel@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable InitialGainHandler to init_gain_handler to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde Tested-by: Philipp Hortmann --- v3: Revert back to v1 of the patch as suggested by Greg Kroah-Hartman . v2: Removed the variable and called the function directly instead of just renaming the variable as suggested by Greg Kroah-Hartman . --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 7b0da55fa7aa..267fc6f8800e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -1109,11 +1109,11 @@ void rtl92e_scan_op_backup(struct net_device *dev, = u8 Operation) if (priv->up) { switch (Operation) { case SCAN_OPT_BACKUP: - priv->rtllib->InitialGainHandler(dev, IG_Backup); + priv->rtllib->init_gain_handler(dev, IG_Backup); break; =20 case SCAN_OPT_RESTORE: - priv->rtllib->InitialGainHandler(dev, IG_Restore); + priv->rtllib->init_gain_handler(dev, IG_Restore); break; } } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index b82d2b7aa26c..eb20b8014997 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -734,7 +734,7 @@ static void _rtl92e_init_priv_handler(struct net_device= *dev) =20 priv->rtllib->SetHwRegHandler =3D rtl92e_set_reg; priv->rtllib->AllowAllDestAddrHandler =3D rtl92e_set_monitor_mode; - priv->rtllib->InitialGainHandler =3D rtl92e_init_gain; + priv->rtllib->init_gain_handler =3D rtl92e_init_gain; priv->rtllib->rtllib_ips_leave_wq =3D rtl92e_rtllib_ips_leave_wq; priv->rtllib->rtllib_ips_leave =3D rtl92e_rtllib_ips_leave; priv->rtllib->ScanOperationBackupHandler =3D rtl92e_scan_op_backup; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 0ee9b99b4c5e..0551f9b108f6 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1711,7 +1711,7 @@ struct rtllib_device { void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); bool (*GetHalfNmodeSupportByAPsHandler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); - void (*InitialGainHandler)(struct net_device *dev, u8 Operation); + void (*init_gain_handler)(struct net_device *dev, u8 Operation); void (*ScanOperationBackupHandler)(struct net_device *dev, u8 Operation); void (*SetHwRegHandler)(struct net_device *dev, u8 variable, u8 *val); --=20 2.34.1