[PATCH v6 6/8] pinctrl: pistachio: relax return value check for IRQ get

Matti Vaittinen posted 8 patches 10 months, 3 weeks ago
There is a newer version of this series
[PATCH v6 6/8] pinctrl: pistachio: relax return value check for IRQ get
Posted by Matti Vaittinen 10 months, 3 weeks ago
fwnode_irq_get[_byname]() were changed to not return 0 anymore.

Drop check for return value 0.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>

---
Revision history:
 - No changes

Please note, I took Linus' reply to v4 cover-letter as ack && added the
tag. Please let me know if this was not Ok.

The first patch of the series changes the fwnode_irq_get() so this depends
on the first patch of the series and should not be applied alone.
---
 drivers/pinctrl/pinctrl-pistachio.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c
index 53408344927a..8c50e0091b32 100644
--- a/drivers/pinctrl/pinctrl-pistachio.c
+++ b/drivers/pinctrl/pinctrl-pistachio.c
@@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
 			dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i);
 			goto err;
 		}
-		if (!ret) {
-			fwnode_handle_put(child);
-			dev_err(pctl->dev, "No IRQ for bank %u\n", i);
-			ret = -EINVAL;
-			goto err;
-		}
 		irq = ret;
 
 		bank = &pctl->gpio_banks[i];
-- 
2.40.1


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 
Re: [PATCH v6 6/8] pinctrl: pistachio: relax return value check for IRQ get
Posted by Jonathan Cameron 10 months, 2 weeks ago
On Fri, 26 May 2023 09:38:58 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> fwnode_irq_get[_byname]() were changed to not return 0 anymore.
> 
> Drop check for return value 0.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> ---
> Revision history:
>  - No changes
> 
> Please note, I took Linus' reply to v4 cover-letter as ack && added the
> tag. Please let me know if this was not Ok.

Whilst I understand your point as Linus said he'd pick the patches up,
I would have left it to Linus to Ack explicitly but added a note here
to say he basically already did.

LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> The first patch of the series changes the fwnode_irq_get() so this depends
> on the first patch of the series and should not be applied alone.
> ---
>  drivers/pinctrl/pinctrl-pistachio.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c
> index 53408344927a..8c50e0091b32 100644
> --- a/drivers/pinctrl/pinctrl-pistachio.c
> +++ b/drivers/pinctrl/pinctrl-pistachio.c
> @@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
>  			dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i);
>  			goto err;
>  		}
> -		if (!ret) {
> -			fwnode_handle_put(child);
> -			dev_err(pctl->dev, "No IRQ for bank %u\n", i);
> -			ret = -EINVAL;
> -			goto err;
> -		}
>  		irq = ret;
>  
>  		bank = &pctl->gpio_banks[i];