From nobody Wed Feb 11 10:38:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29879C77B7C for ; Wed, 10 May 2023 15:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237417AbjEJPJT (ORCPT ); Wed, 10 May 2023 11:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237376AbjEJPJQ (ORCPT ); Wed, 10 May 2023 11:09:16 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D18EF65AA for ; Wed, 10 May 2023 08:09:12 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-250175762b8so6358865a91.1 for ; Wed, 10 May 2023 08:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683731352; x=1686323352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2/5MHYkfOkYJQ3WwKEx9INoY78DTjq0oXqSLJNfYktQ=; b=PYswHEjGfGlAdOKS84F9lqMmvGRYBxNBZZQ48dL4ScLEKMBvflskAouwo5LA7m3tYJ UHwuHv1aTb79xITPkI1r/B4pujZ3JsnY5vGCzy/KjrPNabIQl4ioYqFVsmnr5BaKfqqP x5Km2JIaPyZlXVVxpr/551I+qkLw0GbgUUYJCmSL4DpCpm/QiecMlY3vWW0bmTodbf3E IdsM4YnnIJYffE9GHwIqBpIsg9vMxtnAtOp/BU4ZAwjb7cjTDV7cGBGkf3QcvxFxabOM YpNt5hLyBAOdeFP0KqvaJtxgocCUg9IglQD7IEQZv/ITHUVHbH8gNLTsv3f0HyHUXEU/ L3KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683731352; x=1686323352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2/5MHYkfOkYJQ3WwKEx9INoY78DTjq0oXqSLJNfYktQ=; b=GSdfBK/y2aFq/4cfobBUnzPt/eZGJxywyo0fOwyGLD2PBVVY4868xqu36THvCF9d/Y TboHDK8BN59wjF4ZMUYzZrAKgT5moXLXI8EpnDbVRiK0qBhNB9RZQJzsIl7G77j7/JxM M+jf76uI+xTDyqtJvN0CiHRHUIpTc56kCoUE1c0yWbDhYYSpWSJwYB61JOuQUUJKc9MH D86YxDuSqRq+xjqqkGh+djFw5yJu/uGOw8O8M8RQsDZIrGUxjk5Biu7bnpk/MlVmUgor 7gurQ3HinWOYi8Mo97JqIcnEbpA+PwG0/4lnurFdEGKAuwZ92mhBhEMr24hT36w0GRLi +0Vg== X-Gm-Message-State: AC+VfDy1Ld5sjZ54rxrCL8bj408id5xplRQO0w8saAV4yqgfRCqsDC24 8eeffyCdk5NQQNAep53HvpM= X-Google-Smtp-Source: ACHHUZ6C6nqRupvnUzPQMrFg/nsiI/qzt3Kvg+6td3NJ9w6K/9l9DCbzSK4zP0ymErHm9FL//pVVEQ== X-Received: by 2002:a17:90a:608f:b0:250:2384:120d with SMTP id z15-20020a17090a608f00b002502384120dmr16991895pji.19.1683731352284; Wed, 10 May 2023 08:09:12 -0700 (PDT) Received: from pop-os.localdomain ([103.251.210.208]) by smtp.gmail.com with ESMTPSA id s14-20020a17090a760e00b0024e134a2408sm16858088pjk.14.2023.05.10.08.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 08:09:12 -0700 (PDT) Date: Wed, 10 May 2023 20:39:07 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] staging: rtl8192e: Rename tmpRegA and TempCCk Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable tmpRegA to tmp_reg, TempCCk to tmp_cck to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 56a8ec517c06..af136abc595c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -657,21 +657,21 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(s= truct net_device *dev) { #define ThermalMeterVal 9 struct r8192_priv *priv =3D rtllib_priv(dev); - u32 tmpRegA, TempCCk; + u32 tmp_reg, tmp_cck; u8 tmpOFDMindex, tmpCCKindex, tmpCCK20Mindex, tmpCCK40Mindex, tmpval; int i =3D 0, CCKSwingNeedUpdate =3D 0; =20 if (!priv->tx_pwr_tracking_init) { - tmpRegA =3D rtl92e_get_bb_reg(dev, rOFDM0_XATxIQImbalance, + tmp_reg =3D rtl92e_get_bb_reg(dev, rOFDM0_XATxIQImbalance, bMaskDWord); for (i =3D 0; i < OFDM_TABLE_LEN; i++) { - if (tmpRegA =3D=3D OFDMSwingTable[i]) + if (tmp_reg =3D=3D OFDMSwingTable[i]) priv->ofdm_index[0] =3D i; } =20 - TempCCk =3D rtl92e_get_bb_reg(dev, rCCK0_TxFilter1, bMaskByte2); + tmp_cck =3D rtl92e_get_bb_reg(dev, rCCK0_TxFilter1, bMaskByte2); for (i =3D 0; i < CCK_TABLE_LEN; i++) { - if (TempCCk =3D=3D (u32)CCKSwingTable_Ch1_Ch13[i][0]) { + if (tmp_cck =3D=3D (u32)CCKSwingTable_Ch1_Ch13[i][0]) { priv->cck_index =3D i; break; } @@ -680,17 +680,17 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(s= truct net_device *dev) return; } =20 - tmpRegA =3D rtl92e_get_rf_reg(dev, RF90_PATH_A, 0x12, 0x078); - if (tmpRegA < 3 || tmpRegA > 13) + tmp_reg =3D rtl92e_get_rf_reg(dev, RF90_PATH_A, 0x12, 0x078); + if (tmp_reg < 3 || tmp_reg > 13) return; - if (tmpRegA >=3D 12) - tmpRegA =3D 12; + if (tmp_reg >=3D 12) + tmp_reg =3D 12; priv->thermal_meter[0] =3D ThermalMeterVal; priv->thermal_meter[1] =3D ThermalMeterVal; =20 - if (priv->thermal_meter[0] >=3D (u8)tmpRegA) { + if (priv->thermal_meter[0] >=3D (u8)tmp_reg) { tmpOFDMindex =3D tmpCCK20Mindex =3D 6+(priv->thermal_meter[0] - - (u8)tmpRegA); + (u8)tmp_reg); tmpCCK40Mindex =3D tmpCCK20Mindex - 6; if (tmpOFDMindex >=3D OFDM_TABLE_LEN) tmpOFDMindex =3D OFDM_TABLE_LEN - 1; @@ -699,7 +699,7 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(str= uct net_device *dev) if (tmpCCK40Mindex >=3D CCK_TABLE_LEN) tmpCCK40Mindex =3D CCK_TABLE_LEN - 1; } else { - tmpval =3D (u8)tmpRegA - priv->thermal_meter[0]; + tmpval =3D (u8)tmp_reg - priv->thermal_meter[0]; if (tmpval >=3D 6) { tmpOFDMindex =3D 0; tmpCCK20Mindex =3D 0; --=20 2.34.1 From nobody Wed Feb 11 10:38:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0867C77B7C for ; Wed, 10 May 2023 15:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237478AbjEJPJh (ORCPT ); Wed, 10 May 2023 11:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237470AbjEJPJd (ORCPT ); Wed, 10 May 2023 11:09:33 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C0855BBD for ; Wed, 10 May 2023 08:09:31 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-64115e652eeso50937729b3a.0 for ; Wed, 10 May 2023 08:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683731371; x=1686323371; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=g/+U69i+oXYARFhfnLN9Kpm6lIKqslW4ET+ngsmdlTA=; b=m6+LJ+C98J+VMJZwyIS8bNLITH3vIYwmhU76QbeV60Ni9XrJdFPl24ysp0a9SJHXrN ttDHsECNj0XpoY8AhZaOfD1Gct0yfoADGWc/60E8uvTEQpjkI0dhA6K0gv4XlflnvxjJ 6xb8XyfIuEEm9jJ40iso744+nePhMxLkUJrYSgPaVKQDvCz0fMx7xQhil78gq0HtkDy0 VXwemSTb0P1JG1L+ZzZNFYR5kfq1Igvaik+go+FYAzx0ZQus7aoUdhdcZSqtd7Zg9Szp GIMC8Su1WaOnPew8TBgKO5kkjWcGaUkZvvu3dWA6Brg81kYdHWQt6D+NyZ0RO16VOttJ +6Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683731371; x=1686323371; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g/+U69i+oXYARFhfnLN9Kpm6lIKqslW4ET+ngsmdlTA=; b=NccaYIadRJAiqL9q/UTzX4IzNrEX2p/1wi9NVukwcPgI7iW7yCJ0pWrs19xu9IWojA IXKlQD7Py/440TYUZAg13t89gCBY0xM6qDmr1DBBy6eL3wKAy/hgSKn/aCZIwQ99WOPe kw+6pP5gn9SXdqkIPDd+lGHuPgyCkZPbuJ5iseQLYXLP1hZIKGJRW1n6ixetS2xbR+l1 9/3NdT9C4+2Te46wAGalv1aupDy/w6iRYBM8uQVhRP11Z5u7KjMwJN46LGbKvsouqJsB sk8rENTPx0NJ/7sXsB62jBLwOuGwQDZG9voRLJhRB39D45kf03+Y9LnRj5ZZ1Hy8FMwF 7Kxw== X-Gm-Message-State: AC+VfDy2VgUvbas2wtO/MG0U2hZQexX+8ytJlOhLDgZ4bEI/d4/QlDpd h/ookIkh37v15mz0RvIp7Q0= X-Google-Smtp-Source: ACHHUZ43znpN4GPGFdQLAMPHvVbbEvcH4cZz8x4AHB+vSapQoQWLDQThNumZ5hWAcMFZ0FlWB58xvw== X-Received: by 2002:a17:90a:db07:b0:250:50c5:cabc with SMTP id g7-20020a17090adb0700b0025050c5cabcmr16937872pjv.3.1683731370599; Wed, 10 May 2023 08:09:30 -0700 (PDT) Received: from pop-os.localdomain ([103.251.210.208]) by smtp.gmail.com with ESMTPSA id t15-20020a17090ad14f00b0024b6a90741esm13456870pjw.49.2023.05.10.08.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 08:09:30 -0700 (PDT) Date: Wed, 10 May 2023 20:39:25 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] staging: rtl8192e: Rename tmpOFDMindex and tmpCCKindex Message-ID: <48098479094e4562fe196cbce813476041a664df.1683730854.git.yogi.kernel@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable tmpOFDMindex to tmp_ofdm_index and tmpCCKindex to tmp_cck_index to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index af136abc595c..117c0538cf5f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -658,7 +658,7 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(str= uct net_device *dev) #define ThermalMeterVal 9 struct r8192_priv *priv =3D rtllib_priv(dev); u32 tmp_reg, tmp_cck; - u8 tmpOFDMindex, tmpCCKindex, tmpCCK20Mindex, tmpCCK40Mindex, tmpval; + u8 tmp_ofdm_index, tmp_cck_index, tmpCCK20Mindex, tmpCCK40Mindex, tmpval; int i =3D 0, CCKSwingNeedUpdate =3D 0; =20 if (!priv->tx_pwr_tracking_init) { @@ -689,11 +689,11 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(s= truct net_device *dev) priv->thermal_meter[1] =3D ThermalMeterVal; =20 if (priv->thermal_meter[0] >=3D (u8)tmp_reg) { - tmpOFDMindex =3D tmpCCK20Mindex =3D 6+(priv->thermal_meter[0] - + tmp_ofdm_index =3D tmpCCK20Mindex =3D 6+(priv->thermal_meter[0] - (u8)tmp_reg); tmpCCK40Mindex =3D tmpCCK20Mindex - 6; - if (tmpOFDMindex >=3D OFDM_TABLE_LEN) - tmpOFDMindex =3D OFDM_TABLE_LEN - 1; + if (tmp_ofdm_index >=3D OFDM_TABLE_LEN) + tmp_ofdm_index =3D OFDM_TABLE_LEN - 1; if (tmpCCK20Mindex >=3D CCK_TABLE_LEN) tmpCCK20Mindex =3D CCK_TABLE_LEN - 1; if (tmpCCK40Mindex >=3D CCK_TABLE_LEN) @@ -701,18 +701,18 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(s= truct net_device *dev) } else { tmpval =3D (u8)tmp_reg - priv->thermal_meter[0]; if (tmpval >=3D 6) { - tmpOFDMindex =3D 0; + tmp_ofdm_index =3D 0; tmpCCK20Mindex =3D 0; } else { - tmpOFDMindex =3D 6 - tmpval; + tmp_ofdm_index =3D 6 - tmpval; tmpCCK20Mindex =3D 6 - tmpval; } tmpCCK40Mindex =3D 0; } if (priv->current_chnl_bw !=3D HT_CHANNEL_WIDTH_20) - tmpCCKindex =3D tmpCCK40Mindex; + tmp_cck_index =3D tmpCCK40Mindex; else - tmpCCKindex =3D tmpCCK20Mindex; + tmp_cck_index =3D tmpCCK20Mindex; =20 priv->rec_cck_20m_idx =3D tmpCCK20Mindex; priv->rec_cck_40m_idx =3D tmpCCK40Mindex; @@ -727,15 +727,15 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(s= truct net_device *dev) CCKSwingNeedUpdate =3D 1; } =20 - if (priv->cck_index !=3D tmpCCKindex) { - priv->cck_index =3D tmpCCKindex; + if (priv->cck_index !=3D tmp_cck_index) { + priv->cck_index =3D tmp_cck_index; CCKSwingNeedUpdate =3D 1; } =20 if (CCKSwingNeedUpdate) rtl92e_dm_cck_txpower_adjust(dev, priv->bcck_in_ch14); - if (priv->ofdm_index[0] !=3D tmpOFDMindex) { - priv->ofdm_index[0] =3D tmpOFDMindex; + if (priv->ofdm_index[0] !=3D tmp_ofdm_index) { + priv->ofdm_index[0] =3D tmp_ofdm_index; rtl92e_set_bb_reg(dev, rOFDM0_XATxIQImbalance, bMaskDWord, OFDMSwingTable[priv->ofdm_index[0]]); } --=20 2.34.1 From nobody Wed Feb 11 10:38:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC0FC77B7C for ; Wed, 10 May 2023 15:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237499AbjEJPJ4 (ORCPT ); Wed, 10 May 2023 11:09:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237571AbjEJPJt (ORCPT ); Wed, 10 May 2023 11:09:49 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F35C41993 for ; Wed, 10 May 2023 08:09:47 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1aad6f2be8eso68615405ad.3 for ; Wed, 10 May 2023 08:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683731387; x=1686323387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2MdUvkOQf/H6u+bsf32R+0B6I/OaVbOPJFXkpsnz650=; b=XceF3oromGb5RS/guK2wNN+F2+fqB6JGxs7JAUfy+IEbKlO7bEtxA6sXW708RRTFWP ZqnxwP405zkdO0YTUCrGlt/lBHeiWf0E4tUX1GA+PCCAPYxJonNfE5GpahOwbHlqAj+3 il9lkE7h45xz7Wcv/OZancE5Se6+GhgCnxaCYqcGYmHbFQJRJw+O+axe9tF1tn/T5/4Y qj3h0h39+rZHEOEs/Lhz4DUAnZQaleeubwdAATBlQqxi4QG787tbarETiRuOPQByXxdX GkLgea/YP03ocP4r7LJBMAcxzqi9T65axWaC7446iyfMeCMPU2/KqoRWejisvI539GxW 47ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683731387; x=1686323387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2MdUvkOQf/H6u+bsf32R+0B6I/OaVbOPJFXkpsnz650=; b=OZwIa5A/8LGQx++OORoZ+dB65TJk7WbkwfmXx+vtzKDYinF0BCnPoLv900vEF81oii 1ZVTzYffU0l4lYZg5N1HsM0b5ccqS8XXClX6hQ2v03setGKJLSgx4lmE3ag2JUR4/Os9 hLqRsal7nlEz/YlCKbhtyxiMtCTmWGt9Pv4H9mkxAE6ThoRFnMhixyU/KeoTSEnrpSW5 oH6ficC1ASGAnL7kabhiGkvOWj0Llh15Xl1roPkkuuNIn4Bvw6XlxURWPv4kS3QBl3Aa 44pxkBuhhD+wSuPdTdTSUyOs7zrnq+dFhJ2/4XNRG4F/1W4EnyWa1DK6HDhgfGGPwTJ2 cPGA== X-Gm-Message-State: AC+VfDyNRADdqFGH9jeTvR9OqFsndqYyh/MI1MEizsX6GO/cWB3SEThr S95XzdjGHOOvaioe5O1jQdQ= X-Google-Smtp-Source: ACHHUZ5h/G3A7pgdl0GfHmqF4GkzWayqzY9cVOhrOcG4jGAppA16m8qxu+4Svg3UWJ/bUXfGwNxSwA== X-Received: by 2002:a17:902:c94b:b0:1ab:14f2:e7e6 with SMTP id i11-20020a170902c94b00b001ab14f2e7e6mr21581496pla.65.1683731387410; Wed, 10 May 2023 08:09:47 -0700 (PDT) Received: from pop-os.localdomain ([103.251.210.208]) by smtp.gmail.com with ESMTPSA id m2-20020a1709026bc200b001a045f45d49sm3869439plt.281.2023.05.10.08.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 08:09:47 -0700 (PDT) Date: Wed, 10 May 2023 20:39:42 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] staging: rtl8192e: Rename tmpCCK20Mindex and tmpCCK40Mindex Message-ID: <3e8b6cd85e6e4fcc934cc1d813f5f594cef8ff92.1683730854.git.yogi.kernel@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable tmpCCK20Mindex to tmp_cck_20m_index and tmpCCK40Mindex to tmp_cck_40m_index to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 28 +++++++++++----------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 117c0538cf5f..a44be3f810ab 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -658,7 +658,7 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(str= uct net_device *dev) #define ThermalMeterVal 9 struct r8192_priv *priv =3D rtllib_priv(dev); u32 tmp_reg, tmp_cck; - u8 tmp_ofdm_index, tmp_cck_index, tmpCCK20Mindex, tmpCCK40Mindex, tmpval; + u8 tmp_ofdm_index, tmp_cck_index, tmp_cck_20m_index, tmp_cck_40m_index, t= mpval; int i =3D 0, CCKSwingNeedUpdate =3D 0; =20 if (!priv->tx_pwr_tracking_init) { @@ -689,33 +689,33 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(s= truct net_device *dev) priv->thermal_meter[1] =3D ThermalMeterVal; =20 if (priv->thermal_meter[0] >=3D (u8)tmp_reg) { - tmp_ofdm_index =3D tmpCCK20Mindex =3D 6+(priv->thermal_meter[0] - + tmp_ofdm_index =3D tmp_cck_20m_index =3D 6+(priv->thermal_meter[0] - (u8)tmp_reg); - tmpCCK40Mindex =3D tmpCCK20Mindex - 6; + tmp_cck_40m_index =3D tmp_cck_20m_index - 6; if (tmp_ofdm_index >=3D OFDM_TABLE_LEN) tmp_ofdm_index =3D OFDM_TABLE_LEN - 1; - if (tmpCCK20Mindex >=3D CCK_TABLE_LEN) - tmpCCK20Mindex =3D CCK_TABLE_LEN - 1; - if (tmpCCK40Mindex >=3D CCK_TABLE_LEN) - tmpCCK40Mindex =3D CCK_TABLE_LEN - 1; + if (tmp_cck_20m_index >=3D CCK_TABLE_LEN) + tmp_cck_20m_index =3D CCK_TABLE_LEN - 1; + if (tmp_cck_40m_index >=3D CCK_TABLE_LEN) + tmp_cck_40m_index =3D CCK_TABLE_LEN - 1; } else { tmpval =3D (u8)tmp_reg - priv->thermal_meter[0]; if (tmpval >=3D 6) { tmp_ofdm_index =3D 0; - tmpCCK20Mindex =3D 0; + tmp_cck_20m_index =3D 0; } else { tmp_ofdm_index =3D 6 - tmpval; - tmpCCK20Mindex =3D 6 - tmpval; + tmp_cck_20m_index =3D 6 - tmpval; } - tmpCCK40Mindex =3D 0; + tmp_cck_40m_index =3D 0; } if (priv->current_chnl_bw !=3D HT_CHANNEL_WIDTH_20) - tmp_cck_index =3D tmpCCK40Mindex; + tmp_cck_index =3D tmp_cck_40m_index; else - tmp_cck_index =3D tmpCCK20Mindex; + tmp_cck_index =3D tmp_cck_20m_index; =20 - priv->rec_cck_20m_idx =3D tmpCCK20Mindex; - priv->rec_cck_40m_idx =3D tmpCCK40Mindex; + priv->rec_cck_20m_idx =3D tmp_cck_20m_index; + priv->rec_cck_40m_idx =3D tmp_cck_40m_index; =20 if (priv->rtllib->current_network.channel =3D=3D 14 && !priv->bcck_in_ch14) { --=20 2.34.1 From nobody Wed Feb 11 10:38:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ACE6C77B7C for ; Wed, 10 May 2023 15:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237565AbjEJPKP (ORCPT ); Wed, 10 May 2023 11:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237504AbjEJPKN (ORCPT ); Wed, 10 May 2023 11:10:13 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8760A7AAE for ; Wed, 10 May 2023 08:10:09 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6439bbc93b6so4979644b3a.1 for ; Wed, 10 May 2023 08:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683731409; x=1686323409; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BbmQvMf9KzmVdxCSRKyarW++yF6GCnmLwgE9M2RotW4=; b=ZtJb+YQhL1NxXiVYXH/As6s0vhSNRYSvBGb+N15NM9sSTgykg2AjFG9qO3PG1SSAdX 3CzT1p1aXATma9d/PmwuFlgGVy7iPV0mFxdq0s4DTw30wK9x5u6+A4moyvlsOiikgmKe AebpEZLZg5GoW77NMWMF3/j1eyyDOkLUUU0EqMnk6swb6Fa0hyQ0dXmmyn2aywJMC7Kg zOTes6Wbgk23IVk/ItcrUYD/ki8KW08GvSbIgX6luFY4S1pMla1MDbBqgHS6hjyOjwtC ShxaC9GcJ/6967chkJuXT2NCet7fFBrtkg8OgXdS0F6KlQH5bM+1Nbl+4E+PuaK1vc+S 7C8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683731409; x=1686323409; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BbmQvMf9KzmVdxCSRKyarW++yF6GCnmLwgE9M2RotW4=; b=UirqQkQ/Mi0NLqvFo1lhlWQ059tueRdiPn11Q/xTlIl6VfeKNP0EyX+Fp0d9p0j7Z9 g8N40WxDWhRwbb/Hd1N8am8VvgcJsiplAw0afcfiYkue4gzhtIz1oKMzum8v9Q0YJuBm okHl8J+UornBTo3ET+Fj5UJRIc7APqoGIVDPB5THH9b7Chs8Su3DU0Sc4GrNrTPKuDOC pav9LXAqnblz1+Gb+bxq6QQTdZhJW+fmJ00T6a3IaEZSFkMX87M0IovFPit1mn1qvVJA c725W39rDRgjs1KHyaLzbwLmZuBlE+1lwxYCMVYmfWcxJivQvWpFBf3jaPISj23oG5h6 MbMQ== X-Gm-Message-State: AC+VfDzKQDr9t8b+NZoW3uS+75N7ZppmfgxFf6enq7+mYcS/QznXNHpq bOFkcIq4GG3O4Kwwvodt1SI= X-Google-Smtp-Source: ACHHUZ4t+R6GTCWUl02uKMGgbAc5ywYmosUfP/6Gl+Jt3HupOylaw31Ww4uk5dzkv3/izFGWD7N64g== X-Received: by 2002:a05:6a21:788f:b0:101:37b2:62f3 with SMTP id bf15-20020a056a21788f00b0010137b262f3mr8536263pzc.61.1683731408908; Wed, 10 May 2023 08:10:08 -0700 (PDT) Received: from pop-os.localdomain ([103.251.210.208]) by smtp.gmail.com with ESMTPSA id x6-20020aa793a6000000b00640f588b36dsm3697217pff.8.2023.05.10.08.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 08:10:08 -0700 (PDT) Date: Wed, 10 May 2023 20:40:04 +0530 From: Yogesh Hegde To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] staging: rtl8192e: Refactor tmp_ofdm_index variable assignment Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor tmp_ofdm_index variable assignment to avoid multiple assignments which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index a44be3f810ab..feac50cd8fa0 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -689,8 +689,8 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(str= uct net_device *dev) priv->thermal_meter[1] =3D ThermalMeterVal; =20 if (priv->thermal_meter[0] >=3D (u8)tmp_reg) { - tmp_ofdm_index =3D tmp_cck_20m_index =3D 6+(priv->thermal_meter[0] - - (u8)tmp_reg); + tmp_ofdm_index =3D 6 + (priv->thermal_meter[0] - (u8)tmp_reg); + tmp_cck_20m_index =3D tmp_ofdm_index; tmp_cck_40m_index =3D tmp_cck_20m_index - 6; if (tmp_ofdm_index >=3D OFDM_TABLE_LEN) tmp_ofdm_index =3D OFDM_TABLE_LEN - 1; --=20 2.34.1