From nobody Wed Dec 17 23:49:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 313E1C77B76 for ; Sun, 16 Apr 2023 07:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230180AbjDPHTp (ORCPT ); Sun, 16 Apr 2023 03:19:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbjDPHTm (ORCPT ); Sun, 16 Apr 2023 03:19:42 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 549FB30F4 for ; Sun, 16 Apr 2023 00:19:41 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f0968734f6so7960985e9.0 for ; Sun, 16 Apr 2023 00:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681629580; x=1684221580; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=84NlWGtUMgf40JNxMvQY6Sfwnuh3njHwFcbtsfdQMSc=; b=baquszBwmPrlDFk14HOGoFLBYnJ8GutC9P6PTy9dNwrHXIOExXawgkl4+vt6botSZ+ X3DRzeK/Nbcw6ipzV1cpix1CJ+NtxglQtYVg9C69KxGAtSQdT02w6ERn1HYd4ZUxZVJg 6/EkfPjFWgdo6X8MHnAUj6WPfcbtt3gVWQLBGYVxRYTaxyFeQ5iqZhb7cTdngIJS1SL7 yiF/gDWeHOBQ/fxOER/RiBqOCgDt21eFwjGq80ZXKEBWG4VrmvEm8cVrMmkarz2kKGVv Gi/2bf8z/aKRTIDNL44UYCyQX6z5VckAq0gIesHdaNyAGjKs7U8gplKpRqZdoJmDNByQ 6adw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629580; x=1684221580; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=84NlWGtUMgf40JNxMvQY6Sfwnuh3njHwFcbtsfdQMSc=; b=S0I/CzHgJeOiYOLY16HhVh+rtJPsm91hdDPpWVlePcr9KMPuu7zzE+I75GL1ffv+G4 LGkrtlo1O1NV5DQH90zWsK6XfmvJEf5re6+OMEI+gzA2JTGoAmvHH3lBEVw2hRVISpEb 6H7ufkn7BK30xO+mfS+8szIA4kqmabRAzm24QNX3ncwzJ93FP1R73bhM7xcOS0JwO2hy huykr2xQnWQOd+MNwDVO/bXFhnepPc/MXTPdm+fq1wVt1/nyfZBSOLSDMJH8HjQ4Sz42 sf4WLL8naRidbTT3Kta8LPo19rlKXBxMc276tTtH0pV3HpNS3SD0iS9izqai3ONs559A 2N1w== X-Gm-Message-State: AAQBX9dllpYGnPm7g0JGQtsQswYmJiFdlUb9XwUlKKCEwZK+2jjk088G x1YU2m5KfhHK0Loun1s0zvSeiOXMtYA= X-Google-Smtp-Source: AKy350ajWbbs61CS1wNRJpRYmnlvV7z8rtabuEracPKp0K7hShoagQm2PVqwvmDaM3zbY/BZGmto7A== X-Received: by 2002:a5d:6281:0:b0:2ef:9699:f906 with SMTP id k1-20020a5d6281000000b002ef9699f906mr4633502wru.7.1681629579682; Sun, 16 Apr 2023 00:19:39 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id n21-20020a7bc5d5000000b003e91b9a92c9sm8567755wmk.24.2023.04.16.00.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 00:19:39 -0700 (PDT) Date: Sun, 16 Apr 2023 09:19:37 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/8] staging: rtl8192e: Remove unchanged variable RegRfPsLevel Message-ID: <49162b0041db33c6c43c4126839baed69c76cb89.1681627603.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unchanged variable RegRfPsLevel and equations that have always the same result to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 +-------- drivers/staging/rtl8192e/rtllib.h | 1 - 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index dd666701138e..4b0ebe96302e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -1089,14 +1089,7 @@ static bool _rtl92e_set_rf_power_state(struct net_de= vice *dev, if (i >=3D MAX_DOZE_WAITING_TIMES_9x) break; } - if (psc->RegRfPsLevel & RT_RF_OFF_LEVL_HALT_NIC && - !RT_IN_PS_LEVEL(psc, RT_RF_OFF_LEVL_HALT_NIC)) { - rtl92e_disable_nic(dev); - RT_SET_PS_LEVEL(psc, RT_RF_OFF_LEVL_HALT_NIC); - } else if (!(psc->RegRfPsLevel & - RT_RF_OFF_LEVL_HALT_NIC)) { - rtl92e_set_rf_off(dev); - } + rtl92e_set_rf_off(dev); break; default: bResult =3D false; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b1729d65f67f..1a0e7ae70ca6 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1237,7 +1237,6 @@ struct rt_pwr_save_ctrl { u8 LPSAwakeIntvl; =20 u32 CurPsLevel; - u32 RegRfPsLevel; }; =20 #define RT_RF_CHANGE_SOURCE u32 --=20 2.40.0 From nobody Wed Dec 17 23:49:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB1CFC77B72 for ; Sun, 16 Apr 2023 07:20:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbjDPHT6 (ORCPT ); Sun, 16 Apr 2023 03:19:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230183AbjDPHTy (ORCPT ); Sun, 16 Apr 2023 03:19:54 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1616D358C for ; Sun, 16 Apr 2023 00:19:48 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f05f61adbeso5879595e9.0 for ; Sun, 16 Apr 2023 00:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681629588; x=1684221588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JlBWI0Ks0qD6ovVmGF/S6pEdK+jxnqFwR9r0p5tYFXk=; b=oxJDFFo/k2jg6JAIz8X8BJqVZoCsd07p6Z/eM/8KtQJ4YeO8ZagSAfzAP1zo3K1I33 kz51qmSc3TOyn4n9Ih+WWNzVwe/uHIKoFowrFre/Th32yFF+3+c8gThwQ5dSBgqM8Xq6 qnPs7vOCvmywAHWcpP8ws7KI7YvaVNvWOQQyLfjR1fyxTI8WsKNj64hDvWQjj9dGoJ3K AYjxR0PsDPBRdbLRpTesd+FY4hFGzoJGZzEIUpVcnZ+eQbG7C9ix1eq325iAEIXq81vk fIJW+1h2yFkq3L3QynQQMhS3AHkQq0PYl6XV/ZG/oO//2lhSVCTgUyytc0kr7Xr6nJfO nHZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629588; x=1684221588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JlBWI0Ks0qD6ovVmGF/S6pEdK+jxnqFwR9r0p5tYFXk=; b=N3m802E+JJAewI3Q4sCfywSVT9uvwVyelffuCGwLMekiXRXFvY3zWYEEcViz7Zsi3l VVBCi97zwFUtPBWABaffMGuRdrvtjRKvTlKEZlDuDbUnaAJa+YbY6XrUBx85cOqU7VJI 80SzfCc7kZxnd7sqjX50xhRKGW3wRwBH+Lz93LJt6rQCIzUPvYxqA+oNAbAFag0SDO5U kVENnER9y1r3iExHBbCUfixZ4U8nGzPx6rDXJYDH+uEGOc43pCUjxH0l0WWM9DVWyh4h BGdSU3+ac5aWjBkX3Beg8951q/c/ZC2zAsNrOpP5zo7VlqbrIBvbNhbZqfnFw0bfk4RR MiWQ== X-Gm-Message-State: AAQBX9eMqSvtO04Ug/1uTX4iv9ow2LK37SYfucseUXsIm/fwwIrEEIpr 7zyP73S2b+Tpzld06hSHO5w= X-Google-Smtp-Source: AKy350agzu/KqAP3xikKyPT9eXV2SN5ENPF2l9Ot66EfD6e1Nga2nW/CegA8GhimOq++asF0ED9i/w== X-Received: by 2002:a05:6000:112:b0:2f9:ee11:e5c3 with SMTP id o18-20020a056000011200b002f9ee11e5c3mr325999wrx.2.1681629588144; Sun, 16 Apr 2023 00:19:48 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id s15-20020adfeb0f000000b002c55306f6edsm7412460wrn.54.2023.04.16.00.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 00:19:47 -0700 (PDT) Date: Sun, 16 Apr 2023 09:19:45 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/8] staging: rtl8192e: Remove unused function rtl92e_disable_nic Message-ID: <5ce2ef58f66e25d7db7432c56c7b7c37a2b15fc1.1681627603.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused function rtl92e_disable_nic to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 16 ---------------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 - 2 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index a644543015ee..a0c6d117211a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2302,22 +2302,6 @@ bool rtl92e_enable_nic(struct net_device *dev) return init_status; } =20 -bool rtl92e_disable_nic(struct net_device *dev) -{ - struct r8192_priv *priv =3D rtllib_priv(dev); - u8 tmp_state =3D 0; - - priv->bdisable_nic =3D true; - tmp_state =3D priv->rtllib->state; - rtllib_softmac_stop_protocol(priv->rtllib, 0, false); - priv->rtllib->state =3D tmp_state; - _rtl92e_cancel_deferred_work(priv); - rtl92e_irq_disable(dev); - - rtl92e_stop_adapter(dev, false); - return true; -} - module_pci_driver(rtl8192_pci_driver); =20 void rtl92e_check_rfctrl_gpio_timer(struct timer_list *t) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index b0aa76574738..51240cbde0d3 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -433,7 +433,6 @@ u8 rtl92e_rx_db_to_percent(s8 antpower); void rtl92e_copy_mpdu_stats(struct rtllib_rx_stats *psrc_stats, struct rtllib_rx_stats *ptarget_stats); bool rtl92e_enable_nic(struct net_device *dev); -bool rtl92e_disable_nic(struct net_device *dev); =20 bool rtl92e_set_rf_state(struct net_device *dev, enum rt_rf_power_state state_to_set, --=20 2.40.0 From nobody Wed Dec 17 23:49:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 687EFC77B61 for ; Sun, 16 Apr 2023 07:20:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjDPHUJ (ORCPT ); Sun, 16 Apr 2023 03:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230203AbjDPHUF (ORCPT ); Sun, 16 Apr 2023 03:20:05 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30EBF30D8 for ; Sun, 16 Apr 2023 00:19:56 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3f167d0cbb7so1330225e9.0 for ; Sun, 16 Apr 2023 00:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681629594; x=1684221594; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xwqobIGOuNNlDjWDqP0aoWUSzuDynHZFKSCMK2X1W5s=; b=MS/9uKs70i2Y0OM91fP96hPnooh51wKOYR5q7O5FvAeHvt655iTNAegCBM1Ui5KHEV +z94oAHtcUPe8k0yJ/pTt5aaHdfPIc4bjaVuVLUhAB/WiOK/VsLBZHdrH99eqL4XRDE5 GVCrcc7QXkWpXNB3Io3SBgSxWQK907xsxRYcxt0XdfQSQZv5ZdBKoRd15y3/wuMnc4/G znizZcWO8/kEzdAt4qgSy/YB43NEqoJOZc5cYS3XhO8/Iz/dpD3/M15iyKBpB7YyalFD O+caYr2XaXzdpHMOHWfVvw/Z58cqsAqcYtzMEJIt8XAp9F+LY5trPSVCpLA6OYLmLRxi inVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629594; x=1684221594; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xwqobIGOuNNlDjWDqP0aoWUSzuDynHZFKSCMK2X1W5s=; b=Ead2baW1cKOpSLbJBuabwibMDm5cqx59v56yI6CCHXuY4kHASFH9llh16miezaAEB6 BGUdEnFlUeVDaA0i0WSGBR2u2gPKK8mxaHdCmprT3mKqIvtAQd30Z+3aLazRebe7B/ko /gtJ4FETFoyUSulaJCP+bcPKSwLj5PG4+ZD+AXxT+tdEItTNiDHlejowY8PgV1iaujg1 4NAtD5okN7dXMF8JxqhZa01U8lvZc60evg8JDQ5868XYD9E1wYUDRUUgSjUW8iZS3W7i oFiG34OZKsJr/1TncxIDQBMoa5OT1GwttGAGg31Kv8zrNSFqvMW1zlqUyKeopMr1yItg 8+Yw== X-Gm-Message-State: AAQBX9fyjrcOGstq26/MJ5Jnl318o1JRwzk37J+RSbzebTREjeZgkFmz e512lN83+2vYpZ57ueucrBXXihha9lw= X-Google-Smtp-Source: AKy350Z/+ex1LitSfEe3lLjtUEoaf67Zo88uq8SYG3OMeuLLafoRZBqhesiGEu3AZyjPPElo2Y3O6A== X-Received: by 2002:adf:fc8b:0:b0:2e4:ccb1:dba5 with SMTP id g11-20020adffc8b000000b002e4ccb1dba5mr4415020wrr.4.1681629594654; Sun, 16 Apr 2023 00:19:54 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id y18-20020adff6d2000000b002daf0b52598sm7427281wrp.18.2023.04.16.00.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 00:19:54 -0700 (PDT) Date: Sun, 16 Apr 2023 09:19:52 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/8] staging: rtl8192e: Remove unused macro RT_SET_PS_LEVEL Message-ID: <0d397210830f77ad3231c3b4a0465ae89aacb962.1681627603.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused macro RT_SET_PS_LEVEL to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 1a0e7ae70ca6..6e665e866f1f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -100,7 +100,6 @@ static inline void *netdev_priv_rsl(struct net_device *= dev) ((psc->CurPsLevel & _PS_FLAG) ? true : false) #define RT_CLEAR_PS_LEVEL(psc, _PS_FLAG) \ (psc->CurPsLevel &=3D (~(_PS_FLAG))) -#define RT_SET_PS_LEVEL(psc, _PS_FLAG) (psc->CurPsLevel |=3D _PS_FLAG) =20 /* defined for skb cb field */ /* At most 28 byte */ --=20 2.40.0 From nobody Wed Dec 17 23:49:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABBA3C77B76 for ; Sun, 16 Apr 2023 07:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230214AbjDPHUN (ORCPT ); Sun, 16 Apr 2023 03:20:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230216AbjDPHUL (ORCPT ); Sun, 16 Apr 2023 03:20:11 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B92093C01 for ; Sun, 16 Apr 2023 00:20:02 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-2f44739a2afso407187f8f.1 for ; Sun, 16 Apr 2023 00:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681629601; x=1684221601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=90mE4vdn9DzTlSbEbDUJ0ZvC16lpbnbcfCKswzbdsYs=; b=VSdKfd6tV+8i05h89Gqj1/SH4zXlr3DvwA7iTIRF3rbn0aSxn7thUq4cJNwm4a/nDP viD1eCUNbN/SwsZwS6SbnljvK0WLZVu0x9kpv/6LkJNzRgqvi6IIpHftz8efjIubOJvR +JcupzZiYw8X0HNjGoTh/nxDMq/JP6Tgyi38p8RnaicRp0YrqMra6uP/OkevglzP9QF2 3OqTWTmhi/xu/s9iHs7c+HfbOrPJG57tbTo3gPZMhuHrodS/WbAsr2zZulFTnGHpILNH otGQh1JxICB4TiNMaVGgP/6Yna9VBdCYmHYbapv7x2UiS6Hryn4gN0v7eHxa/xMpI1hT KCOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629601; x=1684221601; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=90mE4vdn9DzTlSbEbDUJ0ZvC16lpbnbcfCKswzbdsYs=; b=ByMpDvJf+I+A+Sp46KYgTsOAi/3AYMSUBgmahec99zAFInnLDpruo+FpD229X63d/P YdGOxqhC+8Z0RQa/+3lNnWnthjNJx+TxBn0Cf1tOEVMIMrU3ceqeNn4Y+1eVJwjSE2gJ V/ZptaiUChrdVgBWUSMkPQpuLe6t1zBuwG2DVMeKZOGR2ApB05adi2z0r0P2bgfiWWCM Y2vTStmRt/JOs5tXuHA0Yij/pXWLgFGw1yPXYdXO/bNL7VXIq2WYxu8AJuyQJYR1QojU /Vd1rv4UrbmFkK65Wy118+P5DjuqOBkA8sNMqDPP7vkg4EF4Vfjo92hQroLTqD9985dK Apig== X-Gm-Message-State: AAQBX9c8R0Rh1VXLowbn6mx5w5QSqljsqYThyy2t0E6zoGQBw2uPK9Zq AfWPdJIoatqhvFthZsg0pWI= X-Google-Smtp-Source: AKy350a4IN4nnH5XTOwrfTuJMdHp0biWw11GVr9plvTPUzlCsevkSGG8ElTmF0/m7+UA5g4YDCZa7w== X-Received: by 2002:a5d:6d4c:0:b0:2f7:dc6a:9468 with SMTP id k12-20020a5d6d4c000000b002f7dc6a9468mr3384392wri.3.1681629600725; Sun, 16 Apr 2023 00:20:00 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id s15-20020adfea8f000000b002d1801018e2sm7388202wrm.63.2023.04.16.00.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 00:20:00 -0700 (PDT) Date: Sun, 16 Apr 2023 09:19:58 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/8] staging: rtl8192e: Remove second initialization of bActuallySet Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove second initialization of bActuallySet to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 93504d5a8578..7342ef591169 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -1539,8 +1539,6 @@ static void _rtl92e_dm_check_rf_ctrl_gpio(void *data) enum rt_rf_power_state rf_power_state_to_set; bool bActuallySet =3D false; =20 - bActuallySet =3D false; - if ((priv->up_first_time =3D=3D 1) || (priv->being_init_adapter)) return; =20 --=20 2.40.0 From nobody Wed Dec 17 23:49:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4303CC77B72 for ; Sun, 16 Apr 2023 07:20:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbjDPHUb (ORCPT ); Sun, 16 Apr 2023 03:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230198AbjDPHU1 (ORCPT ); Sun, 16 Apr 2023 03:20:27 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C565435BC for ; Sun, 16 Apr 2023 00:20:10 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f0c5a426aaso3847345e9.1 for ; Sun, 16 Apr 2023 00:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681629608; x=1684221608; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3sQy4s8gKGVczlWnljrStDth9N5l0gCvMunNzrUK7V4=; b=dquZOYPM9/nNsKWfMEHGolT2T5M7XCO/lBux8GNZUVpURx63aXgcknmp0dYLkkRXlV BqOObD6pWZ16ZK89eDqEjCipG5TIhBzdU1Vk9/SnwJusVksnrwJ/DNoDW8WAyTQJpu92 45UPoFAXANVPRScQigVBTdBdiyd4/TfcW/IAqHfFtQLADHFWDWHTmK05qKvv6Dd6kJZv 5liMO3fd5o4FzQ4EGVQIJrOx273lOwVfEIyNJuC++NaE1WKRM+x+fcTsEeQTrjUPGaCs AEF4GuX0uUCrTe8vOHzqcvfwQFyfCXsQg4fA1pikYjzF98VWpB6r9BwBm8YyklZBt258 mWTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629608; x=1684221608; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3sQy4s8gKGVczlWnljrStDth9N5l0gCvMunNzrUK7V4=; b=SMkJNSUImnc2ftfToEnDbHqsOxCLxrfl9klEkA1J0r/MyFc/I6P85UfMja46Dbh61b WzRE2fPnGQ18Zwn/loBcIC8UF8cV7NHUHnEtYP+/7MPZUmB6H6GQKimx4sLo+fFqsplL CKI6gjW1kBDvhp4K5sa3+LctL7IcgU+EF/OPoHVNXZ8vmyo63tKjA91REdX/S4QrdcwK w65OyC285KmXDdcImcHTZRLShjKAH8v/VX/fpes+6DM+ka5z1LTXse43f8lyJb0UFPcb Vk2X060HpEV28mObkUFtlgS+dLGC6bEJYReAkINnS1tDMJP3UDN/RCAahm+AV5tC2riE VHFA== X-Gm-Message-State: AAQBX9evBz8o/iSKwJA8BcKdfGi5GTHIEic8aA2NhdZR3Meq31h+sBKz l44wGz2DhFj/24GwMxDg8lV1hwnJ5fo= X-Google-Smtp-Source: AKy350YZQstyORQTHMwBxbX2MVAYnNGd4gNX/Rg5+KRPqNYjBK3ui7IUxuh9uhUDhy6ZoohJCYpnsw== X-Received: by 2002:a05:600c:450f:b0:3f1:714d:c40b with SMTP id t15-20020a05600c450f00b003f1714dc40bmr855206wmo.3.1681629608269; Sun, 16 Apr 2023 00:20:08 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id iz19-20020a05600c555300b003f1733feb3dsm167648wmb.0.2023.04.16.00.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 00:20:07 -0700 (PDT) Date: Sun, 16 Apr 2023 09:20:06 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/8] staging: rtl8192e: Remove set to true while true of bfirst_after_down Message-ID: <053ab341e80909e81867e42ec4c077e76b762051.1681627603.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove set to true while true of bfirst_after_down to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 7342ef591169..ed8b39d3c856 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -1542,10 +1542,8 @@ static void _rtl92e_dm_check_rf_ctrl_gpio(void *data) if ((priv->up_first_time =3D=3D 1) || (priv->being_init_adapter)) return; =20 - if (priv->bfirst_after_down) { - priv->bfirst_after_down =3D true; + if (priv->bfirst_after_down) return; - } =20 tmp1byte =3D rtl92e_readb(dev, GPI); =20 --=20 2.40.0 From nobody Wed Dec 17 23:49:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F21CEC77B72 for ; Sun, 16 Apr 2023 07:20:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230230AbjDPHUk (ORCPT ); Sun, 16 Apr 2023 03:20:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbjDPHUg (ORCPT ); Sun, 16 Apr 2023 03:20:36 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 670E8448A for ; Sun, 16 Apr 2023 00:20:15 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f05f61adbeso5880065e9.0 for ; Sun, 16 Apr 2023 00:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681629615; x=1684221615; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K6KW2PuE6P/kp4akhCiH7Sdg4oCedA/I/EoMEq7tlfU=; b=CZn/S7FnVfpzAK2O+MIC993MubTweoYi2b0kLcTR3DfnbjRf6cQ4pzcSSmkDpfSzm9 R8VObwR6/8AG3HzELGMGv8dDvLzys99MxhaOU4bAfCKZm+toknizX+Tl2sfK2N3p/9yJ 3G2O7PvMV6OfSOIWZ1ZRXVUlrp18DKWiCflvdDKrQXC/h5UOx2eEbNSXHh0xx05p8es0 xu5ahE5zI/MlpLX/gHB5+4rr1CGB8Ns7uJQMADOYE02YOwp5bF+XvQMyKL+gaXQW+RSg MxrvIU/3puKczz5nrPJcfN1HxSNuYyhAj01Ko8tHcqgO+huRw5MfTQcmcZrIn4BTDVsY qFgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629615; x=1684221615; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K6KW2PuE6P/kp4akhCiH7Sdg4oCedA/I/EoMEq7tlfU=; b=JSUKvngj4yh/bQD+X3ot/g+jS/Xmck8YCfqEzqei1TXLd1MeXFlfvZ6znfu6vUfI4U MfDzLjemn0fM0eNlmGI4fBbnifQ1Dwc3wNOH7RuVZ3Qe6uX4m1GenQGCag0w1Opj1tlN YEueQv/cyTwMIfUS3RYriJREZq9bg41vQZkxsIT/0iCuiK1VfQFMdi4g6X87oTKKhi4c EgGF/KauONx6CiWBA/kNBlqD6ZJvJmAW/jriwOGpNAeYJiTEPvGIpU6NIfS4EcMbFc48 AMHrbPff0k6j1Ffzxic/BvejVPRH30m3IpDHjt2URlwjp8xB4HkYDQ9SounqWun8CLG8 C7gg== X-Gm-Message-State: AAQBX9chHwyzMwk9S2tG7EPA9oG9gzCVjiyWUxLrbV4n+Dh0FaD7Q7gM AIQJmiI4Oy9qmM74yKGKKYs= X-Google-Smtp-Source: AKy350bGjtWeR3gK8kXbPzhir2vkzZs20IZA8ABoWWJWn7J+vjLNB6cMWP/Dn13R6eMaDYboT9i/wQ== X-Received: by 2002:a05:600c:3ca0:b0:3f0:a845:f215 with SMTP id bg32-20020a05600c3ca000b003f0a845f215mr5380689wmb.3.1681629614746; Sun, 16 Apr 2023 00:20:14 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id 14-20020a05600c020e00b003eb596cbc54sm8547121wmi.0.2023.04.16.00.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 00:20:14 -0700 (PDT) Date: Sun, 16 Apr 2023 09:20:12 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/8] staging: rtl8192e: Remove unchanged variable chan_forced Message-ID: <3f218531a9d31c399d1351d3da7f9ca13d20df0c.1681627603.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unchanged variable chan_forced and equations that have always the same result to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index a0c6d117211a..88ff54173a1f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -249,9 +249,6 @@ static void _rtl92e_set_chan(struct net_device *dev, sh= ort ch) { struct r8192_priv *priv =3D rtllib_priv(dev); =20 - if (priv->chan_forced) - return; - priv->chan =3D ch; =20 if (priv->rf_set_chan) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 51240cbde0d3..0eca73e4540f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -392,8 +392,6 @@ struct r8192_priv { bool reset_in_progress; bool force_reset; bool force_lps; - - bool chan_forced; }; =20 extern const struct ethtool_ops rtl819x_ethtool_ops; --=20 2.40.0 From nobody Wed Dec 17 23:49:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B6C6C77B72 for ; Sun, 16 Apr 2023 07:20:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230270AbjDPHUp (ORCPT ); Sun, 16 Apr 2023 03:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230232AbjDPHUi (ORCPT ); Sun, 16 Apr 2023 03:20:38 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED91A30C7 for ; Sun, 16 Apr 2023 00:20:21 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3f167d0cbb7so1330645e9.0 for ; Sun, 16 Apr 2023 00:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681629621; x=1684221621; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AUb4sZWN17aC9uOKE2iR6leNu0T6NHURX++nzdcY5IQ=; b=MylfWUa6l5E2JtYJ7hpuPbEowIeba5IImp/dH6hgWNM0p9QGdUDaDmtisIubZwQikE mxbLM6ZUClNtfMR3LTvZcpcsGxu1aOWLXm2yEgq1hwd7Cw5rsfinlP41oSTV2yuf5i5b VJsHlBQBQpco06d6T6/kDyihQwNxfJWEKIpdYAP16tzjwrs4ugGWk1l1+il/z6qYeNPX /XENEnca5zJTrglitawS/ZrwzBcZLlUTuY33QE7DbTvi0lRwUVuLl1oGdyu+w8pZDJvU Dn083f7fDbTaIIsK2PKzZKG9anqP3xoYXaII+lj/QRY7onhngkOWpy84Lj8kq3YpJSxp lUKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629621; x=1684221621; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AUb4sZWN17aC9uOKE2iR6leNu0T6NHURX++nzdcY5IQ=; b=ZT2UfO9lXMJzGa6byw+78s0jktqnZ54sHTJTXWMexknywV2fsDTZRf50bSA77HDSwB mILcLGFvWbCOAdZIZiKFAh5mLPRXCYzB1DPp1rL3LfY4NSHxZK66Y45O5rYN6LXIJ0S9 RXVcO0UrF8uhhgft0mHBQ3CN1tDeCBGlGU6XI0wLqX2U65Hc58lEe7jqNAaFMlu090KN 2chqcbnCo3EW/4dULzXV09YcdNXRi61liIedh1bzJPqJfUxvZKb1duZqlTduFf27643w cakRvJX0BhlM/HEf8wfbp+Znu7aSwlCL4IR8BEzn4kTrPH/lylHbLBGNGBaskgyYk/92 lFgA== X-Gm-Message-State: AAQBX9eqQucwmNpEwgHBywqXVmY/j6b1xIoCeEQBPpd5DAF1NWVfsixb xIYCEdTGMdF/NwCKtdslgns= X-Google-Smtp-Source: AKy350YitU+UU2jw5wDn+l9M1NI73lhAQ0cERXBFyYf6PJFI8vTl1eBeYIT5zZaG79bcRBNm5JGTEw== X-Received: by 2002:a5d:58d8:0:b0:2f7:ee2:c2a3 with SMTP id o24-20020a5d58d8000000b002f70ee2c2a3mr4343301wrf.3.1681629621442; Sun, 16 Apr 2023 00:20:21 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id d4-20020a056000114400b002cea8f07813sm7351663wrx.81.2023.04.16.00.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 00:20:20 -0700 (PDT) Date: Sun, 16 Apr 2023 09:20:19 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 7/8] staging: rtl8192e: Remove unchanged variable frame_sync_monitor Message-ID: <0c4bdca5f5dbb93bb05c6b7f32136d4dfb3b0e4b.1681627603.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unchanged variable frame_sync_monitor and equations that have always the same result to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 - drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 73 ++++++++------------ 2 files changed, 30 insertions(+), 45 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 0eca73e4540f..c97e315a9091 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -382,8 +382,6 @@ struct r8192_priv { u32 continue_diff_count; bool bswitch_fsync; u8 framesync; - u8 frame_sync_monitor; - u32 reset_count; =20 enum reset_type rst_progress; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index ed8b39d3c856..43e335ab0733 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -1826,7 +1826,6 @@ static void _rtl92e_dm_init_fsync(struct net_device *= dev) priv->rtllib->fsync_firstdiff_ratethreshold =3D 100; priv->rtllib->fsync_seconddiff_ratethreshold =3D 200; priv->rtllib->fsync_state =3D Default_Fsync; - priv->frame_sync_monitor =3D 1; =20 timer_setup(&priv->fsync_timer, _rtl92e_dm_fsync_timer_callback, 0); } @@ -2053,12 +2052,10 @@ static void _rtl92e_dm_check_fsync(struct net_devic= e *dev) =20 } } - if (priv->frame_sync_monitor) { - if (reg_c38_State !=3D RegC38_Fsync_AP_BCM) { - rtl92e_writeb(dev, rOFDM0_RxDetector3, 0x95); + if (reg_c38_State !=3D RegC38_Fsync_AP_BCM) { + rtl92e_writeb(dev, rOFDM0_RxDetector3, 0x95); =20 - reg_c38_State =3D RegC38_Fsync_AP_BCM; - } + reg_c38_State =3D RegC38_Fsync_AP_BCM; } } else { switch (priv->rtllib->fsync_state) { @@ -2075,50 +2072,40 @@ static void _rtl92e_dm_check_fsync(struct net_devic= e *dev) break; } =20 - if (priv->frame_sync_monitor) { - if (priv->rtllib->state =3D=3D RTLLIB_LINKED) { - if (priv->undecorated_smoothed_pwdb <=3D - RegC38_TH) { - if (reg_c38_State !=3D - RegC38_NonFsync_Other_AP) { - rtl92e_writeb(dev, - rOFDM0_RxDetector3, - 0x90); - - reg_c38_State =3D - RegC38_NonFsync_Other_AP; - } - } else if (priv->undecorated_smoothed_pwdb >=3D - (RegC38_TH+5)) { - if (reg_c38_State) { - rtl92e_writeb(dev, - rOFDM0_RxDetector3, - priv->framesync); - reg_c38_State =3D RegC38_Default; - } + if (priv->rtllib->state =3D=3D RTLLIB_LINKED) { + if (priv->undecorated_smoothed_pwdb <=3D + RegC38_TH) { + if (reg_c38_State !=3D + RegC38_NonFsync_Other_AP) { + rtl92e_writeb(dev, + rOFDM0_RxDetector3, + 0x90); + + reg_c38_State =3D + RegC38_NonFsync_Other_AP; } - } else { + } else if (priv->undecorated_smoothed_pwdb >=3D + (RegC38_TH+5)) { if (reg_c38_State) { - rtl92e_writeb(dev, rOFDM0_RxDetector3, - priv->framesync); + rtl92e_writeb(dev, + rOFDM0_RxDetector3, + priv->framesync); reg_c38_State =3D RegC38_Default; } } + } else { + if (reg_c38_State) { + rtl92e_writeb(dev, rOFDM0_RxDetector3, + priv->framesync); + reg_c38_State =3D RegC38_Default; + } } } - if (priv->frame_sync_monitor) { - if (priv->reset_count !=3D reset_cnt) { - rtl92e_writeb(dev, rOFDM0_RxDetector3, - priv->framesync); - reg_c38_State =3D RegC38_Default; - reset_cnt =3D priv->reset_count; - } - } else { - if (reg_c38_State) { - rtl92e_writeb(dev, rOFDM0_RxDetector3, - priv->framesync); - reg_c38_State =3D RegC38_Default; - } + if (priv->reset_count !=3D reset_cnt) { + rtl92e_writeb(dev, rOFDM0_RxDetector3, + priv->framesync); + reg_c38_State =3D RegC38_Default; + reset_cnt =3D priv->reset_count; } } =20 --=20 2.40.0 From nobody Wed Dec 17 23:49:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5B7C77B61 for ; Sun, 16 Apr 2023 07:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230291AbjDPHUt (ORCPT ); Sun, 16 Apr 2023 03:20:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbjDPHUl (ORCPT ); Sun, 16 Apr 2023 03:20:41 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DC8B30D8 for ; Sun, 16 Apr 2023 00:20:28 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-2f44739a2afso407251f8f.1 for ; Sun, 16 Apr 2023 00:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681629628; x=1684221628; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8k9nO2fKVUUnwg/PlGeQfjbj4jMnL8QuYn9ONfwhXe4=; b=sNI+KFfcbiffyf/EojEIoeeerwb5EobglE7DpjCOkmAa3g0CQ+eysVPTAHBhgG8ztK AxIpWSVoKAkW5WMzFvz2ERsWrlDub+4d8ut8NKFTwa4eqc3juDJuHWrxeZ4CjOl3NIUj NxTS8tFIPAbkL9gpf3/mKn5hqzLkZCiBl9TqJpUMXXO3Fty5Q+20iTS19A2EVWfx62hg MKIMOqqcYocgRxy0oNJqw3HheaHOJNiou7SNplPGqTGdjui/kHmxhnWlsXYhqNb0t0AZ TFG17W6y/pOz6lJPHzGGyaAUDDga50KIDSb0VI/3w12h74WCoj8b0Ur1tju4aK+GW04i gduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629628; x=1684221628; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8k9nO2fKVUUnwg/PlGeQfjbj4jMnL8QuYn9ONfwhXe4=; b=jf3fs8rSETlXljO/0n1b6LlDb4GzqQP9NVPvnqgjQCMa/IBCahM4spMGzS7g9Jpoq1 yTP/TRVEhye9032sX0Axgfm7mvBCHQqd2P/WtMafQeo510wkv+o2pLZUthIaVk/hrFZS OzjzyJGJE1NmncB00gaOmeJIzdEu5Sn4te8dx4xwxuQYVMm0bgr+8kyi9jVYcvv+RVH5 dKfHn8qvUyCqdbQ/oSt6Isw9Ud6ujJNQpfeGPA48j7Y0WeGlK+DYSAi5hWNCgPbhaO0D JwYoAsnes8nEhxxwgF8JoerKwMaLRa08+g+gt/GnRQ6HQl8hUUCavBD6N3nLUcRd+Cxx ZWlg== X-Gm-Message-State: AAQBX9eZj5eK5xRtXc4QJnNjoOWFqlzju4uErBV8zQXWOAtFNgT49ppl HCiYxH/fP6GhUGIxP8quPfW44gJeO6M= X-Google-Smtp-Source: AKy350btAN4DW4CTH6qT6sz3xd8RKmz9VH32cpkb6NnPX0LeUxjcUaGl8ZGZzJGvd9Sq5U24p8uI9g== X-Received: by 2002:a05:600c:1d11:b0:3f1:7138:91ee with SMTP id l17-20020a05600c1d1100b003f1713891eemr899513wms.2.1681629628131; Sun, 16 Apr 2023 00:20:28 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id f20-20020a1c6a14000000b003f17329f7f2sm291552wmc.38.2023.04.16.00.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 00:20:27 -0700 (PDT) Date: Sun, 16 Apr 2023 09:20:25 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 8/8] staging: rtl8192e: Remove unchanged variables bfsync_processing and more Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unchanged variable bfsync_processing and rfc_txpowertrackingindex_real to shorten code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 1 - 3 files changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 88ff54173a1f..27040d1e3230 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -786,7 +786,6 @@ static void _rtl92e_init_priv_variable(struct net_devic= e *dev) priv->rtllib->short_slot =3D 1; priv->promisc =3D (dev->flags & IFF_PROMISC) ? 1 : 0; priv->bcck_in_ch14 =3D false; - priv->bfsync_processing =3D false; priv->cck_present_attn =3D 0; priv->rfa_txpowertrackingindex =3D 0; priv->rfc_txpowertrackingindex =3D 0; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index c97e315a9091..285dac32c074 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -357,7 +357,6 @@ struct r8192_priv { u8 rfa_txpowertrackingindex_real; u8 rfa_txpowertracking_default; u8 rfc_txpowertrackingindex; - u8 rfc_txpowertrackingindex_real; bool btxpower_tracking; bool bcck_in_ch14; =20 @@ -376,7 +375,6 @@ struct r8192_priv { bool bcurrent_turbo_EDCA; bool bis_cur_rdlstate; =20 - bool bfsync_processing; u32 rate_record; u32 rate_count_diff_rec; u32 continue_diff_count; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 43e335ab0733..56a8ec517c06 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -998,7 +998,6 @@ void rtl92e_dm_backup_state(struct net_device *dev) u32 bit_mask =3D bMaskByte0; =20 priv->bswitch_fsync =3D false; - priv->bfsync_processing =3D false; =20 if (dm_digtable.dig_algorithm =3D=3D DIG_ALGO_BY_RSSI) return; --=20 2.40.0