From nobody Wed Feb 11 09:41:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C5EC7619A for ; Sun, 2 Apr 2023 14:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbjDBOc4 (ORCPT ); Sun, 2 Apr 2023 10:32:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230488AbjDBOcy (ORCPT ); Sun, 2 Apr 2023 10:32:54 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3621D86AF for ; Sun, 2 Apr 2023 07:32:53 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id cn12so107736188edb.4 for ; Sun, 02 Apr 2023 07:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680445971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N4O3XZtJ4K7opusRPJDG2obDOo5CziuFWNMf3s6wXVg=; b=NEZ9LvN/mLZqMYlZ9L97ckgrRkCra4szM2G/LmlReGnOgGbBbef0SywgS4v/MorZA5 vpnrDojGnEoS35dcoYWOup6RUSnCjG4WLkeS2dy1vLcnmPN1iXPOX0385h2+hFeqkUEE TPzQQgqE0XzgFTDtMnPzKmBLjPhNZhmAlziVLSEybCsriR2YGd7sZkcfXxiwN6UrnFtT h2LsUEwUN6WoC5mf5BovXQ8PWhH8NwX6MiHh+hNb8tvHvG3MZOyuUCmKbxzx1gkyy+Lx 8FjrRuW8IWLlwoQ7T9OdPyFnMxizP0A45rgOZWubPQ7IPhtrKVY4B+TmSxI120+XdPp5 M0jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680445971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N4O3XZtJ4K7opusRPJDG2obDOo5CziuFWNMf3s6wXVg=; b=LhnVfA+BjTy9/9SSPUHeF3xpW+Jwq+Gvnerms5fqxjh3TWlAMk9iGfIBwAml16fqRU arM4bMvUptsQi5kkxWVH3VTyMc35Ji/wr+SqHDiBP1kBLQp0iYsSaMz6QZrjBFrPQObX tybQZx7z/t5gLBoSMjxTNoyAJN67CcumBA/iEiIDMUs+8rgeo9JcsUs7MKfVXZgJTIbz /5fe8hsG4XI02bz6NY0kj9VjCbe2inLwGiV3JdPXjTE0B+cbnn4u+QGktR3XE7306pcW DVpoPe3difwTS3o96zZy+Hicu0E9rRxQEYPKzX67Ito0UJ19UNEOR9XUXz+BrBML1FGG ZnWA== X-Gm-Message-State: AAQBX9dkoE68spU/2XzubpyiVkYmX90H/CawwN5rICa2FwtQjdpwL4aP uQ0twjMUnY+NvF2eDJi+RYc9H+4zeSbOsQ== X-Google-Smtp-Source: AKy350Z+eGdsDHytrStVjlEP6NI/g26MKcJtEiZg3BQ2pkBC19vUWrXi2ZyL5He6BWREvl4IwSHnCQ== X-Received: by 2002:a17:906:85c2:b0:88d:ba89:1837 with SMTP id i2-20020a17090685c200b0088dba891837mr15072836ejy.8.1680445971564; Sun, 02 Apr 2023 07:32:51 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id p18-20020a170906839200b009476dafa705sm3273292ejx.193.2023.04.02.07.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 07:32:51 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/5] staging: rtl8192e: remove extra blank lines in rtllib_crypt_ccmp.c Date: Sun, 2 Apr 2023 19:32:42 +0500 Message-Id: <283265f6a5ff938f8425e14af86cee9e2da36318.1680445545.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove extra blank lines as suggested by the Linux kernel coding-style. These issues were reported by checkpatch. "CHECK: Please don't use multiple blank lines" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging= /rtl8192e/rtllib_crypt_ccmp.c index a8d22da8bc9a..eb7b6deb2ca7 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c @@ -74,7 +74,6 @@ static void *rtllib_ccmp_init(int key_idx) return NULL; } =20 - static void rtllib_ccmp_deinit(void *priv) { struct rtllib_ccmp_data *_priv =3D priv; @@ -84,7 +83,6 @@ static void rtllib_ccmp_deinit(void *priv) kfree(priv); } =20 - static int ccmp_init_iv_and_aad(struct rtllib_hdr_4addr *hdr, u8 *pn, u8 *iv, u8 *aad) { @@ -150,8 +148,6 @@ static int ccmp_init_iv_and_aad(struct rtllib_hdr_4addr= *hdr, return aad_len; } =20 - - static int rtllib_ccmp_encrypt(struct sk_buff *skb, int hdr_len, void *pri= v) { struct rtllib_ccmp_data *key =3D priv; @@ -220,7 +216,6 @@ static int rtllib_ccmp_encrypt(struct sk_buff *skb, int= hdr_len, void *priv) return 0; } =20 - static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *pri= v) { struct rtllib_ccmp_data *key =3D priv; @@ -315,7 +310,6 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int= hdr_len, void *priv) return keyidx; } =20 - static int rtllib_ccmp_set_key(void *key, int len, u8 *seq, void *priv) { struct rtllib_ccmp_data *data =3D priv; @@ -349,7 +343,6 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *= seq, void *priv) return 0; } =20 - static int rtllib_ccmp_get_key(void *key, int len, u8 *seq, void *priv) { struct rtllib_ccmp_data *data =3D priv; @@ -373,7 +366,6 @@ static int rtllib_ccmp_get_key(void *key, int len, u8 *= seq, void *priv) return CCMP_TK_LEN; } =20 - static void rtllib_ccmp_print_stats(struct seq_file *m, void *priv) { struct rtllib_ccmp_data *ccmp =3D priv; @@ -403,13 +395,11 @@ static struct lib80211_crypto_ops rtllib_crypt_ccmp = =3D { .owner =3D THIS_MODULE, }; =20 - static int __init rtllib_crypto_ccmp_init(void) { return lib80211_register_crypto_ops(&rtllib_crypt_ccmp); } =20 - static void __exit rtllib_crypto_ccmp_exit(void) { lib80211_unregister_crypto_ops(&rtllib_crypt_ccmp); --=20 2.34.1 From nobody Wed Feb 11 09:41:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41429C7619A for ; Sun, 2 Apr 2023 14:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231129AbjDBOc6 (ORCPT ); Sun, 2 Apr 2023 10:32:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbjDBOcy (ORCPT ); Sun, 2 Apr 2023 10:32:54 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAE8AA5D6 for ; Sun, 2 Apr 2023 07:32:53 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id y4so107760608edo.2 for ; Sun, 02 Apr 2023 07:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680445973; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K0EbqnaKdSiijP5AMHVuBOUgkUfHYyGlvbGYlKLav6c=; b=fxPZuh0uJQhe82KpCnaxLqcWweaM7VRVfxJNvpKtiVclnj/SXwE+HdnKx4fLcPEE9x SoJGqi3nbaWpfxGHIbaUZZc1u3FZARth9Dfz8AixcFoOReKECB0GpFOYMwFn3ssw/k5y q142iY3YVJKC4wI72scS6Nba/pcAvv0K3fbrrDr7Uyjxe9xl6GwcmoGV34YI4KbcMbP+ E70eRTnbICOq7e1rwQRRx5Jb+zaNUWuQIocp7NZ7gk6GC6g2RnqwQSeeEd7jwj9dHhwm B3Xt5URhADdQSIdB8nbEwELfcNQBDbdHhi9AV5jZX3OwP/C/yu9/4eyuF5/QeLA6Zrc7 L8fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680445973; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K0EbqnaKdSiijP5AMHVuBOUgkUfHYyGlvbGYlKLav6c=; b=SmIWiXoy/UKzBaf3efdunEOVyXrLb/ergGdk01At9ghxp4uKSqitbFAFXkLvB8cXgr axuDEEDdaQysfPHW/RfyHOuZQeuk43WgWkMFdbRcXhOKntuOkmFZsW0jBy5h7LDjW94X W21Gv/sbvj24ANhd9dvn1LKNs/snrdNUpzL62GfUnjSOQyc7ErTrxS6nWaDCgMf/UULm /oNB6h7M5xN05bwwVPJILGi2v9DdUsJC+EruXVsTRCxGv5z8jHGW4kRO1cKGXzTmL5rE gyDo4YSLCUKYQurGrz7F2ZlXbhUlgR8QpUqs+KFFooQiO1unC9Je8QXggEyJe2TISyG5 PZ7g== X-Gm-Message-State: AAQBX9eLvhia9Wh2BCxuskqGhI3iYWNt90Q2AX/zN7EBKhgoNeJeTxFY fQ+JHTxJZY6XE/h8qb6GO5n+2W0GqUwNBA== X-Google-Smtp-Source: AKy350ZXjjFMXrLcYZ/YZ3o327TMJILni8gdgD6bYM8TDo4r4Za9IJQi5IHub9U9f8+b/7aFDgb3zg== X-Received: by 2002:a17:907:7d89:b0:947:c8d5:bfab with SMTP id oz9-20020a1709077d8900b00947c8d5bfabmr7852387ejc.35.1680445973100; Sun, 02 Apr 2023 07:32:53 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id p18-20020a170906839200b009476dafa705sm3273292ejx.193.2023.04.02.07.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 07:32:52 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] staging: rtl8192e: fix alignment to match open parenthesis Date: Sun, 2 Apr 2023 19:32:43 +0500 Message-Id: <76814f7a2a026ef195334b0c42ecd2aeb8e8ea40.1680445545.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix alignemnt to match opening parenthesis as suggested by Linux kernel coding-style. This issue is reported by checkpatch. Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging= /rtl8192e/rtllib_crypt_ccmp.c index eb7b6deb2ca7..8d3067a6ccca 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c @@ -332,7 +332,7 @@ static int rtllib_ccmp_set_key(void *key, int len, u8 *= seq, void *priv) data->rx_pn[5] =3D seq[0]; } if (crypto_aead_setauthsize(data->tfm, CCMP_MIC_LEN) || - crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN)) + crypto_aead_setkey(data->tfm, data->key, CCMP_TK_LEN)) return -1; } else if (len =3D=3D 0) { data->key_set =3D 0; --=20 2.34.1 From nobody Wed Feb 11 09:41:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6549DC76196 for ; Sun, 2 Apr 2023 14:33:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231161AbjDBOdM (ORCPT ); Sun, 2 Apr 2023 10:33:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbjDBOc6 (ORCPT ); Sun, 2 Apr 2023 10:32:58 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A48ABDA for ; Sun, 2 Apr 2023 07:32:56 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id t10so107524552edd.12 for ; Sun, 02 Apr 2023 07:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680445975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0lNLxgv/KOG23ypMmeKBWcQbi18NmEa6zz29IZ1WhUc=; b=HuxIK+VBPzhv5W0m/zcMz59LHQ01rcrj7Js6RPwQ7AgzmwoEGQvh5RGFwGXBtUHF+F ATfW6T3zc8iAkII5oNuSkdiZzvTWygNJ5obLK3ADRIOHnP8Tpj4Xxh36KXJDxJSJe2TG o4B3abL5TbBt31HgUdHk3gx5/lrmvSW6dE9oO5oOYFSoVDBSRiTumXdE3cWrTo7RwslI u38yNgnqa6c702QzrCjr24uWZbkdq1mWYMIWupnX3juPHK9sfStHgwY6Eio0CcgfNSd0 s9/M01VUt+1ojPOPWqxT74y6cLBwdm6qgVIVLMJjvs9tgde0Qyo7bd6V746PGigj+YcM oW5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680445975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0lNLxgv/KOG23ypMmeKBWcQbi18NmEa6zz29IZ1WhUc=; b=msF0Q6b0XmI64SdGS9uC81vWfMcK7yR9EP8awiZTCONkGDfxCxkugx96Tg25XzbIGQ FKRezbg4mX4p3zYLqg0arxTAzIM9FVA6KASCrG6FqtrFfLRF1YvgRLQpnLIDE0vtvFL0 /rh3ZybYnVk8rOa0VQOIqoqeWlVekwn2k7as5cCqeuBsl7s7EzC8HrGL3/RdfEnUJa1F wQe4qp88V7cqhb8/osLCvvXQWPGRmUSpmEyjUBhP4O2UYPMjKUFNDbSw/QmvDzDsIiyA uLnQ5y/8TY8CiNBBESAjg9qXmgTgeAzgfDkElKeefV5RYiGZQfhBK6b44Tv20Ka25U6k 03ig== X-Gm-Message-State: AAQBX9ePGgQMTn+Iz5TZN+Ezy7S0UlAu95AwR04LfMYk/haohzmgYqEv h3gl/hAJmX7FRLYxvlFoP5Q= X-Google-Smtp-Source: AKy350YuQIS5zi91f2yrQQSNGpzQ3ahqrQshBnd7iEXQsnACnBOhpn9QRJJq9azomFDXhJpmeuNHpg== X-Received: by 2002:a17:906:fc0b:b0:87b:e105:5d9a with SMTP id ov11-20020a170906fc0b00b0087be1055d9amr34224412ejb.67.1680445974644; Sun, 02 Apr 2023 07:32:54 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id p18-20020a170906839200b009476dafa705sm3273292ejx.193.2023.04.02.07.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 07:32:54 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] staging: rtl8192e: avoid CamelCase Date: Sun, 2 Apr 2023 19:32:44 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Linux kernel coding-style suggests to not use mixed-case names. Fix checkpatch issue by changing the variable name from camel case to snake case. Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging= /rtl8192e/rtllib_crypt_ccmp.c index 8d3067a6ccca..d37ca72678c8 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c @@ -34,7 +34,7 @@ struct rtllib_ccmp_data { u8 tx_pn[CCMP_PN_LEN]; u8 rx_pn[CCMP_PN_LEN]; =20 - u32 dot11RSNAStatsCCMPFormatErrors; + u32 dot11rsna_stats_ccmp_format_errors; u32 dot11RSNAStatsCCMPReplays; u32 dot11RSNAStatsCCMPDecryptErrors; =20 @@ -226,7 +226,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int= hdr_len, void *priv) u8 pn[6]; =20 if (skb->len < hdr_len + CCMP_HDR_LEN + CCMP_MIC_LEN) { - key->dot11RSNAStatsCCMPFormatErrors++; + key->dot11rsna_stats_ccmp_format_errors++; return -1; } =20 @@ -238,7 +238,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int= hdr_len, void *priv) pr_debug("CCMP: received packet without ExtIV flag from %pM\n", hdr->addr2); } - key->dot11RSNAStatsCCMPFormatErrors++; + key->dot11rsna_stats_ccmp_format_errors++; return -2; } keyidx >>=3D 6; @@ -374,7 +374,7 @@ static void rtllib_ccmp_print_stats(struct seq_file *m,= void *priv) "key[%d] alg=3DCCMP key_set=3D%d tx_pn=3D%pM rx_pn=3D%pM format_error= s=3D%d replays=3D%d decrypt_errors=3D%d\n", ccmp->key_idx, ccmp->key_set, ccmp->tx_pn, ccmp->rx_pn, - ccmp->dot11RSNAStatsCCMPFormatErrors, + ccmp->dot11rsna_stats_ccmp_format_errors, ccmp->dot11RSNAStatsCCMPReplays, ccmp->dot11RSNAStatsCCMPDecryptErrors); } --=20 2.34.1 From nobody Wed Feb 11 09:41:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F3DC76196 for ; Sun, 2 Apr 2023 14:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbjDBOdH (ORCPT ); Sun, 2 Apr 2023 10:33:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230522AbjDBOc6 (ORCPT ); Sun, 2 Apr 2023 10:32:58 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCF521994 for ; Sun, 2 Apr 2023 07:32:56 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id cn12so107736533edb.4 for ; Sun, 02 Apr 2023 07:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680445976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0VpvWUtWbJT8YstgxikOx5Ko60XPMRGflN6BioEOG+4=; b=ngsGSh04fpEbkCAXlhuCz29S2OlIPQSejpYIDqmJbKHn1FEmdF03cvkclWt3dPBHi1 98aY2pMKuj8DoAHJ0HWplNPLn+IUNOAi01Dq984xBxz0RARgpHzDRb/mRTQ0zvAfmzWg 8gmGdnhYCl93yp6mr3qfohLkU1EcT0MzPjDToh6HXCRyclUXNK22oUEPDTbx7JxDCms3 5BlTmmTTJu7pGeT4hyKSoNL2JMNWjDEtlyQWQ6dQSIeY7IcHZ72F1oJgh4C4nG8PtJCf OlvtfhSUxWTKDP7yhDq0HRMn4LoMZt+qTAIfLXd4KNqdaN2oG/Az9xMt3bz7MC0FK3nM 8CmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680445976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0VpvWUtWbJT8YstgxikOx5Ko60XPMRGflN6BioEOG+4=; b=yRPJP6GCk8gnibj4i53b80YbM4C1HBEqSuoByXcbbJN4TY1PFQaWvEeFy2nZ/v6XrD p6/14keoi2ReGEtiu5QV/Ht6b0CQsJkgF34UeVPw6BOBob5/gP112BO22kXocynOzsxD vqI6i0UMF2BHpWnB91Fsg4nmn9t2mEOi4uhBHoX0gWjAJ18Ms/eiepRhfh0hCgCuDfTG IgWBaYktuone0opzbRBNip1BZPxc19Tm9EbTSKfyFPT2XFnDvwg0DguKfmqm5mbp09QS EcgSVL1mFO4okXDhz+7JX+6OfiNAZvpQr8W3ufKSBtOgRhYw53Cbcvnw/xa7Q6nnVrMn +52Q== X-Gm-Message-State: AAQBX9dY8qdDUme1Ngv4mPm84cH4Bq2m505blqPFsBZ/47uZCO6ieon5 EvY6H4TvQTc3W+fA+U+YV43GMBQPYzzOWQ== X-Google-Smtp-Source: AKy350YoVEg93SRXWO5VhAFf+Xwl7hwi9aKziysxUjr10GN679/Ilr/6a4pr5bnpC0W+Lvq2lxSOqw== X-Received: by 2002:a17:906:f190:b0:931:a321:7640 with SMTP id gs16-20020a170906f19000b00931a3217640mr35829287ejb.74.1680445976368; Sun, 02 Apr 2023 07:32:56 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id p18-20020a170906839200b009476dafa705sm3273292ejx.193.2023.04.02.07.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 07:32:56 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/5] staging: rtl8192e: avoid CamelCase Date: Sun, 2 Apr 2023 19:32:45 +0500 Message-Id: <7166160c0face9e32dbb28c44727eb8856173f0a.1680445545.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Linux kernel coding-style suggests to not use mixed-case names. Fix checkpatch issue by changing the variable name from camel case to snake case. Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging= /rtl8192e/rtllib_crypt_ccmp.c index d37ca72678c8..448c0a931c78 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c @@ -35,7 +35,7 @@ struct rtllib_ccmp_data { u8 rx_pn[CCMP_PN_LEN]; =20 u32 dot11rsna_stats_ccmp_format_errors; - u32 dot11RSNAStatsCCMPReplays; + u32 dot11rsna_stats_ccmp_replays; u32 dot11RSNAStatsCCMPDecryptErrors; =20 int key_idx; @@ -263,7 +263,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int= hdr_len, void *priv) pn[5] =3D pos[0]; pos +=3D 8; if (memcmp(pn, key->rx_pn, CCMP_PN_LEN) <=3D 0) { - key->dot11RSNAStatsCCMPReplays++; + key->dot11rsna_stats_ccmp_replays++; return -4; } if (!tcb_desc->bHwSec) { @@ -375,7 +375,7 @@ static void rtllib_ccmp_print_stats(struct seq_file *m,= void *priv) ccmp->key_idx, ccmp->key_set, ccmp->tx_pn, ccmp->rx_pn, ccmp->dot11rsna_stats_ccmp_format_errors, - ccmp->dot11RSNAStatsCCMPReplays, + ccmp->dot11rsna_stats_ccmp_replays, ccmp->dot11RSNAStatsCCMPDecryptErrors); } =20 --=20 2.34.1 From nobody Wed Feb 11 09:41:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E875C76196 for ; Sun, 2 Apr 2023 14:33:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231169AbjDBOdP (ORCPT ); Sun, 2 Apr 2023 10:33:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231159AbjDBOdF (ORCPT ); Sun, 2 Apr 2023 10:33:05 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A3D82682 for ; Sun, 2 Apr 2023 07:32:59 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id h8so107712098ede.8 for ; Sun, 02 Apr 2023 07:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680445978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=81yzIuoBJY31RIgCNtPXI4MH4MI0Ymz/ovjpa7G5Au8=; b=mz8q8tlTRahr4dUJqiWpfSFk/N5vv6BLwE3qVuiCsEYdc/9lsa0OL2zlXz9KCo/NQQ DiPa3GFA4WkUWpNMJdWWumgcd8swVdzafrOhHnOBNi8qZ3XGv5Na+jxcwGDSDrMvbtC9 OzlmQwlz36Gp/gSfyaOFoHgWIX4CfNHJT9T8h6xAjwCTojXywY0/hEfXP1WzmKo1YbCX aIbC1Knr8I+lpuC4YrKpYu+T4YsLIIS9nq8PoYwKi+QnnB9oWlPFmAqqvH8obAWYf2vu lWo8uab5iTo+IFTmSXBygZh4UTRSIF7jNMv2ba7Zh4pcwi1vvc8Uw4vWpCUrZVrF9H54 sjMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680445978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=81yzIuoBJY31RIgCNtPXI4MH4MI0Ymz/ovjpa7G5Au8=; b=pxaPYHF2ZpxU18vVXC3xzXAGjRCSO4TqbDoROBZ/MClyf5wty1VfKHW6K/S4QfPEQP St8NqZPVXdGn4/ADQ1kiqIEDp6Hi/nKuTfSZvTLmFxVNJUWCjjuKdkDmB8VgHm4UK6f0 +miMLty8RTj38Fkw0zFdI+E9pzhrT/1YIkeOMXpzUJNR+h3nMuiuCBfFEj7dwgr2mY0F WYZu3GkCNIbgamddZOZtRExE88orcEmENMC5eCKPO5Lm1N6QzM3/pa7DRhyKh+ezwJ1y xHDgAKvMdaL75pOA7QprkEmUO+XlP7WV2myLYd3TLSVKZ/DN+hwHqmCsAKrr1VpKKeVi 4A6w== X-Gm-Message-State: AAQBX9fv15LOTBbRntZfYzdNxYAO5CjfR/gw53vlYXI5UFovCLcFRe4G PINjdVwRlkqClp14RPbJOYU= X-Google-Smtp-Source: AKy350ZcqOubIDVdPJe9vMrgbtScXlEby33eShAZQfT065MfI3J9DCmnbKS86v+TQomKpq6WDtswyA== X-Received: by 2002:a17:906:5d03:b0:92f:495b:bc7c with SMTP id g3-20020a1709065d0300b0092f495bbc7cmr17158572ejt.23.1680445978075; Sun, 02 Apr 2023 07:32:58 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id p18-20020a170906839200b009476dafa705sm3273292ejx.193.2023.04.02.07.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 07:32:57 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/5] staging: rtl8192e: avoid CamelCase Date: Sun, 2 Apr 2023 19:32:46 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Linux kernel coding-style suggests to not use mixed-case names. Fix checkpatch issue by changing the variable name from camel case to snake case. Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging= /rtl8192e/rtllib_crypt_ccmp.c index 448c0a931c78..f88096bcb181 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c @@ -36,7 +36,7 @@ struct rtllib_ccmp_data { =20 u32 dot11rsna_stats_ccmp_format_errors; u32 dot11rsna_stats_ccmp_replays; - u32 dot11RSNAStatsCCMPDecryptErrors; + u32 dot11rsna_stats_ccmp_decrypt_errors; =20 int key_idx; =20 @@ -296,7 +296,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int= hdr_len, void *priv) pr_debug("CCMP: decrypt failed: STA=3D %pM\n", hdr->addr2); } - key->dot11RSNAStatsCCMPDecryptErrors++; + key->dot11rsna_stats_ccmp_decrypt_errors++; return -5; } =20 @@ -376,7 +376,7 @@ static void rtllib_ccmp_print_stats(struct seq_file *m,= void *priv) ccmp->tx_pn, ccmp->rx_pn, ccmp->dot11rsna_stats_ccmp_format_errors, ccmp->dot11rsna_stats_ccmp_replays, - ccmp->dot11RSNAStatsCCMPDecryptErrors); + ccmp->dot11rsna_stats_ccmp_decrypt_errors); } =20 static struct lib80211_crypto_ops rtllib_crypt_ccmp =3D { --=20 2.34.1