From nobody Wed Feb 11 03:42:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42F5C761A6 for ; Fri, 31 Mar 2023 21:28:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231851AbjCaV2L (ORCPT ); Fri, 31 Mar 2023 17:28:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231837AbjCaV2I (ORCPT ); Fri, 31 Mar 2023 17:28:08 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A34A122EA3 for ; Fri, 31 Mar 2023 14:28:07 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id cn12so94887848edb.4 for ; Fri, 31 Mar 2023 14:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680298086; x=1682890086; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e9uZA67W0J8w9CI902YQgQUJeWdtlUq1O49C7+5+Pz8=; b=U1nS8FwPD58ih3N7LbDn1tTS+raRgE8DI4T3z1JbCUvgfuCM4RlncHg2TlsQtQHCMI gr0qGfXdxErOiVLueD7Z1YE6Bx45IodE6fual4LiKeQp4DpkQgEr841oLAmpV9tuYC2Y LKfDo5F5mx/+CTj9S4WdpE1EkuF60X9ivDz2XbTvsEY6IrRXLa9ExRvlfaTPbLe8PopN KYsaQ5EGe8N3eJO2pR7VaS6XzOxAS6YNqKCYmtRg9dOP5NW3i28mTJB4gJiqIRD8SH4L fNpqrnUEVU+4f9Pm5yeqLJZaLCnhMh8YofkYZaeD1tQfLRWMM7goBLLTtPrAiT5oGiMP nSzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680298086; x=1682890086; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e9uZA67W0J8w9CI902YQgQUJeWdtlUq1O49C7+5+Pz8=; b=Qsqk+IyfxZOaBMiVYXElLdAynkRRIrOYVQ8OhgnpgVWnarV0bSb/qTFkal8VDLPWtz DJNZpokWtYdNBIsu7Ghv3KEmCrxve1Zv08d+DOiFfNL3+g/KPQ7BptgB5ED1653Lw61P SFo8pIYSWiQ8qdpUOGco0jDONp7Vol+vJ0r25FUV3dpg3pwf0GGhDvPE75ohbXlb1d0t 26oAF3XPL9szgasL4UsOCz10emOG0JaoA2EP855girYXoWbh9XINqJpYk3HfHSBqMKxS nQLbcOMT3v0ZZUCYiCYKpDg3uFOCoIn1RGzxExEKBvMkqi1nasnqhthst7tkDtcGBk47 LREQ== X-Gm-Message-State: AAQBX9egBksft0S93E1tiZM1bvazQCRLSZLtp2IPElSk+HNqMdGL+zsb NdN+WHLuBUWIW+OgpfSpbNk= X-Google-Smtp-Source: AKy350a+9GIqV36l6mzsxYJ2WdxKzCqvhSjUnkPcecT7weya6li6mBC9FORXKpZOY/0nu4jkxr9OrQ== X-Received: by 2002:a17:906:15c:b0:8f5:14ab:94bc with SMTP id 28-20020a170906015c00b008f514ab94bcmr24544306ejh.6.1680298086210; Fri, 31 Mar 2023 14:28:06 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id tq24-20020a170907c51800b00947abb70c93sm1092989ejc.112.2023.03.31.14.28.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 14:28:05 -0700 (PDT) Date: Fri, 31 Mar 2023 23:28:03 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] staging: rtl8192e: Remove enum RF_1T2R Message-ID: <97fef03c12dbc619aab749867fa20686af2b8e3b.1680297150.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" enum RF_1T2R is used to initialize a local variable that is then shifted. The result of the shift is zero. Remove code that has always the same result to increase readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 3 +-- drivers/staging/rtl8192e/rtllib.h | 4 ---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index b5f4d0230da7..2100d9d4e940 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -531,8 +531,7 @@ static void _rtl92e_dm_tx_power_tracking_callback_tssi(= struct net_device *dev) priv->rtllib->bdynamic_txpower_enable =3D false; =20 powerlevelOFDM24G =3D priv->pwr_track >> 24; - RF_Type =3D RF_1T2R; - Value =3D (RF_Type<<8) | powerlevelOFDM24G; + Value =3D powerlevelOFDM24G; =20 for (j =3D 0; j <=3D 30; j++) { =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 197c0a44ebd6..7d83a4c322cf 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -433,10 +433,6 @@ enum led_ctl_mode { LED_CTL_START_TO_LINK =3D 8, }; =20 -enum rt_rf_type_def { - RF_1T2R =3D 0, -}; - enum wireless_mode { WIRELESS_MODE_UNKNOWN =3D 0x00, WIRELESS_MODE_A =3D 0x01, --=20 2.40.0 From nobody Wed Feb 11 03:42:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDBCC76196 for ; Fri, 31 Mar 2023 21:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232622AbjCaV2Y (ORCPT ); Fri, 31 Mar 2023 17:28:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232508AbjCaV2T (ORCPT ); Fri, 31 Mar 2023 17:28:19 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D14A424430 for ; Fri, 31 Mar 2023 14:28:13 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id eg48so94745444edb.13 for ; Fri, 31 Mar 2023 14:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680298092; x=1682890092; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M6eeMO2fOkTmQFtQvQlgUDTMHxNMIRBK0p3MGXvUrqc=; b=NRmG9bnKsan4+8PU/mmgHL/s1dDmkW2yglzBB9UpGMXu8E7Eud+uG7q76n03riVT5n ZBaVBw8+G+Uf1v/nzPiL+bweIUWFh3+TM4+y08A5xclaySnckVIJbI+8ENxfoNC6c+C0 VVf2iiG7Dat/Nt8hQr9/6+yTIxP3nJuwZCZerGycFBhJkAt2Nn6Z27XX+GeVB9pPQOFr R50JXql/vqgtalxz5EOlf0UI1WH5fEoJkVRQqmYWzT72KwX0M2xy8cC9Ox67XFAUywwg WlXD5C6GMfxBIiJdoN3TTx19KlTeuCR2gfNk6Ywp8JvI52KwVLODZU8i6aHzckstm6xu cPpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680298092; x=1682890092; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M6eeMO2fOkTmQFtQvQlgUDTMHxNMIRBK0p3MGXvUrqc=; b=YPJyev1peYkFAv25cVY47WADibBXfA7MjRNjqM76I9MwnlTh1W8fYfQ8MqC2H3l+/w iB1mG2r8efRLdF3hhC1qUixji4a00pQYw9G+hPUdDv9zXM8kWJyFAoZD186c7as9/TIc 2oyotnUK1ghF4jwGRcmZObupQMt3zn39M9AmSoe+dngO5c6OcrjU+m6pUihFAZ0D34OT l7C0fpX6i0inG/Kzfct8euk6elrIlBkYm7KCJRAYh7v+vFVMrUri6oxVpLEh/dQjzEsq SUt3hn0ojksmphu3Jhcs+rmhxYpCgwnvw7R/LrhbDKub/WHEU3gKzAR7GDNkIEjvO8TA /xGA== X-Gm-Message-State: AAQBX9dlXVEHUhGIo4rirWPRyJ7hOyhiqZf0AZ8UiTb6p7TJDkm6vr/L EeBF2PT8F4PzO9Y+/KlfywQ= X-Google-Smtp-Source: AKy350aEiQiP4G5X3dx7V6sMsDzvREAngt9bWeT7p6yDFAXhqy2v9do3VMobs5Ni/SpTBfIfdWq7YQ== X-Received: by 2002:a17:906:519d:b0:939:5398:768e with SMTP id y29-20020a170906519d00b009395398768emr25210213ejk.7.1680298092270; Fri, 31 Mar 2023 14:28:12 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id t23-20020a1709060c5700b0093e23d03d72sm1381763ejf.177.2023.03.31.14.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 14:28:11 -0700 (PDT) Date: Fri, 31 Mar 2023 23:28:09 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] staging: rtl8192e: Remove local variable Value and powerlevelOFDM24G Message-ID: <9b17cf3828915f541aa26b02973f4e9f9ddd1776.1680297150.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" powerlevelOFDM24G is set to priv->pwr_track. Then Value is set to powerlevelOFDM24G and then only once used. Remove both variables to increase readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 2100d9d4e940..a6ae76005d56 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -518,10 +518,8 @@ static void _rtl92e_dm_tx_power_tracking_callback_tssi= (struct net_device *dev) struct r8192_priv *priv =3D rtllib_priv(dev); bool viviflag =3D false; struct dcmd_txcmd tx_cmd; - u8 powerlevelOFDM24G; int i =3D 0, j =3D 0, k =3D 0; u8 RF_Type, tmp_report[5] =3D {0, 0, 0, 0, 0}; - u32 Value; u8 Pwr_Flag; u16 Avg_TSSI_Meas, tssi_13dBm, Avg_TSSI_Meas_from_driver =3D 0; u32 delta =3D 0; @@ -530,14 +528,11 @@ static void _rtl92e_dm_tx_power_tracking_callback_tss= i(struct net_device *dev) rtl92e_writeb(dev, FW_Busy_Flag, 0); priv->rtllib->bdynamic_txpower_enable =3D false; =20 - powerlevelOFDM24G =3D priv->pwr_track >> 24; - Value =3D powerlevelOFDM24G; - for (j =3D 0; j <=3D 30; j++) { =20 tx_cmd.op =3D TXCMD_SET_TX_PWR_TRACKING; tx_cmd.length =3D 4; - tx_cmd.value =3D Value; + tx_cmd.value =3D priv->pwr_track >> 24; rtl92e_send_cmd_pkt(dev, DESC_PACKET_TYPE_NORMAL, (u8 *)&tx_cmd, sizeof(struct dcmd_txcmd)); mdelay(1); --=20 2.40.0 From nobody Wed Feb 11 03:42:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41FA3C76196 for ; Fri, 31 Mar 2023 21:28:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232574AbjCaV2e (ORCPT ); Fri, 31 Mar 2023 17:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231929AbjCaV2b (ORCPT ); Fri, 31 Mar 2023 17:28:31 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23DF923FFA for ; Fri, 31 Mar 2023 14:28:20 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-502507c7da4so244476a12.0 for ; Fri, 31 Mar 2023 14:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680298098; x=1682890098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J25hLV3FiWX9nakLLPh8ft08O4hV9weZdaVT2vmny5g=; b=M3UB/OqFTUVzhx17Xvw+Y45bmYCpDuSluFqye4oH8pAVZzKlEdjAHdUodVOgQxKG1Z fXIpFv3hUsL7BcFFyQlrXQ/uFaUaCGNwF9wp9Ndjnxr2WAECurfze/BRn2p4KUivDLaY FakYt5rWdUSI54y3drY5DJ5b+WK3Q2wWGE+rQ0B41O/hHr55BsNtTr01VqR3YzlIpeUo 9S9fVJ3AIQnh/+5Ek46Ex6VuXchhQCpktWQ/GclR2Z+vCRjQx6U1iUXKyjD9jkOTlTF7 wxF8cbKsK43jGztMOlta5w96inDZnTjSca13SDOStO6d33C5ZypkarU7ssaEj+GLj/66 ZaEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680298098; x=1682890098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J25hLV3FiWX9nakLLPh8ft08O4hV9weZdaVT2vmny5g=; b=bFFA3rwDPfXkeWSh9U1rEwlIn70NB/R+9X67XK5EbCqyH5CLabqcbqyiWEAYxuwCR1 KJix5LAX6EKLag87Zo+D0YXiKpbqyLh00jHBTFJ9JEXYuT4MDaBPtwEqY5xUoRhHRErP 9AqYMTEtyAiPE4HRxfF4w1P8a7zkYD0XfXZig7jNi5Z+++rySvTjqt5A2e6g0iwpkkH3 4MW1vjDARkDqmbG8TGIEN9YMdKkaKY/vpY++uir6vfwpr3B+G8kpMe7HCh1POngEzdXG WybcXuHB9ta/+gnDZFpNQPSEgAyFSUpPFZt+/V1oi9zIFGKhwP4HAUuh+hMViRTG+gSn WU7w== X-Gm-Message-State: AAQBX9dnOiC7jfSiCgezPI8o4FtCv4LSmC+RAx/Ubdg1I8vEtp0gZRXU pukUPCz5peJJ90FZZfBI6Z5J+atHaAA= X-Google-Smtp-Source: AKy350ZqWv1X0AQqpyjUZfzWoHYufJ7efeHzue1dd2mTvDgT+3o2eQB50GJ4LhKE06e659A/4h25wg== X-Received: by 2002:a05:6402:524e:b0:500:3fd0:25a8 with SMTP id t14-20020a056402524e00b005003fd025a8mr7158816edd.0.1680298098261; Fri, 31 Mar 2023 14:28:18 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id g8-20020a170906394800b008cafeec917dsm1378502eje.101.2023.03.31.14.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 14:28:17 -0700 (PDT) Date: Fri, 31 Mar 2023 23:28:15 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] staging: rtl8192e: Remove case customer_id = RT_CID_DLINK Message-ID: <4786e89c7a394f0e7f4d17c35cda147b11162268.1680297150.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" customer_id is initialize to zero. Changing customer_id to RT_CID_DLINK would not change the program execution as there is no equation for RT_CID_DLINK. Remove useless code lines to increase readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 ------ drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 - 3 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 1da14e737aa4..cbe66b4a6ad9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -431,9 +431,6 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) else priv->chnl_plan =3D priv->reg_chnl_plan; =20 - if (priv->eeprom_vid =3D=3D 0x1186 && priv->eeprom_did =3D=3D 0x3304) - priv->customer_id =3D RT_CID_DLINK; - switch (priv->eeprom_customer_id) { case EEPROM_CID_DEFAULT: priv->customer_id =3D RT_CID_DEFAULT; @@ -460,9 +457,6 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) case EEPROM_CID_Pronet: priv->customer_id =3D RT_CID_PRONET; break; - case EEPROM_CID_DLINK: - priv->customer_id =3D RT_CID_DLINK; - break; =20 case EEPROM_CID_WHQL: break; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/stagin= g/rtl8192e/rtl8192e/r8192E_hw.h index 99640c4779f7..706d024bcfd1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h @@ -37,7 +37,6 @@ enum baseband_config { #define EEPROM_CID_NetCore 0x5 #define EEPROM_CID_Nettronix 0x6 #define EEPROM_CID_Pronet 0x7 -#define EEPROM_CID_DLINK 0x8 #define EEPROM_CID_WHQL 0xFE enum _RTL8192PCI_HW { MAC0 =3D 0x000, diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 1e99eb833405..91d634f5d3e7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -134,7 +134,6 @@ enum rt_customer_id { RT_CID_TOSHIBA =3D 9, RT_CID_819X_NETCORE =3D 10, RT_CID_Nettronix =3D 11, - RT_CID_DLINK =3D 12, RT_CID_PRONET =3D 13, }; =20 --=20 2.40.0 From nobody Wed Feb 11 03:42:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD10C761A6 for ; Fri, 31 Mar 2023 21:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231929AbjCaV2o (ORCPT ); Fri, 31 Mar 2023 17:28:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232682AbjCaV2k (ORCPT ); Fri, 31 Mar 2023 17:28:40 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 925C223FD4 for ; Fri, 31 Mar 2023 14:28:25 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id h8so94868969ede.8 for ; Fri, 31 Mar 2023 14:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680298104; x=1682890104; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JRCbMUje3cpH1xwjxBasK79dtrxHrD4T1n+xlf4Bj5I=; b=AxlBnyKadKVXmu+QpVSZZZEYhaX7SSoipSLThw6HsUfjqAcYlzbcn7+qDJccZSIy+U pvTl2SSUF96wMQxL59VO408vvKscOORjJjYL7oSmbrEmnMOvr1axMJrU0PT09pakdYRV X4yUNIHJ1jDgZiUL8iWNkr2geIquyG9pAqjNMzoYonv6EYg3hId/djkk7AAjyR4l/bEV 2Alh3b7yiBeZbxheNSckQuBd+1ye+EDdxqPK2uJqusC2lUjS0825KZMxyCBQ+bB88elZ 0t7yxncOIDL6iBGuKlYQ/VSRJKauffS37WweRq5YBMnZAcR/08oTnK2J8OORyvO+ZohH 8E/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680298104; x=1682890104; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JRCbMUje3cpH1xwjxBasK79dtrxHrD4T1n+xlf4Bj5I=; b=KrSyz4pu2644ATZqc60QJHb7Fxn0PgyAMS/PSrbqmvYHps95tSwaAkVQUKl2aWYPVH tLZqs63aLyhqlnmNTMdUj2hH4ypNBGwlH22uc4IzaGWJ9avnRwfVFiEwxLiLmaFzL2k8 dRDa0MWLUzPfLBOT1lZPU5vAoeGDSfZoCplnqwFRE87p8HMLQnoipFll+hTU4n45y1Cr uW34HBTe9+i7zR9tWC6ie7ulBlvjKX3DX1j0LdEgKpNx/RSBiveuHRwWg+N6y1CkzE+d tbChj4nERC00wjg+G5sjQtfVI9FjU5Ohe4g5NDqg7tBCvgO9Sx8mNmWz0rncR4DlkWji gdkA== X-Gm-Message-State: AAQBX9cvk+jSKkPwWODuRpt/GvcPtNv0VYvupD1BBFZaGXGADKw7vkU3 C3As8WAh/RHIBhqEG5B6Pf0= X-Google-Smtp-Source: AKy350aowEQ04TzOniwFMcPRznhogZogpjU3hgXHKDccY6WyxcnTrUApAROULvLijFNT6nNrMWK1FQ== X-Received: by 2002:a17:906:101c:b0:929:b101:937d with SMTP id 28-20020a170906101c00b00929b101937dmr5559316ejm.1.1680298103964; Fri, 31 Mar 2023 14:28:23 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id v7-20020a170906564700b009447277c26fsm1372726ejr.72.2023.03.31.14.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 14:28:23 -0700 (PDT) Date: Fri, 31 Mar 2023 23:28:21 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] staging: rtl8192e: Remove case customer_id = RT_CID_819x_CAMEO, .. Message-ID: <72d9c0325ecabc007234ac5d4dba27556168d8a9.1680297150.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" customer_id is initialize to zero. Changing customer_id to RT_CID_819x_CAMEO, RT_CID_819x_RUNTOP, RT_CID_Nettronix or RT_CID_PRONET would not change the program execution as there is no equation for RT_CID_819x_CAMEO, RT_CID_819x_RUNTOP, RT_CID_Nettronix or RT_CID_PRONET. Remove useless code lines to increase readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 12 ------------ drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 4 ---- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 4 ---- 3 files changed, 20 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index cbe66b4a6ad9..df8de35cbe0e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -435,12 +435,6 @@ static void _rtl92e_read_eeprom_info(struct net_device= *dev) case EEPROM_CID_DEFAULT: priv->customer_id =3D RT_CID_DEFAULT; break; - case EEPROM_CID_CAMEO: - priv->customer_id =3D RT_CID_819x_CAMEO; - break; - case EEPROM_CID_RUNTOP: - priv->customer_id =3D RT_CID_819x_RUNTOP; - break; case EEPROM_CID_NetCore: priv->customer_id =3D RT_CID_819X_NETCORE; break; @@ -451,12 +445,6 @@ static void _rtl92e_read_eeprom_info(struct net_device= *dev) else priv->chnl_plan =3D 0x0; break; - case EEPROM_CID_Nettronix: - priv->customer_id =3D RT_CID_Nettronix; - break; - case EEPROM_CID_Pronet: - priv->customer_id =3D RT_CID_PRONET; - break; =20 case EEPROM_CID_WHQL: break; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/stagin= g/rtl8192e/rtl8192e/r8192E_hw.h index 706d024bcfd1..4ee78b7a558e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h @@ -31,12 +31,8 @@ enum baseband_config { #define EEPROM_TxPwIndex_OFDM_24G 0x3A =20 #define EEPROM_CID_DEFAULT 0x0 -#define EEPROM_CID_CAMEO 0x1 -#define EEPROM_CID_RUNTOP 0x2 #define EEPROM_CID_TOSHIBA 0x4 #define EEPROM_CID_NetCore 0x5 -#define EEPROM_CID_Nettronix 0x6 -#define EEPROM_CID_Pronet 0x7 #define EEPROM_CID_WHQL 0xFE enum _RTL8192PCI_HW { MAC0 =3D 0x000, diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 91d634f5d3e7..2b2d8af4cf6e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -129,12 +129,8 @@ enum dcmg_txcmd_op { =20 enum rt_customer_id { RT_CID_DEFAULT =3D 0, - RT_CID_819x_CAMEO =3D 6, - RT_CID_819x_RUNTOP =3D 7, RT_CID_TOSHIBA =3D 9, RT_CID_819X_NETCORE =3D 10, - RT_CID_Nettronix =3D 11, - RT_CID_PRONET =3D 13, }; =20 enum reset_type { --=20 2.40.0 From nobody Wed Feb 11 03:42:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 944FEC761A6 for ; Fri, 31 Mar 2023 21:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232729AbjCaV2u (ORCPT ); Fri, 31 Mar 2023 17:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232659AbjCaV2p (ORCPT ); Fri, 31 Mar 2023 17:28:45 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AE8221A8E for ; Fri, 31 Mar 2023 14:28:30 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id cn12so94890617edb.4 for ; Fri, 31 Mar 2023 14:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680298110; x=1682890110; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ou/EV0dTqA/jTIKJ3wQ2Lp2bM3Hd0avOtCVCqCD0Yds=; b=PCSwtAhLBW+9hO7OghdXuhAPmZIkwabNBzILwMsID39DXlNu6UTjh/TjpbPlE2sNHD Bk9SN33zk/kBnLF9dKPBXL/DTitZwwCgomOEYvdVPVEoPJidoPvAG6N+CfokSHg6qFXD ntM3kur2dYBVsoTvFdv4XeUo+hRmhd2SfK4x16cxxSg1R5tiBodBIgxfHFLGt4RaNaiQ QvsTGwjFVlyv1AhPH6cqKi7+VHc/hCZcLjKTUGw5FoNBKUFiEBGo7HaPuPHWXb8I0yQQ 9h/MmSh9u4wTGXjCWcvOQ3LF6pzShKjDrZuV/xmNJjoZEX5kfnK1JcigQ8Hnlkdtnqoy vmHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680298110; x=1682890110; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ou/EV0dTqA/jTIKJ3wQ2Lp2bM3Hd0avOtCVCqCD0Yds=; b=UIWAMmJ9CNlNz5PFB1sUKE+c0ArX0jSd+o4REjmazGw/cyZchb7edv3Cc6yrSjEhSg aIo7nlExa0uFxS8YVRXHr+Dsr578v8oO+izHVCxYig+zjOwUCRijMi8J6rSSCk0Hm97y k8BxoIDrEcwbp6qQRkI5TparGDcmN3+AOr+qKPDBuBO3nRkcvi6z8RBqV60+cFCK1Yzd JaVf84fMhsDO/9IWluuJiqBE528/JGO5rWItleghFEDOClip1naRcsXf30AeNa7HuYMY zL6jFn6r3an/upv6dx7NYCf862kvsjUZ3SaUXiAJ85naFq7jvPRnwmoO1BTI3PH1HCV8 dc7g== X-Gm-Message-State: AAQBX9dvFJmQHxWnE9x8CeTjMtbPGjqxDcx1IGLSzIRaT3abOamp4WQF GXYSYzc8CqOJL8TzW0gRpl8= X-Google-Smtp-Source: AKy350ay9EDB9BVpddsn8Gbt3dyTky5cd2zQgtWfTNLnHQvLCKI/uH1KqBJJLNtWFD6exCxLmbRAIg== X-Received: by 2002:a17:906:28e:b0:947:404b:eb2 with SMTP id 14-20020a170906028e00b00947404b0eb2mr6603384ejf.0.1680298109788; Fri, 31 Mar 2023 14:28:29 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id ce13-20020a170906b24d00b008e68d2c11d8sm1354003ejb.218.2023.03.31.14.28.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 14:28:29 -0700 (PDT) Date: Fri, 31 Mar 2023 23:28:27 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] staging: rtl8192e: Remove case customer_id = RT_CID_DEFAULT, .. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" customer_id is initialize to zero. Changing customer_id to RT_CID_DEFAULT will not change customer_id as it is already zero. default and EEPROM_CID_WHQL contain only a break. Remove useless code lines to increase readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 -------- drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 2 -- 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index df8de35cbe0e..aed53fedeb61 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -432,9 +432,6 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) priv->chnl_plan =3D priv->reg_chnl_plan; =20 switch (priv->eeprom_customer_id) { - case EEPROM_CID_DEFAULT: - priv->customer_id =3D RT_CID_DEFAULT; - break; case EEPROM_CID_NetCore: priv->customer_id =3D RT_CID_819X_NETCORE; break; @@ -445,11 +442,6 @@ static void _rtl92e_read_eeprom_info(struct net_device= *dev) else priv->chnl_plan =3D 0x0; break; - - case EEPROM_CID_WHQL: - break; - default: - break; } =20 if (priv->chnl_plan > CHANNEL_PLAN_LEN - 1) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/stagin= g/rtl8192e/rtl8192e/r8192E_hw.h index 4ee78b7a558e..f4d4b01630a2 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h @@ -30,10 +30,8 @@ enum baseband_config { #define EEPROM_TxPwIndex_CCK 0x2C #define EEPROM_TxPwIndex_OFDM_24G 0x3A =20 -#define EEPROM_CID_DEFAULT 0x0 #define EEPROM_CID_TOSHIBA 0x4 #define EEPROM_CID_NetCore 0x5 -#define EEPROM_CID_WHQL 0xFE enum _RTL8192PCI_HW { MAC0 =3D 0x000, MAC4 =3D 0x004, --=20 2.40.0