From nobody Mon Feb 9 07:19:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1991C76195 for ; Mon, 27 Mar 2023 21:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231881AbjC0VCx (ORCPT ); Mon, 27 Mar 2023 17:02:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231694AbjC0VCq (ORCPT ); Mon, 27 Mar 2023 17:02:46 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 132982D56 for ; Mon, 27 Mar 2023 14:02:41 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id ew6so41510408edb.7 for ; Mon, 27 Mar 2023 14:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679950959; x=1682542959; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1phiZ58+EMRbY3VbMSGewPlLSXTWA1xaHhQHOvOJHU8=; b=Tds7GZe6GMy19tM8wGQWXvcQU08egoXRGcLainzn2B1odQmaXTVRox4nABk41g0bNm VdVbwpMuCEgFBK85siNeFVTUBZgYHhytlLlqIlwXZ4h6TTuhvkgLIxOsHqu8rlGvPWs8 G/obEJpLtdyoIrELMbTNIaet6VPorsKgICoM6qi8UK2R9vc5VUy2Utluq4UcP9tC7UB5 wvB14uYwhdX+37dmyzxrozSxM8DWW87awJ3UauwliFvelv+uFcUzEdS30LX7v4JYQfPo MD4cBAUu0FlosQxpLomKXBBX++hIM9GSiVwz9IiINbnHVzoknqMZJJH5w0QBJm2LAnT9 HTpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679950959; x=1682542959; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1phiZ58+EMRbY3VbMSGewPlLSXTWA1xaHhQHOvOJHU8=; b=6Q0mmjHMoZFvDCf3OEnNKE+zSS8OGOei6gYgNcR/vhoiO+/RgKM6ktKSkyx42G+DS+ cjhtyx3/I5+nhU6rMeXncuA1+ZecohiUheBEdzgnrnhMim6cr4pM2wMURdbTPMLU90VO JF5omhlqv2h9vwTo/JoSnJ9mxR9E3P/4kB/3t6cYXCnQ4zpDxBTOIPK7g4ZbcVGrjxgm a40gfSMUvKlg5vM+zTvs/6EUkLyg0+v31jmKh68uKdtT76vzqldUfFNSK2qDhoqf7L1g txQnMF3jdgUw2C9UGk1B9b+NZB4DedtWw+FkYRseK4djcXIIb52cOCFgZBUoDg7wNVxt mIpA== X-Gm-Message-State: AAQBX9e+1DLKz4yKrWC2lK31pGgq/dsbrxXED8kLIyWTeXtXhU3XY8OX B8cbQ0kUvLgvT4+y3VtD1DU= X-Google-Smtp-Source: AKy350bnSsb0asvSic5sjbqzwB61xRFAnihr/5UPCw95zz2nv4BcziVhugLL43EPp1qMRLbf6OozBQ== X-Received: by 2002:a17:906:2219:b0:931:4285:ea16 with SMTP id s25-20020a170906221900b009314285ea16mr10643243ejs.7.1679950959216; Mon, 27 Mar 2023 14:02:39 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id m17-20020a17090607d100b0093a768b3dddsm9018768ejc.216.2023.03.27.14.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:02:31 -0700 (PDT) Date: Mon, 27 Mar 2023 23:02:19 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] staging: rtl8192e: Remove rtl92e_config_phy Message-ID: <5c433417b4e8e96a70c23a03bec30d26e45791d0.1679949171.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove rtl92e_config_phy to improve readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 --------- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h | 1 - 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 1eb063fe660a..f4fdaeff2917 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -691,7 +691,7 @@ bool rtl92e_start_adapter(struct net_device *dev) } =20 if (priv->rst_progress =3D=3D RESET_TYPE_NORESET) { - rtStatus =3D rtl92e_config_phy(dev); + rtStatus =3D rtl92e_config_rf(dev); if (!rtStatus) { netdev_info(dev, "RF Config failed\n"); return rtStatus; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index bd302f5cb356..139d8268c8dc 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -468,15 +468,6 @@ void rtl92e_set_tx_power(struct net_device *dev, u8 ch= annel) rtl92e_set_ofdm_tx_power(dev, powerlevelOFDM24G); } =20 -bool rtl92e_config_phy(struct net_device *dev) -{ - bool rtStatus =3D true; - - rtStatus =3D rtl92e_config_rf(dev); - - return rtStatus; -} - u8 rtl92e_config_rf_path(struct net_device *dev, enum rf90_radio_path eRFP= ath) { =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.h index 498da6be3e4e..6c4c33ded6a9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h @@ -39,7 +39,6 @@ bool rtl92e_check_bb_and_rf(struct net_device *dev, bool rtl92e_config_bb(struct net_device *dev); void rtl92e_get_tx_power(struct net_device *dev); void rtl92e_set_tx_power(struct net_device *dev, u8 channel); -bool rtl92e_config_phy(struct net_device *dev); u8 rtl92e_config_rf_path(struct net_device *dev, enum rf90_radio_path eRFP= ath); =20 u8 rtl92e_set_channel(struct net_device *dev, u8 channel); --=20 2.39.2 From nobody Mon Feb 9 07:19:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88736C76195 for ; Mon, 27 Mar 2023 21:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231133AbjC0VDM (ORCPT ); Mon, 27 Mar 2023 17:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbjC0VDJ (ORCPT ); Mon, 27 Mar 2023 17:03:09 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8069D170B for ; Mon, 27 Mar 2023 14:02:58 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id h8so41550123ede.8 for ; Mon, 27 Mar 2023 14:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679950977; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=see/tMyHGeTFgBe28oR3fGtGcVzBX17DM6QeEae9PEI=; b=BG69Ctf4CNtfGm8kdwx+9G6WIIW/befZ3ZVOM/QeD5hvSR3antuakGaqq2NTuVmJ8e d0Rmyp4K2k3jI6RZ2IHOmBfSPxEvKduNGj2DQw0jSBNdvdO1iOyrUpFA5XHs/U3UvU8D gwrsysopPs+742PPmU1wjOD5k2a3VL+DN85U0tVSPM22l5KhV0Kyd8CKfz0zv+2wPRLP K5iYQKDbxlijmyYdTEtVEEDIorFbmn1tpueO8Kl+yLxfC3mmpiNzz6HnZjkRfdwWJ7RT nEFBQreByWdb/lSYdhIxLkFC8MX2qIM9pCJuvJY4vkuMBMh0x28oqvW0M4Dq8a0Z6EYW dTjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679950977; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=see/tMyHGeTFgBe28oR3fGtGcVzBX17DM6QeEae9PEI=; b=F0u7AacJz4OiEOCI8nEYhmWjOE+K94CNcO/myIWq5zWkE4jZK0gI6IEim/BHyQIULj pg5lv0/8wNSgq5Co9xtMKgZOCb41SpglG75c9Zkm/UDvBg1CWbUb5nkX7Fsxbn1eKerU mb8qNiYwNEa5Gj0SSrpptP849O5brYY9aKA3rakbw/n4a75RzTX+wCfTlZr4teyzKsHu V9cCcN7XYVZZKNRHZmuwHIY2AM+eods+mG1aSNv+rut3YNNl/WKNb7qvEiGdWqoM6pkD RErNbUaChRmZOMSCPt6/BGNt5zh4K8qnpCvX7dCE+y+OYUzr+N2TuVf0Svlb4xsgXZ/4 vSHA== X-Gm-Message-State: AAQBX9chbB0aYmFSWuW99p1Ekrqs2v0nwiL10IKYTgV9vqYYIVJoHKBL Gmw+DithfD7h5c+nm72GeFc= X-Google-Smtp-Source: AKy350ZavlmG7gd+4zStA4EziPmcCI0rvw37VH+lsJkeS+LrOMdkfot21hPRD1uMPmvzYytDFGwz6Q== X-Received: by 2002:a05:6402:3490:b0:501:ea97:519c with SMTP id v16-20020a056402349000b00501ea97519cmr15032395edc.4.1679950976977; Mon, 27 Mar 2023 14:02:56 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id a18-20020a50c312000000b004c06f786602sm15085330edb.85.2023.03.27.14.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:02:49 -0700 (PDT) Date: Mon, 27 Mar 2023 23:02:37 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] staging: rtl8192e: Remove _rtl92e_get_supported_wireless_mode Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove _rtl92e_get_supported_wireless_mode to improve readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index ecc3f0c6c267..12e5132fa788 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -593,18 +593,10 @@ static void _rtl92e_refresh_support_rate(struct r8192= _priv *priv) } } =20 -static u8 _rtl92e_get_supported_wireless_mode(struct net_device *dev) -{ - u8 ret =3D 0; - - ret =3D (WIRELESS_MODE_N_24G | WIRELESS_MODE_G | WIRELESS_MODE_B); - return ret; -} - void rtl92e_set_wireless_mode(struct net_device *dev, u8 wireless_mode) { struct r8192_priv *priv =3D rtllib_priv(dev); - u8 support_mode =3D _rtl92e_get_supported_wireless_mode(dev); + u8 support_mode =3D (WIRELESS_MODE_N_24G | WIRELESS_MODE_G | WIRELESS_MOD= E_B); =20 if ((wireless_mode =3D=3D WIRELESS_MODE_AUTO) || ((wireless_mode & support_mode) =3D=3D 0)) { --=20 2.39.2 From nobody Mon Feb 9 07:19:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51954C76195 for ; Mon, 27 Mar 2023 21:03:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230473AbjC0VDa (ORCPT ); Mon, 27 Mar 2023 17:03:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231932AbjC0VDX (ORCPT ); Mon, 27 Mar 2023 17:03:23 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 002CE273B for ; Mon, 27 Mar 2023 14:03:07 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-93075ee221bso38690466b.0 for ; Mon, 27 Mar 2023 14:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679950986; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JdyEfmioMXlj8zaCBESKr5gB9JvQl1r0IW8/axbQUWk=; b=JSM7FINsXu+k0Q8FSg9PdASYMz0a426/lZY0A2yAmS56PUYmHT0ahCa6b269dEJ+3C zArw8BRovwRPPlRQtW45C87/+8uMPX1DKYVl7VXcU8DWwVyNPynHQPtirDmgKC3Fapl3 eE8MKIs2uFYMu0FV5ZHch9YHm3spthPvmF7Rm9jcl8p2V99KdNbmeBBtnNdsZKOrPq6r XpfDqRmrKFGKnLMpy5xcAfitXmyJGp6LyrnGBarqGguIiEvNdvS/fTclm+QTYmWbT434 lnwjYSpdYolTbH7r9UAu7pF66vQqEt/bu2qKzWZr5ZyT+jGaEq+Hzi97vYpwKrxzM68a pDRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679950986; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JdyEfmioMXlj8zaCBESKr5gB9JvQl1r0IW8/axbQUWk=; b=ZVbSOtIMYB5qssJbfenopt6jTkMDoG78hbFDIeq9H8sxSHzHCSsfMMFAmJmdwlqyDQ VjJHsTCUfGw7UXlmiu8fuV0XmeR3JwtzPc2uD7sPyH1JmZVNB6mkR8EBRD0iENSIRrao NvbKhUNdzsIjzwGUL7+II8RVwK6ppXHWQ/Cc/FK/AUFI33+tBIipEVr5Q6s/p9N7zJfE j2u2nVoChK13IkyohoL9buHQn5FioPH/LIj5WNqQy5FhPAbUVYREcd75q+pzGXfGgdJW gQ1EO1fhlR2e0vuuo1acun1Dn5wG4bv+3rmKPDRXf5VgRAe8+9eLrmTMKv/boic9Gvg9 /0Pw== X-Gm-Message-State: AAQBX9cAd+3gLIzMIjqaWVKQ1AJBgAcERhHO71wRzbrJZ+kunmyKwJF/ a4GlXNLjOshnlThSd2HqeQU= X-Google-Smtp-Source: AKy350ZRWyOrbJwCctralYpHk1twvtMNFXbyP8Xd9seLJHuiF/qb1wy+2gyKvMBOiZE75LGlxkJ5/Q== X-Received: by 2002:a17:906:51c9:b0:92f:27c2:13c0 with SMTP id v9-20020a17090651c900b0092f27c213c0mr11868755ejk.6.1679950986448; Mon, 27 Mar 2023 14:03:06 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id sd24-20020a170906ce3800b00931024e96c5sm14628338ejb.99.2023.03.27.14.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:02:59 -0700 (PDT) Date: Mon, 27 Mar 2023 23:02:45 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] staging: rtl8192e: Remove 5G wireless_mode in rtl92e_set_wireless_mode Message-ID: <693a34b187f21d9d48accd3b0b953dff2f0795eb.1679949171.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove wireless_mode =3D=3D WIRELESS_MODE_N_5G as 5G is not supported by hardware and to improve readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 12e5132fa788..c03978353a90 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -624,12 +624,11 @@ void rtl92e_set_wireless_mode(struct net_device *dev,= u8 wireless_mode) =20 priv->rtllib->mode =3D wireless_mode; =20 - if ((wireless_mode =3D=3D WIRELESS_MODE_N_24G) || - (wireless_mode =3D=3D WIRELESS_MODE_N_5G)) { + if (wireless_mode =3D=3D WIRELESS_MODE_N_24G) priv->rtllib->ht_info->enable_ht =3D 1; - } else { + else priv->rtllib->ht_info->enable_ht =3D 0; - } + _rtl92e_refresh_support_rate(priv); } =20 --=20 2.39.2 From nobody Mon Feb 9 07:19:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CABDEC76195 for ; Mon, 27 Mar 2023 21:03:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232190AbjC0VDf (ORCPT ); Mon, 27 Mar 2023 17:03:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231987AbjC0VD1 (ORCPT ); Mon, 27 Mar 2023 17:03:27 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 272B530E9 for ; Mon, 27 Mar 2023 14:03:15 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id w9so41627918edc.3 for ; Mon, 27 Mar 2023 14:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679950994; x=1682542994; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MT5t4boQulRjetg/3fnrhsk3Dnqce+x2uebcAL0xAiQ=; b=DjL8IAwBgRhT+yLu9O+NFfgVv9qXEMHhSzS0s08MvjmM1H0XRfsEtkhLVa4gbu2YEf D+XEvSC4B8htimvnk/N1uYCV5uLfnmPDTtKtjDjW+Vh2HWi+9i1LLaWefvWZ8E2Ng4SA lviD35xdItNHgDDRMsVqfSxXsDqUxuN9TCrKfCr8xleY0WPT7G15KY0+r66lWNVqS7sx NjxYQYch1yZKW26uSuDzURokkMyS1YDz1r+tNosW5LjwiWGwea9YQO6+iZi8cN8lNoN0 9ULmaOXW/+vEcud+uMzB/LkmF++PyoqNXPmMhliX6LS2DNID/3is4YdIaqLfwvQYjfnQ 7CWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679950994; x=1682542994; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MT5t4boQulRjetg/3fnrhsk3Dnqce+x2uebcAL0xAiQ=; b=e6M/YTXkWrgIvGeflt7UK9boMUTCx3cYecXl1aPAfMytOADwj8K5Mz0RNu8jOQUpCk uN0NiI1sEdAW5EnSOB0fIZWVGAKGTTtWjvJu1dug3Fik3WCW9OZsS4szaoPTTVAyoRc2 oUsrbzJZGBguS+hJWk1/wv9FZC9MqumqKu/1cwX1uif+KcFoXwTqtDqXluHGm9W2+/D7 +Jg5tr4z13kHRIev3WGxZmnGLOKOU+KBc18Z5Ik6icRqUZcq/xxxvGs5j8p09Gfjf+2b Abs/eLqAbfRL6WSPU09LdTQKqo3g683g/G1vEaykdtMgeMxMtIQwRjr11oOsS1q+MKa2 GsmA== X-Gm-Message-State: AAQBX9f5+bba3YVuSq3DNKKwQwksEQ5e7fJ3T5lZyezXzO/VPx+ndqw/ aniDW7LIo+5rRgXPBZQ2If8= X-Google-Smtp-Source: AKy350axgeXrDsMz7i3yaU0RAi1gc+voidVnK36WqZSdfbvFpue+fo0Aw3nOH50MqHOvV3CiPP5KWA== X-Received: by 2002:a05:6402:4402:b0:502:367:d5b8 with SMTP id y2-20020a056402440200b005020367d5b8mr17397382eda.4.1679950993703; Mon, 27 Mar 2023 14:03:13 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id p25-20020a50cd99000000b004bf76fdfdb3sm14962347edi.26.2023.03.27.14.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:03:04 -0700 (PDT) Date: Mon, 27 Mar 2023 23:02:51 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] staging: rtl8192e: Remove unused if clauses in rtl92e_set_wireless_mode Message-ID: <359ed203ab08afe5c2f449f40d2958868b4e55b4.1679949171.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Equation (support_mode & WIRELESS_MODE_N_24G) will always be true. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 21 ++------------------ 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index c03978353a90..689a5e16eb4d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -598,25 +598,8 @@ void rtl92e_set_wireless_mode(struct net_device *dev, = u8 wireless_mode) struct r8192_priv *priv =3D rtllib_priv(dev); u8 support_mode =3D (WIRELESS_MODE_N_24G | WIRELESS_MODE_G | WIRELESS_MOD= E_B); =20 - if ((wireless_mode =3D=3D WIRELESS_MODE_AUTO) || - ((wireless_mode & support_mode) =3D=3D 0)) { - if (support_mode & WIRELESS_MODE_N_24G) { - wireless_mode =3D WIRELESS_MODE_N_24G; - } else if (support_mode & WIRELESS_MODE_N_5G) { - wireless_mode =3D WIRELESS_MODE_N_5G; - } else if ((support_mode & WIRELESS_MODE_A)) { - wireless_mode =3D WIRELESS_MODE_A; - } else if ((support_mode & WIRELESS_MODE_G)) { - wireless_mode =3D WIRELESS_MODE_G; - } else if ((support_mode & WIRELESS_MODE_B)) { - wireless_mode =3D WIRELESS_MODE_B; - } else { - netdev_info(dev, - "%s(): Unsupported mode requested. Fallback to 802.11b\n", - __func__); - wireless_mode =3D WIRELESS_MODE_B; - } - } + if ((wireless_mode =3D=3D WIRELESS_MODE_AUTO) || ((wireless_mode & suppor= t_mode) =3D=3D 0)) + wireless_mode =3D WIRELESS_MODE_N_24G; =20 if ((wireless_mode & (WIRELESS_MODE_B | WIRELESS_MODE_G)) =3D=3D (WIRELESS_MODE_G | WIRELESS_MODE_B)) --=20 2.39.2 From nobody Mon Feb 9 07:19:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5ECC6FD1D for ; Mon, 27 Mar 2023 21:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232153AbjC0VDu (ORCPT ); Mon, 27 Mar 2023 17:03:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232225AbjC0VDn (ORCPT ); Mon, 27 Mar 2023 17:03:43 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E5823590 for ; Mon, 27 Mar 2023 14:03:22 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id x3so41497977edb.10 for ; Mon, 27 Mar 2023 14:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679951001; x=1682543001; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KtIG2xIOByplMnWqws/0mvUBLuQ/qpbAME2bjfonzr4=; b=XSgeDbWO64zzzTWA5jpAhIvsNrcP9pvd1oXovn7RPKk0naVZfF+fqxA/J3+nbcNB0t Is3PTlNaVrEjWQZze8oAiBBoWxenWFfliTKLFRPQQYsQUho0YnvTZQOqQ/RSKUaipiuo Bczo7sgOoxWOZEhJMK1uWbII95FmJeaBecr3eRxx2KeecIjtEYo8Vh7kzDJT4KQ6mBov cUN+lSQF+x4kMlCZIca59HzVGxlyT6QjqTZQszDbtOvEcTAR5cYSMP1BdlFg8v/36s5x 4uUi6PiU0lxZu2/XqwQuQItYcUc6C06pH7A4ziZ5t+4+nGSrAYeSuwWz2PgwfNw9nG+n Nz0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679951001; x=1682543001; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KtIG2xIOByplMnWqws/0mvUBLuQ/qpbAME2bjfonzr4=; b=D76Y9s1l81K4XDpZf+N+oeZEYuCBx2jrzutjDqdp4JTIo6oB2EEu169yoZR93HGFMi TDKIjoCelNI2umW13aSZstfslnXTDGTwvPxH9UsjJAmtdeJUZOIWSRZMREqpXMwojjvs +UfajCBtpbPm5ycmfBymNLFuUFwOokgZ9xdJuqtkPyXjOUvN0A1lc/BM2UDYGXYjGDaS vDcRMYYY02bc5LBHeahGQ5S6x0Mveod4vt/nrZRNysYCNhkAj9rcruSRPwAEf+cDzfn8 LzH1yUusyUc8M0Q68bwpNnT12tM8CPWiM2I3rkyLq86M7cULohGAb6Fcsr98vzxoG4Ya /vsw== X-Gm-Message-State: AAQBX9ean/b/iSr95QGSyNmimc69sjOVH8qJxGs+TjUyfpE/ujXZUkUD gxXTMKBEIBoP5dMZ60jZ8kK+ahQMIHo= X-Google-Smtp-Source: AKy350azLVFQA+ldnfv1H9+tJT/ffPgd2H+4RbeKa9lH8FycSHOZzQVxWiGwsOZH/iVX/DEKi8GtUg== X-Received: by 2002:a17:906:7490:b0:933:fa42:7e36 with SMTP id e16-20020a170906749000b00933fa427e36mr11690098ejl.5.1679951000955; Mon, 27 Mar 2023 14:03:20 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id i6-20020a170906250600b009306be6bed7sm14381083ejb.190.2023.03.27.14.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:03:14 -0700 (PDT) Date: Mon, 27 Mar 2023 23:02:57 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] staging: rtl8192e: Remove wireless modes A, N_5G from _rtl92e_hwconfig Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove WIRELESS_MODE_N_5G and WIRELESS_MODE_A as those are not supported by hardware and to improve readability. Combine WIRELESS_MODE_G with default to improve readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index f4fdaeff2917..1da14e737aa4 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -503,16 +503,6 @@ static void _rtl92e_hwconfig(struct net_device *dev) regRATR =3D RATE_ALL_CCK; regRRSR =3D RATE_ALL_CCK; break; - case WIRELESS_MODE_A: - regBwOpMode =3D BW_OPMODE_5G | BW_OPMODE_20MHZ; - regRATR =3D RATE_ALL_OFDM_AG; - regRRSR =3D RATE_ALL_OFDM_AG; - break; - case WIRELESS_MODE_G: - regBwOpMode =3D BW_OPMODE_20MHZ; - regRATR =3D RATE_ALL_CCK | RATE_ALL_OFDM_AG; - regRRSR =3D RATE_ALL_CCK | RATE_ALL_OFDM_AG; - break; case WIRELESS_MODE_AUTO: case WIRELESS_MODE_N_24G: regBwOpMode =3D BW_OPMODE_20MHZ; @@ -520,12 +510,7 @@ static void _rtl92e_hwconfig(struct net_device *dev) RATE_ALL_OFDM_1SS | RATE_ALL_OFDM_2SS; regRRSR =3D RATE_ALL_CCK | RATE_ALL_OFDM_AG; break; - case WIRELESS_MODE_N_5G: - regBwOpMode =3D BW_OPMODE_5G; - regRATR =3D RATE_ALL_OFDM_AG | RATE_ALL_OFDM_1SS | - RATE_ALL_OFDM_2SS; - regRRSR =3D RATE_ALL_OFDM_AG; - break; + case WIRELESS_MODE_G: default: regBwOpMode =3D BW_OPMODE_20MHZ; regRATR =3D RATE_ALL_CCK | RATE_ALL_OFDM_AG; --=20 2.39.2 From nobody Mon Feb 9 07:19:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4252CC76195 for ; Mon, 27 Mar 2023 21:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231375AbjC0VEB (ORCPT ); Mon, 27 Mar 2023 17:04:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232200AbjC0VDt (ORCPT ); Mon, 27 Mar 2023 17:03:49 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6626B2705 for ; Mon, 27 Mar 2023 14:03:28 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id h8so41556364ede.8 for ; Mon, 27 Mar 2023 14:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679951008; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AozKR2DoQOOyJHBglyYFmZBaHgy3GkeNuTZPAIS6qrc=; b=MVgyfKsxyF7IMhk6z/KTbB4cUeKi3N9CiLUP5+wDXffu0NBjZ1vTVkD9gutrRv3/28 Nyj/Y2/H+keaqnF016TTUdblXefz0kpYHeoAFQKmLOdCwiO7ZaZ+wLYSPBEtPkFk/O1j eganBRmBIgU+utePVhgEk8Vk/i/WQIvVtvmXCswmk637rDwGiszFpX4SHrlp+5sxzL49 jW1JrUUyW+7GOJSe/B34JY0FCI5cEb/7cnFbxV0VhaW9aoKJmg3UxcPEtxESd6r8BDO6 feL5qQQf4yrI7s6rZAJjL3tyiGmclltYVZOxKsBeSiE+1cvDB6M0SiFveoohnu6sR0cL 8BUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679951008; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AozKR2DoQOOyJHBglyYFmZBaHgy3GkeNuTZPAIS6qrc=; b=Oi8MfS8HPjV3wFDsCFMNP1cFzFrjLWUXLrEhLlpkHidkZvqYrar8ffEIZfcN9PMR1o XW3JDTAPUDzQYAZVOS+rP4aDoTX1fEEBmQ9ZJqCqCiF/XKFeTgihBwJq4ZACCdtqNYoj xtMDeQgTT511/kqrlrlyDd/2dylXQYXNrYsaNrRHvSneBqqqFd4GaHmqI26TwJajdCZN Aer7bu2/4vHC3yMenj9u8562pbTD3nuscwN9rXfbjVMKYneHIfDqUqcsdJxd2BhkGqDp RqRgDSgtNtlwfGiu9OiOXT86xMfewANa5kbRfvcf3nEPaJsA8BN/ZGPHvzfHDf18GVSc fbJw== X-Gm-Message-State: AAQBX9fYJgnsXvNy23VT2QjdbZnF3MLsYrJpAIOIQwpFA22OFvqm0qnb hM4u3PiULCrUPIkmgaeyBaI= X-Google-Smtp-Source: AKy350ZK0tpkIhJczcUkPG0Uonl+xK8i3Ec6WYb/RETj2/9m5xG31AKWZnZq2aowbnlkT+3PpTR5vQ== X-Received: by 2002:a17:906:49:b0:944:4d7:d3d9 with SMTP id 9-20020a170906004900b0094404d7d3d9mr6011882ejg.2.1679951007840; Mon, 27 Mar 2023 14:03:27 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id lg10-20020a170906f88a00b008cc920469b5sm14541859ejb.18.2023.03.27.14.03.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:03:21 -0700 (PDT) Date: Mon, 27 Mar 2023 23:03:06 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/7] staging: rtl8192e: Remove wireless modes A, N_5G from rtl92e_set_channel Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove WIRELESS_MODE_N_5G and WIRELESS_MODE_A as those are not supported by hardware and to improve readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 139d8268c8dc..dd666701138e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -696,15 +696,6 @@ u8 rtl92e_set_channel(struct net_device *dev, u8 chann= el) =20 =20 switch (priv->rtllib->mode) { - case WIRELESS_MODE_A: - case WIRELESS_MODE_N_5G: - if (channel <=3D 14) { - netdev_warn(dev, - "Channel %d not available in 802.11a.\n", - channel); - return false; - } - break; case WIRELESS_MODE_B: if (channel > 14) { netdev_warn(dev, --=20 2.39.2 From nobody Mon Feb 9 07:19:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB863C76195 for ; Mon, 27 Mar 2023 21:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230424AbjC0VEN (ORCPT ); Mon, 27 Mar 2023 17:04:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232254AbjC0VEH (ORCPT ); Mon, 27 Mar 2023 17:04:07 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A022E35BF for ; Mon, 27 Mar 2023 14:03:40 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id ek18so41588906edb.6 for ; Mon, 27 Mar 2023 14:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679951017; x=1682543017; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j1dijQb8BuQ1TCaGZWjHBSiEbh0gAL996aMBpLIQUkU=; b=YLRt1mLppRbAUSoZtvP5gsGj7SNMrEFdjt3LJVP5tCvFFqfkpxvBs9CvVTr2EKF8NJ qi9Fto0b8TfBvro6NkW8PV2tijDQv8x3wQVaI+wawLdjFPKv/XWNG3TFrioB1dZx0uxy f77tHKh4ek8hPSSBWcaLsOhU5QRrHywD7pyUsWqJ/fiWwt9CoYr8PT+2lTb3Jikf1wo7 u5DvQi2E8W6UdRsX3h4cK/h+xuaMlt70GKRCzadkF1SRcOvyUr+SiH5O434DHvsX/jgW mzVZLSV19QaiRqRGCSO2T9CNWq15+P2H2TMWlehALB9pfnf6AWiUf26viB4Tls2R30q/ 9w4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679951017; x=1682543017; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j1dijQb8BuQ1TCaGZWjHBSiEbh0gAL996aMBpLIQUkU=; b=jsE8d6x+MVPQEzKIvBACtpO7ZwYvEK3v4pEqBrH/F+75YLdMlS4lvKAp0trGHn4/pm Vudrvht0sKfGb3wX7nAQEbQU+0S+xbs05gcRbMFpiB//MXMfXFvwUSEtT/b1DmfYhXSB er0wrIzT1RkTDoSrTfTTQm4uTtj+8lCmGbXB+mn3zc3h3t106irWpYZl/4IhVU5Zc3Om YRWUC1DPUJqPNXuy9URy21utcPuk/vjFI1rrw/M8B8Pgz3X0uotvK2tVCTpBbopqDuDI oQyjExKF2TioaOLcorOTF7m9UJHtSvezKKWRioVScy5dundhiOvCogS3J2556ZDCdWmF Yp4g== X-Gm-Message-State: AAQBX9fVwO7ND/Eabo0wDvO8hYrrH7npUVJrc5f3XrkvC8pc/iOZRDgP FMv+c3uoNK2DMpusXNVDI6I= X-Google-Smtp-Source: AKy350aB5SpUawuuaM1kNxTxi4xFOG+eQ0y3u6d0yjM2nctv1Vsgga/cwaDAosROAT7V6/bw5C4lrg== X-Received: by 2002:a17:906:519d:b0:939:5398:768e with SMTP id y29-20020a170906519d00b009395398768emr11736026ejk.7.1679951017597; Mon, 27 Mar 2023 14:03:37 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id w7-20020a17090649c700b0093d9fddcd22sm5655119ejv.125.2023.03.27.14.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 14:03:28 -0700 (PDT) Date: Mon, 27 Mar 2023 23:03:14 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 7/7] staging: rtl8192e: Remove wireless mode WIRELESS_MODE_N_5G Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove WIRELESS_MODE_N_5G from equations as it is not supported by hardware and to improve readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +-- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 689a5e16eb4d..7506d7eb7b4c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -581,8 +581,7 @@ static void _rtl92e_refresh_support_rate(struct r8192_p= riv *priv) { struct rtllib_device *ieee =3D priv->rtllib; =20 - if (ieee->mode =3D=3D WIRELESS_MODE_N_24G || - ieee->mode =3D=3D WIRELESS_MODE_N_5G) { + if (ieee->mode =3D=3D WIRELESS_MODE_N_24G) { memcpy(ieee->reg_dot11ht_oper_rate_set, ieee->reg_ht_supp_rate_set, 16); memcpy(ieee->reg_dot11tx_ht_oper_rate_set, diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index d45808760638..b5f4d0230da7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -296,8 +296,7 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_d= evice *dev) if (pra->rate_adaptive_disabled) return; =20 - if (!(priv->rtllib->mode =3D=3D WIRELESS_MODE_N_24G || - priv->rtllib->mode =3D=3D WIRELESS_MODE_N_5G)) + if (priv->rtllib->mode !=3D WIRELESS_MODE_N_24G) return; =20 if (priv->rtllib->state =3D=3D RTLLIB_LINKED) { @@ -971,8 +970,7 @@ void rtl92e_dm_restore_state(struct net_device *dev) =20 if (priv->rate_adaptive.rate_adaptive_disabled) return; - if (!(priv->rtllib->mode =3D=3D WIRELESS_MODE_N_24G || - priv->rtllib->mode =3D=3D WIRELESS_MODE_N_5G)) + if (priv->rtllib->mode !=3D WIRELESS_MODE_N_24G) return; ratr_value =3D reg_ratr; ratr_value &=3D ~(RATE_ALL_OFDM_2SS); --=20 2.39.2