From nobody Sun May 5 05:28:52 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B53C761A6 for ; Mon, 27 Mar 2023 19:49:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232254AbjC0Ttd (ORCPT ); Mon, 27 Mar 2023 15:49:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231833AbjC0Tt3 (ORCPT ); Mon, 27 Mar 2023 15:49:29 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD6AB170B for ; Mon, 27 Mar 2023 12:49:16 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id n10-20020a05600c4f8a00b003ee93d2c914so7741629wmq.2 for ; Mon, 27 Mar 2023 12:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679946555; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v+ndiX5rXJ02XC2sW9a3uAWMCd1mtaGH5vgN2+hWRpM=; b=lUNofYe7Tgq1WR1WRbmtJUtFok3sGtUwKGREElZ4LpzBWRMH/Pj/fB7F9IV5PRSqgL WMKAHfmsN5N3kzwvYzWgP8CI3hWurW7tbeL90ggZmF5moLrDhwmUtPiDgp7pAPtktiya pooetdmRKwC3ZX+HpH1cJxqWjiJlHqAWCyDNmfb7MtC7hHMmu+QuQsJv0YLu/Ax6gd0b KZoDS17T8Wm82hodqADDbrJv+jVp5SeL30ZbCkcOp4LCNScJswtgtkqjY6/3Cv3gxVrL dT87qvq55x4f4v0qMVvjngTlEOwJFQ/gzfp+73p0Omhgm50eHgh+YTznp9lmONMGWzKv ATyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679946555; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v+ndiX5rXJ02XC2sW9a3uAWMCd1mtaGH5vgN2+hWRpM=; b=Y3ej4lW1lHjiZ0A4xNVmf3SV7rAfse5o3dhHSNdhQlrq4M647McbiT5hejuQjFUZ1E 0YnKtD5DONHg2PLb3nBJJoSqT9aSDqq78HQiTrZBV14ElOj5UAeibDnNQrVwqFNiJ13c pkz6TRcb97niOf9GWFmj9hyigl+GVH283uCC8il37xB8ixvOM7t8l6cPi8qmKMLraSn9 6No1rZqJ3DdMJgNPq6qWa4rNiDSGofq0SmfS0M2qlDObifERIRfyN5Vre6o0t42PYEOM yopwNSCPF/oBoCT9gFWhJGvXRZgkx2vI7vsEe0JKzc4nK7Thh8Uorx9RvzfzAlmgqSYq 9Xyg== X-Gm-Message-State: AO0yUKUyJQd0Tb7fa0I1y4sDBTjRF6aWrAHpPKhk7mrh7aVNVOJi8D63 63yE1AfSesZCfCtgfFjgWVY= X-Google-Smtp-Source: AK7set+tT4xHUiGnq6RSW28Uqrpa66lsGupdL7ofW1l7uQdAEe3MdFr/Wn45tTxEDyUolU6rWSZ8Qw== X-Received: by 2002:a05:600c:28b:b0:3ed:5cf7:3080 with SMTP id 11-20020a05600c028b00b003ed5cf73080mr10030913wmk.5.1679946554791; Mon, 27 Mar 2023 12:49:14 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id c13-20020a05600c0acd00b003ee42696acesm14661366wmr.16.2023.03.27.12.49.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 12:49:14 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/4] staging: rtl8192u: remove change history from comments Date: Tue, 28 Mar 2023 00:49:06 +0500 Message-Id: <95fff39231ebb2bb683c2a8f252a93f4845fffb1.1679945728.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the change history information as it is not required in the comments. Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192u/r8192U_dm.c | 45 ---------------------------- 1 file changed, 45 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192= u/r8192U_dm.c index 6a33ca02c3dc..b1ebb776fc42 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.c +++ b/drivers/staging/rtl8192u/r8192U_dm.c @@ -7,12 +7,6 @@ Module Name: =20 Abstract: HW dynamic mechanism. - -Major Change History: - When Who What - ---------- --------------- ------------------------------- - 2008-05-14 amy create version 0 porting from windows = code. - --*/ #include "r8192U.h" #include "r8192U_dm.h" @@ -274,11 +268,6 @@ void init_rate_adaptive(struct net_device *dev) * Output: NONE * * Return: NONE - * - * Revised History: - * When Who Remark - * 05/26/08 amy Create version 0 porting from windows code. - * *------------------------------------------------------------------------= ---*/ static void dm_check_rate_adaptive(struct net_device *dev) { @@ -1589,11 +1578,6 @@ static void dm_bb_initialgain_backup(struct net_devi= ce *dev) * Output: NONE * * Return: NONE - * - * Revised History: - * When Who Remark - * 05/15/2008 amy Create Version 0 porting from windows code. - * *------------------------------------------------------------------------= ---*/ static void dm_dig_init(struct net_device *dev) { @@ -1634,10 +1618,6 @@ static void dm_dig_init(struct net_device *dev) * Output: NONE * * Return: NONE - * - * Revised History: - * When Who Remark - * 05/27/2008 amy Create Version 0 porting from windows code. *------------------------------------------------------------------------= ---*/ static void dm_ctrl_initgain_byrssi(struct net_device *dev) { @@ -1850,11 +1830,6 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm( * Output: NONE * * Return: NONE - * - * Revised History: - * When Who Remark - * 05/28/2008 amy Create Version 0 porting from windows code. - * *------------------------------------------------------------------------= ---*/ static void dm_ctrl_initgain_byrssi_highpwr( struct net_device *dev) @@ -2269,11 +2244,6 @@ static void dm_ctstoself(struct net_device *dev) * Output: NONE * * Return: NONE - * - * Revised History: - * When Who Remark - * 05/28/2008 amy Create Version 0 porting from windows code. - * *------------------------------------------------------------------------= ---*/ static void dm_check_pbc_gpio(struct net_device *dev) { @@ -2303,11 +2273,6 @@ static void dm_check_pbc_gpio(struct net_device *dev) * Output: NONE * * Return: NONE - * - * Revised History: - * When Who Remark - * 01/30/2008 MHC Create Version 0. - * *------------------------------------------------------------------------= ---*/ void dm_rf_pathcheck_workitemcallback(struct work_struct *work) { @@ -2552,11 +2517,6 @@ static void dm_rxpath_sel_byrssi(struct net_device *= dev) * Output: NONE * * Return: NONE - * - * Revised History: - * When Who Remark - * 05/28/2008 amy Create Version 0 porting from windows code. - * *------------------------------------------------------------------------= ---*/ static void dm_check_rx_path_selection(struct net_device *dev) { @@ -2871,11 +2831,6 @@ void dm_check_fsync(struct net_device *dev) * Output: NONE * * Return: NONE - * - * Revised History: - * When Who Remark - * 03/06/2008 Jacken Create Version 0. - * *------------------------------------------------------------------------= --- */ static void dm_init_dynamic_txpower(struct net_device *dev) --=20 2.34.1 From nobody Sun May 5 05:28:52 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABACC6FD1D for ; Mon, 27 Mar 2023 19:49:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232439AbjC0Ttg (ORCPT ); Mon, 27 Mar 2023 15:49:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232115AbjC0Ttb (ORCPT ); Mon, 27 Mar 2023 15:49:31 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D37630D8 for ; Mon, 27 Mar 2023 12:49:18 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id l8-20020a05600c1d0800b003ef6708bbf6so4003976wms.5 for ; Mon, 27 Mar 2023 12:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679946557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fBqoyIg2s4G+6qTIVouHyZXfEx2G2/CvGDdlltVjXl8=; b=eUYUdmhuTWZxvqlHRicLeShNEJW4CCxGugtbglhQnY2fzSpMRMMRWJQfj8tqGfdLXg X5/FlLmD8o/q+0LlI+uhFXm2X3jX7+u1ulnlgblgEtt1pF5OZ0Gzs4vez5YJziN2hJWM rPjJDJYkJxTEBgfSKgBQCtwAHgTnJYlP4pU+15ASgeRw6pbsvI1kJKHyLXh+I3gJ4wwv zEBvjTN2MEQfZzWsw0ZCTrfOpgMV6zA0ziAQG0RLEngc8ogfeuXoy5pGhMOE8i5Di7Bj KwSRMObiqNuDZKRH5vyhQB9yrbbiH87ga4CAzYvOoxJuwc6O0ILiIO4kdEdhJKnmU7g4 z/gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679946557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fBqoyIg2s4G+6qTIVouHyZXfEx2G2/CvGDdlltVjXl8=; b=qGroP9pnR4rVISaDZJW72qh8JoRUzx3+9EVTr6zOlU7GNkFtHo7IxopcXzFIa09Aq3 w3MDF+1JVdimg40pFxJKAngqeP82NUkX1r7/bdpZGTkaULCShL7d91K9ANmZtc3qDYZA XQF/apItppq1eEo9MnmJQFrXeguYVK2uiUx6oWyns0qpQd4yCewrrvRzT32x4XX/radD wqbQi86lvlyBWubKmF67w8EYcNbcyz0BFcHnliVcoFEVFTLooz0qEUhjgSppV3A6CQBH uNs5cQIi05h/+jqBNRz3vDIvspXE+8hNLdzOvFqZlOyaxa+BZ8oTcK4wCU6S9iYfK3o5 ADEA== X-Gm-Message-State: AO0yUKWxuT4zPpX7SnnFRVtvG7FT7ZAq/1AmK07acmGpD6xrFOz73I4R MzACw7CswqXLcjDzKcw5MXBhPOkfC/XTCc7Q X-Google-Smtp-Source: AK7set+ZWzKk/4sY8suyU/gB2jdUS/eovrbW+ikGAwehhfKylhZfEyAhZ//GivWQE8WmIALmBV2yPw== X-Received: by 2002:a7b:c853:0:b0:3ed:ca62:418e with SMTP id c19-20020a7bc853000000b003edca62418emr10044475wml.9.1679946556445; Mon, 27 Mar 2023 12:49:16 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id c13-20020a05600c0acd00b003ee42696acesm14661366wmr.16.2023.03.27.12.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 12:49:16 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/4] staging: rtl8192u: remove commented out code Date: Tue, 28 Mar 2023 00:49:07 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove all of the commented out code lines as they are not being used and can be brought back in the future if they are ever needed again. Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192u/r8192U_dm.c | 123 --------------------------- 1 file changed, 123 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192= u/r8192U_dm.c index b1ebb776fc42..e5c0bece4bb4 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.c +++ b/drivers/staging/rtl8192u/r8192U_dm.c @@ -48,12 +48,8 @@ static void dm_init_bandwidth_autoswitch(struct net_devi= ce *dev); static void dm_bandwidth_autoswitch(struct net_device *dev); =20 /* DM --> TX power control */ -/*static void dm_initialize_txpower_tracking(struct net_device *dev);*/ - static void dm_check_txpower_tracking(struct net_device *dev); =20 -/*static void dm_txpower_reset_recovery(struct net_device *dev);*/ - /* DM --> Dynamic Init Gain by RSSI */ static void dm_dig_init(struct net_device *dev); static void dm_ctrl_initgain_byrssi(struct net_device *dev); @@ -68,7 +64,6 @@ static void dm_init_ctstoself(struct net_device *dev); /* DM --> EDCA turbo mode control */ static void dm_check_edca_turbo(struct net_device *dev); =20 -/*static void dm_gpio_change_rf(struct net_device *dev);*/ /* DM --> Check PBC */ static void dm_check_pbc_gpio(struct net_device *dev); =20 @@ -115,7 +110,6 @@ void init_hal_dm(struct net_device *dev) /* Initial TX Power Control for near/far range , add by amy 2008/05/15, p= orting from windows code. */ dm_init_dynamic_txpower(dev); init_rate_adaptive(dev); - /*dm_initialize_txpower_tracking(dev);*/ dm_dig_init(dev); dm_init_edca_turbo(dev); dm_init_bandwidth_autoswitch(dev); @@ -140,21 +134,6 @@ void dm_CheckRxAggregation(struct net_device *dev) unsigned long curTxOkCnt =3D 0; unsigned long curRxOkCnt =3D 0; =20 -/* - if (pHalData->bForcedUsbRxAggr) { - if (pHalData->ForcedUsbRxAggrInfo =3D=3D 0) { - if (pHalData->bCurrentRxAggrEnable) { - Adapter->HalFunc.HalUsbRxAggrHandler(Adapter, FALSE); - } - } else { - if (!pHalData->bCurrentRxAggrEnable || (pHalData->ForcedUsbRxAggrInfo != =3D pHalData->LastUsbRxAggrInfoSetting)) { - Adapter->HalFunc.HalUsbRxAggrHandler(Adapter, TRUE); - } - } - return; - } - -*/ curTxOkCnt =3D priv->stats.txbytesunicast - lastTxOkCnt; curRxOkCnt =3D priv->stats.rxbytesunicast - lastRxOkCnt; =20 @@ -188,10 +167,6 @@ void dm_CheckRxAggregation(struct net_device *dev) =20 void hal_dm_watchdog(struct net_device *dev) { - /*struct r8192_priv *priv =3D ieee80211_priv(dev);*/ - - /*static u8 previous_bssid[6] =3D{0};*/ - /*Add by amy 2008/05/15 ,porting from windows code.*/ dm_check_rate_adaptive(dev); dm_dynamic_txpower(dev); @@ -293,7 +268,6 @@ static void dm_check_rate_adaptive(struct net_device *d= ev) return; =20 if (priv->ieee80211->state =3D=3D IEEE80211_LINKED) { - /*RT_TRACE(COMP_RATE, "dm_CheckRateAdaptive(): \t");*/ =20 /* Check whether Short GI is enabled */ bshort_gi_enabled =3D (pHTInfo->bCurTxBW40MHz && pHTInfo->bCurShortGI40M= Hz) || @@ -340,36 +314,27 @@ static void dm_check_rate_adaptive(struct net_device = *dev) (pra->low_rssi_thresh_for_ra40M):(pra->low_rssi_thresh_for_ra20M); } =20 - /*DbgPrint("[DM] THresh H/L=3D%d/%d\n\r", RATR.HighRSSIThreshForRA, RATR= .LowRSSIThreshForRA);*/ if (priv->undecorated_smoothed_pwdb >=3D (long)HighRSSIThreshForRA) { - /*DbgPrint("[DM] RSSI=3D%d STA=3DHIGH\n\r", pHalData->UndecoratedSmooth= edPWDB);*/ pra->ratr_state =3D DM_RATR_STA_HIGH; targetRATR =3D pra->upper_rssi_threshold_ratr; } else if (priv->undecorated_smoothed_pwdb >=3D (long)LowRSSIThreshForRA= ) { - /*DbgPrint("[DM] RSSI=3D%d STA=3DMiddle\n\r", pHalData->UndecoratedSmoo= thedPWDB);*/ pra->ratr_state =3D DM_RATR_STA_MIDDLE; targetRATR =3D pra->middle_rssi_threshold_ratr; } else { - /*DbgPrint("[DM] RSSI=3D%d STA=3DLOW\n\r", pHalData->UndecoratedSmoothe= dPWDB);*/ pra->ratr_state =3D DM_RATR_STA_LOW; targetRATR =3D pra->low_rssi_threshold_ratr; } =20 /* cosa add for test */ if (pra->ping_rssi_enable) { - /*pHalData->UndecoratedSmoothedPWDB =3D 19;*/ if (priv->undecorated_smoothed_pwdb < (long)(pra->ping_rssi_thresh_for_= ra+5)) { if ((priv->undecorated_smoothed_pwdb < (long)pra->ping_rssi_thresh_for= _ra) || ping_rssi_state) { - /*DbgPrint("TestRSSI =3D %d, set RATR to 0x%x\n", pHalData->Undecorat= edSmoothedPWDB, pRA->TestRSSIRATR);*/ pra->ratr_state =3D DM_RATR_STA_LOW; targetRATR =3D pra->ping_rssi_ratr; ping_rssi_state =3D 1; } - /*else - DbgPrint("TestRSSI is between the range.\n");*/ } else { - /*DbgPrint("TestRSSI Recover to 0x%x\n", targetRATR);*/ ping_rssi_state =3D 0; } } @@ -491,7 +456,6 @@ static void dm_TXPowerTrackingCallback_TSSI(struct net_= device *dev) u32 Value; u8 Pwr_Flag; u16 Avg_TSSI_Meas, TSSI_13dBm, Avg_TSSI_Meas_from_driver =3D 0; - /*RT_STATUS rtStatus =3D RT_STATUS_SUCCESS;*/ bool rtStatus =3D true; u32 delta =3D 0; =20 @@ -513,7 +477,6 @@ static void dm_TXPowerTrackingCallback_TSSI(struct net_= device *dev) if (rtStatus =3D=3D RT_STATUS_FAILURE) RT_TRACE(COMP_POWER_TRACKING, "Set configuration with tx cmd queue fail= !\n"); usleep_range(1000, 2000); - /*DbgPrint("hi, vivi, strange\n");*/ for (i =3D 0; i <=3D 30; i++) { read_nic_byte(dev, 0x1ba, &Pwr_Flag); =20 @@ -559,8 +522,6 @@ static void dm_TXPowerTrackingCallback_TSSI(struct net_= device *dev) TSSI_13dBm =3D priv->TSSI_13dBm; RT_TRACE(COMP_POWER_TRACKING, "TSSI_13dBm =3D %d\n", TSSI_13dBm); =20 - /*if (abs(Avg_TSSI_Meas_from_driver - TSSI_13dBm) <=3D E_FOR_TX_POWER_T= RACK)*/ - /* For MacOS-compatible */ if (Avg_TSSI_Meas_from_driver > TSSI_13dBm) delta =3D Avg_TSSI_Meas_from_driver - TSSI_13dBm; else @@ -664,7 +625,6 @@ static void dm_TXPowerTrackingCallback_ThermalMeter(str= uct net_device *dev) } } priv->btxpower_trackingInit =3D true; - /*pHalData->TXPowercount =3D 0;*/ return; } =20 @@ -708,9 +668,6 @@ static void dm_TXPowerTrackingCallback_ThermalMeter(str= uct net_device *dev) } tmpCCK40Mindex =3D 0; } - /*DbgPrint("%ddb, tmpOFDMindex =3D %d, tmpCCK20Mindex =3D %d, tmpCCK40Min= dex =3D %d", - ((u1Byte)tmpRegA - pHalData->ThermalMeter[0]), - tmpOFDMindex, tmpCCK20Mindex, tmpCCK40Mindex);*/ if (priv->CurrentChannelBW !=3D HT_CHANNEL_WIDTH_20) /* 40M */ tmpCCKindex =3D tmpCCK40Mindex; else @@ -730,7 +687,6 @@ static void dm_TXPowerTrackingCallback_ThermalMeter(str= uct net_device *dev) } =20 if (CCKSwingNeedUpdate) { - /*DbgPrint("Update CCK Swing, CCK_index =3D %d\n", pHalData->CCK_index);= */ dm_cck_txpower_adjust(dev, priv->bcck_in_ch14); } if (priv->OFDM_index !=3D tmpOFDMindex) { @@ -1301,7 +1257,6 @@ static void dm_CheckTXPowerTracking_ThermalMeter(stru= ct net_device *dev) { struct r8192_priv *priv =3D ieee80211_priv(dev); static u8 TM_Trigger; - /*DbgPrint("dm_CheckTXPowerTracking()\n");*/ if (!priv->btxpower_tracking) return; if (priv->txpower_count <=3D 2) { @@ -1321,7 +1276,6 @@ static void dm_CheckTXPowerTracking_ThermalMeter(stru= ct net_device *dev) TM_Trigger =3D 1; return; } - /*DbgPrint("Schedule TxPowerTrackingWorkItem\n");*/ queue_delayed_work(priv->priv_wq, &priv->txpower_tracking_wq, 0); TM_Trigger =3D 0; } @@ -1329,7 +1283,6 @@ static void dm_CheckTXPowerTracking_ThermalMeter(stru= ct net_device *dev) static void dm_check_txpower_tracking(struct net_device *dev) { struct r8192_priv *priv =3D ieee80211_priv(dev); - /*static u32 tx_power_track_counter =3D 0;*/ =20 #ifdef RTL8190P dm_CheckTXPowerTracking_TSSI(dev); @@ -1414,7 +1367,6 @@ static void dm_CCKTxPowerAdjust_ThermalMeter(struct n= et_device *dev, bool bInCH RT_TRACE(COMP_POWER_TRACKING, "CCK not chnl 14, reg 0x%x =3D 0x%x\n", rCCK0_DebugPort, TempVal); } else { - /*priv->CCKTxPowerAdjustCntNotCh14++; cosa add for debug.*/ /* Write 0xa22 0xa23 */ TempVal =3D CCKSwingTable_Ch14[priv->CCK_index][0] + (CCKSwingTable_Ch14[priv->CCK_index][1]<<8); @@ -1497,10 +1449,7 @@ void dm_restore_dynamic_mechanism_state(struct net_d= evice *dev) ratr_value =3D reg_ratr; if (priv->rf_type =3D=3D RF_1T2R) { /* 1T2R, Spatial Stream 2 should be= disabled */ ratr_value &=3D ~(RATE_ALL_OFDM_2SS); - /*DbgPrint("HW_VAR_TATR_0 from 0x%x =3D=3D> 0x%x\n", ((pu4Byte)(val))[= 0], ratr_value);*/ } - /*DbgPrint("set HW_VAR_TATR_0 =3D 0x%x\n", ratr_value);*/ - /*cosa PlatformEFIOWrite4Byte(Adapter, RATR0, ((pu4Byte)(val))[0]);*/ write_nic_dword(dev, RATR0, ratr_value); write_nic_byte(dev, UFWP, 1); } @@ -1522,7 +1471,6 @@ static void dm_bb_initialgain_restore(struct net_devi= ce *dev) return; =20 /* Disable Initial Gain */ - /*PHY_SetBBReg(Adapter, UFWP, bMaskLWord, 0x800);*/ rtl8192_setBBreg(dev, UFWP, bMaskByte1, 0x8); /* Only clear byte 1 and re= write. */ rtl8192_setBBreg(dev, rOFDM0_XAAGCCore1, bit_mask, (u32)priv->initgain_ba= ckup.xaagccore1); rtl8192_setBBreg(dev, rOFDM0_XBAGCCore1, bit_mask, (u32)priv->initgain_ba= ckup.xbagccore1); @@ -1537,7 +1485,6 @@ static void dm_bb_initialgain_restore(struct net_devi= ce *dev) RT_TRACE(COMP_DIG, "dm_BBInitialGainRestore 0xc68 is %x\n", priv->initgai= n_backup.xdagccore1); RT_TRACE(COMP_DIG, "dm_BBInitialGainRestore 0xa0a is %x\n", priv->initgai= n_backup.cca); /* Enable Initial Gain */ - /*PHY_SetBBReg(Adapter, UFWP, bMaskLWord, 0x100);*/ rtl8192_setBBreg(dev, UFWP, bMaskByte1, 0x1); /* Only clear byte 1 and re= write. */ =20 } /* dm_BBInitialGainRestore */ @@ -1550,7 +1497,6 @@ static void dm_bb_initialgain_backup(struct net_devic= e *dev) if (dm_digtable.dig_algorithm =3D=3D DIG_ALGO_BY_RSSI) return; =20 - /*PHY_SetBBReg(Adapter, UFWP, bMaskLWord, 0x800);*/ rtl8192_setBBreg(dev, UFWP, bMaskByte1, 0x8); /* Only clear byte 1 and re= write. */ priv->initgain_backup.xaagccore1 =3D (u8)rtl8192_QueryBBReg(dev, rOFDM0_X= AAGCCore1, bit_mask); priv->initgain_backup.xbagccore1 =3D (u8)rtl8192_QueryBBReg(dev, rOFDM0_X= BAGCCore1, bit_mask); @@ -1643,7 +1589,6 @@ static void dm_ctrl_initgain_byrssi_by_driverrssi( if (!dm_digtable.dig_enable_flag) return; =20 - /*DbgPrint("Dig by Sw Rssi\n");*/ if (dm_digtable.dig_algorithm_switch) /* if switched algorithm, we have t= o disable FW Dig. */ fw_dig =3D 0; =20 @@ -1660,11 +1605,7 @@ static void dm_ctrl_initgain_byrssi_by_driverrssi( else dm_digtable.cur_connect_state =3D DIG_DISCONNECT; =20 - /*DbgPrint("DM_DigTable.PreConnectState =3D %d, DM_DigTable.CurConnectSta= te =3D %d\n", - DM_DigTable.PreConnectState, DM_DigTable.CurConnectState);*/ - dm_digtable.rssi_val =3D priv->undecorated_smoothed_pwdb; - /*DbgPrint("DM_DigTable.Rssi_val =3D %d\n", DM_DigTable.Rssi_val);*/ dm_initial_gain(dev); dm_pd_th(dev); dm_cs_ratio(dev); @@ -1700,11 +1641,6 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm( (priv->undecorated_smoothed_pwdb < dm_digtable.rssi_high_thresh)) return; =20 - /*DbgPrint("Dig by Fw False Alarm\n");*/ - /*if (DM_DigTable.Dig_State =3D=3D DM_STA_DIG_OFF)*/ - /*DbgPrint("DIG Check\n\r RSSI=3D%d LOW=3D%d HIGH=3D%d STATE=3D%d", - pHalData->UndecoratedSmoothedPWDB, DM_DigTable.RssiLowThresh, - DM_DigTable.RssiHighThresh, DM_DigTable.Dig_State);*/ /* 1. When RSSI decrease, We have to judge if it is smaller than a thresh= old * and then execute the step below. */ @@ -1737,12 +1673,6 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm( * 2008/02/05 MH SD3-Jerry 92U/92E PD_TH are the same. */ write_nic_byte(dev, (rOFDM0_XATxAFE+3), 0x00); - /*else if (priv->card_8192 =3D=3D HARDWARE_TYPE_RTL8190P) - write_nic_byte(pAdapter, rOFDM0_RxDetector1, 0x40); - else if (pAdapter->HardwareType =3D=3D HARDWARE_TYPE_RTL8192E) - else - PlatformEFIOWrite1Byte(pAdapter, rOFDM0_RxDetector1, 0x40); - */ } else write_nic_byte(dev, rOFDM0_RxDetector1, 0x42); =20 @@ -1750,7 +1680,6 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm( write_nic_byte(dev, 0xa0a, 0x08); =20 /* 1.5 Higher EDCCA. */ - /*PlatformEFIOWrite4Byte(pAdapter, rOFDM0_ECCAThreshold, 0x325);*/ return; } =20 @@ -1771,7 +1700,6 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm( reset_cnt =3D priv->reset_count; =20 dm_digtable.dig_state =3D DM_STA_DIG_ON; - /*DbgPrint("DIG ON\n\r");*/ =20 /* 2.1 Set initial gain. * 2008/02/26 MH SD3-Jerry suggest to prevent dirty environment. @@ -1794,13 +1722,6 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm( * 2008/02/05 MH SD3-Jerry 92U/92E PD_TH are the same. */ write_nic_byte(dev, (rOFDM0_XATxAFE+3), 0x20); - /* - else if (priv->card_8192 =3D=3D HARDWARE_TYPE_RTL8190P) - write_nic_byte(dev, rOFDM0_RxDetector1, 0x42); - else if (pAdapter->HardwareType =3D=3D HARDWARE_TYPE_RTL8192E) - else - PlatformEFIOWrite1Byte(pAdapter, rOFDM0_RxDetector1, 0x42); - */ } else write_nic_byte(dev, rOFDM0_RxDetector1, 0x44); =20 @@ -1810,7 +1731,6 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm( /* 2.4 Lower EDCCA. * 2008/01/11 MH 90/92 series are the same. */ - /*PlatformEFIOWrite4Byte(pAdapter, rOFDM0_ECCAThreshold, 0x346);*/ =20 /* 2.5 DIG On. */ rtl8192_setBBreg(dev, UFWP, bMaskByte1, 0x1); /* Only clear byte 1 and = rewrite. */ @@ -1856,11 +1776,6 @@ static void dm_ctrl_initgain_byrssi_highpwr( /* 3.1 Higher PD_TH for OFDM for high power state. */ if (priv->CurrentChannelBW !=3D HT_CHANNEL_WIDTH_20) { write_nic_byte(dev, (rOFDM0_XATxAFE+3), 0x10); - - /*else if (priv->card_8192 =3D=3D HARDWARE_TYPE_RTL8190P) - write_nic_byte(dev, rOFDM0_RxDetector1, 0x41); - */ - } else write_nic_byte(dev, rOFDM0_RxDetector1, 0x43); } else { @@ -1874,10 +1789,6 @@ static void dm_ctrl_initgain_byrssi_highpwr( /* 3.2 Recover PD_TH for OFDM for normal power region. */ if (priv->CurrentChannelBW !=3D HT_CHANNEL_WIDTH_20) { write_nic_byte(dev, (rOFDM0_XATxAFE+3), 0x20); - /*else if (priv->card_8192 =3D=3D HARDWARE_TYPE_RTL8190P) - write_nic_byte(dev, rOFDM0_RxDetector1, 0x42); - */ - } else write_nic_byte(dev, rOFDM0_RxDetector1, 0x44); } @@ -1919,7 +1830,6 @@ static void dm_initial_gain( dm_digtable.cur_ig_value =3D priv->DefaultInitialGain[0]; dm_digtable.pre_ig_value =3D 0; } - /*DbgPrint("DM_DigTable.CurIGValue =3D 0x%x, DM_DigTable.PreIGValue =3D 0= x%x\n", DM_DigTable.CurIGValue, DM_DigTable.PreIGValue);*/ =20 /* if silent reset happened, we should rewrite the values back */ if (priv->reset_count !=3D reset_cnt) { @@ -1935,7 +1845,6 @@ static void dm_initial_gain( if ((dm_digtable.pre_ig_value !=3D dm_digtable.cur_ig_value) || !initialized || force_write) { initial_gain =3D (u8)dm_digtable.cur_ig_value; - /*DbgPrint("Write initial gain =3D 0x%x\n", initial_gain);*/ /* Set initial gain. */ write_nic_byte(dev, rOFDM0_XAAGCCore1, initial_gain); write_nic_byte(dev, rOFDM0_XBAGCCore1, initial_gain); @@ -1987,7 +1896,6 @@ static void dm_pd_th( { if ((dm_digtable.prepd_thstate !=3D dm_digtable.curpd_thstate) || (initialized <=3D 3) || force_write) { - /*DbgPrint("Write PD_TH state =3D %d\n", DM_DigTable.CurPD_THState);*/ if (dm_digtable.curpd_thstate =3D=3D DIG_PD_AT_LOW_POWER) { /* Lower PD_TH for OFDM. */ if (priv->CurrentChannelBW !=3D HT_CHANNEL_WIDTH_20) { @@ -1995,9 +1903,6 @@ static void dm_pd_th( * 2008/02/05 MH SD3-Jerry 92U/92E PD_TH are the same. */ write_nic_byte(dev, (rOFDM0_XATxAFE+3), 0x00); - /*else if (priv->card_8192 =3D=3D HARDWARE_TYPE_RTL8190P) - write_nic_byte(dev, rOFDM0_RxDetector1, 0x40); - */ } else write_nic_byte(dev, rOFDM0_RxDetector1, 0x42); } else if (dm_digtable.curpd_thstate =3D=3D DIG_PD_AT_NORMAL_POWER) { @@ -2007,18 +1912,12 @@ static void dm_pd_th( * 2008/02/05 MH SD3-Jerry 92U/92E PD_TH are the same. */ write_nic_byte(dev, (rOFDM0_XATxAFE+3), 0x20); - /*else if (priv->card_8192 =3D=3D HARDWARE_TYPE_RTL8190P) - write_nic_byte(dev, rOFDM0_RxDetector1, 0x42); - */ } else write_nic_byte(dev, rOFDM0_RxDetector1, 0x44); } else if (dm_digtable.curpd_thstate =3D=3D DIG_PD_AT_HIGH_POWER) { /* Higher PD_TH for OFDM for high power state. */ if (priv->CurrentChannelBW !=3D HT_CHANNEL_WIDTH_20) { write_nic_byte(dev, (rOFDM0_XATxAFE+3), 0x10); - /*else if (priv->card_8192 =3D=3D HARDWARE_TYPE_RTL8190P) - write_nic_byte(dev, rOFDM0_RxDetector1, 0x41); - */ } else write_nic_byte(dev, rOFDM0_RxDetector1, 0x43); } @@ -2065,7 +1964,6 @@ static void dm_cs_ratio( { if ((dm_digtable.precs_ratio_state !=3D dm_digtable.curcs_ratio_state) || !initialized || force_write) { - /*DbgPrint("Write CS_ratio state =3D %d\n", DM_DigTable.CurCS_ratioStat= e);*/ if (dm_digtable.curcs_ratio_state =3D=3D DIG_CS_RATIO_LOWER) { /* Lower CS ratio for CCK. */ write_nic_byte(dev, 0xa0a, 0x08); @@ -2094,7 +1992,6 @@ static void dm_check_edca_turbo( { struct r8192_priv *priv =3D ieee80211_priv(dev); PRT_HIGH_THROUGHPUT pHTInfo =3D priv->ieee80211->pHTInfo; - /*PSTA_QOS pStaQos =3D pMgntInfo->pStaQos;*/ =20 /* Keep past Tx/Rx packet count for RT-to-RT EDCA turbo. */ static unsigned long lastTxOkCnt; @@ -2111,20 +2008,16 @@ static void dm_check_edca_turbo( if (priv->ieee80211->pHTInfo->IOTAction & HT_IOT_ACT_DISABLE_EDCA_TURBO) goto dm_CheckEdcaTurbo_EXIT; =20 - /*printk("=3D=3D=3D=3D=3D=3D=3D=3D>%s():bis_any_nonbepkts is %d\n", __fun= c__, priv->bis_any_nonbepkts);*/ - /* Check the status for current condition. */ if (!priv->ieee80211->bis_any_nonbepkts) { curTxOkCnt =3D priv->stats.txbytesunicast - lastTxOkCnt; curRxOkCnt =3D priv->stats.rxbytesunicast - lastRxOkCnt; /* For RT-AP, we needs to turn it on when Rx>Tx */ if (curRxOkCnt > 4*curTxOkCnt) { - /*printk("%s():curRxOkCnt > 4*curTxOkCnt\n");*/ if (!priv->bis_cur_rdlstate || !priv->bcurrent_turbo_EDCA) { write_nic_dword(dev, EDCAPARA_BE, edca_setting_DL[pHTInfo->IOTPeer]); priv->bis_cur_rdlstate =3D true; } } else { - /*printk("%s():curRxOkCnt < 4*curTxOkCnt\n");*/ if (priv->bis_cur_rdlstate || !priv->bcurrent_turbo_EDCA) { write_nic_dword(dev, EDCAPARA_BE, edca_setting_UL[pHTInfo->IOTPeer]); priv->bis_cur_rdlstate =3D false; @@ -2224,7 +2117,6 @@ static void dm_ctstoself(struct net_device *dev) curRxOkCnt =3D priv->stats.rxbytesunicast - lastRxOkCnt; if (curRxOkCnt > 4*curTxOkCnt) { /* downlink, disable CTS to self */ pHTInfo->IOTAction &=3D ~HT_IOT_ACT_FORCED_CTS2SELF; - /*DbgPrint("dm_CTSToSelf() =3D=3D> CTS to self disabled -- downlink\n")= ;*/ } else { /* uplink */ pHTInfo->IOTAction |=3D HT_IOT_ACT_FORCED_CTS2SELF; } @@ -2279,7 +2171,6 @@ void dm_rf_pathcheck_workitemcallback(struct work_str= uct *work) struct delayed_work *dwork =3D to_delayed_work(work); struct r8192_priv *priv =3D container_of(dwork, struct r8192_priv, rfpath= _check_wq); struct net_device *dev =3D priv->ieee80211->dev; - /*bool bactually_set =3D false;*/ u8 rfpath =3D 0, i; =20 /* 2008/01/30 MH After discussing with SD3 Jerry, 0xc04/0xd04 register wi= ll @@ -2343,7 +2234,6 @@ static void dm_rxpath_sel_byrssi(struct net_device *d= ev) =20 if (priv->ieee80211->mode =3D=3D WIRELESS_MODE_B) { DM_RxPathSelTable.cck_method =3D CCK_RX_VERSION_2; /* pure B mode, fixed= cck version2 */ - /*DbgPrint("Pure B mode, use cck rx version2\n");*/ } =20 /* decide max/sec/min rssi index */ @@ -2496,7 +2386,6 @@ static void dm_rxpath_sel_byrssi(struct net_device *d= ev) if ((DM_RxPathSelTable.disabled_rf >> i) & 0x1) { /* disabled rf */ if (tmp_max_rssi >=3D DM_RxPathSelTable.rf_enable_rssi_th[i]) { /* enable the BB Rx path */ - /*DbgPrint("RF-%d is enabled.\n", 0x1<framesync); reg_c38_State =3D RegC38_Default; - /*DbgPrint("Fsync is idle, rssi>=3D40, write 0xc38 =3D 0x%x\n", pHal= Data->framesync);*/ } } } else { if (reg_c38_State) { write_nic_byte(dev, rOFDM0_RxDetector3, priv->framesync); reg_c38_State =3D RegC38_Default; - /*DbgPrint("Fsync is idle, not connected, write 0xc38 =3D 0x%x\n", pH= alData->framesync);*/ } } } @@ -2808,13 +2694,11 @@ void dm_check_fsync(struct net_device *dev) write_nic_byte(dev, rOFDM0_RxDetector3, priv->framesync); reg_c38_State =3D RegC38_Default; reset_cnt =3D priv->reset_count; - /*DbgPrint("reg_c38_State =3D 0 for silent reset.\n");*/ } } else { if (reg_c38_State) { write_nic_byte(dev, rOFDM0_RxDetector3, priv->framesync); reg_c38_State =3D RegC38_Default; - /*DbgPrint("framesync no monitor, write 0xc38 =3D 0x%x\n", pHalData->fr= amesync);*/ } } } @@ -2856,7 +2740,6 @@ static void dm_dynamic_txpower(struct net_device *dev) priv->bDynamicTxLowPower =3D false; return; } - /*printk("priv->ieee80211->current_network.unknown_cap_exist is %d , priv= ->ieee80211->current_network.broadcom_cap_exist is %d\n", priv->ieee80211->= current_network.unknown_cap_exist, priv->ieee80211->current_network.broadco= m_cap_exist);*/ if ((priv->ieee80211->current_network.atheros_cap_exist) && (priv->ieee80= 211->mode =3D=3D IEEE_G)) { txhipower_threshold =3D TX_POWER_ATHEROAP_THRESH_HIGH; txlowpower_threshold =3D TX_POWER_ATHEROAP_THRESH_LOW; @@ -2865,7 +2748,6 @@ static void dm_dynamic_txpower(struct net_device *dev) txlowpower_threshold =3D TX_POWER_NEAR_FIELD_THRESH_LOW; } =20 - /*printk("=3D=3D=3D=3D=3D=3D=3D>%s(): txhipower_threshold is %d, txlowpow= er_threshold is %d\n", __func__, txhipower_threshold, txlowpower_threshold)= ;*/ RT_TRACE(COMP_TXAGC, "priv->undecorated_smoothed_pwdb =3D %ld\n", priv->u= ndecorated_smoothed_pwdb); =20 if (priv->ieee80211->state =3D=3D IEEE80211_LINKED) { @@ -2884,7 +2766,6 @@ static void dm_dynamic_txpower(struct net_device *dev) priv->bDynamicTxLowPower =3D false; } } else { - /*pHalData->bTXPowerCtrlforNearFarRange =3D !pHalData->bTXPowerCtrlforNe= arFarRange;*/ priv->bDynamicTxHighPower =3D false; priv->bDynamicTxLowPower =3D false; } @@ -2911,14 +2792,10 @@ static void dm_check_txrateandretrycount(struct net= _device *dev) struct r8192_priv *priv =3D ieee80211_priv(dev); struct ieee80211_device *ieee =3D priv->ieee80211; /* for 11n tx rate */ - /*priv->stats.CurrentShowTxate =3D read_nic_byte(dev, CURRENT_TX_RATE_REG= );*/ read_nic_byte(dev, CURRENT_TX_RATE_REG, &ieee->softmac_stats.CurrentShowT= xate); - /*printk("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>tx_rate_reg:%x\n", ieee= ->softmac_stats.CurrentShowTxate);*/ /* for initial tx rate */ - /*priv->stats.last_packet_rate =3D read_nic_byte(dev, INITIAL_TX_RATE_REG= );*/ read_nic_byte(dev, INITIAL_TX_RATE_REG, &ieee->softmac_stats.last_packet_= rate); /* for tx retry count */ - /*priv->stats.txretrycount =3D read_nic_dword(dev, TX_RETRY_COUNT_REG);*/ read_nic_dword(dev, TX_RETRY_COUNT_REG, &ieee->softmac_stats.txretrycount= ); } =20 --=20 2.34.1 From nobody Sun May 5 05:28:52 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473B7C6FD1D for ; Mon, 27 Mar 2023 19:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232220AbjC0Ttk (ORCPT ); Mon, 27 Mar 2023 15:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232127AbjC0Ttb (ORCPT ); Mon, 27 Mar 2023 15:49:31 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BED513AAB for ; Mon, 27 Mar 2023 12:49:19 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id u1so5656223wmn.5 for ; Mon, 27 Mar 2023 12:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679946558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eWKsykkKVuz2dhEzgsJk6LsgHkCtoaGRFeLVtPb88b4=; b=M9ozzLvSFwB0rFvoXKyJaaa4QUuyFwmExeqAdbrW5d/4GD8gy7KNsAgLxRlVMLR/4C fqiK6c5MW0kbcD1fnK1RsfkgDLfSh8hlycjyCREBzsTg6iIYZMJJ3uCR6qS6sMDJRMjG eWN0qMnpKQRZoa6chaxCXdrEQ+9hXcBaLxJ3iKEm1vCHb7zelhRifQFrB2sV4R/UCe45 YLMlO7G1eCcJMtku+l9RvLu4XwV6BC5jS1bhCoEJEYm0ew3iVo3CbyxOGorcirWX/R1e o101smcEVU3jamQ4pQiiJO6OWZawW4nDMF7nzCAW0bHXDlOhP/eAPmBZF602GMfwPl7I Wuew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679946558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eWKsykkKVuz2dhEzgsJk6LsgHkCtoaGRFeLVtPb88b4=; b=6jbgaUfJEDEPa2nJphAtbd/2R8tmRW0TdDPrGWJunhkkkP45kV403194L8PqzYI4x/ vp77TkK0tObl+AlamP1Q9rOFBQQptynCgSG1tSIhgeo1+j4XlrSdLBvAACaOkQQlHfDQ nkKutZlur4WbI1dji3lJOds8ENI5iVwMkLy5BrFVDB9svyuD3SlR0GOVDTDxlshZ2QiL 3Gv34E2Vq4qnaPGGZUejAf3XId00FQvisPYG+esolJEw2mOPtF9DczqOToEPITSjxSrd q7P70cnCK88JHTzXs+948ca/rkGXtC+8TRT1kngVbVLUEPxRLFGR8lLgauvsYwTWaPyT +lBg== X-Gm-Message-State: AO0yUKU18UonMSZdZ2lXMewHnAsxO/AhzCEEJL4A5K+lj631KQme1m+/ Suk1NDI6deNy+rmZMMyddJM= X-Google-Smtp-Source: AK7set8Uxf+Nc7JF9L4fgS5+Z8Z3CoEKoIml9ofdpLE0kZzWgeKEu5QchrpmMMC+SqimZGpJBYaWNQ== X-Received: by 2002:a1c:4c0d:0:b0:3eb:2e32:72c3 with SMTP id z13-20020a1c4c0d000000b003eb2e3272c3mr11137268wmf.22.1679946558133; Mon, 27 Mar 2023 12:49:18 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id c13-20020a05600c0acd00b003ee42696acesm14661366wmr.16.2023.03.27.12.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 12:49:17 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/4] staging: rtl8192u: add '*' on subsequent lines in block comment Date: Tue, 28 Mar 2023 00:49:08 +0500 Message-Id: <3a581aae65a152ce41fdd2db667574eba1783113.1679945728.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Linux kernel coding style for block comments uses a column of '*' on the left side. Fix block comment by adding '*' on subsequent lines as reported by checkatch.pl script. Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192u/r8192U_dm.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192= u/r8192U_dm.c index e5c0bece4bb4..dd9903719c20 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.c +++ b/drivers/staging/rtl8192u/r8192U_dm.c @@ -1,13 +1,14 @@ // SPDX-License-Identifier: GPL-2.0 /*++ -Copyright-c Realtek Semiconductor Corp. All rights reserved. - -Module Name: - r8192U_dm.c - -Abstract: - HW dynamic mechanism. ---*/ + * Copyright-c Realtek Semiconductor Corp. All rights reserved. + * + * Module Name: + * r8192U_dm.c + * + * Abstract: + * HW dynamic mechanism. + *-- + */ #include "r8192U.h" #include "r8192U_dm.h" #include "r8192U_hw.h" --=20 2.34.1 From nobody Sun May 5 05:28:52 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0204C6FD1D for ; Mon, 27 Mar 2023 19:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232323AbjC0Ttp (ORCPT ); Mon, 27 Mar 2023 15:49:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232252AbjC0Ttd (ORCPT ); Mon, 27 Mar 2023 15:49:33 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52B9630F7 for ; Mon, 27 Mar 2023 12:49:21 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id l15-20020a05600c4f0f00b003ef6d684102so2761825wmq.3 for ; Mon, 27 Mar 2023 12:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679946560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QPniY3ABE/sruZLdMSgZ+HEbx7EmfDzf62Z17Bwx1Ak=; b=Jp2YU7qCgvZ7R2rCUAPUlzoUKdssJSvgdDuyFZiYh5qO3Pqmlgf67CTx2mOiO6qKxV 57yH8QmWmS2+4JsdYaRZiZw6xIPsxo4kqGS13ib2JcJnVVbQTTJophKQSoPaNRygJeG5 5B5abgaYu8jvhIrRbnDC1YjLGople/D1y6GXh+NlxMlrWHZMLD5r7la78Vle9DvnHR25 jeQPp6UFV8ZbM/1XqoHfWI+sGB8Zp5Sk5uSIiLyB7RESiVTPRi/KetI2HdNxUCNfl8xf EJD/jSy81pL96HqSLY6qeGJmFtYORXmciz4ybAEe/W/4MAsuzE8Sp1ctDCVM6OwnRQI5 yOew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679946560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QPniY3ABE/sruZLdMSgZ+HEbx7EmfDzf62Z17Bwx1Ak=; b=si4SzImhLJ5T/p65g2INW9hmEB6pMFmDvpJlBWNBpk6m0rawTTwgk7IeHCfFifwqC8 DqF7VyhZedkdDVQiz3sr+quCgEwIBnulvllm4CQk9rRpM3oIlhpPXBqWqdH8IXRfb0zP QH+W1H5NCCx5EFw3haeT8PvvPIX6geoMBfYnMg1NDKVz3nSIHWj4cyaSkfXleTPBJnWG 6BoKXyPusRFf+nHzV02m57j/pvlYeJPwpcnoSrMJaorzbGky1paeIMYpCQBjjcW0+jhG KOx7izrnPupj9U7BZvNGatOB+eP7iTGDQ9nqAP+nRwOdJsPwhs3DICTiNrspa0ZwCDuH h7pQ== X-Gm-Message-State: AO0yUKVq7D78uJsWxWxXkssEWsL41y/3AN5PE7ui6A46skEMO68wKkHh /UCkFFVOR4NPP14J2NdAelIfI7nGaNRj9mJw X-Google-Smtp-Source: AK7set9bVcb5J4EZwsO3Gh0znIBxvte0wIssM94wD+oYiUrT0TbMIdu5FDWi9o2K9dhUIM8nd+/djg== X-Received: by 2002:a05:600c:28c:b0:3ef:561d:255d with SMTP id 12-20020a05600c028c00b003ef561d255dmr9392630wmk.41.1679946559770; Mon, 27 Mar 2023 12:49:19 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id c13-20020a05600c0acd00b003ee42696acesm14661366wmr.16.2023.03.27.12.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 12:49:19 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/4] staging: rtl8192u: add '*/' on separate line in block comments Date: Tue, 28 Mar 2023 00:49:09 +0500 Message-Id: <140e0928531e61dc7396271a5b16a6be17514c76.1679945728.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Linux kernel coding style uses '*/' on a separate line at the end of multi line comments. Fix block comments by moving '*/' at the end of block comments on a separate line as reported by checkpatch.pl script. Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192u/r8192U_dm.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192= u/r8192U_dm.c index dd9903719c20..cbae852478ea 100644 --- a/drivers/staging/rtl8192u/r8192U_dm.c +++ b/drivers/staging/rtl8192u/r8192U_dm.c @@ -244,7 +244,8 @@ void init_rate_adaptive(struct net_device *dev) * Output: NONE * * Return: NONE - *------------------------------------------------------------------------= ---*/ + *------------------------------------------------------------------------= --- + */ static void dm_check_rate_adaptive(struct net_device *dev) { struct r8192_priv *priv =3D ieee80211_priv(dev); @@ -1525,7 +1526,8 @@ static void dm_bb_initialgain_backup(struct net_devic= e *dev) * Output: NONE * * Return: NONE - *------------------------------------------------------------------------= ---*/ + *------------------------------------------------------------------------= --- + */ static void dm_dig_init(struct net_device *dev) { struct r8192_priv *priv =3D ieee80211_priv(dev); @@ -1565,7 +1567,8 @@ static void dm_dig_init(struct net_device *dev) * Output: NONE * * Return: NONE - *------------------------------------------------------------------------= ---*/ + *------------------------------------------------------------------------= --- + */ static void dm_ctrl_initgain_byrssi(struct net_device *dev) { if (!dm_digtable.dig_enable_flag) @@ -1751,7 +1754,8 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm( * Output: NONE * * Return: NONE - *------------------------------------------------------------------------= ---*/ + *------------------------------------------------------------------------= --- + */ static void dm_ctrl_initgain_byrssi_highpwr( struct net_device *dev) { @@ -2137,7 +2141,8 @@ static void dm_ctstoself(struct net_device *dev) * Output: NONE * * Return: NONE - *------------------------------------------------------------------------= ---*/ + *------------------------------------------------------------------------= --- + */ static void dm_check_pbc_gpio(struct net_device *dev) { struct r8192_priv *priv =3D ieee80211_priv(dev); @@ -2166,7 +2171,8 @@ static void dm_check_pbc_gpio(struct net_device *dev) * Output: NONE * * Return: NONE - *------------------------------------------------------------------------= ---*/ + *------------------------------------------------------------------------= --- + */ void dm_rf_pathcheck_workitemcallback(struct work_struct *work) { struct delayed_work *dwork =3D to_delayed_work(work); @@ -2407,7 +2413,8 @@ static void dm_rxpath_sel_byrssi(struct net_device *d= ev) * Output: NONE * * Return: NONE - *------------------------------------------------------------------------= ---*/ + *------------------------------------------------------------------------= --- + */ static void dm_check_rx_path_selection(struct net_device *dev) { struct r8192_priv *priv =3D ieee80211_priv(dev); --=20 2.34.1