From nobody Thu May 2 02:10:16 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D730C76195 for ; Fri, 24 Mar 2023 22:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232260AbjCXWcf (ORCPT ); Fri, 24 Mar 2023 18:32:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231572AbjCXWcb (ORCPT ); Fri, 24 Mar 2023 18:32:31 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C919218A85 for ; Fri, 24 Mar 2023 15:32:02 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id q19so118247wrc.5 for ; Fri, 24 Mar 2023 15:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679697097; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qHW/CyCQWbbVJjXUcNnqunHcb5Z7BkaW2HblBqM5Qy8=; b=lF8aSnuGs07w78dFpM5Y6jST1Xi8c2bJH0TU6U2bR0GpNl/vttBD48nkPPnVw31uhS sYUEMi3JHyIR510+aG+zQdNEQXgmsG8KXejsdESjn0yjg/u5Cpxs9yr2K3qZWG3m3+gQ F3gb29BXkefGJkGuZbgcq2uH6GTjo2t4QkD9LCmzs6Uhh7MQ+58GeTdGyFJAKRA0gtPa 6+P9Chh87JvAWFjivD7Ok0j+8IChbVdcGsGQHQRDYTKgI6dwQ7P6Z7Xu62OBtz8BhbJ2 kiUIDbjVM43ayevoxDSl6hD9CjoHmMi48wOkij9ZmyPnT+wgMdQUnGd6YuQcY21fi4L2 UVPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679697097; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qHW/CyCQWbbVJjXUcNnqunHcb5Z7BkaW2HblBqM5Qy8=; b=ax5W9vVyL40eVqAIESAs22vPjVtlxg0S9PEujcRGKSZFVSmd46ykWLXTfmn38KDb8Y /jlco0wxPUJL1dGyouvbDLw+ymBVak65NgOviV9SHdwYsZ1x47N/XOfsnQjGwcUhvyUH IrxwZRqcbjsLBOQ/u4m2R9aLg1GrzOc+39C6DR+ULfeXcrLyWR9MNsTmqT6Vu2pL31DD nIIwaiXw4kvDvpSTy3NqZAGQhGXlMk4zILigG51c7J6/i3J2XYvoipuh9ZiptNCcFGg/ jLnT5bVtru1zEFwaQvtrKPEEoa/+peimTDGDieCDGpn2NqSNq+DB5ujrOLJT2UwPEUFq gPcw== X-Gm-Message-State: AAQBX9e90znf9hgGclNGKkaus6iBrGWvNR25ZAZ9OvwctfMOOQ8qe46D ylg/tIc9uKV5v+iBPccR5MXPU/gDl/JVHA== X-Google-Smtp-Source: AKy350a9UZDIiX005q9r6mmPw0t9DeoHB2kKoOS1rKdhV8GyhxQSNi8TEYKOWPPpLVUub2VqkoUk4g== X-Received: by 2002:adf:dccc:0:b0:2d2:29a4:4457 with SMTP id x12-20020adfdccc000000b002d229a44457mr3436258wrm.13.1679697096706; Fri, 24 Mar 2023 15:31:36 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id d7-20020adffbc7000000b002d5a8d8442asm14984138wrs.37.2023.03.24.15.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:31:36 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/4] staging: rtl8192e: remove extra blank lines Date: Sat, 25 Mar 2023 03:31:28 +0500 Message-Id: <6d7388f944e8296227269c7472a462ea7c94149c.1679696777.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the extra blank line in accordance with the Linux kernel coding-style regulations. These issues were reported by checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c394c21beefb..c6114d99829b 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -154,7 +154,6 @@ rtllib_frag_cache_get(struct rtllib_device *ieee, return skb; } =20 - /* Called only as a tasklet (software IRQ) */ static int rtllib_frag_cache_invalidate(struct rtllib_device *ieee, struct rtllib_hdr_4addr *hdr) @@ -318,7 +317,6 @@ rtllib_rx_frame_decrypt(struct rtllib_device *ieee, str= uct sk_buff *skb, return res; } =20 - /* Called only as a tasklet (software IRQ), by rtllib_rx */ static inline int rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee, struct sk_buff *s= kb, @@ -355,7 +353,6 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, return 0; } =20 - /* this function is stolen from ipw2200 driver*/ #define IEEE_PACKET_RETRY_TIME (5*HZ) static int is_duplicate_packet(struct rtllib_device *ieee, @@ -887,7 +884,6 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, return rxb->nr_subframes; } =20 - static size_t rtllib_rx_get_hdrlen(struct rtllib_device *ieee, struct sk_buff *skb, struct rtllib_rx_stats *rx_stats) @@ -1569,7 +1565,6 @@ static int rtllib_verify_qos_info(struct rtllib_qos_i= nformation_element return 0; } =20 - /* Parse a QoS parameter element */ static int rtllib_read_qos_param_element( struct rtllib_qos_parameter_info *element_param, @@ -1599,7 +1594,6 @@ static int rtllib_read_qos_info_element( return rtllib_verify_qos_info(element_info, QOS_OUI_INFO_SUB_TYPE); } =20 - /* Write QoS parameters from the ac parameters. */ static int rtllib_qos_convert_ac_to_parameters(struct rtllib_qos_parameter= _info *param_elm, struct rtllib_qos_data *qos_data) @@ -1843,7 +1837,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, } } =20 - if (*tmp_htinfo_len =3D=3D 0) { if (info_element->len >=3D 4 && info_element->data[0] =3D=3D 0x00 && @@ -1932,7 +1925,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[2] =3D=3D 0x96) network->cisco_cap_exist =3D true; =20 - if (info_element->len >=3D 3 && info_element->data[0] =3D=3D 0x00 && info_element->data[1] =3D=3D 0x0a && @@ -2142,13 +2134,11 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, =20 network->dtim_data =3D RTLLIB_DTIM_VALID; =20 - if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; =20 offset =3D (info_element->data[2] >> 1)*2; =20 - if (ieee->assoc_id < 8*offset || ieee->assoc_id > 8*(offset + info_element->len - 3)) break; @@ -2203,7 +2193,6 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, &tmp_htcap_len); break; =20 - case MFIE_TYPE_HT_INFO: netdev_dbg(ieee->dev, "MFIE_TYPE_HT_INFO: %d bytes\n", info_element->len); @@ -2392,7 +2381,6 @@ static inline int is_same_network(struct rtllib_netwo= rk *src, (dst->capability & WLAN_CAPABILITY_ESS))); } =20 - static inline void update_network(struct rtllib_device *ieee, struct rtllib_network *dst, struct rtllib_network *src) @@ -2580,7 +2568,6 @@ static inline void rtllib_process_probe_response( goto free_network; } =20 - if (!rtllib_legal_channel(ieee, network->channel)) goto free_network; =20 --=20 2.34.1 From nobody Thu May 2 02:10:16 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49FEC76195 for ; Fri, 24 Mar 2023 22:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232141AbjCXWcj (ORCPT ); Fri, 24 Mar 2023 18:32:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjCXWcb (ORCPT ); Fri, 24 Mar 2023 18:32:31 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C796C1F908 for ; Fri, 24 Mar 2023 15:32:03 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id l12so3161297wrm.10 for ; Fri, 24 Mar 2023 15:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679697098; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3Mi0Pc446/hNZjoA2whb7pVis3I9iPt8Xg8w3eBefMA=; b=mobA70mS99HIO8GofxD3z9FKdGusnjzAI/gAeFjArElMNCo5NfQvSbk6Sxh9NWZScu 0N3K/5Nlr4AEYpeglA53RuQWLjPblzOoua5gBnGIjpKeQdRGMwV4Y3Xi1roA0YeP3fYe 6y1uJSGwfYYJCE6aM+fLGdYKjKk5mtpAbfSVU5HamqNnX5bmAliBHKoH7PAd2XHwuGYT Tm+w+2Pu0J/2Kn4/NFPJgl2ZPwGJUyO6RvDEPGLGI/tCErRBTyIpxX36f++YbYHDliwv OWdw7przsj+4A5pXd+4LM9h0baNua+tUR9xjetbcjHgqvl1Wtm6IazNHd+3bV4ccALaz BG2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679697098; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Mi0Pc446/hNZjoA2whb7pVis3I9iPt8Xg8w3eBefMA=; b=No/kVAOe+Uj2s6lLXOp8FYk8SyoFNi3mKcrKXMHHr4dE7mUzfnmQkn435jouJjTCxw 3S7nC9QkeFLXCCj/e6HWK4UBe+ez3Q/16y1ELg/g142AvVg96nsmQqBVP5NxgwYqdyCW /z1aT/rJalBH5VB/a3QY933ryf+4Xo3hfJPqiGJn6WzSRYvW2qqIngP2WgSsOgaFWtgH AW3H6VNlS//CxnGNn9iPZywC957an2HgBhgbMDt5F6EZViXXFwvBmumGsMNS417V0/Nd iw3AMVl7q3rjVo7gW9xWn3qs5JA+UyyXcjWme2wKU00k+0s/dkLJWKfYBYldIiHOA+pQ dzOw== X-Gm-Message-State: AAQBX9f4FMleuFyw5gSYQnigkZD1+k4y8KI6iwWYxvIWI4pM0VzXmSQH LIxo6niwyURoguIwhZnNE5TyQWfZoqL+ow== X-Google-Smtp-Source: AKy350aF8hqqUeU5omOOYaYRzd2NcGnM1I0RRzkrA4T9gmjTQPoPECgS8HaiMJrnyj1W0t3wJb377g== X-Received: by 2002:a5d:4b44:0:b0:2d8:47c7:7b50 with SMTP id w4-20020a5d4b44000000b002d847c77b50mr3464652wrs.1.1679697098358; Fri, 24 Mar 2023 15:31:38 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id d7-20020adffbc7000000b002d5a8d8442asm14984138wrs.37.2023.03.24.15.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:31:38 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/4] staging: rtl8192e: add blank lines after declarations Date: Sat, 25 Mar 2023 03:31:29 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add blank lines after declarations to adhere to the Linux kernel coding-style guidelines. These issues are reported by checkpatch.pl "CHECK: Please use a blank line after function/struct/union/enum declarations" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c6114d99829b..7144a0630ea6 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -231,10 +231,12 @@ rtllib_rx_frame_mgmt(struct rtllib_device *ieee, stru= ct sk_buff *skb, static unsigned char rfc1042_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 }; + /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */ static unsigned char bridge_tunnel_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 }; + /* No encapsulation header if EtherType < 0x600 (=3Dlength) */ =20 /* Called by rtllib_rx_frame_decrypt */ --=20 2.34.1 From nobody Thu May 2 02:10:16 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF75C76195 for ; Fri, 24 Mar 2023 22:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232369AbjCXWcl (ORCPT ); Fri, 24 Mar 2023 18:32:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231843AbjCXWcd (ORCPT ); Fri, 24 Mar 2023 18:32:33 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6391F1F919 for ; Fri, 24 Mar 2023 15:32:04 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id m2so3180509wrh.6 for ; Fri, 24 Mar 2023 15:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679697100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qfo0BLzIV++drYzkU45P3MSEyypvlv0tFWK+3aZYqRo=; b=f+GVk7b+IOCM+D2lg1fWQRomk+YEeS58qX88K/YYaVb7FZQT1Gmgn1F/+tGOEojQzr 3vHRTqeoPQNqg1eP0XEi1mWbuu+aSNIFi+XIoXfXuDzVKI2StL5mCVobAuAi9Ooc8kYO KdspqZFYYYwVsSzkUyq4gxYzf7y2j2gycPul+xoN7nqx1k0XrWeImtQtpKYbcO5Tm5To 0cCc/upAoqV3WzQgY6YD2js0KCEBHps8lysfFQSUPUKEz8ui/O55A9x9cIMX+iv/2PWe sj2s8zi7QW2iwCatm0VMffhouPd9Fp/McTedSQnWJY20SIJ9gNuHkKHIJOAGP2RxXHJe IB3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679697100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qfo0BLzIV++drYzkU45P3MSEyypvlv0tFWK+3aZYqRo=; b=u6xv/UhkPRRUcXG4u/W+5XqM1iMGYBaCnSlHs4dX6RqEKlDfayOxdzj2kdIaPxRfgf rHqfK7iIhjQ9onb64K4tLz2KpLorKhXicl5Dng7tfIYaId35Nz0TO5I+z/LuFqerXnzi rr4IeGc+nMoq/RFtNcXgnIz6b3t11KQIoL2bR43SjhDuwrmCJOX3PSGq8K4L5KhnAkRC ub0prGyqIRvScofuJ0TpzdBhHquHzuqKgaNcTfS9oK6sC5RxSntFVRXmb83+8GWk6CMv HdKAFp1vfzdcFZ8PtdU6Az+JXXHHaRhyvxt/7TfNEQX2Vzwrv/A82T5hYrsouSLpG5/4 5Pqw== X-Gm-Message-State: AAQBX9dGoJYJqe4XdmJvlK45LIl92gUYt7MQOqo4v0DTV4WNi8ctZwS7 M+HQV6z1zo+/8SEHwaJPsb8= X-Google-Smtp-Source: AKy350ZwbZtAyJ4Plf4KpwqcjyscxgI9h5gs6KY+Q29SeU612VY/cbQNrA63O87a3RvyyBRTKvzqCw== X-Received: by 2002:a5d:58d4:0:b0:2da:650f:4517 with SMTP id o20-20020a5d58d4000000b002da650f4517mr3196262wrf.30.1679697100081; Fri, 24 Mar 2023 15:31:40 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id d7-20020adffbc7000000b002d5a8d8442asm14984138wrs.37.2023.03.24.15.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:31:39 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 3/4] staging: rtl8192e: add spaces around binary operators Date: Sat, 25 Mar 2023 03:31:30 +0500 Message-Id: <44a545cf8e99ebfdbfc3f5bb314f3828abe98558.1679696777.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use spaces around binary operators as suggested by Linux kernel coding style guidelines. Issues reported by checkpatch.pl for the following binary operators: + , - , * , | , << Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 54 ++++++++++++++-------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 7144a0630ea6..f627dfe66d90 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -356,7 +356,7 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, } =20 /* this function is stolen from ipw2200 driver*/ -#define IEEE_PACKET_RETRY_TIME (5*HZ) +#define IEEE_PACKET_RETRY_TIME (5 * HZ) static int is_duplicate_packet(struct rtllib_device *ieee, struct rtllib_hdr_4addr *header) { @@ -936,7 +936,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, =20 if (GetTs(ieee, (struct ts_common_info **)&pRxTS, hdr->addr2, (u8)Frame_QoSTID((u8 *)(skb->data)), RX_DIR, true)) { - if ((fc & (1<<11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && + if ((fc & (1 << 11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && (WLAN_GET_SEQ_SEQ(sc) =3D=3D pRxTS->rx_last_seq_num)) return -1; pRxTS->rx_last_frag_num =3D frag; @@ -1619,23 +1619,23 @@ static int rtllib_qos_convert_ac_to_parameters(stru= ct rtllib_qos_parameter_info case 1: /* BIT(0) | BIT(3) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<0)|(0x01<<3); + qos_data->wmm_acm |=3D (0x01 << 0) | (0x01 << 3); break; case 2: /* BIT(4) | BIT(5) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<4)|(0x01<<5); + qos_data->wmm_acm |=3D (0x01 << 4) | (0x01 << 5); break; case 3: /* BIT(6) | BIT(7) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<6)|(0x01<<7); + qos_data->wmm_acm |=3D (0x01 << 6) | (0x01 << 7); break; case 0: default: /* BIT(1) | BIT(2) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<1)|(0x01<<2); + qos_data->wmm_acm |=3D (0x01 << 1) | (0x01 << 2); break; } =20 @@ -1979,7 +1979,7 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[3] =3D=3D 0x04) { netdev_dbg(ieee->dev, "MFIE_TYPE_WZC: %d bytes\n", info_element->len); - network->wzc_ie_len =3D min(info_element->len+2, MAX_WZC_IE_LEN); + network->wzc_ie_len =3D min(info_element->len + 2, MAX_WZC_IE_LEN); memcpy(network->wzc_ie, info_element, network->wzc_ie_len); } } @@ -2139,10 +2139,10 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; =20 - offset =3D (info_element->data[2] >> 1)*2; + offset =3D (info_element->data[2] >> 1) * 2; =20 - if (ieee->assoc_id < 8*offset || - ieee->assoc_id > 8*(offset + info_element->len - 3)) + if (ieee->assoc_id < 8 * offset || + ieee->assoc_id > 8 * (offset + info_element->len - 3)) break; =20 offset =3D (ieee->assoc_id / 8) - offset; @@ -2357,7 +2357,7 @@ static inline int rtllib_network_init( if (rtllib_is_empty_essid(network->ssid, network->ssid_len)) network->flags |=3D NETWORK_EMPTY_ESSID; stats->signal =3D 30 + (stats->SignalStrength * 70) / 100; - stats->noise =3D rtllib_translate_todbm((u8)(100-stats->signal)) - 25; + stats->noise =3D rtllib_translate_todbm((u8)(100 - stats->signal)) - 25; =20 memcpy(&network->stats, stats, sizeof(network->stats)); =20 @@ -2545,22 +2545,22 @@ static inline void rtllib_process_probe_response( "'%s' ( %pM ): %c%c%c%c %c%c%c%c-%c%c%c%c %c%c%c%c\n", escape_essid(info_element->data, info_element->len), beacon->header.addr3, - (le16_to_cpu(beacon->capability) & (1<<0xf)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xe)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xd)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xc)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xb)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xa)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x9)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x8)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x7)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x6)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x5)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x4)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x3)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x2)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x1)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x0)) ? '1' : '0'); + (le16_to_cpu(beacon->capability) & (1 << 0xf)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xe)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xd)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xc)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xb)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xa)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x9)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x8)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x7)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x6)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x5)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x4)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x3)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x2)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x1)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x0)) ? '1' : '0'); =20 if (rtllib_network_init(ieee, beacon, network, stats)) { netdev_dbg(ieee->dev, "Dropped '%s' ( %pM) via %s.\n", --=20 2.34.1 From nobody Thu May 2 02:10:16 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA313C6FD1C for ; Fri, 24 Mar 2023 22:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232410AbjCXWco (ORCPT ); Fri, 24 Mar 2023 18:32:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232251AbjCXWce (ORCPT ); Fri, 24 Mar 2023 18:32:34 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBE2F17163 for ; Fri, 24 Mar 2023 15:32:06 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id r29so3154532wra.13 for ; Fri, 24 Mar 2023 15:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679697102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bmc+Yh3XTUiALV4q5vVltlntUVE9IZwmAKsrbcMIn8E=; b=TOehl8DELE79NdFccOToF+06ibX42eREC2NRuACv6k+1L5EILYAaJ7eaGX9WtfZZxg uH1lZE6QJMgtcXHVjDgZX7zSSBfw/3S1nfZWPB/PN2n97Omf9frrDP07axSF+nsSqDPI D8/wzXBg+IZsIfSQ0KvQ6KAuNXjD5CYIAf0JmUIO3fvPNuJb6f3HDwvull2tHzh2Qrg1 QMmEemNJgr3lGUqPE+jlAh4LTFuBBCvI8fga+jlnSSy1f8j03ZU1boQoE47EgQUYTFqJ jEGJ4b5t5CyKAZYJJHcGzY/iJErLw+VbUUtFG0IWQc9N12pxwFu3cpXH4ylBgbfSH6gC zihA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679697102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmc+Yh3XTUiALV4q5vVltlntUVE9IZwmAKsrbcMIn8E=; b=wRGFVCOk8VUZj2ma/Yd+OK4XbqYjAuXgbbh9Jywck37PlQoaDtnjaNUKRQdMLPzgII XKCQOwBQDhLHr0FkymtvTYlPUtv9JUb7Q7pkGt95Jwq4GYACfhQ636N81dWrIeUVrwWB 4eqUbSzJTRf5DLfAlHX8qQuMwpvwAcZYA8JL/F0mpfBw+ICpyasu6ickPzSKA9q++IbB sEaADIGwxJlRmpOYcacU5lie5dysc0dsojl84AvTRhjlZxMPsDL48CJi0xpJ/4MSg+zk tP1qt7f6ERhIu9w5MsXAJGFH27VPkVsIrt12dIREqb4WbrziIFqXhrDdpV2Dy8Ks7cv+ DGyg== X-Gm-Message-State: AAQBX9cBJK0Uze2GH7pHP/+1u2tyKuc5KSzz7FXJWeoffFLn+kQFCB1R 0en7fuuKHIi6USnAeGsWWq8= X-Google-Smtp-Source: AKy350YW+ObTwB8qFEBil0ujwjLpj3qCbbiuQ6mZyifEicheKw+4GJ68D+e0FKPwPpuhRJ62pVsF/g== X-Received: by 2002:adf:e683:0:b0:2ce:ae5b:27a2 with SMTP id r3-20020adfe683000000b002ceae5b27a2mr3107845wrm.17.1679697101860; Fri, 24 Mar 2023 15:31:41 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id d7-20020adffbc7000000b002d5a8d8442asm14984138wrs.37.2023.03.24.15.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:31:41 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 4/4] staging: rtl8192e: remove blank lines after '{' Date: Sat, 25 Mar 2023 03:31:31 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unnecessary blank lines after an open brace to adhere to the Linux kernel coding-style guidelines. These issues are reported by checkpatch.pl "CHECK: Blank lines aren't necessary after an open brace '{'" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index f627dfe66d90..b649d02dc5c8 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1167,7 +1167,6 @@ static int rtllib_rx_decrypt(struct rtllib_device *ie= ee, struct sk_buff *skb, if (crypt && !(fc & RTLLIB_FCTL_WEP) && !ieee->open_wep) { if (/*ieee->ieee802_1x &&*/ rtllib_is_eapol_frame(ieee, skb, hdrlen)) { - /* pass unencrypted EAPOL frames even if encryption is * configured */ @@ -1207,7 +1206,6 @@ static void rtllib_rx_check_leave_lps(struct rtllib_d= evice *ieee, u8 unicast, u8 nr_subframes) { if (unicast) { - if (ieee->state =3D=3D RTLLIB_LINKED) { if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) > 8) || @@ -1552,7 +1550,6 @@ static u8 qos_oui[QOS_OUI_LEN] =3D { 0x00, 0x50, 0xF2= }; static int rtllib_verify_qos_info(struct rtllib_qos_information_element *info_element, int sub_type) { - if (info_element->elementID !=3D QOS_ELEMENT_ID) return -1; if (info_element->qui_subtype !=3D sub_type) @@ -2696,7 +2693,6 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee, ieee->last_rx_ps_time =3D jiffies; =20 switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))) { - case RTLLIB_STYPE_BEACON: netdev_dbg(ieee->dev, "received BEACON (%d)\n", WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))); --=20 2.34.1