From nobody Mon May 6 22:24:31 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36377C76195 for ; Fri, 24 Mar 2023 22:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231977AbjCXWKF (ORCPT ); Fri, 24 Mar 2023 18:10:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231693AbjCXWKA (ORCPT ); Fri, 24 Mar 2023 18:10:00 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 099F3C2 for ; Fri, 24 Mar 2023 15:09:59 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id l27so3162528wrb.2 for ; Fri, 24 Mar 2023 15:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679695797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qHW/CyCQWbbVJjXUcNnqunHcb5Z7BkaW2HblBqM5Qy8=; b=P8OaKsVj8aVBbGfD44ArWKOkdXCKP4ihm+EBz8j6hFS/77+OnOC+rb1B321webTsN3 kNl5ixQm2p5+I4JBMST/4+5NW9LEeffyRP2UlKs46HsGp+S6Lfny7yOsBMGK2tKy9+wN 0VoteDOVJRtrL96nIJPhnA59RVIL4ua2ACnPyOpoBVSOn8CNeHjvu1OgRpHOp2W/EtlR DeubsbdrOiwOtmn4KhxbTfLaqPJnqekJIMmf54U8858WxQxwP50++wp0h98wWdngWj33 hpIZwcZTs0e5MvOTtmSD5TLPyFsWJtk/3TEvEnTAi7T6jd1pvxTdX0ajh9Hdenkqa2tX Hsvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679695797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qHW/CyCQWbbVJjXUcNnqunHcb5Z7BkaW2HblBqM5Qy8=; b=ET/bENtSYEU+uWBTHg9gtXCARM3n9ZgBdIGpAXWZWZrUHPBK5TzTmSdnc1Z7Xw8UKZ pIaPfKHRDihZdPOY33u/PVz4UnyL3TZcaj+YYqkgZhns2VE2EtUjQ5J1vZ3BQa6iwwd1 oeW98xZtMy0wm1fr0Yfn6HtiCwRL8qxbYJ4OcLbxFShVZnWd1HFJJjwANvdP3Fqzzpf1 3x0UEyTW3u5TzWwGbRIxG+Xt2tSRU7eXUOFlaJA9Bt+XFlUL/4zIanebD/7/HXsbgTFh UfzqxiMek02Zf0lzYQ2GMSHhT47u2ynb3kyDk0TsuFNaRZewI/AeXNUkLHpOWl8QhISa kQAA== X-Gm-Message-State: AAQBX9c1t3qUSBiRZ7syEqUypQkn9Zd+2CiGzdUwVN5eQSHY/orTkosA L2Y+K/lBTZ9lhy8SqsdG5AUNprejrNvv13vt X-Google-Smtp-Source: AKy350bv17FwvgoxD59q8/VBlKC/zE+cjJOKqNKrhpDnqxwyw8eiQV8Nh5Xzg6YWbmjIpYSO1opkTQ== X-Received: by 2002:a5d:58e9:0:b0:2d1:87f:2cd1 with SMTP id f9-20020a5d58e9000000b002d1087f2cd1mr3876648wrd.25.1679695797489; Fri, 24 Mar 2023 15:09:57 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id x12-20020a5d650c000000b002c5544b3a69sm19201736wru.89.2023.03.24.15.09.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:09:57 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/4] staging: rtl8192e: remove extra blank lines Date: Sat, 25 Mar 2023 03:09:48 +0500 Message-Id: <6d7388f944e8296227269c7472a462ea7c94149c.1679695111.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the extra blank line in accordance with the Linux kernel coding-style regulations. These issues were reported by checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c394c21beefb..c6114d99829b 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -154,7 +154,6 @@ rtllib_frag_cache_get(struct rtllib_device *ieee, return skb; } =20 - /* Called only as a tasklet (software IRQ) */ static int rtllib_frag_cache_invalidate(struct rtllib_device *ieee, struct rtllib_hdr_4addr *hdr) @@ -318,7 +317,6 @@ rtllib_rx_frame_decrypt(struct rtllib_device *ieee, str= uct sk_buff *skb, return res; } =20 - /* Called only as a tasklet (software IRQ), by rtllib_rx */ static inline int rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee, struct sk_buff *s= kb, @@ -355,7 +353,6 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, return 0; } =20 - /* this function is stolen from ipw2200 driver*/ #define IEEE_PACKET_RETRY_TIME (5*HZ) static int is_duplicate_packet(struct rtllib_device *ieee, @@ -887,7 +884,6 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, return rxb->nr_subframes; } =20 - static size_t rtllib_rx_get_hdrlen(struct rtllib_device *ieee, struct sk_buff *skb, struct rtllib_rx_stats *rx_stats) @@ -1569,7 +1565,6 @@ static int rtllib_verify_qos_info(struct rtllib_qos_i= nformation_element return 0; } =20 - /* Parse a QoS parameter element */ static int rtllib_read_qos_param_element( struct rtllib_qos_parameter_info *element_param, @@ -1599,7 +1594,6 @@ static int rtllib_read_qos_info_element( return rtllib_verify_qos_info(element_info, QOS_OUI_INFO_SUB_TYPE); } =20 - /* Write QoS parameters from the ac parameters. */ static int rtllib_qos_convert_ac_to_parameters(struct rtllib_qos_parameter= _info *param_elm, struct rtllib_qos_data *qos_data) @@ -1843,7 +1837,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, } } =20 - if (*tmp_htinfo_len =3D=3D 0) { if (info_element->len >=3D 4 && info_element->data[0] =3D=3D 0x00 && @@ -1932,7 +1925,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[2] =3D=3D 0x96) network->cisco_cap_exist =3D true; =20 - if (info_element->len >=3D 3 && info_element->data[0] =3D=3D 0x00 && info_element->data[1] =3D=3D 0x0a && @@ -2142,13 +2134,11 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, =20 network->dtim_data =3D RTLLIB_DTIM_VALID; =20 - if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; =20 offset =3D (info_element->data[2] >> 1)*2; =20 - if (ieee->assoc_id < 8*offset || ieee->assoc_id > 8*(offset + info_element->len - 3)) break; @@ -2203,7 +2193,6 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, &tmp_htcap_len); break; =20 - case MFIE_TYPE_HT_INFO: netdev_dbg(ieee->dev, "MFIE_TYPE_HT_INFO: %d bytes\n", info_element->len); @@ -2392,7 +2381,6 @@ static inline int is_same_network(struct rtllib_netwo= rk *src, (dst->capability & WLAN_CAPABILITY_ESS))); } =20 - static inline void update_network(struct rtllib_device *ieee, struct rtllib_network *dst, struct rtllib_network *src) @@ -2580,7 +2568,6 @@ static inline void rtllib_process_probe_response( goto free_network; } =20 - if (!rtllib_legal_channel(ieee, network->channel)) goto free_network; =20 --=20 2.34.1 From nobody Mon May 6 22:24:31 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A39C3C76196 for ; Fri, 24 Mar 2023 22:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232115AbjCXWKI (ORCPT ); Fri, 24 Mar 2023 18:10:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbjCXWKB (ORCPT ); Fri, 24 Mar 2023 18:10:01 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4C77C2 for ; Fri, 24 Mar 2023 15:10:00 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id m2so3147633wrh.6 for ; Fri, 24 Mar 2023 15:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679695799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3Mi0Pc446/hNZjoA2whb7pVis3I9iPt8Xg8w3eBefMA=; b=C3lIZ59MI/zpkajBX1d9LTgxSG0qzcXP1h+ypEYFxHDSerYuKyU6WuRbqGvsqVwkWG bVKnIyc7XZyJMQMG2fSsGEpnGiRA6bOjwuGcTJebMtW4h9r7kiPDwdRLT6MzKr5sZLUj un40BwtzlLI4OQO5VoeIORjX5D8D3HXVajTHXhBFRMcAtsc69aZ728a9N7elA918E/bg IHq9Y2kKMBvQbVswxQ2AZOcchbQLGOEPGf1Lrr7MnzPz6fspsEAQFjjWMo+XvvM9KZwH hihL/buxOeshSk+P1ZoNYRrZ9wMsVXbqYFRWKc11O4DDMgj6BDbQ7901xCnOWRew3JVe q9Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679695799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Mi0Pc446/hNZjoA2whb7pVis3I9iPt8Xg8w3eBefMA=; b=DCnE/x9JfmU+WkRECLfpCNARrZdLHI0meCPmbreIRn3FokPOzpIKnfZUWdDCC7tuAa sMnOECh3QzK6Df7Hz4oivR8YUVKteJFjxfrNVsfbg4yzxwJ3o0IAeaoavVVr6TT8Yd4G 0Ki2XgqzLpIJmeEOvzm4InSFDPuziKwhwZZ8b7Jiha78mxGqwYbEAe7Sd+aufe3oRzyM N43GIBsyNxCmhVpKTgwykaagewEmgQzMENiGBaUfE/PIeWBXV9ImL6yy4g/IT96R1P9G p0OAc5clt3xWxkYZgcbcDxYi6dj9Yr/EACI5OfAAj2kSoo/BZK6GwznrAEx5PYU6qVuK m6tw== X-Gm-Message-State: AAQBX9cgdcd8izOzHnx3j6zF5a9Uvj5xhmdvYDL+mRbx3MPzoNrTlaXp EtrwKtjLNCwS0K9Pp6qeIAm41+CWDirl2ORL X-Google-Smtp-Source: AKy350YjgZrnou6wBPTuCWPpZ2H5j5+SSAl4aMmQtvh8CHcJPd8u2xbM00+091JwSq+cRGDa5f1KbA== X-Received: by 2002:adf:e90b:0:b0:2d4:751d:675b with SMTP id f11-20020adfe90b000000b002d4751d675bmr3330504wrm.35.1679695799202; Fri, 24 Mar 2023 15:09:59 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id x12-20020a5d650c000000b002c5544b3a69sm19201736wru.89.2023.03.24.15.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:09:58 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/4] staging: rtl8192e: add blank lines after declarations Date: Sat, 25 Mar 2023 03:09:49 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add blank lines after declarations to adhere to the Linux kernel coding-style guidelines. These issues are reported by checkpatch.pl "CHECK: Please use a blank line after function/struct/union/enum declarations" Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c6114d99829b..7144a0630ea6 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -231,10 +231,12 @@ rtllib_rx_frame_mgmt(struct rtllib_device *ieee, stru= ct sk_buff *skb, static unsigned char rfc1042_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 }; + /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */ static unsigned char bridge_tunnel_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 }; + /* No encapsulation header if EtherType < 0x600 (=3Dlength) */ =20 /* Called by rtllib_rx_frame_decrypt */ --=20 2.34.1 From nobody Mon May 6 22:24:31 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B3FAC6FD1C for ; Fri, 24 Mar 2023 22:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232305AbjCXWKL (ORCPT ); Fri, 24 Mar 2023 18:10:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231877AbjCXWKC (ORCPT ); Fri, 24 Mar 2023 18:10:02 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947E517163 for ; Fri, 24 Mar 2023 15:10:01 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id y14so3153564wrq.4 for ; Fri, 24 Mar 2023 15:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679695801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qfo0BLzIV++drYzkU45P3MSEyypvlv0tFWK+3aZYqRo=; b=KtRipMNnMTzFh6YP+ZewZkDVdWFPWdmQNvW2BUoxsf6putKXIz5vH1Jj5xlZl8QlHh vpiZ/cKS7qt2tCSA/h4ZGfzMygg1M67OtsNwHsSyNJmjCS89wnFK1l+U+Pt0M1P4gG1l /9AKwxX6UroisK+aOB8wompussx6ltDKozwBbVaBqbjE0uFjhCcak1dClPceRKEbpWD4 HRYHrgvKIFi+3enJOxOKt79mwhd9Xj2eYhfzkOoD4570oLix5hdOCroY8Cb+MUCPNknn 2dYjaqELlE2ihyeNUHILmUb+aSHthhphWdGiU6ySi7cvlMMkcIXBTpJtTiYMeJaDNk6v CyMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679695801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qfo0BLzIV++drYzkU45P3MSEyypvlv0tFWK+3aZYqRo=; b=THf5oCJLAaeb5Vj2P0J2ExBK+s75iszQnX3mFAxGAfeZHfs5OyB6pVoE5Z4QtEo5Mu dP1kDKDS1MR0/yK6yi+u3IXuMIrOzPzPm/NMFLRtzhj3M6tnsa+kKIoeM1jHmt1gglcC htPdLIglXmYna6mEOh3INXbJDKJE1oVlA6g8YXnGkDuSJgJX0vLKjFJBJ6ORXwQ4qklT ufsKRShrTt4/EUQ1+pwWJm/0RMX3s6mMzokMdJ1QYhqb7hBskslcKCmcvYhfmYRg2Mm9 vAE9zvleCHAygHuwx+hdixpw978NZG/vhxfyb39L/cb4+E8ca8q6U84kDo1qmIj7l2yO R5Hg== X-Gm-Message-State: AAQBX9evwP92r0knsZlWPk+Y3Q9n370Zhl/t48K0YHgO/RsrZGkaXPve Ex6v9zrWW/F/FTQieLXkXF0b954cvLfcMvZ3 X-Google-Smtp-Source: AKy350aUi8rQQNrDCDHt6Jzk5bH1w5SVaxnL2V6tvNKMPfg/C7/im46sk7mSayhIKLhrR1SWmGFNZw== X-Received: by 2002:a5d:4a89:0:b0:2ce:a835:83d4 with SMTP id o9-20020a5d4a89000000b002cea83583d4mr2787755wrq.27.1679695800886; Fri, 24 Mar 2023 15:10:00 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id x12-20020a5d650c000000b002c5544b3a69sm19201736wru.89.2023.03.24.15.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:10:00 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/4] staging: rtl8192e: add spaces around binary operators Date: Sat, 25 Mar 2023 03:09:50 +0500 Message-Id: <44a545cf8e99ebfdbfc3f5bb314f3828abe98558.1679695111.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use spaces around binary operators as suggested by Linux kernel coding style guidelines. Issues reported by checkpatch.pl for the following binary operators: + , - , * , | , << Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 54 ++++++++++++++-------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 7144a0630ea6..f627dfe66d90 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -356,7 +356,7 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, } =20 /* this function is stolen from ipw2200 driver*/ -#define IEEE_PACKET_RETRY_TIME (5*HZ) +#define IEEE_PACKET_RETRY_TIME (5 * HZ) static int is_duplicate_packet(struct rtllib_device *ieee, struct rtllib_hdr_4addr *header) { @@ -936,7 +936,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, =20 if (GetTs(ieee, (struct ts_common_info **)&pRxTS, hdr->addr2, (u8)Frame_QoSTID((u8 *)(skb->data)), RX_DIR, true)) { - if ((fc & (1<<11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && + if ((fc & (1 << 11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && (WLAN_GET_SEQ_SEQ(sc) =3D=3D pRxTS->rx_last_seq_num)) return -1; pRxTS->rx_last_frag_num =3D frag; @@ -1619,23 +1619,23 @@ static int rtllib_qos_convert_ac_to_parameters(stru= ct rtllib_qos_parameter_info case 1: /* BIT(0) | BIT(3) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<0)|(0x01<<3); + qos_data->wmm_acm |=3D (0x01 << 0) | (0x01 << 3); break; case 2: /* BIT(4) | BIT(5) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<4)|(0x01<<5); + qos_data->wmm_acm |=3D (0x01 << 4) | (0x01 << 5); break; case 3: /* BIT(6) | BIT(7) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<6)|(0x01<<7); + qos_data->wmm_acm |=3D (0x01 << 6) | (0x01 << 7); break; case 0: default: /* BIT(1) | BIT(2) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<1)|(0x01<<2); + qos_data->wmm_acm |=3D (0x01 << 1) | (0x01 << 2); break; } =20 @@ -1979,7 +1979,7 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[3] =3D=3D 0x04) { netdev_dbg(ieee->dev, "MFIE_TYPE_WZC: %d bytes\n", info_element->len); - network->wzc_ie_len =3D min(info_element->len+2, MAX_WZC_IE_LEN); + network->wzc_ie_len =3D min(info_element->len + 2, MAX_WZC_IE_LEN); memcpy(network->wzc_ie, info_element, network->wzc_ie_len); } } @@ -2139,10 +2139,10 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; =20 - offset =3D (info_element->data[2] >> 1)*2; + offset =3D (info_element->data[2] >> 1) * 2; =20 - if (ieee->assoc_id < 8*offset || - ieee->assoc_id > 8*(offset + info_element->len - 3)) + if (ieee->assoc_id < 8 * offset || + ieee->assoc_id > 8 * (offset + info_element->len - 3)) break; =20 offset =3D (ieee->assoc_id / 8) - offset; @@ -2357,7 +2357,7 @@ static inline int rtllib_network_init( if (rtllib_is_empty_essid(network->ssid, network->ssid_len)) network->flags |=3D NETWORK_EMPTY_ESSID; stats->signal =3D 30 + (stats->SignalStrength * 70) / 100; - stats->noise =3D rtllib_translate_todbm((u8)(100-stats->signal)) - 25; + stats->noise =3D rtllib_translate_todbm((u8)(100 - stats->signal)) - 25; =20 memcpy(&network->stats, stats, sizeof(network->stats)); =20 @@ -2545,22 +2545,22 @@ static inline void rtllib_process_probe_response( "'%s' ( %pM ): %c%c%c%c %c%c%c%c-%c%c%c%c %c%c%c%c\n", escape_essid(info_element->data, info_element->len), beacon->header.addr3, - (le16_to_cpu(beacon->capability) & (1<<0xf)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xe)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xd)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xc)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xb)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xa)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x9)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x8)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x7)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x6)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x5)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x4)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x3)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x2)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x1)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x0)) ? '1' : '0'); + (le16_to_cpu(beacon->capability) & (1 << 0xf)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xe)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xd)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xc)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xb)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xa)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x9)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x8)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x7)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x6)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x5)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x4)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x3)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x2)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x1)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x0)) ? '1' : '0'); =20 if (rtllib_network_init(ieee, beacon, network, stats)) { netdev_dbg(ieee->dev, "Dropped '%s' ( %pM) via %s.\n", --=20 2.34.1 From nobody Mon May 6 22:24:31 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C197C6FD1C for ; Fri, 24 Mar 2023 22:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231801AbjCXWKO (ORCPT ); Fri, 24 Mar 2023 18:10:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231985AbjCXWKF (ORCPT ); Fri, 24 Mar 2023 18:10:05 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DEC51F5C1 for ; Fri, 24 Mar 2023 15:10:04 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id i9so3160804wrp.3 for ; Fri, 24 Mar 2023 15:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679695802; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bmc+Yh3XTUiALV4q5vVltlntUVE9IZwmAKsrbcMIn8E=; b=bNPlIuYIBzrqhtaoy7xHmivpmU2OfSBWDYwRCu1ODldBBcHsmid5AeRgr7TiYc6p0H ZsiQFUqvyW9lYRiLcARM4JpKj6backof5tP9hyFQ72Db/gtBmusvPj57j+c0tfDGRJiO gp7nI9A5/sOHYU8x7D8WdiN4jFXM5/GpI6uhqPBMXik+LVROMKCXK1zTFIoRpfYEyUAD iBXhnXQGucRLIfx867s1r7vrrJmiUxtB1YxKrdXVJANyXMVTqxaFek+ArcBq/FsI+6Bm 6cyFRw6NicPPYaCjNaMJDCMCw2OOCNN0vxDQRRgrlmLFlU1/EgXhmw3hiqgCvdt2ZXl0 Y3RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679695802; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmc+Yh3XTUiALV4q5vVltlntUVE9IZwmAKsrbcMIn8E=; b=0hUHgJGXFJALFKabL2a/XP7T0fF/b024yWkazWV4e0FPpcDBPIxltRvk7wC9RoIoK/ HhNNkTfBtjyzS2ouYb6Hd3+HJIyzpBDATkboe9W/dAmn7YOYI2SLGjTQGuw3ud6dvu91 xmBNvAwNh1fDOOGPxkC4ye71zNfzNTQFXZDRroWgM0Oa+kBcdNj5Co0ygRwdDNR3/bhX E5qzyCQBusavYdituzIdEzVf1xWs8gBTCNPbLRVbnl7EFEHvbkdnGe2cuT7dM79FP6q8 iK4pLG//SJv8/RbE7a3fGiy9hviXpsYND1AoZtZugA0GINSrz9A9O8MTd46WYSYf2vHD Ep2A== X-Gm-Message-State: AAQBX9cN1JYTOtHPSzg8EkLY8znxBMqtmYD6RIxf12ASiSEFFS0HUqqd V0LZ0rmQoI4JsPTzzXWjTLY= X-Google-Smtp-Source: AKy350Yk6TS348ocuPvtjqqhydMRLE5llnNXAN4RasfwNkcS/+7lIDOzkZt6YHeIH7cxc7jtilwDhA== X-Received: by 2002:adf:f887:0:b0:2ce:a9e9:4905 with SMTP id u7-20020adff887000000b002cea9e94905mr3875825wrp.34.1679695802535; Fri, 24 Mar 2023 15:10:02 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id x12-20020a5d650c000000b002c5544b3a69sm19201736wru.89.2023.03.24.15.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:10:02 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/4] staging: rtl8192e: remove blank lines after '{' Date: Sat, 25 Mar 2023 03:09:51 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unnecessary blank lines after an open brace to adhere to the Linux kernel coding-style guidelines. These issues are reported by checkpatch.pl "CHECK: Blank lines aren't necessary after an open brace '{'" Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index f627dfe66d90..b649d02dc5c8 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1167,7 +1167,6 @@ static int rtllib_rx_decrypt(struct rtllib_device *ie= ee, struct sk_buff *skb, if (crypt && !(fc & RTLLIB_FCTL_WEP) && !ieee->open_wep) { if (/*ieee->ieee802_1x &&*/ rtllib_is_eapol_frame(ieee, skb, hdrlen)) { - /* pass unencrypted EAPOL frames even if encryption is * configured */ @@ -1207,7 +1206,6 @@ static void rtllib_rx_check_leave_lps(struct rtllib_d= evice *ieee, u8 unicast, u8 nr_subframes) { if (unicast) { - if (ieee->state =3D=3D RTLLIB_LINKED) { if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) > 8) || @@ -1552,7 +1550,6 @@ static u8 qos_oui[QOS_OUI_LEN] =3D { 0x00, 0x50, 0xF2= }; static int rtllib_verify_qos_info(struct rtllib_qos_information_element *info_element, int sub_type) { - if (info_element->elementID !=3D QOS_ELEMENT_ID) return -1; if (info_element->qui_subtype !=3D sub_type) @@ -2696,7 +2693,6 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee, ieee->last_rx_ps_time =3D jiffies; =20 switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))) { - case RTLLIB_STYPE_BEACON: netdev_dbg(ieee->dev, "received BEACON (%d)\n", WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))); --=20 2.34.1