From nobody Sat Feb 7 17:55:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B44B4C76196 for ; Thu, 23 Mar 2023 19:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbjCWTUP (ORCPT ); Thu, 23 Mar 2023 15:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbjCWTUL (ORCPT ); Thu, 23 Mar 2023 15:20:11 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 968D083E6 for ; Thu, 23 Mar 2023 12:20:09 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id h8so91165111ede.8 for ; Thu, 23 Mar 2023 12:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679599208; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2qlJwucxS9YsM3710vjGoZ2YHREnKLXbsqoSCiO7TnI=; b=PsuTEuVki59XvlIOe683IH21N2h3cwEZY2drskLXIGwugdNSh38u6C+x8s02j8NfV0 Yizqxtb8CgKZgvaBfAYH0VoXODjt+F1WcjD/OS60F9QWSuOkokokuKzVTpI5eqWwOAP5 Nc80OqwiM9YaTqSBlrI82KfzVGyAobA8zVLP1D/UMf6HFkvnmyB3H9fH6fWIn0qjy/20 uOQxVpjriETGw7WFXWDJUaS7XMrV8rmAp9hnLI6YKCRZVsTjqi2mhfarIfCIyMQzimcX w7LRytJSypb44ZAtP8Xxjo5pmYU2onkBChPsiBhVBpZ71WiSLS3oIvhkU8CkorbwoaSY fQHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679599208; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2qlJwucxS9YsM3710vjGoZ2YHREnKLXbsqoSCiO7TnI=; b=lZYRE1OzmEqAA/eVJMt52Zl7B1BchiUM+SdcM5qqVQxbSnDrdTYPYSQJVwik7wHfzc OhHl46Zu3zHyLXELHcRZfeApcq8QkHm0hsHM+QtgL1tssdB/CWaUAqb7REcqlmxqy462 fLXnWRJFT82ovIKgJL6v5jLcvTcnYa1RA3JkW4dEg0pJ5gtQoT+ewNWSpfbdXGzvHNip jYjNAF4kkFyAC6IfVZWJDI9dzkxbqGUXo+2tse2D6i+2jwsaSAIDGYLcFMCy0eHt+mlW QK8ze+K/U+v4tNySp3UTD03lWmf4Vce4PhMC2aeZkMg5Q+Oj4HaaIKUkQ7yG8C39qeKD O2ig== X-Gm-Message-State: AAQBX9dEwhna4AH9ef1a+xHuZ25EcS7LVI21lL9tsZ5DtISFJlU17y5U PT1pBStSzY2K/J3xd4n7LVzw6zsJ6wfWT4pF X-Google-Smtp-Source: AKy350bf0NJcNtyMw1PGl1+fYaOTcrduaQMD+oQUX44CrbV6JT++QGPCa4Fkie7tUhjHP7LVwzInrA== X-Received: by 2002:a17:906:32d6:b0:931:f8b2:c7a0 with SMTP id k22-20020a17090632d600b00931f8b2c7a0mr119045ejk.43.1679599207999; Thu, 23 Mar 2023 12:20:07 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id ia9-20020a170907a06900b00932b3e2c015sm8161409ejc.51.2023.03.23.12.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 12:20:07 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] staging: rtl8192e: remove extra blank lines Date: Fri, 24 Mar 2023 00:19:59 +0500 Message-Id: <43d5864fc42e51089a0a0626278204bac8313eb0.1679598576.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove extra blank lines as reported by checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c394c21beefb..c6114d99829b 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -154,7 +154,6 @@ rtllib_frag_cache_get(struct rtllib_device *ieee, return skb; } =20 - /* Called only as a tasklet (software IRQ) */ static int rtllib_frag_cache_invalidate(struct rtllib_device *ieee, struct rtllib_hdr_4addr *hdr) @@ -318,7 +317,6 @@ rtllib_rx_frame_decrypt(struct rtllib_device *ieee, str= uct sk_buff *skb, return res; } =20 - /* Called only as a tasklet (software IRQ), by rtllib_rx */ static inline int rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee, struct sk_buff *s= kb, @@ -355,7 +353,6 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, return 0; } =20 - /* this function is stolen from ipw2200 driver*/ #define IEEE_PACKET_RETRY_TIME (5*HZ) static int is_duplicate_packet(struct rtllib_device *ieee, @@ -887,7 +884,6 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, return rxb->nr_subframes; } =20 - static size_t rtllib_rx_get_hdrlen(struct rtllib_device *ieee, struct sk_buff *skb, struct rtllib_rx_stats *rx_stats) @@ -1569,7 +1565,6 @@ static int rtllib_verify_qos_info(struct rtllib_qos_i= nformation_element return 0; } =20 - /* Parse a QoS parameter element */ static int rtllib_read_qos_param_element( struct rtllib_qos_parameter_info *element_param, @@ -1599,7 +1594,6 @@ static int rtllib_read_qos_info_element( return rtllib_verify_qos_info(element_info, QOS_OUI_INFO_SUB_TYPE); } =20 - /* Write QoS parameters from the ac parameters. */ static int rtllib_qos_convert_ac_to_parameters(struct rtllib_qos_parameter= _info *param_elm, struct rtllib_qos_data *qos_data) @@ -1843,7 +1837,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, } } =20 - if (*tmp_htinfo_len =3D=3D 0) { if (info_element->len >=3D 4 && info_element->data[0] =3D=3D 0x00 && @@ -1932,7 +1925,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[2] =3D=3D 0x96) network->cisco_cap_exist =3D true; =20 - if (info_element->len >=3D 3 && info_element->data[0] =3D=3D 0x00 && info_element->data[1] =3D=3D 0x0a && @@ -2142,13 +2134,11 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, =20 network->dtim_data =3D RTLLIB_DTIM_VALID; =20 - if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; =20 offset =3D (info_element->data[2] >> 1)*2; =20 - if (ieee->assoc_id < 8*offset || ieee->assoc_id > 8*(offset + info_element->len - 3)) break; @@ -2203,7 +2193,6 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, &tmp_htcap_len); break; =20 - case MFIE_TYPE_HT_INFO: netdev_dbg(ieee->dev, "MFIE_TYPE_HT_INFO: %d bytes\n", info_element->len); @@ -2392,7 +2381,6 @@ static inline int is_same_network(struct rtllib_netwo= rk *src, (dst->capability & WLAN_CAPABILITY_ESS))); } =20 - static inline void update_network(struct rtllib_device *ieee, struct rtllib_network *dst, struct rtllib_network *src) @@ -2580,7 +2568,6 @@ static inline void rtllib_process_probe_response( goto free_network; } =20 - if (!rtllib_legal_channel(ieee, network->channel)) goto free_network; =20 --=20 2.34.1 From nobody Sat Feb 7 17:55:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53079C76196 for ; Thu, 23 Mar 2023 19:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbjCWTUS (ORCPT ); Thu, 23 Mar 2023 15:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbjCWTUN (ORCPT ); Thu, 23 Mar 2023 15:20:13 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42CA59004 for ; Thu, 23 Mar 2023 12:20:12 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id cn12so45550017edb.4 for ; Thu, 23 Mar 2023 12:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679599210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bNg7iZ+PuRMN0DqLdZrW00PMhOD0f4GRznXTT5Ec9ug=; b=OJIo47Myz01VHL4lrQeojnyEpyLvmvQXDDd6hHSS/33DZtiIbZVU7qBQHVeN4eZmqL pI2LMQEvACyay5EpO7m6NGMH86o9x5+k7B9iv6q7KUkN6DVpgEls47lJsY7TVbLUuYYs EgX/06Rd6Ojoal6cMZxhPVS3xQDwCs2aWpLeWE9CozYurmhRzls9imDtcCRe2uLvVFDp J1agRigoHP+AyEzl9XD55oHW1M1J+5dFbufDsoa0zPDlhs8FzN2XvXMVucbHr5aIA+MH ryYX++TbCXHWoTO5zgUPCSntzQlRZJShFvrRv/YZ10dv8/2LwakQd17YgLq3BiwvLzBn yYtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679599210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bNg7iZ+PuRMN0DqLdZrW00PMhOD0f4GRznXTT5Ec9ug=; b=t/W4DFpIolAOvESFd4G59OMsUYBNFRrpEcJXFePw70OZF1wlnkuh8j9JtfJRPKWgG1 Nfi83nyzEv5JH5T/AIb1Y6GeUu1XPdYyqTBGME7cf9VBIHFuqrXlMlKXXFjCdVtpXxC1 frJ7ley99f4J7qr3JmxJuXAVgEiJrH7nZiWzu10USbHNLaaQgaGzGhg0mfqpoC/lhyJJ ziUaE3H0Ip7SCyfohTdUa04BGA7ot/V5N387F2E0HntzV6ZzJ1Q5I/xs9RPp7E5Ws6En hWAR7r/CN2FHwvtfJYVxKNW6pv1fQDyp7+ZQ7Z3VyttS63O+2FQepTXbU5g7N1VgNr+U FkVg== X-Gm-Message-State: AAQBX9eFFuYyRM1kTm3YD5SWO+C145SfUA/9FJv0Ij8wZAjTwe3p7oG5 GhHB/6X2Enf8sFtFIzszsOk= X-Google-Smtp-Source: AKy350aEDwuUxxMp4nnwx5P5DHdZ0chMO6ZyhQIUZoD3U+kI9JNHF+uSmtwf+ENiSGPY9Y3xEewkHQ== X-Received: by 2002:a17:906:3592:b0:932:ba53:83ba with SMTP id o18-20020a170906359200b00932ba5383bamr126094ejb.34.1679599209880; Thu, 23 Mar 2023 12:20:09 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id ia9-20020a170907a06900b00932b3e2c015sm8161409ejc.51.2023.03.23.12.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 12:20:09 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] staging: rtl8192e: add blank lines after declarations Date: Fri, 24 Mar 2023 00:20:00 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add blank lines after declarations as reported by checkpatch.pl "CHECK: Please use a blank line after function/struct/union/enum declarations" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c6114d99829b..7144a0630ea6 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -231,10 +231,12 @@ rtllib_rx_frame_mgmt(struct rtllib_device *ieee, stru= ct sk_buff *skb, static unsigned char rfc1042_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 }; + /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */ static unsigned char bridge_tunnel_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 }; + /* No encapsulation header if EtherType < 0x600 (=3Dlength) */ =20 /* Called by rtllib_rx_frame_decrypt */ --=20 2.34.1 From nobody Sat Feb 7 17:55:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A6EC6FD1C for ; Thu, 23 Mar 2023 19:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230216AbjCWTUU (ORCPT ); Thu, 23 Mar 2023 15:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbjCWTUQ (ORCPT ); Thu, 23 Mar 2023 15:20:16 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47C0B9030 for ; Thu, 23 Mar 2023 12:20:13 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id t10so2074844edd.12 for ; Thu, 23 Mar 2023 12:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679599212; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=weAoEEZiI2mKD//rUNwkb5TZGAcwsmwF1BER0SC0aPA=; b=QOwTBrIoQI4r47IwGRXZMp2IDYBD9WP0CX7XfF52XB/le+m7+VBEY/PK/FyWfvrQ9j AKY0EQnaN9w1ZqggShE8P8wWUCIDrNG9QQ6+WZWsQmWgoBnff3J49JmTd9PKHg/6nc4d G8MQDGv5xD9jmL8BYUw/e9XihdmV9S651QeBIrTEKI8FbE+8aZsT7An7DBRzV2t+2J9v /ZxJPXUhXvG6qW3vPOdGlA7p0n7K7j5xrQ5dRcn4jrmDA5bKOi/YUqaX5HREKJJ2fDy1 jW/HhC0MiPQ8zyn6unPjs3UgP/fEeCF1m/UurBC8RRoacpVGuZxlSMTSoRi4uSWCS1lx 4A0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679599212; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=weAoEEZiI2mKD//rUNwkb5TZGAcwsmwF1BER0SC0aPA=; b=TCglGjmXqsqrmbcly0k0+7vC0Q9WWorriwo7gVCVRUZLgg8j5+uZh81zf28pjr1Gik lYKBsp7bJd6cvtdTIKZXkks2SxdA1jmqw9r36wqO9xcNJzfIudI0GdFmwhz+m1UKA7CY nZeTIiDu7LBmMfH4tzQYo0U4Lv7QeiSaB0z1GvgxYKiW4lCXjOGMnxQTd6vVDqbNSwXt 1vXlgQy9ShCe04sPGflHrPX5k1gdUfquDysn2auZ1635KipqZdElS9Qnm+pv7PUSiBs7 pyi6c1vUoClOeavls0tzy9q3gglzkQRueL/+MZJzaP4+5FxG0E+z+eNmW85oeT2uBp90 mHmA== X-Gm-Message-State: AAQBX9euOSMFHbc7oKldhDbkSv1+bMHNHXTSw/fArtbpsHEg6b4CETz8 4NctnHnc4XtkGABeg2nLCftYaf3sqEHAoZSy X-Google-Smtp-Source: AKy350aiEBpV6lmofnF4exR52xTqmfIoyICqxXKfOTZaYAEJsRnwEHorlV1J272fmC6VY0cnkLzVgQ== X-Received: by 2002:a17:906:cd12:b0:930:f149:7865 with SMTP id oz18-20020a170906cd1200b00930f1497865mr136513ejb.21.1679599211581; Thu, 23 Mar 2023 12:20:11 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id ia9-20020a170907a06900b00932b3e2c015sm8161409ejc.51.2023.03.23.12.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 12:20:11 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/4] staging: rtl8192e: add spaces around binary operators Date: Fri, 24 Mar 2023 00:20:01 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use spaces around binary operators as suggested by Linux kernel coding style. Issues reported by checkpatch.pl for the following binary operators: + , - , * , | , << Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 54 ++++++++++++++-------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 7144a0630ea6..f627dfe66d90 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -356,7 +356,7 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, } =20 /* this function is stolen from ipw2200 driver*/ -#define IEEE_PACKET_RETRY_TIME (5*HZ) +#define IEEE_PACKET_RETRY_TIME (5 * HZ) static int is_duplicate_packet(struct rtllib_device *ieee, struct rtllib_hdr_4addr *header) { @@ -936,7 +936,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, =20 if (GetTs(ieee, (struct ts_common_info **)&pRxTS, hdr->addr2, (u8)Frame_QoSTID((u8 *)(skb->data)), RX_DIR, true)) { - if ((fc & (1<<11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && + if ((fc & (1 << 11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && (WLAN_GET_SEQ_SEQ(sc) =3D=3D pRxTS->rx_last_seq_num)) return -1; pRxTS->rx_last_frag_num =3D frag; @@ -1619,23 +1619,23 @@ static int rtllib_qos_convert_ac_to_parameters(stru= ct rtllib_qos_parameter_info case 1: /* BIT(0) | BIT(3) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<0)|(0x01<<3); + qos_data->wmm_acm |=3D (0x01 << 0) | (0x01 << 3); break; case 2: /* BIT(4) | BIT(5) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<4)|(0x01<<5); + qos_data->wmm_acm |=3D (0x01 << 4) | (0x01 << 5); break; case 3: /* BIT(6) | BIT(7) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<6)|(0x01<<7); + qos_data->wmm_acm |=3D (0x01 << 6) | (0x01 << 7); break; case 0: default: /* BIT(1) | BIT(2) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<1)|(0x01<<2); + qos_data->wmm_acm |=3D (0x01 << 1) | (0x01 << 2); break; } =20 @@ -1979,7 +1979,7 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[3] =3D=3D 0x04) { netdev_dbg(ieee->dev, "MFIE_TYPE_WZC: %d bytes\n", info_element->len); - network->wzc_ie_len =3D min(info_element->len+2, MAX_WZC_IE_LEN); + network->wzc_ie_len =3D min(info_element->len + 2, MAX_WZC_IE_LEN); memcpy(network->wzc_ie, info_element, network->wzc_ie_len); } } @@ -2139,10 +2139,10 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; =20 - offset =3D (info_element->data[2] >> 1)*2; + offset =3D (info_element->data[2] >> 1) * 2; =20 - if (ieee->assoc_id < 8*offset || - ieee->assoc_id > 8*(offset + info_element->len - 3)) + if (ieee->assoc_id < 8 * offset || + ieee->assoc_id > 8 * (offset + info_element->len - 3)) break; =20 offset =3D (ieee->assoc_id / 8) - offset; @@ -2357,7 +2357,7 @@ static inline int rtllib_network_init( if (rtllib_is_empty_essid(network->ssid, network->ssid_len)) network->flags |=3D NETWORK_EMPTY_ESSID; stats->signal =3D 30 + (stats->SignalStrength * 70) / 100; - stats->noise =3D rtllib_translate_todbm((u8)(100-stats->signal)) - 25; + stats->noise =3D rtllib_translate_todbm((u8)(100 - stats->signal)) - 25; =20 memcpy(&network->stats, stats, sizeof(network->stats)); =20 @@ -2545,22 +2545,22 @@ static inline void rtllib_process_probe_response( "'%s' ( %pM ): %c%c%c%c %c%c%c%c-%c%c%c%c %c%c%c%c\n", escape_essid(info_element->data, info_element->len), beacon->header.addr3, - (le16_to_cpu(beacon->capability) & (1<<0xf)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xe)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xd)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xc)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xb)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xa)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x9)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x8)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x7)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x6)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x5)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x4)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x3)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x2)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x1)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x0)) ? '1' : '0'); + (le16_to_cpu(beacon->capability) & (1 << 0xf)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xe)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xd)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xc)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xb)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xa)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x9)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x8)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x7)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x6)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x5)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x4)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x3)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x2)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x1)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x0)) ? '1' : '0'); =20 if (rtllib_network_init(ieee, beacon, network, stats)) { netdev_dbg(ieee->dev, "Dropped '%s' ( %pM) via %s.\n", --=20 2.34.1 From nobody Sat Feb 7 17:55:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35A8C74A5B for ; Thu, 23 Mar 2023 19:20:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231154AbjCWTUY (ORCPT ); Thu, 23 Mar 2023 15:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbjCWTUQ (ORCPT ); Thu, 23 Mar 2023 15:20:16 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA4AEEFA1 for ; Thu, 23 Mar 2023 12:20:14 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id x3so91155369edb.10 for ; Thu, 23 Mar 2023 12:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679599213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jRIhiCMIYhlzOxpqNUvBzZ/DfwkIA0+Cejq18uIa0y0=; b=lRY8iaHw69WCs1URcFv4/laikeuajycokc36F6FdzbOd+szHEuJtUPQSc3rAvyEBd8 PhzFu9iGZhI6tQcgvCbQ4Vtg8s4zM/Ft0ublnHympVGRZz4y6kjCaZaMZWX7+OBkmR76 tusUCSPQ66ntZcNhbTRUbVEAfAUEPPKs+vsEn5Y8q2e3gw+RWFUkmC2+rkk/B2MRWulA 9aWfqWwV7l5uqkigskT8iz1Val+oWI2IUFtNRaWpWtizZ6PxfFsmc5ADQ8eeTycaE3cZ HSFVC2L/WeKZsETyk3wJR366nK8+0Lwn/ygS+1vzDBNXhVIYy+uM/oq3oahKUwS09DmP royw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679599213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jRIhiCMIYhlzOxpqNUvBzZ/DfwkIA0+Cejq18uIa0y0=; b=54kfkk9LEAh/z+RfGRAFObZrNDVAhUxpMG/tJen7Xm3Euw2PDvR4L4MsNrbRq9APU3 TwGpld1+lJZq0uhsmZxhpsH0yl5rhFdomMTkh64MIxFcX25IUyvoyzvBU7a75DN5lC8c 08WyOQ/8L40E4GxWCGNTYllJqGCRQAdz+wDKJMJ88fzIpXcDLY1ivq01ayM4oKD7ipHr 0P/LdNqptk4Q1e4xreh5LbaHG0hS2/W/W3KdtiHqBpQ+CI59vs8mPpH6jV8hfVIaT4Ru JfFzWfbLE1TW2nD+/bDdZ5+u/Qgqf3mkztzW4Oxb4gsBPQpZYLUxeV/cZnUX8X+L/y2d ne8w== X-Gm-Message-State: AAQBX9d0NlTtBk0cOlLNhH/d88DU/ZUXPXvAQlSnPEN5AadbY5rIjwIW r+zJ3ls1A/bp2PDZ0SnpX/o= X-Google-Smtp-Source: AKy350bv2nW0ssSW58xZk/A1hVR6vQGpLcJ1lDh0NrD7/70XHYAWOJKVIw/lFQwMBDo6Wl2JAZ8PLg== X-Received: by 2002:a17:907:8c0e:b0:930:bc07:3bf7 with SMTP id ta14-20020a1709078c0e00b00930bc073bf7mr207842ejc.5.1679599213094; Thu, 23 Mar 2023 12:20:13 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id ia9-20020a170907a06900b00932b3e2c015sm8161409ejc.51.2023.03.23.12.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 12:20:12 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] staging: rtl8192e: remove blank lines after '{' Date: Fri, 24 Mar 2023 00:20:02 +0500 Message-Id: <303a41480220a6c31cee91d40ece40b3fae3bddf.1679598576.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unnecessary blank lines after an open brace as reported by checkpatch.pl "CHECK: Blank lines aren't necessary after an open brace '{'" Signed-off-by: Khadija Kamran Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index f627dfe66d90..b649d02dc5c8 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1167,7 +1167,6 @@ static int rtllib_rx_decrypt(struct rtllib_device *ie= ee, struct sk_buff *skb, if (crypt && !(fc & RTLLIB_FCTL_WEP) && !ieee->open_wep) { if (/*ieee->ieee802_1x &&*/ rtllib_is_eapol_frame(ieee, skb, hdrlen)) { - /* pass unencrypted EAPOL frames even if encryption is * configured */ @@ -1207,7 +1206,6 @@ static void rtllib_rx_check_leave_lps(struct rtllib_d= evice *ieee, u8 unicast, u8 nr_subframes) { if (unicast) { - if (ieee->state =3D=3D RTLLIB_LINKED) { if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) > 8) || @@ -1552,7 +1550,6 @@ static u8 qos_oui[QOS_OUI_LEN] =3D { 0x00, 0x50, 0xF2= }; static int rtllib_verify_qos_info(struct rtllib_qos_information_element *info_element, int sub_type) { - if (info_element->elementID !=3D QOS_ELEMENT_ID) return -1; if (info_element->qui_subtype !=3D sub_type) @@ -2696,7 +2693,6 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee, ieee->last_rx_ps_time =3D jiffies; =20 switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))) { - case RTLLIB_STYPE_BEACON: netdev_dbg(ieee->dev, "received BEACON (%d)\n", WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))); --=20 2.34.1