From nobody Mon Feb 9 07:19:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F00C6FD1C for ; Thu, 23 Mar 2023 12:42:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231288AbjCWMmA (ORCPT ); Thu, 23 Mar 2023 08:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230231AbjCWMl5 (ORCPT ); Thu, 23 Mar 2023 08:41:57 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D2042210F for ; Thu, 23 Mar 2023 05:41:52 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id ek18so85980327edb.6 for ; Thu, 23 Mar 2023 05:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679575311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2qlJwucxS9YsM3710vjGoZ2YHREnKLXbsqoSCiO7TnI=; b=j+Ir1g/OUjpJiUjvV/6+8j4aR7/q4Z07vY8VqTz8lNOlI7cslcW+1DYMyk2UxDSJhC j3cKjK+Fve9mMChDP/IchnqNX86XJdlAY254J5F0CEy028olhesU7IktJYVjLGBDcJ9U GaDuogzrZ8iuwVTZo7FJa79AGU8C+xJplxD/63WUdBeDqLl+drNDn2nX2Sm4guV3so/r 0Yvmyk1E2bQbWyBcqP4Xu7SjUoJm+rzVcY00YqVTzbCCiWhwi4YO5rXeEN7uZE9zE/PB trmFkCNk5zk8GRREgymClP8YKo9qPlJsB+bNFDjVpYiNwbTkbav0s29t7PuQhebg/s8l ZK/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679575311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2qlJwucxS9YsM3710vjGoZ2YHREnKLXbsqoSCiO7TnI=; b=0pg0SErhjsuBshp2RUf6Hu/Iw69q/nqXBCIk0GrclivzDsiYnlQkeyMXo01jnJh1Ss QBeh3XDsee+Hl6+6nqCW4BOiRww5MnsxMJqfH/3wWHKYrIgYgnQQcY36uqWRyBoFQ4KQ 9/lrw+1+HbkiJC3EPf0G/x0wRNfjKdOI8cWRWajQFu43Hdx7OOQd3+GmuVFMLucV1Ryc iS+KwDl3fm/G2nwyfiFLOCWLqVMzl/6AxP0NuyDzKlXYrRw29A8geBoQThYo6riEh3gz 4Kxx6lSMKrqpNEh1vpn7vwRJstTHAlOxDYORU8ixaLEype9kCtQsDYMjTKPasOF+rt6M /SKw== X-Gm-Message-State: AO0yUKUbPfmONa+S4ShkfAFlytu2zLYVYcEI6urjqBiECq87vNxigkb7 W6nFAHEHbDsUTJMpWLP/s8unvawxZY4N/jUJ X-Google-Smtp-Source: AK7set9CR/MF1vkyti76l+sUzxLObEV+YfuqVq7IWRcC91AvxbsYRoPqyrbqdDgUHXoHcugLgVfnnw== X-Received: by 2002:a17:907:765a:b0:8b1:7684:dfab with SMTP id kj26-20020a170907765a00b008b17684dfabmr12180970ejc.38.1679575311092; Thu, 23 Mar 2023 05:41:51 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id g1-20020a1709061c8100b0092669fb4ba1sm8597116ejh.130.2023.03.23.05.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 05:41:50 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 1/4] staging: rtl8192e: remove extra blank lines Date: Thu, 23 Mar 2023 17:41:42 +0500 Message-Id: <43d5864fc42e51089a0a0626278204bac8313eb0.1679573474.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove extra blank lines as reported by checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c394c21beefb..c6114d99829b 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -154,7 +154,6 @@ rtllib_frag_cache_get(struct rtllib_device *ieee, return skb; } - /* Called only as a tasklet (software IRQ) */ static int rtllib_frag_cache_invalidate(struct rtllib_device *ieee, struct rtllib_hdr_4addr *hdr) @@ -318,7 +317,6 @@ rtllib_rx_frame_decrypt(struct rtllib_device *ieee, str= uct sk_buff *skb, return res; } - /* Called only as a tasklet (software IRQ), by rtllib_rx */ static inline int rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee, struct sk_buff *s= kb, @@ -355,7 +353,6 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, return 0; } - /* this function is stolen from ipw2200 driver*/ #define IEEE_PACKET_RETRY_TIME (5*HZ) static int is_duplicate_packet(struct rtllib_device *ieee, @@ -887,7 +884,6 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, return rxb->nr_subframes; } - static size_t rtllib_rx_get_hdrlen(struct rtllib_device *ieee, struct sk_buff *skb, struct rtllib_rx_stats *rx_stats) @@ -1569,7 +1565,6 @@ static int rtllib_verify_qos_info(struct rtllib_qos_i= nformation_element return 0; } - /* Parse a QoS parameter element */ static int rtllib_read_qos_param_element( struct rtllib_qos_parameter_info *element_param, @@ -1599,7 +1594,6 @@ static int rtllib_read_qos_info_element( return rtllib_verify_qos_info(element_info, QOS_OUI_INFO_SUB_TYPE); } - /* Write QoS parameters from the ac parameters. */ static int rtllib_qos_convert_ac_to_parameters(struct rtllib_qos_parameter= _info *param_elm, struct rtllib_qos_data *qos_data) @@ -1843,7 +1837,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, } } - if (*tmp_htinfo_len =3D=3D 0) { if (info_element->len >=3D 4 && info_element->data[0] =3D=3D 0x00 && @@ -1932,7 +1925,6 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[2] =3D=3D 0x96) network->cisco_cap_exist =3D true; - if (info_element->len >=3D 3 && info_element->data[0] =3D=3D 0x00 && info_element->data[1] =3D=3D 0x0a && @@ -2142,13 +2134,11 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, network->dtim_data =3D RTLLIB_DTIM_VALID; - if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; offset =3D (info_element->data[2] >> 1)*2; - if (ieee->assoc_id < 8*offset || ieee->assoc_id > 8*(offset + info_element->len - 3)) break; @@ -2203,7 +2193,6 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, &tmp_htcap_len); break; - case MFIE_TYPE_HT_INFO: netdev_dbg(ieee->dev, "MFIE_TYPE_HT_INFO: %d bytes\n", info_element->len); @@ -2392,7 +2381,6 @@ static inline int is_same_network(struct rtllib_netwo= rk *src, (dst->capability & WLAN_CAPABILITY_ESS))); } - static inline void update_network(struct rtllib_device *ieee, struct rtllib_network *dst, struct rtllib_network *src) @@ -2580,7 +2568,6 @@ static inline void rtllib_process_probe_response( goto free_network; } - if (!rtllib_legal_channel(ieee, network->channel)) goto free_network; -- 2.34.1 From nobody Mon Feb 9 07:19:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3225EC6FD1C for ; Thu, 23 Mar 2023 12:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231254AbjCWMmD (ORCPT ); Thu, 23 Mar 2023 08:42:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230321AbjCWMl5 (ORCPT ); Thu, 23 Mar 2023 08:41:57 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BC9526C0E for ; Thu, 23 Mar 2023 05:41:53 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id cn12so40300992edb.4 for ; Thu, 23 Mar 2023 05:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679575312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bNg7iZ+PuRMN0DqLdZrW00PMhOD0f4GRznXTT5Ec9ug=; b=c2mdPwifKTGrVqQfBoQq5+0Qbh3+PzLWiTCBTCOI4wPnQmVhzmFPhlk5IcPthraXZ3 1HXFfgirj+JKFx4BbPzy/P5IF4NUDy3ujgKxJ6Zg8IKS8ikQXsMHfm4Xnx0tYE7R4sTD vgQnQCLxPv3GCDiorv5u8pIdElZpye5l8wdwJde09YUNsotqRaoE6vUPDMQZ0MSllAlC +13Ez1ev9J65M3fJcugW9nCxTkP+0c76tSy9m093j8yoyhKMFbnaTEYPL5kNxj53v3pa QqPaErJgBodvp7zJ3BG3YxxkrPQuCFgiIMy8LhHWvL8tUkkHngN+SAmK6yP4TkjqU9mZ 4l8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679575312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bNg7iZ+PuRMN0DqLdZrW00PMhOD0f4GRznXTT5Ec9ug=; b=fXVhV60EHaqrJKITdOOZCaj825t9Qsli76eSOy9W6sF+vrDly/hXy2Id9ohjejfdC1 EIQvzZ0WwRcmiabiNN09m8ABvyGKZ2WF8ghUhAWZ8RjywhjtOqHzUKuS2bgdkxnTZZRn LZZ09wzHkfika8sn/kNwaQolV9lqs4x+Rd5tRHGvst58oK1y7j5q/FK3tLyVhHOtBmHe MIRvchHFQUNbnTpUH/1ZVzaO8t0PjhF3/zjKZ3ybtsD28QcS+e/Ma5iykqtWjQcZi51P 9CxkMJutIuRsIGxdv+LxjvzKDFI/gel2SOjA5qdw6AWViwHL1IEgQxd8ayzWgC3lVuPy UfjA== X-Gm-Message-State: AO0yUKU12ibay5Z1k8wdZixaMXRCw66z+Bqg4NFqhGumS+WAnEY8D7o1 6GtPTX4O2FB5MQwNCOayNsU= X-Google-Smtp-Source: AK7set/+XEjs58tHkW2iyt4lkh0/495N66AhyWek8O/RYAogGfqhYlkGlfP6yviSN2wtRHgYI8sYMg== X-Received: by 2002:a17:906:3710:b0:923:812c:a5d3 with SMTP id d16-20020a170906371000b00923812ca5d3mr5550362ejc.25.1679575312825; Thu, 23 Mar 2023 05:41:52 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id g1-20020a1709061c8100b0092669fb4ba1sm8597116ejh.130.2023.03.23.05.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 05:41:52 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 2/4] staging: rtl8192e: add blank lines after declarations Date: Thu, 23 Mar 2023 17:41:43 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add blank lines after declarations as reported by checkpatch.pl "CHECK: Please use a blank line after function/struct/union/enum declarations" Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index c6114d99829b..7144a0630ea6 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -231,10 +231,12 @@ rtllib_rx_frame_mgmt(struct rtllib_device *ieee, stru= ct sk_buff *skb, static unsigned char rfc1042_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 }; + /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */ static unsigned char bridge_tunnel_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 }; + /* No encapsulation header if EtherType < 0x600 (=3Dlength) */ /* Called by rtllib_rx_frame_decrypt */ -- 2.34.1 From nobody Mon Feb 9 07:19:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77036C6FD1C for ; Thu, 23 Mar 2023 12:42:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231896AbjCWMmG (ORCPT ); Thu, 23 Mar 2023 08:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbjCWMl5 (ORCPT ); Thu, 23 Mar 2023 08:41:57 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EBEA26C15 for ; Thu, 23 Mar 2023 05:41:56 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id o12so85928424edb.9 for ; Thu, 23 Mar 2023 05:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679575314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=weAoEEZiI2mKD//rUNwkb5TZGAcwsmwF1BER0SC0aPA=; b=quthEa3NKe31Ms5cF2a+VQtTEMJoU2+HqyJmRi9EhCOkGGAkhYmDfaL2U/sAxh2lkS pqzW8Uq3Vtkx9QknepnocC07d2V1hv/IvY0Wi35mpRR+FmdK3Ippsb9NuxC9N/WVCJO4 U3dXEktjMR8MWLHX0fr5n1b1mlpHvy8GyZ2xbfGSvmRIvVuIp1lGkmiFwA8zKK7bt+p2 zTIwJofgV0/fo5ZA/wha813T4IDrRw0GTv3QpERv3N0E0GOtoGSFhk2l5xR6eWeLWGDe MltZQjAeEzA9x5z8RX+u1I5x25xWTb5ZQep5M5k38R5nnxH97ZV0FRuI0cW1jW9FCGun dUIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679575314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=weAoEEZiI2mKD//rUNwkb5TZGAcwsmwF1BER0SC0aPA=; b=D94NPLsrQ8umfoYG48Y/i/EobTlHxmnkhyV3fbEBWoATrkezCc8V00oahQqi3FW35E mgws41wkkTkMHLXAWgzjswy7aiS2WMqijHxHeZMVX0jt1wB5u6yhyOOl1SBg/5sLkTI1 oMo9XpXnbge0JOJTxm7yCuaIuIWqGw/HiLJgGVQ4+bWdVmUEqzEwps2naSv6s50nNGYD /jP9/2mKxqwuIBMJqOu3m1MSdXP3MaMR8xXnI6mMS0YRQV+oI4XCE/sj+bDSC5PAFbbr eYZEdf9iws42eWzjfgjZusSfaYgsX8WfKdnlYBKWN1ERIWyEF7/XhBQqMk9inm4cVM2+ mt9Q== X-Gm-Message-State: AO0yUKUrPcNjO8MG3CpPXAlvbABdhUU7Ak9X4lG4FRHoUw4MypBCE0ie pWP3JiLSv842jcYcBnGlMLI= X-Google-Smtp-Source: AK7set92y/Q1tjFRXN7fFz6mmX1OAyLFmShqWD5vbYUYdzCfNP2NiUw7AtF0kJ3kPNGupjGDo500+w== X-Received: by 2002:a17:906:3b59:b0:877:573d:e919 with SMTP id h25-20020a1709063b5900b00877573de919mr9578563ejf.20.1679575314560; Thu, 23 Mar 2023 05:41:54 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id g1-20020a1709061c8100b0092669fb4ba1sm8597116ejh.130.2023.03.23.05.41.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 05:41:54 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 3/4] staging: rtl8192e: add spaces around binary operators Date: Thu, 23 Mar 2023 17:41:44 +0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use spaces around binary operators as suggested by Linux kernel coding style. Issues reported by checkpatch.pl for the following binary operators: + , - , * , | , << Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 54 ++++++++++++++-------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 7144a0630ea6..f627dfe66d90 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -356,7 +356,7 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, } /* this function is stolen from ipw2200 driver*/ -#define IEEE_PACKET_RETRY_TIME (5*HZ) +#define IEEE_PACKET_RETRY_TIME (5 * HZ) static int is_duplicate_packet(struct rtllib_device *ieee, struct rtllib_hdr_4addr *header) { @@ -936,7 +936,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, if (GetTs(ieee, (struct ts_common_info **)&pRxTS, hdr->addr2, (u8)Frame_QoSTID((u8 *)(skb->data)), RX_DIR, true)) { - if ((fc & (1<<11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && + if ((fc & (1 << 11)) && (frag =3D=3D pRxTS->rx_last_frag_num) && (WLAN_GET_SEQ_SEQ(sc) =3D=3D pRxTS->rx_last_seq_num)) return -1; pRxTS->rx_last_frag_num =3D frag; @@ -1619,23 +1619,23 @@ static int rtllib_qos_convert_ac_to_parameters(stru= ct rtllib_qos_parameter_info case 1: /* BIT(0) | BIT(3) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<0)|(0x01<<3); + qos_data->wmm_acm |=3D (0x01 << 0) | (0x01 << 3); break; case 2: /* BIT(4) | BIT(5) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<4)|(0x01<<5); + qos_data->wmm_acm |=3D (0x01 << 4) | (0x01 << 5); break; case 3: /* BIT(6) | BIT(7) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<6)|(0x01<<7); + qos_data->wmm_acm |=3D (0x01 << 6) | (0x01 << 7); break; case 0: default: /* BIT(1) | BIT(2) */ if (acm) - qos_data->wmm_acm |=3D (0x01<<1)|(0x01<<2); + qos_data->wmm_acm |=3D (0x01 << 1) | (0x01 << 2); break; } @@ -1979,7 +1979,7 @@ static void rtllib_parse_mife_generic(struct rtllib_d= evice *ieee, info_element->data[3] =3D=3D 0x04) { netdev_dbg(ieee->dev, "MFIE_TYPE_WZC: %d bytes\n", info_element->len); - network->wzc_ie_len =3D min(info_element->len+2, MAX_WZC_IE_LEN); + network->wzc_ie_len =3D min(info_element->len + 2, MAX_WZC_IE_LEN); memcpy(network->wzc_ie, info_element, network->wzc_ie_len); } } @@ -2139,10 +2139,10 @@ int rtllib_parse_info_param(struct rtllib_device *i= eee, if (info_element->data[2] & 1) network->dtim_data |=3D RTLLIB_DTIM_MBCAST; - offset =3D (info_element->data[2] >> 1)*2; + offset =3D (info_element->data[2] >> 1) * 2; - if (ieee->assoc_id < 8*offset || - ieee->assoc_id > 8*(offset + info_element->len - 3)) + if (ieee->assoc_id < 8 * offset || + ieee->assoc_id > 8 * (offset + info_element->len - 3)) break; offset =3D (ieee->assoc_id / 8) - offset; @@ -2357,7 +2357,7 @@ static inline int rtllib_network_init( if (rtllib_is_empty_essid(network->ssid, network->ssid_len)) network->flags |=3D NETWORK_EMPTY_ESSID; stats->signal =3D 30 + (stats->SignalStrength * 70) / 100; - stats->noise =3D rtllib_translate_todbm((u8)(100-stats->signal)) - 25; + stats->noise =3D rtllib_translate_todbm((u8)(100 - stats->signal)) - 25; memcpy(&network->stats, stats, sizeof(network->stats)); @@ -2545,22 +2545,22 @@ static inline void rtllib_process_probe_response( "'%s' ( %pM ): %c%c%c%c %c%c%c%c-%c%c%c%c %c%c%c%c\n", escape_essid(info_element->data, info_element->len), beacon->header.addr3, - (le16_to_cpu(beacon->capability) & (1<<0xf)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xe)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xd)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xc)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xb)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xa)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x9)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x8)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x7)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x6)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x5)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x4)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x3)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x2)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x1)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x0)) ? '1' : '0'); + (le16_to_cpu(beacon->capability) & (1 << 0xf)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xe)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xd)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xc)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xb)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xa)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x9)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x8)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x7)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x6)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x5)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x4)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x3)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x2)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x1)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x0)) ? '1' : '0'); if (rtllib_network_init(ieee, beacon, network, stats)) { netdev_dbg(ieee->dev, "Dropped '%s' ( %pM) via %s.\n", -- 2.34.1 From nobody Mon Feb 9 07:19:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36626C6FD1C for ; Thu, 23 Mar 2023 12:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231658AbjCWMmI (ORCPT ); Thu, 23 Mar 2023 08:42:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231902AbjCWMl7 (ORCPT ); Thu, 23 Mar 2023 08:41:59 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2A1726CCC for ; Thu, 23 Mar 2023 05:41:57 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id h8so85923899ede.8 for ; Thu, 23 Mar 2023 05:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679575316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jRIhiCMIYhlzOxpqNUvBzZ/DfwkIA0+Cejq18uIa0y0=; b=YsRResv+/EI11pFUKv28iYf87fPzodJ7FzZRpMbbtBK9NxRuWP97dVWS2trAsAWjq3 JKX36XXrg9hwR+RiPd5fEwCl6zW2Wh642ctovQP4owleX4n3EiOd94c2eWef+qhVZ4fz hJMpTs5Kv3JMpN/2vyK5XJ5QIHcI6NrT6uJL96NZM2hyPY50HUuRr4fUf+1u6ngdzldn sfVObj6QZVDCZ8+HtaPWfSLagsO0hpebwPKTFtJ8xMnY/WLlZN/zNiXx4who+c0WDwsm 8bpp1FYVcYYdWoi6Tydjr4lx07UNGQUxmVKo6UmEnan/qyrdY8fkuZ0YQNpE+wHqkHQW 58lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679575316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jRIhiCMIYhlzOxpqNUvBzZ/DfwkIA0+Cejq18uIa0y0=; b=tmU1U2UOOpfjmpMTJlLkVAQ0DNJhyNFigjNVe5rea07pCqBHRetc0uYnQXAMv5ErW8 y8hsC94enX2K31f+gIOjpYGE1m3pSTMNwXew6S5ZzjScbhYX3ZigDkQNdUkNFUzazc8J AHGmYJ8skyNJp7bKbHekEQT2pdBrlGtY1U60D255QFYlFVJS0DDPC+GCUKLCh5xaWyx0 DUpG9aDuc/eRUJQkn6jCwHiHwoZRowOZcW/TTPWki2cJL5OO0RzY+X0YrfT0JMdjxcxs +z9FvMn9mOL4q+A165Cf1wXQsNq8g2u8i0IECG4ylVu1HgrJrMEanUlBLJV1+DI0zLKt Q63g== X-Gm-Message-State: AO0yUKVHpuY/Fo+6mYW4LgMFA2jVzyIem8vq2etEoA+bniRJRYCPwR2Z lT9+2wTrwFY8ebkoQHFggbg= X-Google-Smtp-Source: AK7set/9vMbuObGoSNbL668Qv2c/PorTp83sSbtHafwYghf4PLlj07ix/seWf8uFUxGjwSCMfqRz9g== X-Received: by 2002:a17:907:7666:b0:931:dcd4:4ff0 with SMTP id kk6-20020a170907766600b00931dcd44ff0mr10644366ejc.75.1679575316304; Thu, 23 Mar 2023 05:41:56 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id g1-20020a1709061c8100b0092669fb4ba1sm8597116ejh.130.2023.03.23.05.41.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 05:41:56 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 4/4] staging: rtl8192e: remove blank lines after '{' Date: Thu, 23 Mar 2023 17:41:45 +0500 Message-Id: <303a41480220a6c31cee91d40ece40b3fae3bddf.1679573474.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unnecessary blank lines after an open brace as reported by checkpatch.pl "CHECK: Blank lines aren't necessary after an open brace '{'" Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index f627dfe66d90..b649d02dc5c8 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1167,7 +1167,6 @@ static int rtllib_rx_decrypt(struct rtllib_device *ie= ee, struct sk_buff *skb, if (crypt && !(fc & RTLLIB_FCTL_WEP) && !ieee->open_wep) { if (/*ieee->ieee802_1x &&*/ rtllib_is_eapol_frame(ieee, skb, hdrlen)) { - /* pass unencrypted EAPOL frames even if encryption is * configured */ @@ -1207,7 +1206,6 @@ static void rtllib_rx_check_leave_lps(struct rtllib_d= evice *ieee, u8 unicast, u8 nr_subframes) { if (unicast) { - if (ieee->state =3D=3D RTLLIB_LINKED) { if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) > 8) || @@ -1552,7 +1550,6 @@ static u8 qos_oui[QOS_OUI_LEN] =3D { 0x00, 0x50, 0xF2= }; static int rtllib_verify_qos_info(struct rtllib_qos_information_element *info_element, int sub_type) { - if (info_element->elementID !=3D QOS_ELEMENT_ID) return -1; if (info_element->qui_subtype !=3D sub_type) @@ -2696,7 +2693,6 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee, ieee->last_rx_ps_time =3D jiffies; switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))) { - case RTLLIB_STYPE_BEACON: netdev_dbg(ieee->dev, "received BEACON (%d)\n", WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))); -- 2.34.1