From nobody Mon Feb 9 05:38:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 110D7C6FD1C for ; Mon, 20 Mar 2023 23:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229936AbjCTXFB (ORCPT ); Mon, 20 Mar 2023 19:05:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbjCTXEz (ORCPT ); Mon, 20 Mar 2023 19:04:55 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 292EB2F05D; Mon, 20 Mar 2023 16:04:54 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id b20so20086410edd.1; Mon, 20 Mar 2023 16:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679353492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1ZHVKRyqUkVQgHIPcnrjM4VftHtoW1MPmlfE9Rq46vI=; b=c+NNbwr/+NJQq6R7u+ToUNyv1k1hJDK98hxkI8xpb6Sz8cHGTsBQ1Am/YOXVVijHnK n/OZGpTKM9gZD9bgPOe62QJGu7dcQkGOpyKZ2H60WsZadCeGE9vKA4jpFUmBtm3uM0/S ukg7FKm8ZZt2dGFVfs6GLO6lFZ89si96Q6vogwbSCBiNa1JPhnsXgk58cWLe6znvtuTJ /pXesrDYYcku9sOSU21Dp3+O+1gl81Rm40MB0sOI1mXayrykUCa4E2lOGXZCAZOJgOHq u/HutsC3loij572OEhBJFAc5vRlyfrbIn4Yvs0b0unBx4WaXVkluJF2jPju8T214mjlV 0pEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679353492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ZHVKRyqUkVQgHIPcnrjM4VftHtoW1MPmlfE9Rq46vI=; b=UkTx2JeZTn2ARPYbCVpvUCuOZhDCxX+r5ma5npTTjUS1JbldPyHRVx6YuH/SJEioYf lVJOpyxqCfGUWubuieWR9QIAkGLiS90M8zRIFLtQJ/y7MIuenjyR7CNEnxPCREC8EZ0b EyoWSWgvBwIX1WxgAd4v4N7I/CC6J4fuE/7kN8yzYkvyVuVKeaFGPuU2SeKvD/kl002l xeKh7jjxBpKtf1ixPPvGjs7n0XRY7YRc940etJ2evhqJr8YawQbrnIgI6E21U4wXqqh0 NP0MuWe7yo7elm+7vX6GNC291nds7W5Df7z3LU0AZHfqzXj4p0CC7wlXV1BScfOeAVKZ p1Qw== X-Gm-Message-State: AO0yUKW0mSlM5XJ64581SlsMwn4sk4LHVcpa1jVwloddL51JWuPVd5WD 8akg80PzW/ZVqdgIOCQEtcg= X-Google-Smtp-Source: AK7set+wgkZkpddvtjrwRkWTzSXRdr48NS7qmGH/+RLgQhNolVcXMwNfqT7C+AR6iDCzQz0vkD9e8Q== X-Received: by 2002:a17:906:594e:b0:8f5:8da0:a482 with SMTP id g14-20020a170906594e00b008f58da0a482mr1279214ejr.25.1679353492536; Mon, 20 Mar 2023 16:04:52 -0700 (PDT) Received: from alaa-emad.. ([41.42.177.251]) by smtp.gmail.com with ESMTPSA id v5-20020a17090690c500b0093188e8d478sm4956403ejw.103.2023.03.20.16.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 16:04:52 -0700 (PDT) From: Menna Mahmoud To: gregkh@linuxfoundation.org Cc: outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org, vireshk@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org, eng.mennamahmoud.mm@gmail.com Subject: [PATCH 1/3] staging: greybus: remove unnecessary blank line Date: Tue, 21 Mar 2023 01:04:32 +0200 Message-Id: <4ea07eb91d7065d81799ad684741ace685a38088.1679352669.git.eng.mennamahmoud.mm@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unnecessary blank line before struct as reported by checkpatch: " CHECK: Please don't use multiple blank lines " Signed-off-by: Menna Mahmoud --- drivers/staging/greybus/greybus_authentication.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/sta= ging/greybus/greybus_authentication.h index 7edc7295b7ab..48b4a9794d3c 100644 --- a/drivers/staging/greybus/greybus_authentication.h +++ b/drivers/staging/greybus/greybus_authentication.h @@ -41,7 +41,6 @@ #define CAP_AUTH_RESULT_CR_NO_KEY 0x03 #define CAP_AUTH_RESULT_CR_SIG_FAIL 0x04 =20 - /* IOCTL support */ struct cap_ioc_get_endpoint_uid { __u8 uid[8]; --=20 2.34.1 From nobody Mon Feb 9 05:38:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D258C6FD1D for ; Mon, 20 Mar 2023 23:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbjCTXFF (ORCPT ); Mon, 20 Mar 2023 19:05:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbjCTXE5 (ORCPT ); Mon, 20 Mar 2023 19:04:57 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BB26166C0; Mon, 20 Mar 2023 16:04:55 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id y4so53103238edo.2; Mon, 20 Mar 2023 16:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679353494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9X61cCXaE+hzLqtVmFIuVzim5tWEuqEAHzNDNeWntzc=; b=MvmeRaVSCe8klsomnf3mJnsEY51ulK1+6uxJnqgvu4urOW6quiwl+MzBMUbeL3GIA9 MsYN6pjF06/vTEQpcgnF2Rye6U95lEglqN9XFUXB8bpL54p7C0G0ZlqKdAfNsvkBVgXL gRApzuxZQ8QtfsL6LO7mOjCRHNfQj7FHvto8lXhcu2UNo+WC9Rb4CGOUlXm9/MNSnR5a 7FyAdhyz11UGMX7pbBcfnb/nyYbPp+POzxLW2UJTwtGFZaPvC+hMewzEYKKwssLDKGre Bv3q0rEwRh9XKY7Lmc192+7QOwV63qm0fMxgxFm4uI6//ciwEXEn+Qsk2vbd0U458P35 iY1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679353494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9X61cCXaE+hzLqtVmFIuVzim5tWEuqEAHzNDNeWntzc=; b=cbinIe5Q6CXfVZXrIqZcP55MSFofbo8s8Ue3RieWJR1hUOvXsW8K43JFI1j/8dJyzl p9LSdC1Q84MQ0OqimAYBx/UspeNLAQglv+uFBwvuXO7DnzBaw3SERSjAWsNmWpFrarbf DO8UWh8qwnKM7gZm0mp85UGYg06I+hXSiyexxmcnWJXD7YKQFx3i/yrdrEIXMU7E9ncV eC3OQ7ozLfLh348avxotqR+CmXPAJO3V27DRQDrMy9hvQgvx4/Ark0Hcqd8RxoZNpPBX sm5Vcy9BV7NTU3HsTNgGB9iBMHLxfOpOz6wCLfJD/3wW5zzqdtqFtINMLVGldSA/9ENM mJhw== X-Gm-Message-State: AO0yUKWCeNfqVn4wmiGUwH2B8QPsS5SWMHo4tfHPUhQs5BVmZADmMTYr bOUjEjDqntafAYALMWxLE1xhxKH57LY= X-Google-Smtp-Source: AK7set9bTQei7X1ViKH2Hqjo4mruuNKD5HQQDKBlF8sx8MkbMtWeQObb2XFIfbtGU/26Kmuny5+ksg== X-Received: by 2002:a17:906:a84:b0:91f:17a5:b359 with SMTP id y4-20020a1709060a8400b0091f17a5b359mr740698ejf.66.1679353494162; Mon, 20 Mar 2023 16:04:54 -0700 (PDT) Received: from alaa-emad.. ([41.42.177.251]) by smtp.gmail.com with ESMTPSA id v5-20020a17090690c500b0093188e8d478sm4956403ejw.103.2023.03.20.16.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 16:04:53 -0700 (PDT) From: Menna Mahmoud To: gregkh@linuxfoundation.org Cc: outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org, vireshk@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org, eng.mennamahmoud.mm@gmail.com, Julia Lawall Subject: [PATCH 2/3] staging: greybus: use inline function for macros Date: Tue, 21 Mar 2023 01:04:33 +0200 Message-Id: <1274302b52ae905dab6f75377d625598facbbdf1.1679352669.git.eng.mennamahmoud.mm@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Convert `to_gbphy_dev` and `to_gbphy_driver` macros into a static inline function. it is not great to have macro that use `container_of` macro, because from looking at the definition one cannot tell what type it applies to. One can get the same benefit from an efficiency point of view by making an inline function. Suggested-by: Julia Lawall Signed-off-by: Menna Mahmoud --- drivers/staging/greybus/gbphy.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbph= y.h index d4a225b76338..03a977056637 100644 --- a/drivers/staging/greybus/gbphy.h +++ b/drivers/staging/greybus/gbphy.h @@ -15,7 +15,10 @@ struct gbphy_device { struct list_head list; struct device dev; }; -#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev) +static inline struct gbphy_device *to_gbphy_dev(const struct device *d) +{ + return container_of(d, struct gbphy_device, dev); +} =20 static inline void *gb_gbphy_get_data(struct gbphy_device *gdev) { @@ -43,7 +46,10 @@ struct gbphy_driver { =20 struct device_driver driver; }; -#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver) +static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d) +{ + return container_of(d, struct gbphy_driver, driver); +} =20 int gb_gbphy_register_driver(struct gbphy_driver *driver, struct module *owner, const char *mod_name); --=20 2.34.1 From nobody Mon Feb 9 05:38:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB839C6FD1D for ; Mon, 20 Mar 2023 23:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229976AbjCTXFK (ORCPT ); Mon, 20 Mar 2023 19:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbjCTXE5 (ORCPT ); Mon, 20 Mar 2023 19:04:57 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6495E311DC; Mon, 20 Mar 2023 16:04:56 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id b20so20086826edd.1; Mon, 20 Mar 2023 16:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679353496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hHi5+GWz44QI22N2lgNwAXCVNfgTvzls3W9uzDI9R7I=; b=KHry5cV/WmYVdWszvx3gMaRricrhKOL/lzXv+ovvM9LdfGIZgyTz5TzaEbBYmrHe+B d6QZ6jCGQWNRv0XTqPoMbbR8LQY7UlBHpPrmWOasvI3x8kdub0KpMZN05I14Wkbg49z6 65WH61JSSg2xleRRoJoySE9nau0xIsxA0xM5siTeJsU7z+U/z1rPNfuoDKuGdzzjD0B0 SVhXx+xnP29qwhgvzh9eTCpHRwtQeMXlRv/Je+70jYIjN8QWj8znIoxds7MXCJDDRQGz 838MLVA7qu2ivpJ0P7b8s1YmRxU4C4L7PrhgtaVnnxN3jPAwyljEwdQsLF9miUVyLK52 pgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679353496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hHi5+GWz44QI22N2lgNwAXCVNfgTvzls3W9uzDI9R7I=; b=7yXtflMxJ0SHbqF4LCWacK5u3rSwT8849RobuG1arLlWVaKnUSi07cB2KUSOfSjNQ7 S+NO+MhAXN8rpYgVKtrfxgglF2jqIO3wq58cUVWCtpEo2+MKZpo5Xq/dx+ObXnIe7pv5 VQzUJJS144D2w7cfzwmemVPdc7SERICHOV+tX/g+AZc5C/f6kc621FYB9o08Po7dw9Gl pygr7/bco+ItTq/WoOKqVtW4wPRi44sFYc4RBjH+08vewT0kjI1lLesv/RR8MGJVl/GM +rppp631K1ckeptlcKyl2gPVUqeqT76pdwudkJgx0Pf6zoGUZlA7OA9nrUZyLpHyNj2A Tthg== X-Gm-Message-State: AO0yUKUFFL261d9mXgKIVTODCgzonrhSPHPTggaYPZm5X8OjctBIhkKH JkR6JOrL/RegFXsMSjw2hpA= X-Google-Smtp-Source: AK7set9oGrCiLwaTVVHNqARv9f/FYWeTuzzJVPjy0U7DAdWmYUUoV1H/27zWIC19MKSsWI6kfTIlNg== X-Received: by 2002:a17:906:f6d9:b0:930:1391:da7c with SMTP id jo25-20020a170906f6d900b009301391da7cmr637301ejb.60.1679353495859; Mon, 20 Mar 2023 16:04:55 -0700 (PDT) Received: from alaa-emad.. ([41.42.177.251]) by smtp.gmail.com with ESMTPSA id v5-20020a17090690c500b0093188e8d478sm4956403ejw.103.2023.03.20.16.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 16:04:55 -0700 (PDT) From: Menna Mahmoud To: gregkh@linuxfoundation.org Cc: outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org, vireshk@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org, eng.mennamahmoud.mm@gmail.com Subject: [PATCH 3/3] staging: greybus: remove unnecessary blank line Date: Tue, 21 Mar 2023 01:04:34 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unnecessary blank line before struct as reported by checkpatch: " CHECK: Please don't use multiple blank lines " Signed-off-by: Menna Mahmoud --- drivers/staging/greybus/pwm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c index 3fda172239d2..26d39e08c3b6 100644 --- a/drivers/staging/greybus/pwm.c +++ b/drivers/staging/greybus/pwm.c @@ -24,7 +24,6 @@ struct gb_pwm_chip { #define pwm_chip_to_gb_pwm_chip(chip) \ container_of(chip, struct gb_pwm_chip, chip) =20 - static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc) { struct gb_pwm_count_response response; --=20 2.34.1