From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 054CCC74A44 for ; Sat, 11 Mar 2023 21:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbjCKVvH (ORCPT ); Sat, 11 Mar 2023 16:51:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbjCKVvE (ORCPT ); Sat, 11 Mar 2023 16:51:04 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9308948E14 for ; Sat, 11 Mar 2023 13:50:36 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id s11so34437618edy.8 for ; Sat, 11 Mar 2023 13:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571433; x=1681163433; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e+E3iul2trnE9AHj4wvDXfrCtnPg8Q0ZfdG1IJq4SqQ=; b=bfo3xiabuGMhrdlbZSwKqkqKgZeoPtJbPH8r0n5evQhlf6UQCHyYmSg5HJzTf2wakS RxcxFen0zRgAFwTOKukKHuuM9W1kJyr55k7ZNV2oQS1kPXNh3IxTPf4TXq5D0Tn0q2oP s1D90qrKQbEIfnChlQjHhBskzv9QZAbvnQ0gq/beiKrqa2OtO/qKSaLK2OlIcH4/9Mba 6dcLQYV8kJ/h5z8E2+YuzrktD0WYdnaWZeU8g54BzEkpa1b7pZDs2O+W5NIrHuSLZeqT Rw4iyZPRRXyzBmrSZR7XOAYdaLT1VVgF9je/JMiU3xn/uyWSiiGnlwTtA+mOVZEpr8NQ uFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571433; x=1681163433; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e+E3iul2trnE9AHj4wvDXfrCtnPg8Q0ZfdG1IJq4SqQ=; b=lm1nw2gcU2T39NwegusLjQ7EH7NJLsL2Bq/4L+6FmkkxgyZLfI82b3wqJPsseYsNXt Hw6l7oSH1Qq08hMB53pFthBkQPJ90smsJFa+My/0tEsX8Kl+OmTLxNe7jS5WQknhGy5p I22tDDQ7eTEukMK222dEgFPrW2HfHgrN/uOSS5EIsy0u0gFcKwy+yPfWfLBTH0AAXutm 7/MxXFG10phyXq/a4d2nLnfNyEll8mHP1VVECQlzgAtvSLuINTfv9x32Lmva/nyeRFja 0cCxiIf35v3hdVQ2VZBmXxST86kCb0eiL5+qpcxk21jnjJUgJuHUcAr6q3z1pPjfs4jy t+rw== X-Gm-Message-State: AO0yUKX7EyWes7A8zrVWjCntEO7Q7RzqxoEV3EKS6GbihLXiS1MaRzKG zCOq7DnL4/IH0SSVVWRS3wYzQpJNmfs= X-Google-Smtp-Source: AK7set9ULwvvVP36i3vUVdIsFBYyLxTyoUX9Rh6hmVJR2cJoH0xep56z0OmOtChAnVPbiGdY+oQlxg== X-Received: by 2002:a17:906:208a:b0:8ae:cd8e:3957 with SMTP id 10-20020a170906208a00b008aecd8e3957mr10222277ejq.4.1678571433637; Sat, 11 Mar 2023 13:50:33 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id xc14-20020a170907074e00b008b904cb2bcdsm1543297ejb.11.2023.03.11.13.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:50:33 -0800 (PST) Date: Sat, 11 Mar 2023 22:50:31 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 01/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D in rtl92e_config_rf Message-ID: <3a62c8803712e7bf905886e670fe334a13d5d753.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused case RF90_PATH_C and case RF90_PATH_D. The termination condition for the loop is set to priv->num_total_rf_path =3D RTL819X_TOTAL_RF_PATH =3D 2. Because of this eRFPath cannot reach the values 2 for RF90_PATH_C and 3 for RF90_PATH_D. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/s= taging/rtl8192e/rtl8192e/r8190P_rtl8256.c index 73a86e1d0701..ecbcf0d5bb68 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c @@ -74,12 +74,10 @@ bool rtl92e_config_rf(struct net_device *dev) =20 switch (eRFPath) { case RF90_PATH_A: - case RF90_PATH_C: u4RegValue =3D rtl92e_get_bb_reg(dev, pPhyReg->rfintfs, bRFSI_RFENV); break; case RF90_PATH_B: - case RF90_PATH_D: u4RegValue =3D rtl92e_get_bb_reg(dev, pPhyReg->rfintfs, bRFSI_RFENV<<16); break; @@ -120,12 +118,10 @@ bool rtl92e_config_rf(struct net_device *dev) =20 switch (eRFPath) { case RF90_PATH_A: - case RF90_PATH_C: rtl92e_set_bb_reg(dev, pPhyReg->rfintfs, bRFSI_RFENV, u4RegValue); break; case RF90_PATH_B: - case RF90_PATH_D: rtl92e_set_bb_reg(dev, pPhyReg->rfintfs, bRFSI_RFENV<<16, u4RegValue); break; --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B42C6FD1F for ; Sat, 11 Mar 2023 21:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbjCKVvM (ORCPT ); Sat, 11 Mar 2023 16:51:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbjCKVvK (ORCPT ); Sat, 11 Mar 2023 16:51:10 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0908C35269 for ; Sat, 11 Mar 2023 13:50:48 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id k10so34350013edk.13 for ; Sat, 11 Mar 2023 13:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571446; x=1681163446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4UP85sr6iGf1vN76NAlj4OusJ0swvD759QkXT0aobgs=; b=V8Z5burVcUIEaPrUPaRikqCuZx+x7xilXlHj7OidoaJvXR2Xjz3j1QuhP8Ldmqw39W H2e4kDOQV6PN9w13Y6yuqFky8OjwaATjudE7ruXroJGAtm9i1zoa3m0fHxp1/uw3V7LB M69H8tkdSEE23kXEZXV6l3kjtWmLrDrX/jpiVuRzhHucAaqlZfrD29xFSC/9Q49e/gUi NAf8+p5ReVHhNDT431Z1zQa0uRFGuKXgd/0Kx1lcExDNcTZ1IHwzABiZxBKXm40tiX6Z wSHNL1zQH0DUBZ0/L/Fpjzmwdv1URQUsg99SJd4Xru+MugIqF8C1FJVNo/VEv4uX/QId zRZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571446; x=1681163446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4UP85sr6iGf1vN76NAlj4OusJ0swvD759QkXT0aobgs=; b=eY4VxjvF3WL83S/3IdtgWIpQCa2+S2dOr/fbCM3r/gAbEpHeMTZldjmLWNizy/UHmL 0rZxHPq6SuDuNX4nzL88YpbSARHUbvrazLoT2ozwIFiXppk92KyGDi1GE31T+pdeV8Df zTMij84GUqUReavpMFMsyV+Zrq3l7qd9poaDlMQmSk9v2GyWFWau3RoxZaXGRluwnMC8 hfXZ1L3AE4VUtCuwJ46RYmSsxLJJVzd1ilcqdwsfyxdiFeC/9oTv2ZVWbRCH25fCmhdT jb/eOX1eMHN9miInD8KWum4ykGBhYDY93JG1uqM51SfjzRLwX9sYR4b8eaBbvoaK6Q01 URWA== X-Gm-Message-State: AO0yUKVabvGT0WkgLc6mI9UULKFr1gEv81QQZWM3t1CK/5ksVSsRGg8h AWibPqRPZDyQabwhkLcTxgc= X-Google-Smtp-Source: AK7set/8S93Qxfz/hN4PvWI9qs6pVgh6/hZYFS+VchJfNFAwsvSJkPceNaueYpxxOjDIlPb8A66ocw== X-Received: by 2002:a17:906:19c:b0:8d3:be84:1cc6 with SMTP id 28-20020a170906019c00b008d3be841cc6mr9839752ejb.3.1678571446404; Sat, 11 Mar 2023 13:50:46 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id t16-20020a1709063e5000b0092435626c0asm413523eji.29.2023.03.11.13.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:50:46 -0800 (PST) Date: Sat, 11 Mar 2023 22:50:44 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 02/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfs Message-ID: <801d10f460acbf0601c78dee05c7b32f1628f3a8.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused priv->phy_reg_def[RF90_PATH_C].rfintfs and priv->phy_reg_def[RF90_PATH_D].rfintfs. The termination condition for the loop is set to priv->num_total_rf_path =3D RTL819X_TOTAL_RF_PATH =3D 2. Because of this pPhyReg =3D &priv->phy_reg_def[eRFPath]; pPhyReg cannot point to array element 2 for RF90_PATH_C and 3 for RF90_PATH_D. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index a9e83ba811b0..94b23cb53c36 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -358,8 +358,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devic= e *dev) =20 priv->phy_reg_def[RF90_PATH_A].rfintfs =3D rFPGA0_XAB_RFInterfaceSW; priv->phy_reg_def[RF90_PATH_B].rfintfs =3D rFPGA0_XAB_RFInterfaceSW; - priv->phy_reg_def[RF90_PATH_C].rfintfs =3D rFPGA0_XCD_RFInterfaceSW; - priv->phy_reg_def[RF90_PATH_D].rfintfs =3D rFPGA0_XCD_RFInterfaceSW; =20 priv->phy_reg_def[RF90_PATH_A].rfintfi =3D rFPGA0_XAB_RFInterfaceRB; priv->phy_reg_def[RF90_PATH_B].rfintfi =3D rFPGA0_XAB_RFInterfaceRB; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index f846f109ed98..616a4b62d4b9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -69,7 +69,6 @@ #define rFPGA0_XC_RFInterfaceOE 0x868 #define rFPGA0_XD_RFInterfaceOE 0x86c #define rFPGA0_XAB_RFInterfaceSW 0x870 -#define rFPGA0_XCD_RFInterfaceSW 0x874 #define rFPGA0_XAB_RFParameter 0x878 #define rFPGA0_XCD_RFParameter 0x87c #define rFPGA0_AnalogParameter1 0x880 --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3B23C61DA4 for ; Sat, 11 Mar 2023 21:51:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbjCKVvS (ORCPT ); Sat, 11 Mar 2023 16:51:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjCKVvN (ORCPT ); Sat, 11 Mar 2023 16:51:13 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8504580CD for ; Sat, 11 Mar 2023 13:50:59 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id r15so7262451edq.11 for ; Sat, 11 Mar 2023 13:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571458; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YZRztXr+yi1+VTQciICFP+x1t1LeLTBQI5V0a9mBDUU=; b=jrsv3JVCjkddk3WtVccMKFPD0rBNEkDOReh9EgvbeGHtlx4u4dBVST9TGLsYnSrik1 fCGRem74PcYWnMSFww/ZBYYkad9whVFjreKmBsKE3WvetcmhfYkkJOMHC3eBVkd3O2/e C/QWu25lRH9Llr0/i8kkw9F1f74a5VveDwjZItIUksclQQNdeUhV4b/wfOZUb6Y6tIgT Ii+SL6IDbR2NS2TuxJmjZsfVhQpFn+UMrBk50894jQRsuplBSocTwjAVWcGTFTBTveVI eHmMGOI9H4LGUV2PxLU2yMFpWhCKCmAJfN8rrOvZ4rKMFZtoZdM8r8i4shwg9Z9k4E86 YTTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571458; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YZRztXr+yi1+VTQciICFP+x1t1LeLTBQI5V0a9mBDUU=; b=o7z6BmKkyzvjGDbIdGjWC0mq006g25eV3/CRy52sRgt7GYhSbH1jPsUxO5GyD7SiDo yMu+094jBZJ05F6pfdR7D0nHoxjT9mv71bcwBJ5UlJOLE1a2UDmU5NSZGZTFkllG1MID pyNZzNJRDGBFnK5QMTzYR4KmI2c6c40Jn4SXMlraPuwSjR8tKZrhrNSQ0ig4n1O0vvby hMs7jV8e83nR8lV7AcizpARg0d9v/A44vrLNaaUI9Sy/FW6CYigmf+IS5FwP6b+x93GU deXDfi2wcU2OFEp3ujBwm5mR3epleIPuo25LnKojRdRBGxNlqf6sXdsiAlRXFzdjBKAY /8oQ== X-Gm-Message-State: AO0yUKV3XjgSXk4buigm14FlV9UAjMmUtRh6gra43RqC7nc+MvLxwRgq HlPh+8TH4azPGC2Q1ZSucg0= X-Google-Smtp-Source: AK7set+ZhZVUGQysFESJVoq6vJY3frd1ZVHwPO/IGJVBnFykg9eG0tx3wxoLTR87kSNaAYx3KLH9Pw== X-Received: by 2002:a17:906:d4:b0:878:5fa4:7443 with SMTP id 20-20020a17090600d400b008785fa47443mr5803546eji.3.1678571458319; Sat, 11 Mar 2023 13:50:58 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id nb17-20020a1709071c9100b00925867d821fsm125242ejc.120.2023.03.11.13.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:50:57 -0800 (PST) Date: Sat, 11 Mar 2023 22:50:56 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 03/12] staging: rtl8192e: Remove unused variable rfintfi Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused variable rfintfi because it is just once set and not used. Remove unused constants as well. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 1 - drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 5 ----- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 2 -- 3 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8190P_def.h index ac192254a4bb..adedcea5824e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -103,7 +103,6 @@ enum rf_optype { =20 struct bb_reg_definition { u32 rfintfs; - u32 rfintfi; u32 rfintfo; u32 rfintfe; u32 rf3wireOffset; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 94b23cb53c36..19fdf56e5e91 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -359,11 +359,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devi= ce *dev) priv->phy_reg_def[RF90_PATH_A].rfintfs =3D rFPGA0_XAB_RFInterfaceSW; priv->phy_reg_def[RF90_PATH_B].rfintfs =3D rFPGA0_XAB_RFInterfaceSW; =20 - priv->phy_reg_def[RF90_PATH_A].rfintfi =3D rFPGA0_XAB_RFInterfaceRB; - priv->phy_reg_def[RF90_PATH_B].rfintfi =3D rFPGA0_XAB_RFInterfaceRB; - priv->phy_reg_def[RF90_PATH_C].rfintfi =3D rFPGA0_XCD_RFInterfaceRB; - priv->phy_reg_def[RF90_PATH_D].rfintfi =3D rFPGA0_XCD_RFInterfaceRB; - priv->phy_reg_def[RF90_PATH_A].rfintfo =3D rFPGA0_XA_RFInterfaceOE; priv->phy_reg_def[RF90_PATH_B].rfintfo =3D rFPGA0_XB_RFInterfaceOE; priv->phy_reg_def[RF90_PATH_C].rfintfo =3D rFPGA0_XC_RFInterfaceOE; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index 616a4b62d4b9..5a47b232945f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -80,8 +80,6 @@ #define rFPGA0_XC_LSSIReadBack 0x8a8 #define rFPGA0_XD_LSSIReadBack 0x8ac #define rFPGA0_PSDReport 0x8b4 -#define rFPGA0_XAB_RFInterfaceRB 0x8e0 -#define rFPGA0_XCD_RFInterfaceRB 0x8e4 =20 /* Page 9 - RF mode & OFDM TxSC */ #define rFPGA1_RFMOD 0x900 --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C645C6FD1F for ; Sat, 11 Mar 2023 21:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbjCKVvb (ORCPT ); Sat, 11 Mar 2023 16:51:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230022AbjCKVvY (ORCPT ); Sat, 11 Mar 2023 16:51:24 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 304172821C for ; Sat, 11 Mar 2023 13:51:14 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id cy23so34343903edb.12 for ; Sat, 11 Mar 2023 13:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571473; x=1681163473; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w6eYhhrlk3QpT3Cy5PgSpe5WK/nBGJNkoN3eiwTzKHM=; b=YmBNqxtAmKGEE3Iiif77W37hUZVglXlHDs5uRhhFokF6a5Fv1yXiePXuf63OzZAqUn dB/OO3UQF3DcYJoH9s1FIGrAmLgCaVD/rOTV8nZo15I0pLgQxtGXo9AKobLW9g20KVLP zcNhH1qhMWBk7dTdX9u+bSnk/+J3oM5zEB43m37g7QAbyXXWkKyncS7myOtJKQ8F683v CW1pWIdPlC5iTzFPxsJUo6YQCPaicONJxYJ7hFRKck1RSm7ISuJDrwN8aUtsw8s8Gdh9 X4m1zmPtTfKHlEWFJ8c9wHZOtIRSQkhdxMGjLfLVnkJUxzvBNTGj606Q+loccB7sR5u4 a4gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571473; x=1681163473; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w6eYhhrlk3QpT3Cy5PgSpe5WK/nBGJNkoN3eiwTzKHM=; b=sDfMGJvyI0rsoxqKJmHqZBWkWaJ/Q4Xhtp3Lz3dBhiSnn4mBUA4YB8lZbrj8n5OVsb fXTzd6KH2LpxCcSw37rAWmUFPnh8SBslZYSyraDCgFa8qWe9oWtWW7OwAO9mDiQc6aJ+ acbBKu83hYJlB9HbPys6+zPUnCQ669FerhIN0RoC3uFug66UeJaYTg+L4yR4xcK90Kqj 0eDJIFqNkRLwtkZY1iPZOPdm0cIrxY8mHqQKwF8qHrkXJXM1KmzZDZxvpkg9u9KqFozm 2YQ0EDNCyodSAjIFa6FZ9cMsUxDFjdF4LRyZOU0tykphXTzSWH6Llk9raWYjtS27N0bv Iebg== X-Gm-Message-State: AO0yUKVP0U6BNmDU8SAxmG/oH+O3bc1z+gPHhNlaqwYLt+rFZAgys8m7 0dppzzE9ABf/PAd+AL4As/c= X-Google-Smtp-Source: AK7set8CUc6ZVyzcT29H+6rTnMe9iPW7jMymRuvZHdtUs/1Ax3OLDsqsoS4HDzmVlaoUiSeaFxaUMA== X-Received: by 2002:a17:906:74cd:b0:88f:1255:59c with SMTP id z13-20020a17090674cd00b0088f1255059cmr9241551ejl.1.1678571473218; Sat, 11 Mar 2023 13:51:13 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id g26-20020a170906869a00b008b23b22b062sm1507539ejx.114.2023.03.11.13.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:51:12 -0800 (PST) Date: Sat, 11 Mar 2023 22:51:11 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 04/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfo and ..fe Message-ID: <3c2237e2b4094129143594a5ab45691e9961e100.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused priv->phy_reg_def[RF90_PATH_C].rfintfo and priv->phy_reg_def[RF90_PATH_D].rfintfo and remove unused priv->phy_reg_def[RF90_PATH_C].rfintfe and priv->phy_reg_def[RF90_PATH_D].rfintfe. The termination condition for the loop is set to priv->num_total_rf_path =3D RTL819X_TOTAL_RF_PATH =3D 2. Because of this pPhyReg =3D &priv->phy_reg_def[eRFPath]; pPhyReg cannot point to array element 2 for RF90_PATH_C and 3 for RF90_PATH_D. Remove unused constants as well. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 ---- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 19fdf56e5e91..a0dd628b1bf5 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -361,13 +361,9 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devi= ce *dev) =20 priv->phy_reg_def[RF90_PATH_A].rfintfo =3D rFPGA0_XA_RFInterfaceOE; priv->phy_reg_def[RF90_PATH_B].rfintfo =3D rFPGA0_XB_RFInterfaceOE; - priv->phy_reg_def[RF90_PATH_C].rfintfo =3D rFPGA0_XC_RFInterfaceOE; - priv->phy_reg_def[RF90_PATH_D].rfintfo =3D rFPGA0_XD_RFInterfaceOE; =20 priv->phy_reg_def[RF90_PATH_A].rfintfe =3D rFPGA0_XA_RFInterfaceOE; priv->phy_reg_def[RF90_PATH_B].rfintfe =3D rFPGA0_XB_RFInterfaceOE; - priv->phy_reg_def[RF90_PATH_C].rfintfe =3D rFPGA0_XC_RFInterfaceOE; - priv->phy_reg_def[RF90_PATH_D].rfintfe =3D rFPGA0_XD_RFInterfaceOE; =20 priv->phy_reg_def[RF90_PATH_A].rf3wireOffset =3D rFPGA0_XA_LSSIParameter; priv->phy_reg_def[RF90_PATH_B].rf3wireOffset =3D rFPGA0_XB_LSSIParameter; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index 5a47b232945f..ec39de9e89fe 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -66,8 +66,6 @@ #define rFPGA0_XCD_SwitchControl 0x85c #define rFPGA0_XA_RFInterfaceOE 0x860 #define rFPGA0_XB_RFInterfaceOE 0x864 -#define rFPGA0_XC_RFInterfaceOE 0x868 -#define rFPGA0_XD_RFInterfaceOE 0x86c #define rFPGA0_XAB_RFInterfaceSW 0x870 #define rFPGA0_XAB_RFParameter 0x878 #define rFPGA0_XCD_RFParameter 0x87c --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA6CC61DA4 for ; Sat, 11 Mar 2023 21:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbjCKVvy (ORCPT ); Sat, 11 Mar 2023 16:51:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjCKVvw (ORCPT ); Sat, 11 Mar 2023 16:51:52 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75E1C521EF for ; Sat, 11 Mar 2023 13:51:27 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id x3so34375877edb.10 for ; Sat, 11 Mar 2023 13:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571486; x=1681163486; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tPkEkboXCEvGQOJLs4aF6ZhqJfv9Ne9y1/jeaB9rp0I=; b=FtDYtRmYudyXOa6xRqhPbHyRbYf0JybwghD58q/7JcyzUrHKjYrShq6EpUcS511R6r UMTkCiSqzisx95d30p2f8+qlwg4gor0JLj05gKTRCuiC4gHsP8V1z9ng29Pq2UCOhLRB ZxDdRS1nIqOydXAADA7zl9A7pL16vDUvTcUmQ+6NR0/C5iUN8fCcSvXKf3z64VRdPPsk Ss8nc/c2w+x3UavBPllw99x2gMiyrwjGImK8LzTdG62UBI/Z2qt/8EYntT9zSiDazOKq PU/EB3E+boklwoELUEI6U7eL85w3riKoBuROUySrwnLlHDAACr4GoRjNhFI+CCrtFONJ yfzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571486; x=1681163486; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tPkEkboXCEvGQOJLs4aF6ZhqJfv9Ne9y1/jeaB9rp0I=; b=W7CrmPPfYhDKfNmasKHiknOSe2GSOc2Giy8riZiaZUZ7vlSwKfp0PlXC6YfMimFXmd QmYgQSWKkf5pOUkJkzuimVgm7L5vuihLZiPH4J9RiNpYK2PXUAxQoSAIyukYBTP95Sq4 k47ZjQi/bUdeLg3lDj+/HgsiOyDYkAPqBn+BtNmCMQr99eW4+l+4hdh4FhgxQaAzEm6w 1o4v9ifhBnC4iByGdpgKy3s3xuMPS3Ec/AG8DujwFB+KJLtnCE55NjM9zKl3ofW2dheU uLI2b7006OmnGGWGg0Vp8NWBM97YhapZ1CrSvqZ1fFy+NWowb/aOZq0lYSBTkWesNZKI RlzA== X-Gm-Message-State: AO0yUKU29WIH0BTxhk/Woresec49YFlff1LMjL99+Txf6h1sLiM2eleD P4GPXNsSr515DNEZvLDf9so= X-Google-Smtp-Source: AK7set+KSxeA2XX82oS+cOYzeFW2kH1OcfNVnVtYJZt3RpnK5l9bcAzeMbrps6pBQwVDXX7gD/DtOA== X-Received: by 2002:a05:6402:280b:b0:4bc:edde:14e2 with SMTP id h11-20020a056402280b00b004bcedde14e2mr7419460ede.0.1678571485984; Sat, 11 Mar 2023 13:51:25 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id z13-20020a50cd0d000000b004acbda55f6bsm1640543edi.27.2023.03.11.13.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:51:25 -0800 (PST) Date: Sat, 11 Mar 2023 22:51:23 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 05/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rf3wireOffset Message-ID: <180723eee77f70ffda1f8f0656c2f256f005c4ef.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused priv->phy_reg_def[RF90_PATH_C].rf3wireOffset and priv->phy_reg_def[RF90_PATH_D].rf3wireOffset. rf3wireOffset is used in _rtl92e_phy_rf_read and _rtl92e_phy_rf_write which are used in: rtl92e_set_rf_reg and rtl92e_get_rf_reg are used in: rtl92e_set_bandwidth (eRFPath only for 0 and 1) rtl92e_config_rf (eRFPath only for 0 and 1) _rtl92e_phy_switch_channel_step (eRFPath only for 0 and 1) _rtl92e_dm_check_tx_power_tracking_thermal (eRFPath only for 0) rtl92e_check_bb_and_rf is used in: rtl92e_config_rf (eRFPath only for 0 and 1) _rtl92e_bb_config_para_file (eRFPath only for 0) rtl92e_config_rf_path is used in: rtl92e_config_rf (eRFPath only for 0 and 1) Remove dead code and constants. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index a0dd628b1bf5..1013ab95bc7b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -367,8 +367,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devic= e *dev) =20 priv->phy_reg_def[RF90_PATH_A].rf3wireOffset =3D rFPGA0_XA_LSSIParameter; priv->phy_reg_def[RF90_PATH_B].rf3wireOffset =3D rFPGA0_XB_LSSIParameter; - priv->phy_reg_def[RF90_PATH_C].rf3wireOffset =3D rFPGA0_XC_LSSIParameter; - priv->phy_reg_def[RF90_PATH_D].rf3wireOffset =3D rFPGA0_XD_LSSIParameter; =20 priv->phy_reg_def[RF90_PATH_A].rfLSSI_Select =3D rFPGA0_XAB_RFParameter; priv->phy_reg_def[RF90_PATH_B].rfLSSI_Select =3D rFPGA0_XAB_RFParameter; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index ec39de9e89fe..19acc44648e1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -58,8 +58,6 @@ #define rFPGA0_XD_HSSIParameter2 0x83c #define rFPGA0_XA_LSSIParameter 0x840 #define rFPGA0_XB_LSSIParameter 0x844 -#define rFPGA0_XC_LSSIParameter 0x848 -#define rFPGA0_XD_LSSIParameter 0x84c #define rFPGA0_RFWakeUpParameter 0x850 #define rFPGA0_RFSleepUpParameter 0x854 #define rFPGA0_XAB_SwitchControl 0x858 --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9E2CC61DA4 for ; Sat, 11 Mar 2023 21:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjCKVwU (ORCPT ); Sat, 11 Mar 2023 16:52:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjCKVwS (ORCPT ); Sat, 11 Mar 2023 16:52:18 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF5969057 for ; Sat, 11 Mar 2023 13:51:45 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id g10so5580494eda.1 for ; Sat, 11 Mar 2023 13:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571499; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OkZ4Olpuxh5E3cDSkJctHgzhe5euz/pqRRghSABvVlc=; b=SEht0PddCHabZafa5KLInfvaUrCDhb/wI+0h7XhFmCtjLMwojaI8lGBbdmwoVCWRqD jmbEJ8pFyMl7u6tFvBGLwun0ozPTG8/JLtjgJSpQTBzTBBtlJWYvOhI4b5NNt/YdXsyE bsfJ2f62XRrBtIZaWDiAtojkaiC6yUiM5a4800H/bAR7QvtR59W3InOdlmZhnf+zObC4 AkEwSD54I2HY/BqBjhfASqM3C6/ZdElhLfOTzVjCNv2d6VCfeasJzWqQw+zvqngO5/4B 4hxPiDssEYxsIfaHQNkLct3YiTUDcX8jZDrzxDcaYWqAGpl8x8Pg1wVws6NOUWITBwsO BV5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571499; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OkZ4Olpuxh5E3cDSkJctHgzhe5euz/pqRRghSABvVlc=; b=ZS1Cj8JUG4WmYMw92z6mLINwPdrrou7vk/ttGTkz08LOlw83huO5Cj5ou+Yq0ysA05 BvvKNLsPMJgflbwgmf66Y0KonruWbSoyXRUCytljeGeGSVf2epTg2T3aYYsGrkLOQTCb UojFYWOfCfzrOskqD5Jk5bUZcK2yxk5etsSfwPSjEdzkiqPRP//qoFE4DIhER0SFKcdK kHuW0zuiMW9oZ37XcacO6nEn3F3RMla2r29NEhmPP41pqy9HYyVmSEy2jGfUOP/iUylW LiytGwihwYxK7bDpL+0i5FEkDmSoqM2nZZLsbu71FOgJfB3WDhe4IDkqQ+Hd9YiP1yi3 3YZQ== X-Gm-Message-State: AO0yUKUVbkCQlbAA/4OgtmhexHNksNP0iPMXZPELZquANJ+4rXzSZOWB GTaPRb45THRZ7ZnkgBXXDg9vNTzwux0= X-Google-Smtp-Source: AK7set9YGzcuNatrSwhGf54AWthgBOslDCEbODCL7EQXYiF40b4xcRx0iaJoZ5cBCUHhHLsjK3HdAA== X-Received: by 2002:a17:906:5352:b0:8b1:814e:c83d with SMTP id j18-20020a170906535200b008b1814ec83dmr6341330ejo.6.1678571498898; Sat, 11 Mar 2023 13:51:38 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id g2-20020a1709062da200b008cf377e8795sm1497633eji.199.2023.03.11.13.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:51:38 -0800 (PST) Date: Sat, 11 Mar 2023 22:51:36 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 06/12] staging: rtl8192e: Remove unused variable rfLSSI_Select and rfTxGainStage Message-ID: <48f05998f4d2fe2df88ff14860cc8615dd72734d.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused variable rfLSSI_Select and rfTxGainStage because they are just once set and not used. Remove unused constants as well. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 ---------- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 2 -- 3 files changed, 14 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8190P_def.h index adedcea5824e..2236c1aaf335 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -106,8 +106,6 @@ struct bb_reg_definition { u32 rfintfo; u32 rfintfe; u32 rf3wireOffset; - u32 rfLSSI_Select; - u32 rfTxGainStage; u32 rfHSSIPara1; u32 rfHSSIPara2; u32 rfSwitchControl; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 1013ab95bc7b..87f28718e732 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -368,16 +368,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devi= ce *dev) priv->phy_reg_def[RF90_PATH_A].rf3wireOffset =3D rFPGA0_XA_LSSIParameter; priv->phy_reg_def[RF90_PATH_B].rf3wireOffset =3D rFPGA0_XB_LSSIParameter; =20 - priv->phy_reg_def[RF90_PATH_A].rfLSSI_Select =3D rFPGA0_XAB_RFParameter; - priv->phy_reg_def[RF90_PATH_B].rfLSSI_Select =3D rFPGA0_XAB_RFParameter; - priv->phy_reg_def[RF90_PATH_C].rfLSSI_Select =3D rFPGA0_XCD_RFParameter; - priv->phy_reg_def[RF90_PATH_D].rfLSSI_Select =3D rFPGA0_XCD_RFParameter; - - priv->phy_reg_def[RF90_PATH_A].rfTxGainStage =3D rFPGA0_TxGainStage; - priv->phy_reg_def[RF90_PATH_B].rfTxGainStage =3D rFPGA0_TxGainStage; - priv->phy_reg_def[RF90_PATH_C].rfTxGainStage =3D rFPGA0_TxGainStage; - priv->phy_reg_def[RF90_PATH_D].rfTxGainStage =3D rFPGA0_TxGainStage; - priv->phy_reg_def[RF90_PATH_A].rfHSSIPara1 =3D rFPGA0_XA_HSSIParameter1; priv->phy_reg_def[RF90_PATH_B].rfHSSIPara1 =3D rFPGA0_XB_HSSIParameter1; priv->phy_reg_def[RF90_PATH_C].rfHSSIPara1 =3D rFPGA0_XC_HSSIParameter1; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index 19acc44648e1..b68e84dd003f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -65,8 +65,6 @@ #define rFPGA0_XA_RFInterfaceOE 0x860 #define rFPGA0_XB_RFInterfaceOE 0x864 #define rFPGA0_XAB_RFInterfaceSW 0x870 -#define rFPGA0_XAB_RFParameter 0x878 -#define rFPGA0_XCD_RFParameter 0x87c #define rFPGA0_AnalogParameter1 0x880 #define rFPGA0_AnalogParameter2 0x884 #define rFPGA0_AnalogParameter3 0x888 --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9716FC6FD1F for ; Sat, 11 Mar 2023 21:52:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbjCKVwa (ORCPT ); Sat, 11 Mar 2023 16:52:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjCKVw1 (ORCPT ); Sat, 11 Mar 2023 16:52:27 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 606AD5F6FA for ; Sat, 11 Mar 2023 13:51:57 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id r15so7266980edq.11 for ; Sat, 11 Mar 2023 13:51:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571511; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3lz0rCujQhVibf0Ri4YpJvVDSlapNGCLqwJwhuUj9iY=; b=g1XROsxLntlHnDJmSTz0qt7nem4Tid9+eF8wErcrgZHZhL1eIYgs9nYN/R8tlQbXPj v8Kx2VhvaP7UK2z3UI8ahK/Lgj62VHFBDaSpIZrwidgWgGxn2fPOCmhjna9aK82KBrHZ YJoFx7d/mvdbbIfpcd1B6dN8oO6mQvLzqzFzR/TA3rnWP3+6A2yTonlUNfGrDBcIeA34 5XFKybm6Ys16llD/wpa/Le9dpfNgbUbIET9gdOZ6M2ppL/8VHXA4W/mwLNxr0UKkdCFQ hEIML6UWRMCblTRLFXYP2UwlCV2QzDEWq0bCzmFTQoBUkBecP8TlkoLTeIqYNPS5MgG3 VDOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571511; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3lz0rCujQhVibf0Ri4YpJvVDSlapNGCLqwJwhuUj9iY=; b=QAuEh4yH4BbIbV60YzSK/xwwYln+KfA6anP1Ha9up7T/Q1P2uwolcFIeqbkPmfEjhF emUoU6Hmk9eJo8gXWAcG/qq/hTktCfnqDv+JMa2G558EuAfmTnqA9HYPf+7k9JZdyed4 4yEC0sZAGOqXCkvoomECXpUMfZh3a6td6qavOo/CrZvYuSZWaDOVUMQ0P9WVFyvozi2c dCzpBxq6LUpZmEsqcWzRzJM+4KDa4zQ5obdpXpiH4NgHZqKjgvo9+pHRENqSodL9DvYM s93YpyNgQ2lBFn+zUnunLslPg3/IqpBvwNANbSywwCiyc2VPr0i7Fv+YJksETR36kO3k AM0g== X-Gm-Message-State: AO0yUKWGnSvUaGatsN4f1MSWHfzTRKoOJ183osMaFInH3Ll441nkbpDo r9VCFFJoLdJWuwpgFN2Vt7S+DZN4EWE= X-Google-Smtp-Source: AK7set9AZWxbuta0wo1kYU6KhCXTkFmoJ1saYc/52/4fbe7kyUJgiPxYbrNgI/MDuhWs4ZbIZFuY0A== X-Received: by 2002:a17:906:d4:b0:878:5fa4:7443 with SMTP id 20-20020a17090600d400b008785fa47443mr5804894eji.3.1678571511297; Sat, 11 Mar 2023 13:51:51 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id q21-20020a170906389500b008b907006d5dsm1522934ejd.173.2023.03.11.13.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:51:50 -0800 (PST) Date: Sat, 11 Mar 2023 22:51:49 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 07/12] staging: rtl8192e: Remove unused variable rfHSSIPara1 and rfSwitchControl Message-ID: <5f13420ce5598d447aaad0fe43b807467e0a15bb.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused variable rfHSSIPara1 and rfSwitchControl because they are just once set and not used. Remove unused constants as well. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 ---------- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 6 ------ 3 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8190P_def.h index 2236c1aaf335..d42eac4b6012 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -106,9 +106,7 @@ struct bb_reg_definition { u32 rfintfo; u32 rfintfe; u32 rf3wireOffset; - u32 rfHSSIPara1; u32 rfHSSIPara2; - u32 rfSwitchControl; u32 rfAGCControl1; u32 rfAGCControl2; u32 rfRxIQImbalance; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 87f28718e732..add3de156e09 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -368,21 +368,11 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_dev= ice *dev) priv->phy_reg_def[RF90_PATH_A].rf3wireOffset =3D rFPGA0_XA_LSSIParameter; priv->phy_reg_def[RF90_PATH_B].rf3wireOffset =3D rFPGA0_XB_LSSIParameter; =20 - priv->phy_reg_def[RF90_PATH_A].rfHSSIPara1 =3D rFPGA0_XA_HSSIParameter1; - priv->phy_reg_def[RF90_PATH_B].rfHSSIPara1 =3D rFPGA0_XB_HSSIParameter1; - priv->phy_reg_def[RF90_PATH_C].rfHSSIPara1 =3D rFPGA0_XC_HSSIParameter1; - priv->phy_reg_def[RF90_PATH_D].rfHSSIPara1 =3D rFPGA0_XD_HSSIParameter1; - priv->phy_reg_def[RF90_PATH_A].rfHSSIPara2 =3D rFPGA0_XA_HSSIParameter2; priv->phy_reg_def[RF90_PATH_B].rfHSSIPara2 =3D rFPGA0_XB_HSSIParameter2; priv->phy_reg_def[RF90_PATH_C].rfHSSIPara2 =3D rFPGA0_XC_HSSIParameter2; priv->phy_reg_def[RF90_PATH_D].rfHSSIPara2 =3D rFPGA0_XD_HSSIParameter2; =20 - priv->phy_reg_def[RF90_PATH_A].rfSwitchControl =3D rFPGA0_XAB_SwitchContr= ol; - priv->phy_reg_def[RF90_PATH_B].rfSwitchControl =3D rFPGA0_XAB_SwitchContr= ol; - priv->phy_reg_def[RF90_PATH_C].rfSwitchControl =3D rFPGA0_XCD_SwitchContr= ol; - priv->phy_reg_def[RF90_PATH_D].rfSwitchControl =3D rFPGA0_XCD_SwitchContr= ol; - priv->phy_reg_def[RF90_PATH_A].rfAGCControl1 =3D rOFDM0_XAAGCCore1; priv->phy_reg_def[RF90_PATH_B].rfAGCControl1 =3D rOFDM0_XBAGCCore1; priv->phy_reg_def[RF90_PATH_C].rfAGCControl1 =3D rOFDM0_XCAGCCore1; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index b68e84dd003f..5062be507a30 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -48,20 +48,14 @@ #define rFPGA0_TxGainStage 0x80c #define rFPGA0_RFTiming1 0x810 #define rFPGA0_RFTiming2 0x814 -#define rFPGA0_XA_HSSIParameter1 0x820 #define rFPGA0_XA_HSSIParameter2 0x824 -#define rFPGA0_XB_HSSIParameter1 0x828 #define rFPGA0_XB_HSSIParameter2 0x82c -#define rFPGA0_XC_HSSIParameter1 0x830 #define rFPGA0_XC_HSSIParameter2 0x834 -#define rFPGA0_XD_HSSIParameter1 0x838 #define rFPGA0_XD_HSSIParameter2 0x83c #define rFPGA0_XA_LSSIParameter 0x840 #define rFPGA0_XB_LSSIParameter 0x844 #define rFPGA0_RFWakeUpParameter 0x850 #define rFPGA0_RFSleepUpParameter 0x854 -#define rFPGA0_XAB_SwitchControl 0x858 -#define rFPGA0_XCD_SwitchControl 0x85c #define rFPGA0_XA_RFInterfaceOE 0x860 #define rFPGA0_XB_RFInterfaceOE 0x864 #define rFPGA0_XAB_RFInterfaceSW 0x870 --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED437C61DA4 for ; Sat, 11 Mar 2023 21:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbjCKVwc (ORCPT ); Sat, 11 Mar 2023 16:52:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbjCKVw3 (ORCPT ); Sat, 11 Mar 2023 16:52:29 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 202E46A43A for ; Sat, 11 Mar 2023 13:52:06 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id j11so34458884edq.4 for ; Sat, 11 Mar 2023 13:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571524; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XTTDljF28vO5H18k+KEi+7UKj1Xzue+t1xSVjk5WnDY=; b=Pk/oE6M2D/waIVTAwHCuGea9qIaLSfIwfe4ngILjkk3KWDiVrIxMHgBUP0qAUjWQdc Fmwp6jM6ObotUih74SJrCNcTfg8RRaaZyZ7H/80HgZE9KK0Q6pnegkYQ0AWPzpdRpxgX tTh2zPWZdYvelCMlcmn9L8DGMWlh0Jli4nAPcPpW+wO+Kr8jnMo4nuaVaAa7Mo/QMM9d AG9DNMUBWgAq/IH6euX+Vd1gCWbfV6otLmxXKz97ULORq4is5mxWOjJipt5LUdWNMMqr 366w341BVFUyebGfrgfIOKtOvDz1dWOOP3XIGiGLTEtIa1ONRRkD2J+bXS3V+CYr9Vgt dH4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571524; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XTTDljF28vO5H18k+KEi+7UKj1Xzue+t1xSVjk5WnDY=; b=EcGXzwdn0LnzSv7YeXsrGfGB3u6F0tEU6ZqfmcjRjXMUsDkFJ2xHCqbh9mrR9H910R 7CHcHxtnSciiLFoFTVOAZFS4k0U55WuBHX63RSAOzKVIaNlEGIWOyFOg66E2LrwnUJFg MgBQRUnNcsSsx8E/qOZlkvZWYud1/PebqV5ASK6j9KNL6fa/U/h3S/q6bDN5P06aKYxP 053ONxPAtQ8xQPGcxZtPRUMVjoBFNbyrVgUY4NY+zPmrvQjtNoJphn+/MKqwP12KDklI kCv8AuxjyhnbI88q5phULPpWpz+11XcVsV80jQTB8l6lRaCpVM16oY9jtRylbSNIxbyv AnAA== X-Gm-Message-State: AO0yUKXelDJDJt5poku0bhEaIiFUUX1TWWaFeZuS5yhqDNUbrMbxX/ZG U69wjichZpJimvnVF9SsQ/MVZDPjvWY= X-Google-Smtp-Source: AK7set+PHiZciZpW3dAVj9Wm59PkUQPLopsZKcnZlvywoLG/k0MX27HZwGyWlmuIlOxvJMx0zLNFTw== X-Received: by 2002:a17:906:15d:b0:888:346a:fb48 with SMTP id 29-20020a170906015d00b00888346afb48mr7103708ejh.0.1678571524440; Sat, 11 Mar 2023 13:52:04 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id hz11-20020a1709072ceb00b008e51a1fd7bfsm1532653ejc.172.2023.03.11.13.52.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:52:04 -0800 (PST) Date: Sat, 11 Mar 2023 22:52:02 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 08/12] staging: rtl8192e: Remove unused variable rfAGCControl1 and rfAGCControl2 Message-ID: <0f191930597517cf88eb6effd4c20a46c99571ad.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused variable rfAGCControl1 and rfAGCControl2 because they are just once set and not used. Remove unused constants as well. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 ---------- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 4 ---- 3 files changed, 16 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8190P_def.h index d42eac4b6012..a5d99891688d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -107,8 +107,6 @@ struct bb_reg_definition { u32 rfintfe; u32 rf3wireOffset; u32 rfHSSIPara2; - u32 rfAGCControl1; - u32 rfAGCControl2; u32 rfRxIQImbalance; u32 rfRxAFE; u32 rfTxIQImbalance; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index add3de156e09..32806bcc953a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -373,16 +373,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devi= ce *dev) priv->phy_reg_def[RF90_PATH_C].rfHSSIPara2 =3D rFPGA0_XC_HSSIParameter2; priv->phy_reg_def[RF90_PATH_D].rfHSSIPara2 =3D rFPGA0_XD_HSSIParameter2; =20 - priv->phy_reg_def[RF90_PATH_A].rfAGCControl1 =3D rOFDM0_XAAGCCore1; - priv->phy_reg_def[RF90_PATH_B].rfAGCControl1 =3D rOFDM0_XBAGCCore1; - priv->phy_reg_def[RF90_PATH_C].rfAGCControl1 =3D rOFDM0_XCAGCCore1; - priv->phy_reg_def[RF90_PATH_D].rfAGCControl1 =3D rOFDM0_XDAGCCore1; - - priv->phy_reg_def[RF90_PATH_A].rfAGCControl2 =3D rOFDM0_XAAGCCore2; - priv->phy_reg_def[RF90_PATH_B].rfAGCControl2 =3D rOFDM0_XBAGCCore2; - priv->phy_reg_def[RF90_PATH_C].rfAGCControl2 =3D rOFDM0_XCAGCCore2; - priv->phy_reg_def[RF90_PATH_D].rfAGCControl2 =3D rOFDM0_XDAGCCore2; - priv->phy_reg_def[RF90_PATH_A].rfRxIQImbalance =3D rOFDM0_XARxIQImbalance; priv->phy_reg_def[RF90_PATH_B].rfRxIQImbalance =3D rOFDM0_XBRxIQImbalance; priv->phy_reg_def[RF90_PATH_C].rfRxIQImbalance =3D rOFDM0_XCRxIQImbalance; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index 5062be507a30..d0ea7e06f0f7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -117,13 +117,9 @@ #define rOFDM0_CCADropThreshold 0xc48 #define rOFDM0_ECCAThreshold 0xc4c /* Energy CCA */ #define rOFDM0_XAAGCCore1 0xc50 -#define rOFDM0_XAAGCCore2 0xc54 #define rOFDM0_XBAGCCore1 0xc58 -#define rOFDM0_XBAGCCore2 0xc5c #define rOFDM0_XCAGCCore1 0xc60 -#define rOFDM0_XCAGCCore2 0xc64 #define rOFDM0_XDAGCCore1 0xc68 -#define rOFDM0_XDAGCCore2 0xc6c #define rOFDM0_AGCParameter1 0xc70 #define rOFDM0_AGCParameter2 0xc74 #define rOFDM0_AGCRSSITable 0xc78 --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C5FC6FD1F for ; Sat, 11 Mar 2023 21:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbjCKVwo (ORCPT ); Sat, 11 Mar 2023 16:52:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbjCKVwk (ORCPT ); Sat, 11 Mar 2023 16:52:40 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F048D6C6BD for ; Sat, 11 Mar 2023 13:52:18 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id r15so7269287edq.11 for ; Sat, 11 Mar 2023 13:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571537; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TdvdZcJwqOxSED82BHJ454QJEkvE45rumYb+PdMANhk=; b=KbQE9gQ4W/aLSm2gJ9USlzEK9E5MDzHVSJHAzEOumHqjyaHmrM59p+IYOJgO7jdKSm qwQ0OUWtQCq3/rXRCkuAeu6ui3MnC5M9DjyoEU+Kp30A6XtKcoZvKMeWmkE1wXdCs6Os t7GPCYMc9kG+/WxxB2zZ8Ruvc3gIKQTCQaSWHAcT3pmiy0OQJhCzlQtAYjrXgVIQukDq SeO2uy1SnpMT0BfpQr8xFWfHl265T10CNW5NF7eOF/bKBKV/JwF/Z3roY5XKGSleAf0o Eus6x+poIQCGeCNzd1AVlJuBcWIVappwUB3CoWYw+nUl//NtlkmGXTQzmebaTuPkGIAD NKBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571537; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TdvdZcJwqOxSED82BHJ454QJEkvE45rumYb+PdMANhk=; b=0orTdd5jwXYaR6KUdbNd3BcxNuRP2aBBtAGX8So2UUnMl0lOvlma6G5pEAAcjsvU0l 1vScfQtkK4882RvfK38EG5GKVSfczpLpoTRVBnkjTHytk+oLx8sbdPh/Sk8H3DIAyrox Nc0q15eZQvq+6eYrPEWuYY9FbEdFH6r8UifIGYmfDFDiZW4Pwvn0rI0a7nbyYuB1n1xa 4p9JG3aasx35pFQb1EW9C9h5zjsiKbYM4GQHvl05QJFFEgqQsws/R8X2kxGDt4zsHAFe JUC0mnRe3yySMlpRrIVBviX/xjhYVJ8VnEd6xSf2xJD2QIULC/nekXCp8yK5K0AjzSE3 UCfQ== X-Gm-Message-State: AO0yUKW0nrjqQ3kRJLwKzNWAD5kA4MRFYil0nrdMl6y5AXoa+fL2SrBx +qNTgo/O10pmFIVVPlh3F/Q= X-Google-Smtp-Source: AK7set/9/649wHsySz4J19RJ3v5gomkREh8afFzkaSUa9/qY3LFUVpM1jnwTCAC10MlTMWFU1ohPSA== X-Received: by 2002:a17:906:7493:b0:878:4bda:2011 with SMTP id e19-20020a170906749300b008784bda2011mr6174866ejl.4.1678571537333; Sat, 11 Mar 2023 13:52:17 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id bg4-20020a170906a04400b008b1797b77b2sm1503688ejb.221.2023.03.11.13.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:52:16 -0800 (PST) Date: Sat, 11 Mar 2023 22:52:15 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 09/12] staging: rtl8192e: Remove unused variable rfRxIQImbalance and rfRxAFE Message-ID: <1d578fc962c938e76bc0df529a3c24bba7abe049.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused variable rfRxIQImbalance and rfRxAFE because they are just once set and not used. Remove unused constants with commenting line. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 ---------- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 9 --------- 3 files changed, 21 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8190P_def.h index a5d99891688d..a5c2ff5b4260 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -107,8 +107,6 @@ struct bb_reg_definition { u32 rfintfe; u32 rf3wireOffset; u32 rfHSSIPara2; - u32 rfRxIQImbalance; - u32 rfRxAFE; u32 rfTxIQImbalance; u32 rfTxAFE; u32 rfLSSIReadBack; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 32806bcc953a..5b63b9eac090 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -373,16 +373,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devi= ce *dev) priv->phy_reg_def[RF90_PATH_C].rfHSSIPara2 =3D rFPGA0_XC_HSSIParameter2; priv->phy_reg_def[RF90_PATH_D].rfHSSIPara2 =3D rFPGA0_XD_HSSIParameter2; =20 - priv->phy_reg_def[RF90_PATH_A].rfRxIQImbalance =3D rOFDM0_XARxIQImbalance; - priv->phy_reg_def[RF90_PATH_B].rfRxIQImbalance =3D rOFDM0_XBRxIQImbalance; - priv->phy_reg_def[RF90_PATH_C].rfRxIQImbalance =3D rOFDM0_XCRxIQImbalance; - priv->phy_reg_def[RF90_PATH_D].rfRxIQImbalance =3D rOFDM0_XDRxIQImbalance; - - priv->phy_reg_def[RF90_PATH_A].rfRxAFE =3D rOFDM0_XARxAFE; - priv->phy_reg_def[RF90_PATH_B].rfRxAFE =3D rOFDM0_XBRxAFE; - priv->phy_reg_def[RF90_PATH_C].rfRxAFE =3D rOFDM0_XCRxAFE; - priv->phy_reg_def[RF90_PATH_D].rfRxAFE =3D rOFDM0_XDRxAFE; - priv->phy_reg_def[RF90_PATH_A].rfTxIQImbalance =3D rOFDM0_XATxIQImbalance; priv->phy_reg_def[RF90_PATH_B].rfTxIQImbalance =3D rOFDM0_XBTxIQImbalance; priv->phy_reg_def[RF90_PATH_C].rfTxIQImbalance =3D rOFDM0_XCTxIQImbalance; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index d0ea7e06f0f7..78e90bf5d79f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -98,15 +98,6 @@ #define rOFDM0_TRxPathEnable 0xc04 #define rOFDM0_TRMuxPar 0xc08 #define rOFDM0_TRSWIsolation 0xc0c -/* RxIQ DC offset, Rx digital filter, DC notch filter */ -#define rOFDM0_XARxAFE 0xc10 -#define rOFDM0_XARxIQImbalance 0xc14 /* RxIQ imbalance matrix */ -#define rOFDM0_XBRxAFE 0xc18 -#define rOFDM0_XBRxIQImbalance 0xc1c -#define rOFDM0_XCRxAFE 0xc20 -#define rOFDM0_XCRxIQImbalance 0xc24 -#define rOFDM0_XDRxAFE 0xc28 -#define rOFDM0_XDRxIQImbalance 0xc2c #define rOFDM0_RxDetector1 0xc30 /* PD, BW & SBD */ #define rOFDM0_RxDetector2 0xc34 /* SBD */ #define rOFDM0_RxDetector3 0xc38 /* Frame Sync */ --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F27C6FD1F for ; Sat, 11 Mar 2023 21:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbjCKVxI (ORCPT ); Sat, 11 Mar 2023 16:53:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbjCKVwz (ORCPT ); Sat, 11 Mar 2023 16:52:55 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62AFF74A4C for ; Sat, 11 Mar 2023 13:52:36 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id fd5so571214edb.7 for ; Sat, 11 Mar 2023 13:52:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571554; x=1681163554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CLM1DMdObV7hO1p/r6vG5OZBTBXPbt7jRsRiNLFKp3Q=; b=T3xGwj5RM/C7sIBdSZr6qko+CotZEUqpuXLdHlUU30M5k1DtpX2ScKCKB43OVJShpM hVUV3zXE9JenvAJeLuudpAPpVUzxHHemqjhwy3yU9ASaL/6YibrYcwVhspxPqNnVxDrd URhtMCxfvzchF60wLwYiHgope0zVDZIVMEDS3wt6w1FGEKoOQG42u+KOcsc/gtGKmc6G +Eezl5BobgE/+whQPiZTzPcmiN+mQAOn4a3t1jaPgHZhsQJh9jdxG41rrwWHd0LXMV1a xXt7wHA1H91Jxj5SDEFBYOpwqNQ3yZyI4ZQYafgaqWPGITgQxzjO7kj5uSYF8ho5Zg1H 9BQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571554; x=1681163554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CLM1DMdObV7hO1p/r6vG5OZBTBXPbt7jRsRiNLFKp3Q=; b=Sa0IUlSihUva2kMAlFpOdNz/zPNXQ+MJbqsS78wHLHoxH21m5VGoHG/1OfcWIp68ZF DmjEcAgQuCvdZvQdogjUArSuHhRMpd8iw/+QlcrSjRBWwC8rAjlZaQ0TzFJ5F6vS3X/a LCAF7ekJv3F37X1uvm4pJKEB+50389nPDOJ1vaAEhbF1KGmIlU8cGLZOK/ppwCPckY+D ESlRDtB5XAhBOM1GUu1/cpabhTK8ioBmt4jxnKo3G1oz35erUfjeeTm8vkW+2Rv1k07w qpfdpqLVUUva6R+m61L7kXWKpjql3MMZ/e3bgGPGeSk70Ik99HQSl0WmeWl0GXU1M8t7 4IQg== X-Gm-Message-State: AO0yUKVqS6iFXhiK2VY4sRdYdCE8qCmxebSolPh2oXO8TS7DJO+j/0Il 1QAOjlzAq2K5exFXZHS9LxM= X-Google-Smtp-Source: AK7set/qZf77ad1RUfZHDcBWbLvREMofsCiPAcIhbCVLCTbsOdpZzxchCSPIe7Q1lCsWiE0V/a9Ldw== X-Received: by 2002:a05:6402:42cf:b0:4af:7bdc:1888 with SMTP id i15-20020a05640242cf00b004af7bdc1888mr12085566edc.4.1678571554119; Sat, 11 Mar 2023 13:52:34 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id ks14-20020a170906f84e00b008ec43ae626csm1504972ejb.167.2023.03.11.13.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:52:33 -0800 (PST) Date: Sat, 11 Mar 2023 22:52:31 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 10/12] staging: rtl8192e: Remove unused variable rfTxIQImbalance and rfTxAFE Message-ID: <62453061bcf1858c23ba57bf1f279999b37b4cc3.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused variable rfTxIQImbalance and rfTxAFE because they are just once set and not used. Remove unused constants. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 ---------- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 5 ----- 3 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8190P_def.h index a5c2ff5b4260..385cca79f484 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -107,8 +107,6 @@ struct bb_reg_definition { u32 rfintfe; u32 rf3wireOffset; u32 rfHSSIPara2; - u32 rfTxIQImbalance; - u32 rfTxAFE; u32 rfLSSIReadBack; u32 rfLSSIReadBackPi; }; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 5b63b9eac090..fe12df93bc60 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -373,16 +373,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devi= ce *dev) priv->phy_reg_def[RF90_PATH_C].rfHSSIPara2 =3D rFPGA0_XC_HSSIParameter2; priv->phy_reg_def[RF90_PATH_D].rfHSSIPara2 =3D rFPGA0_XD_HSSIParameter2; =20 - priv->phy_reg_def[RF90_PATH_A].rfTxIQImbalance =3D rOFDM0_XATxIQImbalance; - priv->phy_reg_def[RF90_PATH_B].rfTxIQImbalance =3D rOFDM0_XBTxIQImbalance; - priv->phy_reg_def[RF90_PATH_C].rfTxIQImbalance =3D rOFDM0_XCTxIQImbalance; - priv->phy_reg_def[RF90_PATH_D].rfTxIQImbalance =3D rOFDM0_XDTxIQImbalance; - - priv->phy_reg_def[RF90_PATH_A].rfTxAFE =3D rOFDM0_XATxAFE; - priv->phy_reg_def[RF90_PATH_B].rfTxAFE =3D rOFDM0_XBTxAFE; - priv->phy_reg_def[RF90_PATH_C].rfTxAFE =3D rOFDM0_XCTxAFE; - priv->phy_reg_def[RF90_PATH_D].rfTxAFE =3D rOFDM0_XDTxAFE; - priv->phy_reg_def[RF90_PATH_A].rfLSSIReadBack =3D rFPGA0_XA_LSSIReadBack; priv->phy_reg_def[RF90_PATH_B].rfLSSIReadBack =3D rFPGA0_XB_LSSIReadBack; priv->phy_reg_def[RF90_PATH_C].rfLSSIReadBack =3D rFPGA0_XC_LSSIReadBack; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index 78e90bf5d79f..fe05a94561e8 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -117,12 +117,7 @@ #define rOFDM0_HTSTFAGC 0xc7c #define rOFDM0_XATxIQImbalance 0xc80 #define rOFDM0_XATxAFE 0xc84 -#define rOFDM0_XBTxIQImbalance 0xc88 -#define rOFDM0_XBTxAFE 0xc8c #define rOFDM0_XCTxIQImbalance 0xc90 -#define rOFDM0_XCTxAFE 0xc94 -#define rOFDM0_XDTxIQImbalance 0xc98 -#define rOFDM0_XDTxAFE 0xc9c #define rOFDM0_RxHPParameter 0xce0 #define rOFDM0_TxPseudoNoiseWgt 0xce4 #define rOFDM0_FrameSync 0xcf0 --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4519C61DA4 for ; Sat, 11 Mar 2023 21:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbjCKVxa (ORCPT ); Sat, 11 Mar 2023 16:53:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230057AbjCKVxT (ORCPT ); Sat, 11 Mar 2023 16:53:19 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BCFC664FB for ; Sat, 11 Mar 2023 13:52:52 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id ek18so3331119edb.6 for ; Sat, 11 Mar 2023 13:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571568; x=1681163568; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RyEajtXCKm6Ql9H6gCOuQjRwjcr6+UWMUOeAMqv/92A=; b=SIy/GjaY1a77lyDckpFkDXDtsTsXvwKdxAdSL9w6MIK9ZcJf6Ze/rYWKK5bodNCpP7 SDZFUNs1ntMFhPV/M6bPLvmtlRXKwIvDM5lUD3MzAcHVtyO/5x6VO2swwSnFFqAVQpWw bLp4KIJgGx1Ux5h21LAsAcibn0W4Tu5cr13khx77MBtn6llKqIbbQCddAMb0ia1qpbLg vq607BohABsjQqLto09qYTXiZVGyyV3WLBian0jcJdKa3Tyel26naQ90pDhM+C29mPfW VZKCK3+l5wC3uqJ2CnU1o5UGzJYrDeSOpM6SONsqrzEl2pXMY73d347so8hDD/k5Y174 vsGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571568; x=1681163568; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RyEajtXCKm6Ql9H6gCOuQjRwjcr6+UWMUOeAMqv/92A=; b=Ca40xBthN4pSHi7FFwLzfAhjNbfkCXQyBnoIquh0nDDYvQcZqRTcu64kPXSpIjlSI7 cD2QWRHMEDXoj9DeePPc2bWMCvAo8sel7ihbyDnLklxeA/7Opl6VAawQy+anwp8/ORdJ Y9SpC1AjOrDnhNij58o+xNZDOQs68td6mZQQI42Y31shu89aNFddJJPr40/Dfigk3KVo We3Sxkoq33POc7dfAxFfNG0WTlMfwhr8zK48Y8NpN84zn/pTI4SB/s9K3ve3zZq1AcWe W/UWEKR8MA15pJC4ryxWZKYNbDJ3X2Mz2BlTJCCURaRTu8dLVu/5bfjPzQSZaUgYH8HD /mkg== X-Gm-Message-State: AO0yUKU6SdSB3Da6uFrkHjMMzKNNwhM84U0W/ukiPJuUzuRCn10eJyWF tVmIbmZZGAgiHfd30XKdjdpeLI6GuuU= X-Google-Smtp-Source: AK7set+DeLK3epRnJ1IoskS86bjOn3azl461Sqqzs9fpCLoU1bIAAK68n+2VIcBXGiPam7J2rGdEZA== X-Received: by 2002:a17:906:19c:b0:8d3:be84:1cc6 with SMTP id 28-20020a170906019c00b008d3be841cc6mr9843663ejb.3.1678571568225; Sat, 11 Mar 2023 13:52:48 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id lc22-20020a170906dff600b00922b009fc79sm746203ejc.164.2023.03.11.13.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:52:47 -0800 (PST) Date: Sat, 11 Mar 2023 22:52:46 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 11/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfLSSIReadBack Message-ID: <622777b394a896b6db08eb7faeb455e5cbeae93f.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused priv->phy_reg_def[RF90_PATH_C].rfLSSIReadBack and priv->phy_reg_def[RF90_PATH_D].rfLSSIReadBack. rfLSSIReadBack is used in: _rtl92e_phy_rf_read which is used in: rtl92e_set_rf_reg and rtl92e_get_rf_reg are used in: rtl92e_set_bandwidth (eRFPath only for 0 and 1) rtl92e_config_rf (eRFPath only for 0 and 1) _rtl92e_phy_switch_channel_step (eRFPath only for 0 and 1) _rtl92e_dm_check_tx_power_tracking_thermal (eRFPath only for 0) rtl92e_check_bb_and_rf is used in: rtl92e_config_rf (eRFPath only for 0 and 1) _rtl92e_bb_config_para_file (eRFPath only for 0) rtl92e_config_rf_path is used in: rtl92e_config_rf (eRFPath only for 0 and 1) Remove dead code and constants. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 3 --- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index fe12df93bc60..b26ea8dfd871 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -375,9 +375,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devic= e *dev) =20 priv->phy_reg_def[RF90_PATH_A].rfLSSIReadBack =3D rFPGA0_XA_LSSIReadBack; priv->phy_reg_def[RF90_PATH_B].rfLSSIReadBack =3D rFPGA0_XB_LSSIReadBack; - priv->phy_reg_def[RF90_PATH_C].rfLSSIReadBack =3D rFPGA0_XC_LSSIReadBack; - priv->phy_reg_def[RF90_PATH_D].rfLSSIReadBack =3D rFPGA0_XD_LSSIReadBack; - } =20 bool rtl92e_check_bb_and_rf(struct net_device *dev, enum hw90_block CheckB= lock, diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index fe05a94561e8..28f9af71f193 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -65,8 +65,6 @@ #define rFPGA0_AnalogParameter4 0x88c #define rFPGA0_XA_LSSIReadBack 0x8a0 #define rFPGA0_XB_LSSIReadBack 0x8a4 -#define rFPGA0_XC_LSSIReadBack 0x8a8 -#define rFPGA0_XD_LSSIReadBack 0x8ac #define rFPGA0_PSDReport 0x8b4 =20 /* Page 9 - RF mode & OFDM TxSC */ --=20 2.39.2 From nobody Wed Feb 11 17:20:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC123C61DA4 for ; Sat, 11 Mar 2023 21:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbjCKVxm (ORCPT ); Sat, 11 Mar 2023 16:53:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbjCKVx2 (ORCPT ); Sat, 11 Mar 2023 16:53:28 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 518651700 for ; Sat, 11 Mar 2023 13:53:01 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id g10so5586818eda.1 for ; Sat, 11 Mar 2023 13:53:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678571576; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SylOTguwShw07odTtBf+yZjPkOGNYCA1EPzmfLeERyE=; b=AbZc6dNuE0DH9mrk0BnEsbIXtG2SqvEmEZowDKThmKeW8hzqHWKHhdvM5iJyvMyb1G 9D/KOEBqVuL4F1YlthGY0jogQao5l4kSdm8bVYeXirOt43il2Wz3zzO0qUC/kswDXGFB qz8w49EjaE5O/38jeukq/oxtQtVqEpglGAWTKsDZGnViQf+fC5rU1WUT8JcrRjWAoP6K txLDpZakyeJEn4XV1GjmtZF6xozwcghxbAN9v3rC0PllZj4LwDIU+uHYE/S5qPYiewQ7 3HLHGueLABbbEY33Udz/BFi4pTxS/J770AHt+nuJGPNOu3TplgW9vKfRI2PIfrPTYjHb 1oFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678571576; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SylOTguwShw07odTtBf+yZjPkOGNYCA1EPzmfLeERyE=; b=ehILouJDFrQB7Lv4Zt1btKNy4JlReR5y7HZtLNrXyPiLoD+0guZ/+E5uzjsqtoJJRC aSBzj8KTZWkDv28efPvFz9ZUlpSAmEStv/t5MPv9R5JsHX7KBROceAwkMHx3WCqvFHxV U8RF+DpRSK/YPQ572zonCtaE3POFfpzCcWyCueuA7g6WjhVjylv2U053KM2JL4yZjRsM qF6deTQIS8jrbtHoxPidfAgZij49zUqlSbhmDoJgeGpoKN8O0OvGXgAH3JycenyV6Kv8 QTSGaZeExK5YBS7k5fXVHMzlIBRtV/ei9HD5WOUNYm91Xxcf6MVUBwnqDsuj0IwKw9jN Ywuw== X-Gm-Message-State: AO0yUKX+bqR1zj91mIgPSaRPRTXFQqRzXHLS6u1Y8EAL/9mFhFImhGUJ +GpPxKhpd148UBchmrPIZUY= X-Google-Smtp-Source: AK7set8lyrTenEJG15id4K+NGbBsW+IlQ8cynBwrYrfBI78SIIMSrlkel1poLGPQl1iL7fp/CnL29A== X-Received: by 2002:a17:906:5352:b0:8b1:814e:c83d with SMTP id j18-20020a170906535200b008b1814ec83dmr6343436ejo.6.1678571575854; Sat, 11 Mar 2023 13:52:55 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id g22-20020a170906395600b008b2aba5fb22sm1501442eje.206.2023.03.11.13.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 13:52:55 -0800 (PST) Date: Sat, 11 Mar 2023 22:52:53 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 12/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfHSSIPara2 Message-ID: <186f3e59e736de6fd2111e835cdb4b633ca41bbc.1678569965.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused priv->phy_reg_def[RF90_PATH_C].rfHSSIPara2 and priv->phy_reg_def[RF90_PATH_D].rfHSSIPara2. rfHSSIPara2 is used in rtl92e_set_bb_reg which is used in: rtl92e_config_rf (eRFPath only for 0 and 1) _rtl92e_phy_rf_read which is used in: rtl92e_set_rf_reg and rtl92e_get_rf_reg are used in: rtl92e_set_bandwidth (eRFPath only for 0 and 1) rtl92e_config_rf (eRFPath only for 0 and 1) _rtl92e_phy_switch_channel_step (eRFPath only for 0 and 1) _rtl92e_dm_check_tx_power_tracking_thermal (eRFPath only for 0) rtl92e_check_bb_and_rf is used in: rtl92e_config_rf (eRFPath only for 0 and 1) _rtl92e_bb_config_para_file (eRFPath only for 0) rtl92e_config_rf_path is used in: rtl92e_config_rf (eRFPath only for 0 and 1) Remove dead code and constants. Signed-off-by: Philipp Hortmann Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 -- drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index b26ea8dfd871..e3886db3bfbb 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -370,8 +370,6 @@ static void _rtl92e_init_bb_rf_reg_def(struct net_devic= e *dev) =20 priv->phy_reg_def[RF90_PATH_A].rfHSSIPara2 =3D rFPGA0_XA_HSSIParameter2; priv->phy_reg_def[RF90_PATH_B].rfHSSIPara2 =3D rFPGA0_XB_HSSIParameter2; - priv->phy_reg_def[RF90_PATH_C].rfHSSIPara2 =3D rFPGA0_XC_HSSIParameter2; - priv->phy_reg_def[RF90_PATH_D].rfHSSIPara2 =3D rFPGA0_XD_HSSIParameter2; =20 priv->phy_reg_def[RF90_PATH_A].rfLSSIReadBack =3D rFPGA0_XA_LSSIReadBack; priv->phy_reg_def[RF90_PATH_B].rfLSSIReadBack =3D rFPGA0_XB_LSSIReadBack; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_phyreg.h index 28f9af71f193..e1b30fbdf8cc 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h @@ -50,8 +50,6 @@ #define rFPGA0_RFTiming2 0x814 #define rFPGA0_XA_HSSIParameter2 0x824 #define rFPGA0_XB_HSSIParameter2 0x82c -#define rFPGA0_XC_HSSIParameter2 0x834 -#define rFPGA0_XD_HSSIParameter2 0x83c #define rFPGA0_XA_LSSIParameter 0x840 #define rFPGA0_XB_LSSIParameter 0x844 #define rFPGA0_RFWakeUpParameter 0x850 --=20 2.39.2