From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644ACC54E94 for ; Wed, 25 Jan 2023 20:08:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235895AbjAYUIj (ORCPT ); Wed, 25 Jan 2023 15:08:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236267AbjAYUIa (ORCPT ); Wed, 25 Jan 2023 15:08:30 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A53A45CFD5 for ; Wed, 25 Jan 2023 12:08:26 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id bk16so18207410wrb.11 for ; Wed, 25 Jan 2023 12:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E3QUDM7lOv5vhtcSI90OpPSN2/l5dUarb+bY6Rv4FS0=; b=EsA4nNT7fKM/RgL86Ec0d6j21wZFI6rqkqUVKwXTv/qCBhPLXnRsXqDfJBRyGewGcn U5L+nc7rPhUomHI/JBCFiVhS0rMIHJMkvJq9uKVQu3m7kIT0LBt3gAZcAfW7SR3lf1kH 6i0wHyZHWlrhNu1PzmaDPNlxU/WQDi/fxhZT2g9DHDD2d6OBI1O3W5KTaMB0tVz2Ty3j +FZWWYunXyEg3IcyxXGaJo0gcNGVMqg+GPNJaMX7SjNtdWzTr2JRNXpQuWGLR2H/Ypke uXrpteTVjyxS5kqotOirCtArEMMxL9FJ4Dkfsz/cusaeCtOODeLxxejS3geGAZnFR06N nOWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E3QUDM7lOv5vhtcSI90OpPSN2/l5dUarb+bY6Rv4FS0=; b=JL8EXA7F6nPcbb6ct4HJTHRqwSQJpuVMyH9fZ9gJIHueDuxvZk/zjZoLnsDsFQmIA3 +EZHaDRALWT5TE6iBc+zyiqlbXeJjKeRchAnyhJYzb2ETlTEL4HNzZeOnDPGYGXXuNyy D/xXA/9HgsSQ6+sYsPZlFL3ez02ArSOn92nKA1l5AK1VcPMMjIXByrgr1L+iac4g4iuD LLBRDl/NmbqlwqIwfx/ych9L6pVm9Tn+DAAYisckIZUKYisO3Rueb7NfTBijjlOccez5 YAhSHmX8UGFdlsUi7LizZZyaZtLEUVMh0T051nHKbikE6O+yYELHv6tNVsju6VDlVIXb snOg== X-Gm-Message-State: AFqh2krgKwMd3J1G83rdFlhKJPGg+Ei7u1ISHbZFWkAv9vOeXUy4NVoo I9wwsuQXuB6vTlHUEGBRlH4= X-Google-Smtp-Source: AMrXdXv0uHv236FNy6MmU6roGijeMmtfDbRsvZpQDZHkC8pSAM1AXkg2KKO9Dc+/Nrqu8t15i8vAZA== X-Received: by 2002:a05:6000:1088:b0:2be:5295:bd9e with SMTP id y8-20020a056000108800b002be5295bd9emr3999634wrw.7.1674677305155; Wed, 25 Jan 2023 12:08:25 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id bi24-20020a05600c3d9800b003d1d5a83b2esm2701098wmb.35.2023.01.25.12.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:08:24 -0800 (PST) Date: Wed, 25 Jan 2023 21:08:22 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 01/11] staging: rtl8192e: Remove unused variables rxrdu and rxok Message-ID: <20738d339066e36f5347c7e5011bd3d1aa3e4f53.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rxrdu and rxok are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 80450d46191c..605146c840c7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1938,7 +1938,6 @@ static void _rtl92e_rx_normal(struct net_device *dev) if (!rtllib_rx(priv->rtllib, skb, &stats)) { dev_kfree_skb_any(skb); } else { - priv->stats.rxok++; if (unicast_packet) priv->stats.rxbytesunicast +=3D skb_len; } @@ -2186,7 +2185,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) tasklet_schedule(&priv->irq_prepare_beacon_tasklet); =20 if (inta & IMR_RDU) { - priv->stats.rxrdu++; rtl92e_writel(dev, INTA_MASK, rtl92e_readl(dev, INTA_MASK) & ~IMR_RDU); tasklet_schedule(&priv->irq_rx_tasklet); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 983bc663a570..82cbc7f5536a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -183,8 +183,6 @@ enum reset_type { }; =20 struct rt_stats { - unsigned long rxrdu; - unsigned long rxok; unsigned long rxdatacrcerr; unsigned long rxmgmtcrcerr; unsigned long rxcrcerrmin; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CF7C27C76 for ; Wed, 25 Jan 2023 20:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236261AbjAYUIw (ORCPT ); Wed, 25 Jan 2023 15:08:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236141AbjAYUIu (ORCPT ); Wed, 25 Jan 2023 15:08:50 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C54BA5D11F for ; Wed, 25 Jan 2023 12:08:35 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id f25-20020a1c6a19000000b003da221fbf48so2134059wmc.1 for ; Wed, 25 Jan 2023 12:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bF+Lp+JDPbwdrmjIfQ0g/QFY3xJvOU79Nk3DY5MrQzU=; b=lZjNXxnG0NwYLfZGiRVHlHOqlnjaMPZ1JSID3VMPnHtvUjKMLeD8kgH7GkoAlRPX/d lZsrQftznCgl+6B9zFnjD0+R9mTZi5VWhbUqy+4Dn9yPmXaY6jyYgA05zUKIL4QREQK5 860WaQ3CHo79PSRDa601F2pA1CnldWLfwjFHehb6YLT3RlbdoLrWrgFfXYGOaht7gepv INCRHLR1CmWe+DN+syp7s+t92FtOLxWMVgWyvQN3aeNBwzg5pTrvlQhgsWUr4Mnq5ALl Pjus4IqrryktYkJ6L4HFew8xH3VG4y/sS7B0imQPMEb4osTROToIXx1df3catPY43Fdy Wg9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bF+Lp+JDPbwdrmjIfQ0g/QFY3xJvOU79Nk3DY5MrQzU=; b=0ZCU4ps7CDjyUNain9SU2rew4DFE91VNZRxynAxv8LdtU23tDZKTdNl6b6zKk4gUNy StzqNr8QHamfWRlv/idz7jV98o8jl9DOSLZbSXRWOfTZOziyIZAGtSUTEziyRBRWIpT7 yr5mhKozdO0FiZfsbWbHiQl6W6slbLJn1w3QHdaCXQMoA3FmI0bqIqQB8KFTp8biPWjQ wOWS6iT1YZEHVrGNpWTnB1y06sc4585ehBPfrFyl9fECxPsFW25zu0NYsUoa2VUDVTv/ wDxaQfEyGMgLNLIta64IVwqt45JPCdjwjcXEy31Y0tMMXBzWSqICiVt0FkWHXDYPtY/z 6Kig== X-Gm-Message-State: AFqh2ko0tLlXmTbJ1OsquExs0W6O2GAz9rq1n5a+0YKqfYXKycPIq+1L O1x9qRuCrd7tj2zpxE4XBWk= X-Google-Smtp-Source: AMrXdXuPLC9TNzoxh2qQMgwhJ2ZPBby8KQ2A7s3S3pJ34Cz3y7HlrsLZZ6qnvRp141wNiT4CSj68aQ== X-Received: by 2002:a05:600c:3ba8:b0:3d9:8635:a901 with SMTP id n40-20020a05600c3ba800b003d98635a901mr8573813wms.3.1674677314209; Wed, 25 Jan 2023 12:08:34 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id bi5-20020a05600c3d8500b003db0bb81b6asm2751098wmb.1.2023.01.25.12.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:08:33 -0800 (PST) Date: Wed, 25 Jan 2023 21:08:31 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/11] staging: rtl8192e: Remove unused variables rxdatacrcerr and rxmgmtcrcerr Message-ID: <32c9183fa2f4edd24ae6f93d56b808eb1821832b.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rxdatacrcerr and rxmgmtcrcerr are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 ------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 605146c840c7..e0d0f4faeca7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1926,13 +1926,6 @@ static void _rtl92e_rx_normal(struct net_device *dev) priv->rtllib->LedControlHandler(dev, LED_CTL_RX); =20 - if (stats.bCRC) { - if (type !=3D RTLLIB_FTYPE_MGMT) - priv->stats.rxdatacrcerr++; - else - priv->stats.rxmgmtcrcerr++; - } - skb_len =3D skb->len; =20 if (!rtllib_rx(priv->rtllib, skb, &stats)) { diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 82cbc7f5536a..f91a6f7a4e0a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -183,8 +183,6 @@ enum reset_type { }; =20 struct rt_stats { - unsigned long rxdatacrcerr; - unsigned long rxmgmtcrcerr; unsigned long rxcrcerrmin; unsigned long rxcrcerrmid; unsigned long rxcrcerrmax; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1478C27C76 for ; Wed, 25 Jan 2023 20:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236269AbjAYUJJ (ORCPT ); Wed, 25 Jan 2023 15:09:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236255AbjAYUJG (ORCPT ); Wed, 25 Jan 2023 15:09:06 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC54135260 for ; Wed, 25 Jan 2023 12:08:43 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id r2so18190805wrv.7 for ; Wed, 25 Jan 2023 12:08:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e3159gyzRYnyKWw0j8EF0nhK1aLDWnlIYkjwkYEv8/0=; b=qJ4Uwx/LpirhfkkhaNbEw7UgnQvUkGfwnShlH39beNasN0JvKq0Twaon7yywI92r5w wcmcqVKrrgD2ZIb5lHH2sRMo+KPkUEcDMCLfYyfRVik0S6NyIFIdM98kOGTL/b8lWlY4 vq/ieZXk1x//6+O9bCm1T7uP2Ib9hv8ha1+cn/ng8bd9kkRDj6X/Klh7CH2hVutweWvv q6zf4VzIYK/O6lJ575FPZZRVya7ujTLCpD6/MM8D7ypP0Ynn/OEIWGkaANA9Zq2KLiVo O/FuqEND8d6YYYzOqdn/qOKUQ+V9DZvgFTsicizungZ/ZHqUGT12+9Xl3VAAR5ymyyKC 4tdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e3159gyzRYnyKWw0j8EF0nhK1aLDWnlIYkjwkYEv8/0=; b=H/eRjcd2ooczv02kSqszFzNsU6tdt/phlOKjg0egWEUsPeGJxF3JoMEbkJwy92KwA1 c/+z+iK/2vsxZ8IjxrQZuGDIFtS/XSQNxmL8Qc/kufPEc677YH1xeRcDole5wEhSVqPn D/E/qdz9F8Qis1umIvsJLpBaWV0JpfC/xi5+SzQiGRM4nAYO+lie2cUCAjYklzT/wSbJ nEoZ6f0sjnHYGTqXPkOETTF5hhq0GT2InDPWkkVcoJF2xEzSc715fns4AVDhj3pakPks VJESraNyIM3im6GYX5rn3mqU2gKxyJIz+1yGu/9GJ3Hy2PkD8TNi2/lo5cXEoIIi2UBJ tqvQ== X-Gm-Message-State: AFqh2kqurFtON2I6/gwuySlmyjk9lMNWRPNwtFup/JtXrfpWUMMn9BLx LLmGAyBrsM/Zg1ce6tA+Az50sqJ//KQ= X-Google-Smtp-Source: AMrXdXvtUFtCFxHlZsDC0OlmrcZnQBmN47kgB/Rp9Et3pN+lO9A/kzbf8ThueNXsV/QYtezuFBh5Kg== X-Received: by 2002:a5d:6b0e:0:b0:2be:1672:748b with SMTP id v14-20020a5d6b0e000000b002be1672748bmr5353853wrw.0.1674677322437; Wed, 25 Jan 2023 12:08:42 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id x10-20020adfdcca000000b002bbddb89c71sm5121166wrm.67.2023.01.25.12.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:08:41 -0800 (PST) Date: Wed, 25 Jan 2023 21:08:40 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/11] staging: rtl8192e: Remove unused variables rxcrcerrmin and friends Message-ID: <4c791fbb3559ce15de60b7bdcabbc50b0ee9adb9.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rxcrcerrmin, rxcrcerrmax and rxcrcerrmid are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 ---------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 9260d308e68b..e9273dfb638e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1812,7 +1812,6 @@ static void _rtl92e_update_received_rate_histogram_st= ats( bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *s= tats, struct rx_desc *pdesc, struct sk_buff *skb) { - struct r8192_priv *priv =3D rtllib_priv(dev); struct rx_fwinfo *pDrvInfo =3D NULL; =20 stats->bICV =3D pdesc->ICV; @@ -1825,15 +1824,6 @@ bool rtl92e_get_rx_stats(struct net_device *dev, str= uct rtllib_rx_stats *stats, =20 if (stats->bHwError) { stats->bShift =3D false; - - if (pdesc->CRC32) { - if (pdesc->Length < 500) - priv->stats.rxcrcerrmin++; - else if (pdesc->Length > 1000) - priv->stats.rxcrcerrmax++; - else - priv->stats.rxcrcerrmid++; - } return false; } =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index f91a6f7a4e0a..167c4aeea44e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -183,9 +183,6 @@ enum reset_type { }; =20 struct rt_stats { - unsigned long rxcrcerrmin; - unsigned long rxcrcerrmid; - unsigned long rxcrcerrmax; unsigned long received_rate_histogram[4][32]; unsigned long received_preamble_GI[2][32]; unsigned long numpacket_matchbssid; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD00C54E94 for ; Wed, 25 Jan 2023 20:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236289AbjAYUJY (ORCPT ); Wed, 25 Jan 2023 15:09:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236268AbjAYUJV (ORCPT ); Wed, 25 Jan 2023 15:09:21 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C49985D11E for ; Wed, 25 Jan 2023 12:08:52 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id h12so14225567wrv.10 for ; Wed, 25 Jan 2023 12:08:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+Qr60u7lvfUmg3t7GN82ZYC7UEclCo+vLTjIrczP5SI=; b=JKMs68+PzgNteTWB0wk6QWiT9tsW/7RxLt0mei0Xbz09mymudC499yGyfEu3qCHeEp iQTiix33JWJs1x5v/wdPpPtrzeKlyc7fkdCh0yWqQOX3ZZIQk6G/hcHnLnqKBFVyPnJ/ fuVybe8vDc5AvF+U5uSQBKIcY9RwIY3IPaG/0ZbnAt8iKZ46H+koh8i8R+UONurkD5l5 qXnDIRH8MWTm6MthflmRQ50CSKW1CpYWWvb8dlQVa4kEz8B2q043bKyi8s4/EcFyz2Ph 15/8FjA6Yi3AGnzRV+0CVSsfqxF7da+qZU6t7RM+rSQhJYXqvEvlkKILQCPX9GaPxLv+ SpNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Qr60u7lvfUmg3t7GN82ZYC7UEclCo+vLTjIrczP5SI=; b=6uF5Rgpyq6VDYCyQbk0ed4uEn/OWUV71Ipwv9CNQRbd6r77z53r/Real9Bs2ITIXnQ poOhWnWKLzwlHrUiy2I4uQ49GAjCVJD3Iedok8vzIWtzYJ6sEdMfACRuMMlvl7Hyja2z yg9ICj8LfVTTuiw33LLFdbFrBELyTHZPnSMEfjQipllsCD6m6fk+7dYLohpF13sFaVjF 5QTsqP8sp4CbFOVQrH+3NKB8ml7d4tj9wF6p4MSW2LfBeZGOIr9mulXi6PwFMPFtPAhg +3DCkGypFeryJB7A1lTOW6vYXFecSjlG9csKjg3ce8No9LriItDupY2aDpVvrjHif7Pn bR2Q== X-Gm-Message-State: AO0yUKWx51kmkoyFRcqhu071cV/+YBYrO2+hkoTeWYf9rKg6A5jBddoK YB96oiOi67r28NnW24Q0j/g= X-Google-Smtp-Source: AK7set88Dkl1JxQP5xyKoZ7XDTMAgeMm+t957mfmuyKK+Un4B3iD1g4nfOWOkaQodU/zJa7DNG2hVA== X-Received: by 2002:a5d:6791:0:b0:2bf:b0cb:1f9f with SMTP id v17-20020a5d6791000000b002bfb0cb1f9fmr1170482wru.7.1674677329651; Wed, 25 Jan 2023 12:08:49 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id r13-20020adfdc8d000000b002bfb5bda59asm3287384wrj.25.2023.01.25.12.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:08:49 -0800 (PST) Date: Wed, 25 Jan 2023 21:08:47 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/11] staging: rtl8192e: Remove unused variables numpacket.. and received_pre.. Message-ID: <0ed5f4134176393110fdb0b7424df7a8a6fc6262.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" numpacket_toself, numpacket_matchbssid and received_preamble_GI are initialized and increased but never read. Remove dead code. As a result the local variable preamble_guardinterval is unused. Remove it also. Reported-by: kernel test robot Signed-off-by: Philipp Hortmann --- V1->V2: removed unused variable preamble_guardinterval --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 11 ----------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 14 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index e9273dfb638e..b4651cea07a1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1685,10 +1685,6 @@ static void _rtl92e_translate_rx_signal_stats(struct= net_device *dev, ether_addr_equal(praddr, priv->rtllib->dev->dev_addr); if (WLAN_FC_GET_FRAMETYPE(fc) =3D=3D RTLLIB_STYPE_BEACON) bPacketBeacon =3D true; - if (bpacket_match_bssid) - priv->stats.numpacket_matchbssid++; - if (bpacket_toself) - priv->stats.numpacket_toself++; _rtl92e_process_phyinfo(priv, tmp_buf, &previous_stats, pstats); _rtl92e_query_rxphystatus(priv, pstats, pdesc, pdrvinfo, &previous_stats, bpacket_match_bssid, @@ -1703,18 +1699,12 @@ static void _rtl92e_update_received_rate_histogram_= stats( struct r8192_priv *priv =3D (struct r8192_priv *)rtllib_priv(dev); u32 rcvType =3D 1; u32 rateIndex; - u32 preamble_guardinterval; =20 if (pstats->bCRC) rcvType =3D 2; else if (pstats->bICV) rcvType =3D 3; =20 - if (pstats->bShortPreamble) - preamble_guardinterval =3D 1; - else - preamble_guardinterval =3D 0; - switch (pstats->rate) { case MGN_1M: rateIndex =3D 0; @@ -1804,7 +1794,6 @@ static void _rtl92e_update_received_rate_histogram_st= ats( rateIndex =3D 28; break; } - priv->stats.received_preamble_GI[preamble_guardinterval][rateIndex]++; priv->stats.received_rate_histogram[0][rateIndex]++; priv->stats.received_rate_histogram[rcvType][rateIndex]++; } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 167c4aeea44e..70767238e721 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { =20 struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long received_preamble_GI[2][32]; - unsigned long numpacket_matchbssid; - unsigned long numpacket_toself; unsigned long num_process_phyinfo; unsigned long numqry_phystatus; unsigned long numqry_phystatusCCK; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62ECC54EED for ; Wed, 25 Jan 2023 20:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236296AbjAYUJb (ORCPT ); Wed, 25 Jan 2023 15:09:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236294AbjAYUJZ (ORCPT ); Wed, 25 Jan 2023 15:09:25 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 311AA5AA6C for ; Wed, 25 Jan 2023 12:08:58 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id n7so18198717wrx.5 for ; Wed, 25 Jan 2023 12:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WPD0oaXUwE0lhRDbVVND/Kc9WuyherZicOM8X1Re1go=; b=K8kyMHybsveElrrjOMCBIF0OmQ6Cuk81brwhY/J2sem7mqToCmCMWnjIDmzlKn3fc9 YUeFpufUdO9fqNX6X9w49EXMt7uFYiYNoR7lTVo38g5V1i/tHc0ScDYzdADVnv0GcJRi 1BW/9tnZDvj2pJo8APvz+AVFEjcB6qTm19hYpW5n3qFA3YHAnH/l+Vps0Tz/VaHzwuQf zWDewvbG0/6v2JS9YlrepfYSJACNlnhLv8l6fAQYW7F+ynPAp+ZaiWrCTqoPQw2jvfSU ccdJ4Q9mdbZuLOmYm3+gNQqtAtNjxcqzGISR9j4RE/16mv753HdBVPSFMnd9m98s5rIR Nkqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WPD0oaXUwE0lhRDbVVND/Kc9WuyherZicOM8X1Re1go=; b=uTURWo8vfyiJAk3eJBKL0M4i7F2nMkH+/BjDzbFz0VWcLcnCBYYvwauZjl+cZyGVan 2PyLH45B2OQVdd5/JLkPaWlKBA9gO9Q9x6pDSem14+BZL3Ul3/lvk/v/g+FWD0boaavE NiGsalQDJomaTOQWckX6y03c60DCJJ5fHL3qsgxTyAB0LrO7B2LaJaEXghg7Z77BjQMZ 2vswxTY/++F4dtMHNfcakXF+N6mDh8YdGfnF2vsPYgYv5GOOsorppiQV9ktnowqpyzrm RnlyuwsJyuQq14LI4nO2PpKRZzYPQ9u0X4BCTa0MHBAfT9JiM7zHIPz6a0M4kJjg/OW+ pmVA== X-Gm-Message-State: AFqh2kqKKHynXmZNgWit2tIEKe7xPPOu7Pyj3HBA5SJrLZei0KvAWB6V okRhRWjI5cBCm4ZAbYOcPAN2QsCJ9og= X-Google-Smtp-Source: AMrXdXtKEG+Hod7P339+LXhVmkjTjcFe4V/KC1S+eyYlY5WEYAOeXBhwq1suHOKgCHufExkr580gHg== X-Received: by 2002:adf:fa4e:0:b0:2bd:e8bd:79c7 with SMTP id y14-20020adffa4e000000b002bde8bd79c7mr5281596wrr.1.1674677335888; Wed, 25 Jan 2023 12:08:55 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id n5-20020a5d4205000000b002bdbead763csm5218018wrq.95.2023.01.25.12.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:08:55 -0800 (PST) Date: Wed, 25 Jan 2023 21:08:53 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/11] staging: rtl8192e: Remove unused variables numqry_.. Message-ID: <20aedc3bd3cc860ee8d86d205461f479ac201fea.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" numqry_phystatus, numqry_phystatusCCK and numqry_phystatusHT are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ---- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index b4651cea07a1..f62547e54261 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1308,8 +1308,6 @@ static void _rtl92e_query_rxphystatus( static u8 check_reg824; static u32 reg824_bit9; =20 - priv->stats.numqry_phystatus++; - is_cck_rate =3D rx_hal_is_cck_rate(pdrvinfo); memset(precord_stats, 0, sizeof(struct rtllib_rx_stats)); pstats->bPacketMatchBSSID =3D precord_stats->bPacketMatchBSSID =3D @@ -1341,7 +1339,6 @@ static void _rtl92e_query_rxphystatus( if (is_cck_rate) { u8 report; =20 - priv->stats.numqry_phystatusCCK++; if (!reg824_bit9) { report =3D pcck_buf->cck_agc_rpt & 0xc0; report >>=3D 6; @@ -1416,7 +1413,6 @@ static void _rtl92e_query_rxphystatus( precord_stats->RxMIMOSignalQuality[1] =3D -1; } } else { - priv->stats.numqry_phystatusHT++; for (i =3D RF90_PATH_A; i < RF90_PATH_MAX; i++) { if (priv->brfpath_rxenable[i]) rf_rx_num++; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 70767238e721..e38de4d8a467 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -185,9 +185,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; unsigned long num_process_phyinfo; - unsigned long numqry_phystatus; - unsigned long numqry_phystatusCCK; - unsigned long numqry_phystatusHT; unsigned long received_bwtype[5]; unsigned long rxoverflow; unsigned long rxint; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB44C61D97 for ; Wed, 25 Jan 2023 20:09:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236321AbjAYUJj (ORCPT ); Wed, 25 Jan 2023 15:09:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236277AbjAYUJb (ORCPT ); Wed, 25 Jan 2023 15:09:31 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6926E5CFE5 for ; Wed, 25 Jan 2023 12:09:03 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id z5so18205998wrt.6 for ; Wed, 25 Jan 2023 12:09:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+5ygW0iNMg8HClPWoVPtKx35n6wKs6NqAz6ewUsuKhU=; b=U4uzPDwfHDjBX1sGGDZR/XNANZn19pibtwG3TSQnL7h8NKJjBFoNFxIopM5mF09P4B trCEIeBvh8aypzWPgonTJsO5i+f/xkkmUEc05qEoPxe0moqC4EtrpBO0wsgBlH+zqnBa UrKuJO9ZesiSt6ssBWl9gx7zdJ8FpfRYlPNiWl62SdvQPb552rdemNgl3TSdID5jGW59 Fc7n0bmzig2tBVE4zl45CLXRfWMORBGk1QByX1mCzhJmu2+DKNpkP0yJ/sHN3VlcCdQj 2tJXHR2PM8KmCbVwzGnMssOxseXaqNPgbsPID+skaRPC8X+IsSBXfbBGIck7VmWm5jtl lkNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+5ygW0iNMg8HClPWoVPtKx35n6wKs6NqAz6ewUsuKhU=; b=SvtU7RNtRZp635q2BwrshesyQhZ6LOcd6rziMmmcHVfz5oFY6ZhvYE1L+jg6YJyBcI dcy1SlvY5coPqv+zH4ibKTecv39OnQ63TL+YlU1mSuV6mDF0JBhL0MNH8uEJTWEMg5ci 7yqg8YFwoWoyhg8iUPSomVgxzCissWyebGR/6dPLQZcz7F1MKfRoXUm5hdPHo20dO+kv W9wqFzvWDXZmTP52BUnCiVIULkg3W2PeMfo/jw8H+ww/YkqejjqniOy/eXpTfF80auVp ZRp8ItdZYdhfRTWRYjvgIsdRJFDrzdyQ0V/LW7bFsowKHQreMXwzgaq9qk+ZJnRbj+3P Bqhg== X-Gm-Message-State: AFqh2koRxzCE/t3c27nCbYed/kVfcoFPoFCN2YNJvc5SWPlZ4Gi26Y2e tnmXhjy2DK7G97r++ESQiTM= X-Google-Smtp-Source: AMrXdXsBEHflsPtdPSO01GmeB+48rssoXjzAYdMT6pVDyZekdlTG5+TNb9jTPssgYJ2aHStNGZD+4w== X-Received: by 2002:a05:6000:69d:b0:2be:184:8af6 with SMTP id bo29-20020a056000069d00b002be01848af6mr6524730wrb.0.1674677341944; Wed, 25 Jan 2023 12:09:01 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id q6-20020a056000136600b00241fde8fe04sm2287868wrz.7.2023.01.25.12.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:09:01 -0800 (PST) Date: Wed, 25 Jan 2023 21:08:59 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/11] staging: rtl8192e: Remove unused variables num_proc.., recei.. and rxov.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" num_process_phyinfo, received_bwtype and rxoverflow are initialized and increased but never read. Remove dead code. As a result prxsc is unused which in result makes rxsc_sgien_exflg unused. Remove prxsc and rxsc_sgien_exflg as well. Reported-by: kernel test robot Signed-off-by: Philipp Hortmann --- V1->V2: Remove prxsc and rxsc_sgien_exflg --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 13 +------------ drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 +--- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 3 files changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index f62547e54261..9d13fda33fbf 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1296,9 +1296,8 @@ static void _rtl92e_query_rxphystatus( { struct phy_sts_ofdm_819xpci *pofdm_buf; struct phy_sts_cck_819xpci *pcck_buf; - struct phy_ofdm_rx_status_rxsc_sgien_exintfflag *prxsc; u8 *prxpkt; - u8 i, max_spatial_stream, tmp_rxsnr, tmp_rxevm, rxsc_sgien_exflg; + u8 i, max_spatial_stream, tmp_rxsnr, tmp_rxevm; s8 rx_pwr[4], rx_pwr_all =3D 0; s8 rx_snrX, rx_evmX; u8 evm, pwdb_all; @@ -1464,15 +1463,6 @@ static void _rtl92e_query_rxphystatus( precord_stats->RxMIMOSignalQuality[i] =3D evm & 0xff; } } - - - rxsc_sgien_exflg =3D pofdm_buf->rxsc_sgien_exflg; - prxsc =3D (struct phy_ofdm_rx_status_rxsc_sgien_exintfflag *) - &rxsc_sgien_exflg; - if (pdrvinfo->BW) - priv->stats.received_bwtype[1+prxsc->rxsc]++; - else - priv->stats.received_bwtype[0]++; } =20 if (is_cck_rate) { @@ -1535,7 +1525,6 @@ static void _rtl92e_process_phyinfo(struct r8192_priv= *priv, u8 *buffer, if (!bcheck) return; =20 - priv->stats.num_process_phyinfo++; if (!prev_st->bIsCCK && prev_st->bPacketToSelf) { for (rfpath =3D RF90_PATH_A; rfpath < RF90_PATH_C; rfpath++) { if (!rtl92e_is_legal_rf_path(priv->rtllib->dev, rfpath)) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index e0d0f4faeca7..c5fe8e0aa83f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2183,10 +2183,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) tasklet_schedule(&priv->irq_rx_tasklet); } =20 - if (inta & IMR_RXFOVW) { - priv->stats.rxoverflow++; + if (inta & IMR_RXFOVW) tasklet_schedule(&priv->irq_rx_tasklet); - } =20 if (inta & IMR_TXFOVW) priv->stats.txoverflow++; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index e38de4d8a467..bb942283bc7a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { =20 struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long num_process_phyinfo; - unsigned long received_bwtype[5]; - unsigned long rxoverflow; unsigned long rxint; unsigned long ints; unsigned long shints; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD81EC54E94 for ; Wed, 25 Jan 2023 20:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236349AbjAYUJv (ORCPT ); Wed, 25 Jan 2023 15:09:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236280AbjAYUJh (ORCPT ); Wed, 25 Jan 2023 15:09:37 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16B705D907 for ; Wed, 25 Jan 2023 12:09:10 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id n7so18199241wrx.5 for ; Wed, 25 Jan 2023 12:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RPkDVI+kwbAJ93P/3HO1c8dYxoMR9aHUJQ6dLWT3TnA=; b=nFNa9GQFJ8A+X4cryDepHdIoycHcC97q53wLw55WoPYQQILEGPqNqavlMFUx8NYeSQ 3rQA78vczlT3E67SuKvBhVztNJXiWtAX5u9LvK3WUbN/w0roPt6td5QfWsFLTDY78tYI r+XmPa8ztUM6fMeYtgvkPOlO5EvUO/Duoyy4cc132pBbAgw6O+wmvcK0iVIDtr+gOcog ida/56erXAFgSQmpBzxep8eQ4j5bul1F4EV70iBTZWWinG/CO2tEdHPMeHnehWCNq0t4 Ra2wLE/yjWdHfXaMlERJ0hX/NUugFMYMKAnZRBErnq7a3xa4bK2WGCdQ50yX9+OfNA4e O0nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RPkDVI+kwbAJ93P/3HO1c8dYxoMR9aHUJQ6dLWT3TnA=; b=NSNdeYBHd0waqbq2O19qZunmb8WUyCA40I+LaqYiQXblblXPLDF5Pb8GEO3jEBxKZa 3e8LrcuoDc8/jAuEkT8NTmweH3PUvfj3UiKxg5dAUXxMmNIqE2px6rh9EDlH3pxAzfpL jDPFlP48UWDlC1ouKTwDHaVKbND4q4CuPkmEIdvifXIrWo7a/cFDoGOaNAUtxwZn8Ac2 6VT38hN8fN/SVbTWLnEo5YU0uD6+8ZrtPy+oqdzRoDMFuC/FicaHN0LRUvcAeafRDsq0 UcOTJ/sVrwtUkTJBiyIfBgp4dUNhXchVJeuCzRlSz9Xh1kopWCU3nozBMktKjgRtHMYU OCZQ== X-Gm-Message-State: AFqh2krLhI3iUvIS31qylAsFi8T+eS4I894XD31e+yDM7uoMDAWQyGyC DC2QcW0aQvJj/PyaGtVy2k/vNGqV25g= X-Google-Smtp-Source: AMrXdXuuDPM7/KXGtoSE1pkM7BeCpSWKMaxKX46SFnwLrs1/YM/M7poDu8pTStktfCpl4ld0LgG4sQ== X-Received: by 2002:a05:6000:69d:b0:2be:184:8af6 with SMTP id bo29-20020a056000069d00b002be01848af6mr6524766wrb.0.1674677348695; Wed, 25 Jan 2023 12:09:08 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id h14-20020a5d430e000000b002366e3f1497sm5248458wrq.6.2023.01.25.12.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:09:08 -0800 (PST) Date: Wed, 25 Jan 2023 21:09:06 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/11] staging: rtl8192e: Remove unused variables rxint, ints and shints Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rxint, ints and shints are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 +------ drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index c5fe8e0aa83f..ff9dc06642f6 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2123,7 +2123,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) spin_lock_irqsave(&priv->irq_th_lock, flags); =20 priv->ops->interrupt_recognized(dev, &inta, &intb); - priv->stats.shints++; =20 if (!inta) { spin_unlock_irqrestore(&priv->irq_th_lock, flags); @@ -2135,8 +2134,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) goto done; } =20 - priv->stats.ints++; - if (!netif_running(dev)) { spin_unlock_irqrestore(&priv->irq_th_lock, flags); goto done; @@ -2169,10 +2166,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) if (inta & IMR_HIGHDOK) _rtl92e_tx_isr(dev, HIGH_QUEUE); =20 - if (inta & IMR_ROK) { - priv->stats.rxint++; + if (inta & IMR_ROK) tasklet_schedule(&priv->irq_rx_tasklet); - } =20 if (inta & IMR_BcnInt) tasklet_schedule(&priv->irq_prepare_beacon_tasklet); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index bb942283bc7a..2d1561a202d0 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { =20 struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long rxint; - unsigned long ints; - unsigned long shints; unsigned long txoverflow; unsigned long txbeokint; unsigned long txbkokint; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EB4C54E94 for ; Wed, 25 Jan 2023 20:10:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236302AbjAYUKB (ORCPT ); Wed, 25 Jan 2023 15:10:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236320AbjAYUJj (ORCPT ); Wed, 25 Jan 2023 15:09:39 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B725A376 for ; Wed, 25 Jan 2023 12:09:18 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id z5so18206579wrt.6 for ; Wed, 25 Jan 2023 12:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u9KDPpjVKPB5sOQxBI2Abbi3wGikXqFCKNDvpCWP0FU=; b=CJFpdB0XCRJu3gIwSZp3Ta9DCtU3V8aBi+GOaExYHwIoDybhpUjd07TFRsBrbfFSls cuCjw6ZWTrV27iC4ZrADnl9lkOmpsM5WeWRWbJDunQFFKeMmGxb2nkVk9mWlL0bljWWx FpbtRX1WwJIGOhV35G9JYf9PIMnsMdcBDF3K7q/389ocJiNVWVZ4Ixvvpnu6BaHe2L1A vEnD52xDd90V6q9OjGadaV6ub8pJEP19PZtySlMi/E+by37M2f1cWqVAadtHbx1MQSYA 0xk/7P6Gbk1XKQHldjM3GbJlJsB9qSaNthc0OPRs9A+z7DcQnA735sZ9uPliKohtWITZ 8K7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u9KDPpjVKPB5sOQxBI2Abbi3wGikXqFCKNDvpCWP0FU=; b=SwvY1SgQVdh1wUoePuWCOdOoAssJdD9C+GtoExieY0hDibL0t8RwrnQolc2NvEtlzF EgjQVZBtkjf8xdEKb8PsPAStcle5esXOspcZw8xxbe93FLAo4hkAjxbcHtS+XLnutC0i Bt5Zbndw4IL7L3zgh7NVFzWXRsJP072Rp8MtMuAIRNWi1Xf/AjqgJSmde3QEGHRQMBmb CVeBpYAsp2aEKC73bBe/cPYjSUUmZK1/sOx7HWIqmhS1umlgvaV5AierYPTbhQodocv2 aVV6pYle8nEmfaxnAmQsI/kMiCZUwJBl0d8H+q3QsJ+CteVU1Iw/z7rILA4uuUXad1JM o6Pg== X-Gm-Message-State: AFqh2krFYgsplTmXVeq5ioNX1iAFPF2tX8k9dXFeEKRanjbNGhmoCg/E ep1KNAL30pL4DzmjXMlR5kq5AyXNzeE= X-Google-Smtp-Source: AMrXdXtH7lBqibmwThD1nA1HAiRVvadzNEpssJMoEV8806t/XJLHi+OsNhMCij1fobz8/UIp6cNVYw== X-Received: by 2002:adf:fd0f:0:b0:2be:4639:ee27 with SMTP id e15-20020adffd0f000000b002be4639ee27mr3835467wrr.1.1674677356684; Wed, 25 Jan 2023 12:09:16 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id r13-20020adfdc8d000000b002bfb5bda59asm3288112wrj.25.2023.01.25.12.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:09:16 -0800 (PST) Date: Wed, 25 Jan 2023 21:09:14 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/11] staging: rtl8192e: Remove unused variables txov.., txbeokint and txbkokint Message-ID: <023f612dc35eca3a74c31344f7dbb168180bf437.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" txoverflow, txbeokint and txbkokint are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 ----- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index ff9dc06642f6..768324cbe253 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2181,17 +2181,12 @@ static irqreturn_t _rtl92e_irq(int irq, void *netde= v) if (inta & IMR_RXFOVW) tasklet_schedule(&priv->irq_rx_tasklet); =20 - if (inta & IMR_TXFOVW) - priv->stats.txoverflow++; - if (inta & IMR_BKDOK) { - priv->stats.txbkokint++; priv->rtllib->link_detect_info.NumTxOkInPeriod++; _rtl92e_tx_isr(dev, BK_QUEUE); } =20 if (inta & IMR_BEDOK) { - priv->stats.txbeokint++; priv->rtllib->link_detect_info.NumTxOkInPeriod++; _rtl92e_tx_isr(dev, BE_QUEUE); } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 2d1561a202d0..96d340f686e9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { =20 struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txoverflow; - unsigned long txbeokint; - unsigned long txbkokint; unsigned long txviokint; unsigned long txvookint; unsigned long txbeaconokint; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7EBC27C76 for ; Wed, 25 Jan 2023 20:10:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236341AbjAYUKF (ORCPT ); Wed, 25 Jan 2023 15:10:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236343AbjAYUJt (ORCPT ); Wed, 25 Jan 2023 15:09:49 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B03425D911 for ; Wed, 25 Jan 2023 12:09:25 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso2134967wmq.5 for ; Wed, 25 Jan 2023 12:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gMf09+fC4QI99DmXPRyQuRL+tFfoSe44zXEcxxr3d1Q=; b=pfhjKcsDMG0B6iYPy1uEpIfPgWWhr2EgYByXnBIKOjyeXxqKfvfk/XevDGkyN8CCTG 16TteLtHyrNqg3yu6p5xze1CVd3TY/TGKo4DSghVvYHCArXdJMQuu9mWRoiXXtqsDrn6 ohxv+G5zIn7LY0YrnCnNfKC83qiVIMcpYA6uuxogHZ/jcOlBJFYmV7lCe+sNR1dyCxfM D1VC9PZQ9SjwFKdS3uakSJVG3z4+sSJretwpGLGSJzmaQjK4ngH+YDsZUQpH3KWFAuH4 ksYOHcqbqcEA/Bg8bBp6uAhwRgOG9y04bn4AnlgUOx/1UzZnErubqvtmvy0ZD/6R0hPr pSYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gMf09+fC4QI99DmXPRyQuRL+tFfoSe44zXEcxxr3d1Q=; b=EjBWDhguTHHxcKjGntGIJKAkpii2ybxurZZCYM6ZrV1QiHLgn776oqrcryn637qEQs f+bTLFFzTjnfgcQ/kMOOM8Z+awdQPsPYmlM+J8M+g1EYjBASJ41uS/LRk3hFQKt9J4hH VafOLXqCVZuZcHVnfYLCCsOKOxmqBkHRBdy/PaOEb32kWP/AaQd5vexfKomuL3J2Dz8b bfb3r+vmfZK4Rqsan8kh6Fck5D7IQ3XZ7CJFFz8xflRk0z34xeoLLzRxbtRXSHDqEkaU yHZdN8fxIwYrmpDYYE2PT7zsK2+9ucBbhlLVp7hLFV0W71rjdXwMFYdQAKiTgUri0szb zd3Q== X-Gm-Message-State: AFqh2kq81iqlkLE0Ohxoa8x5Z8LFUrdMRQupD9++p6ERajQywaeFYYpD jYMqDL+Y6gaLMJL6GnIW44c= X-Google-Smtp-Source: AMrXdXuRK3unvrxzTT2n3UwgPxByGkxRMh16tfnSW1GPMorniKmgRgivipCX6eq2+CH7VhJg8DoW2Q== X-Received: by 2002:a05:600c:3ba8:b0:3d9:8635:a901 with SMTP id n40-20020a05600c3ba800b003d98635a901mr8574306wms.3.1674677362197; Wed, 25 Jan 2023 12:09:22 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id t16-20020a05600c329000b003d35acb0fd7sm2685430wmp.34.2023.01.25.12.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:09:21 -0800 (PST) Date: Wed, 25 Jan 2023 21:09:20 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/11] staging: rtl8192e: Remove unused variables txviok.., txvook.. and txbea.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" txviokint, txvookint and txbeaconokint are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 ----- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 768324cbe253..4cc90425fa4c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2139,9 +2139,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) goto done; } =20 - if (inta & IMR_TBDOK) - priv->stats.txbeaconokint++; - if (inta & IMR_TBDER) priv->stats.txbeaconerr++; =20 @@ -2192,13 +2189,11 @@ static irqreturn_t _rtl92e_irq(int irq, void *netde= v) } =20 if (inta & IMR_VIDOK) { - priv->stats.txviokint++; priv->rtllib->link_detect_info.NumTxOkInPeriod++; _rtl92e_tx_isr(dev, VI_QUEUE); } =20 if (inta & IMR_VODOK) { - priv->stats.txvookint++; priv->rtllib->link_detect_info.NumTxOkInPeriod++; _rtl92e_tx_isr(dev, VO_QUEUE); } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 96d340f686e9..f8b2201ea288 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { =20 struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txviokint; - unsigned long txvookint; - unsigned long txbeaconokint; unsigned long txbeaconerr; unsigned long txmanageokint; unsigned long txcmdpktokint; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57807C27C76 for ; Wed, 25 Jan 2023 20:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236368AbjAYUKH (ORCPT ); Wed, 25 Jan 2023 15:10:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236354AbjAYUJw (ORCPT ); Wed, 25 Jan 2023 15:09:52 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60ED75AA6C for ; Wed, 25 Jan 2023 12:09:30 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id q10so1265856wrm.4 for ; Wed, 25 Jan 2023 12:09:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NDxe4oIJJSUOqPRwp3G0IGOgJo50hIDpNvcK0HbcW+I=; b=qAtHh3HwGlWTIavwZBR9eHLTvK0r//m0TwA4Wf7MIK+sqNyRDS3PBTtmyYxSdDSyAz 0wCiETk9qiVzPJvSFoDDOueI0oJhHGQ5Lqa6G+DLURT6rn7UocCXrK2Pp5gYfhFFpOQc Nnc21ecuBb/maD0nI2yjRXyHfVHCjFXU8sIq6WkU7w4r7e50X5c+27sGqh91QyW44z7N qp5wDQqjntoRCjZ32ps2I21XkincXo2a7MgfTnSvvptA0UynoKz/F4ohixYTn9jQWKr3 3BgCXgoqm+RkgjaTMCe9F2TMhzCHvkOZd8F6RsN5TL5HBO2tckVNf6KlnSQsjQb7/MVv ylxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NDxe4oIJJSUOqPRwp3G0IGOgJo50hIDpNvcK0HbcW+I=; b=bqyNKzdnxHK1BiNOCUVrmYg1X6JhYhdW2mnMiHu+sepySAx0gwPKcwP3cxXC6CtVwf +B9Vt3f72vUYWNbj33NVzUa8JOjJITeChKS5BSsWPCc2DlJlQtFYa370+7EF8ODIxBqX krx6BwBpfmrLIiSNrf0m8kU1KBu6lIT6kIx1Gj/tBy8wVrOjoyrunMycZTJFIjRWivSE mEAeQZ6DEy50zT+MyunKCPzmQuddwvT2wcfM13Wzbfc+VoJqfQvau1KJRF2SqPU+L1J/ HNt5Ez1hXd7OggNimgezIRiotaZotl6Fh/x7VuaOFJQn9+N6DTclXK+bHrvuhOb6gL58 F49Q== X-Gm-Message-State: AO0yUKWQ2leQzaMDYzP4J5lS+vD3CT1kKmccTPQww/kN0vFo1ddwMyKy qxx2aCQ08uXynA487f3Ar3M= X-Google-Smtp-Source: AK7set+gKyL1/EbwngB0SCDE5eQm9o64IfenrGX4+jjBe5iXQY2tEPg5qF3+P6yRQEdKGjIvZeijFg== X-Received: by 2002:adf:e3d0:0:b0:2bf:b41c:61de with SMTP id k16-20020adfe3d0000000b002bfb41c61demr1049378wrm.4.1674677368768; Wed, 25 Jan 2023 12:09:28 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id f5-20020adffcc5000000b002bfae3f6802sm5124513wrs.58.2023.01.25.12.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:09:28 -0800 (PST) Date: Wed, 25 Jan 2023 21:09:26 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 10/11] staging: rtl8192e: Remove unused variables txbeac.., txman.. and txcmdp.. Message-ID: <6c922591c48512692f77729ac91849ebb4e61bd1.1674675808.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" txbeaconerr, txmanageokint and txcmdpktokint are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 +------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 4cc90425fa4c..2c5edda74e73 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2139,11 +2139,7 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) goto done; } =20 - if (inta & IMR_TBDER) - priv->stats.txbeaconerr++; - if (inta & IMR_MGNTDOK) { - priv->stats.txmanageokint++; _rtl92e_tx_isr(dev, MGNT_QUEUE); spin_unlock_irqrestore(&priv->irq_th_lock, flags); if (priv->rtllib->ack_tx_to_ieee) { @@ -2155,10 +2151,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) spin_lock_irqsave(&priv->irq_th_lock, flags); } =20 - if (inta & IMR_COMDOK) { - priv->stats.txcmdpktokint++; + if (inta & IMR_COMDOK) _rtl92e_tx_isr(dev, TXCMD_QUEUE); - } =20 if (inta & IMR_HIGHDOK) _rtl92e_tx_isr(dev, HIGH_QUEUE); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index f8b2201ea288..c6a4ac6ce959 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { =20 struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txbeaconerr; - unsigned long txmanageokint; - unsigned long txcmdpktokint; unsigned long txbytesmulticast; unsigned long txbytesbroadcast; unsigned long txbytesunicast; --=20 2.39.1 From nobody Sun Sep 14 06:35:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0165C27C76 for ; Wed, 25 Jan 2023 20:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236421AbjAYUKM (ORCPT ); Wed, 25 Jan 2023 15:10:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236405AbjAYUJ7 (ORCPT ); Wed, 25 Jan 2023 15:09:59 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B068F5CFF5 for ; Wed, 25 Jan 2023 12:09:38 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id k16so14625437wms.2 for ; Wed, 25 Jan 2023 12:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IUNK4telbL5iEm9hMJeiQP6SRHQdjAr35nMvZWBiILs=; b=REd4vr+NBUQzVGTn98U8rYpH2ztbkzE46mstrYzWVGqc6JaLtIGyXUEXeQaMNry8kG 8Np9kCEW0zrxUpZ0uq/bQCP247NQl8Ygff6Rb9Mw3xJXO4fufvQrpVUGHZJMM3+PjA/D bAWsJhV67XoXXs2EOA3HdfZY/4ohZvP8e8p4E9wInWYxMjseqMg7XlW+Tv94sDV3gUmg MdADRNptB9qFbCXuJzg8rPdfmcZa7Ax0OIT4RHo8R8inA0v+6DJ4A3S7keWLmHJPfb/q i39yTLdw2v91ILvGUGOOm8JeHw6bWSmVhJD0XSL6xTtFgHdQU6gZcgstxE0dzLk46uyd 9MHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IUNK4telbL5iEm9hMJeiQP6SRHQdjAr35nMvZWBiILs=; b=HGGpgvEoTEZGdG0N0p5x/Bj9Fhmu4P8pFrRTOIhHoql4Te33pQhQoM5IhYhlDJWigj DY2iM3frOuRln+9rrx68G2GnxiwkSuUd3wt0+/Whqxvzq82NN+PRgvGXEhFzPhC6QUwx Eea4a92yBgrrh7Zh63hzhtxPa59qHMX7qo88/PWmBFlrDE3+FBHvu9L4tQuE3EJUpi0n wD6JMQ04EZg5sXu0r0mWGR86lHHZWrniokA3No1upp706v5GB50RS2C5hy4+J1vNqA72 L2L6DM7cx8beTy6bYdlS/VzyvYM+QP6AKSrxXdAEgWKArseJ/iG9K9fKr3oFdKjHHQGW etug== X-Gm-Message-State: AFqh2kp+Lu17EzFC9tp0B+z0QysfcWBFKakHxT3EBMtbvu1EjWSKGdP8 FJ3fyhIIK57p+ObfQmJ6Qu4= X-Google-Smtp-Source: AMrXdXuepv1cKXrMXx18nZpaMQWWKMg9TVj9FBgPL1rBbx9bj+2ZLOkP+Euv57+gjC7jBl1bo1b82Q== X-Received: by 2002:a05:600c:1c83:b0:3da:ff24:4b93 with SMTP id k3-20020a05600c1c8300b003daff244b93mr8571356wms.3.1674677374737; Wed, 25 Jan 2023 12:09:34 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id h24-20020a05600c499800b003dc1a525f22sm2642847wmp.25.2023.01.25.12.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 12:09:34 -0800 (PST) Date: Wed, 25 Jan 2023 21:09:32 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/11] staging: rtl8192e: Remove unused variables txbytes.., txbyt.. and signa.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" txbytesmulticast, txbytesbroadcast and signal_quality are initialized and increased or set but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +----- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 9d13fda33fbf..3989d484cc33 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1613,7 +1613,6 @@ static void _rtl92e_process_phyinfo(struct r8192_priv= *priv, u8 *buffer, =20 tmp_val =3D priv->stats.slide_evm_total / slide_evm_statistics; - priv->stats.signal_quality =3D tmp_val; priv->stats.last_signal_strength_inpercent =3D tmp_val; } =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 2c5edda74e73..f8a8ece40ac1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1616,11 +1616,7 @@ static short _rtl92e_tx(struct net_device *dev, stru= ct sk_buff *skb) type =3D WLAN_FC_GET_TYPE(fc); pda_addr =3D header->addr1; =20 - if (is_broadcast_ether_addr(pda_addr)) - priv->stats.txbytesbroadcast +=3D skb->len - fwinfo_size; - else if (is_multicast_ether_addr(pda_addr)) - priv->stats.txbytesmulticast +=3D skb->len - fwinfo_size; - else + if (!is_broadcast_ether_addr(pda_addr) && !is_multicast_ether_addr(pda_ad= dr)) priv->stats.txbytesunicast +=3D skb->len - fwinfo_size; =20 spin_lock_irqsave(&priv->irq_th_lock, flags); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index c6a4ac6ce959..4cf776094ac0 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,8 +184,6 @@ enum reset_type { =20 struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txbytesmulticast; - unsigned long txbytesbroadcast; unsigned long txbytesunicast; unsigned long rxbytesunicast; unsigned long txretrycount; @@ -195,7 +193,6 @@ struct rt_stats { unsigned long slide_rssi_total; unsigned long slide_evm_total; long signal_strength; - long signal_quality; long last_signal_strength_inpercent; long recv_signal_power; u8 rx_rssi_percentage[4]; --=20 2.39.1