From nobody Thu Apr 9 12:06:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67803C38142 for ; Mon, 23 Jan 2023 19:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232073AbjAWTGZ (ORCPT ); Mon, 23 Jan 2023 14:06:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231501AbjAWTGY (ORCPT ); Mon, 23 Jan 2023 14:06:24 -0500 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7616F2FCEA for ; Mon, 23 Jan 2023 11:06:22 -0800 (PST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:6083:1fd7:ba05:ea8d]) by baptiste.telenet-ops.be with bizsmtp id CK6L2900P4604Ck01K6LwW; Mon, 23 Jan 2023 20:06:21 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1pK28y-0076NU-L1; Mon, 23 Jan 2023 20:06:20 +0100 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1pK296-00Ekpu-IJ; Mon, 23 Jan 2023 20:06:20 +0100 From: Geert Uytterhoeven To: Magnus Damm Cc: Wolfram Sang , Ulrich Hecht , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 1/2] arm64: dts: renesas: r8a779g0: Add CAN-FD node Date: Mon, 23 Jan 2023 20:06:18 +0100 Message-Id: <6c55d0995089917216ee261a8b8cbb980c7b5304.1674500205.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add device nodes for the CAN-FD interface and the related external CAN clock on the Renesas R-Car V4H (R8A779G0) SoC. Based on a patch in the BSP by Kazuya Mizuguch. Signed-off-by: Geert Uytterhoeven --- Changes compared to the BSP: - Add family-specific compatible value, - Correct reg size, - Add missing interrupt-names. --- arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 57 +++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dt= s/renesas/r8a779g0.dtsi index 83d1666a2ea16de2..d4cc89e49c68d52e 100644 --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi @@ -14,6 +14,13 @@ / { #address-cells =3D <2>; #size-cells =3D <2>; =20 + /* External CAN clock - to be overridden by boards that provide it */ + can_clk: can { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <0>; + }; + cluster0_opp: opp-table-0 { compatible =3D "operating-points-v2"; opp-shared; @@ -676,6 +683,56 @@ hscif3: serial@e66a0000 { status =3D "disabled"; }; =20 + canfd: can@e6660000 { + compatible =3D "renesas,r8a779g0-canfd", + "renesas,rcar-gen4-canfd"; + reg =3D <0 0xe6660000 0 0x8500>; + interrupts =3D , + ; + interrupt-names =3D "ch_int", "g_int"; + clocks =3D <&cpg CPG_MOD 328>, + <&cpg CPG_CORE R8A779G0_CLK_CANFD>, + <&can_clk>; + clock-names =3D "fck", "canfd", "can_clk"; + assigned-clocks =3D <&cpg CPG_CORE R8A779G0_CLK_CANFD>; + assigned-clock-rates =3D <80000000>; + power-domains =3D <&sysc R8A779G0_PD_ALWAYS_ON>; + resets =3D <&cpg 328>; + status =3D "disabled"; + + channel0 { + status =3D "disabled"; + }; + + channel1 { + status =3D "disabled"; + }; + + channel2 { + status =3D "disabled"; + }; + + channel3 { + status =3D "disabled"; + }; + + channel4 { + status =3D "disabled"; + }; + + channel5 { + status =3D "disabled"; + }; + + channel6 { + status =3D "disabled"; + }; + + channel7 { + status =3D "disabled"; + }; + }; + avb0: ethernet@e6800000 { compatible =3D "renesas,etheravb-r8a779g0", "renesas,etheravb-rcar-gen4"; --=20 2.34.1 From nobody Thu Apr 9 12:06:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5E4C38142 for ; Mon, 23 Jan 2023 19:06:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232266AbjAWTG3 (ORCPT ); Mon, 23 Jan 2023 14:06:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231501AbjAWTG0 (ORCPT ); Mon, 23 Jan 2023 14:06:26 -0500 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1166C2FCF6 for ; Mon, 23 Jan 2023 11:06:23 -0800 (PST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:6083:1fd7:ba05:ea8d]) by michel.telenet-ops.be with bizsmtp id CK6L2900F4604Ck06K6Lbw; Mon, 23 Jan 2023 20:06:22 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1pK28y-0076NW-LM; Mon, 23 Jan 2023 20:06:20 +0100 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1pK296-00Ekpx-Iu; Mon, 23 Jan 2023 20:06:20 +0100 From: Geert Uytterhoeven To: Magnus Damm Cc: Wolfram Sang , Ulrich Hecht , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 2/2] arm64: dts: renesas: white-hawk: Add CAN-FD support Date: Mon, 23 Jan 2023 20:06:19 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Enable confirmed-working CAN-FD channels 0 and 1 on the White-Hawk development board: - Channel 0 uses an NXP TJR1443AT CAN transceiver, which is be enabled through a GPIO, - Channels 1-7 use Microchip MCP2558FD-H/SN CAN transceivers (not mounted for channels 4-7), which do not need explicit description, but channels 2-3 do not seem to work. Inspired by a patch in the BSP by Kazuya Mizuguch. Signed-off-by: Geert Uytterhoeven --- This depends on "[PATCH 2/2] phy: phy-can-transceiver: Add support for NXP TJR1443" https://lore.kernel.org/all/0bfa1e4c43632e49c9512b4e7daa970545545dcf.167403= 7830.git.geert+renesas@glider.be Changed compared to the BSP: - Add can_clk, - Add missing can_transceiver0, - Disable channels 2-7. Tested using cansend, candump, and canfdtest. - Channel 2 does not work: "bus-off" error message. - Channel 3 does not work: - Using cansend on another interface, and candump on can3 shows that nothing is received. However, my scope does see the data on the bus, and it is not sent repeatedly, hence it must have been acked by the receiver. - Using canfdtest on can3 gives: can3: Message ID mismatch! expected: 0078: [8] 01 02 03 04 05 06 07 08 received: 0077: [8] 00 01 02 03 04 05 06 07 Note that describing a plain gpio-hog instead of can_transceiver0 is not sufficient, as the enable signal must not be asserted before initialization of the CAN-FD controller, --- .../boot/dts/renesas/r8a779g0-white-hawk.dts | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk.dts b/arch/arm= 64/boot/dts/renesas/r8a779g0-white-hawk.dts index 04a2b6b83e743f32..eff1ef6e2cc83aba 100644 --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk.dts +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk.dts @@ -13,6 +13,33 @@ / { model =3D "Renesas White Hawk CPU and Breakout boards based on r8a779g0"; compatible =3D "renesas,white-hawk-breakout", "renesas,white-hawk-cpu", "= renesas,r8a779g0"; + + can_transceiver0: can-phy0 { + compatible =3D "nxp,tjr1443"; + #phy-cells =3D <0>; + enable-gpios =3D <&gpio1 3 GPIO_ACTIVE_HIGH>; + max-bitrate =3D <5000000>; + }; +}; + +&can_clk { + clock-frequency =3D <40000000>; +}; + +&canfd { + pinctrl-0 =3D <&canfd0_pins>, <&canfd1_pins>, <&can_clk_pins>; + pinctrl-names =3D "default"; + + status =3D "okay"; + + channel0 { + status =3D "okay"; + phys =3D <&can_transceiver0>; + }; + + channel1 { + status =3D "okay"; + }; }; =20 &i2c0 { @@ -23,3 +50,20 @@ eeprom@51 { pagesize =3D <8>; }; }; + +&pfc { + can_clk_pins: can-clk { + groups =3D "can_clk"; + function =3D "can_clk"; + }; + + canfd0_pins: canfd0 { + groups =3D "canfd0_data"; + function =3D "canfd0"; + }; + + canfd1_pins: canfd1 { + groups =3D "canfd1_data"; + function =3D "canfd1"; + }; +}; --=20 2.34.1