From nobody Fri Apr 17 10:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD90CC4332F for ; Fri, 2 Dec 2022 09:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232707AbiLBJjQ (ORCPT ); Fri, 2 Dec 2022 04:39:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232937AbiLBJjC (ORCPT ); Fri, 2 Dec 2022 04:39:02 -0500 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 668CAB5D9B for ; Fri, 2 Dec 2022 01:39:01 -0800 (PST) Received: by mail-pf1-f169.google.com with SMTP id c15so4385477pfb.13 for ; Fri, 02 Dec 2022 01:39:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z0HPGO5sCDYER8nLUp0b1v0HtrgxMZNE6bVgRCZ1Yeo=; b=P/qk4oZLqrAsqVK4/jnSl3q8IgbW3j+klplsHe3l81+pvr0S8zC0nRpgD2T0jKBBXw 7XAWNtkwvaQU8pWFh92uCbDuluxJDSffE8D5yOcUrjjRqjuSoZ6W78fMjSju132raAVW pVr3fyYck+tYx/HXajAlMNr3n/GPje5C51ZtlPhJCQ7tMVYGf9C8LQ3Bft7/zFQS2+3O N9WhYQx6+wb1L56GfcwK8kFn/N8oqrWsGnGiZeZDDsbllQm1xdKioFA/AuWNiIUVJU26 vlNExzgSEs9BMCnxrV2XO+c6AVC2aQvkPslqxZ+ZtQ3iZxxQDddCL4UnFIAmB6kBQ/2r yyMw== X-Gm-Message-State: ANoB5pki36Q0rWdSz7OMTBfWOV9LMx9Num3KvnI8syF9dDknbeD/lZez XlK0X7mcPTqyLag/vtQPRrY= X-Google-Smtp-Source: AA0mqf7W2TXFm/GNZrafRIqn4w21vsuQ6VvwezFXzzneUimTFz9VgvlZ9ut8pM+ancPPVzQ60GVczA== X-Received: by 2002:a63:f845:0:b0:478:1187:b58 with SMTP id v5-20020a63f845000000b0047811870b58mr22256887pgj.43.1669973940511; Fri, 02 Dec 2022 01:39:00 -0800 (PST) Received: from redsun91.ssa.fujisawa.hgst.com ([129.253.182.55]) by smtp.gmail.com with ESMTPSA id d15-20020a17090a564f00b001ef8ab65052sm4370881pji.11.2022.12.02.01.38.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 01:38:59 -0800 (PST) From: Johannes Thumshirn To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Johannes Thumshirn , Zhengchao Shao Subject: [PATCH 1/2] drivers: mcb: fix resource leak in mcb_probe() Date: Fri, 2 Dec 2022 01:38:49 -0800 Message-Id: <9f87de36bfb85158b506cb78c6fc9db3f6a3bad1.1669624063.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Zhengchao Shao When probe hook function failed in mcb_probe(), it doesn't put the device. Compiled test only. Fixes: 7bc364097a89 ("mcb: Acquire reference to device in probe") Signed-off-by: Zhengchao Shao Signed-off-by: Johannes Thumshirn --- drivers/mcb/mcb-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c index 338fc889b357..b8ad4f16b4ac 100644 --- a/drivers/mcb/mcb-core.c +++ b/drivers/mcb/mcb-core.c @@ -71,8 +71,10 @@ static int mcb_probe(struct device *dev) =20 get_device(dev); ret =3D mdrv->probe(mdev, found_id); - if (ret) + if (ret) { module_put(carrier_mod); + put_device(dev); + } =20 return ret; } --=20 2.37.3 From nobody Fri Apr 17 10:24:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29871C4332F for ; Fri, 2 Dec 2022 09:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232505AbiLBJjV (ORCPT ); Fri, 2 Dec 2022 04:39:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232504AbiLBJjE (ORCPT ); Fri, 2 Dec 2022 04:39:04 -0500 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45C3DB7DDF for ; Fri, 2 Dec 2022 01:39:03 -0800 (PST) Received: by mail-pg1-f173.google.com with SMTP id s196so3958479pgs.3 for ; Fri, 02 Dec 2022 01:39:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OTUvgvzDNVb3Q9BB7bRv2FXaIaCGfv+EeGtlZYfVaoQ=; b=hMvIFlwlVksw1eDYumOyDAe11st4Yq+ToOip5YnUcW5IwJNugmUb5q4tjItT0aLg/g ZGEZJosDgbqFI6/v6pFNmaUhRn32NHYNdix/RZIExGDNKFOMKkDliczA9U9/xZrxE58K MdWNRAAbO50wdaSO/Qc3XwLAb/0gv/0aBMRLxheLiT7zmcyBZuOrTyiUjfLppMTbguJl VSqVmyVXlkEWjah4ofHrHaRYP0KAxH/Erbri50B5okozhkrwG5x71uPU233dj7gDzpfY YQ1gEdKVDcY91IDBTLS9CXrYWla8a8bSE3TTfst6uss5M45xO9uBMHa9rYL9R+TZlJhd 8DfA== X-Gm-Message-State: ANoB5pkwNl5pX7L3+ZHXSOBshPYbPKnxMAXkMPN2A17HVqbhR9xpkUfR iD0j0t0Zj7LICEN9rLUOwDs= X-Google-Smtp-Source: AA0mqf6J1M+yCJEF5nYzQWdCHEx6Sr9pLrtgXjbBufF2fVOSOVHalEqonlNYxQzI8ak98NKtBx2JCQ== X-Received: by 2002:a05:6a00:3017:b0:56b:ac5c:f3dc with SMTP id ay23-20020a056a00301700b0056bac5cf3dcmr53663510pfb.77.1669973942742; Fri, 02 Dec 2022 01:39:02 -0800 (PST) Received: from redsun91.ssa.fujisawa.hgst.com ([129.253.182.55]) by smtp.gmail.com with ESMTPSA id d15-20020a17090a564f00b001ef8ab65052sm4370881pji.11.2022.12.02.01.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 01:39:01 -0800 (PST) From: Johannes Thumshirn To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Johannes Thumshirn , Yang Yingliang Subject: [PATCH 2/2] mcb: mcb-parse: fix error handing in chameleon_parse_gdd() Date: Fri, 2 Dec 2022 01:38:50 -0800 Message-Id: X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Yang Yingliang If mcb_device_register() returns error in chameleon_parse_gdd(), the refcou= nt of bus and device name are leaked. Fix this by calling put_device() to give= up the reference, so they can be released in mcb_release_dev() and kobject_cle= anup(). Fixes: 3764e82e5150 ("drivers: Introduce MEN Chameleon Bus") Signed-off-by: Yang Yingliang Reviewed-by: Johannes Thumshirn Signed-off-by: Johannes Thumshirn --- drivers/mcb/mcb-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c index 0266bfddfbe2..aa6938da0db8 100644 --- a/drivers/mcb/mcb-parse.c +++ b/drivers/mcb/mcb-parse.c @@ -108,7 +108,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus, return 0; =20 err: - mcb_free_dev(mdev); + put_device(&mdev->dev); =20 return ret; } --=20 2.37.3