From nobody Thu Apr 16 00:48:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84894C4332F for ; Tue, 22 Nov 2022 22:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234943AbiKVWqH (ORCPT ); Tue, 22 Nov 2022 17:46:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235043AbiKVWqC (ORCPT ); Tue, 22 Nov 2022 17:46:02 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EAB1BEB71 for ; Tue, 22 Nov 2022 14:46:01 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id p16so11908283wmc.3 for ; Tue, 22 Nov 2022 14:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LaM4uBFPK4LMbdxsIb7pxDSXVMQTFFMHLlfL2JcjVUM=; b=bWZjjnUkUXYQxbQ42tbjZksddrd+wvEx1I46C6UKITkM/8kfuyE3hogrMMlwh2IjKw rHsxbr7rxGwJQdOuptveRWF5qtSx/KQRNEA4O9k1EWu5UztaoRoDhMsIdVGRbFUqsBWp GbTEhkvaPbOpvRQ5cVsx2NLYzyCXZfpl4neqUN1mvwS1egOkWxIGCnENmDAYonbRjiTH B5h5konFG5/TSCSjrDJKp/W4Xx9jtmX4HqwRBVUxw4XEb/IrHhJQSYhjKfxbtlL4j3uZ HfbwzAK0p0ES8y3FY7EFo3FFtimky4pJB1SWinkCpHw2hkKh9/EDP4vL9VzsX6xFjMKF JS0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LaM4uBFPK4LMbdxsIb7pxDSXVMQTFFMHLlfL2JcjVUM=; b=PVu3j7oBKxRe1aapP6WXptr92E2KlU/5fzPQEVCiJue+EgqHumNor8/PQLBlt+ruRP nrufHow4gYmTQQ6OaNsYLoHFN9WzsfFMxTzpqsZy8iS1qLqecVeeZgGZE0uwrgYFnqgS Vg6ecpJKmfrgYNK8ZQzZq7s6ykplE9aphtQl837kJt70d3//YfrOMZSoH3qirJ8LFj0O t9sXcNpHgRW/+fC7JgNZAsF9FyAQNVRAlmUJ7JqbcqEmLz+ACbob7uWynZ3lfIPPsIjq ImnbAh8Xrm/Zrg+18Y0Uz3ZiTC4PP4hB8WzPzkTn4wAhnzf2UGIHL5mLqXSAvku3VWoW 1CPQ== X-Gm-Message-State: ANoB5pmMKDG6OwqrvY3KSyptgvTmVFFurPOKBg3AL2Rl1RaOB/ouYiyn LXeqfRB+tDvQfqdq3S/WYju0xLEYk0w= X-Google-Smtp-Source: AA0mqf7O/pfxst0Zs/QaWzPCTIu3maDJVE6OQHbQrUhRJmYB+NpG+EhA/mdGAk3WWagvkQf9osM1LA== X-Received: by 2002:a05:600c:1ca4:b0:3cf:7125:fc1d with SMTP id k36-20020a05600c1ca400b003cf7125fc1dmr4421820wms.70.1669157159967; Tue, 22 Nov 2022 14:45:59 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id s2-20020adff802000000b00241c712916fsm13824559wrp.0.2022.11.22.14.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:45:59 -0800 (PST) Date: Tue, 22 Nov 2022 23:45:57 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] staging: rtl8192e: Remove unchanged variable AcmMethod Message-ID: <7d73a66184e13d5f8d4af7d21564032247a7e923.1669156825.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" AcmMethod is initialized and never changed. The evaluation will always have the same result. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- drivers/staging/rtl8192e/rtl819x_Qos.h | 7 ------- 4 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index b9c846015d28..80eba5d5ab37 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -224,8 +224,6 @@ void rtl92e_set_reg(struct net_device *dev, u8 variable= , u8 *val) u8 acm =3D pAciAifsn->f.acm; u8 AcmCtrl =3D rtl92e_readb(dev, AcmHwCtrl); =20 - AcmCtrl =3D AcmCtrl | ((priv->AcmMethod =3D=3D 2) ? 0x0 : 0x1); - if (acm) { switch (eACI) { case AC0_BE: diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 399ee9783f99..a8cbeb9545da 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -830,7 +830,6 @@ static void _rtl92e_init_priv_variable(struct net_devic= e *dev) struct r8192_priv *priv =3D rtllib_priv(dev); u8 i; =20 - priv->AcmMethod =3D eAcmWay2_SW; priv->dot11_current_preamble_mode =3D PREAMBLE_AUTO; priv->rtllib->status =3D 0; priv->polling_timer_on =3D 0; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index b1656d4ecbad..54c7a2128053 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -340,8 +340,6 @@ struct r8192_priv { struct bb_reg_definition PHYRegDef[4]; struct rate_adaptive rate_adaptive; =20 - enum acm_method AcmMethod; - struct rt_firmware *pFirmware; enum rtl819x_loopback LoopbackMode; =20 diff --git a/drivers/staging/rtl8192e/rtl819x_Qos.h b/drivers/staging/rtl81= 92e/rtl819x_Qos.h index 5073f9f40fdc..c010eb0d6036 100644 --- a/drivers/staging/rtl8192e/rtl819x_Qos.h +++ b/drivers/staging/rtl8192e/rtl819x_Qos.h @@ -97,13 +97,6 @@ enum direction_value { DIR_BI_DIR =3D 3, }; =20 -enum acm_method { - eAcmWay0_SwAndHw =3D 0, - eAcmWay1_HW =3D 1, - eAcmWay2_SW =3D 2, -}; - - struct acm { u64 UsedTime; u64 MediumTime; --=20 2.37.3 From nobody Thu Apr 16 00:48:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6607C433FE for ; Tue, 22 Nov 2022 22:46:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231773AbiKVWqb (ORCPT ); Tue, 22 Nov 2022 17:46:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235123AbiKVWqR (ORCPT ); Tue, 22 Nov 2022 17:46:17 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEA15C902B for ; Tue, 22 Nov 2022 14:46:11 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id v1so26945396wrt.11 for ; Tue, 22 Nov 2022 14:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4kX4/EANOvk92+tIojhRVqHRQq3FkLftzIvzrby6dVc=; b=O+zXr+8OCFBH3GxbvFTezKFVJ1vV6pp7rEsO9XTqBKuUBAcPD9j+YRjL0x8q2kLrwA 4HW809wY/kZRcV0JxQYe4OCHg4xztFfFuVCJtvIN7fSrFs96wovcZj5fzvx/GjQ2ijgY yz25SMG9Rr8C7MzNvPAQpvG9r5xDBJrcXt0+AGjtgZzDbBVqtsirDHBNuZpa2fXSDrJb SEfDmDajMlZgkTumExqpDrCCtPu69E50ouWOy734MnDQ+u6D2Usvm6NAetu+mSDqmIH1 VZkL/5Qjhr6wb0gHDxkz4ivqIT9iGO8uRzGHjiKYiDYaZXPqh2d7IGCl52OCEOt/tFQ6 NAug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4kX4/EANOvk92+tIojhRVqHRQq3FkLftzIvzrby6dVc=; b=sJqOis0QBDihA2BAN+yxEeomdwmXkRpqTn7jHr1K0dbbcotMsjiXuHo908PRJvZkc8 eG6TlR12bHlA5q13Xpyqd+JyA5KWGF5T8CWacfKxomUXLgMh2AZaa3wRqAvC3PWd8qrc Q2klLpjyUitX0C75GtonbvC/XEMHlT9NisfvjZ/ZgLLxbgxMto6N02AXyaH30eHpDnVh GjR1F91hbNDq2c/oNvHvsLBVEjcuB05aA7tfo0ePHGUn3WSfktEmQyIhyMoaHXYfNt4C 2p/JaXaGARnK7FmcisuQTqqS7zOPXyVsj0je7hizsRvwsioHR2qj9cq1wP2ARKf50/Or UL/w== X-Gm-Message-State: ANoB5pkhh7CzojV/FbB9XVYmhK27F99qHV6IJpPlcHU11p25gP5e7wBZ /OjRSsbnNQX3Jlfj4G+GkYE= X-Google-Smtp-Source: AA0mqf6A/nblVO+geoFYaq9gruFl8YL+W6oIjovbTzlwhfG4ceSGhlTRUikeMKLrkKDwaG2NS3RzTw== X-Received: by 2002:a5d:4533:0:b0:241:d13a:1d52 with SMTP id j19-20020a5d4533000000b00241d13a1d52mr8711702wra.270.1669157170445; Tue, 22 Nov 2022 14:46:10 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id m35-20020a05600c3b2300b003cfd0bd8c0asm133961wms.30.2022.11.22.14.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:46:10 -0800 (PST) Date: Tue, 22 Nov 2022 23:46:08 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] staging: rtl8192e: Remove unused variable skb_aggQ Message-ID: <3197be3cb412eea1c662a5bec1b1afda2cee675d.1669156825.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" skb_aggQ is initialized, never used and purged. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 -- drivers/staging/rtl8192e/rtllib.h | 1 - 3 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 80eba5d5ab37..f02e67f68e23 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1946,8 +1946,6 @@ void rtl92e_stop_adapter(struct net_device *dev, bool= reset) =20 for (i =3D 0; i < MAX_QUEUE_SIZE; i++) skb_queue_purge(&priv->rtllib->skb_waitQ[i]); - for (i =3D 0; i < MAX_QUEUE_SIZE; i++) - skb_queue_purge(&priv->rtllib->skb_aggQ[i]); =20 skb_queue_purge(&priv->skb_queue); } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index a8cbeb9545da..369a59a753fe 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -903,8 +903,6 @@ static void _rtl92e_init_priv_variable(struct net_devic= e *dev) =20 for (i =3D 0; i < MAX_QUEUE_SIZE; i++) skb_queue_head_init(&priv->rtllib->skb_waitQ[i]); - for (i =3D 0; i < MAX_QUEUE_SIZE; i++) - skb_queue_head_init(&priv->rtllib->skb_aggQ[i]); } =20 static void _rtl92e_init_priv_lock(struct r8192_priv *priv) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 7119c9c5e1fe..1152fbf43383 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1624,7 +1624,6 @@ struct rtllib_device { int mgmt_queue_tail; u8 AsocRetryCount; struct sk_buff_head skb_waitQ[MAX_QUEUE_SIZE]; - struct sk_buff_head skb_aggQ[MAX_QUEUE_SIZE]; =20 bool bdynamic_txpower_enable; =20 --=20 2.37.3 From nobody Thu Apr 16 00:48:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7AF5C433FE for ; Tue, 22 Nov 2022 22:46:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235234AbiKVWqj (ORCPT ); Tue, 22 Nov 2022 17:46:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235176AbiKVWqT (ORCPT ); Tue, 22 Nov 2022 17:46:19 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5EDBC9A81 for ; Tue, 22 Nov 2022 14:46:18 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id b12so13191211wrn.2 for ; Tue, 22 Nov 2022 14:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=loIlTu8AgTjjJ6bJKu7RkzWKYzkXqArC4i+/pF5KBwc=; b=oMkaIW/0mTFAA+i4rUf7b+aSV01mbdvY80WjaKdbE1lKG6728xGMJDvIHEJWKg8Unj 0PpdDTQlSoXrkEL9Qc9gdm5BQft4jWf4YBsEcjZ7i+rE9nME86Wj0Va32womP+1zVUJ0 8MZQ0n6zRjv4QuV2yX7LwKipH4ajoAJad0o+WVOQCvMIQeyMR0gELhclStesHLnG/FIh qGZhfLz8Yf8PHpMt0W/ieN5GeG/Pg1h/feOSt/Jgd25L/THlGzXYrRRggcPXmiNvQbxB RKgUlhuYK8xq2qS15sWFlF4fDkI4+Lrt7kezfBtxK1q0ZodaDODHvTQL5LLFiQOWFUvY NLYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=loIlTu8AgTjjJ6bJKu7RkzWKYzkXqArC4i+/pF5KBwc=; b=d13qKqfUwDSgBf0ix0Gklm5K557BQVJYKW7OybzE4fpb97h6fCprfO5ZDvz07goK0m 4mfvwjNztXvhMyXH4nTMEKiDJ2u1ohwLeQtZ/R5WYZBpw8MyUv1qY8sLj1iKJf2GcLAl RY1ARa0CD7riMPeW12AgK3galrMUtp9T2haDKsLYZ0/pT9PgWpsjbS3sru3t2D6n5XWd kSONS/+MaqxUKxlbVOxF0OtEQN6DBg9tA/+4T3Gfw1vrSHzIVEa4pTmYJ/3g06qqfOYG K+ijMvkqcli4GFljZ4Z6MwW/KfM3BU3ScVNDTGfjQ2SRr/765DFrLOkLkbl+wWDtG2Js XB7A== X-Gm-Message-State: ANoB5plgmSx7V+MDLX5yd3IEHLc+DZO1ObuhLFa6zR7tVDumuTqVZbSt EzZfZSC368Hwy5BrKx/94IM= X-Google-Smtp-Source: AA0mqf6bsUikRzP+3fX620L7gB6pgldCvN4IFyO9E3NZs/QdGZGwZN8cA/zXdWwoubRAl+opBDkmWw== X-Received: by 2002:a5d:4bd2:0:b0:241:ec17:6cd8 with SMTP id l18-20020a5d4bd2000000b00241ec176cd8mr191941wrt.108.1669157177281; Tue, 22 Nov 2022 14:46:17 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id j15-20020adfe50f000000b002366d1cc198sm14886700wrm.41.2022.11.22.14.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:46:16 -0800 (PST) Date: Tue, 22 Nov 2022 23:46:15 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] staging: rtl8192e: Remove unused variable initialized_at_probe Message-ID: <4855b2dd5b7296b0eb10e697f605fb820e1dfc7b.1669156825.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" initialized_at_probe is initialized and never used. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 369a59a753fe..7b78bdfadc8d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -836,7 +836,6 @@ static void _rtl92e_init_priv_variable(struct net_devic= e *dev) priv->up_first_time =3D 1; priv->blinked_ingpio =3D false; priv->being_init_adapter =3D false; - priv->initialized_at_probe =3D false; priv->bdisable_nic =3D false; priv->bfirst_init =3D false; priv->txringcount =3D 64; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 54c7a2128053..1c00ad709a3c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -309,7 +309,6 @@ struct r8192_priv { =20 bool bfirst_init; bool bfirst_after_down; - bool initialized_at_probe; bool being_init_adapter; =20 int irq; --=20 2.37.3 From nobody Thu Apr 16 00:48:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37FE1C4332F for ; Tue, 22 Nov 2022 22:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbiKVWqm (ORCPT ); Tue, 22 Nov 2022 17:46:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235195AbiKVWq0 (ORCPT ); Tue, 22 Nov 2022 17:46:26 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E19B4CB9F1 for ; Tue, 22 Nov 2022 14:46:24 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id x5so22932239wrt.7 for ; Tue, 22 Nov 2022 14:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HLjjlcGTaW2VPVbDaaDB7cRE9v4ZMit0fR2VgDn30QM=; b=HTTkiYlIc9Ku+jNrHublAdad+nJaZNuUMCLWS0dq7OdKjZjk8DQKouCO+fBmIJXUr1 6Gj+FOHaPiWkfl2lUWAM0X5349dLz0y6ZkgASzs3o8LKGrcVIcRwK4o/scaGira1Jbn5 G2HZx9wQ2AU3FpjfYm33eUHPqhlQY0QfjMYrV7jfTLWgTkNWvTFwScR3b+cXfXXaX+JX cPKke3t2xd/1eg2v3Aj2lPFEOqzt1PpEQOuAFtrU/ZG6205y4XYsQG8tUKAwuwVPMHKa b17lcPfd6pnV6vbPWrda9dPDYfx8xHx/my+i13j16wQkMD3Nj28y515hKjQywLUqFYsl viHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HLjjlcGTaW2VPVbDaaDB7cRE9v4ZMit0fR2VgDn30QM=; b=Fc5o+/gZWKeKFGZqhvOBvOGBlN5vE0Qozh0Tasi9Ll8JRouGlq9XCu9YOBvDztKK+1 dqS9JFgwbLYtbxwYfUqt2hfc/VupEaJai8l91BLTcvXBdoe/knmorXvLd8QblWsYjymp Sek6RwzkwI5FqDJyCXLq9IUOsVr2Yhp22VL038TBNbcdhC8X4njvOAJql5RsXWSTLlKn R/U7Dn7dGFOSUeme+6tb5VuHKYwa170pyrawcHKzNVEW0aS7hcn5YAefauzUz8X/5bmc 2KhCzTza3D+GwkstkrXkARKBoc02yOuGuI2NgSqeXJUmFSPm5K/Jl5tXbq2h8uZk7HQ2 M4KQ== X-Gm-Message-State: ANoB5pnR4zXax5ZH4CM3n0FKcnTxUro2XKItuSomdGpiCixeBwpU36Gq HI4Pf3lZxHQloFdCGwAoKj8= X-Google-Smtp-Source: AA0mqf5XugPomKIinxu2xA5lQFggHnOmjU9XgebG8dPdPCVUfTH53hlM8f4GVwCweODBIXv/4e9sRQ== X-Received: by 2002:adf:ea52:0:b0:241:b999:9e8f with SMTP id j18-20020adfea52000000b00241b9999e8fmr14552580wrn.151.1669157183435; Tue, 22 Nov 2022 14:46:23 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id t5-20020a1c7705000000b003cfd4e6400csm154351wmi.19.2022.11.22.14.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:46:22 -0800 (PST) Date: Tue, 22 Nov 2022 23:46:21 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] staging: rtl8192e: Remove unused variable ChannelAccessSetting Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ChannelAccessSetting is never used. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 1c00ad709a3c..ca2e685148d4 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -234,15 +234,6 @@ struct rt_stats { u32 CurrentShowTxate; }; =20 -struct channel_access_setting { - u16 SIFS_Timer; - u16 DIFS_Timer; - u16 SlotTimeTimer; - u16 EIFS_Timer; - u16 CWminIndex; - u16 CWmaxIndex; -}; - struct init_gain { u8 xaagccore1; u8 xbagccore1; @@ -321,9 +312,6 @@ struct r8192_priv { struct delayed_work txpower_tracking_wq; struct delayed_work rfpath_check_wq; struct delayed_work gpio_change_rf_wq; - - struct channel_access_setting ChannelAccessSetting; - struct rtl819x_ops *ops; struct rtllib_device *rtllib; =20 --=20 2.37.3 From nobody Thu Apr 16 00:48:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA30C4332F for ; Tue, 22 Nov 2022 22:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235271AbiKVWq4 (ORCPT ); Tue, 22 Nov 2022 17:46:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234874AbiKVWqd (ORCPT ); Tue, 22 Nov 2022 17:46:33 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1939CEB97 for ; Tue, 22 Nov 2022 14:46:32 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id x17so13531235wrn.6 for ; Tue, 22 Nov 2022 14:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QEaJLedtxp4Hd4OqGYxt+eo5FX2zcD+DeLqh0BnkZRE=; b=htH6hiIze2cA8azBJCi1YaJk/VDgg84GAWotqblQ09VK/wBHIlp4u3VqNiJ8ufYlIZ yQV6VjC42gjeBOTKRlWYofvHJubGgUOHGnHFmAKufSrIStW3Df8tnKQNQ5i3xVh3jTMs S6S3x5gxJn9jNSOqO7lvraQpf44qwGKunVEVOF08Flwc9u1/I6QvaYrtpluz/BP5QjHt Za+Mn4P+WDNEFwQS01ihYWoC5l8zpPj7/TFC1OHRmyaSWdX/JlnKRboef72xCBl4rfPj Xtiu1eNh2Rh2w+fXn0pDoN6FlIj9WP+EcGUHsbv6Ib2u9LEqD0gx0D/qD6B5zcz2omiF rcsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QEaJLedtxp4Hd4OqGYxt+eo5FX2zcD+DeLqh0BnkZRE=; b=sMdKHIbNaGt3oFDBD/wLUMhxgRI9gAuKltJzHbT7MLoDh/bWQGR74okR06iasYQ6EW IfZoMhPjpToLjx7ONH1wc4iVjw++5EqBDYvJUsPCFFpx3JFiDDLtq/hBGZOdl9s1IERM SoJkkgM+on/2LXz0DDYA/oJLf6UnXfniIT166UjIfzXyQ5VpUJcjdiZgKxKrgBQAk7Dx +k7g0xIG4cnU6JVJVp4Envg1mCL5sPl7TgzbGlsncS6k7mDQMbnhpZAeRxxW3cD1U0KI fVw2Bm6rOByKr0gtLxcsavjcUsPWLnsuHnYwC4UOrmdTjSxRRHXnRrshmoRHoEIRmkC4 PZCA== X-Gm-Message-State: ANoB5pmoH/lCRVOIWQCugD9nLy0KgTu1aKUCK9X6nHEQ6MrwLjUSFvwv Rywp+6FsdHexW8xMrSWwWnMIJi7jVHE= X-Google-Smtp-Source: AA0mqf6wsqjCTuK+EIEbfNaR6eiboD6gYIG0Df1WvEzxJ/tgJfrjB4le2tp8RIaqluCvI3HVucqi6A== X-Received: by 2002:adf:c64e:0:b0:236:78cd:f3d2 with SMTP id u14-20020adfc64e000000b0023678cdf3d2mr16049108wrg.719.1669157191563; Tue, 22 Nov 2022 14:46:31 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id u17-20020a05600c19d100b003c6f8d30e40sm153935wmq.31.2022.11.22.14.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:46:31 -0800 (PST) Date: Tue, 22 Nov 2022 23:46:29 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] staging: rtl8192e: Remove unused variable int_log Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" int_log is initialized and incremented but never evaluated. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 15 --------------- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 3 files changed, 20 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8190P_def.h index 53fd79a28189..ac192254a4bb 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -154,21 +154,6 @@ struct tx_fwinfo_8190pci { =20 }; =20 -struct log_int_8190 { - u32 nIMR_COMDOK; - u32 nIMR_MGNTDOK; - u32 nIMR_HIGH; - u32 nIMR_VODOK; - u32 nIMR_VIDOK; - u32 nIMR_BEDOK; - u32 nIMR_BKDOK; - u32 nIMR_ROK; - u32 nIMR_RCOK; - u32 nIMR_TBDOK; - u32 nIMR_BDOK; - u32 nIMR_RXFOVW; -}; - struct phy_ofdm_rx_status_rxsc_sgien_exintfflag { u8 reserved:4; u8 rxsc:2; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 7b78bdfadc8d..f8fbe78ccad9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -866,8 +866,6 @@ static void _rtl92e_init_priv_variable(struct net_devic= e *dev) priv->rst_progress =3D RESET_TYPE_NORESET; priv->force_reset =3D false; memset(priv->rtllib->swcamtable, 0, sizeof(struct sw_cam_table) * 32); - - memset(&priv->int_log, 0, sizeof(struct log_int_8190)); priv->rx_ctr =3D 0; priv->rtllib->wx_set_enc =3D 0; priv->hw_radio_off =3D false; @@ -2185,7 +2183,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) =20 if (inta & IMR_ROK) { priv->stats.rxint++; - priv->int_log.nIMR_ROK++; tasklet_schedule(&priv->irq_rx_tasklet); } =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index ca2e685148d4..cceb77492363 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -317,8 +317,6 @@ struct r8192_priv { =20 struct work_struct reset_wq; =20 - struct log_int_8190 int_log; - enum rt_customer_id CustomerID; =20 =20 --=20 2.37.3