From nobody Thu Apr 9 01:41:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F8EC433FE for ; Wed, 2 Nov 2022 14:09:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbiKBOJV (ORCPT ); Wed, 2 Nov 2022 10:09:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbiKBOJQ (ORCPT ); Wed, 2 Nov 2022 10:09:16 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C346657F for ; Wed, 2 Nov 2022 07:09:13 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id g7so28443828lfv.5 for ; Wed, 02 Nov 2022 07:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vodxGcB9Pfq4inF2n1v2hS81nVigSig+J8tui1TzmuI=; b=e/qJP6e1FUzJhEUZWVa0R6rF1rF7EmWXTZq7dzIrJBXev+c2OnbNKAN4SQNPbTiXhC qHaEq/Z2QDmQN2Pq0wQx1IjPmqLTYcGploBQNvY4ogc3fItUA4mGyClW+CCujAqn32ke WJO4MFQNIwHLWla0C4n20iUn7mtuS0BZ9dIsoBoNnkNRgckBkYOdJVZHVHWkKmaGms9s kIXTWqBKPMBC9qlItrMqbjJ00ncyQUHEJnYGRUI+mU7Ms6BXDo+FKHAmaDjjBMkVcRfT VrGxGD5ccRge2Gl9fUvhVIE0CxOwCikcTqVVFKYFQrwM8/Tl1/OvDP7EWUHPHZJzQUgt NamQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vodxGcB9Pfq4inF2n1v2hS81nVigSig+J8tui1TzmuI=; b=zjTdPL/Y0KapYXXpbAZM7z4ufejMY3DyXd2KDRvpShF3qK2MigvJcGP5O7vKMJKBbg uizEM7TF+r3aNATT5GRbytYyBmonM4uTbyyqL3/1/xO9eV7X52px0RQwBnPCLnVBR4bb dh+eaMTH8Yl6EbBXrd2iC2KugM7aNlMklHIhnOhFOQtIpav67zQJtJ+NFsOQVKlV/O/n UAWYU1rSmH/7EKztl6yBDN+MYbRhjHkq7lnvRf0Cp+GX1PkhuKkatIVV88Yp2SMl+i/n 30Kgi2K8VnkCXappRsucd4/gWDvf/A7BVPuH0kj8HZ26dWL76qWJ3MgvinBLHF260Fm3 WKWg== X-Gm-Message-State: ACrzQf2qEYRCUBlU9nDINK+CYiTmiZXFHB0LU5A2wn5K9wMH+wq06AuG RSatiKER2gQbNTgaeR6Eq8E= X-Google-Smtp-Source: AMsMyM45YwFCqNKNFINuFl0RjlFgTYk/NqeZ8JkQG46HPl7XgbIr+zPAqYjZhFMoXjoE8DyFoJ9y5Q== X-Received: by 2002:a05:6512:54a:b0:4af:b4ac:c2bb with SMTP id h10-20020a056512054a00b004afb4acc2bbmr9042950lfl.650.1667398151683; Wed, 02 Nov 2022 07:09:11 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id bj12-20020a2eaa8c000000b0026e0434eb1esm119503ljb.67.2022.11.02.07.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 07:09:11 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH V4 1/2] staging: vt6655: change the function name s_vFillRTSHead Date: Wed, 2 Nov 2022 14:08:47 +0000 Message-Id: <5a0649c6019f1717cb2e2e8fc4e262f3747d73a5.1667397591.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the use of Hungarian notation, which is not used in the Linux kernel. Reported by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 31ae99b3cb35..c01fc1a593f3 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -23,7 +23,7 @@ * s_uGetTxRsvTime- get frame reserved time * s_vFillCTSHead- fulfill CTS ctl header * s_vFillFragParameter- Set fragment ctl parameter. - * s_vFillRTSHead- fulfill RTS ctl header + * fill_rts_header- fulfill RTS ctl header * s_vFillTxKey- fulfill tx encrypt key * s_vSWencryption- Software encrypt header * vDMA0_tx_80211- tx 802.11 frame via dma0 @@ -85,15 +85,15 @@ static const unsigned short fb_opt1[2][5] =3D { #define DATADUR_A_F1 13 =20 /*--------------------- Static Functions --------------------------*/ -static void s_vFillRTSHead(struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption); +static void fill_rts_head(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption); =20 static void s_vGenerateTxParameter(struct vnt_private *pDevice, unsigned char byPktType, @@ -912,7 +912,7 @@ s_vGenerateTxParameter( buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSi= ze, wCurrentRate, bNeedACK); buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrame= Size, pDevice->byTopCCKBasicRate, bNeedACK); =20 - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisC= RC, psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pvRrvTime; =20 @@ -931,7 +931,7 @@ s_vGenerateTxParameter( buf->rrv_time =3D vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize= , wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisC= RC, psEthHeader, wCurrentRate, byFBOption); } else if (!pvRTS) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 @@ -945,7 +945,7 @@ s_vGenerateTxParameter( buf->rrv_time =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSi= ze, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, psEthHeader, wCurrentRate, byFBOption); + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisC= RC, psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 --=20 2.34.1 From nobody Thu Apr 9 01:41:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC0C1C4332F for ; Wed, 2 Nov 2022 14:09:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbiKBOJ0 (ORCPT ); Wed, 2 Nov 2022 10:09:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231334AbiKBOJU (ORCPT ); Wed, 2 Nov 2022 10:09:20 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D829D11B for ; Wed, 2 Nov 2022 07:09:18 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id b2so28417678lfp.6 for ; Wed, 02 Nov 2022 07:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xGATexOV6vnPuB2p8dA7jNyMLlzx3cNJwqnDQnqy0Lw=; b=QWREUQ+MIJRrxRHUnzmPUZtlJTHGq5/FaclL+DWpDyQxxqT/i5uu7XBDF76Uu6ajEe mf70HZLIapmkvb4+0bHS/y5X4Kt5QNaT90iNT8cn28CK+wWYVDGLODeERdzPjDn6nH8B xUYbtJoJPPwm6imgVr85phnsbZZk3C8HA9iC4Nj7zscE/OmRpEpJanP2ikBDWsnw9hZs YEQt4G3pLPP444oE9TZgGXFi9iTY9WDNZryx2RPXh52I3SsiCVBOpRoLHitQyCK2DOon OtjJeEIAEk7eCAw3CVyFjTKe9Rm2NWBIbH0HI5ovY68pGGKOF9QZPBgikz9KAmh1lOum iDsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xGATexOV6vnPuB2p8dA7jNyMLlzx3cNJwqnDQnqy0Lw=; b=p0E8htpetoA9J3QWAZniezrUDMeuyYNNBEdRaztsIzFaE8VTerCI80yQ7xLal3jkNP zj7znMCj39x9jhFJm+cxj6/29eJSEZOfJvo4Ag6NTKPPK482yaDi4tWyNWZOMg60UZzM VuZIGjoLoeWCDgaW48W3A1ps9IMlbEf5KjvZqzS8s5nL+utcFLHDi/q1DkxgGHovNvcL 3HLa8G/2m2wyZ4u7Dj+v0Hl/P5Hljfl91Su1Zul0/cWcpqptaeWEyKO5UEGz4jQsm5fS G5R8P0MgrgBDQAruvwjpt0Th3wDSmafDFHkbKR7jp7KhWTXaEYgl+ifc2KxyEa9xn/Sd j2dA== X-Gm-Message-State: ACrzQf3r/X7irzg/30a7K+GLKgup4SRLZ/mHC+2K64KJDKzgZsqcHCJk SLhj8IPMZ/ChpvBYBJApGHI= X-Google-Smtp-Source: AMsMyM7xppK3b50AM2XFDO4L4Ca+NPGXo1QFwfnB5fOVrd6kV2dssjPBwKExCJZN7sIZMIelaoy6bQ== X-Received: by 2002:ac2:446b:0:b0:4a2:7e14:933d with SMTP id y11-20020ac2446b000000b004a27e14933dmr9134935lfl.338.1667398156338; Wed, 02 Nov 2022 07:09:16 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id bj12-20020a2eaa8c000000b0026e0434eb1esm119503ljb.67.2022.11.02.07.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 07:09:16 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH V4 2/2] staging: vt6655: Join some lines of code to avoid code lines ending in ( Date: Wed, 2 Nov 2022 14:08:48 +0000 Message-Id: <1026afe9c4c358b7b8a9fac62833ee62d2f4f9b5.1667397591.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix checkpatch error related to code line ends with a '(', by joining some lines and indenting correctly. This improves visibility Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 40 ++++++++++++++++------------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index c01fc1a593f3..debc5d5daede 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -85,15 +85,15 @@ static const unsigned short fb_opt1[2][5] =3D { #define DATADUR_A_F1 13 =20 /*--------------------- Static Functions --------------------------*/ -static void fill_rts_head(struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption); +static void fill_rts_header(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption); =20 static void s_vGenerateTxParameter(struct vnt_private *pDevice, unsigned char byPktType, @@ -555,19 +555,15 @@ s_uFillDataHead( return buf->duration; } =20 -static -void -s_vFillRTSHead( - struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption -) +static void fill_rts_header(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uRTSFrameLen =3D 20; =20 --=20 2.34.1