From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E25CECDFA1 for ; Tue, 25 Oct 2022 23:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232743AbiJYXhs (ORCPT ); Tue, 25 Oct 2022 19:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232740AbiJYXho (ORCPT ); Tue, 25 Oct 2022 19:37:44 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DD12FBCEF for ; Tue, 25 Oct 2022 16:37:43 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id g12so14793003lfh.3 for ; Tue, 25 Oct 2022 16:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IXPNjur9hX3brkcnEBIrqKBooU3Q3eUrz/4SzAXBpVA=; b=jzl5YR81A7lYG73Lf+1XMTb9CoEJEJPlwnkeCDFtkp+RHRHEdxQPxse1+hFdP8aiBg XzzMFi7VIzEJE6Xlc7+0pfm6HjDJkCW8qWW/cSrVWUrEyFdrFjpJxnqAOW/jmL931n38 jBpRezQxT80yh9/PQhFaxjJrkp1HIcwV2dvrqDHGSS/2mkCz05I/yKszlAxJkYNSQdCv kABXCygbrACSUxeIyKlhhfrdc+sxqiNzrCgsJAOT4uhfMM/kt6/WgCm4Bed8HmSNVibG UnlfhUSmv4rAo+BF83Kk6YlyQ0AZjjtC5smmxBiLxmFIkpLLBv724IKBCrTHOWkFRssQ 8W0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IXPNjur9hX3brkcnEBIrqKBooU3Q3eUrz/4SzAXBpVA=; b=jvV/XVR90Tn+fOd4LsuSUMULjU+Egrw4FRkK25/qRppiOSjLLrOlmw0kxO8kiQ3EaA o7tOa7xgJRuMB85ickCcf1cVTvdZoW9XNEGI1/8knJtWDfTsKUt5DNSYkOPJZQq90nPW iIgIGieKatKNCZ0aqM3pCHRP7qW10Vndnw0Gs+Lx/euyXIqE3TjukFvpSLDOnnCUD90T e799y5sqZ2IzHtLtwM0PjLOi+6Y/sRmBGOjSH1Cpv3Qyzn23zfUkUVm6N781PSoXSQPo ZBtzhTy5u7VNbSP8qbphCVwZYPGBZMifY+6GaWzRZmJFhYeAagEzjS7NZ5uT3OIvTmpu ZDAA== X-Gm-Message-State: ACrzQf2F4qpswNKXnKmOG9cA4DgDPAb9haroGdEGvm/ek1cCO/Pz5YU7 xntavLh3Yu3m0lUegSX0zz0= X-Google-Smtp-Source: AMsMyM7Pe031fV6dLsDcFE0Y71MlktJu3nQOGADKKYnctZQOfUBTA4Qf79fVkJ1h1EUx8GGiTuV08w== X-Received: by 2002:a05:6512:34d4:b0:4a4:20da:7538 with SMTP id w20-20020a05651234d400b004a420da7538mr16228447lfr.371.1666741061836; Tue, 25 Oct 2022 16:37:41 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:41 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 01/17] staging: vt6655: changed variable names: wFB_Opt0 Date: Tue, 25 Oct 2022 23:36:57 +0000 Message-Id: <62f69eddc9641ac9eb045edf8a9453bf36a02b36.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names wFB_Opt0 and wFB_Opt1 to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index d585435520b3..ac9b3402be4f 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -59,12 +59,12 @@ static const unsigned short wTimeStampOff[2][MAX_RATE] = =3D { {384, 192, 130, 113, 54, 43, 37, 31, 28, 25, 24, 23}, /* Short Preamble */ }; =20 -static const unsigned short wFB_Opt0[2][5] =3D { +static const unsigned short w_fb_opt_0[2][5] =3D { {RATE_12M, RATE_18M, RATE_24M, RATE_36M, RATE_48M}, /* fallback_rate0 */ {RATE_12M, RATE_12M, RATE_18M, RATE_24M, RATE_36M}, /* fallback_rate1 */ }; =20 -static const unsigned short wFB_Opt1[2][5] =3D { +static const unsigned short w_fb_opt_1[2][5] =3D { {RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */ {RATE_6M, RATE_6M, RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */ }; @@ -299,9 +299,9 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *pDevice, wRate -=3D RATE_18M; =20 if (byFBOption =3D=3D AUTO_FB_0) - wRate =3D wFB_Opt0[FB_RATE0][wRate]; + wRate =3D w_fb_opt_0[FB_RATE0][wRate]; else - wRate =3D wFB_Opt1[FB_RATE0][wRate]; + wRate =3D w_fb_opt_1[FB_RATE0][wRate]; =20 uNextPktTime =3D s_uGetTxRsvTime(pDevice, byPktType, len, wRate, bNeedAck); @@ -360,11 +360,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *pDevice, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt0[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt1[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; =20 @@ -374,11 +374,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *pDevice, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt0[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt1[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; =20 @@ -388,11 +388,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *pDevice, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt0[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt1[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; =20 @@ -402,11 +402,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *pDevice, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt0[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt1[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; =20 @@ -414,11 +414,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *pDevice, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt0[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt1[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; =20 @@ -426,11 +426,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *pDevice, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt0[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, - wFB_Opt1[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; =20 --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B168ECDFA1 for ; Tue, 25 Oct 2022 23:37:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232802AbiJYXhw (ORCPT ); Tue, 25 Oct 2022 19:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232773AbiJYXhq (ORCPT ); Tue, 25 Oct 2022 19:37:46 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 480DEFBCDC for ; Tue, 25 Oct 2022 16:37:45 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id d6so25280546lfs.10 for ; Tue, 25 Oct 2022 16:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zwmqc0ZHV1ejckQpOtC4ineulUJPlyh7/lvqbQKOwHg=; b=lohPY4YD0kSx0eh/wtGO/OHGpFqedZkzTscd30xAtFeZIwS1rVi6Vjxu+LvIYZiCFB X8aVTJ39+5VIPWDctbVxcXR6yvIGLrfK5SDDzt/D8bCvi2fKFI4W56TASurAY63Qyc+y Nu4QZpgNY2tHT+XjU8xguX7id6ZzweoJKDvMZjbLsCcLcmVqtC5XUvE2t9GRn+9xaKtI tueSOdKntKsbubliqd2DDc52BH2ZuIn+02TH65lh9ActVt6F2c2VjXCeEyQZshXBLMGe N44InlOYID129fOM/Rx4lTYboW1OkzHxCh2RlmH9ded2DttBa5Xr5ca5fT9no4zoSs2O Biug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zwmqc0ZHV1ejckQpOtC4ineulUJPlyh7/lvqbQKOwHg=; b=xgl04tUPGbE7f6qxheJskWv41Do1K/Y8I8w2nYGiCDOxYTBoD1u81P2xO8baHbcuVi MlTHwGNDwCKeHYVTnve8jUtZxAUJeHSg+wvWRMbLxBAHIGZKhmZ2gmLpC/kdD03U7YXd /E8aesheP9Ha/TjZXEhynTpsH1D5+COa8PwKaAuIdZtL/qy+IZYOklKuMOt+BXCzIVkO v+d/qT4pwHthotbmXSamBj+l+bHwN8gy8P48kAh4oB3r7p0Ra56CB4MYs2hBHNhc1PBU hfTxPBR3ykJeChvhebUmY4aO0H3mbbzi+bwmFeP9ZWv+O7a2ejjGmphQ0/VjMhITtMTh jjww== X-Gm-Message-State: ACrzQf3X2Bk7F52qMNDB1Fa20VJs7Uk5691s9r6M8Y18PTP01liD51R5 i8gBVHZWSkvNxJD7XjpJQTE= X-Google-Smtp-Source: AMsMyM68KtLT7ZZCJ60EUKqFsybR7kwuop+yBLXEThWQxQ5OP0iFicE8YUdnWrSOiL0yn1B4MASryA== X-Received: by 2002:ac2:58ca:0:b0:4a2:7bb1:ad61 with SMTP id u10-20020ac258ca000000b004a27bb1ad61mr15431669lfo.212.1666741063660; Tue, 25 Oct 2022 16:37:43 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:43 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 02/17] staging: vt6655: changed variable names: s_vFillRTSHead Date: Tue, 25 Oct 2022 23:36:58 +0000 Message-Id: <8afb904f9fb22a262b3563d5cfc5804863bfb5ea.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names s_vFillRTSHead and wTimeStampOff to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 54 +++++++++++++++++------------------ 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index ac9b3402be4f..8bb06b142748 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -23,7 +23,7 @@ * s_uGetTxRsvTime- get frame reserved time * s_vFillCTSHead- fulfill CTS ctl header * s_vFillFragParameter- Set fragment ctl parameter. - * s_vFillRTSHead- fulfill RTS ctl header + * s_v_fill_rts_head- fulfill RTS ctl header * s_vFillTxKey- fulfill tx encrypt key * s_vSWencryption- Software encrypt header * vDMA0_tx_80211- tx 802.11 frame via dma0 @@ -54,7 +54,7 @@ */ #define CRITICAL_PACKET_LEN 256 =20 -static const unsigned short wTimeStampOff[2][MAX_RATE] =3D { +static const unsigned short w_time_stamp_off[2][MAX_RATE] =3D { {384, 288, 226, 209, 54, 43, 37, 31, 28, 25, 24, 23}, /* Long Preamble */ {384, 192, 130, 113, 54, 43, 37, 31, 28, 25, 24, 23}, /* Short Preamble */ }; @@ -85,15 +85,15 @@ static const unsigned short w_fb_opt_1[2][5] =3D { #define DATADUR_A_F1 13 =20 /*--------------------- Static Functions --------------------------*/ -static void s_vFillRTSHead(struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption); +static void s_v_fill_rts_head(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption); =20 static void s_vGenerateTxParameter(struct vnt_private *pDevice, unsigned char byPktType, @@ -130,7 +130,7 @@ static __le16 s_uFillDataHead(struct vnt_private *pDevi= ce, =20 static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate) { - return cpu_to_le16(wTimeStampOff[priv->preamble_type % 2] + return cpu_to_le16(w_time_stamp_off[priv->preamble_type % 2] [rate % MAX_RATE]); } =20 @@ -620,15 +620,15 @@ static __le16 s_uFillDataHead(struct vnt_private *pDe= vice, return buf->duration; } =20 -static void s_vFillRTSHead(struct vnt_private *pDevice, - unsigned char byPktType, - void *pvRTS, - unsigned int cbFrameLength, - bool bNeedAck, - bool bDisCRC, - struct ieee80211_hdr *hdr, - unsigned short wCurrentRate, - unsigned char byFBOption) +static void s_v_fill_rts_head(struct vnt_private *pDevice, + unsigned char byPktType, + void *pvRTS, + unsigned int cbFrameLength, + bool bNeedAck, + bool bDisCRC, + struct ieee80211_hdr *hdr, + unsigned short wCurrentRate, + unsigned char byFBOption) { unsigned int uRTSFrameLen =3D 20; =20 @@ -977,8 +977,8 @@ static void s_vGenerateTxParameter(struct vnt_private *= pDevice, pDevice->byTopCCKBasicRate, bNeedACK); =20 - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, - psEthHeader, wCurrentRate, byFBOption); + s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDi= sCRC, + psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pvRrvTime; =20 @@ -1004,8 +1004,8 @@ static void s_vGenerateTxParameter(struct vnt_private= *pDevice, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, - psEthHeader, wCurrentRate, byFBOption); + s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDi= sCRC, + psEthHeader, wCurrentRate, byFBOption); } else if (!pvRTS) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 @@ -1022,8 +1022,8 @@ static void s_vGenerateTxParameter(struct vnt_private= *pDevice, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_vFillRTSHead(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCR= C, - psEthHeader, wCurrentRate, byFBOption); + s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDi= sCRC, + psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E2F4C38A2D for ; Tue, 25 Oct 2022 23:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232818AbiJYXhy (ORCPT ); Tue, 25 Oct 2022 19:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232787AbiJYXhu (ORCPT ); Tue, 25 Oct 2022 19:37:50 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DA80FBCE2 for ; Tue, 25 Oct 2022 16:37:47 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id j14so19404246ljh.12 for ; Tue, 25 Oct 2022 16:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y0LhEiNv/k5Hpq27rSC3zc2EE2gi/gZz8EVFap4u7Eg=; b=G1Sk9Va7pINmcPV06Ec2PWyBhCpSuw8RimaDz3KNGinY6HUjGMfGYLmcH/8ZCOshY7 0fdT55wEDFDjNDFpyDGDEbQhk5aj4dkZWZHBYcN6Hd7X6fvUF95TW+w9X1kZ4MG/Dq0d ux5xEeTQLpoNuM7Lax0gfxd/tA4YGz6T1x8qOUK0c4oW4SaYg2oOLk+wfFKT7GkREUV4 //+ysrSX6jRxpzUn1LYTTsXQ29O7Js+E7s/xrRxS8158yeuaHaM7vpYrxLRTtLJ6wzk3 fiiZIWcVRAa7x9Gucit5T0PKZ20rz56wbwpsLPPvEHxpp7p7t+PBw1vj3NT8S0Nxe3h3 xHFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y0LhEiNv/k5Hpq27rSC3zc2EE2gi/gZz8EVFap4u7Eg=; b=5kQTDSL56YBHTD8cFML0T3ptV9eqYmtELQN4RPqG+zh5w2E4TziRciS9yUBee1vAtG 36wai9ZDqKLxMj/cEzdvXvRNrelB/J/O68o5T9h7Aw3Q330w5UJ21+CXB95BJOqsKE0v XkFnt9lTgiVyNqDtsjy60K3mEy72KJK5S4vwk2rp4NzHPDLrtJV39rauTTN1TVmvyDzl WbNlqEjoVeAM6a1eoV9ThrrAIDIAHBAZBwUj9KCo5HpC2GkGnvYOu4d/3X4GTMyzWvZv ffNz2HJreZLvYQbnN7Eq+UFbFOijP89iO3ZPapvTRi4DkNw/phTEVZzjo8Lf3o3MKKzv Diow== X-Gm-Message-State: ACrzQf30yNxHadC/HfKMNLNBxWJaCM4dN5PecVJ5rQLYylrgf3pnaDsd T8IvAVehhAEyocboNaQPo3k= X-Google-Smtp-Source: AMsMyM4P3P32wMJWQOuKMQBH8qv5YS6tsvUmudTzHLRTPWJxXI5b+abToRDPZP0wCMaUJPHDzd1Mjg== X-Received: by 2002:a2e:92c4:0:b0:25d:9d30:5d61 with SMTP id k4-20020a2e92c4000000b0025d9d305d61mr16117924ljh.202.1666741065436; Tue, 25 Oct 2022 16:37:45 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:45 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 03/17] staging: vt6655: changed variable name: pDevice Date: Tue, 25 Oct 2022 23:36:59 +0000 Message-Id: <1f09760c8f6972b0e2b272060424b60a11166a0d.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names pDevice to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 354 +++++++++++++++++----------------- 1 file changed, 177 insertions(+), 177 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 8bb06b142748..3565f5608790 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -85,7 +85,7 @@ static const unsigned short w_fb_opt_1[2][5] =3D { #define DATADUR_A_F1 13 =20 /*--------------------- Static Functions --------------------------*/ -static void s_v_fill_rts_head(struct vnt_private *pDevice, +static void s_v_fill_rts_head(struct vnt_private *p_device, unsigned char byPktType, void *pvRTS, unsigned int cbFrameLength, @@ -95,7 +95,7 @@ static void s_v_fill_rts_head(struct vnt_private *pDevice, unsigned short wCurrentRate, unsigned char byFBOption); =20 -static void s_vGenerateTxParameter(struct vnt_private *pDevice, +static void s_vGenerateTxParameter(struct vnt_private *p_device, unsigned char byPktType, struct vnt_tx_fifo_head *, void *pvRrvTime, @@ -108,12 +108,12 @@ static void s_vGenerateTxParameter(struct vnt_private= *pDevice, unsigned short wCurrentRate); =20 static unsigned int -s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, +s_cbFillTxBufHead(struct vnt_private *p_device, unsigned char byPktType, unsigned char *pbyTxBufferAddr, unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, unsigned int uNodeIndex); =20 -static __le16 s_uFillDataHead(struct vnt_private *pDevice, +static __le16 s_uFillDataHead(struct vnt_private *p_device, unsigned char byPktType, void *pTxDataHead, unsigned int cbFrameLength, @@ -139,7 +139,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private *pr= iv, u16 rate) * PK_TYPE_11GB 2 * PK_TYPE_11GA 3 */ -static unsigned int s_uGetTxRsvTime(struct vnt_private *pDevice, +static unsigned int s_uGetTxRsvTime(struct vnt_private *p_device, unsigned char byPktType, unsigned int cbFrameLength, unsigned short wRate, @@ -147,7 +147,7 @@ static unsigned int s_uGetTxRsvTime(struct vnt_private = *pDevice, { unsigned int uDataTime, uAckTime; =20 - uDataTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, cbFram= eLength, wRate); + uDataTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, cbFra= meLength, wRate); =20 if (!bNeedAck) return uDataTime; @@ -156,12 +156,12 @@ static unsigned int s_uGetTxRsvTime(struct vnt_privat= e *pDevice, * CCK mode - 11b * OFDM mode - 11g 2.4G & 11a 5G */ - uAckTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, 14, + uAckTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, byPktType =3D=3D PK_TYPE_11B ? - pDevice->byTopCCKBasicRate : - pDevice->byTopOFDMBasicRate); + p_device->byTopCCKBasicRate : + p_device->byTopOFDMBasicRate); =20 - return uDataTime + pDevice->uSIFS + uAckTime; + return uDataTime + p_device->uSIFS + uAckTime; } =20 static __le16 vnt_rxtx_rsvtime_le16(struct vnt_private *priv, u8 pkt_type, @@ -219,7 +219,7 @@ static __le16 get_rtscts_time(struct vnt_private *priv, } =20 /* byFreqType 0: 5GHz, 1:2.4Ghz */ -static unsigned int s_uGetDataDuration(struct vnt_private *pDevice, +static unsigned int s_uGetDataDuration(struct vnt_private *p_device, unsigned char byDurType, unsigned int cbFrameLength, unsigned char byPktType, @@ -244,9 +244,9 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *pDevice, switch (byDurType) { case DATADUR_B: /* DATADUR_B */ if (bNeedAck) { - uAckTime =3D bb_get_frame_time(pDevice->preamble_type, + uAckTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, - pDevice->byTopCCKBasicRate); + p_device->byTopCCKBasicRate); } /* Non Frag or Last Frag */ if ((uMACfragNum =3D=3D 1) || bLastFrag) { @@ -254,17 +254,17 @@ static unsigned int s_uGetDataDuration(struct vnt_pri= vate *pDevice, return 0; } else { /* First Frag or Mid Frag */ - uNextPktTime =3D s_uGetTxRsvTime(pDevice, byPktType, + uNextPktTime =3D s_uGetTxRsvTime(p_device, byPktType, len, wRate, bNeedAck); } =20 - return pDevice->uSIFS + uAckTime + uNextPktTime; + return p_device->uSIFS + uAckTime + uNextPktTime; =20 case DATADUR_A: /* DATADUR_A */ if (bNeedAck) { - uAckTime =3D bb_get_frame_time(pDevice->preamble_type, + uAckTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, - pDevice->byTopOFDMBasicRate); + p_device->byTopOFDMBasicRate); } /* Non Frag or Last Frag */ if ((uMACfragNum =3D=3D 1) || bLastFrag) { @@ -272,18 +272,18 @@ static unsigned int s_uGetDataDuration(struct vnt_pri= vate *pDevice, return 0; } else { /* First Frag or Mid Frag */ - uNextPktTime =3D s_uGetTxRsvTime(pDevice, byPktType, + uNextPktTime =3D s_uGetTxRsvTime(p_device, byPktType, len, wRate, bNeedAck); } =20 - return pDevice->uSIFS + uAckTime + uNextPktTime; + return p_device->uSIFS + uAckTime + uNextPktTime; =20 case DATADUR_A_F0: /* DATADUR_A_F0 */ case DATADUR_A_F1: /* DATADUR_A_F1 */ if (bNeedAck) { - uAckTime =3D bb_get_frame_time(pDevice->preamble_type, + uAckTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, - pDevice->byTopOFDMBasicRate); + p_device->byTopOFDMBasicRate); } /* Non Frag or Last Frag */ if ((uMACfragNum =3D=3D 1) || bLastFrag) { @@ -303,11 +303,11 @@ static unsigned int s_uGetDataDuration(struct vnt_pri= vate *pDevice, else wRate =3D w_fb_opt_1[FB_RATE0][wRate]; =20 - uNextPktTime =3D s_uGetTxRsvTime(pDevice, byPktType, + uNextPktTime =3D s_uGetTxRsvTime(p_device, byPktType, len, wRate, bNeedAck); } =20 - return pDevice->uSIFS + uAckTime + uNextPktTime; + return p_device->uSIFS + uAckTime + uNextPktTime; =20 default: break; @@ -317,7 +317,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *pDevice, } =20 /* byFreqType: 0=3D>5GHZ 1=3D>2.4GHZ */ -static __le16 s_uGetRTSCTSDuration(struct vnt_private *pDevice, +static __le16 s_uGetRTSCTSDuration(struct vnt_private *p_device, unsigned char byDurType, unsigned int cbFrameLength, unsigned char byPktType, @@ -329,107 +329,107 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_priva= te *pDevice, =20 switch (byDurType) { case RTSDUR_BB: /* RTSDuration_bb */ - uCTSTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, 14, - pDevice->byTopCCKBasicRate); - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wRate, bNeedAck); + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + p_device->byTopCCKBasicRate); + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, wRate, bNeedAck); break; =20 case RTSDUR_BA: /* RTSDuration_ba */ - uCTSTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, 14, - pDevice->byTopCCKBasicRate); - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wRate, bNeedAck); + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + p_device->byTopCCKBasicRate); + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, wRate, bNeedAck); break; =20 case RTSDUR_AA: /* RTSDuration_aa */ - uCTSTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, 14, - pDevice->byTopOFDMBasicRate); - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, wRate, bNeedAck); + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + p_device->byTopOFDMBasicRate); + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, wRate, bNeedAck); break; =20 case CTSDUR_BA: /* CTSDuration_ba */ - uDurTime =3D pDevice->uSIFS + s_uGetTxRsvTime(pDevice, byPktType, + uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, wRate, bNeedAck); break; =20 case RTSDUR_BA_F0: /* RTSDuration_ba_f0 */ - uCTSTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, 14, - pDevice->byTopCCKBasicRate); + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + p_device->byTopCCKBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; =20 case RTSDUR_AA_F0: /* RTSDuration_aa_f0 */ - uCTSTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, 14, - pDevice->byTopOFDMBasicRate); + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + p_device->byTopOFDMBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; =20 case RTSDUR_BA_F1: /* RTSDuration_ba_f1 */ - uCTSTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, 14, - pDevice->byTopCCKBasicRate); + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + p_device->byTopCCKBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; =20 case RTSDUR_AA_F1: /* RTSDuration_aa_f1 */ - uCTSTime =3D bb_get_frame_time(pDevice->preamble_type, byPktType, 14, - pDevice->byTopOFDMBasicRate); + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + p_device->byTopOFDMBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) - uDurTime =3D uCTSTime + 2 * pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D uCTSTime + 2 * p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; =20 case CTSDUR_BA_F0: /* CTSDuration_ba_f0 */ if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) - uDurTime =3D pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) - uDurTime =3D pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; =20 case CTSDUR_BA_F1: /* CTSDuration_ba_f1 */ if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) - uDurTime =3D pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) - uDurTime =3D pDevice->uSIFS + - s_uGetTxRsvTime(pDevice, byPktType, cbFrameLength, + uDurTime =3D p_device->uSIFS + + s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; @@ -441,7 +441,7 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private *= pDevice, return cpu_to_le16((u16)uDurTime); } =20 -static __le16 s_uFillDataHead(struct vnt_private *pDevice, +static __le16 s_uFillDataHead(struct vnt_private *p_device, unsigned char byPktType, void *pTxDataHead, unsigned int cbFrameLength, @@ -466,22 +466,22 @@ static __le16 s_uFillDataHead(struct vnt_private *pDe= vice, if (byFBOption =3D=3D AUTO_FB_NONE) { struct vnt_tx_datahead_g *buf =3D pTxDataHead; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, byPktType, &buf->a); =20 - vnt_get_phy_field(pDevice, cbFrameLength, - pDevice->byTopCCKBasicRate, + vnt_get_phy_field(p_device, cbFrameLength, + p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); =20 if (is_pspoll) { - __le16 dur =3D cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15)); + __le16 dur =3D cpu_to_le16(p_device->current_aid | BIT(14) | BIT(15)); =20 buf->duration_a =3D dur; buf->duration_b =3D dur; } else { /* Get Duration and TimeStamp */ buf->duration_a =3D - cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A, + cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, cbFrameLength, byPktType, wCurrentRate, bNeedAck, @@ -490,57 +490,57 @@ static __le16 s_uFillDataHead(struct vnt_private *pDe= vice, uMACfragNum, byFBOption)); buf->duration_b =3D - cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_B, + cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, cbFrameLength, PK_TYPE_11B, - pDevice->byTopCCKBasicRate, + p_device->byTopCCKBasicRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); } =20 - buf->time_stamp_off_a =3D vnt_time_stamp_off(pDevice, wCurrentRate); - buf->time_stamp_off_b =3D vnt_time_stamp_off(pDevice, - pDevice->byTopCCKBasicRate); + buf->time_stamp_off_a =3D vnt_time_stamp_off(p_device, wCurrentRate); + buf->time_stamp_off_b =3D vnt_time_stamp_off(p_device, + p_device->byTopCCKBasicRate); =20 return buf->duration_a; } =20 /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, byPktType, &buf->a); =20 - vnt_get_phy_field(pDevice, cbFrameLength, - pDevice->byTopCCKBasicRate, + vnt_get_phy_field(p_device, cbFrameLength, + p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); /* Get Duration and TimeStamp */ - buf->duration_a =3D cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR= _A, + buf->duration_a =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADU= R_A, cbFrameLength, byPktType, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); - buf->duration_b =3D cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR= _B, + buf->duration_b =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADU= R_B, cbFrameLength, PK_TYPE_11B, - pDevice->byTopCCKBasicRate, + p_device->byTopCCKBasicRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); - buf->duration_a_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATA= DUR_A_F0, + buf->duration_a_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F0, cbFrameLength, byPktType, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); - buf->duration_a_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATA= DUR_A_F1, + buf->duration_a_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F1, cbFrameLength, byPktType, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); =20 - buf->time_stamp_off_a =3D vnt_time_stamp_off(pDevice, wCurrentRate); - buf->time_stamp_off_b =3D vnt_time_stamp_off(pDevice, pDevice->byTopCCKB= asicRate); + buf->time_stamp_off_a =3D vnt_time_stamp_off(p_device, wCurrentRate); + buf->time_stamp_off_b =3D vnt_time_stamp_off(p_device, p_device->byTopCC= KBasicRate); =20 return buf->duration_a; /* if (byFBOption =3D=3D AUTO_FB_NONE) */ @@ -551,76 +551,76 @@ static __le16 s_uFillDataHead(struct vnt_private *pDe= vice, /* Auto Fallback */ struct vnt_tx_datahead_a_fb *buf =3D pTxDataHead; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, byPktType, &buf->a); =20 /* Get Duration and TimeStampOff */ buf->duration =3D - cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A, + cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, cbFrameLength, byPktType, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_f0 =3D - cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A_F0, + cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F0, cbFrameLength, byPktType, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_f1 =3D - cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A_F1, + cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F1, cbFrameLength, byPktType, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); - buf->time_stamp_off =3D vnt_time_stamp_off(pDevice, wCurrentRate); + buf->time_stamp_off =3D vnt_time_stamp_off(p_device, wCurrentRate); return buf->duration; } =20 /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, byPktType, &buf->ab); =20 if (is_pspoll) { - __le16 dur =3D cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15)); + __le16 dur =3D cpu_to_le16(p_device->current_aid | BIT(14) | BIT(15)); =20 buf->duration =3D dur; } else { /* Get Duration and TimeStampOff */ buf->duration =3D - cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A, + cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, cbFrameLength, byPktType, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); } =20 - buf->time_stamp_off =3D vnt_time_stamp_off(pDevice, wCurrentRate); + buf->time_stamp_off =3D vnt_time_stamp_off(p_device, wCurrentRate); return buf->duration; } =20 /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, byPktType, &buf->ab); =20 if (is_pspoll) { - __le16 dur =3D cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15)); + __le16 dur =3D cpu_to_le16(p_device->current_aid | BIT(14) | BIT(15)); =20 buf->duration =3D dur; } else { /* Get Duration and TimeStampOff */ buf->duration =3D - cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_B, cbFrameLength, + cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, cbFrameLength, byPktType, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); } =20 - buf->time_stamp_off =3D vnt_time_stamp_off(pDevice, wCurrentRate); + buf->time_stamp_off =3D vnt_time_stamp_off(p_device, wCurrentRate); return buf->duration; } =20 -static void s_v_fill_rts_head(struct vnt_private *pDevice, +static void s_v_fill_rts_head(struct vnt_private *p_device, unsigned char byPktType, void *pvRTS, unsigned int cbFrameLength, @@ -650,26 +650,26 @@ static void s_v_fill_rts_head(struct vnt_private *pDe= vice, if (byFBOption =3D=3D AUTO_FB_NONE) { struct vnt_rts_g *buf =3D pvRTS; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, uRTSFrameLen, - pDevice->byTopCCKBasicRate, + vnt_get_phy_field(p_device, uRTSFrameLen, + p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); =20 - vnt_get_phy_field(pDevice, uRTSFrameLen, - pDevice->byTopOFDMBasicRate, + vnt_get_phy_field(p_device, uRTSFrameLen, + p_device->byTopOFDMBasicRate, byPktType, &buf->a); /* Get Duration */ buf->duration_bb =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_BB, + s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cbFrameLength, PK_TYPE_11B, - pDevice->byTopCCKBasicRate, + p_device->byTopCCKBasicRate, bNeedAck, byFBOption); buf->duration_aa =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_AA, + s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); buf->duration_ba =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_BA, + s_uGetRTSCTSDuration(p_device, RTSDUR_BA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); @@ -685,46 +685,46 @@ static void s_v_fill_rts_head(struct vnt_private *pDe= vice, } else { struct vnt_rts_g_fb *buf =3D pvRTS; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, uRTSFrameLen, - pDevice->byTopCCKBasicRate, + vnt_get_phy_field(p_device, uRTSFrameLen, + p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); =20 - vnt_get_phy_field(pDevice, uRTSFrameLen, - pDevice->byTopOFDMBasicRate, + vnt_get_phy_field(p_device, uRTSFrameLen, + p_device->byTopOFDMBasicRate, byPktType, &buf->a); /* Get Duration */ buf->duration_bb =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_BB, + s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cbFrameLength, PK_TYPE_11B, - pDevice->byTopCCKBasicRate, + p_device->byTopCCKBasicRate, bNeedAck, byFBOption); buf->duration_aa =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_AA, + s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); buf->duration_ba =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_BA, + s_uGetRTSCTSDuration(p_device, RTSDUR_BA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_ba_f0 =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_BA_F0, + s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F0, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_aa_f0 =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_AA_F0, + s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_ba_f1 =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_BA_F1, + s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F1, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_aa_f1 =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_AA_F1, + s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); @@ -741,12 +741,12 @@ static void s_v_fill_rts_head(struct vnt_private *pDe= vice, if (byFBOption =3D=3D AUTO_FB_NONE) { struct vnt_rts_ab *buf =3D pvRTS; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, uRTSFrameLen, - pDevice->byTopOFDMBasicRate, + vnt_get_phy_field(p_device, uRTSFrameLen, + p_device->byTopOFDMBasicRate, byPktType, &buf->ab); /* Get Duration */ buf->duration =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_AA, + s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); @@ -761,22 +761,22 @@ static void s_v_fill_rts_head(struct vnt_private *pDe= vice, } else { struct vnt_rts_a_fb *buf =3D pvRTS; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, uRTSFrameLen, - pDevice->byTopOFDMBasicRate, + vnt_get_phy_field(p_device, uRTSFrameLen, + p_device->byTopOFDMBasicRate, byPktType, &buf->a); /* Get Duration */ buf->duration =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_AA, + s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_f0 =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_AA_F0, + s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_f1 =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_AA_F1, + s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); @@ -792,12 +792,12 @@ static void s_v_fill_rts_head(struct vnt_private *pDe= vice, } else if (byPktType =3D=3D PK_TYPE_11B) { struct vnt_rts_ab *buf =3D pvRTS; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, uRTSFrameLen, - pDevice->byTopCCKBasicRate, + vnt_get_phy_field(p_device, uRTSFrameLen, + p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->ab); /* Get Duration */ buf->duration =3D - s_uGetRTSCTSDuration(pDevice, RTSDUR_BB, cbFrameLength, + s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); =20 @@ -811,7 +811,7 @@ static void s_v_fill_rts_head(struct vnt_private *pDevi= ce, } } =20 -static void s_vFillCTSHead(struct vnt_private *pDevice, +static void s_vFillCTSHead(struct vnt_private *p_device, unsigned int uDMAIdx, unsigned char byPktType, void *pvCTS, @@ -840,26 +840,26 @@ static void s_vFillCTSHead(struct vnt_private *pDevic= e, /* Auto Fall back */ struct vnt_cts_fb *buf =3D pvCTS; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, uCTSFrameLen, - pDevice->byTopCCKBasicRate, + vnt_get_phy_field(p_device, uCTSFrameLen, + p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); =20 buf->duration_ba =3D - s_uGetRTSCTSDuration(pDevice, CTSDUR_BA, + s_uGetRTSCTSDuration(p_device, CTSDUR_BA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); =20 /* Get CTSDuration_ba_f0 */ buf->cts_duration_ba_f0 =3D - s_uGetRTSCTSDuration(pDevice, CTSDUR_BA_F0, + s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F0, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); =20 /* Get CTSDuration_ba_f1 */ buf->cts_duration_ba_f1 =3D - s_uGetRTSCTSDuration(pDevice, CTSDUR_BA_F1, + s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F1, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); @@ -874,7 +874,7 @@ static void s_vFillCTSHead(struct vnt_private *pDevice, buf->reserved2 =3D 0x0; =20 ether_addr_copy(buf->data.ra, - pDevice->abyCurrentNetAddr); + p_device->abyCurrentNetAddr); } else { /* if (byFBOption !=3D AUTO_FB_NONE && * uDMAIdx !=3D TYPE_ATIMDMA && @@ -882,13 +882,13 @@ static void s_vFillCTSHead(struct vnt_private *pDevic= e, */ struct vnt_cts *buf =3D pvCTS; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(pDevice, uCTSFrameLen, - pDevice->byTopCCKBasicRate, + vnt_get_phy_field(p_device, uCTSFrameLen, + p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); =20 /* Get CTSDuration_ba */ buf->duration_ba =3D - s_uGetRTSCTSDuration(pDevice, CTSDUR_BA, + s_uGetRTSCTSDuration(p_device, CTSDUR_BA, cbFrameLength, byPktType, wCurrentRate, bNeedAck, byFBOption); @@ -902,7 +902,7 @@ static void s_vFillCTSHead(struct vnt_private *pDevice, =20 buf->reserved2 =3D 0x0; ether_addr_copy(buf->data.ra, - pDevice->abyCurrentNetAddr); + p_device->abyCurrentNetAddr); } } } @@ -914,7 +914,7 @@ static void s_vFillCTSHead(struct vnt_private *pDevice, * * Parameters: * In: - * pDevice - Pointer to adapter + * p_device - Pointer to adapter * pTxDataHead - Transmit Data Buffer * pTxBufHead - pTxBufHead * pvRrvTime - pvRrvTime @@ -931,7 +931,7 @@ static void s_vFillCTSHead(struct vnt_private *pDevice, - * unsigned int cbFrameSize, Hdr+Payload+FCS */ -static void s_vGenerateTxParameter(struct vnt_private *pDevice, +static void s_vGenerateTxParameter(struct vnt_private *p_device, unsigned char byPktType, struct vnt_tx_fifo_head *tx_buffer_head, void *pvRrvTime, @@ -965,75 +965,75 @@ static void s_vGenerateTxParameter(struct vnt_private= *pDevice, /* Fill RsvTime */ struct vnt_rrv_time_rts *buf =3D pvRrvTime; =20 - buf->rts_rrv_time_aa =3D get_rtscts_time(pDevice, 2, byPktType, cbFrame= Size, + buf->rts_rrv_time_aa =3D get_rtscts_time(p_device, 2, byPktType, cbFram= eSize, wCurrentRate); - buf->rts_rrv_time_ba =3D get_rtscts_time(pDevice, 1, byPktType, cbFrame= Size, + buf->rts_rrv_time_ba =3D get_rtscts_time(p_device, 1, byPktType, cbFram= eSize, wCurrentRate); - buf->rts_rrv_time_bb =3D get_rtscts_time(pDevice, 0, byPktType, cbFrame= Size, + buf->rts_rrv_time_bb =3D get_rtscts_time(p_device, 0, byPktType, cbFram= eSize, wCurrentRate); - buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSi= ze, + buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, byPktType, cbFrameS= ize, wCurrentRate, bNeedACK); - buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrame= Size, - pDevice->byTopCCKBasicRate, + buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFram= eSize, + p_device->byTopCCKBasicRate, bNeedACK); =20 - s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDi= sCRC, - psEthHeader, wCurrentRate, byFBOption); + s_v_fill_rts_head(p_device, byPktType, pvRTS, cbFrameSize, bNeedACK, + bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pvRrvTime; =20 - buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSi= ze, + buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, byPktType, cbFrameS= ize, wCurrentRate, bNeedACK); - buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrame= Size, - pDevice->byTopCCKBasicRate, + buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFram= eSize, + p_device->byTopCCKBasicRate, bNeedACK); - buf->cts_rrv_time_ba =3D get_rtscts_time(pDevice, 3, byPktType, cbFrame= Size, + buf->cts_rrv_time_ba =3D get_rtscts_time(p_device, 3, byPktType, cbFram= eSize, wCurrentRate); =20 /* Fill CTS */ - s_vFillCTSHead(pDevice, uDMAIdx, byPktType, pvCTS, cbFrameSize, bNeedAC= K, + s_vFillCTSHead(p_device, uDMAIdx, byPktType, pvCTS, cbFrameSize, bNeedA= CK, bDisCRC, wCurrentRate, byFBOption); } } else if (byPktType =3D=3D PK_TYPE_11A) { if (pvRTS) {/* RTS_need, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 - buf->rts_rrv_time =3D get_rtscts_time(pDevice, 2, byPktType, cbFrameSiz= e, + buf->rts_rrv_time =3D get_rtscts_time(p_device, 2, byPktType, cbFrameSi= ze, wCurrentRate); - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(pDevice, byPktType, cbFrameSize, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, byPktType, cbFrameSiz= e, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDi= sCRC, - psEthHeader, wCurrentRate, byFBOption); + s_v_fill_rts_head(p_device, byPktType, pvRTS, cbFrameSize, bNeedACK, + bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else if (!pvRTS) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11A, cbFrameSi= ze, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11A, cbFrameS= ize, wCurrentRate, bNeedACK); } } else if (byPktType =3D=3D PK_TYPE_11B) { if (pvRTS) {/* RTS_need, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 - buf->rts_rrv_time =3D get_rtscts_time(pDevice, 0, byPktType, cbFrameSiz= e, + buf->rts_rrv_time =3D get_rtscts_time(p_device, 0, byPktType, cbFrameSi= ze, wCurrentRate); - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSi= ze, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFrameS= ize, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_v_fill_rts_head(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDi= sCRC, - psEthHeader, wCurrentRate, byFBOption); + s_v_fill_rts_head(p_device, byPktType, pvRTS, cbFrameSize, bNeedACK, + bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11B, cbFrameSi= ze, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFrameS= ize, wCurrentRate, bNeedACK); } } } =20 -static unsigned int s_cbFillTxBufHead(struct vnt_private *pDevice, +static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device, unsigned char byPktType, unsigned char *pbyTxBufferAddr, unsigned int uDMAIdx, @@ -1080,7 +1080,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *pDevice, =20 cbFrameSize +=3D info->control.hw_key->icv_len; =20 - if (pDevice->local_id > REV_ID_VT3253_A1) { + if (p_device->local_id > REV_ID_VT3253_A1) { /* MAC Header should be padding 0 to DW alignment. */ uPadding =3D 4 - (ieee80211_get_hdrlen_from_skb(skb) % 4); uPadding %=3D 4; @@ -1218,11 +1218,11 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *pDevice, memset((void *)(pbyTxBufferAddr + wTxBufSize), 0, (cbHeaderLength - wTxBu= fSize)); =20 /* Fill FIFO,RrvTime,RTS,and CTS */ - s_vGenerateTxParameter(pDevice, byPktType, tx_buffer_head, pvRrvTime, pvR= TS, pvCTS, - cbFrameSize, bNeedACK, uDMAIdx, hdr, pDevice->wCurrentRate); + s_vGenerateTxParameter(p_device, byPktType, tx_buffer_head, pvRrvTime, pv= RTS, pvCTS, + cbFrameSize, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); /* Fill DataHead */ - uDuration =3D s_uFillDataHead(pDevice, byPktType, pvTxDataHd, cbFrameSize= , uDMAIdx, bNeedACK, - 0, 0, uMACfragNum, byFBOption, pDevice->wCurrentRate, + uDuration =3D s_uFillDataHead(p_device, byPktType, pvTxDataHd, cbFrameSiz= e, uDMAIdx, bNeedACK, + 0, 0, uMACfragNum, byFBOption, p_device->wCurrentRate, is_pspoll); =20 hdr->duration_id =3D uDuration; --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65635ECDFA1 for ; Tue, 25 Oct 2022 23:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232865AbiJYXiC (ORCPT ); Tue, 25 Oct 2022 19:38:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232799AbiJYXhv (ORCPT ); Tue, 25 Oct 2022 19:37:51 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9D31FB726 for ; Tue, 25 Oct 2022 16:37:48 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id b1so25301226lfs.7 for ; Tue, 25 Oct 2022 16:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lvzDdjgKAe+oes/kVBvMNsXTWZdcaXY0ZRcD0jQY8yg=; b=fwDJ67ST9phJ0pIN6h32/XH28ITv4wBSvmFIhh0/Taru1JR1IOMseZr6BUxyXiCQ3h RwGlBox7+c5CX7u+WaW1P1qF+8vNq1cicgHbplrZk82my8PF67KiRkDwwSRq1lIql2U6 TgbzV1CS0ESIx5ecgDtMrdJSxvV0IK+oRCvxLpMRfy3czhUivYFJDNHyjhA4evezp1T8 Fmdo3dUiXSPZE9FGyAIxUqYWLoo1ulQO7RyXIOPw+icvlLL6WNOzsy/xyHHjbgfEnLLO LlBhJvLLbg62YPESgVS7zrH8JKxBXmA0Ol6eNoL+jmL5SkEBYMP3EGc92DaxjNfPZKo7 02rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lvzDdjgKAe+oes/kVBvMNsXTWZdcaXY0ZRcD0jQY8yg=; b=rf+0lYjAM5sgcxz4HsrC8eefrNrG3oc/NHeU1U+J//LC/z+SjsamdJ7yTKidq4bYr7 2fGMPgpWh8/i18TT1N6YF1o9bNt2VyPwyaBheRv+w3fek0ykGVCizSu9xg0Yu1UGC6ba tiTlMEkT7bx98o/30W+lavEVGUeaQmH+S1eGXlH+t+Yc2x3Y+x6zvbHOzJ9n4Y3UInC3 BQoaziJt9WttZQmakSl53IHEnxHb0UU6eNnpXp4ukBU1yHHVfwEnsKyv9Pa8aF+RKPsi lSHBQVPLAJ7Oh4IcbN2voUN16KPLjfk7qgngm3jkFMAmVnLJifbqk91zmcM/OMVm3gbp IHnQ== X-Gm-Message-State: ACrzQf3+KyozJ6uMvj0X6hbc5oxu7197e0RqRKzrIZtqskvJwgQOhztZ eKj4kIMQzGAj+JyidtYIVi4= X-Google-Smtp-Source: AMsMyM7RE+Rj0Up1g0yO21JUDQGmnpJDHAbWaEDa5n+77EmbpR9eKVrKxQPSI4I5bONLiwy8H5ciCQ== X-Received: by 2002:ac2:5f51:0:b0:4a4:5e1f:fce1 with SMTP id 17-20020ac25f51000000b004a45e1ffce1mr16121943lfz.130.1666741067149; Tue, 25 Oct 2022 16:37:47 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:46 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 04/17] staging: vt6655: changed variable name: byPktType Date: Tue, 25 Oct 2022 23:37:00 +0000 Message-Id: <7b7d78fcab2941fc5af1220c627d4b77afe03ab0.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names byPktType to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 222 +++++++++++++++++----------------- 1 file changed, 111 insertions(+), 111 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 3565f5608790..2cac8f3882df 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -86,7 +86,7 @@ static const unsigned short w_fb_opt_1[2][5] =3D { =20 /*--------------------- Static Functions --------------------------*/ static void s_v_fill_rts_head(struct vnt_private *p_device, - unsigned char byPktType, + unsigned char by_pkt_type, void *pvRTS, unsigned int cbFrameLength, bool bNeedAck, @@ -96,7 +96,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_devic= e, unsigned char byFBOption); =20 static void s_vGenerateTxParameter(struct vnt_private *p_device, - unsigned char byPktType, + unsigned char by_pkt_type, struct vnt_tx_fifo_head *, void *pvRrvTime, void *pvRTS, @@ -108,13 +108,13 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, unsigned short wCurrentRate); =20 static unsigned int -s_cbFillTxBufHead(struct vnt_private *p_device, unsigned char byPktType, +s_cbFillTxBufHead(struct vnt_private *p_device, unsigned char by_pkt_type, unsigned char *pbyTxBufferAddr, unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, unsigned int uNodeIndex); =20 static __le16 s_uFillDataHead(struct vnt_private *p_device, - unsigned char byPktType, + unsigned char by_pkt_type, void *pTxDataHead, unsigned int cbFrameLength, unsigned int uDMAIdx, @@ -134,20 +134,20 @@ static __le16 vnt_time_stamp_off(struct vnt_private *= priv, u16 rate) [rate % MAX_RATE]); } =20 -/* byPktType : PK_TYPE_11A 0 +/* by_pkt_type : PK_TYPE_11A 0 * PK_TYPE_11B 1 * PK_TYPE_11GB 2 * PK_TYPE_11GA 3 */ static unsigned int s_uGetTxRsvTime(struct vnt_private *p_device, - unsigned char byPktType, + unsigned char by_pkt_type, unsigned int cbFrameLength, unsigned short wRate, bool bNeedAck) { unsigned int uDataTime, uAckTime; =20 - uDataTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, cbFra= meLength, wRate); + uDataTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, cbF= rameLength, wRate); =20 if (!bNeedAck) return uDataTime; @@ -156,8 +156,8 @@ static unsigned int s_uGetTxRsvTime(struct vnt_private = *p_device, * CCK mode - 11b * OFDM mode - 11g 2.4G & 11a 5G */ - uAckTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, - byPktType =3D=3D PK_TYPE_11B ? + uAckTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, + by_pkt_type =3D=3D PK_TYPE_11B ? p_device->byTopCCKBasicRate : p_device->byTopOFDMBasicRate); =20 @@ -222,7 +222,7 @@ static __le16 get_rtscts_time(struct vnt_private *priv, static unsigned int s_uGetDataDuration(struct vnt_private *p_device, unsigned char byDurType, unsigned int cbFrameLength, - unsigned char byPktType, + unsigned char by_pkt_type, unsigned short wRate, bool bNeedAck, unsigned int uFragIdx, @@ -245,7 +245,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, case DATADUR_B: /* DATADUR_B */ if (bNeedAck) { uAckTime =3D bb_get_frame_time(p_device->preamble_type, - byPktType, 14, + by_pkt_type, 14, p_device->byTopCCKBasicRate); } /* Non Frag or Last Frag */ @@ -254,7 +254,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, return 0; } else { /* First Frag or Mid Frag */ - uNextPktTime =3D s_uGetTxRsvTime(p_device, byPktType, + uNextPktTime =3D s_uGetTxRsvTime(p_device, by_pkt_type, len, wRate, bNeedAck); } =20 @@ -263,7 +263,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, case DATADUR_A: /* DATADUR_A */ if (bNeedAck) { uAckTime =3D bb_get_frame_time(p_device->preamble_type, - byPktType, 14, + by_pkt_type, 14, p_device->byTopOFDMBasicRate); } /* Non Frag or Last Frag */ @@ -272,7 +272,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, return 0; } else { /* First Frag or Mid Frag */ - uNextPktTime =3D s_uGetTxRsvTime(p_device, byPktType, + uNextPktTime =3D s_uGetTxRsvTime(p_device, by_pkt_type, len, wRate, bNeedAck); } =20 @@ -282,7 +282,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, case DATADUR_A_F1: /* DATADUR_A_F1 */ if (bNeedAck) { uAckTime =3D bb_get_frame_time(p_device->preamble_type, - byPktType, 14, + by_pkt_type, 14, p_device->byTopOFDMBasicRate); } /* Non Frag or Last Frag */ @@ -303,7 +303,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, else wRate =3D w_fb_opt_1[FB_RATE0][wRate]; =20 - uNextPktTime =3D s_uGetTxRsvTime(p_device, byPktType, + uNextPktTime =3D s_uGetTxRsvTime(p_device, by_pkt_type, len, wRate, bNeedAck); } =20 @@ -320,7 +320,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, static __le16 s_uGetRTSCTSDuration(struct vnt_private *p_device, unsigned char byDurType, unsigned int cbFrameLength, - unsigned char byPktType, + unsigned char by_pkt_type, unsigned short wRate, bool bNeedAck, unsigned char byFBOption) @@ -329,83 +329,83 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, =20 switch (byDurType) { case RTSDUR_BB: /* RTSDuration_bb */ - uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, wRate, bNeedAck); + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, wRate, bNeedAck); break; =20 case RTSDUR_BA: /* RTSDuration_ba */ - uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, wRate, bNeedAck); + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, wRate, bNeedAck); break; =20 case RTSDUR_AA: /* RTSDuration_aa */ - uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, wRate, bNeedAck); + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, wRate, bNeedAck); break; =20 case CTSDUR_BA: /* CTSDuration_ba */ - uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, byPktType, + uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, wRate, bNeedAck); break; =20 case RTSDUR_BA_F0: /* RTSDuration_ba_f0 */ - uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; =20 case RTSDUR_AA_F0: /* RTSDuration_aa_f0 */ - uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; =20 case RTSDUR_BA_F1: /* RTSDuration_ba_f1 */ - uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; =20 case RTSDUR_AA_F1: /* RTSDuration_aa_f1 */ - uCTSTime =3D bb_get_frame_time(p_device->preamble_type, byPktType, 14, + uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; @@ -413,11 +413,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, case CTSDUR_BA_F0: /* CTSDuration_ba_f0 */ if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; @@ -425,11 +425,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, case CTSDUR_BA_F1: /* CTSDuration_ba_f1 */ if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D p_device->uSIFS + - s_uGetTxRsvTime(p_device, byPktType, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; @@ -442,7 +442,7 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private *= p_device, } =20 static __le16 s_uFillDataHead(struct vnt_private *p_device, - unsigned char byPktType, + unsigned char by_pkt_type, void *pTxDataHead, unsigned int cbFrameLength, unsigned int uDMAIdx, @@ -459,7 +459,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, if (!pTxDataHead) return 0; =20 - if (byPktType =3D=3D PK_TYPE_11GB || byPktType =3D=3D PK_TYPE_11GA) { + if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { /* Auto Fallback */ struct vnt_tx_datahead_g_fb *buf =3D pTxDataHead; =20 @@ -467,7 +467,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, struct vnt_tx_datahead_g *buf =3D pTxDataHead; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, - byPktType, &buf->a); + by_pkt_type, &buf->a); =20 vnt_get_phy_field(p_device, cbFrameLength, p_device->byTopCCKBasicRate, @@ -483,7 +483,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, buf->duration_a =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, cbFrameLength, - byPktType, + by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, @@ -509,14 +509,14 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, =20 /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, - byPktType, &buf->a); + by_pkt_type, &buf->a); =20 vnt_get_phy_field(p_device, cbFrameLength, p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); /* Get Duration and TimeStamp */ buf->duration_a =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADU= R_A, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); @@ -527,13 +527,13 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_a_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F0, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_a_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F1, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, @@ -544,7 +544,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, =20 return buf->duration_a; /* if (byFBOption =3D=3D AUTO_FB_NONE) */ - } else if (byPktType =3D=3D PK_TYPE_11A) { + } else if (by_pkt_type =3D=3D PK_TYPE_11A) { struct vnt_tx_datahead_ab *buf =3D pTxDataHead; =20 if (byFBOption !=3D AUTO_FB_NONE) { @@ -552,24 +552,24 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, struct vnt_tx_datahead_a_fb *buf =3D pTxDataHead; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, - byPktType, &buf->a); + by_pkt_type, &buf->a); =20 /* Get Duration and TimeStampOff */ buf->duration =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F0, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F1, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); @@ -579,7 +579,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, =20 /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, - byPktType, &buf->ab); + by_pkt_type, &buf->ab); =20 if (is_pspoll) { __le16 dur =3D cpu_to_le16(p_device->current_aid | BIT(14) | BIT(15)); @@ -589,7 +589,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, /* Get Duration and TimeStampOff */ buf->duration =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); @@ -601,7 +601,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, =20 /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, - byPktType, &buf->ab); + by_pkt_type, &buf->ab); =20 if (is_pspoll) { __le16 dur =3D cpu_to_le16(p_device->current_aid | BIT(14) | BIT(15)); @@ -611,7 +611,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, /* Get Duration and TimeStampOff */ buf->duration =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, cbFrameLength, - byPktType, wCurrentRate, bNeedAck, + by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); } @@ -621,7 +621,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, } =20 static void s_v_fill_rts_head(struct vnt_private *p_device, - unsigned char byPktType, + unsigned char by_pkt_type, void *pvRTS, unsigned int cbFrameLength, bool bNeedAck, @@ -646,7 +646,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, * so we don't need to take them into account. * Otherwise, we need to modify codes for them. */ - if (byPktType =3D=3D PK_TYPE_11GB || byPktType =3D=3D PK_TYPE_11GA) { + if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { if (byFBOption =3D=3D AUTO_FB_NONE) { struct vnt_rts_g *buf =3D pvRTS; /* Get SignalField, ServiceField & Length */ @@ -656,7 +656,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, =20 vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopOFDMBasicRate, - byPktType, &buf->a); + by_pkt_type, &buf->a); /* Get Duration */ buf->duration_bb =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BB, @@ -665,12 +665,12 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, bNeedAck, byFBOption); buf->duration_aa =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 @@ -691,7 +691,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, =20 vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopOFDMBasicRate, - byPktType, &buf->a); + by_pkt_type, &buf->a); /* Get Duration */ buf->duration_bb =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BB, @@ -700,32 +700,32 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, bNeedAck, byFBOption); buf->duration_aa =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_ba_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F0, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_aa_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_ba_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F1, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_aa_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->data.duration =3D buf->duration_aa; @@ -737,17 +737,17 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, ether_addr_copy(buf->data.ra, hdr->addr1); ether_addr_copy(buf->data.ta, hdr->addr2); } /* if (byFBOption =3D=3D AUTO_FB_NONE) */ - } else if (byPktType =3D=3D PK_TYPE_11A) { + } else if (by_pkt_type =3D=3D PK_TYPE_11A) { if (byFBOption =3D=3D AUTO_FB_NONE) { struct vnt_rts_ab *buf =3D pvRTS; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopOFDMBasicRate, - byPktType, &buf->ab); + by_pkt_type, &buf->ab); /* Get Duration */ buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->data.duration =3D buf->duration; @@ -763,21 +763,21 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopOFDMBasicRate, - byPktType, &buf->a); + by_pkt_type, &buf->a); /* Get Duration */ buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->data.duration =3D buf->duration; @@ -789,7 +789,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, ether_addr_copy(buf->data.ra, hdr->addr1); ether_addr_copy(buf->data.ta, hdr->addr2); } - } else if (byPktType =3D=3D PK_TYPE_11B) { + } else if (by_pkt_type =3D=3D PK_TYPE_11B) { struct vnt_rts_ab *buf =3D pvRTS; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, @@ -798,7 +798,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, /* Get Duration */ buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cbFrameLength, - byPktType, wCurrentRate, bNeedAck, + by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 buf->data.duration =3D buf->duration; @@ -813,7 +813,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, =20 static void s_vFillCTSHead(struct vnt_private *p_device, unsigned int uDMAIdx, - unsigned char byPktType, + unsigned char by_pkt_type, void *pvCTS, unsigned int cbFrameLength, bool bNeedAck, @@ -833,7 +833,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, uCTSFrameLen -=3D 4; } =20 - if (byPktType =3D=3D PK_TYPE_11GB || byPktType =3D=3D PK_TYPE_11GA) { + if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { if (byFBOption !=3D AUTO_FB_NONE && uDMAIdx !=3D TYPE_ATIMDMA && uDMAIdx !=3D TYPE_BEACONDMA) { @@ -846,21 +846,21 @@ static void s_vFillCTSHead(struct vnt_private *p_devi= ce, =20 buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 /* Get CTSDuration_ba_f0 */ buf->cts_duration_ba_f0 =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F0, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 /* Get CTSDuration_ba_f1 */ buf->cts_duration_ba_f1 =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F1, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 @@ -889,7 +889,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, /* Get CTSDuration_ba */ buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA, - cbFrameLength, byPktType, + cbFrameLength, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 @@ -932,7 +932,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, * unsigned int cbFrameSize, Hdr+Payload+FCS */ static void s_vGenerateTxParameter(struct vnt_private *p_device, - unsigned char byPktType, + unsigned char by_pkt_type, struct vnt_tx_fifo_head *tx_buffer_head, void *pvRrvTime, void *pvRTS, @@ -960,51 +960,51 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, if (!pvRrvTime) return; =20 - if (byPktType =3D=3D PK_TYPE_11GB || byPktType =3D=3D PK_TYPE_11GA) { + if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { if (pvRTS) { /* RTS_need */ /* Fill RsvTime */ struct vnt_rrv_time_rts *buf =3D pvRrvTime; =20 - buf->rts_rrv_time_aa =3D get_rtscts_time(p_device, 2, byPktType, cbFram= eSize, - wCurrentRate); - buf->rts_rrv_time_ba =3D get_rtscts_time(p_device, 1, byPktType, cbFram= eSize, - wCurrentRate); - buf->rts_rrv_time_bb =3D get_rtscts_time(p_device, 0, byPktType, cbFram= eSize, - wCurrentRate); - buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, byPktType, cbFrameS= ize, + buf->rts_rrv_time_aa =3D get_rtscts_time(p_device, 2, by_pkt_type, + cbFrameSize, wCurrentRate); + buf->rts_rrv_time_ba =3D get_rtscts_time(p_device, 1, by_pkt_type, + cbFrameSize, wCurrentRate); + buf->rts_rrv_time_bb =3D get_rtscts_time(p_device, 0, by_pkt_type, + cbFrameSize, wCurrentRate); + buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cbFram= eSize, wCurrentRate, bNeedACK); buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFram= eSize, p_device->byTopCCKBasicRate, bNeedACK); =20 - s_v_fill_rts_head(p_device, byPktType, pvRTS, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pvRrvTime; =20 - buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, byPktType, cbFrameS= ize, + buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cbFram= eSize, wCurrentRate, bNeedACK); buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFram= eSize, p_device->byTopCCKBasicRate, bNeedACK); - buf->cts_rrv_time_ba =3D get_rtscts_time(p_device, 3, byPktType, cbFram= eSize, - wCurrentRate); + buf->cts_rrv_time_ba =3D get_rtscts_time(p_device, 3, by_pkt_type, + cbFrameSize, wCurrentRate); =20 /* Fill CTS */ - s_vFillCTSHead(p_device, uDMAIdx, byPktType, pvCTS, cbFrameSize, bNeedA= CK, + s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pvCTS, cbFrameSize, bNee= dACK, bDisCRC, wCurrentRate, byFBOption); } - } else if (byPktType =3D=3D PK_TYPE_11A) { + } else if (by_pkt_type =3D=3D PK_TYPE_11A) { if (pvRTS) {/* RTS_need, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 - buf->rts_rrv_time =3D get_rtscts_time(p_device, 2, byPktType, cbFrameSi= ze, + buf->rts_rrv_time =3D get_rtscts_time(p_device, 2, by_pkt_type, cbFrame= Size, wCurrentRate); - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, byPktType, cbFrameSiz= e, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cbFrameS= ize, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_v_fill_rts_head(p_device, byPktType, pvRTS, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else if (!pvRTS) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; @@ -1012,17 +1012,17 @@ static void s_vGenerateTxParameter(struct vnt_priva= te *p_device, buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11A, cbFrameS= ize, wCurrentRate, bNeedACK); } - } else if (byPktType =3D=3D PK_TYPE_11B) { + } else if (by_pkt_type =3D=3D PK_TYPE_11B) { if (pvRTS) {/* RTS_need, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 - buf->rts_rrv_time =3D get_rtscts_time(p_device, 0, byPktType, cbFrameSi= ze, + buf->rts_rrv_time =3D get_rtscts_time(p_device, 0, by_pkt_type, cbFrame= Size, wCurrentRate); buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFrameS= ize, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_v_fill_rts_head(p_device, byPktType, pvRTS, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; @@ -1034,7 +1034,7 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, } =20 static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device, - unsigned char byPktType, + unsigned char by_pkt_type, unsigned char *pbyTxBufferAddr, unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, @@ -1097,7 +1097,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, =20 /* Set RrvTime/RTS/CTS Buffer */ wTxBufSize =3D sizeof(struct vnt_tx_fifo_head); - if (byPktType =3D=3D PK_TYPE_11GB || byPktType =3D=3D PK_TYPE_11GA) {/* 8= 02.11g packet */ + if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) {= /* 802.11g packet */ =20 if (byFBOption =3D=3D AUTO_FB_NONE) { if (bRTS) {/* RTS_need */ @@ -1218,12 +1218,12 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, memset((void *)(pbyTxBufferAddr + wTxBufSize), 0, (cbHeaderLength - wTxBu= fSize)); =20 /* Fill FIFO,RrvTime,RTS,and CTS */ - s_vGenerateTxParameter(p_device, byPktType, tx_buffer_head, pvRrvTime, pv= RTS, pvCTS, + s_vGenerateTxParameter(p_device, by_pkt_type, tx_buffer_head, pvRrvTime, = pvRTS, pvCTS, cbFrameSize, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); /* Fill DataHead */ - uDuration =3D s_uFillDataHead(p_device, byPktType, pvTxDataHd, cbFrameSiz= e, uDMAIdx, bNeedACK, - 0, 0, uMACfragNum, byFBOption, p_device->wCurrentRate, - is_pspoll); + uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cbFrameS= ize, uDMAIdx, + bNeedACK, 0, 0, uMACfragNum, byFBOption, + p_device->wCurrentRate, is_pspoll); =20 hdr->duration_id =3D uDuration; =20 --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF9A9ECDFA1 for ; Tue, 25 Oct 2022 23:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232799AbiJYXiG (ORCPT ); Tue, 25 Oct 2022 19:38:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232803AbiJYXhw (ORCPT ); Tue, 25 Oct 2022 19:37:52 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBD80FBCE4 for ; Tue, 25 Oct 2022 16:37:50 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id f37so25279934lfv.8 for ; Tue, 25 Oct 2022 16:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cIL7hs0OLEXS53X2Oc0txigmp9eqeR1FsRtjuja64LE=; b=SX2PETI8yg6/z0hzhnzoaQ6p83+ugQFMryOzbtKkrGBuF83p6LpQJ+p6i0OTGd2JUV vqhWpnQNdYYhJtUBAIhKPKrFWwtYC3wfCLfxhzAEIyG4zKmr5xxun/jFjcwqG7rgTd6W vBf+AO22Sz62zJazOq0swtREV8KOo2lYugCmBSvQdX3kxh3E5XOn6Z6wnpc54I8JXe1u VC8ErfUEEk4Rgo6QVqJE7iWXDOB6RRw0LQDqLA6mvarw7DVSueDbqnB6iZRml0l/HI2X aPrVfBV4jz46hSp4LM7CYq+MaJbdAFrAgRNxnPrxBamPV51a0i9NbEHCbimhhTcCIoRg A6kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cIL7hs0OLEXS53X2Oc0txigmp9eqeR1FsRtjuja64LE=; b=kE0UmStH1JmaD3V+dUCkqS8E6ZylrCLWBoNDKmWeOj+SJ77EFjidjx+zHdU15noX/S Dcoh1eWaAT6gfmN3xaUoMZXtGdV6F7t6ZFcxfYxSbNoQokO3iztHwpgcpIpahoikACF6 4AQBnrltI+8yT9DuEJyjna1QJKFP6j7SD699NrltdeUFi1sY15FtwQiAf+Q1VlAtc7Cw SwvNI1mD2sv1LpS1IX98x7FGKdYTRa5J2csZ3HU07QBO6tOdGjVrJAYOJlSVTjwfE7uX +6JSzYBx3RT8V/Qp3PRTrtcRv5g0KaouBmgDSS9COvTc99BdVrIN9uKOmkSwQ/jYai58 QQhA== X-Gm-Message-State: ACrzQf2edhPHWVeHteq2h/RADgeC0mJj9QxPbaUIzzXh9DmAkkKnqaB6 0OmaiCPsWBNH575FeAxI5zA= X-Google-Smtp-Source: AMsMyM6m+P1aW4KvgKvgzx5s3B8cYmoIyN5cMvlq6Jg4RBpEQsZnplv+joIkRcnyUNFrC7aOXfS84g== X-Received: by 2002:a05:6512:2153:b0:4a2:9c69:ab4b with SMTP id s19-20020a056512215300b004a29c69ab4bmr15576767lfr.459.1666741068903; Tue, 25 Oct 2022 16:37:48 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:48 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 05/17] staging: vt6655: changed variable name: pvRTS Date: Tue, 25 Oct 2022 23:37:01 +0000 Message-Id: <47da976cd02d262cebe520b21a0bf2451de6731b.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names pvRTS to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 56 +++++++++++++++++------------------ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 2cac8f3882df..e97cba014adf 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -87,7 +87,7 @@ static const unsigned short w_fb_opt_1[2][5] =3D { /*--------------------- Static Functions --------------------------*/ static void s_v_fill_rts_head(struct vnt_private *p_device, unsigned char by_pkt_type, - void *pvRTS, + void *pv_rts, unsigned int cbFrameLength, bool bNeedAck, bool bDisCRC, @@ -99,7 +99,7 @@ static void s_vGenerateTxParameter(struct vnt_private *p_= device, unsigned char by_pkt_type, struct vnt_tx_fifo_head *, void *pvRrvTime, - void *pvRTS, + void *pv_rts, void *pvCTS, unsigned int cbFrameSize, bool bNeedACK, @@ -622,7 +622,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, =20 static void s_v_fill_rts_head(struct vnt_private *p_device, unsigned char by_pkt_type, - void *pvRTS, + void *pv_rts, unsigned int cbFrameLength, bool bNeedAck, bool bDisCRC, @@ -632,7 +632,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, { unsigned int uRTSFrameLen =3D 20; =20 - if (!pvRTS) + if (!pv_rts) return; =20 if (bDisCRC) { @@ -648,7 +648,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, */ if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { if (byFBOption =3D=3D AUTO_FB_NONE) { - struct vnt_rts_g *buf =3D pvRTS; + struct vnt_rts_g *buf =3D pv_rts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopCCKBasicRate, @@ -683,7 +683,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, ether_addr_copy(buf->data.ra, hdr->addr1); ether_addr_copy(buf->data.ta, hdr->addr2); } else { - struct vnt_rts_g_fb *buf =3D pvRTS; + struct vnt_rts_g_fb *buf =3D pv_rts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopCCKBasicRate, @@ -739,7 +739,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, } /* if (byFBOption =3D=3D AUTO_FB_NONE) */ } else if (by_pkt_type =3D=3D PK_TYPE_11A) { if (byFBOption =3D=3D AUTO_FB_NONE) { - struct vnt_rts_ab *buf =3D pvRTS; + struct vnt_rts_ab *buf =3D pv_rts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopOFDMBasicRate, @@ -759,7 +759,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, ether_addr_copy(buf->data.ra, hdr->addr1); ether_addr_copy(buf->data.ta, hdr->addr2); } else { - struct vnt_rts_a_fb *buf =3D pvRTS; + struct vnt_rts_a_fb *buf =3D pv_rts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopOFDMBasicRate, @@ -790,7 +790,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, ether_addr_copy(buf->data.ta, hdr->addr2); } } else if (by_pkt_type =3D=3D PK_TYPE_11B) { - struct vnt_rts_ab *buf =3D pvRTS; + struct vnt_rts_ab *buf =3D pv_rts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, p_device->byTopCCKBasicRate, @@ -918,7 +918,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, * pTxDataHead - Transmit Data Buffer * pTxBufHead - pTxBufHead * pvRrvTime - pvRrvTime - * pvRTS - RTS Buffer + * pv_rts - RTS Buffer * pCTS - CTS Buffer * cbFrameSize - Transmit Data Length (Hdr+Payload+FCS) * bNeedACK - If need ACK @@ -935,7 +935,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, unsigned char by_pkt_type, struct vnt_tx_fifo_head *tx_buffer_head, void *pvRrvTime, - void *pvRTS, + void *pv_rts, void *pvCTS, unsigned int cbFrameSize, bool bNeedACK, @@ -961,7 +961,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, return; =20 if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { - if (pvRTS) { /* RTS_need */ + if (pv_rts) { /* RTS_need */ /* Fill RsvTime */ struct vnt_rrv_time_rts *buf =3D pvRrvTime; =20 @@ -977,7 +977,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, p_device->byTopCCKBasicRate, bNeedACK); =20 - s_v_fill_rts_head(p_device, by_pkt_type, pvRTS, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pvRrvTime; @@ -995,7 +995,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, bDisCRC, wCurrentRate, byFBOption); } } else if (by_pkt_type =3D=3D PK_TYPE_11A) { - if (pvRTS) {/* RTS_need, non PCF mode */ + if (pv_rts) {/* RTS_need, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 buf->rts_rrv_time =3D get_rtscts_time(p_device, 2, by_pkt_type, cbFrame= Size, @@ -1004,16 +1004,16 @@ static void s_vGenerateTxParameter(struct vnt_priva= te *p_device, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_v_fill_rts_head(p_device, by_pkt_type, pvRTS, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); - } else if (!pvRTS) {/* RTS_needless, non PCF mode */ + } else if (!pv_rts) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11A, cbFrameS= ize, wCurrentRate, bNeedACK); } } else if (by_pkt_type =3D=3D PK_TYPE_11B) { - if (pvRTS) {/* RTS_need, non PCF mode */ + if (pv_rts) {/* RTS_need, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 buf->rts_rrv_time =3D get_rtscts_time(p_device, 0, by_pkt_type, cbFrame= Size, @@ -1022,7 +1022,7 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_v_fill_rts_head(p_device, by_pkt_type, pvRTS, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; @@ -1061,7 +1061,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, unsigned int cbHeaderLength =3D 0; void *pvRrvTime =3D NULL; struct vnt_mic_hdr *pMICHDR =3D NULL; - void *pvRTS =3D NULL; + void *pv_rts =3D NULL; void *pvCTS =3D NULL; void *pvTxDataHd =3D NULL; unsigned short wTxBufSize; /* FFinfo size */ @@ -1104,7 +1104,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); - pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); pvCTS =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + @@ -1117,7 +1117,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); - pvRTS =3D NULL; + pv_rts =3D NULL; pvCTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + @@ -1133,7 +1133,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); - pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); pvCTS =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + @@ -1146,7 +1146,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); - pvRTS =3D NULL; + pv_rts =3D NULL; pvCTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + @@ -1164,7 +1164,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); - pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); pvCTS =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + @@ -1177,7 +1177,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); - pvRTS =3D NULL; + pv_rts =3D NULL; pvCTS =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); @@ -1190,7 +1190,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); - pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); pvCTS =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + @@ -1203,7 +1203,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); - pvRTS =3D NULL; + pv_rts =3D NULL; pvCTS =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); @@ -1218,7 +1218,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, memset((void *)(pbyTxBufferAddr + wTxBufSize), 0, (cbHeaderLength - wTxBu= fSize)); =20 /* Fill FIFO,RrvTime,RTS,and CTS */ - s_vGenerateTxParameter(p_device, by_pkt_type, tx_buffer_head, pvRrvTime, = pvRTS, pvCTS, + s_vGenerateTxParameter(p_device, by_pkt_type, tx_buffer_head, pvRrvTime, = pv_rts, pvCTS, cbFrameSize, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); /* Fill DataHead */ uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cbFrameS= ize, uDMAIdx, --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE88C38A2D for ; Tue, 25 Oct 2022 23:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232875AbiJYXiJ (ORCPT ); Tue, 25 Oct 2022 19:38:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232848AbiJYXiB (ORCPT ); Tue, 25 Oct 2022 19:38:01 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80023FC1D3 for ; Tue, 25 Oct 2022 16:37:52 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id s24so8925902ljs.11 for ; Tue, 25 Oct 2022 16:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=28Kkq5ITo1dNRgDi7dXE3iCd3I8xo6zdByktxBrcm6c=; b=dqrCAkPJ7HVGRUwV+j9rE3Er3CLOGNXuOtgcuCIvy0lyFutsWYgGdoyUlG166bbbZZ 4Yuj3BV9MgTrQQJv+GXlMe43YOstNBe62hC28S59Fw7IOKWBc6fFh5n4IJEPiGCSTbA0 zvKnBYX6ai3GHBylKhbU0o9l316lejVYWXcv4WdYA92F5o7/SQfjLmtmFN6yFkPa52Pi AHl+efg39EmGMLkyftraqc2t3JIS1ZGkhPQwZJL9Cf/Njg95+ths2j6zURExzpB4oStn klrtp/G90mJ9MgrPG3JfrqfC4gnVO0cGNjKdR8zvrnJOnWAJW78nTTG9oRNDiory1bTw 7aFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=28Kkq5ITo1dNRgDi7dXE3iCd3I8xo6zdByktxBrcm6c=; b=X1yO5sQVg9LEvlUN0wS87O8i8xtQruUrx2iLzj79TPbRYjMS0j0/fV0EJ7PGejkVDB 9Ny4OZwoCArucg0yPjoZJOGSpNADNEf8zCVvhkkDmH6lOLJ1SM/FxFMM0dPaLu+KZ374 M+LYAo6+ZnRc4XD1yV5EyUUu7Lcq2e+c4b4f571GE40KxAGZkj5SQn3FCn8yyaLuXiax EH9FFUOam+SRtXO0YTi3qDQhv34vlDr5oGpPFx6twhPdNHt0JgIq+dh4Bem6ll9Elw4R TA67ppdAEsbQQi+vgcaG8WdfQfYjL8EvJd82IwnJkf+csSNH2umky6DkLQOf2eKCoVL6 0Iuw== X-Gm-Message-State: ACrzQf0VpGFwjPt+cclV+rBoC2DLIyK+Mf76FGy+jpE589cPchcnC3uJ m8iFyrLq38/3+aW5hAE2Xcc= X-Google-Smtp-Source: AMsMyM5STbFGr1Laqst3i21MteVbIaafq4qu1jyv4KKItWTLJl8fwSBzjgmH/BPHpVaMRcnBqyiDmg== X-Received: by 2002:a2e:b892:0:b0:26f:ec13:e712 with SMTP id r18-20020a2eb892000000b0026fec13e712mr15135399ljp.50.1666741070794; Tue, 25 Oct 2022 16:37:50 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:50 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 06/17] staging: vt6655: changed variable name: cbFrameLength Date: Tue, 25 Oct 2022 23:37:02 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names cbFrameLength to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 128 +++++++++++++++++----------------- 1 file changed, 65 insertions(+), 63 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index e97cba014adf..699ca2685052 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -88,7 +88,7 @@ static const unsigned short w_fb_opt_1[2][5] =3D { static void s_v_fill_rts_head(struct vnt_private *p_device, unsigned char by_pkt_type, void *pv_rts, - unsigned int cbFrameLength, + unsigned int cb_frame_length, bool bNeedAck, bool bDisCRC, struct ieee80211_hdr *hdr, @@ -116,7 +116,7 @@ s_cbFillTxBufHead(struct vnt_private *p_device, unsigne= d char by_pkt_type, static __le16 s_uFillDataHead(struct vnt_private *p_device, unsigned char by_pkt_type, void *pTxDataHead, - unsigned int cbFrameLength, + unsigned int cb_frame_length, unsigned int uDMAIdx, bool bNeedAck, unsigned int uFragIdx, @@ -141,13 +141,13 @@ static __le16 vnt_time_stamp_off(struct vnt_private *= priv, u16 rate) */ static unsigned int s_uGetTxRsvTime(struct vnt_private *p_device, unsigned char by_pkt_type, - unsigned int cbFrameLength, + unsigned int cb_frame_length, unsigned short wRate, bool bNeedAck) { unsigned int uDataTime, uAckTime; =20 - uDataTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, cbF= rameLength, wRate); + uDataTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, cb_= frame_length, wRate); =20 if (!bNeedAck) return uDataTime; @@ -221,7 +221,7 @@ static __le16 get_rtscts_time(struct vnt_private *priv, /* byFreqType 0: 5GHz, 1:2.4Ghz */ static unsigned int s_uGetDataDuration(struct vnt_private *p_device, unsigned char byDurType, - unsigned int cbFrameLength, + unsigned int cb_frame_length, unsigned char by_pkt_type, unsigned short wRate, bool bNeedAck, @@ -239,7 +239,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, if (uFragIdx =3D=3D (uMACfragNum - 2)) len =3D cbLastFragmentSize; else - len =3D cbFrameLength; + len =3D cb_frame_length; =20 switch (byDurType) { case DATADUR_B: /* DATADUR_B */ @@ -319,7 +319,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, /* byFreqType: 0=3D>5GHZ 1=3D>2.4GHZ */ static __le16 s_uGetRTSCTSDuration(struct vnt_private *p_device, unsigned char byDurType, - unsigned int cbFrameLength, + unsigned int cb_frame_length, unsigned char by_pkt_type, unsigned short wRate, bool bNeedAck, @@ -332,26 +332,26 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, wRate, bNeedAck); + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, bNeedAck= ); break; =20 case RTSDUR_BA: /* RTSDuration_ba */ uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, wRate, bNeedAck); + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, bNeedAck= ); break; =20 case RTSDUR_AA: /* RTSDuration_aa */ uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, wRate, bNeedAck); + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, bNeedAck= ); break; =20 case CTSDUR_BA: /* CTSDuration_ba */ uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, - cbFrameLength, wRate, bNeedAck); + cb_frame_length, wRate, bNeedAck); break; =20 case RTSDUR_BA_F0: /* RTSDuration_ba_f0 */ @@ -359,11 +359,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, p_device->byTopCCKBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; @@ -373,11 +373,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, p_device->byTopOFDMBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; @@ -387,11 +387,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, p_device->byTopCCKBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; @@ -401,11 +401,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, p_device->byTopOFDMBasicRate); if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; @@ -413,11 +413,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, case CTSDUR_BA_F0: /* CTSDuration_ba_f0 */ if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); =20 break; @@ -425,11 +425,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, case CTSDUR_BA_F1: /* CTSDuration_ba_f1 */ if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cbFrameLength, + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); =20 break; @@ -444,7 +444,7 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private *= p_device, static __le16 s_uFillDataHead(struct vnt_private *p_device, unsigned char by_pkt_type, void *pTxDataHead, - unsigned int cbFrameLength, + unsigned int cb_frame_length, unsigned int uDMAIdx, bool bNeedAck, unsigned int uFragIdx, @@ -466,10 +466,10 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, if (byFBOption =3D=3D AUTO_FB_NONE) { struct vnt_tx_datahead_g *buf =3D pTxDataHead; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cb_frame_length, wCurrentRate, by_pkt_type, &buf->a); =20 - vnt_get_phy_field(p_device, cbFrameLength, + vnt_get_phy_field(p_device, cb_frame_length, p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); =20 @@ -482,7 +482,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, /* Get Duration and TimeStamp */ buf->duration_a =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, - cbFrameLength, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, @@ -491,7 +491,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, byFBOption)); buf->duration_b =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, - cbFrameLength, + cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, bNeedAck, uFragIdx, @@ -508,32 +508,34 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, } =20 /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cb_frame_length, wCurrentRate, by_pkt_type, &buf->a); =20 - vnt_get_phy_field(p_device, cbFrameLength, + vnt_get_phy_field(p_device, cb_frame_length, p_device->byTopCCKBasicRate, PK_TYPE_11B, &buf->b); /* Get Duration and TimeStamp */ buf->duration_a =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADU= R_A, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_b =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADU= R_B, - cbFrameLength, PK_TYPE_11B, + cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_a_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F0, - cbFrameLength, by_pkt_type, + cb_frame_length, + by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_a_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F1, - cbFrameLength, by_pkt_type, + cb_frame_length, + by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, @@ -551,25 +553,25 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, /* Auto Fallback */ struct vnt_tx_datahead_a_fb *buf =3D pTxDataHead; /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cb_frame_length, wCurrentRate, by_pkt_type, &buf->a); =20 /* Get Duration and TimeStampOff */ buf->duration =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F0, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F1, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); @@ -578,7 +580,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, } =20 /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cb_frame_length, wCurrentRate, by_pkt_type, &buf->ab); =20 if (is_pspoll) { @@ -589,7 +591,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, /* Get Duration and TimeStampOff */ buf->duration =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); @@ -600,7 +602,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, } =20 /* Get SignalField, ServiceField & Length */ - vnt_get_phy_field(p_device, cbFrameLength, wCurrentRate, + vnt_get_phy_field(p_device, cb_frame_length, wCurrentRate, by_pkt_type, &buf->ab); =20 if (is_pspoll) { @@ -610,7 +612,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, } else { /* Get Duration and TimeStampOff */ buf->duration =3D - cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, cbFrameLength, + cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, cb_frame_lengt= h, by_pkt_type, wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); @@ -623,7 +625,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, static void s_v_fill_rts_head(struct vnt_private *p_device, unsigned char by_pkt_type, void *pv_rts, - unsigned int cbFrameLength, + unsigned int cb_frame_length, bool bNeedAck, bool bDisCRC, struct ieee80211_hdr *hdr, @@ -660,17 +662,17 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, /* Get Duration */ buf->duration_bb =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BB, - cbFrameLength, PK_TYPE_11B, + cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, bNeedAck, byFBOption); buf->duration_aa =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 @@ -695,37 +697,37 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, /* Get Duration */ buf->duration_bb =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BB, - cbFrameLength, PK_TYPE_11B, + cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, bNeedAck, byFBOption); buf->duration_aa =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_ba_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F0, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_aa_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_ba_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F1, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_aa_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->data.duration =3D buf->duration_aa; @@ -747,7 +749,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, /* Get Duration */ buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->data.duration =3D buf->duration; @@ -767,17 +769,17 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, /* Get Duration */ buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->rts_duration_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); buf->data.duration =3D buf->duration; @@ -797,7 +799,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, PK_TYPE_11B, &buf->ab); /* Get Duration */ buf->duration =3D - s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cbFrameLength, + s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 @@ -815,7 +817,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, unsigned int uDMAIdx, unsigned char by_pkt_type, void *pvCTS, - unsigned int cbFrameLength, + unsigned int cb_frame_length, bool bNeedAck, bool bDisCRC, unsigned short wCurrentRate, @@ -846,21 +848,21 @@ static void s_vFillCTSHead(struct vnt_private *p_devi= ce, =20 buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 /* Get CTSDuration_ba_f0 */ buf->cts_duration_ba_f0 =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F0, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 /* Get CTSDuration_ba_f1 */ buf->cts_duration_ba_f1 =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F1, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 @@ -889,7 +891,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, /* Get CTSDuration_ba */ buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA, - cbFrameLength, by_pkt_type, + cb_frame_length, by_pkt_type, wCurrentRate, bNeedAck, byFBOption); =20 --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D168ECDFA1 for ; Tue, 25 Oct 2022 23:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232824AbiJYXiM (ORCPT ); Tue, 25 Oct 2022 19:38:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232874AbiJYXiD (ORCPT ); Tue, 25 Oct 2022 19:38:03 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9447DFC1FA for ; Tue, 25 Oct 2022 16:37:54 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id u11so7434038ljk.6 for ; Tue, 25 Oct 2022 16:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1PdLirpLV6lpEban/gZoe78yVzKjxuzACUa6QXtdzHw=; b=F5kYhw4rLKn+wqfXUM9pf+I8wfBQO8SBWO2tV7cNOVc3pnYZh+d1prXQJAeDXB5M+z ivpRXsrN2bED857w7QDPzxmcksXIVKvuiQbHR+j6197iTY/qiCR7KeGIGzw/tTKUuahD Tf9NzBjDLHXScK6CsITFK/1ABPLgrVvd34MkMR4F83qp//OK/hDRQD4ENsgGaPMh5UpW VbEplDnaSKkTn2EqnaCd7FoRBzwJYko1+qTIUBlubcWjFTPaWl4Bqpm8BD2QlLcFtjIh 1YwlI9/J8qKNcnTydaLBBaA1EcC2MIkEdbCPx7VjSgwMDEqGsGP/8sR6XR5Sq8GbluLI 2Yug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1PdLirpLV6lpEban/gZoe78yVzKjxuzACUa6QXtdzHw=; b=Bsg8cy5ZCjOpidrlNU6XGfpdEd+rT89fkdBtxcNcgQFMo6ByL1fgiAG9M1NWEygXy8 0C7CjoHHCKe9V4vdiYDOGxm0Tow3ww0pzAUZ6N7uTIoY2jE9y4D+gp5aFrW7lS0YHH1p 9KraELx2CIeLxbLY2i6jJGIT6bA3TaI1e+gNiLEaG/Z05Rc7IOlhYwGnV5+rvd4WMkJJ Rr8SgdHHy8Kf8moLU0D1kDdDUW7kSkHsMDGK9K01lMC2bk14etK7WQsX5nEBKdtioOHA jO7kIrpmju67BYD8G/CMMH3tG5wyaQLwp9pG1GbJTJPIvfcG3pzpmL48j+x4AqY3VN1s 24Ow== X-Gm-Message-State: ACrzQf3q+LhtPzpho+CaRlT6o14FB7IR2DAPG9mO0VzaTKr6zV3+88Ub MDhBaE/C0/uChwuHOm+ycXmdJzIixeoQ8w== X-Google-Smtp-Source: AMsMyM5dEKSRQKf5DrOfygOKx1BNR0qrr3KwdJrNNiZIPbd6T4z1GwwcHBQpP4Sy+pM3a1GajKkC5w== X-Received: by 2002:a2e:a490:0:b0:277:e5b:ec07 with SMTP id h16-20020a2ea490000000b002770e5bec07mr4600417lji.371.1666741072756; Tue, 25 Oct 2022 16:37:52 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:52 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 07/17] staging: vt6655: changed variable name: b_need_ack Date: Tue, 25 Oct 2022 23:37:03 +0000 Message-Id: <3990f2dbe4cf931092a113e3eeb79b9917861cb5.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names pDevice to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 129 +++++++++++++++++----------------- 1 file changed, 65 insertions(+), 64 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 699ca2685052..1949a647a443 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -89,7 +89,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_devic= e, unsigned char by_pkt_type, void *pv_rts, unsigned int cb_frame_length, - bool bNeedAck, + bool b_need_ack, bool bDisCRC, struct ieee80211_hdr *hdr, unsigned short wCurrentRate, @@ -118,7 +118,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, void *pTxDataHead, unsigned int cb_frame_length, unsigned int uDMAIdx, - bool bNeedAck, + bool b_need_ack, unsigned int uFragIdx, unsigned int cbLastFragmentSize, unsigned int uMACfragNum, @@ -143,13 +143,13 @@ static unsigned int s_uGetTxRsvTime(struct vnt_privat= e *p_device, unsigned char by_pkt_type, unsigned int cb_frame_length, unsigned short wRate, - bool bNeedAck) + bool b_need_ack) { unsigned int uDataTime, uAckTime; =20 uDataTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, cb_= frame_length, wRate); =20 - if (!bNeedAck) + if (!b_need_ack) return uDataTime; =20 /* @@ -224,7 +224,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, unsigned int cb_frame_length, unsigned char by_pkt_type, unsigned short wRate, - bool bNeedAck, + bool b_need_ack, unsigned int uFragIdx, unsigned int cbLastFragmentSize, unsigned int uMACfragNum, @@ -243,51 +243,51 @@ static unsigned int s_uGetDataDuration(struct vnt_pri= vate *p_device, =20 switch (byDurType) { case DATADUR_B: /* DATADUR_B */ - if (bNeedAck) { + if (b_need_ack) { uAckTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); } /* Non Frag or Last Frag */ if ((uMACfragNum =3D=3D 1) || bLastFrag) { - if (!bNeedAck) + if (!b_need_ack) return 0; } else { /* First Frag or Mid Frag */ uNextPktTime =3D s_uGetTxRsvTime(p_device, by_pkt_type, - len, wRate, bNeedAck); + len, wRate, b_need_ack); } =20 return p_device->uSIFS + uAckTime + uNextPktTime; =20 case DATADUR_A: /* DATADUR_A */ - if (bNeedAck) { + if (b_need_ack) { uAckTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); } /* Non Frag or Last Frag */ if ((uMACfragNum =3D=3D 1) || bLastFrag) { - if (!bNeedAck) + if (!b_need_ack) return 0; } else { /* First Frag or Mid Frag */ uNextPktTime =3D s_uGetTxRsvTime(p_device, by_pkt_type, - len, wRate, bNeedAck); + len, wRate, b_need_ack); } =20 return p_device->uSIFS + uAckTime + uNextPktTime; =20 case DATADUR_A_F0: /* DATADUR_A_F0 */ case DATADUR_A_F1: /* DATADUR_A_F1 */ - if (bNeedAck) { + if (b_need_ack) { uAckTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); } /* Non Frag or Last Frag */ if ((uMACfragNum =3D=3D 1) || bLastFrag) { - if (!bNeedAck) + if (!b_need_ack) return 0; } else { /* First Frag or Mid Frag */ @@ -304,7 +304,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, wRate =3D w_fb_opt_1[FB_RATE0][wRate]; =20 uNextPktTime =3D s_uGetTxRsvTime(p_device, by_pkt_type, - len, wRate, bNeedAck); + len, wRate, b_need_ack); } =20 return p_device->uSIFS + uAckTime + uNextPktTime; @@ -322,7 +322,7 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private *= p_device, unsigned int cb_frame_length, unsigned char by_pkt_type, unsigned short wRate, - bool bNeedAck, + bool b_need_ack, unsigned char byFBOption) { unsigned int uCTSTime =3D 0, uDurTime =3D 0; @@ -332,26 +332,26 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, bNeedAck= ); + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, b_need_a= ck); break; =20 case RTSDUR_BA: /* RTSDuration_ba */ uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, bNeedAck= ); + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, b_need_a= ck); break; =20 case RTSDUR_AA: /* RTSDuration_aa */ uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); uDurTime =3D uCTSTime + 2 * p_device->uSIFS + - s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, bNeedAck= ); + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, wRate, b_need_a= ck); break; =20 case CTSDUR_BA: /* CTSDuration_ba */ uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, - cb_frame_length, wRate, bNeedAck); + cb_frame_length, wRate, b_need_ack); break; =20 case RTSDUR_BA_F0: /* RTSDuration_ba_f0 */ @@ -360,11 +360,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE0][wRate - RATE_18M], b_need_ack); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE0][wRate - RATE_18M], b_need_ack); =20 break; =20 @@ -374,11 +374,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE0][wRate - RATE_18M], b_need_ack); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE0][wRate - RATE_18M], b_need_ack); =20 break; =20 @@ -388,11 +388,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE1][wRate - RATE_18M], b_need_ack); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE1][wRate - RATE_18M], b_need_ack); =20 break; =20 @@ -402,11 +402,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE1][wRate - RATE_18M], b_need_ack); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE1][wRate - RATE_18M], b_need_ack); =20 break; =20 @@ -414,11 +414,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_0[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE0][wRate - RATE_18M], b_need_ack); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_1[FB_RATE0][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE0][wRate - RATE_18M], b_need_ack); =20 break; =20 @@ -426,11 +426,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_0[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_0[FB_RATE1][wRate - RATE_18M], b_need_ack); else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, - w_fb_opt_1[FB_RATE1][wRate - RATE_18M], bNeedAck); + w_fb_opt_1[FB_RATE1][wRate - RATE_18M], b_need_ack); =20 break; =20 @@ -446,7 +446,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, void *pTxDataHead, unsigned int cb_frame_length, unsigned int uDMAIdx, - bool bNeedAck, + bool b_need_ack, unsigned int uFragIdx, unsigned int cbLastFragmentSize, unsigned int uMACfragNum, @@ -484,7 +484,8 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, + b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, @@ -494,7 +495,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, - bNeedAck, uFragIdx, + b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); @@ -517,26 +518,26 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, /* Get Duration and TimeStamp */ buf->duration_a =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADU= R_A, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_b =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADU= R_B, cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, - bNeedAck, uFragIdx, + b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_a_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F0, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_a_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F1, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); @@ -560,19 +561,19 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, buf->duration =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F0, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->duration_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F1, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); buf->time_stamp_off =3D vnt_time_stamp_off(p_device, wCurrentRate); @@ -592,7 +593,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, buf->duration =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); } @@ -613,7 +614,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, /* Get Duration and TimeStampOff */ buf->duration =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, cb_frame_lengt= h, - by_pkt_type, wCurrentRate, bNeedAck, + by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption)); } @@ -626,7 +627,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, unsigned char by_pkt_type, void *pv_rts, unsigned int cb_frame_length, - bool bNeedAck, + bool b_need_ack, bool bDisCRC, struct ieee80211_hdr *hdr, unsigned short wCurrentRate, @@ -664,16 +665,16 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, - bNeedAck, byFBOption); + b_need_ack, byFBOption); buf->duration_aa =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); =20 buf->data.duration =3D buf->duration_aa; @@ -699,36 +700,36 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, - bNeedAck, byFBOption); + b_need_ack, byFBOption); buf->duration_aa =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->rts_duration_ba_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F0, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->rts_duration_aa_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->rts_duration_ba_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F1, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->rts_duration_aa_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->data.duration =3D buf->duration_aa; /* Get RTS Frame body */ @@ -750,7 +751,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->data.duration =3D buf->duration; /* Get RTS Frame body */ @@ -770,17 +771,17 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->rts_duration_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->rts_duration_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); buf->data.duration =3D buf->duration; /* Get RTS Frame body */ @@ -800,7 +801,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, /* Get Duration */ buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cb_frame_length, - by_pkt_type, wCurrentRate, bNeedAck, + by_pkt_type, wCurrentRate, b_need_ack, byFBOption); =20 buf->data.duration =3D buf->duration; @@ -818,7 +819,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, unsigned char by_pkt_type, void *pvCTS, unsigned int cb_frame_length, - bool bNeedAck, + bool b_need_ack, bool bDisCRC, unsigned short wCurrentRate, unsigned char byFBOption) @@ -849,21 +850,21 @@ static void s_vFillCTSHead(struct vnt_private *p_devi= ce, buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); =20 /* Get CTSDuration_ba_f0 */ buf->cts_duration_ba_f0 =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F0, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); =20 /* Get CTSDuration_ba_f1 */ buf->cts_duration_ba_f1 =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F1, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); =20 /* Get CTS Frame body */ @@ -892,7 +893,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA, cb_frame_length, by_pkt_type, - wCurrentRate, bNeedAck, + wCurrentRate, b_need_ack, byFBOption); =20 /* Get CTS Frame body */ --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9366ECDFA1 for ; Tue, 25 Oct 2022 23:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232951AbiJYXiS (ORCPT ); Tue, 25 Oct 2022 19:38:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232883AbiJYXiE (ORCPT ); Tue, 25 Oct 2022 19:38:04 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EF36FC6DB for ; Tue, 25 Oct 2022 16:37:56 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id j4so25419571lfk.0 for ; Tue, 25 Oct 2022 16:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I/urUot3cNFITmccYXucAWbb6h0aY9AK/ky19fLze9Y=; b=eW2kzFNFulbHPkEY7L5bBP+QwQ3W37hMKKPg0Qaeboh3BrZ7/uL6LUSZ5FFptG3XZ7 NS0PqiWbQ0EeEyzfFWoobh4lME1DosqR8XHU9m7mu6pU6vZ8NSUAEhR/II8EQWim5kV/ mlkodIg0psVC7jLm+cbtiapnCeeN9shZyLVNC7THLMoMeS7K55gHiALm2PyiMS4uuuFx prQqbGpXyuSFdPNDnrayMe4jyat+D0Tde7eiRJF05I16Z1bObQaouZ0GYffCCkrEsqrU BmcSqY7wTbf3sJNdSjSKZZHcFSawKk8h+J1MpiVfycLoeeLa7FrB92I7AGmZHky8Y20B bMHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I/urUot3cNFITmccYXucAWbb6h0aY9AK/ky19fLze9Y=; b=bRh9gZzT5yPG5fdDHFe/rCnW7EgDTG6ynmBq2iYJOhVmkUriP5lZi/o40OB+kuQ2fv DqavJvEg9trguXkrnYB2Co5l+9+te880tpOglxO4mN7R/zLpSE7Qjpng1ZB6UdunfLEj vqlD392CAlh7Nw1oc6kQXfZ69NY3GO00yfVZbWEY8AG22qGOb7br42Ueea0Ympgmkf/d Jb4SpB99ZGnaVrfpmOm12zHQQqLzhXQom5K7Ro9rpBTCA++hInokTSfgTBVQN3aKpbLT AV8b95PUH07pu7iV/fgRSFR3uhAZjNTD6EMs6O6+Sbc/s2qd/nlkPodohNt7JqCTmxbD OmHQ== X-Gm-Message-State: ACrzQf3jT9GG7PHiTy4PsUBZSinFLdBNEnwU7w2GUTiXv31EgmAThR/a bYoQO7V1CmwssKjuSq5irOs= X-Google-Smtp-Source: AMsMyM4/u8NvgBgAVSW7nJHMWTZ4tIpusPuAe4BeRtt5DfV4jV37O9yX7AZSzNvJXNl/EM1m5GT/7Q== X-Received: by 2002:ac2:4a6b:0:b0:4a2:46f7:93f1 with SMTP id q11-20020ac24a6b000000b004a246f793f1mr15337574lfp.675.1666741074451; Tue, 25 Oct 2022 16:37:54 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:54 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 08/17] staging: vt6655: changed variable name: bDisCRC Date: Tue, 25 Oct 2022 23:37:04 +0000 Message-Id: <45a1de2d980f814ccc7e5c3932e4084d4d057f9e.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names bDisCRC to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 1949a647a443..cb6d915fe7d0 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -90,7 +90,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_devic= e, void *pv_rts, unsigned int cb_frame_length, bool b_need_ack, - bool bDisCRC, + bool b_dis_crc, struct ieee80211_hdr *hdr, unsigned short wCurrentRate, unsigned char byFBOption); @@ -628,7 +628,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, void *pv_rts, unsigned int cb_frame_length, bool b_need_ack, - bool bDisCRC, + bool b_dis_crc, struct ieee80211_hdr *hdr, unsigned short wCurrentRate, unsigned char byFBOption) @@ -638,7 +638,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, if (!pv_rts) return; =20 - if (bDisCRC) { + if (b_dis_crc) { /* When CRCDIS bit is on, H/W forgot to generate FCS for * RTS frame, in this case we need to decrease its length by 4. */ @@ -820,7 +820,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, void *pvCTS, unsigned int cb_frame_length, bool b_need_ack, - bool bDisCRC, + bool b_dis_crc, unsigned short wCurrentRate, unsigned char byFBOption) { @@ -829,7 +829,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, if (!pvCTS) return; =20 - if (bDisCRC) { + if (b_dis_crc) { /* When CRCDIS bit is on, H/W forgot to generate FCS for * CTS frame, in this case we need to decrease its length by 4. */ @@ -947,13 +947,13 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, unsigned short wCurrentRate) { u16 fifo_ctl =3D le16_to_cpu(tx_buffer_head->fifo_ctl); - bool bDisCRC =3D false; + bool b_dis_crc =3D false; unsigned char byFBOption =3D AUTO_FB_NONE; =20 tx_buffer_head->current_rate =3D cpu_to_le16(wCurrentRate); =20 if (fifo_ctl & FIFOCTL_CRCDIS) - bDisCRC =3D true; + b_dis_crc =3D true; =20 if (fifo_ctl & FIFOCTL_AUTO_FB_0) byFBOption =3D AUTO_FB_0; @@ -981,7 +981,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, bNeedACK); =20 s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, - bDisCRC, psEthHeader, wCurrentRate, byFBOption); + b_dis_crc, psEthHeader, wCurrentRate, byFBOption); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pvRrvTime; =20 @@ -995,7 +995,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, =20 /* Fill CTS */ s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pvCTS, cbFrameSize, bNee= dACK, - bDisCRC, wCurrentRate, byFBOption); + b_dis_crc, wCurrentRate, byFBOption); } } else if (by_pkt_type =3D=3D PK_TYPE_11A) { if (pv_rts) {/* RTS_need, non PCF mode */ @@ -1008,7 +1008,7 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, =20 /* Fill RTS */ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, - bDisCRC, psEthHeader, wCurrentRate, byFBOption); + b_dis_crc, psEthHeader, wCurrentRate, byFBOption); } else if (!pv_rts) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 @@ -1026,7 +1026,7 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, =20 /* Fill RTS */ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, - bDisCRC, psEthHeader, wCurrentRate, byFBOption); + b_dis_crc, psEthHeader, wCurrentRate, byFBOption); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FB45C38A2D for ; Tue, 25 Oct 2022 23:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232933AbiJYXij (ORCPT ); Tue, 25 Oct 2022 19:38:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232906AbiJYXiF (ORCPT ); Tue, 25 Oct 2022 19:38:05 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB4E6FE901 for ; Tue, 25 Oct 2022 16:37:57 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id j16so5707824lfe.12 for ; Tue, 25 Oct 2022 16:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4tXQriNIUNQE5KtMY/NQlCVdZ4fNvTwXzlYXOzW4dhc=; b=ettj2sD2aHK9+vfsMIHmyHUux1Rhyfj+iM3Aw5R8f7i7opCg9NNmprowG8/Q+h/lIJ 3VOkslfQQadBPWs63v6Pxq6UoVAgIo1NqJBwtFemPa+7q49IurqtDfgKIb83mFA4hMsB E/PqlO8DRCvAeQE7uOpcchdvljlHzvsP6l007OdJuoKtx9AWgzat2gUMnaxP5S2gnFf+ CrRCN4Hw2nPc7qhBMLJE+Ib/Dgei3chLbMUFi7Sys5wAX+S4l1ADVgEUX93E2/fnNZWe 1E1aKTc45n4eyG3f3ydgmjVPitaIR444whIhKv+Y7tp1agPpKME77sC+TApUlKEPmiPG qcxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4tXQriNIUNQE5KtMY/NQlCVdZ4fNvTwXzlYXOzW4dhc=; b=jzADuxQJQe5meslN4G+dxqtGoyCzsEuJxQpQYp4RkTmE9Na+6U75vzH9AvgIiymM6I U9/+hxvmALh75Gk+gZ2dUpvs4KYq+C6vXZsyHMMk6dLyQIryEEQPQuou4ieZiWYh9hZn G/tRcSlrPpcFhJnLvqGjvTALniBTb2Ewoq6neha1Gqa9Napt2ffZlgiMhCSH7VjHqB7f LkD3c+CXkHa4uIxxdUriQkGMBfLAnHqYzfn2oA7plKzxXvyYNX6ML5Yoc/ljSeJT+wnH Zxu0eoikQ2CJMpDQgALK4lf9tvvAwDk1p5pMzYaPfm0kljK54+6Sr0haIEPOpEzVg+tV nt1Q== X-Gm-Message-State: ACrzQf27TFPBG1GKTTmtpM3vi3B0eH3Lq1tTnDVa+RN42MEdXUKQEmKd kfqmyX3GayEHDZFX4jnlScAImtGqlhtccw== X-Google-Smtp-Source: AMsMyM7S4xMS3PRW+xVTY7PuAwa6utl8oN5DRUvLdD3XGJiacmrLuOCkSh52i40Gh5ZlfA2wIIP0vQ== X-Received: by 2002:ac2:5469:0:b0:4a2:6e4c:35da with SMTP id e9-20020ac25469000000b004a26e4c35damr15941101lfn.191.1666741076273; Tue, 25 Oct 2022 16:37:56 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:55 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 09/17] staging: vt6655: changed variable name: byFBOption Date: Tue, 25 Oct 2022 23:37:05 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names byFBOption to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 144 +++++++++++++++++----------------- 1 file changed, 73 insertions(+), 71 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index cb6d915fe7d0..3d28cbfec618 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -93,7 +93,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_devic= e, bool b_dis_crc, struct ieee80211_hdr *hdr, unsigned short wCurrentRate, - unsigned char byFBOption); + unsigned char by_fb_option); =20 static void s_vGenerateTxParameter(struct vnt_private *p_device, unsigned char by_pkt_type, @@ -122,7 +122,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, unsigned int uFragIdx, unsigned int cbLastFragmentSize, unsigned int uMACfragNum, - unsigned char byFBOption, + unsigned char by_fb_option, unsigned short wCurrentRate, bool is_pspoll); =20 @@ -228,7 +228,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, unsigned int uFragIdx, unsigned int cbLastFragmentSize, unsigned int uMACfragNum, - unsigned char byFBOption) + unsigned char by_fb_option) { bool bLastFrag =3D false; unsigned int uAckTime =3D 0, uNextPktTime =3D 0, len; @@ -298,7 +298,7 @@ static unsigned int s_uGetDataDuration(struct vnt_priva= te *p_device, =20 wRate -=3D RATE_18M; =20 - if (byFBOption =3D=3D AUTO_FB_0) + if (by_fb_option =3D=3D AUTO_FB_0) wRate =3D w_fb_opt_0[FB_RATE0][wRate]; else wRate =3D w_fb_opt_1[FB_RATE0][wRate]; @@ -323,7 +323,7 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private *= p_device, unsigned char by_pkt_type, unsigned short wRate, bool b_need_ack, - unsigned char byFBOption) + unsigned char by_fb_option) { unsigned int uCTSTime =3D 0, uDurTime =3D 0; =20 @@ -357,11 +357,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, case RTSDUR_BA_F0: /* RTSDuration_ba_f0 */ uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); - if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) + if ((by_fb_option =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], b_need_ack); - else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) + else if ((by_fb_option =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wR= ate <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], b_need_ack); @@ -371,11 +371,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, case RTSDUR_AA_F0: /* RTSDuration_aa_f0 */ uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); - if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) + if ((by_fb_option =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], b_need_ack); - else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) + else if ((by_fb_option =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wR= ate <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], b_need_ack); @@ -385,11 +385,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, case RTSDUR_BA_F1: /* RTSDuration_ba_f1 */ uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopCCKBasicRate); - if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) + if ((by_fb_option =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], b_need_ack); - else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) + else if ((by_fb_option =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wR= ate <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], b_need_ack); @@ -399,11 +399,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, case RTSDUR_AA_F1: /* RTSDuration_aa_f1 */ uCTSTime =3D bb_get_frame_time(p_device->preamble_type, by_pkt_type, 14, p_device->byTopOFDMBasicRate); - if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) + if ((by_fb_option =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], b_need_ack); - else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) + else if ((by_fb_option =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wR= ate <=3D RATE_54M)) uDurTime =3D uCTSTime + 2 * p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], b_need_ack); @@ -411,11 +411,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, break; =20 case CTSDUR_BA_F0: /* CTSDuration_ba_f0 */ - if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) + if ((by_fb_option =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE0][wRate - RATE_18M], b_need_ack); - else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) + else if ((by_fb_option =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wR= ate <=3D RATE_54M)) uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE0][wRate - RATE_18M], b_need_ack); @@ -423,11 +423,11 @@ static __le16 s_uGetRTSCTSDuration(struct vnt_private= *p_device, break; =20 case CTSDUR_BA_F1: /* CTSDuration_ba_f1 */ - if ((byFBOption =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) + if ((by_fb_option =3D=3D AUTO_FB_0) && (wRate >=3D RATE_18M) && (wRate <= =3D RATE_54M)) uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_0[FB_RATE1][wRate - RATE_18M], b_need_ack); - else if ((byFBOption =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wRat= e <=3D RATE_54M)) + else if ((by_fb_option =3D=3D AUTO_FB_1) && (wRate >=3D RATE_18M) && (wR= ate <=3D RATE_54M)) uDurTime =3D p_device->uSIFS + s_uGetTxRsvTime(p_device, by_pkt_type, cb_frame_length, w_fb_opt_1[FB_RATE1][wRate - RATE_18M], b_need_ack); @@ -450,7 +450,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, unsigned int uFragIdx, unsigned int cbLastFragmentSize, unsigned int uMACfragNum, - unsigned char byFBOption, + unsigned char by_fb_option, unsigned short wCurrentRate, bool is_pspoll) { @@ -463,7 +463,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, /* Auto Fallback */ struct vnt_tx_datahead_g_fb *buf =3D pTxDataHead; =20 - if (byFBOption =3D=3D AUTO_FB_NONE) { + if (by_fb_option =3D=3D AUTO_FB_NONE) { struct vnt_tx_datahead_g *buf =3D pTxDataHead; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, cb_frame_length, wCurrentRate, @@ -489,7 +489,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, uFragIdx, cbLastFragmentSize, uMACfragNum, - byFBOption)); + by_fb_option)); buf->duration_b =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, cb_frame_length, @@ -498,7 +498,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, b_need_ack, uFragIdx, cbLastFragmentSize, uMACfragNum, - byFBOption)); + by_fb_option)); } =20 buf->time_stamp_off_a =3D vnt_time_stamp_off(p_device, wCurrentRate); @@ -520,37 +520,39 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, by_fb_option)); buf->duration_b =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADU= R_B, cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, by_fb_option)); buf->duration_a_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F0, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, + by_fb_option)); buf->duration_a_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DAT= ADUR_A_F1, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, + by_fb_option)); =20 buf->time_stamp_off_a =3D vnt_time_stamp_off(p_device, wCurrentRate); buf->time_stamp_off_b =3D vnt_time_stamp_off(p_device, p_device->byTopCC= KBasicRate); =20 return buf->duration_a; - /* if (byFBOption =3D=3D AUTO_FB_NONE) */ + /* if (by_fb_option =3D=3D AUTO_FB_NONE) */ } else if (by_pkt_type =3D=3D PK_TYPE_11A) { struct vnt_tx_datahead_ab *buf =3D pTxDataHead; =20 - if (byFBOption !=3D AUTO_FB_NONE) { + if (by_fb_option !=3D AUTO_FB_NONE) { /* Auto Fallback */ struct vnt_tx_datahead_a_fb *buf =3D pTxDataHead; /* Get SignalField, ServiceField & Length */ @@ -563,19 +565,19 @@ static __le16 s_uFillDataHead(struct vnt_private *p_d= evice, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, by_fb_option)); buf->duration_f0 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F0, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, by_fb_option)); buf->duration_f1 =3D cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_A_F1, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, by_fb_option)); buf->time_stamp_off =3D vnt_time_stamp_off(p_device, wCurrentRate); return buf->duration; } @@ -595,7 +597,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, by_fb_option)); } =20 buf->time_stamp_off =3D vnt_time_stamp_off(p_device, wCurrentRate); @@ -616,7 +618,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, cpu_to_le16((u16)s_uGetDataDuration(p_device, DATADUR_B, cb_frame_lengt= h, by_pkt_type, wCurrentRate, b_need_ack, uFragIdx, cbLastFragmentSize, - uMACfragNum, byFBOption)); + uMACfragNum, by_fb_option)); } =20 buf->time_stamp_off =3D vnt_time_stamp_off(p_device, wCurrentRate); @@ -631,7 +633,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, bool b_dis_crc, struct ieee80211_hdr *hdr, unsigned short wCurrentRate, - unsigned char byFBOption) + unsigned char by_fb_option) { unsigned int uRTSFrameLen =3D 20; =20 @@ -650,7 +652,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, * Otherwise, we need to modify codes for them. */ if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { - if (byFBOption =3D=3D AUTO_FB_NONE) { + if (by_fb_option =3D=3D AUTO_FB_NONE) { struct vnt_rts_g *buf =3D pv_rts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, @@ -665,17 +667,17 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, - b_need_ack, byFBOption); + b_need_ack, by_fb_option); buf->duration_aa =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); =20 buf->data.duration =3D buf->duration_aa; /* Get RTS Frame body */ @@ -700,37 +702,37 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cb_frame_length, PK_TYPE_11B, p_device->byTopCCKBasicRate, - b_need_ack, byFBOption); + b_need_ack, by_fb_option); buf->duration_aa =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->duration_ba =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->rts_duration_ba_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F0, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->rts_duration_aa_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->rts_duration_ba_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BA_F1, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->rts_duration_aa_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->data.duration =3D buf->duration_aa; /* Get RTS Frame body */ buf->data.frame_control =3D @@ -739,9 +741,9 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, =20 ether_addr_copy(buf->data.ra, hdr->addr1); ether_addr_copy(buf->data.ta, hdr->addr2); - } /* if (byFBOption =3D=3D AUTO_FB_NONE) */ + } /* if (by_fb_option =3D=3D AUTO_FB_NONE) */ } else if (by_pkt_type =3D=3D PK_TYPE_11A) { - if (byFBOption =3D=3D AUTO_FB_NONE) { + if (by_fb_option =3D=3D AUTO_FB_NONE) { struct vnt_rts_ab *buf =3D pv_rts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uRTSFrameLen, @@ -752,7 +754,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->data.duration =3D buf->duration; /* Get RTS Frame body */ buf->data.frame_control =3D @@ -772,17 +774,17 @@ static void s_v_fill_rts_head(struct vnt_private *p_d= evice, s_uGetRTSCTSDuration(p_device, RTSDUR_AA, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->rts_duration_f0 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F0, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->rts_duration_f1 =3D s_uGetRTSCTSDuration(p_device, RTSDUR_AA_F1, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); buf->data.duration =3D buf->duration; /* Get RTS Frame body */ buf->data.frame_control =3D @@ -802,7 +804,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, buf->duration =3D s_uGetRTSCTSDuration(p_device, RTSDUR_BB, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); =20 buf->data.duration =3D buf->duration; /* Get RTS Frame body */ @@ -822,7 +824,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, bool b_need_ack, bool b_dis_crc, unsigned short wCurrentRate, - unsigned char byFBOption) + unsigned char by_fb_option) { unsigned int uCTSFrameLen =3D 14; =20 @@ -837,7 +839,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, } =20 if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { - if (byFBOption !=3D AUTO_FB_NONE && + if (by_fb_option !=3D AUTO_FB_NONE && uDMAIdx !=3D TYPE_ATIMDMA && uDMAIdx !=3D TYPE_BEACONDMA) { /* Auto Fall back */ @@ -851,21 +853,21 @@ static void s_vFillCTSHead(struct vnt_private *p_devi= ce, s_uGetRTSCTSDuration(p_device, CTSDUR_BA, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); =20 /* Get CTSDuration_ba_f0 */ buf->cts_duration_ba_f0 =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F0, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); =20 /* Get CTSDuration_ba_f1 */ buf->cts_duration_ba_f1 =3D s_uGetRTSCTSDuration(p_device, CTSDUR_BA_F1, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); =20 /* Get CTS Frame body */ buf->data.duration =3D buf->duration_ba; @@ -879,7 +881,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, ether_addr_copy(buf->data.ra, p_device->abyCurrentNetAddr); } else { - /* if (byFBOption !=3D AUTO_FB_NONE && + /* if (by_fb_option !=3D AUTO_FB_NONE && * uDMAIdx !=3D TYPE_ATIMDMA && * uDMAIdx !=3D TYPE_BEACONDMA) */ @@ -894,7 +896,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, s_uGetRTSCTSDuration(p_device, CTSDUR_BA, cb_frame_length, by_pkt_type, wCurrentRate, b_need_ack, - byFBOption); + by_fb_option); =20 /* Get CTS Frame body */ buf->data.duration =3D buf->duration_ba; @@ -948,7 +950,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, { u16 fifo_ctl =3D le16_to_cpu(tx_buffer_head->fifo_ctl); bool b_dis_crc =3D false; - unsigned char byFBOption =3D AUTO_FB_NONE; + unsigned char by_fb_option =3D AUTO_FB_NONE; =20 tx_buffer_head->current_rate =3D cpu_to_le16(wCurrentRate); =20 @@ -956,9 +958,9 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, b_dis_crc =3D true; =20 if (fifo_ctl & FIFOCTL_AUTO_FB_0) - byFBOption =3D AUTO_FB_0; + by_fb_option =3D AUTO_FB_0; else if (fifo_ctl & FIFOCTL_AUTO_FB_1) - byFBOption =3D AUTO_FB_1; + by_fb_option =3D AUTO_FB_1; =20 if (!pvRrvTime) return; @@ -981,7 +983,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, bNeedACK); =20 s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, - b_dis_crc, psEthHeader, wCurrentRate, byFBOption); + b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pvRrvTime; =20 @@ -995,7 +997,7 @@ static void s_vGenerateTxParameter(struct vnt_private *= p_device, =20 /* Fill CTS */ s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pvCTS, cbFrameSize, bNee= dACK, - b_dis_crc, wCurrentRate, byFBOption); + b_dis_crc, wCurrentRate, by_fb_option); } } else if (by_pkt_type =3D=3D PK_TYPE_11A) { if (pv_rts) {/* RTS_need, non PCF mode */ @@ -1008,7 +1010,7 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, =20 /* Fill RTS */ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, - b_dis_crc, psEthHeader, wCurrentRate, byFBOption); + b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else if (!pv_rts) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 @@ -1026,7 +1028,7 @@ static void s_vGenerateTxParameter(struct vnt_private= *p_device, =20 /* Fill RTS */ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, - b_dis_crc, psEthHeader, wCurrentRate, byFBOption); + b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pvRrvTime; =20 @@ -1068,7 +1070,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, void *pvCTS =3D NULL; void *pvTxDataHd =3D NULL; unsigned short wTxBufSize; /* FFinfo size */ - unsigned char byFBOption =3D AUTO_FB_NONE; + unsigned char by_fb_option =3D AUTO_FB_NONE; =20 cbFrameSize =3D skb->len + 4; =20 @@ -1094,15 +1096,15 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, * Use for AUTO FALL BACK */ if (fifo_ctl & FIFOCTL_AUTO_FB_0) - byFBOption =3D AUTO_FB_0; + by_fb_option =3D AUTO_FB_0; else if (fifo_ctl & FIFOCTL_AUTO_FB_1) - byFBOption =3D AUTO_FB_1; + by_fb_option =3D AUTO_FB_1; =20 /* Set RrvTime/RTS/CTS Buffer */ wTxBufSize =3D sizeof(struct vnt_tx_fifo_head); if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) {= /* 802.11g packet */ =20 - if (byFBOption =3D=3D AUTO_FB_NONE) { + if (by_fb_option =3D=3D AUTO_FB_NONE) { if (bRTS) {/* RTS_need */ pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + @@ -1162,7 +1164,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, } /* Auto Fall Back */ } else {/* 802.11a/b packet */ =20 - if (byFBOption =3D=3D AUTO_FB_NONE) { + if (by_fb_option =3D=3D AUTO_FB_NONE) { if (bRTS) { pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + @@ -1225,7 +1227,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, cbFrameSize, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); /* Fill DataHead */ uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cbFrameS= ize, uDMAIdx, - bNeedACK, 0, 0, uMACfragNum, byFBOption, + bNeedACK, 0, 0, uMACfragNum, by_fb_option, p_device->wCurrentRate, is_pspoll); =20 hdr->duration_id =3D uDuration; --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB77AC38A2D for ; Tue, 25 Oct 2022 23:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232877AbiJYXjF (ORCPT ); Tue, 25 Oct 2022 19:39:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232884AbiJYXip (ORCPT ); Tue, 25 Oct 2022 19:38:45 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DF1F101E12 for ; Tue, 25 Oct 2022 16:38:19 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id j4so25421307lfk.0 for ; Tue, 25 Oct 2022 16:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9lBB9ttth4eSvyWXw/F4NyKEvhAfegcmcryN6aA811E=; b=iWjbB1MkJ8RdSGc1z4wf+4T1ykM7kFl5KvHpIftG9RAiamzCimo1+PPA58KNIfOF9k zN/2StTMzeXZg6QWr0FRwCHL75FDBNEwS6V8xSMBJg8ie7w/QlTIjyLcg/k0KjeaTNuU an7NAL6mwIXVorwvVF7/MU5qPbPDMmaEucLxXyDPETHvEkkzo9Z/J+SBToqqT42MX1od VCuyJ+HSoL1w8774Br39u2PBO26YO22OdM9UBJPBB1xKajeerVm2Jh9FtZN0+6x1e2Nv pobkJqamcVygUlnU6Y4uxhHwjW75iL2DUJYnLTFqxJMKr4l8qyFSnsrNuQgws0gn5Bm2 4GjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9lBB9ttth4eSvyWXw/F4NyKEvhAfegcmcryN6aA811E=; b=Xu6vT1/CvQrfIsRtn45hY3Dl8ot8ILSMZ+M3ZcrKw/TKGOwPXRNLWKC26px2oLn2vx QMtX8pV3RlsnUTomPLKDqtS7If5GVvQFCfkzR7l0O9YsjsHeM1cEmcMd7LPjjcUlUXyS 5h3Pbuz1iOEq3PatvPuEwV5Yxjpyrkdak9tnAdOSQT4LukOGijRn8e9BBE49OaWaZRVN hX9XITJ6PSsq/GZ3BsKYRE1rgRQhQehlmI40+GoqIm71H1ofib9ll5S+NLGDPi8gtuTE aztXzk8H7gaPUA7LgeOO5xpGskkO+8HsrzSJyvAmOGDJKyWHJMj+N4KAfPVuPkwtSql7 i77A== X-Gm-Message-State: ACrzQf374oH00/nxH+CvhiiUXwJoYcpbHxsBE6SPk4KvdYvty+1apSPg BoNxnyc2pAXp7z+NwDGgdwA= X-Google-Smtp-Source: AMsMyM6hKY1Be5hoWquevsFoyovMmI3SbUuUpyGkvJLYhauoAYKbzJI171InzQXsBuI4ozqn5bZyAQ== X-Received: by 2002:ac2:5e35:0:b0:4a4:754f:e2d5 with SMTP id o21-20020ac25e35000000b004a4754fe2d5mr16858525lfg.77.1666741099189; Tue, 25 Oct 2022 16:38:19 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:37:57 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 10/17] staging: vt6655: changed variable name: s_vGenerateTxParameter Date: Tue, 25 Oct 2022 23:37:06 +0000 Message-Id: <1663fb051fe1a25189bb578e1e6bcde7f9ad39d4.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names s_vGenerateTxParameter to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 63 ++++++++++++++++++----------------- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 3d28cbfec618..fa11677ce119 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -10,7 +10,7 @@ * Date: May 20, 2003 * * Functions: - * s_vGenerateTxParameter - Generate tx dma required parameter. + * s_vgenerate_tx_parameter - Generate tx dma required parameter. * vGenerateMACHeader - Translate 802.3 to 802.11 header * cbGetFragCount - Calculate fragment number count * csBeacon_xmit - beacon tx function @@ -95,23 +95,24 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, unsigned short wCurrentRate, unsigned char by_fb_option); =20 -static void s_vGenerateTxParameter(struct vnt_private *p_device, - unsigned char by_pkt_type, - struct vnt_tx_fifo_head *, - void *pvRrvTime, - void *pv_rts, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate); - -static unsigned int -s_cbFillTxBufHead(struct vnt_private *p_device, unsigned char by_pkt_type, - unsigned char *pbyTxBufferAddr, - unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD, - unsigned int uNodeIndex); +static void s_vgenerate_tx_parameter(struct vnt_private *p_device, + unsigned char by_pkt_type, + struct vnt_tx_fifo_head *, + void *pvRrvTime, + void *pv_rts, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate); + +static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device, + unsigned char by_pkt_type, + unsigned char *pbyTxBufferAddr, + unsigned int uDMAIdx, + struct vnt_tx_desc *pHeadTD, + unsigned int uNodeIndex); =20 static __le16 s_uFillDataHead(struct vnt_private *p_device, unsigned char by_pkt_type, @@ -936,17 +937,17 @@ static void s_vFillCTSHead(struct vnt_private *p_devi= ce, - * unsigned int cbFrameSize, Hdr+Payload+FCS */ -static void s_vGenerateTxParameter(struct vnt_private *p_device, - unsigned char by_pkt_type, - struct vnt_tx_fifo_head *tx_buffer_head, - void *pvRrvTime, - void *pv_rts, - void *pvCTS, - unsigned int cbFrameSize, - bool bNeedACK, - unsigned int uDMAIdx, - void *psEthHeader, - unsigned short wCurrentRate) +static void s_vgenerate_tx_parameter(struct vnt_private *p_device, + unsigned char by_pkt_type, + struct vnt_tx_fifo_head *tx_buffer_head, + void *pvRrvTime, + void *pv_rts, + void *pvCTS, + unsigned int cbFrameSize, + bool bNeedACK, + unsigned int uDMAIdx, + void *psEthHeader, + unsigned short wCurrentRate) { u16 fifo_ctl =3D le16_to_cpu(tx_buffer_head->fifo_ctl); bool b_dis_crc =3D false; @@ -1223,8 +1224,8 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, memset((void *)(pbyTxBufferAddr + wTxBufSize), 0, (cbHeaderLength - wTxBu= fSize)); =20 /* Fill FIFO,RrvTime,RTS,and CTS */ - s_vGenerateTxParameter(p_device, by_pkt_type, tx_buffer_head, pvRrvTime, = pv_rts, pvCTS, - cbFrameSize, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); + s_vgenerate_tx_parameter(p_device, by_pkt_type, tx_buffer_head, pvRrvTime= , pv_rts, pvCTS, + cbFrameSize, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); /* Fill DataHead */ uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cbFrameS= ize, uDMAIdx, bNeedACK, 0, 0, uMACfragNum, by_fb_option, --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A20C38A2D for ; Tue, 25 Oct 2022 23:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232921AbiJYXjM (ORCPT ); Tue, 25 Oct 2022 19:39:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232917AbiJYXix (ORCPT ); Tue, 25 Oct 2022 19:38:53 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 111AB102DDF for ; Tue, 25 Oct 2022 16:38:26 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id o4so14576445ljp.8 for ; Tue, 25 Oct 2022 16:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=adPsMdFwSL6bN+PRqyEO9NMGmOAYkX+WohB+bU52QsU=; b=RFK2lxvoWSgqEP+BdLH+86oCD5XSSSnP+5BCA1qwL2oRjYI7jxPbLa1fHqZu3HW7ug T5cl2Gysve1287anMcBHgAO0T5VK0Ha+WUfqer2+fFFjJUDjmHkbmX9r6lQM48jw9C5r ZpRDmI+9W7r2Bs1y8I4SypkNluvFh6ohIe2VKPJq9qYQgA8bAi/yeypPnI8SFkq8BgeY LE1lMjHwpkr1C39AgU1tvjwfaM7TQwKI1A5ojSrGfwx+6rrTjE7shtO2dV2htdAupmM4 NsHprC8Wskiy90yuMITwjHBjljESvmFzcnPyi5o5enuoZ5LRGj197yTkemNU9985DYcY z05A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=adPsMdFwSL6bN+PRqyEO9NMGmOAYkX+WohB+bU52QsU=; b=K9MHAfrfZxtGSda1omqnPuFYEgefTeM8QUk+YrceXPirAHKO87Cw+gLXiGRuxJ0N3W cL9f80BBq1VIuIzQiEvVIcO/EXXtMyxfdLtfCp8BzP4xPhu4mKL2ydxxd+pcp68DS8Ah ewqjdHlPZqih+omP8Sd6RKq0WXabDWA6ip+g5umgK+0YeL0bWkETnZMxhaEypltO0vRD 6YddPQwhYI0ZND8DvC0ZRi+VmiEMD3UNHZ3KPWHS0Q3LFBC2iy+N0ZvHEXhcuCYTXq5G ahSlCn3OCRCB4pXnv/GCNWTqviadEBvhkOoZwx49uJddqMOH/JX9rg/eJnoUlB3tGuUo 3H9A== X-Gm-Message-State: ACrzQf2pzgekrWW5JIFlhf0gO2WtFt6x282lqoWfnNw4BFlyaNLE3jnk 6UaGFslxMbG1mX8swEZGc/6L5NXogcnPlw== X-Google-Smtp-Source: AMsMyM5hn1X3ZBKXJ+eyK8BQPlYTTlzEpspv1PrW4RQrhbe8FF8ovRbSF6A69SmI9FX8ubG/p3lKEQ== X-Received: by 2002:a05:651c:1601:b0:25d:744b:cdb5 with SMTP id f1-20020a05651c160100b0025d744bcdb5mr15899425ljq.351.1666741104371; Tue, 25 Oct 2022 16:38:24 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:38:20 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 11/17] staging: vt6655: changed variable name: pvRrvTime Date: Tue, 25 Oct 2022 23:37:07 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names pvRrvTime to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 74 +++++++++++++++++------------------ 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index fa11677ce119..819080b14d5d 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -98,9 +98,9 @@ static void s_v_fill_rts_head(struct vnt_private *p_devic= e, static void s_vgenerate_tx_parameter(struct vnt_private *p_device, unsigned char by_pkt_type, struct vnt_tx_fifo_head *, - void *pvRrvTime, + void *pv_rrv_time, void *pv_rts, - void *pvCTS, + void *pv_cts, unsigned int cbFrameSize, bool bNeedACK, unsigned int uDMAIdx, @@ -820,7 +820,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, static void s_vFillCTSHead(struct vnt_private *p_device, unsigned int uDMAIdx, unsigned char by_pkt_type, - void *pvCTS, + void *pv_cts, unsigned int cb_frame_length, bool b_need_ack, bool b_dis_crc, @@ -829,7 +829,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, { unsigned int uCTSFrameLen =3D 14; =20 - if (!pvCTS) + if (!pv_cts) return; =20 if (b_dis_crc) { @@ -844,7 +844,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, uDMAIdx !=3D TYPE_ATIMDMA && uDMAIdx !=3D TYPE_BEACONDMA) { /* Auto Fall back */ - struct vnt_cts_fb *buf =3D pvCTS; + struct vnt_cts_fb *buf =3D pv_cts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uCTSFrameLen, p_device->byTopCCKBasicRate, @@ -886,7 +886,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, * uDMAIdx !=3D TYPE_ATIMDMA && * uDMAIdx !=3D TYPE_BEACONDMA) */ - struct vnt_cts *buf =3D pvCTS; + struct vnt_cts *buf =3D pv_cts; /* Get SignalField, ServiceField & Length */ vnt_get_phy_field(p_device, uCTSFrameLen, p_device->byTopCCKBasicRate, @@ -923,7 +923,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, * p_device - Pointer to adapter * pTxDataHead - Transmit Data Buffer * pTxBufHead - pTxBufHead - * pvRrvTime - pvRrvTime + * pv_rrv_time - pv_rrv_time * pv_rts - RTS Buffer * pCTS - CTS Buffer * cbFrameSize - Transmit Data Length (Hdr+Payload+FCS) @@ -940,9 +940,9 @@ static void s_vFillCTSHead(struct vnt_private *p_device, static void s_vgenerate_tx_parameter(struct vnt_private *p_device, unsigned char by_pkt_type, struct vnt_tx_fifo_head *tx_buffer_head, - void *pvRrvTime, + void *pv_rrv_time, void *pv_rts, - void *pvCTS, + void *pv_cts, unsigned int cbFrameSize, bool bNeedACK, unsigned int uDMAIdx, @@ -963,13 +963,13 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, else if (fifo_ctl & FIFOCTL_AUTO_FB_1) by_fb_option =3D AUTO_FB_1; =20 - if (!pvRrvTime) + if (!pv_rrv_time) return; =20 if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { if (pv_rts) { /* RTS_need */ /* Fill RsvTime */ - struct vnt_rrv_time_rts *buf =3D pvRrvTime; + struct vnt_rrv_time_rts *buf =3D pv_rrv_time; =20 buf->rts_rrv_time_aa =3D get_rtscts_time(p_device, 2, by_pkt_type, cbFrameSize, wCurrentRate); @@ -986,7 +986,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else {/* RTS_needless, PCF mode */ - struct vnt_rrv_time_cts *buf =3D pvRrvTime; + struct vnt_rrv_time_cts *buf =3D pv_rrv_time; =20 buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cbFram= eSize, wCurrentRate, bNeedACK); @@ -997,12 +997,12 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, cbFrameSize, wCurrentRate); =20 /* Fill CTS */ - s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pvCTS, cbFrameSize, bNee= dACK, - b_dis_crc, wCurrentRate, by_fb_option); + s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pv_cts, cbFrameSize, + bNeedACK, b_dis_crc, wCurrentRate, by_fb_option); } } else if (by_pkt_type =3D=3D PK_TYPE_11A) { if (pv_rts) {/* RTS_need, non PCF mode */ - struct vnt_rrv_time_ab *buf =3D pvRrvTime; + struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 buf->rts_rrv_time =3D get_rtscts_time(p_device, 2, by_pkt_type, cbFrame= Size, wCurrentRate); @@ -1013,14 +1013,14 @@ static void s_vgenerate_tx_parameter(struct vnt_pri= vate *p_device, s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else if (!pv_rts) {/* RTS_needless, non PCF mode */ - struct vnt_rrv_time_ab *buf =3D pvRrvTime; + struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11A, cbFrameS= ize, wCurrentRate, bNeedACK); } } else if (by_pkt_type =3D=3D PK_TYPE_11B) { if (pv_rts) {/* RTS_need, non PCF mode */ - struct vnt_rrv_time_ab *buf =3D pvRrvTime; + struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 buf->rts_rrv_time =3D get_rtscts_time(p_device, 0, by_pkt_type, cbFrame= Size, wCurrentRate); @@ -1031,7 +1031,7 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else { /* RTS_needless, non PCF mode */ - struct vnt_rrv_time_ab *buf =3D pvRrvTime; + struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFrameS= ize, wCurrentRate, bNeedACK); @@ -1065,10 +1065,10 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, bool bRTS =3D (bool)(fifo_ctl & FIFOCTL_RTS); struct vnt_tx_desc *ptdCurr; unsigned int cbHeaderLength =3D 0; - void *pvRrvTime =3D NULL; + void *pv_rrv_time =3D NULL; struct vnt_mic_hdr *pMICHDR =3D NULL; void *pv_rts =3D NULL; - void *pvCTS =3D NULL; + void *pv_cts =3D NULL; void *pvTxDataHd =3D NULL; unsigned short wTxBufSize; /* FFinfo size */ unsigned char by_fb_option =3D AUTO_FB_NONE; @@ -1107,12 +1107,12 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, =20 if (by_fb_option =3D=3D AUTO_FB_NONE) { if (bRTS) {/* RTS_need */ - pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); + pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); - pvCTS =3D NULL; + pv_cts =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR + sizeof(struct vnt_rts_g)); @@ -1120,11 +1120,11 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, cbMICHDR + sizeof(struct vnt_rts_g) + sizeof(struct vnt_tx_datahead_g); } else { /* RTS_needless */ - pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); + pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); pv_rts =3D NULL; - pvCTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_cts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR + @@ -1136,12 +1136,12 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, } else { /* Auto Fall Back */ if (bRTS) {/* RTS_need */ - pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); + pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); - pvCTS =3D NULL; + pv_cts =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR + sizeof(struct vnt_rts_g_fb)); @@ -1149,11 +1149,11 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, cbMICHDR + sizeof(struct vnt_rts_g_fb) + sizeof(struct vnt_tx_datahead_g_fb); } else { /* RTS_needless */ - pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); + pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); pv_rts =3D NULL; - pvCTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_cts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + @@ -1167,12 +1167,12 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, =20 if (by_fb_option =3D=3D AUTO_FB_NONE) { if (bRTS) { - pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); + pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); - pvCTS =3D NULL; + pv_cts =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_rts_ab)); @@ -1180,11 +1180,11 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, cbMICHDR + sizeof(struct vnt_rts_ab) + sizeof(struct vnt_tx_datahead_ab); } else { /* RTS_needless, need MICHDR */ - pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); + pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); pv_rts =3D NULL; - pvCTS =3D NULL; + pv_cts =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + @@ -1193,12 +1193,12 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, } else { /* Auto Fall Back */ if (bRTS) { /* RTS_need */ - pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); + pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); - pvCTS =3D NULL; + pv_cts =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_rts_a_fb)); @@ -1206,11 +1206,11 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, cbMICHDR + sizeof(struct vnt_rts_a_fb) + sizeof(struct vnt_tx_datahead_a_fb); } else { /* RTS_needless */ - pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); + pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); pv_rts =3D NULL; - pvCTS =3D NULL; + pv_cts =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + @@ -1224,7 +1224,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, memset((void *)(pbyTxBufferAddr + wTxBufSize), 0, (cbHeaderLength - wTxBu= fSize)); =20 /* Fill FIFO,RrvTime,RTS,and CTS */ - s_vgenerate_tx_parameter(p_device, by_pkt_type, tx_buffer_head, pvRrvTime= , pv_rts, pvCTS, + s_vgenerate_tx_parameter(p_device, by_pkt_type, tx_buffer_head, pv_rrv_ti= me, pv_rts, pv_cts, cbFrameSize, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); /* Fill DataHead */ uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cbFrameS= ize, uDMAIdx, --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D48ECDFA1 for ; Tue, 25 Oct 2022 23:39:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232864AbiJYXjd (ORCPT ); Tue, 25 Oct 2022 19:39:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232906AbiJYXjI (ORCPT ); Tue, 25 Oct 2022 19:39:08 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56E32FC6E1 for ; Tue, 25 Oct 2022 16:38:55 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id z24so9438146ljn.4 for ; Tue, 25 Oct 2022 16:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AQhShKhvS/+oh7sUIgvlgzVYDBBWcRkOByOCMCkM4bY=; b=K1XJ5QSKOcw0J6F5+EbA4VLES15MWEwPg7xBGqBZOqyU16Lis5D8BqIXTe+jdpp4Hn N9i5u1qbmtACjsFk1AY2h+Pv5Fah+53WjqaC/p9hd5WahD0M4gCvMAmf7ezZbi+X4w97 tntdzGoxV/mf0z10t1Qlwi6tsxYEo5qameKn9VENyPVjo9H55WXtymWUNerUXG7R/TgA 7YdqhSpv4WRoxWR7+0y4nYMuYsPXDO6EZ1hD76a0JkBftpUW3MuROXgucKmF/cXTiBQZ Eg0Zd2EXuTarw5f/KeWqmGxCl9N7uss3ZP9b0uzeaeNy1O7tmZ4VhIILgb6ubzzSVv9X +TDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AQhShKhvS/+oh7sUIgvlgzVYDBBWcRkOByOCMCkM4bY=; b=fXA1iXuUG4r7oZxbG5she8Lv7SnNSoTlL1zC7oCZ1/1JwF7v4MoNE6k87xrjGIAruE A5sRxYjq+jM11Cii5GVbnZjIt5pwrWeSeo1a1peWM2OyQ6SfiL+te5zpZkfI/Uwu7Rkr lFn3eKWwVKtVtuzGBilZk+ytFfanr7J60e59FuszFHVncI/yIvMY6IwVCi7DmQlEGkGX mWfLgZK3k/6cQzrTwWWZqqq9+sJS1SHJqBU9yMsIXEcATicRqDDb01L8izvebfjdCNz9 833Czu8CVM9S1BVApcRu3OEPNkYsr9URvKh1oyeGBR1/OVDlSwZqfCcDav60iiuyFSho vcMw== X-Gm-Message-State: ACrzQf1TYxLk+jjvgJw5kAh0DHpI/5xDQ8ijybyJjVA/ixzLxZR0MhDs kI3+HMNzc6oTrKoMZQxsKvo= X-Google-Smtp-Source: AMsMyM4bS3i6ryub5rHwNMHGTrDUdundTDbq2f+u2NAQPYqGqLKlD3DC/3shqFXGiIs4AzNmpqwMpg== X-Received: by 2002:a2e:3a12:0:b0:277:a6b:b919 with SMTP id h18-20020a2e3a12000000b002770a6bb919mr5462167lja.191.1666741133690; Tue, 25 Oct 2022 16:38:53 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:38:49 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 12/17] staging: vt6655: changed variable name: cbFrameSize Date: Tue, 25 Oct 2022 23:37:08 +0000 Message-Id: <1be63d32bee244e0259a81b0c463efe98952aacd.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names cbFrameSize to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 58 +++++++++++++++++++---------------- 1 file changed, 31 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 819080b14d5d..cc3b642ef8af 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -101,7 +101,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, void *pv_rrv_time, void *pv_rts, void *pv_cts, - unsigned int cbFrameSize, + unsigned int cb_frame_size, bool bNeedACK, unsigned int uDMAIdx, void *psEthHeader, @@ -926,7 +926,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, * pv_rrv_time - pv_rrv_time * pv_rts - RTS Buffer * pCTS - CTS Buffer - * cbFrameSize - Transmit Data Length (Hdr+Payload+FCS) + * cb_frame_size - Transmit Data Length (Hdr+Payload+FCS) * bNeedACK - If need ACK * uDescIdx - Desc Index * Out: @@ -935,7 +935,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, * Return Value: none * - - * unsigned int cbFrameSize, Hdr+Payload+FCS + * unsigned int cb_frame_size, Hdr+Payload+FCS */ static void s_vgenerate_tx_parameter(struct vnt_private *p_device, unsigned char by_pkt_type, @@ -943,7 +943,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, void *pv_rrv_time, void *pv_rts, void *pv_cts, - unsigned int cbFrameSize, + unsigned int cb_frame_size, bool bNeedACK, unsigned int uDMAIdx, void *psEthHeader, @@ -972,68 +972,72 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, struct vnt_rrv_time_rts *buf =3D pv_rrv_time; =20 buf->rts_rrv_time_aa =3D get_rtscts_time(p_device, 2, by_pkt_type, - cbFrameSize, wCurrentRate); + cb_frame_size, wCurrentRate); buf->rts_rrv_time_ba =3D get_rtscts_time(p_device, 1, by_pkt_type, - cbFrameSize, wCurrentRate); + cb_frame_size, wCurrentRate); buf->rts_rrv_time_bb =3D get_rtscts_time(p_device, 0, by_pkt_type, - cbFrameSize, wCurrentRate); - buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cbFram= eSize, + cb_frame_size, wCurrentRate); + buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, + cb_frame_size, wCurrentRate, bNeedACK); - buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFram= eSize, + buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, + cb_frame_size, p_device->byTopCCKBasicRate, bNeedACK); =20 - s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedAC= K, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pv_rrv_time; =20 - buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cbFram= eSize, + buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, + cb_frame_size, wCurrentRate, bNeedACK); - buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFram= eSize, + buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, + cb_frame_size, p_device->byTopCCKBasicRate, bNeedACK); buf->cts_rrv_time_ba =3D get_rtscts_time(p_device, 3, by_pkt_type, - cbFrameSize, wCurrentRate); + cb_frame_size, wCurrentRate); =20 /* Fill CTS */ - s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pv_cts, cbFrameSize, + s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pv_cts, cb_frame_size, bNeedACK, b_dis_crc, wCurrentRate, by_fb_option); } } else if (by_pkt_type =3D=3D PK_TYPE_11A) { if (pv_rts) {/* RTS_need, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 - buf->rts_rrv_time =3D get_rtscts_time(p_device, 2, by_pkt_type, cbFrame= Size, + buf->rts_rrv_time =3D get_rtscts_time(p_device, 2, by_pkt_type, cb_fram= e_size, wCurrentRate); - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cbFrameS= ize, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cb_frame= _size, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedAC= K, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else if (!pv_rts) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11A, cbFrameS= ize, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11A, cb_frame= _size, wCurrentRate, bNeedACK); } } else if (by_pkt_type =3D=3D PK_TYPE_11B) { if (pv_rts) {/* RTS_need, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 - buf->rts_rrv_time =3D get_rtscts_time(p_device, 0, by_pkt_type, cbFrame= Size, + buf->rts_rrv_time =3D get_rtscts_time(p_device, 0, by_pkt_type, cb_fram= e_size, wCurrentRate); - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFrameS= ize, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cb_frame= _size, wCurrentRate, bNeedACK); =20 /* Fill RTS */ - s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cbFrameSize, bNeedACK, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedAC= K, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 - buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cbFrameS= ize, + buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cb_frame= _size, wCurrentRate, bNeedACK); } } @@ -1053,7 +1057,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, struct vnt_tx_fifo_head *tx_buffer_head =3D (struct vnt_tx_fifo_head *)td_info->buf; u16 fifo_ctl =3D le16_to_cpu(tx_buffer_head->fifo_ctl); - unsigned int cbFrameSize; + unsigned int cb_frame_size; __le16 uDuration; unsigned char *pbyBuffer; unsigned int uLength =3D 0; @@ -1073,7 +1077,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, unsigned short wTxBufSize; /* FFinfo size */ unsigned char by_fb_option =3D AUTO_FB_NONE; =20 - cbFrameSize =3D skb->len + 4; + cb_frame_size =3D skb->len + 4; =20 if (info->control.hw_key) { switch (info->control.hw_key->cipher) { @@ -1084,7 +1088,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, break; } =20 - cbFrameSize +=3D info->control.hw_key->icv_len; + cb_frame_size +=3D info->control.hw_key->icv_len; =20 if (p_device->local_id > REV_ID_VT3253_A1) { /* MAC Header should be padding 0 to DW alignment. */ @@ -1225,9 +1229,9 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, =20 /* Fill FIFO,RrvTime,RTS,and CTS */ s_vgenerate_tx_parameter(p_device, by_pkt_type, tx_buffer_head, pv_rrv_ti= me, pv_rts, pv_cts, - cbFrameSize, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); + cb_frame_size, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); /* Fill DataHead */ - uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cbFrameS= ize, uDMAIdx, + uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cb_frame= _size, uDMAIdx, bNeedACK, 0, 0, uMACfragNum, by_fb_option, p_device->wCurrentRate, is_pspoll); =20 --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8411ECDFA1 for ; Tue, 25 Oct 2022 23:39:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233055AbiJYXjh (ORCPT ); Tue, 25 Oct 2022 19:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232939AbiJYXjP (ORCPT ); Tue, 25 Oct 2022 19:39:15 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A69F6FFF83 for ; Tue, 25 Oct 2022 16:39:01 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id u2so10257516ljl.3 for ; Tue, 25 Oct 2022 16:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zbs1vdQmiigLvQ3VvOjQt4juPolJu9r7kj9YMM+BCuw=; b=NGGj1EZTA4a4FcTTnQKW9KHL1pqKgIDEiWhDE4hi1Ey4SgonsFSUwaMYcDWPIoxqhe YCpWJxCg1M55KAz8p6jqDu5+7pxZ+Cx6W9qapjoteC6XDMTKaAfQPAXEieIvF2O7IZG4 tSd/sKZOKHolv6CUJbje8MFNcs0E4XWZOKax3G79OdSWqFES6OuYMJ5WQ34zhNxYbSPt BAT5z0esFRGdQ7l9b9D7fcooSfiJaN65yWAUPqEhlkTQg6yXwOkImF1+ZOBVEt0jtyVw RQh2iOywYvPEZFWWjlMvAmfk1m0e2LUWpulbXOsPF2Vl0cOPpeaRybOsd7nS3WeKum8e Eq1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zbs1vdQmiigLvQ3VvOjQt4juPolJu9r7kj9YMM+BCuw=; b=jNJa3WhFQ8TOGX9h1DY/UFx5jQyXUYmP7qq3tuxsH9HoFPWz35IJin9p3Whs/C8IbA peaJti91JG17VMORUG8XgdZ+FWUgbRqTFP79/XbtmZGaH7LdB1Yz+eKZjUskh+R8AtBH TEed8ayyJB9bCJO6CAfLnPnyoNTYEDmSlE5xzQIDo93+MEZUBQLbDJoPnzQ665xobR9x +kuxEGg9OAr4R0pcuTTqLg5SYG+43RPo7WQVaO66BriQ9X6xj6DbPA1Zbp4/xXVgMQyv Q6JGf1InW+efueVmjgCxIG04tuCMSVguyqkfMJNVrJibeiKeegxw14rkqe8yMBrSUgz/ wa7w== X-Gm-Message-State: ACrzQf10A2h+5NUDK9i3AflxjdFcCzF/+JCRe6jNxCUzbGOBiBU6Im1w zPFSH4tKo1nXclcAOB5bJRw= X-Google-Smtp-Source: AMsMyM7mXecyr92BeBSXLrQzK/Rv3qWMmq4SmvN+zIhRShjfY3ljYeZSnuGsFUjAFASXDuiNkkgBSA== X-Received: by 2002:a2e:b626:0:b0:277:249:c1d9 with SMTP id s6-20020a2eb626000000b002770249c1d9mr7679370ljn.514.1666741140048; Tue, 25 Oct 2022 16:39:00 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:38:56 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 13/17] staging: vt6655: changed variable name: bNeedACK Date: Tue, 25 Oct 2022 23:37:09 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names bDisCRC to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 36 +++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index cc3b642ef8af..1704b63da2cd 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -102,7 +102,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, void *pv_rts, void *pv_cts, unsigned int cb_frame_size, - bool bNeedACK, + bool b_need_ack, unsigned int uDMAIdx, void *psEthHeader, unsigned short wCurrentRate); @@ -927,7 +927,7 @@ static void s_vFillCTSHead(struct vnt_private *p_device, * pv_rts - RTS Buffer * pCTS - CTS Buffer * cb_frame_size - Transmit Data Length (Hdr+Payload+FCS) - * bNeedACK - If need ACK + * b_need_ack - If need ACK * uDescIdx - Desc Index * Out: * none @@ -944,7 +944,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, void *pv_rts, void *pv_cts, unsigned int cb_frame_size, - bool bNeedACK, + bool b_need_ack, unsigned int uDMAIdx, void *psEthHeader, unsigned short wCurrentRate) @@ -979,30 +979,30 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, cb_frame_size, wCurrentRate); buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cb_frame_size, - wCurrentRate, bNeedACK); + wCurrentRate, b_need_ack); buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cb_frame_size, p_device->byTopCCKBasicRate, - bNeedACK); + b_need_ack); =20 - s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedAC= K, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_= ack, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pv_rrv_time; =20 buf->rrv_time_a =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cb_frame_size, - wCurrentRate, bNeedACK); + wCurrentRate, b_need_ack); buf->rrv_time_b =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cb_frame_size, p_device->byTopCCKBasicRate, - bNeedACK); + b_need_ack); buf->cts_rrv_time_ba =3D get_rtscts_time(p_device, 3, by_pkt_type, cb_frame_size, wCurrentRate); =20 /* Fill CTS */ s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pv_cts, cb_frame_size, - bNeedACK, b_dis_crc, wCurrentRate, by_fb_option); + b_need_ack, b_dis_crc, wCurrentRate, by_fb_option); } } else if (by_pkt_type =3D=3D PK_TYPE_11A) { if (pv_rts) {/* RTS_need, non PCF mode */ @@ -1011,16 +1011,16 @@ static void s_vgenerate_tx_parameter(struct vnt_pri= vate *p_device, buf->rts_rrv_time =3D get_rtscts_time(p_device, 2, by_pkt_type, cb_fram= e_size, wCurrentRate); buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, by_pkt_type, cb_frame= _size, - wCurrentRate, bNeedACK); + wCurrentRate, b_need_ack); =20 /* Fill RTS */ - s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedAC= K, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_= ack, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else if (!pv_rts) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11A, cb_frame= _size, - wCurrentRate, bNeedACK); + wCurrentRate, b_need_ack); } } else if (by_pkt_type =3D=3D PK_TYPE_11B) { if (pv_rts) {/* RTS_need, non PCF mode */ @@ -1029,16 +1029,16 @@ static void s_vgenerate_tx_parameter(struct vnt_pri= vate *p_device, buf->rts_rrv_time =3D get_rtscts_time(p_device, 0, by_pkt_type, cb_fram= e_size, wCurrentRate); buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cb_frame= _size, - wCurrentRate, bNeedACK); + wCurrentRate, b_need_ack); =20 /* Fill RTS */ - s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, bNeedAC= K, + s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_= ack, b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 buf->rrv_time =3D vnt_rxtx_rsvtime_le16(p_device, PK_TYPE_11B, cb_frame= _size, - wCurrentRate, bNeedACK); + wCurrentRate, b_need_ack); } } } @@ -1065,7 +1065,7 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, unsigned int uMACfragNum =3D 1; unsigned int uPadding =3D 0; unsigned int cbReqCount =3D 0; - bool bNeedACK =3D (bool)(fifo_ctl & FIFOCTL_NEEDACK); + bool b_need_ack =3D (bool)(fifo_ctl & FIFOCTL_NEEDACK); bool bRTS =3D (bool)(fifo_ctl & FIFOCTL_RTS); struct vnt_tx_desc *ptdCurr; unsigned int cbHeaderLength =3D 0; @@ -1229,10 +1229,10 @@ static unsigned int s_cbFillTxBufHead(struct vnt_pr= ivate *p_device, =20 /* Fill FIFO,RrvTime,RTS,and CTS */ s_vgenerate_tx_parameter(p_device, by_pkt_type, tx_buffer_head, pv_rrv_ti= me, pv_rts, pv_cts, - cb_frame_size, bNeedACK, uDMAIdx, hdr, p_device->wCurrentRate); + cb_frame_size, b_need_ack, uDMAIdx, hdr, p_device->wCurrentRate); /* Fill DataHead */ uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cb_frame= _size, uDMAIdx, - bNeedACK, 0, 0, uMACfragNum, by_fb_option, + b_need_ack, 0, 0, uMACfragNum, by_fb_option, p_device->wCurrentRate, is_pspoll); =20 hdr->duration_id =3D uDuration; --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C47C38A2D for ; Tue, 25 Oct 2022 23:39:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233018AbiJYXj5 (ORCPT ); Tue, 25 Oct 2022 19:39:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232892AbiJYXja (ORCPT ); Tue, 25 Oct 2022 19:39:30 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78DE91011A6 for ; Tue, 25 Oct 2022 16:39:10 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id j14so19408478ljh.12 for ; Tue, 25 Oct 2022 16:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OSbtAZQWWUA8oTDpFvYcQ18EJpkt7HUeuRn90GptEz0=; b=mStNlURizmGwwogj8cXNTWYxzr9XjCSZqreRIJpf9nQ5klAtRnZLrr+m7d7bX+Ttni rRhf+yKLeaFcFMpnOFlKF/ECFKxO+Cw8lcS3fT2zwcx7ecZUbXhpJmROC9oqImPt/sCx NTwyoTDID0iB/d74+Jfju2f6YjbVYJXZ+NIZuSz/f3ma/WImvMa9Gqk8rfnfX6ja8riT myWKjSIz4IvZgac5sugaijiVut/VncqugeF0MCqf8y8l4a6Im8R9tup+WjbK31+80nNg tPPV2lJrzcX16ULm1CG9Jf5oWS69ARn75EoxgiTO1Sp24UNAQRIswTEPW+0cTBPTHfLJ ssCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OSbtAZQWWUA8oTDpFvYcQ18EJpkt7HUeuRn90GptEz0=; b=C8rIiur5fajFB3EZ2Geeyvy+4a1yHbLR+1u686omip9A4FD2H9ogLFaoMAnnTy9YRp oCK+nMrv5UCzODlKoEfokNEr1swpHnEq6i1x+Sm7r0L9ZTku7ZE+oGSnQfk2fexhYzlh T3yYFKfRFmnH9cDlZevNbKTctF/VqGUgJ8UGQpgmGVGnGIGDAse0bYsGDoj2dsGxs7+p 0uMMBaV6tID+HrxByqNTwjkua21j4k5d7w7ToL3fR9Ezrt60lFQHQ/5b0v6HnYvLQr5X qfLKyOc/wDJBbE2vRyuGAwZyaRDgQzJl5DJ54GZ3W2IiQFJOQDJANeggZZSfXUYD3PZl 9VOA== X-Gm-Message-State: ACrzQf1uj+mLczh1n42qef5TPgwhJfRXZpwOp3a42NlXYOykHR4qCFeL E7ztjylRvf3WDqrojuNQfdE= X-Google-Smtp-Source: AMsMyM6pdPVd6dt3s0MKaOCCsRvUdbiaILZagVCon5/XBfX5/EPzo1x+zfy5pEYokvIIN+W/gEcpXg== X-Received: by 2002:a05:651c:c88:b0:26d:fea6:36b1 with SMTP id bz8-20020a05651c0c8800b0026dfea636b1mr15976530ljb.433.1666741148867; Tue, 25 Oct 2022 16:39:08 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:39:02 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 14/17] staging: vt6655: changed variable name: uDMAIdx Date: Tue, 25 Oct 2022 23:37:10 +0000 Message-Id: <97d1381cd24f3655ce6a17998805f0e2ca82c83f.1666740522.git.tanjubrunostar0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names uDMAIdx to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 1704b63da2cd..5729798973b4 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -103,14 +103,14 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, void *pv_cts, unsigned int cb_frame_size, bool b_need_ack, - unsigned int uDMAIdx, + unsigned int u_dma_idx, void *psEthHeader, unsigned short wCurrentRate); =20 static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device, unsigned char by_pkt_type, unsigned char *pbyTxBufferAddr, - unsigned int uDMAIdx, + unsigned int u_dma_idx, struct vnt_tx_desc *pHeadTD, unsigned int uNodeIndex); =20 @@ -118,7 +118,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, unsigned char by_pkt_type, void *pTxDataHead, unsigned int cb_frame_length, - unsigned int uDMAIdx, + unsigned int u_dma_idx, bool b_need_ack, unsigned int uFragIdx, unsigned int cbLastFragmentSize, @@ -446,7 +446,7 @@ static __le16 s_uFillDataHead(struct vnt_private *p_dev= ice, unsigned char by_pkt_type, void *pTxDataHead, unsigned int cb_frame_length, - unsigned int uDMAIdx, + unsigned int u_dma_idx, bool b_need_ack, unsigned int uFragIdx, unsigned int cbLastFragmentSize, @@ -818,7 +818,7 @@ static void s_v_fill_rts_head(struct vnt_private *p_dev= ice, } =20 static void s_vFillCTSHead(struct vnt_private *p_device, - unsigned int uDMAIdx, + unsigned int u_dma_idx, unsigned char by_pkt_type, void *pv_cts, unsigned int cb_frame_length, @@ -841,8 +841,8 @@ static void s_vFillCTSHead(struct vnt_private *p_device, =20 if (by_pkt_type =3D=3D PK_TYPE_11GB || by_pkt_type =3D=3D PK_TYPE_11GA) { if (by_fb_option !=3D AUTO_FB_NONE && - uDMAIdx !=3D TYPE_ATIMDMA && - uDMAIdx !=3D TYPE_BEACONDMA) { + u_dma_idx !=3D TYPE_ATIMDMA && + u_dma_idx !=3D TYPE_BEACONDMA) { /* Auto Fall back */ struct vnt_cts_fb *buf =3D pv_cts; /* Get SignalField, ServiceField & Length */ @@ -883,8 +883,8 @@ static void s_vFillCTSHead(struct vnt_private *p_device, p_device->abyCurrentNetAddr); } else { /* if (by_fb_option !=3D AUTO_FB_NONE && - * uDMAIdx !=3D TYPE_ATIMDMA && - * uDMAIdx !=3D TYPE_BEACONDMA) + * u_dma_idx !=3D TYPE_ATIMDMA && + * u_dma_idx !=3D TYPE_BEACONDMA) */ struct vnt_cts *buf =3D pv_cts; /* Get SignalField, ServiceField & Length */ @@ -945,7 +945,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, void *pv_cts, unsigned int cb_frame_size, bool b_need_ack, - unsigned int uDMAIdx, + unsigned int u_dma_idx, void *psEthHeader, unsigned short wCurrentRate) { @@ -1001,7 +1001,7 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, cb_frame_size, wCurrentRate); =20 /* Fill CTS */ - s_vFillCTSHead(p_device, uDMAIdx, by_pkt_type, pv_cts, cb_frame_size, + s_vFillCTSHead(p_device, u_dma_idx, by_pkt_type, pv_cts, cb_frame_size, b_need_ack, b_dis_crc, wCurrentRate, by_fb_option); } } else if (by_pkt_type =3D=3D PK_TYPE_11A) { @@ -1046,7 +1046,7 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device, unsigned char by_pkt_type, unsigned char *pbyTxBufferAddr, - unsigned int uDMAIdx, + unsigned int u_dma_idx, struct vnt_tx_desc *pHeadTD, unsigned int is_pspoll) { @@ -1229,9 +1229,9 @@ static unsigned int s_cbFillTxBufHead(struct vnt_priv= ate *p_device, =20 /* Fill FIFO,RrvTime,RTS,and CTS */ s_vgenerate_tx_parameter(p_device, by_pkt_type, tx_buffer_head, pv_rrv_ti= me, pv_rts, pv_cts, - cb_frame_size, b_need_ack, uDMAIdx, hdr, p_device->wCurrentRate); + cb_frame_size, b_need_ack, u_dma_idx, hdr, p_device->wCurrentRate); /* Fill DataHead */ - uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cb_frame= _size, uDMAIdx, + uDuration =3D s_uFillDataHead(p_device, by_pkt_type, pvTxDataHd, cb_frame= _size, u_dma_idx, b_need_ack, 0, 0, uMACfragNum, by_fb_option, p_device->wCurrentRate, is_pspoll); =20 --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA0CECDFA1 for ; Tue, 25 Oct 2022 23:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233072AbiJYXkH (ORCPT ); Tue, 25 Oct 2022 19:40:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232926AbiJYXjf (ORCPT ); Tue, 25 Oct 2022 19:39:35 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A67A102DCD for ; Tue, 25 Oct 2022 16:39:17 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id be13so25331279lfb.4 for ; Tue, 25 Oct 2022 16:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jbEoGrXusmODeHp59Zc33PMYoCkMrCDJTVhmN+b+I+A=; b=M9fqafIZ1Re9mdOIXzPeUQ2SxkiGyfeeov1l/PQhWDPAO7db+ZZK+C9YeB6Ihvuq36 TpOQ2E4xpDuFYruMg7nZ8mQV16dapSI0/ahxfw7IcHxXZTDfyLlRqncA9cecH94bsura 11hOYU1vEANCo4P19p7zdHeSituoHVfg3I0NenQo5s1VG19OlW3N6myBlX1YF9kclsK8 f/osWfHTqIzpGc7awCXeLQpHXvd0k6AjjSUVKSUYIne6CGyEpMjkyylWeovahjTlrm7f oJFoxW92ufiwhDuA/ggeImMl2qgXPOckWO3byfwiQ+yD+e8fPAR17npkJcJfnjZPULzG UijA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jbEoGrXusmODeHp59Zc33PMYoCkMrCDJTVhmN+b+I+A=; b=c5bQsHjzJET4enpO/mX+5PYCEqgRqWt8Q8VrycAwrcMftENXTwy/phhCCmPkd5nRHz yMNl2Knugf3vKg91sg4vTNf/uPv30NlaDp86y/qNzOdYin9v5YukmlJHa7RekGlEks8O +Mf8tXZwMqt5SK/xK2K9NxWnMcDN6XiLbDGkjmpKFKgB5urGiLUjY+3ZmBtNGfuq8+Al tofTrf++TrTtFNktHXmoa1FzQM+IbjDge9vu3fex6I9BNHbuJJNS1+YdAdvd8KxkAB7g uJG5/avUagaZa/9vw8g+jBdGVex4T0qYKdMXOXHlGq/HRS3xVd9bc6Fwftr1Gt0nCc8z HDfw== X-Gm-Message-State: ACrzQf04mPZZX9X8vGmaOTs5+967BX3J8UsXaXVOSfXxMnIcxktT+htk kwbOG9rkDdAIykLpJRH4OTk= X-Google-Smtp-Source: AMsMyM6UhwvO3JUqhW/6sJglO/qyarUK8nliSw1Qw+2cQpPNnVqcEx/ejROPYKKaxEqyAUIAHOK23g== X-Received: by 2002:a19:9106:0:b0:4ab:a0dc:ac3e with SMTP id t6-20020a199106000000b004aba0dcac3emr4992767lfd.395.1666741155896; Tue, 25 Oct 2022 16:39:15 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.39.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:39:13 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 15/17] staging: vt6655: changed variable name: psEthHeader Date: Tue, 25 Oct 2022 23:37:11 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names psEthHeader to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 5729798973b4..6a54f234261a 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -104,7 +104,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, unsigned int cb_frame_size, bool b_need_ack, unsigned int u_dma_idx, - void *psEthHeader, + void *ps_eth_header, unsigned short wCurrentRate); =20 static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device, @@ -946,7 +946,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, unsigned int cb_frame_size, bool b_need_ack, unsigned int u_dma_idx, - void *psEthHeader, + void *ps_eth_header, unsigned short wCurrentRate) { u16 fifo_ctl =3D le16_to_cpu(tx_buffer_head->fifo_ctl); @@ -986,7 +986,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, b_need_ack); =20 s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_= ack, - b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); + b_dis_crc, ps_eth_header, wCurrentRate, by_fb_option); } else {/* RTS_needless, PCF mode */ struct vnt_rrv_time_cts *buf =3D pv_rrv_time; =20 @@ -1015,7 +1015,7 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, =20 /* Fill RTS */ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_= ack, - b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); + b_dis_crc, ps_eth_header, wCurrentRate, by_fb_option); } else if (!pv_rts) {/* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 @@ -1033,7 +1033,7 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, =20 /* Fill RTS */ s_v_fill_rts_head(p_device, by_pkt_type, pv_rts, cb_frame_size, b_need_= ack, - b_dis_crc, psEthHeader, wCurrentRate, by_fb_option); + b_dis_crc, ps_eth_header, wCurrentRate, by_fb_option); } else { /* RTS_needless, non PCF mode */ struct vnt_rrv_time_ab *buf =3D pv_rrv_time; =20 --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C32CECDFA1 for ; Tue, 25 Oct 2022 23:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233005AbiJYXkU (ORCPT ); Tue, 25 Oct 2022 19:40:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232994AbiJYXjj (ORCPT ); Tue, 25 Oct 2022 19:39:39 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CAF330E for ; Tue, 25 Oct 2022 16:39:24 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id bp15so25263852lfb.13 for ; Tue, 25 Oct 2022 16:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4gmfQ841LKpP9QCVyPPMnd2eQzGH1p8rgK8Y5XRomgo=; b=YTmuRZFIcZVli7zhVelVT0g3PfnT8wjxDyEkrrLfyX+5+HGECvthmVBGulRNFLMoCo eSusTOBklBWWHLazqKRF9Z0ksJUaCQ/PdBuZKmnY1Uu2AZ9PuLXlx9+w0ORQZpu3aiJ+ Luac4gPX2tInIseUdN1qHkoUaljhESq15Bm/V6lBVPTbj3fza9rhaK6tbnKdmNQ7/U9t dkUPVnC26YINzefoOmjFhtrypAgFmrtxOYl1JlDdNQ/HF1oNxKTaG1UfrW50H/6vtJ1H sUOMkq73xvpNUY/lD/kBWflPyN9xmKCe9sVKAZV/3Ute3dhwsSylSADqqGASqWVUAdk0 gXIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4gmfQ841LKpP9QCVyPPMnd2eQzGH1p8rgK8Y5XRomgo=; b=V1kdIlmqkuW7DEyBbMjP2GKPjsBV7cV84uUFr1ZSnXNMc1B4N3brhHiMcAgNF26DH7 kRQ6A+kXYu0nrvrbt/RFEL31hmm4yEjzT1QB92WcVfEz06gGHWA2r8W0tmARskbtL/hn asViJIKsfgk/haqhDaZOv916N7PcYOw+YraAKkak8H7suao06N2664RL2uBmz6eiKn4H CPTJ8YVMp87CInrgcYdmrJlFXjAe5c0ZuycRlb0iMwsDpyO9Fln6On7B/y2FlV2r+HqX g3nyX4qCPiXtZTAApezzQthOHYqI0KByhocLcW6dVFbdySA776LdWVVGHWCTDYEUrtJO XWBA== X-Gm-Message-State: ACrzQf2Muo/a+Y3oJtqbrOXJpVZ5I3sdE1oBPRe+QGmaXv3AeIlux4eR AZj8m7XrOs/37AMMSJCOBr0= X-Google-Smtp-Source: AMsMyM7xnOhYklUk/L6qn+lAmcei5pXO3NUS6ORAguJHkjet9pjpysYnr5824VxiKOFXUeyqvIjDyg== X-Received: by 2002:a05:6512:340f:b0:4a2:a946:613e with SMTP id i15-20020a056512340f00b004a2a946613emr16309543lfr.230.1666741162864; Tue, 25 Oct 2022 16:39:22 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:39:20 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 16/17] staging: vt6655: changed variable name: s_cbFillTxBufHead Date: Tue, 25 Oct 2022 23:37:12 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names s_cbFillTxBufHead to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 6a54f234261a..90e7330680d9 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -15,7 +15,7 @@ * cbGetFragCount - Calculate fragment number count * csBeacon_xmit - beacon tx function * csMgmt_xmit - management tx function - * s_cbFillTxBufHead - fulfill tx dma buffer header + * s_cb_fill_tx_buf_head - fulfill tx dma buffer header * s_uGetDataDuration - get tx data required duration * s_uFillDataHead- fulfill tx data duration header * s_uGetRTSCTSDuration- get rtx/cts required duration @@ -107,12 +107,12 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, void *ps_eth_header, unsigned short wCurrentRate); =20 -static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device, - unsigned char by_pkt_type, - unsigned char *pbyTxBufferAddr, - unsigned int u_dma_idx, - struct vnt_tx_desc *pHeadTD, - unsigned int uNodeIndex); +static unsigned int s_cb_fill_tx_buf_head(struct vnt_private *p_device, + unsigned char by_pkt_type, + unsigned char *pbyTxBufferAddr, + unsigned int u_dma_idx, + struct vnt_tx_desc *pHeadTD, + unsigned int uNodeIndex); =20 static __le16 s_uFillDataHead(struct vnt_private *p_device, unsigned char by_pkt_type, @@ -1043,12 +1043,12 @@ static void s_vgenerate_tx_parameter(struct vnt_pri= vate *p_device, } } =20 -static unsigned int s_cbFillTxBufHead(struct vnt_private *p_device, - unsigned char by_pkt_type, - unsigned char *pbyTxBufferAddr, - unsigned int u_dma_idx, - struct vnt_tx_desc *pHeadTD, - unsigned int is_pspoll) +static unsigned int s_cb_fill_tx_buf_head(struct vnt_private *p_device, + unsigned char by_pkt_type, + unsigned char *pbyTxBufferAddr, + unsigned int u_dma_idx, + struct vnt_tx_desc *pHeadTD, + unsigned int is_pspoll) { struct vnt_td_info *td_info =3D pHeadTD->td_info; struct sk_buff *skb =3D td_info->skb; @@ -1442,8 +1442,8 @@ int vnt_generate_fifo_header(struct vnt_private *priv= , u32 dma_idx, =20 tx_buffer_head->frag_ctl |=3D cpu_to_le16(FRAGCTL_NONFRAG); =20 - s_cbFillTxBufHead(priv, pkt_type, (u8 *)tx_buffer_head, - dma_idx, head_td, is_pspoll); + s_cb_fill_tx_buf_head(priv, pkt_type, (u8 *)tx_buffer_head, + dma_idx, head_td, is_pspoll); =20 if (info->control.hw_key) { tx_key =3D info->control.hw_key; --=20 2.34.1 From nobody Fri Apr 10 12:32:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D256C38A2D for ; Tue, 25 Oct 2022 23:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232995AbiJYXkh (ORCPT ); Tue, 25 Oct 2022 19:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233059AbiJYXjw (ORCPT ); Tue, 25 Oct 2022 19:39:52 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBC035AC7A for ; Tue, 25 Oct 2022 16:39:29 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id bn35so10736266ljb.5 for ; Tue, 25 Oct 2022 16:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rE7Qn2LJBw8oRGNZ8jZhcTnY/ucTu/x/xnasCdttkZM=; b=FmDhoxwjDUlKlmkONPUz9V7W3/Kwk0CBFEgESZq6/unF/EzolZFw+WJN5jVxi3Ncwl hLZjdLWocl5LUzVeJiAqU/2Jwlk9XboIG23o6O/wP1Abgst+20FdUElcenuWVkDZQNir DErLib+eOebSw+m7fLcoKhGlP9Bwsmj84kbpwu+OyYLiBMlNz4v6POnqzw0pai5ubyfx mQAcFCjpsvRvtfkPiaizKl10eJm3kXvtRRjrlietGwLqcFTr37kcasY/sxq0sld2sDla 2fiFeQn3B3CZyKo/Ssdv6prq5LOxQcsHcBe9BfVmiHh2is/1eU80o1Wh2uBk9bkrT7tx u4IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rE7Qn2LJBw8oRGNZ8jZhcTnY/ucTu/x/xnasCdttkZM=; b=VFgawYwi80p78EcB1plvxuxBGCX9T2L0FJYclRGHpGL46cAokLyp1bjNgNQD0nLgg0 HcJpzJzn2A/ykp6u6GVHOXOnMYv1QhBKiEUFPDwRSkxhnjupXhrN91/3kBkca0nCQLcd YAeTq9hV7pPXPe6tFvf9zhFjNswbfapFJtEU1L+KYP+9LX/rumxLdMgMSRWSmindsUUi OtpbeJMuNzn7+nl2vZq98UDaub+9WUAfAWHhxw5Tg4q9JECcFzZgg5BvFUw5srhPmkRo P5PbHc2/RVBn86SOKb2GQvyy2OmRSp6WkZnlaShQNzRvjQE2B2JuaGsq3QG0td6nT06K Q1fA== X-Gm-Message-State: ACrzQf3FC6xHyWgT//W8go/3A6lbl7blD4Y3lEecTviKYkCxPkHwSkIp t6EixnBA/4Tt7ajHNP5LspE= X-Google-Smtp-Source: AMsMyM4zV0sl9A0tncbG1gM7BRs6RzCO70UrswQmq/m/SFoU/pIu57Jkzx8UI4lMGwYc2N/JLwTcWA== X-Received: by 2002:a05:651c:547:b0:26f:d2ef:bccc with SMTP id q7-20020a05651c054700b0026fd2efbcccmr15973015ljp.272.1666741168006; Tue, 25 Oct 2022 16:39:28 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id w17-20020a05651c119100b0026daf4fc0f7sm701969ljo.92.2022.10.25.16.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 16:39:25 -0700 (PDT) From: Tanjuate Brunostar To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 17/17] staging: vt6655: changed variable name: pbyTxBufferAddr Date: Tue, 25 Oct 2022 23:37:13 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" change variable names pbyTxBufferAddr to meet the linux coding standard, as it says to avoid using camelCase naming style. Cought by checkpatch Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 66 +++++++++++++++++------------------ 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 90e7330680d9..da75ae573a00 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -109,7 +109,7 @@ static void s_vgenerate_tx_parameter(struct vnt_private= *p_device, =20 static unsigned int s_cb_fill_tx_buf_head(struct vnt_private *p_device, unsigned char by_pkt_type, - unsigned char *pbyTxBufferAddr, + unsigned char *pby_tx_buffer_addr, unsigned int u_dma_idx, struct vnt_tx_desc *pHeadTD, unsigned int uNodeIndex); @@ -1045,7 +1045,7 @@ static void s_vgenerate_tx_parameter(struct vnt_priva= te *p_device, =20 static unsigned int s_cb_fill_tx_buf_head(struct vnt_private *p_device, unsigned char by_pkt_type, - unsigned char *pbyTxBufferAddr, + unsigned char *pby_tx_buffer_addr, unsigned int u_dma_idx, struct vnt_tx_desc *pHeadTD, unsigned int is_pspoll) @@ -1111,26 +1111,26 @@ static unsigned int s_cb_fill_tx_buf_head(struct vn= t_private *p_device, =20 if (by_fb_option =3D=3D AUTO_FB_NONE) { if (bRTS) {/* RTS_need */ - pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + pv_rrv_time =3D (void *)(pby_tx_buffer_addr + wTxBufSize); + pMICHDR =3D (struct vnt_mic_hdr *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); - pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_rts =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); pv_cts =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pvTxDataHd =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR + sizeof(struct vnt_rts_g)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR + sizeof(struct vnt_rts_g) + sizeof(struct vnt_tx_datahead_g); } else { /* RTS_needless */ - pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + pv_rrv_time =3D (void *)(pby_tx_buffer_addr + wTxBufSize); + pMICHDR =3D (struct vnt_mic_hdr *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); pv_rts =3D NULL; - pv_cts =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_cts =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pvTxDataHd =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR + sizeof(struct vnt_cts)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_cts) + @@ -1140,26 +1140,26 @@ static unsigned int s_cb_fill_tx_buf_head(struct vn= t_private *p_device, } else { /* Auto Fall Back */ if (bRTS) {/* RTS_need */ - pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + pv_rrv_time =3D (void *)(pby_tx_buffer_addr + wTxBufSize); + pMICHDR =3D (struct vnt_mic_hdr *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_rts)); - pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_rts =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); pv_cts =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pvTxDataHd =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR + sizeof(struct vnt_rts_g_fb)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR + sizeof(struct vnt_rts_g_fb) + sizeof(struct vnt_tx_datahead_g_fb); } else { /* RTS_needless */ - pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + pv_rrv_time =3D (void *)(pby_tx_buffer_addr + wTxBufSize); + pMICHDR =3D (struct vnt_mic_hdr *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_cts)); pv_rts =3D NULL; - pv_cts =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_cts =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pvTxDataHd =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_cts) + cbMICHDR + sizeof(struct vnt_cts_fb)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_cts) + @@ -1171,25 +1171,25 @@ static unsigned int s_cb_fill_tx_buf_head(struct vn= t_private *p_device, =20 if (by_fb_option =3D=3D AUTO_FB_NONE) { if (bRTS) { - pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + pv_rrv_time =3D (void *)(pby_tx_buffer_addr + wTxBufSize); + pMICHDR =3D (struct vnt_mic_hdr *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); - pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_rts =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); pv_cts =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pvTxDataHd =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_rts_ab)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_rts_ab) + sizeof(struct vnt_tx_datahead_ab); } else { /* RTS_needless, need MICHDR */ - pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + pv_rrv_time =3D (void *)(pby_tx_buffer_addr + wTxBufSize); + pMICHDR =3D (struct vnt_mic_hdr *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); pv_rts =3D NULL; pv_cts =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pvTxDataHd =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_tx_datahead_ab); @@ -1197,25 +1197,25 @@ static unsigned int s_cb_fill_tx_buf_head(struct vn= t_private *p_device, } else { /* Auto Fall Back */ if (bRTS) { /* RTS_need */ - pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + pv_rrv_time =3D (void *)(pby_tx_buffer_addr + wTxBufSize); + pMICHDR =3D (struct vnt_mic_hdr *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); - pv_rts =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pv_rts =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); pv_cts =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pvTxDataHd =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_rts_a_fb)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_rts_a_fb) + sizeof(struct vnt_tx_datahead_a_fb); } else { /* RTS_needless */ - pv_rrv_time =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + pv_rrv_time =3D (void *)(pby_tx_buffer_addr + wTxBufSize); + pMICHDR =3D (struct vnt_mic_hdr *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab)); pv_rts =3D NULL; pv_cts =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + pvTxDataHd =3D (void *)(pby_tx_buffer_addr + wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_tx_datahead_a_fb); @@ -1225,7 +1225,7 @@ static unsigned int s_cb_fill_tx_buf_head(struct vnt_= private *p_device, =20 td_info->mic_hdr =3D pMICHDR; =20 - memset((void *)(pbyTxBufferAddr + wTxBufSize), 0, (cbHeaderLength - wTxBu= fSize)); + memset((void *)(pby_tx_buffer_addr + wTxBufSize), 0, (cbHeaderLength - wT= xBufSize)); =20 /* Fill FIFO,RrvTime,RTS,and CTS */ s_vgenerate_tx_parameter(p_device, by_pkt_type, tx_buffer_head, pv_rrv_ti= me, pv_rts, pv_cts, --=20 2.34.1