From nobody Fri Apr 10 10:43:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1E7C38A2D for ; Tue, 25 Oct 2022 11:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232430AbiJYLES (ORCPT ); Tue, 25 Oct 2022 07:04:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232399AbiJYLEK (ORCPT ); Tue, 25 Oct 2022 07:04:10 -0400 Received: from us-smtp-delivery-115.mimecast.com (us-smtp-delivery-115.mimecast.com [170.10.129.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7931180AE4 for ; Tue, 25 Oct 2022 04:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maxlinear.com; s=selector; t=1666695849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7CmpWjF+tdyh105skX48laQa4/MYRdbS099VgNPfZ0c=; b=QL+Z/tyFcq+4yUBxPR7Qmva09UBcYCbhP8dptEF1PGBbqOHx6QwFpdvOGOZSk2S4CMNyp8 yE8r+6Yw+cYafBevopvNGwfk3FPg6Vgj0wGy/lUuJLBOHQFxNVAHBRAMV6edK9z/m/y40m /EpffmsJT5u2a53l+SJmRQo5XyLXzHhzcOnCR/fSohO7L6tFO7guTukHEUCLwTy23SKfDY 5ilfLPFsxJu4vwyMPraycmZprrv+bpQOQx5CFVYLxyGfY0v/EA3TosQqtHG14vrBrLBpmw KMC5XylcCy5PuYzvLxZkG2xlKkhODIXkr02hYnF5QEdxcyU+Jm3nCAlH/Txplg== Received: from mail.maxlinear.com (174-47-1-84.static.ctl.one [174.47.1.84]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id us-mta-387-57sMzBxpPEGF0iddEP81UA-1; Tue, 25 Oct 2022 07:04:07 -0400 X-MC-Unique: 57sMzBxpPEGF0iddEP81UA-1 Received: from sgsxdev001.isng.phoenix.local (10.226.81.111) by mail.maxlinear.com (10.23.38.119) with Microsoft SMTP Server id 15.1.2375.24; Tue, 25 Oct 2022 04:04:04 -0700 From: Rahul Tanwar To: , , , CC: , , "Rahul Tanwar" Subject: [PATCH 1/1] clk: mxl: Fix smatch static checker warning Date: Tue, 25 Oct 2022 19:03:57 +0800 Message-ID: <49e339d4739e4ae4c92b00c1b2918af0755d4122.1666695221.git.rtanwar@maxlinear.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: maxlinear.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Commit 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to regmap based IO") introduced code resulting in below warning issued by the smatch static checker. drivers/clk/x86/clk-lgm.c:441 lgm_cgu_probe() warn: passing zero to 'PTR_ERR' Fix the warning by replacing incorrect IS_ERR_OR_NULL() with IS_ERR(). Fixes: 036177310bac: ("clk: mxl: Switch from direct readl/writel based IO to regmap based IO") Reported-by: Dan Carpenter Signed-off-by: Rahul Tanwar --- drivers/clk/x86/clk-lgm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/x86/clk-lgm.c b/drivers/clk/x86/clk-lgm.c index 4de77b2c750d..f69455dd1c98 100644 --- a/drivers/clk/x86/clk-lgm.c +++ b/drivers/clk/x86/clk-lgm.c @@ -436,7 +436,7 @@ static int lgm_cgu_probe(struct platform_device *pdev) ctx->clk_data.num =3D CLK_NR_CLKS; =20 ctx->membase =3D syscon_node_to_regmap(np); - if (IS_ERR_OR_NULL(ctx->membase)) { + if (IS_ERR(ctx->membase)) { dev_err(dev, "Failed to get clk CGU iomem\n"); return PTR_ERR(ctx->membase); } --=20 2.17.1