From nobody Sat Dec 13 23:04:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3DD7C4332F for ; Thu, 20 Oct 2022 02:14:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231241AbiJTCOf (ORCPT ); Wed, 19 Oct 2022 22:14:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbiJTCOb (ORCPT ); Wed, 19 Oct 2022 22:14:31 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D489128E3D for ; Wed, 19 Oct 2022 19:14:30 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id u8-20020a17090a5e4800b002106dcdd4a0so1976795pji.1 for ; Wed, 19 Oct 2022 19:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I3ANpxjJ572lzCN+d7NeAV+J7e07b8qZ08Zpd9awBZk=; b=LdPZykmSqN6UwxtypWa2H15iI1/ZrD3Z9GGkGlxaAGsFw8K99tPDeUPZMp9OI/wF1T Vzl4hBhXGlRZ2tg0X/KBwo7DqO2/4IRujPeby9Pr4Wti8jcgew3rub+0HelojqiQsfKB 6rKJ4NaeYqeNpgKTickgVynxBqzPWm8iEFoSHb5AtHBPemVCrRfPPI7JMLmfLkd/f5IJ FX/v5Rspo6JlJGO6pC01AVqD3tcvua04jwVXgHnmml7uMzWRZTNyOd5cSSMWVZJNwf3y LJoEoysx5eUy2h1kMJyiBw1PFop2vQdc+S7sHgqbNn7q/aeo+VZet5aan6dB07sf25j7 RdFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I3ANpxjJ572lzCN+d7NeAV+J7e07b8qZ08Zpd9awBZk=; b=W6gtQv/RJPiPQlyAqHu6lbOZ9qXjEf2/hMP5SQX2nmNS8hYI6b57VSC3tcSNMNmpDh XCDbE/Ppm55GVpfD0PxmgF+8DBcprEa14iAbLqlplSKze25BM6SBQg/i8e+kSC1xFswB gHLjLe1JZ4NtaKt8Njjm9zdCECP5GXaBWe4x3bQlWWx0BesAFmy4Mr+CMznhqaIOmXCA 0BwMOQVXjX40XOV31ri2WcfjdWbjwFYx2RXFx4/4Fgn8DAywgRTi4wnPUadA0X8AiO4K F0MesuVY5nge8Gd6s9iVAfA6iYpfyHMn31jIP+8mOz3eJt+EIp9pXOhd/Bw9YFiAjcVu cHTA== X-Gm-Message-State: ACrzQf3CTXxDPHZEd5976OJASWfR/tz2o/3bcmWbq1AjXK0E/TaXqxEJ FNN5A8ZpA0vffcOe8M6Dssbu/Bw1mhRqGA== X-Google-Smtp-Source: AMsMyM4FY7Z/vObWo6W/aKPN+GV/NUPBodquhSEqJnUrucWScnRYdQJjsDQmHxtdRz40InqSLjqLOA== X-Received: by 2002:a17:903:189:b0:183:7473:57f1 with SMTP id z9-20020a170903018900b00183747357f1mr10974663plg.28.1666232069847; Wed, 19 Oct 2022 19:14:29 -0700 (PDT) Received: from localhost.localdomain (192-184-163-51.fiber.dynamic.sonic.net. [192.184.163.51]) by smtp.gmail.com with ESMTPSA id n18-20020aa79852000000b005631af4ece2sm11942936pfq.182.2022.10.19.19.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 19:14:29 -0700 (PDT) From: Emily Peri To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Emily Peri Subject: [PATCH 1/3] staging: rtl8723bs: fix white space warnings Date: Wed, 19 Oct 2022 19:10:51 -0700 Message-Id: <45558673b486808e7978e2e4838c6ce5a2485b8b.1666230736.git.eperi1024@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch warnings in rtw_ioctl_set: 1) Add missing blankline after declaration 2) Replace spaces used for indent with tab 3) Remove space before tab Signed-off-by: Emily Peri --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index 8c11daff2d59..354e61a8f2bd 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -78,6 +78,7 @@ u8 rtw_do_join(struct adapter *padapter) goto exit; } else { int select_ret; + spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); select_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); if (select_ret =3D=3D _SUCCESS) { @@ -311,7 +312,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *p= adapter, if ((*pold_state =3D=3D Ndis802_11Infrastructure) || (*pold_state =3D=3D= Ndis802_11IBSS)) { if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) rtw_indicate_disconnect(padapter); /* will clr Linked_state; before th= is function, we must have checked whether issue dis-assoc_cmd or not */ - } + } =20 *pold_state =3D networktype; =20 @@ -367,7 +368,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter) =20 u8 rtw_set_802_11_bssid_list_scan(struct adapter *padapter, struct ndis_80= 2_11_ssid *pssid, int ssid_max_num) { - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; u8 res =3D true; =20 if (!padapter) { --=20 2.34.1 From nobody Sat Dec 13 23:04:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B0E6C433FE for ; Thu, 20 Oct 2022 02:14:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230324AbiJTCOv (ORCPT ); Wed, 19 Oct 2022 22:14:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbiJTCOq (ORCPT ); Wed, 19 Oct 2022 22:14:46 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6938639127 for ; Wed, 19 Oct 2022 19:14:40 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id g28so18950326pfk.8 for ; Wed, 19 Oct 2022 19:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FOPnQVDm1uAKZaYosB1mytuxMV4Sy6PQL9rIuuTadMA=; b=Tkq2h0XXIBtZb4SLlY3CjWI51sPYHo+Rnbpus2JveFpIvBGXGJFM1YSiUfVEWQuV+X 6XAVgmZujVpxUqNgVAcwxf5VXKfuoJONR5/VixMSUSakRjR1jE3gKDnfC9nLgFPkEvSM //OqJAXlXcrDxBvQ1lrFnadFYbohDN+SjRL6x5cxTTDCKiaY4+si58LGvs4imHLG74io ItiwnVHuk5fiSIkpj5INWTGPhJn/yxeH8KJUFWZot12gqC/AoDazE+7TBsIH2fWoYpGP CAycea1c9+9+0hVnLq0QnY61+frH9ZRqoFN+Brl933Jd6w94bqsbUuOQFPsDMSZbRPmb SuxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FOPnQVDm1uAKZaYosB1mytuxMV4Sy6PQL9rIuuTadMA=; b=RT1uAFc62rxgGHZwMsgCVyJHM/Oe6r6WIaJaP7+XSH9gTxq4ChrkmOjkzWPtY4YHfE Q/AGYHfoqFgw9K9pTolLEBknEubXjWVCV5s107Etiwr39siv52oRCpbr7NNRkCTBLt2u 2D3OTiwQkezHgTtQpdo1WgMKINPZ1VRP6TL2znUIcsR5WehFWn5FTIi3ZYpQ3Pr9CPqA 6BNGhfZzC0T2085F3Syi4EQVH5U411uGcQB8nt+yeOPSl5mSq7qnkT436A3NVgxNyOVQ OpCAYDuRZENB8fPApybBlxX/TvJZOirHiiUs4abD/OtkkHp7mAd3Eao7DHMPKH9ugP7W mFyw== X-Gm-Message-State: ACrzQf0NNEbJAaF7m6q/48gUUiVWcTRR+KCYGnPP0/wo3OlVDNrvfwfV rCPmVwwnw5g+mxNan7Mj9hc2UJwEeNO5ZA== X-Google-Smtp-Source: AMsMyM5Dr2TlH0gGTxnHEEsVWzmYNvyXTdzJ3oQXUX6XiAwO4DtVcVZ8C43jQNliO9NUCUYiJ47wnQ== X-Received: by 2002:a63:2b4b:0:b0:440:2963:5863 with SMTP id r72-20020a632b4b000000b0044029635863mr9568549pgr.28.1666232079822; Wed, 19 Oct 2022 19:14:39 -0700 (PDT) Received: from localhost.localdomain (192-184-163-51.fiber.dynamic.sonic.net. [192.184.163.51]) by smtp.gmail.com with ESMTPSA id n18-20020aa79852000000b005631af4ece2sm11942936pfq.182.2022.10.19.19.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 19:14:39 -0700 (PDT) From: Emily Peri To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Emily Peri Subject: [PATCH 2/3] staging: rtl8723bs: align block comment stars Date: Wed, 19 Oct 2022 19:10:52 -0700 Message-Id: <3d9738edd0992b72bf8fc8a05706a490772b5317.1666230736.git.eperi1024@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Align '*' on each line of block comment in rtw_ioctl_set. Issue found by checkpatch. Signed-off-by: Emily Peri --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index 354e61a8f2bd..ac957035bf1a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -463,11 +463,11 @@ u8 rtw_set_802_11_add_wep(struct adapter *padapter, s= truct ndis_802_11_wep *wep) } =20 /* -* rtw_get_cur_max_rate - -* @adapter: pointer to struct adapter structure -* -* Return 0 or 100Kbps -*/ + * rtw_get_cur_max_rate - + * @adapter: pointer to struct adapter structure + * + * Return 0 or 100Kbps + */ u16 rtw_get_cur_max_rate(struct adapter *adapter) { int i =3D 0; --=20 2.34.1 From nobody Sat Dec 13 23:04:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F488C433FE for ; Thu, 20 Oct 2022 02:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231509AbiJTCOz (ORCPT ); Wed, 19 Oct 2022 22:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbiJTCOr (ORCPT ); Wed, 19 Oct 2022 22:14:47 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC9F75AC4B for ; Wed, 19 Oct 2022 19:14:44 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id l6so17938121pgu.7 for ; Wed, 19 Oct 2022 19:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5cxlbEVDeF4plEeh62JkmWpXJNLBpkyMDDpLc8c5MkU=; b=i/ZHwd6vtO8tnDAAAmZSyChgftK9wsSwRMKMhPJZoaiURvJ8gEdumCl6AOR1lR5ZKf KiSg3hanIqMlz291v/w0umgZzgIlR2uzUcVqDvwEixzgGYYzFsSMdrIaIuQlV6Rw6F53 xPstk3O+7bTDGXwmtBKvBDzmThnbs3TbXKwf927+rJ53uQ2sN/9sRQUSqFF2vlWe+TW0 IDpScgosPWp7njzSoz9BBlkhTkXfAIyb7j0ZGWvQir9/DCt8HA9tw0YwQ958YU3pyPk+ x00xiEredWYJvKcyy8BxPhMoxSrwqcywKSGxXYxgemgV3tJp8+lcglLt5p1gphgCPvMM Rldw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5cxlbEVDeF4plEeh62JkmWpXJNLBpkyMDDpLc8c5MkU=; b=x+OZ7E0piVGC7n3949j0yuM4Q3BHCgGOVyoHooH2TZsqZjBRprLZx0W/hz6ETCmFAq om+kJhDEIpSaYI603HNmXA2E0e5UbMk793RNZJ3mAetduYDiIZKXZU6eagm5zQv11IUr FS6ngxyTX3B0d/h6lbALwrZqzV2QC1GQo+LNYVr0tZnhIpuKyQQo86hmvLyVbPDZ8wwS Pk3uWJ+ru4eQwm0IdVeKVEMHrtMe4uqJW82qFJMc4RTSp+dp63Og9RDOUj8R/N1059Sd UvUbFfh/UJci5wH5kgvzq4kWnbqb5qA10tQ2KRVUTQ/ASJbQqAXiyTHcQmJXgBMi0UZD kNxg== X-Gm-Message-State: ACrzQf3eVr6VMQ0fJ2zkCwi7tUXFA9eDyxH222HNnkSiBMntny72TCf+ fHFppof6+iD6Gy8ArAc3bfU= X-Google-Smtp-Source: AMsMyM6w3Kn9m+GCRlAqC2fbXBLFG9tRtOfO2XMsER+YC571XMz1GzczedPWGtvXX0+kFvqmMtE5Qw== X-Received: by 2002:a63:2c8:0:b0:46e:9da9:8083 with SMTP id 191-20020a6302c8000000b0046e9da98083mr456343pgc.186.1666232083946; Wed, 19 Oct 2022 19:14:43 -0700 (PDT) Received: from localhost.localdomain (192-184-163-51.fiber.dynamic.sonic.net. [192.184.163.51]) by smtp.gmail.com with ESMTPSA id n18-20020aa79852000000b005631af4ece2sm11942936pfq.182.2022.10.19.19.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 19:14:43 -0700 (PDT) From: Emily Peri To: gregkh@linuxfoundation.org, outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Emily Peri Subject: [PATCH 3/3] staging: rtl8723bs: remove unnecessary parenthesis Date: Wed, 19 Oct 2022 19:10:53 -0700 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove extra parenthesis in conditional statement in rtw_ioctl_set. Issue found by checkpatch. Signed-off-by: Emily Peri --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index ac957035bf1a..32194dabd587 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -160,7 +160,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct= ndis_802_11_ssid *ssid) if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) =3D=3D t= rue) { if ((pmlmepriv->assoc_ssid.ssid_length =3D=3D ssid->ssid_length) && (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length)= )) { - if ((check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D false)) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D false) { if (rtw_is_same_ibss(padapter, pnetwork) =3D=3D false) { /* if in WIFI_ADHOC_MASTER_STATE | WIFI_ADHOC_STATE, create bss or re= join again */ rtw_disassoc_cmd(padapter, 0, true); --=20 2.34.1