From nobody Wed Apr 8 12:49:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF79DC6FA86 for ; Fri, 9 Sep 2022 12:21:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbiIIMVH (ORCPT ); Fri, 9 Sep 2022 08:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbiIIMUm (ORCPT ); Fri, 9 Sep 2022 08:20:42 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB5978587 for ; Fri, 9 Sep 2022 05:18:35 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id r17so3514166ejy.9 for ; Fri, 09 Sep 2022 05:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=NM+lxSqjM8oFCbQnG31XvkQ4+xfR81iJOrwKlVfJyok=; b=WejafAQQbqcpEnzAtu/PpyOP7fmVQf6gG2x6M2S5Vm7Rg8NWLbgGQ5RpkHCQxTHi/m XW85pwdMq8KL2wN2kXynuASuLaPlphzRYSmBlEdwBWZAov0sqMhSiBdBINGTWmKVf5oE jQzPXuSJQSkar5SSa5QB2I7o7WFWWJyHyux6NKGKvXGK0YPK6ADoyS5ryOqX9jPuEuzt //RIfavaV7baPOK3aYiVw9O+s9Y8p4Lv14IXpOaj42BzbEWvIirNnXoXsyKUBGbViCda 5s4S9JcGF5Yi4+r8xuBgOKgnuL5LLHpqGPigWXv/5o7quVKeWIHdmqtJTDaiuscpaBTD bfTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=NM+lxSqjM8oFCbQnG31XvkQ4+xfR81iJOrwKlVfJyok=; b=tKfU9+myTT7hHVyFrqpVgjx4b6+MfSqp7JdW0o/SjV6xWKzeKBQpY3I0gffb3Dxhes IF8M86hXsuJWBPZD8Y6OG+vWKlyWyP35GO5gxyt5cmZpawUUjq9Mgp2vP3lVjZx/dWgQ 5y7yo/vmVjPxDm85g7X+cRcJkZZoJEzdUfgr4zBF2oS4vZVZUIpjBj1jLTRp5WTVxbBp IZYAUeVwHDBK9loJJ8e2xJ/Zq0htafIPwe8Fdkiqu1jbcoa7H5dv8g151HenumpYYBbR 7ZsOz3FJiMBNhiE0z3RjvxAwNbGi1F3k3jRggHgLHHD0KTPlUK13fa12anV4Ei6M/A9n Jzmw== X-Gm-Message-State: ACgBeo2VlzCb8z5WO+nkAjCczur7X0gnC/+OKcvy/LBfti37plucOyFZ BvXsfYZDaRcU/cuQVwqOIOk= X-Google-Smtp-Source: AA6agR4AHMKVaBWkWEN5wVUo9hiOeUinsMUur891/drAYP2F99sCJd9oJx2G+nFVAs+Re4srAIay6g== X-Received: by 2002:a17:907:6e8a:b0:779:9e32:8dff with SMTP id sh10-20020a1709076e8a00b007799e328dffmr2532629ejc.20.1662725913877; Fri, 09 Sep 2022 05:18:33 -0700 (PDT) Received: from localhost.localdomain (wlan-244090.nbw.tue.nl. [131.155.244.90]) by smtp.gmail.com with ESMTPSA id p17-20020a170906785100b0073bdb2f6f28sm167143ejm.217.2022.09.09.05.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 05:18:33 -0700 (PDT) From: Nam Cao To: forest@alittletooquiet.net, gregkh@linuxfoundation.org Cc: namcaov@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v3 1/2] staging: vt6655: remove unnecessary volatile qualifier Date: Fri, 9 Sep 2022 14:17:55 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove volatile qualifier for the member rd0 of struct vnt_rx_desc, because there is no reason it must be volatile. Signed-off-by: Nam Cao Tested-by: Philipp Hortmann --- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655/desc.h index 17a40c53b8ff..3f0f287b1693 100644 --- a/drivers/staging/vt6655/desc.h +++ b/drivers/staging/vt6655/desc.h @@ -182,7 +182,7 @@ struct vnt_rdes1 { =20 /* Rx descriptor*/ struct vnt_rx_desc { - volatile struct vnt_rdes0 rd0; + struct vnt_rdes0 rd0; volatile struct vnt_rdes1 rd1; volatile __le32 buff_addr; volatile __le32 next_desc; --=20 2.25.1 From nobody Wed Apr 8 12:49:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88992ECAAD3 for ; Fri, 9 Sep 2022 12:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231303AbiIIMVN (ORCPT ); Fri, 9 Sep 2022 08:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231668AbiIIMUm (ORCPT ); Fri, 9 Sep 2022 08:20:42 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2F763AB02 for ; Fri, 9 Sep 2022 05:18:36 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id m1so2214520edb.7 for ; Fri, 09 Sep 2022 05:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Tcj9zdEuhhwwc+19W7KyuMTeuqCemH8yB/Q5e9nu8aA=; b=QJxqTxB//D87aPuiZfpZ5VujODmr6Zn7XTUdwOc9fB7P++LBDU6mZ5MyPB3filboiV 3QdtP/VQuoOT6v1Amv1a4hZ1jKAfJlN/9HqbXqmHT41NJpE30/3fubB7OH+lNLRM4z2B nQzKDW23vFo83M4VlpOExEGMPpLjeefE0pGi0G77AGb5GnW2WkMbFh6+TXebQ9ugKTvi NWhYU1FnmKwrFWOPZW7GNwol2T0ILIeBQsEDYMGFxMxZ6wPT0soA/hjuwzBNgCOztft4 TqZ1qaaDz72BmobxjK+vp0+LaU/FSRf5OZVLYlCpSMiXZ0fLzWs14bctFAP8EU9TzfW+ n0sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Tcj9zdEuhhwwc+19W7KyuMTeuqCemH8yB/Q5e9nu8aA=; b=lo93TmJejOWRF/0q/Ha8H2pCZUajdpb2ulb4DxI1KIk0ueVke4rpIVFkcnxMUVpRYo oT26HIdAapaWwSxSGX4I39pOtgKbjrp29FJgpNXtX5Qaa73HQrqi2yN4BWajEqj5QvP2 K1lSJJSQvlf/NTCb/SrSHKbxEOmiN/fhXjrjSLM0m+a/JafOR1AuL8bU2Me3pDwO3ft1 t7o1skz+3ZK+i8MfRG2Tsf+mF2P1iQeWUDpBAev9JSDnbr2chzpgkMNyX20LAqc2tvij plNZJkAQEuM96b5t3SbBsKK9dPjzoaPoN1CFkXVoy77SQnGx5CauXsLhilLPLW14Ugxr ooJA== X-Gm-Message-State: ACgBeo04k3Aa0Z0Lbc8U7WbcBH9l54VNmYpYj/5zXI2Wl/01fBEJKUk9 PACZhyde2OazQKX7vP6TAIrdALU+Zms= X-Google-Smtp-Source: AA6agR7tG4OqK0nNY0mWWPRkvmCx6vmHSl4Auf4Q6D2X/J23GoevX7VhHbkYiUTqyfiLEpEzMQzThA== X-Received: by 2002:a05:6402:1a4d:b0:44e:221d:d1dd with SMTP id bf13-20020a0564021a4d00b0044e221dd1ddmr11469097edb.267.1662725914920; Fri, 09 Sep 2022 05:18:34 -0700 (PDT) Received: from localhost.localdomain (wlan-244090.nbw.tue.nl. [131.155.244.90]) by smtp.gmail.com with ESMTPSA id p17-20020a170906785100b0073bdb2f6f28sm167143ejm.217.2022.09.09.05.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 05:18:34 -0700 (PDT) From: Nam Cao To: forest@alittletooquiet.net, gregkh@linuxfoundation.org Cc: namcaov@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v3 2/2] staging: vt6655: use memset to make code clearer Date: Fri, 9 Sep 2022 14:17:56 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" A line of code sets the entire struct vnt_rdes0 to zero by treating it as unsigned int. This works because sizeof(unsigned int) is equal to sizeof(struct vnt_rdes0) (4 bytes). However it is not obvious what this code is doing. Re-write this using memset to make the code clearer. Signed-off-by: Nam Cao Tested-by: Philipp Hortmann --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index 3397c78b975a..34a65a92d602 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -867,7 +867,7 @@ static bool device_alloc_rx_buf(struct vnt_private *pri= v, return false; } =20 - *((unsigned int *)&rd->rd0) =3D 0; /* FIX cast */ + memset(&rd->rd0, 0, sizeof(rd->rd0)); =20 rd->rd0.res_count =3D cpu_to_le16(priv->rx_buf_sz); rd->rd0.owner =3D OWNED_BY_NIC; --=20 2.25.1