From nobody Sat Apr 11 19:47:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 584ABC19F2A for ; Sun, 7 Aug 2022 18:13:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234761AbiHGSNm (ORCPT ); Sun, 7 Aug 2022 14:13:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232878AbiHGSNh (ORCPT ); Sun, 7 Aug 2022 14:13:37 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B25B26558 for ; Sun, 7 Aug 2022 11:13:35 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id j8so12839566ejx.9 for ; Sun, 07 Aug 2022 11:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc; bh=AN1zVwKUXEz2V3Gkaa20oR+ncHTmapAurqeiNEnFlvE=; b=psqh4H1CDUWrtpWNIaieHeb4g77hr/WG3ZPjvz/nmEuWgZ7+zCtqiXOTu98qQeeW68 8F7ay7GI+/UqaOyqucKP3J9dRnM4/g+CeogJj+EOcAXRKFirCS0gSTgpRglXPy/E97sV kcajyrljmxc/IrhCKl+N9qMP99ImnE70YVKr3IKYqKf8x3NSyjPh2amOtYSYDk5g9Fut sfQB7i5yukmLkBwvWb25MBvzLsz6Z5N1TO9KFAKLBnSDZsSGHidP/kPMuF6AJfq8svdr c8/MLhFbIm6m87be3MvgW2hdJnuBErEBczQ10xwWVmDoOa3Jwo++WAifjUkP5nl7Vqo1 hl4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc; bh=AN1zVwKUXEz2V3Gkaa20oR+ncHTmapAurqeiNEnFlvE=; b=GYy9QNVkWZE6Cu14+N549l69zseQd75qdv+PWWH6BlTf/L95YDiISWOjVo0BuNnBrh SGebUpLcfx0YNY7FyeJ+3hWVtsh8FQnnKqXa9PpH56KpnsnnLpdhzO7u027wL1K4j7EZ 3H+hI0Wz2PQ9+jX99bD/wMXGSJRehdwAEN6AOri60LHoFyjKKO82M3bFmKSK2ZruXVYz NC3rc6OSQBIgEchf+ovDNM43HvtOQn75H60TwnG9z6XJbOU+dbQGwBD8NUKAeV98I9x1 pMR2KtklmtWN8x8P8CvqwAnYCgyj3lisTRxF8FOilL0joqy1VsHLiwDtojCyZKd0XlhZ aKaA== X-Gm-Message-State: ACgBeo1jADJ8TVBf2V4i+agTn1x/i9+lbJU01dnjj9SG2LsycPBjjuYV MFbLMFUb2nHaY6EpO7NgI2D1MFSs3mc= X-Google-Smtp-Source: AA6agR7JjLX0OtZogUv+gm0tyk8HgnyPc/CVtzUJs04tXoMd7OhARgwKPDQLbnboZcpjFJfIjt5bAg== X-Received: by 2002:a17:907:720a:b0:72b:549e:305a with SMTP id dr10-20020a170907720a00b0072b549e305amr11111101ejc.691.1659896015249; Sun, 07 Aug 2022 11:13:35 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id g18-20020a17090604d200b0072ee7b51d9asm4082722eja.39.2022.08.07.11.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 11:13:34 -0700 (PDT) Date: Sun, 7 Aug 2022 20:13:33 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/6] staging: vt6655: Convert macro MACvEnableProtectMD to function Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert macro to static function. Multiline macros are not liked by kernel community. Rename variable dwOrgValue to reg_value to avoid CamelCase which is not accepted by checkpatch.pl. Change variable declaration to u32 as this improves readability. Signed-off-by: Philipp Hortmann --- V1 -> V2: No changes --- drivers/staging/vt6655/device_main.c | 9 +++++++++ drivers/staging/vt6655/mac.h | 8 -------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index 8db655742bd4..ab6456fc2b3f 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -216,6 +216,15 @@ static void vt6655_mac_dma_ctl(void __iomem *iobase, u= 8 reg_index) iowrite32(DMACTL_RUN, iobase + reg_index); } =20 +static void MACvEnableProtectMD(void __iomem *iobase) +{ + u32 reg_value; + + reg_value =3D ioread32(iobase + MAC_REG_ENCFG); + reg_value =3D reg_value | ENCFG_PROTECTMD; + iowrite32(reg_value, iobase + MAC_REG_ENCFG); +} + /* * Initialisation of MAC & BBP registers */ diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h index 467c599a3289..84d203c56b1f 100644 --- a/drivers/staging/vt6655/mac.h +++ b/drivers/staging/vt6655/mac.h @@ -543,14 +543,6 @@ #define MACvSelectPage1(iobase) \ iowrite8(1, iobase + MAC_REG_PAGE1SEL) =20 -#define MACvEnableProtectMD(iobase) \ -do { \ - unsigned long dwOrgValue; \ - dwOrgValue =3D ioread32(iobase + MAC_REG_ENCFG); \ - dwOrgValue =3D dwOrgValue | ENCFG_PROTECTMD; \ - iowrite32((u32)dwOrgValue, iobase + MAC_REG_ENCFG); \ -} while (0) - #define MACvDisableProtectMD(iobase) \ do { \ unsigned long dwOrgValue; \ --=20 2.37.1 From nobody Sat Apr 11 19:47:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BF7C19F2A for ; Sun, 7 Aug 2022 18:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235035AbiHGSNx (ORCPT ); Sun, 7 Aug 2022 14:13:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234777AbiHGSNm (ORCPT ); Sun, 7 Aug 2022 14:13:42 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DD6E65F3 for ; Sun, 7 Aug 2022 11:13:41 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id m4so12900021ejr.3 for ; Sun, 07 Aug 2022 11:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc; bh=zD17J0eH2wPYwZr+9CUo9VuUmFGElTpvvgk6zTTTY90=; b=ZztM717a1mtjobKwFBK8U7wqJxMgEkltelF826ecqjXXWaGseSHNt0g8ztaSXMmX8x y1fLdu47CanmPT4NNAEYwSfVblRpWlZNsYef7x4+nI91wuIItOKkdxnov90ntvrdNuXU 97m/e7HXAvwsmm2fKGLxHrZF8t0dxrBpQlXZhsSqa1cvaCtalCqwuveCzcC9L2HTJB0+ IbsQLP0khV8XSwykp8q04EO353l38aQ2FqNVeARAuHDWIhWpNpvw2nnIu4Xey8GYPRAW mWbAnFNXQaxS3NwD4GpaNeCxd68fh5NKkgNwqTJbjZsMcJKUefBFwkylprvd/ZBXH5CW /V7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc; bh=zD17J0eH2wPYwZr+9CUo9VuUmFGElTpvvgk6zTTTY90=; b=KNcF8ydcv+QQhce8FxBLF4KnZdcDVSrZL7+o40F3a0CnNrX1Vr6GUcvBe3jDHQ4a4J JVcB/38wQlPVCTjKVhJmDczXpugVsU+P7Hx1f43s5RvbnMNlBPDuzExOczo994zLKxH7 VHaMAyrge8GFM0sXxiC7r2a/6ARuki1VBKEm5DUyh1mJ06M0CdtRTBGnwTq13AB5Evel A8TKkWb9E5eH5AISaq/XpX9+PleyX2VVC+wX9i/elfLz/G2hKTf4zHtqqsq+KB9IjilI NdY7ipwnfWErHyrT7FGgUSzWdiW3Wzsw8kvER06PIZi+KADRJ3t2Bj06T+INlIIYyAzk uTUw== X-Gm-Message-State: ACgBeo11UbROhJv0UDRjeCAdT3eE4nNLExyuRzVwTeBU5tdofmbz2hCc cnMs9kc4skpbag3PHosq9VQ= X-Google-Smtp-Source: AA6agR6Xa3KQwBv71sNy/xYGmyk4Ok+a6lmfLPRbZ/59pl81W9v6lO0IN7Eaqne1ge7LY3x3IY5X0A== X-Received: by 2002:a17:906:8a4e:b0:730:9fcd:d988 with SMTP id gx14-20020a1709068a4e00b007309fcdd988mr11498063ejc.636.1659896019873; Sun, 07 Aug 2022 11:13:39 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id q9-20020a170906540900b0073073ce488asm4021819ejo.45.2022.08.07.11.13.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 11:13:39 -0700 (PDT) Date: Sun, 7 Aug 2022 20:13:37 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/6] staging: vt6655: Create one function for two macros Message-ID: <78883f42b2df258dbf821d7f7515a82932a157f1.1659892670.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create function vt6655_mac_set_bits with two parameters to cover functionality of two macros. Signed-off-by: Philipp Hortmann --- V1 -> V2: Change function to cover only the set bits part and omitted the clear bits part Changed title from "...four..." to "...two..." Changed description accordingly --- drivers/staging/vt6655/device_main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index ab6456fc2b3f..dc50bff4403f 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -216,15 +216,20 @@ static void vt6655_mac_dma_ctl(void __iomem *iobase, = u8 reg_index) iowrite32(DMACTL_RUN, iobase + reg_index); } =20 -static void MACvEnableProtectMD(void __iomem *iobase) +static void vt6655_mac_set_bits(void __iomem *iobase, u32 mask) { u32 reg_value; =20 reg_value =3D ioread32(iobase + MAC_REG_ENCFG); - reg_value =3D reg_value | ENCFG_PROTECTMD; + reg_value =3D reg_value | mask; iowrite32(reg_value, iobase + MAC_REG_ENCFG); } =20 +static void MACvEnableProtectMD(void __iomem *iobase) +{ + vt6655_mac_set_bits(iobase, ENCFG_PROTECTMD); +} + /* * Initialisation of MAC & BBP registers */ --=20 2.37.1 From nobody Sat Apr 11 19:47:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE5CC19F2A for ; Sun, 7 Aug 2022 18:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234574AbiHGSOD (ORCPT ); Sun, 7 Aug 2022 14:14:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234959AbiHGSNq (ORCPT ); Sun, 7 Aug 2022 14:13:46 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22D3965FD for ; Sun, 7 Aug 2022 11:13:45 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id j8so12839965ejx.9 for ; Sun, 07 Aug 2022 11:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc; bh=+FsM9BSLLhQlcBk3zJRjR04gJAe6i1I5jpWIJQymm4Q=; b=G9lNccKYXi936800LuvsrO6U9gwlyjprNZJqVFunrUPoeNUJeaCWgRdxklKtIPcIBa 7YNaCqWFOLf2XTAU5tQU/MwvLGgIFnFHLEcdaBSBiS0W3feuCeiWT2xq7+0FEAi7phZy uIrdY0N3iVFeok6QtvYVp/5Vc2YY85gS4F/RSsoE35EQtpsQslCZt3SgeourenCRjUw6 xvYW4xHflB30QVefC6n/xz6whJbBzINPn/mlQKcSedv0Yi7ygxACQ7UPBcutLzt02TvR 5c74TYdL5focUaDU8hqNBkXEEr/epiLkeuzwQUT41SCNilwuwW4LMkI3RsSxboCA17+C idTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc; bh=+FsM9BSLLhQlcBk3zJRjR04gJAe6i1I5jpWIJQymm4Q=; b=KoZuDvjSdHhViDfQZcdvG6yybkj7TJDrZEAJgaeyjXetu9WjXmONbXIU6aHOrPodD6 uRxdXJG2Ow4c7DxOLWv0TooszhHuYYzaOQlkp8mjjjopk047wPalvLOaCDw8iECnhzkI IMxExJXcpCrIcEevN1/2OJvij23CEbEu24vgdlNNhLQg9XSFEQ8bd3gfO8O9xSMrMGRz Ros8sp2290S5TUNviU+mAk2/pIHNlkyveeiL+ZKDXhlxUWbAC5HwzcCpYEXEU46ZRvZZ /WIGUTL74hIifOB4fy9fzV0rwWlcshkY15A03oLPvdm5ezehxfUG8JzAds8DYNE/+wH4 pfKw== X-Gm-Message-State: ACgBeo0lHPtYGTiVAmQ+ltlD/RuJf7z1VSkdkN+KCXOM+i9W7/wRFaxp Biz49jRlJIPCp4/9BuzOENobaEfenT4= X-Google-Smtp-Source: AA6agR5nJtgs4H6oxgLQPmN30x/Pt6UcZezLdIKnEceF7jwGWJcrpU/O6N181CjwcMsHekov3oaHbQ== X-Received: by 2002:a17:906:9b16:b0:730:d5f4:d46e with SMTP id eo22-20020a1709069b1600b00730d5f4d46emr11412955ejc.701.1659896024608; Sun, 07 Aug 2022 11:13:44 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id 9-20020a170906200900b0073100dfa7b5sm3083158ejo.33.2022.08.07.11.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 11:13:44 -0700 (PDT) Date: Sun, 7 Aug 2022 20:13:42 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/6] staging: vt6655: Rename function MACvEnableProtectMD Message-ID: <927d7c6e7c9d5214e4faeca886efd2696b2abc31.1659892670.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename MACvEnableProtectMD function to vt6655_mac_en_protect_md to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Signed-off-by: Philipp Hortmann --- V1 -> V2: No changes --- drivers/staging/vt6655/device_main.c | 4 ++-- drivers/staging/vt6655/mac.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index dc50bff4403f..ccfd4bfa0502 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -225,7 +225,7 @@ static void vt6655_mac_set_bits(void __iomem *iobase, u= 32 mask) iowrite32(reg_value, iobase + MAC_REG_ENCFG); } =20 -static void MACvEnableProtectMD(void __iomem *iobase) +static void vt6655_mac_en_protect_md(void __iomem *iobase) { vt6655_mac_set_bits(iobase, ENCFG_PROTECTMD); } @@ -1475,7 +1475,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw = *hw, =20 if (changed & BSS_CHANGED_ERP_CTS_PROT) { if (conf->use_cts_prot) - MACvEnableProtectMD(priv->port_offset); + vt6655_mac_en_protect_md(priv->port_offset); else MACvDisableProtectMD(priv->port_offset); } diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h index 84d203c56b1f..4de9974e6c69 100644 --- a/drivers/staging/vt6655/mac.h +++ b/drivers/staging/vt6655/mac.h @@ -12,7 +12,7 @@ * Revision History: * 07-01-2003 Bryan YC Fan: Re-write codes to support VT3253 spec. * 08-25-2003 Kyle Hsu: Porting MAC functions from sim53. - * 09-03-2003 Bryan YC Fan: Add MACvDisableProtectMD & MACvEnablePro= tectMD + * 09-03-2003 Bryan YC Fan: Add MACvDisableProtectMD & vt6655_mac_en= _protect_md */ =20 #ifndef __MAC_H__ --=20 2.37.1 From nobody Sat Apr 11 19:47:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C560FC19F2A for ; Sun, 7 Aug 2022 18:14:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234975AbiHGSOH (ORCPT ); Sun, 7 Aug 2022 14:14:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235069AbiHGSOA (ORCPT ); Sun, 7 Aug 2022 14:14:00 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3416365F3 for ; Sun, 7 Aug 2022 11:13:50 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id x21so8960695edd.3 for ; Sun, 07 Aug 2022 11:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc; bh=4L2Ey6uuwyz5FiRHKjwFd1Rwtr7ClW4F9v5PIxtOSOs=; b=WilrlL87tkAOk31c1/a6fXFIim59k8jArfK9u3y9MiBAgtrydTFPRKIzOeY/dlKBX6 oxO8hOBp2eSJv/ho2SQvm0yxSNjy1WLraeC2G9botxKL0u4q+s7+gGdycpb0Mie4Zmh0 swqLSFetLB5XhbdufQL4b/oX4H29ZIU4WgbhJNe9Vng+H9A2eRYpggplb+/53gjWRZCF 2+V78a8LFZ9zYoyq0z7v6K++JMQPOW3FWno+oKvg1vnka2L4aXkl5phAycNZ+F3HgbBi 6m7lTYNM5Gt8zPq3/O4k1Kt317jGWmlLqmIlKVkx88OenRUcG1zfuSoRqExEKK5HFAK6 iclA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc; bh=4L2Ey6uuwyz5FiRHKjwFd1Rwtr7ClW4F9v5PIxtOSOs=; b=Vit8ioxtz29DcmQcfsPBfVYI46QAV4RuKpKBA0Xz8VeObitxomwhqIMJ+3ONUN2ufH wBYyGlUoWXRSlBPPomEn1h6yE/GLpjN37p7zdpLpeO1PXL2zO46/G8PXgBS7KVLprGSE RpIpioHroLLdLK03Z+sbfTtX2EI3NMgIHuObHVqodT9n9Rw0/mpONMyi1X1unVVFZnLf vRgfFi/bvBHuuxo+hsoZ+c5x2msJTtRnLiv/xTikK/UkTAo0StPeJY7JgLYVfsXpzyx4 sBgHH4KUNMy5uE+uE6BsujMm6OyFNUxK6epi4uU9Ay5Syq9NSzOBPWF4RXeCr72zo89E AHkA== X-Gm-Message-State: ACgBeo2KJeKzrDLlR8eZM2mY3TfhW6QU5gIZ9xAVwdg0K49rWvdEznxf oFjgHrYAVOg02jO/tf5xOuLK/+raeQg= X-Google-Smtp-Source: AA6agR5dkJAQKSJ3H1Ivo2Opn7Qvsx44GLA2MeeB6nT/q88o6cX2sB0ne4Tn4EQLxfHAfKR45ClEwQ== X-Received: by 2002:a05:6402:b85:b0:43c:f8e8:96ba with SMTP id cf5-20020a0564020b8500b0043cf8e896bamr15497163edb.183.1659896028829; Sun, 07 Aug 2022 11:13:48 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id v18-20020a1709061dd200b0072ecef772a7sm3989417ejh.160.2022.08.07.11.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 11:13:48 -0700 (PDT) Date: Sun, 7 Aug 2022 20:13:46 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/6] staging: vt6655: Convert macro MACvDisableProtectMD Message-ID: <4cb2b8025adde2a3addfd8e954faf18a0a8032aa.1659892670.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert macro MACvDisableProtectMD to static function which calls the new common static function vt6655_mac_clear_bits. This saves codelines and multiline macros are not liked by kernel community. Function name is also changed to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Signed-off-by: Philipp Hortmann --- V1 -> V2: Added new function vt6655_mac_clear_bits Updated description --- drivers/staging/vt6655/device_main.c | 16 +++++++++++++++- drivers/staging/vt6655/mac.h | 10 +--------- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index ccfd4bfa0502..96945fb8d536 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -225,11 +225,25 @@ static void vt6655_mac_set_bits(void __iomem *iobase,= u32 mask) iowrite32(reg_value, iobase + MAC_REG_ENCFG); } =20 +static void vt6655_mac_clear_bits(void __iomem *iobase, u32 mask) +{ + u32 reg_value; + + reg_value =3D ioread32(iobase + MAC_REG_ENCFG); + reg_value =3D reg_value & ~mask; + iowrite32(reg_value, iobase + MAC_REG_ENCFG); +} + static void vt6655_mac_en_protect_md(void __iomem *iobase) { vt6655_mac_set_bits(iobase, ENCFG_PROTECTMD); } =20 +static void vt6655_mac_dis_protect_md(void __iomem *iobase) +{ + vt6655_mac_clear_bits(iobase, ENCFG_PROTECTMD); +} + /* * Initialisation of MAC & BBP registers */ @@ -1477,7 +1491,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw = *hw, if (conf->use_cts_prot) vt6655_mac_en_protect_md(priv->port_offset); else - MACvDisableProtectMD(priv->port_offset); + vt6655_mac_dis_protect_md(priv->port_offset); } =20 if (changed & BSS_CHANGED_ERP_SLOT) { diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h index 4de9974e6c69..a7d6254fded0 100644 --- a/drivers/staging/vt6655/mac.h +++ b/drivers/staging/vt6655/mac.h @@ -12,7 +12,7 @@ * Revision History: * 07-01-2003 Bryan YC Fan: Re-write codes to support VT3253 spec. * 08-25-2003 Kyle Hsu: Porting MAC functions from sim53. - * 09-03-2003 Bryan YC Fan: Add MACvDisableProtectMD & vt6655_mac_en= _protect_md + * 09-03-2003 Bryan YC Fan: Add vt6655_mac_dis_protect_md & vt6655_m= ac_en_protect_md */ =20 #ifndef __MAC_H__ @@ -543,14 +543,6 @@ #define MACvSelectPage1(iobase) \ iowrite8(1, iobase + MAC_REG_PAGE1SEL) =20 -#define MACvDisableProtectMD(iobase) \ -do { \ - unsigned long dwOrgValue; \ - dwOrgValue =3D ioread32(iobase + MAC_REG_ENCFG); \ - dwOrgValue =3D dwOrgValue & ~ENCFG_PROTECTMD; \ - iowrite32((u32)dwOrgValue, iobase + MAC_REG_ENCFG); \ -} while (0) - #define MACvEnableBarkerPreambleMd(iobase) \ do { \ unsigned long dwOrgValue; \ --=20 2.37.1 From nobody Sat Apr 11 19:47:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB23EC19F2A for ; Sun, 7 Aug 2022 18:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235563AbiHGSOR (ORCPT ); Sun, 7 Aug 2022 14:14:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234097AbiHGSOC (ORCPT ); Sun, 7 Aug 2022 14:14:02 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C520A9583 for ; Sun, 7 Aug 2022 11:13:54 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id f22so8925832edc.7 for ; Sun, 07 Aug 2022 11:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc; bh=VP/KKkIUNQwmK/Lbxdjw2+ts47zQFWqZhW4ZLZ9vpOc=; b=JkD41WlYO/1YezLjNDCVBFgaskAYKk3CyHrN/I0dDy7W00OfgfLekpYiKFLhkuKmod D7JqaZV20QKzGyte258FcETHbgz79KxFU8YotPYL8UdTCOtE6mC4FwGMS1Cw4PY8hxpu DpKYWdfBxFbgJojsBM6RZ4slxncdSh9ZSOlgoHsdbzFmk+Hgw89vjZRDnVjcoARiuKL7 dTD/GE34LQpNKUC5YSoPI/boBBbLUrug6HpkSCTT+vt1J4+zalziIRkLcSTbZyN15z3q o184F3sbe5bPcYpH45a5r4jnNhVJBWbVdN17h7ZYIjWTh0+h0vGXQH3rMKFp5k85zNqZ fCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc; bh=VP/KKkIUNQwmK/Lbxdjw2+ts47zQFWqZhW4ZLZ9vpOc=; b=ZnM9ELsQNs/Yan4T7r4Qbe7S11FJeh2dFEdDmoHVHmilN9AgWa5yxr9Fi6Y9UI4ouV G5TCpOHs88SSJd5icXZkp9/S2SWE9mpRkm8tITF1Kqqip0vIDevJrh1JY7qVlSN9WDxk ZuW6EO+95vhyNp4Vy4XNUpnA8+7jce6Cr9sl5K2V8+iY8LWu55tECOkQzsKu2Lhlj1br XAdCck1igIx8q7/8BAW2cl5EJfhbocBzJfnmL+O8RUqGDcQ+k2kI6Pq0s7gRcRlcvPV6 geCzlANbPREGS04iuN6xiCxirgnmcJN20KNaFb7l2iwXCCBbaDK6BldTFx9YvqkdYIvE aepw== X-Gm-Message-State: ACgBeo0IIF0iNaju8mGbzwtROS49LDOb3tF1s4XPHnCZG5monbk/E1ZG VYMnPgXB9Id6o9t7KRBkdIM= X-Google-Smtp-Source: AA6agR5NLfEBuWbhHw9Au5cYdfb0rpy5Ezpjl8QLqICxFOW3L6xzGfIiLo2RHCvjN6d2+p2CT6YC5w== X-Received: by 2002:a05:6402:331d:b0:43d:9e2e:6966 with SMTP id e29-20020a056402331d00b0043d9e2e6966mr15470087eda.214.1659896033293; Sun, 07 Aug 2022 11:13:53 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id l18-20020a1709063d3200b006fee98045cdsm4115660ejf.10.2022.08.07.11.13.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 11:13:53 -0700 (PDT) Date: Sun, 7 Aug 2022 20:13:51 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] staging: vt6655: Convert macro MACvEnableBarkerPreambleMd Message-ID: <542b9f8c0b10aa3db143b22f7425ab5bddc5bffe.1659892671.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert macro MACvEnableBarkerPreambleMd to static function which calls the common static function vt6655_mac_set_bits. This saves codelines and multiline macros are not liked by kernel community. Function name is also changed to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Signed-off-by: Philipp Hortmann --- V1 -> V2: Changed used function to vt6655_mac_set_bits --- drivers/staging/vt6655/device_main.c | 6 +++++- drivers/staging/vt6655/mac.h | 8 -------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index 96945fb8d536..46bd88ee4668 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -244,6 +244,10 @@ static void vt6655_mac_dis_protect_md(void __iomem *io= base) vt6655_mac_clear_bits(iobase, ENCFG_PROTECTMD); } =20 +static void vt6655_mac_en_barker_preamble_md(void __iomem *iobase) +{ + vt6655_mac_set_bits(iobase, ENCFG_BARKERPREAM); +} /* * Initialisation of MAC & BBP registers */ @@ -1479,7 +1483,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw = *hw, =20 if (changed & BSS_CHANGED_ERP_PREAMBLE) { if (conf->use_short_preamble) { - MACvEnableBarkerPreambleMd(priv->port_offset); + vt6655_mac_en_barker_preamble_md(priv->port_offset); priv->preamble_type =3D true; } else { MACvDisableBarkerPreambleMd(priv->port_offset); diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h index a7d6254fded0..3400ea15b673 100644 --- a/drivers/staging/vt6655/mac.h +++ b/drivers/staging/vt6655/mac.h @@ -543,14 +543,6 @@ #define MACvSelectPage1(iobase) \ iowrite8(1, iobase + MAC_REG_PAGE1SEL) =20 -#define MACvEnableBarkerPreambleMd(iobase) \ -do { \ - unsigned long dwOrgValue; \ - dwOrgValue =3D ioread32(iobase + MAC_REG_ENCFG); \ - dwOrgValue =3D dwOrgValue | ENCFG_BARKERPREAM; \ - iowrite32((u32)dwOrgValue, iobase + MAC_REG_ENCFG); \ -} while (0) - #define MACvDisableBarkerPreambleMd(iobase) \ do { \ unsigned long dwOrgValue; \ --=20 2.37.1 From nobody Sat Apr 11 19:47:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02C43C25B0C for ; Sun, 7 Aug 2022 18:14:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235358AbiHGSOX (ORCPT ); Sun, 7 Aug 2022 14:14:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233898AbiHGSOD (ORCPT ); Sun, 7 Aug 2022 14:14:03 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A35695A4 for ; Sun, 7 Aug 2022 11:13:59 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id z22so8937994edd.6 for ; Sun, 07 Aug 2022 11:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc; bh=vMHi6yjR8K+qFLdzbL1qS1VwBovHqrZTSu9kJ2npcA4=; b=LCyoBZP90E+9ObSdPhnohQL4+qRXAFcyx+5ucHnVgxvNxlRzJttmiInnAJCeFhMWrJ sAYDRPSn3P0y9EUsmvtvr7wswB7/eYYRjCq1kA+Mr3+8jXCiInLmF1wLJeVszjr3Arxz eq485gWizpqmAe7WAtdCcC37bmKt8inIBhNGkzbY171RDvFcQtpO5M78HwSi5Fj+8DQb ne4xgm3zpZp7+4lj0WsNnlqw6nkRyzQJv2kg36+id7wzEWS8ntjddcHlCfOh8KSYBjVK 12jwZZc7Au0IjJtn5a/2WxNxL6U8q7BDgn5iKSsox1VYkk2DIEhz7xwGjQ7+QQD4VgdJ LJwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc; bh=vMHi6yjR8K+qFLdzbL1qS1VwBovHqrZTSu9kJ2npcA4=; b=CxgZKje/o6yhUwN5+ZHMOS8NGPLMuDuEt1hBDI5diAiZ/9e0JmG46pBjP/yJOSRCU5 r5PVxRRjlscz8bH4vOMPEitOpmY3mYbrDlRvxF4L8rpZ7QNP2iv9i+1VJX8MDCwY2/MB N8RsrQIl2xDqRpULC/w/f800BT4iN7QefRgFE6tKiKdvqYuhL5hc5NbkYDUpn738IYUe mkoOBIYgl1s0BplMzSqS7lbZwh6xZWhC3zhPu0RyouFLGiCPB/G+Z39gRHxFNObGTbGa nghfoHrUYUNviMdlw6YPigIC8MZiZOdkL2uGy0FhWGWeydP8ENaAW0wLDI/CyI+iLCJ+ oIPQ== X-Gm-Message-State: ACgBeo0uqPsJb6W1k0HOvSZwMUVaffj+Z6b8zOQvNPS12eF8QEK9XNCv SQIukNoXzlpo8AxahN24+8E= X-Google-Smtp-Source: AA6agR46EgO+2eepxhX3z5DGowcKmMPWYCnnyQzdj/zHuozdCf99GIjeXiJAFxyLWE8nAVbyDj/uWg== X-Received: by 2002:a05:6402:348f:b0:43d:e568:97bd with SMTP id v15-20020a056402348f00b0043de56897bdmr14845164edc.279.1659896037459; Sun, 07 Aug 2022 11:13:57 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id qk27-20020a170906d9db00b006ff0b457cdasm4053477ejb.53.2022.08.07.11.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 11:13:57 -0700 (PDT) Date: Sun, 7 Aug 2022 20:13:55 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] staging: vt6655: Convert macro MACvDisableBarkerPreambleMd Message-ID: <2a1d67762d9ecf3f30f3e293ad6ab997ad278b84.1659892671.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert macro MACvDisableBarkerPreambleMd to static function which calls the common static function vt6655_mac_clear_bits. This saves codelines and multiline macros are not liked by kernel community. Function name is also changed to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Signed-off-by: Philipp Hortmann --- V1 -> V2: Changed used function to vt6655_mac_clear_bits --- drivers/staging/vt6655/device_main.c | 8 +++++++- drivers/staging/vt6655/mac.h | 8 -------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index 46bd88ee4668..8e2a976aaaad 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -248,6 +248,12 @@ static void vt6655_mac_en_barker_preamble_md(void __io= mem *iobase) { vt6655_mac_set_bits(iobase, ENCFG_BARKERPREAM); } + +static void vt6655_mac_dis_barker_preamble_md(void __iomem *iobase) +{ + vt6655_mac_clear_bits(iobase, ENCFG_BARKERPREAM); +} + /* * Initialisation of MAC & BBP registers */ @@ -1486,7 +1492,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw = *hw, vt6655_mac_en_barker_preamble_md(priv->port_offset); priv->preamble_type =3D true; } else { - MACvDisableBarkerPreambleMd(priv->port_offset); + vt6655_mac_dis_barker_preamble_md(priv->port_offset); priv->preamble_type =3D false; } } diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h index 3400ea15b673..a75cd318ee25 100644 --- a/drivers/staging/vt6655/mac.h +++ b/drivers/staging/vt6655/mac.h @@ -543,14 +543,6 @@ #define MACvSelectPage1(iobase) \ iowrite8(1, iobase + MAC_REG_PAGE1SEL) =20 -#define MACvDisableBarkerPreambleMd(iobase) \ -do { \ - unsigned long dwOrgValue; \ - dwOrgValue =3D ioread32(iobase + MAC_REG_ENCFG); \ - dwOrgValue =3D dwOrgValue & ~ENCFG_BARKERPREAM; \ - iowrite32((u32)dwOrgValue, iobase + MAC_REG_ENCFG); \ -} while (0) - #define MACvSetBBType(iobase, byTyp) \ do { \ unsigned long dwOrgValue; \ --=20 2.37.1