From nobody Fri Apr 17 22:28:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC9BC433EF for ; Thu, 21 Jul 2022 18:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230267AbiGUSBw (ORCPT ); Thu, 21 Jul 2022 14:01:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232142AbiGUSBk (ORCPT ); Thu, 21 Jul 2022 14:01:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D92A48B4B2 for ; Thu, 21 Jul 2022 11:01:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48D21B8261F for ; Thu, 21 Jul 2022 18:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 977E1C341C0; Thu, 21 Jul 2022 18:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658426495; bh=2X7EC2fEKDDFX9102vFFdzD+y+hPXyUc3ajPWGZzqEw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aY9uxJy7cF9+x2tJCU/mnh0SX/gtaYfhZ220LHGFM//Ccz1nZLz/g81ECAjQBq237 rYmViIPkpRlAGX0sBHvSkrgWqqjtUHoZ010bnxPCwbVrtQ81Zf+ON6OLDaSsZqWv+l sogwpcIbH5DH95ePWEJST/+dTGEEwKqtDYgqDEKxwEZpXAht0t2h25m1/sD/3geZNV J0LUnHUZRNdKxzo7CeOLsz47YfOj/PbyJLw4ppuatdj8TK9SvY83mVYXY4ILWK/f3S xGsFqCTzw2cQCvFmqGYx0nL8aIhEu11Ma8RlvGd55bMXAFXsNkcKpbWoNxhiJYLZuu jtvB7D8/EohGw== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , John Garry Subject: [PATCH 1/2] scripts/faddr2line: Fix vmlinux detection on arm64 Date: Thu, 21 Jul 2022 11:01:23 -0700 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since commit dcea997beed6 ("faddr2line: Fix overlapping text section failures, the sequel"), faddr2line is completely broken on arm64. For some reason, on arm64, the vmlinux ELF object file type is ET_DYN rather than ET_EXEC. Check for both when determining whether the object is vmlinux. Modules and vmlinux.o have type ET_REL on all arches. Fixes: dcea997beed6 ("faddr2line: Fix overlapping text section failures, th= e sequel") Reported-by: John Garry Tested-by: John Garry Signed-off-by: Josh Poimboeuf --- scripts/faddr2line | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/faddr2line b/scripts/faddr2line index 94ed98dd899f..57099687e5e1 100755 --- a/scripts/faddr2line +++ b/scripts/faddr2line @@ -112,7 +112,9 @@ __faddr2line() { # section offsets. local file_type=3D$(${READELF} --file-header $objfile | ${AWK} '$1 =3D=3D "Type:" { print $2; exit }') - [[ $file_type =3D "EXEC" ]] && is_vmlinux=3D1 + if [[ $file_type =3D "EXEC" ]] || [[ $file_type =3D=3D "DYN" ]]; then + is_vmlinux=3D1 + fi =20 # Go through each of the object's symbols which match the func name. # In rare cases there might be duplicates, in which case we print all --=20 2.36.1 From nobody Fri Apr 17 22:28:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73DDC43334 for ; Thu, 21 Jul 2022 18:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232210AbiGUSBn (ORCPT ); Thu, 21 Jul 2022 14:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbiGUSBk (ORCPT ); Thu, 21 Jul 2022 14:01:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A4608B4B4 for ; Thu, 21 Jul 2022 11:01:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91ECAB82622 for ; Thu, 21 Jul 2022 18:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA955C341CF; Thu, 21 Jul 2022 18:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658426496; bh=HeHAa1GYP+Ezlk0vFf4+XDc2BHmt8PbK4OsvrkAKxhI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oimh8exnFPGmXgG3prFkrvRQNqLzLwTrgsk08nN848l6xRggsmSi0L1eGDWxKKnip ndp/oLTE2eSi2YsZShgE4GJ3Upk3KiSbc8ZB1b0+3j1W1YEqhvEgVc2ntQ1t8vnFwe ykbkWTllt76UGR9qlEFiaOdyhqXNbLyIlmFdzINHTxWZuHIH1PLF+66wmBLDjWvEJH 7vzIXzPGolGKMnWWgYKaNfl1154eT+ePaSFGoPqK4T+DusAKjei2o6JWdM/3MVQxn/ +z2EI0Vk43Yz2eyBYGJaDld30wpepjxsjzuEGk+0AAqi6Ha4mUMAYt0XjTW/9zNDE5 eaMUD54b5gVqg== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , John Garry Subject: [PATCH 2/2] scripts/faddr2line: Add CONFIG_DEBUG_INFO check Date: Thu, 21 Jul 2022 11:01:24 -0700 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Otherwise without DWARF it spits out gibberish and gives no indication of what the problem is. Suggested-by: John Garry Signed-off-by: Josh Poimboeuf Tested-by: John Garry --- scripts/faddr2line | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/faddr2line b/scripts/faddr2line index 57099687e5e1..5514c23f45c2 100755 --- a/scripts/faddr2line +++ b/scripts/faddr2line @@ -61,6 +61,7 @@ die() { READELF=3D"${CROSS_COMPILE:-}readelf" ADDR2LINE=3D"${CROSS_COMPILE:-}addr2line" AWK=3D"awk" +GREP=3D"grep" =20 command -v ${AWK} >/dev/null 2>&1 || die "${AWK} isn't installed" command -v ${READELF} >/dev/null 2>&1 || die "${READELF} isn't installed" @@ -271,6 +272,8 @@ LIST=3D0 [[ ! -f $objfile ]] && die "can't find objfile $objfile" shift =20 +${READELF} --section-headers --wide $objfile | ${GREP} -q '\.debug_info' |= | die "CONFIG_DEBUG_INFO not enabled" + DIR_PREFIX=3Dsupercalifragilisticexpialidocious find_dir_prefix $objfile =20 --=20 2.36.1